{"action":"closed","number":1757,"pull_request":{"url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757","id":226404977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDA0OTc3","html_url":"https://github.com/FreeCAD/FreeCAD/pull/1757","diff_url":"https://github.com/FreeCAD/FreeCAD/pull/1757.diff","patch_url":"https://github.com/FreeCAD/FreeCAD/pull/1757.patch","issue_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1757","number":1757,"state":"closed","locked":false,"title":"Fix spurious error message in PD::Groove","user":{"login":"WandererFan","id":3587161,"node_id":"MDQ6VXNlcjM1ODcxNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3587161?v=4","gravatar_id":"","url":"https://api.github.com/users/WandererFan","html_url":"https://github.com/WandererFan","followers_url":"https://api.github.com/users/WandererFan/followers","following_url":"https://api.github.com/users/WandererFan/following{/other_user}","gists_url":"https://api.github.com/users/WandererFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WandererFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WandererFan/subscriptions","organizations_url":"https://api.github.com/users/WandererFan/orgs","repos_url":"https://api.github.com/users/WandererFan/repos","events_url":"https://api.github.com/users/WandererFan/events{/privacy}","received_events_url":"https://api.github.com/users/WandererFan/received_events","type":"User","site_admin":false},"body":"THis PR fixes an error in PartDesign::FeatureGroove where a multi-solid error message was reported for a single solid result.   Please merge.\r\nThanks,\r\nwf\r\n\r\n-  in FeatureGroove, the check for multiple\r\n   solids in result was checking the wrong\r\n   variable.\r\n\r\nThank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:\r\n\r\n- [ ] Branch rebased on latest master `git pull --rebase upstream master`\r\n- [ ] Unit tests confirmed to pass by running `./bin/FreeCAD --run-test 0`\r\n- [ ] Commit message is [well-written](https://chris.beams.io/posts/git-commit/)\r\n- [ ] Commit message includes `issue #<id>` or `fixes #<id>` where `<id>` is the [associated MantisBT](https://freecadweb.org/wiki/tracker#GitHub_and_MantisBT) issue id if one exists\r\n\r\nAnd please remember to update the Wiki with the features added or changed once this PR is merged.\r\n\r\n---\r\n","created_at":"2018-10-28T23:10:49Z","updated_at":"2018-10-29T13:29:24Z","closed_at":"2018-10-29T13:29:24Z","merged_at":"2018-10-29T13:29:24Z","merge_commit_sha":"2b84be64cc764e2de5aac02f53e99b289c8ffc95","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757/commits","review_comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757/comments","review_comment_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1757/comments","statuses_url":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/30c949bc0bc6a49d839046dbf18cbb7e427d8a53","head":{"label":"WandererFan:grooveFix","ref":"grooveFix","sha":"30c949bc0bc6a49d839046dbf18cbb7e427d8a53","user":{"login":"WandererFan","id":3587161,"node_id":"MDQ6VXNlcjM1ODcxNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3587161?v=4","gravatar_id":"","url":"https://api.github.com/users/WandererFan","html_url":"https://github.com/WandererFan","followers_url":"https://api.github.com/users/WandererFan/followers","following_url":"https://api.github.com/users/WandererFan/following{/other_user}","gists_url":"https://api.github.com/users/WandererFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WandererFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WandererFan/subscriptions","organizations_url":"https://api.github.com/users/WandererFan/orgs","repos_url":"https://api.github.com/users/WandererFan/repos","events_url":"https://api.github.com/users/WandererFan/events{/privacy}","received_events_url":"https://api.github.com/users/WandererFan/received_events","type":"User","site_admin":false},"repo":{"id":62413019,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQxMzAxOQ==","name":"FreeCAD","full_name":"WandererFan/FreeCAD","private":false,"owner":{"login":"WandererFan","id":3587161,"node_id":"MDQ6VXNlcjM1ODcxNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3587161?v=4","gravatar_id":"","url":"https://api.github.com/users/WandererFan","html_url":"https://github.com/WandererFan","followers_url":"https://api.github.com/users/WandererFan/followers","following_url":"https://api.github.com/users/WandererFan/following{/other_user}","gists_url":"https://api.github.com/users/WandererFan/gists{/gist_id}","starred_url":"https://api.github.com/users/WandererFan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WandererFan/subscriptions","organizations_url":"https://api.github.com/users/WandererFan/orgs","repos_url":"https://api.github.com/users/WandererFan/repos","events_url":"https://api.github.com/users/WandererFan/events{/privacy}","received_events_url":"https://api.github.com/users/WandererFan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WandererFan/FreeCAD","description":"This is my fork of FreeCAD. ","fork":true,"url":"https://api.github.com/repos/WandererFan/FreeCAD","forks_url":"https://api.github.com/repos/WandererFan/FreeCAD/forks","keys_url":"https://api.github.com/repos/WandererFan/FreeCAD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WandererFan/FreeCAD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WandererFan/FreeCAD/teams","hooks_url":"https://api.github.com/repos/WandererFan/FreeCAD/hooks","issue_events_url":"https://api.github.com/repos/WandererFan/FreeCAD/issues/events{/number}","events_url":"https://api.github.com/repos/WandererFan/FreeCAD/events","assignees_url":"https://api.github.com/repos/WandererFan/FreeCAD/assignees{/user}","branches_url":"https://api.github.com/repos/WandererFan/FreeCAD/branches{/branch}","tags_url":"https://api.github.com/repos/WandererFan/FreeCAD/tags","blobs_url":"https://api.github.com/repos/WandererFan/FreeCAD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WandererFan/FreeCAD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WandererFan/FreeCAD/git/refs{/sha}","trees_url":"https://api.github.com/repos/WandererFan/FreeCAD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WandererFan/FreeCAD/statuses/{sha}","languages_url":"https://api.github.com/repos/WandererFan/FreeCAD/languages","stargazers_url":"https://api.github.com/repos/WandererFan/FreeCAD/stargazers","contributors_url":"https://api.github.com/repos/WandererFan/FreeCAD/contributors","subscribers_url":"https://api.github.com/repos/WandererFan/FreeCAD/subscribers","subscription_url":"https://api.github.com/repos/WandererFan/FreeCAD/subscription","commits_url":"https://api.github.com/repos/WandererFan/FreeCAD/commits{/sha}","git_commits_url":"https://api.github.com/repos/WandererFan/FreeCAD/git/commits{/sha}","comments_url":"https://api.github.com/repos/WandererFan/FreeCAD/comments{/number}","issue_comment_url":"https://api.github.com/repos/WandererFan/FreeCAD/issues/comments{/number}","contents_url":"https://api.github.com/repos/WandererFan/FreeCAD/contents/{+path}","compare_url":"https://api.github.com/repos/WandererFan/FreeCAD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WandererFan/FreeCAD/merges","archive_url":"https://api.github.com/repos/WandererFan/FreeCAD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WandererFan/FreeCAD/downloads","issues_url":"https://api.github.com/repos/WandererFan/FreeCAD/issues{/number}","pulls_url":"https://api.github.com/repos/WandererFan/FreeCAD/pulls{/number}","milestones_url":"https://api.github.com/repos/WandererFan/FreeCAD/milestones{/number}","notifications_url":"https://api.github.com/repos/WandererFan/FreeCAD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WandererFan/FreeCAD/labels{/name}","releases_url":"https://api.github.com/repos/WandererFan/FreeCAD/releases{/id}","deployments_url":"https://api.github.com/repos/WandererFan/FreeCAD/deployments","created_at":"2016-07-01T18:39:49Z","updated_at":"2016-10-23T21:44:04Z","pushed_at":"2018-10-28T23:16:53Z","git_url":"git://github.com/WandererFan/FreeCAD.git","ssh_url":"git@github.com:WandererFan/FreeCAD.git","clone_url":"https://github.com/WandererFan/FreeCAD.git","svn_url":"https://github.com/WandererFan/FreeCAD","homepage":"","size":638731,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeCAD:master","ref":"master","sha":"42c5b2e9ca437bb654a5fc2b26f52ca23f9983b5","user":{"login":"FreeCAD","id":2306237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDYyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2306237?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeCAD","html_url":"https://github.com/FreeCAD","followers_url":"https://api.github.com/users/FreeCAD/followers","following_url":"https://api.github.com/users/FreeCAD/following{/other_user}","gists_url":"https://api.github.com/users/FreeCAD/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCAD/subscriptions","organizations_url":"https://api.github.com/users/FreeCAD/orgs","repos_url":"https://api.github.com/users/FreeCAD/repos","events_url":"https://api.github.com/users/FreeCAD/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCAD/received_events","type":"Organization","site_admin":false},"repo":{"id":5736080,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM2MDgw","name":"FreeCAD","full_name":"FreeCAD/FreeCAD","private":false,"owner":{"login":"FreeCAD","id":2306237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDYyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2306237?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeCAD","html_url":"https://github.com/FreeCAD","followers_url":"https://api.github.com/users/FreeCAD/followers","following_url":"https://api.github.com/users/FreeCAD/following{/other_user}","gists_url":"https://api.github.com/users/FreeCAD/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCAD/subscriptions","organizations_url":"https://api.github.com/users/FreeCAD/orgs","repos_url":"https://api.github.com/users/FreeCAD/repos","events_url":"https://api.github.com/users/FreeCAD/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCAD/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FreeCAD/FreeCAD","description":"This is the official source code of FreeCAD, a free and opensource multiplatform 3D parametric modeler","fork":false,"url":"https://api.github.com/repos/FreeCAD/FreeCAD","forks_url":"https://api.github.com/repos/FreeCAD/FreeCAD/forks","keys_url":"https://api.github.com/repos/FreeCAD/FreeCAD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeCAD/FreeCAD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeCAD/FreeCAD/teams","hooks_url":"https://api.github.com/repos/FreeCAD/FreeCAD/hooks","issue_events_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/events{/number}","events_url":"https://api.github.com/repos/FreeCAD/FreeCAD/events","assignees_url":"https://api.github.com/repos/FreeCAD/FreeCAD/assignees{/user}","branches_url":"https://api.github.com/repos/FreeCAD/FreeCAD/branches{/branch}","tags_url":"https://api.github.com/repos/FreeCAD/FreeCAD/tags","blobs_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeCAD/FreeCAD/languages","stargazers_url":"https://api.github.com/repos/FreeCAD/FreeCAD/stargazers","contributors_url":"https://api.github.com/repos/FreeCAD/FreeCAD/contributors","subscribers_url":"https://api.github.com/repos/FreeCAD/FreeCAD/subscribers","subscription_url":"https://api.github.com/repos/FreeCAD/FreeCAD/subscription","commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeCAD/FreeCAD/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeCAD/FreeCAD/contents/{+path}","compare_url":"https://api.github.com/repos/FreeCAD/FreeCAD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeCAD/FreeCAD/merges","archive_url":"https://api.github.com/repos/FreeCAD/FreeCAD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeCAD/FreeCAD/downloads","issues_url":"https://api.github.com/repos/FreeCAD/FreeCAD/issues{/number}","pulls_url":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeCAD/FreeCAD/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeCAD/FreeCAD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeCAD/FreeCAD/labels{/name}","releases_url":"https://api.github.com/repos/FreeCAD/FreeCAD/releases{/id}","deployments_url":"https://api.github.com/repos/FreeCAD/FreeCAD/deployments","created_at":"2012-09-09T08:25:02Z","updated_at":"2018-10-29T13:29:03Z","pushed_at":"2018-10-29T13:29:24Z","git_url":"git://github.com/FreeCAD/FreeCAD.git","ssh_url":"git@github.com:FreeCAD/FreeCAD.git","clone_url":"https://github.com/FreeCAD/FreeCAD.git","svn_url":"https://github.com/FreeCAD/FreeCAD","homepage":"http://www.freecadweb.org","size":639938,"stargazers_count":2990,"watchers_count":2990,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1112,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1112,"open_issues":17,"watchers":2990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757"},"html":{"href":"https://github.com/FreeCAD/FreeCAD/pull/1757"},"issue":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1757"},"comments":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/issues/1757/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/pulls/1757/commits"},"statuses":{"href":"https://api.github.com/repos/FreeCAD/FreeCAD/statuses/30c949bc0bc6a49d839046dbf18cbb7e427d8a53"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yorikvanhavre","id":1136856,"node_id":"MDQ6VXNlcjExMzY4NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1136856?v=4","gravatar_id":"","url":"https://api.github.com/users/yorikvanhavre","html_url":"https://github.com/yorikvanhavre","followers_url":"https://api.github.com/users/yorikvanhavre/followers","following_url":"https://api.github.com/users/yorikvanhavre/following{/other_user}","gists_url":"https://api.github.com/users/yorikvanhavre/gists{/gist_id}","starred_url":"https://api.github.com/users/yorikvanhavre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorikvanhavre/subscriptions","organizations_url":"https://api.github.com/users/yorikvanhavre/orgs","repos_url":"https://api.github.com/users/yorikvanhavre/repos","events_url":"https://api.github.com/users/yorikvanhavre/events{/privacy}","received_events_url":"https://api.github.com/users/yorikvanhavre/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"yorikvanhavre"}}