{"action":"created","issue":{"url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/406","repository_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD","labels_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/406/labels{/name}","comments_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/406/comments","events_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/406/events","html_url":"https://github.com/MusicPlayerDaemon/MPD/pull/406","id":377150140,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTc1MTk2","number":406,"title":"doc/protocol.rst: update information about volume since -1 is not sent anymore","user":{"login":"nroi","id":14194284,"node_id":"MDQ6VXNlcjE0MTk0Mjg0","avatar_url":"https://avatars2.githubusercontent.com/u/14194284?v=4","gravatar_id":"","url":"https://api.github.com/users/nroi","html_url":"https://github.com/nroi","followers_url":"https://api.github.com/users/nroi/followers","following_url":"https://api.github.com/users/nroi/following{/other_user}","gists_url":"https://api.github.com/users/nroi/gists{/gist_id}","starred_url":"https://api.github.com/users/nroi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nroi/subscriptions","organizations_url":"https://api.github.com/users/nroi/orgs","repos_url":"https://api.github.com/users/nroi/repos","events_url":"https://api.github.com/users/nroi/events{/privacy}","received_events_url":"https://api.github.com/users/nroi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-04T12:57:03Z","updated_at":"2018-11-07T12:49:33Z","closed_at":"2018-11-07T12:49:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/pulls/406","html_url":"https://github.com/MusicPlayerDaemon/MPD/pull/406","diff_url":"https://github.com/MusicPlayerDaemon/MPD/pull/406.diff","patch_url":"https://github.com/MusicPlayerDaemon/MPD/pull/406.patch"},"body":"Since 9cc37bdea2a55ca022c92902f943443badb94bce, MPD's status command does not emit the value -1 for the volume if the player is stopped. Instead, volume information is completely absent from the response sent by MPD.\r\n\r\nAlso, two backticks were missing."},"comment":{"url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/comments/436612296","html_url":"https://github.com/MusicPlayerDaemon/MPD/pull/406#issuecomment-436612296","issue_url":"https://api.github.com/repos/MusicPlayerDaemon/MPD/issues/406","id":436612296,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjYxMjI5Ng==","user":{"login":"MaxKellermann","id":1443144,"node_id":"MDQ6VXNlcjE0NDMxNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1443144?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxKellermann","html_url":"https://github.com/MaxKellermann","followers_url":"https://api.github.com/users/MaxKellermann/followers","following_url":"https://api.github.com/users/MaxKellermann/following{/other_user}","gists_url":"https://api.github.com/users/MaxKellermann/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxKellermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxKellermann/subscriptions","organizations_url":"https://api.github.com/users/MaxKellermann/orgs","repos_url":"https://api.github.com/users/MaxKellermann/repos","events_url":"https://api.github.com/users/MaxKellermann/events{/privacy}","received_events_url":"https://api.github.com/users/MaxKellermann/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T12:49:33Z","updated_at":"2018-11-07T12:49:33Z","author_association":"MEMBER","body":"Your change removes something from the documentation which is deprecated, but keeping this rule in client code is a good idea even if it's deprecated, because it avoids breaking backwards compatibility. I'd agree to change the wording to mention that `-1` is deprecated, but not remove it completely from the document.\r\nYour argument is not wrong, it's just that I value backwards compatibility more than keeping documentation clean of deprecated things. This is my subjective choice, not the absolute truth.\r\nI've cherry-picked your first commit, but the second isn't a good improvement. Anyway thanks for far for caring about the documentation, we need more of that!"}}
{"actor":{"display_login":"MaxKellermann"}}