{"push_id":3135468371,"size":6,"distinct_size":6,"ref":"refs/heads/refactor-render-namespaces","head":"29ea544d11addbe85e20b5738caa2561ca78009d","before":"01622024a8d52eb09f4596ea5ab7a00e8516151b","commits":[{"sha":"54a2d0286e44cbecdb90f9758d4bfd9df3fe8f30","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool EP05] Add function fc4.io/binary-spit\n\nThis will be used by a function added/changed in the next commit.","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/54a2d0286e44cbecdb90f9758d4bfd9df3fe8f30"},{"sha":"ad9b4a86a65452ea0771e4e2e955e4c5c062e072","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool] Tiny refactor to a function in fc4.io\n\nPreparatory refactoring: I’ll need this predicate soon for EP05 (#111).\n\nAlso, I think this makes yaml-files easier to read and understand.","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/ad9b4a86a65452ea0771e4e2e955e4c5c062e072"},{"sha":"ee157ad279ab42774bd7957eaf72abefd8a94be9","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool EP05] Move fns from fc4.cli.render to fc4.io.render\n\nThis is preparatory refactoring because as per EP05 (#111) we’ll soon be\nadding a new `edit` CLI command that will be implemented in\n`fc4.cli.edit` and will also need to render YAML files. In other words,\nthe functionality that until now was only in fc4.cli.render will need to\nbe used by two different namespaces under fc4.cli, so we needed that\nfunctionality to be in a third namespace.\n\nI chose to move these functions out of the `cli` source tree and into\nthe `main` source tree because by convention we don’t have tests for\nthe code under `cli` but we do have tests for that under `main`. And\nsince this code will now be shared by more than one ns, and anyway\nsince it was fairly extensive, it should be tested.","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/ee157ad279ab42774bd7957eaf72abefd8a94be9"},{"sha":"398b745c25b451085330e1be1675624c388e40d3","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool EP05] Change how fc4.io.render handles errors\n\nInstead of calling fc4.cli.util/fail which generally calls System/exit\nit now just throws an exception and leaves it to the caller to decide\nwhat to do with it.\n\nThis preparatory refactoring for EP05 (#111) for which we’ll soon be\nadding an `edit` subcommand, and when a user has run that from the CLI\nand one or more files are being watched for changes, we don’t want to\nexit the JVM when there are errors — we just want to print them out and\nthen continue, keep watching for more changes and then try again.","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/398b745c25b451085330e1be1675624c388e40d3"},{"sha":"b384976836a66c3543432d67ff28930b50921cdb","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool EP05] Add tests for new fc4.io.render ns","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/b384976836a66c3543432d67ff28930b50921cdb"},{"sha":"29ea544d11addbe85e20b5738caa2561ca78009d","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool EP05] More tests for new fc4.io.render ns","distinct":true,"url":"https://api.github.com/repos/FundingCircle/fc4-framework/commits/29ea544d11addbe85e20b5738caa2561ca78009d"}]}
{"actor":{"display_login":"aviflax"}}