{"action":"created","issue":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/2418","repository_url":"https://api.github.com/repos/apache/activemq-artemis","labels_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2418/labels{/name}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2418/comments","events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2418/events","html_url":"https://github.com/apache/activemq-artemis/pull/2418","id":378042238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODQxNjIz","number":2418,"title":"ARTEMIS-2142 Fix ServerJMSMessage - Fix current broker integration tests in master","user":{"login":"michaelandrepearce","id":1387822,"node_id":"MDQ6VXNlcjEzODc4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-11-06T21:33:10Z","updated_at":"2018-11-09T15:13:55Z","closed_at":"2018-11-09T15:13:55Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2418","html_url":"https://github.com/apache/activemq-artemis/pull/2418","diff_url":"https://github.com/apache/activemq-artemis/pull/2418.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2418.patch"},"body":"Fix ServerJMSMessage so it correctly transposes JMSX headers.\r\nPush common JMS to Message Interface mappings into MessageUtil"},"comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments/437389380","html_url":"https://github.com/apache/activemq-artemis/pull/2418#issuecomment-437389380","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2418","id":437389380,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzM4OTM4MA==","user":{"login":"michaelandrepearce","id":1387822,"node_id":"MDQ6VXNlcjEzODc4MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1387822?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelandrepearce","html_url":"https://github.com/michaelandrepearce","followers_url":"https://api.github.com/users/michaelandrepearce/followers","following_url":"https://api.github.com/users/michaelandrepearce/following{/other_user}","gists_url":"https://api.github.com/users/michaelandrepearce/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelandrepearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelandrepearce/subscriptions","organizations_url":"https://api.github.com/users/michaelandrepearce/orgs","repos_url":"https://api.github.com/users/michaelandrepearce/repos","events_url":"https://api.github.com/users/michaelandrepearce/events{/privacy}","received_events_url":"https://api.github.com/users/michaelandrepearce/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T15:13:55Z","updated_at":"2018-11-09T15:13:55Z","author_association":"CONTRIBUTOR","body":"@gemmellr im closing this, ive split this into two now as you had suggested.\r\n\r\nFirst is the minimal changes needed to fix the immediate issue https://github.com/apache/activemq-artemis/pull/2424\r\n\r\nSecond is the refactor thats a more complete fixup around this area and cleaner (but larger change)  https://github.com/apache/activemq-artemis/pull/2425\r\n\r\nThis way the first PR can be cherry picked if needed to HF branches as you suggested.\r\n\r\nIm closing this one now, with the above to replace it."}}
{"actor":{"display_login":"michaelandrepearce"}}