{"action":"opened","issue":{"url":"https://api.github.com/repos/cilium/cilium/issues/6139","repository_url":"https://api.github.com/repos/cilium/cilium","labels_url":"https://api.github.com/repos/cilium/cilium/issues/6139/labels{/name}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6139/comments","events_url":"https://api.github.com/repos/cilium/cilium/issues/6139/events","html_url":"https://github.com/cilium/cilium/issues/6139","id":376547060,"node_id":"MDU6SXNzdWUzNzY1NDcwNjA=","number":6139,"title":"Adding clarification in Contributor Guide regarding running unit test","user":{"login":"ruigulala","id":10216005,"node_id":"MDQ6VXNlcjEwMjE2MDA1","avatar_url":"https://avatars2.githubusercontent.com/u/10216005?v=4","gravatar_id":"","url":"https://api.github.com/users/ruigulala","html_url":"https://github.com/ruigulala","followers_url":"https://api.github.com/users/ruigulala/followers","following_url":"https://api.github.com/users/ruigulala/following{/other_user}","gists_url":"https://api.github.com/users/ruigulala/gists{/gist_id}","starred_url":"https://api.github.com/users/ruigulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruigulala/subscriptions","organizations_url":"https://api.github.com/users/ruigulala/orgs","repos_url":"https://api.github.com/users/ruigulala/repos","events_url":"https://api.github.com/users/ruigulala/events{/privacy}","received_events_url":"https://api.github.com/users/ruigulala/received_events","type":"User","site_admin":false},"labels":[{"id":665378286,"node_id":"MDU6TGFiZWw2NjUzNzgyODY=","url":"https://api.github.com/repos/cilium/cilium/labels/area/documentation","name":"area/documentation","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-01T19:59:01Z","updated_at":"2018-11-01T19:59:01Z","closed_at":null,"author_association":"COLLABORATOR","body":"<!--\r\n\r\nIf you have usage questions, please try the [slack\r\nchannel](http://cilium.io/slack) and see the [FAQ](https://goo.gl/qG2YmU)\r\nfirst.\r\n\r\nChoose either \"Proposal\" or \"Bug report\"\r\n\r\n-->\r\n\r\n## Proposal / RFE\r\n\r\n**Is your feature request related to a problem?**\r\nWhen following the unit test part of the Contributor Guide, if people follow the command directly, they'll run into the following error. This is due to the kv-store test server hasn't been set up before running the test.\r\n```\r\nvagrant@k8s1:~/go/src/github.com/cilium/cilium/pkg/kvstore$ go test\r\nlevel=info msg=\"Waiting for consul to elect a leader\" subsys=kvstore\r\nlevel=info msg=\"Waiting for consul to elect a leader\" subsys=kvstore\r\nlevel=fatal msg=\"Unable to contact consul server\" error=\"Get http://127.0.0.1:8501/v1/status/leader: dial tcp 127.0.0.1:8501: connect: connection refused\" subsys=kvstore\r\nexit status 1\r\nFAIL\tgithub.com/cilium/cilium/pkg/kvstore\t1.442s\r\n```\r\n\r\n**Describe the solution you'd like**\r\nSome extra clarifications may be needed. For example, the following command can be suggested as a complement. Because the makefile target also handles removing the kv-store server container.\r\n```\r\nmake unit-tests TESTPKGS=github.com/cilium/cilium/pkg/kvstore\r\n```"}}
{"actor":{"display_login":"ruigulala"}}