{"action":"created","comment":{"url":"https://api.github.com/repos/sensu/sensu-go/pulls/comments/215386005","pull_request_review_id":152638849,"id":215386005,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM4NjAwNQ==","diff_hunk":"@@ -236,13 +236,18 @@ func (opts *checkOpts) administerQuestionnaire(editing bool) error {\n \t\t},\n \t\t{\n \t\t\tName: \"output-metric-format\",\n-\t\t\tPrompt: &survey.Input{\n+\t\t\tPrompt: &survey.Select{\n \t\t\t\tMessage: \"Metric Format:\",\n-\t\t\t\tHelp:    \"Optional output metric format used to parse check output for metric extraction. Valid formats include: nagios_perfdata, graphite_plaintext, opentsdb_line, and influxdb_line\",\n-\t\t\t\tDefault: opts.OutputMetricFormat,\n+\t\t\t\tOptions: []string{\n+\t\t\t\t\t\"nagios_perfdata\",","path":"cli/commands/check/interactive.go","position":10,"original_position":10,"commit_id":"85af3016591822a69a571254801d23c2f0d57ead","original_commit_id":"85af3016591822a69a571254801d23c2f0d57ead","user":{"login":"palourde","id":4105580,"node_id":"MDQ6VXNlcjQxMDU1ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/4105580?v=4","gravatar_id":"","url":"https://api.github.com/users/palourde","html_url":"https://github.com/palourde","followers_url":"https://api.github.com/users/palourde/followers","following_url":"https://api.github.com/users/palourde/following{/other_user}","gists_url":"https://api.github.com/users/palourde/gists{/gist_id}","starred_url":"https://api.github.com/users/palourde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palourde/subscriptions","organizations_url":"https://api.github.com/users/palourde/orgs","repos_url":"https://api.github.com/users/palourde/repos","events_url":"https://api.github.com/users/palourde/events{/privacy}","received_events_url":"https://api.github.com/users/palourde/received_events","type":"User","site_admin":false},"body":"We have some constants for these formats, see https://github.com/sensu/sensu-go/blob/6996d8ccb36ba9a9b6750da016ce3b5ea118bcfd/types/check.go#L40\r\n\r\n","created_at":"2018-09-05T18:49:19Z","updated_at":"2018-09-05T18:49:19Z","html_url":"https://github.com/sensu/sensu-go/pull/2030#discussion_r215386005","pull_request_url":"https://api.github.com/repos/sensu/sensu-go/pulls/2030","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/comments/215386005"},"html":{"href":"https://github.com/sensu/sensu-go/pull/2030#discussion_r215386005"},"pull_request":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/2030"}}},"pull_request":{"url":"https://api.github.com/repos/sensu/sensu-go/pulls/2030","id":213141496,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTQxNDk2","html_url":"https://github.com/sensu/sensu-go/pull/2030","diff_url":"https://github.com/sensu/sensu-go/pull/2030.diff","patch_url":"https://github.com/sensu/sensu-go/pull/2030.patch","issue_url":"https://api.github.com/repos/sensu/sensu-go/issues/2030","number":2030,"state":"open","locked":false,"title":"Fix a bug in sensuctl check update.","user":{"login":"echlebek","id":1633772,"node_id":"MDQ6VXNlcjE2MzM3NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1633772?v=4","gravatar_id":"","url":"https://api.github.com/users/echlebek","html_url":"https://github.com/echlebek","followers_url":"https://api.github.com/users/echlebek/followers","following_url":"https://api.github.com/users/echlebek/following{/other_user}","gists_url":"https://api.github.com/users/echlebek/gists{/gist_id}","starred_url":"https://api.github.com/users/echlebek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echlebek/subscriptions","organizations_url":"https://api.github.com/users/echlebek/orgs","repos_url":"https://api.github.com/users/echlebek/repos","events_url":"https://api.github.com/users/echlebek/events{/privacy}","received_events_url":"https://api.github.com/users/echlebek/received_events","type":"User","site_admin":false},"body":"## What is this change?\r\n\r\nThis commit fixes a bug in sensuctl check update where once a\r\nmetrics output format had been set, it could no longer be unset.\r\n\r\n## Why is this change necessary?\r\n\r\nCloses #2023\r\n\r\n## Does your change need a Changelog entry?\r\n\r\nYes\r\n\r\n## Do you need clarification on anything?\r\n\r\nNo\r\n\r\n## Were there any complications while making this change?\r\n\r\nIt seems likely that a slew of similar bugs exists in the interactive mode of sensuctl. We should discuss how to resolve this on a product-wide basis.","created_at":"2018-09-05T00:56:06Z","updated_at":"2018-09-05T18:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a87a579297a5451efe11d19d2a0e3c6b0591c1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mercul3s","id":2100610,"node_id":"MDQ6VXNlcjIxMDA2MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2100610?v=4","gravatar_id":"","url":"https://api.github.com/users/mercul3s","html_url":"https://github.com/mercul3s","followers_url":"https://api.github.com/users/mercul3s/followers","following_url":"https://api.github.com/users/mercul3s/following{/other_user}","gists_url":"https://api.github.com/users/mercul3s/gists{/gist_id}","starred_url":"https://api.github.com/users/mercul3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercul3s/subscriptions","organizations_url":"https://api.github.com/users/mercul3s/orgs","repos_url":"https://api.github.com/users/mercul3s/repos","events_url":"https://api.github.com/users/mercul3s/events{/privacy}","received_events_url":"https://api.github.com/users/mercul3s/received_events","type":"User","site_admin":false},{"login":"nikkiki","id":10634078,"node_id":"MDQ6VXNlcjEwNjM0MDc4","avatar_url":"https://avatars2.githubusercontent.com/u/10634078?v=4","gravatar_id":"","url":"https://api.github.com/users/nikkiki","html_url":"https://github.com/nikkiki","followers_url":"https://api.github.com/users/nikkiki/followers","following_url":"https://api.github.com/users/nikkiki/following{/other_user}","gists_url":"https://api.github.com/users/nikkiki/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkiki/subscriptions","organizations_url":"https://api.github.com/users/nikkiki/orgs","repos_url":"https://api.github.com/users/nikkiki/repos","events_url":"https://api.github.com/users/nikkiki/events{/privacy}","received_events_url":"https://api.github.com/users/nikkiki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":658326752,"node_id":"MDU6TGFiZWw2NTgzMjY3NTI=","url":"https://api.github.com/repos/sensu/sensu-go/labels/ready-for-review","name":"ready-for-review","color":"ff8800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sensu/sensu-go/pulls/2030/commits","review_comments_url":"https://api.github.com/repos/sensu/sensu-go/pulls/2030/comments","review_comment_url":"https://api.github.com/repos/sensu/sensu-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensu/sensu-go/issues/2030/comments","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/85af3016591822a69a571254801d23c2f0d57ead","head":{"label":"sensu:bugfix/sensuctl-check-update","ref":"bugfix/sensuctl-check-update","sha":"85af3016591822a69a571254801d23c2f0d57ead","user":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":82981995,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk4MTk5NQ==","name":"sensu-go","full_name":"sensu/sensu-go","owner":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-go","description":"Open source monitoring tool for ephemeral infrastructure & distributed applications.","fork":false,"url":"https://api.github.com/repos/sensu/sensu-go","forks_url":"https://api.github.com/repos/sensu/sensu-go/forks","keys_url":"https://api.github.com/repos/sensu/sensu-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-go/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-go/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-go/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-go/events","assignees_url":"https://api.github.com/repos/sensu/sensu-go/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-go/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-go/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-go/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-go/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-go/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-go/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-go/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-go/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-go/merges","archive_url":"https://api.github.com/repos/sensu/sensu-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-go/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-go/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-go/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-go/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-go/deployments","created_at":"2017-02-23T23:38:08Z","updated_at":"2018-09-04T18:53:29Z","pushed_at":"2018-09-05T16:20:18Z","git_url":"git://github.com/sensu/sensu-go.git","ssh_url":"git@github.com:sensu/sensu-go.git","clone_url":"https://github.com/sensu/sensu-go.git","svn_url":"https://github.com/sensu/sensu-go","homepage":"https://sensu.io","size":72987,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":233,"watchers":172,"default_branch":"master"}},"base":{"label":"sensu:master","ref":"master","sha":"cabf902304749827aea739f692f552e4668b28c9","user":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":82981995,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk4MTk5NQ==","name":"sensu-go","full_name":"sensu/sensu-go","owner":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-go","description":"Open source monitoring tool for ephemeral infrastructure & distributed applications.","fork":false,"url":"https://api.github.com/repos/sensu/sensu-go","forks_url":"https://api.github.com/repos/sensu/sensu-go/forks","keys_url":"https://api.github.com/repos/sensu/sensu-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-go/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-go/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-go/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-go/events","assignees_url":"https://api.github.com/repos/sensu/sensu-go/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-go/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-go/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-go/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-go/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-go/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-go/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-go/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-go/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-go/merges","archive_url":"https://api.github.com/repos/sensu/sensu-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-go/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-go/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-go/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-go/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-go/deployments","created_at":"2017-02-23T23:38:08Z","updated_at":"2018-09-04T18:53:29Z","pushed_at":"2018-09-05T16:20:18Z","git_url":"git://github.com/sensu/sensu-go.git","ssh_url":"git@github.com:sensu/sensu-go.git","clone_url":"https://github.com/sensu/sensu-go.git","svn_url":"https://github.com/sensu/sensu-go","homepage":"https://sensu.io","size":72987,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":233,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/2030"},"html":{"href":"https://github.com/sensu/sensu-go/pull/2030"},"issue":{"href":"https://api.github.com/repos/sensu/sensu-go/issues/2030"},"comments":{"href":"https://api.github.com/repos/sensu/sensu-go/issues/2030/comments"},"review_comments":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/2030/comments"},"review_comment":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensu/sensu-go/pulls/2030/commits"},"statuses":{"href":"https://api.github.com/repos/sensu/sensu-go/statuses/85af3016591822a69a571254801d23c2f0d57ead"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"palourde"}}