{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/eth-account/pulls/comments/190359271","pull_request_review_id":122718152,"id":190359271,"diff_hunk":"@@ -59,3 +59,9 @@ def signTransaction(self, transaction_dict):\n \n     def __bytes__(self):\n         return self.privateKey\n+\n+    def __hash__(self):\n+        return hash(self.privateKey)","path":"eth_account/local.py","position":6,"original_position":6,"commit_id":"5445b69d622e091158fac8eeda5c614d5a9e1ef6","original_commit_id":"5445b69d622e091158fac8eeda5c614d5a9e1ef6","user":{"login":"carver","id":205327,"avatar_url":"https://avatars0.githubusercontent.com/u/205327?v=4","gravatar_id":"","url":"https://api.github.com/users/carver","html_url":"https://github.com/carver","followers_url":"https://api.github.com/users/carver/followers","following_url":"https://api.github.com/users/carver/following{/other_user}","gists_url":"https://api.github.com/users/carver/gists{/gist_id}","starred_url":"https://api.github.com/users/carver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carver/subscriptions","organizations_url":"https://api.github.com/users/carver/orgs","repos_url":"https://api.github.com/users/carver/repos","events_url":"https://api.github.com/users/carver/events{/privacy}","received_events_url":"https://api.github.com/users/carver/received_events","type":"User","site_admin":false},"body":"Implementing `__hash__` implies that the object is immutable, so we need to make it harder to accidentally change the private key.\r\n\r\nThat could look something like: moving `privateKey` to `_privateKey`, and adding a `@property` for `privateKey`.\r\n\r\nOr, if you don't feel like doing that, you can remove the `__hash__` implementation.","created_at":"2018-05-23T18:45:19Z","updated_at":"2018-05-23T18:49:55Z","html_url":"https://github.com/ethereum/eth-account/pull/23#discussion_r190359271","pull_request_url":"https://api.github.com/repos/ethereum/eth-account/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/comments/190359271"},"html":{"href":"https://github.com/ethereum/eth-account/pull/23#discussion_r190359271"},"pull_request":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/eth-account/pulls/23","id":189860838,"html_url":"https://github.com/ethereum/eth-account/pull/23","diff_url":"https://github.com/ethereum/eth-account/pull/23.diff","patch_url":"https://github.com/ethereum/eth-account/pull/23.patch","issue_url":"https://api.github.com/repos/ethereum/eth-account/issues/23","number":23,"state":"open","locked":false,"title":"[WIP] Implement __eq__ and __hash__ for LocalAccount","user":{"login":"stefanmendoza","id":6325996,"avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"body":"## What was wrong?\r\n\r\nFixes #21 \r\n\r\n## How was it fixed?\r\n\r\nImplemented `__eq__` and `__hash__` for `LocalAccount` + new tests.\r\n\r\n-- This is a work in progress --\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses](https://user-images.githubusercontent.com/6325996/40405130-e2d170ae-5e20-11e8-8b21-b6699550725f.jpg)\r\n","created_at":"2018-05-23T05:33:45Z","updated_at":"2018-05-23T18:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1980cbc51a5462bc45f5608f0ff2c62159360e68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/eth-account/pulls/23/commits","review_comments_url":"https://api.github.com/repos/ethereum/eth-account/pulls/23/comments","review_comment_url":"https://api.github.com/repos/ethereum/eth-account/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/eth-account/issues/23/comments","statuses_url":"https://api.github.com/repos/ethereum/eth-account/statuses/5445b69d622e091158fac8eeda5c614d5a9e1ef6","head":{"label":"stefanmendoza:issue-21","ref":"issue-21","sha":"5445b69d622e091158fac8eeda5c614d5a9e1ef6","user":{"login":"stefanmendoza","id":6325996,"avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"repo":{"id":134509596,"name":"eth-account","full_name":"stefanmendoza/eth-account","owner":{"login":"stefanmendoza","id":6325996,"avatar_url":"https://avatars2.githubusercontent.com/u/6325996?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanmendoza","html_url":"https://github.com/stefanmendoza","followers_url":"https://api.github.com/users/stefanmendoza/followers","following_url":"https://api.github.com/users/stefanmendoza/following{/other_user}","gists_url":"https://api.github.com/users/stefanmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanmendoza/subscriptions","organizations_url":"https://api.github.com/users/stefanmendoza/orgs","repos_url":"https://api.github.com/users/stefanmendoza/repos","events_url":"https://api.github.com/users/stefanmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/stefanmendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanmendoza/eth-account","description":"STUB","fork":true,"url":"https://api.github.com/repos/stefanmendoza/eth-account","forks_url":"https://api.github.com/repos/stefanmendoza/eth-account/forks","keys_url":"https://api.github.com/repos/stefanmendoza/eth-account/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanmendoza/eth-account/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanmendoza/eth-account/teams","hooks_url":"https://api.github.com/repos/stefanmendoza/eth-account/hooks","issue_events_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues/events{/number}","events_url":"https://api.github.com/repos/stefanmendoza/eth-account/events","assignees_url":"https://api.github.com/repos/stefanmendoza/eth-account/assignees{/user}","branches_url":"https://api.github.com/repos/stefanmendoza/eth-account/branches{/branch}","tags_url":"https://api.github.com/repos/stefanmendoza/eth-account/tags","blobs_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanmendoza/eth-account/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanmendoza/eth-account/languages","stargazers_url":"https://api.github.com/repos/stefanmendoza/eth-account/stargazers","contributors_url":"https://api.github.com/repos/stefanmendoza/eth-account/contributors","subscribers_url":"https://api.github.com/repos/stefanmendoza/eth-account/subscribers","subscription_url":"https://api.github.com/repos/stefanmendoza/eth-account/subscription","commits_url":"https://api.github.com/repos/stefanmendoza/eth-account/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanmendoza/eth-account/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanmendoza/eth-account/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanmendoza/eth-account/contents/{+path}","compare_url":"https://api.github.com/repos/stefanmendoza/eth-account/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanmendoza/eth-account/merges","archive_url":"https://api.github.com/repos/stefanmendoza/eth-account/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanmendoza/eth-account/downloads","issues_url":"https://api.github.com/repos/stefanmendoza/eth-account/issues{/number}","pulls_url":"https://api.github.com/repos/stefanmendoza/eth-account/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanmendoza/eth-account/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanmendoza/eth-account/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanmendoza/eth-account/labels{/name}","releases_url":"https://api.github.com/repos/stefanmendoza/eth-account/releases{/id}","deployments_url":"https://api.github.com/repos/stefanmendoza/eth-account/deployments","created_at":"2018-05-23T03:40:47Z","updated_at":"2018-05-23T03:40:49Z","pushed_at":"2018-05-23T05:41:24Z","git_url":"git://github.com/stefanmendoza/eth-account.git","ssh_url":"git@github.com:stefanmendoza/eth-account.git","clone_url":"https://github.com/stefanmendoza/eth-account.git","svn_url":"https://github.com/stefanmendoza/eth-account","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"c9c4a9039aa5693912a0e7c6e308e2801e1ba880","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":118818588,"name":"eth-account","full_name":"ethereum/eth-account","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/eth-account","description":"STUB","fork":false,"url":"https://api.github.com/repos/ethereum/eth-account","forks_url":"https://api.github.com/repos/ethereum/eth-account/forks","keys_url":"https://api.github.com/repos/ethereum/eth-account/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/eth-account/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/eth-account/teams","hooks_url":"https://api.github.com/repos/ethereum/eth-account/hooks","issue_events_url":"https://api.github.com/repos/ethereum/eth-account/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/eth-account/events","assignees_url":"https://api.github.com/repos/ethereum/eth-account/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/eth-account/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/eth-account/tags","blobs_url":"https://api.github.com/repos/ethereum/eth-account/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/eth-account/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/eth-account/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/eth-account/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/eth-account/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/eth-account/languages","stargazers_url":"https://api.github.com/repos/ethereum/eth-account/stargazers","contributors_url":"https://api.github.com/repos/ethereum/eth-account/contributors","subscribers_url":"https://api.github.com/repos/ethereum/eth-account/subscribers","subscription_url":"https://api.github.com/repos/ethereum/eth-account/subscription","commits_url":"https://api.github.com/repos/ethereum/eth-account/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/eth-account/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/eth-account/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/eth-account/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/eth-account/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/eth-account/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/eth-account/merges","archive_url":"https://api.github.com/repos/ethereum/eth-account/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/eth-account/downloads","issues_url":"https://api.github.com/repos/ethereum/eth-account/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/eth-account/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/eth-account/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/eth-account/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/eth-account/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/eth-account/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/eth-account/deployments","created_at":"2018-01-24T20:32:30Z","updated_at":"2018-05-23T03:36:03Z","pushed_at":"2018-05-23T05:41:25Z","git_url":"git://github.com/ethereum/eth-account.git","ssh_url":"git@github.com:ethereum/eth-account.git","clone_url":"https://github.com/ethereum/eth-account.git","svn_url":"https://github.com/ethereum/eth-account","homepage":null,"size":87,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/23"},"html":{"href":"https://github.com/ethereum/eth-account/pull/23"},"issue":{"href":"https://api.github.com/repos/ethereum/eth-account/issues/23"},"comments":{"href":"https://api.github.com/repos/ethereum/eth-account/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/eth-account/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/eth-account/statuses/5445b69d622e091158fac8eeda5c614d5a9e1ef6"}},"author_association":"NONE"}}
{"actor":{"display_login":"carver"}}