{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/237145850","pull_request_review_id":179372889,"id":237145850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE0NTg1MA==","diff_hunk":"@@ -1662,7 +1662,17 @@ Variant::operator Transform() const {\n \t\treturn Transform(*_data._basis, Vector3());\n \telse if (type == QUAT)\n \t\treturn Transform(Basis(*reinterpret_cast<const Quat *>(_data._mem)), Vector3());\n-\telse\n+\telse if (type == TRANSFORM2D) {\n+\t\tconst Transform2D &t = *_data._transform2d;\n+\t\tTransform m;\n+\t\tm.basis.elements[0][0] = t.elements[0][0];\n+\t\tm.basis.elements[1][0] = t.elements[1][0];","path":"core/variant.cpp","position":9,"original_position":9,"commit_id":"d22bc7413c083b11e9ee0ae8532e5aadd8aa0375","original_commit_id":"d22bc7413c083b11e9ee0ae8532e5aadd8aa0375","user":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"body":"Right, I saw that before implementing this and then messed up the actual implementation. Ill submit a new PR. ","created_at":"2018-11-28T15:56:19Z","updated_at":"2018-11-28T15:56:20Z","html_url":"https://github.com/godotengine/godot/pull/23976#discussion_r237145850","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/23976","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/237145850"},"html":{"href":"https://github.com/godotengine/godot/pull/23976#discussion_r237145850"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/23976"}},"in_reply_to_id":237099884},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/23976","id":233439485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDM5NDg1","html_url":"https://github.com/godotengine/godot/pull/23976","diff_url":"https://github.com/godotengine/godot/pull/23976.diff","patch_url":"https://github.com/godotengine/godot/pull/23976.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/23976","number":23976,"state":"closed","locked":false,"title":"Construct Transform from Transform2D ","user":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"body":"According to the [docs](http://docs.godotengine.org/en/latest/classes/class_transform.html#class-transform) for Transform, you are supposed to be able to construct a Transform using a Transform2D. However, I noticed that when you do so, all you get is an identity transform. \r\n\r\nThis was also creating a serious bug when using as a shader uniform. I'm not sure why, becuase Transform2Ds should be passed in as uniforms no problem, but for some reason they are getting converted to Transforms before being passed into the shader, as a result, if you tried to pass a Transform2D into a shader all you would get is an identity matrix in the shader. Because of the nature of shaders, this bug was *very* difficult to diagnose.","created_at":"2018-11-26T05:02:55Z","updated_at":"2018-11-28T15:56:20Z","closed_at":"2018-11-28T14:14:03Z","merged_at":"2018-11-28T14:14:03Z","merge_commit_sha":"348708cad30c2fa60e7bba6d62f0104c56fb9e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":73330064,"node_id":"MDU6TGFiZWw3MzMzMDA2NA==","url":"https://api.github.com/repos/godotengine/godot/labels/bug","name":"bug","color":"ff2222","default":true},{"id":279097966,"node_id":"MDU6TGFiZWwyNzkwOTc5NjY=","url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffdd44","default":false}],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/7","html_url":"https://github.com/godotengine/godot/milestone/7","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/7/labels","id":2529217,"node_id":"MDk6TWlsZXN0b25lMjUyOTIxNw==","number":7,"title":"3.1","description":"","creator":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":902,"closed_issues":4673,"state":"open","created_at":"2017-05-18T13:33:56Z","updated_at":"2018-11-28T15:43:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/23976/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/23976/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/23976/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/d22bc7413c083b11e9ee0ae8532e5aadd8aa0375","head":{"label":"clayjohn:transform_bug","ref":"transform_bug","sha":"d22bc7413c083b11e9ee0ae8532e5aadd8aa0375","user":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"repo":{"id":89124405,"node_id":"MDEwOlJlcG9zaXRvcnk4OTEyNDQwNQ==","name":"godot","full_name":"clayjohn/godot","private":false,"owner":{"login":"clayjohn","id":16521339,"node_id":"MDQ6VXNlcjE2NTIxMzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16521339?v=4","gravatar_id":"","url":"https://api.github.com/users/clayjohn","html_url":"https://github.com/clayjohn","followers_url":"https://api.github.com/users/clayjohn/followers","following_url":"https://api.github.com/users/clayjohn/following{/other_user}","gists_url":"https://api.github.com/users/clayjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/clayjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clayjohn/subscriptions","organizations_url":"https://api.github.com/users/clayjohn/orgs","repos_url":"https://api.github.com/users/clayjohn/repos","events_url":"https://api.github.com/users/clayjohn/events{/privacy}","received_events_url":"https://api.github.com/users/clayjohn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/clayjohn/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/clayjohn/godot","forks_url":"https://api.github.com/repos/clayjohn/godot/forks","keys_url":"https://api.github.com/repos/clayjohn/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clayjohn/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clayjohn/godot/teams","hooks_url":"https://api.github.com/repos/clayjohn/godot/hooks","issue_events_url":"https://api.github.com/repos/clayjohn/godot/issues/events{/number}","events_url":"https://api.github.com/repos/clayjohn/godot/events","assignees_url":"https://api.github.com/repos/clayjohn/godot/assignees{/user}","branches_url":"https://api.github.com/repos/clayjohn/godot/branches{/branch}","tags_url":"https://api.github.com/repos/clayjohn/godot/tags","blobs_url":"https://api.github.com/repos/clayjohn/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clayjohn/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clayjohn/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/clayjohn/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clayjohn/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/clayjohn/godot/languages","stargazers_url":"https://api.github.com/repos/clayjohn/godot/stargazers","contributors_url":"https://api.github.com/repos/clayjohn/godot/contributors","subscribers_url":"https://api.github.com/repos/clayjohn/godot/subscribers","subscription_url":"https://api.github.com/repos/clayjohn/godot/subscription","commits_url":"https://api.github.com/repos/clayjohn/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/clayjohn/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/clayjohn/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/clayjohn/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/clayjohn/godot/contents/{+path}","compare_url":"https://api.github.com/repos/clayjohn/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clayjohn/godot/merges","archive_url":"https://api.github.com/repos/clayjohn/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clayjohn/godot/downloads","issues_url":"https://api.github.com/repos/clayjohn/godot/issues{/number}","pulls_url":"https://api.github.com/repos/clayjohn/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/clayjohn/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/clayjohn/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clayjohn/godot/labels{/name}","releases_url":"https://api.github.com/repos/clayjohn/godot/releases{/id}","deployments_url":"https://api.github.com/repos/clayjohn/godot/deployments","created_at":"2017-04-23T07:20:23Z","updated_at":"2018-11-26T18:54:53Z","pushed_at":"2018-11-28T15:54:48Z","git_url":"git://github.com/clayjohn/godot.git","ssh_url":"git@github.com:clayjohn/godot.git","clone_url":"https://github.com/clayjohn/godot.git","svn_url":"https://github.com/clayjohn/godot","homepage":"https://godotengine.org","size":255190,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"815557c81228efc9e74097b50590b2d091387059","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDk4MQ==","name":"godot","full_name":"godotengine/godot","private":false,"owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2018-11-28T15:42:36Z","pushed_at":"2018-11-28T15:22:12Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":268083,"stargazers_count":17971,"watchers_count":17971,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3680,"mirror_url":null,"archived":false,"open_issues_count":4023,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3680,"open_issues":4023,"watchers":17971,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/23976"},"html":{"href":"https://github.com/godotengine/godot/pull/23976"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/23976"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/23976/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/23976/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/23976/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/d22bc7413c083b11e9ee0ae8532e5aadd8aa0375"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"clayjohn"}}