{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/rally/pulls/comments/189792828","pull_request_review_id":122038211,"id":189792828,"diff_hunk":"@@ -276,6 +276,159 @@ def detach_from_node(self, node, running):\n             self.attached = False\n \n \n+class CCRStats(TelemetryDevice):\n+    internal = False\n+    command = \"ccr-stats\"\n+    human_name = \"CCR Stats\"\n+    help = \"Regularly samples CCR related stats\"\n+\n+    \"\"\"\n+    Gathers CCR stats on a cluster level\n+    \"\"\"\n+\n+    def __init__(self, telemetry_params, clients, metrics_store):\n+        \"\"\"\n+        :param telemetry_params: The configuration object for telemetry_params.\n+            May optionally specify:\n+            ``ccr-stats-indices``: JSON object specifying the indices per cluster to pushish statistics from.","path":"esrally/mechanic/telemetry.py","position":29,"original_position":29,"commit_id":"040634296ce47e6e728e722657a271d6417de771","original_commit_id":"040634296ce47e6e728e722657a271d6417de771","user":{"login":"dliappis","id":1754575,"avatar_url":"https://avatars0.githubusercontent.com/u/1754575?v=4","gravatar_id":"","url":"https://api.github.com/users/dliappis","html_url":"https://github.com/dliappis","followers_url":"https://api.github.com/users/dliappis/followers","following_url":"https://api.github.com/users/dliappis/following{/other_user}","gists_url":"https://api.github.com/users/dliappis/gists{/gist_id}","starred_url":"https://api.github.com/users/dliappis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dliappis/subscriptions","organizations_url":"https://api.github.com/users/dliappis/orgs","repos_url":"https://api.github.com/users/dliappis/repos","events_url":"https://api.github.com/users/dliappis/events{/privacy}","received_events_url":"https://api.github.com/users/dliappis/received_events","type":"User","site_admin":false},"body":"This was meant to refer to https://www.w3schools.com/js/js_json_objects.asp and not the specific data type because we support reading both a JSON string directly in the cli arg or from a JSON filename.","created_at":"2018-05-22T06:53:12Z","updated_at":"2018-05-22T06:53:13Z","html_url":"https://github.com/elastic/rally/pull/505#discussion_r189792828","pull_request_url":"https://api.github.com/repos/elastic/rally/pulls/505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/rally/pulls/comments/189792828"},"html":{"href":"https://github.com/elastic/rally/pull/505#discussion_r189792828"},"pull_request":{"href":"https://api.github.com/repos/elastic/rally/pulls/505"}},"in_reply_to_id":189770810},"pull_request":{"url":"https://api.github.com/repos/elastic/rally/pulls/505","id":189045065,"html_url":"https://github.com/elastic/rally/pull/505","diff_url":"https://github.com/elastic/rally/pull/505.diff","patch_url":"https://github.com/elastic/rally/pull/505.patch","issue_url":"https://api.github.com/repos/elastic/rally/issues/505","number":505,"state":"open","locked":false,"title":"Commit ccr-stats telemetry device and tests","user":{"login":"dliappis","id":1754575,"avatar_url":"https://avatars0.githubusercontent.com/u/1754575?v=4","gravatar_id":"","url":"https://api.github.com/users/dliappis","html_url":"https://github.com/dliappis","followers_url":"https://api.github.com/users/dliappis/followers","following_url":"https://api.github.com/users/dliappis/following{/other_user}","gists_url":"https://api.github.com/users/dliappis/gists{/gist_id}","starred_url":"https://api.github.com/users/dliappis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dliappis/subscriptions","organizations_url":"https://api.github.com/users/dliappis/orgs","repos_url":"https://api.github.com/users/dliappis/repos","events_url":"https://api.github.com/users/dliappis/events{/privacy}","received_events_url":"https://api.github.com/users/dliappis/received_events","type":"User","site_admin":false},"body":"This PR adds a telemetry device called `ccr-stats`.\r\n\r\nAs this is meant to be used mostly internally no accompanying documentation is available yet, but I put some effort to document the Classes/Methods.","created_at":"2018-05-18T14:33:36Z","updated_at":"2018-05-22T06:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78b41983df085bad56c0a312c8f21dcd1ffe85e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":302600187,"url":"https://api.github.com/repos/elastic/rally/labels/:Telemetry","name":":Telemetry","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/elastic/rally/milestones/50","html_url":"https://github.com/elastic/rally/milestone/50","labels_url":"https://api.github.com/repos/elastic/rally/milestones/50/labels","id":3329960,"number":50,"title":"0.12.0","description":"","creator":{"login":"danielmitterdorfer","id":1699576,"avatar_url":"https://avatars3.githubusercontent.com/u/1699576?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmitterdorfer","html_url":"https://github.com/danielmitterdorfer","followers_url":"https://api.github.com/users/danielmitterdorfer/followers","following_url":"https://api.github.com/users/danielmitterdorfer/following{/other_user}","gists_url":"https://api.github.com/users/danielmitterdorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmitterdorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmitterdorfer/subscriptions","organizations_url":"https://api.github.com/users/danielmitterdorfer/orgs","repos_url":"https://api.github.com/users/danielmitterdorfer/repos","events_url":"https://api.github.com/users/danielmitterdorfer/events{/privacy}","received_events_url":"https://api.github.com/users/danielmitterdorfer/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":7,"state":"open","created_at":"2018-05-08T13:16:19Z","updated_at":"2018-05-22T06:31:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/elastic/rally/pulls/505/commits","review_comments_url":"https://api.github.com/repos/elastic/rally/pulls/505/comments","review_comment_url":"https://api.github.com/repos/elastic/rally/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/rally/issues/505/comments","statuses_url":"https://api.github.com/repos/elastic/rally/statuses/040634296ce47e6e728e722657a271d6417de771","head":{"label":"dliappis:ccr-telemetry-devices","ref":"ccr-telemetry-devices","sha":"040634296ce47e6e728e722657a271d6417de771","user":{"login":"dliappis","id":1754575,"avatar_url":"https://avatars0.githubusercontent.com/u/1754575?v=4","gravatar_id":"","url":"https://api.github.com/users/dliappis","html_url":"https://github.com/dliappis","followers_url":"https://api.github.com/users/dliappis/followers","following_url":"https://api.github.com/users/dliappis/following{/other_user}","gists_url":"https://api.github.com/users/dliappis/gists{/gist_id}","starred_url":"https://api.github.com/users/dliappis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dliappis/subscriptions","organizations_url":"https://api.github.com/users/dliappis/orgs","repos_url":"https://api.github.com/users/dliappis/repos","events_url":"https://api.github.com/users/dliappis/events{/privacy}","received_events_url":"https://api.github.com/users/dliappis/received_events","type":"User","site_admin":false},"repo":{"id":124390606,"name":"rally","full_name":"dliappis/rally","owner":{"login":"dliappis","id":1754575,"avatar_url":"https://avatars0.githubusercontent.com/u/1754575?v=4","gravatar_id":"","url":"https://api.github.com/users/dliappis","html_url":"https://github.com/dliappis","followers_url":"https://api.github.com/users/dliappis/followers","following_url":"https://api.github.com/users/dliappis/following{/other_user}","gists_url":"https://api.github.com/users/dliappis/gists{/gist_id}","starred_url":"https://api.github.com/users/dliappis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dliappis/subscriptions","organizations_url":"https://api.github.com/users/dliappis/orgs","repos_url":"https://api.github.com/users/dliappis/repos","events_url":"https://api.github.com/users/dliappis/events{/privacy}","received_events_url":"https://api.github.com/users/dliappis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dliappis/rally","description":"Macrobenchmarking framework for Elasticsearch","fork":true,"url":"https://api.github.com/repos/dliappis/rally","forks_url":"https://api.github.com/repos/dliappis/rally/forks","keys_url":"https://api.github.com/repos/dliappis/rally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dliappis/rally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dliappis/rally/teams","hooks_url":"https://api.github.com/repos/dliappis/rally/hooks","issue_events_url":"https://api.github.com/repos/dliappis/rally/issues/events{/number}","events_url":"https://api.github.com/repos/dliappis/rally/events","assignees_url":"https://api.github.com/repos/dliappis/rally/assignees{/user}","branches_url":"https://api.github.com/repos/dliappis/rally/branches{/branch}","tags_url":"https://api.github.com/repos/dliappis/rally/tags","blobs_url":"https://api.github.com/repos/dliappis/rally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dliappis/rally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dliappis/rally/git/refs{/sha}","trees_url":"https://api.github.com/repos/dliappis/rally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dliappis/rally/statuses/{sha}","languages_url":"https://api.github.com/repos/dliappis/rally/languages","stargazers_url":"https://api.github.com/repos/dliappis/rally/stargazers","contributors_url":"https://api.github.com/repos/dliappis/rally/contributors","subscribers_url":"https://api.github.com/repos/dliappis/rally/subscribers","subscription_url":"https://api.github.com/repos/dliappis/rally/subscription","commits_url":"https://api.github.com/repos/dliappis/rally/commits{/sha}","git_commits_url":"https://api.github.com/repos/dliappis/rally/git/commits{/sha}","comments_url":"https://api.github.com/repos/dliappis/rally/comments{/number}","issue_comment_url":"https://api.github.com/repos/dliappis/rally/issues/comments{/number}","contents_url":"https://api.github.com/repos/dliappis/rally/contents/{+path}","compare_url":"https://api.github.com/repos/dliappis/rally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dliappis/rally/merges","archive_url":"https://api.github.com/repos/dliappis/rally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dliappis/rally/downloads","issues_url":"https://api.github.com/repos/dliappis/rally/issues{/number}","pulls_url":"https://api.github.com/repos/dliappis/rally/pulls{/number}","milestones_url":"https://api.github.com/repos/dliappis/rally/milestones{/number}","notifications_url":"https://api.github.com/repos/dliappis/rally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dliappis/rally/labels{/name}","releases_url":"https://api.github.com/repos/dliappis/rally/releases{/id}","deployments_url":"https://api.github.com/repos/dliappis/rally/deployments","created_at":"2018-03-08T12:48:35Z","updated_at":"2018-05-18T14:03:25Z","pushed_at":"2018-05-22T06:15:47Z","git_url":"git://github.com/dliappis/rally.git","ssh_url":"git@github.com:dliappis/rally.git","clone_url":"https://github.com/dliappis/rally.git","svn_url":"https://github.com/dliappis/rally","homepage":"","size":4265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1ceb4dbe3d5c925fbcc63bc4ec8426a653d7c6f3","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":47140131,"name":"rally","full_name":"elastic/rally","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/rally","description":"Macrobenchmarking framework for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/rally","forks_url":"https://api.github.com/repos/elastic/rally/forks","keys_url":"https://api.github.com/repos/elastic/rally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/rally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/rally/teams","hooks_url":"https://api.github.com/repos/elastic/rally/hooks","issue_events_url":"https://api.github.com/repos/elastic/rally/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/rally/events","assignees_url":"https://api.github.com/repos/elastic/rally/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/rally/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/rally/tags","blobs_url":"https://api.github.com/repos/elastic/rally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/rally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/rally/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/rally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/rally/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/rally/languages","stargazers_url":"https://api.github.com/repos/elastic/rally/stargazers","contributors_url":"https://api.github.com/repos/elastic/rally/contributors","subscribers_url":"https://api.github.com/repos/elastic/rally/subscribers","subscription_url":"https://api.github.com/repos/elastic/rally/subscription","commits_url":"https://api.github.com/repos/elastic/rally/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/rally/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/rally/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/rally/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/rally/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/rally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/rally/merges","archive_url":"https://api.github.com/repos/elastic/rally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/rally/downloads","issues_url":"https://api.github.com/repos/elastic/rally/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/rally/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/rally/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/rally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/rally/labels{/name}","releases_url":"https://api.github.com/repos/elastic/rally/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/rally/deployments","created_at":"2015-11-30T19:11:43Z","updated_at":"2018-05-21T03:02:16Z","pushed_at":"2018-05-22T06:15:48Z","git_url":"git://github.com/elastic/rally.git","ssh_url":"git@github.com:elastic/rally.git","clone_url":"https://github.com/elastic/rally.git","svn_url":"https://github.com/elastic/rally","homepage":"","size":4216,"stargazers_count":474,"watchers_count":474,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":87,"open_issues":35,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/rally/pulls/505"},"html":{"href":"https://github.com/elastic/rally/pull/505"},"issue":{"href":"https://api.github.com/repos/elastic/rally/issues/505"},"comments":{"href":"https://api.github.com/repos/elastic/rally/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/rally/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/rally/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/rally/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/rally/statuses/040634296ce47e6e728e722657a271d6417de771"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dliappis"}}