{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/comments/200525320","pull_request_review_id":134859668,"id":200525320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDUyNTMyMA==","diff_hunk":"@@ -0,0 +1,88 @@\n+AWSTemplateFormatVersion: '2010-09-09'\n+Description: 'cloudtrail-streamer dev template'\n+Parameters:\n+  LambdaBucket:\n+    Description: 'S3 bucket with Lambda code'\n+    Type: String\n+  LambdaKey:\n+    Description: 'S3 bucket key with Lambda code'\n+    Type: String\n+  KinesisStream:\n+    Description: 'Kinesis stream for event submission'\n+    Type: String\n+Resources:\n+  CTStreamerRole:\n+    Type: 'AWS::IAM::Role'\n+    Properties:\n+      AssumeRolePolicyDocument:\n+        Statement:\n+          - Action:\n+              - 'sts:AssumeRole'\n+            Effect: Allow\n+            Principal:\n+              Service: lambda.amazonaws.com\n+      Policies:\n+        - PolicyDocument:\n+            Statement:\n+              - Action:\n+                  - 's3:GetObject'\n+                Resource: !Sub ${S3Bucket.Arn}/*\n+                Effect: 'Allow'\n+          PolicyName: CTStreamer-GetCloudtrailLogs\n+        - PolicyDocument:\n+            Statement:\n+              - Action:\n+                  - 'kinesis:*'\n+                Resource: !Sub ${KinesisStream.Arn}\n+                Effect: 'Allow'\n+          PolicyName: CTStreamer-Kinesis\n+        - PolicyDocument:\n+            Statement:\n+              - Action:\n+                  - 'logs:CreateLogGroup'\n+                  - 'logs:CreateLogStream'\n+                  - 'logs:PutLogEvents'\n+                Resource: 'arn:aws:logs:*:*:*'\n+                Effect: 'Allow'\n+          PolicyName: CTStreamer-Logs\n+\n+  S3Bucket:\n+    Type: 'AWS::S3::Bucket'\n+    Properties:\n+      BucketName: 'dev-cloudtrail-streamer'\n+      NotificationConfiguration:\n+        LambdaConfigurations:\n+          Function: !Sub ${CTStreamerFunction.Arn}","path":"cf/dev.yml","position":55,"original_position":55,"commit_id":"51c6a047644f1b75007d8ebbdf8d249137acb1f4","original_commit_id":"51c6a047644f1b75007d8ebbdf8d249137acb1f4","user":{"login":"ameihm0912","id":9889986,"node_id":"MDQ6VXNlcjk4ODk5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/9889986?v=4","gravatar_id":"","url":"https://api.github.com/users/ameihm0912","html_url":"https://github.com/ameihm0912","followers_url":"https://api.github.com/users/ameihm0912/followers","following_url":"https://api.github.com/users/ameihm0912/following{/other_user}","gists_url":"https://api.github.com/users/ameihm0912/gists{/gist_id}","starred_url":"https://api.github.com/users/ameihm0912/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameihm0912/subscriptions","organizations_url":"https://api.github.com/users/ameihm0912/orgs","repos_url":"https://api.github.com/users/ameihm0912/repos","events_url":"https://api.github.com/users/ameihm0912/events{/privacy}","received_events_url":"https://api.github.com/users/ameihm0912/received_events","type":"User","site_admin":false},"body":"Minor, but should we adjust this for the SNS case just for testing purposes in the future if it's intended to be deployed that way in prod?","created_at":"2018-07-06T00:48:41Z","updated_at":"2018-07-06T01:02:08Z","html_url":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1#discussion_r200525320","pull_request_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/comments/200525320"},"html":{"href":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1#discussion_r200525320"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1","id":198798490,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Nzk4NDkw","html_url":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1","diff_url":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1.diff","patch_url":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1.patch","issue_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/1","number":1,"state":"open","locked":false,"title":"v1 + initial commit","user":{"login":"ajvb","id":1144310,"node_id":"MDQ6VXNlcjExNDQzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1144310?v=4","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"body":"Took a lot from https://github.com/mozilla-services/duopull-lambda/\r\n\r\nr? @ameihm0912 @g-k","created_at":"2018-07-02T21:50:25Z","updated_at":"2018-07-06T01:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91cd007b562987e511049641c5374cd03697b0e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/1/comments","statuses_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/statuses/51c6a047644f1b75007d8ebbdf8d249137acb1f4","head":{"label":"mozilla-services:ajvb/initial-commit","ref":"ajvb/initial-commit","sha":"51c6a047644f1b75007d8ebbdf8d249137acb1f4","user":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":139498198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0OTgxOTg=","name":"cloudtrail-streamer","full_name":"mozilla-services/cloudtrail-streamer","owner":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/cloudtrail-streamer","description":"Lambda function to stream Cloudtrail logs to a Kinesis stream","fork":false,"url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer","forks_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/forks","keys_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/teams","hooks_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/events","assignees_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/tags","blobs_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/subscription","commits_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/merges","archive_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/downloads","issues_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/deployments","created_at":"2018-07-02T21:45:02Z","updated_at":"2018-07-02T21:45:05Z","pushed_at":"2018-07-05T23:29:22Z","git_url":"git://github.com/mozilla-services/cloudtrail-streamer.git","ssh_url":"git@github.com:mozilla-services/cloudtrail-streamer.git","clone_url":"https://github.com/mozilla-services/cloudtrail-streamer.git","svn_url":"https://github.com/mozilla-services/cloudtrail-streamer","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"4f4fb7deeb83932fd85b6effd754f31e38b2e78d","user":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":139498198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0OTgxOTg=","name":"cloudtrail-streamer","full_name":"mozilla-services/cloudtrail-streamer","owner":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/cloudtrail-streamer","description":"Lambda function to stream Cloudtrail logs to a Kinesis stream","fork":false,"url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer","forks_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/forks","keys_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/teams","hooks_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/events","assignees_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/tags","blobs_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/subscription","commits_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/merges","archive_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/downloads","issues_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/deployments","created_at":"2018-07-02T21:45:02Z","updated_at":"2018-07-02T21:45:05Z","pushed_at":"2018-07-05T23:29:22Z","git_url":"git://github.com/mozilla-services/cloudtrail-streamer.git","ssh_url":"git@github.com:mozilla-services/cloudtrail-streamer.git","clone_url":"https://github.com/mozilla-services/cloudtrail-streamer.git","svn_url":"https://github.com/mozilla-services/cloudtrail-streamer","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1"},"html":{"href":"https://github.com/mozilla-services/cloudtrail-streamer/pull/1"},"issue":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/1"},"comments":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/cloudtrail-streamer/statuses/51c6a047644f1b75007d8ebbdf8d249137acb1f4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ameihm0912"}}