{"action":"created","comment":{"url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/comments/219555558","pull_request_review_id":157280246,"id":219555558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTU1NTU1OA==","diff_hunk":"@@ -303,9 +303,8 @@ def __init__(self, underlying_position):\n     def __getattr__(self, attr):\n         return getattr(self._underlying_position, attr)\n \n-    # this is required for the zipline-live project\n-    # def __setattr__(self, attr, value):\n-    #     raise AttributeError('cannot mutate Position objects')\n+    def __setattr__(self, attr, value):","path":"zipline/protocol.py","position":20,"original_position":20,"commit_id":"31f99e013f35bedd54c470d8ef80d4477c86cdc6","original_commit_id":"31f99e013f35bedd54c470d8ef80d4477c86cdc6","user":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"body":"I was wrong about this.\r\nwe should not change the `protocol.py` code","created_at":"2018-09-21T16:29:33Z","updated_at":"2018-09-21T16:39:14Z","html_url":"https://github.com/shlomikushchi/zipline/pull/7#discussion_r219555558","pull_request_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/comments/219555558"},"html":{"href":"https://github.com/shlomikushchi/zipline/pull/7#discussion_r219555558"},"pull_request":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7","id":216889137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODg5MTM3","html_url":"https://github.com/shlomikushchi/zipline/pull/7","diff_url":"https://github.com/shlomikushchi/zipline/pull/7.diff","patch_url":"https://github.com/shlomikushchi/zipline/pull/7.patch","issue_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/7","number":7,"state":"open","locked":false,"title":"Adjusting to new perf tracker methods","user":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-20T08:42:58Z","updated_at":"2018-09-21T16:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9deb5b895233b61dd1647dd2b25f6247044e06a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7/commits","review_comments_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7/comments","review_comment_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/7/comments","statuses_url":"https://api.github.com/repos/shlomikushchi/zipline/statuses/31f99e013f35bedd54c470d8ef80d4477c86cdc6","head":{"label":"shlomikushchi:Adjusting-to-new-perfTracker-methods","ref":"Adjusting-to-new-perfTracker-methods","sha":"31f99e013f35bedd54c470d8ef80d4477c86cdc6","user":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"repo":{"id":143399252,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzOTkyNTI=","name":"zipline","full_name":"shlomikushchi/zipline","private":false,"owner":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shlomikushchi/zipline","description":"Zipline-Live, a Pythonic Algorithmic Trading Library","fork":true,"url":"https://api.github.com/repos/shlomikushchi/zipline","forks_url":"https://api.github.com/repos/shlomikushchi/zipline/forks","keys_url":"https://api.github.com/repos/shlomikushchi/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlomikushchi/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlomikushchi/zipline/teams","hooks_url":"https://api.github.com/repos/shlomikushchi/zipline/hooks","issue_events_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/shlomikushchi/zipline/events","assignees_url":"https://api.github.com/repos/shlomikushchi/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/shlomikushchi/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/shlomikushchi/zipline/tags","blobs_url":"https://api.github.com/repos/shlomikushchi/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlomikushchi/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlomikushchi/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlomikushchi/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlomikushchi/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/shlomikushchi/zipline/languages","stargazers_url":"https://api.github.com/repos/shlomikushchi/zipline/stargazers","contributors_url":"https://api.github.com/repos/shlomikushchi/zipline/contributors","subscribers_url":"https://api.github.com/repos/shlomikushchi/zipline/subscribers","subscription_url":"https://api.github.com/repos/shlomikushchi/zipline/subscription","commits_url":"https://api.github.com/repos/shlomikushchi/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlomikushchi/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlomikushchi/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlomikushchi/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/shlomikushchi/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlomikushchi/zipline/merges","archive_url":"https://api.github.com/repos/shlomikushchi/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlomikushchi/zipline/downloads","issues_url":"https://api.github.com/repos/shlomikushchi/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/shlomikushchi/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/shlomikushchi/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlomikushchi/zipline/labels{/name}","releases_url":"https://api.github.com/repos/shlomikushchi/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/shlomikushchi/zipline/deployments","created_at":"2018-08-03T08:17:59Z","updated_at":"2018-09-19T08:33:16Z","pushed_at":"2018-09-20T09:04:46Z","git_url":"git://github.com/shlomikushchi/zipline.git","ssh_url":"git@github.com:shlomikushchi/zipline.git","clone_url":"https://github.com/shlomikushchi/zipline.git","svn_url":"https://github.com/shlomikushchi/zipline","homepage":"http://www.zipline-live.io/","size":144485,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"shlomikushchi:master","ref":"master","sha":"6b9b8673e6a07d91954c08b6327cb9d83ffbc3de","user":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"repo":{"id":143399252,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzOTkyNTI=","name":"zipline","full_name":"shlomikushchi/zipline","private":false,"owner":{"login":"shlomikushchi","id":7924802,"node_id":"MDQ6VXNlcjc5MjQ4MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7924802?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomikushchi","html_url":"https://github.com/shlomikushchi","followers_url":"https://api.github.com/users/shlomikushchi/followers","following_url":"https://api.github.com/users/shlomikushchi/following{/other_user}","gists_url":"https://api.github.com/users/shlomikushchi/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomikushchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomikushchi/subscriptions","organizations_url":"https://api.github.com/users/shlomikushchi/orgs","repos_url":"https://api.github.com/users/shlomikushchi/repos","events_url":"https://api.github.com/users/shlomikushchi/events{/privacy}","received_events_url":"https://api.github.com/users/shlomikushchi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shlomikushchi/zipline","description":"Zipline-Live, a Pythonic Algorithmic Trading Library","fork":true,"url":"https://api.github.com/repos/shlomikushchi/zipline","forks_url":"https://api.github.com/repos/shlomikushchi/zipline/forks","keys_url":"https://api.github.com/repos/shlomikushchi/zipline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shlomikushchi/zipline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shlomikushchi/zipline/teams","hooks_url":"https://api.github.com/repos/shlomikushchi/zipline/hooks","issue_events_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/events{/number}","events_url":"https://api.github.com/repos/shlomikushchi/zipline/events","assignees_url":"https://api.github.com/repos/shlomikushchi/zipline/assignees{/user}","branches_url":"https://api.github.com/repos/shlomikushchi/zipline/branches{/branch}","tags_url":"https://api.github.com/repos/shlomikushchi/zipline/tags","blobs_url":"https://api.github.com/repos/shlomikushchi/zipline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shlomikushchi/zipline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shlomikushchi/zipline/git/refs{/sha}","trees_url":"https://api.github.com/repos/shlomikushchi/zipline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shlomikushchi/zipline/statuses/{sha}","languages_url":"https://api.github.com/repos/shlomikushchi/zipline/languages","stargazers_url":"https://api.github.com/repos/shlomikushchi/zipline/stargazers","contributors_url":"https://api.github.com/repos/shlomikushchi/zipline/contributors","subscribers_url":"https://api.github.com/repos/shlomikushchi/zipline/subscribers","subscription_url":"https://api.github.com/repos/shlomikushchi/zipline/subscription","commits_url":"https://api.github.com/repos/shlomikushchi/zipline/commits{/sha}","git_commits_url":"https://api.github.com/repos/shlomikushchi/zipline/git/commits{/sha}","comments_url":"https://api.github.com/repos/shlomikushchi/zipline/comments{/number}","issue_comment_url":"https://api.github.com/repos/shlomikushchi/zipline/issues/comments{/number}","contents_url":"https://api.github.com/repos/shlomikushchi/zipline/contents/{+path}","compare_url":"https://api.github.com/repos/shlomikushchi/zipline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shlomikushchi/zipline/merges","archive_url":"https://api.github.com/repos/shlomikushchi/zipline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shlomikushchi/zipline/downloads","issues_url":"https://api.github.com/repos/shlomikushchi/zipline/issues{/number}","pulls_url":"https://api.github.com/repos/shlomikushchi/zipline/pulls{/number}","milestones_url":"https://api.github.com/repos/shlomikushchi/zipline/milestones{/number}","notifications_url":"https://api.github.com/repos/shlomikushchi/zipline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shlomikushchi/zipline/labels{/name}","releases_url":"https://api.github.com/repos/shlomikushchi/zipline/releases{/id}","deployments_url":"https://api.github.com/repos/shlomikushchi/zipline/deployments","created_at":"2018-08-03T08:17:59Z","updated_at":"2018-09-19T08:33:16Z","pushed_at":"2018-09-20T09:04:46Z","git_url":"git://github.com/shlomikushchi/zipline.git","ssh_url":"git@github.com:shlomikushchi/zipline.git","clone_url":"https://github.com/shlomikushchi/zipline.git","svn_url":"https://github.com/shlomikushchi/zipline","homepage":"http://www.zipline-live.io/","size":144485,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7"},"html":{"href":"https://github.com/shlomikushchi/zipline/pull/7"},"issue":{"href":"https://api.github.com/repos/shlomikushchi/zipline/issues/7"},"comments":{"href":"https://api.github.com/repos/shlomikushchi/zipline/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shlomikushchi/zipline/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/shlomikushchi/zipline/statuses/31f99e013f35bedd54c470d8ef80d4477c86cdc6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"shlomikushchi"}}