{"action":"created","comment":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/199631481","pull_request_review_id":133786364,"id":199631481,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYzMTQ4MQ==","diff_hunk":"@@ -37,46 +37,54 @@ using Timestamp = time_point;\n class MetadataStore {\n  public:\n   struct Metadata {\n-    Metadata(const std::string& version_,\n+    Metadata(const std::string& type_,\n+             const std::string& location_,\n+             const std::string& version_,\n+             const std::string& schema_name_,\n              bool is_deleted_,\n-             const Timestamp& created_at_,\n              const Timestamp& collected_at_,\n              json::value metadata_)\n-        : version(version_), is_deleted(is_deleted_), created_at(created_at_),\n-          collected_at(collected_at_), metadata(std::move(metadata_)),\n-          ignore(false) {}\n+        : type(type_), location(location_), version(version_),\n+        schema_name(schema_name_), is_deleted(is_deleted_),","path":"src/store.h","position":null,"original_position":17,"commit_id":"38877fcda8c0662931509cc8867dc7f50292f159","original_commit_id":"370aaa0a057d98f7acbefb5d951ffbf71e5a5e1b","user":{"login":"supriyagarg","id":11726936,"node_id":"MDQ6VXNlcjExNzI2OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/11726936?v=4","gravatar_id":"","url":"https://api.github.com/users/supriyagarg","html_url":"https://github.com/supriyagarg","followers_url":"https://api.github.com/users/supriyagarg/followers","following_url":"https://api.github.com/users/supriyagarg/following{/other_user}","gists_url":"https://api.github.com/users/supriyagarg/gists{/gist_id}","starred_url":"https://api.github.com/users/supriyagarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supriyagarg/subscriptions","organizations_url":"https://api.github.com/users/supriyagarg/orgs","repos_url":"https://api.github.com/users/supriyagarg/repos","events_url":"https://api.github.com/users/supriyagarg/events{/privacy}","received_events_url":"https://api.github.com/users/supriyagarg/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-07-02T21:50:54Z","updated_at":"2018-07-02T21:59:48Z","html_url":"https://github.com/Stackdriver/metadata-agent/pull/153#discussion_r199631481","pull_request_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/199631481"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/153#discussion_r199631481"},"pull_request":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153"}},"in_reply_to_id":199549049},"pull_request":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153","id":196597913,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTk3OTEz","html_url":"https://github.com/Stackdriver/metadata-agent/pull/153","diff_url":"https://github.com/Stackdriver/metadata-agent/pull/153.diff","patch_url":"https://github.com/Stackdriver/metadata-agent/pull/153.patch","issue_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/153","number":153,"state":"open","locked":false,"title":"Update Storage schema","user":{"login":"supriyagarg","id":11726936,"node_id":"MDQ6VXNlcjExNzI2OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/11726936?v=4","gravatar_id":"","url":"https://api.github.com/users/supriyagarg","html_url":"https://github.com/supriyagarg","followers_url":"https://api.github.com/users/supriyagarg/followers","following_url":"https://api.github.com/users/supriyagarg/following{/other_user}","gists_url":"https://api.github.com/users/supriyagarg/gists{/gist_id}","starred_url":"https://api.github.com/users/supriyagarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supriyagarg/subscriptions","organizations_url":"https://api.github.com/users/supriyagarg/orgs","repos_url":"https://api.github.com/users/supriyagarg/repos","events_url":"https://api.github.com/users/supriyagarg/events{/privacy}","received_events_url":"https://api.github.com/users/supriyagarg/received_events","type":"User","site_admin":false},"body":"Add the new endpoint for v1beta3 as the default value for MetadataIngestionDefaultEndpointFormat.\r\nUpdate the storage schema to key the metadata by the full resource name.","created_at":"2018-06-21T22:57:42Z","updated_at":"2018-07-02T21:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c443c63b72266e3c360157467e2e346af354c8ff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bmoyles0117","id":264816,"node_id":"MDQ6VXNlcjI2NDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/264816?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoyles0117","html_url":"https://github.com/bmoyles0117","followers_url":"https://api.github.com/users/bmoyles0117/followers","following_url":"https://api.github.com/users/bmoyles0117/following{/other_user}","gists_url":"https://api.github.com/users/bmoyles0117/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoyles0117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoyles0117/subscriptions","organizations_url":"https://api.github.com/users/bmoyles0117/orgs","repos_url":"https://api.github.com/users/bmoyles0117/repos","events_url":"https://api.github.com/users/bmoyles0117/events{/privacy}","received_events_url":"https://api.github.com/users/bmoyles0117/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":971766958,"node_id":"MDU6TGFiZWw5NzE3NjY5NTg=","url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels/v1beta3","name":"v1beta3","color":"d3a03b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153/commits","review_comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153/comments","review_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/153/comments","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/38877fcda8c0662931509cc8867dc7f50292f159","head":{"label":"supriyagarg:storage_schema","ref":"storage_schema","sha":"38877fcda8c0662931509cc8867dc7f50292f159","user":{"login":"supriyagarg","id":11726936,"node_id":"MDQ6VXNlcjExNzI2OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/11726936?v=4","gravatar_id":"","url":"https://api.github.com/users/supriyagarg","html_url":"https://github.com/supriyagarg","followers_url":"https://api.github.com/users/supriyagarg/followers","following_url":"https://api.github.com/users/supriyagarg/following{/other_user}","gists_url":"https://api.github.com/users/supriyagarg/gists{/gist_id}","starred_url":"https://api.github.com/users/supriyagarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supriyagarg/subscriptions","organizations_url":"https://api.github.com/users/supriyagarg/orgs","repos_url":"https://api.github.com/users/supriyagarg/repos","events_url":"https://api.github.com/users/supriyagarg/events{/privacy}","received_events_url":"https://api.github.com/users/supriyagarg/received_events","type":"User","site_admin":false},"repo":{"id":118942349,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NDIzNDk=","name":"metadata-agent","full_name":"supriyagarg/metadata-agent","owner":{"login":"supriyagarg","id":11726936,"node_id":"MDQ6VXNlcjExNzI2OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/11726936?v=4","gravatar_id":"","url":"https://api.github.com/users/supriyagarg","html_url":"https://github.com/supriyagarg","followers_url":"https://api.github.com/users/supriyagarg/followers","following_url":"https://api.github.com/users/supriyagarg/following{/other_user}","gists_url":"https://api.github.com/users/supriyagarg/gists{/gist_id}","starred_url":"https://api.github.com/users/supriyagarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supriyagarg/subscriptions","organizations_url":"https://api.github.com/users/supriyagarg/orgs","repos_url":"https://api.github.com/users/supriyagarg/repos","events_url":"https://api.github.com/users/supriyagarg/events{/privacy}","received_events_url":"https://api.github.com/users/supriyagarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/supriyagarg/metadata-agent","description":"Stackdriver metadata agent","fork":true,"url":"https://api.github.com/repos/supriyagarg/metadata-agent","forks_url":"https://api.github.com/repos/supriyagarg/metadata-agent/forks","keys_url":"https://api.github.com/repos/supriyagarg/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supriyagarg/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supriyagarg/metadata-agent/teams","hooks_url":"https://api.github.com/repos/supriyagarg/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/supriyagarg/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/supriyagarg/metadata-agent/events","assignees_url":"https://api.github.com/repos/supriyagarg/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/supriyagarg/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/supriyagarg/metadata-agent/tags","blobs_url":"https://api.github.com/repos/supriyagarg/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supriyagarg/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supriyagarg/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/supriyagarg/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supriyagarg/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/supriyagarg/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/supriyagarg/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/supriyagarg/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/supriyagarg/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/supriyagarg/metadata-agent/subscription","commits_url":"https://api.github.com/repos/supriyagarg/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/supriyagarg/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/supriyagarg/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/supriyagarg/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/supriyagarg/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/supriyagarg/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supriyagarg/metadata-agent/merges","archive_url":"https://api.github.com/repos/supriyagarg/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supriyagarg/metadata-agent/downloads","issues_url":"https://api.github.com/repos/supriyagarg/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/supriyagarg/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/supriyagarg/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/supriyagarg/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supriyagarg/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/supriyagarg/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/supriyagarg/metadata-agent/deployments","created_at":"2018-01-25T17:03:49Z","updated_at":"2018-06-21T21:37:46Z","pushed_at":"2018-07-02T21:59:44Z","git_url":"git://github.com/supriyagarg/metadata-agent.git","ssh_url":"git@github.com:supriyagarg/metadata-agent.git","clone_url":"https://github.com/supriyagarg/metadata-agent.git","svn_url":"https://github.com/supriyagarg/metadata-agent","homepage":"","size":500,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Stackdriver:v1beta3-working-branch","ref":"v1beta3-working-branch","sha":"95e4e88268cb7a19351d570e68d7b2ff55cc9079","user":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM5NjMxMA==","name":"metadata-agent","full_name":"Stackdriver/metadata-agent","owner":{"login":"Stackdriver","id":2104369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-06-18T02:10:55Z","pushed_at":"2018-07-02T21:59:45Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"git@github.com:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":510,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/153"},"issue":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/153"},"comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/38877fcda8c0662931509cc8867dc7f50292f159"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"supriyagarg"}}