{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72075","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72075/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72075/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72075/events","html_url":"https://github.com/kubernetes/kubernetes/issues/72075","id":391352638,"node_id":"MDU6SXNzdWUzOTEzNTI2Mzg=","number":72075,"title":"suggestion for pod qos","user":{"login":"yanghaichao12","id":20693362,"node_id":"MDQ6VXNlcjIwNjkzMzYy","avatar_url":"https://avatars0.githubusercontent.com/u/20693362?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghaichao12","html_url":"https://github.com/yanghaichao12","followers_url":"https://api.github.com/users/yanghaichao12/followers","following_url":"https://api.github.com/users/yanghaichao12/following{/other_user}","gists_url":"https://api.github.com/users/yanghaichao12/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghaichao12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghaichao12/subscriptions","organizations_url":"https://api.github.com/users/yanghaichao12/orgs","repos_url":"https://api.github.com/users/yanghaichao12/repos","events_url":"https://api.github.com/users/yanghaichao12/events{/privacy}","received_events_url":"https://api.github.com/users/yanghaichao12/received_events","type":"User","site_admin":false},"labels":[{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-15T07:20:32Z","updated_at":"2018-12-21T12:52:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!-- Please only use this template for submitting enhancement requests -->\r\n\r\n**What would you like to be added**:\r\n    now pod qos is defined according to 'resources requests  and 'limits'  in container specification. if a pod has more than one container, we must write it many times. like that:\r\n`    \"spec\": {\r\n        \"replicas\": 2,\r\n        \"selector\": {\r\n            \"name\": \"ubuntu-test-pod\"\r\n        },\r\n        \"template\": {\r\n            \"metadata\": {\r\n                \"creationTimestamp\": null,\r\n                \"labels\": {\r\n                    \"name\": \"ubuntu-test-pod\"\r\n                }\r\n            },\r\n            \"spec\": {\r\n                \"containers\": [\r\n                    {\r\n                        \"command\": [\r\n                            \"sleep\",\r\n                            \"86400\"\r\n                        ],\r\n                        \"image\": \"ubuntu:v1\",\r\n                        \"imagePullPolicy\": \"IfNotPresent\",\r\n                        \"name\": \"ubuntu-test\",\r\n                        **_\"resources\": {\r\n                            \"limites\": {\r\n                                \"cpu\": \"500m\"\r\n                            }_**\r\n                        },\r\n                        \"terminationMessagePath\": \"/dev/termination-log\",\r\n                        \"terminationMessagePolicy\": \"File\"\r\n                    },\r\n                    {\r\n                        \"command\": [\r\n                            \"sleep\",\r\n                            \"7200\"\r\n                        ],\r\n                        \"image\": \"ubuntu:v1\",\r\n                        \"imagePullPolicy\": \"IfNotPresent\",\r\n                        \"name\": \"ubuntu-cgroup\",\r\n                        **_\"resources\": {\r\n                            \"limites\": {\r\n                                \"cpu\": \"600m\"\r\n                            }_**\r\n                        },\r\n                        \"terminationMessagePath\": \"/dev/termination-log\",\r\n                        \"terminationMessagePolicy\": \"File\"\r\n                    }\r\n                ],\r\n`\r\n\r\n**Why is this needed**:\r\n          can we just specify one time for one pod? and all PIDs of pod are put in one cgroup?\r\n<!-- DO NOT EDIT BELOW THIS LINE -->\r\n/kind feature"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/449380848","html_url":"https://github.com/kubernetes/kubernetes/issues/72075#issuecomment-449380848","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/72075","id":449380848,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTM4MDg0OA==","user":{"login":"ipuustin","id":998633,"node_id":"MDQ6VXNlcjk5ODYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/998633?v=4","gravatar_id":"","url":"https://api.github.com/users/ipuustin","html_url":"https://github.com/ipuustin","followers_url":"https://api.github.com/users/ipuustin/followers","following_url":"https://api.github.com/users/ipuustin/following{/other_user}","gists_url":"https://api.github.com/users/ipuustin/gists{/gist_id}","starred_url":"https://api.github.com/users/ipuustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipuustin/subscriptions","organizations_url":"https://api.github.com/users/ipuustin/orgs","repos_url":"https://api.github.com/users/ipuustin/repos","events_url":"https://api.github.com/users/ipuustin/events{/privacy}","received_events_url":"https://api.github.com/users/ipuustin/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T12:52:05Z","updated_at":"2018-12-21T12:52:05Z","author_association":"CONTRIBUTOR","body":"Already the QoS classes work in a somewhat more complex way. The docs say that for a `guaranteed` pod, **every** container in a pod must have matching memory and CPU resource requests and limits. However, for a `burstable` pod, **at least one** container must have a memory or CPU request."}}
{"actor":{"display_login":"ipuustin"}}