{"action":"created","comment":{"url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments/239844710","pull_request_review_id":182723717,"id":239844710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg0NDcxMA==","diff_hunk":"@@ -147,12 +135,14 @@ class NodeRuntime private[node] (\n       _   <- Task.delay(Kamon.stopAllReporters())\n       _   <- servers.httpServer.cancel\n       _   <- log.info(\"Shutting down interpreter runtime ...\")\n-      _   <- runtime.close()\n-      _   <- log.info(\"Shutting down Casper runtime ...\")\n-      _   <- casperRuntime.close()\n-      _   <- log.info(\"Bringing BlockStore down ...\")\n-      _   <- blockStore.close().value\n-      _   <- log.info(\"Goodbye.\")\n+// TODO Resources cleaning","path":"node/src/main/scala/coop/rchain/node/NodeRuntime.scala","position":59,"original_position":59,"commit_id":"299b29f089ceac053ae2b3f4f75643364d17fcc7","original_commit_id":"958f4c66f312fceebac33cf696c37590d780c13a","user":{"login":"DoSOfRedRiver","id":2995220,"node_id":"MDQ6VXNlcjI5OTUyMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2995220?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSOfRedRiver","html_url":"https://github.com/DoSOfRedRiver","followers_url":"https://api.github.com/users/DoSOfRedRiver/followers","following_url":"https://api.github.com/users/DoSOfRedRiver/following{/other_user}","gists_url":"https://api.github.com/users/DoSOfRedRiver/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSOfRedRiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSOfRedRiver/subscriptions","organizations_url":"https://api.github.com/users/DoSOfRedRiver/orgs","repos_url":"https://api.github.com/users/DoSOfRedRiver/repos","events_url":"https://api.github.com/users/DoSOfRedRiver/events{/privacy}","received_events_url":"https://api.github.com/users/DoSOfRedRiver/received_events","type":"User","site_admin":false},"body":"Why this was commented out?","created_at":"2018-12-07T15:25:57Z","updated_at":"2018-12-07T15:34:38Z","html_url":"https://github.com/CasperLabs/CasperLabs/pull/5#discussion_r239844710","pull_request_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments/239844710"},"html":{"href":"https://github.com/CasperLabs/CasperLabs/pull/5#discussion_r239844710"},"pull_request":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5","id":236831805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODMxODA1","html_url":"https://github.com/CasperLabs/CasperLabs/pull/5","diff_url":"https://github.com/CasperLabs/CasperLabs/pull/5.diff","patch_url":"https://github.com/CasperLabs/CasperLabs/pull/5.patch","issue_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/5","number":5,"state":"open","locked":false,"title":"[WIP] NODE-3 Breaking up the project on separate modules","user":{"login":"igor-ramazanov","id":12570166,"node_id":"MDQ6VXNlcjEyNTcwMTY2","avatar_url":"https://avatars2.githubusercontent.com/u/12570166?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-ramazanov","html_url":"https://github.com/igor-ramazanov","followers_url":"https://api.github.com/users/igor-ramazanov/followers","following_url":"https://api.github.com/users/igor-ramazanov/following{/other_user}","gists_url":"https://api.github.com/users/igor-ramazanov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ramazanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ramazanov/subscriptions","organizations_url":"https://api.github.com/users/igor-ramazanov/orgs","repos_url":"https://api.github.com/users/igor-ramazanov/repos","events_url":"https://api.github.com/users/igor-ramazanov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ramazanov/received_events","type":"User","site_admin":false},"body":"## Overview\r\nRemoving unnecessary modules and fixing compilation errors.\r\nThis is a WIP PR, and more changes will be added:\r\n* Fixing tests compilation and running\r\n* Defining boundaries and interfaces between modules\r\n* Removing all other unnecessary stuff like docs, scripts, etc.\r\n* Adjusting namings after forking\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nhttps://casperlabs.atlassian.net/browse/NODE-3\r\n\r\n### Complete this checklist before you submit the PR\r\n- [ ] This PR contains no more than 200 lines of code, excluding test code.\r\n- [ ] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [ ] If this PR adds a new feature, this PR includes tests related, to this feature.\r\n- [ ] You assigned one person to review this PR","created_at":"2018-12-07T11:07:21Z","updated_at":"2018-12-07T15:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b8ec1663462c361126a52a22956f3452641aac3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5/commits","review_comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5/comments","review_comment_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/5/comments","statuses_url":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/299b29f089ceac053ae2b3f4f75643364d17fcc7","head":{"label":"igor-ramazanov:NODE-3","ref":"NODE-3","sha":"299b29f089ceac053ae2b3f4f75643364d17fcc7","user":{"login":"igor-ramazanov","id":12570166,"node_id":"MDQ6VXNlcjEyNTcwMTY2","avatar_url":"https://avatars2.githubusercontent.com/u/12570166?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-ramazanov","html_url":"https://github.com/igor-ramazanov","followers_url":"https://api.github.com/users/igor-ramazanov/followers","following_url":"https://api.github.com/users/igor-ramazanov/following{/other_user}","gists_url":"https://api.github.com/users/igor-ramazanov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ramazanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ramazanov/subscriptions","organizations_url":"https://api.github.com/users/igor-ramazanov/orgs","repos_url":"https://api.github.com/users/igor-ramazanov/repos","events_url":"https://api.github.com/users/igor-ramazanov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ramazanov/received_events","type":"User","site_admin":false},"repo":{"id":160303066,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzMDMwNjY=","name":"CasperLabs","full_name":"igor-ramazanov/CasperLabs","private":false,"owner":{"login":"igor-ramazanov","id":12570166,"node_id":"MDQ6VXNlcjEyNTcwMTY2","avatar_url":"https://avatars2.githubusercontent.com/u/12570166?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-ramazanov","html_url":"https://github.com/igor-ramazanov","followers_url":"https://api.github.com/users/igor-ramazanov/followers","following_url":"https://api.github.com/users/igor-ramazanov/following{/other_user}","gists_url":"https://api.github.com/users/igor-ramazanov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ramazanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ramazanov/subscriptions","organizations_url":"https://api.github.com/users/igor-ramazanov/orgs","repos_url":"https://api.github.com/users/igor-ramazanov/repos","events_url":"https://api.github.com/users/igor-ramazanov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ramazanov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/igor-ramazanov/CasperLabs","description":null,"fork":true,"url":"https://api.github.com/repos/igor-ramazanov/CasperLabs","forks_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/forks","keys_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/teams","hooks_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/hooks","issue_events_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/issues/events{/number}","events_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/events","assignees_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/assignees{/user}","branches_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/branches{/branch}","tags_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/tags","blobs_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/languages","stargazers_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/stargazers","contributors_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/contributors","subscribers_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/subscribers","subscription_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/subscription","commits_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/contents/{+path}","compare_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/merges","archive_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/downloads","issues_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/issues{/number}","pulls_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/labels{/name}","releases_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/releases{/id}","deployments_url":"https://api.github.com/repos/igor-ramazanov/CasperLabs/deployments","created_at":"2018-12-04T05:25:18Z","updated_at":"2018-12-04T05:25:23Z","pushed_at":"2018-12-07T14:55:34Z","git_url":"git://github.com/igor-ramazanov/CasperLabs.git","ssh_url":"git@github.com:igor-ramazanov/CasperLabs.git","clone_url":"https://github.com/igor-ramazanov/CasperLabs.git","svn_url":"https://github.com/igor-ramazanov/CasperLabs","homepage":null,"size":2410,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CasperLabs:dev","ref":"dev","sha":"6d867545bef25cfc9086dc191ca9006f4b96f7e8","user":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":160243933,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyNDM5MzM=","name":"CasperLabs","full_name":"CasperLabs/CasperLabs","private":false,"owner":{"login":"CasperLabs","id":44785362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Nzg1MzYy","avatar_url":"https://avatars0.githubusercontent.com/u/44785362?v=4","gravatar_id":"","url":"https://api.github.com/users/CasperLabs","html_url":"https://github.com/CasperLabs","followers_url":"https://api.github.com/users/CasperLabs/followers","following_url":"https://api.github.com/users/CasperLabs/following{/other_user}","gists_url":"https://api.github.com/users/CasperLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CasperLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CasperLabs/subscriptions","organizations_url":"https://api.github.com/users/CasperLabs/orgs","repos_url":"https://api.github.com/users/CasperLabs/repos","events_url":"https://api.github.com/users/CasperLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CasperLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CasperLabs/CasperLabs","description":null,"fork":false,"url":"https://api.github.com/repos/CasperLabs/CasperLabs","forks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/forks","keys_url":"https://api.github.com/repos/CasperLabs/CasperLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CasperLabs/CasperLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CasperLabs/CasperLabs/teams","hooks_url":"https://api.github.com/repos/CasperLabs/CasperLabs/hooks","issue_events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/events{/number}","events_url":"https://api.github.com/repos/CasperLabs/CasperLabs/events","assignees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/assignees{/user}","branches_url":"https://api.github.com/repos/CasperLabs/CasperLabs/branches{/branch}","tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/tags","blobs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/CasperLabs/CasperLabs/languages","stargazers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/stargazers","contributors_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contributors","subscribers_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscribers","subscription_url":"https://api.github.com/repos/CasperLabs/CasperLabs/subscription","commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CasperLabs/CasperLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CasperLabs/CasperLabs/contents/{+path}","compare_url":"https://api.github.com/repos/CasperLabs/CasperLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CasperLabs/CasperLabs/merges","archive_url":"https://api.github.com/repos/CasperLabs/CasperLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CasperLabs/CasperLabs/downloads","issues_url":"https://api.github.com/repos/CasperLabs/CasperLabs/issues{/number}","pulls_url":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/CasperLabs/CasperLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/CasperLabs/CasperLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CasperLabs/CasperLabs/labels{/name}","releases_url":"https://api.github.com/repos/CasperLabs/CasperLabs/releases{/id}","deployments_url":"https://api.github.com/repos/CasperLabs/CasperLabs/deployments","created_at":"2018-12-03T19:39:20Z","updated_at":"2018-12-06T17:52:55Z","pushed_at":"2018-12-07T14:55:36Z","git_url":"git://github.com/CasperLabs/CasperLabs.git","ssh_url":"git@github.com:CasperLabs/CasperLabs.git","clone_url":"https://github.com/CasperLabs/CasperLabs.git","svn_url":"https://github.com/CasperLabs/CasperLabs","homepage":null,"size":2342,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5"},"html":{"href":"https://github.com/CasperLabs/CasperLabs/pull/5"},"issue":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/5"},"comments":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/CasperLabs/CasperLabs/statuses/299b29f089ceac053ae2b3f4f75643364d17fcc7"}},"author_association":"NONE"}}
{"actor":{"display_login":"DoSOfRedRiver"}}