{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/166989092","pull_request_review_id":95138680,"id":166989092,"diff_hunk":"@@ -250,26 +271,29 @@ def handle(event)\n     private\n \n       def mount_device\n-        @controller.mount_point = @mount_point_widget.value.to_s\n-        @fstab_options_widget.enable\n         @mount_point_widget.enable\n+        mount_point_change\n       end\n \n       def dont_mount_device\n-        @controller.mount_point = \"\"\n+        @controller.remove_mount_point\n         @fstab_options_widget.disable\n         @mount_point_widget.disable\n       end\n \n       def mount_point_change\n-        mount_point = @mount_point_widget.value.to_s\n-        @controller.mount_point = mount_point\n-        if mount_point.nil? || mount_point.empty?\n+        if mount_path.empty?","path":"src/lib/y2partitioner/widgets/format_and_mount.rb","position":55,"original_position":55,"commit_id":"efb418b0633016587314c3b163ac79be4f039796","original_commit_id":"efb418b0633016587314c3b163ac79be4f039796","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"In this case, `mount_path` is a method belonging to the widget. It simply returns the string given by the user for the mount point, so we only check that the string is not empty.","created_at":"2018-02-08T16:24:18Z","updated_at":"2018-02-08T16:24:18Z","html_url":"https://github.com/yast/yast-storage-ng/pull/510#discussion_r166989092","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/166989092"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/510#discussion_r166989092"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510"}},"in_reply_to_id":166972518},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510","id":167401523,"html_url":"https://github.com/yast/yast-storage-ng/pull/510","diff_url":"https://github.com/yast/yast-storage-ng/pull/510.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/510.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/510","number":510,"state":"open","locked":false,"title":"Add MountPoint class","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"PBI: https://trello.com/c/NYy7AklQ/144-5-use-new-libstorage-ng-api-for-mount-points\r\n\r\nNote for reviewers:\r\n\r\nCode climate starts to complain after adapting some methods to use the new API. One error is because controller `filesystem` is too long. This controller should be \"refactorized\" in future.\r\n\r\nOther errors are related to complexity 7/6. Do you think it worth to fix?\r\n  ","created_at":"2018-02-06T12:33:31Z","updated_at":"2018-02-08T16:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f59e14b3e130a8300115bd48128fad628b547730","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/510/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/efb418b0633016587314c3b163ac79be4f039796","head":{"label":"joseivanlopez:add_mount_point_class","ref":"add_mount_point_class","sha":"efb418b0633016587314c3b163ac79be4f039796","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"repo":{"id":81220643,"name":"yast-storage-ng","full_name":"joseivanlopez/yast-storage-ng","owner":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joseivanlopez/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":true,"url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng","forks_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/deployments","created_at":"2017-02-07T15:04:53Z","updated_at":"2017-02-07T15:04:56Z","pushed_at":"2018-02-08T14:59:13Z","git_url":"git://github.com/joseivanlopez/yast-storage-ng.git","ssh_url":"git@github.com:joseivanlopez/yast-storage-ng.git","clone_url":"https://github.com/joseivanlopez/yast-storage-ng.git","svn_url":"https://github.com/joseivanlopez/yast-storage-ng","homepage":"http://yast.github.io/","size":4398,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"6600c9ae48828da454a00a051608bff480a111f7","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-12-13T17:35:51Z","pushed_at":"2018-02-08T16:16:16Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":4320,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/510"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/510"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/efb418b0633016587314c3b163ac79be4f039796"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joseivanlopez"}}