{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/240258300","pull_request_review_id":183230135,"id":240258300,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI1ODMwMA==","diff_hunk":"@@ -38,4 +38,8 @@\n \t */\n \tInputSplit getNextInputSplit(String host, int taskId);\n \n+\t/**\n+\t * return the split to assigner if the task fail to process it.","path":"flink-core/src/main/java/org/apache/flink/core/io/InputSplitAssigner.java","position":5,"original_position":5,"commit_id":"5b6cdb5f5bedc1edc5690ec6039527b12eb8757f","original_commit_id":"5b6cdb5f5bedc1edc5690ec6039527b12eb8757f","user":{"login":"StefanRRichter","id":2128543,"node_id":"MDQ6VXNlcjIxMjg1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2128543?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanRRichter","html_url":"https://github.com/StefanRRichter","followers_url":"https://api.github.com/users/StefanRRichter/followers","following_url":"https://api.github.com/users/StefanRRichter/following{/other_user}","gists_url":"https://api.github.com/users/StefanRRichter/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanRRichter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanRRichter/subscriptions","organizations_url":"https://api.github.com/users/StefanRRichter/orgs","repos_url":"https://api.github.com/users/StefanRRichter/repos","events_url":"https://api.github.com/users/StefanRRichter/events{/privacy}","received_events_url":"https://api.github.com/users/StefanRRichter/received_events","type":"User","site_admin":false},"body":"Please add the parameter description.","created_at":"2018-12-10T15:34:42Z","updated_at":"2018-12-10T15:43:17Z","html_url":"https://github.com/apache/flink/pull/6684#discussion_r240258300","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/240258300"},"html":{"href":"https://github.com/apache/flink/pull/6684#discussion_r240258300"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6684"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6684","id":214950948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTUwOTQ4","html_url":"https://github.com/apache/flink/pull/6684","diff_url":"https://github.com/apache/flink/pull/6684.diff","patch_url":"https://github.com/apache/flink/pull/6684.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6684","number":6684,"state":"open","locked":false,"title":"    [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…","user":{"login":"isunjin","id":2673621,"node_id":"MDQ6VXNlcjI2NzM2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2673621?v=4","gravatar_id":"","url":"https://api.github.com/users/isunjin","html_url":"https://github.com/isunjin","followers_url":"https://api.github.com/users/isunjin/followers","following_url":"https://api.github.com/users/isunjin/following{/other_user}","gists_url":"https://api.github.com/users/isunjin/gists{/gist_id}","starred_url":"https://api.github.com/users/isunjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isunjin/subscriptions","organizations_url":"https://api.github.com/users/isunjin/orgs","repos_url":"https://api.github.com/users/isunjin/repos","events_url":"https://api.github.com/users/isunjin/events{/privacy}","received_events_url":"https://api.github.com/users/isunjin/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\n    Today DataSource Task pull InputSplits from JobManager to achieve better\r\n    performance, however, when a DataSourceTask failed and rerun, it will\r\n    not get the same splits as its previous version. this will introduce\r\n    inconsistent result or even data corruption.\r\n\r\n    Furthermore,  if there are two executions run at the same time (in batch\r\n    scenario), this two executions should process same splits.\r\n\r\n    we need to fix the issue to make the inputs of a DataSourceTask\r\n    deterministic. The propose is save all splits into ExecutionVertex and\r\n    DataSourceTask will pull split from there.\r\n\r\n\r\n## Brief change log\r\n\r\n  - *JobMaster getNextInputSplit from Execution*\r\n  - *Execution forward getNextInputSplit and the sequence number of the request to ExecutionVertex*\r\n  - *If the sequence number exist in the ExecutionVertex return, else calculate and cache*\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n  - *covered by existing test*\r\n  - *Added a new test that validates the scenario that getNextInputSplit multiple times with different Execution attempts per ExecutionVertex*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n","created_at":"2018-09-12T12:56:40Z","updated_at":"2018-12-10T15:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1127e51efeb2c077ba39c4ac3483ec3528b316b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6684/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6684/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6684/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/5b6cdb5f5bedc1edc5690ec6039527b12eb8757f","head":{"label":"isunjin:FLINK-10205","ref":"FLINK-10205","sha":"5b6cdb5f5bedc1edc5690ec6039527b12eb8757f","user":{"login":"isunjin","id":2673621,"node_id":"MDQ6VXNlcjI2NzM2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2673621?v=4","gravatar_id":"","url":"https://api.github.com/users/isunjin","html_url":"https://github.com/isunjin","followers_url":"https://api.github.com/users/isunjin/followers","following_url":"https://api.github.com/users/isunjin/following{/other_user}","gists_url":"https://api.github.com/users/isunjin/gists{/gist_id}","starred_url":"https://api.github.com/users/isunjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isunjin/subscriptions","organizations_url":"https://api.github.com/users/isunjin/orgs","repos_url":"https://api.github.com/users/isunjin/repos","events_url":"https://api.github.com/users/isunjin/events{/privacy}","received_events_url":"https://api.github.com/users/isunjin/received_events","type":"User","site_admin":false},"repo":{"id":147265493,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNjU0OTM=","name":"flink","full_name":"isunjin/flink","private":false,"owner":{"login":"isunjin","id":2673621,"node_id":"MDQ6VXNlcjI2NzM2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2673621?v=4","gravatar_id":"","url":"https://api.github.com/users/isunjin","html_url":"https://github.com/isunjin","followers_url":"https://api.github.com/users/isunjin/followers","following_url":"https://api.github.com/users/isunjin/following{/other_user}","gists_url":"https://api.github.com/users/isunjin/gists{/gist_id}","starred_url":"https://api.github.com/users/isunjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isunjin/subscriptions","organizations_url":"https://api.github.com/users/isunjin/orgs","repos_url":"https://api.github.com/users/isunjin/repos","events_url":"https://api.github.com/users/isunjin/events{/privacy}","received_events_url":"https://api.github.com/users/isunjin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/isunjin/flink","description":"Apache Flink","fork":true,"url":"https://api.github.com/repos/isunjin/flink","forks_url":"https://api.github.com/repos/isunjin/flink/forks","keys_url":"https://api.github.com/repos/isunjin/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isunjin/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isunjin/flink/teams","hooks_url":"https://api.github.com/repos/isunjin/flink/hooks","issue_events_url":"https://api.github.com/repos/isunjin/flink/issues/events{/number}","events_url":"https://api.github.com/repos/isunjin/flink/events","assignees_url":"https://api.github.com/repos/isunjin/flink/assignees{/user}","branches_url":"https://api.github.com/repos/isunjin/flink/branches{/branch}","tags_url":"https://api.github.com/repos/isunjin/flink/tags","blobs_url":"https://api.github.com/repos/isunjin/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isunjin/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isunjin/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/isunjin/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isunjin/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/isunjin/flink/languages","stargazers_url":"https://api.github.com/repos/isunjin/flink/stargazers","contributors_url":"https://api.github.com/repos/isunjin/flink/contributors","subscribers_url":"https://api.github.com/repos/isunjin/flink/subscribers","subscription_url":"https://api.github.com/repos/isunjin/flink/subscription","commits_url":"https://api.github.com/repos/isunjin/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/isunjin/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/isunjin/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/isunjin/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/isunjin/flink/contents/{+path}","compare_url":"https://api.github.com/repos/isunjin/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isunjin/flink/merges","archive_url":"https://api.github.com/repos/isunjin/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isunjin/flink/downloads","issues_url":"https://api.github.com/repos/isunjin/flink/issues{/number}","pulls_url":"https://api.github.com/repos/isunjin/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/isunjin/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/isunjin/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isunjin/flink/labels{/name}","releases_url":"https://api.github.com/repos/isunjin/flink/releases{/id}","deployments_url":"https://api.github.com/repos/isunjin/flink/deployments","created_at":"2018-09-04T00:10:42Z","updated_at":"2018-09-12T11:05:04Z","pushed_at":"2018-11-30T23:48:59Z","git_url":"git://github.com/isunjin/flink.git","ssh_url":"git@github.com:isunjin/flink.git","clone_url":"https://github.com/isunjin/flink.git","svn_url":"https://github.com/isunjin/flink","homepage":"","size":169266,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"test-push"}},"base":{"label":"apache:master","ref":"master","sha":"f75c33d81993240b0a67feffc348aa19dc6c2834","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-12-10T15:04:22Z","pushed_at":"2018-12-10T15:02:25Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":171483,"stargazers_count":5240,"watchers_count":5240,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3238,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3238,"open_issues":428,"watchers":5240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6684"},"html":{"href":"https://github.com/apache/flink/pull/6684"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6684"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6684/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6684/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6684/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/5b6cdb5f5bedc1edc5690ec6039527b12eb8757f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"StefanRRichter"}}