{"action":"created","comment":{"url":"https://api.github.com/repos/kamax-io/mxisd/pulls/comments/170322541","pull_request_review_id":98998972,"id":170322541,"diff_hunk":"@@ -92,5 +94,5 @@ threepid.medium.email.connectors.smtp.login: \"matrix-identity@example.org\"\n # Password for the account\n threepid.medium.email.connectors.smtp.password: \"ThePassword\"\n \n-# The e-mail to send as. If empty, will be the same as login\n+# The e-mail to send as.","path":"application.example.yaml","position":31,"original_position":31,"commit_id":"261f3d814d8b18ddd13f4aa11666a8514c8e1f44","original_commit_id":"261f3d814d8b18ddd13f4aa11666a8514c8e1f44","user":{"login":"adrnam","id":13910467,"avatar_url":"https://avatars1.githubusercontent.com/u/13910467?v=4","gravatar_id":"","url":"https://api.github.com/users/adrnam","html_url":"https://github.com/adrnam","followers_url":"https://api.github.com/users/adrnam/followers","following_url":"https://api.github.com/users/adrnam/following{/other_user}","gists_url":"https://api.github.com/users/adrnam/gists{/gist_id}","starred_url":"https://api.github.com/users/adrnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrnam/subscriptions","organizations_url":"https://api.github.com/users/adrnam/orgs","repos_url":"https://api.github.com/users/adrnam/repos","events_url":"https://api.github.com/users/adrnam/events{/privacy}","received_events_url":"https://api.github.com/users/adrnam/received_events","type":"User","site_admin":false},"body":"Given that the ```smtp.login``` may be not an email address but just an username, I think it is error-prone. Unless we implement a dirty mechanism to verify that ```identity.from``` is a correct email address. Also, the ```e-mail to send as``` is usuallly a \"no-reply\" address, and should not be the same as the username login. ","created_at":"2018-02-23T18:02:47Z","updated_at":"2018-02-23T18:02:47Z","html_url":"https://github.com/kamax-io/mxisd/pull/54#discussion_r170322541","pull_request_url":"https://api.github.com/repos/kamax-io/mxisd/pulls/54","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/comments/170322541"},"html":{"href":"https://github.com/kamax-io/mxisd/pull/54#discussion_r170322541"},"pull_request":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/54"}},"in_reply_to_id":170308127},"pull_request":{"url":"https://api.github.com/repos/kamax-io/mxisd/pulls/54","id":171064781,"html_url":"https://github.com/kamax-io/mxisd/pull/54","diff_url":"https://github.com/kamax-io/mxisd/pull/54.diff","patch_url":"https://github.com/kamax-io/mxisd/pull/54.patch","issue_url":"https://api.github.com/repos/kamax-io/mxisd/issues/54","number":54,"state":"open","locked":false,"title":"Clarified configuration comments","user":{"login":"adrnam","id":13910467,"avatar_url":"https://avatars1.githubusercontent.com/u/13910467?v=4","gravatar_id":"","url":"https://api.github.com/users/adrnam","html_url":"https://github.com/adrnam","followers_url":"https://api.github.com/users/adrnam/followers","following_url":"https://api.github.com/users/adrnam/following{/other_user}","gists_url":"https://api.github.com/users/adrnam/gists{/gist_id}","starred_url":"https://api.github.com/users/adrnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrnam/subscriptions","organizations_url":"https://api.github.com/users/adrnam/orgs","repos_url":"https://api.github.com/users/adrnam/repos","events_url":"https://api.github.com/users/adrnam/events{/privacy}","received_events_url":"https://api.github.com/users/adrnam/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-23T16:56:31Z","updated_at":"2018-02-23T18:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1893ad6383e6db21db6215408cb761a0ab87e606","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kamax-io/mxisd/pulls/54/commits","review_comments_url":"https://api.github.com/repos/kamax-io/mxisd/pulls/54/comments","review_comment_url":"https://api.github.com/repos/kamax-io/mxisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kamax-io/mxisd/issues/54/comments","statuses_url":"https://api.github.com/repos/kamax-io/mxisd/statuses/261f3d814d8b18ddd13f4aa11666a8514c8e1f44","head":{"label":"kamax-io:configuration-review","ref":"configuration-review","sha":"261f3d814d8b18ddd13f4aa11666a8514c8e1f44","user":{"login":"kamax-io","id":25289324,"avatar_url":"https://avatars1.githubusercontent.com/u/25289324?v=4","gravatar_id":"","url":"https://api.github.com/users/kamax-io","html_url":"https://github.com/kamax-io","followers_url":"https://api.github.com/users/kamax-io/followers","following_url":"https://api.github.com/users/kamax-io/following{/other_user}","gists_url":"https://api.github.com/users/kamax-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamax-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamax-io/subscriptions","organizations_url":"https://api.github.com/users/kamax-io/orgs","repos_url":"https://api.github.com/users/kamax-io/repos","events_url":"https://api.github.com/users/kamax-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamax-io/received_events","type":"Organization","site_admin":false},"repo":{"id":79761508,"name":"mxisd","full_name":"kamax-io/mxisd","owner":{"login":"kamax-io","id":25289324,"avatar_url":"https://avatars1.githubusercontent.com/u/25289324?v=4","gravatar_id":"","url":"https://api.github.com/users/kamax-io","html_url":"https://github.com/kamax-io","followers_url":"https://api.github.com/users/kamax-io/followers","following_url":"https://api.github.com/users/kamax-io/following{/other_user}","gists_url":"https://api.github.com/users/kamax-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamax-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamax-io/subscriptions","organizations_url":"https://api.github.com/users/kamax-io/orgs","repos_url":"https://api.github.com/users/kamax-io/repos","events_url":"https://api.github.com/users/kamax-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamax-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kamax-io/mxisd","description":"Federated Matrix Identity Server","fork":false,"url":"https://api.github.com/repos/kamax-io/mxisd","forks_url":"https://api.github.com/repos/kamax-io/mxisd/forks","keys_url":"https://api.github.com/repos/kamax-io/mxisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamax-io/mxisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamax-io/mxisd/teams","hooks_url":"https://api.github.com/repos/kamax-io/mxisd/hooks","issue_events_url":"https://api.github.com/repos/kamax-io/mxisd/issues/events{/number}","events_url":"https://api.github.com/repos/kamax-io/mxisd/events","assignees_url":"https://api.github.com/repos/kamax-io/mxisd/assignees{/user}","branches_url":"https://api.github.com/repos/kamax-io/mxisd/branches{/branch}","tags_url":"https://api.github.com/repos/kamax-io/mxisd/tags","blobs_url":"https://api.github.com/repos/kamax-io/mxisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamax-io/mxisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamax-io/mxisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamax-io/mxisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamax-io/mxisd/statuses/{sha}","languages_url":"https://api.github.com/repos/kamax-io/mxisd/languages","stargazers_url":"https://api.github.com/repos/kamax-io/mxisd/stargazers","contributors_url":"https://api.github.com/repos/kamax-io/mxisd/contributors","subscribers_url":"https://api.github.com/repos/kamax-io/mxisd/subscribers","subscription_url":"https://api.github.com/repos/kamax-io/mxisd/subscription","commits_url":"https://api.github.com/repos/kamax-io/mxisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamax-io/mxisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamax-io/mxisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamax-io/mxisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamax-io/mxisd/contents/{+path}","compare_url":"https://api.github.com/repos/kamax-io/mxisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamax-io/mxisd/merges","archive_url":"https://api.github.com/repos/kamax-io/mxisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamax-io/mxisd/downloads","issues_url":"https://api.github.com/repos/kamax-io/mxisd/issues{/number}","pulls_url":"https://api.github.com/repos/kamax-io/mxisd/pulls{/number}","milestones_url":"https://api.github.com/repos/kamax-io/mxisd/milestones{/number}","notifications_url":"https://api.github.com/repos/kamax-io/mxisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamax-io/mxisd/labels{/name}","releases_url":"https://api.github.com/repos/kamax-io/mxisd/releases{/id}","deployments_url":"https://api.github.com/repos/kamax-io/mxisd/deployments","created_at":"2017-01-23T02:09:53Z","updated_at":"2018-02-18T19:52:47Z","pushed_at":"2018-02-23T16:56:32Z","git_url":"git://github.com/kamax-io/mxisd.git","ssh_url":"git@github.com:kamax-io/mxisd.git","clone_url":"https://github.com/kamax-io/mxisd.git","svn_url":"https://github.com/kamax-io/mxisd","homepage":"","size":610,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":6,"open_issues":10,"watchers":51,"default_branch":"master"}},"base":{"label":"kamax-io:master","ref":"master","sha":"665a284f4bf1fb4ab9d7e72d55b25c2ec042a9b6","user":{"login":"kamax-io","id":25289324,"avatar_url":"https://avatars1.githubusercontent.com/u/25289324?v=4","gravatar_id":"","url":"https://api.github.com/users/kamax-io","html_url":"https://github.com/kamax-io","followers_url":"https://api.github.com/users/kamax-io/followers","following_url":"https://api.github.com/users/kamax-io/following{/other_user}","gists_url":"https://api.github.com/users/kamax-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamax-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamax-io/subscriptions","organizations_url":"https://api.github.com/users/kamax-io/orgs","repos_url":"https://api.github.com/users/kamax-io/repos","events_url":"https://api.github.com/users/kamax-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamax-io/received_events","type":"Organization","site_admin":false},"repo":{"id":79761508,"name":"mxisd","full_name":"kamax-io/mxisd","owner":{"login":"kamax-io","id":25289324,"avatar_url":"https://avatars1.githubusercontent.com/u/25289324?v=4","gravatar_id":"","url":"https://api.github.com/users/kamax-io","html_url":"https://github.com/kamax-io","followers_url":"https://api.github.com/users/kamax-io/followers","following_url":"https://api.github.com/users/kamax-io/following{/other_user}","gists_url":"https://api.github.com/users/kamax-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamax-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamax-io/subscriptions","organizations_url":"https://api.github.com/users/kamax-io/orgs","repos_url":"https://api.github.com/users/kamax-io/repos","events_url":"https://api.github.com/users/kamax-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamax-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kamax-io/mxisd","description":"Federated Matrix Identity Server","fork":false,"url":"https://api.github.com/repos/kamax-io/mxisd","forks_url":"https://api.github.com/repos/kamax-io/mxisd/forks","keys_url":"https://api.github.com/repos/kamax-io/mxisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamax-io/mxisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamax-io/mxisd/teams","hooks_url":"https://api.github.com/repos/kamax-io/mxisd/hooks","issue_events_url":"https://api.github.com/repos/kamax-io/mxisd/issues/events{/number}","events_url":"https://api.github.com/repos/kamax-io/mxisd/events","assignees_url":"https://api.github.com/repos/kamax-io/mxisd/assignees{/user}","branches_url":"https://api.github.com/repos/kamax-io/mxisd/branches{/branch}","tags_url":"https://api.github.com/repos/kamax-io/mxisd/tags","blobs_url":"https://api.github.com/repos/kamax-io/mxisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamax-io/mxisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamax-io/mxisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamax-io/mxisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamax-io/mxisd/statuses/{sha}","languages_url":"https://api.github.com/repos/kamax-io/mxisd/languages","stargazers_url":"https://api.github.com/repos/kamax-io/mxisd/stargazers","contributors_url":"https://api.github.com/repos/kamax-io/mxisd/contributors","subscribers_url":"https://api.github.com/repos/kamax-io/mxisd/subscribers","subscription_url":"https://api.github.com/repos/kamax-io/mxisd/subscription","commits_url":"https://api.github.com/repos/kamax-io/mxisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamax-io/mxisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamax-io/mxisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamax-io/mxisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamax-io/mxisd/contents/{+path}","compare_url":"https://api.github.com/repos/kamax-io/mxisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamax-io/mxisd/merges","archive_url":"https://api.github.com/repos/kamax-io/mxisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamax-io/mxisd/downloads","issues_url":"https://api.github.com/repos/kamax-io/mxisd/issues{/number}","pulls_url":"https://api.github.com/repos/kamax-io/mxisd/pulls{/number}","milestones_url":"https://api.github.com/repos/kamax-io/mxisd/milestones{/number}","notifications_url":"https://api.github.com/repos/kamax-io/mxisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamax-io/mxisd/labels{/name}","releases_url":"https://api.github.com/repos/kamax-io/mxisd/releases{/id}","deployments_url":"https://api.github.com/repos/kamax-io/mxisd/deployments","created_at":"2017-01-23T02:09:53Z","updated_at":"2018-02-18T19:52:47Z","pushed_at":"2018-02-23T16:56:32Z","git_url":"git://github.com/kamax-io/mxisd.git","ssh_url":"git@github.com:kamax-io/mxisd.git","clone_url":"https://github.com/kamax-io/mxisd.git","svn_url":"https://github.com/kamax-io/mxisd","homepage":"","size":610,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":6,"open_issues":10,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/54"},"html":{"href":"https://github.com/kamax-io/mxisd/pull/54"},"issue":{"href":"https://api.github.com/repos/kamax-io/mxisd/issues/54"},"comments":{"href":"https://api.github.com/repos/kamax-io/mxisd/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kamax-io/mxisd/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/kamax-io/mxisd/statuses/261f3d814d8b18ddd13f4aa11666a8514c8e1f44"}},"author_association":"NONE"}}
{"actor":{"display_login":"adrnam"}}