{"action":"created","issue":{"url":"https://api.github.com/repos/xmollv/Llitgi/issues/35","repository_url":"https://api.github.com/repos/xmollv/Llitgi","labels_url":"https://api.github.com/repos/xmollv/Llitgi/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/xmollv/Llitgi/issues/35/comments","events_url":"https://api.github.com/repos/xmollv/Llitgi/issues/35/events","html_url":"https://github.com/xmollv/Llitgi/pull/35","id":348512939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODQ2OTgz","number":35,"title":"Coordinators + iPad support","user":{"login":"xmollv","id":8229382,"node_id":"MDQ6VXNlcjgyMjkzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/8229382?v=4","gravatar_id":"","url":"https://api.github.com/users/xmollv","html_url":"https://github.com/xmollv","followers_url":"https://api.github.com/users/xmollv/followers","following_url":"https://api.github.com/users/xmollv/following{/other_user}","gists_url":"https://api.github.com/users/xmollv/gists{/gist_id}","starred_url":"https://api.github.com/users/xmollv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmollv/subscriptions","organizations_url":"https://api.github.com/users/xmollv/orgs","repos_url":"https://api.github.com/users/xmollv/repos","events_url":"https://api.github.com/users/xmollv/events{/privacy}","received_events_url":"https://api.github.com/users/xmollv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"xmollv","id":8229382,"node_id":"MDQ6VXNlcjgyMjkzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/8229382?v=4","gravatar_id":"","url":"https://api.github.com/users/xmollv","html_url":"https://github.com/xmollv","followers_url":"https://api.github.com/users/xmollv/followers","following_url":"https://api.github.com/users/xmollv/following{/other_user}","gists_url":"https://api.github.com/users/xmollv/gists{/gist_id}","starred_url":"https://api.github.com/users/xmollv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmollv/subscriptions","organizations_url":"https://api.github.com/users/xmollv/orgs","repos_url":"https://api.github.com/users/xmollv/repos","events_url":"https://api.github.com/users/xmollv/events{/privacy}","received_events_url":"https://api.github.com/users/xmollv/received_events","type":"User","site_admin":false},"assignees":[{"login":"xmollv","id":8229382,"node_id":"MDQ6VXNlcjgyMjkzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/8229382?v=4","gravatar_id":"","url":"https://api.github.com/users/xmollv","html_url":"https://github.com/xmollv","followers_url":"https://api.github.com/users/xmollv/followers","following_url":"https://api.github.com/users/xmollv/following{/other_user}","gists_url":"https://api.github.com/users/xmollv/gists{/gist_id}","starred_url":"https://api.github.com/users/xmollv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmollv/subscriptions","organizations_url":"https://api.github.com/users/xmollv/orgs","repos_url":"https://api.github.com/users/xmollv/repos","events_url":"https://api.github.com/users/xmollv/events{/privacy}","received_events_url":"https://api.github.com/users/xmollv/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-08-07T22:43:46Z","updated_at":"2018-08-13T09:02:30Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/xmollv/Llitgi/pulls/35","html_url":"https://github.com/xmollv/Llitgi/pull/35","diff_url":"https://github.com/xmollv/Llitgi/pull/35.diff","patch_url":"https://github.com/xmollv/Llitgi/pull/35.patch"},"body":"This PR finishes #23 and it's heavily inspired on the PR that @atineoSE opened a while ago. I went down a rabbit hole and did the iPad support + Coordinators everything on the same branch 🤷🏼‍♂️\r\n\r\nI'm pushing this PR but should not be merged yet, I want to review it tomorrow when I'm not as tired as I am right now."},"comment":{"url":"https://api.github.com/repos/xmollv/Llitgi/issues/comments/412453622","html_url":"https://github.com/xmollv/Llitgi/pull/35#issuecomment-412453622","issue_url":"https://api.github.com/repos/xmollv/Llitgi/issues/35","id":412453622,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQ1MzYyMg==","user":{"login":"xmollv","id":8229382,"node_id":"MDQ6VXNlcjgyMjkzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/8229382?v=4","gravatar_id":"","url":"https://api.github.com/users/xmollv","html_url":"https://github.com/xmollv","followers_url":"https://api.github.com/users/xmollv/followers","following_url":"https://api.github.com/users/xmollv/following{/other_user}","gists_url":"https://api.github.com/users/xmollv/gists{/gist_id}","starred_url":"https://api.github.com/users/xmollv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmollv/subscriptions","organizations_url":"https://api.github.com/users/xmollv/orgs","repos_url":"https://api.github.com/users/xmollv/repos","events_url":"https://api.github.com/users/xmollv/events{/privacy}","received_events_url":"https://api.github.com/users/xmollv/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T09:02:30Z","updated_at":"2018-08-13T09:02:30Z","author_association":"OWNER","body":"@atineoSE Thanks! I'll double check the adding behaviour to see if I broke something.\r\n\r\nI'm also leaving a reminder to myself about some bugs that i found:\r\n- The login screen on a Plus device in landscape is broken. We need to do some magics with horizontalSizeClass == .regular && verticalSizeClass == .compact to avoid it.\r\n- The settings screen (or any other modal) is dismissed if we switch from a compact environment to a regular one. This happens because of the fix to dismiss the SFS when this behaviour occurs, but the other VC's should not be dismissed."}}
{"actor":{"display_login":"xmollv"}}