{"action":"created","comment":{"url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/comments/180987263","pull_request_review_id":111506083,"id":180987263,"diff_hunk":"@@ -10,7 +10,10 @@\n \n import android.util.Log;\n \n-/** package */ class PLog {\n+/**\n+ * Parse Logger\n+ */\n+public class PLog {","path":"Parse/src/main/java/com/parse/PLog.java","position":8,"original_position":8,"commit_id":"abd132486aef38dd9344545e5544bde3f45195e0","original_commit_id":"abd132486aef38dd9344545e5544bde3f45195e0","user":{"login":"Jawnnypoo","id":1459320,"avatar_url":"https://avatars3.githubusercontent.com/u/1459320?v=4","gravatar_id":"","url":"https://api.github.com/users/Jawnnypoo","html_url":"https://github.com/Jawnnypoo","followers_url":"https://api.github.com/users/Jawnnypoo/followers","following_url":"https://api.github.com/users/Jawnnypoo/following{/other_user}","gists_url":"https://api.github.com/users/Jawnnypoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jawnnypoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jawnnypoo/subscriptions","organizations_url":"https://api.github.com/users/Jawnnypoo/orgs","repos_url":"https://api.github.com/users/Jawnnypoo/repos","events_url":"https://api.github.com/users/Jawnnypoo/events{/privacy}","received_events_url":"https://api.github.com/users/Jawnnypoo/received_events","type":"User","site_admin":false},"body":"Had to make this public to allow for logging in the other modules","created_at":"2018-04-12T07:29:34Z","updated_at":"2018-04-12T07:29:34Z","html_url":"https://github.com/parse-community/Parse-SDK-Android/pull/800#discussion_r180987263","pull_request_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/comments/180987263"},"html":{"href":"https://github.com/parse-community/Parse-SDK-Android/pull/800#discussion_r180987263"},"pull_request":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800"}}},"pull_request":{"url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800","id":181112034,"html_url":"https://github.com/parse-community/Parse-SDK-Android/pull/800","diff_url":"https://github.com/parse-community/Parse-SDK-Android/pull/800.diff","patch_url":"https://github.com/parse-community/Parse-SDK-Android/pull/800.patch","issue_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/800","number":800,"state":"open","locked":false,"title":"FCM Support - GCM Module","user":{"login":"Jawnnypoo","id":1459320,"avatar_url":"https://avatars3.githubusercontent.com/u/1459320?v=4","gravatar_id":"","url":"https://api.github.com/users/Jawnnypoo","html_url":"https://github.com/Jawnnypoo","followers_url":"https://api.github.com/users/Jawnnypoo/followers","following_url":"https://api.github.com/users/Jawnnypoo/following{/other_user}","gists_url":"https://api.github.com/users/Jawnnypoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jawnnypoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jawnnypoo/subscriptions","organizations_url":"https://api.github.com/users/Jawnnypoo/orgs","repos_url":"https://api.github.com/users/Jawnnypoo/repos","events_url":"https://api.github.com/users/Jawnnypoo/events{/privacy}","received_events_url":"https://api.github.com/users/Jawnnypoo/received_events","type":"User","site_admin":false},"body":"This ended up being a pretty large effort and a substantial set of changes. \r\n\r\nThe good news is that now that GCM is not anywhere in the core SDK, it removes quite a bit of code and allows us to lean more on the Google Play Services library to do the implementation. \r\n\r\nSo, this update will **not** be backwards compatible, and will require us to solve the problem of shipping multiple artifacts with the library. I think maybe you have more experience with this process, @rogerhu ? I once again would advocate for switching over to jitpack.io to make the releases easy and doable by anyone who can tag a release. But I digress. \r\n\r\nI have tested the `gcm` and `fcm` modules in a sample project with a standard setup. Everything seems to work fine. Note that the instructions for setting up can be found in the README of the `gcm` and `fcm` modules respectively. We will need to update http://docs.parseplatform.org/tutorials/android-push-notifications/ to either reflect the changes, or point users to the FCM and GCM docs, leaning them more toward FCM since GCM is going away. \r\n\r\nSomewhat unrelated, but I think with these changes bumping us to a 1.17.0, we should consider removing or deprecating any other things we think need to be removed or deprecated. I for one think that we need to get rid of parsing the server url and application id and client key from the Android Manifest. It seems like as we add more and more methods to the Parse.Configuration.Builder, we would just want people to use this instead. ","created_at":"2018-04-12T07:26:17Z","updated_at":"2018-04-12T07:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9221ba87c671ec5437fd4b47e771e54604b6669e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rogerhu","id":326857,"avatar_url":"https://avatars1.githubusercontent.com/u/326857?v=4","gravatar_id":"","url":"https://api.github.com/users/rogerhu","html_url":"https://github.com/rogerhu","followers_url":"https://api.github.com/users/rogerhu/followers","following_url":"https://api.github.com/users/rogerhu/following{/other_user}","gists_url":"https://api.github.com/users/rogerhu/gists{/gist_id}","starred_url":"https://api.github.com/users/rogerhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogerhu/subscriptions","organizations_url":"https://api.github.com/users/rogerhu/orgs","repos_url":"https://api.github.com/users/rogerhu/repos","events_url":"https://api.github.com/users/rogerhu/events{/privacy}","received_events_url":"https://api.github.com/users/rogerhu/received_events","type":"User","site_admin":false},{"login":"flovilmart","id":364568,"avatar_url":"https://avatars3.githubusercontent.com/u/364568?v=4","gravatar_id":"","url":"https://api.github.com/users/flovilmart","html_url":"https://github.com/flovilmart","followers_url":"https://api.github.com/users/flovilmart/followers","following_url":"https://api.github.com/users/flovilmart/following{/other_user}","gists_url":"https://api.github.com/users/flovilmart/gists{/gist_id}","starred_url":"https://api.github.com/users/flovilmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flovilmart/subscriptions","organizations_url":"https://api.github.com/users/flovilmart/orgs","repos_url":"https://api.github.com/users/flovilmart/repos","events_url":"https://api.github.com/users/flovilmart/events{/privacy}","received_events_url":"https://api.github.com/users/flovilmart/received_events","type":"User","site_admin":false},{"login":"natario1","id":15526561,"avatar_url":"https://avatars2.githubusercontent.com/u/15526561?v=4","gravatar_id":"","url":"https://api.github.com/users/natario1","html_url":"https://github.com/natario1","followers_url":"https://api.github.com/users/natario1/followers","following_url":"https://api.github.com/users/natario1/following{/other_user}","gists_url":"https://api.github.com/users/natario1/gists{/gist_id}","starred_url":"https://api.github.com/users/natario1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natario1/subscriptions","organizations_url":"https://api.github.com/users/natario1/orgs","repos_url":"https://api.github.com/users/natario1/repos","events_url":"https://api.github.com/users/natario1/events{/privacy}","received_events_url":"https://api.github.com/users/natario1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800/commits","review_comments_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800/comments","review_comment_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/800/comments","statuses_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/statuses/abd132486aef38dd9344545e5544bde3f45195e0","head":{"label":"Jawnnypoo:fcm","ref":"fcm","sha":"abd132486aef38dd9344545e5544bde3f45195e0","user":{"login":"Jawnnypoo","id":1459320,"avatar_url":"https://avatars3.githubusercontent.com/u/1459320?v=4","gravatar_id":"","url":"https://api.github.com/users/Jawnnypoo","html_url":"https://github.com/Jawnnypoo","followers_url":"https://api.github.com/users/Jawnnypoo/followers","following_url":"https://api.github.com/users/Jawnnypoo/following{/other_user}","gists_url":"https://api.github.com/users/Jawnnypoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jawnnypoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jawnnypoo/subscriptions","organizations_url":"https://api.github.com/users/Jawnnypoo/orgs","repos_url":"https://api.github.com/users/Jawnnypoo/repos","events_url":"https://api.github.com/users/Jawnnypoo/events{/privacy}","received_events_url":"https://api.github.com/users/Jawnnypoo/received_events","type":"User","site_admin":false},"repo":{"id":129015763,"name":"Parse-SDK-Android","full_name":"Jawnnypoo/Parse-SDK-Android","owner":{"login":"Jawnnypoo","id":1459320,"avatar_url":"https://avatars3.githubusercontent.com/u/1459320?v=4","gravatar_id":"","url":"https://api.github.com/users/Jawnnypoo","html_url":"https://github.com/Jawnnypoo","followers_url":"https://api.github.com/users/Jawnnypoo/followers","following_url":"https://api.github.com/users/Jawnnypoo/following{/other_user}","gists_url":"https://api.github.com/users/Jawnnypoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jawnnypoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jawnnypoo/subscriptions","organizations_url":"https://api.github.com/users/Jawnnypoo/orgs","repos_url":"https://api.github.com/users/Jawnnypoo/repos","events_url":"https://api.github.com/users/Jawnnypoo/events{/privacy}","received_events_url":"https://api.github.com/users/Jawnnypoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jawnnypoo/Parse-SDK-Android","description":"Parse SDK for Android","fork":true,"url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android","forks_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/forks","keys_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/teams","hooks_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/events","assignees_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/tags","blobs_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/subscription","commits_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/merges","archive_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/downloads","issues_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Jawnnypoo/Parse-SDK-Android/deployments","created_at":"2018-04-11T01:25:01Z","updated_at":"2018-04-12T07:13:30Z","pushed_at":"2018-04-12T07:28:44Z","git_url":"git://github.com/Jawnnypoo/Parse-SDK-Android.git","ssh_url":"git@github.com:Jawnnypoo/Parse-SDK-Android.git","clone_url":"https://github.com/Jawnnypoo/Parse-SDK-Android.git","svn_url":"https://github.com/Jawnnypoo/Parse-SDK-Android","homepage":"http://docs.parseplatform.org/android/guide/","size":1526,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"parse-community:master","ref":"master","sha":"01299c90f2404cc79b146eb294c7527eff03f47f","user":{"login":"parse-community","id":26932219,"avatar_url":"https://avatars3.githubusercontent.com/u/26932219?v=4","gravatar_id":"","url":"https://api.github.com/users/parse-community","html_url":"https://github.com/parse-community","followers_url":"https://api.github.com/users/parse-community/followers","following_url":"https://api.github.com/users/parse-community/following{/other_user}","gists_url":"https://api.github.com/users/parse-community/gists{/gist_id}","starred_url":"https://api.github.com/users/parse-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parse-community/subscriptions","organizations_url":"https://api.github.com/users/parse-community/orgs","repos_url":"https://api.github.com/users/parse-community/repos","events_url":"https://api.github.com/users/parse-community/events{/privacy}","received_events_url":"https://api.github.com/users/parse-community/received_events","type":"Organization","site_admin":false},"repo":{"id":40628209,"name":"Parse-SDK-Android","full_name":"parse-community/Parse-SDK-Android","owner":{"login":"parse-community","id":26932219,"avatar_url":"https://avatars3.githubusercontent.com/u/26932219?v=4","gravatar_id":"","url":"https://api.github.com/users/parse-community","html_url":"https://github.com/parse-community","followers_url":"https://api.github.com/users/parse-community/followers","following_url":"https://api.github.com/users/parse-community/following{/other_user}","gists_url":"https://api.github.com/users/parse-community/gists{/gist_id}","starred_url":"https://api.github.com/users/parse-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parse-community/subscriptions","organizations_url":"https://api.github.com/users/parse-community/orgs","repos_url":"https://api.github.com/users/parse-community/repos","events_url":"https://api.github.com/users/parse-community/events{/privacy}","received_events_url":"https://api.github.com/users/parse-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/parse-community/Parse-SDK-Android","description":"Parse SDK for Android","fork":false,"url":"https://api.github.com/repos/parse-community/Parse-SDK-Android","forks_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/forks","keys_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/teams","hooks_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/events","assignees_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/tags","blobs_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/subscription","commits_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/merges","archive_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/downloads","issues_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/parse-community/Parse-SDK-Android/deployments","created_at":"2015-08-12T22:57:48Z","updated_at":"2018-04-08T09:06:25Z","pushed_at":"2018-04-12T07:28:45Z","git_url":"git://github.com/parse-community/Parse-SDK-Android.git","ssh_url":"git@github.com:parse-community/Parse-SDK-Android.git","clone_url":"https://github.com/parse-community/Parse-SDK-Android.git","svn_url":"https://github.com/parse-community/Parse-SDK-Android","homepage":"http://docs.parseplatform.org/android/guide/","size":1415,"stargazers_count":1471,"watchers_count":1471,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":634,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":634,"open_issues":93,"watchers":1471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800"},"html":{"href":"https://github.com/parse-community/Parse-SDK-Android/pull/800"},"issue":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/800"},"comments":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/parse-community/Parse-SDK-Android/statuses/abd132486aef38dd9344545e5544bde3f45195e0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Jawnnypoo"}}