{"action":"created","comment":{"url":"https://api.github.com/repos/grails/grails-core/pulls/comments/166892475","pull_request_review_id":95024283,"id":166892475,"diff_hunk":"@@ -91,6 +91,13 @@ class ResponseRedirector {\n             absolute = (absoluteArgument == null) ? true : (Boolean.TRUE == absoluteArgument)\n         }\n \n+        // When redirecting from UrlMappings the original request params are on webRequest.originalParams\n+        // instead of arguments.params\n+        def webRequest = GrailsWebRequest.lookup()","path":"grails-web-url-mappings/src/main/groovy/grails/web/mapping/ResponseRedirector.groovy","position":6,"original_position":6,"commit_id":"c815fea8d51e5a84facead01b4636264372c0398","original_commit_id":"c815fea8d51e5a84facead01b4636264372c0398","user":{"login":"graemerocher","id":66626,"avatar_url":"https://avatars2.githubusercontent.com/u/66626?v=4","gravatar_id":"","url":"https://api.github.com/users/graemerocher","html_url":"https://github.com/graemerocher","followers_url":"https://api.github.com/users/graemerocher/followers","following_url":"https://api.github.com/users/graemerocher/following{/other_user}","gists_url":"https://api.github.com/users/graemerocher/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerocher/subscriptions","organizations_url":"https://api.github.com/users/graemerocher/orgs","repos_url":"https://api.github.com/users/graemerocher/repos","events_url":"https://api.github.com/users/graemerocher/events{/privacy}","received_events_url":"https://api.github.com/users/graemerocher/received_events","type":"User","site_admin":false},"body":"Could you change this to `lookup(HttpServletRequest request)` instead as it will be more efficient and avoid the thread local lookup","created_at":"2018-02-08T10:35:50Z","updated_at":"2018-02-08T10:35:51Z","html_url":"https://github.com/grails/grails-core/pull/10926#discussion_r166892475","pull_request_url":"https://api.github.com/repos/grails/grails-core/pulls/10926","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/grails/grails-core/pulls/comments/166892475"},"html":{"href":"https://github.com/grails/grails-core/pull/10926#discussion_r166892475"},"pull_request":{"href":"https://api.github.com/repos/grails/grails-core/pulls/10926"}}},"pull_request":{"url":"https://api.github.com/repos/grails/grails-core/pulls/10926","id":167430987,"html_url":"https://github.com/grails/grails-core/pull/10926","diff_url":"https://github.com/grails/grails-core/pull/10926.diff","patch_url":"https://github.com/grails/grails-core/pull/10926.patch","issue_url":"https://api.github.com/repos/grails/grails-core/issues/10926","number":10926,"state":"open","locked":false,"title":"Keep request parameters when doing a redirect defined in UrlMappings","user":{"login":"ilopmar","id":559192,"avatar_url":"https://avatars3.githubusercontent.com/u/559192?v=4","gravatar_id":"","url":"https://api.github.com/users/ilopmar","html_url":"https://github.com/ilopmar","followers_url":"https://api.github.com/users/ilopmar/followers","following_url":"https://api.github.com/users/ilopmar/following{/other_user}","gists_url":"https://api.github.com/users/ilopmar/gists{/gist_id}","starred_url":"https://api.github.com/users/ilopmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilopmar/subscriptions","organizations_url":"https://api.github.com/users/ilopmar/orgs","repos_url":"https://api.github.com/users/ilopmar/repos","events_url":"https://api.github.com/users/ilopmar/events{/privacy}","received_events_url":"https://api.github.com/users/ilopmar/received_events","type":"User","site_admin":false},"body":"Closes #10622 ","created_at":"2018-02-06T14:37:20Z","updated_at":"2018-02-08T10:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb01c49431276d43a22d3cc860a706cbf7de1767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/grails/grails-core/pulls/10926/commits","review_comments_url":"https://api.github.com/repos/grails/grails-core/pulls/10926/comments","review_comment_url":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grails/grails-core/issues/10926/comments","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/c815fea8d51e5a84facead01b4636264372c0398","head":{"label":"grails:issue-10622","ref":"issue-10622","sha":"c815fea8d51e5a84facead01b4636264372c0398","user":{"login":"grails","id":64546,"avatar_url":"https://avatars3.githubusercontent.com/u/64546?v=4","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"repo":{"id":512295,"name":"grails-core","full_name":"grails/grails-core","owner":{"login":"grails","id":64546,"avatar_url":"https://avatars3.githubusercontent.com/u/64546?v=4","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails/grails-core","description":"The Grails Web Application Framework","fork":false,"url":"https://api.github.com/repos/grails/grails-core","forks_url":"https://api.github.com/repos/grails/grails-core/forks","keys_url":"https://api.github.com/repos/grails/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails/grails-core/teams","hooks_url":"https://api.github.com/repos/grails/grails-core/hooks","issue_events_url":"https://api.github.com/repos/grails/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails/grails-core/events","assignees_url":"https://api.github.com/repos/grails/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails/grails-core/tags","blobs_url":"https://api.github.com/repos/grails/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails/grails-core/languages","stargazers_url":"https://api.github.com/repos/grails/grails-core/stargazers","contributors_url":"https://api.github.com/repos/grails/grails-core/contributors","subscribers_url":"https://api.github.com/repos/grails/grails-core/subscribers","subscription_url":"https://api.github.com/repos/grails/grails-core/subscription","commits_url":"https://api.github.com/repos/grails/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails/grails-core/merges","archive_url":"https://api.github.com/repos/grails/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails/grails-core/downloads","issues_url":"https://api.github.com/repos/grails/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/grails/grails-core/releases{/id}","deployments_url":"https://api.github.com/repos/grails/grails-core/deployments","created_at":"2010-02-10T23:57:57Z","updated_at":"2018-02-07T19:55:49Z","pushed_at":"2018-02-06T16:20:13Z","git_url":"git://github.com/grails/grails-core.git","ssh_url":"git@github.com:grails/grails-core.git","clone_url":"https://github.com/grails/grails-core.git","svn_url":"https://github.com/grails/grails-core","homepage":"http://grails.org","size":350644,"stargazers_count":2287,"watchers_count":2287,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":918,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":918,"open_issues":182,"watchers":2287,"default_branch":"master"}},"base":{"label":"grails:3.3.x","ref":"3.3.x","sha":"8518e24d906b854b80b93e64f7fb5333fc02556d","user":{"login":"grails","id":64546,"avatar_url":"https://avatars3.githubusercontent.com/u/64546?v=4","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"repo":{"id":512295,"name":"grails-core","full_name":"grails/grails-core","owner":{"login":"grails","id":64546,"avatar_url":"https://avatars3.githubusercontent.com/u/64546?v=4","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails/grails-core","description":"The Grails Web Application Framework","fork":false,"url":"https://api.github.com/repos/grails/grails-core","forks_url":"https://api.github.com/repos/grails/grails-core/forks","keys_url":"https://api.github.com/repos/grails/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails/grails-core/teams","hooks_url":"https://api.github.com/repos/grails/grails-core/hooks","issue_events_url":"https://api.github.com/repos/grails/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails/grails-core/events","assignees_url":"https://api.github.com/repos/grails/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails/grails-core/tags","blobs_url":"https://api.github.com/repos/grails/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails/grails-core/languages","stargazers_url":"https://api.github.com/repos/grails/grails-core/stargazers","contributors_url":"https://api.github.com/repos/grails/grails-core/contributors","subscribers_url":"https://api.github.com/repos/grails/grails-core/subscribers","subscription_url":"https://api.github.com/repos/grails/grails-core/subscription","commits_url":"https://api.github.com/repos/grails/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails/grails-core/merges","archive_url":"https://api.github.com/repos/grails/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails/grails-core/downloads","issues_url":"https://api.github.com/repos/grails/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/grails/grails-core/releases{/id}","deployments_url":"https://api.github.com/repos/grails/grails-core/deployments","created_at":"2010-02-10T23:57:57Z","updated_at":"2018-02-07T19:55:49Z","pushed_at":"2018-02-06T16:20:13Z","git_url":"git://github.com/grails/grails-core.git","ssh_url":"git@github.com:grails/grails-core.git","clone_url":"https://github.com/grails/grails-core.git","svn_url":"https://github.com/grails/grails-core","homepage":"http://grails.org","size":350644,"stargazers_count":2287,"watchers_count":2287,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":918,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":918,"open_issues":182,"watchers":2287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grails/grails-core/pulls/10926"},"html":{"href":"https://github.com/grails/grails-core/pull/10926"},"issue":{"href":"https://api.github.com/repos/grails/grails-core/issues/10926"},"comments":{"href":"https://api.github.com/repos/grails/grails-core/issues/10926/comments"},"review_comments":{"href":"https://api.github.com/repos/grails/grails-core/pulls/10926/comments"},"review_comment":{"href":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grails/grails-core/pulls/10926/commits"},"statuses":{"href":"https://api.github.com/repos/grails/grails-core/statuses/c815fea8d51e5a84facead01b4636264372c0398"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"graemerocher"}}