{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/196395693","pull_request_review_id":129937416,"id":196395693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjM5NTY5Mw==","diff_hunk":"@@ -36,7 +36,7 @@ $(TARBALLS_LOCATION)/$(ARCHIVE):\n $(PLATFORM): $(TARBALLS_LOCATION)/$(ARCHIVE) $(DEPS)\n ifeq ($(PREFIX),)\n \t@echo\n-\t@echo \"ERROR: please set PREFIX to the kodi install path e.g. make PREFIX=/usr/local\"\n+\t@echo \"ERROR: please set PREFIX to the kodi install path e.g. $(MAKE) PREFIX=/usr/local\"","path":"tools/depends/target/rapidjson/Makefile","position":5,"original_position":5,"commit_id":"5bfd75e6ff533e0d10b979cc2ebf8a5db379a0bf","original_commit_id":"5bfd75e6ff533e0d10b979cc2ebf8a5db379a0bf","user":{"login":"wsnipex","id":909455,"node_id":"MDQ6VXNlcjkwOTQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/909455?v=4","gravatar_id":"","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"body":"it that works, it's perfectly fine, just wasn't 100% sure it works as expected in echo lines","created_at":"2018-06-19T12:04:43Z","updated_at":"2018-06-19T12:04:43Z","html_url":"https://github.com/xbmc/xbmc/pull/14080#discussion_r196395693","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14080","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/196395693"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14080#discussion_r196395693"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14080"}},"in_reply_to_id":196395061},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14080","id":195742737,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzQyNzM3","html_url":"https://github.com/xbmc/xbmc/pull/14080","diff_url":"https://github.com/xbmc/xbmc/pull/14080.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14080.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14080","number":14080,"state":"open","locked":false,"title":"[depends] use MAKE variable instead of make command","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"body":"## Description\r\nfixes building binary addons on FreeBSD, by using gmake for getting supported_addons too\r\n\r\n## Motivation and Context\r\nstop @hudokkow telling building binary addons is broken, even if it is unrelated to the current way of building them\r\n\r\n## How Has This Been Tested?\r\nbuild binary addons on FreeBSD and Linux with `(g)make -C tools/depends/target/binary-addons PREFIX=<...>`\r\n\r\n## Types of change\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n","created_at":"2018-06-19T08:06:46Z","updated_at":"2018-06-19T12:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1ee3085950fe2d521716a4403c85380d1d94871","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":777642478,"node_id":"MDU6TGFiZWw3Nzc2NDI0Nzg=","url":"https://api.github.com/repos/xbmc/xbmc/labels/BSD","name":"BSD","color":"ef8307","default":false},{"id":1659186,"node_id":"MDU6TGFiZWwxNjU5MTg2","url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1","default":false},{"id":400751192,"node_id":"MDU6TGFiZWw0MDA3NTExOTI=","url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14080/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/14080/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14080/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/5bfd75e6ff533e0d10b979cc2ebf8a5db379a0bf","head":{"label":"Rechi:depends/fixMakeVariable","ref":"depends/fixMakeVariable","sha":"5bfd75e6ff533e0d10b979cc2ebf8a5db379a0bf","user":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"repo":{"id":31212951,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxMjk1MQ==","name":"xbmc","full_name":"Rechi/xbmc","owner":{"login":"Rechi","id":5367567,"node_id":"MDQ6VXNlcjUzNjc1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5367567?v=4","gravatar_id":"","url":"https://api.github.com/users/Rechi","html_url":"https://github.com/Rechi","followers_url":"https://api.github.com/users/Rechi/followers","following_url":"https://api.github.com/users/Rechi/following{/other_user}","gists_url":"https://api.github.com/users/Rechi/gists{/gist_id}","starred_url":"https://api.github.com/users/Rechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rechi/subscriptions","organizations_url":"https://api.github.com/users/Rechi/orgs","repos_url":"https://api.github.com/users/Rechi/repos","events_url":"https://api.github.com/users/Rechi/events{/privacy}","received_events_url":"https://api.github.com/users/Rechi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rechi/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/Rechi/xbmc","forks_url":"https://api.github.com/repos/Rechi/xbmc/forks","keys_url":"https://api.github.com/repos/Rechi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rechi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rechi/xbmc/teams","hooks_url":"https://api.github.com/repos/Rechi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Rechi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Rechi/xbmc/events","assignees_url":"https://api.github.com/repos/Rechi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Rechi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Rechi/xbmc/tags","blobs_url":"https://api.github.com/repos/Rechi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rechi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rechi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rechi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rechi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Rechi/xbmc/languages","stargazers_url":"https://api.github.com/repos/Rechi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Rechi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Rechi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Rechi/xbmc/subscription","commits_url":"https://api.github.com/repos/Rechi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rechi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rechi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rechi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rechi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Rechi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rechi/xbmc/merges","archive_url":"https://api.github.com/repos/Rechi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rechi/xbmc/downloads","issues_url":"https://api.github.com/repos/Rechi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Rechi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Rechi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Rechi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rechi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Rechi/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/Rechi/xbmc/deployments","created_at":"2015-02-23T15:03:56Z","updated_at":"2018-06-19T07:49:51Z","pushed_at":"2018-06-19T12:00:15Z","git_url":"git://github.com/Rechi/xbmc.git","ssh_url":"git@github.com:Rechi/xbmc.git","clone_url":"https://github.com/Rechi/xbmc.git","svn_url":"https://github.com/Rechi/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":597661,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"cde85331c57b85a0ba97befe6092236bbc2a8aab","user":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NjE0","name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2018-06-19T11:27:36Z","pushed_at":"2018-06-19T12:01:42Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1449178,"stargazers_count":7113,"watchers_count":7113,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4650,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":4650,"open_issues":140,"watchers":7113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14080"},"html":{"href":"https://github.com/xbmc/xbmc/pull/14080"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14080"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/14080/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14080/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/14080/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/5bfd75e6ff533e0d10b979cc2ebf8a5db379a0bf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wsnipex"}}