{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/platform/pulls/comments/239861755","pull_request_review_id":182760740,"id":239861755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg2MTc1NQ==","diff_hunk":"@@ -570,10 +701,10 @@ func (c *SeriesPartitionCompactor) Compact(p *SeriesPartition) error {\n \t\t}\n \t\treturn nil\n \t}(); err != nil {\n-\t\treturn err\n+\t\treturn 0, err\n \t}\n \n-\treturn nil\n+\treturn duration, nil","path":"tsdb/series_partition.go","position":301,"original_position":301,"commit_id":"b015757c06f9897e4a4ca8f74c862bf17b92b3a2","original_commit_id":"b015757c06f9897e4a4ca8f74c862bf17b92b3a2","user":{"login":"jacobmarble","id":622263,"node_id":"MDQ6VXNlcjYyMjI2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/622263?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobmarble","html_url":"https://github.com/jacobmarble","followers_url":"https://api.github.com/users/jacobmarble/followers","following_url":"https://api.github.com/users/jacobmarble/following{/other_user}","gists_url":"https://api.github.com/users/jacobmarble/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobmarble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobmarble/subscriptions","organizations_url":"https://api.github.com/users/jacobmarble/orgs","repos_url":"https://api.github.com/users/jacobmarble/repos","events_url":"https://api.github.com/users/jacobmarble/events{/privacy}","received_events_url":"https://api.github.com/users/jacobmarble/received_events","type":"User","site_admin":false},"body":"Love this.","created_at":"2018-12-07T16:12:41Z","updated_at":"2018-12-07T16:31:44Z","html_url":"https://github.com/influxdata/platform/pull/1623#discussion_r239861755","pull_request_url":"https://api.github.com/repos/influxdata/platform/pulls/1623","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments/239861755"},"html":{"href":"https://github.com/influxdata/platform/pull/1623#discussion_r239861755"},"pull_request":{"href":"https://api.github.com/repos/influxdata/platform/pulls/1623"}}},"pull_request":{"url":"https://api.github.com/repos/influxdata/platform/pulls/1623","id":234682808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjgyODA4","html_url":"https://github.com/influxdata/platform/pull/1623","diff_url":"https://github.com/influxdata/platform/pull/1623.diff","patch_url":"https://github.com/influxdata/platform/pull/1623.patch","issue_url":"https://api.github.com/repos/influxdata/platform/issues/1623","number":1623,"state":"open","locked":false,"title":"Add storage engine metrics","user":{"login":"e-dard","id":501993,"node_id":"MDQ6VXNlcjUwMTk5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/501993?v=4","gravatar_id":"","url":"https://api.github.com/users/e-dard","html_url":"https://github.com/e-dard","followers_url":"https://api.github.com/users/e-dard/followers","following_url":"https://api.github.com/users/e-dard/following{/other_user}","gists_url":"https://api.github.com/users/e-dard/gists{/gist_id}","starred_url":"https://api.github.com/users/e-dard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-dard/subscriptions","organizations_url":"https://api.github.com/users/e-dard/orgs","repos_url":"https://api.github.com/users/e-dard/repos","events_url":"https://api.github.com/users/e-dard/events{/privacy}","received_events_url":"https://api.github.com/users/e-dard/received_events","type":"User","site_admin":false},"body":"  - [ ] CHANGELOG.md updated with a link to the PR (not the Issue)\r\n  - [ ] Rebased/mergeable\r\n  - [ ] Tests pass\r\n  - [ ] swagger.json updated (if modified Go structs or API)\r\n  - [ ] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\r\n\r\nCloses #885\r\n\r\n_Briefly describe your proposed changes:_\r\n\r\n_What was the problem?_\r\nWe didn't have any prometheus metrics for the storage engine, series file or index.\r\n\r\n_What was the solution?_\r\n\r\nThis PR adds prometheus metrics for the following areas:\r\n\r\n**Compactions**\r\n  - Number of compactions by level;\r\n  - Compactions currently actively;\r\n  - Histogram of compaction durations by level;\r\n  - Compactions currently queued up.\r\n\r\n**TSM Files**\r\n  - Number of bytes TSM files using on disk;\r\n  - Number of TSM files.\r\n\r\n**TSM Cache**\r\n  - Heap size;\r\n  - On disk size (snapshot file);\r\n  - Number of active snapshote (can be greater than 1 for big caches);\r\n  - Time since we last snapshotted cache;\r\n  - Total number of bytes snapshotted;\r\n  - Total number of bytes written to the cache;\r\n  - Number of write calls on the cache.\r\n\r\n**WAL**\r\n  - Number of bytes in old segments (full WAL files);\r\n  - Number of bytes in the current active segment file;\r\n  - Number of segment files;\r\n  - Total number of write calls to the WAL.\r\n\r\n**Series File**\r\n  All metrics are by partition.\r\n  - Created series;\r\n  - Total series;\r\n  - Disk size of series files;\r\n  - Number of segment files in series file;\r\n  - Active series index compactions; \r\n  - Histogram of series index compaction times;\r\n  - Total number of series index compactions.\r\n  - Load factor on series index hashmap;\r\n  - Size in bytes of series index hashmap; \r\n  - Histogram of GET durations for series index hashmap (sampled 1 in 10 calls);\r\n  - Last GET duration for series index hashmap (sampled 1 in 10 calls);\r\n  - Histogram of PUT durations for series index hashmap (sampled 1 in 10 calls);\r\n  - Last PUT duration for series index hashmap (sampled 1 in 10 calls);\r\n  - Last hashmap grow duration for series index hashmap;\r\n  - Total number of GETs from the series index hashmap (broken out by hits and misses);\r\n  - Total number of PUTs to the series index hashmap (broken out by hits and misses).\r\n\r\n**TSI Tag Cache**\r\n  - Number of items (bitsets) in the cache;\r\n  - Number of GETs to the cache (broken out by hits and misses);\r\n  - Number of PUTs to the cache (broken out by hits and misses);\r\n  - Number of DELETEs on the cache;\r\n  - Number of EVICTIONs on the cache (it's an LRU cache).\r\n\r\n**TSI Index**\r\nAll metrics are by partition.\r\n  - Created series;\r\n  - Histogram of single series creation time (nanoseconds);\r\n  - Series removed;\r\n  - Total series;\r\n  - Total number of files (broken out by index files and log files);\r\n  - Disk size in bytes;\r\n  - Number of active TSI compactions (broken out by level);\r\n  - Histogram of compaction duration (broken out by level);\r\n  - Total number of compactions (broken out by level).\r\n","created_at":"2018-11-29T15:36:09Z","updated_at":"2018-12-07T16:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176c945bdc2f184882308ef4ac55ce1819e7f4ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zeebo","id":96925,"node_id":"MDQ6VXNlcjk2OTI1","avatar_url":"https://avatars2.githubusercontent.com/u/96925?v=4","gravatar_id":"","url":"https://api.github.com/users/zeebo","html_url":"https://github.com/zeebo","followers_url":"https://api.github.com/users/zeebo/followers","following_url":"https://api.github.com/users/zeebo/following{/other_user}","gists_url":"https://api.github.com/users/zeebo/gists{/gist_id}","starred_url":"https://api.github.com/users/zeebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeebo/subscriptions","organizations_url":"https://api.github.com/users/zeebo/orgs","repos_url":"https://api.github.com/users/zeebo/repos","events_url":"https://api.github.com/users/zeebo/events{/privacy}","received_events_url":"https://api.github.com/users/zeebo/received_events","type":"User","site_admin":false},{"login":"benbjohnson","id":118015,"node_id":"MDQ6VXNlcjExODAxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/118015?v=4","gravatar_id":"","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/platform/pulls/1623/commits","review_comments_url":"https://api.github.com/repos/influxdata/platform/pulls/1623/comments","review_comment_url":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/platform/issues/1623/comments","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/b015757c06f9897e4a4ca8f74c862bf17b92b3a2","head":{"label":"influxdata:er-storage-metrics","ref":"er-storage-metrics","sha":"b015757c06f9897e4a4ca8f74c862bf17b92b3a2","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","private":false,"owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-12-07T00:39:06Z","pushed_at":"2018-12-07T15:10:05Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":37282,"stargazers_count":182,"watchers_count":182,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":464,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":464,"watchers":182,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"8d546ff6893cee8b0c919524b3ca5a3edca5d7d5","user":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":132783164,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODMxNjQ=","name":"platform","full_name":"influxdata/platform","private":false,"owner":{"login":"influxdata","id":5713248,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MTMyNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/influxdata/platform","description":"InfluxDB 2.0: The community version of the InfluxData Platform for Time Series","fork":false,"url":"https://api.github.com/repos/influxdata/platform","forks_url":"https://api.github.com/repos/influxdata/platform/forks","keys_url":"https://api.github.com/repos/influxdata/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/platform/teams","hooks_url":"https://api.github.com/repos/influxdata/platform/hooks","issue_events_url":"https://api.github.com/repos/influxdata/platform/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/platform/events","assignees_url":"https://api.github.com/repos/influxdata/platform/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/platform/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/platform/tags","blobs_url":"https://api.github.com/repos/influxdata/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/platform/languages","stargazers_url":"https://api.github.com/repos/influxdata/platform/stargazers","contributors_url":"https://api.github.com/repos/influxdata/platform/contributors","subscribers_url":"https://api.github.com/repos/influxdata/platform/subscribers","subscription_url":"https://api.github.com/repos/influxdata/platform/subscription","commits_url":"https://api.github.com/repos/influxdata/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/platform/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/platform/merges","archive_url":"https://api.github.com/repos/influxdata/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/platform/downloads","issues_url":"https://api.github.com/repos/influxdata/platform/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/platform/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/platform/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/platform/deployments","created_at":"2018-05-09T16:17:29Z","updated_at":"2018-12-07T00:39:06Z","pushed_at":"2018-12-07T15:10:05Z","git_url":"git://github.com/influxdata/platform.git","ssh_url":"git@github.com:influxdata/platform.git","clone_url":"https://github.com/influxdata/platform.git","svn_url":"https://github.com/influxdata/platform","homepage":"","size":37282,"stargazers_count":182,"watchers_count":182,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":464,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":464,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/platform/pulls/1623"},"html":{"href":"https://github.com/influxdata/platform/pull/1623"},"issue":{"href":"https://api.github.com/repos/influxdata/platform/issues/1623"},"comments":{"href":"https://api.github.com/repos/influxdata/platform/issues/1623/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/platform/pulls/1623/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/platform/pulls/1623/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/platform/statuses/b015757c06f9897e4a4ca8f74c862bf17b92b3a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jacobmarble"}}