{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/flow/issues/4916","repository_url":"https://api.github.com/repos/facebook/flow","labels_url":"https://api.github.com/repos/facebook/flow/issues/4916/labels{/name}","comments_url":"https://api.github.com/repos/facebook/flow/issues/4916/comments","events_url":"https://api.github.com/repos/facebook/flow/issues/4916/events","html_url":"https://github.com/facebook/flow/pull/4916","id":258638973,"number":4916,"title":"Add silence support.","user":{"login":"LegNeato","id":368904,"avatar_url":"https://avatars0.githubusercontent.com/u/368904?v=4","gravatar_id":"","url":"https://api.github.com/users/LegNeato","html_url":"https://github.com/LegNeato","followers_url":"https://api.github.com/users/LegNeato/followers","following_url":"https://api.github.com/users/LegNeato/following{/other_user}","gists_url":"https://api.github.com/users/LegNeato/gists{/gist_id}","starred_url":"https://api.github.com/users/LegNeato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LegNeato/subscriptions","organizations_url":"https://api.github.com/users/LegNeato/orgs","repos_url":"https://api.github.com/users/LegNeato/repos","events_url":"https://api.github.com/users/LegNeato/events{/privacy}","received_events_url":"https://api.github.com/users/LegNeato/received_events","type":"User","site_admin":false},"labels":[{"id":196859323,"url":"https://api.github.com/repos/facebook/flow/labels/CLA%20Signed","name":"CLA Signed","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2017-09-18T22:21:07Z","updated_at":"2018-04-20T07:45:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/flow/pulls/4916","html_url":"https://github.com/facebook/flow/pull/4916","diff_url":"https://github.com/facebook/flow/pull/4916.diff","patch_url":"https://github.com/facebook/flow/pull/4916.patch"},"body":"With this patch there is a new section in `.flowconfig`:\r\n\r\n```ini\r\n[silence]\r\n/path/to/file.js\r\n/path/to/dir\r\n```\r\n\r\nPaths in `[silence]` will still be typechecked, but any\r\nerrors will be silenced as if there was a `suppress_comment` comment string\r\non every line where there are errors.\r\n\r\nI called it `silence` to make it stand out from `ignore` and `suppress_comment` as\r\nit currently silences all errors, including lints.\r\n\r\nI believe this fixes https://github.com/facebook/flow/issues/869, though I admit I didn't read\r\nthe whole issue.\r\n\r\n(If this is accepted I'll add docs in a follow-up)."},"comment":{"url":"https://api.github.com/repos/facebook/flow/issues/comments/383012099","html_url":"https://github.com/facebook/flow/pull/4916#issuecomment-383012099","issue_url":"https://api.github.com/repos/facebook/flow/issues/4916","id":383012099,"user":{"login":"yleflour","id":1863461,"avatar_url":"https://avatars0.githubusercontent.com/u/1863461?v=4","gravatar_id":"","url":"https://api.github.com/users/yleflour","html_url":"https://github.com/yleflour","followers_url":"https://api.github.com/users/yleflour/followers","following_url":"https://api.github.com/users/yleflour/following{/other_user}","gists_url":"https://api.github.com/users/yleflour/gists{/gist_id}","starred_url":"https://api.github.com/users/yleflour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yleflour/subscriptions","organizations_url":"https://api.github.com/users/yleflour/orgs","repos_url":"https://api.github.com/users/yleflour/repos","events_url":"https://api.github.com/users/yleflour/events{/privacy}","received_events_url":"https://api.github.com/users/yleflour/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T07:45:10Z","updated_at":"2018-04-20T07:45:10Z","author_association":"NONE","body":"> How many weeks will I keep checking back for this before I give up on flow and just recommend typescript to my team? I'm starting to wonder. @jlaustill \r\n\r\nThe transition is already starting for our teams. New projects are getting Typescript support from now on. Our decision is motivated by 2 reasons:\r\n\r\n- node_modules which can't be silenced\r\n- Too many breaking changes (which makes silencing node_modules all the more important)\r\n\r\nI've been watching this PR for > 6 months and the discussion seems to be going nowhere. I just don't understand why there are backlashes against this feature. A lot of people seem to need it and it wouldn't introduce breaking changes as it's a new config option."}}
{"actor":{"display_login":"yleflour"}}