{"action":"created","comment":{"url":"https://api.github.com/repos/aicis/fresco/pulls/comments/188849201","pull_request_review_id":120906900,"id":188849201,"diff_hunk":"@@ -0,0 +1,71 @@\n+package dk.alexandra.fresco.framework.configuration;\n+\n+import dk.alexandra.fresco.framework.Party;\n+import java.io.IOException;\n+import java.net.ServerSocket;\n+import java.util.ArrayList;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.stream.Collectors;\n+\n+/**\n+ * Network-related functionality such as creating valid network configurations and finding free\n+ * ports.\n+ */\n+public class NetworkTestUtils {\n+\n+  public static Map<Integer, NetworkConfiguration> getNetworkConfigurations(int n,\n+      List<Integer> ports) {\n+    Map<Integer, NetworkConfiguration> confs = new HashMap<>(n);\n+    for (int i = 0; i < n; i++) {\n+      Map<Integer, Party> partyMap = new HashMap<>();\n+      int id = 1;\n+      for (int port : ports) {","path":"core/src/test/java/dk/alexandra/fresco/framework/configuration/NetworkTestUtils.java","position":24,"original_position":24,"commit_id":"dbfd61317c0daf65148bed9e5567879aba5be63c","original_commit_id":"dbfd61317c0daf65148bed9e5567879aba5be63c","user":{"login":"GuutBoy","id":6916414,"avatar_url":"https://avatars0.githubusercontent.com/u/6916414?v=4","gravatar_id":"","url":"https://api.github.com/users/GuutBoy","html_url":"https://github.com/GuutBoy","followers_url":"https://api.github.com/users/GuutBoy/followers","following_url":"https://api.github.com/users/GuutBoy/following{/other_user}","gists_url":"https://api.github.com/users/GuutBoy/gists{/gist_id}","starred_url":"https://api.github.com/users/GuutBoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuutBoy/subscriptions","organizations_url":"https://api.github.com/users/GuutBoy/orgs","repos_url":"https://api.github.com/users/GuutBoy/repos","events_url":"https://api.github.com/users/GuutBoy/events{/privacy}","received_events_url":"https://api.github.com/users/GuutBoy/received_events","type":"User","site_admin":false},"body":"Is there a reason to re-compute this `partyMap` for each party?","created_at":"2018-05-17T06:22:45Z","updated_at":"2018-05-17T06:33:18Z","html_url":"https://github.com/aicis/fresco/pull/290#discussion_r188849201","pull_request_url":"https://api.github.com/repos/aicis/fresco/pulls/290","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments/188849201"},"html":{"href":"https://github.com/aicis/fresco/pull/290#discussion_r188849201"},"pull_request":{"href":"https://api.github.com/repos/aicis/fresco/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/aicis/fresco/pulls/290","id":188424526,"html_url":"https://github.com/aicis/fresco/pull/290","diff_url":"https://github.com/aicis/fresco/pull/290.diff","patch_url":"https://github.com/aicis/fresco/pull/290.patch","issue_url":"https://api.github.com/repos/aicis/fresco/issues/290","number":290,"state":"open","locked":false,"title":"289 find free ports","user":{"login":"n1v0lg","id":13320119,"avatar_url":"https://avatars3.githubusercontent.com/u/13320119?v=4","gravatar_id":"","url":"https://api.github.com/users/n1v0lg","html_url":"https://github.com/n1v0lg","followers_url":"https://api.github.com/users/n1v0lg/followers","following_url":"https://api.github.com/users/n1v0lg/following{/other_user}","gists_url":"https://api.github.com/users/n1v0lg/gists{/gist_id}","starred_url":"https://api.github.com/users/n1v0lg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n1v0lg/subscriptions","organizations_url":"https://api.github.com/users/n1v0lg/orgs","repos_url":"https://api.github.com/users/n1v0lg/repos","events_url":"https://api.github.com/users/n1v0lg/events{/privacy}","received_events_url":"https://api.github.com/users/n1v0lg/received_events","type":"User","site_admin":false},"body":"Addresses issue #289 by ensuring that getFreePorts returns unique port numbers. Also adds some sanity checks to NetworkConfiguration.","created_at":"2018-05-16T13:00:55Z","updated_at":"2018-05-17T06:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f31ffbf6c29619479cbf09ebf020a6741351bfe1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aicis/fresco/pulls/290/commits","review_comments_url":"https://api.github.com/repos/aicis/fresco/pulls/290/comments","review_comment_url":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aicis/fresco/issues/290/comments","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/dbfd61317c0daf65148bed9e5567879aba5be63c","head":{"label":"aicis:289-find-free-ports","ref":"289-find-free-ports","sha":"dbfd61317c0daf65148bed9e5567879aba5be63c","user":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"name":"fresco","full_name":"aicis/fresco","owner":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-05-15T20:18:33Z","pushed_at":"2018-05-16T13:58:58Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":15847,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":16,"open_issues":26,"watchers":32,"default_branch":"master"}},"base":{"label":"aicis:master","ref":"master","sha":"3fc19c3f20a70f2f8b484bf6551c161cebd9539e","user":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"repo":{"id":46789213,"name":"fresco","full_name":"aicis/fresco","owner":{"login":"aicis","id":23210753,"avatar_url":"https://avatars1.githubusercontent.com/u/23210753?v=4","gravatar_id":"","url":"https://api.github.com/users/aicis","html_url":"https://github.com/aicis","followers_url":"https://api.github.com/users/aicis/followers","following_url":"https://api.github.com/users/aicis/following{/other_user}","gists_url":"https://api.github.com/users/aicis/gists{/gist_id}","starred_url":"https://api.github.com/users/aicis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aicis/subscriptions","organizations_url":"https://api.github.com/users/aicis/orgs","repos_url":"https://api.github.com/users/aicis/repos","events_url":"https://api.github.com/users/aicis/events{/privacy}","received_events_url":"https://api.github.com/users/aicis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aicis/fresco","description":"A FRamework for Efficient Secure COmputation","fork":false,"url":"https://api.github.com/repos/aicis/fresco","forks_url":"https://api.github.com/repos/aicis/fresco/forks","keys_url":"https://api.github.com/repos/aicis/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aicis/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aicis/fresco/teams","hooks_url":"https://api.github.com/repos/aicis/fresco/hooks","issue_events_url":"https://api.github.com/repos/aicis/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/aicis/fresco/events","assignees_url":"https://api.github.com/repos/aicis/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/aicis/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/aicis/fresco/tags","blobs_url":"https://api.github.com/repos/aicis/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aicis/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aicis/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/aicis/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aicis/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/aicis/fresco/languages","stargazers_url":"https://api.github.com/repos/aicis/fresco/stargazers","contributors_url":"https://api.github.com/repos/aicis/fresco/contributors","subscribers_url":"https://api.github.com/repos/aicis/fresco/subscribers","subscription_url":"https://api.github.com/repos/aicis/fresco/subscription","commits_url":"https://api.github.com/repos/aicis/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/aicis/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/aicis/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/aicis/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/aicis/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/aicis/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aicis/fresco/merges","archive_url":"https://api.github.com/repos/aicis/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aicis/fresco/downloads","issues_url":"https://api.github.com/repos/aicis/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/aicis/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/aicis/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/aicis/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aicis/fresco/labels{/name}","releases_url":"https://api.github.com/repos/aicis/fresco/releases{/id}","deployments_url":"https://api.github.com/repos/aicis/fresco/deployments","created_at":"2015-11-24T12:05:17Z","updated_at":"2018-05-15T20:18:33Z","pushed_at":"2018-05-16T13:58:58Z","git_url":"git://github.com/aicis/fresco.git","ssh_url":"git@github.com:aicis/fresco.git","clone_url":"https://github.com/aicis/fresco.git","svn_url":"https://github.com/aicis/fresco","homepage":null,"size":15847,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":16,"open_issues":26,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aicis/fresco/pulls/290"},"html":{"href":"https://github.com/aicis/fresco/pull/290"},"issue":{"href":"https://api.github.com/repos/aicis/fresco/issues/290"},"comments":{"href":"https://api.github.com/repos/aicis/fresco/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/aicis/fresco/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/aicis/fresco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aicis/fresco/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/aicis/fresco/statuses/dbfd61317c0daf65148bed9e5567879aba5be63c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"GuutBoy"}}