{"action":"created","comment":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/comments/211820254","pull_request_review_id":148322455,"id":211820254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTgyMDI1NA==","diff_hunk":"@@ -39,7 +39,6 @@ generateproto(){\n }\n \n main(){\n-    API_ROOT=\"${DIR}/cri/apis/v1alpha1\" YEAR_TIME=\" $(date '+%Y')\" generateproto","path":"hack/protoc.sh","position":4,"original_position":4,"commit_id":"b4c0678d3eab39f88115fa0834f7518dc8ca4ea5","original_commit_id":"b4c0678d3eab39f88115fa0834f7518dc8ca4ea5","user":{"login":"rudyfly","id":2264659,"node_id":"MDQ6VXNlcjIyNjQ2NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2264659?v=4","gravatar_id":"","url":"https://api.github.com/users/rudyfly","html_url":"https://github.com/rudyfly","followers_url":"https://api.github.com/users/rudyfly/followers","following_url":"https://api.github.com/users/rudyfly/following{/other_user}","gists_url":"https://api.github.com/users/rudyfly/gists{/gist_id}","starred_url":"https://api.github.com/users/rudyfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudyfly/subscriptions","organizations_url":"https://api.github.com/users/rudyfly/orgs","repos_url":"https://api.github.com/users/rudyfly/repos","events_url":"https://api.github.com/users/rudyfly/events{/privacy}","received_events_url":"https://api.github.com/users/rudyfly/received_events","type":"User","site_admin":false},"body":"Why delete it？","created_at":"2018-08-22T03:31:33Z","updated_at":"2018-08-22T03:32:47Z","html_url":"https://github.com/alibaba/pouch/pull/2124#discussion_r211820254","pull_request_url":"https://api.github.com/repos/alibaba/pouch/pulls/2124","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments/211820254"},"html":{"href":"https://github.com/alibaba/pouch/pull/2124#discussion_r211820254"},"pull_request":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2124"}}},"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/2124","id":209453030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDUzMDMw","html_url":"https://github.com/alibaba/pouch/pull/2124","diff_url":"https://github.com/alibaba/pouch/pull/2124.diff","patch_url":"https://github.com/alibaba/pouch/pull/2124.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/2124","number":2124,"state":"open","locked":false,"title":"feature: extend cri apis for remove volume","user":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Starnop <starnop@163.com>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nextend cri apis for remove volume\r\n+ PouchContainer CRI Manager provides an interface for removing volume.\r\n+ PouchContainer CRI Manager supports querying the name of volume by containerstatus.\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\nNone.\r\n\r\n### Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)\r\n\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\nuse cri-tools that has been modified：[starnop/cri-tools](https://github.com/Starnop/cri-tools/tree/test-remove-volume)\r\n```\r\n# pouch volume ls\r\nDRIVER   VOLUME NAME\r\nlocal    687a243f9aafb0264b491dc1128b2c842b45f420894d36671332d30862c76bc7\r\nlocal    c2ad62ff78afc55efe1d43649b9e77a780875bb348f2def8903ffefa3709f5b1\r\nlocal    d8d84f8709e4e0093feb72c78eb6921f7dc1c02d92e121b520fb697add44a6af\r\n\r\n# crictl rmv 687a243f9aafb0264b491dc1128b2c842b45f420894d36671332d30862c76bc7\r\nDEBU[0000] RemoveVolumeRequest: &RemoveVolumeRequest{VolumeName:687a243f9aafb0264b491dc1128b2c842b45f420894d36671332d30862c76bc7,} \r\nDEBU[0000] RemoveVolumeResponse: &RemoveVolumeResponse{} \r\n\r\n# pouch volume ls\r\nDRIVER   VOLUME NAME\r\nlocal    d8d84f8709e4e0093feb72c78eb6921f7dc1c02d92e121b520fb697add44a6af\r\nlocal    c2ad62ff78afc55efe1d43649b9e77a780875bb348f2def8903ffefa3709f5b1\r\n```\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-08-20T08:56:17Z","updated_at":"2018-08-22T03:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edf748ea04678dc4edb3f0047663337e10108abb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722338639,"node_id":"MDU6TGFiZWw3MjIzMzg2Mzk=","url":"https://api.github.com/repos/alibaba/pouch/labels/areas/storage","name":"areas/storage","color":"1d76db","default":false},{"id":722348097,"node_id":"MDU6TGFiZWw3MjIzNDgwOTc=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/feature","name":"kind/feature","color":"1d76db","default":false},{"id":722355711,"node_id":"MDU6TGFiZWw3MjIzNTU3MTE=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/XXL","name":"size/XXL","color":"cc3d73","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/2124/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/2124/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/2124/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/b4c0678d3eab39f88115fa0834f7518dc8ca4ea5","head":{"label":"Starnop:cri-extend-removeVolume","ref":"cri-extend-removeVolume","sha":"b4c0678d3eab39f88115fa0834f7518dc8ca4ea5","user":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"repo":{"id":128589385,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1ODkzODU=","name":"pouch","full_name":"Starnop/pouch","owner":{"login":"Starnop","id":31209634,"node_id":"MDQ6VXNlcjMxMjA5NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/31209634?v=4","gravatar_id":"","url":"https://api.github.com/users/Starnop","html_url":"https://github.com/Starnop","followers_url":"https://api.github.com/users/Starnop/followers","following_url":"https://api.github.com/users/Starnop/following{/other_user}","gists_url":"https://api.github.com/users/Starnop/gists{/gist_id}","starred_url":"https://api.github.com/users/Starnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starnop/subscriptions","organizations_url":"https://api.github.com/users/Starnop/orgs","repos_url":"https://api.github.com/users/Starnop/repos","events_url":"https://api.github.com/users/Starnop/events{/privacy}","received_events_url":"https://api.github.com/users/Starnop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Starnop/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/Starnop/pouch","forks_url":"https://api.github.com/repos/Starnop/pouch/forks","keys_url":"https://api.github.com/repos/Starnop/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starnop/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starnop/pouch/teams","hooks_url":"https://api.github.com/repos/Starnop/pouch/hooks","issue_events_url":"https://api.github.com/repos/Starnop/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/Starnop/pouch/events","assignees_url":"https://api.github.com/repos/Starnop/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/Starnop/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/Starnop/pouch/tags","blobs_url":"https://api.github.com/repos/Starnop/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starnop/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starnop/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starnop/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starnop/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/Starnop/pouch/languages","stargazers_url":"https://api.github.com/repos/Starnop/pouch/stargazers","contributors_url":"https://api.github.com/repos/Starnop/pouch/contributors","subscribers_url":"https://api.github.com/repos/Starnop/pouch/subscribers","subscription_url":"https://api.github.com/repos/Starnop/pouch/subscription","commits_url":"https://api.github.com/repos/Starnop/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starnop/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starnop/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starnop/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starnop/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/Starnop/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starnop/pouch/merges","archive_url":"https://api.github.com/repos/Starnop/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starnop/pouch/downloads","issues_url":"https://api.github.com/repos/Starnop/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/Starnop/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/Starnop/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/Starnop/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starnop/pouch/labels{/name}","releases_url":"https://api.github.com/repos/Starnop/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/Starnop/pouch/deployments","created_at":"2018-04-08T02:38:51Z","updated_at":"2018-08-22T02:03:02Z","pushed_at":"2018-08-22T03:29:36Z","git_url":"git://github.com/Starnop/pouch.git","ssh_url":"git@github.com:Starnop/pouch.git","clone_url":"https://github.com/Starnop/pouch.git","svn_url":"https://github.com/Starnop/pouch","homepage":"","size":19760,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"8eb612ed880ac93764eaed43132b5d751bf52c34","user":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NTU5NjU=","name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjE5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"An Efficient Enterprise-class Rich Container Engine","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-08-22T01:54:40Z","pushed_at":"2018-08-22T03:28:17Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"https://pouchcontainer.io","size":19558,"stargazers_count":3046,"watchers_count":3046,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":779,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":779,"open_issues":158,"watchers":3046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2124"},"html":{"href":"https://github.com/alibaba/pouch/pull/2124"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/2124"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/2124/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2124/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/2124/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/b4c0678d3eab39f88115fa0834f7518dc8ca4ea5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rudyfly"}}