{"action":"closed","number":127,"pull_request":{"url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127","id":116145070,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE2MTQ1MDcw","html_url":"https://github.com/alexdalitz/dnsruby/pull/127","diff_url":"https://github.com/alexdalitz/dnsruby/pull/127.diff","patch_url":"https://github.com/alexdalitz/dnsruby/pull/127.patch","issue_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/127","number":127,"state":"closed","locked":false,"title":"Updated rubydns gem used for testing","user":{"login":"nwitkowski","id":1732725,"node_id":"MDQ6VXNlcjE3MzI3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1732725?v=4","gravatar_id":"","url":"https://api.github.com/users/nwitkowski","html_url":"https://github.com/nwitkowski","followers_url":"https://api.github.com/users/nwitkowski/followers","following_url":"https://api.github.com/users/nwitkowski/following{/other_user}","gists_url":"https://api.github.com/users/nwitkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/nwitkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwitkowski/subscriptions","organizations_url":"https://api.github.com/users/nwitkowski/orgs","repos_url":"https://api.github.com/users/nwitkowski/repos","events_url":"https://api.github.com/users/nwitkowski/events{/privacy}","received_events_url":"https://api.github.com/users/nwitkowski/received_events","type":"User","site_admin":false},"body":"Using a local dns (based on rubydns as a separate process) during the soak test\r\n\r\nAll changes are under the test directory so it's minimal impact.\r\nThere was a bit a rework needed due to the rubydns update. The gem was split in 3 (async, async-dns, rubydns). I tried my best to use the new gems accordingly.\r\n\r\nThe local dns change should simplify soak testing. Everything is done internally in 2 different processes (localdns & ruby test process). The soak test instantiates a local dns and then kills it for every test in setup and teardown methods.","created_at":"2017-04-17T14:53:26Z","updated_at":"2018-07-11T14:12:23Z","closed_at":"2018-07-11T14:12:22Z","merged_at":null,"merge_commit_sha":"18fa190d2e28d99a9431231a4da416cacb988821","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127/commits","review_comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127/comments","review_comment_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/127/comments","statuses_url":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/45cc0e4d77f09ed69f4f3f473640ade30939524d","head":{"label":"nwitkowski:rubydns-test-update","ref":"rubydns-test-update","sha":"45cc0e4d77f09ed69f4f3f473640ade30939524d","user":{"login":"nwitkowski","id":1732725,"node_id":"MDQ6VXNlcjE3MzI3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1732725?v=4","gravatar_id":"","url":"https://api.github.com/users/nwitkowski","html_url":"https://github.com/nwitkowski","followers_url":"https://api.github.com/users/nwitkowski/followers","following_url":"https://api.github.com/users/nwitkowski/following{/other_user}","gists_url":"https://api.github.com/users/nwitkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/nwitkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwitkowski/subscriptions","organizations_url":"https://api.github.com/users/nwitkowski/orgs","repos_url":"https://api.github.com/users/nwitkowski/repos","events_url":"https://api.github.com/users/nwitkowski/events{/privacy}","received_events_url":"https://api.github.com/users/nwitkowski/received_events","type":"User","site_admin":false},"repo":{"id":31529656,"node_id":"MDEwOlJlcG9zaXRvcnkzMTUyOTY1Ng==","name":"dnsruby","full_name":"nwitkowski/dnsruby","owner":{"login":"nwitkowski","id":1732725,"node_id":"MDQ6VXNlcjE3MzI3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1732725?v=4","gravatar_id":"","url":"https://api.github.com/users/nwitkowski","html_url":"https://github.com/nwitkowski","followers_url":"https://api.github.com/users/nwitkowski/followers","following_url":"https://api.github.com/users/nwitkowski/following{/other_user}","gists_url":"https://api.github.com/users/nwitkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/nwitkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwitkowski/subscriptions","organizations_url":"https://api.github.com/users/nwitkowski/orgs","repos_url":"https://api.github.com/users/nwitkowski/repos","events_url":"https://api.github.com/users/nwitkowski/events{/privacy}","received_events_url":"https://api.github.com/users/nwitkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nwitkowski/dnsruby","description":"Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project","fork":true,"url":"https://api.github.com/repos/nwitkowski/dnsruby","forks_url":"https://api.github.com/repos/nwitkowski/dnsruby/forks","keys_url":"https://api.github.com/repos/nwitkowski/dnsruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwitkowski/dnsruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwitkowski/dnsruby/teams","hooks_url":"https://api.github.com/repos/nwitkowski/dnsruby/hooks","issue_events_url":"https://api.github.com/repos/nwitkowski/dnsruby/issues/events{/number}","events_url":"https://api.github.com/repos/nwitkowski/dnsruby/events","assignees_url":"https://api.github.com/repos/nwitkowski/dnsruby/assignees{/user}","branches_url":"https://api.github.com/repos/nwitkowski/dnsruby/branches{/branch}","tags_url":"https://api.github.com/repos/nwitkowski/dnsruby/tags","blobs_url":"https://api.github.com/repos/nwitkowski/dnsruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwitkowski/dnsruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwitkowski/dnsruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwitkowski/dnsruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwitkowski/dnsruby/statuses/{sha}","languages_url":"https://api.github.com/repos/nwitkowski/dnsruby/languages","stargazers_url":"https://api.github.com/repos/nwitkowski/dnsruby/stargazers","contributors_url":"https://api.github.com/repos/nwitkowski/dnsruby/contributors","subscribers_url":"https://api.github.com/repos/nwitkowski/dnsruby/subscribers","subscription_url":"https://api.github.com/repos/nwitkowski/dnsruby/subscription","commits_url":"https://api.github.com/repos/nwitkowski/dnsruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwitkowski/dnsruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwitkowski/dnsruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwitkowski/dnsruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwitkowski/dnsruby/contents/{+path}","compare_url":"https://api.github.com/repos/nwitkowski/dnsruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwitkowski/dnsruby/merges","archive_url":"https://api.github.com/repos/nwitkowski/dnsruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwitkowski/dnsruby/downloads","issues_url":"https://api.github.com/repos/nwitkowski/dnsruby/issues{/number}","pulls_url":"https://api.github.com/repos/nwitkowski/dnsruby/pulls{/number}","milestones_url":"https://api.github.com/repos/nwitkowski/dnsruby/milestones{/number}","notifications_url":"https://api.github.com/repos/nwitkowski/dnsruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwitkowski/dnsruby/labels{/name}","releases_url":"https://api.github.com/repos/nwitkowski/dnsruby/releases{/id}","deployments_url":"https://api.github.com/repos/nwitkowski/dnsruby/deployments","created_at":"2015-03-02T08:09:50Z","updated_at":"2016-10-18T19:56:22Z","pushed_at":"2018-04-16T12:47:01Z","git_url":"git://github.com/nwitkowski/dnsruby.git","ssh_url":"git@github.com:nwitkowski/dnsruby.git","clone_url":"https://github.com/nwitkowski/dnsruby.git","svn_url":"https://github.com/nwitkowski/dnsruby","homepage":"","size":1450,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexdalitz:master","ref":"master","sha":"8c573412e9cf7cf4b4e7c752b88cb63ef0345c63","user":{"login":"alexdalitz","id":7693018,"node_id":"MDQ6VXNlcjc2OTMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7693018?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdalitz","html_url":"https://github.com/alexdalitz","followers_url":"https://api.github.com/users/alexdalitz/followers","following_url":"https://api.github.com/users/alexdalitz/following{/other_user}","gists_url":"https://api.github.com/users/alexdalitz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdalitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdalitz/subscriptions","organizations_url":"https://api.github.com/users/alexdalitz/orgs","repos_url":"https://api.github.com/users/alexdalitz/repos","events_url":"https://api.github.com/users/alexdalitz/events{/privacy}","received_events_url":"https://api.github.com/users/alexdalitz/received_events","type":"User","site_admin":false},"repo":{"id":24405039,"node_id":"MDEwOlJlcG9zaXRvcnkyNDQwNTAzOQ==","name":"dnsruby","full_name":"alexdalitz/dnsruby","owner":{"login":"alexdalitz","id":7693018,"node_id":"MDQ6VXNlcjc2OTMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7693018?v=4","gravatar_id":"","url":"https://api.github.com/users/alexdalitz","html_url":"https://github.com/alexdalitz","followers_url":"https://api.github.com/users/alexdalitz/followers","following_url":"https://api.github.com/users/alexdalitz/following{/other_user}","gists_url":"https://api.github.com/users/alexdalitz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexdalitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexdalitz/subscriptions","organizations_url":"https://api.github.com/users/alexdalitz/orgs","repos_url":"https://api.github.com/users/alexdalitz/repos","events_url":"https://api.github.com/users/alexdalitz/events{/privacy}","received_events_url":"https://api.github.com/users/alexdalitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexdalitz/dnsruby","description":"Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project","fork":false,"url":"https://api.github.com/repos/alexdalitz/dnsruby","forks_url":"https://api.github.com/repos/alexdalitz/dnsruby/forks","keys_url":"https://api.github.com/repos/alexdalitz/dnsruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexdalitz/dnsruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexdalitz/dnsruby/teams","hooks_url":"https://api.github.com/repos/alexdalitz/dnsruby/hooks","issue_events_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/events{/number}","events_url":"https://api.github.com/repos/alexdalitz/dnsruby/events","assignees_url":"https://api.github.com/repos/alexdalitz/dnsruby/assignees{/user}","branches_url":"https://api.github.com/repos/alexdalitz/dnsruby/branches{/branch}","tags_url":"https://api.github.com/repos/alexdalitz/dnsruby/tags","blobs_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/{sha}","languages_url":"https://api.github.com/repos/alexdalitz/dnsruby/languages","stargazers_url":"https://api.github.com/repos/alexdalitz/dnsruby/stargazers","contributors_url":"https://api.github.com/repos/alexdalitz/dnsruby/contributors","subscribers_url":"https://api.github.com/repos/alexdalitz/dnsruby/subscribers","subscription_url":"https://api.github.com/repos/alexdalitz/dnsruby/subscription","commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexdalitz/dnsruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexdalitz/dnsruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexdalitz/dnsruby/contents/{+path}","compare_url":"https://api.github.com/repos/alexdalitz/dnsruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexdalitz/dnsruby/merges","archive_url":"https://api.github.com/repos/alexdalitz/dnsruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexdalitz/dnsruby/downloads","issues_url":"https://api.github.com/repos/alexdalitz/dnsruby/issues{/number}","pulls_url":"https://api.github.com/repos/alexdalitz/dnsruby/pulls{/number}","milestones_url":"https://api.github.com/repos/alexdalitz/dnsruby/milestones{/number}","notifications_url":"https://api.github.com/repos/alexdalitz/dnsruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexdalitz/dnsruby/labels{/name}","releases_url":"https://api.github.com/repos/alexdalitz/dnsruby/releases{/id}","deployments_url":"https://api.github.com/repos/alexdalitz/dnsruby/deployments","created_at":"2014-09-24T07:27:33Z","updated_at":"2018-07-11T14:10:19Z","pushed_at":"2018-07-11T14:10:18Z","git_url":"git://github.com/alexdalitz/dnsruby.git","ssh_url":"git@github.com:alexdalitz/dnsruby.git","clone_url":"https://github.com/alexdalitz/dnsruby.git","svn_url":"https://github.com/alexdalitz/dnsruby","homepage":"","size":1483,"stargazers_count":91,"watchers_count":91,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":44,"open_issues":0,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127"},"html":{"href":"https://github.com/alexdalitz/dnsruby/pull/127"},"issue":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/issues/127"},"comments":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/alexdalitz/dnsruby/statuses/45cc0e4d77f09ed69f4f3f473640ade30939524d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":3,"additions":192,"deletions":105,"changed_files":5}}
{"actor":{"display_login":"alexdalitz"}}