{"action":"created","comment":{"url":"https://api.github.com/repos/google/neuroglancer/pulls/comments/218908302","pull_request_review_id":156952553,"id":218908302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODkwODMwMg==","diff_hunk":"@@ -410,4 +415,54 @@ registerAnnotationTypeRenderHandler(AnnotationType.AXIS_ALIGNED_BOUNDING_BOX, {\n       // vec3.transformMat4(position, annotation.point, objectToData);\n     }\n   },\n+  getRepresentativePoint: (objectToData, ann, partIndex) => {\n+    let repPoint= vec3.create();\n+    // if the full object is selected pick the first corner as representative\n+    if (partIndex==FULL_OBJECT_PICK_OFFSET){\n+      vec3.transformMat4(repPoint, ann.pointA, objectToData);\n+    }\n+    else if (partIndex >= CORNERS_PICK_OFFSET && partIndex < EDGES_PICK_OFFSET) {\n+      // picked a corner\n+      // FIXME: figure out how to return corner point\n+      vec3.transformMat4(repPoint, ann.pointA, objectToData);\n+    } else if (partIndex >= EDGES_PICK_OFFSET && partIndex < FACES_PICK_OFFSET) {\n+      // FIXME: can't figure out how to resize based upon edge grabbed\n+      vec3.transformMat4(repPoint, ann.pointA, objectToData);\n+      // snapPositionToCorner(repPoint, objectToData, corners, 5);\n+    }\n+    else{ // for now faces will move the whole object so pick the first corner\n+      vec3.transformMat4(repPoint, ann.pointA, objectToData);\n+    }\n+    return repPoint\n+  }, \n+  updateViaRepresentativePoint: (oldAnnotation: AxisAlignedBoundingBox, position: vec3, dataToObject: mat4, partIndex: number) => {\n+    let newPt = vec3.transformMat4(vec3.create(), position, dataToObject);","path":"src/neuroglancer/annotation/bounding_box.ts","position":61,"original_position":61,"commit_id":"4d65dcd0227e1d13dc92be4b95097b49860c6968","original_commit_id":"4d65dcd0227e1d13dc92be4b95097b49860c6968","user":{"login":"fcollman","id":782341,"node_id":"MDQ6VXNlcjc4MjM0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/782341?v=4","gravatar_id":"","url":"https://api.github.com/users/fcollman","html_url":"https://github.com/fcollman","followers_url":"https://api.github.com/users/fcollman/followers","following_url":"https://api.github.com/users/fcollman/following{/other_user}","gists_url":"https://api.github.com/users/fcollman/gists{/gist_id}","starred_url":"https://api.github.com/users/fcollman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcollman/subscriptions","organizations_url":"https://api.github.com/users/fcollman/orgs","repos_url":"https://api.github.com/users/fcollman/repos","events_url":"https://api.github.com/users/fcollman/events{/privacy}","received_events_url":"https://api.github.com/users/fcollman/received_events","type":"User","site_admin":false},"body":"I thought you had said that the annotations should be atomic, so I thought the new annotation should get a new ID, and I thought that ID got assigned when i added the new annotation to the layer.  Is my thinking off?","created_at":"2018-09-19T18:09:14Z","updated_at":"2018-09-19T18:09:14Z","html_url":"https://github.com/google/neuroglancer/pull/100#discussion_r218908302","pull_request_url":"https://api.github.com/repos/google/neuroglancer/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/comments/218908302"},"html":{"href":"https://github.com/google/neuroglancer/pull/100#discussion_r218908302"},"pull_request":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/100"}},"in_reply_to_id":218867874},"pull_request":{"url":"https://api.github.com/repos/google/neuroglancer/pulls/100","id":212621916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjIxOTE2","html_url":"https://github.com/google/neuroglancer/pull/100","diff_url":"https://github.com/google/neuroglancer/pull/100.diff","patch_url":"https://github.com/google/neuroglancer/pull/100.patch","issue_url":"https://api.github.com/repos/google/neuroglancer/issues/100","number":100,"state":"open","locked":false,"title":"Moveable annotations","user":{"login":"fcollman","id":782341,"node_id":"MDQ6VXNlcjc4MjM0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/782341?v=4","gravatar_id":"","url":"https://api.github.com/users/fcollman","html_url":"https://github.com/fcollman","followers_url":"https://api.github.com/users/fcollman/followers","following_url":"https://api.github.com/users/fcollman/following{/other_user}","gists_url":"https://api.github.com/users/fcollman/gists{/gist_id}","starred_url":"https://api.github.com/users/fcollman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcollman/subscriptions","organizations_url":"https://api.github.com/users/fcollman/orgs","repos_url":"https://api.github.com/users/fcollman/repos","events_url":"https://api.github.com/users/fcollman/events{/privacy}","received_events_url":"https://api.github.com/users/fcollman/received_events","type":"User","site_admin":false},"body":"This PR allows the user to move annotations once they have been placed in both 2d slice views and 3d perspective views, presently via a alt+right mouse click drag. \r\n","created_at":"2018-09-03T01:14:33Z","updated_at":"2018-09-19T18:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e35d9c61601308bc65978812af263d628a5f0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/neuroglancer/pulls/100/commits","review_comments_url":"https://api.github.com/repos/google/neuroglancer/pulls/100/comments","review_comment_url":"https://api.github.com/repos/google/neuroglancer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/neuroglancer/issues/100/comments","statuses_url":"https://api.github.com/repos/google/neuroglancer/statuses/4d65dcd0227e1d13dc92be4b95097b49860c6968","head":{"label":"fcollman:movePointsAlt","ref":"movePointsAlt","sha":"4d65dcd0227e1d13dc92be4b95097b49860c6968","user":{"login":"fcollman","id":782341,"node_id":"MDQ6VXNlcjc4MjM0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/782341?v=4","gravatar_id":"","url":"https://api.github.com/users/fcollman","html_url":"https://github.com/fcollman","followers_url":"https://api.github.com/users/fcollman/followers","following_url":"https://api.github.com/users/fcollman/following{/other_user}","gists_url":"https://api.github.com/users/fcollman/gists{/gist_id}","starred_url":"https://api.github.com/users/fcollman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcollman/subscriptions","organizations_url":"https://api.github.com/users/fcollman/orgs","repos_url":"https://api.github.com/users/fcollman/repos","events_url":"https://api.github.com/users/fcollman/events{/privacy}","received_events_url":"https://api.github.com/users/fcollman/received_events","type":"User","site_admin":false},"repo":{"id":110624996,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MjQ5OTY=","name":"neuroglancer","full_name":"fcollman/neuroglancer","private":false,"owner":{"login":"fcollman","id":782341,"node_id":"MDQ6VXNlcjc4MjM0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/782341?v=4","gravatar_id":"","url":"https://api.github.com/users/fcollman","html_url":"https://github.com/fcollman","followers_url":"https://api.github.com/users/fcollman/followers","following_url":"https://api.github.com/users/fcollman/following{/other_user}","gists_url":"https://api.github.com/users/fcollman/gists{/gist_id}","starred_url":"https://api.github.com/users/fcollman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcollman/subscriptions","organizations_url":"https://api.github.com/users/fcollman/orgs","repos_url":"https://api.github.com/users/fcollman/repos","events_url":"https://api.github.com/users/fcollman/events{/privacy}","received_events_url":"https://api.github.com/users/fcollman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fcollman/neuroglancer","description":"WebGL-based viewer for volumetric data","fork":true,"url":"https://api.github.com/repos/fcollman/neuroglancer","forks_url":"https://api.github.com/repos/fcollman/neuroglancer/forks","keys_url":"https://api.github.com/repos/fcollman/neuroglancer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcollman/neuroglancer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcollman/neuroglancer/teams","hooks_url":"https://api.github.com/repos/fcollman/neuroglancer/hooks","issue_events_url":"https://api.github.com/repos/fcollman/neuroglancer/issues/events{/number}","events_url":"https://api.github.com/repos/fcollman/neuroglancer/events","assignees_url":"https://api.github.com/repos/fcollman/neuroglancer/assignees{/user}","branches_url":"https://api.github.com/repos/fcollman/neuroglancer/branches{/branch}","tags_url":"https://api.github.com/repos/fcollman/neuroglancer/tags","blobs_url":"https://api.github.com/repos/fcollman/neuroglancer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcollman/neuroglancer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcollman/neuroglancer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcollman/neuroglancer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcollman/neuroglancer/statuses/{sha}","languages_url":"https://api.github.com/repos/fcollman/neuroglancer/languages","stargazers_url":"https://api.github.com/repos/fcollman/neuroglancer/stargazers","contributors_url":"https://api.github.com/repos/fcollman/neuroglancer/contributors","subscribers_url":"https://api.github.com/repos/fcollman/neuroglancer/subscribers","subscription_url":"https://api.github.com/repos/fcollman/neuroglancer/subscription","commits_url":"https://api.github.com/repos/fcollman/neuroglancer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcollman/neuroglancer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcollman/neuroglancer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcollman/neuroglancer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcollman/neuroglancer/contents/{+path}","compare_url":"https://api.github.com/repos/fcollman/neuroglancer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcollman/neuroglancer/merges","archive_url":"https://api.github.com/repos/fcollman/neuroglancer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcollman/neuroglancer/downloads","issues_url":"https://api.github.com/repos/fcollman/neuroglancer/issues{/number}","pulls_url":"https://api.github.com/repos/fcollman/neuroglancer/pulls{/number}","milestones_url":"https://api.github.com/repos/fcollman/neuroglancer/milestones{/number}","notifications_url":"https://api.github.com/repos/fcollman/neuroglancer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcollman/neuroglancer/labels{/name}","releases_url":"https://api.github.com/repos/fcollman/neuroglancer/releases{/id}","deployments_url":"https://api.github.com/repos/fcollman/neuroglancer/deployments","created_at":"2017-11-14T01:39:34Z","updated_at":"2018-09-01T20:57:59Z","pushed_at":"2018-09-18T16:21:48Z","git_url":"git://github.com/fcollman/neuroglancer.git","ssh_url":"git@github.com:fcollman/neuroglancer.git","clone_url":"https://github.com/fcollman/neuroglancer.git","svn_url":"https://github.com/fcollman/neuroglancer","homepage":"","size":2668,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"89fcdc1f534407623975044a4e74de672ea8c656","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":59798355,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc5ODM1NQ==","name":"neuroglancer","full_name":"google/neuroglancer","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/neuroglancer","description":"WebGL-based viewer for volumetric data","fork":false,"url":"https://api.github.com/repos/google/neuroglancer","forks_url":"https://api.github.com/repos/google/neuroglancer/forks","keys_url":"https://api.github.com/repos/google/neuroglancer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/neuroglancer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/neuroglancer/teams","hooks_url":"https://api.github.com/repos/google/neuroglancer/hooks","issue_events_url":"https://api.github.com/repos/google/neuroglancer/issues/events{/number}","events_url":"https://api.github.com/repos/google/neuroglancer/events","assignees_url":"https://api.github.com/repos/google/neuroglancer/assignees{/user}","branches_url":"https://api.github.com/repos/google/neuroglancer/branches{/branch}","tags_url":"https://api.github.com/repos/google/neuroglancer/tags","blobs_url":"https://api.github.com/repos/google/neuroglancer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/neuroglancer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/neuroglancer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/neuroglancer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/neuroglancer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/neuroglancer/languages","stargazers_url":"https://api.github.com/repos/google/neuroglancer/stargazers","contributors_url":"https://api.github.com/repos/google/neuroglancer/contributors","subscribers_url":"https://api.github.com/repos/google/neuroglancer/subscribers","subscription_url":"https://api.github.com/repos/google/neuroglancer/subscription","commits_url":"https://api.github.com/repos/google/neuroglancer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/neuroglancer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/neuroglancer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/neuroglancer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/neuroglancer/contents/{+path}","compare_url":"https://api.github.com/repos/google/neuroglancer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/neuroglancer/merges","archive_url":"https://api.github.com/repos/google/neuroglancer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/neuroglancer/downloads","issues_url":"https://api.github.com/repos/google/neuroglancer/issues{/number}","pulls_url":"https://api.github.com/repos/google/neuroglancer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/neuroglancer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/neuroglancer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/neuroglancer/labels{/name}","releases_url":"https://api.github.com/repos/google/neuroglancer/releases{/id}","deployments_url":"https://api.github.com/repos/google/neuroglancer/deployments","created_at":"2016-05-27T02:37:25Z","updated_at":"2018-09-19T16:07:03Z","pushed_at":"2018-09-19T16:07:00Z","git_url":"git://github.com/google/neuroglancer.git","ssh_url":"git@github.com:google/neuroglancer.git","clone_url":"https://github.com/google/neuroglancer.git","svn_url":"https://github.com/google/neuroglancer","homepage":"","size":2547,"stargazers_count":239,"watchers_count":239,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":85,"open_issues":17,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/100"},"html":{"href":"https://github.com/google/neuroglancer/pull/100"},"issue":{"href":"https://api.github.com/repos/google/neuroglancer/issues/100"},"comments":{"href":"https://api.github.com/repos/google/neuroglancer/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/neuroglancer/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/google/neuroglancer/statuses/4d65dcd0227e1d13dc92be4b95097b49860c6968"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fcollman"}}