{"action":"created","issue":{"url":"https://api.github.com/repos/acornjs/acorn/issues/673","repository_url":"https://api.github.com/repos/acornjs/acorn","labels_url":"https://api.github.com/repos/acornjs/acorn/issues/673/labels{/name}","comments_url":"https://api.github.com/repos/acornjs/acorn/issues/673/comments","events_url":"https://api.github.com/repos/acornjs/acorn/issues/673/events","html_url":"https://github.com/acornjs/acorn/pull/673","id":296106359,"number":673,"title":"ES2018 RegExp enhancements","user":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars2.githubusercontent.com/u/1937871?v=4","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2018-02-10T14:52:14Z","updated_at":"2018-02-27T03:59:25Z","closed_at":"2018-02-22T08:20:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/acornjs/acorn/pulls/673","html_url":"https://github.com/acornjs/acorn/pull/673","diff_url":"https://github.com/acornjs/acorn/pull/673.diff","patch_url":"https://github.com/acornjs/acorn/pull/673.patch"},"body":"- [X] Replaces `RegExp` validation by own validator. The validator satisfies the full-spec regular expressions based on [A.8 Regular Expressions](https://www.ecma-international.org/ecma-262/8.0/#sec-regular-expressions) and [B.1.4 Regular Expressions Patterns](https://www.ecma-international.org/ecma-262/8.0/#sec-regular-expressions-patterns). The validator generates the same error messages as Node.js native `RegExp` implementation. (I checked the code coverage of the validator by [nyc](https://github.com/istanbuljs/nyc) and made almost 100%)\r\n- [X] Enhances the validator to support RegExp named capture groups (https://github.com/tc39/ecma262/commit/95ec0c6e67af8e6294225e090613bf4e87fed446)\r\n- [x] Enhances the validator to support RegExp Unicode Property Escapes (https://github.com/tc39/ecma262/commit/0ae3582a32125f560ecac540c5444a05e92e5a41)\r\n- [x] Enhances the validator to support RegExp Lookbehind Assertions (https://github.com/tc39/ecma262/commit/bf8a9be462d76cf86b5906e3ccad6a91568199f9)\r\n\r\nI'd like to get advice for the direction."},"comment":{"url":"https://api.github.com/repos/acornjs/acorn/issues/comments/368739764","html_url":"https://github.com/acornjs/acorn/pull/673#issuecomment-368739764","issue_url":"https://api.github.com/repos/acornjs/acorn/issues/673","id":368739764,"user":{"login":"mysticatea","id":1937871,"avatar_url":"https://avatars2.githubusercontent.com/u/1937871?v=4","gravatar_id":"","url":"https://api.github.com/users/mysticatea","html_url":"https://github.com/mysticatea","followers_url":"https://api.github.com/users/mysticatea/followers","following_url":"https://api.github.com/users/mysticatea/following{/other_user}","gists_url":"https://api.github.com/users/mysticatea/gists{/gist_id}","starred_url":"https://api.github.com/users/mysticatea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mysticatea/subscriptions","organizations_url":"https://api.github.com/users/mysticatea/orgs","repos_url":"https://api.github.com/users/mysticatea/repos","events_url":"https://api.github.com/users/mysticatea/events{/privacy}","received_events_url":"https://api.github.com/users/mysticatea/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T03:59:25Z","updated_at":"2018-02-27T03:59:25Z","author_association":"CONTRIBUTOR","body":"Ah, I find it in `test/bench` directory. Thanks."}}
{"actor":{"display_login":"mysticatea"}}