{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack/pulls/comments/181573211","pull_request_review_id":112119725,"id":181573211,"diff_hunk":"@@ -43,13 +75,23 @@ const getModulesSize = set => {\n \treturn count;\n };\n \n+/**\n+ * @class\n+ * @name Chunk\n+ * @description A Chunk is a unit of encapsulation for Modules.\n+ * Chunks are \"rendered\" into bundles that get emitted when the build completes.\n+ */\n class Chunk {\n+\t/**\n+\t * @param {string=} name of chunk being created, is optional (for subclasses)\n+\t */\n \tconstructor(name) {\n \t\tthis.id = null;","path":"lib/Chunk.js","position":75,"original_position":75,"commit_id":"72e0e1bf0e55e9f030b188333233cafbcefa54ab","original_commit_id":"72e0e1bf0e55e9f030b188333233cafbcefa54ab","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"body":"every member should have a `@type` comment (and optionally `@private`)","created_at":"2018-04-15T07:36:44Z","updated_at":"2018-04-15T07:38:21Z","html_url":"https://github.com/webpack/webpack/pull/7031#discussion_r181573211","pull_request_url":"https://api.github.com/repos/webpack/webpack/pulls/7031","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments/181573211"},"html":{"href":"https://github.com/webpack/webpack/pull/7031#discussion_r181573211"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7031"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/7031","id":181357332,"html_url":"https://github.com/webpack/webpack/pull/7031","diff_url":"https://github.com/webpack/webpack/pull/7031.diff","patch_url":"https://github.com/webpack/webpack/pull/7031.patch","issue_url":"https://api.github.com/repos/webpack/webpack/issues/7031","number":7031,"state":"open","locked":false,"title":"feat(chunk): add chunk typing support","user":{"login":"TheLarkInn","id":3408176,"avatar_url":"https://avatars1.githubusercontent.com/u/3408176?v=4","gravatar_id":"","url":"https://api.github.com/users/TheLarkInn","html_url":"https://github.com/TheLarkInn","followers_url":"https://api.github.com/users/TheLarkInn/followers","following_url":"https://api.github.com/users/TheLarkInn/following{/other_user}","gists_url":"https://api.github.com/users/TheLarkInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheLarkInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheLarkInn/subscriptions","organizations_url":"https://api.github.com/users/TheLarkInn/orgs","repos_url":"https://api.github.com/users/TheLarkInn/repos","events_url":"https://api.github.com/users/TheLarkInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheLarkInn/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\nRefactoring, Type Annotations\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\n**Did you add tests for your changes?**\r\nN/A\r\n<!-- Note that we won't merge your changes if you don't add tests -->\r\n\r\n**If relevant, link to documentation update:**\r\nN/A\r\n<!-- Link PR from webpack/webpack.js.org here, or N/A -->\r\nN/A\r\n\r\n**Summary**\r\nThis adds more (but not complete) typing to Chunk.js. \r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\nChunk is one of many base Types that could value from being completely typed and referenced in other modules, etc. It is also heavily used across plugins in our ecosystem, and having these annotations will assist in authoring of plugins and other integrations. \r\n\r\n<!-- Try to link to an open issue for more information. -->\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n**Other information**\r\n\r\nAlso helped discover the following TypeScript bugs: \r\n- https://github.com/Microsoft/TypeScript/issues/23375\r\n- https://github.com/Microsoft/TypeScript/issues/23384\r\n- https://github.com/Microsoft/TypeScript/issues/23385\r\n","created_at":"2018-04-13T00:17:06Z","updated_at":"2018-04-15T07:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fe97b9e3e5656ae20251043da4d39721ce4125f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":572712741,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-ok","name":"PR: CI-ok","color":"0e8a16","default":false},{"id":572817354,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack/pulls/7031/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack/pulls/7031/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/7031/comments","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/72e0e1bf0e55e9f030b188333233cafbcefa54ab","head":{"label":"webpack:feature/chunk-type-support","ref":"feature/chunk-type-support","sha":"72e0e1bf0e55e9f030b188333233cafbcefa54ab","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-04-15T07:20:41Z","pushed_at":"2018-04-15T06:14:52Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":13085,"stargazers_count":39866,"watchers_count":39866,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4968,"mirror_url":null,"archived":false,"open_issues_count":532,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4968,"open_issues":532,"watchers":39866,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"10282ea20648b465caec6448849f24fc34e1ba3e","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3678731,"name":"webpack","full_name":"webpack/webpack","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack","description":"A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through \"loaders,\" modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.","fork":false,"url":"https://api.github.com/repos/webpack/webpack","forks_url":"https://api.github.com/repos/webpack/webpack/forks","keys_url":"https://api.github.com/repos/webpack/webpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack/teams","hooks_url":"https://api.github.com/repos/webpack/webpack/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack/events","assignees_url":"https://api.github.com/repos/webpack/webpack/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack/tags","blobs_url":"https://api.github.com/repos/webpack/webpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack/subscription","commits_url":"https://api.github.com/repos/webpack/webpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack/merges","archive_url":"https://api.github.com/repos/webpack/webpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack/downloads","issues_url":"https://api.github.com/repos/webpack/webpack/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack/deployments","created_at":"2012-03-10T10:08:14Z","updated_at":"2018-04-15T07:20:41Z","pushed_at":"2018-04-15T06:14:52Z","git_url":"git://github.com/webpack/webpack.git","ssh_url":"git@github.com:webpack/webpack.git","clone_url":"https://github.com/webpack/webpack.git","svn_url":"https://github.com/webpack/webpack","homepage":"https://webpack.js.org","size":13085,"stargazers_count":39866,"watchers_count":39866,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4968,"mirror_url":null,"archived":false,"open_issues_count":532,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4968,"open_issues":532,"watchers":39866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7031"},"html":{"href":"https://github.com/webpack/webpack/pull/7031"},"issue":{"href":"https://api.github.com/repos/webpack/webpack/issues/7031"},"comments":{"href":"https://api.github.com/repos/webpack/webpack/issues/7031/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7031/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack/pulls/7031/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack/statuses/72e0e1bf0e55e9f030b188333233cafbcefa54ab"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sokra"}}