{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/200105203","pull_request_review_id":134353655,"id":200105203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDEwNTIwMw==","diff_hunk":"@@ -36,12 +35,11 @@ public function __construct(SenderLocatorInterface $senderLocator, array $messag\n     /**\n      * {@inheritdoc}\n      */\n-    public function handle($message, callable $next)\n+    public function handle($envelope, callable $next)","path":"src/Symfony/Component/Messenger/Asynchronous/Middleware/SendMessageMiddleware.php","position":13,"original_position":13,"commit_id":"ec4439b0cc8713ed3cbc5a044bf53cb58a08420c","original_commit_id":"ec4439b0cc8713ed3cbc5a044bf53cb58a08420c","user":{"login":"sroze","id":804625,"node_id":"MDQ6VXNlcjgwNDYyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/804625?v=4","gravatar_id":"","url":"https://api.github.com/users/sroze","html_url":"https://github.com/sroze","followers_url":"https://api.github.com/users/sroze/followers","following_url":"https://api.github.com/users/sroze/following{/other_user}","gists_url":"https://api.github.com/users/sroze/gists{/gist_id}","starred_url":"https://api.github.com/users/sroze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sroze/subscriptions","organizations_url":"https://api.github.com/users/sroze/orgs","repos_url":"https://api.github.com/users/sroze/repos","events_url":"https://api.github.com/users/sroze/events{/privacy}","received_events_url":"https://api.github.com/users/sroze/received_events","type":"User","site_admin":false},"body":"Can you add a `@param Envelope $envelope` above the `{@inheritdoc}`? I think that this would be better to explicit it's an Envelope.","created_at":"2018-07-04T12:04:07Z","updated_at":"2018-07-04T12:04:55Z","html_url":"https://github.com/symfony/symfony/pull/27841#discussion_r200105203","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/27841","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/200105203"},"html":{"href":"https://github.com/symfony/symfony/pull/27841#discussion_r200105203"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27841"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/27841","id":199198536,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTk4NTM2","html_url":"https://github.com/symfony/symfony/pull/27841","diff_url":"https://github.com/symfony/symfony/pull/27841.diff","patch_url":"https://github.com/symfony/symfony/pull/27841.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/27841","number":27841,"state":"open","locked":false,"title":"[Messenger] Envelope-aware middleware is never called with a message","user":{"login":"Cydonia7","id":6281515,"node_id":"MDQ6VXNlcjYyODE1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6281515?v=4","gravatar_id":"","url":"https://api.github.com/users/Cydonia7","html_url":"https://github.com/Cydonia7","followers_url":"https://api.github.com/users/Cydonia7/followers","following_url":"https://api.github.com/users/Cydonia7/following{/other_user}","gists_url":"https://api.github.com/users/Cydonia7/gists{/gist_id}","starred_url":"https://api.github.com/users/Cydonia7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cydonia7/subscriptions","organizations_url":"https://api.github.com/users/Cydonia7/orgs","repos_url":"https://api.github.com/users/Cydonia7/repos","events_url":"https://api.github.com/users/Cydonia7/events{/privacy}","received_events_url":"https://api.github.com/users/Cydonia7/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 4.1\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | no\r\n| License       | MIT\r\n| Doc PR        | no\r\n\r\nMessenger components middlewares implementing `Symfony\\Component\\Messenger\\EnvelopeAwareInterface` receive in their handle method an instance of `Symfony\\Component\\Messenger\\Envelope`, not a message.\r\n\r\nTo better reflect the expected usage, I've updated the unit tests for the message middleware and fixed the code accordingly.","created_at":"2018-07-04T09:58:45Z","updated_at":"2018-07-04T12:04:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9e678b0aec16cdbf00d0597406c364da4d3e1fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100079,"node_id":"MDU6TGFiZWwxMDAwNzk=","url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":877085690,"node_id":"MDU6TGFiZWw4NzcwODU2OTA=","url":"https://api.github.com/repos/symfony/symfony/labels/Messenger","name":"Messenger","color":"dddddd","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/27841/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/27841/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/27841/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/ec4439b0cc8713ed3cbc5a044bf53cb58a08420c","head":{"label":"Cydonia7:envelope-aware-middleware","ref":"envelope-aware-middleware","sha":"ec4439b0cc8713ed3cbc5a044bf53cb58a08420c","user":{"login":"Cydonia7","id":6281515,"node_id":"MDQ6VXNlcjYyODE1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6281515?v=4","gravatar_id":"","url":"https://api.github.com/users/Cydonia7","html_url":"https://github.com/Cydonia7","followers_url":"https://api.github.com/users/Cydonia7/followers","following_url":"https://api.github.com/users/Cydonia7/following{/other_user}","gists_url":"https://api.github.com/users/Cydonia7/gists{/gist_id}","starred_url":"https://api.github.com/users/Cydonia7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cydonia7/subscriptions","organizations_url":"https://api.github.com/users/Cydonia7/orgs","repos_url":"https://api.github.com/users/Cydonia7/repos","events_url":"https://api.github.com/users/Cydonia7/events{/privacy}","received_events_url":"https://api.github.com/users/Cydonia7/received_events","type":"User","site_admin":false},"repo":{"id":139637368,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MzczNjg=","name":"symfony","full_name":"Cydonia7/symfony","owner":{"login":"Cydonia7","id":6281515,"node_id":"MDQ6VXNlcjYyODE1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6281515?v=4","gravatar_id":"","url":"https://api.github.com/users/Cydonia7","html_url":"https://github.com/Cydonia7","followers_url":"https://api.github.com/users/Cydonia7/followers","following_url":"https://api.github.com/users/Cydonia7/following{/other_user}","gists_url":"https://api.github.com/users/Cydonia7/gists{/gist_id}","starred_url":"https://api.github.com/users/Cydonia7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cydonia7/subscriptions","organizations_url":"https://api.github.com/users/Cydonia7/orgs","repos_url":"https://api.github.com/users/Cydonia7/repos","events_url":"https://api.github.com/users/Cydonia7/events{/privacy}","received_events_url":"https://api.github.com/users/Cydonia7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cydonia7/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Cydonia7/symfony","forks_url":"https://api.github.com/repos/Cydonia7/symfony/forks","keys_url":"https://api.github.com/repos/Cydonia7/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cydonia7/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cydonia7/symfony/teams","hooks_url":"https://api.github.com/repos/Cydonia7/symfony/hooks","issue_events_url":"https://api.github.com/repos/Cydonia7/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Cydonia7/symfony/events","assignees_url":"https://api.github.com/repos/Cydonia7/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Cydonia7/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Cydonia7/symfony/tags","blobs_url":"https://api.github.com/repos/Cydonia7/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cydonia7/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cydonia7/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cydonia7/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cydonia7/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Cydonia7/symfony/languages","stargazers_url":"https://api.github.com/repos/Cydonia7/symfony/stargazers","contributors_url":"https://api.github.com/repos/Cydonia7/symfony/contributors","subscribers_url":"https://api.github.com/repos/Cydonia7/symfony/subscribers","subscription_url":"https://api.github.com/repos/Cydonia7/symfony/subscription","commits_url":"https://api.github.com/repos/Cydonia7/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cydonia7/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cydonia7/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cydonia7/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cydonia7/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Cydonia7/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cydonia7/symfony/merges","archive_url":"https://api.github.com/repos/Cydonia7/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cydonia7/symfony/downloads","issues_url":"https://api.github.com/repos/Cydonia7/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Cydonia7/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Cydonia7/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Cydonia7/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cydonia7/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Cydonia7/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Cydonia7/symfony/deployments","created_at":"2018-07-03T21:10:43Z","updated_at":"2018-07-03T21:11:02Z","pushed_at":"2018-07-04T09:59:25Z","git_url":"git://github.com/Cydonia7/symfony.git","ssh_url":"git@github.com:Cydonia7/symfony.git","clone_url":"https://github.com/Cydonia7/symfony.git","svn_url":"https://github.com/Cydonia7/symfony","homepage":"https://symfony.com","size":115306,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"04b2c2db4f64174b9aca74f3cb60c84e55172807","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-07-04T10:24:06Z","pushed_at":"2018-07-04T11:57:56Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":120130,"stargazers_count":17979,"watchers_count":17979,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6295,"mirror_url":null,"archived":false,"open_issues_count":885,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6295,"open_issues":885,"watchers":17979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27841"},"html":{"href":"https://github.com/symfony/symfony/pull/27841"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/27841"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/27841/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27841/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27841/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/ec4439b0cc8713ed3cbc5a044bf53cb58a08420c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sroze"}}