{"action":"created","issue":{"url":"https://api.github.com/repos/renovateapp/renovate/issues/1655","repository_url":"https://api.github.com/repos/renovateapp/renovate","labels_url":"https://api.github.com/repos/renovateapp/renovate/issues/1655/labels{/name}","comments_url":"https://api.github.com/repos/renovateapp/renovate/issues/1655/comments","events_url":"https://api.github.com/repos/renovateapp/renovate/issues/1655/events","html_url":"https://github.com/renovateapp/renovate/issues/1655","id":304733446,"number":1655,"title":"Lock file maintenance PR didn't use lockfile from master","user":{"login":"edmorley","id":501702,"avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-13T11:52:20Z","updated_at":"2018-03-13T12:03:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"#### This is a:\r\n\r\n* [X] Bug report (non-security related)\r\n* [ ] Feature request\r\n* [ ] I'm not sure which of those it is\r\n\r\n#### I'm using:\r\n\r\n* [X] The Renovate GitHub App\r\n* [ ] Self-hosted GitHub\r\n* [ ] Self-hosted GitLab\r\n* [ ] Self-hosted VSTS\r\n\r\n#### Please describe the issue:\r\nHi :-)\r\n\r\nRenovate opened a lockfile update PR (mozilla-neutrino/neutrino-dev#743) which failed because of a problem on our side. \r\n\r\nTo resolve that, I created a new PR (mozilla-neutrino/neutrino-dev#744) that (a) removed the stray 2nd `yarn.lock`, (b) refreshed the lockfile manually to save Renovate from having to do so. I merged that PR, which also had a `closes #NNN` line in the commit message, causing the initial failing Renovate PR to be closed.\r\n\r\nOne minute after I merged my PR, Renovate opened a second lockfile update PR (presumably since it was still in the scheduled time window for refreshing, which itself is fine):\r\nhttps://github.com/mozilla-neutrino/neutrino-dev/pull/745\r\n\r\nThe problem is that the new PR duplicate the changes I made in my PR - implying that it wasn't rebased on master, even though my PR was merged before it opened. GitHub doesn't show the PR as having conflicts since the changes are identical (so presumably git auto-resolves them)."},"comment":{"url":"https://api.github.com/repos/renovateapp/renovate/issues/comments/372642303","html_url":"https://github.com/renovateapp/renovate/issues/1655#issuecomment-372642303","issue_url":"https://api.github.com/repos/renovateapp/renovate/issues/1655","id":372642303,"user":{"login":"rarkins","id":6311784,"avatar_url":"https://avatars1.githubusercontent.com/u/6311784?v=4","gravatar_id":"","url":"https://api.github.com/users/rarkins","html_url":"https://github.com/rarkins","followers_url":"https://api.github.com/users/rarkins/followers","following_url":"https://api.github.com/users/rarkins/following{/other_user}","gists_url":"https://api.github.com/users/rarkins/gists{/gist_id}","starred_url":"https://api.github.com/users/rarkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rarkins/subscriptions","organizations_url":"https://api.github.com/users/rarkins/orgs","repos_url":"https://api.github.com/users/rarkins/repos","events_url":"https://api.github.com/users/rarkins/events{/privacy}","received_events_url":"https://api.github.com/users/rarkins/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T12:03:32Z","updated_at":"2018-03-13T12:03:32Z","author_association":"OWNER","body":"I may need to add a special rule for lock file PRs to avoid this edge case. You see, we deliberately don't keep updating/checking lock files for updates or we'd be running `yarn` non stop. Once a lock file maintenance PR has been created, we don't update it until you merge it or delete it. BUT I guess that may have this annoying side condition that if you close it without deleting it and Renovate runs again, it sees the existing branch and figures it doesn't need to run again. Then if there's no PR it thinks \"I guess I should create that then\". There's no logic to think \"Looks like they closed the PR without deleting the branch - I'll start over and remove this branch first\""}}
{"actor":{"display_login":"rarkins"}}