{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/166045986","pull_request_review_id":94072146,"id":166045986,"diff_hunk":"@@ -0,0 +1,73 @@\n+// Copyright Joyent, Inc. and other Node contributors.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a\n+// copy of this software and associated documentation files (the\n+// \"Software\"), to deal in the Software without restriction, including\n+// without limitation the rights to use, copy, modify, merge, publish,\n+// distribute, sublicense, and/or sell copies of the Software, and to permit\n+// persons to whom the Software is furnished to do so, subject to the\n+// following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included\n+// in all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS\n+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN\n+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,\n+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE\n+// USE OR OTHER DEALINGS IN THE SOFTWARE.","path":"test/parallel/test-http-information-processing.js","position":null,"original_position":20,"commit_id":"68c4032e0681f55103b99e798c9c5bb5c3815078","original_commit_id":"da81197d38884097b0b9282dbb903592029e6a07","user":{"login":"miles-po","id":30807186,"avatar_url":"https://avatars0.githubusercontent.com/u/30807186?v=4","gravatar_id":"","url":"https://api.github.com/users/miles-po","html_url":"https://github.com/miles-po","followers_url":"https://api.github.com/users/miles-po/followers","following_url":"https://api.github.com/users/miles-po/following{/other_user}","gists_url":"https://api.github.com/users/miles-po/gists{/gist_id}","starred_url":"https://api.github.com/users/miles-po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miles-po/subscriptions","organizations_url":"https://api.github.com/users/miles-po/orgs","repos_url":"https://api.github.com/users/miles-po/repos","events_url":"https://api.github.com/users/miles-po/events{/privacy}","received_events_url":"https://api.github.com/users/miles-po/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-02-05T17:23:11Z","updated_at":"2018-02-05T17:23:11Z","html_url":"https://github.com/nodejs/node/pull/18033#discussion_r166045986","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/18033","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/166045986"},"html":{"href":"https://github.com/nodejs/node/pull/18033#discussion_r166045986"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/18033"}},"in_reply_to_id":165922571},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/18033","id":161579737,"html_url":"https://github.com/nodejs/node/pull/18033","diff_url":"https://github.com/nodejs/node/pull/18033.diff","patch_url":"https://github.com/nodejs/node/pull/18033.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/18033","number":18033,"state":"open","locked":false,"title":"Process 100, 102-199 status codes according to specs.","user":{"login":"miles-po","id":30807186,"avatar_url":"https://avatars0.githubusercontent.com/u/30807186?v=4","gravatar_id":"","url":"https://api.github.com/users/miles-po","html_url":"https://github.com/miles-po","followers_url":"https://api.github.com/users/miles-po/followers","following_url":"https://api.github.com/users/miles-po/following{/other_user}","gists_url":"https://api.github.com/users/miles-po/gists{/gist_id}","starred_url":"https://api.github.com/users/miles-po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miles-po/subscriptions","organizations_url":"https://api.github.com/users/miles-po/orgs","repos_url":"https://api.github.com/users/miles-po/repos","events_url":"https://api.github.com/users/miles-po/events{/privacy}","received_events_url":"https://api.github.com/users/miles-po/received_events","type":"User","site_admin":false},"body":"\r\nRelevant references:\r\n RFC7231 Section 6.2.1\r\n RFC2518\r\n RFC8297\r\n\r\nThis affects several modules downstream that use the http\r\nmodule, e.g., node-fetch, all of whom violate HTTP RFCs\r\ndue to this module. As such, this could introduce a\r\nbreaking change for downstream if HTTP standards were\r\nignored in an ad-hoc fashion.\r\n\r\n101 Upgrade is excluded due to its non-informational\r\nprocessing according to RFC7231, Section 6.2.2.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nhttp, http2, https","created_at":"2018-01-08T08:33:39Z","updated_at":"2018-02-05T17:23:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed5ed5068d6ea6990913e2e5ca3863ddba3599a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/26","html_url":"https://github.com/nodejs/node/milestone/26","labels_url":"https://api.github.com/repos/nodejs/node/milestones/26/labels","id":2551352,"number":26,"title":"10.0.0","description":"","creator":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"open","created_at":"2017-05-30T19:07:02Z","updated_at":"2018-02-02T19:41:56Z","due_on":"2018-04-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodejs/node/pulls/18033/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/18033/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/18033/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/68c4032e0681f55103b99e798c9c5bb5c3815078","head":{"label":"miles-po:1xx","ref":"1xx","sha":"68c4032e0681f55103b99e798c9c5bb5c3815078","user":{"login":"miles-po","id":30807186,"avatar_url":"https://avatars0.githubusercontent.com/u/30807186?v=4","gravatar_id":"","url":"https://api.github.com/users/miles-po","html_url":"https://github.com/miles-po","followers_url":"https://api.github.com/users/miles-po/followers","following_url":"https://api.github.com/users/miles-po/following{/other_user}","gists_url":"https://api.github.com/users/miles-po/gists{/gist_id}","starred_url":"https://api.github.com/users/miles-po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miles-po/subscriptions","organizations_url":"https://api.github.com/users/miles-po/orgs","repos_url":"https://api.github.com/users/miles-po/repos","events_url":"https://api.github.com/users/miles-po/events{/privacy}","received_events_url":"https://api.github.com/users/miles-po/received_events","type":"User","site_admin":false},"repo":{"id":116639277,"name":"node","full_name":"miles-po/node","owner":{"login":"miles-po","id":30807186,"avatar_url":"https://avatars0.githubusercontent.com/u/30807186?v=4","gravatar_id":"","url":"https://api.github.com/users/miles-po","html_url":"https://github.com/miles-po","followers_url":"https://api.github.com/users/miles-po/followers","following_url":"https://api.github.com/users/miles-po/following{/other_user}","gists_url":"https://api.github.com/users/miles-po/gists{/gist_id}","starred_url":"https://api.github.com/users/miles-po/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miles-po/subscriptions","organizations_url":"https://api.github.com/users/miles-po/orgs","repos_url":"https://api.github.com/users/miles-po/repos","events_url":"https://api.github.com/users/miles-po/events{/privacy}","received_events_url":"https://api.github.com/users/miles-po/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miles-po/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/miles-po/node","forks_url":"https://api.github.com/repos/miles-po/node/forks","keys_url":"https://api.github.com/repos/miles-po/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miles-po/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miles-po/node/teams","hooks_url":"https://api.github.com/repos/miles-po/node/hooks","issue_events_url":"https://api.github.com/repos/miles-po/node/issues/events{/number}","events_url":"https://api.github.com/repos/miles-po/node/events","assignees_url":"https://api.github.com/repos/miles-po/node/assignees{/user}","branches_url":"https://api.github.com/repos/miles-po/node/branches{/branch}","tags_url":"https://api.github.com/repos/miles-po/node/tags","blobs_url":"https://api.github.com/repos/miles-po/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miles-po/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miles-po/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/miles-po/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miles-po/node/statuses/{sha}","languages_url":"https://api.github.com/repos/miles-po/node/languages","stargazers_url":"https://api.github.com/repos/miles-po/node/stargazers","contributors_url":"https://api.github.com/repos/miles-po/node/contributors","subscribers_url":"https://api.github.com/repos/miles-po/node/subscribers","subscription_url":"https://api.github.com/repos/miles-po/node/subscription","commits_url":"https://api.github.com/repos/miles-po/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/miles-po/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/miles-po/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/miles-po/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/miles-po/node/contents/{+path}","compare_url":"https://api.github.com/repos/miles-po/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miles-po/node/merges","archive_url":"https://api.github.com/repos/miles-po/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miles-po/node/downloads","issues_url":"https://api.github.com/repos/miles-po/node/issues{/number}","pulls_url":"https://api.github.com/repos/miles-po/node/pulls{/number}","milestones_url":"https://api.github.com/repos/miles-po/node/milestones{/number}","notifications_url":"https://api.github.com/repos/miles-po/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miles-po/node/labels{/name}","releases_url":"https://api.github.com/repos/miles-po/node/releases{/id}","deployments_url":"https://api.github.com/repos/miles-po/node/deployments","created_at":"2018-01-08T06:34:11Z","updated_at":"2018-01-08T06:34:38Z","pushed_at":"2018-02-05T17:22:52Z","git_url":"git://github.com/miles-po/node.git","ssh_url":"git@github.com:miles-po/node.git","clone_url":"https://github.com/miles-po/node.git","svn_url":"https://github.com/miles-po/node","homepage":"https://nodejs.org","size":348433,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"6d84ecefcd7da51ee5f9613f745ba5d0a9818726","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-02-05T17:22:16Z","pushed_at":"2018-02-05T17:22:57Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":350872,"stargazers_count":45221,"watchers_count":45221,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9470,"mirror_url":null,"archived":false,"open_issues_count":792,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9470,"open_issues":792,"watchers":45221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/18033"},"html":{"href":"https://github.com/nodejs/node/pull/18033"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/18033"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/18033/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/18033/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/18033/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/68c4032e0681f55103b99e798c9c5bb5c3815078"}},"author_association":"NONE"}}
{"actor":{"display_login":"miles-po"}}