{"action":"opened","issue":{"url":"https://api.github.com/repos/wixtoolset/issues/issues/5772","repository_url":"https://api.github.com/repos/wixtoolset/issues","labels_url":"https://api.github.com/repos/wixtoolset/issues/issues/5772/labels{/name}","comments_url":"https://api.github.com/repos/wixtoolset/issues/issues/5772/comments","events_url":"https://api.github.com/repos/wixtoolset/issues/issues/5772/events","html_url":"https://github.com/wixtoolset/issues/issues/5772","id":300275142,"number":5772,"title":"Preprocessor documentation is lacking","user":{"login":"PerMildner","id":1358238,"avatar_url":"https://avatars0.githubusercontent.com/u/1358238?v=4","gravatar_id":"","url":"https://api.github.com/users/PerMildner","html_url":"https://github.com/PerMildner","followers_url":"https://api.github.com/users/PerMildner/followers","following_url":"https://api.github.com/users/PerMildner/following{/other_user}","gists_url":"https://api.github.com/users/PerMildner/gists{/gist_id}","starred_url":"https://api.github.com/users/PerMildner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerMildner/subscriptions","organizations_url":"https://api.github.com/users/PerMildner/orgs","repos_url":"https://api.github.com/users/PerMildner/repos","events_url":"https://api.github.com/users/PerMildner/events{/privacy}","received_events_url":"https://api.github.com/users/PerMildner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-26T15:11:46Z","updated_at":"2018-02-26T15:11:46Z","closed_at":null,"author_association":"NONE","body":"Please provide answers to the following questions to help us narrow down, reproduce, and fix the problem. Fill out one section and delete the others.\r\n\r\n\r\n## Triage\r\n\r\nIssues are triaged at [online meetings](https://www.firegiant.com/blog/), generally held alternate Tuesdays at 9:30 a.m. Pacific time (UTC-7/UTC-8). Meeting requests are sent to the [wix-devs](http://wixtoolset.org/documentation/mailinglist/#wix-devs) mailing list.\r\n\r\n\r\n## Discussions and support\r\n\r\nNote that discussions are best held on the mailing lists, not in issues. Please do not open issues requesting support or debugging help; first start a thread on the [wix-users](http://wixtoolset.org/documentation/mailinglist/#wix-users) mailing list and open an issue if the discussion suggests a bug in the WiX Toolset or that a feature request is appropriate.\r\n\r\n\r\n## Bugs\r\n\r\nIf this issue is a bug:\r\n\r\n* Which version of WiX are you building with?\r\n\r\n> (WiX version in major.minor.release.build format)\r\n\r\n* Which version of Visual Studio are you building with (if any)?\r\n\r\n> (Visual Studio version, including year and update)\r\n\r\n* Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?\r\n\r\n> (WiX Toolset Visual Studio Extension version in major.minor.release.build format)\r\n\r\n* Which version of .NET are you building with?\r\n\r\n> (.NET version)\r\n\r\n* If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?\r\n\r\n> (Windows version)\r\n\r\n* Describe the problem and the steps to reproduce it.\r\n\r\nThe documentation http://wixtoolset.org/documentation/manual/v3/overview/preprocessor.html is incorrect, and its examples are broken.\r\n\r\nIt does not contain any information about how the value of a variable is interpreted in a Boolean context, e.g. which values of Foo will make `<?if $(var.Foo) ?>` consider the test to be true (and which values of Foo, if any, will make the test come out as false).\r\n\r\nThe examples mixes the case for the variable `IExist` which makes the tests incorrect. I.e.  `error CNDL0150 : Undefined preprocessor variable '$(var.Iexist)'`\r\n\r\nAlso, the description does not make it clear when `$(var.Foo)` and `Foo` should be used, it calls both variants \"variable\". I suspect many places that says \"variable\" really means something like \"expression\", where `$(var.Foo)` is one possible expression (and the literal `Sunny` is another expression).\r\n\r\nThe text about stripping whitespace from literals is unclear. Presumably `\"  foo \"` is not treated the same as `\"foo\"` but that is what the text `Literals can be surrounded by quotes, although quotes are not required.` together with `Quotes, leading, and trailing white space are stripped off literal values` seems to imply.\r\n\r\n> (Be as specific as you can and err on the side of providing too much information, including code, error messages, command lines you used to invoke the build, and so forth.)\r\n\r\n* Describe the behavior you expected and how it differed from the actual behavior.\r\n\r\n> (Be as specific as you can and err on the side of providing too much information.)\r\n\r\n\r\n## Feature requests\r\n\r\nIf this issue is a feature request:\r\n\r\n* Describe the scenario and benefits that the feature supports.\r\n\r\n> (Provide lots of specific detail so we understand the context around the feature.)\r\n\r\n* Describe how you're accomplishing the feature today (if possible).\r\n\r\n> (Be as specific as you can and err on the side of providing too much information.)\r\n\r\n* Describe what you'd like the new feature to do.\r\n\r\n> (There's no need to design it but suggestions are appreciated.)\r\n"}}
{"actor":{"display_login":"PerMildner"}}