{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/18237","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/18237/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/18237/comments","events_url":"https://api.github.com/repos/apple/swift/issues/18237/events","html_url":"https://github.com/apple/swift/pull/18237","id":344642059,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTkwNTA1","number":18237,"title":"Fix dead instruction cleanup in deabstraction.","user":{"login":"dan-zheng","id":5590046,"node_id":"MDQ6VXNlcjU1OTAwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5590046?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-zheng","html_url":"https://github.com/dan-zheng","followers_url":"https://api.github.com/users/dan-zheng/followers","following_url":"https://api.github.com/users/dan-zheng/following{/other_user}","gists_url":"https://api.github.com/users/dan-zheng/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-zheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-zheng/subscriptions","organizations_url":"https://api.github.com/users/dan-zheng/orgs","repos_url":"https://api.github.com/users/dan-zheng/repos","events_url":"https://api.github.com/users/dan-zheng/events{/privacy}","received_events_url":"https://api.github.com/users/dan-zheng/received_events","type":"User","site_admin":false},"labels":[{"id":955546636,"node_id":"MDU6TGFiZWw5NTU1NDY2MzY=","url":"https://api.github.com/repos/apple/swift/labels/tensorflow","name":"tensorflow","color":"EF6C00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-25T23:27:44Z","updated_at":"2018-07-26T01:43:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18237","html_url":"https://github.com/apple/swift/pull/18237","diff_url":"https://github.com/apple/swift/pull/18237.diff","patch_url":"https://github.com/apple/swift/pull/18237.patch"},"body":"Previously, `cleanupDeadInstructions` simultaneously traversed a basic block\r\nwhile removing some of its instructions. This caused a segfault due to iterator\r\ninvalidation: for trivially dead instructions whose only uses were debug value\r\ninstructions, the debug value uses would be removed without incrementing the\r\niterator.\r\n\r\nNow, instructions are marked for deletion, and marked instructions are deleted\r\nin a separate pass. This is less efficient but avoids iterator invalidation\r\nerrors.\r\n\r\nAddresses [SR-8316](https://bugs.swift.org/browse/SR-8316)."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/407949193","html_url":"https://github.com/apple/swift/pull/18237#issuecomment-407949193","issue_url":"https://api.github.com/repos/apple/swift/issues/18237","id":407949193,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzk0OTE5Mw==","user":{"login":"dan-zheng","id":5590046,"node_id":"MDQ6VXNlcjU1OTAwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5590046?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-zheng","html_url":"https://github.com/dan-zheng","followers_url":"https://api.github.com/users/dan-zheng/followers","following_url":"https://api.github.com/users/dan-zheng/following{/other_user}","gists_url":"https://api.github.com/users/dan-zheng/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-zheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-zheng/subscriptions","organizations_url":"https://api.github.com/users/dan-zheng/orgs","repos_url":"https://api.github.com/users/dan-zheng/repos","events_url":"https://api.github.com/users/dan-zheng/events{/privacy}","received_events_url":"https://api.github.com/users/dan-zheng/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T01:43:14Z","updated_at":"2018-07-26T01:43:14Z","author_association":"COLLABORATOR","body":"Merging to unblock model development, happy to address comments in a follow-up."}}
{"actor":{"display_login":"dan-zheng"}}