{"action":"closed","number":55616,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/55616","id":227970116,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTcwMTE2","html_url":"https://github.com/rust-lang/rust/pull/55616","diff_url":"https://github.com/rust-lang/rust/pull/55616.diff","patch_url":"https://github.com/rust-lang/rust/pull/55616.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/55616","number":55616,"state":"closed","locked":false,"title":"Return impl Iterator from required_region_bounds","user":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"body":"This removes the vector from `ty::util::required_region_bounds` by returning `impl Iterator`; it also makes `typeck::astconv::compute_object_lifetime_bound` go through `derived_region_bounds` only once.\r\n\r\nThere is one downside (that I can detect) - `ty::wf::from_object_ty` can no longer precisely preallocate one vector in case `!data.has_escaping_regions()` is true. We might want to verify if this is beneficial enough with a perf run.","created_at":"2018-11-02T15:18:07Z","updated_at":"2018-11-13T07:57:34Z","closed_at":"2018-11-13T07:57:34Z","merged_at":null,"merge_commit_sha":"fe61897c724518daa0d46bb812d74e3949d2d5d7","assignee":{"login":"zackmdavis","id":1076988,"node_id":"MDQ6VXNlcjEwNzY5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1076988?v=4","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"assignees":[{"login":"zackmdavis","id":1076988,"node_id":"MDQ6VXNlcjEwNzY5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1076988?v=4","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/55616/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/55616/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/55616/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/e0c2fa7ad335b760f7cc56989267c40941c7349e","head":{"label":"ljedrz:return_impl_iterator_required_region_bounds","ref":"return_impl_iterator_required_region_bounds","sha":"e0c2fa7ad335b760f7cc56989267c40941c7349e","user":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"repo":{"id":138298132,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyOTgxMzI=","name":"rust-1","full_name":"ljedrz/rust-1","private":false,"owner":{"login":"ljedrz","id":3750347,"node_id":"MDQ6VXNlcjM3NTAzNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/3750347?v=4","gravatar_id":"","url":"https://api.github.com/users/ljedrz","html_url":"https://github.com/ljedrz","followers_url":"https://api.github.com/users/ljedrz/followers","following_url":"https://api.github.com/users/ljedrz/following{/other_user}","gists_url":"https://api.github.com/users/ljedrz/gists{/gist_id}","starred_url":"https://api.github.com/users/ljedrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljedrz/subscriptions","organizations_url":"https://api.github.com/users/ljedrz/orgs","repos_url":"https://api.github.com/users/ljedrz/repos","events_url":"https://api.github.com/users/ljedrz/events{/privacy}","received_events_url":"https://api.github.com/users/ljedrz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ljedrz/rust-1","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/ljedrz/rust-1","forks_url":"https://api.github.com/repos/ljedrz/rust-1/forks","keys_url":"https://api.github.com/repos/ljedrz/rust-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljedrz/rust-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljedrz/rust-1/teams","hooks_url":"https://api.github.com/repos/ljedrz/rust-1/hooks","issue_events_url":"https://api.github.com/repos/ljedrz/rust-1/issues/events{/number}","events_url":"https://api.github.com/repos/ljedrz/rust-1/events","assignees_url":"https://api.github.com/repos/ljedrz/rust-1/assignees{/user}","branches_url":"https://api.github.com/repos/ljedrz/rust-1/branches{/branch}","tags_url":"https://api.github.com/repos/ljedrz/rust-1/tags","blobs_url":"https://api.github.com/repos/ljedrz/rust-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljedrz/rust-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljedrz/rust-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljedrz/rust-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljedrz/rust-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ljedrz/rust-1/languages","stargazers_url":"https://api.github.com/repos/ljedrz/rust-1/stargazers","contributors_url":"https://api.github.com/repos/ljedrz/rust-1/contributors","subscribers_url":"https://api.github.com/repos/ljedrz/rust-1/subscribers","subscription_url":"https://api.github.com/repos/ljedrz/rust-1/subscription","commits_url":"https://api.github.com/repos/ljedrz/rust-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljedrz/rust-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljedrz/rust-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljedrz/rust-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljedrz/rust-1/contents/{+path}","compare_url":"https://api.github.com/repos/ljedrz/rust-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljedrz/rust-1/merges","archive_url":"https://api.github.com/repos/ljedrz/rust-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljedrz/rust-1/downloads","issues_url":"https://api.github.com/repos/ljedrz/rust-1/issues{/number}","pulls_url":"https://api.github.com/repos/ljedrz/rust-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ljedrz/rust-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ljedrz/rust-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljedrz/rust-1/labels{/name}","releases_url":"https://api.github.com/repos/ljedrz/rust-1/releases{/id}","deployments_url":"https://api.github.com/repos/ljedrz/rust-1/deployments","created_at":"2018-06-22T12:05:10Z","updated_at":"2018-07-13T09:38:34Z","pushed_at":"2018-11-13T07:49:59Z","git_url":"git://github.com/ljedrz/rust-1.git","ssh_url":"git@github.com:ljedrz/rust-1.git","clone_url":"https://github.com/ljedrz/rust-1.git","svn_url":"https://github.com/ljedrz/rust-1","homepage":"https://www.rust-lang.org","size":401970,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"d0c869c323289c5ec4df83e1c9091fa0b3e2fc07","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-11-13T07:27:52Z","pushed_at":"2018-11-13T07:43:58Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":403187,"stargazers_count":31724,"watchers_count":31724,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5293,"mirror_url":null,"archived":false,"open_issues_count":4552,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5293,"open_issues":4552,"watchers":31724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55616"},"html":{"href":"https://github.com/rust-lang/rust/pull/55616"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55616"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/55616/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55616/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/55616/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/e0c2fa7ad335b760f7cc56989267c40941c7349e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":35,"deletions":24,"changed_files":4}}
{"actor":{"display_login":"ljedrz"}}