{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/168033227","pull_request_review_id":96336441,"id":168033227,"diff_hunk":"@@ -276,17 +279,82 @@ namespace {\n         parse::detail::planet_type_parser_rules planet_type_rules;\n         parse::detail::planet_environment_parser_rules planet_environment_rules;\n     };\n+\n+    using manifest_start_rule_signature = void (std::vector<std::string>&);\n+\n+    struct manifest_grammar : public parse::detail::grammar<manifest_start_rule_signature> {\n+        manifest_grammar(const parse::lexer& tok,\n+                         const std::string& filename,\n+                         const parse::text_iterator& first, const parse::text_iterator& last) :\n+            manifest_grammar::base_type(start),\n+            labeller(tok)\n+        {\n+            namespace phoenix = boost::phoenix;\n+            namespace qi = boost::spirit::qi;\n+\n+            using phoenix::push_back;\n+\n+            qi::_1_type _1;\n+            qi::_2_type _2;\n+            qi::_3_type _3;\n+            qi::_4_type _4;\n+            qi::_r1_type _r1;\n+\n+            species_manifest\n+                =    tok.SpeciesCensusOrdering_\n+                >    *(labeller.rule(Tag_token)       > tok.string [ push_back(_r1, _1) ])\n+                ;\n+\n+            start\n+                =   +species_manifest(_r1)\n+                ;\n+\n+            species_manifest.name(\"ParsedSpeciesCensusOrdering\");\n+\n+#if DEBUG_PARSERS\n+            debug(species_manifest);\n+#endif\n+\n+            qi::on_error<qi::fail>(start, parse::report_error(filename, first, last, _1, _2, _3, _4));\n+        }\n+\n+        using manifest_rule = parse::detail::rule<void (std::vector<std::string>&)>;\n+        using start_rule = parse::detail::rule<manifest_start_rule_signature>;\n+\n+        parse::detail::Labeller labeller;\n+        manifest_rule species_manifest;\n+        start_rule start;\n+    };\n }\n \n namespace parse {\n     start_rule_payload species(const boost::filesystem::path& path) {\n         const lexer lexer;\n-        start_rule_payload species_;\n+        start_rule_payload::first_type species_;\n+        start_rule_payload::second_type ordering;\n+\n+        boost::filesystem::path manifest_file;\n \n         for (const boost::filesystem::path& file : ListScripts(path)) {\n-            /*auto success =*/ detail::parse_file<grammar, start_rule_payload>(lexer, file, species_);\n+            if (file.filename() == \"SpeciesCensusOrdering.focs.txt\" ) {","path":"parse/SpeciesParser.cpp","position":95,"original_position":95,"commit_id":"9c468477d1932e864b484eb557d15e0db2747fd6","original_commit_id":"9c468477d1932e864b484eb557d15e0db2747fd6","user":{"login":"dbenage-cx","id":17205519,"avatar_url":"https://avatars2.githubusercontent.com/u/17205519?v=4","gravatar_id":"","url":"https://api.github.com/users/dbenage-cx","html_url":"https://github.com/dbenage-cx","followers_url":"https://api.github.com/users/dbenage-cx/followers","following_url":"https://api.github.com/users/dbenage-cx/following{/other_user}","gists_url":"https://api.github.com/users/dbenage-cx/gists{/gist_id}","starred_url":"https://api.github.com/users/dbenage-cx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbenage-cx/subscriptions","organizations_url":"https://api.github.com/users/dbenage-cx/orgs","repos_url":"https://api.github.com/users/dbenage-cx/repos","events_url":"https://api.github.com/users/dbenage-cx/events{/privacy}","received_events_url":"https://api.github.com/users/dbenage-cx/received_events","type":"User","site_admin":false},"body":"Can we use .inf for such files, or should we rename the existing .inf files?","created_at":"2018-02-13T23:12:04Z","updated_at":"2018-02-13T23:12:04Z","html_url":"https://github.com/freeorion/freeorion/pull/1992#discussion_r168033227","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1992","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/168033227"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1992#discussion_r168033227"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1992"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/1992","id":168947033,"html_url":"https://github.com/freeorion/freeorion/pull/1992","diff_url":"https://github.com/freeorion/freeorion/pull/1992.diff","patch_url":"https://github.com/freeorion/freeorion/pull/1992.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/1992","number":1992,"state":"open","locked":false,"title":"Remove stringtable includes","user":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars3.githubusercontent.com/u/84891?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"body":"This PR partially removes the misuse of the translation API to get content specific configuration values.\r\n\r\nAddresses parts of #907","created_at":"2018-02-13T20:25:10Z","updated_at":"2018-02-13T23:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10a3779cc8eec9e84de8b19784b236e0765a847c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1992/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/1992/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/1992/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/9c468477d1932e864b484eb557d15e0db2747fd6","head":{"label":"freeorion:remove-stringtable-includes","ref":"remove-stringtable-includes","sha":"9c468477d1932e864b484eb557d15e0db2747fd6","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2018-02-13T19:06:41Z","pushed_at":"2018-02-13T20:25:10Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":545232,"stargazers_count":264,"watchers_count":264,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":184,"license":null,"forks":94,"open_issues":184,"watchers":264,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"995c722673eb08ea84735e6bef20587591797e69","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars1.githubusercontent.com/u/1025550?v=4","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","deployments_url":"https://api.github.com/repos/freeorion/freeorion/deployments","created_at":"2015-03-29T08:22:20Z","updated_at":"2018-02-13T19:06:41Z","pushed_at":"2018-02-13T20:25:10Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":545232,"stargazers_count":264,"watchers_count":264,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":184,"license":null,"forks":94,"open_issues":184,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1992"},"html":{"href":"https://github.com/freeorion/freeorion/pull/1992"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1992"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/1992/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1992/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/1992/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/9c468477d1932e864b484eb557d15e0db2747fd6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dbenage-cx"}}