{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/244399099","pull_request_review_id":188362363,"id":244399099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM5OTA5OQ==","diff_hunk":"@@ -191,6 +195,37 @@ public Node apply(MutableNetwork<Node, Edge> input) {\n         Iterables.filter(input.nodes(), InstructionOutputNode.class)) {\n       InstructionOutput instructionOutput = node.getInstructionOutput();\n \n+      // If this is the input PCollection or the output PCollection for an ExecutableStage, it's\n+      // necessary to check whether the window coder is not a GlobalWindow coder.\n+      if (isExecutableStageInputPCollection(input, node)\n+          || isExecutableStageOutputPCollection(input, node)) {\n+        Coder<?> javaCoder =\n+            CloudObjects.coderFromCloudObject(CloudObject.fromSpec(instructionOutput.getCodec()));\n+        // For now, Dataflow runner harness only deal with FixedWindow.\n+        if (FullWindowedValueCoder.class.isInstance(javaCoder)) {\n+          FullWindowedValueCoder<?> windowedValueCoder = (FullWindowedValueCoder<?>) javaCoder;\n+          Coder<?> windowCoder = windowedValueCoder.getWindowCoder();\n+          if (IntervalWindowCoder.class.isInstance(windowCoder)) {\n+            fakeWindowingStrategyId = \"generatedFixedWindowingStrategy\" + idGenerator.getId();\n+            try {\n+              // Since the coder is the only needed from a WindowingStrategy, the size field of one","path":"runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/CreateExecutableStageNodeFunction.java","position":41,"original_position":41,"commit_id":"68c0e557cd3698518fef3da7ef1c26f4fc94d233","original_commit_id":"68c0e557cd3698518fef3da7ef1c26f4fc94d233","user":{"login":"boyuanzz","id":36090911,"node_id":"MDQ6VXNlcjM2MDkwOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/36090911?v=4","gravatar_id":"","url":"https://api.github.com/users/boyuanzz","html_url":"https://github.com/boyuanzz","followers_url":"https://api.github.com/users/boyuanzz/followers","following_url":"https://api.github.com/users/boyuanzz/following{/other_user}","gists_url":"https://api.github.com/users/boyuanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/boyuanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyuanzz/subscriptions","organizations_url":"https://api.github.com/users/boyuanzz/orgs","repos_url":"https://api.github.com/users/boyuanzz/repos","events_url":"https://api.github.com/users/boyuanzz/events{/privacy}","received_events_url":"https://api.github.com/users/boyuanzz/received_events","type":"User","site_admin":false},"body":"Could you please explain more about how we can manually set the coder_id to the right thing?","created_at":"2018-12-28T20:12:44Z","updated_at":"2018-12-28T20:12:44Z","html_url":"https://github.com/apache/beam/pull/7356#discussion_r244399099","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/7356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/244399099"},"html":{"href":"https://github.com/apache/beam/pull/7356#discussion_r244399099"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/7356"}},"in_reply_to_id":244296842},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/7356","id":241054006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDU0MDA2","html_url":"https://github.com/apache/beam/pull/7356","diff_url":"https://github.com/apache/beam/pull/7356.diff","patch_url":"https://github.com/apache/beam/pull/7356.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/7356","number":7356,"state":"open","locked":false,"title":"[BEAM-6231] Make Dataflow runner harness work with FixedWindow","user":{"login":"boyuanzz","id":36090911,"node_id":"MDQ6VXNlcjM2MDkwOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/36090911?v=4","gravatar_id":"","url":"https://api.github.com/users/boyuanzz","html_url":"https://github.com/boyuanzz","followers_url":"https://api.github.com/users/boyuanzz/followers","following_url":"https://api.github.com/users/boyuanzz/following{/other_user}","gists_url":"https://api.github.com/users/boyuanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/boyuanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyuanzz/subscriptions","organizations_url":"https://api.github.com/users/boyuanzz/orgs","repos_url":"https://api.github.com/users/boyuanzz/repos","events_url":"https://api.github.com/users/boyuanzz/events{/privacy}","received_events_url":"https://api.github.com/users/boyuanzz/received_events","type":"User","site_admin":false},"body":"There is a window error \"IntervalWindow cannot be cast to GlobalWindow\" introduced by https://github.com/apache/beam/pull/7015. This PR fixes this error and removes all DataflowPortabilityExecutableStageUnsupported tags. \r\nThis test report https://scans.gradle.com/s/645npxy7rmibi/tests is running with\r\n```\r\nincludeCategories 'org.apache.beam.testing.DataflowPortabilityExecutableStageUnsupported'\r\nexcludeCategories 'org.apache.beam.testing.UsesSideInputs'\r\nexcludeCategories 'org.apache.beam.testing.UsesStatefulPardo'\r\n```\r\nR: @robertwb \r\ncc: @HuangLED","created_at":"2018-12-27T00:43:41Z","updated_at":"2018-12-28T20:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f09b35d041fdf7481a017ea0652f323b4acc837e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/7356/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/7356/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/7356/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/68c0e557cd3698518fef3da7ef1c26f4fc94d233","head":{"label":"boyuanzz:fix_window","ref":"fix_window","sha":"68c0e557cd3698518fef3da7ef1c26f4fc94d233","user":{"login":"boyuanzz","id":36090911,"node_id":"MDQ6VXNlcjM2MDkwOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/36090911?v=4","gravatar_id":"","url":"https://api.github.com/users/boyuanzz","html_url":"https://github.com/boyuanzz","followers_url":"https://api.github.com/users/boyuanzz/followers","following_url":"https://api.github.com/users/boyuanzz/following{/other_user}","gists_url":"https://api.github.com/users/boyuanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/boyuanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyuanzz/subscriptions","organizations_url":"https://api.github.com/users/boyuanzz/orgs","repos_url":"https://api.github.com/users/boyuanzz/repos","events_url":"https://api.github.com/users/boyuanzz/events{/privacy}","received_events_url":"https://api.github.com/users/boyuanzz/received_events","type":"User","site_admin":false},"repo":{"id":120047461,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNDc0NjE=","name":"beam","full_name":"boyuanzz/beam","private":false,"owner":{"login":"boyuanzz","id":36090911,"node_id":"MDQ6VXNlcjM2MDkwOTEx","avatar_url":"https://avatars2.githubusercontent.com/u/36090911?v=4","gravatar_id":"","url":"https://api.github.com/users/boyuanzz","html_url":"https://github.com/boyuanzz","followers_url":"https://api.github.com/users/boyuanzz/followers","following_url":"https://api.github.com/users/boyuanzz/following{/other_user}","gists_url":"https://api.github.com/users/boyuanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/boyuanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boyuanzz/subscriptions","organizations_url":"https://api.github.com/users/boyuanzz/orgs","repos_url":"https://api.github.com/users/boyuanzz/repos","events_url":"https://api.github.com/users/boyuanzz/events{/privacy}","received_events_url":"https://api.github.com/users/boyuanzz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/boyuanzz/beam","description":"Apache Beam","fork":true,"url":"https://api.github.com/repos/boyuanzz/beam","forks_url":"https://api.github.com/repos/boyuanzz/beam/forks","keys_url":"https://api.github.com/repos/boyuanzz/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boyuanzz/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boyuanzz/beam/teams","hooks_url":"https://api.github.com/repos/boyuanzz/beam/hooks","issue_events_url":"https://api.github.com/repos/boyuanzz/beam/issues/events{/number}","events_url":"https://api.github.com/repos/boyuanzz/beam/events","assignees_url":"https://api.github.com/repos/boyuanzz/beam/assignees{/user}","branches_url":"https://api.github.com/repos/boyuanzz/beam/branches{/branch}","tags_url":"https://api.github.com/repos/boyuanzz/beam/tags","blobs_url":"https://api.github.com/repos/boyuanzz/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boyuanzz/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boyuanzz/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/boyuanzz/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boyuanzz/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/boyuanzz/beam/languages","stargazers_url":"https://api.github.com/repos/boyuanzz/beam/stargazers","contributors_url":"https://api.github.com/repos/boyuanzz/beam/contributors","subscribers_url":"https://api.github.com/repos/boyuanzz/beam/subscribers","subscription_url":"https://api.github.com/repos/boyuanzz/beam/subscription","commits_url":"https://api.github.com/repos/boyuanzz/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/boyuanzz/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/boyuanzz/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/boyuanzz/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/boyuanzz/beam/contents/{+path}","compare_url":"https://api.github.com/repos/boyuanzz/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boyuanzz/beam/merges","archive_url":"https://api.github.com/repos/boyuanzz/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boyuanzz/beam/downloads","issues_url":"https://api.github.com/repos/boyuanzz/beam/issues{/number}","pulls_url":"https://api.github.com/repos/boyuanzz/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/boyuanzz/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/boyuanzz/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boyuanzz/beam/labels{/name}","releases_url":"https://api.github.com/repos/boyuanzz/beam/releases{/id}","deployments_url":"https://api.github.com/repos/boyuanzz/beam/deployments","created_at":"2018-02-03T00:59:30Z","updated_at":"2018-07-23T23:04:09Z","pushed_at":"2018-12-27T23:11:43Z","git_url":"git://github.com/boyuanzz/beam.git","ssh_url":"git@github.com:boyuanzz/beam.git","clone_url":"https://github.com/boyuanzz/beam.git","svn_url":"https://github.com/boyuanzz/beam","homepage":"","size":112670,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dc01009613f220659a5de16bff3059810d1aa7e2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-12-28T16:12:52Z","pushed_at":"2018-12-28T19:54:54Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":114301,"stargazers_count":2429,"watchers_count":2429,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1517,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1517,"open_issues":80,"watchers":2429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/7356"},"html":{"href":"https://github.com/apache/beam/pull/7356"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/7356"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/7356/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/7356/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/7356/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/68c0e557cd3698518fef3da7ef1c26f4fc94d233"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"boyuanzz"}}