{"action":"created","issue":{"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/81","repository_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin","labels_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/81/comments","events_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/81/events","html_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/81","id":346659742,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDcxMTUy","number":81,"title":"Fixed GraphBuilderMatcher and omitReachablePaths implementation","user":{"login":"squishtronics","id":42003494,"node_id":"MDQ6VXNlcjQyMDAzNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/42003494?v=4","gravatar_id":"","url":"https://api.github.com/users/squishtronics","html_url":"https://github.com/squishtronics","followers_url":"https://api.github.com/users/squishtronics/followers","following_url":"https://api.github.com/users/squishtronics/following{/other_user}","gists_url":"https://api.github.com/users/squishtronics/gists{/gist_id}","starred_url":"https://api.github.com/users/squishtronics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squishtronics/subscriptions","organizations_url":"https://api.github.com/users/squishtronics/orgs","repos_url":"https://api.github.com/users/squishtronics/repos","events_url":"https://api.github.com/users/squishtronics/events{/privacy}","received_events_url":"https://api.github.com/users/squishtronics/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-01T15:51:58Z","updated_at":"2018-08-02T05:57:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/pulls/81","html_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/81","diff_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/81.diff","patch_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/81.patch"},"body":"Fixed error in GraphBuilderMatcher which incorrectly matched if either nodes or edges were equal, instead requiring both to match.\r\n\r\nChanged omitReachablePaths implementation in GraphBuilderVisitor so that it remove edges after the graph is created, previously it would only detect duplicate paths if nodes were added in a specific order."},"comment":{"url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/comments/409814728","html_url":"https://github.com/ferstl/depgraph-maven-plugin/pull/81#issuecomment-409814728","issue_url":"https://api.github.com/repos/ferstl/depgraph-maven-plugin/issues/81","id":409814728,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTgxNDcyOA==","user":{"login":"ferstl","id":1487727,"node_id":"MDQ6VXNlcjE0ODc3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1487727?v=4","gravatar_id":"","url":"https://api.github.com/users/ferstl","html_url":"https://github.com/ferstl","followers_url":"https://api.github.com/users/ferstl/followers","following_url":"https://api.github.com/users/ferstl/following{/other_user}","gists_url":"https://api.github.com/users/ferstl/gists{/gist_id}","starred_url":"https://api.github.com/users/ferstl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferstl/subscriptions","organizations_url":"https://api.github.com/users/ferstl/orgs","repos_url":"https://api.github.com/users/ferstl/repos","events_url":"https://api.github.com/users/ferstl/events{/privacy}","received_events_url":"https://api.github.com/users/ferstl/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T05:57:21Z","updated_at":"2018-08-02T05:57:21Z","author_association":"OWNER","body":"Hi @squishtronics \r\nThank you for your work. But I don't yet understand what problem you are trying to fix. Did you find a bug where the graph was not created correctly? If so, it would be nice to have an example to reproduce the problem.\r\nI didn't have the time to look at the details of your changes yet but I looked at your changes in the expectations of the integration tests. Both are not correct. In `aggregate_transitive-excludes.txt` module-1 and its dependencies get resolved during the resolution of module-3, not of module-2. In `aggregate_graph.dot` module-a is not an optional dependency and module-test clearly has a dependency to module-a.\r\nGenerally, the traversal order of the dependencies is essential when creating the graph."}}
{"actor":{"display_login":"ferstl"}}