{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/comments/221537298","pull_request_review_id":160206602,"id":221537298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTUzNzI5OA==","diff_hunk":"@@ -77,16 +71,16 @@ where\n ///\n /// The `Ordering` parameter determines which argument is preferred. If `Less` or `Equal` we\n /// try for each of `theirs` every one of `ours`, for `Greater` it's the other way around.\n-pub fn select_agreement<'a>(r: Ordering, ours: &str, theirs: &str) -> Result<&'a agreement::Algorithm, SecioError> {\n+pub fn select_agreement<'a>(r: Ordering, ours: &str, theirs: &str) -> Result<KeyAgreement, SecioError> {","path":"protocols/secio/src/algo_support.rs","position":33,"original_position":33,"commit_id":"02850a015c416b2f4ce583b4f9fd9e2cf7dbf9c1","original_commit_id":"02850a015c416b2f4ce583b4f9fd9e2cf7dbf9c1","user":{"login":"twittner","id":132165,"node_id":"MDQ6VXNlcjEzMjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/132165?v=4","gravatar_id":"","url":"https://api.github.com/users/twittner","html_url":"https://github.com/twittner","followers_url":"https://api.github.com/users/twittner/followers","following_url":"https://api.github.com/users/twittner/following{/other_user}","gists_url":"https://api.github.com/users/twittner/gists{/gist_id}","starred_url":"https://api.github.com/users/twittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twittner/subscriptions","organizations_url":"https://api.github.com/users/twittner/orgs","repos_url":"https://api.github.com/users/twittner/repos","events_url":"https://api.github.com/users/twittner/events{/privacy}","received_events_url":"https://api.github.com/users/twittner/received_events","type":"User","site_admin":false},"body":"`<'a>` can be removed.","created_at":"2018-10-01T09:02:38Z","updated_at":"2018-10-01T09:40:49Z","html_url":"https://github.com/libp2p/rust-libp2p/pull/519#discussion_r221537298","pull_request_url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/comments/221537298"},"html":{"href":"https://github.com/libp2p/rust-libp2p/pull/519#discussion_r221537298"},"pull_request":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519","id":218240608,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjQwNjA4","html_url":"https://github.com/libp2p/rust-libp2p/pull/519","diff_url":"https://github.com/libp2p/rust-libp2p/pull/519.diff","patch_url":"https://github.com/libp2p/rust-libp2p/pull/519.patch","issue_url":"https://api.github.com/repos/libp2p/rust-libp2p/issues/519","number":519,"state":"open","locked":false,"title":"Make secio almost compile for asmjs/wasm","user":{"login":"tomaka","id":1412254,"node_id":"MDQ6VXNlcjE0MTIyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"body":"Close #499 \r\n\r\n~~Disclaimer: this doesn't actually compile because emscripten doesn't support i128 operations. However on the Rust side everything works, and one can argue that this PR is a good first step. I'm also fine with leaving this PR on ice for some time.~~\r\nFor some reason this works now.\r\n\r\nDisclaimer: the crypto library I used (`ed25519-dalek`) is not audited, but neither is ring.\r\n\r\nThis PR replaces most of the usages of `ring` with the `ed25519-dalek`, `hmac` and `sha2` crates. The only remaining usage is for ECDH, because I'm not aware of any other library that supports this. For emscripten, the implementation uses `WebCrypto`. The `WebCrypto` path is unfortunately untested, as the code doesn't actually compile.\r\n\r\nThis adds a `rsa` feature to secio which makes it support RSA public keys. If we want to connect to IPFS nodes, this feature has to be enabled.\r\nI also removed the `libp2p-secio` feature, making secio mandatory.","created_at":"2018-09-26T09:10:16Z","updated_at":"2018-10-01T09:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"535388cc042e0a33f4c786a7e9fb2ef6de3f4468","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1003551815,"node_id":"MDU6TGFiZWwxMDAzNTUxODE1","url":"https://api.github.com/repos/libp2p/rust-libp2p/labels/pr-needs-review","name":"pr-needs-review","color":"96f2a2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519/commits","review_comments_url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519/comments","review_comment_url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/rust-libp2p/issues/519/comments","statuses_url":"https://api.github.com/repos/libp2p/rust-libp2p/statuses/02850a015c416b2f4ce583b4f9fd9e2cf7dbf9c1","head":{"label":"tomaka:secio-asmjs","ref":"secio-asmjs","sha":"02850a015c416b2f4ce583b4f9fd9e2cf7dbf9c1","user":{"login":"tomaka","id":1412254,"node_id":"MDQ6VXNlcjE0MTIyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"repo":{"id":110135073,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxMzUwNzM=","name":"libp2p-rs","full_name":"tomaka/libp2p-rs","private":false,"owner":{"login":"tomaka","id":1412254,"node_id":"MDQ6VXNlcjE0MTIyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomaka/libp2p-rs","description":"LibP2P networking library written in Rust","fork":true,"url":"https://api.github.com/repos/tomaka/libp2p-rs","forks_url":"https://api.github.com/repos/tomaka/libp2p-rs/forks","keys_url":"https://api.github.com/repos/tomaka/libp2p-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaka/libp2p-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaka/libp2p-rs/teams","hooks_url":"https://api.github.com/repos/tomaka/libp2p-rs/hooks","issue_events_url":"https://api.github.com/repos/tomaka/libp2p-rs/issues/events{/number}","events_url":"https://api.github.com/repos/tomaka/libp2p-rs/events","assignees_url":"https://api.github.com/repos/tomaka/libp2p-rs/assignees{/user}","branches_url":"https://api.github.com/repos/tomaka/libp2p-rs/branches{/branch}","tags_url":"https://api.github.com/repos/tomaka/libp2p-rs/tags","blobs_url":"https://api.github.com/repos/tomaka/libp2p-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaka/libp2p-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaka/libp2p-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaka/libp2p-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaka/libp2p-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaka/libp2p-rs/languages","stargazers_url":"https://api.github.com/repos/tomaka/libp2p-rs/stargazers","contributors_url":"https://api.github.com/repos/tomaka/libp2p-rs/contributors","subscribers_url":"https://api.github.com/repos/tomaka/libp2p-rs/subscribers","subscription_url":"https://api.github.com/repos/tomaka/libp2p-rs/subscription","commits_url":"https://api.github.com/repos/tomaka/libp2p-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaka/libp2p-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaka/libp2p-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaka/libp2p-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaka/libp2p-rs/contents/{+path}","compare_url":"https://api.github.com/repos/tomaka/libp2p-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaka/libp2p-rs/merges","archive_url":"https://api.github.com/repos/tomaka/libp2p-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaka/libp2p-rs/downloads","issues_url":"https://api.github.com/repos/tomaka/libp2p-rs/issues{/number}","pulls_url":"https://api.github.com/repos/tomaka/libp2p-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaka/libp2p-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaka/libp2p-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaka/libp2p-rs/labels{/name}","releases_url":"https://api.github.com/repos/tomaka/libp2p-rs/releases{/id}","deployments_url":"https://api.github.com/repos/tomaka/libp2p-rs/deployments","created_at":"2017-11-09T15:51:30Z","updated_at":"2018-08-21T14:18:19Z","pushed_at":"2018-10-01T09:35:38Z","git_url":"git://github.com/tomaka/libp2p-rs.git","ssh_url":"git@github.com:tomaka/libp2p-rs.git","clone_url":"https://github.com/tomaka/libp2p-rs.git","svn_url":"https://github.com/tomaka/libp2p-rs","homepage":"","size":2176,"stargazers_count":8,"watchers_count":8,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"bf066773e365e91dd7d5cc3667c26b68e24ca938","user":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":86106381,"node_id":"MDEwOlJlcG9zaXRvcnk4NjEwNjM4MQ==","name":"rust-libp2p","full_name":"libp2p/rust-libp2p","private":false,"owner":{"login":"libp2p","id":14838238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODM4MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/14838238?v=4","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libp2p/rust-libp2p","description":"The Rust Implementation of libp2p networking stack. ","fork":false,"url":"https://api.github.com/repos/libp2p/rust-libp2p","forks_url":"https://api.github.com/repos/libp2p/rust-libp2p/forks","keys_url":"https://api.github.com/repos/libp2p/rust-libp2p/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/rust-libp2p/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/rust-libp2p/teams","hooks_url":"https://api.github.com/repos/libp2p/rust-libp2p/hooks","issue_events_url":"https://api.github.com/repos/libp2p/rust-libp2p/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/rust-libp2p/events","assignees_url":"https://api.github.com/repos/libp2p/rust-libp2p/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/rust-libp2p/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/rust-libp2p/tags","blobs_url":"https://api.github.com/repos/libp2p/rust-libp2p/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/rust-libp2p/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/rust-libp2p/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/rust-libp2p/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/rust-libp2p/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/rust-libp2p/languages","stargazers_url":"https://api.github.com/repos/libp2p/rust-libp2p/stargazers","contributors_url":"https://api.github.com/repos/libp2p/rust-libp2p/contributors","subscribers_url":"https://api.github.com/repos/libp2p/rust-libp2p/subscribers","subscription_url":"https://api.github.com/repos/libp2p/rust-libp2p/subscription","commits_url":"https://api.github.com/repos/libp2p/rust-libp2p/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/rust-libp2p/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/rust-libp2p/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/rust-libp2p/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/rust-libp2p/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/rust-libp2p/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/rust-libp2p/merges","archive_url":"https://api.github.com/repos/libp2p/rust-libp2p/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/rust-libp2p/downloads","issues_url":"https://api.github.com/repos/libp2p/rust-libp2p/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/rust-libp2p/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/rust-libp2p/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/rust-libp2p/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/rust-libp2p/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/rust-libp2p/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/rust-libp2p/deployments","created_at":"2017-03-24T20:05:11Z","updated_at":"2018-10-01T09:18:04Z","pushed_at":"2018-10-01T09:35:39Z","git_url":"git://github.com/libp2p/rust-libp2p.git","ssh_url":"git@github.com:libp2p/rust-libp2p.git","clone_url":"https://github.com/libp2p/rust-libp2p.git","svn_url":"https://github.com/libp2p/rust-libp2p","homepage":"https://libp2p.io","size":1789,"stargazers_count":415,"watchers_count":415,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":60,"open_issues":104,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519"},"html":{"href":"https://github.com/libp2p/rust-libp2p/pull/519"},"issue":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/issues/519"},"comments":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/rust-libp2p/statuses/02850a015c416b2f4ce583b4f9fd9e2cf7dbf9c1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"twittner"}}