{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/EdgeML/issues/58","repository_url":"https://api.github.com/repos/Microsoft/EdgeML","labels_url":"https://api.github.com/repos/Microsoft/EdgeML/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/EdgeML/issues/58/comments","events_url":"https://api.github.com/repos/Microsoft/EdgeML/issues/58/events","html_url":"https://github.com/Microsoft/EdgeML/pull/58","id":366370749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDYwNzIy","number":58,"title":"Remove an unnecessary null pointer check in Destructor of ProtoNNPredictor.cpp Class","user":{"login":"abhijeet2096","id":21152367,"node_id":"MDQ6VXNlcjIxMTUyMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/21152367?v=4","gravatar_id":"","url":"https://api.github.com/users/abhijeet2096","html_url":"https://github.com/abhijeet2096","followers_url":"https://api.github.com/users/abhijeet2096/followers","following_url":"https://api.github.com/users/abhijeet2096/following{/other_user}","gists_url":"https://api.github.com/users/abhijeet2096/gists{/gist_id}","starred_url":"https://api.github.com/users/abhijeet2096/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhijeet2096/subscriptions","organizations_url":"https://api.github.com/users/abhijeet2096/orgs","repos_url":"https://api.github.com/users/abhijeet2096/repos","events_url":"https://api.github.com/users/abhijeet2096/events{/privacy}","received_events_url":"https://api.github.com/users/abhijeet2096/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-03T14:33:59Z","updated_at":"2018-11-10T18:57:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/EdgeML/pulls/58","html_url":"https://github.com/Microsoft/EdgeML/pull/58","diff_url":"https://github.com/Microsoft/EdgeML/pull/58.diff","patch_url":"https://github.com/Microsoft/EdgeML/pull/58.patch"},"body":"According to [1], the \"C++ language guarantees that delete p will do nothing if p is null\", so we could avoid reductant if.\r\n\r\n```\r\nif (p != nullptr)   // or just \"if (p)\"\r\n  delete p;\r\n```\r\n\r\nIssue Fixed: https://github.com/Microsoft/EdgeML/issues/48\r\n\r\nReference: \r\n[1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null"},"comment":{"url":"https://api.github.com/repos/Microsoft/EdgeML/issues/comments/437610594","html_url":"https://github.com/Microsoft/EdgeML/pull/58#issuecomment-437610594","issue_url":"https://api.github.com/repos/Microsoft/EdgeML/issues/58","id":437610594,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzYxMDU5NA==","user":{"login":"elfring","id":660477,"node_id":"MDQ6VXNlcjY2MDQ3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T18:57:17Z","updated_at":"2018-11-10T18:57:17Z","author_association":"NONE","body":"* The pull/merge request description contains a typo.\r\n* Thanks for your small source code improvement."}}
{"actor":{"display_login":"elfring"}}