{"action":"opened","number":56,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56","id":216924878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTI0ODc4","html_url":"https://github.com/dcos/dcos-diagnostics/pull/56","diff_url":"https://github.com/dcos/dcos-diagnostics/pull/56.diff","patch_url":"https://github.com/dcos/dcos-diagnostics/pull/56.patch","issue_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/56","number":56,"state":"open","locked":false,"title":"Fail when no external log providers config files","user":{"login":"janisz","id":1616386,"node_id":"MDQ6VXNlcjE2MTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1616386?v=4","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"body":"Current implementation silently goes over errors with reading `endpoint-config`. This commit changes this behaviour to fail when external config could not be loaded. No matter if the file is empty, does not exist or is invalid JSON.\r\n\r\nFixes: [DCOS_OSS-4130](https://jira.mesosphere.com/browse/DCOS_OSS-4130)","created_at":"2018-09-20T10:41:36Z","updated_at":"2018-09-20T10:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/56/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-diagnostics/statuses/78612cae15b8c92ad05357e2058fe9785ecc41b3","head":{"label":"dcos:exit_on_error_when_loading_config","ref":"exit_on_error_when_loading_config","sha":"78612cae15b8c92ad05357e2058fe9785ecc41b3","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":94367552,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM2NzU1Mg==","name":"dcos-diagnostics","full_name":"dcos/dcos-diagnostics","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos-diagnostics","description":"DC/OS Distributed Diagnostics Tool & Aggregation Service","fork":false,"url":"https://api.github.com/repos/dcos/dcos-diagnostics","forks_url":"https://api.github.com/repos/dcos/dcos-diagnostics/forks","keys_url":"https://api.github.com/repos/dcos/dcos-diagnostics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-diagnostics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-diagnostics/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-diagnostics/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-diagnostics/events","assignees_url":"https://api.github.com/repos/dcos/dcos-diagnostics/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-diagnostics/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-diagnostics/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-diagnostics/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-diagnostics/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-diagnostics/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-diagnostics/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-diagnostics/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-diagnostics/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-diagnostics/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-diagnostics/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-diagnostics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-diagnostics/merges","archive_url":"https://api.github.com/repos/dcos/dcos-diagnostics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-diagnostics/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-diagnostics/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-diagnostics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-diagnostics/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-diagnostics/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/deployments","created_at":"2017-06-14T19:49:08Z","updated_at":"2018-09-20T08:32:28Z","pushed_at":"2018-09-20T10:40:03Z","git_url":"git://github.com/dcos/dcos-diagnostics.git","ssh_url":"git@github.com:dcos/dcos-diagnostics.git","clone_url":"https://github.com/dcos/dcos-diagnostics.git","svn_url":"https://github.com/dcos/dcos-diagnostics","homepage":"","size":2807,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"d58f8899f09e93c753129f28182b72a85d2e6f08","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":94367552,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM2NzU1Mg==","name":"dcos-diagnostics","full_name":"dcos/dcos-diagnostics","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos-diagnostics","description":"DC/OS Distributed Diagnostics Tool & Aggregation Service","fork":false,"url":"https://api.github.com/repos/dcos/dcos-diagnostics","forks_url":"https://api.github.com/repos/dcos/dcos-diagnostics/forks","keys_url":"https://api.github.com/repos/dcos/dcos-diagnostics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-diagnostics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-diagnostics/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-diagnostics/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-diagnostics/events","assignees_url":"https://api.github.com/repos/dcos/dcos-diagnostics/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-diagnostics/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-diagnostics/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-diagnostics/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-diagnostics/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-diagnostics/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-diagnostics/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-diagnostics/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-diagnostics/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-diagnostics/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-diagnostics/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-diagnostics/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-diagnostics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-diagnostics/merges","archive_url":"https://api.github.com/repos/dcos/dcos-diagnostics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-diagnostics/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-diagnostics/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-diagnostics/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-diagnostics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-diagnostics/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-diagnostics/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-diagnostics/deployments","created_at":"2017-06-14T19:49:08Z","updated_at":"2018-09-20T08:32:28Z","pushed_at":"2018-09-20T10:40:03Z","git_url":"git://github.com/dcos/dcos-diagnostics.git","ssh_url":"git@github.com:dcos/dcos-diagnostics.git","clone_url":"https://github.com/dcos/dcos-diagnostics.git","svn_url":"https://github.com/dcos/dcos-diagnostics","homepage":"","size":2807,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56"},"html":{"href":"https://github.com/dcos/dcos-diagnostics/pull/56"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/56"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-diagnostics/statuses/78612cae15b8c92ad05357e2058fe9785ecc41b3"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":52,"deletions":31,"changed_files":3}}
{"actor":{"display_login":"janisz"}}