{"action":"closed","number":1312,"pull_request":{"url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312","id":172550489,"html_url":"https://github.com/uktrade/data-hub-frontend/pull/1312","diff_url":"https://github.com/uktrade/data-hub-frontend/pull/1312.diff","patch_url":"https://github.com/uktrade/data-hub-frontend/pull/1312.patch","issue_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1312","number":1312,"state":"closed","locked":false,"title":"Favour dot notation when possible in JavaScript","user":{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false},"body":"The dot notation is the preferred over square-bracket notation because\r\nit is easier to read, less verbose, and works better with aggressive\r\nJavaScript minimizers.\r\n\r\nAlso includes an autofix to existing uses of square-bracket notation.","created_at":"2018-03-02T16:47:39Z","updated_at":"2018-03-05T12:57:48Z","closed_at":"2018-03-05T12:57:48Z","merged_at":"2018-03-05T12:57:48Z","merge_commit_sha":"abbba92f0d9d10d01c72ede6bc1bf8788172e790","assignee":{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false},"assignees":[{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yozzo","id":1295319,"avatar_url":"https://avatars0.githubusercontent.com/u/1295319?v=4","gravatar_id":"","url":"https://api.github.com/users/yozzo","html_url":"https://github.com/yozzo","followers_url":"https://api.github.com/users/yozzo/followers","following_url":"https://api.github.com/users/yozzo/following{/other_user}","gists_url":"https://api.github.com/users/yozzo/gists{/gist_id}","starred_url":"https://api.github.com/users/yozzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yozzo/subscriptions","organizations_url":"https://api.github.com/users/yozzo/orgs","repos_url":"https://api.github.com/users/yozzo/repos","events_url":"https://api.github.com/users/yozzo/events{/privacy}","received_events_url":"https://api.github.com/users/yozzo/received_events","type":"User","site_admin":false},{"login":"feedmypixel","id":2305016,"avatar_url":"https://avatars0.githubusercontent.com/u/2305016?v=4","gravatar_id":"","url":"https://api.github.com/users/feedmypixel","html_url":"https://github.com/feedmypixel","followers_url":"https://api.github.com/users/feedmypixel/followers","following_url":"https://api.github.com/users/feedmypixel/following{/other_user}","gists_url":"https://api.github.com/users/feedmypixel/gists{/gist_id}","starred_url":"https://api.github.com/users/feedmypixel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedmypixel/subscriptions","organizations_url":"https://api.github.com/users/feedmypixel/orgs","repos_url":"https://api.github.com/users/feedmypixel/repos","events_url":"https://api.github.com/users/feedmypixel/events{/privacy}","received_events_url":"https://api.github.com/users/feedmypixel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312/commits","review_comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312/comments","review_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1312/comments","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/d15cc7e1b493a2e275a96c2cacf7fda826ab087f","head":{"label":"uktrade:eslint-dot-notation","ref":"eslint-dot-notation","sha":"d15cc7e1b493a2e275a96c2cacf7fda826ab087f","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-12-06T11:06:00Z","pushed_at":"2018-03-05T12:57:48Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":5270,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":38,"watchers":0,"default_branch":"develop"}},"base":{"label":"uktrade:develop","ref":"develop","sha":"6e3339b65a0ccff36bc32464d134b23f2529134a","user":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"repo":{"id":83823675,"name":"data-hub-frontend","full_name":"uktrade/data-hub-frontend","owner":{"login":"uktrade","id":15107524,"avatar_url":"https://avatars2.githubusercontent.com/u/15107524?v=4","gravatar_id":"","url":"https://api.github.com/users/uktrade","html_url":"https://github.com/uktrade","followers_url":"https://api.github.com/users/uktrade/followers","following_url":"https://api.github.com/users/uktrade/following{/other_user}","gists_url":"https://api.github.com/users/uktrade/gists{/gist_id}","starred_url":"https://api.github.com/users/uktrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uktrade/subscriptions","organizations_url":"https://api.github.com/users/uktrade/orgs","repos_url":"https://api.github.com/users/uktrade/repos","events_url":"https://api.github.com/users/uktrade/events{/privacy}","received_events_url":"https://api.github.com/users/uktrade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uktrade/data-hub-frontend","description":"The frontend rendering application for Data Hub","fork":false,"url":"https://api.github.com/repos/uktrade/data-hub-frontend","forks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/forks","keys_url":"https://api.github.com/repos/uktrade/data-hub-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uktrade/data-hub-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uktrade/data-hub-frontend/teams","hooks_url":"https://api.github.com/repos/uktrade/data-hub-frontend/hooks","issue_events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/uktrade/data-hub-frontend/events","assignees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/uktrade/data-hub-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/tags","blobs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/uktrade/data-hub-frontend/languages","stargazers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/stargazers","contributors_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contributors","subscribers_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscribers","subscription_url":"https://api.github.com/repos/uktrade/data-hub-frontend/subscription","commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/uktrade/data-hub-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/uktrade/data-hub-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/uktrade/data-hub-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uktrade/data-hub-frontend/merges","archive_url":"https://api.github.com/repos/uktrade/data-hub-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uktrade/data-hub-frontend/downloads","issues_url":"https://api.github.com/repos/uktrade/data-hub-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/uktrade/data-hub-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/uktrade/data-hub-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uktrade/data-hub-frontend/labels{/name}","releases_url":"https://api.github.com/repos/uktrade/data-hub-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/uktrade/data-hub-frontend/deployments","created_at":"2017-03-03T17:26:35Z","updated_at":"2017-12-06T11:06:00Z","pushed_at":"2018-03-05T12:57:48Z","git_url":"git://github.com/uktrade/data-hub-frontend.git","ssh_url":"git@github.com:uktrade/data-hub-frontend.git","clone_url":"https://github.com/uktrade/data-hub-frontend.git","svn_url":"https://github.com/uktrade/data-hub-frontend","homepage":"","size":5270,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":38,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312"},"html":{"href":"https://github.com/uktrade/data-hub-frontend/pull/1312"},"issue":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1312"},"comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/issues/1312/comments"},"review_comments":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312/comments"},"review_comment":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/pulls/1312/commits"},"statuses":{"href":"https://api.github.com/repos/uktrade/data-hub-frontend/statuses/d15cc7e1b493a2e275a96c2cacf7fda826ab087f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"teneightfive","id":3327997,"avatar_url":"https://avatars1.githubusercontent.com/u/3327997?v=4","gravatar_id":"","url":"https://api.github.com/users/teneightfive","html_url":"https://github.com/teneightfive","followers_url":"https://api.github.com/users/teneightfive/followers","following_url":"https://api.github.com/users/teneightfive/following{/other_user}","gists_url":"https://api.github.com/users/teneightfive/gists{/gist_id}","starred_url":"https://api.github.com/users/teneightfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teneightfive/subscriptions","organizations_url":"https://api.github.com/users/teneightfive/orgs","repos_url":"https://api.github.com/users/teneightfive/repos","events_url":"https://api.github.com/users/teneightfive/events{/privacy}","received_events_url":"https://api.github.com/users/teneightfive/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":18,"changed_files":5}}
{"actor":{"display_login":"teneightfive"}}