{"action":"closed","number":64,"pull_request":{"url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64","id":218794016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Nzk0MDE2","html_url":"https://github.com/MolSSI/QCFractal/pull/64","diff_url":"https://github.com/MolSSI/QCFractal/pull/64.diff","patch_url":"https://github.com/MolSSI/QCFractal/pull/64.patch","issue_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/64","number":64,"state":"closed","locked":false,"title":" Ensure torsion drive completed tasks pull from their queue id","user":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis makes sure the `job_map` for new Torsion Drive service tasks\r\nreference the same table in the storage layer rather than different\r\nlayers.\r\n\r\nA new bug was identified for a rare corner case where a secondary\r\nservice submits jobs after the initial query from a primary service, but\r\nbefore the tasks from the primary are submitted to the queue. We have\r\nelected not to fix that in this change, but will raise a helpful error\r\nif someone ever actually gets it.\r\n\r\nFixes #62 \r\n\r\nCredit to @dgasmith for coming up with the main fix.\r\n\r\nOnce this is merged in, we should make a pair of new issues:\r\n1. Fix the duplicate entry bug mentioned above (easier)\r\n2. Generalize the service submission process since we will have to do that anyways going forward so as to not have to fix this for every new service (harder)\r\n\r\n## Status\r\n- [x] Ready to go","created_at":"2018-09-27T21:27:27Z","updated_at":"2018-09-28T15:26:59Z","closed_at":"2018-09-28T15:26:59Z","merged_at":"2018-09-28T15:26:59Z","merge_commit_sha":"15b51b48e0321003dff45b034ebb424b1e463090","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":522022809,"node_id":"MDU6TGFiZWw1MjIwMjI4MDk=","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":1027448898,"node_id":"MDU6TGFiZWwxMDI3NDQ4ODk4","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Procedure","name":"Procedure","color":"023672","default":false},{"id":1027448180,"node_id":"MDU6TGFiZWwxMDI3NDQ4MTgw","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Service","name":"Service","color":"5770c1","default":false}],"milestone":{"url":"https://api.github.com/repos/MolSSI/QCFractal/milestones/2","html_url":"https://github.com/MolSSI/QCFractal/milestone/2","labels_url":"https://api.github.com/repos/MolSSI/QCFractal/milestones/2/labels","id":3579295,"node_id":"MDk6TWlsZXN0b25lMzU3OTI5NQ==","number":2,"title":"v0.2.0a","description":"Second alpha release with bug fixes, fleshed out documentation, and examples.","creator":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":17,"state":"open","created_at":"2018-08-17T16:22:34Z","updated_at":"2018-09-28T15:26:59Z","due_on":"2018-10-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64/commits","review_comments_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64/comments","review_comment_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/64/comments","statuses_url":"https://api.github.com/repos/MolSSI/QCFractal/statuses/ab2537d5db9143af871a42165875a74792d0e171","head":{"label":"Lnaden:td_dup_fix","ref":"td_dup_fix","sha":"ab2537d5db9143af871a42165875a74792d0e171","user":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"repo":{"id":145884903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4ODQ5MDM=","name":"QCFractal","full_name":"Lnaden/QCFractal","private":false,"owner":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lnaden/QCFractal","description":"A distributed compute and database platform for quantum chemistry. ","fork":true,"url":"https://api.github.com/repos/Lnaden/QCFractal","forks_url":"https://api.github.com/repos/Lnaden/QCFractal/forks","keys_url":"https://api.github.com/repos/Lnaden/QCFractal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lnaden/QCFractal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lnaden/QCFractal/teams","hooks_url":"https://api.github.com/repos/Lnaden/QCFractal/hooks","issue_events_url":"https://api.github.com/repos/Lnaden/QCFractal/issues/events{/number}","events_url":"https://api.github.com/repos/Lnaden/QCFractal/events","assignees_url":"https://api.github.com/repos/Lnaden/QCFractal/assignees{/user}","branches_url":"https://api.github.com/repos/Lnaden/QCFractal/branches{/branch}","tags_url":"https://api.github.com/repos/Lnaden/QCFractal/tags","blobs_url":"https://api.github.com/repos/Lnaden/QCFractal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lnaden/QCFractal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lnaden/QCFractal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lnaden/QCFractal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lnaden/QCFractal/statuses/{sha}","languages_url":"https://api.github.com/repos/Lnaden/QCFractal/languages","stargazers_url":"https://api.github.com/repos/Lnaden/QCFractal/stargazers","contributors_url":"https://api.github.com/repos/Lnaden/QCFractal/contributors","subscribers_url":"https://api.github.com/repos/Lnaden/QCFractal/subscribers","subscription_url":"https://api.github.com/repos/Lnaden/QCFractal/subscription","commits_url":"https://api.github.com/repos/Lnaden/QCFractal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lnaden/QCFractal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lnaden/QCFractal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lnaden/QCFractal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lnaden/QCFractal/contents/{+path}","compare_url":"https://api.github.com/repos/Lnaden/QCFractal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lnaden/QCFractal/merges","archive_url":"https://api.github.com/repos/Lnaden/QCFractal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lnaden/QCFractal/downloads","issues_url":"https://api.github.com/repos/Lnaden/QCFractal/issues{/number}","pulls_url":"https://api.github.com/repos/Lnaden/QCFractal/pulls{/number}","milestones_url":"https://api.github.com/repos/Lnaden/QCFractal/milestones{/number}","notifications_url":"https://api.github.com/repos/Lnaden/QCFractal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lnaden/QCFractal/labels{/name}","releases_url":"https://api.github.com/repos/Lnaden/QCFractal/releases{/id}","deployments_url":"https://api.github.com/repos/Lnaden/QCFractal/deployments","created_at":"2018-08-23T17:14:39Z","updated_at":"2018-09-24T12:56:33Z","pushed_at":"2018-09-28T15:19:00Z","git_url":"git://github.com/Lnaden/QCFractal.git","ssh_url":"git@github.com:Lnaden/QCFractal.git","clone_url":"https://github.com/Lnaden/QCFractal.git","svn_url":"https://github.com/Lnaden/QCFractal","homepage":"https://qcfractal.readthedocs.io/en/latest/?badge=latest","size":2158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MolSSI:master","ref":"master","sha":"84ee1b154117daa7b376cfd720e45ace1c2a7895","user":{"login":"MolSSI","id":26232579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjMyNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/26232579?v=4","gravatar_id":"","url":"https://api.github.com/users/MolSSI","html_url":"https://github.com/MolSSI","followers_url":"https://api.github.com/users/MolSSI/followers","following_url":"https://api.github.com/users/MolSSI/following{/other_user}","gists_url":"https://api.github.com/users/MolSSI/gists{/gist_id}","starred_url":"https://api.github.com/users/MolSSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MolSSI/subscriptions","organizations_url":"https://api.github.com/users/MolSSI/orgs","repos_url":"https://api.github.com/users/MolSSI/repos","events_url":"https://api.github.com/users/MolSSI/events{/privacy}","received_events_url":"https://api.github.com/users/MolSSI/received_events","type":"Organization","site_admin":false},"repo":{"id":79492087,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQ5MjA4Nw==","name":"QCFractal","full_name":"MolSSI/QCFractal","private":false,"owner":{"login":"MolSSI","id":26232579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjMyNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/26232579?v=4","gravatar_id":"","url":"https://api.github.com/users/MolSSI","html_url":"https://github.com/MolSSI","followers_url":"https://api.github.com/users/MolSSI/followers","following_url":"https://api.github.com/users/MolSSI/following{/other_user}","gists_url":"https://api.github.com/users/MolSSI/gists{/gist_id}","starred_url":"https://api.github.com/users/MolSSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MolSSI/subscriptions","organizations_url":"https://api.github.com/users/MolSSI/orgs","repos_url":"https://api.github.com/users/MolSSI/repos","events_url":"https://api.github.com/users/MolSSI/events{/privacy}","received_events_url":"https://api.github.com/users/MolSSI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MolSSI/QCFractal","description":"A distributed compute and database platform for quantum chemistry. ","fork":false,"url":"https://api.github.com/repos/MolSSI/QCFractal","forks_url":"https://api.github.com/repos/MolSSI/QCFractal/forks","keys_url":"https://api.github.com/repos/MolSSI/QCFractal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MolSSI/QCFractal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MolSSI/QCFractal/teams","hooks_url":"https://api.github.com/repos/MolSSI/QCFractal/hooks","issue_events_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/events{/number}","events_url":"https://api.github.com/repos/MolSSI/QCFractal/events","assignees_url":"https://api.github.com/repos/MolSSI/QCFractal/assignees{/user}","branches_url":"https://api.github.com/repos/MolSSI/QCFractal/branches{/branch}","tags_url":"https://api.github.com/repos/MolSSI/QCFractal/tags","blobs_url":"https://api.github.com/repos/MolSSI/QCFractal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MolSSI/QCFractal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MolSSI/QCFractal/git/refs{/sha}","trees_url":"https://api.github.com/repos/MolSSI/QCFractal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MolSSI/QCFractal/statuses/{sha}","languages_url":"https://api.github.com/repos/MolSSI/QCFractal/languages","stargazers_url":"https://api.github.com/repos/MolSSI/QCFractal/stargazers","contributors_url":"https://api.github.com/repos/MolSSI/QCFractal/contributors","subscribers_url":"https://api.github.com/repos/MolSSI/QCFractal/subscribers","subscription_url":"https://api.github.com/repos/MolSSI/QCFractal/subscription","commits_url":"https://api.github.com/repos/MolSSI/QCFractal/commits{/sha}","git_commits_url":"https://api.github.com/repos/MolSSI/QCFractal/git/commits{/sha}","comments_url":"https://api.github.com/repos/MolSSI/QCFractal/comments{/number}","issue_comment_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/comments{/number}","contents_url":"https://api.github.com/repos/MolSSI/QCFractal/contents/{+path}","compare_url":"https://api.github.com/repos/MolSSI/QCFractal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MolSSI/QCFractal/merges","archive_url":"https://api.github.com/repos/MolSSI/QCFractal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MolSSI/QCFractal/downloads","issues_url":"https://api.github.com/repos/MolSSI/QCFractal/issues{/number}","pulls_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls{/number}","milestones_url":"https://api.github.com/repos/MolSSI/QCFractal/milestones{/number}","notifications_url":"https://api.github.com/repos/MolSSI/QCFractal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MolSSI/QCFractal/labels{/name}","releases_url":"https://api.github.com/repos/MolSSI/QCFractal/releases{/id}","deployments_url":"https://api.github.com/repos/MolSSI/QCFractal/deployments","created_at":"2017-01-19T20:28:18Z","updated_at":"2018-09-28T14:28:48Z","pushed_at":"2018-09-28T15:26:59Z","git_url":"git://github.com/MolSSI/QCFractal.git","ssh_url":"git@github.com:MolSSI/QCFractal.git","clone_url":"https://github.com/MolSSI/QCFractal.git","svn_url":"https://github.com/MolSSI/QCFractal","homepage":"https://qcfractal.readthedocs.io/en/latest/?badge=latest","size":2150,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64"},"html":{"href":"https://github.com/MolSSI/QCFractal/pull/64"},"issue":{"href":"https://api.github.com/repos/MolSSI/QCFractal/issues/64"},"comments":{"href":"https://api.github.com/repos/MolSSI/QCFractal/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/MolSSI/QCFractal/statuses/ab2537d5db9143af871a42165875a74792d0e171"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"maintainer_can_modify":false,"commits":4,"additions":85,"deletions":27,"changed_files":5}}
{"actor":{"display_login":"dgasmith"}}