{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/223594473","pull_request_review_id":162754821,"id":223594473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzU5NDQ3Mw==","diff_hunk":"@@ -511,14 +512,12 @@ class NormaliseToMonitorTest : public CxxTest::TestSuite {\n         N_DET, N_BINS, true);\n     auto &detInfo1 = ws1->mutableDetectorInfo();\n     auto &detInfo2 = ws2->mutableDetectorInfo();\n-    for (size_t i = 0; i < N_DET; ++i) {\n-      detInfo1.setScanInterval(i, {10, 20});\n-      detInfo2.setScanInterval(i, {20, 30});\n-    }\n+    detInfo1.setScanInterval({10, 20});\n+    detInfo2.setScanInterval({20, 30});\n     // Merge\n     auto merged = WorkspaceFactory::Instance().create(ws1, 2 * N_DET);\n-    auto &detInfo = merged->mutableDetectorInfo();\n-    detInfo.merge(detInfo2);\n+    auto &cmpInfo = merged->mutableComponentInfo();\n+    cmpInfo.merge(ws2->mutableComponentInfo());","path":"Framework/Algorithms/test/NormaliseToMonitorTest.h","position":23,"original_position":23,"commit_id":"8828f33ca51f47b7a27d9b68ddd5a108f433a617","original_commit_id":"8828f33ca51f47b7a27d9b68ddd5a108f433a617","user":{"login":"SimonHeybrock","id":12912489,"node_id":"MDQ6VXNlcjEyOTEyNDg5","avatar_url":"https://avatars1.githubusercontent.com/u/12912489?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"body":"`ws2->componentInfo()`.","created_at":"2018-10-09T08:00:12Z","updated_at":"2018-10-09T08:53:20Z","html_url":"https://github.com/mantidproject/mantid/pull/23744#discussion_r223594473","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23744","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/223594473"},"html":{"href":"https://github.com/mantidproject/mantid/pull/23744#discussion_r223594473"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23744"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/23744","id":221337668,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzM3NjY4","html_url":"https://github.com/mantidproject/mantid/pull/23744","diff_url":"https://github.com/mantidproject/mantid/pull/23744.diff","patch_url":"https://github.com/mantidproject/mantid/pull/23744.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/23744","number":23744,"state":"open","locked":false,"title":"23238 remove nonsync scan","user":{"login":"nvaytet","id":39047984,"node_id":"MDQ6VXNlcjM5MDQ3OTg0","avatar_url":"https://avatars2.githubusercontent.com/u/39047984?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaytet","html_url":"https://github.com/nvaytet","followers_url":"https://api.github.com/users/nvaytet/followers","following_url":"https://api.github.com/users/nvaytet/following{/other_user}","gists_url":"https://api.github.com/users/nvaytet/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaytet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaytet/subscriptions","organizations_url":"https://api.github.com/users/nvaytet/orgs","repos_url":"https://api.github.com/users/nvaytet/repos","events_url":"https://api.github.com/users/nvaytet/events{/privacy}","received_events_url":"https://api.github.com/users/nvaytet/received_events","type":"User","site_admin":false},"body":"**Description of work.**\r\n\r\nDetectorInfo has 2 modes for scanning detectors:\r\n1. Individual time intervals per detector (non-sync scan)\r\n2. Global intervals for all detectors (sync scan)\r\nWe only need the second version, which is also simpler and can lead to optimisations.\r\n\r\nI removed all places in DetectorInfo and ComponentInfo where non-sync scan was used.\r\n`m_scanCounts` and `m_scanIntervals` are now initialised to\r\n```\r\nsize_t m_scanCounts = 1;\r\nstd::vector<std::pair<int64_t, int64_t>> m_scanIntervals{{0, 1}};\r\n```\r\ninstead of being `null` pointers.\r\n\r\nIn addition, the `merge()` operation was made private in `DetectorInfo`, and only accessible through `ComponentInfo` (via a `friend` declaration) because we need to avoid merging `DetectorInfo`without merging `ComponentInfo`, since that would effectively let us create a non-sync scan. Otherwise we cannot provide scanning-related methods in `ComponentInfo` without component index.\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nFixes #23238 \r\n\r\n<!-- delete this if you added release notes\r\n*This does not require release notes* because **fill in an explanation of why**\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://developer.mantidproject.org/IndividualTicketTesting/)):\r\n\r\n##### Code Review #####\r\n\r\n- Is the code of an acceptable quality?\r\n- Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)?\r\n- Are the unit tests small and test the class in isolation?\r\n- If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- Do changes function as described? Add comments below that describe the tests performed?\r\n- Do the changes handle unexpected situations, e.g. bad input?\r\n- Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2018-10-09T07:45:02Z","updated_at":"2018-10-09T08:53:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d50108d9dc0d0a32e201e4e1335052d7737c42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":177607615,"node_id":"MDU6TGFiZWwxNzc2MDc2MTU=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":154208631,"node_id":"MDU6TGFiZWwxNTQyMDg2MzE=","url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23744/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/23744/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/23744/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/8828f33ca51f47b7a27d9b68ddd5a108f433a617","head":{"label":"mantidproject:23238_remove_nonsync_scan","ref":"23238_remove_nonsync_scan","sha":"8828f33ca51f47b7a27d9b68ddd5a108f433a617","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","private":false,"owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-10-09T08:49:48Z","pushed_at":"2018-10-09T08:49:30Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":516274,"stargazers_count":97,"watchers_count":97,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":1866,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":58,"open_issues":1866,"watchers":97,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"598514074eeea1dbb35820aebd60244a2e56c1f2","user":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk0MTE2","name":"mantid","full_name":"mantidproject/mantid","private":false,"owner":{"login":"mantidproject","id":671496,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3MTQ5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2018-10-09T08:49:48Z","pushed_at":"2018-10-09T08:49:30Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":516274,"stargazers_count":97,"watchers_count":97,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":1866,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":58,"open_issues":1866,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23744"},"html":{"href":"https://github.com/mantidproject/mantid/pull/23744"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23744"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/23744/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23744/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/23744/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/8828f33ca51f47b7a27d9b68ddd5a108f433a617"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SimonHeybrock"}}