{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20268","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20268/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20268/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20268/events","html_url":"https://github.com/nodejs/node/pull/20268","id":317430708,"number":20268,"title":"fs/promises: ensure options.flag is defaulted to 'r' in readFile","user":{"login":"bdistin","id":18535830,"avatar_url":"https://avatars2.githubusercontent.com/u/18535830?v=4","gravatar_id":"","url":"https://api.github.com/users/bdistin","html_url":"https://github.com/bdistin","followers_url":"https://api.github.com/users/bdistin/followers","following_url":"https://api.github.com/users/bdistin/following{/other_user}","gists_url":"https://api.github.com/users/bdistin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdistin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdistin/subscriptions","organizations_url":"https://api.github.com/users/bdistin/orgs","repos_url":"https://api.github.com/users/bdistin/repos","events_url":"https://api.github.com/users/bdistin/events{/privacy}","received_events_url":"https://api.github.com/users/bdistin/received_events","type":"User","site_admin":false},"labels":[{"id":647282848,"url":"https://api.github.com/repos/nodejs/node/labels/experimental","name":"experimental","color":"c5def5","default":false},{"id":155435785,"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":340436277,"url":"https://api.github.com/repos/nodejs/node/labels/promises","name":"promises","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-04-24T23:33:00Z","updated_at":"2018-05-26T01:51:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20268","html_url":"https://github.com/nodejs/node/pull/20268","diff_url":"https://github.com/nodejs/node/pull/20268.diff","patch_url":"https://github.com/nodejs/node/pull/20268.patch"},"body":"When passing `{}` or `{ encoding: 'utf8' }` as options to readFile, the\r\nflag is not defaulted to 'r' unlike normal fs. This fix makes\r\n(fs/promises).readFile() act consistently with fs.readFile().\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/392227028","html_url":"https://github.com/nodejs/node/pull/20268#issuecomment-392227028","issue_url":"https://api.github.com/repos/nodejs/node/issues/20268","id":392227028,"user":{"login":"bdistin","id":18535830,"avatar_url":"https://avatars2.githubusercontent.com/u/18535830?v=4","gravatar_id":"","url":"https://api.github.com/users/bdistin","html_url":"https://github.com/bdistin","followers_url":"https://api.github.com/users/bdistin/followers","following_url":"https://api.github.com/users/bdistin/following{/other_user}","gists_url":"https://api.github.com/users/bdistin/gists{/gist_id}","starred_url":"https://api.github.com/users/bdistin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdistin/subscriptions","organizations_url":"https://api.github.com/users/bdistin/orgs","repos_url":"https://api.github.com/users/bdistin/repos","events_url":"https://api.github.com/users/bdistin/events{/privacy}","received_events_url":"https://api.github.com/users/bdistin/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T01:51:13Z","updated_at":"2018-05-26T01:51:13Z","author_association":"NONE","body":"bump? @nodejs/fs ??"}}
{"actor":{"display_login":"bdistin"}}