{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/comments/170461911","pull_request_review_id":99151129,"id":170461911,"diff_hunk":"@@ -78,19 +78,28 @@\n   end\n end\n \n-# TODO: change 'xdescribe' to 'describe' to run these tests\n-xdescribe \"Order Wave 2\" do\n+describe \"Order Wave 2\" do\n   describe \"Order.all\" do\n     it \"Returns an array of all orders\" do\n-      # TODO: Your test code here!\n+      Grocery::Order.all.must_be_kind_of Array\n     end\n \n     it \"Returns accurate information about the first order\" do\n-      # TODO: Your test code here!\n-    end\n \n+      Grocery::Order.all[0].id.must_equal 1\n+\n+      products = {\"Slivered Almonds\" => 22.88, \"Wholewheat flour\" => 1.93, \"Grape Seed Oil\" => 74.9}\n+      Grocery::Order.all[0].products.must_equal products","path":"specs/order_spec.rb","position":20,"original_position":20,"commit_id":"cec389ff1e2475709b55b553bb74461f5a0046e6","original_commit_id":"cec389ff1e2475709b55b553bb74461f5a0046e6","user":{"login":"droberts-ada","id":21064499,"avatar_url":"https://avatars1.githubusercontent.com/u/21064499?v=4","gravatar_id":"","url":"https://api.github.com/users/droberts-ada","html_url":"https://github.com/droberts-ada","followers_url":"https://api.github.com/users/droberts-ada/followers","following_url":"https://api.github.com/users/droberts-ada/following{/other_user}","gists_url":"https://api.github.com/users/droberts-ada/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts-ada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts-ada/subscriptions","organizations_url":"https://api.github.com/users/droberts-ada/orgs","repos_url":"https://api.github.com/users/droberts-ada/repos","events_url":"https://api.github.com/users/droberts-ada/events{/privacy}","received_events_url":"https://api.github.com/users/droberts-ada/received_events","type":"User","site_admin":false},"body":"This test looks good. One change you might make is to only call `Grocery::Order.all` once, and save the result in a local variable. Something like:\r\n\r\n```ruby\r\n# Arrange\r\nid = 1\r\nproducts = {\"Slivered Almonds\" => 22.88, \"Wholewheat flour\" => 1.93, \"Grape Seed Oil\" => 74.9}\r\n\r\n# Act\r\nfirst_order = Grocery::Order.all[0]\r\n\r\n# Assert\r\nfirst_order.id.must_equal id\r\nfirst_order.products.must_equal products\r\n```\r\n\r\nThis has the added benefit of making the _Arrange_, _Act_ and _Assert_ steps very distinct.","created_at":"2018-02-25T18:27:15Z","updated_at":"2018-02-25T18:32:45Z","html_url":"https://github.com/Ada-C9/grocery-store/pull/46#discussion_r170461911","pull_request_url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/comments/170461911"},"html":{"href":"https://github.com/Ada-C9/grocery-store/pull/46#discussion_r170461911"},"pull_request":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46","id":171038254,"html_url":"https://github.com/Ada-C9/grocery-store/pull/46","diff_url":"https://github.com/Ada-C9/grocery-store/pull/46.diff","patch_url":"https://github.com/Ada-C9/grocery-store/pull/46.patch","issue_url":"https://api.github.com/repos/Ada-C9/grocery-store/issues/46","number":46,"state":"open","locked":false,"title":"Erika Hughes - Grocery Store - Octos","user":{"login":"HughesErika","id":13161379,"avatar_url":"https://avatars0.githubusercontent.com/u/13161379?v=4","gravatar_id":"","url":"https://api.github.com/users/HughesErika","html_url":"https://github.com/HughesErika","followers_url":"https://api.github.com/users/HughesErika/followers","following_url":"https://api.github.com/users/HughesErika/following{/other_user}","gists_url":"https://api.github.com/users/HughesErika/gists{/gist_id}","starred_url":"https://api.github.com/users/HughesErika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HughesErika/subscriptions","organizations_url":"https://api.github.com/users/HughesErika/orgs","repos_url":"https://api.github.com/users/HughesErika/repos","events_url":"https://api.github.com/users/HughesErika/events{/privacy}","received_events_url":"https://api.github.com/users/HughesErika/received_events","type":"User","site_admin":false},"body":"# Grocery Store\r\n## Comprehension Questions\r\n\r\n|  Question \t|   Response\t| Instructor Response\r\n|---\t|---\t|---\r\n|   Why is it useful to put classes inside modules? \t| For organizational (namespaces) and functionality purposes I believe.    |\r\n|   What is accomplished with `raise ArgumentError`? \t|  Not sure when it comes to this project. I didn't use this. | Correct, we haven't covered this yet, it's a holdover from a previous cohort\r\n|   Why do you think we made the `.all` & `.find` methods class methods?  Why not instance methods?\t|  Not sure. | To think about why we've made them class methods, consider how your code would be different if we had made them instance methods. In that case, you would need to already have an instance of `Order` to get the list of all orders, which doesn't make much sense. With class methods, all you need is to know that there is such a thing as an `Order`, and then you can call `Order.all` to get the list.\r\n|   Why does it make sense to use inheritance for the online order?  | I didn't finish this project. I know that inheritance is in reference to classes and how they behave. Its a way to share common behaviors between a 'parent' and a 'child' class.   |\r\n|   Did the presence of automated tests change the way you thought about the problem? How? | Not sure. |\r\n","created_at":"2018-02-23T15:11:08Z","updated_at":"2018-02-25T18:32:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"589e0000028d82c0d6f1197a7522e978089c45f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46/commits","review_comments_url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46/comments","review_comment_url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C9/grocery-store/issues/46/comments","statuses_url":"https://api.github.com/repos/Ada-C9/grocery-store/statuses/cec389ff1e2475709b55b553bb74461f5a0046e6","head":{"label":"HughesErika:master","ref":"master","sha":"cec389ff1e2475709b55b553bb74461f5a0046e6","user":{"login":"HughesErika","id":13161379,"avatar_url":"https://avatars0.githubusercontent.com/u/13161379?v=4","gravatar_id":"","url":"https://api.github.com/users/HughesErika","html_url":"https://github.com/HughesErika","followers_url":"https://api.github.com/users/HughesErika/followers","following_url":"https://api.github.com/users/HughesErika/following{/other_user}","gists_url":"https://api.github.com/users/HughesErika/gists{/gist_id}","starred_url":"https://api.github.com/users/HughesErika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HughesErika/subscriptions","organizations_url":"https://api.github.com/users/HughesErika/orgs","repos_url":"https://api.github.com/users/HughesErika/repos","events_url":"https://api.github.com/users/HughesErika/events{/privacy}","received_events_url":"https://api.github.com/users/HughesErika/received_events","type":"User","site_admin":false},"repo":{"id":121795074,"name":"grocery-store","full_name":"HughesErika/grocery-store","owner":{"login":"HughesErika","id":13161379,"avatar_url":"https://avatars0.githubusercontent.com/u/13161379?v=4","gravatar_id":"","url":"https://api.github.com/users/HughesErika","html_url":"https://github.com/HughesErika","followers_url":"https://api.github.com/users/HughesErika/followers","following_url":"https://api.github.com/users/HughesErika/following{/other_user}","gists_url":"https://api.github.com/users/HughesErika/gists{/gist_id}","starred_url":"https://api.github.com/users/HughesErika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HughesErika/subscriptions","organizations_url":"https://api.github.com/users/HughesErika/orgs","repos_url":"https://api.github.com/users/HughesErika/repos","events_url":"https://api.github.com/users/HughesErika/events{/privacy}","received_events_url":"https://api.github.com/users/HughesErika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HughesErika/grocery-store","description":null,"fork":true,"url":"https://api.github.com/repos/HughesErika/grocery-store","forks_url":"https://api.github.com/repos/HughesErika/grocery-store/forks","keys_url":"https://api.github.com/repos/HughesErika/grocery-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HughesErika/grocery-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HughesErika/grocery-store/teams","hooks_url":"https://api.github.com/repos/HughesErika/grocery-store/hooks","issue_events_url":"https://api.github.com/repos/HughesErika/grocery-store/issues/events{/number}","events_url":"https://api.github.com/repos/HughesErika/grocery-store/events","assignees_url":"https://api.github.com/repos/HughesErika/grocery-store/assignees{/user}","branches_url":"https://api.github.com/repos/HughesErika/grocery-store/branches{/branch}","tags_url":"https://api.github.com/repos/HughesErika/grocery-store/tags","blobs_url":"https://api.github.com/repos/HughesErika/grocery-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HughesErika/grocery-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HughesErika/grocery-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/HughesErika/grocery-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HughesErika/grocery-store/statuses/{sha}","languages_url":"https://api.github.com/repos/HughesErika/grocery-store/languages","stargazers_url":"https://api.github.com/repos/HughesErika/grocery-store/stargazers","contributors_url":"https://api.github.com/repos/HughesErika/grocery-store/contributors","subscribers_url":"https://api.github.com/repos/HughesErika/grocery-store/subscribers","subscription_url":"https://api.github.com/repos/HughesErika/grocery-store/subscription","commits_url":"https://api.github.com/repos/HughesErika/grocery-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/HughesErika/grocery-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/HughesErika/grocery-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/HughesErika/grocery-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/HughesErika/grocery-store/contents/{+path}","compare_url":"https://api.github.com/repos/HughesErika/grocery-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HughesErika/grocery-store/merges","archive_url":"https://api.github.com/repos/HughesErika/grocery-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HughesErika/grocery-store/downloads","issues_url":"https://api.github.com/repos/HughesErika/grocery-store/issues{/number}","pulls_url":"https://api.github.com/repos/HughesErika/grocery-store/pulls{/number}","milestones_url":"https://api.github.com/repos/HughesErika/grocery-store/milestones{/number}","notifications_url":"https://api.github.com/repos/HughesErika/grocery-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HughesErika/grocery-store/labels{/name}","releases_url":"https://api.github.com/repos/HughesErika/grocery-store/releases{/id}","deployments_url":"https://api.github.com/repos/HughesErika/grocery-store/deployments","created_at":"2018-02-16T20:03:53Z","updated_at":"2018-02-16T20:03:55Z","pushed_at":"2018-02-22T18:36:29Z","git_url":"git://github.com/HughesErika/grocery-store.git","ssh_url":"git@github.com:HughesErika/grocery-store.git","clone_url":"https://github.com/HughesErika/grocery-store.git","svn_url":"https://github.com/HughesErika/grocery-store","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C9:master","ref":"master","sha":"91f5a4ee46790dfd562075890470aba02c02b7bd","user":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"repo":{"id":120687607,"name":"grocery-store","full_name":"Ada-C9/grocery-store","owner":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C9/grocery-store","description":null,"fork":true,"url":"https://api.github.com/repos/Ada-C9/grocery-store","forks_url":"https://api.github.com/repos/Ada-C9/grocery-store/forks","keys_url":"https://api.github.com/repos/Ada-C9/grocery-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C9/grocery-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C9/grocery-store/teams","hooks_url":"https://api.github.com/repos/Ada-C9/grocery-store/hooks","issue_events_url":"https://api.github.com/repos/Ada-C9/grocery-store/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C9/grocery-store/events","assignees_url":"https://api.github.com/repos/Ada-C9/grocery-store/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C9/grocery-store/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C9/grocery-store/tags","blobs_url":"https://api.github.com/repos/Ada-C9/grocery-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C9/grocery-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C9/grocery-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C9/grocery-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C9/grocery-store/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C9/grocery-store/languages","stargazers_url":"https://api.github.com/repos/Ada-C9/grocery-store/stargazers","contributors_url":"https://api.github.com/repos/Ada-C9/grocery-store/contributors","subscribers_url":"https://api.github.com/repos/Ada-C9/grocery-store/subscribers","subscription_url":"https://api.github.com/repos/Ada-C9/grocery-store/subscription","commits_url":"https://api.github.com/repos/Ada-C9/grocery-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C9/grocery-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C9/grocery-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C9/grocery-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C9/grocery-store/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C9/grocery-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C9/grocery-store/merges","archive_url":"https://api.github.com/repos/Ada-C9/grocery-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C9/grocery-store/downloads","issues_url":"https://api.github.com/repos/Ada-C9/grocery-store/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C9/grocery-store/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C9/grocery-store/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C9/grocery-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C9/grocery-store/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C9/grocery-store/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C9/grocery-store/deployments","created_at":"2018-02-08T00:02:36Z","updated_at":"2018-02-08T00:02:38Z","pushed_at":"2018-02-24T23:48:56Z","git_url":"git://github.com/Ada-C9/grocery-store.git","ssh_url":"git@github.com:Ada-C9/grocery-store.git","clone_url":"https://github.com/Ada-C9/grocery-store.git","svn_url":"https://github.com/Ada-C9/grocery-store","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":50,"open_issues":47,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46"},"html":{"href":"https://github.com/Ada-C9/grocery-store/pull/46"},"issue":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/issues/46"},"comments":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C9/grocery-store/statuses/cec389ff1e2475709b55b553bb74461f5a0046e6"}},"author_association":"NONE"}}
{"actor":{"display_login":"droberts-ada"}}