{"push_id":2771565672,"size":10,"distinct_size":10,"ref":"refs/heads/4115_fix_infinite_loop","head":"b7bba462d7f56f5d774044cba197e7e5359f8fb7","before":"af206655874f610d25658683c1cae5c520570c16","commits":[{"sha":"978f9cd06a2a678a28e8a8e5d24cf13822c388a9","author":{"name":"Jared Beck","email":"420d97235124da5bf24c51a35edb1119f653ce09@jaredbeck.com"},"message":"Add an example of merging Include with default.yml to the docs (#6134)\n\nFollow up to help confused people (including myself) from\r\nhttps://github.com/rubocop-hq/rubocop/issues/6119","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/978f9cd06a2a678a28e8a8e5d24cf13822c388a9"},{"sha":"f0050e69c6b5997ec9fcc3d8950977a3f80a43d8","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"Varify that there is newline at EOL of CHANGELOG.md\n\nThis PR adds a new spec to project_spec confirms that there\nis a newline at end of CHANGELOG.md file.\n\nFor example, run the test when there is no newline as follows.\n\n```diff\n% git diff\ndiff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 3303f22e2..744f681b2 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -3493,4 +3493,4 @@\n [@kenman345]: https://github.com/kenman345\n [@nijikon]: https://github.com/nijikon\n [@mikeyhew]: https://github.com/mikeyhew\n-[@kenman345]: https://github.com/kenman345\n+[@kenman345]: https://github.com/kenman345\n\\ No newline at end of file\n```\n\nThe test fails.\n\n```console\n% rspec spec/project_spec.rb\nRun options: include {:focus=>true}\n\nAll examples were filtered out; ignoring {:focus=>true}\n\nRandomized with seed 65019\n.F................\n\nFailures:\n\n  1) RuboCop Project changelog has newline at end of file\n     Failure/Error: expect(changelog.end_with?(\"\\n\")).to be true\n\n       expected true\n            got false\n     # ./spec/project_spec.rb:100:in `block (3 levels) in\n            <top (required)>'\n\nFinished in 1.42 seconds (files took 2.65 seconds to load)\n18 examples, 1 failure\n\nFailed examples:\n\nrspec ./spec/project_spec.rb:99 # RuboCop Project changelog has newline\nat end of file\n```\n\nWith this change, newline of CHANGELOG.md will not be mixed with\nanother commit, and the difference of the individual commit will\nbe clarified.\n\nRefer: https://github.com/rubocop-hq/rubocop/pull/6114/files","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/f0050e69c6b5997ec9fcc3d8950977a3f80a43d8"},{"sha":"6795d6dff685ffd2ad2ffdf73b9a6b9fc70c72e1","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"Verify CHANGELOG.md should not duplicate contributor names\n\nThis commit adds a new spec to project_spec confirms that\nCHANGELOG.md should not duplicate contributor names.","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/6795d6dff685ffd2ad2ffdf73b9a6b9fc70c72e1"},{"sha":"03f66a61b9e17e236c5d48f22b22669a6ffa6a3f","author":{"name":"Mike Kenyon","email":"75e91291951205528b64b1cd362d7f89c6e1e1b5@pivotal.io"},"message":"Allow `db` as method parameter in default config\n\nAdd `db` to AllowedNames in default configuration for cop\nNaming/UncommunicativeMethodParamName in order to allow talking about or\nconfiguring a particular database.","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/03f66a61b9e17e236c5d48f22b22669a6ffa6a3f"},{"sha":"c853715c77656574d5cea83b1a283c3087c5a1f0","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"Merge pull request #6137 from mkenyon/allow-db-in-naming-uncommunicative\n\nAllow `db` to allowed names of `Naming/UncommunicativeMethodParamName` cop in default config","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/c853715c77656574d5cea83b1a283c3087c5a1f0"},{"sha":"1bff66b2b8bafd215c106ee06411277d5554581d","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"Use https instead of http for github.com\n\nThis commit is a nitpick.\n\ngithub.com is https by default.\nThe files under the relnotes directory have already\nbeen cut and have not been changed.","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/1bff66b2b8bafd215c106ee06411277d5554581d"},{"sha":"4ba783ba0c344a70e972eda3d9a389fb640e5a4b","author":{"name":"Alexander Popov","email":"d6fd7d3ac122b93163939623901f58e5194c17ae@gmail.com"},"message":"Add `IgnoredMethods` option to `Style/NumericPredicate` cop","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/4ba783ba0c344a70e972eda3d9a389fb640e5a4b"},{"sha":"5cc9aa855e5711bd8484da65a8f1c5be0826cd7b","author":{"name":"Alexander Popov","email":"d6fd7d3ac122b93163939623901f58e5194c17ae@gmail.com"},"message":"Add `IgnoredMethods` mixin","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/5cc9aa855e5711bd8484da65a8f1c5be0826cd7b"},{"sha":"514131b3a50fdb456b9090db2d9e9e0fff1a90cb","author":{"name":"Koichi ITO","email":"62fb6e080cf43b35af11716cc49ab9063e71c433@gmail.com"},"message":"[Fix #6132] Fix a false negative for `Naming/FileName` (#6145)\n\nFixes #6132.\r\n\r\n### Summary\r\n\r\nThis PR fixes a false negative for `Naming/FileName`\r\nwhen `Include` of `AllCops` is the default setting.\r\n\r\nThe important change in this PR is below.\r\n\r\n```diff\r\ndiff --git a/lib/rubocop/cop/naming/file_name.rb\r\nb/lib/rubocop/cop/naming/file_name.rb\r\nindex a025a73b7..be3f1c5aa 100644\r\n--- a/lib/rubocop/cop/naming/file_name.rb\r\n+++ b/lib/rubocop/cop/naming/file_name.rb\r\n@@ -32,7 +32,7 @@ module RuboCop\r\n\r\n         def investigate(processed_source)\r\n           file_path = processed_source.file_path\r\n-          return if config.file_to_include?(file_path)\r\n+          return if config.file_to_exclude?(file_path)\r\n```\r\n\r\nThe problem is that the target to be excluded was\r\n`Include` instead of `Exclude`.\r\n\r\nAlso this PR adds the `RuboCop::Config#allowed_camel_case_file?`\r\nmethod to judge ignoring `Gemfile`, `Rakefile`, etc\r\ndescribed in` Include`.\r\n\r\n### Other Information\r\n\r\nThis false negative was noticed by adding `**/*.rb` to\r\nconfig/default.yml at rubocop-hq/rubocop#5882.\r\n\r\nhttps://github.com/rubocop-hq/rubocop/pull/5882/files#diff-e93280b3b31a6438c533a5f3232340d8R18","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/514131b3a50fdb456b9090db2d9e9e0fff1a90cb"},{"sha":"b7bba462d7f56f5d774044cba197e7e5359f8fb7","author":{"name":"Bozhidar Batsov","email":"219199d75e607b143e770035d8a9199c2af66000@gmail.com"},"message":"Merge branch 'master' into 4115_fix_infinite_loop","distinct":true,"url":"https://api.github.com/repos/jonas054/rubocop/commits/b7bba462d7f56f5d774044cba197e7e5359f8fb7"}]}
{"actor":{"display_login":"bbatsov"}}