{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/engine/issues/6117","repository_url":"https://api.github.com/repos/flutter/engine","labels_url":"https://api.github.com/repos/flutter/engine/issues/6117/labels{/name}","comments_url":"https://api.github.com/repos/flutter/engine/issues/6117/comments","events_url":"https://api.github.com/repos/flutter/engine/issues/6117/events","html_url":"https://github.com/flutter/engine/pull/6117","id":355383671,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTI2NDA0","number":6117,"title":"Create new FlutterActivity, FlutterFragment, and FlutterShellArgs","user":{"login":"matthew-carroll","id":7259036,"node_id":"MDQ6VXNlcjcyNTkwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7259036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-carroll","html_url":"https://github.com/matthew-carroll","followers_url":"https://api.github.com/users/matthew-carroll/followers","following_url":"https://api.github.com/users/matthew-carroll/following{/other_user}","gists_url":"https://api.github.com/users/matthew-carroll/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-carroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-carroll/subscriptions","organizations_url":"https://api.github.com/users/matthew-carroll/orgs","repos_url":"https://api.github.com/users/matthew-carroll/repos","events_url":"https://api.github.com/users/matthew-carroll/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-carroll/received_events","type":"User","site_admin":false},"labels":[{"id":487933774,"node_id":"MDU6TGFiZWw0ODc5MzM3NzQ=","url":"https://api.github.com/repos/flutter/engine/labels/cla:%20no","name":"cla: no","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-30T00:50:17Z","updated_at":"2018-08-30T20:19:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/6117","html_url":"https://github.com/flutter/engine/pull/6117","diff_url":"https://github.com/flutter/engine/pull/6117.diff","patch_url":"https://github.com/flutter/engine/pull/6117.patch"},"body":"This PR kicks off a larger project.  To understand the general direction, please review:\r\nhttps://docs.google.com/document/d/1TaDV1ZAwBeVBkBA2rtBbt1BRr96WSFqEv6MNAHdgmGY/edit?usp=sharing\r\n\r\nThe plan for PRs is to put up PRs of a manageable size, have them vetted as much as possible, merge them into a staging branch, and then upon project completion, marge the staging branch into master.\r\n\r\nGoals of this PR:\r\n- Reduce FlutterActivity definition to only the OS signals that MUST be handled by an Activity and nothing else.\r\n- Move all existing FlutterActivity to FlutterFragment that can be moved\r\n- Write all Javadocs that make sense at this juncture of development for FlutterActivity and FlutterFragment\r\n\r\nAnti-Goals of this PR:\r\n- Establish official new packaging structure\r\n- Finalize FlutterActivity and FlutterFragment\r\n- Determine packaging and distribution strategy for embedding APIs\r\n\r\nThere are a number of TODOs in this code that are left as open ended questions until I'm able to track down good answers.  If you have a good answer, please leave it in a comment!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/flutter/engine/issues/comments/417453831","html_url":"https://github.com/flutter/engine/pull/6117#issuecomment-417453831","issue_url":"https://api.github.com/repos/flutter/engine/issues/6117","id":417453831,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQ1MzgzMQ==","user":{"login":"googlebot","id":5384588,"node_id":"MDQ6VXNlcjUzODQ1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5384588?v=4","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T20:19:07Z","updated_at":"2018-08-30T20:19:07Z","author_association":"NONE","body":"So there's good news and bad news.\n\n:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so.  Everything is all good there.\n\n:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter.  We need to confirm that all authors are ok with their commits being contributed to this project.  Please have them confirm that here in the pull request.\n\n*Note to project maintainer: This is a terminal state, meaning the `cla/google` commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the `cla` label to `yes` (if enabled on your project), and then merge this pull request when appropriate.*\n\n<!-- need_author_consent -->"}}
{"actor":{"display_login":"googlebot"}}