{"action":"closed","number":3139,"pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/3139","id":189881462,"html_url":"https://github.com/runelite/runelite/pull/3139","diff_url":"https://github.com/runelite/runelite/pull/3139.diff","patch_url":"https://github.com/runelite/runelite/pull/3139.patch","issue_url":"https://api.github.com/repos/runelite/runelite/issues/3139","number":3139,"state":"closed","locked":false,"title":"Screenmarkers plugin redesign","user":{"login":"psikoi","id":3278148,"avatar_url":"https://avatars0.githubusercontent.com/u/3278148?v=4","gravatar_id":"","url":"https://api.github.com/users/psikoi","html_url":"https://github.com/psikoi","followers_url":"https://api.github.com/users/psikoi/followers","following_url":"https://api.github.com/users/psikoi/following{/other_user}","gists_url":"https://api.github.com/users/psikoi/gists{/gist_id}","starred_url":"https://api.github.com/users/psikoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psikoi/subscriptions","organizations_url":"https://api.github.com/users/psikoi/orgs","repos_url":"https://api.github.com/users/psikoi/repos","events_url":"https://api.github.com/users/psikoi/events{/privacy}","received_events_url":"https://api.github.com/users/psikoi/received_events","type":"User","site_admin":false},"body":"I'm sorry, it's 8h30m in the morning and I have been coding this for\r\n7 straight hours, I underestimated the size of this commit.\r\nI can't think clearly enough to write a proper commit or PR message.\r\n\r\nI would ask of the other developers that were involved in this project already to please finish this PR.\r\n@Kamielvf  @deathbeam  @Adam- \r\n\r\nTO-DO list:\r\n- (Maybe) add a PluginErrorPanel explaining what screen markers are if the list is empty (see implementations on ExpTrackers or Ge)\r\n- Hover effects, different shade versions of icons as an hover effect\r\n- Only allow creation of markers when logged in, and if player logs out in the process of creating one, dismiss the creation mode\r\n\r\nI'm sorry if the code isn't up to my latest standarts, just trying to get this out before thursday, would love some patches from other devs.\r\n","created_at":"2018-05-23T07:36:24Z","updated_at":"2018-05-24T08:01:39Z","closed_at":"2018-05-24T08:01:39Z","merged_at":"2018-05-24T08:01:39Z","merge_commit_sha":"b9f1b6e1ef9373e445854f39c2de4018125ea101","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366780279,"url":"https://api.github.com/repos/runelite/runelite/labels/bug","name":"bug","color":"ee0701","default":true},{"id":771846940,"url":"https://api.github.com/repos/runelite/runelite/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runelite/runelite/pulls/3139/commits","review_comments_url":"https://api.github.com/repos/runelite/runelite/pulls/3139/comments","review_comment_url":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/3139/comments","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/c30b53b82edd5e94ccf40f8911f68edcc02f5246","head":{"label":"psikoi:screen-markers-redesign","ref":"screen-markers-redesign","sha":"c30b53b82edd5e94ccf40f8911f68edcc02f5246","user":{"login":"psikoi","id":3278148,"avatar_url":"https://avatars0.githubusercontent.com/u/3278148?v=4","gravatar_id":"","url":"https://api.github.com/users/psikoi","html_url":"https://github.com/psikoi","followers_url":"https://api.github.com/users/psikoi/followers","following_url":"https://api.github.com/users/psikoi/following{/other_user}","gists_url":"https://api.github.com/users/psikoi/gists{/gist_id}","starred_url":"https://api.github.com/users/psikoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psikoi/subscriptions","organizations_url":"https://api.github.com/users/psikoi/orgs","repos_url":"https://api.github.com/users/psikoi/repos","events_url":"https://api.github.com/users/psikoi/events{/privacy}","received_events_url":"https://api.github.com/users/psikoi/received_events","type":"User","site_admin":false},"repo":{"id":127810132,"name":"runelite","full_name":"psikoi/runelite","owner":{"login":"psikoi","id":3278148,"avatar_url":"https://avatars0.githubusercontent.com/u/3278148?v=4","gravatar_id":"","url":"https://api.github.com/users/psikoi","html_url":"https://github.com/psikoi","followers_url":"https://api.github.com/users/psikoi/followers","following_url":"https://api.github.com/users/psikoi/following{/other_user}","gists_url":"https://api.github.com/users/psikoi/gists{/gist_id}","starred_url":"https://api.github.com/users/psikoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psikoi/subscriptions","organizations_url":"https://api.github.com/users/psikoi/orgs","repos_url":"https://api.github.com/users/psikoi/repos","events_url":"https://api.github.com/users/psikoi/events{/privacy}","received_events_url":"https://api.github.com/users/psikoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psikoi/runelite","description":"Open source Old School RuneScape client","fork":true,"url":"https://api.github.com/repos/psikoi/runelite","forks_url":"https://api.github.com/repos/psikoi/runelite/forks","keys_url":"https://api.github.com/repos/psikoi/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psikoi/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psikoi/runelite/teams","hooks_url":"https://api.github.com/repos/psikoi/runelite/hooks","issue_events_url":"https://api.github.com/repos/psikoi/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/psikoi/runelite/events","assignees_url":"https://api.github.com/repos/psikoi/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/psikoi/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/psikoi/runelite/tags","blobs_url":"https://api.github.com/repos/psikoi/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psikoi/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psikoi/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/psikoi/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psikoi/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/psikoi/runelite/languages","stargazers_url":"https://api.github.com/repos/psikoi/runelite/stargazers","contributors_url":"https://api.github.com/repos/psikoi/runelite/contributors","subscribers_url":"https://api.github.com/repos/psikoi/runelite/subscribers","subscription_url":"https://api.github.com/repos/psikoi/runelite/subscription","commits_url":"https://api.github.com/repos/psikoi/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/psikoi/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/psikoi/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/psikoi/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/psikoi/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/psikoi/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psikoi/runelite/merges","archive_url":"https://api.github.com/repos/psikoi/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psikoi/runelite/downloads","issues_url":"https://api.github.com/repos/psikoi/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/psikoi/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/psikoi/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/psikoi/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psikoi/runelite/labels{/name}","releases_url":"https://api.github.com/repos/psikoi/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/psikoi/runelite/deployments","created_at":"2018-04-02T20:42:07Z","updated_at":"2018-05-23T02:19:30Z","pushed_at":"2018-05-24T06:07:27Z","git_url":"git://github.com/psikoi/runelite.git","ssh_url":"git@github.com:psikoi/runelite.git","clone_url":"https://github.com/psikoi/runelite.git","svn_url":"https://github.com/psikoi/runelite","homepage":"https://runelite.net","size":42215,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"runelite:master","ref":"master","sha":"5b1289afa8717960701d43ee8b1e153b6a7cd1a0","user":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"repo":{"id":57461213,"name":"runelite","full_name":"runelite/runelite","owner":{"login":"runelite","id":13814776,"avatar_url":"https://avatars1.githubusercontent.com/u/13814776?v=4","gravatar_id":"","url":"https://api.github.com/users/runelite","html_url":"https://github.com/runelite","followers_url":"https://api.github.com/users/runelite/followers","following_url":"https://api.github.com/users/runelite/following{/other_user}","gists_url":"https://api.github.com/users/runelite/gists{/gist_id}","starred_url":"https://api.github.com/users/runelite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runelite/subscriptions","organizations_url":"https://api.github.com/users/runelite/orgs","repos_url":"https://api.github.com/users/runelite/repos","events_url":"https://api.github.com/users/runelite/events{/privacy}","received_events_url":"https://api.github.com/users/runelite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runelite/runelite","description":"Open source Old School RuneScape client","fork":false,"url":"https://api.github.com/repos/runelite/runelite","forks_url":"https://api.github.com/repos/runelite/runelite/forks","keys_url":"https://api.github.com/repos/runelite/runelite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runelite/runelite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runelite/runelite/teams","hooks_url":"https://api.github.com/repos/runelite/runelite/hooks","issue_events_url":"https://api.github.com/repos/runelite/runelite/issues/events{/number}","events_url":"https://api.github.com/repos/runelite/runelite/events","assignees_url":"https://api.github.com/repos/runelite/runelite/assignees{/user}","branches_url":"https://api.github.com/repos/runelite/runelite/branches{/branch}","tags_url":"https://api.github.com/repos/runelite/runelite/tags","blobs_url":"https://api.github.com/repos/runelite/runelite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runelite/runelite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runelite/runelite/git/refs{/sha}","trees_url":"https://api.github.com/repos/runelite/runelite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runelite/runelite/statuses/{sha}","languages_url":"https://api.github.com/repos/runelite/runelite/languages","stargazers_url":"https://api.github.com/repos/runelite/runelite/stargazers","contributors_url":"https://api.github.com/repos/runelite/runelite/contributors","subscribers_url":"https://api.github.com/repos/runelite/runelite/subscribers","subscription_url":"https://api.github.com/repos/runelite/runelite/subscription","commits_url":"https://api.github.com/repos/runelite/runelite/commits{/sha}","git_commits_url":"https://api.github.com/repos/runelite/runelite/git/commits{/sha}","comments_url":"https://api.github.com/repos/runelite/runelite/comments{/number}","issue_comment_url":"https://api.github.com/repos/runelite/runelite/issues/comments{/number}","contents_url":"https://api.github.com/repos/runelite/runelite/contents/{+path}","compare_url":"https://api.github.com/repos/runelite/runelite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runelite/runelite/merges","archive_url":"https://api.github.com/repos/runelite/runelite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runelite/runelite/downloads","issues_url":"https://api.github.com/repos/runelite/runelite/issues{/number}","pulls_url":"https://api.github.com/repos/runelite/runelite/pulls{/number}","milestones_url":"https://api.github.com/repos/runelite/runelite/milestones{/number}","notifications_url":"https://api.github.com/repos/runelite/runelite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runelite/runelite/labels{/name}","releases_url":"https://api.github.com/repos/runelite/runelite/releases{/id}","deployments_url":"https://api.github.com/repos/runelite/runelite/deployments","created_at":"2016-04-30T20:48:02Z","updated_at":"2018-05-24T01:30:48Z","pushed_at":"2018-05-24T08:01:39Z","git_url":"git://github.com/runelite/runelite.git","ssh_url":"git@github.com:runelite/runelite.git","clone_url":"https://github.com/runelite/runelite.git","svn_url":"https://github.com/runelite/runelite","homepage":"https://runelite.net","size":15261,"stargazers_count":882,"watchers_count":882,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1120,"mirror_url":null,"archived":false,"open_issues_count":898,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":1120,"open_issues":898,"watchers":882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runelite/runelite/pulls/3139"},"html":{"href":"https://github.com/runelite/runelite/pull/3139"},"issue":{"href":"https://api.github.com/repos/runelite/runelite/issues/3139"},"comments":{"href":"https://api.github.com/repos/runelite/runelite/issues/3139/comments"},"review_comments":{"href":"https://api.github.com/repos/runelite/runelite/pulls/3139/comments"},"review_comment":{"href":"https://api.github.com/repos/runelite/runelite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runelite/runelite/pulls/3139/commits"},"statuses":{"href":"https://api.github.com/repos/runelite/runelite/statuses/c30b53b82edd5e94ccf40f8911f68edcc02f5246"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"deathbeam","id":5115805,"avatar_url":"https://avatars3.githubusercontent.com/u/5115805?v=4","gravatar_id":"","url":"https://api.github.com/users/deathbeam","html_url":"https://github.com/deathbeam","followers_url":"https://api.github.com/users/deathbeam/followers","following_url":"https://api.github.com/users/deathbeam/following{/other_user}","gists_url":"https://api.github.com/users/deathbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbeam/subscriptions","organizations_url":"https://api.github.com/users/deathbeam/orgs","repos_url":"https://api.github.com/users/deathbeam/repos","events_url":"https://api.github.com/users/deathbeam/events{/privacy}","received_events_url":"https://api.github.com/users/deathbeam/received_events","type":"User","site_admin":false},"comments":7,"review_comments":10,"maintainer_can_modify":false,"commits":2,"additions":671,"deletions":169,"changed_files":22}}
{"actor":{"display_login":"deathbeam"}}