{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/shibani/java_server/pulls/22","id":202356509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzU2NTA5","html_url":"https://github.com/shibani/java_server/pull/22","diff_url":"https://github.com/shibani/java_server/pull/22.diff","patch_url":"https://github.com/shibani/java_server/pull/22.patch","issue_url":"https://api.github.com/repos/shibani/java_server/issues/22","number":22,"state":"closed","locked":false,"title":"Feature/directory links","user":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"body":"## Pivotal Link\r\nhttps://www.pivotaltracker.com/story/show/159011776\r\n\r\n## Description\r\n- greenlit `Directory Links` test in Cobspec\r\n- Updated the method that built and returned a Directory Listing to `directoryLinksBody`.  It now wraps each listing in html link tags.\r\n- Updated the parameter used by Directory Listing to take in a RequestParams object instead of a String.\r\n- Added the `htmlbuilder` helper method, to generate an html wrapper.\r\n- Created a dummy directory in the `test-listing` directory (in `test`) to confirm that links to directories were also returned in our tests (added a `.gitkeep` file to prevent the directory from collapsing in git and subsequently causing the test to fail on Travis)\r\n- Updated links to use `relative paths` so that they work in the browser.\r\n\r\n","created_at":"2018-07-18T19:31:49Z","updated_at":"2018-07-18T20:38:45Z","closed_at":"2018-07-18T20:38:45Z","merged_at":"2018-07-18T20:38:45Z","merge_commit_sha":"3e1269dcc7ae1fe888a13e38b7e7342d0cc4f0dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shibani/java_server/pulls/22/commits","review_comments_url":"https://api.github.com/repos/shibani/java_server/pulls/22/comments","review_comment_url":"https://api.github.com/repos/shibani/java_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shibani/java_server/issues/22/comments","statuses_url":"https://api.github.com/repos/shibani/java_server/statuses/7ffe05fde61e0a546ca715a565d6dba5e4b6cd59","head":{"label":"shibani:feature/directory-links","ref":"feature/directory-links","sha":"7ffe05fde61e0a546ca715a565d6dba5e4b6cd59","user":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"repo":{"id":137762445,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NjI0NDU=","name":"java_server","full_name":"shibani/java_server","owner":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shibani/java_server","description":null,"fork":false,"url":"https://api.github.com/repos/shibani/java_server","forks_url":"https://api.github.com/repos/shibani/java_server/forks","keys_url":"https://api.github.com/repos/shibani/java_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shibani/java_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shibani/java_server/teams","hooks_url":"https://api.github.com/repos/shibani/java_server/hooks","issue_events_url":"https://api.github.com/repos/shibani/java_server/issues/events{/number}","events_url":"https://api.github.com/repos/shibani/java_server/events","assignees_url":"https://api.github.com/repos/shibani/java_server/assignees{/user}","branches_url":"https://api.github.com/repos/shibani/java_server/branches{/branch}","tags_url":"https://api.github.com/repos/shibani/java_server/tags","blobs_url":"https://api.github.com/repos/shibani/java_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shibani/java_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shibani/java_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/shibani/java_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shibani/java_server/statuses/{sha}","languages_url":"https://api.github.com/repos/shibani/java_server/languages","stargazers_url":"https://api.github.com/repos/shibani/java_server/stargazers","contributors_url":"https://api.github.com/repos/shibani/java_server/contributors","subscribers_url":"https://api.github.com/repos/shibani/java_server/subscribers","subscription_url":"https://api.github.com/repos/shibani/java_server/subscription","commits_url":"https://api.github.com/repos/shibani/java_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/shibani/java_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/shibani/java_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/shibani/java_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/shibani/java_server/contents/{+path}","compare_url":"https://api.github.com/repos/shibani/java_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shibani/java_server/merges","archive_url":"https://api.github.com/repos/shibani/java_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shibani/java_server/downloads","issues_url":"https://api.github.com/repos/shibani/java_server/issues{/number}","pulls_url":"https://api.github.com/repos/shibani/java_server/pulls{/number}","milestones_url":"https://api.github.com/repos/shibani/java_server/milestones{/number}","notifications_url":"https://api.github.com/repos/shibani/java_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shibani/java_server/labels{/name}","releases_url":"https://api.github.com/repos/shibani/java_server/releases{/id}","deployments_url":"https://api.github.com/repos/shibani/java_server/deployments","created_at":"2018-06-18T14:29:38Z","updated_at":"2018-07-18T13:59:30Z","pushed_at":"2018-07-18T20:38:45Z","git_url":"git://github.com/shibani/java_server.git","ssh_url":"git@github.com:shibani/java_server.git","clone_url":"https://github.com/shibani/java_server.git","svn_url":"https://github.com/shibani/java_server","homepage":null,"size":309,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"shibani:master","ref":"master","sha":"4bbb322e19d19a48fcc098650af00e3e03bee7c3","user":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"repo":{"id":137762445,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NjI0NDU=","name":"java_server","full_name":"shibani/java_server","owner":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shibani/java_server","description":null,"fork":false,"url":"https://api.github.com/repos/shibani/java_server","forks_url":"https://api.github.com/repos/shibani/java_server/forks","keys_url":"https://api.github.com/repos/shibani/java_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shibani/java_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shibani/java_server/teams","hooks_url":"https://api.github.com/repos/shibani/java_server/hooks","issue_events_url":"https://api.github.com/repos/shibani/java_server/issues/events{/number}","events_url":"https://api.github.com/repos/shibani/java_server/events","assignees_url":"https://api.github.com/repos/shibani/java_server/assignees{/user}","branches_url":"https://api.github.com/repos/shibani/java_server/branches{/branch}","tags_url":"https://api.github.com/repos/shibani/java_server/tags","blobs_url":"https://api.github.com/repos/shibani/java_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shibani/java_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shibani/java_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/shibani/java_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shibani/java_server/statuses/{sha}","languages_url":"https://api.github.com/repos/shibani/java_server/languages","stargazers_url":"https://api.github.com/repos/shibani/java_server/stargazers","contributors_url":"https://api.github.com/repos/shibani/java_server/contributors","subscribers_url":"https://api.github.com/repos/shibani/java_server/subscribers","subscription_url":"https://api.github.com/repos/shibani/java_server/subscription","commits_url":"https://api.github.com/repos/shibani/java_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/shibani/java_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/shibani/java_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/shibani/java_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/shibani/java_server/contents/{+path}","compare_url":"https://api.github.com/repos/shibani/java_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shibani/java_server/merges","archive_url":"https://api.github.com/repos/shibani/java_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shibani/java_server/downloads","issues_url":"https://api.github.com/repos/shibani/java_server/issues{/number}","pulls_url":"https://api.github.com/repos/shibani/java_server/pulls{/number}","milestones_url":"https://api.github.com/repos/shibani/java_server/milestones{/number}","notifications_url":"https://api.github.com/repos/shibani/java_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shibani/java_server/labels{/name}","releases_url":"https://api.github.com/repos/shibani/java_server/releases{/id}","deployments_url":"https://api.github.com/repos/shibani/java_server/deployments","created_at":"2018-06-18T14:29:38Z","updated_at":"2018-07-18T13:59:30Z","pushed_at":"2018-07-18T20:38:45Z","git_url":"git://github.com/shibani/java_server.git","ssh_url":"git@github.com:shibani/java_server.git","clone_url":"https://github.com/shibani/java_server.git","svn_url":"https://github.com/shibani/java_server","homepage":null,"size":309,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shibani/java_server/pulls/22"},"html":{"href":"https://github.com/shibani/java_server/pull/22"},"issue":{"href":"https://api.github.com/repos/shibani/java_server/issues/22"},"comments":{"href":"https://api.github.com/repos/shibani/java_server/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/shibani/java_server/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/shibani/java_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shibani/java_server/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/shibani/java_server/statuses/7ffe05fde61e0a546ca715a565d6dba5e4b6cd59"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shibani","id":874357,"node_id":"MDQ6VXNlcjg3NDM1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/874357?v=4","gravatar_id":"","url":"https://api.github.com/users/shibani","html_url":"https://github.com/shibani","followers_url":"https://api.github.com/users/shibani/followers","following_url":"https://api.github.com/users/shibani/following{/other_user}","gists_url":"https://api.github.com/users/shibani/gists{/gist_id}","starred_url":"https://api.github.com/users/shibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibani/subscriptions","organizations_url":"https://api.github.com/users/shibani/orgs","repos_url":"https://api.github.com/users/shibani/repos","events_url":"https://api.github.com/users/shibani/events{/privacy}","received_events_url":"https://api.github.com/users/shibani/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":88,"deletions":28,"changed_files":4}}
{"actor":{"display_login":"shibani"}}