{"action":"created","issue":{"url":"https://api.github.com/repos/samvera/hyrax/issues/2849","repository_url":"https://api.github.com/repos/samvera/hyrax","labels_url":"https://api.github.com/repos/samvera/hyrax/issues/2849/labels{/name}","comments_url":"https://api.github.com/repos/samvera/hyrax/issues/2849/comments","events_url":"https://api.github.com/repos/samvera/hyrax/issues/2849/events","html_url":"https://github.com/samvera/hyrax/pull/2849","id":309000900,"number":2849,"title":"2837 add sidebar to management pages","user":{"login":"smithjp","id":7035044,"avatar_url":"https://avatars3.githubusercontent.com/u/7035044?v=4","gravatar_id":"","url":"https://api.github.com/users/smithjp","html_url":"https://github.com/smithjp","followers_url":"https://api.github.com/users/smithjp/followers","following_url":"https://api.github.com/users/smithjp/following{/other_user}","gists_url":"https://api.github.com/users/smithjp/gists{/gist_id}","starred_url":"https://api.github.com/users/smithjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithjp/subscriptions","organizations_url":"https://api.github.com/users/smithjp/orgs","repos_url":"https://api.github.com/users/smithjp/repos","events_url":"https://api.github.com/users/smithjp/events{/privacy}","received_events_url":"https://api.github.com/users/smithjp/received_events","type":"User","site_admin":false},"labels":[{"id":503705298,"url":"https://api.github.com/repos/samvera/hyrax/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-27T14:44:22Z","updated_at":"2018-03-27T17:54:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/samvera/hyrax/pulls/2849","html_url":"https://github.com/samvera/hyrax/pull/2849","diff_url":"https://github.com/samvera/hyrax/pull/2849.diff","patch_url":"https://github.com/samvera/hyrax/pull/2849.patch"},"body":"Fixes #2837 \r\n\r\nAdds the dashboard layout to the lease management, embargo management, batch edit, and file set edit pages as mentioned in #2837 and in https://github.com/curationexperts/nurax/issues/239.\r\n\r\nPanels were added to the batch edit and file set edit views, and breadcrumbs were added to the lease and embargo management views for consistency.\r\n\r\nChanges proposed in this pull request:\r\n* add dashboard layout to lease, embargo, batch edit, and file set edit views\r\n* add panel to batch edit and file set edit views\r\n* add breadcrumbs to lease and embargo views\r\n\r\n@samvera/hyrax-code-reviewers\r\n"},"comment":{"url":"https://api.github.com/repos/samvera/hyrax/issues/comments/376616672","html_url":"https://github.com/samvera/hyrax/pull/2849#issuecomment-376616672","issue_url":"https://api.github.com/repos/samvera/hyrax/issues/2849","id":376616672,"user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars2.githubusercontent.com/u/92044?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T17:54:08Z","updated_at":"2018-03-27T17:54:08Z","author_association":"OWNER","body":"Can you add some before/after screenshots of the pages you changed? Specifically the batch edit and file set edit views?\r\n\r\nShould there be tests for the breadcrumbs? For example https://github.com/samvera/hyrax/blob/36b6a7fa6da239c6b43e79e941ccceafcd0677e3/spec/controllers/hyrax/admin/workflows_controller_spec.rb#L7-L9"}}
{"actor":{"display_login":"jcoyne"}}