{"action":"created","issue":{"url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/1","repository_url":"https://api.github.com/repos/jmtyszka/atlaskit","labels_url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/1/comments","events_url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/1/events","html_url":"https://github.com/jmtyszka/atlaskit/issues/1","id":316333390,"number":1,"title":"enhancements to tmp2ind_T1T2.sh (and tmp2ind_T1.sh)","user":{"login":"jcrdubois","id":5529616,"avatar_url":"https://avatars3.githubusercontent.com/u/5529616?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrdubois","html_url":"https://github.com/jcrdubois","followers_url":"https://api.github.com/users/jcrdubois/followers","following_url":"https://api.github.com/users/jcrdubois/following{/other_user}","gists_url":"https://api.github.com/users/jcrdubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrdubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrdubois/subscriptions","organizations_url":"https://api.github.com/users/jcrdubois/orgs","repos_url":"https://api.github.com/users/jcrdubois/repos","events_url":"https://api.github.com/users/jcrdubois/events{/privacy}","received_events_url":"https://api.github.com/users/jcrdubois/received_events","type":"User","site_admin":false},"labels":[{"id":196821906,"url":"https://api.github.com/repos/jmtyszka/atlaskit/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-20T16:28:51Z","updated_at":"2018-04-20T16:39:03Z","closed_at":null,"author_association":"COLLABORATOR","body":"A few suggestions:\r\n- add an input argument for nthreads\r\n- if probability atlas is 4d, then WarpImageMultiTransform is not appropriate; you need to use WarpTimeSeriesImageMultiTransform (currently only the first volume of the probability atlas gets transformed)\r\n- make input probability atlas optional; it can be transformed at a later step using the learned affine & warp\r\n\r\nHappy to make & push these edits if you agree.\r\n"},"comment":{"url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/comments/383153537","html_url":"https://github.com/jmtyszka/atlaskit/issues/1#issuecomment-383153537","issue_url":"https://api.github.com/repos/jmtyszka/atlaskit/issues/1","id":383153537,"user":{"login":"jmtyszka","id":4984927,"avatar_url":"https://avatars1.githubusercontent.com/u/4984927?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtyszka","html_url":"https://github.com/jmtyszka","followers_url":"https://api.github.com/users/jmtyszka/followers","following_url":"https://api.github.com/users/jmtyszka/following{/other_user}","gists_url":"https://api.github.com/users/jmtyszka/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtyszka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtyszka/subscriptions","organizations_url":"https://api.github.com/users/jmtyszka/orgs","repos_url":"https://api.github.com/users/jmtyszka/repos","events_url":"https://api.github.com/users/jmtyszka/events{/privacy}","received_events_url":"https://api.github.com/users/jmtyszka/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T16:39:03Z","updated_at":"2018-04-20T16:39:03Z","author_association":"OWNER","body":"Hi Julien,\n\nYes, all excellent suggestions! If you have the time to implement these, I’ll accept the pull request on arrival. Let me know.\n\nCheers,\n\nMike\n\nJ. Michael Tyszka, Ph.D. | Associate Director | Caltech Brain Imaging Center\nCaltech | Broad 114-96 | Pasadena CA 91125 | (626) 395-5796 | http://www.its.caltech.edu/~jmt\n\nFrom: Wolfgang Pauli<mailto:notifications@github.com>\nSent: Friday, April 20, 2018 9:34 AM\nTo: jmtyszka/atlaskit<mailto:atlaskit@noreply.github.com>\nCc: Subscribed<mailto:subscribed@noreply.github.com>\nSubject: Re: [jmtyszka/atlaskit] enhancements to tmp2ind_T1T2.sh (and tmp2ind_T1.sh) (#1)\n\nThank you for these suggestions!\n\nOn Fri, Apr 20, 2018, 9:28 AM Julien Dubois <notifications@github.com>\nwrote:\n\n> A few suggestions:\n>\n> - add an input argument for nthreads\n> - if probability atlas is 4d, then WarpImageMultiTransform is not\n> appropriate; you need to use WarpTimeSeriesImageMultiTransform (currently\n> only the first volume of the probability atlas gets transformed)\n> - make input probability atlas optional; it can be transformed at a\n> later step using the learned affine & warp\n>\n> Happy to make & push these edits if you agree.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jmtyszka/atlaskit/issues/1>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGPHiYfRsyQ0I1SEhEAjXFD3Cy0pzSsBks5tqgzDgaJpZM4Tdv4Y>\n> .\n>\n\n—\nYou are receiving this because you are subscribed to this thread.\nReply to this email directly, view it on GitHub<https://github.com/jmtyszka/atlaskit/issues/1#issuecomment-383152224>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEwQX-Y37H0NesMvwmNKzUUk44nOvHXvks5tqg4LgaJpZM4Tdv4Y>.\n"}}
{"actor":{"display_login":"jmtyszka"}}