{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4470","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4470/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4470/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4470/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4470","id":306628074,"number":4470,"title":"Classifier themes","user":{"login":"srallen","id":5016731,"avatar_url":"https://avatars1.githubusercontent.com/u/5016731?v=4","gravatar_id":"","url":"https://api.github.com/users/srallen","html_url":"https://github.com/srallen","followers_url":"https://api.github.com/users/srallen/followers","following_url":"https://api.github.com/users/srallen/following{/other_user}","gists_url":"https://api.github.com/users/srallen/gists{/gist_id}","starred_url":"https://api.github.com/users/srallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srallen/subscriptions","organizations_url":"https://api.github.com/users/srallen/orgs","repos_url":"https://api.github.com/users/srallen/repos","events_url":"https://api.github.com/users/srallen/events{/privacy}","received_events_url":"https://api.github.com/users/srallen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2018-03-19T20:44:54Z","updated_at":"2018-04-27T15:50:26Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/4470","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4470","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4470.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4470.patch"},"body":"Staging branch URL: https://classifier-light-theme.pfe-preview.zooniverse.org/\r\n\r\nThis is the first half of the 'facelift' style update to the task area of the classifier. It should be noted that this does not entirely update the survey task according to the new design. \r\n\r\nThis will close #4447.\r\n\r\nTODO: \r\n- [x] Tests for new components\r\n- [x] Dark theme. I'm branching off of this and doing that separately because this PR is getting big on its own. This could wait to merge until the dark theme is done and merged into this OR we can merge them separately.\r\n- [x] Manually test in various browsers\r\n\r\nQuestions for @beckyrother:\r\n1. What should be done with the restart mini-course button as seen in this test project?: https://classifier-light-theme.pfe-preview.zooniverse.org/projects/srallen086/workflow-assignment-testing/classify\r\n2. What should the tutorial tab hover/focus state be? Right now it just opens the modal pop up like the old button\r\n3. I guessed at a hover/focus state for the done/next buttons and made it a slightly lighter yellow. Is that ok?\r\n4. I guessed on styling for the back button in the task navigation. You can see the back button on multi-step tasks starting on the second task. You can see it using the dev classifier: https://classifier-light-theme.pfe-preview.zooniverse.org/dev/classifier\r\n5. What would you like done with the shortcut? I removed the button styling from it as it was styled like the darker style buttons from before and now just looks like a standard checkbox. It can be seen in the dev classifier, but in context it is most often used with survey tasks, so here's an example project: https://classifier-light-theme.pfe-preview.zooniverse.org/projects/srallen086/survey-test/classify\r\n6. The focus/hover state for the question task looks like it has a gradient and/or opacity, but the inspector in invision isn't picking that up (seen here: https://projects.invisionapp.com/d/main#/console/12923997/270495244/preview) Can you confirm what you want done here?\r\n7. Similarly the selected survey options appear to either have opacity or gradient, but invision inspector isn't picking that up either: https://projects.invisionapp.com/d/main#/console/12923997/270495286/preview\r\n\r\n\r\n\r\n# Required Manual Testing\r\n\r\n- [ ] Does the non-logged in home page render correctly?\r\n- [ ] Does the logged in home page render correctly?\r\n- [ ] Does the projects page render correctly?\r\n- [ ] Can you load project home pages?\r\n- [ ] Can you load the classification page?\r\n- [ ] Can you submit a classification?\r\n- [ ] Does talk load correctly?\r\n- [ ] Can you post a talk comment?\r\n\r\n# Review Checklist\r\n\r\n- [ ] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [ ] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [ ] If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?\r\n- [ ] Are the tests passing locally and on Travis?\r\n\r\n# Optional\r\n\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you [resized and compressed](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/image-optimization) any image you've added?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?\r\n- [ ] Have you followed the [Springer guidelines for commit messages](https://github.com/springernature/frontend-playbook/blob/master/git/git.md#commit-messages)?\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/385012699","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/4470#issuecomment-385012699","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/4470","id":385012699,"user":{"login":"eatyourgreens","id":59547,"avatar_url":"https://avatars3.githubusercontent.com/u/59547?v=4","gravatar_id":"","url":"https://api.github.com/users/eatyourgreens","html_url":"https://github.com/eatyourgreens","followers_url":"https://api.github.com/users/eatyourgreens/followers","following_url":"https://api.github.com/users/eatyourgreens/following{/other_user}","gists_url":"https://api.github.com/users/eatyourgreens/gists{/gist_id}","starred_url":"https://api.github.com/users/eatyourgreens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatyourgreens/subscriptions","organizations_url":"https://api.github.com/users/eatyourgreens/orgs","repos_url":"https://api.github.com/users/eatyourgreens/repos","events_url":"https://api.github.com/users/eatyourgreens/events{/privacy}","received_events_url":"https://api.github.com/users/eatyourgreens/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T15:50:26Z","updated_at":"2018-04-27T15:50:26Z","author_association":"OWNER","body":"Not related to this PR as such, but [the How section](https://github.com/springernature/frontend-playbook/blob/master/practices/code-review.md#how) of that playbook is good advice for PR management."}}
{"actor":{"display_login":"eatyourgreens"}}