{"action":"closed","number":1554,"pull_request":{"url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554","id":166962427,"html_url":"https://github.com/measurement-kit/measurement-kit/pull/1554","diff_url":"https://github.com/measurement-kit/measurement-kit/pull/1554.diff","patch_url":"https://github.com/measurement-kit/measurement-kit/pull/1554.patch","issue_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/1554","number":1554,"state":"closed","locked":false,"title":"Simpler build system","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"body":"As mentioned in #1532, after negative feedback pretty much from everyone regarding the way in which I was structuring build scripts, I spent time trying to find out a simpler way.\r\n\r\nThis PR introduces low-level build scripts that are feature equivalent to the ones in `./build` [*], except that they are simpler (I flattened the architecture and disposed of some gratuitous complexity).\r\n\r\nRegarding Windows proper, I removed the requirement that one should not use the Ubuntu shell on Windows to start this build. Without this requirement, things are much more easy than before.\r\n\r\nNote that these build scripts are in `./script/build` rather than in `./build` because there are many CMake guides suggesting to create a directory named `./build`. So, I'd like to move away from `./build`.\r\n\r\n- - -\r\n\r\nWhat I would like a reviewer to do:\r\n\r\n1. comment on the overall approach and way in which I'm structuring things (is the optional complexity reduced? Is it difficult to understand the structure of the build scripts, also given the README.md?)\r\n\r\n2. read the scripts and check whether they're reasonable (below I'll publish diff wrt previous version of the scripts, which is still inside of `./build` &mdash; I did this to start moving away from `./build`)\r\n\r\n3. optionally run _some_ builds (I think it would especially be useful if @hellais can run the Windows build and generally try to build dependencies using these scripts and provide feedback)\r\n\r\n4. comment on the plan I drafted to move forward, which is:\r\n\r\n    1. make a full Android and iOS build using these scripts and test them with our apps\r\n\r\n    2. if this works, edit existing scripts inside of `./build` to point to the new scripts, but leave the old scripts as _wrappers_ / _aliases_ for now\r\n\r\n    3. also, remove vendored code, which now becomes unnecessary\r\n\r\n    4. also, since we are assuming we'll be running Unix scripts in all scenario, remove from the repository the autogenerated stuff that we committed and make sure we autogenerate all we need in `./autogen.sh` to avoid having the problem of keeping autogenerated things consistent\r\n\r\n    5. do not perform more changes for now, but note that more refactoring is pending (I think more of this can be done after we bless v0.9.0, which is probably something to do ASAP once we have support for Windows and an experimental new API)\r\n\r\n    6. rebase the existing PR to build MK on Windows on top of this branch (or better master once this branch is merged) and get a review of the CMake and code changes\r\n\r\n- - -\r\n\r\n[*] There are also high level build scripts in `./build` but there is no point in touching them and making things simpler until the low-level ones have been vetted, IMHO.","created_at":"2018-02-03T13:34:19Z","updated_at":"2018-02-14T13:01:20Z","closed_at":"2018-02-14T13:01:19Z","merged_at":"2018-02-14T13:01:19Z","merge_commit_sha":"1233fa423584ee6459641613a673b5db8863b9f3","assignee":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"assignees":[{"login":"bassosimone","id":337298,"avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rschulman","id":1304536,"avatar_url":"https://avatars3.githubusercontent.com/u/1304536?v=4","gravatar_id":"","url":"https://api.github.com/users/rschulman","html_url":"https://github.com/rschulman","followers_url":"https://api.github.com/users/rschulman/followers","following_url":"https://api.github.com/users/rschulman/following{/other_user}","gists_url":"https://api.github.com/users/rschulman/gists{/gist_id}","starred_url":"https://api.github.com/users/rschulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschulman/subscriptions","organizations_url":"https://api.github.com/users/rschulman/orgs","repos_url":"https://api.github.com/users/rschulman/repos","events_url":"https://api.github.com/users/rschulman/events{/privacy}","received_events_url":"https://api.github.com/users/rschulman/received_events","type":"User","site_admin":false},{"login":"AntonioLangiu","id":4649406,"avatar_url":"https://avatars2.githubusercontent.com/u/4649406?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonioLangiu","html_url":"https://github.com/AntonioLangiu","followers_url":"https://api.github.com/users/AntonioLangiu/followers","following_url":"https://api.github.com/users/AntonioLangiu/following{/other_user}","gists_url":"https://api.github.com/users/AntonioLangiu/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioLangiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioLangiu/subscriptions","organizations_url":"https://api.github.com/users/AntonioLangiu/orgs","repos_url":"https://api.github.com/users/AntonioLangiu/repos","events_url":"https://api.github.com/users/AntonioLangiu/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioLangiu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":217831593,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/cleanup","name":"cleanup","color":"fbca04","default":false},{"id":103088501,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":437538715,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/merge_pending","name":"merge_pending","color":"5319e7","default":false},{"id":103088504,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/question","name":"question","color":"cc317c","default":true},{"id":321612524,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/ready%20for%20review","name":"ready for review","color":"eb6420","default":false},{"id":473102883,"url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels/refactoring","name":"refactoring","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/measurement-kit/measurement-kit/milestones/17","html_url":"https://github.com/measurement-kit/measurement-kit/milestone/17","labels_url":"https://api.github.com/repos/measurement-kit/measurement-kit/milestones/17/labels","id":2777967,"number":17,"title":"v0.9.0","description":"","creator":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":13,"state":"open","created_at":"2017-09-19T14:49:20Z","updated_at":"2018-02-14T13:01:20Z","due_on":"2018-02-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554/commits","review_comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554/comments","review_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/1554/comments","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit/statuses/faf0f489b8e3592140f788aa20b1d620c2df3eb6","head":{"label":"measurement-kit:feature/sbs","ref":"feature/sbs","sha":"faf0f489b8e3592140f788aa20b1d620c2df3eb6","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars1.githubusercontent.com/u/11982841?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":20287787,"name":"measurement-kit","full_name":"measurement-kit/measurement-kit","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars1.githubusercontent.com/u/11982841?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/measurement-kit","description":"Portable C++14 network measurement library","fork":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit","forks_url":"https://api.github.com/repos/measurement-kit/measurement-kit/forks","keys_url":"https://api.github.com/repos/measurement-kit/measurement-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/measurement-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/measurement-kit/teams","hooks_url":"https://api.github.com/repos/measurement-kit/measurement-kit/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/measurement-kit/events","assignees_url":"https://api.github.com/repos/measurement-kit/measurement-kit/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/measurement-kit/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit/tags","blobs_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/measurement-kit/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/measurement-kit/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/measurement-kit/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/measurement-kit/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/measurement-kit/subscription","commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/measurement-kit/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/measurement-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/measurement-kit/merges","archive_url":"https://api.github.com/repos/measurement-kit/measurement-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/measurement-kit/downloads","issues_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/measurement-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/measurement-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/measurement-kit/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/deployments","created_at":"2014-05-29T08:44:43Z","updated_at":"2018-02-08T00:46:08Z","pushed_at":"2018-02-14T13:01:19Z","git_url":"git://github.com/measurement-kit/measurement-kit.git","ssh_url":"git@github.com:measurement-kit/measurement-kit.git","clone_url":"https://github.com/measurement-kit/measurement-kit.git","svn_url":"https://github.com/measurement-kit/measurement-kit","homepage":"https://measurement-kit.github.io/","size":19452,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":158,"watchers":49,"default_branch":"master"}},"base":{"label":"measurement-kit:master","ref":"master","sha":"5c9583761d553caa46ad3cce73a58530d98b332e","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars1.githubusercontent.com/u/11982841?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":20287787,"name":"measurement-kit","full_name":"measurement-kit/measurement-kit","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars1.githubusercontent.com/u/11982841?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/measurement-kit","description":"Portable C++14 network measurement library","fork":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit","forks_url":"https://api.github.com/repos/measurement-kit/measurement-kit/forks","keys_url":"https://api.github.com/repos/measurement-kit/measurement-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/measurement-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/measurement-kit/teams","hooks_url":"https://api.github.com/repos/measurement-kit/measurement-kit/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/measurement-kit/events","assignees_url":"https://api.github.com/repos/measurement-kit/measurement-kit/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/measurement-kit/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit/tags","blobs_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/measurement-kit/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/measurement-kit/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/measurement-kit/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/measurement-kit/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/measurement-kit/subscription","commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/measurement-kit/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/measurement-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/measurement-kit/merges","archive_url":"https://api.github.com/repos/measurement-kit/measurement-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/measurement-kit/downloads","issues_url":"https://api.github.com/repos/measurement-kit/measurement-kit/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/measurement-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/measurement-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/measurement-kit/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/measurement-kit/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-kit/measurement-kit/deployments","created_at":"2014-05-29T08:44:43Z","updated_at":"2018-02-08T00:46:08Z","pushed_at":"2018-02-14T13:01:19Z","git_url":"git://github.com/measurement-kit/measurement-kit.git","ssh_url":"git@github.com:measurement-kit/measurement-kit.git","clone_url":"https://github.com/measurement-kit/measurement-kit.git","svn_url":"https://github.com/measurement-kit/measurement-kit","homepage":"https://measurement-kit.github.io/","size":19452,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":17,"open_issues":158,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554"},"html":{"href":"https://github.com/measurement-kit/measurement-kit/pull/1554"},"issue":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/1554"},"comments":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/issues/1554/comments"},"review_comments":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554/comments"},"review_comment":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/pulls/1554/commits"},"statuses":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit/statuses/faf0f489b8e3592140f788aa20b1d620c2df3eb6"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars0.githubusercontent.com/u/337298?v=4","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"comments":8,"review_comments":24,"maintainer_can_modify":false,"commits":54,"additions":784,"deletions":0,"changed_files":15}}
{"actor":{"display_login":"bassosimone"}}