{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/213945889","pull_request_review_id":150889000,"id":213945889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk0NTg4OQ==","diff_hunk":"@@ -652,65 +653,66 @@ class ALSSuite extends MLTest with DefaultReadWriteTest with Logging {\n   test(\"input type validation\") {\n     val spark = this.spark\n     import spark.implicits._\n-\n-    // check that ALS can handle all numeric types for rating column\n-    // and user/item columns (when the user/item ids are within Int range)\n-    val als = new ALS().setMaxIter(1).setRank(1)\n-    Seq((\"user\", IntegerType), (\"item\", IntegerType), (\"rating\", FloatType)).foreach {\n-      case (colName, sqlType) =>\n-        checkNumericTypesALS(als, spark, colName, sqlType) {\n-          (ex, act) =>\n-            ex.userFactors.first().getSeq[Float](1) === act.userFactors.first().getSeq[Float](1)\n-        } { (ex, act, df, enc) =>\n-          val expected = ex.transform(df).selectExpr(\"prediction\")\n-            .first().getFloat(0)\n-          testTransformerByGlobalCheckFunc(df, act, \"prediction\") {\n-            case rows: Seq[Row] =>\n-              expected ~== rows.head.getFloat(0) absTol 1e-6\n-          }(enc)\n-        }\n-    }\n-    // check user/item ids falling outside of Int range\n-    val big = Int.MaxValue.toLong + 1\n-    val small = Int.MinValue.toDouble - 1\n-    val df = Seq(\n-      (0, 0L, 0d, 1, 1L, 1d, 3.0),\n-      (0, big, small, 0, big, small, 2.0),\n-      (1, 1L, 1d, 0, 0L, 0d, 5.0)\n-    ).toDF(\"user\", \"user_big\", \"user_small\", \"item\", \"item_big\", \"item_small\", \"rating\")\n-    val msg = \"either out of Integer range or contained a fractional part\"\n-    withClue(\"fit should fail when ids exceed integer range. \") {\n-      assert(intercept[SparkException] {\n-        als.fit(df.select(df(\"user_big\").as(\"user\"), df(\"item\"), df(\"rating\")))\n-      }.getCause.getMessage.contains(msg))\n-      assert(intercept[SparkException] {\n-        als.fit(df.select(df(\"user_small\").as(\"user\"), df(\"item\"), df(\"rating\")))\n-      }.getCause.getMessage.contains(msg))\n-      assert(intercept[SparkException] {\n-        als.fit(df.select(df(\"item_big\").as(\"item\"), df(\"user\"), df(\"rating\")))\n-      }.getCause.getMessage.contains(msg))\n-      assert(intercept[SparkException] {\n-        als.fit(df.select(df(\"item_small\").as(\"item\"), df(\"user\"), df(\"rating\")))\n-      }.getCause.getMessage.contains(msg))\n-    }\n-    withClue(\"transform should fail when ids exceed integer range. \") {\n-      val model = als.fit(df)\n-      def testTransformIdExceedsIntRange[A : Encoder](dataFrame: DataFrame): Unit = {\n+    withSQLConf(SQLConf.OPTIMIZER_EXCLUDED_RULES.key -> \"\") {","path":"mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala","position":56,"original_position":56,"commit_id":"877ad9689c0d1fb7bbbc34d210fd16aa278e5779","original_commit_id":"877ad9689c0d1fb7bbbc34d210fd16aa278e5779","user":{"login":"viirya","id":68855,"node_id":"MDQ6VXNlcjY4ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/68855?v=4","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"body":"Sure. :)","created_at":"2018-08-30T08:33:19Z","updated_at":"2018-08-30T08:33:19Z","html_url":"https://github.com/apache/spark/pull/22270#discussion_r213945889","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22270","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/213945889"},"html":{"href":"https://github.com/apache/spark/pull/22270#discussion_r213945889"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22270"}},"in_reply_to_id":213938811},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22270","id":211841128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODQxMTI4","html_url":"https://github.com/apache/spark/pull/22270","diff_url":"https://github.com/apache/spark/pull/22270.diff","patch_url":"https://github.com/apache/spark/pull/22270.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22270","number":22270,"state":"open","locked":false,"title":"[SPARK-25267][SQL][TEST] Disable ConvertToLocalRelation in the test cases of sql/core and sql/hive","user":{"login":"dilipbiswal","id":14225158,"node_id":"MDQ6VXNlcjE0MjI1MTU4","avatar_url":"https://avatars0.githubusercontent.com/u/14225158?v=4","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nIn SharedSparkSession and TestHive, we need to disable the rule ConvertToLocalRelation for better test case coverage. \r\n## How was this patch tested?\r\nIdentify the failures after excluding \"ConvertToLocalRelation\" rule.","created_at":"2018-08-29T18:10:18Z","updated_at":"2018-08-30T08:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b72f010efdaf025c1d0b8064ef691ca4fe3ce32a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22270/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22270/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22270/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/877ad9689c0d1fb7bbbc34d210fd16aa278e5779","head":{"label":"dilipbiswal:SPARK-25267-final","ref":"SPARK-25267-final","sha":"877ad9689c0d1fb7bbbc34d210fd16aa278e5779","user":{"login":"dilipbiswal","id":14225158,"node_id":"MDQ6VXNlcjE0MjI1MTU4","avatar_url":"https://avatars0.githubusercontent.com/u/14225158?v=4","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"repo":{"id":42921897,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkyMTg5Nw==","name":"spark","full_name":"dilipbiswal/spark","owner":{"login":"dilipbiswal","id":14225158,"node_id":"MDQ6VXNlcjE0MjI1MTU4","avatar_url":"https://avatars0.githubusercontent.com/u/14225158?v=4","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilipbiswal/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dilipbiswal/spark","forks_url":"https://api.github.com/repos/dilipbiswal/spark/forks","keys_url":"https://api.github.com/repos/dilipbiswal/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilipbiswal/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilipbiswal/spark/teams","hooks_url":"https://api.github.com/repos/dilipbiswal/spark/hooks","issue_events_url":"https://api.github.com/repos/dilipbiswal/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dilipbiswal/spark/events","assignees_url":"https://api.github.com/repos/dilipbiswal/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dilipbiswal/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dilipbiswal/spark/tags","blobs_url":"https://api.github.com/repos/dilipbiswal/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilipbiswal/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilipbiswal/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilipbiswal/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilipbiswal/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dilipbiswal/spark/languages","stargazers_url":"https://api.github.com/repos/dilipbiswal/spark/stargazers","contributors_url":"https://api.github.com/repos/dilipbiswal/spark/contributors","subscribers_url":"https://api.github.com/repos/dilipbiswal/spark/subscribers","subscription_url":"https://api.github.com/repos/dilipbiswal/spark/subscription","commits_url":"https://api.github.com/repos/dilipbiswal/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilipbiswal/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilipbiswal/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilipbiswal/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilipbiswal/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dilipbiswal/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilipbiswal/spark/merges","archive_url":"https://api.github.com/repos/dilipbiswal/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilipbiswal/spark/downloads","issues_url":"https://api.github.com/repos/dilipbiswal/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dilipbiswal/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dilipbiswal/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dilipbiswal/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilipbiswal/spark/labels{/name}","releases_url":"https://api.github.com/repos/dilipbiswal/spark/releases{/id}","deployments_url":"https://api.github.com/repos/dilipbiswal/spark/deployments","created_at":"2015-09-22T08:39:46Z","updated_at":"2016-04-06T08:56:13Z","pushed_at":"2018-08-30T07:55:14Z","git_url":"git://github.com/dilipbiswal/spark.git","ssh_url":"git@github.com:dilipbiswal/spark.git","clone_url":"https://github.com/dilipbiswal/spark.git","svn_url":"https://github.com/dilipbiswal/spark","homepage":null,"size":266578,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"20b7c684cc4a8136b9a9c56390a4948de04e7c34","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-30T08:29:22Z","pushed_at":"2018-08-30T08:25:18Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":280471,"stargazers_count":18573,"watchers_count":18573,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16784,"mirror_url":null,"archived":false,"open_issues_count":496,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16784,"open_issues":496,"watchers":18573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22270"},"html":{"href":"https://github.com/apache/spark/pull/22270"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22270"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22270/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22270/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22270/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/877ad9689c0d1fb7bbbc34d210fd16aa278e5779"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"viirya"}}