{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/198654283","pull_request_review_id":132624412,"id":198654283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODY1NDI4Mw==","diff_hunk":"@@ -28,22 +28,50 @@ struct InputConstants\n #define NumTrianglesBufferRegister 1\n #define AABBBufferRegister 2\n #define ElementBufferRegister 3\n+#define BaseTreeletsCountBufferRegister 4\n+#define BaseTreeletsIndexBufferRegister 5\n \n #define GlobalDescriptorHeapRegister 0","path":"Libraries/D3D12RaytracingFallback/src/TreeletReorderBindings.h","position":7,"original_position":7,"commit_id":"a931f3984f45306cbc7f374641c37b2067baf05a","original_commit_id":"a931f3984f45306cbc7f374641c37b2067baf05a","user":{"login":"wallisc","id":2508805,"node_id":"MDQ6VXNlcjI1MDg4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/2508805?v=4","gravatar_id":"","url":"https://api.github.com/users/wallisc","html_url":"https://github.com/wallisc","followers_url":"https://api.github.com/users/wallisc/followers","following_url":"https://api.github.com/users/wallisc/following{/other_user}","gists_url":"https://api.github.com/users/wallisc/gists{/gist_id}","starred_url":"https://api.github.com/users/wallisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallisc/subscriptions","organizations_url":"https://api.github.com/users/wallisc/orgs","repos_url":"https://api.github.com/users/wallisc/repos","events_url":"https://api.github.com/users/wallisc/events{/privacy}","received_events_url":"https://api.github.com/users/wallisc/received_events","type":"User","site_admin":false},"body":"Good catch on the removal here, you can also remove these GlobalDescriptorHeap defines also","created_at":"2018-06-27T21:57:51Z","updated_at":"2018-06-27T21:57:51Z","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411#discussion_r198654283","pull_request_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments/198654283"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411#discussion_r198654283"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411","id":197848495,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODQ4NDk1","html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411","diff_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411.diff","patch_url":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/411","number":411,"state":"open","locked":false,"title":"Optimized treelet reorder pass","user":{"login":"rgerd","id":4724014,"node_id":"MDQ6VXNlcjQ3MjQwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4724014?v=4","gravatar_id":"","url":"https://api.github.com/users/rgerd","html_url":"https://github.com/rgerd","followers_url":"https://api.github.com/users/rgerd/followers","following_url":"https://api.github.com/users/rgerd/following{/other_user}","gists_url":"https://api.github.com/users/rgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/rgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgerd/subscriptions","organizations_url":"https://api.github.com/users/rgerd/orgs","repos_url":"https://api.github.com/users/rgerd/repos","events_url":"https://api.github.com/users/rgerd/events{/privacy}","received_events_url":"https://api.github.com/users/rgerd/received_events","type":"User","site_admin":false},"body":"[Link to NVIDIA paper](http://research.nvidia.com/publication/fast-parallel-construction-high-quality-bounding-volume-hierarchies)\r\n- Split treelet reorder pass of BVH construction into two dispatches: FindTreelets and TreeletReorder\r\n- Using full waves on each treelet to parallelize reordering\r\n\r\n- Optimized inner loop of reordering by using bit arithmetic\r\n\r\nOn NVIDIA 1080, building a bottom-level BVH with 1 million triangles and three optimization passes used to take 930ms. Now it takes 72ms.\r\n\r\n\r\n","created_at":"2018-06-27T20:45:34Z","updated_at":"2018-06-27T21:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58de20ba2f0a2895a4a70466f0adaad6e49e3a70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/411/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/a931f3984f45306cbc7f374641c37b2067baf05a","head":{"label":"Microsoft:develop-dxr-treeletOptimize","ref":"develop-dxr-treeletOptimize","sha":"a931f3984f45306cbc7f374641c37b2067baf05a","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-06-27T16:52:24Z","pushed_at":"2018-06-27T20:45:35Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106129,"stargazers_count":1641,"watchers_count":1641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":626,"open_issues":48,"watchers":1641,"default_branch":"master"}},"base":{"label":"Microsoft:develop-dxr","ref":"develop-dxr","sha":"866ac724da7354919e7575b65abb96dcd43a57b9","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36831874,"node_id":"MDEwOlJlcG9zaXRvcnkzNjgzMTg3NA==","name":"DirectX-Graphics-Samples","full_name":"Microsoft/DirectX-Graphics-Samples","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","description":"This repo contains the DirectX Graphics samples that demonstrate how to build graphics intensive applications on Windows.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples","forks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/deployments","created_at":"2015-06-03T21:34:47Z","updated_at":"2018-06-27T16:52:24Z","pushed_at":"2018-06-27T20:45:35Z","git_url":"git://github.com/Microsoft/DirectX-Graphics-Samples.git","ssh_url":"git@github.com:Microsoft/DirectX-Graphics-Samples.git","clone_url":"https://github.com/Microsoft/DirectX-Graphics-Samples.git","svn_url":"https://github.com/Microsoft/DirectX-Graphics-Samples","homepage":null,"size":106129,"stargazers_count":1641,"watchers_count":1641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":626,"open_issues":48,"watchers":1641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411"},"html":{"href":"https://github.com/Microsoft/DirectX-Graphics-Samples/pull/411"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/411"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectX-Graphics-Samples/statuses/a931f3984f45306cbc7f374641c37b2067baf05a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wallisc"}}