{"action":"created","issue":{"url":"https://api.github.com/repos/python-trio/trio/issues/448","repository_url":"https://api.github.com/repos/python-trio/trio","labels_url":"https://api.github.com/repos/python-trio/trio/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/python-trio/trio/issues/448/comments","events_url":"https://api.github.com/repos/python-trio/trio/issues/448/events","html_url":"https://github.com/python-trio/trio/pull/448","id":298871373,"number":448,"title":"Refactor open_unix_stream tests, and use more unique filename","user":{"login":"njsmith","id":609896,"avatar_url":"https://avatars0.githubusercontent.com/u/609896?v=4","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-21T07:53:46Z","updated_at":"2018-02-21T08:01:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/python-trio/trio/pulls/448","html_url":"https://github.com/python-trio/trio/pull/448","diff_url":"https://github.com/python-trio/trio/pull/448.diff","patch_url":"https://github.com/python-trio/trio/pull/448.patch"},"body":"The main substantive change here is switching to using mktemp() to\npick a server socket name, instead of using the fixed name\n\"/tmp/test.sock\". This should fix gh-447.\n\nWhile I was at it, I also refactored the main test, and made it clean\nup after itself more carefully.\n\nFinally, I replaced\n\n   os.path.join(tempfile.gettempdir(), tempfile.mktemp())\n\nwith\n\n   tempfile.mktemp()\n\nBecause it turns out they're equivalent: mktemp() already returns an\nabsolute filename inside an appropriate directory."},"comment":{"url":"https://api.github.com/repos/python-trio/trio/issues/comments/367242847","html_url":"https://github.com/python-trio/trio/pull/448#issuecomment-367242847","issue_url":"https://api.github.com/repos/python-trio/trio/issues/448","id":367242847,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-21T08:01:19Z","updated_at":"2018-02-21T08:01:19Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=h1) Report\n> Merging [#448](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=desc) into [master](https://codecov.io/gh/python-trio/trio/commit/670933ead934b56189f031614285d6cf54a623bb?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/python-trio/trio/pull/448/graphs/tree.svg?width=650&src=pr&token=Lhvc0OnSCw&height=150)](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master    #448      +/-   ##\n=========================================\n- Coverage    99.2%   99.2%   -0.01%     \n=========================================\n  Files          89      89              \n  Lines       10345   10337       -8     \n  Branches      720     721       +1     \n=========================================\n- Hits        10263   10255       -8     \n  Misses         61      61              \n  Partials       21      21\n```\n\n\n| [Impacted Files](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [trio/tests/test\\_highlevel\\_open\\_unix\\_stream.py](https://codecov.io/gh/python-trio/trio/pull/448/diff?src=pr&el=tree#diff-dHJpby90ZXN0cy90ZXN0X2hpZ2hsZXZlbF9vcGVuX3VuaXhfc3RyZWFtLnB5) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=footer). Last update [670933e...72e9fc9](https://codecov.io/gh/python-trio/trio/pull/448?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}