{"action":"created","issue":{"url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/891","repository_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter","labels_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/891/labels{/name}","comments_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/891/comments","events_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/891/events","html_url":"https://github.com/jruby/activerecord-jdbc-adapter/issues/891","id":316334295,"number":891,"title":"jdbc_connection method hides ArgumentErrors thrown from 4-arg adapter_class constructors","user":{"login":"aschmied","id":4484927,"avatar_url":"https://avatars1.githubusercontent.com/u/4484927?v=4","gravatar_id":"","url":"https://api.github.com/users/aschmied","html_url":"https://github.com/aschmied","followers_url":"https://api.github.com/users/aschmied/followers","following_url":"https://api.github.com/users/aschmied/following{/other_user}","gists_url":"https://api.github.com/users/aschmied/gists{/gist_id}","starred_url":"https://api.github.com/users/aschmied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschmied/subscriptions","organizations_url":"https://api.github.com/users/aschmied/orgs","repos_url":"https://api.github.com/users/aschmied/repos","events_url":"https://api.github.com/users/aschmied/events{/privacy}","received_events_url":"https://api.github.com/users/aschmied/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-20T16:31:31Z","updated_at":"2018-04-21T08:09:32Z","closed_at":null,"author_association":"NONE","body":"# Summary\r\n\r\n[This rescue](https://github.com/jruby/activerecord-jdbc-adapter/blob/v50.0/lib/arjdbc/jdbc/connection_methods.rb#L16) hides ArgumentErrors thrown from 4-argument adapter_class constructors\r\n\r\n# Environment\r\n\r\n* activerecord-jdbc-adapter 50.0\r\n\r\n# Steps\r\n\r\nAttempt to initialize an adapter with a 4-argument constructor that throws an ArgumentError (in my case it was activerecord-postgis-adapter)\r\n\r\n# Expected\r\n\r\nThe exception thrown from the constructor\r\n\r\n# Actual\r\n\r\n\"Wrong number of arguments (3 for 4)\" from [this line](https://github.com/jruby/activerecord-jdbc-adapter/blob/v50.0/lib/arjdbc/jdbc/connection_methods.rb#L17)\r\n"},"comment":{"url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/comments/383276726","html_url":"https://github.com/jruby/activerecord-jdbc-adapter/issues/891#issuecomment-383276726","issue_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/891","id":383276726,"user":{"login":"kares","id":45967,"avatar_url":"https://avatars0.githubusercontent.com/u/45967?v=4","gravatar_id":"","url":"https://api.github.com/users/kares","html_url":"https://github.com/kares","followers_url":"https://api.github.com/users/kares/followers","following_url":"https://api.github.com/users/kares/following{/other_user}","gists_url":"https://api.github.com/users/kares/gists{/gist_id}","starred_url":"https://api.github.com/users/kares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kares/subscriptions","organizations_url":"https://api.github.com/users/kares/orgs","repos_url":"https://api.github.com/users/kares/repos","events_url":"https://api.github.com/users/kares/events{/privacy}","received_events_url":"https://api.github.com/users/kares/received_events","type":"User","site_admin":false},"created_at":"2018-04-21T08:09:32Z","updated_at":"2018-04-21T08:09:32Z","author_association":"OWNER","body":"yeah that is quite an ugly piece of hack.\r\ndo you happen to know whether the **activerecord-postgis-adapter** is updated/following the changes done here to support 5.x ? since AR-JDBC isn't stable in terms of adapters building on top of its API (as it used to be) ... yet."}}
{"actor":{"display_login":"kares"}}