{"action":"opened","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/950","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/950/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/950/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/950/events","html_url":"https://github.com/jetstack/cert-manager/issues/950","id":369365721,"node_id":"MDU6SXNzdWUzNjkzNjU3MjE=","number":950,"title":"Handle new empty certificate secrets better","user":{"login":"willthames","id":391807,"node_id":"MDQ6VXNlcjM5MTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391807?v=4","gravatar_id":"","url":"https://api.github.com/users/willthames","html_url":"https://github.com/willthames","followers_url":"https://api.github.com/users/willthames/followers","following_url":"https://api.github.com/users/willthames/following{/other_user}","gists_url":"https://api.github.com/users/willthames/gists{/gist_id}","starred_url":"https://api.github.com/users/willthames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willthames/subscriptions","organizations_url":"https://api.github.com/users/willthames/orgs","repos_url":"https://api.github.com/users/willthames/repos","events_url":"https://api.github.com/users/willthames/events{/privacy}","received_events_url":"https://api.github.com/users/willthames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T01:34:18Z","updated_at":"2018-10-12T01:34:18Z","closed_at":null,"author_association":"NONE","body":"**Is your feature request related to a problem? Please describe.**\r\n\r\ncert-manager should cope with empty certificates better\r\n\r\nWe see\r\n\r\n```\r\nI1012 01:25:52.547012       1 controller.go:181] certificates controller: syncing item 'test/my-application-tls'\r\nE1012 01:25:52.547078       1 controller.go:190] certificates controller: Re-queuing item \"test/my-application-tls\" due to error processing: no data for \"tls.crt\" in secret 'test/my-application-tls'\r\n```\r\n\r\nin the cert manager logs\r\n\r\n**Describe the solution you'd like**\r\n\r\nThere should be a way to allow cert-manager to use secrets that don't necessarily have an existing tls.key or tls.crt. This might be a new annotation on the secret or allowing the secret to be used if it has no other data (I'm not really sure why the check is needed, but I assume there is a reason, and a mechanism that respects that reason is likely necessary)\r\n\r\n**Describe alternatives you've considered**\r\n\r\nAt the moment, as this is a one off for new services with new secrets, we manually edit the secret to add empty string values for tls.key and tls.crt. However, this is error prone and relies on someone knowing that they have to do this. \r\n\r\nThere's no easy way to add this to our automation such that we won't overwrite the LE cert with empty values on subsequent deploys. \r\n\r\n**Additional context**\r\nAdd any other context about the feature request here.\r\n\r\n**Environment details (if applicable)**:\r\n- Kubernetes version (e.g. v1.10.2): v1.10.8\r\n- Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): kops\r\n- cert-manager version (e.g. v0.4.0): v0.4.1\r\n- Install method (e.g. helm or static manifests): static manifests\r\n\r\n/kind feature\r\n"}}
{"actor":{"display_login":"willthames"}}