{"action":"created","issue":{"url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/191","repository_url":"https://api.github.com/repos/Nordstrom/serverless-artillery","labels_url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/191/comments","events_url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/191/events","html_url":"https://github.com/Nordstrom/serverless-artillery/issues/191","id":373582983,"node_id":"MDU6SXNzdWUzNzM1ODI5ODM=","number":191,"title":"Upgrade the local assets that were built using previous versions of SA, after user has installed newer version of SA","user":{"login":"ashmibhanushali","id":26556765,"node_id":"MDQ6VXNlcjI2NTU2NzY1","avatar_url":"https://avatars3.githubusercontent.com/u/26556765?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmibhanushali","html_url":"https://github.com/ashmibhanushali","followers_url":"https://api.github.com/users/ashmibhanushali/followers","following_url":"https://api.github.com/users/ashmibhanushali/following{/other_user}","gists_url":"https://api.github.com/users/ashmibhanushali/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmibhanushali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmibhanushali/subscriptions","organizations_url":"https://api.github.com/users/ashmibhanushali/orgs","repos_url":"https://api.github.com/users/ashmibhanushali/repos","events_url":"https://api.github.com/users/ashmibhanushali/events{/privacy}","received_events_url":"https://api.github.com/users/ashmibhanushali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gwsii","id":1920378,"node_id":"MDQ6VXNlcjE5MjAzNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1920378?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false},"assignees":[{"login":"gwsii","id":1920378,"node_id":"MDQ6VXNlcjE5MjAzNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1920378?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-10-24T17:02:06Z","updated_at":"2018-10-24T19:59:03Z","closed_at":null,"author_association":"NONE","body":"Use case:\r\n1. User has an older version of SA installed.\r\n2. User has created project using the older version of SA and the local assets are built using that.\r\n3. User uninstalls the older version of SA and installs newer version.\r\n4. User wants to run SA commands from the project created in step 2. Some commands could be safe to invoke and some are not.\r\n\r\nSafe vs unsafe commands:\r\n- When user invokes safe commands we would like to allow them.\r\n  - This would be commands like `slsart invoke` which would invoke the load test on the assets that are already deployed.\r\n- When user invokes unsafe commands we would like to block that action and prompt user to upgrade the local assets.\r\n  - This would be commands like `slsart invoke -m` when the deployed assets are not supporting monitoring. In such case command would invoke load test instead of running monitoring once (as user would expect).\r\n- For cases such as \"user is always using the safe commands and hence is never notified about upgrade\", we would like to inform the user that they can upgrade the local assets by printing a message for only a certain commands that are less used.\r\n  - Informing user about upgrade for safe commands like `slsart invoke` could be annoying as user would be running that command more often than others.\r\n  - Informing user about upgrade for safe commands like `slsart deploy` which is used less often would be less annoying. And at the same time we get to inform the user that they are deploying assets built using older version of SA where as they have now installed newer version on their dev machine. We don't need to block the command as it will not cause any harm but would be a good place to remind them that they are deploying older assets. And that they have an option to upgrade them.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/comments/432806683","html_url":"https://github.com/Nordstrom/serverless-artillery/issues/191#issuecomment-432806683","issue_url":"https://api.github.com/repos/Nordstrom/serverless-artillery/issues/191","id":432806683,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjgwNjY4Mw==","user":{"login":"gwsii","id":1920378,"node_id":"MDQ6VXNlcjE5MjAzNzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1920378?v=4","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T19:59:03Z","updated_at":"2018-10-24T19:59:03Z","author_association":"MEMBER","body":"Upgrading the `package.json` requires the following changes, informed by the updates made to implement [`monitoring-mode`](https://github.com/Nordstrom/serverless-artillery/pull/107/files#diff-31562d4ba875e17c1c33cdfd175a99f4).\r\n\r\n* Add `version` set to `0.0.1`\r\n* Update `license` to `Apache-2.0`\r\n* Remove the following dependencies:\r\n```\r\n    \"artillery-core\": \"^2.0.3-0\",\r\n    \"csv-parse\": \"^1.1.7\"\r\n```\r\n* Add the following dependiencies:\r\n```\r\n    \"artillery\": \"git+https://github.com/Nordstrom/artillery.git#2d99b7ab1075e9df9f6eb2903102abc7849f1879\",\r\n    \"js-yaml\": \"^3.11.0\",\r\n    \"lodash.merge\": \"^4.6.1\",\r\n    \"lodash.omit\": \"^4.5.0\",\r\n    \"util-promisify\": \"^2.1.0\"\r\n``` \r\n\r\nNote: This takes a dependency on our private branch of Artillery. We need to discuss if this is the appropriate decision.\r\n\r\nAlso, there is a risk of breaking the developer's project if they've taken a dependency on either `artillery-core` or `csv-parse` in their code. This seems unlikely to occur and also difficult to detect when this is the case."}}
{"actor":{"display_login":"gwsii"}}