{"action":"opened","issue":{"url":"https://api.github.com/repos/scikit-learn-contrib/imbalanced-learn/issues/508","repository_url":"https://api.github.com/repos/scikit-learn-contrib/imbalanced-learn","labels_url":"https://api.github.com/repos/scikit-learn-contrib/imbalanced-learn/issues/508/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn-contrib/imbalanced-learn/issues/508/comments","events_url":"https://api.github.com/repos/scikit-learn-contrib/imbalanced-learn/issues/508/events","html_url":"https://github.com/scikit-learn-contrib/imbalanced-learn/issues/508","id":381851683,"node_id":"MDU6SXNzdWUzODE4NTE2ODM=","number":508,"title":"API design when passing a callable to `sampling_strategy`","user":{"login":"glemaitre","id":7454015,"node_id":"MDQ6VXNlcjc0NTQwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-17T10:51:01Z","updated_at":"2018-11-17T10:51:01Z","closed_at":null,"author_association":"MEMBER","body":"`sampling_strategy` accepts callable. However, even if `check_sampling_strategy` accepts keywords with this callable, the `BaseSampler` API does not allow to pass these parameters. We have to define those parameters within a closure which start to be a bit cryptic to be used, IMO.\r\n\r\nWe should think about allowing to pass some parameters with the callable in an easy manner. We should make it easy such that a user can set this callable and parameter with `set_params` as well. The most naive solution might be to pass a tuple (callable, kw_params).\r\n\r\n@chkoar any thoughts on that?"}}
{"actor":{"display_login":"glemaitre"}}