{"action":"created","comment":{"url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/comments/239507398","pull_request_review_id":182309756,"id":239507398,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUwNzM5OA==","diff_hunk":"@@ -0,0 +1,124 @@\n+package calculator.example.com.kotlincalculator.mvp\n+\n+import calculator.example.com.kotlincalculator.CalculatorActivity\n+import calculator.example.com.kotlincalculator.bus.observer.OnCalculatorActionButtonPressedBusObserver\n+import calculator.example.com.kotlincalculator.bus.observer.OnCalculatorClearButtonPressedBusObserver\n+import calculator.example.com.kotlincalculator.bus.observer.OnCalculatorEqualButtonPressedBusObserver\n+import calculator.example.com.kotlincalculator.bus.observer.OnCalculatorNumberButtonPressedBusObserver\n+import calculator.example.com.kotlincalculator.mvp.model.CalculatorActions\n+import calculator.example.com.kotlincalculator.mvp.model.CalculatorModel\n+import calculator.example.com.kotlincalculator.mvp.view.CalculatorView\n+import com.globant.counter.utils.bus.RxBus\n+import org.junit.After\n+import org.junit.Assert.assertEquals\n+import org.junit.Before\n+import org.junit.Test\n+import org.mockito.Mock\n+import org.mockito.Mockito.*\n+import org.mockito.MockitoAnnotations\n+import org.mockito.Mockito.`when` as whenever\n+\n+class CalculatorPresenterTest {\n+\n+    private var presenter: CalculatorPresenter? = null\n+    private var model: CalculatorModel? = null","path":"app/src/test/java/calculator/example/com/kotlincalculator/mvp/CalculatorPresenterTest.kt","position":24,"original_position":24,"commit_id":"348246fde01b24655a3f884e170061913f2a06ca","original_commit_id":"a55b3e02000d7342311df6889c19d6cec3aa03d0","user":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"body":"I could, however in this test Im also testing the interactions between the `Presenter` and the `model ` if I mock the `model` i would have to mock every interaction (by using mockito for example) and as in this case the model is not a complex object (so the effort to do it does not make sense neither) I will keep it as non-mock so it will operate normally ","created_at":"2018-12-06T15:56:26Z","updated_at":"2018-12-06T15:56:27Z","html_url":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1#discussion_r239507398","pull_request_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/comments/239507398"},"html":{"href":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1#discussion_r239507398"},"pull_request":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1"}},"in_reply_to_id":239480407},"pull_request":{"url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1","id":235920727,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTIwNzI3","html_url":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1","diff_url":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1.diff","patch_url":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1.patch","issue_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/1","number":1,"state":"open","locked":false,"title":"KOTLIN - Presenter First - MVP Calculator ","user":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"body":"## Description \r\n\r\nSimple Calculator App using \r\n- Kotlin \r\n- MVP Pattern\r\n- Presenter First (PF) \r\n\r\n##  Test done \r\n- Nexus 4 emulator \r\n\r\n## Images \r\n![kotlincalculator](https://user-images.githubusercontent.com/11579887/49465559-ecea4d00-f7cb-11e8-9744-79d6b4da1701.gif)\r\n\r\n\r\n\r\n","created_at":"2018-12-04T18:53:25Z","updated_at":"2018-12-06T15:56:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7eb7031b83c98faff5290d4e7cb17c1c848cbcc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/1/comments","statuses_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/statuses/348246fde01b24655a3f884e170061913f2a06ca","head":{"label":"ingjuanocampo:calculator/ingjuanocampo/implementing_PF_MVP","ref":"calculator/ingjuanocampo/implementing_PF_MVP","sha":"348246fde01b24655a3f884e170061913f2a06ca","user":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"repo":{"id":160221372,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMjEzNzI=","name":"Kotlin-Calculator","full_name":"ingjuanocampo/Kotlin-Calculator","private":false,"owner":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ingjuanocampo/Kotlin-Calculator","description":"Kotlin Example code, Using MVP and Clean Architecture ","fork":false,"url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator","forks_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/forks","keys_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/teams","hooks_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/hooks","issue_events_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/events","assignees_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/tags","blobs_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/languages","stargazers_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/stargazers","contributors_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/contributors","subscribers_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/subscribers","subscription_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/subscription","commits_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/merges","archive_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/downloads","issues_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/deployments","created_at":"2018-12-03T16:31:18Z","updated_at":"2018-12-03T16:31:21Z","pushed_at":"2018-12-06T15:45:27Z","git_url":"git://github.com/ingjuanocampo/Kotlin-Calculator.git","ssh_url":"git@github.com:ingjuanocampo/Kotlin-Calculator.git","clone_url":"https://github.com/ingjuanocampo/Kotlin-Calculator.git","svn_url":"https://github.com/ingjuanocampo/Kotlin-Calculator","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ingjuanocampo:master","ref":"master","sha":"fcb2a863572753124e439ee61e746cfe0ed8cbee","user":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"repo":{"id":160221372,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMjEzNzI=","name":"Kotlin-Calculator","full_name":"ingjuanocampo/Kotlin-Calculator","private":false,"owner":{"login":"ingjuanocampo","id":11579887,"node_id":"MDQ6VXNlcjExNTc5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/11579887?v=4","gravatar_id":"","url":"https://api.github.com/users/ingjuanocampo","html_url":"https://github.com/ingjuanocampo","followers_url":"https://api.github.com/users/ingjuanocampo/followers","following_url":"https://api.github.com/users/ingjuanocampo/following{/other_user}","gists_url":"https://api.github.com/users/ingjuanocampo/gists{/gist_id}","starred_url":"https://api.github.com/users/ingjuanocampo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingjuanocampo/subscriptions","organizations_url":"https://api.github.com/users/ingjuanocampo/orgs","repos_url":"https://api.github.com/users/ingjuanocampo/repos","events_url":"https://api.github.com/users/ingjuanocampo/events{/privacy}","received_events_url":"https://api.github.com/users/ingjuanocampo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ingjuanocampo/Kotlin-Calculator","description":"Kotlin Example code, Using MVP and Clean Architecture ","fork":false,"url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator","forks_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/forks","keys_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/teams","hooks_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/hooks","issue_events_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/events","assignees_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/tags","blobs_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/languages","stargazers_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/stargazers","contributors_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/contributors","subscribers_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/subscribers","subscription_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/subscription","commits_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/merges","archive_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/downloads","issues_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/deployments","created_at":"2018-12-03T16:31:18Z","updated_at":"2018-12-03T16:31:21Z","pushed_at":"2018-12-06T15:45:27Z","git_url":"git://github.com/ingjuanocampo/Kotlin-Calculator.git","ssh_url":"git@github.com:ingjuanocampo/Kotlin-Calculator.git","clone_url":"https://github.com/ingjuanocampo/Kotlin-Calculator.git","svn_url":"https://github.com/ingjuanocampo/Kotlin-Calculator","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1"},"html":{"href":"https://github.com/ingjuanocampo/Kotlin-Calculator/pull/1"},"issue":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/1"},"comments":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ingjuanocampo/Kotlin-Calculator/statuses/348246fde01b24655a3f884e170061913f2a06ca"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ingjuanocampo"}}