{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/216155484","pull_request_review_id":153579743,"id":216155484,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE1NTQ4NA==","diff_hunk":"@@ -261,7 +262,8 @@ static private native int createFileWithPermissionsImpl(String path,\n \tstatic String getTmpDir() {\n \t\tString tmpDir = getTempDirImpl();\n \t\tif (null == tmpDir) {\n-\t\t\ttmpDir = com.ibm.oti.vm.VM.getVMLangAccess().internalGetProperties().getProperty(\"java.io.tmpdir\"); //$NON-NLS-1$\n+\t\t\tIPC.logMessage(\"Could not get system temporary directory. Trying \"+JAVA_IO_TMPDIR); //$NON-NLS-1$\n+\t\t\ttmpDir = com.ibm.oti.vm.VM.getVMLangAccess().internalGetProperties().getProperty(JAVA_IO_TMPDIR); //$NON-NLS-1$","path":"jcl/src/java.base/share/classes/com/ibm/tools/attach/target/IPC.java","position":14,"original_position":14,"commit_id":"ceb4f8ee550dc226da6f35f78d1ef1a9d6ff5717","original_commit_id":"ceb4f8ee550dc226da6f35f78d1ef1a9d6ff5717","user":{"login":"CodingFabian","id":176132,"node_id":"MDQ6VXNlcjE3NjEzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/176132?v=4","gravatar_id":"","url":"https://api.github.com/users/CodingFabian","html_url":"https://github.com/CodingFabian","followers_url":"https://api.github.com/users/CodingFabian/followers","following_url":"https://api.github.com/users/CodingFabian/following{/other_user}","gists_url":"https://api.github.com/users/CodingFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingFabian/subscriptions","organizations_url":"https://api.github.com/users/CodingFabian/orgs","repos_url":"https://api.github.com/users/CodingFabian/repos","events_url":"https://api.github.com/users/CodingFabian/events{/privacy}","received_events_url":"https://api.github.com/users/CodingFabian/received_events","type":"User","site_admin":false},"body":"will this default to /tmp if not set?","created_at":"2018-09-09T11:55:27Z","updated_at":"2018-09-09T11:55:31Z","html_url":"https://github.com/eclipse/openj9/pull/2803#discussion_r216155484","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2803","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/216155484"},"html":{"href":"https://github.com/eclipse/openj9/pull/2803#discussion_r216155484"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2803"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2803","id":213995036,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTk1MDM2","html_url":"https://github.com/eclipse/openj9/pull/2803","diff_url":"https://github.com/eclipse/openj9/pull/2803.diff","patch_url":"https://github.com/eclipse/openj9/pull/2803.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2803","number":2803,"state":"open","locked":false,"title":"Handle string conversion errors in attach API","user":{"login":"pdbain-ibm","id":18007966,"node_id":"MDQ6VXNlcjE4MDA3OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/18007966?v=4","gravatar_id":"","url":"https://api.github.com/users/pdbain-ibm","html_url":"https://github.com/pdbain-ibm","followers_url":"https://api.github.com/users/pdbain-ibm/followers","following_url":"https://api.github.com/users/pdbain-ibm/following{/other_user}","gists_url":"https://api.github.com/users/pdbain-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/pdbain-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdbain-ibm/subscriptions","organizations_url":"https://api.github.com/users/pdbain-ibm/orgs","repos_url":"https://api.github.com/users/pdbain-ibm/repos","events_url":"https://api.github.com/users/pdbain-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/pdbain-ibm/received_events","type":"User","site_admin":false},"body":"If the name of the temporary directory cannot be converted to UTF-16, use the\r\nJava system property.\r\n\r\nFixes https://github.com/eclipse/openj9/issues/2781\r\n\r\nSigned-off-by: Peter Bain <peter_bain@ca.ibm.com>","created_at":"2018-09-07T17:39:44Z","updated_at":"2018-09-09T11:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50349e56e4abb65fa58c5ceba97d9b408c57c2fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2803/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2803/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2803/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/ceb4f8ee550dc226da6f35f78d1ef1a9d6ff5717","head":{"label":"pdbain-ibm:attach","ref":"attach","sha":"ceb4f8ee550dc226da6f35f78d1ef1a9d6ff5717","user":{"login":"pdbain-ibm","id":18007966,"node_id":"MDQ6VXNlcjE4MDA3OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/18007966?v=4","gravatar_id":"","url":"https://api.github.com/users/pdbain-ibm","html_url":"https://github.com/pdbain-ibm","followers_url":"https://api.github.com/users/pdbain-ibm/followers","following_url":"https://api.github.com/users/pdbain-ibm/following{/other_user}","gists_url":"https://api.github.com/users/pdbain-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/pdbain-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdbain-ibm/subscriptions","organizations_url":"https://api.github.com/users/pdbain-ibm/orgs","repos_url":"https://api.github.com/users/pdbain-ibm/repos","events_url":"https://api.github.com/users/pdbain-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/pdbain-ibm/received_events","type":"User","site_admin":false},"repo":{"id":103548540,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1NDg1NDA=","name":"openj9","full_name":"pdbain-ibm/openj9","owner":{"login":"pdbain-ibm","id":18007966,"node_id":"MDQ6VXNlcjE4MDA3OTY2","avatar_url":"https://avatars1.githubusercontent.com/u/18007966?v=4","gravatar_id":"","url":"https://api.github.com/users/pdbain-ibm","html_url":"https://github.com/pdbain-ibm","followers_url":"https://api.github.com/users/pdbain-ibm/followers","following_url":"https://api.github.com/users/pdbain-ibm/following{/other_user}","gists_url":"https://api.github.com/users/pdbain-ibm/gists{/gist_id}","starred_url":"https://api.github.com/users/pdbain-ibm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdbain-ibm/subscriptions","organizations_url":"https://api.github.com/users/pdbain-ibm/orgs","repos_url":"https://api.github.com/users/pdbain-ibm/repos","events_url":"https://api.github.com/users/pdbain-ibm/events{/privacy}","received_events_url":"https://api.github.com/users/pdbain-ibm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdbain-ibm/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/pdbain-ibm/openj9","forks_url":"https://api.github.com/repos/pdbain-ibm/openj9/forks","keys_url":"https://api.github.com/repos/pdbain-ibm/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdbain-ibm/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdbain-ibm/openj9/teams","hooks_url":"https://api.github.com/repos/pdbain-ibm/openj9/hooks","issue_events_url":"https://api.github.com/repos/pdbain-ibm/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/pdbain-ibm/openj9/events","assignees_url":"https://api.github.com/repos/pdbain-ibm/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/pdbain-ibm/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/pdbain-ibm/openj9/tags","blobs_url":"https://api.github.com/repos/pdbain-ibm/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdbain-ibm/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdbain-ibm/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdbain-ibm/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdbain-ibm/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/pdbain-ibm/openj9/languages","stargazers_url":"https://api.github.com/repos/pdbain-ibm/openj9/stargazers","contributors_url":"https://api.github.com/repos/pdbain-ibm/openj9/contributors","subscribers_url":"https://api.github.com/repos/pdbain-ibm/openj9/subscribers","subscription_url":"https://api.github.com/repos/pdbain-ibm/openj9/subscription","commits_url":"https://api.github.com/repos/pdbain-ibm/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdbain-ibm/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdbain-ibm/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdbain-ibm/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdbain-ibm/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/pdbain-ibm/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdbain-ibm/openj9/merges","archive_url":"https://api.github.com/repos/pdbain-ibm/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdbain-ibm/openj9/downloads","issues_url":"https://api.github.com/repos/pdbain-ibm/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/pdbain-ibm/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/pdbain-ibm/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/pdbain-ibm/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdbain-ibm/openj9/labels{/name}","releases_url":"https://api.github.com/repos/pdbain-ibm/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/pdbain-ibm/openj9/deployments","created_at":"2017-09-14T15:19:47Z","updated_at":"2018-09-07T18:00:02Z","pushed_at":"2018-09-07T17:59:55Z","git_url":"git://github.com/pdbain-ibm/openj9.git","ssh_url":"git@github.com:pdbain-ibm/openj9.git","clone_url":"https://github.com/pdbain-ibm/openj9.git","svn_url":"https://github.com/pdbain-ibm/openj9","homepage":null,"size":33907,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"87d1393122eb15b590a3885df46ba64546494f8f","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-09-08T02:14:20Z","pushed_at":"2018-09-09T04:11:16Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":33907,"stargazers_count":1399,"watchers_count":1399,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"archived":false,"open_issues_count":454,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":275,"open_issues":454,"watchers":1399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2803"},"html":{"href":"https://github.com/eclipse/openj9/pull/2803"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2803"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2803/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2803/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2803/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/ceb4f8ee550dc226da6f35f78d1ef1a9d6ff5717"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CodingFabian"}}