{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/comments/216107675","pull_request_review_id":153528133,"id":216107675,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEwNzY3NQ==","diff_hunk":"@@ -63,27 +62,44 @@ def build(no_cache: false, version: nil, build_args: [], latest: true)\n \n       path = \"#{repository}/#{image_name}\"\n \n-      build_options = {'dockerfile' => dockerfile, 'buildargs' => \"#{build_args_hash.to_json}\"}\n-\n+      build_options = ''","path":"lib/puppet_docker_tools/runner.rb","position":21,"original_position":21,"commit_id":"a3912953fb44bb0f18e810ac200cc3facfea5832","original_commit_id":"a3912953fb44bb0f18e810ac200cc3facfea5832","user":{"login":"Iristyle","id":394081,"node_id":"MDQ6VXNlcjM5NDA4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"Rather than concatenating args yourself, it's usually better to keep an array, and use that form of arg passing to `popen`. Then you don't have to worry about weird quoting rules, etc (which could be a problem on Windows)\r\n\r\nSee examples at:\r\nhttps://ruby-doc.org/stdlib-2.4.0/libdoc/open3/rdoc/Open3.html#method-c-popen2e","created_at":"2018-09-07T23:12:08Z","updated_at":"2018-09-07T23:12:08Z","html_url":"https://github.com/puppetlabs/puppet_docker_tools/pull/25#discussion_r216107675","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/comments/216107675"},"html":{"href":"https://github.com/puppetlabs/puppet_docker_tools/pull/25#discussion_r216107675"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25","id":214057190,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDU3MTkw","html_url":"https://github.com/puppetlabs/puppet_docker_tools/pull/25","diff_url":"https://github.com/puppetlabs/puppet_docker_tools/pull/25.diff","patch_url":"https://github.com/puppetlabs/puppet_docker_tools/pull/25.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/25","number":25,"state":"open","locked":false,"title":"Undo docker gem","user":{"login":"underscorgan","id":553464,"node_id":"MDQ6VXNlcjU1MzQ2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/553464?v=4","gravatar_id":"","url":"https://api.github.com/users/underscorgan","html_url":"https://github.com/underscorgan","followers_url":"https://api.github.com/users/underscorgan/followers","following_url":"https://api.github.com/users/underscorgan/following{/other_user}","gists_url":"https://api.github.com/users/underscorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/underscorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underscorgan/subscriptions","organizations_url":"https://api.github.com/users/underscorgan/orgs","repos_url":"https://api.github.com/users/underscorgan/repos","events_url":"https://api.github.com/users/underscorgan/events{/privacy}","received_events_url":"https://api.github.com/users/underscorgan/received_events","type":"User","site_admin":false},"body":"Still to-do: unraveling it from the tests","created_at":"2018-09-07T22:54:08Z","updated_at":"2018-09-07T23:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd0c029943afc13db2fb281c105573091436d8eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/25/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/statuses/a3912953fb44bb0f18e810ac200cc3facfea5832","head":{"label":"underscorgan:undo-docker-gem","ref":"undo-docker-gem","sha":"a3912953fb44bb0f18e810ac200cc3facfea5832","user":{"login":"underscorgan","id":553464,"node_id":"MDQ6VXNlcjU1MzQ2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/553464?v=4","gravatar_id":"","url":"https://api.github.com/users/underscorgan","html_url":"https://github.com/underscorgan","followers_url":"https://api.github.com/users/underscorgan/followers","following_url":"https://api.github.com/users/underscorgan/following{/other_user}","gists_url":"https://api.github.com/users/underscorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/underscorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underscorgan/subscriptions","organizations_url":"https://api.github.com/users/underscorgan/orgs","repos_url":"https://api.github.com/users/underscorgan/repos","events_url":"https://api.github.com/users/underscorgan/events{/privacy}","received_events_url":"https://api.github.com/users/underscorgan/received_events","type":"User","site_admin":false},"repo":{"id":132679863,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2Nzk4NjM=","name":"puppet_docker_tools","full_name":"underscorgan/puppet_docker_tools","owner":{"login":"underscorgan","id":553464,"node_id":"MDQ6VXNlcjU1MzQ2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/553464?v=4","gravatar_id":"","url":"https://api.github.com/users/underscorgan","html_url":"https://github.com/underscorgan","followers_url":"https://api.github.com/users/underscorgan/followers","following_url":"https://api.github.com/users/underscorgan/following{/other_user}","gists_url":"https://api.github.com/users/underscorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/underscorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underscorgan/subscriptions","organizations_url":"https://api.github.com/users/underscorgan/orgs","repos_url":"https://api.github.com/users/underscorgan/repos","events_url":"https://api.github.com/users/underscorgan/events{/privacy}","received_events_url":"https://api.github.com/users/underscorgan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/underscorgan/puppet_docker_tools","description":"Utilities for building and publishing the docker images at https://hub.docker.com/u/puppet","fork":true,"url":"https://api.github.com/repos/underscorgan/puppet_docker_tools","forks_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/forks","keys_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/teams","hooks_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/hooks","issue_events_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/issues/events{/number}","events_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/events","assignees_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/assignees{/user}","branches_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/branches{/branch}","tags_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/tags","blobs_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/languages","stargazers_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/stargazers","contributors_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/contributors","subscribers_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/subscribers","subscription_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/subscription","commits_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/contents/{+path}","compare_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/merges","archive_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/downloads","issues_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/issues{/number}","pulls_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/labels{/name}","releases_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/releases{/id}","deployments_url":"https://api.github.com/repos/underscorgan/puppet_docker_tools/deployments","created_at":"2018-05-09T00:26:34Z","updated_at":"2018-05-09T00:26:36Z","pushed_at":"2018-09-07T22:53:21Z","git_url":"git://github.com/underscorgan/puppet_docker_tools.git","ssh_url":"git@github.com:underscorgan/puppet_docker_tools.git","clone_url":"https://github.com/underscorgan/puppet_docker_tools.git","svn_url":"https://github.com/underscorgan/puppet_docker_tools","homepage":"","size":102,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6749ed01566106497694c378dbbd0f75a67929d2","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":132679092,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2NzkwOTI=","name":"puppet_docker_tools","full_name":"puppetlabs/puppet_docker_tools","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet_docker_tools","description":"Utilities for building and publishing the docker images at https://hub.docker.com/u/puppet","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools","forks_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/deployments","created_at":"2018-05-09T00:14:35Z","updated_at":"2018-07-10T22:04:44Z","pushed_at":"2018-09-07T22:54:08Z","git_url":"git://github.com/puppetlabs/puppet_docker_tools.git","ssh_url":"git@github.com:puppetlabs/puppet_docker_tools.git","clone_url":"https://github.com/puppetlabs/puppet_docker_tools.git","svn_url":"https://github.com/puppetlabs/puppet_docker_tools","homepage":"","size":97,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25"},"html":{"href":"https://github.com/puppetlabs/puppet_docker_tools/pull/25"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/25"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet_docker_tools/statuses/a3912953fb44bb0f18e810ac200cc3facfea5832"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Iristyle"}}