{"action":"opened","number":648,"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/648","id":213244010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjQ0MDEw","html_url":"https://github.com/kiali/kiali-ui/pull/648","diff_url":"https://github.com/kiali/kiali-ui/pull/648.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/648.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/648","number":648,"state":"open","locked":false,"title":"KIALI-1235 Graph: lock icon disappear when json indicates that","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"body":"** Describe the change **\r\nIn graph, lock icon didn't disappear when json stop sending `isMTLS` field. It turns out that there was a missing default value which made the graph to keep the mTLS previous value.\r\n\r\n** Issue reference **\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1235\r\nhttps://issues.jboss.org/browse/KIALI-1238\r\n\r\n** Backwards compatible? **\r\nYes.\r\n\r\nIs your pull-request introducing changes in behaviour?\r\nYes.\r\n\r\nLock icon disappears when istio switch from using security connection to non-security one.\r\n\r\n** Screenshot **\r\n\r\n![screen recording 2](https://user-images.githubusercontent.com/613814/45087729-2e088d80-b107-11e8-8549-660bbedbfe16.gif)\r\n\r\n","created_at":"2018-09-05T10:28:51Z","updated_at":"2018-09-05T10:28:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/648/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/648/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/648/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/d416483c8bef49869aaa8d6a34d1348ae186ac55","head":{"label":"xeviknal:KIALI-1235","ref":"KIALI-1235","sha":"d416483c8bef49869aaa8d6a34d1348ae186ac55","user":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"repo":{"id":123581522,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1ODE1MjI=","name":"kiali-ui","full_name":"xeviknal/kiali-ui","owner":{"login":"xeviknal","id":613814,"node_id":"MDQ6VXNlcjYxMzgxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/613814?v=4","gravatar_id":"","url":"https://api.github.com/users/xeviknal","html_url":"https://github.com/xeviknal","followers_url":"https://api.github.com/users/xeviknal/followers","following_url":"https://api.github.com/users/xeviknal/following{/other_user}","gists_url":"https://api.github.com/users/xeviknal/gists{/gist_id}","starred_url":"https://api.github.com/users/xeviknal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeviknal/subscriptions","organizations_url":"https://api.github.com/users/xeviknal/orgs","repos_url":"https://api.github.com/users/xeviknal/repos","events_url":"https://api.github.com/users/xeviknal/events{/privacy}","received_events_url":"https://api.github.com/users/xeviknal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xeviknal/kiali-ui","description":null,"fork":true,"url":"https://api.github.com/repos/xeviknal/kiali-ui","forks_url":"https://api.github.com/repos/xeviknal/kiali-ui/forks","keys_url":"https://api.github.com/repos/xeviknal/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xeviknal/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xeviknal/kiali-ui/teams","hooks_url":"https://api.github.com/repos/xeviknal/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/xeviknal/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/xeviknal/kiali-ui/events","assignees_url":"https://api.github.com/repos/xeviknal/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/xeviknal/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/xeviknal/kiali-ui/tags","blobs_url":"https://api.github.com/repos/xeviknal/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xeviknal/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xeviknal/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/xeviknal/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xeviknal/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/xeviknal/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/xeviknal/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/xeviknal/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/xeviknal/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/xeviknal/kiali-ui/subscription","commits_url":"https://api.github.com/repos/xeviknal/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/xeviknal/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/xeviknal/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/xeviknal/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/xeviknal/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/xeviknal/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xeviknal/kiali-ui/merges","archive_url":"https://api.github.com/repos/xeviknal/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xeviknal/kiali-ui/downloads","issues_url":"https://api.github.com/repos/xeviknal/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/xeviknal/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/xeviknal/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/xeviknal/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xeviknal/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/xeviknal/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/xeviknal/kiali-ui/deployments","created_at":"2018-03-02T13:20:14Z","updated_at":"2018-06-12T09:10:45Z","pushed_at":"2018-09-05T10:12:50Z","git_url":"git://github.com/xeviknal/kiali-ui.git","ssh_url":"git@github.com:xeviknal/kiali-ui.git","clone_url":"https://github.com/xeviknal/kiali-ui.git","svn_url":"https://github.com/xeviknal/kiali-ui","homepage":null,"size":2863,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"19bdb4b6d141f52266b1d63832e6ebd26f843354","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDgyNjQ=","name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali (use kiali/kial to report issues)","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-09-05T08:08:35Z","pushed_at":"2018-09-05T10:11:15Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"https://kiali.io","size":2884,"stargazers_count":31,"watchers_count":31,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":6,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/648"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/648"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/648"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/d416483c8bef49869aaa8d6a34d1348ae186ac55"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"xeviknal"}}