{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/240556716","pull_request_review_id":183610087,"id":240556716,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU1NjcxNg==","diff_hunk":"@@ -285,6 +285,10 @@ ApplicationImpl::~ApplicationImpl()\n     if (mWorkScheduler)\n     {\n         mWorkScheduler->shutdown();\n+        while (mWorkScheduler->getState() != BasicWork::State::WORK_ABORTED)","path":"src/main/ApplicationImpl.cpp","position":50,"original_position":4,"commit_id":"b007949f34bd5a08e9e0ab141e36b58e7d34bbb5","original_commit_id":"a7b9b0a24df01b76a729ed6f21eee0c25397c3ff","user":{"login":"vogel","id":101391,"node_id":"MDQ6VXNlcjEwMTM5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101391?v=4","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"body":"this makes me think:\r\n\r\nWorkScheduler never gets into WORK_SUCCESS or WORK_FAILURE states\r\n\r\nIt also never uses most of Work/BasicWork APIs. So it is really a Work? Maybe it would be better for it to have an internal never-ending Work item and make all scheduled Works children of that one?","created_at":"2018-12-11T10:40:56Z","updated_at":"2018-12-11T10:40:57Z","html_url":"https://github.com/stellar/stellar-core/pull/1819#discussion_r240556716","pull_request_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1819","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/240556716"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1819#discussion_r240556716"},"pull_request":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1819"}}},"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/1819","id":226670220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjcwMjIw","html_url":"https://github.com/stellar/stellar-core/pull/1819","diff_url":"https://github.com/stellar/stellar-core/pull/1819.diff","patch_url":"https://github.com/stellar/stellar-core/pull/1819.patch","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/1819","number":1819,"state":"open","locked":false,"title":"New work interface implementation","user":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"body":"Work interface makeover based on the following discussions:\r\nhttps://github.com/stellar/stellar-core/issues/1755 - original issue with design brainstorm\r\nhttps://github.com/stellar/stellar-core/pull/1801 - rough prototype to exhibit how Work would operate\r\n","created_at":"2018-10-29T18:36:30Z","updated_at":"2018-12-11T10:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29a1d9c2c0f44650866d4f1904c4d276078a61c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1819/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1819/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/1819/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/b007949f34bd5a08e9e0ab141e36b58e7d34bbb5","head":{"label":"marta-lokhova:new_work_interface_builds","ref":"new_work_interface_builds","sha":"b007949f34bd5a08e9e0ab141e36b58e7d34bbb5","user":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"repo":{"id":120042958,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNDI5NTg=","name":"stellar-core","full_name":"marta-lokhova/stellar-core","private":false,"owner":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marta-lokhova/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/marta-lokhova/stellar-core","forks_url":"https://api.github.com/repos/marta-lokhova/stellar-core/forks","keys_url":"https://api.github.com/repos/marta-lokhova/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marta-lokhova/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marta-lokhova/stellar-core/teams","hooks_url":"https://api.github.com/repos/marta-lokhova/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/marta-lokhova/stellar-core/events","assignees_url":"https://api.github.com/repos/marta-lokhova/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/marta-lokhova/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/marta-lokhova/stellar-core/tags","blobs_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marta-lokhova/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/marta-lokhova/stellar-core/languages","stargazers_url":"https://api.github.com/repos/marta-lokhova/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/marta-lokhova/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/marta-lokhova/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/marta-lokhova/stellar-core/subscription","commits_url":"https://api.github.com/repos/marta-lokhova/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/marta-lokhova/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/marta-lokhova/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/marta-lokhova/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marta-lokhova/stellar-core/merges","archive_url":"https://api.github.com/repos/marta-lokhova/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marta-lokhova/stellar-core/downloads","issues_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/marta-lokhova/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/marta-lokhova/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/marta-lokhova/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marta-lokhova/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/marta-lokhova/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/marta-lokhova/stellar-core/deployments","created_at":"2018-02-02T23:38:31Z","updated_at":"2018-12-10T19:32:35Z","pushed_at":"2018-12-11T01:46:09Z","git_url":"git://github.com/marta-lokhova/stellar-core.git","ssh_url":"git@github.com:marta-lokhova/stellar-core.git","clone_url":"https://github.com/marta-lokhova/stellar-core.git","svn_url":"https://github.com/marta-lokhova/stellar-core","homepage":"","size":15944,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"3274bb3213c5aa1ef7139447ec4375a53629c316","user":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":27085821,"node_id":"MDEwOlJlcG9zaXRvcnkyNzA4NTgyMQ==","name":"stellar-core","full_name":"stellar/stellar-core","private":false,"owner":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stellar/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-core","forks_url":"https://api.github.com/repos/stellar/stellar-core/forks","keys_url":"https://api.github.com/repos/stellar/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-core/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-core/events","assignees_url":"https://api.github.com/repos/stellar/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-core/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-core/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-core/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-core/merges","archive_url":"https://api.github.com/repos/stellar/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-core/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-core/deployments","created_at":"2014-11-24T17:11:12Z","updated_at":"2018-12-11T06:47:52Z","pushed_at":"2018-12-11T01:46:11Z","git_url":"git://github.com/stellar/stellar-core.git","ssh_url":"git@github.com:stellar/stellar-core.git","clone_url":"https://github.com/stellar/stellar-core.git","svn_url":"https://github.com/stellar/stellar-core","homepage":"","size":15662,"stargazers_count":1901,"watchers_count":1901,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":558,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":558,"open_issues":150,"watchers":1901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1819"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1819"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1819"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1819/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1819/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1819/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-core/statuses/b007949f34bd5a08e9e0ab141e36b58e7d34bbb5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vogel"}}