{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/55543","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/55543/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/55543/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/55543/events","html_url":"https://github.com/Microsoft/vscode/pull/55543","id":346419220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mjg4MTE1","number":55543,"title":"Settings Editor: Add aria labels for input elements Fixes: #54836","user":{"login":"cleidigh","id":25272315,"node_id":"MDQ6VXNlcjI1MjcyMzE1","avatar_url":"https://avatars0.githubusercontent.com/u/25272315?v=4","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false},"labels":[{"id":316813364,"node_id":"MDU6TGFiZWwzMTY4MTMzNjQ=","url":"https://api.github.com/repos/Microsoft/vscode/labels/accessibility","name":"accessibility","color":"d93f0b","default":false},{"id":529237263,"node_id":"MDU6TGFiZWw1MjkyMzcyNjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/settings-editor","name":"settings-editor","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":{"login":"cleidigh","id":25272315,"node_id":"MDQ6VXNlcjI1MjcyMzE1","avatar_url":"https://avatars0.githubusercontent.com/u/25272315?v=4","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false},"assignees":[{"login":"cleidigh","id":25272315,"node_id":"MDQ6VXNlcjI1MjcyMzE1","avatar_url":"https://avatars0.githubusercontent.com/u/25272315?v=4","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/72","html_url":"https://github.com/Microsoft/vscode/milestone/72","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/72/labels","id":3417555,"node_id":"MDk6TWlsZXN0b25lMzQxNzU1NQ==","number":72,"title":"July 2018","description":"","creator":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":673,"state":"open","created_at":"2018-06-12T01:40:14Z","updated_at":"2018-08-10T05:03:32Z","due_on":"2018-08-03T07:00:00Z","closed_at":null},"comments":14,"created_at":"2018-08-01T01:56:19Z","updated_at":"2018-08-11T20:46:17Z","closed_at":"2018-08-01T02:00:26Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/55543","html_url":"https://github.com/Microsoft/vscode/pull/55543","diff_url":"https://github.com/Microsoft/vscode/pull/55543.diff","patch_url":"https://github.com/Microsoft/vscode/pull/55543.patch"},"body":"@roblourens \r\n\r\nThis addresses labels for input elements as best as possible for elements within a tree.\r\nMy research suggests interactive elements within a tree are not formally supported\r\nbut at least NVDA does its best.\r\n\r\nI believe will have to revisit this with more information, perhaps we need to use treegrid or\r\ngrid both of which explicitly support interactive elements.  These might need to be added as options\r\nfor list and tree widgets\r\n\r\nI will also work at adding support for the links within descriptions but I will wait till after this milestone\r\n\r\nNo response yet on my question on this for NVDA\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/412300577","html_url":"https://github.com/Microsoft/vscode/pull/55543#issuecomment-412300577","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/55543","id":412300577,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjMwMDU3Nw==","user":{"login":"cleidigh","id":25272315,"node_id":"MDQ6VXNlcjI1MjcyMzE1","avatar_url":"https://avatars0.githubusercontent.com/u/25272315?v=4","gravatar_id":"","url":"https://api.github.com/users/cleidigh","html_url":"https://github.com/cleidigh","followers_url":"https://api.github.com/users/cleidigh/followers","following_url":"https://api.github.com/users/cleidigh/following{/other_user}","gists_url":"https://api.github.com/users/cleidigh/gists{/gist_id}","starred_url":"https://api.github.com/users/cleidigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleidigh/subscriptions","organizations_url":"https://api.github.com/users/cleidigh/orgs","repos_url":"https://api.github.com/users/cleidigh/repos","events_url":"https://api.github.com/users/cleidigh/events{/privacy}","received_events_url":"https://api.github.com/users/cleidigh/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T20:46:17Z","updated_at":"2018-08-11T20:46:17Z","author_association":"COLLABORATOR","body":"there are actually issues at multiple points.\r\nFirst, what parent structure/role is being used at the \"top\"  in our case both the list and tree widgets\r\nstructure themselves as a aria tree .\r\nThat requires a particular HTML structure, specifically an unordered list with li elements as tree rows\r\nand with the attribute role=treeitem\r\ndescendent elements under the tree item are usually just text or links or sub branches.  The readers\r\ncan infer for some information from this structure or be helped by additional attributes.  Level, active-descendent, posinset are examples and these are managed by our widgets.\r\n\r\nI did quite a bit of research and it became clear or unclear about how or if interactive form elements\r\nare  fully supported within a tree .  The labels and editable state and content selection all appear to have some quirks in this case.  I'm still trying to figure out if electron 3.0 addresses any of these.\r\n\r\nARIA treegrid and grid unambiguously supports form elements, although I have seen some labeling issues with these as well.\r\n\r\nwe can just some experiments to see what the state of things is."}}
{"actor":{"display_login":"cleidigh"}}