{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/4020","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/4020/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/4020/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/4020/events","html_url":"https://github.com/vaadin/flow/pull/4020","id":318185034,"number":4020,"title":"Add component attribute API","user":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Legioth","id":1294657,"avatar_url":"https://avatars2.githubusercontent.com/u/1294657?v=4","gravatar_id":"","url":"https://api.github.com/users/Legioth","html_url":"https://github.com/Legioth","followers_url":"https://api.github.com/users/Legioth/followers","following_url":"https://api.github.com/users/Legioth/following{/other_user}","gists_url":"https://api.github.com/users/Legioth/gists{/gist_id}","starred_url":"https://api.github.com/users/Legioth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legioth/subscriptions","organizations_url":"https://api.github.com/users/Legioth/orgs","repos_url":"https://api.github.com/users/Legioth/repos","events_url":"https://api.github.com/users/Legioth/events{/privacy}","received_events_url":"https://api.github.com/users/Legioth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-04-26T20:28:35Z","updated_at":"2018-04-30T09:18:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/4020","html_url":"https://github.com/vaadin/flow/pull/4020","diff_url":"https://github.com/vaadin/flow/pull/4020.diff","patch_url":"https://github.com/vaadin/flow/pull/4020.patch"},"body":"The API is in CompnentUtil to avoid bloating the main Component API and\r\nto reduce the risk of mixups with element attributes.\r\n\r\nFixes #2307\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/4020)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/385348212","html_url":"https://github.com/vaadin/flow/pull/4020#issuecomment-385348212","issue_url":"https://api.github.com/repos/vaadin/flow/issues/4020","id":385348212,"user":{"login":"pleku","id":1478381,"avatar_url":"https://avatars1.githubusercontent.com/u/1478381?v=4","gravatar_id":"","url":"https://api.github.com/users/pleku","html_url":"https://github.com/pleku","followers_url":"https://api.github.com/users/pleku/followers","following_url":"https://api.github.com/users/pleku/following{/other_user}","gists_url":"https://api.github.com/users/pleku/gists{/gist_id}","starred_url":"https://api.github.com/users/pleku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleku/subscriptions","organizations_url":"https://api.github.com/users/pleku/orgs","repos_url":"https://api.github.com/users/pleku/repos","events_url":"https://api.github.com/users/pleku/events{/privacy}","received_events_url":"https://api.github.com/users/pleku/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T09:18:20Z","updated_at":"2018-04-30T09:18:20Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[a discussion](https://reviewable.io/reviews/vaadin/flow/4020#-LB5e8W_4fLMCdtbjhOw:-LBKoTye2h6ezgKMCGUY:b-qhofdq) (no related file):*\n<details><summary><i>Previously, Legioth (Leif Åstrand) wrote…</i></summary><blockquote>\n\nIt doesn't directly replace the old ugly `setData` API from previous versions. Instead, it offers a more flexible solution that makes it possible for different parties to store their own data in the component, as described in https://github.com/vaadin/flow/issues/2307#issuecomment-326807910.\n</blockquote></details>\n\nI see that issue as a use case for component users, and it remains impossible regardless of this PR since you cannot discover this solution in any way. So I would keep the issue open. I think the use case is only fulfilled if there is some API that the users can use in the component API or similar. And tutorial might be nice to have too.\n\nSo, :+1: for this PR, but I would not close the issue based on this.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/flow/4020)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pleku"}}