{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/comments/189810288","pull_request_review_id":122059106,"id":189810288,"diff_hunk":"@@ -706,7 +706,12 @@ let write_stream common s destination source_protocol destination_protocol preze\n       return (c, [ Nbd; NoProtocol; Chunked; Human; Tar ])\n     | Sockaddr sockaddr ->\n       let sock = socket sockaddr in\n-      Lwt_unix.connect sock sockaddr >>= fun () ->\n+      Lwt.catch (fun () ->\n+          Lwt_unix.connect sock sockaddr\n+        ) (fun e ->\n+          Lwt_unix.close sock >>= Lwt.fail e","path":"src/impl.ml","position":8,"original_position":8,"commit_id":"93cf7e2f82fa45a2853da5c9a7ea9c1c81decd42","original_commit_id":"93cf7e2f82fa45a2853da5c9a7ea9c1c81decd42","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"`>>=` -> `>>= fun () ->`","created_at":"2018-05-22T08:10:35Z","updated_at":"2018-05-22T08:10:35Z","html_url":"https://github.com/xapi-project/vhd-tool/pull/60#discussion_r189810288","pull_request_url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/comments/189810288"},"html":{"href":"https://github.com/xapi-project/vhd-tool/pull/60#discussion_r189810288"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60","id":189327715,"html_url":"https://github.com/xapi-project/vhd-tool/pull/60","diff_url":"https://github.com/xapi-project/vhd-tool/pull/60.diff","patch_url":"https://github.com/xapi-project/vhd-tool/pull/60.patch","issue_url":"https://api.github.com/repos/xapi-project/vhd-tool/issues/60","number":60,"state":"open","locked":false,"title":"CA-289145: close socket if error occurs when using lwt connect","user":{"login":"krizex","id":3365993,"avatar_url":"https://avatars0.githubusercontent.com/u/3365993?v=4","gravatar_id":"","url":"https://api.github.com/users/krizex","html_url":"https://github.com/krizex","followers_url":"https://api.github.com/users/krizex/followers","following_url":"https://api.github.com/users/krizex/following{/other_user}","gists_url":"https://api.github.com/users/krizex/gists{/gist_id}","starred_url":"https://api.github.com/users/krizex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizex/subscriptions","organizations_url":"https://api.github.com/users/krizex/orgs","repos_url":"https://api.github.com/users/krizex/repos","events_url":"https://api.github.com/users/krizex/events{/privacy}","received_events_url":"https://api.github.com/users/krizex/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Yang Qian <yang.qian@citrix.com>","created_at":"2018-05-21T09:31:04Z","updated_at":"2018-05-22T08:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df875e22bfc1b927181dfd0ff05ac531e0ded612","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60/commits","review_comments_url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60/comments","review_comment_url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/vhd-tool/issues/60/comments","statuses_url":"https://api.github.com/repos/xapi-project/vhd-tool/statuses/93cf7e2f82fa45a2853da5c9a7ea9c1c81decd42","head":{"label":"krizex:CA-289145","ref":"CA-289145","sha":"93cf7e2f82fa45a2853da5c9a7ea9c1c81decd42","user":{"login":"krizex","id":3365993,"avatar_url":"https://avatars0.githubusercontent.com/u/3365993?v=4","gravatar_id":"","url":"https://api.github.com/users/krizex","html_url":"https://github.com/krizex","followers_url":"https://api.github.com/users/krizex/followers","following_url":"https://api.github.com/users/krizex/following{/other_user}","gists_url":"https://api.github.com/users/krizex/gists{/gist_id}","starred_url":"https://api.github.com/users/krizex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizex/subscriptions","organizations_url":"https://api.github.com/users/krizex/orgs","repos_url":"https://api.github.com/users/krizex/repos","events_url":"https://api.github.com/users/krizex/events{/privacy}","received_events_url":"https://api.github.com/users/krizex/received_events","type":"User","site_admin":false},"repo":{"id":134247840,"name":"vhd-tool","full_name":"krizex/vhd-tool","owner":{"login":"krizex","id":3365993,"avatar_url":"https://avatars0.githubusercontent.com/u/3365993?v=4","gravatar_id":"","url":"https://api.github.com/users/krizex","html_url":"https://github.com/krizex","followers_url":"https://api.github.com/users/krizex/followers","following_url":"https://api.github.com/users/krizex/following{/other_user}","gists_url":"https://api.github.com/users/krizex/gists{/gist_id}","starred_url":"https://api.github.com/users/krizex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizex/subscriptions","organizations_url":"https://api.github.com/users/krizex/orgs","repos_url":"https://api.github.com/users/krizex/repos","events_url":"https://api.github.com/users/krizex/events{/privacy}","received_events_url":"https://api.github.com/users/krizex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krizex/vhd-tool","description":"Command-line tools for streaming and manipulating vhd format data","fork":true,"url":"https://api.github.com/repos/krizex/vhd-tool","forks_url":"https://api.github.com/repos/krizex/vhd-tool/forks","keys_url":"https://api.github.com/repos/krizex/vhd-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krizex/vhd-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krizex/vhd-tool/teams","hooks_url":"https://api.github.com/repos/krizex/vhd-tool/hooks","issue_events_url":"https://api.github.com/repos/krizex/vhd-tool/issues/events{/number}","events_url":"https://api.github.com/repos/krizex/vhd-tool/events","assignees_url":"https://api.github.com/repos/krizex/vhd-tool/assignees{/user}","branches_url":"https://api.github.com/repos/krizex/vhd-tool/branches{/branch}","tags_url":"https://api.github.com/repos/krizex/vhd-tool/tags","blobs_url":"https://api.github.com/repos/krizex/vhd-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krizex/vhd-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krizex/vhd-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/krizex/vhd-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krizex/vhd-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/krizex/vhd-tool/languages","stargazers_url":"https://api.github.com/repos/krizex/vhd-tool/stargazers","contributors_url":"https://api.github.com/repos/krizex/vhd-tool/contributors","subscribers_url":"https://api.github.com/repos/krizex/vhd-tool/subscribers","subscription_url":"https://api.github.com/repos/krizex/vhd-tool/subscription","commits_url":"https://api.github.com/repos/krizex/vhd-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/krizex/vhd-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/krizex/vhd-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/krizex/vhd-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/krizex/vhd-tool/contents/{+path}","compare_url":"https://api.github.com/repos/krizex/vhd-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krizex/vhd-tool/merges","archive_url":"https://api.github.com/repos/krizex/vhd-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krizex/vhd-tool/downloads","issues_url":"https://api.github.com/repos/krizex/vhd-tool/issues{/number}","pulls_url":"https://api.github.com/repos/krizex/vhd-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/krizex/vhd-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/krizex/vhd-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krizex/vhd-tool/labels{/name}","releases_url":"https://api.github.com/repos/krizex/vhd-tool/releases{/id}","deployments_url":"https://api.github.com/repos/krizex/vhd-tool/deployments","created_at":"2018-05-21T09:29:22Z","updated_at":"2018-05-21T09:29:24Z","pushed_at":"2018-05-22T05:23:11Z","git_url":"git://github.com/krizex/vhd-tool.git","ssh_url":"git@github.com:krizex/vhd-tool.git","clone_url":"https://github.com/krizex/vhd-tool.git","svn_url":"https://github.com/krizex/vhd-tool","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"9db42f18670b07208218d2a4f4d9b7b1bc410f45","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":13275300,"name":"vhd-tool","full_name":"xapi-project/vhd-tool","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/vhd-tool","description":"Command-line tools for streaming and manipulating vhd format data","fork":true,"url":"https://api.github.com/repos/xapi-project/vhd-tool","forks_url":"https://api.github.com/repos/xapi-project/vhd-tool/forks","keys_url":"https://api.github.com/repos/xapi-project/vhd-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/vhd-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/vhd-tool/teams","hooks_url":"https://api.github.com/repos/xapi-project/vhd-tool/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/vhd-tool/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/vhd-tool/events","assignees_url":"https://api.github.com/repos/xapi-project/vhd-tool/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/vhd-tool/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/vhd-tool/tags","blobs_url":"https://api.github.com/repos/xapi-project/vhd-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/vhd-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/vhd-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/vhd-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/vhd-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/vhd-tool/languages","stargazers_url":"https://api.github.com/repos/xapi-project/vhd-tool/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/vhd-tool/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/vhd-tool/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/vhd-tool/subscription","commits_url":"https://api.github.com/repos/xapi-project/vhd-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/vhd-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/vhd-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/vhd-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/vhd-tool/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/vhd-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/vhd-tool/merges","archive_url":"https://api.github.com/repos/xapi-project/vhd-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/vhd-tool/downloads","issues_url":"https://api.github.com/repos/xapi-project/vhd-tool/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/vhd-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/vhd-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/vhd-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/vhd-tool/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/vhd-tool/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/vhd-tool/deployments","created_at":"2013-10-02T15:47:14Z","updated_at":"2018-05-18T17:57:02Z","pushed_at":"2018-05-22T05:23:12Z","git_url":"git://github.com/xapi-project/vhd-tool.git","ssh_url":"git@github.com:xapi-project/vhd-tool.git","clone_url":"https://github.com/xapi-project/vhd-tool.git","svn_url":"https://github.com/xapi-project/vhd-tool","homepage":null,"size":320,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60"},"html":{"href":"https://github.com/xapi-project/vhd-tool/pull/60"},"issue":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/issues/60"},"comments":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/vhd-tool/statuses/93cf7e2f82fa45a2853da5c9a7ea9c1c81decd42"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mseri"}}