{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/187894472","pull_request_review_id":119763075,"id":187894472,"diff_hunk":"@@ -0,0 +1,40 @@\n+// Unless explicitly stated otherwise all files in this repository are licensed\n+// under the Apache License Version 2.0.\n+// This product includes software developed at Datadog (https://www.datadoghq.com/).\n+// Copyright 2018 Datadog, Inc.\n+\n+// +build !systemd\n+\n+package journald\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"github.com/DataDog/datadog-agent/pkg/logs/config\"\n+\t\"github.com/DataDog/datadog-agent/pkg/logs/message\"\n+)\n+\n+// Tailer collects logs from a journal.\n+type Tailer struct {\n+\tsource     *config.LogSource\n+\toutputChan chan message.Message\n+\terrHandler ErrorHandler\n+\tstop       chan struct{}\n+\tdone       chan struct{}\n+}\n+\n+// setup does nothing\n+func (t *Tailer) setup() error {\n+\treturn fmt.Errorf(\"journald is not supported on your system\")","path":"pkg/logs/input/journald/tailer_nosystemd.go","position":28,"original_position":28,"commit_id":"291e6aba41edc4fcd502cd15cad320e617a5a747","original_commit_id":"291e6aba41edc4fcd502cd15cad320e617a5a747","user":{"login":"tmichelet","id":1532259,"avatar_url":"https://avatars0.githubusercontent.com/u/1532259?v=4","gravatar_id":"","url":"https://api.github.com/users/tmichelet","html_url":"https://github.com/tmichelet","followers_url":"https://api.github.com/users/tmichelet/followers","following_url":"https://api.github.com/users/tmichelet/following{/other_user}","gists_url":"https://api.github.com/users/tmichelet/gists{/gist_id}","starred_url":"https://api.github.com/users/tmichelet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmichelet/subscriptions","organizations_url":"https://api.github.com/users/tmichelet/orgs","repos_url":"https://api.github.com/users/tmichelet/repos","events_url":"https://api.github.com/users/tmichelet/events{/privacy}","received_events_url":"https://api.github.com/users/tmichelet/received_events","type":"User","site_admin":false},"body":"your -> this","created_at":"2018-05-14T09:50:37Z","updated_at":"2018-05-14T09:50:37Z","html_url":"https://github.com/DataDog/datadog-agent/pull/1618#discussion_r187894472","pull_request_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/187894472"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/1618#discussion_r187894472"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618","id":183066422,"html_url":"https://github.com/DataDog/datadog-agent/pull/1618","diff_url":"https://github.com/DataDog/datadog-agent/pull/1618.diff","patch_url":"https://github.com/DataDog/datadog-agent/pull/1618.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/1618","number":1618,"state":"open","locked":false,"title":"[Logs]: Added a support for journald","user":{"login":"ajacquemot","id":5777308,"avatar_url":"https://avatars0.githubusercontent.com/u/5777308?v=4","gravatar_id":"","url":"https://api.github.com/users/ajacquemot","html_url":"https://github.com/ajacquemot","followers_url":"https://api.github.com/users/ajacquemot/followers","following_url":"https://api.github.com/users/ajacquemot/following{/other_user}","gists_url":"https://api.github.com/users/ajacquemot/gists{/gist_id}","starred_url":"https://api.github.com/users/ajacquemot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajacquemot/subscriptions","organizations_url":"https://api.github.com/users/ajacquemot/orgs","repos_url":"https://api.github.com/users/ajacquemot/repos","events_url":"https://api.github.com/users/ajacquemot/events{/privacy}","received_events_url":"https://api.github.com/users/ajacquemot/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\n- Added a new kind of input\r\n- Created a Scanner+Tailer to be able to collect logs from journald\r\n- Added a new kind of integration in the configuration\r\n- Updated the auditor to be able to save cursors\r\n\r\n### Motivation\r\n\r\nCollect logs from journald.\r\n\r\n### Additional Notes\r\n\r\nUse of external [package](https://github.com/coreos/go-systemd/tree/master/sdjournal)\r\nThis should close this [issue](https://github.com/DataDog/datadog-agent/issues/948).","created_at":"2018-04-20T13:42:24Z","updated_at":"2018-05-14T09:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d6b79f521003bb5552d560604d5bbfa2b6d6851","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Croissant","id":1224133,"slug":"croissant","description":"Agent and Integrations","privacy":"closed","url":"https://api.github.com/teams/1224133","members_url":"https://api.github.com/teams/1224133/members{/member}","repositories_url":"https://api.github.com/teams/1224133/repos","permission":"pull"}],"labels":[{"id":776720186,"url":"https://api.github.com/repos/DataDog/datadog-agent/labels/component/logs","name":"component/logs","color":"0052cc","default":false},{"id":796118273,"url":"https://api.github.com/repos/DataDog/datadog-agent/labels/noreno","name":"noreno","color":"edd682","default":false},{"id":695416522,"url":"https://api.github.com/repos/DataDog/datadog-agent/labels/team/ramen","name":"team/ramen","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/1618/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/291e6aba41edc4fcd502cd15cad320e617a5a747","head":{"label":"DataDog:ajacquemot/logs_journald","ref":"ajacquemot/logs_journald","sha":"291e6aba41edc4fcd502cd15cad320e617a5a747","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-05-14T07:54:06Z","pushed_at":"2018-05-14T09:03:05Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":18540,"stargazers_count":163,"watchers_count":163,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":87,"watchers":163,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"b8605983994454066ec9c5aa9686ba444b6d3682","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-05-14T07:54:06Z","pushed_at":"2018-05-14T09:03:05Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":18540,"stargazers_count":163,"watchers_count":163,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":52,"open_issues":87,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/1618"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/1618"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/1618/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/1618/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-agent/statuses/291e6aba41edc4fcd502cd15cad320e617a5a747"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tmichelet"}}