{"action":"created","issue":{"url":"https://api.github.com/repos/naemon/naemon-core/issues/255","repository_url":"https://api.github.com/repos/naemon/naemon-core","labels_url":"https://api.github.com/repos/naemon/naemon-core/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/naemon/naemon-core/issues/255/comments","events_url":"https://api.github.com/repos/naemon/naemon-core/issues/255/events","html_url":"https://github.com/naemon/naemon-core/pull/255","id":354724707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDE3Mzg0","number":255,"title":"parse_check: Don't escape already escaped newlines","user":{"login":"jacobbaungard","id":7610459,"node_id":"MDQ6VXNlcjc2MTA0NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/7610459?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobbaungard","html_url":"https://github.com/jacobbaungard","followers_url":"https://api.github.com/users/jacobbaungard/followers","following_url":"https://api.github.com/users/jacobbaungard/following{/other_user}","gists_url":"https://api.github.com/users/jacobbaungard/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobbaungard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobbaungard/subscriptions","organizations_url":"https://api.github.com/users/jacobbaungard/orgs","repos_url":"https://api.github.com/users/jacobbaungard/repos","events_url":"https://api.github.com/users/jacobbaungard/events{/privacy}","received_events_url":"https://api.github.com/users/jacobbaungard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-28T13:11:37Z","updated_at":"2018-08-29T08:28:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/naemon/naemon-core/pulls/255","html_url":"https://github.com/naemon/naemon-core/pull/255","diff_url":"https://github.com/naemon/naemon-core/pull/255.diff","patch_url":"https://github.com/naemon/naemon-core/pull/255.patch"},"body":"This patch ensures that newlines which are already escaped in a check results long_output is not escaped again.\r\n\r\nWhen running [Merlin](https://github.com/op5/merlin) to have a distributed Naemon setup, we had a problem where a check result coming from another node, would have double escaped new lines. Merlin sends check results to different nodes, after the check_result has been parsed. The receiving node would in turn also run it through Naemons check result parsing mechanism. This resulted in newlines being escaped twice, once on the remote node, and once on the master (for example). \r\n\r\nThis fix works by adding \"\\\\n\" to the exception list of g_strescape, which means already escaped newlines won't be escaped again.\r\n\r\nThis fixes [MON-11112](https://jira.op5.com/browse/MON-11112)"},"comment":{"url":"https://api.github.com/repos/naemon/naemon-core/issues/comments/416870038","html_url":"https://github.com/naemon/naemon-core/pull/255#issuecomment-416870038","issue_url":"https://api.github.com/repos/naemon/naemon-core/issues/255","id":416870038,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjg3MDAzOA==","user":{"login":"roengstrom","id":26772201,"node_id":"MDQ6VXNlcjI2NzcyMjAx","avatar_url":"https://avatars0.githubusercontent.com/u/26772201?v=4","gravatar_id":"","url":"https://api.github.com/users/roengstrom","html_url":"https://github.com/roengstrom","followers_url":"https://api.github.com/users/roengstrom/followers","following_url":"https://api.github.com/users/roengstrom/following{/other_user}","gists_url":"https://api.github.com/users/roengstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/roengstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roengstrom/subscriptions","organizations_url":"https://api.github.com/users/roengstrom/orgs","repos_url":"https://api.github.com/users/roengstrom/repos","events_url":"https://api.github.com/users/roengstrom/events{/privacy}","received_events_url":"https://api.github.com/users/roengstrom/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T08:28:43Z","updated_at":"2018-08-29T08:28:43Z","author_association":"CONTRIBUTOR","body":"Nice fix, looks good to me."}}
{"actor":{"display_login":"roengstrom"}}