{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4908","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4908/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4908/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4908/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4908","id":380251739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDk0NTg3","number":4908,"title":"Cloud Volume creation fixes","user":{"login":"martinpovolny","id":51095,"node_id":"MDQ6VXNlcjUxMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"id":505074429,"node_id":"MDU6TGFiZWw1MDUwNzQ0Mjk=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/bug","name":"bug","color":"ee0701","default":true},{"id":505532506,"node_id":"MDU6TGFiZWw1MDU1MzI1MDY=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/compute/cloud","name":"compute/cloud","color":"5319e7","default":false},{"id":1069068141,"node_id":"MDU6TGFiZWwxMDY5MDY4MTQx","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/hammer/yes","name":"hammer/yes","color":"000000","default":false},{"id":534298973,"node_id":"MDU6TGFiZWw1MzQyOTg5NzM=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/storage","name":"storage","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-11-13T14:27:53Z","updated_at":"2018-11-19T18:18:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4908","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4908","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4908.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4908.patch"},"body":"Fixes:\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1644310\r\n\r\n * CloudVolume create: Need to turn off the spinner in both if/else branches.\r\n * Fix a crash when there is a CloudManager that does not have a CloudVolume. Such as Azure.\r\n * Fix the storage manager is not being loaded when creating a new Volume (and therefor `emstype` (and possibly other) parameters where missing) . Therefor the case when adding a new volume w/o selecting a storage manager did not work.\r\n\r\nPart of the problems seem to be coming from 771e97f7251c33d900fa1f244aa6ae294f7995bf .\r\n\r\nPopulate volume types for EBS. Fixing:\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1644306\r\n\r\nI have issues with understanding what are all the possible situations here and what is the expected behavior. Review and more testing is very welcome. Ping @mansam, @miha-plesko, @gberginc "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/439991194","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4908#issuecomment-439991194","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4908","id":439991194,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTk5MTE5NA==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T18:18:06Z","updated_at":"2018-11-19T18:18:06Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/martinpovolny/manageiq-ui-classic/compare/b5d15d85e1071cd7cbd8c50d1b7b58c75cf8a5e1~...4a3c9a3ce165835de7ecc4494fe6df39551ce192 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n5 files checked, 4 offenses detected\n\n**app/controllers/ems_common.rb**\n- [ ] :exclamation: - [Line 209](https://github.com/martinpovolny/manageiq-ui-classic/blob/4a3c9a3ce165835de7ecc4494fe6df39551ce192/app/controllers/ems_common.rb#L209), Col 37 - [Style/SymbolProc](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SymbolProc) - Pass `&:supports_block_storage?` as an argument to `detect` instead of a block.\n\n**app/helpers/application_helper/button/cloud_volume_backup_create.rb**\n- [ ] :exclamation: - [Line 3](https://github.com/martinpovolny/manageiq-ui-classic/blob/4a3c9a3ce165835de7ecc4494fe6df39551ce192/app/helpers/application_helper/button/cloud_volume_backup_create.rb#L3), Col 5 - [Style/InverseMethods](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/InverseMethods) - Use `none?` instead of inverting `any?`.\n\n**app/helpers/application_helper/button/cloud_volume_backup_restore.rb**\n- [ ] :exclamation: - [Line 3](https://github.com/martinpovolny/manageiq-ui-classic/blob/4a3c9a3ce165835de7ecc4494fe6df39551ce192/app/helpers/application_helper/button/cloud_volume_backup_restore.rb#L3), Col 5 - [Style/InverseMethods](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/InverseMethods) - Use `none?` instead of inverting `any?`.\n\n**app/helpers/application_helper/button/cloud_volume_new.rb**\n- [ ] :exclamation: - [Line 15](https://github.com/martinpovolny/manageiq-ui-classic/blob/4a3c9a3ce165835de7ecc4494fe6df39551ce192/app/helpers/application_helper/button/cloud_volume_new.rb#L15), Col 5 - [Style/InverseMethods](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/InverseMethods) - Use `none?` instead of inverting `any?`.\n"}}
{"actor":{"display_login":"miq-bot"}}