{"action":"created","issue":{"url":"https://api.github.com/repos/ogrisel/pygbm/issues/21","repository_url":"https://api.github.com/repos/ogrisel/pygbm","labels_url":"https://api.github.com/repos/ogrisel/pygbm/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/ogrisel/pygbm/issues/21/comments","events_url":"https://api.github.com/repos/ogrisel/pygbm/issues/21/events","html_url":"https://github.com/ogrisel/pygbm/pull/21","id":376194315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDY4OTIw","number":21,"title":"[MRG] Avoid multiple array allocations by using a partition array","user":{"login":"NicolasHug","id":1190450,"node_id":"MDQ6VXNlcjExOTA0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1190450?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasHug","html_url":"https://github.com/NicolasHug","followers_url":"https://api.github.com/users/NicolasHug/followers","following_url":"https://api.github.com/users/NicolasHug/following{/other_user}","gists_url":"https://api.github.com/users/NicolasHug/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasHug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasHug/subscriptions","organizations_url":"https://api.github.com/users/NicolasHug/orgs","repos_url":"https://api.github.com/users/NicolasHug/repos","events_url":"https://api.github.com/users/NicolasHug/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasHug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-31T23:10:48Z","updated_at":"2018-11-01T15:16:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ogrisel/pygbm/pulls/21","html_url":"https://github.com/ogrisel/pygbm/pull/21","diff_url":"https://github.com/ogrisel/pygbm/pull/21.diff","patch_url":"https://github.com/ogrisel/pygbm/pull/21.patch"},"body":"This PR avoids the allocations of the `samples_indices` array for each nodes.\r\n\r\nIndexes are stored in the `partition` array in `SplittingContext` and the `samples_indices` are now views on this array.\r\n\r\nStrongly inspired from lightgbm\r\n\r\nI'm not sure how better it is performance-wise but it sure doesn't hurt. And memory footprint is now much lower."},"comment":{"url":"https://api.github.com/repos/ogrisel/pygbm/issues/comments/435073975","html_url":"https://github.com/ogrisel/pygbm/pull/21#issuecomment-435073975","issue_url":"https://api.github.com/repos/ogrisel/pygbm/issues/21","id":435073975,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTA3Mzk3NQ==","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T15:16:27Z","updated_at":"2018-11-01T15:16:27Z","author_association":"OWNER","body":"The split costs of this PR is very close to the one reported by LightGBM with `TIME_TAG` enabled."}}
{"actor":{"display_login":"ogrisel"}}