{"action":"created","issue":{"url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/97","repository_url":"https://api.github.com/repos/e2y/adyen-mirakl","labels_url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/97/comments","events_url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/97/events","html_url":"https://github.com/e2y/adyen-mirakl/pull/97","id":306672671,"number":97,"title":"[DG] ADY-99 As a Business Seller I would like to upload new or update…","user":{"login":"pandemicGander","id":1323016,"avatar_url":"https://avatars0.githubusercontent.com/u/1323016?v=4","gravatar_id":"","url":"https://api.github.com/users/pandemicGander","html_url":"https://github.com/pandemicGander","followers_url":"https://api.github.com/users/pandemicGander/followers","following_url":"https://api.github.com/users/pandemicGander/following{/other_user}","gists_url":"https://api.github.com/users/pandemicGander/gists{/gist_id}","starred_url":"https://api.github.com/users/pandemicGander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandemicGander/subscriptions","organizations_url":"https://api.github.com/users/pandemicGander/orgs","repos_url":"https://api.github.com/users/pandemicGander/repos","events_url":"https://api.github.com/users/pandemicGander/events{/privacy}","received_events_url":"https://api.github.com/users/pandemicGander/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T23:16:45Z","updated_at":"2018-03-20T17:19:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/e2y/adyen-mirakl/pulls/97","html_url":"https://github.com/e2y/adyen-mirakl/pull/97","diff_url":"https://github.com/e2y/adyen-mirakl/pull/97.diff","patch_url":"https://github.com/e2y/adyen-mirakl/pull/97.patch"},"body":"…d photo id for shareholders so that I can complete identity checks"},"comment":{"url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/comments/374682772","html_url":"https://github.com/e2y/adyen-mirakl/pull/97#issuecomment-374682772","issue_url":"https://api.github.com/repos/e2y/adyen-mirakl/issues/97","id":374682772,"user":{"login":"e2ygithubBot","id":18720617,"avatar_url":"https://avatars2.githubusercontent.com/u/18720617?v=4","gravatar_id":"","url":"https://api.github.com/users/e2ygithubBot","html_url":"https://github.com/e2ygithubBot","followers_url":"https://api.github.com/users/e2ygithubBot/followers","following_url":"https://api.github.com/users/e2ygithubBot/following{/other_user}","gists_url":"https://api.github.com/users/e2ygithubBot/gists{/gist_id}","starred_url":"https://api.github.com/users/e2ygithubBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2ygithubBot/subscriptions","organizations_url":"https://api.github.com/users/e2ygithubBot/orgs","repos_url":"https://api.github.com/users/e2ygithubBot/repos","events_url":"https://api.github.com/users/e2ygithubBot/events{/privacy}","received_events_url":"https://api.github.com/users/e2ygithubBot/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T17:19:08Z","updated_at":"2018-03-20T17:19:08Z","author_association":"NONE","body":"SonarQube analysis reported 18 issues\n* ![MAJOR][MAJOR] 12 major\n* ![MINOR][MINOR] 5 minor\n* ![INFO][INFO] 1 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [DocService.java#L79](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L79): Format specifiers should be used instead of string concatenation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MAJOR][MAJOR] [DocService.java#L120](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L120): Use the built-in formatting to construct this argument. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS2629)\n1. ![MAJOR][MAJOR] [DocService.java#L120](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L120): Format specifiers should be used instead of string concatenation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MAJOR][MAJOR] [DocService.java#L121](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L121): Use the built-in formatting to construct this argument. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS2629)\n1. ![MAJOR][MAJOR] [DocService.java#L121](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L121): Format specifiers should be used instead of string concatenation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MAJOR][MAJOR] [DocService.java#L122](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L122): Invoke method(s) only conditionally. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS2629)\n1. ![MAJOR][MAJOR] [DocService.java#L122](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/DocService.java#L122): String contains no format specifiers. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MAJOR][MAJOR] [ShopService.java#L156](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/ShopService.java#L156): Format specifiers should be used instead of string concatenation. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3457)\n1. ![MAJOR][MAJOR] [ShopService.java#L341](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/ShopService.java#L341): Merge this if statement with the enclosing one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1066)\n1. ![MAJOR][MAJOR] [ShopService.java#L342](https://github.com/e2y/adyen-mirakl/blob/b68e31c2c0172e0ce7d1f052530c97d8bfb93bd9/src/main/java/com/adyen/mirakl/service/ShopService.java#L342): Merge this if statement with the enclosing one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1066)\n\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"e2ygithubBot"}}