{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/175965194","pull_request_review_id":105585545,"id":175965194,"diff_hunk":"@@ -70,14 +70,26 @@ function (\n       // setup schema\n       var Schema = RegistrationSchema.extend({\n         settings: this.options.settings,\n-        url: this.getRegistrationApiUrl()+'/form'\n+        url: this.getRegistrationApiBase()+'/form'\n       });\n       var schema = new Schema();\n       this.state.set('schema', schema);\n     },\n     getRegistrationApiUrl: function() {\n-      var clientId = this.options.settings.get('clientId');\n-      return this.options.settings.get('baseUrl')+'/api/v1/registration/'+clientId;\n+      if (this.options.settings.get('policyId')) {\n+        return this.options.settings.get('baseUrl') + '/api/v1/registration/' + this.options.settings.get('policyId');\n+      } else if (this.settings.get('policyId')) {\n+        return this.options.settings.get('baseUrl') + '/api/v1/registration/' + this.settings.get('policyId');\n+      } else {\n+        return this.options.settings.get('baseUrl');","path":"src/RegistrationController.js","position":18,"original_position":18,"commit_id":"0948523b33807b43e52124ed575a155e0c10c862","original_commit_id":"0948523b33807b43e52124ed575a155e0c10c862","user":{"login":"uvartak-okta","id":5923960,"avatar_url":"https://avatars0.githubusercontent.com/u/5923960?v=4","gravatar_id":"","url":"https://api.github.com/users/uvartak-okta","html_url":"https://github.com/uvartak-okta","followers_url":"https://api.github.com/users/uvartak-okta/followers","following_url":"https://api.github.com/users/uvartak-okta/following{/other_user}","gists_url":"https://api.github.com/users/uvartak-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/uvartak-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uvartak-okta/subscriptions","organizations_url":"https://api.github.com/users/uvartak-okta/orgs","repos_url":"https://api.github.com/users/uvartak-okta/repos","events_url":"https://api.github.com/users/uvartak-okta/events{/privacy}","received_events_url":"https://api.github.com/users/uvartak-okta/received_events","type":"User","site_admin":false},"body":"we do not need it.. however i was not sure how to return error.","created_at":"2018-03-21T00:54:18Z","updated_at":"2018-03-21T00:54:18Z","html_url":"https://github.com/okta/okta-signin-widget/pull/410#discussion_r175965194","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/175965194"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/410#discussion_r175965194"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410"}},"in_reply_to_id":175947281},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410","id":176317445,"html_url":"https://github.com/okta/okta-signin-widget/pull/410","diff_url":"https://github.com/okta/okta-signin-widget/pull/410.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/410.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/410","number":410,"state":"open","locked":false,"title":"Signin widget change to use org level registration policy.","user":{"login":"uvartak-okta","id":5923960,"avatar_url":"https://avatars0.githubusercontent.com/u/5923960?v=4","gravatar_id":"","url":"https://api.github.com/users/uvartak-okta","html_url":"https://github.com/uvartak-okta","followers_url":"https://api.github.com/users/uvartak-okta/followers","following_url":"https://api.github.com/users/uvartak-okta/following{/other_user}","gists_url":"https://api.github.com/users/uvartak-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/uvartak-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uvartak-okta/subscriptions","organizations_url":"https://api.github.com/users/uvartak-okta/orgs","repos_url":"https://api.github.com/users/uvartak-okta/repos","events_url":"https://api.github.com/users/uvartak-okta/events{/privacy}","received_events_url":"https://api.github.com/users/uvartak-okta/received_events","type":"User","site_admin":false},"body":"🌱 Signin widget change to use org level registration policy.\r\n\r\nUpdated registrationControlller to use new registration endpoint. Added unit tests.\r\nResolves OKTA-160857\r\n\r\nReviewers:\r\n@hor-kanchan-okta @nikhilvenkatraman-okta  ","created_at":"2018-03-20T20:45:58Z","updated_at":"2018-03-21T00:54:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a28856ccdfa5dda7aa6e56994902a8dec5abcdb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/410/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/0948523b33807b43e52124ed575a155e0c10c862","head":{"label":"uvartak-okta:okta-160857-uvartak-1","ref":"okta-160857-uvartak-1","sha":"0948523b33807b43e52124ed575a155e0c10c862","user":{"login":"uvartak-okta","id":5923960,"avatar_url":"https://avatars0.githubusercontent.com/u/5923960?v=4","gravatar_id":"","url":"https://api.github.com/users/uvartak-okta","html_url":"https://github.com/uvartak-okta","followers_url":"https://api.github.com/users/uvartak-okta/followers","following_url":"https://api.github.com/users/uvartak-okta/following{/other_user}","gists_url":"https://api.github.com/users/uvartak-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/uvartak-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uvartak-okta/subscriptions","organizations_url":"https://api.github.com/users/uvartak-okta/orgs","repos_url":"https://api.github.com/users/uvartak-okta/repos","events_url":"https://api.github.com/users/uvartak-okta/events{/privacy}","received_events_url":"https://api.github.com/users/uvartak-okta/received_events","type":"User","site_admin":false},"repo":{"id":125909363,"name":"okta-signin-widget","full_name":"uvartak-okta/okta-signin-widget","owner":{"login":"uvartak-okta","id":5923960,"avatar_url":"https://avatars0.githubusercontent.com/u/5923960?v=4","gravatar_id":"","url":"https://api.github.com/users/uvartak-okta","html_url":"https://github.com/uvartak-okta","followers_url":"https://api.github.com/users/uvartak-okta/followers","following_url":"https://api.github.com/users/uvartak-okta/following{/other_user}","gists_url":"https://api.github.com/users/uvartak-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/uvartak-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uvartak-okta/subscriptions","organizations_url":"https://api.github.com/users/uvartak-okta/orgs","repos_url":"https://api.github.com/users/uvartak-okta/repos","events_url":"https://api.github.com/users/uvartak-okta/events{/privacy}","received_events_url":"https://api.github.com/users/uvartak-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uvartak-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/uvartak-okta/okta-signin-widget/deployments","created_at":"2018-03-19T19:25:57Z","updated_at":"2018-03-19T19:26:00Z","pushed_at":"2018-03-20T20:43:05Z","git_url":"git://github.com/uvartak-okta/okta-signin-widget.git","ssh_url":"git@github.com:uvartak-okta/okta-signin-widget.git","clone_url":"https://github.com/uvartak-okta/okta-signin-widget.git","svn_url":"https://github.com/uvartak-okta/okta-signin-widget","homepage":null,"size":18273,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"503cf949da897ce81e69b74075d8233722330472","user":{"login":"okta","id":362460,"avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-03-16T16:50:31Z","pushed_at":"2018-03-20T20:45:59Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":18269,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":64,"open_issues":28,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/410"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/410"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/0948523b33807b43e52124ed575a155e0c10c862"}},"author_association":"NONE"}}
{"actor":{"display_login":"uvartak-okta"}}