{"action":"created","issue":{"url":"https://api.github.com/repos/vapor/http/issues/307","repository_url":"https://api.github.com/repos/vapor/http","labels_url":"https://api.github.com/repos/vapor/http/issues/307/labels{/name}","comments_url":"https://api.github.com/repos/vapor/http/issues/307/comments","events_url":"https://api.github.com/repos/vapor/http/issues/307/events","html_url":"https://github.com/vapor/http/pull/307","id":358289552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDkyMTEz","number":307,"title":"stream file fix","user":{"login":"tanner0101","id":1342803,"node_id":"MDQ6VXNlcjEzNDI4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false},"labels":[{"id":404072435,"node_id":"MDU6TGFiZWw0MDQwNzI0MzU=","url":"https://api.github.com/repos/vapor/http/labels/bug","name":"bug","color":"d93f0b","default":true}],"state":"closed","locked":false,"assignee":{"login":"tanner0101","id":1342803,"node_id":"MDQ6VXNlcjEzNDI4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false},"assignees":[{"login":"tanner0101","id":1342803,"node_id":"MDQ6VXNlcjEzNDI4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vapor/http/milestones/52","html_url":"https://github.com/vapor/http/milestone/52","labels_url":"https://api.github.com/repos/vapor/http/milestones/52/labels","id":3635642,"node_id":"MDk6TWlsZXN0b25lMzYzNTY0Mg==","number":52,"title":"3.1.3","description":null,"creator":{"login":"tanner0101","id":1342803,"node_id":"MDQ6VXNlcjEzNDI4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1342803?v=4","gravatar_id":"","url":"https://api.github.com/users/tanner0101","html_url":"https://github.com/tanner0101","followers_url":"https://api.github.com/users/tanner0101/followers","following_url":"https://api.github.com/users/tanner0101/following{/other_user}","gists_url":"https://api.github.com/users/tanner0101/gists{/gist_id}","starred_url":"https://api.github.com/users/tanner0101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanner0101/subscriptions","organizations_url":"https://api.github.com/users/tanner0101/orgs","repos_url":"https://api.github.com/users/tanner0101/repos","events_url":"https://api.github.com/users/tanner0101/events{/privacy}","received_events_url":"https://api.github.com/users/tanner0101/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2018-09-08T14:24:58Z","updated_at":"2018-09-08T14:29:32Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-09-08T12:01:21Z","updated_at":"2018-09-10T19:56:58Z","closed_at":"2018-09-08T14:29:32Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vapor/http/pulls/307","html_url":"https://github.com/vapor/http/pull/307","diff_url":"https://github.com/vapor/http/pull/307.diff","patch_url":"https://github.com/vapor/http/pull/307.patch"},"body":"Potential fix for https://github.com/vapor/vapor/issues/1801.\r\n\r\nFixes an issue where connection would be closed before chunked body is finished streaming."},"comment":{"url":"https://api.github.com/repos/vapor/http/issues/comments/420039871","html_url":"https://github.com/vapor/http/pull/307#issuecomment-420039871","issue_url":"https://api.github.com/repos/vapor/http/issues/307","id":420039871,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDAzOTg3MQ==","user":{"login":"foscomputerservices","id":2438421,"node_id":"MDQ6VXNlcjI0Mzg0MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2438421?v=4","gravatar_id":"","url":"https://api.github.com/users/foscomputerservices","html_url":"https://github.com/foscomputerservices","followers_url":"https://api.github.com/users/foscomputerservices/followers","following_url":"https://api.github.com/users/foscomputerservices/following{/other_user}","gists_url":"https://api.github.com/users/foscomputerservices/gists{/gist_id}","starred_url":"https://api.github.com/users/foscomputerservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foscomputerservices/subscriptions","organizations_url":"https://api.github.com/users/foscomputerservices/orgs","repos_url":"https://api.github.com/users/foscomputerservices/repos","events_url":"https://api.github.com/users/foscomputerservices/events{/privacy}","received_events_url":"https://api.github.com/users/foscomputerservices/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T19:56:58Z","updated_at":"2018-09-10T19:56:58Z","author_association":"NONE","body":"Just curious, are there any plans to implement CI tests for this issue?  Maybe I missed something in the change log, but I didn't notice any tests added along with the bug fix.\r\n\r\nThis bug caused our production website to be unusable for 3 days and caused much consternation with customers during this time (they are paying for our service).  I also spent a weekend thinking that I had broken something in the container/load balancer/nginx configuration.\r\n\r\nThe problem is that I use 'vapor update' (or swift package update) to pick up changes in my own packages, which also updates vapor and its dependencies.\r\n\r\nI suppose I could pin all of the vapor dependencies and hand-test everything before pulling updates, but I was under the impression that there were tests for most of Vapor (especially at the lowest levels) due to the Circle CI passing badge.  However, when I dig into the tests, there doesn't seem to be much there.  Maybe I'm missing something?\r\n\r\nI do realize that vapor is open source and I could contribute tests as well, and if I can find some spare cycles I just might do that.  I'm mostly wondering what we can expect for stability from these lowest-level libraries as I was a bit dismayed when I see a PR with no unit/regression tests validating the new functionality. (https://github.com/vapor/http/pull/306/files)"}}
{"actor":{"display_login":"foscomputerservices"}}