{"action":"created","issue":{"url":"https://api.github.com/repos/cakephp/debug_kit/issues/617","repository_url":"https://api.github.com/repos/cakephp/debug_kit","labels_url":"https://api.github.com/repos/cakephp/debug_kit/issues/617/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/debug_kit/issues/617/comments","events_url":"https://api.github.com/repos/cakephp/debug_kit/issues/617/events","html_url":"https://github.com/cakephp/debug_kit/issues/617","id":319890872,"number":617,"title":"Safe TLD configurable","user":{"login":"Moutard3","id":9319054,"avatar_url":"https://avatars2.githubusercontent.com/u/9319054?v=4","gravatar_id":"","url":"https://api.github.com/users/Moutard3","html_url":"https://github.com/Moutard3","followers_url":"https://api.github.com/users/Moutard3/followers","following_url":"https://api.github.com/users/Moutard3/following{/other_user}","gists_url":"https://api.github.com/users/Moutard3/gists{/gist_id}","starred_url":"https://api.github.com/users/Moutard3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moutard3/subscriptions","organizations_url":"https://api.github.com/users/Moutard3/orgs","repos_url":"https://api.github.com/users/Moutard3/repos","events_url":"https://api.github.com/users/Moutard3/events{/privacy}","received_events_url":"https://api.github.com/users/Moutard3/received_events","type":"User","site_admin":false},"labels":[{"id":60503788,"url":"https://api.github.com/repos/cakephp/debug_kit/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/debug_kit/milestones/37","html_url":"https://github.com/cakephp/debug_kit/milestone/37","labels_url":"https://api.github.com/repos/cakephp/debug_kit/milestones/37/labels","id":3125392,"number":37,"title":"3.x","description":"Minor features and bugfixes for DebugKit that is compatible with CakePHP 3.x","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars3.githubusercontent.com/u/24086?v=4","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":17,"state":"open","created_at":"2018-02-19T01:51:23Z","updated_at":"2018-05-08T18:41:17Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2018-05-03T12:00:13Z","updated_at":"2018-05-09T17:13:53Z","closed_at":null,"author_association":"NONE","body":"The array containing the safe TLDs should be configurable with something like this:\r\n`Configure::write('DebugKit', ['safeTLD' => [\"localhost\", \"dev\", \"test\", \"example\", \"local\",\"somethingelse\"]]);`\r\nI think that's a useful feature tu add one more layer to disable DebugKit in prod in case debug mode is not disabled, but it can't be used if not using a \"standard\" dev TLD (because we need to forceEnable it).\r\nIn my case I'm using `.loc` and Laragon is using `.oo` by default."},"comment":{"url":"https://api.github.com/repos/cakephp/debug_kit/issues/comments/387810286","html_url":"https://github.com/cakephp/debug_kit/issues/617#issuecomment-387810286","issue_url":"https://api.github.com/repos/cakephp/debug_kit/issues/617","id":387810286,"user":{"login":"highstrike","id":2379538,"avatar_url":"https://avatars3.githubusercontent.com/u/2379538?v=4","gravatar_id":"","url":"https://api.github.com/users/highstrike","html_url":"https://github.com/highstrike","followers_url":"https://api.github.com/users/highstrike/followers","following_url":"https://api.github.com/users/highstrike/following{/other_user}","gists_url":"https://api.github.com/users/highstrike/gists{/gist_id}","starred_url":"https://api.github.com/users/highstrike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highstrike/subscriptions","organizations_url":"https://api.github.com/users/highstrike/orgs","repos_url":"https://api.github.com/users/highstrike/repos","events_url":"https://api.github.com/users/highstrike/events{/privacy}","received_events_url":"https://api.github.com/users/highstrike/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T17:13:53Z","updated_at":"2018-05-09T17:13:53Z","author_association":"CONTRIBUTOR","body":"### I feel that all these solutions are now created for problems that shouldn't exist in the first place\r\n\r\nThe **developer** should have the choice to either deploy with debug on or off on production. \r\nJust like the **developer** has a choice to upload the files on production with the composer `--no-dev` flag or without.\r\n\r\nIMHO the original feature #595 just adds more problems than it tries to solve, and because if it now we have things like:\r\n- silently running with debug on without the possibility of clearly seeing it now - @dereuromark \r\n- safe TLDs not covering all the use cases - @davidyell \r\n- make debugkit icon blink, huge arrows, bubble of texts - @dereuromark \r\n- having the `forceEnable` and now the `safeTld` extra options in order to fix what #595 added by *default* - @lorenzo @dereuromark \r\n- preventing the site from rendering at all because of the debug flag + aditional logic in the `ErrorHandlerMiddleware` (this is not just a debugkit *plugin* change now, its a cakephp *framework* one) - @jeremyharris @jorisvaesen \r\n\r\n## More\r\nWhy would my application break with a red error page just because I wanted to have debug enabled on production for 5 minutes to record some logs that i wouldn't log otherwise? You guys will probably tell me, well, no, make another flag for that. Why would I as a developer have to change my existing application because of a new feature being added... *to a PLUGIN* that I don't even install on Prod.\r\n\r\n## TL;DR\r\nDebugKit's mission shouldn't be that to protect developers from themselves. It's a plugin that does debugging, if you forget it on production that's on you as a developer, not on the plugin or on the framework."}}
{"actor":{"display_login":"highstrike"}}