{"action":"created","comment":{"url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/comments/169062065","pull_request_review_id":97526805,"id":169062065,"diff_hunk":"@@ -24,7 +23,7 @@\n \n     public static final Location NEW_YORK_CITY = new Location(40.7127753, -74.0059728);\n     public static final Location BERLIN = new Location(52.5200066, 13.404954);\n-    public static final int DISTANCE_NYC_BERLIN = 6381 * 1000;\n+    public static final int DISTANCE_NYC_BERLIN = 6385 * 1000;","path":"BLE Indoor Positioning/src/test/java/com/nexenio/bleindoorpositioning/location/LocationTest.java","position":13,"original_position":13,"commit_id":"756782adfbceba10123cf99c57c7ffff8607a314","original_commit_id":"b2fff69a3c6d3e3fa0a7d5444383bd085e80a626","user":{"login":"marvinmirtschin","id":7871106,"avatar_url":"https://avatars3.githubusercontent.com/u/7871106?v=4","gravatar_id":"","url":"https://api.github.com/users/marvinmirtschin","html_url":"https://github.com/marvinmirtschin","followers_url":"https://api.github.com/users/marvinmirtschin/followers","following_url":"https://api.github.com/users/marvinmirtschin/following{/other_user}","gists_url":"https://api.github.com/users/marvinmirtschin/gists{/gist_id}","starred_url":"https://api.github.com/users/marvinmirtschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvinmirtschin/subscriptions","organizations_url":"https://api.github.com/users/marvinmirtschin/orgs","repos_url":"https://api.github.com/users/marvinmirtschin/repos","events_url":"https://api.github.com/users/marvinmirtschin/events{/privacy}","received_events_url":"https://api.github.com/users/marvinmirtschin/received_events","type":"User","site_admin":false},"body":"What I meant was not which distance may be the correct one, but that the location is still the same. Therefore the calculation must have changed to result in a new distance. Doing so can be fine, but constants like 'DISTANCE_NYC_BERLIN' should normally not change as they do not change in real life. \r\nIn this example a difference of a few km is not a problem of cause, as there are different sources.","created_at":"2018-02-19T12:29:13Z","updated_at":"2018-02-19T12:29:13Z","html_url":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35#discussion_r169062065","pull_request_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/comments/169062065"},"html":{"href":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35#discussion_r169062065"},"pull_request":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35"}},"in_reply_to_id":169021576},"pull_request":{"url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35","id":168199803,"html_url":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35","diff_url":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35.diff","patch_url":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35.patch","issue_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/35","number":35,"state":"open","locked":false,"title":"0629 device location prediction","user":{"login":"leonlowitzki","id":1987342,"avatar_url":"https://avatars3.githubusercontent.com/u/1987342?v=4","gravatar_id":"","url":"https://api.github.com/users/leonlowitzki","html_url":"https://github.com/leonlowitzki","followers_url":"https://api.github.com/users/leonlowitzki/followers","following_url":"https://api.github.com/users/leonlowitzki/following{/other_user}","gists_url":"https://api.github.com/users/leonlowitzki/gists{/gist_id}","starred_url":"https://api.github.com/users/leonlowitzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonlowitzki/subscriptions","organizations_url":"https://api.github.com/users/leonlowitzki/orgs","repos_url":"https://api.github.com/users/leonlowitzki/repos","events_url":"https://api.github.com/users/leonlowitzki/events{/privacy}","received_events_url":"https://api.github.com/users/leonlowitzki/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-09T10:12:14Z","updated_at":"2018-02-19T12:29:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8c42d14a55bf958d2044ac85958a0bebcdc793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35/commits","review_comments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35/comments","review_comment_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/35/comments","statuses_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/statuses/756782adfbceba10123cf99c57c7ffff8607a314","head":{"label":"neXenio:0629-device-location-prediction","ref":"0629-device-location-prediction","sha":"756782adfbceba10123cf99c57c7ffff8607a314","user":{"login":"neXenio","id":25456325,"avatar_url":"https://avatars1.githubusercontent.com/u/25456325?v=4","gravatar_id":"","url":"https://api.github.com/users/neXenio","html_url":"https://github.com/neXenio","followers_url":"https://api.github.com/users/neXenio/followers","following_url":"https://api.github.com/users/neXenio/following{/other_user}","gists_url":"https://api.github.com/users/neXenio/gists{/gist_id}","starred_url":"https://api.github.com/users/neXenio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neXenio/subscriptions","organizations_url":"https://api.github.com/users/neXenio/orgs","repos_url":"https://api.github.com/users/neXenio/repos","events_url":"https://api.github.com/users/neXenio/events{/privacy}","received_events_url":"https://api.github.com/users/neXenio/received_events","type":"Organization","site_admin":false},"repo":{"id":110686293,"name":"BLE-Indoor-Positioning","full_name":"neXenio/BLE-Indoor-Positioning","owner":{"login":"neXenio","id":25456325,"avatar_url":"https://avatars1.githubusercontent.com/u/25456325?v=4","gravatar_id":"","url":"https://api.github.com/users/neXenio","html_url":"https://github.com/neXenio","followers_url":"https://api.github.com/users/neXenio/followers","following_url":"https://api.github.com/users/neXenio/following{/other_user}","gists_url":"https://api.github.com/users/neXenio/gists{/gist_id}","starred_url":"https://api.github.com/users/neXenio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neXenio/subscriptions","organizations_url":"https://api.github.com/users/neXenio/orgs","repos_url":"https://api.github.com/users/neXenio/repos","events_url":"https://api.github.com/users/neXenio/events{/privacy}","received_events_url":"https://api.github.com/users/neXenio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neXenio/BLE-Indoor-Positioning","description":"Multilateration using bluetooth beacons","fork":false,"url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning","forks_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/forks","keys_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/teams","hooks_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/hooks","issue_events_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/events{/number}","events_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/events","assignees_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/assignees{/user}","branches_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/branches{/branch}","tags_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/tags","blobs_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/statuses/{sha}","languages_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/languages","stargazers_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/stargazers","contributors_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/contributors","subscribers_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/subscribers","subscription_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/subscription","commits_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/contents/{+path}","compare_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/merges","archive_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/downloads","issues_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues{/number}","pulls_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls{/number}","milestones_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/milestones{/number}","notifications_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/labels{/name}","releases_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/releases{/id}","deployments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/deployments","created_at":"2017-11-14T12:16:43Z","updated_at":"2018-02-15T10:32:01Z","pushed_at":"2018-02-19T09:51:36Z","git_url":"git://github.com/neXenio/BLE-Indoor-Positioning.git","ssh_url":"git@github.com:neXenio/BLE-Indoor-Positioning.git","clone_url":"https://github.com/neXenio/BLE-Indoor-Positioning.git","svn_url":"https://github.com/neXenio/BLE-Indoor-Positioning","homepage":"","size":623,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"neXenio:dev","ref":"dev","sha":"a6bc6418f43d117e100ef636efac672881811e3a","user":{"login":"neXenio","id":25456325,"avatar_url":"https://avatars1.githubusercontent.com/u/25456325?v=4","gravatar_id":"","url":"https://api.github.com/users/neXenio","html_url":"https://github.com/neXenio","followers_url":"https://api.github.com/users/neXenio/followers","following_url":"https://api.github.com/users/neXenio/following{/other_user}","gists_url":"https://api.github.com/users/neXenio/gists{/gist_id}","starred_url":"https://api.github.com/users/neXenio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neXenio/subscriptions","organizations_url":"https://api.github.com/users/neXenio/orgs","repos_url":"https://api.github.com/users/neXenio/repos","events_url":"https://api.github.com/users/neXenio/events{/privacy}","received_events_url":"https://api.github.com/users/neXenio/received_events","type":"Organization","site_admin":false},"repo":{"id":110686293,"name":"BLE-Indoor-Positioning","full_name":"neXenio/BLE-Indoor-Positioning","owner":{"login":"neXenio","id":25456325,"avatar_url":"https://avatars1.githubusercontent.com/u/25456325?v=4","gravatar_id":"","url":"https://api.github.com/users/neXenio","html_url":"https://github.com/neXenio","followers_url":"https://api.github.com/users/neXenio/followers","following_url":"https://api.github.com/users/neXenio/following{/other_user}","gists_url":"https://api.github.com/users/neXenio/gists{/gist_id}","starred_url":"https://api.github.com/users/neXenio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neXenio/subscriptions","organizations_url":"https://api.github.com/users/neXenio/orgs","repos_url":"https://api.github.com/users/neXenio/repos","events_url":"https://api.github.com/users/neXenio/events{/privacy}","received_events_url":"https://api.github.com/users/neXenio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neXenio/BLE-Indoor-Positioning","description":"Multilateration using bluetooth beacons","fork":false,"url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning","forks_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/forks","keys_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/teams","hooks_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/hooks","issue_events_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/events{/number}","events_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/events","assignees_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/assignees{/user}","branches_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/branches{/branch}","tags_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/tags","blobs_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/refs{/sha}","trees_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/statuses/{sha}","languages_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/languages","stargazers_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/stargazers","contributors_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/contributors","subscribers_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/subscribers","subscription_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/subscription","commits_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/commits{/sha}","git_commits_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/git/commits{/sha}","comments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/comments{/number}","issue_comment_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/comments{/number}","contents_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/contents/{+path}","compare_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/merges","archive_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/downloads","issues_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues{/number}","pulls_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls{/number}","milestones_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/milestones{/number}","notifications_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/labels{/name}","releases_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/releases{/id}","deployments_url":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/deployments","created_at":"2017-11-14T12:16:43Z","updated_at":"2018-02-15T10:32:01Z","pushed_at":"2018-02-19T09:51:36Z","git_url":"git://github.com/neXenio/BLE-Indoor-Positioning.git","ssh_url":"git@github.com:neXenio/BLE-Indoor-Positioning.git","clone_url":"https://github.com/neXenio/BLE-Indoor-Positioning.git","svn_url":"https://github.com/neXenio/BLE-Indoor-Positioning","homepage":"","size":623,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35"},"html":{"href":"https://github.com/neXenio/BLE-Indoor-Positioning/pull/35"},"issue":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/35"},"comments":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/neXenio/BLE-Indoor-Positioning/statuses/756782adfbceba10123cf99c57c7ffff8607a314"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marvinmirtschin"}}