{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/13526","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/13526/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/13526/comments","events_url":"https://api.github.com/repos/facebook/react/issues/13526/events","html_url":"https://github.com/facebook/react/pull/13526","id":356141875,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTA4MTM4","number":13526,"title":"🔥 Stop syncing the value attribute on inputs","user":{"login":"nhunzaker","id":590904,"node_id":"MDQ6VXNlcjU5MDkwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/590904?v=4","gravatar_id":"","url":"https://api.github.com/users/nhunzaker","html_url":"https://github.com/nhunzaker","followers_url":"https://api.github.com/users/nhunzaker/followers","following_url":"https://api.github.com/users/nhunzaker/following{/other_user}","gists_url":"https://api.github.com/users/nhunzaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nhunzaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhunzaker/subscriptions","organizations_url":"https://api.github.com/users/nhunzaker/orgs","repos_url":"https://api.github.com/users/nhunzaker/repos","events_url":"https://api.github.com/users/nhunzaker/events{/privacy}","received_events_url":"https://api.github.com/users/nhunzaker/received_events","type":"User","site_admin":false},"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"state":"open","locked":false,"assignee":{"login":"gaearon","id":810438,"node_id":"MDQ6VXNlcjgxMDQzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/810438?v=4","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"assignees":[{"login":"gaearon","id":810438,"node_id":"MDQ6VXNlcjgxMDQzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/810438?v=4","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-08-31T22:37:41Z","updated_at":"2018-09-04T23:01:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/13526","html_url":"https://github.com/facebook/react/pull/13526","diff_url":"https://github.com/facebook/react/pull/13526.diff","patch_url":"https://github.com/facebook/react/pull/13526.patch"},"body":"This PR revives https://github.com/facebook/react/pull/10150, my original PR to remove value attribute syncing.\r\n\r\n**TODOs**:\r\n\r\n- [x] value set value, defaultValue set defaultValue\r\n- [x] checked sets checked, defaultChecked sets defaultChecked\r\n- [x] Remove warning if defaultValue changes (if it exists)\r\n- [x] Remove warning if defaultChecked changes (if it exists)\r\n- [ ] Can we get rid of wrapper state alltogether?\r\n- [x] Could we only apply value to text inputs?\r\n- [x] Could we apply checked to check/radios?\r\n- [ ] Could submit/reset just use standard attribute assignment?\r\n- [ ] SSR mismatch?\r\n\r\nThis fixture build demonstrates the behavior:\r\n\r\nhttp://react-dom-no-sync-value.surge.sh/\r\n\r\n---\r\n\r\nSee https://github.com/facebook/react/issues/11896 and https://github.com/facebook/react/issues/13525\r\n\r\n🔥 🔥 🔥 "},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/418544972","html_url":"https://github.com/facebook/react/pull/13526#issuecomment-418544972","issue_url":"https://api.github.com/repos/facebook/react/issues/13526","id":418544972,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODU0NDk3Mg==","user":{"login":"nhunzaker","id":590904,"node_id":"MDQ6VXNlcjU5MDkwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/590904?v=4","gravatar_id":"","url":"https://api.github.com/users/nhunzaker","html_url":"https://github.com/nhunzaker","followers_url":"https://api.github.com/users/nhunzaker/followers","following_url":"https://api.github.com/users/nhunzaker/following{/other_user}","gists_url":"https://api.github.com/users/nhunzaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nhunzaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhunzaker/subscriptions","organizations_url":"https://api.github.com/users/nhunzaker/orgs","repos_url":"https://api.github.com/users/nhunzaker/repos","events_url":"https://api.github.com/users/nhunzaker/events{/privacy}","received_events_url":"https://api.github.com/users/nhunzaker/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T23:01:49Z","updated_at":"2018-09-04T23:01:49Z","author_association":"COLLABORATOR","body":"One idea for SSR is to very strictly adhere to \"value sets the property, defaultValue sets the attribute\". For this to work, we'd need to allow a user to set both properties at once without warning.\r\n\r\nI don't necessarily sponsor this idea 😸. This would be a breaking change for just about every server-side app, but it would keep things consistent in both environments. \r\n\r\nIt also requires a user to be intentional about setting the value attribute for sensitive information, like passwords, which could be a desired side-effect for some users."}}
{"actor":{"display_login":"nhunzaker"}}