{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/comments/209378959","pull_request_review_id":145391002,"id":209378959,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM3ODk1OQ==","diff_hunk":"@@ -138,15 +132,15 @@ The names of classes and defined resource types can consist of one or more [name\n \n Namespace segments should match the following regular expression:\n \n-    \\A[a-z][a-z0-9_]*\\Z\n+    \\A[a-z][a-zA-Z0-9_]*\\Z\n \n The one exception is the top namespace, whose name is the empty string.\n \n Multiple namespace segments can be joined together in a class or defined type name with the `::` (double colon) [namespace][] separator.\n \n Class names with multiple namespaces should match the following regular expression:\n \n-    \\A([a-z][a-z0-9_]*)?(::[a-z][a-z0-9_]*)*\\Z\n+    \\A([a-z][a-zA-Z0-9_]*)?(::[a-z][a-zA-Z0-9_]*)*\\Z","path":"source/puppet/5.5/lang_reserved.markdown","position":56,"original_position":56,"commit_id":"7da6aa7a36237644f34c021383bfa0eaa567a6fc","original_commit_id":"7da6aa7a36237644f34c021383bfa0eaa567a6fc","user":{"login":"binford2k","id":1392917,"node_id":"MDQ6VXNlcjEzOTI5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1392917?v=4","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"body":"The actual regex used in the codebase is `\\A((::)?[a-z]\\w*)(::[a-z]\\w*)*\\z`. As far as I can tell, this is equivalent.\r\n\r\nhttps://github.com/puppetlabs/puppet/blob/952414c36b45df9a0f46f4fe816bac4d2b18a89e/lib/puppet/pops/patterns.rb#L26","created_at":"2018-08-10T20:39:40Z","updated_at":"2018-08-10T20:39:47Z","html_url":"https://github.com/puppetlabs/puppet-docs/pull/883#discussion_r209378959","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/comments/209378959"},"html":{"href":"https://github.com/puppetlabs/puppet-docs/pull/883#discussion_r209378959"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883","id":207487446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDg3NDQ2","html_url":"https://github.com/puppetlabs/puppet-docs/pull/883","diff_url":"https://github.com/puppetlabs/puppet-docs/pull/883.diff","patch_url":"https://github.com/puppetlabs/puppet-docs/pull/883.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/883","number":883,"state":"open","locked":false,"title":"(DOC-3645) Update class name regex.","user":{"login":"gguillotte","id":1296917,"node_id":"MDQ6VXNlcjEyOTY5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1296917?v=4","gravatar_id":"","url":"https://api.github.com/users/gguillotte","html_url":"https://github.com/gguillotte","followers_url":"https://api.github.com/users/gguillotte/followers","following_url":"https://api.github.com/users/gguillotte/following{/other_user}","gists_url":"https://api.github.com/users/gguillotte/gists{/gist_id}","starred_url":"https://api.github.com/users/gguillotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gguillotte/subscriptions","organizations_url":"https://api.github.com/users/gguillotte/orgs","repos_url":"https://api.github.com/users/gguillotte/repos","events_url":"https://api.github.com/users/gguillotte/events{/privacy}","received_events_url":"https://api.github.com/users/gguillotte/received_events","type":"User","site_admin":false},"body":"Updates the class name regex and cleans up some Markdown formatting.","created_at":"2018-08-10T01:51:51Z","updated_at":"2018-08-10T20:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18806b2b406da3779f841f978e804cd77d36d697","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/883/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-docs/statuses/7da6aa7a36237644f34c021383bfa0eaa567a6fc","head":{"label":"gguillotte:DOC-3645","ref":"DOC-3645","sha":"7da6aa7a36237644f34c021383bfa0eaa567a6fc","user":{"login":"gguillotte","id":1296917,"node_id":"MDQ6VXNlcjEyOTY5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1296917?v=4","gravatar_id":"","url":"https://api.github.com/users/gguillotte","html_url":"https://github.com/gguillotte","followers_url":"https://api.github.com/users/gguillotte/followers","following_url":"https://api.github.com/users/gguillotte/following{/other_user}","gists_url":"https://api.github.com/users/gguillotte/gists{/gist_id}","starred_url":"https://api.github.com/users/gguillotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gguillotte/subscriptions","organizations_url":"https://api.github.com/users/gguillotte/orgs","repos_url":"https://api.github.com/users/gguillotte/repos","events_url":"https://api.github.com/users/gguillotte/events{/privacy}","received_events_url":"https://api.github.com/users/gguillotte/received_events","type":"User","site_admin":false},"repo":{"id":28131278,"node_id":"MDEwOlJlcG9zaXRvcnkyODEzMTI3OA==","name":"puppet-docs","full_name":"gguillotte/puppet-docs","owner":{"login":"gguillotte","id":1296917,"node_id":"MDQ6VXNlcjEyOTY5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1296917?v=4","gravatar_id":"","url":"https://api.github.com/users/gguillotte","html_url":"https://github.com/gguillotte","followers_url":"https://api.github.com/users/gguillotte/followers","following_url":"https://api.github.com/users/gguillotte/following{/other_user}","gists_url":"https://api.github.com/users/gguillotte/gists{/gist_id}","starred_url":"https://api.github.com/users/gguillotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gguillotte/subscriptions","organizations_url":"https://api.github.com/users/gguillotte/orgs","repos_url":"https://api.github.com/users/gguillotte/repos","events_url":"https://api.github.com/users/gguillotte/events{/privacy}","received_events_url":"https://api.github.com/users/gguillotte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gguillotte/puppet-docs","description":"Curated Puppet Documentation","fork":true,"url":"https://api.github.com/repos/gguillotte/puppet-docs","forks_url":"https://api.github.com/repos/gguillotte/puppet-docs/forks","keys_url":"https://api.github.com/repos/gguillotte/puppet-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gguillotte/puppet-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gguillotte/puppet-docs/teams","hooks_url":"https://api.github.com/repos/gguillotte/puppet-docs/hooks","issue_events_url":"https://api.github.com/repos/gguillotte/puppet-docs/issues/events{/number}","events_url":"https://api.github.com/repos/gguillotte/puppet-docs/events","assignees_url":"https://api.github.com/repos/gguillotte/puppet-docs/assignees{/user}","branches_url":"https://api.github.com/repos/gguillotte/puppet-docs/branches{/branch}","tags_url":"https://api.github.com/repos/gguillotte/puppet-docs/tags","blobs_url":"https://api.github.com/repos/gguillotte/puppet-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gguillotte/puppet-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gguillotte/puppet-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gguillotte/puppet-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gguillotte/puppet-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/gguillotte/puppet-docs/languages","stargazers_url":"https://api.github.com/repos/gguillotte/puppet-docs/stargazers","contributors_url":"https://api.github.com/repos/gguillotte/puppet-docs/contributors","subscribers_url":"https://api.github.com/repos/gguillotte/puppet-docs/subscribers","subscription_url":"https://api.github.com/repos/gguillotte/puppet-docs/subscription","commits_url":"https://api.github.com/repos/gguillotte/puppet-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gguillotte/puppet-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gguillotte/puppet-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gguillotte/puppet-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gguillotte/puppet-docs/contents/{+path}","compare_url":"https://api.github.com/repos/gguillotte/puppet-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gguillotte/puppet-docs/merges","archive_url":"https://api.github.com/repos/gguillotte/puppet-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gguillotte/puppet-docs/downloads","issues_url":"https://api.github.com/repos/gguillotte/puppet-docs/issues{/number}","pulls_url":"https://api.github.com/repos/gguillotte/puppet-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/gguillotte/puppet-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/gguillotte/puppet-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gguillotte/puppet-docs/labels{/name}","releases_url":"https://api.github.com/repos/gguillotte/puppet-docs/releases{/id}","deployments_url":"https://api.github.com/repos/gguillotte/puppet-docs/deployments","created_at":"2014-12-17T09:54:17Z","updated_at":"2016-11-02T21:35:16Z","pushed_at":"2018-08-10T01:50:39Z","git_url":"git://github.com/gguillotte/puppet-docs.git","ssh_url":"git@github.com:gguillotte/puppet-docs.git","clone_url":"https://github.com/gguillotte/puppet-docs.git","svn_url":"https://github.com/gguillotte/puppet-docs","homepage":"","size":152301,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"e178354eb438d0cda782e93596ef2ed20c114356","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910752,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NTI=","name":"puppet-docs","full_name":"puppetlabs/puppet-docs","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-docs","description":"Curated Puppet Documentation","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-docs","forks_url":"https://api.github.com/repos/puppetlabs/puppet-docs/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-docs/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-docs/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-docs/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-docs/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-docs/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-docs/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-docs/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-docs/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-docs/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-docs/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-docs/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-docs/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-docs/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-docs/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-docs/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-docs/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-docs/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet-docs/deployments","created_at":"2010-09-14T19:30:19Z","updated_at":"2018-08-10T16:52:27Z","pushed_at":"2018-08-10T16:52:23Z","git_url":"git://github.com/puppetlabs/puppet-docs.git","ssh_url":"git@github.com:puppetlabs/puppet-docs.git","clone_url":"https://github.com/puppetlabs/puppet-docs.git","svn_url":"https://github.com/puppetlabs/puppet-docs","homepage":"","size":151824,"stargazers_count":200,"watchers_count":200,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":317,"open_issues":5,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883"},"html":{"href":"https://github.com/puppetlabs/puppet-docs/pull/883"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/883"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/issues/883/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/pulls/883/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-docs/statuses/7da6aa7a36237644f34c021383bfa0eaa567a6fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"binford2k"}}