{"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/173636567","pull_request_review_id":102863770,"id":173636567,"diff_hunk":"@@ -0,0 +1,120 @@\n+/*\r\n+ * Zed Attack Proxy (ZAP) and its related class files.\r\n+ * \r\n+ * ZAP is an HTTP/HTTPS proxy for assessing web application security.\r\n+ * \r\n+ * Copyright 2017 The ZAP Development Team\r\n+ * \r\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); \r\n+ * you may not use this file except in compliance with the License. \r\n+ * You may obtain a copy of the License at \r\n+ * \r\n+ *   http://www.apache.org/licenses/LICENSE-2.0 \r\n+ *   \r\n+ * Unless required by applicable law or agreed to in writing, software \r\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, \r\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. \r\n+ * See the License for the specific language governing permissions and \r\n+ * limitations under the License. \r\n+ */\r\n+package org.zaproxy.zap.extension.custompages;\r\n+\r\n+import org.parosproxy.paros.network.HttpMessage;\r\n+import org.zaproxy.zap.utils.EnableableInterface;\r\n+\r\n+public interface CustomPage extends EnableableInterface{\r\n+\r\n+\t/**\r\n+\t * Returns the context ID for a Custom Page.\r\n+\t * \r\n+\t *  @return the context ID {@code int}\r\n+\t */\r\n+\tint getContextId();\r\n+\r\n+\t/**\r\n+\t * Sets the context ID for a Custom Page.\r\n+\t * \r\n+\t * @param contextId the ID of the context\r\n+\t */\r\n+\tvoid setContextId(int contextId);\r\n+\r\n+\t/**\r\n+\t * Returns the content for a Custom Page.\r\n+\t * \r\n+\t * @return the content {@code String}\r\n+\t */\r\n+\tString getContent();\r","path":"src/org/zaproxy/zap/extension/custompages/CustomPage.java","position":46,"original_position":46,"commit_id":"dc150455d9230fbbcc3956bb690547193f917aa3","original_commit_id":"dc150455d9230fbbcc3956bb690547193f917aa3","user":{"login":"denniskniep","id":3629463,"avatar_url":"https://avatars2.githubusercontent.com/u/3629463?v=4","gravatar_id":"","url":"https://api.github.com/users/denniskniep","html_url":"https://github.com/denniskniep","followers_url":"https://api.github.com/users/denniskniep/followers","following_url":"https://api.github.com/users/denniskniep/following{/other_user}","gists_url":"https://api.github.com/users/denniskniep/gists{/gist_id}","starred_url":"https://api.github.com/users/denniskniep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denniskniep/subscriptions","organizations_url":"https://api.github.com/users/denniskniep/orgs","repos_url":"https://api.github.com/users/denniskniep/repos","events_url":"https://api.github.com/users/denniskniep/events{/privacy}","received_events_url":"https://api.github.com/users/denniskniep/received_events","type":"User","site_admin":false},"body":"I think the terms `Content` and  `ContentType` are a bit confusing.\r\nThese terms are strongly related to the http wording. \r\n\r\nHow about renaming them into `Matcher` and `MatcherType` or  `PageMatcher` and `PageMatcherType` ? This renaming is also related to the class `CustomPageContentType`\r\n\r\n  ","created_at":"2018-03-10T22:07:34Z","updated_at":"2018-03-10T22:31:41Z","html_url":"https://github.com/zaproxy/zaproxy/pull/3638#discussion_r173636567","pull_request_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/173636567"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/3638#discussion_r173636567"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638"}}},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638","id":124887608,"html_url":"https://github.com/zaproxy/zaproxy/pull/3638","diff_url":"https://github.com/zaproxy/zaproxy/pull/3638.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/3638.patch","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3638","number":3638,"state":"open","locked":false,"title":"Initial CustomPages Implementation","user":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars0.githubusercontent.com/u/7570458?v=4","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"body":"All the \"gutts\" of the solution for other components to take advantage of.\r\n\r\nSee zaproxy/zaproxy#9","created_at":"2017-06-09T15:03:10Z","updated_at":"2018-03-10T22:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4f53605e70b36de8170f8f0e91b9ece35eebc3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":220536002,"url":"https://api.github.com/repos/zaproxy/zaproxy/labels/Type-Task","name":"Type-Task","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3638/comments","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/dc150455d9230fbbcc3956bb690547193f917aa3","head":{"label":"kingthorin:issue-9-customerrors","ref":"issue-9-customerrors","sha":"dc150455d9230fbbcc3956bb690547193f917aa3","user":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars0.githubusercontent.com/u/7570458?v=4","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"repo":{"id":39949051,"name":"zaproxy","full_name":"kingthorin/zaproxy","owner":{"login":"kingthorin","id":7570458,"avatar_url":"https://avatars0.githubusercontent.com/u/7570458?v=4","gravatar_id":"","url":"https://api.github.com/users/kingthorin","html_url":"https://github.com/kingthorin","followers_url":"https://api.github.com/users/kingthorin/followers","following_url":"https://api.github.com/users/kingthorin/following{/other_user}","gists_url":"https://api.github.com/users/kingthorin/gists{/gist_id}","starred_url":"https://api.github.com/users/kingthorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingthorin/subscriptions","organizations_url":"https://api.github.com/users/kingthorin/orgs","repos_url":"https://api.github.com/users/kingthorin/repos","events_url":"https://api.github.com/users/kingthorin/events{/privacy}","received_events_url":"https://api.github.com/users/kingthorin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingthorin/zaproxy","description":"The OWASP ZAP core project","fork":true,"url":"https://api.github.com/repos/kingthorin/zaproxy","forks_url":"https://api.github.com/repos/kingthorin/zaproxy/forks","keys_url":"https://api.github.com/repos/kingthorin/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingthorin/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingthorin/zaproxy/teams","hooks_url":"https://api.github.com/repos/kingthorin/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/kingthorin/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/kingthorin/zaproxy/events","assignees_url":"https://api.github.com/repos/kingthorin/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/kingthorin/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/kingthorin/zaproxy/tags","blobs_url":"https://api.github.com/repos/kingthorin/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingthorin/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingthorin/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingthorin/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingthorin/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/kingthorin/zaproxy/languages","stargazers_url":"https://api.github.com/repos/kingthorin/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/kingthorin/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/kingthorin/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/kingthorin/zaproxy/subscription","commits_url":"https://api.github.com/repos/kingthorin/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingthorin/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingthorin/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingthorin/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingthorin/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/kingthorin/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingthorin/zaproxy/merges","archive_url":"https://api.github.com/repos/kingthorin/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingthorin/zaproxy/downloads","issues_url":"https://api.github.com/repos/kingthorin/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/kingthorin/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/kingthorin/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/kingthorin/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingthorin/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/kingthorin/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/kingthorin/zaproxy/deployments","created_at":"2015-07-30T12:21:06Z","updated_at":"2016-01-11T13:02:07Z","pushed_at":"2018-03-10T12:07:24Z","git_url":"git://github.com/kingthorin/zaproxy.git","ssh_url":"git@github.com:kingthorin/zaproxy.git","clone_url":"https://github.com/kingthorin/zaproxy.git","svn_url":"https://github.com/kingthorin/zaproxy","homepage":null,"size":174672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zaproxy:develop","ref":"develop","sha":"31d5a245b53e2584f5d3791f84389817fea5372e","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":36817565,"name":"zaproxy","full_name":"zaproxy/zaproxy","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zaproxy","description":"The OWASP ZAP core project","fork":false,"url":"https://api.github.com/repos/zaproxy/zaproxy","forks_url":"https://api.github.com/repos/zaproxy/zaproxy/forks","keys_url":"https://api.github.com/repos/zaproxy/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zaproxy/teams","hooks_url":"https://api.github.com/repos/zaproxy/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zaproxy/events","assignees_url":"https://api.github.com/repos/zaproxy/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zaproxy/tags","blobs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zaproxy/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zaproxy/subscription","commits_url":"https://api.github.com/repos/zaproxy/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zaproxy/merges","archive_url":"https://api.github.com/repos/zaproxy/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zaproxy/downloads","issues_url":"https://api.github.com/repos/zaproxy/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zaproxy/deployments","created_at":"2015-06-03T16:55:01Z","updated_at":"2018-03-10T14:32:40Z","pushed_at":"2018-03-10T00:44:13Z","git_url":"git://github.com/zaproxy/zaproxy.git","ssh_url":"git@github.com:zaproxy/zaproxy.git","clone_url":"https://github.com/zaproxy/zaproxy.git","svn_url":"https://github.com/zaproxy/zaproxy","homepage":null,"size":174726,"stargazers_count":3649,"watchers_count":3649,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":719,"mirror_url":null,"archived":false,"open_issues_count":601,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":719,"open_issues":601,"watchers":3649,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/3638"},"issue":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/3638"},"comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/3638/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3638/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zaproxy/statuses/dc150455d9230fbbcc3956bb690547193f917aa3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"denniskniep"}}