{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/comments/228764104","pull_request_review_id":169108165,"id":228764104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc2NDEwNA==","diff_hunk":"@@ -911,11 +911,18 @@ uint64_t FlowController::getUptime() {\n }\n \n std::vector<BackTrace> FlowController::getTraces() {\n-    std::vector<BackTrace> traces;\n+  std::vector<BackTrace> traces;\n   auto timer_driven = timer_scheduler_->getTraces();\n   traces.insert(traces.end(), std::make_move_iterator(timer_driven.begin()), std::make_move_iterator(timer_driven.end()));\n   auto event_driven = event_scheduler_->getTraces();\n   traces.insert(traces.end(), std::make_move_iterator(event_driven.begin()), std::make_move_iterator(event_driven.end()));\n+  // repositories\n+  auto prov_repo_trace = provenance_repo_->getTraces();\n+  traces.emplace_back(std::move(prov_repo_trace));","path":"libminifi/src/FlowController.cpp","position":12,"original_position":12,"commit_id":"5fe24701cbe690e9bc2df95ea638271d22cf8812","original_commit_id":"5fe24701cbe690e9bc2df95ea638271d22cf8812","user":{"login":"arpadboda","id":43749426,"node_id":"MDQ6VXNlcjQzNzQ5NDI2","avatar_url":"https://avatars0.githubusercontent.com/u/43749426?v=4","gravatar_id":"","url":"https://api.github.com/users/arpadboda","html_url":"https://github.com/arpadboda","followers_url":"https://api.github.com/users/arpadboda/followers","following_url":"https://api.github.com/users/arpadboda/following{/other_user}","gists_url":"https://api.github.com/users/arpadboda/gists{/gist_id}","starred_url":"https://api.github.com/users/arpadboda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arpadboda/subscriptions","organizations_url":"https://api.github.com/users/arpadboda/orgs","repos_url":"https://api.github.com/users/arpadboda/repos","events_url":"https://api.github.com/users/arpadboda/events{/privacy}","received_events_url":"https://api.github.com/users/arpadboda/received_events","type":"User","site_admin":false},"body":"Emplacing doesn't make sense in case the argument type is the same as the container template type. ","created_at":"2018-10-28T20:37:14Z","updated_at":"2018-10-28T20:39:15Z","html_url":"https://github.com/apache/nifi-minifi-cpp/pull/428#discussion_r228764104","pull_request_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/comments/228764104"},"html":{"href":"https://github.com/apache/nifi-minifi-cpp/pull/428#discussion_r228764104"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428","id":226254085,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjU0MDg1","html_url":"https://github.com/apache/nifi-minifi-cpp/pull/428","diff_url":"https://github.com/apache/nifi-minifi-cpp/pull/428.diff","patch_url":"https://github.com/apache/nifi-minifi-cpp/pull/428.patch","issue_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/428","number":428,"state":"open","locked":false,"title":"MINIFICPP-652: Add traceability to repositories and flow controller","user":{"login":"phrocker","id":1781585,"node_id":"MDQ6VXNlcjE3ODE1ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1781585?v=4","gravatar_id":"","url":"https://api.github.com/users/phrocker","html_url":"https://github.com/phrocker","followers_url":"https://api.github.com/users/phrocker/followers","following_url":"https://api.github.com/users/phrocker/following{/other_user}","gists_url":"https://api.github.com/users/phrocker/gists{/gist_id}","starred_url":"https://api.github.com/users/phrocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phrocker/subscriptions","organizations_url":"https://api.github.com/users/phrocker/orgs","repos_url":"https://api.github.com/users/phrocker/repos","events_url":"https://api.github.com/users/phrocker/events{/privacy}","received_events_url":"https://api.github.com/users/phrocker/received_events","type":"User","site_admin":false},"body":"Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced\r\n     in the commit message?\r\n\r\n- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [ ] If applicable, have you updated the LICENSE file?\r\n- [ ] If applicable, have you updated the NOTICE file?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2018-10-27T00:03:14Z","updated_at":"2018-10-28T20:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e0e1283a98b3f8d95ccdfdc8bfe49db1486f235","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428/commits","review_comments_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428/comments","review_comment_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/428/comments","statuses_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/statuses/5fe24701cbe690e9bc2df95ea638271d22cf8812","head":{"label":"phrocker:MINIFICPP-652-b","ref":"MINIFICPP-652-b","sha":"5fe24701cbe690e9bc2df95ea638271d22cf8812","user":{"login":"phrocker","id":1781585,"node_id":"MDQ6VXNlcjE3ODE1ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1781585?v=4","gravatar_id":"","url":"https://api.github.com/users/phrocker","html_url":"https://github.com/phrocker","followers_url":"https://api.github.com/users/phrocker/followers","following_url":"https://api.github.com/users/phrocker/following{/other_user}","gists_url":"https://api.github.com/users/phrocker/gists{/gist_id}","starred_url":"https://api.github.com/users/phrocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phrocker/subscriptions","organizations_url":"https://api.github.com/users/phrocker/orgs","repos_url":"https://api.github.com/users/phrocker/repos","events_url":"https://api.github.com/users/phrocker/events{/privacy}","received_events_url":"https://api.github.com/users/phrocker/received_events","type":"User","site_admin":false},"repo":{"id":80614745,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxNDc0NQ==","name":"nifi-minifi-cpp","full_name":"phrocker/nifi-minifi-cpp","private":false,"owner":{"login":"phrocker","id":1781585,"node_id":"MDQ6VXNlcjE3ODE1ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1781585?v=4","gravatar_id":"","url":"https://api.github.com/users/phrocker","html_url":"https://github.com/phrocker","followers_url":"https://api.github.com/users/phrocker/followers","following_url":"https://api.github.com/users/phrocker/following{/other_user}","gists_url":"https://api.github.com/users/phrocker/gists{/gist_id}","starred_url":"https://api.github.com/users/phrocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phrocker/subscriptions","organizations_url":"https://api.github.com/users/phrocker/orgs","repos_url":"https://api.github.com/users/phrocker/repos","events_url":"https://api.github.com/users/phrocker/events{/privacy}","received_events_url":"https://api.github.com/users/phrocker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phrocker/nifi-minifi-cpp","description":"Mirror of Apache Nifi Minifi CPP","fork":true,"url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp","forks_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/forks","keys_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/teams","hooks_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/hooks","issue_events_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/events","assignees_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/tags","blobs_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/languages","stargazers_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/stargazers","contributors_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/contributors","subscribers_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/subscribers","subscription_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/subscription","commits_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/merges","archive_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/downloads","issues_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/labels{/name}","releases_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/phrocker/nifi-minifi-cpp/deployments","created_at":"2017-02-01T11:41:22Z","updated_at":"2018-10-26T23:57:40Z","pushed_at":"2018-10-27T00:02:56Z","git_url":"git://github.com/phrocker/nifi-minifi-cpp.git","ssh_url":"git@github.com:phrocker/nifi-minifi-cpp.git","clone_url":"https://github.com/phrocker/nifi-minifi-cpp.git","svn_url":"https://github.com/phrocker/nifi-minifi-cpp","homepage":null,"size":50824,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0043155dce73ded463f42c80de142ce908a9c08b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":56750161,"node_id":"MDEwOlJlcG9zaXRvcnk1Njc1MDE2MQ==","name":"nifi-minifi-cpp","full_name":"apache/nifi-minifi-cpp","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/nifi-minifi-cpp","description":"Mirror of Apache Nifi Minifi CPP","fork":false,"url":"https://api.github.com/repos/apache/nifi-minifi-cpp","forks_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/forks","keys_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/teams","hooks_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/events","assignees_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/tags","blobs_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/subscription","commits_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/merges","archive_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/downloads","issues_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi-minifi-cpp/deployments","created_at":"2016-04-21T07:00:06Z","updated_at":"2018-10-26T03:35:24Z","pushed_at":"2018-10-27T00:03:15Z","git_url":"git://github.com/apache/nifi-minifi-cpp.git","ssh_url":"git@github.com:apache/nifi-minifi-cpp.git","clone_url":"https://github.com/apache/nifi-minifi-cpp.git","svn_url":"https://github.com/apache/nifi-minifi-cpp","homepage":null,"size":29703,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":3,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428"},"html":{"href":"https://github.com/apache/nifi-minifi-cpp/pull/428"},"issue":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/428"},"comments":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi-minifi-cpp/statuses/5fe24701cbe690e9bc2df95ea638271d22cf8812"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arpadboda"}}