{"action":"created","comment":{"url":"https://api.github.com/repos/Kong/kong/pulls/comments/178231011","pull_request_review_id":108261351,"id":178231011,"diff_hunk":"@@ -211,14 +211,16 @@ local function wait_until(f, timeout)\n     error(\"arg #1 must be a function\", 2)\n   end\n \n+  ngx.update_time()","path":"spec/helpers.lua","position":4,"original_position":4,"commit_id":"cdf50955cc876d95bc79f16015c7c5c547c77bed","original_commit_id":"cdf50955cc876d95bc79f16015c7c5c547c77bed","user":{"login":"thibaultcha","id":1125431,"avatar_url":"https://avatars2.githubusercontent.com/u/1125431?v=4","gravatar_id":"","url":"https://api.github.com/users/thibaultcha","html_url":"https://github.com/thibaultcha","followers_url":"https://api.github.com/users/thibaultcha/followers","following_url":"https://api.github.com/users/thibaultcha/following{/other_user}","gists_url":"https://api.github.com/users/thibaultcha/gists{/gist_id}","starred_url":"https://api.github.com/users/thibaultcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibaultcha/subscriptions","organizations_url":"https://api.github.com/users/thibaultcha/orgs","repos_url":"https://api.github.com/users/thibaultcha/repos","events_url":"https://api.github.com/users/thibaultcha/events{/privacy}","received_events_url":"https://api.github.com/users/thibaultcha/received_events","type":"User","site_admin":false},"body":"I wasn't sure, but double check and yeah indeed :+1:","created_at":"2018-03-30T04:27:25Z","updated_at":"2018-03-30T04:27:25Z","html_url":"https://github.com/Kong/kong/pull/3360#discussion_r178231011","pull_request_url":"https://api.github.com/repos/Kong/kong/pulls/3360","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Kong/kong/pulls/comments/178231011"},"html":{"href":"https://github.com/Kong/kong/pull/3360#discussion_r178231011"},"pull_request":{"href":"https://api.github.com/repos/Kong/kong/pulls/3360"}},"in_reply_to_id":178222910},"pull_request":{"url":"https://api.github.com/repos/Kong/kong/pulls/3360","id":178416149,"html_url":"https://github.com/Kong/kong/pull/3360","diff_url":"https://github.com/Kong/kong/pull/3360.diff","patch_url":"https://github.com/Kong/kong/pull/3360.patch","issue_url":"https://api.github.com/repos/Kong/kong/issues/3360","number":3360,"state":"open","locked":false,"title":"tests(dao) increase speed and reliability of DAO ttl tests","user":{"login":"hishamhm","id":245621,"avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"body":"### increase speed and reliability of DAO ttl tests \r\n\r\n* remove explicit uses of `ngx.sleep`, make tests rely on `wait_until` only.\r\n* increase `wait_until` timeouts, to make them more resilient to slowness in CI environment\r\n* lower ttl values in examples to make tests run faster\r\n\r\n###  ensure `wait_until` runs with an updated time\r\n\r\nUpdate the internal `ngx` clock before calculating the start time of the `wait_until` loop. This also allows moving the `ngx.sleep` of the loop after the `pcall` (without the `ngx.update_time` at the top, some tests would break if `ngx.sleep` was done after the `pcall` as they were implicitly assuming that they ran with an updated clock).","created_at":"2018-03-29T19:11:48Z","updated_at":"2018-03-30T04:27:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af91d4baf1a118f145b9d1ce0cbc9d541e7a1bdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kong/kong/pulls/3360/commits","review_comments_url":"https://api.github.com/repos/Kong/kong/pulls/3360/comments","review_comment_url":"https://api.github.com/repos/Kong/kong/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kong/kong/issues/3360/comments","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/cdf50955cc876d95bc79f16015c7c5c547c77bed","head":{"label":"Kong:tests/flaky-ttl","ref":"tests/flaky-ttl","sha":"cdf50955cc876d95bc79f16015c7c5c547c77bed","user":{"login":"Kong","id":962416,"avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"repo":{"id":26783295,"name":"kong","full_name":"Kong/kong","owner":{"login":"Kong","id":962416,"avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kong/kong","description":":monkey: The Microservice API Gateway","fork":false,"url":"https://api.github.com/repos/Kong/kong","forks_url":"https://api.github.com/repos/Kong/kong/forks","keys_url":"https://api.github.com/repos/Kong/kong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kong/kong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kong/kong/teams","hooks_url":"https://api.github.com/repos/Kong/kong/hooks","issue_events_url":"https://api.github.com/repos/Kong/kong/issues/events{/number}","events_url":"https://api.github.com/repos/Kong/kong/events","assignees_url":"https://api.github.com/repos/Kong/kong/assignees{/user}","branches_url":"https://api.github.com/repos/Kong/kong/branches{/branch}","tags_url":"https://api.github.com/repos/Kong/kong/tags","blobs_url":"https://api.github.com/repos/Kong/kong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kong/kong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kong/kong/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kong/kong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/{sha}","languages_url":"https://api.github.com/repos/Kong/kong/languages","stargazers_url":"https://api.github.com/repos/Kong/kong/stargazers","contributors_url":"https://api.github.com/repos/Kong/kong/contributors","subscribers_url":"https://api.github.com/repos/Kong/kong/subscribers","subscription_url":"https://api.github.com/repos/Kong/kong/subscription","commits_url":"https://api.github.com/repos/Kong/kong/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kong/kong/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kong/kong/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kong/kong/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kong/kong/contents/{+path}","compare_url":"https://api.github.com/repos/Kong/kong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kong/kong/merges","archive_url":"https://api.github.com/repos/Kong/kong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kong/kong/downloads","issues_url":"https://api.github.com/repos/Kong/kong/issues{/number}","pulls_url":"https://api.github.com/repos/Kong/kong/pulls{/number}","milestones_url":"https://api.github.com/repos/Kong/kong/milestones{/number}","notifications_url":"https://api.github.com/repos/Kong/kong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kong/kong/labels{/name}","releases_url":"https://api.github.com/repos/Kong/kong/releases{/id}","deployments_url":"https://api.github.com/repos/Kong/kong/deployments","created_at":"2014-11-17T23:56:08Z","updated_at":"2018-03-30T03:58:28Z","pushed_at":"2018-03-30T02:33:08Z","git_url":"git://github.com/Kong/kong.git","ssh_url":"git@github.com:Kong/kong.git","clone_url":"https://github.com/Kong/kong.git","svn_url":"https://github.com/Kong/kong","homepage":"https://konghq.com/install","size":8361,"stargazers_count":15062,"watchers_count":15062,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1733,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1733,"open_issues":277,"watchers":15062,"default_branch":"master"}},"base":{"label":"Kong:master","ref":"master","sha":"8318ad563c770fcc4cd09e35230d7d279f6d575d","user":{"login":"Kong","id":962416,"avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"repo":{"id":26783295,"name":"kong","full_name":"Kong/kong","owner":{"login":"Kong","id":962416,"avatar_url":"https://avatars0.githubusercontent.com/u/962416?v=4","gravatar_id":"","url":"https://api.github.com/users/Kong","html_url":"https://github.com/Kong","followers_url":"https://api.github.com/users/Kong/followers","following_url":"https://api.github.com/users/Kong/following{/other_user}","gists_url":"https://api.github.com/users/Kong/gists{/gist_id}","starred_url":"https://api.github.com/users/Kong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kong/subscriptions","organizations_url":"https://api.github.com/users/Kong/orgs","repos_url":"https://api.github.com/users/Kong/repos","events_url":"https://api.github.com/users/Kong/events{/privacy}","received_events_url":"https://api.github.com/users/Kong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kong/kong","description":":monkey: The Microservice API Gateway","fork":false,"url":"https://api.github.com/repos/Kong/kong","forks_url":"https://api.github.com/repos/Kong/kong/forks","keys_url":"https://api.github.com/repos/Kong/kong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kong/kong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kong/kong/teams","hooks_url":"https://api.github.com/repos/Kong/kong/hooks","issue_events_url":"https://api.github.com/repos/Kong/kong/issues/events{/number}","events_url":"https://api.github.com/repos/Kong/kong/events","assignees_url":"https://api.github.com/repos/Kong/kong/assignees{/user}","branches_url":"https://api.github.com/repos/Kong/kong/branches{/branch}","tags_url":"https://api.github.com/repos/Kong/kong/tags","blobs_url":"https://api.github.com/repos/Kong/kong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kong/kong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kong/kong/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kong/kong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kong/kong/statuses/{sha}","languages_url":"https://api.github.com/repos/Kong/kong/languages","stargazers_url":"https://api.github.com/repos/Kong/kong/stargazers","contributors_url":"https://api.github.com/repos/Kong/kong/contributors","subscribers_url":"https://api.github.com/repos/Kong/kong/subscribers","subscription_url":"https://api.github.com/repos/Kong/kong/subscription","commits_url":"https://api.github.com/repos/Kong/kong/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kong/kong/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kong/kong/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kong/kong/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kong/kong/contents/{+path}","compare_url":"https://api.github.com/repos/Kong/kong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kong/kong/merges","archive_url":"https://api.github.com/repos/Kong/kong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kong/kong/downloads","issues_url":"https://api.github.com/repos/Kong/kong/issues{/number}","pulls_url":"https://api.github.com/repos/Kong/kong/pulls{/number}","milestones_url":"https://api.github.com/repos/Kong/kong/milestones{/number}","notifications_url":"https://api.github.com/repos/Kong/kong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kong/kong/labels{/name}","releases_url":"https://api.github.com/repos/Kong/kong/releases{/id}","deployments_url":"https://api.github.com/repos/Kong/kong/deployments","created_at":"2014-11-17T23:56:08Z","updated_at":"2018-03-30T03:58:28Z","pushed_at":"2018-03-30T02:33:08Z","git_url":"git://github.com/Kong/kong.git","ssh_url":"git@github.com:Kong/kong.git","clone_url":"https://github.com/Kong/kong.git","svn_url":"https://github.com/Kong/kong","homepage":"https://konghq.com/install","size":8361,"stargazers_count":15062,"watchers_count":15062,"language":"Lua","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1733,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1733,"open_issues":277,"watchers":15062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kong/kong/pulls/3360"},"html":{"href":"https://github.com/Kong/kong/pull/3360"},"issue":{"href":"https://api.github.com/repos/Kong/kong/issues/3360"},"comments":{"href":"https://api.github.com/repos/Kong/kong/issues/3360/comments"},"review_comments":{"href":"https://api.github.com/repos/Kong/kong/pulls/3360/comments"},"review_comment":{"href":"https://api.github.com/repos/Kong/kong/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kong/kong/pulls/3360/commits"},"statuses":{"href":"https://api.github.com/repos/Kong/kong/statuses/cdf50955cc876d95bc79f16015c7c5c547c77bed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thibaultcha"}}