{"action":"created","issue":{"url":"https://api.github.com/repos/yarpc/metrics/issues/4","repository_url":"https://api.github.com/repos/yarpc/metrics","labels_url":"https://api.github.com/repos/yarpc/metrics/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/yarpc/metrics/issues/4/comments","events_url":"https://api.github.com/repos/yarpc/metrics/issues/4/events","html_url":"https://github.com/yarpc/metrics/issues/4","id":280326145,"node_id":"MDU6SXNzdWUyODAzMjYxNDU=","number":4,"title":"Vendor Prometheus to keep it out of our dependency manifest","user":{"login":"akshayjshah","id":972790,"node_id":"MDQ6VXNlcjk3Mjc5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/972790?v=4","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-08T00:18:16Z","updated_at":"2018-07-13T23:32:43Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Internally, we use portions of the Prometheus client library and the generated protocol buffer code. However, these packages don't have stable releases yet.\r\n\r\nSince none of these types leak across our package boundaries, we should check in these dependencies in `internal/vendor/`. This would then let us remove these packages from our `glide.yaml`, which makes life easier for consumers - all the packages they're compiling into their binary don't need to agree on the Prometheus version they'd like to use.\r\n\r\nUnfortunately, I don't think that this is possible without either (a) copying the code into a non-vendor directory, or (2) using Go 1.9's type aliases. Since I'd still like to manage these vendored dependencies with `glide` or `dep`, I'd prefer to wait until we only support Go 1.9 and above. This will be completely backward-compatible, so we can make this change in a future minor release."},"comment":{"url":"https://api.github.com/repos/yarpc/metrics/issues/comments/404979072","html_url":"https://github.com/yarpc/metrics/issues/4#issuecomment-404979072","issue_url":"https://api.github.com/repos/yarpc/metrics/issues/4","id":404979072,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDk3OTA3Mg==","user":{"login":"akshayjshah","id":972790,"node_id":"MDQ6VXNlcjk3Mjc5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/972790?v=4","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T23:32:43Z","updated_at":"2018-07-13T23:32:43Z","author_association":"CONTRIBUTOR","body":"Closing this, since it's irrelevant in the future of Go modules - nested vendor directories are going to be ignored anyways."}}
{"actor":{"display_login":"akshayjshah"}}