{"action":"created","comment":{"url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/comments/242615512","pull_request_review_id":186169464,"id":242615512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjYxNTUxMg==","diff_hunk":"@@ -0,0 +1,83 @@\n+# NAMESERVER12: Test for unknown EDNS flags\n+\n+## Test case identifier\n+\n+**NAMESERVER12** \n+\n+## Objective\n+\n+EDNS is a mechanism to announce capabilities of a dns implementation,\n+and is now basically required by any new functionality in dns such as\n+DNSSEC ([RFC 6891]).\n+\n+[RFC 6891, section 6.1.4] states that \"Z\" flag set to zero by senders and ignored by\n+receiver.\n+\n+In this test case, we will query with an unknown EDNS flag\n+and expect that \"Z\" bits to be clear in the response.\n+\n+## Inputs\n+\n+\"Child Zone\" - The domain name to be tested.\n+\n+## Ordered description of steps to be taken to execute the test case\n+\n+1. Create a SOA query for the *Child Zone* with an OPT record with \n+   EDNS flag \"Z\" bit set to anything other than \"0\" and no other EDNS options or flags.\n+\n+2. Obtain the set of name server IP addresses using [Method4] and [Method5]\n+   (\"Name Server IP\").\n+\n+3. For each name server in *Name Server IP* do:\n+\t1. Send the SOA query to the name server and collect the response.\n+\t2. If there is no DNS response, output *[NO_RESPONSE]* and go to\n+      \tnext server.\n+\t3. Else, if the DNS response has the RCODE \"FORMERR\" then output\n+      \t*[NO_EDNS_SUPPORT]*.\n+\t4. Else, if the pseudo-section has an OPT record with flags being set to\n+\tsome value, then output [Z_FLAGS_NOTCLEAR]. \n+\t5. Else, if the DNS response meet the following four criteria,\n+      \tthen just go to the next name server (no error):\n+\t\t1. The SOA is obtained as response in the ANSWER section.\n+\t\t2. If the DNS response has the RCODE \"NOERROR\".\n+\t\t3. The pseudo-section response has an OPT record with version set to 0.\n+\t\t4. The \"Z\" bits are clear in the response\n+\n+4. Else output *[NS_ERROR]*.","path":"docs/specifications/tests/Nameserver-TP/nameserver12.md","position":46,"original_position":46,"commit_id":"06d99571a426e59351d133e27f899df864aa64f9","original_commit_id":"06d99571a426e59351d133e27f899df864aa64f9","user":{"login":"matsduf","id":5430733,"node_id":"MDQ6VXNlcjU0MzA3MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/5430733?v=4","gravatar_id":"","url":"https://api.github.com/users/matsduf","html_url":"https://github.com/matsduf","followers_url":"https://api.github.com/users/matsduf/followers","following_url":"https://api.github.com/users/matsduf/following{/other_user}","gists_url":"https://api.github.com/users/matsduf/gists{/gist_id}","starred_url":"https://api.github.com/users/matsduf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsduf/subscriptions","organizations_url":"https://api.github.com/users/matsduf/orgs","repos_url":"https://api.github.com/users/matsduf/repos","events_url":"https://api.github.com/users/matsduf/events{/privacy}","received_events_url":"https://api.github.com/users/matsduf/received_events","type":"User","site_admin":false},"body":"This should be \"5\" and indented to be grouped with the other \"else\".","created_at":"2018-12-18T16:45:09Z","updated_at":"2018-12-18T16:45:21Z","html_url":"https://github.com/zonemaster/zonemaster/pull/658#discussion_r242615512","pull_request_url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/comments/242615512"},"html":{"href":"https://github.com/zonemaster/zonemaster/pull/658#discussion_r242615512"},"pull_request":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658"}}},"pull_request":{"url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658","id":238990747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTkwNzQ3","html_url":"https://github.com/zonemaster/zonemaster/pull/658","diff_url":"https://github.com/zonemaster/zonemaster/pull/658.diff","patch_url":"https://github.com/zonemaster/zonemaster/pull/658.patch","issue_url":"https://api.github.com/repos/zonemaster/zonemaster/issues/658","number":658,"state":"open","locked":false,"title":"Added nameserver12.md - Testing for EDNS unknown flags","user":{"login":"sandoche2k","id":5484470,"node_id":"MDQ6VXNlcjU0ODQ0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5484470?v=4","gravatar_id":"","url":"https://api.github.com/users/sandoche2k","html_url":"https://github.com/sandoche2k","followers_url":"https://api.github.com/users/sandoche2k/followers","following_url":"https://api.github.com/users/sandoche2k/following{/other_user}","gists_url":"https://api.github.com/users/sandoche2k/gists{/gist_id}","starred_url":"https://api.github.com/users/sandoche2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandoche2k/subscriptions","organizations_url":"https://api.github.com/users/sandoche2k/orgs","repos_url":"https://api.github.com/users/sandoche2k/repos","events_url":"https://api.github.com/users/sandoche2k/events{/privacy}","received_events_url":"https://api.github.com/users/sandoche2k/received_events","type":"User","site_admin":false},"body":"Test for unknown EDNS flag version. It has already been reviewed. I just separated this test case, from the previous one on the basis of @matsduf request. Hence, now we have a PR for each test case. ","created_at":"2018-12-16T21:15:50Z","updated_at":"2018-12-18T16:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b3f1d7beacfdfb175e71e4f07a739782597eaed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/zonemaster/zonemaster/milestones/18","html_url":"https://github.com/zonemaster/zonemaster/milestone/18","labels_url":"https://api.github.com/repos/zonemaster/zonemaster/milestones/18/labels","id":3262466,"node_id":"MDk6TWlsZXN0b25lMzI2MjQ2Ng==","number":18,"title":"v2018.2","description":"","creator":{"login":"sandoche2k","id":5484470,"node_id":"MDQ6VXNlcjU0ODQ0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5484470?v=4","gravatar_id":"","url":"https://api.github.com/users/sandoche2k","html_url":"https://github.com/sandoche2k","followers_url":"https://api.github.com/users/sandoche2k/followers","following_url":"https://api.github.com/users/sandoche2k/following{/other_user}","gists_url":"https://api.github.com/users/sandoche2k/gists{/gist_id}","starred_url":"https://api.github.com/users/sandoche2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandoche2k/subscriptions","organizations_url":"https://api.github.com/users/sandoche2k/orgs","repos_url":"https://api.github.com/users/sandoche2k/repos","events_url":"https://api.github.com/users/sandoche2k/events{/privacy}","received_events_url":"https://api.github.com/users/sandoche2k/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":6,"state":"open","created_at":"2018-04-12T15:35:55Z","updated_at":"2018-12-18T15:06:32Z","due_on":"2018-09-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658/commits","review_comments_url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658/comments","review_comment_url":"https://api.github.com/repos/zonemaster/zonemaster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zonemaster/zonemaster/issues/658/comments","statuses_url":"https://api.github.com/repos/zonemaster/zonemaster/statuses/06d99571a426e59351d133e27f899df864aa64f9","head":{"label":"sandoche2k:fix-unknown-EDNS-flags","ref":"fix-unknown-EDNS-flags","sha":"06d99571a426e59351d133e27f899df864aa64f9","user":{"login":"sandoche2k","id":5484470,"node_id":"MDQ6VXNlcjU0ODQ0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5484470?v=4","gravatar_id":"","url":"https://api.github.com/users/sandoche2k","html_url":"https://github.com/sandoche2k","followers_url":"https://api.github.com/users/sandoche2k/followers","following_url":"https://api.github.com/users/sandoche2k/following{/other_user}","gists_url":"https://api.github.com/users/sandoche2k/gists{/gist_id}","starred_url":"https://api.github.com/users/sandoche2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandoche2k/subscriptions","organizations_url":"https://api.github.com/users/sandoche2k/orgs","repos_url":"https://api.github.com/users/sandoche2k/repos","events_url":"https://api.github.com/users/sandoche2k/events{/privacy}","received_events_url":"https://api.github.com/users/sandoche2k/received_events","type":"User","site_admin":false},"repo":{"id":131575108,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1NzUxMDg=","name":"zonemaster","full_name":"sandoche2k/zonemaster","private":false,"owner":{"login":"sandoche2k","id":5484470,"node_id":"MDQ6VXNlcjU0ODQ0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5484470?v=4","gravatar_id":"","url":"https://api.github.com/users/sandoche2k","html_url":"https://github.com/sandoche2k","followers_url":"https://api.github.com/users/sandoche2k/followers","following_url":"https://api.github.com/users/sandoche2k/following{/other_user}","gists_url":"https://api.github.com/users/sandoche2k/gists{/gist_id}","starred_url":"https://api.github.com/users/sandoche2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandoche2k/subscriptions","organizations_url":"https://api.github.com/users/sandoche2k/orgs","repos_url":"https://api.github.com/users/sandoche2k/repos","events_url":"https://api.github.com/users/sandoche2k/events{/privacy}","received_events_url":"https://api.github.com/users/sandoche2k/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sandoche2k/zonemaster","description":"The Zonemaster Project","fork":true,"url":"https://api.github.com/repos/sandoche2k/zonemaster","forks_url":"https://api.github.com/repos/sandoche2k/zonemaster/forks","keys_url":"https://api.github.com/repos/sandoche2k/zonemaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandoche2k/zonemaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandoche2k/zonemaster/teams","hooks_url":"https://api.github.com/repos/sandoche2k/zonemaster/hooks","issue_events_url":"https://api.github.com/repos/sandoche2k/zonemaster/issues/events{/number}","events_url":"https://api.github.com/repos/sandoche2k/zonemaster/events","assignees_url":"https://api.github.com/repos/sandoche2k/zonemaster/assignees{/user}","branches_url":"https://api.github.com/repos/sandoche2k/zonemaster/branches{/branch}","tags_url":"https://api.github.com/repos/sandoche2k/zonemaster/tags","blobs_url":"https://api.github.com/repos/sandoche2k/zonemaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandoche2k/zonemaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandoche2k/zonemaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandoche2k/zonemaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandoche2k/zonemaster/statuses/{sha}","languages_url":"https://api.github.com/repos/sandoche2k/zonemaster/languages","stargazers_url":"https://api.github.com/repos/sandoche2k/zonemaster/stargazers","contributors_url":"https://api.github.com/repos/sandoche2k/zonemaster/contributors","subscribers_url":"https://api.github.com/repos/sandoche2k/zonemaster/subscribers","subscription_url":"https://api.github.com/repos/sandoche2k/zonemaster/subscription","commits_url":"https://api.github.com/repos/sandoche2k/zonemaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandoche2k/zonemaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandoche2k/zonemaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandoche2k/zonemaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandoche2k/zonemaster/contents/{+path}","compare_url":"https://api.github.com/repos/sandoche2k/zonemaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandoche2k/zonemaster/merges","archive_url":"https://api.github.com/repos/sandoche2k/zonemaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandoche2k/zonemaster/downloads","issues_url":"https://api.github.com/repos/sandoche2k/zonemaster/issues{/number}","pulls_url":"https://api.github.com/repos/sandoche2k/zonemaster/pulls{/number}","milestones_url":"https://api.github.com/repos/sandoche2k/zonemaster/milestones{/number}","notifications_url":"https://api.github.com/repos/sandoche2k/zonemaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandoche2k/zonemaster/labels{/name}","releases_url":"https://api.github.com/repos/sandoche2k/zonemaster/releases{/id}","deployments_url":"https://api.github.com/repos/sandoche2k/zonemaster/deployments","created_at":"2018-04-30T09:01:38Z","updated_at":"2018-06-26T08:09:55Z","pushed_at":"2018-12-18T14:59:30Z","git_url":"git://github.com/sandoche2k/zonemaster.git","ssh_url":"git@github.com:sandoche2k/zonemaster.git","clone_url":"https://github.com/sandoche2k/zonemaster.git","svn_url":"https://github.com/sandoche2k/zonemaster","homepage":"","size":7516,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zonemaster:develop","ref":"develop","sha":"e6c386b89bab61dab262f45bb72fdddd87231f83","user":{"login":"zonemaster","id":37844868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODQ0ODY4","avatar_url":"https://avatars2.githubusercontent.com/u/37844868?v=4","gravatar_id":"","url":"https://api.github.com/users/zonemaster","html_url":"https://github.com/zonemaster","followers_url":"https://api.github.com/users/zonemaster/followers","following_url":"https://api.github.com/users/zonemaster/following{/other_user}","gists_url":"https://api.github.com/users/zonemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/zonemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonemaster/subscriptions","organizations_url":"https://api.github.com/users/zonemaster/orgs","repos_url":"https://api.github.com/users/zonemaster/repos","events_url":"https://api.github.com/users/zonemaster/events{/privacy}","received_events_url":"https://api.github.com/users/zonemaster/received_events","type":"Organization","site_admin":false},"repo":{"id":12428636,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyODYzNg==","name":"zonemaster","full_name":"zonemaster/zonemaster","private":false,"owner":{"login":"zonemaster","id":37844868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODQ0ODY4","avatar_url":"https://avatars2.githubusercontent.com/u/37844868?v=4","gravatar_id":"","url":"https://api.github.com/users/zonemaster","html_url":"https://github.com/zonemaster","followers_url":"https://api.github.com/users/zonemaster/followers","following_url":"https://api.github.com/users/zonemaster/following{/other_user}","gists_url":"https://api.github.com/users/zonemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/zonemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonemaster/subscriptions","organizations_url":"https://api.github.com/users/zonemaster/orgs","repos_url":"https://api.github.com/users/zonemaster/repos","events_url":"https://api.github.com/users/zonemaster/events{/privacy}","received_events_url":"https://api.github.com/users/zonemaster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zonemaster/zonemaster","description":"The Zonemaster Project","fork":false,"url":"https://api.github.com/repos/zonemaster/zonemaster","forks_url":"https://api.github.com/repos/zonemaster/zonemaster/forks","keys_url":"https://api.github.com/repos/zonemaster/zonemaster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zonemaster/zonemaster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zonemaster/zonemaster/teams","hooks_url":"https://api.github.com/repos/zonemaster/zonemaster/hooks","issue_events_url":"https://api.github.com/repos/zonemaster/zonemaster/issues/events{/number}","events_url":"https://api.github.com/repos/zonemaster/zonemaster/events","assignees_url":"https://api.github.com/repos/zonemaster/zonemaster/assignees{/user}","branches_url":"https://api.github.com/repos/zonemaster/zonemaster/branches{/branch}","tags_url":"https://api.github.com/repos/zonemaster/zonemaster/tags","blobs_url":"https://api.github.com/repos/zonemaster/zonemaster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zonemaster/zonemaster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zonemaster/zonemaster/git/refs{/sha}","trees_url":"https://api.github.com/repos/zonemaster/zonemaster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zonemaster/zonemaster/statuses/{sha}","languages_url":"https://api.github.com/repos/zonemaster/zonemaster/languages","stargazers_url":"https://api.github.com/repos/zonemaster/zonemaster/stargazers","contributors_url":"https://api.github.com/repos/zonemaster/zonemaster/contributors","subscribers_url":"https://api.github.com/repos/zonemaster/zonemaster/subscribers","subscription_url":"https://api.github.com/repos/zonemaster/zonemaster/subscription","commits_url":"https://api.github.com/repos/zonemaster/zonemaster/commits{/sha}","git_commits_url":"https://api.github.com/repos/zonemaster/zonemaster/git/commits{/sha}","comments_url":"https://api.github.com/repos/zonemaster/zonemaster/comments{/number}","issue_comment_url":"https://api.github.com/repos/zonemaster/zonemaster/issues/comments{/number}","contents_url":"https://api.github.com/repos/zonemaster/zonemaster/contents/{+path}","compare_url":"https://api.github.com/repos/zonemaster/zonemaster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zonemaster/zonemaster/merges","archive_url":"https://api.github.com/repos/zonemaster/zonemaster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zonemaster/zonemaster/downloads","issues_url":"https://api.github.com/repos/zonemaster/zonemaster/issues{/number}","pulls_url":"https://api.github.com/repos/zonemaster/zonemaster/pulls{/number}","milestones_url":"https://api.github.com/repos/zonemaster/zonemaster/milestones{/number}","notifications_url":"https://api.github.com/repos/zonemaster/zonemaster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zonemaster/zonemaster/labels{/name}","releases_url":"https://api.github.com/repos/zonemaster/zonemaster/releases{/id}","deployments_url":"https://api.github.com/repos/zonemaster/zonemaster/deployments","created_at":"2013-08-28T08:31:30Z","updated_at":"2018-12-07T21:47:26Z","pushed_at":"2018-12-18T14:59:32Z","git_url":"git://github.com/zonemaster/zonemaster.git","ssh_url":"git@github.com:zonemaster/zonemaster.git","clone_url":"https://github.com/zonemaster/zonemaster.git","svn_url":"https://github.com/zonemaster/zonemaster","homepage":"","size":7464,"stargazers_count":178,"watchers_count":178,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":83,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658"},"html":{"href":"https://github.com/zonemaster/zonemaster/pull/658"},"issue":{"href":"https://api.github.com/repos/zonemaster/zonemaster/issues/658"},"comments":{"href":"https://api.github.com/repos/zonemaster/zonemaster/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zonemaster/zonemaster/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/zonemaster/zonemaster/statuses/06d99571a426e59351d133e27f899df864aa64f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matsduf"}}