{"action":"created","issue":{"url":"https://api.github.com/repos/containous/traefik/issues/3080","repository_url":"https://api.github.com/repos/containous/traefik","labels_url":"https://api.github.com/repos/containous/traefik/issues/3080/labels{/name}","comments_url":"https://api.github.com/repos/containous/traefik/issues/3080/comments","events_url":"https://api.github.com/repos/containous/traefik/issues/3080/events","html_url":"https://github.com/containous/traefik/pull/3080","id":308625079,"number":3080,"title":"Add wildcard match to acme domains","user":{"login":"oldmantaiter","id":2213247,"avatar_url":"https://avatars0.githubusercontent.com/u/2213247?v=4","gravatar_id":"","url":"https://api.github.com/users/oldmantaiter","html_url":"https://github.com/oldmantaiter","followers_url":"https://api.github.com/users/oldmantaiter/followers","following_url":"https://api.github.com/users/oldmantaiter/following{/other_user}","gists_url":"https://api.github.com/users/oldmantaiter/gists{/gist_id}","starred_url":"https://api.github.com/users/oldmantaiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldmantaiter/subscriptions","organizations_url":"https://api.github.com/users/oldmantaiter/orgs","repos_url":"https://api.github.com/users/oldmantaiter/repos","events_url":"https://api.github.com/users/oldmantaiter/events{/privacy}","received_events_url":"https://api.github.com/users/oldmantaiter/received_events","type":"User","site_admin":false},"labels":[{"id":587491203,"url":"https://api.github.com/repos/containous/traefik/labels/area/acme","name":"area/acme","color":"bfdadc","default":false},{"id":687860286,"url":"https://api.github.com/repos/containous/traefik/labels/bot/no-merge","name":"bot/no-merge","color":"D3D3D3","default":false},{"id":591452819,"url":"https://api.github.com/repos/containous/traefik/labels/kind/bug/fix","name":"kind/bug/fix","color":"ee0701","default":false},{"id":265100665,"url":"https://api.github.com/repos/containous/traefik/labels/status/2-needs-review","name":"status/2-needs-review","color":"FADECF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/containous/traefik/milestones/8","html_url":"https://github.com/containous/traefik/milestone/8","labels_url":"https://api.github.com/repos/containous/traefik/milestones/8/labels","id":2946215,"number":8,"title":"1.6","description":"","creator":{"login":"ldez","id":5674651,"avatar_url":"https://avatars0.githubusercontent.com/u/5674651?v=4","gravatar_id":"","url":"https://api.github.com/users/ldez","html_url":"https://github.com/ldez","followers_url":"https://api.github.com/users/ldez/followers","following_url":"https://api.github.com/users/ldez/following{/other_user}","gists_url":"https://api.github.com/users/ldez/gists{/gist_id}","starred_url":"https://api.github.com/users/ldez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldez/subscriptions","organizations_url":"https://api.github.com/users/ldez/orgs","repos_url":"https://api.github.com/users/ldez/repos","events_url":"https://api.github.com/users/ldez/events{/privacy}","received_events_url":"https://api.github.com/users/ldez/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":174,"state":"open","created_at":"2017-11-29T10:46:50Z","updated_at":"2018-03-27T10:22:04Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-03-26T15:37:52Z","updated_at":"2018-03-27T11:36:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/containous/traefik/pulls/3080","html_url":"https://github.com/containous/traefik/pull/3080","diff_url":"https://github.com/containous/traefik/pull/3080.diff","patch_url":"https://github.com/containous/traefik/pull/3080.patch"},"body":"<!--\r\nPLEASE READ THIS MESSAGE.\r\n\r\nHOW TO WRITE A GOOD PULL REQUEST?\r\n\r\n- Make it small.\r\n- Do only one thing.\r\n- Avoid re-formatting.\r\n- Make sure the code builds.\r\n- Make sure all tests pass.\r\n- Add tests.\r\n- Write useful descriptions and titles.\r\n- Address review comments in terms of additional commits.\r\n- Do not amend/squash existing ones unless the PR is trivial.\r\n- Read the contributing guide: https://github.com/containous/traefik/blob/master/.github/CONTRIBUTING.md.\r\n\r\n-->\r\n\r\n### What does this PR do?\r\n\r\n- Allows matching of hosts like `x.traefik.wtf` to ACME wildcard\r\n  certs `*.traefik.wtf`\r\n\r\n\r\n### Motivation\r\n\r\n- Tested wildcard acme v2 and noticed that it was not properly selecting my wildcard domains\r\n\r\n\r\n### More\r\n\r\n- [x] Added/updated tests\r\n- [ ] Added/updated documentation\r\n\r\n### Additional Notes\r\n\r\n<!-- Anything else we should know when reviewing? -->\r\n"},"comment":{"url":"https://api.github.com/repos/containous/traefik/issues/comments/376492716","html_url":"https://github.com/containous/traefik/pull/3080#issuecomment-376492716","issue_url":"https://api.github.com/repos/containous/traefik/issues/3080","id":376492716,"user":{"login":"oldmantaiter","id":2213247,"avatar_url":"https://avatars0.githubusercontent.com/u/2213247?v=4","gravatar_id":"","url":"https://api.github.com/users/oldmantaiter","html_url":"https://github.com/oldmantaiter","followers_url":"https://api.github.com/users/oldmantaiter/followers","following_url":"https://api.github.com/users/oldmantaiter/following{/other_user}","gists_url":"https://api.github.com/users/oldmantaiter/gists{/gist_id}","starred_url":"https://api.github.com/users/oldmantaiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oldmantaiter/subscriptions","organizations_url":"https://api.github.com/users/oldmantaiter/orgs","repos_url":"https://api.github.com/users/oldmantaiter/repos","events_url":"https://api.github.com/users/oldmantaiter/events{/privacy}","received_events_url":"https://api.github.com/users/oldmantaiter/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T11:36:08Z","updated_at":"2018-03-27T11:36:08Z","author_association":"CONTRIBUTOR","body":"@nmengin Thanks. There is one more place I saw this pattern matching code (`provider/acme/provider.go`) so I was going to put the function inside `provider/acme` and reference it from the `acme` package."}}
{"actor":{"display_login":"oldmantaiter"}}