{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/190805307","pull_request_review_id":123261160,"id":190805307,"diff_hunk":"@@ -76,7 +76,8 @@ const inspectDefaultOptions = Object.seal({\n   showProxy: false,\n   maxArrayLength: 100,\n   breakLength: 60,\n-  compact: true\n+  compact: true,\n+  minComplexity: 1e5","path":"lib/util.js","position":6,"original_position":6,"commit_id":"8dba214f941387504870fc2bced4cbe18b39bffc","original_commit_id":"8dba214f941387504870fc2bced4cbe18b39bffc","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Can you add a trailing comma?  Ditto on line 309.","created_at":"2018-05-25T06:57:59Z","updated_at":"2018-05-25T07:04:39Z","html_url":"https://github.com/nodejs/node/pull/19994#discussion_r190805307","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19994","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/190805307"},"html":{"href":"https://github.com/nodejs/node/pull/19994#discussion_r190805307"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19994"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19994","id":181364642,"html_url":"https://github.com/nodejs/node/pull/19994","diff_url":"https://github.com/nodejs/node/pull/19994.diff","patch_url":"https://github.com/nodejs/node/pull/19994.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19994","number":19994,"state":"open","locked":false,"title":"util: add computeTime option to inspect","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"This adds a limit to the maximum computation time while using\r\n`util.inspect()`. That makes sure the event loop is not blocked for\r\nto long even though still having a good output in pretty much all\r\ncases.\r\n\r\nFixes: #19405\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-04-13T01:27:04Z","updated_at":"2018-05-25T07:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e6e6c115ab1a36b2690092dab6cba90fd33a598","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491152610,"url":"https://api.github.com/repos/nodejs/node/labels/notable-change","name":"notable-change","color":"f9d0c4","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false},{"id":155267446,"url":"https://api.github.com/repos/nodejs/node/labels/util","name":"util","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/27","html_url":"https://github.com/nodejs/node/milestone/27","labels_url":"https://api.github.com/repos/nodejs/node/milestones/27/labels","id":2873513,"number":27,"title":"11.0.0","description":"","creator":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":5,"state":"open","created_at":"2017-10-30T07:17:48Z","updated_at":"2018-05-19T17:31:35Z","due_on":"2018-10-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19994/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19994/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19994/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8dba214f941387504870fc2bced4cbe18b39bffc","head":{"label":"BridgeAR:add-util-compute-time","ref":"add-util-compute-time","sha":"8dba214f941387504870fc2bced4cbe18b39bffc","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":51107611,"name":"node","full_name":"BridgeAR/node","owner":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BridgeAR/node","forks_url":"https://api.github.com/repos/BridgeAR/node/forks","keys_url":"https://api.github.com/repos/BridgeAR/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/node/teams","hooks_url":"https://api.github.com/repos/BridgeAR/node/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/node/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/node/events","assignees_url":"https://api.github.com/repos/BridgeAR/node/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/node/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/node/tags","blobs_url":"https://api.github.com/repos/BridgeAR/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/node/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/node/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/node/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/node/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/node/subscription","commits_url":"https://api.github.com/repos/BridgeAR/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/node/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/node/merges","archive_url":"https://api.github.com/repos/BridgeAR/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/node/downloads","issues_url":"https://api.github.com/repos/BridgeAR/node/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/node/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/node/releases{/id}","deployments_url":"https://api.github.com/repos/BridgeAR/node/deployments","created_at":"2016-02-04T21:41:27Z","updated_at":"2018-05-21T15:57:36Z","pushed_at":"2018-05-24T14:28:31Z","git_url":"git://github.com/BridgeAR/node.git","ssh_url":"git@github.com:BridgeAR/node.git","clone_url":"https://github.com/BridgeAR/node.git","svn_url":"https://github.com/BridgeAR/node","homepage":"https://nodejs.org","size":359662,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"531b4bedcac14044f09129ffb65dab71cc2707d9","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-05-25T06:26:16Z","pushed_at":"2018-05-25T06:25:26Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":378475,"stargazers_count":49192,"watchers_count":49192,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10374,"mirror_url":null,"archived":false,"open_issues_count":753,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10374,"open_issues":753,"watchers":49192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19994"},"html":{"href":"https://github.com/nodejs/node/pull/19994"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19994"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19994/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19994/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19994/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8dba214f941387504870fc2bced4cbe18b39bffc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bnoordhuis"}}