{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28","id":165844112,"html_url":"https://github.com/plone/Products.PortalTransforms/pull/28","diff_url":"https://github.com/plone/Products.PortalTransforms/pull/28.diff","patch_url":"https://github.com/plone/Products.PortalTransforms/pull/28.patch","issue_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/28","number":28,"state":"closed","locked":false,"title":"Begin fixing startup in py3","user":{"login":"pbauer","id":453208,"avatar_url":"https://avatars1.githubusercontent.com/u/453208?v=4","gravatar_id":"","url":"https://api.github.com/users/pbauer","html_url":"https://github.com/pbauer","followers_url":"https://api.github.com/users/pbauer/followers","following_url":"https://api.github.com/users/pbauer/following{/other_user}","gists_url":"https://api.github.com/users/pbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/pbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbauer/subscriptions","organizations_url":"https://api.github.com/users/pbauer/orgs","repos_url":"https://api.github.com/users/pbauer/repos","events_url":"https://api.github.com/users/pbauer/events{/privacy}","received_events_url":"https://api.github.com/users/pbauer/received_events","type":"User","site_admin":false},"body":"There is the following issue during startup in python3 only:\r\n\r\n```\r\nfrom Products.PortalTransforms.data import datastream\r\n  File \"/Users/pbauer/workspace/coredev_py3/src/Products.PortalTransforms/Products/PortalTransforms/data.py\", line 6, in <module>\r\n    class datastream(object):\r\nValueError: 'name' in __slots__ conflicts with class variable\r\n```\r\n\r\nThat results from:\r\n\r\n```python\r\n@implementer(IDataStream)\r\nclass datastream(object):\r\n    \"\"\"A transformation datastream packet\"\"\"\r\n\r\n    __slots__ = (\r\n        'name', '_data', '_metadata', '__name__', '_objects', '_cacheable'\r\n    )\r\n\r\n    def __init__(self, name):\r\n        self.__name__ = name\r\n        self._data = ''\r\n        self._metadata = {}\r\n        self._objects = {}\r\n        self._cacheable = 1\r\n```\r\n\r\nWould it be safe to rename `name` to `name_` or could that be used anywhere except for assigning `self.__name__`?","created_at":"2018-01-29T23:10:38Z","updated_at":"2018-03-18T18:17:51Z","closed_at":"2018-03-18T18:17:51Z","merged_at":"2018-03-18T18:17:51Z","merge_commit_sha":"42a836b24cd4803f16520ac79ff0f3d70f0dd8ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":274270409,"url":"https://api.github.com/repos/plone/Products.PortalTransforms/labels/04%20type:%20enhancement","name":"04 type: enhancement","color":"00fa00","default":false},{"id":213991201,"url":"https://api.github.com/repos/plone/Products.PortalTransforms/labels/24%20status:%20ready","name":"24 status: ready","color":"fafa00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28/commits","review_comments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28/comments","review_comment_url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/28/comments","statuses_url":"https://api.github.com/repos/plone/Products.PortalTransforms/statuses/39a89ccbbbb1febf207eb04b7fa2681c40ac03bc","head":{"label":"plone:python3","ref":"python3","sha":"39a89ccbbbb1febf207eb04b7fa2681c40ac03bc","user":{"login":"plone","id":72034,"avatar_url":"https://avatars0.githubusercontent.com/u/72034?v=4","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2479449,"name":"Products.PortalTransforms","full_name":"plone/Products.PortalTransforms","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars0.githubusercontent.com/u/72034?v=4","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/Products.PortalTransforms","description":"Provides MIME types based transformation chains on Plone Archetypes contents","fork":false,"url":"https://api.github.com/repos/plone/Products.PortalTransforms","forks_url":"https://api.github.com/repos/plone/Products.PortalTransforms/forks","keys_url":"https://api.github.com/repos/plone/Products.PortalTransforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/Products.PortalTransforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/Products.PortalTransforms/teams","hooks_url":"https://api.github.com/repos/plone/Products.PortalTransforms/hooks","issue_events_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/events{/number}","events_url":"https://api.github.com/repos/plone/Products.PortalTransforms/events","assignees_url":"https://api.github.com/repos/plone/Products.PortalTransforms/assignees{/user}","branches_url":"https://api.github.com/repos/plone/Products.PortalTransforms/branches{/branch}","tags_url":"https://api.github.com/repos/plone/Products.PortalTransforms/tags","blobs_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/Products.PortalTransforms/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/Products.PortalTransforms/languages","stargazers_url":"https://api.github.com/repos/plone/Products.PortalTransforms/stargazers","contributors_url":"https://api.github.com/repos/plone/Products.PortalTransforms/contributors","subscribers_url":"https://api.github.com/repos/plone/Products.PortalTransforms/subscribers","subscription_url":"https://api.github.com/repos/plone/Products.PortalTransforms/subscription","commits_url":"https://api.github.com/repos/plone/Products.PortalTransforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/Products.PortalTransforms/contents/{+path}","compare_url":"https://api.github.com/repos/plone/Products.PortalTransforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/Products.PortalTransforms/merges","archive_url":"https://api.github.com/repos/plone/Products.PortalTransforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/Products.PortalTransforms/downloads","issues_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues{/number}","pulls_url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/Products.PortalTransforms/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/Products.PortalTransforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/Products.PortalTransforms/labels{/name}","releases_url":"https://api.github.com/repos/plone/Products.PortalTransforms/releases{/id}","deployments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/deployments","created_at":"2011-09-29T02:35:46Z","updated_at":"2017-02-17T13:25:03Z","pushed_at":"2018-03-18T18:17:51Z","git_url":"git://github.com/plone/Products.PortalTransforms.git","ssh_url":"git@github.com:plone/Products.PortalTransforms.git","clone_url":"https://github.com/plone/Products.PortalTransforms.git","svn_url":"https://github.com/plone/Products.PortalTransforms","homepage":"","size":630,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":14,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"plone:master","ref":"master","sha":"4a7ec1eae0942fe32f8de1e3df3a0a6885c345a7","user":{"login":"plone","id":72034,"avatar_url":"https://avatars0.githubusercontent.com/u/72034?v=4","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2479449,"name":"Products.PortalTransforms","full_name":"plone/Products.PortalTransforms","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars0.githubusercontent.com/u/72034?v=4","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/Products.PortalTransforms","description":"Provides MIME types based transformation chains on Plone Archetypes contents","fork":false,"url":"https://api.github.com/repos/plone/Products.PortalTransforms","forks_url":"https://api.github.com/repos/plone/Products.PortalTransforms/forks","keys_url":"https://api.github.com/repos/plone/Products.PortalTransforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/Products.PortalTransforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/Products.PortalTransforms/teams","hooks_url":"https://api.github.com/repos/plone/Products.PortalTransforms/hooks","issue_events_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/events{/number}","events_url":"https://api.github.com/repos/plone/Products.PortalTransforms/events","assignees_url":"https://api.github.com/repos/plone/Products.PortalTransforms/assignees{/user}","branches_url":"https://api.github.com/repos/plone/Products.PortalTransforms/branches{/branch}","tags_url":"https://api.github.com/repos/plone/Products.PortalTransforms/tags","blobs_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/Products.PortalTransforms/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/Products.PortalTransforms/languages","stargazers_url":"https://api.github.com/repos/plone/Products.PortalTransforms/stargazers","contributors_url":"https://api.github.com/repos/plone/Products.PortalTransforms/contributors","subscribers_url":"https://api.github.com/repos/plone/Products.PortalTransforms/subscribers","subscription_url":"https://api.github.com/repos/plone/Products.PortalTransforms/subscription","commits_url":"https://api.github.com/repos/plone/Products.PortalTransforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/Products.PortalTransforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/Products.PortalTransforms/contents/{+path}","compare_url":"https://api.github.com/repos/plone/Products.PortalTransforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/Products.PortalTransforms/merges","archive_url":"https://api.github.com/repos/plone/Products.PortalTransforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/Products.PortalTransforms/downloads","issues_url":"https://api.github.com/repos/plone/Products.PortalTransforms/issues{/number}","pulls_url":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/Products.PortalTransforms/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/Products.PortalTransforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/Products.PortalTransforms/labels{/name}","releases_url":"https://api.github.com/repos/plone/Products.PortalTransforms/releases{/id}","deployments_url":"https://api.github.com/repos/plone/Products.PortalTransforms/deployments","created_at":"2011-09-29T02:35:46Z","updated_at":"2017-02-17T13:25:03Z","pushed_at":"2018-03-18T18:17:51Z","git_url":"git://github.com/plone/Products.PortalTransforms.git","ssh_url":"git@github.com:plone/Products.PortalTransforms.git","clone_url":"https://github.com/plone/Products.PortalTransforms.git","svn_url":"https://github.com/plone/Products.PortalTransforms","homepage":"","size":630,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":14,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28"},"html":{"href":"https://github.com/plone/Products.PortalTransforms/pull/28"},"issue":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/28"},"comments":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/plone/Products.PortalTransforms/statuses/39a89ccbbbb1febf207eb04b7fa2681c40ac03bc"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jensens","id":157140,"avatar_url":"https://avatars1.githubusercontent.com/u/157140?v=4","gravatar_id":"","url":"https://api.github.com/users/jensens","html_url":"https://github.com/jensens","followers_url":"https://api.github.com/users/jensens/followers","following_url":"https://api.github.com/users/jensens/following{/other_user}","gists_url":"https://api.github.com/users/jensens/gists{/gist_id}","starred_url":"https://api.github.com/users/jensens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensens/subscriptions","organizations_url":"https://api.github.com/users/jensens/orgs","repos_url":"https://api.github.com/users/jensens/repos","events_url":"https://api.github.com/users/jensens/events{/privacy}","received_events_url":"https://api.github.com/users/jensens/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":15,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"jensens"}}