{"action":"closed","number":254,"pull_request":{"url":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254","id":213123287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTIzMjg3","html_url":"https://github.com/JoinColony/colonyJS/pull/254","diff_url":"https://github.com/JoinColony/colonyJS/pull/254.diff","patch_url":"https://github.com/JoinColony/colonyJS/pull/254.patch","issue_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/254","number":254,"state":"closed","locked":false,"title":"Parse all method events with ContractEvent","user":{"login":"JamesLefrere","id":5450382,"node_id":"MDQ6VXNlcjU0NTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5450382?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesLefrere","html_url":"https://github.com/JamesLefrere","followers_url":"https://api.github.com/users/JamesLefrere/followers","following_url":"https://api.github.com/users/JamesLefrere/following{/other_user}","gists_url":"https://api.github.com/users/JamesLefrere/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesLefrere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesLefrere/subscriptions","organizations_url":"https://api.github.com/users/JamesLefrere/orgs","repos_url":"https://api.github.com/users/JamesLefrere/repos","events_url":"https://api.github.com/users/JamesLefrere/events{/privacy}","received_events_url":"https://api.github.com/users/JamesLefrere/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n**Halt Stopp!**\r\n\r\nPlease do the code review commit-by-commit, it will make things _much_ clearer :)\r\n\r\n* Documentation is better! (see changes below)\r\n* Missing events are added! (see changes below)\r\n* All events logged during method calls are now parsed according to their specifications on the `ContractClient`, without specifying event handlers\r\n* Event data in method responses is now provided in a flat format (where property names might collide) and in a format nested under the event name; e.g. `{ taskId: 1, potId: 2 }` becomes `{ taskId: 1, potId: 2, TaskAdded: { taskId: 1 }, PotAdded: { potId: 2 } }`.\r\n* Event property names are now more specific (e.g. `taskId` rather than `id`)\r\n\r\n## Other changes (e.g. bug fixes, UI tweaks, refactors)\r\n\r\n* Use contract interface for events\r\n  * Remove `getEventData` and `getEventPromises` from the adapter\r\n  * Specify `interface` for the contract interface, which provides the contract events\r\n  * Correct the `log` property name for the receipt (should be `logs`)\r\n* Parse all method events\r\n  * Add `ContractClient.getReceiptEventData` method, to decode and parse event data from a transaction receipt\r\n  * Add `ContractEvent.parse` (static and instance methods) to parse event args\r\n  * Implement `getReceiptEventData` in `ContractMethodSender.send` method\r\n  * Use the `length` property (if available) to get values when converting output values\r\n* Remove eventHandlers from method specs\r\n* Specify events for contract clients\r\n  * Flesh out event types for the contract clients\r\n  * Add ColonyNetworkClient events\r\n  * Add TokenClient events\r\n* Events support for docgen\r\n  * Add support for the flat/nested event data in the documentation generation\r\n  * Add support for documenting `ContractEvent` classes\r\n* Update docs\r\n  * Add Events section to ContractClient\r\n  * Update event data in ContractClient\r\n  * Update ColonyClient senders/events\r\n  * Update ColonyNetworkClient senders/events\r\n  * Update TokenClient senders/events\r\n\r\n## TODO\r\n\r\n> ⚠️  NOTE: Please make sure all items are checked or remove the TODO list before closing the PR\r\n\r\n- [x] Test against colonyDapp integration tests\r\n- [x] QA deployed documentation pages\r\n\r\n\r\nResolves #223 #127 \r\n\r\nContributes to #253 #252 \r\n","created_at":"2018-09-04T22:42:04Z","updated_at":"2018-09-05T13:30:09Z","closed_at":"2018-09-05T13:30:09Z","merged_at":"2018-09-05T13:30:09Z","merge_commit_sha":"7b9f2574cf5e79de184d1ef24d1355af52566e26","assignee":{"login":"JamesLefrere","id":5450382,"node_id":"MDQ6VXNlcjU0NTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5450382?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesLefrere","html_url":"https://github.com/JamesLefrere","followers_url":"https://api.github.com/users/JamesLefrere/followers","following_url":"https://api.github.com/users/JamesLefrere/following{/other_user}","gists_url":"https://api.github.com/users/JamesLefrere/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesLefrere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesLefrere/subscriptions","organizations_url":"https://api.github.com/users/JamesLefrere/orgs","repos_url":"https://api.github.com/users/JamesLefrere/repos","events_url":"https://api.github.com/users/JamesLefrere/events{/privacy}","received_events_url":"https://api.github.com/users/JamesLefrere/received_events","type":"User","site_admin":false},"assignees":[{"login":"JamesLefrere","id":5450382,"node_id":"MDQ6VXNlcjU0NTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5450382?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesLefrere","html_url":"https://github.com/JamesLefrere","followers_url":"https://api.github.com/users/JamesLefrere/followers","following_url":"https://api.github.com/users/JamesLefrere/following{/other_user}","gists_url":"https://api.github.com/users/JamesLefrere/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesLefrere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesLefrere/subscriptions","organizations_url":"https://api.github.com/users/JamesLefrere/orgs","repos_url":"https://api.github.com/users/JamesLefrere/repos","events_url":"https://api.github.com/users/JamesLefrere/events{/privacy}","received_events_url":"https://api.github.com/users/JamesLefrere/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":801744067,"node_id":"MDU6TGFiZWw4MDE3NDQwNjc=","url":"https://api.github.com/repos/JoinColony/colonyJS/labels/Code%20review%20me!!11one","name":"Code review me!!11one","color":"fbca04","default":false},{"id":881883090,"node_id":"MDU6TGFiZWw4ODE4ODMwOTA=","url":"https://api.github.com/repos/JoinColony/colonyJS/labels/documentation","name":"documentation","color":"b2ffd1","default":false},{"id":762892474,"node_id":"MDU6TGFiZWw3NjI4OTI0NzQ=","url":"https://api.github.com/repos/JoinColony/colonyJS/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":868251101,"node_id":"MDU6TGFiZWw4NjgyNTExMDE=","url":"https://api.github.com/repos/JoinColony/colonyJS/labels/maintenance","name":"maintenance","color":"ecf243","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254/commits","review_comments_url":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254/comments","review_comment_url":"https://api.github.com/repos/JoinColony/colonyJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/254/comments","statuses_url":"https://api.github.com/repos/JoinColony/colonyJS/statuses/749e59ff066d2d00e86b853f3899345ce2f30f54","head":{"label":"JoinColony:feature/parse-all-method-events","ref":"feature/parse-all-method-events","sha":"749e59ff066d2d00e86b853f3899345ce2f30f54","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":112282190,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyODIxOTA=","name":"colonyJS","full_name":"JoinColony/colonyJS","owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JoinColony/colonyJS","description":"Monorepo for the Colony JavaScript client","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyJS","forks_url":"https://api.github.com/repos/JoinColony/colonyJS/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyJS/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyJS/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyJS/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyJS/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyJS/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyJS/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyJS/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyJS/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyJS/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyJS/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyJS/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyJS/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyJS/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyJS/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyJS/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyJS/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyJS/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyJS/deployments","created_at":"2017-11-28T03:43:42Z","updated_at":"2018-09-05T09:49:23Z","pushed_at":"2018-09-05T13:30:09Z","git_url":"git://github.com/JoinColony/colonyJS.git","ssh_url":"git@github.com:JoinColony/colonyJS.git","clone_url":"https://github.com/JoinColony/colonyJS.git","svn_url":"https://github.com/JoinColony/colonyJS","homepage":null,"size":1468,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":38,"watchers":35,"default_branch":"master"}},"base":{"label":"JoinColony:master","ref":"master","sha":"6f36b26b7e896d5dc57e62807806ac77a0f31d6c","user":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"repo":{"id":112282190,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyODIxOTA=","name":"colonyJS","full_name":"JoinColony/colonyJS","owner":{"login":"JoinColony","id":7784398,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODQzOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7784398?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinColony","html_url":"https://github.com/JoinColony","followers_url":"https://api.github.com/users/JoinColony/followers","following_url":"https://api.github.com/users/JoinColony/following{/other_user}","gists_url":"https://api.github.com/users/JoinColony/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinColony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinColony/subscriptions","organizations_url":"https://api.github.com/users/JoinColony/orgs","repos_url":"https://api.github.com/users/JoinColony/repos","events_url":"https://api.github.com/users/JoinColony/events{/privacy}","received_events_url":"https://api.github.com/users/JoinColony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JoinColony/colonyJS","description":"Monorepo for the Colony JavaScript client","fork":false,"url":"https://api.github.com/repos/JoinColony/colonyJS","forks_url":"https://api.github.com/repos/JoinColony/colonyJS/forks","keys_url":"https://api.github.com/repos/JoinColony/colonyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinColony/colonyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinColony/colonyJS/teams","hooks_url":"https://api.github.com/repos/JoinColony/colonyJS/hooks","issue_events_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/events{/number}","events_url":"https://api.github.com/repos/JoinColony/colonyJS/events","assignees_url":"https://api.github.com/repos/JoinColony/colonyJS/assignees{/user}","branches_url":"https://api.github.com/repos/JoinColony/colonyJS/branches{/branch}","tags_url":"https://api.github.com/repos/JoinColony/colonyJS/tags","blobs_url":"https://api.github.com/repos/JoinColony/colonyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinColony/colonyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinColony/colonyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinColony/colonyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinColony/colonyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinColony/colonyJS/languages","stargazers_url":"https://api.github.com/repos/JoinColony/colonyJS/stargazers","contributors_url":"https://api.github.com/repos/JoinColony/colonyJS/contributors","subscribers_url":"https://api.github.com/repos/JoinColony/colonyJS/subscribers","subscription_url":"https://api.github.com/repos/JoinColony/colonyJS/subscription","commits_url":"https://api.github.com/repos/JoinColony/colonyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinColony/colonyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinColony/colonyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinColony/colonyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinColony/colonyJS/contents/{+path}","compare_url":"https://api.github.com/repos/JoinColony/colonyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinColony/colonyJS/merges","archive_url":"https://api.github.com/repos/JoinColony/colonyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinColony/colonyJS/downloads","issues_url":"https://api.github.com/repos/JoinColony/colonyJS/issues{/number}","pulls_url":"https://api.github.com/repos/JoinColony/colonyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinColony/colonyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinColony/colonyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinColony/colonyJS/labels{/name}","releases_url":"https://api.github.com/repos/JoinColony/colonyJS/releases{/id}","deployments_url":"https://api.github.com/repos/JoinColony/colonyJS/deployments","created_at":"2017-11-28T03:43:42Z","updated_at":"2018-09-05T09:49:23Z","pushed_at":"2018-09-05T13:30:09Z","git_url":"git://github.com/JoinColony/colonyJS.git","ssh_url":"git@github.com:JoinColony/colonyJS.git","clone_url":"https://github.com/JoinColony/colonyJS.git","svn_url":"https://github.com/JoinColony/colonyJS","homepage":null,"size":1468,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":38,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254"},"html":{"href":"https://github.com/JoinColony/colonyJS/pull/254"},"issue":{"href":"https://api.github.com/repos/JoinColony/colonyJS/issues/254"},"comments":{"href":"https://api.github.com/repos/JoinColony/colonyJS/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinColony/colonyJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinColony/colonyJS/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/JoinColony/colonyJS/statuses/749e59ff066d2d00e86b853f3899345ce2f30f54"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JamesLefrere","id":5450382,"node_id":"MDQ6VXNlcjU0NTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5450382?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesLefrere","html_url":"https://github.com/JamesLefrere","followers_url":"https://api.github.com/users/JamesLefrere/followers","following_url":"https://api.github.com/users/JamesLefrere/following{/other_user}","gists_url":"https://api.github.com/users/JamesLefrere/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesLefrere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesLefrere/subscriptions","organizations_url":"https://api.github.com/users/JamesLefrere/orgs","repos_url":"https://api.github.com/users/JamesLefrere/repos","events_url":"https://api.github.com/users/JamesLefrere/events{/privacy}","received_events_url":"https://api.github.com/users/JamesLefrere/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":769,"deletions":607,"changed_files":26}}
{"actor":{"display_login":"JamesLefrere"}}