{"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/comments/231222451","pull_request_review_id":172144770,"id":231222451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTIyMjQ1MQ==","diff_hunk":"@@ -34,6 +34,8 @@ auth:\n   admins: []\n   # Default session timeout (in minutes)\n   sessionTimeout: 120\n+  # SameSite Cookie Option\n+  sameSite: false","path":"config/default.yaml","position":null,"original_position":5,"commit_id":"0fb8b7e273e3e1536256515fe735158acfaf4825","original_commit_id":"f1912b47b878ff96705d462747dda88d98d46e3e","user":{"login":"jithin1987","id":193126,"node_id":"MDQ6VXNlcjE5MzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/193126?v=4","gravatar_id":"","url":"https://api.github.com/users/jithin1987","html_url":"https://github.com/jithin1987","followers_url":"https://api.github.com/users/jithin1987/followers","following_url":"https://api.github.com/users/jithin1987/following{/other_user}","gists_url":"https://api.github.com/users/jithin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jithin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithin1987/subscriptions","organizations_url":"https://api.github.com/users/jithin1987/orgs","repos_url":"https://api.github.com/users/jithin1987/repos","events_url":"https://api.github.com/users/jithin1987/events{/privacy}","received_events_url":"https://api.github.com/users/jithin1987/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-11-06T17:41:12Z","updated_at":"2018-11-06T17:41:12Z","html_url":"https://github.com/screwdriver-cd/screwdriver/pull/1376#discussion_r231222451","pull_request_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/comments/231222451"},"html":{"href":"https://github.com/screwdriver-cd/screwdriver/pull/1376#discussion_r231222451"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376"}},"in_reply_to_id":230913320},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376","id":228077787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDc3Nzg3","html_url":"https://github.com/screwdriver-cd/screwdriver/pull/1376","diff_url":"https://github.com/screwdriver-cd/screwdriver/pull/1376.diff","patch_url":"https://github.com/screwdriver-cd/screwdriver/pull/1376.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/1376","number":1376,"state":"open","locked":false,"title":"feat: expose SameSite Cookie option","user":{"login":"jithin1987","id":193126,"node_id":"MDQ6VXNlcjE5MzEyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/193126?v=4","gravatar_id":"","url":"https://api.github.com/users/jithin1987","html_url":"https://github.com/jithin1987","followers_url":"https://api.github.com/users/jithin1987/followers","following_url":"https://api.github.com/users/jithin1987/following{/other_user}","gists_url":"https://api.github.com/users/jithin1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jithin1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithin1987/subscriptions","organizations_url":"https://api.github.com/users/jithin1987/orgs","repos_url":"https://api.github.com/users/jithin1987/repos","events_url":"https://api.github.com/users/jithin1987/events{/privacy}","received_events_url":"https://api.github.com/users/jithin1987/received_events","type":"User","site_admin":false},"body":"## Context\r\n\r\n`SameSite` cookie config provides strict CSRF protection, but it breaks CORS interaction for our internal usecases. Hence providing an option for cluster admins to set this value.\r\n\r\n## Objective\r\n1. Upgrade `hapi-auth-cookie` to v7  which supports `isSameSite` setting.\r\n2. Provide a config to set this value.\r\n\r\n\r\n## References\r\n\r\n1. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#Directives See `SameSite` section\r\n","created_at":"2018-11-02T22:54:11Z","updated_at":"2018-11-06T17:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56a4eed3c07cb094a1d4b01a62b4c50f012a209d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/1376/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/statuses/0fb8b7e273e3e1536256515fe735158acfaf4825","head":{"label":"screwdriver-cd:cookie","ref":"cookie","sha":"0fb8b7e273e3e1536256515fe735158acfaf4825","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":59517730,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUxNzczMA==","name":"screwdriver","full_name":"screwdriver-cd/screwdriver","private":false,"owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/screwdriver-cd/screwdriver","description":"An open source build platform designed for Continuous Delivery","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/screwdriver","forks_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/deployments","created_at":"2016-05-23T20:55:35Z","updated_at":"2018-11-05T03:11:53Z","pushed_at":"2018-11-06T17:40:57Z","git_url":"git://github.com/screwdriver-cd/screwdriver.git","ssh_url":"git@github.com:screwdriver-cd/screwdriver.git","clone_url":"https://github.com/screwdriver-cd/screwdriver.git","svn_url":"https://github.com/screwdriver-cd/screwdriver","homepage":"http://screwdriver.cd","size":2720,"stargazers_count":548,"watchers_count":548,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":218,"watchers":548,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"91f9b7fec5aa78d47fc6633a327a2071e1e0cc5f","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":59517730,"node_id":"MDEwOlJlcG9zaXRvcnk1OTUxNzczMA==","name":"screwdriver","full_name":"screwdriver-cd/screwdriver","private":false,"owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/screwdriver-cd/screwdriver","description":"An open source build platform designed for Continuous Delivery","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/screwdriver","forks_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/screwdriver/deployments","created_at":"2016-05-23T20:55:35Z","updated_at":"2018-11-05T03:11:53Z","pushed_at":"2018-11-06T17:40:57Z","git_url":"git://github.com/screwdriver-cd/screwdriver.git","ssh_url":"git@github.com:screwdriver-cd/screwdriver.git","clone_url":"https://github.com/screwdriver-cd/screwdriver.git","svn_url":"https://github.com/screwdriver-cd/screwdriver","homepage":"http://screwdriver.cd","size":2720,"stargazers_count":548,"watchers_count":548,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":218,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376"},"html":{"href":"https://github.com/screwdriver-cd/screwdriver/pull/1376"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/1376"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/issues/1376/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/pulls/1376/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/screwdriver/statuses/0fb8b7e273e3e1536256515fe735158acfaf4825"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jithin1987"}}