{"action":"created","comment":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/215900273","pull_request_review_id":153268075,"id":215900273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTkwMDI3Mw==","diff_hunk":"@@ -332,14 +323,26 @@ class XHClass {\n         }\n     }\n \n+    _idSeed = 1;\n+\n+    /**\n+     * Generate an ID string, unique within this run of the client application and suitable\n+     * for local-to-client uses such as auto-generated store record identifiers.\n+     *\n+     * Deliberately *not* intended to be globally unique, suitable for reuse, or to appear as such.\n+     * @returns {string}\n+     */\n+    genId() {\n+        return `xh-id-${this._idSeed++}`;","path":"core/XH.js","position":128,"original_position":128,"commit_id":"b9e618c5ef3f57c69f544d374cbe7b04efa6cb74","original_commit_id":"b9e618c5ef3f57c69f544d374cbe7b04efa6cb74","user":{"login":"TomTirapani","id":3017757,"node_id":"MDQ6VXNlcjMwMTc3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3017757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomTirapani","html_url":"https://github.com/TomTirapani","followers_url":"https://api.github.com/users/TomTirapani/followers","following_url":"https://api.github.com/users/TomTirapani/following{/other_user}","gists_url":"https://api.github.com/users/TomTirapani/gists{/gist_id}","starred_url":"https://api.github.com/users/TomTirapani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomTirapani/subscriptions","organizations_url":"https://api.github.com/users/TomTirapani/orgs","repos_url":"https://api.github.com/users/TomTirapani/repos","events_url":"https://api.github.com/users/TomTirapani/events{/privacy}","received_events_url":"https://api.github.com/users/TomTirapani/received_events","type":"User","site_admin":false},"body":"I think we could use lodash's `uniqueId('xh-id-')` here and lose the local _idSeed","created_at":"2018-09-07T09:29:29Z","updated_at":"2018-09-07T09:29:29Z","html_url":"https://github.com/exhi/hoist-react/pull/596#discussion_r215900273","pull_request_url":"https://api.github.com/repos/exhi/hoist-react/pulls/596","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/215900273"},"html":{"href":"https://github.com/exhi/hoist-react/pull/596#discussion_r215900273"},"pull_request":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/596","id":213781573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzgxNTcz","html_url":"https://github.com/exhi/hoist-react/pull/596","diff_url":"https://github.com/exhi/hoist-react/pull/596.diff","patch_url":"https://github.com/exhi/hoist-react/pull/596.patch","issue_url":"https://api.github.com/repos/exhi/hoist-react/issues/596","number":596,"state":"closed","locked":false,"title":"Add XH.genId(), update LocalStore ID generation + validation","user":{"login":"amcclain","id":225806,"node_id":"MDQ6VXNlcjIyNTgwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/225806?v=4","gravatar_id":"","url":"https://api.github.com/users/amcclain","html_url":"https://github.com/amcclain","followers_url":"https://api.github.com/users/amcclain/followers","following_url":"https://api.github.com/users/amcclain/following{/other_user}","gists_url":"https://api.github.com/users/amcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/amcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcclain/subscriptions","organizations_url":"https://api.github.com/users/amcclain/orgs","repos_url":"https://api.github.com/users/amcclain/repos","events_url":"https://api.github.com/users/amcclain/events{/privacy}","received_events_url":"https://api.github.com/users/amcclain/received_events","type":"User","site_admin":false},"body":"+ Add XH.genId() to return locally-generated unique ID.\r\n+ LocalStore uses XH.genId() if raw records do not contain an ID property.\r\n+ LocalStore replaces null record IDs with generated IDs (not just undefined).\r\n+ LocalStore warns if records contain non-unique IDs.\r\n+ Minor re-org of some XH method blocks and comments.\r\n+ Fixes #590 ","created_at":"2018-09-06T23:55:58Z","updated_at":"2018-09-07T09:29:29Z","closed_at":"2018-09-07T01:44:20Z","merged_at":"2018-09-07T01:44:20Z","merge_commit_sha":"e2a9259b2c4f535c09dae16eb7320e520eed73bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lbwexler","id":2307561,"node_id":"MDQ6VXNlcjIzMDc1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2307561?v=4","gravatar_id":"","url":"https://api.github.com/users/lbwexler","html_url":"https://github.com/lbwexler","followers_url":"https://api.github.com/users/lbwexler/followers","following_url":"https://api.github.com/users/lbwexler/following{/other_user}","gists_url":"https://api.github.com/users/lbwexler/gists{/gist_id}","starred_url":"https://api.github.com/users/lbwexler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbwexler/subscriptions","organizations_url":"https://api.github.com/users/lbwexler/orgs","repos_url":"https://api.github.com/users/lbwexler/repos","events_url":"https://api.github.com/users/lbwexler/events{/privacy}","received_events_url":"https://api.github.com/users/lbwexler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exhi/hoist-react/pulls/596/commits","review_comments_url":"https://api.github.com/repos/exhi/hoist-react/pulls/596/comments","review_comment_url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exhi/hoist-react/issues/596/comments","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/b9e618c5ef3f57c69f544d374cbe7b04efa6cb74","head":{"label":"exhi:saferRecordIds","ref":"saferRecordIds","sha":"b9e618c5ef3f57c69f544d374cbe7b04efa6cb74","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-09-07T01:44:22Z","pushed_at":"2018-09-07T03:17:16Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":1971,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":36,"watchers":3,"default_branch":"develop"}},"base":{"label":"exhi:develop","ref":"develop","sha":"bf27a5e8089d0032110297fd6d3e13b2a507f70f","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-09-07T01:44:22Z","pushed_at":"2018-09-07T03:17:16Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":1971,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":36,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/596"},"html":{"href":"https://github.com/exhi/hoist-react/pull/596"},"issue":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/596"},"comments":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/exhi/hoist-react/statuses/b9e618c5ef3f57c69f544d374cbe7b04efa6cb74"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TomTirapani"}}