{"action":"closed","issue":{"url":"https://api.github.com/repos/deltachat/deltachat-core/issues/386","repository_url":"https://api.github.com/repos/deltachat/deltachat-core","labels_url":"https://api.github.com/repos/deltachat/deltachat-core/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/deltachat/deltachat-core/issues/386/comments","events_url":"https://api.github.com/repos/deltachat/deltachat-core/issues/386/events","html_url":"https://github.com/deltachat/deltachat-core/issues/386","id":369807743,"node_id":"MDU6SXNzdWUzNjk4MDc3NDM=","number":386,"title":"log excerpt needed in dc_get_info()?","user":{"login":"r10s","id":9800740,"node_id":"MDQ6VXNlcjk4MDA3NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800740?v=4","gravatar_id":"","url":"https://api.github.com/users/r10s","html_url":"https://github.com/r10s","followers_url":"https://api.github.com/users/r10s/followers","following_url":"https://api.github.com/users/r10s/following{/other_user}","gists_url":"https://api.github.com/users/r10s/gists{/gist_id}","starred_url":"https://api.github.com/users/r10s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r10s/subscriptions","organizations_url":"https://api.github.com/users/r10s/orgs","repos_url":"https://api.github.com/users/r10s/repos","events_url":"https://api.github.com/users/r10s/events{/privacy}","received_events_url":"https://api.github.com/users/r10s/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-13T14:35:21Z","updated_at":"2018-10-15T09:59:47Z","closed_at":"2018-10-15T09:59:47Z","author_association":"MEMBER","body":"wondering if the log excerpt is needed in dc_get_info().\r\n\r\ncurrently, i am adapting the debug-log-view on android, and the new code offers a much better approach by using the system log-lines (that include the delta ones).\r\n\r\nas i would like to prepend the info from dc_get_info() to the debug-view, i would need a flag or so that removes the log lines.\r\n\r\nhowever, i am not sure that the 200 last log lines are needed at all in dc_get_info(), esp as they exclude all log stuff that is not done in the core.\r\nmight be that also for node, there are better methods. for cli-bots, i think it is also not needed as the log is just always printed and available as the normal shell-buffer.\r\n\r\nthe code to collect them is not that complex, however, includes some locking and so on, so if it is not really needed, maybe we should get rid of it.\r\n\r\n@ralphtheninja @hpk42 what do you think?"}}
{"actor":{"display_login":"hpk42"}}