{"action":"created","comment":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/comments/195409426","pull_request_review_id":128772733,"id":195409426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQwOTQyNg==","diff_hunk":"@@ -33,20 +33,33 @@ export default class LevelController extends EventHandler {\n     }\n   }\n \n-  startLoad () {\n+  \n+  startLoad() {\n     let levels = this._levels;\n \n     this.canload = true;\n     this.levelRetryCount = 0;\n-\n+    var timePassed = (performance.now() - this.stoppedLoadingAtTime) / 1000;","path":"src/controller/level-controller.js","position":12,"original_position":12,"commit_id":"b1cdad632bf170741c619073b49449b1da7a7a6e","original_commit_id":"b1cdad632bf170741c619073b49449b1da7a7a6e","user":{"login":"tchakabam","id":1480052,"node_id":"MDQ6VXNlcjE0ODAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"body":"use `const` here or `let` if writtable","created_at":"2018-06-14T12:52:05Z","updated_at":"2018-06-14T12:56:48Z","html_url":"https://github.com/video-dev/hls.js/pull/1740#discussion_r195409426","pull_request_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1740","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/comments/195409426"},"html":{"href":"https://github.com/video-dev/hls.js/pull/1740#discussion_r195409426"},"pull_request":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1740"}}},"pull_request":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/1740","id":191460806,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDYwODA2","html_url":"https://github.com/video-dev/hls.js/pull/1740","diff_url":"https://github.com/video-dev/hls.js/pull/1740.diff","patch_url":"https://github.com/video-dev/hls.js/pull/1740.patch","issue_url":"https://api.github.com/repos/video-dev/hls.js/issues/1740","number":1740,"state":"open","locked":false,"title":"Suggested fix for issue#1725 - startLoad for live playbakcs, halts pl…","user":{"login":"shaibam","id":1324331,"node_id":"MDQ6VXNlcjEzMjQzMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1324331?v=4","gravatar_id":"","url":"https://api.github.com/users/shaibam","html_url":"https://github.com/shaibam","followers_url":"https://api.github.com/users/shaibam/followers","following_url":"https://api.github.com/users/shaibam/following{/other_user}","gists_url":"https://api.github.com/users/shaibam/gists{/gist_id}","starred_url":"https://api.github.com/users/shaibam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaibam/subscriptions","organizations_url":"https://api.github.com/users/shaibam/orgs","repos_url":"https://api.github.com/users/shaibam/repos","events_url":"https://api.github.com/users/shaibam/events{/privacy}","received_events_url":"https://api.github.com/users/shaibam/received_events","type":"User","site_admin":false},"body":"Suggested fix for issue#1725 - startLoad for live playbacks, halts playback or skips fragments\r\n\r\n### This PR will...\r\nSuggest a fix for issue #1725.\r\n### Why is this Pull Request needed?\r\nOn live hls playback, there are several issues that appear when pausing and resuming live playback using stopLoad and startLoad.\r\nscenario\r\n1. startLoad(with empty arguments), halts the playback.\r\n* pause a live playback.\r\n* call stopLoad().\r\n*, wait for at least the duration of a single fragment (but not for longer than the DVR's duration).\r\n* call startLoad(without time argument).\r\n* resume playback.\r\n* result: when the video will reach its load buffer, it will freeze.\r\n2.startLoad(with currentTime to load from), halts the playback.\r\n* pause a live playback.\r\n* call stopLoad().\r\n*, wait for at least the duration of a single fragment (but not for longer than the DVR's duration).\r\n* call startLoad(without time argument).\r\n* resume playback.\r\n* result: when the video will reach its load buffer, it will skip the next .ts file's enen though they are available in the m3u8 file.\r\n### Are there any points in the code the reviewer needs to double check?\r\nthe change was done on level-controller.js in the startLoad and stopLoad functions.\r\n### Resolves issues:\r\nPlease test, \r\n*both short DVR streams and long DVR streams\r\n*call startLoad with and without 'time' argument. \r\n*a resume playback after the current paused time is earlier than available in the DVR range.\r\n### Checklist\r\n\r\n- [x] changes have been done against master branch, and PR does not conflict\r\n- [x] no commits have been done in dist folder (we will take care of updating it)\r\n- [x] new unit / functional tests have been added (whenever applicable)\r\n- [x] API or design changes are documented in API.md\r\n","created_at":"2018-05-30T13:52:29Z","updated_at":"2018-06-14T12:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d54252792f8f52023f6e3751d93a6a605ec6b4d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1740/commits","review_comments_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1740/comments","review_comment_url":"https://api.github.com/repos/video-dev/hls.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/video-dev/hls.js/issues/1740/comments","statuses_url":"https://api.github.com/repos/video-dev/hls.js/statuses/b1cdad632bf170741c619073b49449b1da7a7a6e","head":{"label":"shaibam:1725","ref":"1725","sha":"b1cdad632bf170741c619073b49449b1da7a7a6e","user":{"login":"shaibam","id":1324331,"node_id":"MDQ6VXNlcjEzMjQzMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1324331?v=4","gravatar_id":"","url":"https://api.github.com/users/shaibam","html_url":"https://github.com/shaibam","followers_url":"https://api.github.com/users/shaibam/followers","following_url":"https://api.github.com/users/shaibam/following{/other_user}","gists_url":"https://api.github.com/users/shaibam/gists{/gist_id}","starred_url":"https://api.github.com/users/shaibam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaibam/subscriptions","organizations_url":"https://api.github.com/users/shaibam/orgs","repos_url":"https://api.github.com/users/shaibam/repos","events_url":"https://api.github.com/users/shaibam/events{/privacy}","received_events_url":"https://api.github.com/users/shaibam/received_events","type":"User","site_admin":false},"repo":{"id":135442047,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NDIwNDc=","name":"hls.js","full_name":"shaibam/hls.js","owner":{"login":"shaibam","id":1324331,"node_id":"MDQ6VXNlcjEzMjQzMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1324331?v=4","gravatar_id":"","url":"https://api.github.com/users/shaibam","html_url":"https://github.com/shaibam","followers_url":"https://api.github.com/users/shaibam/followers","following_url":"https://api.github.com/users/shaibam/following{/other_user}","gists_url":"https://api.github.com/users/shaibam/gists{/gist_id}","starred_url":"https://api.github.com/users/shaibam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaibam/subscriptions","organizations_url":"https://api.github.com/users/shaibam/orgs","repos_url":"https://api.github.com/users/shaibam/repos","events_url":"https://api.github.com/users/shaibam/events{/privacy}","received_events_url":"https://api.github.com/users/shaibam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shaibam/hls.js","description":"JavaScript HLS client using Media Source Extension","fork":true,"url":"https://api.github.com/repos/shaibam/hls.js","forks_url":"https://api.github.com/repos/shaibam/hls.js/forks","keys_url":"https://api.github.com/repos/shaibam/hls.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaibam/hls.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaibam/hls.js/teams","hooks_url":"https://api.github.com/repos/shaibam/hls.js/hooks","issue_events_url":"https://api.github.com/repos/shaibam/hls.js/issues/events{/number}","events_url":"https://api.github.com/repos/shaibam/hls.js/events","assignees_url":"https://api.github.com/repos/shaibam/hls.js/assignees{/user}","branches_url":"https://api.github.com/repos/shaibam/hls.js/branches{/branch}","tags_url":"https://api.github.com/repos/shaibam/hls.js/tags","blobs_url":"https://api.github.com/repos/shaibam/hls.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaibam/hls.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaibam/hls.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaibam/hls.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaibam/hls.js/statuses/{sha}","languages_url":"https://api.github.com/repos/shaibam/hls.js/languages","stargazers_url":"https://api.github.com/repos/shaibam/hls.js/stargazers","contributors_url":"https://api.github.com/repos/shaibam/hls.js/contributors","subscribers_url":"https://api.github.com/repos/shaibam/hls.js/subscribers","subscription_url":"https://api.github.com/repos/shaibam/hls.js/subscription","commits_url":"https://api.github.com/repos/shaibam/hls.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaibam/hls.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaibam/hls.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaibam/hls.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaibam/hls.js/contents/{+path}","compare_url":"https://api.github.com/repos/shaibam/hls.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaibam/hls.js/merges","archive_url":"https://api.github.com/repos/shaibam/hls.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaibam/hls.js/downloads","issues_url":"https://api.github.com/repos/shaibam/hls.js/issues{/number}","pulls_url":"https://api.github.com/repos/shaibam/hls.js/pulls{/number}","milestones_url":"https://api.github.com/repos/shaibam/hls.js/milestones{/number}","notifications_url":"https://api.github.com/repos/shaibam/hls.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaibam/hls.js/labels{/name}","releases_url":"https://api.github.com/repos/shaibam/hls.js/releases{/id}","deployments_url":"https://api.github.com/repos/shaibam/hls.js/deployments","created_at":"2018-05-30T12:50:14Z","updated_at":"2018-05-30T12:50:19Z","pushed_at":"2018-05-31T12:03:10Z","git_url":"git://github.com/shaibam/hls.js.git","ssh_url":"git@github.com:shaibam/hls.js.git","clone_url":"https://github.com/shaibam/hls.js.git","svn_url":"https://github.com/shaibam/hls.js","homepage":"http://video-dev.github.io/hls.js/demo","size":64852,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"video-dev:master","ref":"master","sha":"93b534807fe7c8d4962ba5effa3eda7ba5ba925e","user":{"login":"video-dev","id":25984302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTg0MzAy","avatar_url":"https://avatars0.githubusercontent.com/u/25984302?v=4","gravatar_id":"","url":"https://api.github.com/users/video-dev","html_url":"https://github.com/video-dev","followers_url":"https://api.github.com/users/video-dev/followers","following_url":"https://api.github.com/users/video-dev/following{/other_user}","gists_url":"https://api.github.com/users/video-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/video-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/video-dev/subscriptions","organizations_url":"https://api.github.com/users/video-dev/orgs","repos_url":"https://api.github.com/users/video-dev/repos","events_url":"https://api.github.com/users/video-dev/events{/privacy}","received_events_url":"https://api.github.com/users/video-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":30064588,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA2NDU4OA==","name":"hls.js","full_name":"video-dev/hls.js","owner":{"login":"video-dev","id":25984302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1OTg0MzAy","avatar_url":"https://avatars0.githubusercontent.com/u/25984302?v=4","gravatar_id":"","url":"https://api.github.com/users/video-dev","html_url":"https://github.com/video-dev","followers_url":"https://api.github.com/users/video-dev/followers","following_url":"https://api.github.com/users/video-dev/following{/other_user}","gists_url":"https://api.github.com/users/video-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/video-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/video-dev/subscriptions","organizations_url":"https://api.github.com/users/video-dev/orgs","repos_url":"https://api.github.com/users/video-dev/repos","events_url":"https://api.github.com/users/video-dev/events{/privacy}","received_events_url":"https://api.github.com/users/video-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/video-dev/hls.js","description":"JavaScript HLS client using Media Source Extension","fork":false,"url":"https://api.github.com/repos/video-dev/hls.js","forks_url":"https://api.github.com/repos/video-dev/hls.js/forks","keys_url":"https://api.github.com/repos/video-dev/hls.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/video-dev/hls.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/video-dev/hls.js/teams","hooks_url":"https://api.github.com/repos/video-dev/hls.js/hooks","issue_events_url":"https://api.github.com/repos/video-dev/hls.js/issues/events{/number}","events_url":"https://api.github.com/repos/video-dev/hls.js/events","assignees_url":"https://api.github.com/repos/video-dev/hls.js/assignees{/user}","branches_url":"https://api.github.com/repos/video-dev/hls.js/branches{/branch}","tags_url":"https://api.github.com/repos/video-dev/hls.js/tags","blobs_url":"https://api.github.com/repos/video-dev/hls.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/video-dev/hls.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/video-dev/hls.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/video-dev/hls.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/video-dev/hls.js/statuses/{sha}","languages_url":"https://api.github.com/repos/video-dev/hls.js/languages","stargazers_url":"https://api.github.com/repos/video-dev/hls.js/stargazers","contributors_url":"https://api.github.com/repos/video-dev/hls.js/contributors","subscribers_url":"https://api.github.com/repos/video-dev/hls.js/subscribers","subscription_url":"https://api.github.com/repos/video-dev/hls.js/subscription","commits_url":"https://api.github.com/repos/video-dev/hls.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/video-dev/hls.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/video-dev/hls.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/video-dev/hls.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/video-dev/hls.js/contents/{+path}","compare_url":"https://api.github.com/repos/video-dev/hls.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/video-dev/hls.js/merges","archive_url":"https://api.github.com/repos/video-dev/hls.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/video-dev/hls.js/downloads","issues_url":"https://api.github.com/repos/video-dev/hls.js/issues{/number}","pulls_url":"https://api.github.com/repos/video-dev/hls.js/pulls{/number}","milestones_url":"https://api.github.com/repos/video-dev/hls.js/milestones{/number}","notifications_url":"https://api.github.com/repos/video-dev/hls.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/video-dev/hls.js/labels{/name}","releases_url":"https://api.github.com/repos/video-dev/hls.js/releases{/id}","deployments_url":"https://api.github.com/repos/video-dev/hls.js/deployments","created_at":"2015-01-30T09:06:27Z","updated_at":"2018-06-14T11:08:49Z","pushed_at":"2018-06-14T12:07:06Z","git_url":"git://github.com/video-dev/hls.js.git","ssh_url":"git@github.com:video-dev/hls.js.git","clone_url":"https://github.com/video-dev/hls.js.git","svn_url":"https://github.com/video-dev/hls.js","homepage":"http://video-dev.github.io/hls.js/demo","size":72284,"stargazers_count":4192,"watchers_count":4192,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":977,"mirror_url":null,"archived":false,"open_issues_count":469,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":977,"open_issues":469,"watchers":4192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1740"},"html":{"href":"https://github.com/video-dev/hls.js/pull/1740"},"issue":{"href":"https://api.github.com/repos/video-dev/hls.js/issues/1740"},"comments":{"href":"https://api.github.com/repos/video-dev/hls.js/issues/1740/comments"},"review_comments":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1740/comments"},"review_comment":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1740/commits"},"statuses":{"href":"https://api.github.com/repos/video-dev/hls.js/statuses/b1cdad632bf170741c619073b49449b1da7a7a6e"}},"author_association":"NONE"}}
{"actor":{"display_login":"tchakabam"}}