{"action":"created","comment":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/240669042","pull_request_review_id":183750378,"id":240669042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDY2OTA0Mg==","diff_hunk":"@@ -3,26 +3,37 @@ import { connect } from 'react-redux'\n import styled from 'styled-components'\n import UnlockPropTypes from '../../../propTypes'\n import { expirationAsDate } from '../../../utils/durations'\n+import Pagination from '../../interface/pagination/Pagination'\n \n // TODO add pagination\n export function KeyList({ keys }) {\n+  const renderItems = items => {\n+    return items.map(item => {\n+      return (\n+        <Row key={item.id}>\n+          <Data>{item.transaction}</Data>\n+          <Cell>{expirationAsDate(item.expiration)}</Cell>\n+          <Data>{item.key}</Data>","path":"unlock-app/src/components/creator/lock/KeyList.js","position":14,"original_position":14,"commit_id":"bef85170a407b15d492696b0d676417bb4e3c4b4","original_commit_id":"bef85170a407b15d492696b0d676417bb4e3c4b4","user":{"login":"julien51","id":17735,"node_id":"MDQ6VXNlcjE3NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/17735?v=4","gravatar_id":"","url":"https://api.github.com/users/julien51","html_url":"https://github.com/julien51","followers_url":"https://api.github.com/users/julien51/followers","following_url":"https://api.github.com/users/julien51/following{/other_user}","gists_url":"https://api.github.com/users/julien51/gists{/gist_id}","starred_url":"https://api.github.com/users/julien51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julien51/subscriptions","organizations_url":"https://api.github.com/users/julien51/orgs","repos_url":"https://api.github.com/users/julien51/repos","events_url":"https://api.github.com/users/julien51/events{/privacy}","received_events_url":"https://api.github.com/users/julien51/received_events","type":"User","site_admin":false},"body":"that would be `item.data`. Also do you mind actually renaming the `item` variable into `key` as it is more explicit (or `lockKey` since `key` is also used by jsx)","created_at":"2018-12-11T15:52:51Z","updated_at":"2018-12-11T16:00:01Z","html_url":"https://github.com/unlock-protocol/unlock/pull/694#discussion_r240669042","pull_request_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/240669042"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/694#discussion_r240669042"},"pull_request":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694","id":237585183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTg1MTgz","html_url":"https://github.com/unlock-protocol/unlock/pull/694","diff_url":"https://github.com/unlock-protocol/unlock/pull/694.diff","patch_url":"https://github.com/unlock-protocol/unlock/pull/694.patch","issue_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/694","number":694,"state":"open","locked":false,"title":"add pagination for keys in each lock","user":{"login":"wawhal","id":27274869,"node_id":"MDQ6VXNlcjI3Mjc0ODY5","avatar_url":"https://avatars1.githubusercontent.com/u/27274869?v=4","gravatar_id":"","url":"https://api.github.com/users/wawhal","html_url":"https://github.com/wawhal","followers_url":"https://api.github.com/users/wawhal/followers","following_url":"https://api.github.com/users/wawhal/following{/other_user}","gists_url":"https://api.github.com/users/wawhal/gists{/gist_id}","starred_url":"https://api.github.com/users/wawhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wawhal/subscriptions","organizations_url":"https://api.github.com/users/wawhal/orgs","repos_url":"https://api.github.com/users/wawhal/repos","events_url":"https://api.github.com/users/wawhal/events{/privacy}","received_events_url":"https://api.github.com/users/wawhal/received_events","type":"User","site_admin":false},"body":"## Proposed Changes\r\n\r\nAdding pagination for the list of keys for each lock\r\n- 10 items per page\r\n- Can go to previous and next page\r\n- Can jump to first page or last page\r\n- Can jump to a page directly\r\n- This pagination component can be reused for pagination purposes\r\n\r\nThings that I had proposed but I could not see them fitting in the design provided in the issue:\r\n- Giving ability to set the number of items per page\r\n\r\nI am new to this crypto world and don't understand much of these contracts and stuff. I am a React developer and I worked on the pagination bit by using dummy data.\r\n\r\nLet me know if there is anything you would like to change :-) ","created_at":"2018-12-11T08:13:16Z","updated_at":"2018-12-11T16:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9063cd85e1f81076697f36b2bd85db491af86e8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694/commits","review_comments_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694/comments","review_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/694/comments","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/bef85170a407b15d492696b0d676417bb4e3c4b4","head":{"label":"wawhal:pagination","ref":"pagination","sha":"bef85170a407b15d492696b0d676417bb4e3c4b4","user":{"login":"wawhal","id":27274869,"node_id":"MDQ6VXNlcjI3Mjc0ODY5","avatar_url":"https://avatars1.githubusercontent.com/u/27274869?v=4","gravatar_id":"","url":"https://api.github.com/users/wawhal","html_url":"https://github.com/wawhal","followers_url":"https://api.github.com/users/wawhal/followers","following_url":"https://api.github.com/users/wawhal/following{/other_user}","gists_url":"https://api.github.com/users/wawhal/gists{/gist_id}","starred_url":"https://api.github.com/users/wawhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wawhal/subscriptions","organizations_url":"https://api.github.com/users/wawhal/orgs","repos_url":"https://api.github.com/users/wawhal/repos","events_url":"https://api.github.com/users/wawhal/events{/privacy}","received_events_url":"https://api.github.com/users/wawhal/received_events","type":"User","site_admin":false},"repo":{"id":161297686,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyOTc2ODY=","name":"unlock","full_name":"wawhal/unlock","private":false,"owner":{"login":"wawhal","id":27274869,"node_id":"MDQ6VXNlcjI3Mjc0ODY5","avatar_url":"https://avatars1.githubusercontent.com/u/27274869?v=4","gravatar_id":"","url":"https://api.github.com/users/wawhal","html_url":"https://github.com/wawhal","followers_url":"https://api.github.com/users/wawhal/followers","following_url":"https://api.github.com/users/wawhal/following{/other_user}","gists_url":"https://api.github.com/users/wawhal/gists{/gist_id}","starred_url":"https://api.github.com/users/wawhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wawhal/subscriptions","organizations_url":"https://api.github.com/users/wawhal/orgs","repos_url":"https://api.github.com/users/wawhal/repos","events_url":"https://api.github.com/users/wawhal/events{/privacy}","received_events_url":"https://api.github.com/users/wawhal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wawhal/unlock","description":"Unlock is the web's new business model","fork":true,"url":"https://api.github.com/repos/wawhal/unlock","forks_url":"https://api.github.com/repos/wawhal/unlock/forks","keys_url":"https://api.github.com/repos/wawhal/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wawhal/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wawhal/unlock/teams","hooks_url":"https://api.github.com/repos/wawhal/unlock/hooks","issue_events_url":"https://api.github.com/repos/wawhal/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/wawhal/unlock/events","assignees_url":"https://api.github.com/repos/wawhal/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/wawhal/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/wawhal/unlock/tags","blobs_url":"https://api.github.com/repos/wawhal/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wawhal/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wawhal/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/wawhal/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wawhal/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/wawhal/unlock/languages","stargazers_url":"https://api.github.com/repos/wawhal/unlock/stargazers","contributors_url":"https://api.github.com/repos/wawhal/unlock/contributors","subscribers_url":"https://api.github.com/repos/wawhal/unlock/subscribers","subscription_url":"https://api.github.com/repos/wawhal/unlock/subscription","commits_url":"https://api.github.com/repos/wawhal/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/wawhal/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/wawhal/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/wawhal/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/wawhal/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/wawhal/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wawhal/unlock/merges","archive_url":"https://api.github.com/repos/wawhal/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wawhal/unlock/downloads","issues_url":"https://api.github.com/repos/wawhal/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/wawhal/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/wawhal/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/wawhal/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wawhal/unlock/labels{/name}","releases_url":"https://api.github.com/repos/wawhal/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/wawhal/unlock/deployments","created_at":"2018-12-11T07:55:01Z","updated_at":"2018-12-11T07:55:04Z","pushed_at":"2018-12-11T09:01:53Z","git_url":"git://github.com/wawhal/unlock.git","ssh_url":"git@github.com:wawhal/unlock.git","clone_url":"https://github.com/wawhal/unlock.git","svn_url":"https://github.com/wawhal/unlock","homepage":"https://unlock-protocol.com","size":10428,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unlock-protocol:master","ref":"master","sha":"4b24abf2a0bb26ef20fde5b0f92dafaf38ec1e74","user":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112683472,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2ODM0NzI=","name":"unlock","full_name":"unlock-protocol/unlock","private":false,"owner":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unlock-protocol/unlock","description":"Unlock is the web's new business model","fork":false,"url":"https://api.github.com/repos/unlock-protocol/unlock","forks_url":"https://api.github.com/repos/unlock-protocol/unlock/forks","keys_url":"https://api.github.com/repos/unlock-protocol/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unlock-protocol/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unlock-protocol/unlock/teams","hooks_url":"https://api.github.com/repos/unlock-protocol/unlock/hooks","issue_events_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/unlock-protocol/unlock/events","assignees_url":"https://api.github.com/repos/unlock-protocol/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/unlock-protocol/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/unlock-protocol/unlock/tags","blobs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unlock-protocol/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/unlock-protocol/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/unlock-protocol/unlock/languages","stargazers_url":"https://api.github.com/repos/unlock-protocol/unlock/stargazers","contributors_url":"https://api.github.com/repos/unlock-protocol/unlock/contributors","subscribers_url":"https://api.github.com/repos/unlock-protocol/unlock/subscribers","subscription_url":"https://api.github.com/repos/unlock-protocol/unlock/subscription","commits_url":"https://api.github.com/repos/unlock-protocol/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/unlock-protocol/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/unlock-protocol/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/unlock-protocol/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unlock-protocol/unlock/merges","archive_url":"https://api.github.com/repos/unlock-protocol/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unlock-protocol/unlock/downloads","issues_url":"https://api.github.com/repos/unlock-protocol/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/unlock-protocol/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/unlock-protocol/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unlock-protocol/unlock/labels{/name}","releases_url":"https://api.github.com/repos/unlock-protocol/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/unlock-protocol/unlock/deployments","created_at":"2017-12-01T02:08:01Z","updated_at":"2018-12-11T00:29:52Z","pushed_at":"2018-12-11T15:59:12Z","git_url":"git://github.com/unlock-protocol/unlock.git","ssh_url":"git@github.com:unlock-protocol/unlock.git","clone_url":"https://github.com/unlock-protocol/unlock.git","svn_url":"https://github.com/unlock-protocol/unlock","homepage":"https://unlock-protocol.com","size":10414,"stargazers_count":64,"watchers_count":64,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":48,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/694"},"issue":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/694"},"comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/unlock-protocol/unlock/statuses/bef85170a407b15d492696b0d676417bb4e3c4b4"}},"author_association":"NONE"}}
{"actor":{"display_login":"julien51"}}