{"action":"opened","number":8616,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/8616","id":216693214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjkzMjE0","html_url":"https://github.com/playframework/playframework/pull/8616","diff_url":"https://github.com/playframework/playframework/pull/8616.diff","patch_url":"https://github.com/playframework/playframework/pull/8616.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/8616","number":8616,"state":"open","locked":false,"title":"Cleanup JPA api so we can remove Http.Context","user":{"login":"mkurz","id":644927,"node_id":"MDQ6VXNlcjY0NDkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/644927?v=4","gravatar_id":"","url":"https://api.github.com/users/mkurz","html_url":"https://github.com/mkurz","followers_url":"https://api.github.com/users/mkurz/followers","following_url":"https://api.github.com/users/mkurz/following{/other_user}","gists_url":"https://api.github.com/users/mkurz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurz/subscriptions","organizations_url":"https://api.github.com/users/mkurz/orgs","repos_url":"https://api.github.com/users/mkurz/repos","events_url":"https://api.github.com/users/mkurz/events{/privacy}","received_events_url":"https://api.github.com/users/mkurz/received_events","type":"User","site_admin":false},"body":"Reviewing per commit should be easiest.\r\n\r\nThe class `play.db.jpa.JPA` was deprecated in 2.6 already, lets remove it.\r\nI deprecated more methods which relied on the `JPAEntityManagerContext` ThreadLocal (so we can remove that in future as well). In future `JPAApi` only has `withTransaction(...)` left with `Function`s or `Consumer`s which always provide the `EntityManager`.\r\n`@Transactional` should have been deprecated in 2.6 already - it was removed from the docs and is now replaced by injecting a `JPAApi`.","created_at":"2018-09-19T16:00:09Z","updated_at":"2018-09-19T16:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/playframework/playframework/milestones/56","html_url":"https://github.com/playframework/playframework/milestone/56","labels_url":"https://api.github.com/repos/playframework/playframework/milestones/56/labels","id":2599231,"node_id":"MDk6TWlsZXN0b25lMjU5OTIzMQ==","number":56,"title":"Play 2.7.0","description":"","creator":{"login":"gmethvin","id":171663,"node_id":"MDQ6VXNlcjE3MTY2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/171663?v=4","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":18,"state":"open","created_at":"2017-06-22T19:55:39Z","updated_at":"2018-09-19T16:00:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/8616/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/8616/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/8616/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/2a03f228f22471b811cb89a54a27ad98dce09228","head":{"label":"mkurz:deprecateJPAstuff","ref":"deprecateJPAstuff","sha":"2a03f228f22471b811cb89a54a27ad98dce09228","user":{"login":"mkurz","id":644927,"node_id":"MDQ6VXNlcjY0NDkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/644927?v=4","gravatar_id":"","url":"https://api.github.com/users/mkurz","html_url":"https://github.com/mkurz","followers_url":"https://api.github.com/users/mkurz/followers","following_url":"https://api.github.com/users/mkurz/following{/other_user}","gists_url":"https://api.github.com/users/mkurz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurz/subscriptions","organizations_url":"https://api.github.com/users/mkurz/orgs","repos_url":"https://api.github.com/users/mkurz/repos","events_url":"https://api.github.com/users/mkurz/events{/privacy}","received_events_url":"https://api.github.com/users/mkurz/received_events","type":"User","site_admin":false},"repo":{"id":17720374,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcyMDM3NA==","name":"playframework","full_name":"mkurz/playframework","private":false,"owner":{"login":"mkurz","id":644927,"node_id":"MDQ6VXNlcjY0NDkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/644927?v=4","gravatar_id":"","url":"https://api.github.com/users/mkurz","html_url":"https://github.com/mkurz","followers_url":"https://api.github.com/users/mkurz/followers","following_url":"https://api.github.com/users/mkurz/following{/other_user}","gists_url":"https://api.github.com/users/mkurz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurz/subscriptions","organizations_url":"https://api.github.com/users/mkurz/orgs","repos_url":"https://api.github.com/users/mkurz/repos","events_url":"https://api.github.com/users/mkurz/events{/privacy}","received_events_url":"https://api.github.com/users/mkurz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mkurz/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/mkurz/playframework","forks_url":"https://api.github.com/repos/mkurz/playframework/forks","keys_url":"https://api.github.com/repos/mkurz/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkurz/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkurz/playframework/teams","hooks_url":"https://api.github.com/repos/mkurz/playframework/hooks","issue_events_url":"https://api.github.com/repos/mkurz/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/mkurz/playframework/events","assignees_url":"https://api.github.com/repos/mkurz/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/mkurz/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/mkurz/playframework/tags","blobs_url":"https://api.github.com/repos/mkurz/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkurz/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkurz/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkurz/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkurz/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/mkurz/playframework/languages","stargazers_url":"https://api.github.com/repos/mkurz/playframework/stargazers","contributors_url":"https://api.github.com/repos/mkurz/playframework/contributors","subscribers_url":"https://api.github.com/repos/mkurz/playframework/subscribers","subscription_url":"https://api.github.com/repos/mkurz/playframework/subscription","commits_url":"https://api.github.com/repos/mkurz/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkurz/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkurz/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkurz/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkurz/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/mkurz/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkurz/playframework/merges","archive_url":"https://api.github.com/repos/mkurz/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkurz/playframework/downloads","issues_url":"https://api.github.com/repos/mkurz/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/mkurz/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/mkurz/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/mkurz/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkurz/playframework/labels{/name}","releases_url":"https://api.github.com/repos/mkurz/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/mkurz/playframework/deployments","created_at":"2014-03-13T17:52:40Z","updated_at":"2016-02-26T09:30:55Z","pushed_at":"2018-09-19T15:50:29Z","git_url":"git://github.com/mkurz/playframework.git","ssh_url":"git@github.com:mkurz/playframework.git","clone_url":"https://github.com/mkurz/playframework.git","svn_url":"https://github.com/mkurz/playframework","homepage":"http://www.playframework.com/","size":88838,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"b8eec82f37b5ade204cd5fe141848c0d1a1dbf5f","user":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"node_id":"MDEwOlJlcG9zaXRvcnkyMzQwNTQ5","name":"playframework","full_name":"playframework/playframework","private":false,"owner":{"login":"playframework","id":319107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTEwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/319107?v=4","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2018-09-19T15:35:56Z","pushed_at":"2018-09-19T15:35:46Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":90163,"stargazers_count":10714,"watchers_count":10714,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3621,"mirror_url":null,"archived":false,"open_issues_count":404,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3621,"open_issues":404,"watchers":10714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8616"},"html":{"href":"https://github.com/playframework/playframework/pull/8616"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/8616"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/8616/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8616/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/8616/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/2a03f228f22471b811cb89a54a27ad98dce09228"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":160,"deletions":112,"changed_files":10}}
{"actor":{"display_login":"mkurz"}}