{"action":"created","comment":{"url":"https://api.github.com/repos/Igalia/chromium/pulls/comments/226183733","pull_request_review_id":165942842,"id":226183733,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE4MzczMw==","diff_hunk":"@@ -0,0 +1,271 @@\n+// Copyright 2018 The Chromium Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#include \"ui/ozone/platform/x11/x11_display_fetcher_ozone.h\"\n+\n+#include <dlfcn.h>\n+\n+#include \"base/logging.h\"\n+#include \"base/memory/protected_memory_cfi.h\"\n+#include \"ui/base/x/x11_util.h\"\n+#include \"ui/display/display.h\"\n+#include \"ui/display/util/display_util.h\"\n+#include \"ui/display/util/x11/edid_parser_x11.h\"\n+#include \"ui/events/platform/platform_event_source.h\"\n+#include \"ui/gfx/x/x11.h\"\n+#include \"ui/gfx/x/x11_atom_cache.h\"\n+#include \"ui/gfx/x/x11_types.h\"\n+\n+namespace ui {\n+\n+namespace {\n+\n+double GetDeviceScaleFactor() {\n+  float device_scale_factor = 1.0f;\n+  // TODO(jkim) : Get device scale factor using scale factor and resolution like\n+  // 'GtkUi::GetRawDeviceScaleFactor'.\n+  if (display::Display::HasForceDeviceScaleFactor()) {\n+    device_scale_factor = display::Display::GetForcedDeviceScaleFactor();\n+  }","path":"ui/ozone/platform/x11/x11_display_fetcher_ozone.cc","position":54,"original_position":30,"commit_id":"3ce06fa29373e86e66a2a5c203e68f959d3dc7a1","original_commit_id":"3ce06fa29373e86e66a2a5c203e68f959d3dc7a1","user":{"login":"msisov","id":5306904,"node_id":"MDQ6VXNlcjUzMDY5MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5306904?v=4","gravatar_id":"","url":"https://api.github.com/users/msisov","html_url":"https://github.com/msisov","followers_url":"https://api.github.com/users/msisov/followers","following_url":"https://api.github.com/users/msisov/following{/other_user}","gists_url":"https://api.github.com/users/msisov/gists{/gist_id}","starred_url":"https://api.github.com/users/msisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msisov/subscriptions","organizations_url":"https://api.github.com/users/msisov/orgs","repos_url":"https://api.github.com/users/msisov/repos","events_url":"https://api.github.com/users/msisov/events{/privacy}","received_events_url":"https://api.github.com/users/msisov/received_events","type":"User","site_admin":false},"body":"remove brackets?","created_at":"2018-10-18T06:41:56Z","updated_at":"2018-10-18T06:57:26Z","html_url":"https://github.com/Igalia/chromium/pull/499#discussion_r226183733","pull_request_url":"https://api.github.com/repos/Igalia/chromium/pulls/499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/comments/226183733"},"html":{"href":"https://github.com/Igalia/chromium/pull/499#discussion_r226183733"},"pull_request":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/Igalia/chromium/pulls/499","id":222819260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODE5MjYw","html_url":"https://github.com/Igalia/chromium/pull/499","diff_url":"https://github.com/Igalia/chromium/pull/499.diff","patch_url":"https://github.com/Igalia/chromium/pull/499.patch","issue_url":"https://api.github.com/repos/Igalia/chromium/issues/499","number":499,"state":"open","locked":false,"title":"Ozone wayland dev platform screen x11","user":{"login":"jkim-julie","id":8217284,"node_id":"MDQ6VXNlcjgyMTcyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8217284?v=4","gravatar_id":"","url":"https://api.github.com/users/jkim-julie","html_url":"https://github.com/jkim-julie","followers_url":"https://api.github.com/users/jkim-julie/followers","following_url":"https://api.github.com/users/jkim-julie/following{/other_user}","gists_url":"https://api.github.com/users/jkim-julie/gists{/gist_id}","starred_url":"https://api.github.com/users/jkim-julie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkim-julie/subscriptions","organizations_url":"https://api.github.com/users/jkim-julie/orgs","repos_url":"https://api.github.com/users/jkim-julie/repos","events_url":"https://api.github.com/users/jkim-julie/events{/privacy}","received_events_url":"https://api.github.com/users/jkim-julie/received_events","type":"User","site_admin":false},"body":"It removes X11DisplayManager and NativeDisplayDelegate for Ozone/X11 and adds Platform Screen implementation.","created_at":"2018-10-15T08:21:35Z","updated_at":"2018-10-18T06:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83afbc254cc5b429ee6898442b7bc3af489d061f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Igalia/chromium/pulls/499/commits","review_comments_url":"https://api.github.com/repos/Igalia/chromium/pulls/499/comments","review_comment_url":"https://api.github.com/repos/Igalia/chromium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Igalia/chromium/issues/499/comments","statuses_url":"https://api.github.com/repos/Igalia/chromium/statuses/3ce06fa29373e86e66a2a5c203e68f959d3dc7a1","head":{"label":"jkim-julie:ozone-wayland-dev-platformScreenX11","ref":"ozone-wayland-dev-platformScreenX11","sha":"3ce06fa29373e86e66a2a5c203e68f959d3dc7a1","user":{"login":"jkim-julie","id":8217284,"node_id":"MDQ6VXNlcjgyMTcyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8217284?v=4","gravatar_id":"","url":"https://api.github.com/users/jkim-julie","html_url":"https://github.com/jkim-julie","followers_url":"https://api.github.com/users/jkim-julie/followers","following_url":"https://api.github.com/users/jkim-julie/following{/other_user}","gists_url":"https://api.github.com/users/jkim-julie/gists{/gist_id}","starred_url":"https://api.github.com/users/jkim-julie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkim-julie/subscriptions","organizations_url":"https://api.github.com/users/jkim-julie/orgs","repos_url":"https://api.github.com/users/jkim-julie/repos","events_url":"https://api.github.com/users/jkim-julie/events{/privacy}","received_events_url":"https://api.github.com/users/jkim-julie/received_events","type":"User","site_admin":false},"repo":{"id":123369096,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNjkwOTY=","name":"chromium","full_name":"jkim-julie/chromium","private":false,"owner":{"login":"jkim-julie","id":8217284,"node_id":"MDQ6VXNlcjgyMTcyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8217284?v=4","gravatar_id":"","url":"https://api.github.com/users/jkim-julie","html_url":"https://github.com/jkim-julie","followers_url":"https://api.github.com/users/jkim-julie/followers","following_url":"https://api.github.com/users/jkim-julie/following{/other_user}","gists_url":"https://api.github.com/users/jkim-julie/gists{/gist_id}","starred_url":"https://api.github.com/users/jkim-julie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkim-julie/subscriptions","organizations_url":"https://api.github.com/users/jkim-julie/orgs","repos_url":"https://api.github.com/users/jkim-julie/repos","events_url":"https://api.github.com/users/jkim-julie/events{/privacy}","received_events_url":"https://api.github.com/users/jkim-julie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jkim-julie/chromium","description":"Development branch of Chromium for Wayland","fork":true,"url":"https://api.github.com/repos/jkim-julie/chromium","forks_url":"https://api.github.com/repos/jkim-julie/chromium/forks","keys_url":"https://api.github.com/repos/jkim-julie/chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkim-julie/chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkim-julie/chromium/teams","hooks_url":"https://api.github.com/repos/jkim-julie/chromium/hooks","issue_events_url":"https://api.github.com/repos/jkim-julie/chromium/issues/events{/number}","events_url":"https://api.github.com/repos/jkim-julie/chromium/events","assignees_url":"https://api.github.com/repos/jkim-julie/chromium/assignees{/user}","branches_url":"https://api.github.com/repos/jkim-julie/chromium/branches{/branch}","tags_url":"https://api.github.com/repos/jkim-julie/chromium/tags","blobs_url":"https://api.github.com/repos/jkim-julie/chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkim-julie/chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkim-julie/chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkim-julie/chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkim-julie/chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/jkim-julie/chromium/languages","stargazers_url":"https://api.github.com/repos/jkim-julie/chromium/stargazers","contributors_url":"https://api.github.com/repos/jkim-julie/chromium/contributors","subscribers_url":"https://api.github.com/repos/jkim-julie/chromium/subscribers","subscription_url":"https://api.github.com/repos/jkim-julie/chromium/subscription","commits_url":"https://api.github.com/repos/jkim-julie/chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkim-julie/chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkim-julie/chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkim-julie/chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkim-julie/chromium/contents/{+path}","compare_url":"https://api.github.com/repos/jkim-julie/chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkim-julie/chromium/merges","archive_url":"https://api.github.com/repos/jkim-julie/chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkim-julie/chromium/downloads","issues_url":"https://api.github.com/repos/jkim-julie/chromium/issues{/number}","pulls_url":"https://api.github.com/repos/jkim-julie/chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/jkim-julie/chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/jkim-julie/chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkim-julie/chromium/labels{/name}","releases_url":"https://api.github.com/repos/jkim-julie/chromium/releases{/id}","deployments_url":"https://api.github.com/repos/jkim-julie/chromium/deployments","created_at":"2018-03-01T02:12:21Z","updated_at":"2018-03-01T02:20:17Z","pushed_at":"2018-10-18T03:40:50Z","git_url":"git://github.com/jkim-julie/chromium.git","ssh_url":"git@github.com:jkim-julie/chromium.git","clone_url":"https://github.com/jkim-julie/chromium.git","svn_url":"https://github.com/jkim-julie/chromium","homepage":"https://chromium.googlesource.com/chromium/src.git","size":9770025,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Igalia:ozone-wayland-dev","ref":"ozone-wayland-dev","sha":"2e09546c74ad648572b60049df03a5fd4d902128","user":{"login":"Igalia","id":1576566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzY1NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1576566?v=4","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":85595633,"node_id":"MDEwOlJlcG9zaXRvcnk4NTU5NTYzMw==","name":"chromium","full_name":"Igalia/chromium","private":false,"owner":{"login":"Igalia","id":1576566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzY1NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1576566?v=4","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Igalia/chromium","description":"Development branch of Chromium for Wayland","fork":true,"url":"https://api.github.com/repos/Igalia/chromium","forks_url":"https://api.github.com/repos/Igalia/chromium/forks","keys_url":"https://api.github.com/repos/Igalia/chromium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/chromium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/chromium/teams","hooks_url":"https://api.github.com/repos/Igalia/chromium/hooks","issue_events_url":"https://api.github.com/repos/Igalia/chromium/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/chromium/events","assignees_url":"https://api.github.com/repos/Igalia/chromium/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/chromium/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/chromium/tags","blobs_url":"https://api.github.com/repos/Igalia/chromium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/chromium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/chromium/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/chromium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/chromium/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/chromium/languages","stargazers_url":"https://api.github.com/repos/Igalia/chromium/stargazers","contributors_url":"https://api.github.com/repos/Igalia/chromium/contributors","subscribers_url":"https://api.github.com/repos/Igalia/chromium/subscribers","subscription_url":"https://api.github.com/repos/Igalia/chromium/subscription","commits_url":"https://api.github.com/repos/Igalia/chromium/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/chromium/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/chromium/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/chromium/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/chromium/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/chromium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/chromium/merges","archive_url":"https://api.github.com/repos/Igalia/chromium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/chromium/downloads","issues_url":"https://api.github.com/repos/Igalia/chromium/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/chromium/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/chromium/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/chromium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/chromium/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/chromium/releases{/id}","deployments_url":"https://api.github.com/repos/Igalia/chromium/deployments","created_at":"2017-03-20T15:45:36Z","updated_at":"2018-10-17T13:18:14Z","pushed_at":"2018-10-18T03:40:58Z","git_url":"git://github.com/Igalia/chromium.git","ssh_url":"git@github.com:Igalia/chromium.git","clone_url":"https://github.com/Igalia/chromium.git","svn_url":"https://github.com/Igalia/chromium","homepage":"https://chromium.googlesource.com/chromium/src.git","size":9796227,"stargazers_count":80,"watchers_count":80,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":18,"watchers":80,"default_branch":"ozone-wayland-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/499"},"html":{"href":"https://github.com/Igalia/chromium/pull/499"},"issue":{"href":"https://api.github.com/repos/Igalia/chromium/issues/499"},"comments":{"href":"https://api.github.com/repos/Igalia/chromium/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Igalia/chromium/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/Igalia/chromium/statuses/3ce06fa29373e86e66a2a5c203e68f959d3dc7a1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"msisov"}}