{"action":"created","comment":{"url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/comments/191909921","pull_request_review_id":124577259,"id":191909921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTkwOTkyMQ==","diff_hunk":"@@ -21,6 +21,7 @@\n     \"babel-cli\": \"^6.23.0\",\n     \"kafka-please\": \"^1.0.1\",\n     \"mocha\": \"^3.2.0\",\n+    \"sinon\": \"^1.17.6\",","path":"packages/zipkin-transport-kafka/package.json","position":4,"original_position":4,"commit_id":"5a05f501049d1fb1993635b5eb7dfb3d6a78ac65","original_commit_id":"5a05f501049d1fb1993635b5eb7dfb3d6a78ac65","user":{"login":"john-bui-zocdoc","id":38500138,"node_id":"MDQ6VXNlcjM4NTAwMTM4","avatar_url":"https://avatars2.githubusercontent.com/u/38500138?v=4","gravatar_id":"","url":"https://api.github.com/users/john-bui-zocdoc","html_url":"https://github.com/john-bui-zocdoc","followers_url":"https://api.github.com/users/john-bui-zocdoc/followers","following_url":"https://api.github.com/users/john-bui-zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/john-bui-zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/john-bui-zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-bui-zocdoc/subscriptions","organizations_url":"https://api.github.com/users/john-bui-zocdoc/orgs","repos_url":"https://api.github.com/users/john-bui-zocdoc/repos","events_url":"https://api.github.com/users/john-bui-zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/john-bui-zocdoc/received_events","type":"User","site_admin":false},"body":"Simon is used in other zipkin modules but not this one. Adding it here to use \"calledThrice\".","created_at":"2018-05-30T20:22:12Z","updated_at":"2018-05-30T20:22:12Z","html_url":"https://github.com/Zocdoc/zipkin-js/pull/1#discussion_r191909921","pull_request_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/comments/191909921"},"html":{"href":"https://github.com/Zocdoc/zipkin-js/pull/1#discussion_r191909921"},"pull_request":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1"}},"in_reply_to_id":191904197},"pull_request":{"url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1","id":190054317,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMDU0MzE3","html_url":"https://github.com/Zocdoc/zipkin-js/pull/1","diff_url":"https://github.com/Zocdoc/zipkin-js/pull/1.diff","patch_url":"https://github.com/Zocdoc/zipkin-js/pull/1.patch","issue_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/1","number":1,"state":"open","locked":false,"title":"kafkaLogger unhandled error in promise fix","user":{"login":"chris-smith-zocdoc","id":2537809,"node_id":"MDQ6VXNlcjI1Mzc4MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2537809?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-smith-zocdoc","html_url":"https://github.com/chris-smith-zocdoc","followers_url":"https://api.github.com/users/chris-smith-zocdoc/followers","following_url":"https://api.github.com/users/chris-smith-zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith-zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith-zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith-zocdoc/subscriptions","organizations_url":"https://api.github.com/users/chris-smith-zocdoc/orgs","repos_url":"https://api.github.com/users/chris-smith-zocdoc/repos","events_url":"https://api.github.com/users/chris-smith-zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith-zocdoc/received_events","type":"User","site_admin":false},"body":"Removed promise in KafkaLogger.js and provide access to the producer within logSpan. onError is always bound to the producer (not sure why removeAllListeners is ever called), and can be defined in the constructor.","created_at":"2018-05-23T17:44:32Z","updated_at":"2018-05-30T20:22:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cf176ad03963386e95d891fba54cdbb11fec4ba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/1/comments","statuses_url":"https://api.github.com/repos/Zocdoc/zipkin-js/statuses/5a05f501049d1fb1993635b5eb7dfb3d6a78ac65","head":{"label":"Zocdoc:promise_fix","ref":"promise_fix","sha":"5a05f501049d1fb1993635b5eb7dfb3d6a78ac65","user":{"login":"Zocdoc","id":1420544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjA1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1420544?v=4","gravatar_id":"","url":"https://api.github.com/users/Zocdoc","html_url":"https://github.com/Zocdoc","followers_url":"https://api.github.com/users/Zocdoc/followers","following_url":"https://api.github.com/users/Zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/Zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zocdoc/subscriptions","organizations_url":"https://api.github.com/users/Zocdoc/orgs","repos_url":"https://api.github.com/users/Zocdoc/repos","events_url":"https://api.github.com/users/Zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/Zocdoc/received_events","type":"Organization","site_admin":false},"repo":{"id":134602934,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MDI5MzQ=","name":"zipkin-js","full_name":"Zocdoc/zipkin-js","owner":{"login":"Zocdoc","id":1420544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjA1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1420544?v=4","gravatar_id":"","url":"https://api.github.com/users/Zocdoc","html_url":"https://github.com/Zocdoc","followers_url":"https://api.github.com/users/Zocdoc/followers","following_url":"https://api.github.com/users/Zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/Zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zocdoc/subscriptions","organizations_url":"https://api.github.com/users/Zocdoc/orgs","repos_url":"https://api.github.com/users/Zocdoc/repos","events_url":"https://api.github.com/users/Zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/Zocdoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zocdoc/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":true,"url":"https://api.github.com/repos/Zocdoc/zipkin-js","forks_url":"https://api.github.com/repos/Zocdoc/zipkin-js/forks","keys_url":"https://api.github.com/repos/Zocdoc/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zocdoc/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zocdoc/zipkin-js/teams","hooks_url":"https://api.github.com/repos/Zocdoc/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/Zocdoc/zipkin-js/events","assignees_url":"https://api.github.com/repos/Zocdoc/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/Zocdoc/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/Zocdoc/zipkin-js/tags","blobs_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zocdoc/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Zocdoc/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/Zocdoc/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/Zocdoc/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/Zocdoc/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/Zocdoc/zipkin-js/subscription","commits_url":"https://api.github.com/repos/Zocdoc/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zocdoc/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/Zocdoc/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zocdoc/zipkin-js/merges","archive_url":"https://api.github.com/repos/Zocdoc/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zocdoc/zipkin-js/downloads","issues_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Zocdoc/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Zocdoc/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zocdoc/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/Zocdoc/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/deployments","created_at":"2018-05-23T17:19:10Z","updated_at":"2018-05-23T17:33:11Z","pushed_at":"2018-05-30T19:56:14Z","git_url":"git://github.com/Zocdoc/zipkin-js.git","ssh_url":"git@github.com:Zocdoc/zipkin-js.git","clone_url":"https://github.com/Zocdoc/zipkin-js.git","svn_url":"https://github.com/Zocdoc/zipkin-js","homepage":"","size":567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Zocdoc:master","ref":"master","sha":"d0631fec03ea86199f6d4a6aa283ef37cb39de60","user":{"login":"Zocdoc","id":1420544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjA1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1420544?v=4","gravatar_id":"","url":"https://api.github.com/users/Zocdoc","html_url":"https://github.com/Zocdoc","followers_url":"https://api.github.com/users/Zocdoc/followers","following_url":"https://api.github.com/users/Zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/Zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zocdoc/subscriptions","organizations_url":"https://api.github.com/users/Zocdoc/orgs","repos_url":"https://api.github.com/users/Zocdoc/repos","events_url":"https://api.github.com/users/Zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/Zocdoc/received_events","type":"Organization","site_admin":false},"repo":{"id":134602934,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2MDI5MzQ=","name":"zipkin-js","full_name":"Zocdoc/zipkin-js","owner":{"login":"Zocdoc","id":1420544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjA1NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1420544?v=4","gravatar_id":"","url":"https://api.github.com/users/Zocdoc","html_url":"https://github.com/Zocdoc","followers_url":"https://api.github.com/users/Zocdoc/followers","following_url":"https://api.github.com/users/Zocdoc/following{/other_user}","gists_url":"https://api.github.com/users/Zocdoc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zocdoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zocdoc/subscriptions","organizations_url":"https://api.github.com/users/Zocdoc/orgs","repos_url":"https://api.github.com/users/Zocdoc/repos","events_url":"https://api.github.com/users/Zocdoc/events{/privacy}","received_events_url":"https://api.github.com/users/Zocdoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zocdoc/zipkin-js","description":"Zipkin instrumentation for Node.js and browsers","fork":true,"url":"https://api.github.com/repos/Zocdoc/zipkin-js","forks_url":"https://api.github.com/repos/Zocdoc/zipkin-js/forks","keys_url":"https://api.github.com/repos/Zocdoc/zipkin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zocdoc/zipkin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zocdoc/zipkin-js/teams","hooks_url":"https://api.github.com/repos/Zocdoc/zipkin-js/hooks","issue_events_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/events{/number}","events_url":"https://api.github.com/repos/Zocdoc/zipkin-js/events","assignees_url":"https://api.github.com/repos/Zocdoc/zipkin-js/assignees{/user}","branches_url":"https://api.github.com/repos/Zocdoc/zipkin-js/branches{/branch}","tags_url":"https://api.github.com/repos/Zocdoc/zipkin-js/tags","blobs_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zocdoc/zipkin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Zocdoc/zipkin-js/languages","stargazers_url":"https://api.github.com/repos/Zocdoc/zipkin-js/stargazers","contributors_url":"https://api.github.com/repos/Zocdoc/zipkin-js/contributors","subscribers_url":"https://api.github.com/repos/Zocdoc/zipkin-js/subscribers","subscription_url":"https://api.github.com/repos/Zocdoc/zipkin-js/subscription","commits_url":"https://api.github.com/repos/Zocdoc/zipkin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zocdoc/zipkin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zocdoc/zipkin-js/contents/{+path}","compare_url":"https://api.github.com/repos/Zocdoc/zipkin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zocdoc/zipkin-js/merges","archive_url":"https://api.github.com/repos/Zocdoc/zipkin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zocdoc/zipkin-js/downloads","issues_url":"https://api.github.com/repos/Zocdoc/zipkin-js/issues{/number}","pulls_url":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Zocdoc/zipkin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Zocdoc/zipkin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zocdoc/zipkin-js/labels{/name}","releases_url":"https://api.github.com/repos/Zocdoc/zipkin-js/releases{/id}","deployments_url":"https://api.github.com/repos/Zocdoc/zipkin-js/deployments","created_at":"2018-05-23T17:19:10Z","updated_at":"2018-05-23T17:33:11Z","pushed_at":"2018-05-30T19:56:14Z","git_url":"git://github.com/Zocdoc/zipkin-js.git","ssh_url":"git@github.com:Zocdoc/zipkin-js.git","clone_url":"https://github.com/Zocdoc/zipkin-js.git","svn_url":"https://github.com/Zocdoc/zipkin-js","homepage":"","size":567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1"},"html":{"href":"https://github.com/Zocdoc/zipkin-js/pull/1"},"issue":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/1"},"comments":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Zocdoc/zipkin-js/statuses/5a05f501049d1fb1993635b5eb7dfb3d6a78ac65"}},"author_association":"NONE"}}
{"actor":{"display_login":"john-bui-zocdoc"}}