{"action":"created","issue":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/507","repository_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/507/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/507/comments","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/507/events","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/507","id":345206251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDE2NDMz","number":507,"title":"Fixes #495 : support for 128 bits trace ids.","user":{"login":"hypnoce","id":4430896,"node_id":"MDQ6VXNlcjQ0MzA4OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430896?v=4","gravatar_id":"","url":"https://api.github.com/users/hypnoce","html_url":"https://github.com/hypnoce","followers_url":"https://api.github.com/users/hypnoce/followers","following_url":"https://api.github.com/users/hypnoce/following{/other_user}","gists_url":"https://api.github.com/users/hypnoce/gists{/gist_id}","starred_url":"https://api.github.com/users/hypnoce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypnoce/subscriptions","organizations_url":"https://api.github.com/users/hypnoce/orgs","repos_url":"https://api.github.com/users/hypnoce/repos","events_url":"https://api.github.com/users/hypnoce/events{/privacy}","received_events_url":"https://api.github.com/users/hypnoce/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-27T12:23:37Z","updated_at":"2018-07-27T12:30:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/507","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/507","diff_url":"https://github.com/jaegertracing/jaeger-client-java/pull/507.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-java/pull/507.patch"},"body":"## Which problem is this PR solving?\r\nFixes #495 : support for 128 bits trace ids.\r\n\r\n## Short description of the changes\r\nAdded environment variable JAEGER_TRACEID_128BIT\r\nAdded TraceId and SpanId classes\r\nAdded withTraceId128Bit method to Configuration\r\nAdded withTraceId128Bit method to Tracer.Builder\r\nAdded useTraceId128Bit property to Tracer\r\n\r\nInspired from https://github.com/jaegertracing/jaeger-client-csharp/pull/94"},"comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/comments/408404948","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/507#issuecomment-408404948","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/507","id":408404948,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQwNDk0OA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-27T12:30:33Z","updated_at":"2018-07-27T12:30:33Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=h1) Report\n> Merging [#507](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=desc) into [master](https://codecov.io/gh/jaegertracing/jaeger-client-java/commit/f3e504992d19843245872fdd1c9f0006a3b70b57?src=pr&el=desc) will **decrease** coverage by `0.65%`.\n> The diff coverage is `73.95%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=DytDRhoRJC)](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master     #507      +/-   ##\n============================================\n- Coverage      88.2%   87.55%   -0.66%     \n- Complexity      498      525      +27     \n============================================\n  Files            65       67       +2     \n  Lines          1848     1920      +72     \n  Branches        239      246       +7     \n============================================\n+ Hits           1630     1681      +51     \n- Misses          141      151      +10     \n- Partials         77       88      +11\n```\n\n\n| [Impacted Files](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...ertracing/zipkin/internal/ThriftSpanConverter.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLXppcGtpbi9zcmMvbWFpbi9qYXZhL2lvL2phZWdlcnRyYWNpbmcvemlwa2luL2ludGVybmFsL1RocmlmdFNwYW5Db252ZXJ0ZXIuamF2YQ==) | `85.55% <100%> (ø)` | `21 <0> (ø)` | :arrow_down: |\n| [.../src/main/java/io/jaegertracing/Configuration.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `94.26% <100%> (+0.12%)` | `41 <1> (+2)` | :arrow_up: |\n| [...ertracing/internal/propagation/B3TextMapCodec.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL2ludGVybmFsL3Byb3BhZ2F0aW9uL0IzVGV4dE1hcENvZGVjLmphdmE=) | `87.03% <100%> (+0.49%)` | `19 <4> (ø)` | :arrow_down: |\n| [...n/java/io/jaegertracing/internal/JaegerTracer.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL2ludGVybmFsL0phZWdlclRyYWNlci5qYXZh) | `90.03% <100%> (+0.2%)` | `25 <4> (+1)` | :arrow_up: |\n| [...jaegertracing/zipkin/internal/V2SpanConverter.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLXppcGtpbi9zcmMvbWFpbi9qYXZhL2lvL2phZWdlcnRyYWNpbmcvemlwa2luL2ludGVybmFsL1YyU3BhbkNvbnZlcnRlci5qYXZh) | `87.83% <100%> (ø)` | `21 <0> (ø)` | :arrow_down: |\n| [...c/main/java/io/jaegertracing/internal/TraceId.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL2ludGVybmFsL1RyYWNlSWQuamF2YQ==) | `53.84% <53.84%> (ø)` | `13 <13> (?)` | |\n| [...rc/main/java/io/jaegertracing/internal/SpanId.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL2ludGVybmFsL1NwYW5JZC5qYXZh) | `70% <70%> (ø)` | `10 <10> (?)` | |\n| [...a/io/jaegertracing/internal/JaegerSpanContext.java](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree#diff-amFlZ2VyLWNvcmUvc3JjL21haW4vamF2YS9pby9qYWVnZXJ0cmFjaW5nL2ludGVybmFsL0phZWdlclNwYW5Db250ZXh0LmphdmE=) | `90% <88.88%> (+0.2%)` | `25 <3> (ø)` | :arrow_down: |\n| ... and [1 more](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=footer). Last update [f3e5049...359c6d3](https://codecov.io/gh/jaegertracing/jaeger-client-java/pull/507?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}