{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/node-oracledb/pulls/comments/210803056","pull_request_review_id":147095955,"id":210803056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDgwMzA1Ng==","diff_hunk":"@@ -138,8 +138,9 @@ function getConnection(a1, a2) {\n   var options = {};\n \n   nodbUtil.assert(arguments.length >= 1 && arguments.length <= 2, 'NJS-009');\n-  nodbUtil.assert(typeof getConnectionCb === 'function', 'NJS-006',\n-      arguments.length);\n+  nodbUtil.assert(typeof getConnectionCb === 'function', 'NJS-006', arguments.length);\n+  nodbUtil.assert(self.closing === false, 'NJS-064', self.poolAlias);","path":"lib/pool.js","position":7,"original_position":7,"commit_id":"5ab1c14c9a0ceeb876e642f894b3e3befc606c16","original_commit_id":"5ab1c14c9a0ceeb876e642f894b3e3befc606c16","user":{"login":"cjbj","id":200778,"node_id":"MDQ6VXNlcjIwMDc3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/200778?v=4","gravatar_id":"","url":"https://api.github.com/users/cjbj","html_url":"https://github.com/cjbj","followers_url":"https://api.github.com/users/cjbj/followers","following_url":"https://api.github.com/users/cjbj/following{/other_user}","gists_url":"https://api.github.com/users/cjbj/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbj/subscriptions","organizations_url":"https://api.github.com/users/cjbj/orgs","repos_url":"https://api.github.com/users/cjbj/repos","events_url":"https://api.github.com/users/cjbj/events{/privacy}","received_events_url":"https://api.github.com/users/cjbj/received_events","type":"User","site_admin":false},"body":"The question is then, should there be a second message printed when the pool has finally closed?  The self.closing attribute would need to have 3 states.","created_at":"2018-08-17T04:38:41Z","updated_at":"2018-08-17T04:38:43Z","html_url":"https://github.com/oracle/node-oracledb/pull/950#discussion_r210803056","pull_request_url":"https://api.github.com/repos/oracle/node-oracledb/pulls/950","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/comments/210803056"},"html":{"href":"https://github.com/oracle/node-oracledb/pull/950#discussion_r210803056"},"pull_request":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/950"}},"in_reply_to_id":210802849},"pull_request":{"url":"https://api.github.com/repos/oracle/node-oracledb/pulls/950","id":203319939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzE5OTM5","html_url":"https://github.com/oracle/node-oracledb/pull/950","diff_url":"https://github.com/oracle/node-oracledb/pull/950.diff","patch_url":"https://github.com/oracle/node-oracledb/pull/950.patch","issue_url":"https://api.github.com/repos/oracle/node-oracledb/issues/950","number":950,"state":"open","locked":false,"title":"WIP: 836 - `pool.close()` should iterate open connections and close them","user":{"login":"danilohgds","id":12349622,"node_id":"MDQ6VXNlcjEyMzQ5NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/12349622?v=4","gravatar_id":"","url":"https://api.github.com/users/danilohgds","html_url":"https://github.com/danilohgds","followers_url":"https://api.github.com/users/danilohgds/followers","following_url":"https://api.github.com/users/danilohgds/following{/other_user}","gists_url":"https://api.github.com/users/danilohgds/gists{/gist_id}","starred_url":"https://api.github.com/users/danilohgds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilohgds/subscriptions","organizations_url":"https://api.github.com/users/danilohgds/orgs","repos_url":"https://api.github.com/users/danilohgds/repos","events_url":"https://api.github.com/users/danilohgds/events{/privacy}","received_events_url":"https://api.github.com/users/danilohgds/received_events","type":"User","site_admin":false},"body":"Added NJS-064 to util.js file\r\nAdded logic for an extra parameter in pool.js to forcibly close connection pool with DPI_MODE_POOL_CLOSE_FORCE after a timer has passed.\r\n\r\nSigned-off-by: Danilo Henrique Garcia da Silva <danilo_hgds@hotmail.com>\r\n","created_at":"2018-07-23T19:30:49Z","updated_at":"2018-08-17T04:38:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf30e0f05eeeed34c38d69a9f8447b4d277bf42d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":346003520,"node_id":"MDU6TGFiZWwzNDYwMDM1MjA=","url":"https://api.github.com/repos/oracle/node-oracledb/labels/OCA%20accepted","name":"OCA accepted","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/node-oracledb/pulls/950/commits","review_comments_url":"https://api.github.com/repos/oracle/node-oracledb/pulls/950/comments","review_comment_url":"https://api.github.com/repos/oracle/node-oracledb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/node-oracledb/issues/950/comments","statuses_url":"https://api.github.com/repos/oracle/node-oracledb/statuses/5ab1c14c9a0ceeb876e642f894b3e3befc606c16","head":{"label":"danilohgds:PR-836","ref":"PR-836","sha":"5ab1c14c9a0ceeb876e642f894b3e3befc606c16","user":{"login":"danilohgds","id":12349622,"node_id":"MDQ6VXNlcjEyMzQ5NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/12349622?v=4","gravatar_id":"","url":"https://api.github.com/users/danilohgds","html_url":"https://github.com/danilohgds","followers_url":"https://api.github.com/users/danilohgds/followers","following_url":"https://api.github.com/users/danilohgds/following{/other_user}","gists_url":"https://api.github.com/users/danilohgds/gists{/gist_id}","starred_url":"https://api.github.com/users/danilohgds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilohgds/subscriptions","organizations_url":"https://api.github.com/users/danilohgds/orgs","repos_url":"https://api.github.com/users/danilohgds/repos","events_url":"https://api.github.com/users/danilohgds/events{/privacy}","received_events_url":"https://api.github.com/users/danilohgds/received_events","type":"User","site_admin":false},"repo":{"id":141483770,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0ODM3NzA=","name":"node-oracledb","full_name":"danilohgds/node-oracledb","owner":{"login":"danilohgds","id":12349622,"node_id":"MDQ6VXNlcjEyMzQ5NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/12349622?v=4","gravatar_id":"","url":"https://api.github.com/users/danilohgds","html_url":"https://github.com/danilohgds","followers_url":"https://api.github.com/users/danilohgds/followers","following_url":"https://api.github.com/users/danilohgds/following{/other_user}","gists_url":"https://api.github.com/users/danilohgds/gists{/gist_id}","starred_url":"https://api.github.com/users/danilohgds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilohgds/subscriptions","organizations_url":"https://api.github.com/users/danilohgds/orgs","repos_url":"https://api.github.com/users/danilohgds/repos","events_url":"https://api.github.com/users/danilohgds/events{/privacy}","received_events_url":"https://api.github.com/users/danilohgds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danilohgds/node-oracledb","description":"Oracle Database driver for Node.js maintained by Oracle Corp.","fork":true,"url":"https://api.github.com/repos/danilohgds/node-oracledb","forks_url":"https://api.github.com/repos/danilohgds/node-oracledb/forks","keys_url":"https://api.github.com/repos/danilohgds/node-oracledb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danilohgds/node-oracledb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danilohgds/node-oracledb/teams","hooks_url":"https://api.github.com/repos/danilohgds/node-oracledb/hooks","issue_events_url":"https://api.github.com/repos/danilohgds/node-oracledb/issues/events{/number}","events_url":"https://api.github.com/repos/danilohgds/node-oracledb/events","assignees_url":"https://api.github.com/repos/danilohgds/node-oracledb/assignees{/user}","branches_url":"https://api.github.com/repos/danilohgds/node-oracledb/branches{/branch}","tags_url":"https://api.github.com/repos/danilohgds/node-oracledb/tags","blobs_url":"https://api.github.com/repos/danilohgds/node-oracledb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danilohgds/node-oracledb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danilohgds/node-oracledb/git/refs{/sha}","trees_url":"https://api.github.com/repos/danilohgds/node-oracledb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danilohgds/node-oracledb/statuses/{sha}","languages_url":"https://api.github.com/repos/danilohgds/node-oracledb/languages","stargazers_url":"https://api.github.com/repos/danilohgds/node-oracledb/stargazers","contributors_url":"https://api.github.com/repos/danilohgds/node-oracledb/contributors","subscribers_url":"https://api.github.com/repos/danilohgds/node-oracledb/subscribers","subscription_url":"https://api.github.com/repos/danilohgds/node-oracledb/subscription","commits_url":"https://api.github.com/repos/danilohgds/node-oracledb/commits{/sha}","git_commits_url":"https://api.github.com/repos/danilohgds/node-oracledb/git/commits{/sha}","comments_url":"https://api.github.com/repos/danilohgds/node-oracledb/comments{/number}","issue_comment_url":"https://api.github.com/repos/danilohgds/node-oracledb/issues/comments{/number}","contents_url":"https://api.github.com/repos/danilohgds/node-oracledb/contents/{+path}","compare_url":"https://api.github.com/repos/danilohgds/node-oracledb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danilohgds/node-oracledb/merges","archive_url":"https://api.github.com/repos/danilohgds/node-oracledb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danilohgds/node-oracledb/downloads","issues_url":"https://api.github.com/repos/danilohgds/node-oracledb/issues{/number}","pulls_url":"https://api.github.com/repos/danilohgds/node-oracledb/pulls{/number}","milestones_url":"https://api.github.com/repos/danilohgds/node-oracledb/milestones{/number}","notifications_url":"https://api.github.com/repos/danilohgds/node-oracledb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danilohgds/node-oracledb/labels{/name}","releases_url":"https://api.github.com/repos/danilohgds/node-oracledb/releases{/id}","deployments_url":"https://api.github.com/repos/danilohgds/node-oracledb/deployments","created_at":"2018-07-18T19:58:24Z","updated_at":"2018-07-18T19:58:27Z","pushed_at":"2018-08-16T13:55:08Z","git_url":"git://github.com/danilohgds/node-oracledb.git","ssh_url":"git@github.com:danilohgds/node-oracledb.git","clone_url":"https://github.com/danilohgds/node-oracledb.git","svn_url":"https://github.com/danilohgds/node-oracledb","homepage":"http://oracle.github.io/node-oracledb/","size":4143,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"d8453812def46c9d04c0fb3cd75a7c8fbdf40aee","user":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":28612154,"node_id":"MDEwOlJlcG9zaXRvcnkyODYxMjE1NA==","name":"node-oracledb","full_name":"oracle/node-oracledb","owner":{"login":"oracle","id":4430336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MzAzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/node-oracledb","description":"Oracle Database driver for Node.js maintained by Oracle Corp.","fork":false,"url":"https://api.github.com/repos/oracle/node-oracledb","forks_url":"https://api.github.com/repos/oracle/node-oracledb/forks","keys_url":"https://api.github.com/repos/oracle/node-oracledb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/node-oracledb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/node-oracledb/teams","hooks_url":"https://api.github.com/repos/oracle/node-oracledb/hooks","issue_events_url":"https://api.github.com/repos/oracle/node-oracledb/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/node-oracledb/events","assignees_url":"https://api.github.com/repos/oracle/node-oracledb/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/node-oracledb/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/node-oracledb/tags","blobs_url":"https://api.github.com/repos/oracle/node-oracledb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/node-oracledb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/node-oracledb/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/node-oracledb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/node-oracledb/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/node-oracledb/languages","stargazers_url":"https://api.github.com/repos/oracle/node-oracledb/stargazers","contributors_url":"https://api.github.com/repos/oracle/node-oracledb/contributors","subscribers_url":"https://api.github.com/repos/oracle/node-oracledb/subscribers","subscription_url":"https://api.github.com/repos/oracle/node-oracledb/subscription","commits_url":"https://api.github.com/repos/oracle/node-oracledb/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/node-oracledb/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/node-oracledb/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/node-oracledb/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/node-oracledb/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/node-oracledb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/node-oracledb/merges","archive_url":"https://api.github.com/repos/oracle/node-oracledb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/node-oracledb/downloads","issues_url":"https://api.github.com/repos/oracle/node-oracledb/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/node-oracledb/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/node-oracledb/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/node-oracledb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/node-oracledb/labels{/name}","releases_url":"https://api.github.com/repos/oracle/node-oracledb/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/node-oracledb/deployments","created_at":"2014-12-30T00:53:54Z","updated_at":"2018-08-16T10:50:52Z","pushed_at":"2018-08-16T13:55:09Z","git_url":"git://github.com/oracle/node-oracledb.git","ssh_url":"git@github.com:oracle/node-oracledb.git","clone_url":"https://github.com/oracle/node-oracledb.git","svn_url":"https://github.com/oracle/node-oracledb","homepage":"http://oracle.github.io/node-oracledb/","size":4172,"stargazers_count":1340,"watchers_count":1340,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":664,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":664,"open_issues":42,"watchers":1340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/950"},"html":{"href":"https://github.com/oracle/node-oracledb/pull/950"},"issue":{"href":"https://api.github.com/repos/oracle/node-oracledb/issues/950"},"comments":{"href":"https://api.github.com/repos/oracle/node-oracledb/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/node-oracledb/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/node-oracledb/statuses/5ab1c14c9a0ceeb876e642f894b3e3befc606c16"}},"author_association":"NONE"}}
{"actor":{"display_login":"cjbj"}}