{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4629","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4629/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4629/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4629/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4629","id":358165154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDA0MDk3","number":4629,"title":"Custom Buttons with expressions are only visible on summary screen","user":{"login":"h-kataria","id":3450808,"node_id":"MDQ6VXNlcjM0NTA4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"labels":[{"id":534299194,"node_id":"MDU6TGFiZWw1MzQyOTkxOTQ=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/automation/automate","name":"automation/automate","color":"5319e7","default":false},{"id":515069740,"node_id":"MDU6TGFiZWw1MTUwNjk3NDA=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/blocker","name":"blocker","color":"000000","default":false},{"id":505074429,"node_id":"MDU6TGFiZWw1MDUwNzQ0Mjk=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/bug","name":"bug","color":"ee0701","default":true},{"id":736077187,"node_id":"MDU6TGFiZWw3MzYwNzcxODc=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"node_id":"MDQ6VXNlcjM0MzM3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"node_id":"MDQ6VXNlcjM0MzM3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-09-07T18:20:34Z","updated_at":"2018-09-12T10:57:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4629","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4629","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4629.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4629.patch"},"body":"- Added a note on both tabs to specify that Expression can only be set for single entity display buttons only.\r\n- Hide expression related fields when user selects \"List\" or \"Single and List\" option in \"Display for\" drop down. Clear out any expression related data if custom button is not displayed on Single item screen only.\r\n- Work as before when \"Single Entity\" is selected in \"display for\" drop down.\r\n- Fixed a failing spec test\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1625382\r\n\r\nScreenshots after fix:\r\n\r\n![screenshot from 2018-09-11 12-52-30](https://user-images.githubusercontent.com/3450808/45374961-a23ca880-b5c1-11e8-854c-6d0fea0c30fd.png)\r\n\r\n![screenshot from 2018-09-10 15-56-14](https://user-images.githubusercontent.com/3450808/45320990-1a4b9580-b512-11e8-94a4-af5bd51a8d18.png)\r\n\r\n![screenshot from 2018-09-11 12-52-42](https://user-images.githubusercontent.com/3450808/45374955-9ea92180-b5c1-11e8-99d9-e70635ed07ea.png)\r\n\r\n![screenshot from 2018-09-10 15-55-58](https://user-images.githubusercontent.com/3450808/45320989-17e93b80-b512-11e8-9922-975d06c0d9e7.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/420606231","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4629#issuecomment-420606231","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4629","id":420606231,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDYwNjIzMQ==","user":{"login":"skateman","id":649130,"node_id":"MDQ6VXNlcjY0OTEzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T10:57:28Z","updated_at":"2018-09-12T10:57:28Z","author_association":"MEMBER","body":"@h-kataria I'm missing the `Enablement` text from the 2nd tab if the `Display for` isn't set to `Single`:\r\n![screenshot from 2018-09-12 12-52-08](https://user-images.githubusercontent.com/649130/45420585-d0d28600-b68a-11e8-9fe1-87fa8c3c2b61.png)\r\n\r\nIt just doesn't really make sense to me ...\r\n\r\n![screenshot from 2018-09-12 12-51-58](https://user-images.githubusercontent.com/649130/45420587-d6c86700-b68a-11e8-8dda-e4f808496703.png)\r\n\r\nBut if that's okay for the others, it's good to go :+1: "}}
{"actor":{"display_login":"skateman"}}