{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11129","repository_url":"https://api.github.com/repos/apache/incubator-mxnet","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11129/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11129/comments","events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11129/events","html_url":"https://github.com/apache/incubator-mxnet/pull/11129","id":328691193,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTY1ODcw","number":11129,"title":"[MXNET-497]Test kAddTo request for mkldnn operators","user":{"login":"azai91","id":8272546,"node_id":"MDQ6VXNlcjgyNzI1NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8272546?v=4","gravatar_id":"","url":"https://api.github.com/users/azai91","html_url":"https://github.com/azai91","followers_url":"https://api.github.com/users/azai91/followers","following_url":"https://api.github.com/users/azai91/following{/other_user}","gists_url":"https://api.github.com/users/azai91/gists{/gist_id}","starred_url":"https://api.github.com/users/azai91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azai91/subscriptions","organizations_url":"https://api.github.com/users/azai91/orgs","repos_url":"https://api.github.com/users/azai91/repos","events_url":"https://api.github.com/users/azai91/events{/privacy}","received_events_url":"https://api.github.com/users/azai91/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-01T23:49:44Z","updated_at":"2018-06-13T00:53:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/11129","html_url":"https://github.com/apache/incubator-mxnet/pull/11129","diff_url":"https://github.com/apache/incubator-mxnet/pull/11129.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/11129.patch"},"body":"## Description ##\r\n(Brief description on what this PR is about)\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [ ] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [ ] add MKLDNN tests to support kAddTo request type\r\n\r\n## Comments ##\r\n- If this change is a backward incompatible change, why must this change be made.\r\n- Interesting edge cases to note here\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments/396779411","html_url":"https://github.com/apache/incubator-mxnet/pull/11129#issuecomment-396779411","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/11129","id":396779411,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njc3OTQxMQ==","user":{"login":"pengzhao-intel","id":22461308,"node_id":"MDQ6VXNlcjIyNDYxMzA4","avatar_url":"https://avatars0.githubusercontent.com/u/22461308?v=4","gravatar_id":"","url":"https://api.github.com/users/pengzhao-intel","html_url":"https://github.com/pengzhao-intel","followers_url":"https://api.github.com/users/pengzhao-intel/followers","following_url":"https://api.github.com/users/pengzhao-intel/following{/other_user}","gists_url":"https://api.github.com/users/pengzhao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/pengzhao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengzhao-intel/subscriptions","organizations_url":"https://api.github.com/users/pengzhao-intel/orgs","repos_url":"https://api.github.com/users/pengzhao-intel/repos","events_url":"https://api.github.com/users/pengzhao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/pengzhao-intel/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T00:53:13Z","updated_at":"2018-06-13T00:53:13Z","author_association":"NONE","body":"@azai91 Really thanks your efforts for improving the quality of MKL-DNN backend.\r\n\r\n@azai91 @zheng-da @eric-haibin-lin @marcoabreu\r\n\r\nTwo suggestions:\r\n\r\n**1) avoiding change the MKL-DNN implementations when adding the test cases.** \r\n   It will be hard to track back the changes. If it really needs to change (for the bugfix or other reasons), I think we can file another PR.\r\n\r\n   One example is #11026, this PR is marked as adding test cases, so we don't pay much attention because it's always a good thing for more cases. But the implementation was changed and led to a performance regression for resnet-50 inference (from 238 drop to 179), see below.\r\n\r\n**2) running the `benchmark_score.py` to verify the performance for each of CI**\r\n\r\n```\r\ncommit 92286c9106dd63d2bfd062f9abb0e53b071a46e4\r\nAuthor: Alexander Zai azai91@gmail.com\r\nDate:   Tue May 29 17:48:33 2018 -0700\r\n\r\n[lvtao@mlt-skx052 image-classification]$ python benchmark_score.py\r\nINFO:root:network: resnet-50\r\nINFO:root:device: cpu(0)\r\n/home/lvtao/Workspace/mxnet-official/python/mxnet/module/base_module.py:66: UserWarning: Data provided by label_shapes don't match names specified by label_names ([] vs. ['softmax_label'])\r\n  warnings.warn(msg)\r\n[22:09:59] src/operator/nn/mkldnn/mkldnn_base.cc:72: Allocate 9437184 bytes with malloc directly\r\nINFO:root:batch size  1, image/sec: 83.039246\r\nINFO:root:batch size  2, image/sec: 118.022742\r\nINFO:root:batch size  4, image/sec: 149.483457\r\nINFO:root:batch size  8, image/sec: 162.208255\r\nINFO:root:batch size 16, image/sec: 166.800091\r\nINFO:root:batch size 32, image/sec: 165.821744\r\nINFO:root:batch size 64, image/sec: 175.934763\r\nINFO:root:batch size 128, image/sec: 179.160898\r\nINFO:root:batch size 256, image/sec: 178.767242\r\n\r\n\r\ncommit 9514a1e39f8356f8fee6202cd86c8f20fbf301b6\r\nAuthor: kpmurali 37911926+kpmurali@users.noreply.github.com\r\nDate:   Tue May 29 17:36:35 2018 -0700\r\n\r\n[lvtao@mlt-skx052 image-classification]$ python benchmark_score.py\r\nINFO:root:network: resnet-50\r\nINFO:root:device: cpu(0)\r\n/home/lvtao/Workspace/mxnet-official/python/mxnet/module/base_module.py:66: UserWarning: Data provided by label_shapes don't match names specified by label_names ([] vs. ['softmax_label'])\r\n  warnings.warn(msg)\r\n[22:19:23] src/operator/nn/mkldnn/mkldnn_base.cc:72: Allocate 147456 bytes with malloc directly\r\n[22:19:23] src/operator/nn/mkldnn/mkldnn_base.cc:72: Allocate 589824 bytes with malloc directly\r\n[22:19:23] src/operator/nn/mkldnn/mkldnn_base.cc:72: Allocate 2359296 bytes with malloc directly\r\n[22:19:23] src/operator/nn/mkldnn/mkldnn_base.cc:72: Allocate 9437184 bytes with malloc directly\r\nINFO:root:batch size  1, image/sec: 89.205967\r\nINFO:root:batch size  2, image/sec: 128.775569\r\nINFO:root:batch size  4, image/sec: 156.363125\r\nINFO:root:batch size  8, image/sec: 195.993911\r\nINFO:root:batch size 16, image/sec: 219.215664\r\nINFO:root:batch size 32, image/sec: 224.414152\r\nINFO:root:batch size 64, image/sec: 238.657344\r\nINFO:root:batch size 128, image/sec: 230.266770\r\nINFO:root:batch size 256, image/sec: 225.139635\r\n\r\n```\r\n"}}
{"actor":{"display_login":"pengzhao-intel"}}