{"action":"created","issue":{"url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/1801","repository_url":"https://api.github.com/repos/jbenden/aircrack-ng-migration","labels_url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/1801/labels{/name}","comments_url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/1801/comments","events_url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/1801/events","html_url":"https://github.com/jbenden/aircrack-ng-migration/issues/1801","id":297984222,"number":1801,"title":"broken SKA","user":{"login":"jbenden","id":73767,"avatar_url":"https://avatars3.githubusercontent.com/u/73767?v=4","gravatar_id":"","url":"https://api.github.com/users/jbenden","html_url":"https://github.com/jbenden","followers_url":"https://api.github.com/users/jbenden/followers","following_url":"https://api.github.com/users/jbenden/following{/other_user}","gists_url":"https://api.github.com/users/jbenden/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenden/subscriptions","organizations_url":"https://api.github.com/users/jbenden/orgs","repos_url":"https://api.github.com/users/jbenden/repos","events_url":"https://api.github.com/users/jbenden/events{/privacy}","received_events_url":"https://api.github.com/users/jbenden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-17T06:39:05Z","updated_at":"2018-02-17T06:39:10Z","closed_at":null,"author_association":"OWNER","body":"**Reported by rofl0r on 7 Jul 2017 23:44 UTC**\n\ni was googling around for \"broken ska\" message in airodump and i've read on several sites about a possible aircrack bug...\r\n\r\nand indeed, looking at the source we have this weird conditional: https://github.com/aircrack-ng/aircrack-ng/blob/master/src/airodump-ng.c#L510\r\nand https://github.com/aircrack-ng/aircrack-ng/blob/master/src/airodump-ng.c#L528\r\n\r\nso the \"not encrypted\" vs \"encrypted\" branches are not on the same indentation level which suggests a bug\r\ni.e. the \"not encrypted\" branch is taken when the packet is not an auth packet\r\nsince that is the spot that sets G.sk_len2 which is later used to check if the SKA is \"broken\"\r\n\r\nalso:\r\n\r\ncommit d12d0803e625e6c0d5cef2be8b91009e8041eaee\r\nAuthor: Martin Beck <hirte@aircrack-ng.org>\r\n\r\nthis commit looks suspicious... there's no info whatsoever about what G.sk_len2 might be, or what criteria makes SKA broken or not broken\r\n\r\ni'd naively suspect that this commit broke xor file generation instead of reporting broken SKA *correctly*\n\nMigrated-From: https://github.com/aircrack-ng/aircrack-ng/issues/125"},"comment":{"url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/comments/366421569","html_url":"https://github.com/jbenden/aircrack-ng-migration/issues/1801#issuecomment-366421569","issue_url":"https://api.github.com/repos/jbenden/aircrack-ng-migration/issues/1801","id":366421569,"user":{"login":"jbenden","id":73767,"avatar_url":"https://avatars3.githubusercontent.com/u/73767?v=4","gravatar_id":"","url":"https://api.github.com/users/jbenden","html_url":"https://github.com/jbenden","followers_url":"https://api.github.com/users/jbenden/followers","following_url":"https://api.github.com/users/jbenden/following{/other_user}","gists_url":"https://api.github.com/users/jbenden/gists{/gist_id}","starred_url":"https://api.github.com/users/jbenden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbenden/subscriptions","organizations_url":"https://api.github.com/users/jbenden/orgs","repos_url":"https://api.github.com/users/jbenden/repos","events_url":"https://api.github.com/users/jbenden/events{/privacy}","received_events_url":"https://api.github.com/users/jbenden/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T06:39:10Z","updated_at":"2018-02-17T06:39:10Z","author_association":"OWNER","body":"**Comment by rofl0r on 8 Jul 2017 17:29 UTC**\n\nbtw, i also tried to reorder the 2 branches i talked about earlier:\r\n\r\n> so the \"not encrypted\" vs \"encrypted\" branches are not on the same indentation level which suggests a bug\r\n\r\nthis is what i tried:\r\n\r\n```c\r\n    /* is auth packet */ \r\n    if( (h80211[0x40) != 0x40 )\r\n    {           \r\n        /* not encrypted */\r\n        if( ( h80211[24](&)(1]) + (h80211[8) ) == 1 )\r\n        {\r\n            /* Shared-Key Authentication */\r\n            if( ( h80211[26](<<)(25]) + (h80211[8) ) == 2 )\r\n            {   \r\n                /* sequence == 2 */ \r\n                memcpy(G.sharedkey[0](<<)(27]), h80211, caplen); \r\n                G.sk_len = caplen-24;\r\n            }\r\n            if( ( h80211[(h80211[27](+)(26]) << 8) ) == 4 )\r\n            {\r\n                /* sequence == 4 */\r\n                memcpy(G.sharedkey[caplen);\r\n            }\r\n        }\r\n    else\r\n    {\r\n        /* encrypted */\r\n        memcpy(G.sharedkey[1](h80211,)(2],), h80211, caplen);\r\n        G.sk_len2 = caplen-24-4;\r\n    }\r\n      \r\n    }\r\n  else return 1;\r\n```\r\n\r\nwhich seems logical according to the comments, however with that in place the .xor generation broke again in a different way, so i think that should be left as is... maybe its only the comment that's misplaced, but i suppose you should take a look at it.\r\n"}}
{"actor":{"display_login":"jbenden"}}