{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/220370062","pull_request_review_id":158763769,"id":220370062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDM3MDA2Mg==","diff_hunk":"@@ -468,9 +468,11 @@ private void unbindTelemetryService() {\n   private void stopTelemetryService() {\n     TelemetryLocationEnabler.LocationState telemetryLocationState = telemetryLocationEnabler","path":"libtelemetry/src/main/java/com/mapbox/android/telemetry/MapboxTelemetry.java","position":2,"original_position":2,"commit_id":"1c1dbae47b8037c1bd338fb782c7928b5c8a8310","original_commit_id":"1c1dbae47b8037c1bd338fb782c7928b5c8a8310","user":{"login":"andrlee","id":1395397,"node_id":"MDQ6VXNlcjEzOTUzOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1395397?v=4","gravatar_id":"","url":"https://api.github.com/users/andrlee","html_url":"https://github.com/andrlee","followers_url":"https://api.github.com/users/andrlee/followers","following_url":"https://api.github.com/users/andrlee/following{/other_user}","gists_url":"https://api.github.com/users/andrlee/gists{/gist_id}","starred_url":"https://api.github.com/users/andrlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrlee/subscriptions","organizations_url":"https://api.github.com/users/andrlee/orgs","repos_url":"https://api.github.com/users/andrlee/repos","events_url":"https://api.github.com/users/andrlee/events{/privacy}","received_events_url":"https://api.github.com/users/andrlee/received_events","type":"User","site_admin":false},"body":"shouldn't null check be at this line? as well as should we escape early? \r\n`if (telemetryService == null) {\r\n     /* log error */ \r\n     return;\r\n  }\r\n`","created_at":"2018-09-25T22:01:45Z","updated_at":"2018-09-25T22:07:22Z","html_url":"https://github.com/mapbox/mapbox-events-android/pull/221#discussion_r220370062","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/220370062"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/221#discussion_r220370062"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221","id":218131653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTMxNjUz","html_url":"https://github.com/mapbox/mapbox-events-android/pull/221","diff_url":"https://github.com/mapbox/mapbox-events-android/pull/221.diff","patch_url":"https://github.com/mapbox/mapbox-events-android/pull/221.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/221","number":221,"state":"open","locked":false,"title":"StopTelemetryService obtainBoundInstances bug fix","user":{"login":"electrostat","id":1819666,"node_id":"MDQ6VXNlcjE4MTk2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false},"body":"Under certain circumstances, `telemetryService` is null and causes a crash when calling `obtainBoundInstances()` within `stopTelemetryService`. Add in check to prevent crash.\r\n\r\nFixes https://github.com/mapbox/mapbox-events-android/issues/188","created_at":"2018-09-25T21:56:33Z","updated_at":"2018-09-25T22:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1b0544cbc38a06ca8f969ca53ea8efc305680e9","assignee":{"login":"electrostat","id":1819666,"node_id":"MDQ6VXNlcjE4MTk2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false},"assignees":[{"login":"electrostat","id":1819666,"node_id":"MDQ6VXNlcjE4MTk2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":716790572,"node_id":"MDU6TGFiZWw3MTY3OTA1NzI=","url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/221/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/1c1dbae47b8037c1bd338fb782c7928b5c8a8310","head":{"label":"mapbox:aa-stop-telem-service-null-check","ref":"aa-stop-telem-service-null-check","sha":"1c1dbae47b8037c1bd338fb782c7928b5c8a8310","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NTk0MzY=","name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry and core libraries for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2018-09-21T15:27:33Z","pushed_at":"2018-09-25T21:56:33Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":"https://www.mapbox.com/android-docs/core/","size":741,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":28,"watchers":12,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"4e4f09f8069a3d95b41026d89d02b50f1ec20cc5","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY1NTk0MzY=","name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry and core libraries for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2018-09-21T15:27:33Z","pushed_at":"2018-09-25T21:56:33Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":"https://www.mapbox.com/android-docs/core/","size":741,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":28,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/221"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/221"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/1c1dbae47b8037c1bd338fb782c7928b5c8a8310"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrlee"}}