{"action":"created","comment":{"url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/comments/230705928","pull_request_review_id":171491922,"id":230705928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcwNTkyOA==","diff_hunk":"@@ -30,6 +39,38 @@ describe('openfisca generateTest', function() {\n     });\n });\n \n+function run_cmd(cmd, args, callback ) {\n+    var spawn = require('child_process').spawn;\n+    var child = spawn(cmd, args);\n+    var respErr = \"\";\n+    var respOut = \"\";\n+\n+    child.stdout.on('data', function (buffer) { respOut += buffer.toString(); });\n+    child.stderr.on('data', function (buffer) { respErr += buffer.toString(); });\n+    child.on('exit', function(code) { callback(code ? 'Exit code was ' + code : null, respOut, respErr); });\n+    child.on('error', function(err) { callback(err); });\n+}\n+\n+function runOpenFiscaTest(yaml, extension, done) {","path":"test/backend/openfisca/test.js","position":48,"original_position":48,"commit_id":"2fa5455427f087cbb6d1b430875638e3d6274c85","original_commit_id":"9a8ef58ba4ec20c3aa035d92bc8bb5a9d04b4bc4","user":{"login":"alexsegura","id":1162230,"node_id":"MDQ6VXNlcjExNjIyMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1162230?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsegura","html_url":"https://github.com/alexsegura","followers_url":"https://api.github.com/users/alexsegura/followers","following_url":"https://api.github.com/users/alexsegura/following{/other_user}","gists_url":"https://api.github.com/users/alexsegura/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsegura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsegura/subscriptions","organizations_url":"https://api.github.com/users/alexsegura/orgs","repos_url":"https://api.github.com/users/alexsegura/repos","events_url":"https://api.github.com/users/alexsegura/events{/privacy}","received_events_url":"https://api.github.com/users/alexsegura/received_events","type":"User","site_admin":false},"body":"IMHO this should be in `backend/lib/openfisca/test.js`, and this shouldn't make any assertion. \r\nAssertions should be move inside the test (i.e, assert this command has returned zero exit code).  ","created_at":"2018-11-05T10:47:06Z","updated_at":"2018-11-05T10:49:30Z","html_url":"https://github.com/betagouv/mes-aides-ui/pull/950#discussion_r230705928","pull_request_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/comments/230705928"},"html":{"href":"https://github.com/betagouv/mes-aides-ui/pull/950#discussion_r230705928"},"pull_request":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950","id":228290737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjkwNzM3","html_url":"https://github.com/betagouv/mes-aides-ui/pull/950","diff_url":"https://github.com/betagouv/mes-aides-ui/pull/950.diff","patch_url":"https://github.com/betagouv/mes-aides-ui/pull/950.patch","issue_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/950","number":950,"state":"open","locked":false,"title":"Add tests for YAML test generation","user":{"login":"guillett","id":1410356,"node_id":"MDQ6VXNlcjE0MTAzNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1410356?v=4","gravatar_id":"","url":"https://api.github.com/users/guillett","html_url":"https://github.com/guillett","followers_url":"https://api.github.com/users/guillett/followers","following_url":"https://api.github.com/users/guillett/following{/other_user}","gists_url":"https://api.github.com/users/guillett/gists{/gist_id}","starred_url":"https://api.github.com/users/guillett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillett/subscriptions","organizations_url":"https://api.github.com/users/guillett/orgs","repos_url":"https://api.github.com/users/guillett/repos","events_url":"https://api.github.com/users/guillett/events{/privacy}","received_events_url":"https://api.github.com/users/guillett/received_events","type":"User","site_admin":false},"body":"We want to move away from [Ludwig v1](https://github.com/betagouv/ludwig-ui) and use [Ludwig v2](https://github.com/betagouv/ludwig).\r\n\r\nLudwig 1 was two things at the same time:\r\n- an expectation editor,\r\n- a test directory and\r\n- a test runner\r\n\r\nWith Ludwig 1 it was easy to generate tests but they were hard to use for developers (tests are in a database). \r\n\r\nLudwig 2 is a way to link applications to their repository and their test base.\r\nThe Ludwig 2 v0 (🙃) is a single endpoint to POST file test content to be added to the underlying repository.\r\n\r\nThis PR ensure that generated YAML are valid OpenFisca tests.","created_at":"2018-11-05T09:40:09Z","updated_at":"2018-11-05T10:49:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c22eae8cc3cecf59eea0655cc5d47c26351e4f6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":199109115,"node_id":"MDU6TGFiZWwxOTkxMDkxMTU=","url":"https://api.github.com/repos/betagouv/mes-aides-ui/labels/impl%C3%A9mentation","name":"implémentation","color":"ededed","default":false},{"id":199109114,"node_id":"MDU6TGFiZWwxOTkxMDkxMTQ=","url":"https://api.github.com/repos/betagouv/mes-aides-ui/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950/commits","review_comments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950/comments","review_comment_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/950/comments","statuses_url":"https://api.github.com/repos/betagouv/mes-aides-ui/statuses/2fa5455427f087cbb6d1b430875638e3d6274c85","head":{"label":"betagouv:ludwig-up","ref":"ludwig-up","sha":"2fa5455427f087cbb6d1b430875638e3d6274c85","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":18399519,"node_id":"MDEwOlJlcG9zaXRvcnkxODM5OTUxOQ==","name":"mes-aides-ui","full_name":"betagouv/mes-aides-ui","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/mes-aides-ui","description":"Le simulateur global des prestations sociales françaises","fork":false,"url":"https://api.github.com/repos/betagouv/mes-aides-ui","forks_url":"https://api.github.com/repos/betagouv/mes-aides-ui/forks","keys_url":"https://api.github.com/repos/betagouv/mes-aides-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/mes-aides-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/mes-aides-ui/teams","hooks_url":"https://api.github.com/repos/betagouv/mes-aides-ui/hooks","issue_events_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/mes-aides-ui/events","assignees_url":"https://api.github.com/repos/betagouv/mes-aides-ui/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/mes-aides-ui/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/mes-aides-ui/tags","blobs_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/mes-aides-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/mes-aides-ui/languages","stargazers_url":"https://api.github.com/repos/betagouv/mes-aides-ui/stargazers","contributors_url":"https://api.github.com/repos/betagouv/mes-aides-ui/contributors","subscribers_url":"https://api.github.com/repos/betagouv/mes-aides-ui/subscribers","subscription_url":"https://api.github.com/repos/betagouv/mes-aides-ui/subscription","commits_url":"https://api.github.com/repos/betagouv/mes-aides-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/mes-aides-ui/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/mes-aides-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/mes-aides-ui/merges","archive_url":"https://api.github.com/repos/betagouv/mes-aides-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/mes-aides-ui/downloads","issues_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/mes-aides-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/mes-aides-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/mes-aides-ui/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/mes-aides-ui/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/deployments","created_at":"2014-04-03T10:42:21Z","updated_at":"2018-10-31T16:25:00Z","pushed_at":"2018-11-05T10:48:55Z","git_url":"git://github.com/betagouv/mes-aides-ui.git","ssh_url":"git@github.com:betagouv/mes-aides-ui.git","clone_url":"https://github.com/betagouv/mes-aides-ui.git","svn_url":"https://github.com/betagouv/mes-aides-ui","homepage":"https://mes-aides.gouv.fr/","size":16933,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":128,"license":null,"forks":10,"open_issues":128,"watchers":50,"default_branch":"master"}},"base":{"label":"betagouv:master","ref":"master","sha":"eab20128b1de24ca81e23d5c44f8c2db6295b4fb","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":18399519,"node_id":"MDEwOlJlcG9zaXRvcnkxODM5OTUxOQ==","name":"mes-aides-ui","full_name":"betagouv/mes-aides-ui","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/mes-aides-ui","description":"Le simulateur global des prestations sociales françaises","fork":false,"url":"https://api.github.com/repos/betagouv/mes-aides-ui","forks_url":"https://api.github.com/repos/betagouv/mes-aides-ui/forks","keys_url":"https://api.github.com/repos/betagouv/mes-aides-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/mes-aides-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/mes-aides-ui/teams","hooks_url":"https://api.github.com/repos/betagouv/mes-aides-ui/hooks","issue_events_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/mes-aides-ui/events","assignees_url":"https://api.github.com/repos/betagouv/mes-aides-ui/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/mes-aides-ui/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/mes-aides-ui/tags","blobs_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/mes-aides-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/mes-aides-ui/languages","stargazers_url":"https://api.github.com/repos/betagouv/mes-aides-ui/stargazers","contributors_url":"https://api.github.com/repos/betagouv/mes-aides-ui/contributors","subscribers_url":"https://api.github.com/repos/betagouv/mes-aides-ui/subscribers","subscription_url":"https://api.github.com/repos/betagouv/mes-aides-ui/subscription","commits_url":"https://api.github.com/repos/betagouv/mes-aides-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/mes-aides-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/mes-aides-ui/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/mes-aides-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/mes-aides-ui/merges","archive_url":"https://api.github.com/repos/betagouv/mes-aides-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/mes-aides-ui/downloads","issues_url":"https://api.github.com/repos/betagouv/mes-aides-ui/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/mes-aides-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/mes-aides-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/mes-aides-ui/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/mes-aides-ui/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/mes-aides-ui/deployments","created_at":"2014-04-03T10:42:21Z","updated_at":"2018-10-31T16:25:00Z","pushed_at":"2018-11-05T10:48:55Z","git_url":"git://github.com/betagouv/mes-aides-ui.git","ssh_url":"git@github.com:betagouv/mes-aides-ui.git","clone_url":"https://github.com/betagouv/mes-aides-ui.git","svn_url":"https://github.com/betagouv/mes-aides-ui","homepage":"https://mes-aides.gouv.fr/","size":16933,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":128,"license":null,"forks":10,"open_issues":128,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950"},"html":{"href":"https://github.com/betagouv/mes-aides-ui/pull/950"},"issue":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/950"},"comments":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/betagouv/mes-aides-ui/statuses/2fa5455427f087cbb6d1b430875638e3d6274c85"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexsegura"}}