{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40","id":206441144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDQxMTQ0","html_url":"https://github.com/YosysHQ/nextpnr/pull/40","diff_url":"https://github.com/YosysHQ/nextpnr/pull/40.diff","patch_url":"https://github.com/YosysHQ/nextpnr/pull/40.patch","issue_url":"https://api.github.com/repos/YosysHQ/nextpnr/issues/40","number":40,"state":"closed","locked":false,"title":"Fix budget overrides","user":{"login":"eddiehung","id":6740044,"node_id":"MDQ6VXNlcjY3NDAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6740044?v=4","gravatar_id":"","url":"https://api.github.com/users/eddiehung","html_url":"https://github.com/eddiehung","followers_url":"https://api.github.com/users/eddiehung/followers","following_url":"https://api.github.com/users/eddiehung/following{/other_user}","gists_url":"https://api.github.com/users/eddiehung/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiehung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiehung/subscriptions","organizations_url":"https://api.github.com/users/eddiehung/orgs","repos_url":"https://api.github.com/users/eddiehung/repos","events_url":"https://api.github.com/users/eddiehung/events{/privacy}","received_events_url":"https://api.github.com/users/eddiehung/received_events","type":"User","site_admin":false},"body":"It appears that `Arch::getBudgetOverride()` wasn't being used correctly during STA. Builds on #38.\r\n\r\nAlso changed signature of `Arch::getBudgetOverride()` to `bool Arch::getBudgetOverride(const Netinfo*, const PortRef&, delay_t&)` to modify budget in place and return bool if this was done.\r\n\r\nThis appears to return a small QoR improvement:\r\nOn #38:\r\n```\r\n  | min | avg | max | success (/32)\r\nmaster 100MHz | 50.88 | 55.04 | 60.28 | 32\r\nmaster 70MHz | 50.4 | 54.97 | 59.13 | 31\r\nmaster 60MHz | 51.16 | 54.97 | 59.06 | 32\r\nmaster (default=12MHz) | 51.54 | 54.42 | 59.73 | 32\r\n```\r\n\r\nThis:\r\n```\r\n  | min | avg | max | success (/32)\r\nmaster 100MHz | 49.87 | 55.45 | 61 | 32\r\nmaster 70MHz | 51.14 | 55.94 | 63.33 | 32\r\nmaster 60MHz | 51.71 | 57.32 | 62.53 | 32\r\nmaster (default=12MHz) | 50.17 | 56.25 | 62.26 | 31\r\n```","created_at":"2018-08-06T15:46:36Z","updated_at":"2018-08-06T19:25:31Z","closed_at":"2018-08-06T19:25:31Z","merged_at":"2018-08-06T19:25:31Z","merge_commit_sha":"88d2c49440c952a097107b6299fd09034532a8db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40/commits","review_comments_url":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40/comments","review_comment_url":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YosysHQ/nextpnr/issues/40/comments","statuses_url":"https://api.github.com/repos/YosysHQ/nextpnr/statuses/9addcac09cd9e95a1078b938c92290c453e53160","head":{"label":"eddiehung:fix_budget_overrides","ref":"fix_budget_overrides","sha":"9addcac09cd9e95a1078b938c92290c453e53160","user":{"login":"eddiehung","id":6740044,"node_id":"MDQ6VXNlcjY3NDAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6740044?v=4","gravatar_id":"","url":"https://api.github.com/users/eddiehung","html_url":"https://github.com/eddiehung","followers_url":"https://api.github.com/users/eddiehung/followers","following_url":"https://api.github.com/users/eddiehung/following{/other_user}","gists_url":"https://api.github.com/users/eddiehung/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiehung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiehung/subscriptions","organizations_url":"https://api.github.com/users/eddiehung/orgs","repos_url":"https://api.github.com/users/eddiehung/repos","events_url":"https://api.github.com/users/eddiehung/events{/privacy}","received_events_url":"https://api.github.com/users/eddiehung/received_events","type":"User","site_admin":false},"repo":{"id":143161565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNjE1NjU=","name":"nextpnr","full_name":"eddiehung/nextpnr","owner":{"login":"eddiehung","id":6740044,"node_id":"MDQ6VXNlcjY3NDAwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6740044?v=4","gravatar_id":"","url":"https://api.github.com/users/eddiehung","html_url":"https://github.com/eddiehung","followers_url":"https://api.github.com/users/eddiehung/followers","following_url":"https://api.github.com/users/eddiehung/following{/other_user}","gists_url":"https://api.github.com/users/eddiehung/gists{/gist_id}","starred_url":"https://api.github.com/users/eddiehung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddiehung/subscriptions","organizations_url":"https://api.github.com/users/eddiehung/orgs","repos_url":"https://api.github.com/users/eddiehung/repos","events_url":"https://api.github.com/users/eddiehung/events{/privacy}","received_events_url":"https://api.github.com/users/eddiehung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddiehung/nextpnr","description":"nextpnr portable FPGA place and route tool","fork":true,"url":"https://api.github.com/repos/eddiehung/nextpnr","forks_url":"https://api.github.com/repos/eddiehung/nextpnr/forks","keys_url":"https://api.github.com/repos/eddiehung/nextpnr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddiehung/nextpnr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddiehung/nextpnr/teams","hooks_url":"https://api.github.com/repos/eddiehung/nextpnr/hooks","issue_events_url":"https://api.github.com/repos/eddiehung/nextpnr/issues/events{/number}","events_url":"https://api.github.com/repos/eddiehung/nextpnr/events","assignees_url":"https://api.github.com/repos/eddiehung/nextpnr/assignees{/user}","branches_url":"https://api.github.com/repos/eddiehung/nextpnr/branches{/branch}","tags_url":"https://api.github.com/repos/eddiehung/nextpnr/tags","blobs_url":"https://api.github.com/repos/eddiehung/nextpnr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddiehung/nextpnr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddiehung/nextpnr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddiehung/nextpnr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddiehung/nextpnr/statuses/{sha}","languages_url":"https://api.github.com/repos/eddiehung/nextpnr/languages","stargazers_url":"https://api.github.com/repos/eddiehung/nextpnr/stargazers","contributors_url":"https://api.github.com/repos/eddiehung/nextpnr/contributors","subscribers_url":"https://api.github.com/repos/eddiehung/nextpnr/subscribers","subscription_url":"https://api.github.com/repos/eddiehung/nextpnr/subscription","commits_url":"https://api.github.com/repos/eddiehung/nextpnr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddiehung/nextpnr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddiehung/nextpnr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddiehung/nextpnr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddiehung/nextpnr/contents/{+path}","compare_url":"https://api.github.com/repos/eddiehung/nextpnr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddiehung/nextpnr/merges","archive_url":"https://api.github.com/repos/eddiehung/nextpnr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddiehung/nextpnr/downloads","issues_url":"https://api.github.com/repos/eddiehung/nextpnr/issues{/number}","pulls_url":"https://api.github.com/repos/eddiehung/nextpnr/pulls{/number}","milestones_url":"https://api.github.com/repos/eddiehung/nextpnr/milestones{/number}","notifications_url":"https://api.github.com/repos/eddiehung/nextpnr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddiehung/nextpnr/labels{/name}","releases_url":"https://api.github.com/repos/eddiehung/nextpnr/releases{/id}","deployments_url":"https://api.github.com/repos/eddiehung/nextpnr/deployments","created_at":"2018-08-01T13:41:59Z","updated_at":"2018-08-05T19:42:13Z","pushed_at":"2018-08-06T19:23:34Z","git_url":"git://github.com/eddiehung/nextpnr.git","ssh_url":"git@github.com:eddiehung/nextpnr.git","clone_url":"https://github.com/eddiehung/nextpnr.git","svn_url":"https://github.com/eddiehung/nextpnr","homepage":null,"size":3008,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YosysHQ:master","ref":"master","sha":"6c8319e29a68d8d54b747e95c3f4a8df8a14d3ba","user":{"login":"YosysHQ","id":35169771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTY5Nzcx","avatar_url":"https://avatars3.githubusercontent.com/u/35169771?v=4","gravatar_id":"","url":"https://api.github.com/users/YosysHQ","html_url":"https://github.com/YosysHQ","followers_url":"https://api.github.com/users/YosysHQ/followers","following_url":"https://api.github.com/users/YosysHQ/following{/other_user}","gists_url":"https://api.github.com/users/YosysHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/YosysHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YosysHQ/subscriptions","organizations_url":"https://api.github.com/users/YosysHQ/orgs","repos_url":"https://api.github.com/users/YosysHQ/repos","events_url":"https://api.github.com/users/YosysHQ/events{/privacy}","received_events_url":"https://api.github.com/users/YosysHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":143147942,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxNDc5NDI=","name":"nextpnr","full_name":"YosysHQ/nextpnr","owner":{"login":"YosysHQ","id":35169771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MTY5Nzcx","avatar_url":"https://avatars3.githubusercontent.com/u/35169771?v=4","gravatar_id":"","url":"https://api.github.com/users/YosysHQ","html_url":"https://github.com/YosysHQ","followers_url":"https://api.github.com/users/YosysHQ/followers","following_url":"https://api.github.com/users/YosysHQ/following{/other_user}","gists_url":"https://api.github.com/users/YosysHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/YosysHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YosysHQ/subscriptions","organizations_url":"https://api.github.com/users/YosysHQ/orgs","repos_url":"https://api.github.com/users/YosysHQ/repos","events_url":"https://api.github.com/users/YosysHQ/events{/privacy}","received_events_url":"https://api.github.com/users/YosysHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YosysHQ/nextpnr","description":"nextpnr portable FPGA place and route tool","fork":false,"url":"https://api.github.com/repos/YosysHQ/nextpnr","forks_url":"https://api.github.com/repos/YosysHQ/nextpnr/forks","keys_url":"https://api.github.com/repos/YosysHQ/nextpnr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YosysHQ/nextpnr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YosysHQ/nextpnr/teams","hooks_url":"https://api.github.com/repos/YosysHQ/nextpnr/hooks","issue_events_url":"https://api.github.com/repos/YosysHQ/nextpnr/issues/events{/number}","events_url":"https://api.github.com/repos/YosysHQ/nextpnr/events","assignees_url":"https://api.github.com/repos/YosysHQ/nextpnr/assignees{/user}","branches_url":"https://api.github.com/repos/YosysHQ/nextpnr/branches{/branch}","tags_url":"https://api.github.com/repos/YosysHQ/nextpnr/tags","blobs_url":"https://api.github.com/repos/YosysHQ/nextpnr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YosysHQ/nextpnr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YosysHQ/nextpnr/git/refs{/sha}","trees_url":"https://api.github.com/repos/YosysHQ/nextpnr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YosysHQ/nextpnr/statuses/{sha}","languages_url":"https://api.github.com/repos/YosysHQ/nextpnr/languages","stargazers_url":"https://api.github.com/repos/YosysHQ/nextpnr/stargazers","contributors_url":"https://api.github.com/repos/YosysHQ/nextpnr/contributors","subscribers_url":"https://api.github.com/repos/YosysHQ/nextpnr/subscribers","subscription_url":"https://api.github.com/repos/YosysHQ/nextpnr/subscription","commits_url":"https://api.github.com/repos/YosysHQ/nextpnr/commits{/sha}","git_commits_url":"https://api.github.com/repos/YosysHQ/nextpnr/git/commits{/sha}","comments_url":"https://api.github.com/repos/YosysHQ/nextpnr/comments{/number}","issue_comment_url":"https://api.github.com/repos/YosysHQ/nextpnr/issues/comments{/number}","contents_url":"https://api.github.com/repos/YosysHQ/nextpnr/contents/{+path}","compare_url":"https://api.github.com/repos/YosysHQ/nextpnr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YosysHQ/nextpnr/merges","archive_url":"https://api.github.com/repos/YosysHQ/nextpnr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YosysHQ/nextpnr/downloads","issues_url":"https://api.github.com/repos/YosysHQ/nextpnr/issues{/number}","pulls_url":"https://api.github.com/repos/YosysHQ/nextpnr/pulls{/number}","milestones_url":"https://api.github.com/repos/YosysHQ/nextpnr/milestones{/number}","notifications_url":"https://api.github.com/repos/YosysHQ/nextpnr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YosysHQ/nextpnr/labels{/name}","releases_url":"https://api.github.com/repos/YosysHQ/nextpnr/releases{/id}","deployments_url":"https://api.github.com/repos/YosysHQ/nextpnr/deployments","created_at":"2018-08-01T11:39:03Z","updated_at":"2018-08-06T19:02:58Z","pushed_at":"2018-08-06T19:25:31Z","git_url":"git://github.com/YosysHQ/nextpnr.git","ssh_url":"git@github.com:YosysHQ/nextpnr.git","clone_url":"https://github.com/YosysHQ/nextpnr.git","svn_url":"https://github.com/YosysHQ/nextpnr","homepage":null,"size":3007,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":8,"open_issues":11,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40"},"html":{"href":"https://github.com/YosysHQ/nextpnr/pull/40"},"issue":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/issues/40"},"comments":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/YosysHQ/nextpnr/statuses/9addcac09cd9e95a1078b938c92290c453e53160"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"daveshah1","id":5521177,"node_id":"MDQ6VXNlcjU1MjExNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5521177?v=4","gravatar_id":"","url":"https://api.github.com/users/daveshah1","html_url":"https://github.com/daveshah1","followers_url":"https://api.github.com/users/daveshah1/followers","following_url":"https://api.github.com/users/daveshah1/following{/other_user}","gists_url":"https://api.github.com/users/daveshah1/gists{/gist_id}","starred_url":"https://api.github.com/users/daveshah1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveshah1/subscriptions","organizations_url":"https://api.github.com/users/daveshah1/orgs","repos_url":"https://api.github.com/users/daveshah1/repos","events_url":"https://api.github.com/users/daveshah1/events{/privacy}","received_events_url":"https://api.github.com/users/daveshah1/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":11,"additions":57,"deletions":31,"changed_files":10}}
{"actor":{"display_login":"daveshah1"}}