{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/comments/202209166","pull_request_review_id":136865412,"id":202209166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIwOTE2Ng==","diff_hunk":"@@ -0,0 +1,115 @@\n+/*\n+ * Copyright (c) 1998, 2018 Oracle and/or its affiliates. All rights reserved.\n+ *\n+ * This program and the accompanying materials are made available under the\n+ * terms of the Eclipse Public License v. 2.0 which is available at\n+ * http://www.eclipse.org/legal/epl-2.0,\n+ * or the Eclipse Distribution License v. 1.0 which is available at\n+ * http://www.eclipse.org/org/documents/edl-v10.php.\n+ *\n+ * SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause\n+ */\n+\n+// Contributors:\n+//     Oracle - initial API and implementation from Oracle TopLink\n+package org.eclipse.persistence.internal.databaseaccess;\n+\n+import java.util.Vector;\n+\n+import org.eclipse.persistence.internal.sessions.DatabaseSessionImpl;\n+import org.eclipse.persistence.queries.DataReadQuery;\n+import org.eclipse.persistence.tools.schemaframework.FieldDefinition;\n+import org.eclipse.persistence.tools.schemaframework.TableDefinition;\n+\n+/**\n+ * INTERNAL:\n+ * Interface to define method prototype for table existence check.\n+ */\n+public interface TableExistenceCheck {","path":"foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/internal/databaseaccess/TableExistenceCheck.java","position":28,"original_position":28,"commit_id":"035ca5a3f287199e3d0acb76c6a9697e2072ddfa","original_commit_id":"035ca5a3f287199e3d0acb76c6a9697e2072ddfa","user":{"login":"Tomas-Kraus","id":37806327,"node_id":"MDQ6VXNlcjM3ODA2MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/37806327?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomas-Kraus","html_url":"https://github.com/Tomas-Kraus","followers_url":"https://api.github.com/users/Tomas-Kraus/followers","following_url":"https://api.github.com/users/Tomas-Kraus/following{/other_user}","gists_url":"https://api.github.com/users/Tomas-Kraus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomas-Kraus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomas-Kraus/subscriptions","organizations_url":"https://api.github.com/users/Tomas-Kraus/orgs","repos_url":"https://api.github.com/users/Tomas-Kraus/repos","events_url":"https://api.github.com/users/Tomas-Kraus/events{/privacy}","received_events_url":"https://api.github.com/users/Tomas-Kraus/received_events","type":"User","site_admin":false},"body":"The only reason of added complexity is to avoid copy-pasting  \r\n ```java\r\n    try {\r\n          session.setLoggingOff(true);\r\n          session.executeQuery(getQuery(table));\r\n          return true;\r\n      } catch (Exception notFound) {\r\n          return false;\r\n      }\r\n```\r\ninto each of the overriding methods. So your DB2 change will define just the query itself.","created_at":"2018-07-12T23:34:47Z","updated_at":"2018-07-12T23:34:47Z","html_url":"https://github.com/eclipse-ee4j/eclipselink/pull/179#discussion_r202209166","pull_request_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/comments/202209166"},"html":{"href":"https://github.com/eclipse-ee4j/eclipselink/pull/179#discussion_r202209166"},"pull_request":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179"}},"in_reply_to_id":202078011},"pull_request":{"url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179","id":200690935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjkwOTM1","html_url":"https://github.com/eclipse-ee4j/eclipselink/pull/179","diff_url":"https://github.com/eclipse-ee4j/eclipselink/pull/179.diff","patch_url":"https://github.com/eclipse-ee4j/eclipselink/pull/179.patch","issue_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/179","number":179,"state":"open","locked":false,"title":"Bug 425150 - Fixed bug in query result evaluation.","user":{"login":"Tomas-Kraus","id":37806327,"node_id":"MDQ6VXNlcjM3ODA2MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/37806327?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomas-Kraus","html_url":"https://github.com/Tomas-Kraus","followers_url":"https://api.github.com/users/Tomas-Kraus/followers","following_url":"https://api.github.com/users/Tomas-Kraus/following{/other_user}","gists_url":"https://api.github.com/users/Tomas-Kraus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomas-Kraus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomas-Kraus/subscriptions","organizations_url":"https://api.github.com/users/Tomas-Kraus/orgs","repos_url":"https://api.github.com/users/Tomas-Kraus/repos","events_url":"https://api.github.com/users/Tomas-Kraus/events{/privacy}","received_events_url":"https://api.github.com/users/Tomas-Kraus/received_events","type":"User","site_admin":false},"body":"This should fix the bug. I moved query result evaluation to platform to allow child platfors to optimize whole process.\r\nTODO: jUnits","created_at":"2018-07-11T12:56:57Z","updated_at":"2018-07-12T23:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"428d7373f54e47bc2395cdaa430b78c20231d2b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lukasj","id":1069133,"node_id":"MDQ6VXNlcjEwNjkxMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1069133?v=4","gravatar_id":"","url":"https://api.github.com/users/lukasj","html_url":"https://github.com/lukasj","followers_url":"https://api.github.com/users/lukasj/followers","following_url":"https://api.github.com/users/lukasj/following{/other_user}","gists_url":"https://api.github.com/users/lukasj/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasj/subscriptions","organizations_url":"https://api.github.com/users/lukasj/orgs","repos_url":"https://api.github.com/users/lukasj/repos","events_url":"https://api.github.com/users/lukasj/events{/privacy}","received_events_url":"https://api.github.com/users/lukasj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":941461223,"node_id":"MDU6TGFiZWw5NDE0NjEyMjM=","url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/labels/Request%20Review","name":"Request Review","color":"b7171f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179/commits","review_comments_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179/comments","review_comment_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/179/comments","statuses_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/statuses/035ca5a3f287199e3d0acb76c6a9697e2072ddfa","head":{"label":"Tomas-Kraus:425150_fix","ref":"425150_fix","sha":"035ca5a3f287199e3d0acb76c6a9697e2072ddfa","user":{"login":"Tomas-Kraus","id":37806327,"node_id":"MDQ6VXNlcjM3ODA2MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/37806327?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomas-Kraus","html_url":"https://github.com/Tomas-Kraus","followers_url":"https://api.github.com/users/Tomas-Kraus/followers","following_url":"https://api.github.com/users/Tomas-Kraus/following{/other_user}","gists_url":"https://api.github.com/users/Tomas-Kraus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomas-Kraus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomas-Kraus/subscriptions","organizations_url":"https://api.github.com/users/Tomas-Kraus/orgs","repos_url":"https://api.github.com/users/Tomas-Kraus/repos","events_url":"https://api.github.com/users/Tomas-Kraus/events{/privacy}","received_events_url":"https://api.github.com/users/Tomas-Kraus/received_events","type":"User","site_admin":false},"repo":{"id":140409720,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MDk3MjA=","name":"eclipselink","full_name":"Tomas-Kraus/eclipselink","owner":{"login":"Tomas-Kraus","id":37806327,"node_id":"MDQ6VXNlcjM3ODA2MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/37806327?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomas-Kraus","html_url":"https://github.com/Tomas-Kraus","followers_url":"https://api.github.com/users/Tomas-Kraus/followers","following_url":"https://api.github.com/users/Tomas-Kraus/following{/other_user}","gists_url":"https://api.github.com/users/Tomas-Kraus/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomas-Kraus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomas-Kraus/subscriptions","organizations_url":"https://api.github.com/users/Tomas-Kraus/orgs","repos_url":"https://api.github.com/users/Tomas-Kraus/repos","events_url":"https://api.github.com/users/Tomas-Kraus/events{/privacy}","received_events_url":"https://api.github.com/users/Tomas-Kraus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tomas-Kraus/eclipselink","description":"Eclipselink project","fork":true,"url":"https://api.github.com/repos/Tomas-Kraus/eclipselink","forks_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/forks","keys_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/teams","hooks_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/hooks","issue_events_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/issues/events{/number}","events_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/events","assignees_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/assignees{/user}","branches_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/branches{/branch}","tags_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/tags","blobs_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/statuses/{sha}","languages_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/languages","stargazers_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/stargazers","contributors_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/contributors","subscribers_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/subscribers","subscription_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/subscription","commits_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/contents/{+path}","compare_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/merges","archive_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/downloads","issues_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/issues{/number}","pulls_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/pulls{/number}","milestones_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/milestones{/number}","notifications_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/labels{/name}","releases_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/releases{/id}","deployments_url":"https://api.github.com/repos/Tomas-Kraus/eclipselink/deployments","created_at":"2018-07-10T09:32:37Z","updated_at":"2018-07-10T11:46:40Z","pushed_at":"2018-07-12T14:11:22Z","git_url":"git://github.com/Tomas-Kraus/eclipselink.git","ssh_url":"git@github.com:Tomas-Kraus/eclipselink.git","clone_url":"https://github.com/Tomas-Kraus/eclipselink.git","svn_url":"https://github.com/Tomas-Kraus/eclipselink","homepage":null,"size":231389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse-ee4j:master","ref":"master","sha":"c9f8c7dbaec193f93398a759251db31cc5574855","user":{"login":"eclipse-ee4j","id":31900942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAwOTQy","avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"repo":{"id":124586660,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1ODY2NjA=","name":"eclipselink","full_name":"eclipse-ee4j/eclipselink","owner":{"login":"eclipse-ee4j","id":31900942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAwOTQy","avatar_url":"https://avatars3.githubusercontent.com/u/31900942?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse-ee4j","html_url":"https://github.com/eclipse-ee4j","followers_url":"https://api.github.com/users/eclipse-ee4j/followers","following_url":"https://api.github.com/users/eclipse-ee4j/following{/other_user}","gists_url":"https://api.github.com/users/eclipse-ee4j/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse-ee4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse-ee4j/subscriptions","organizations_url":"https://api.github.com/users/eclipse-ee4j/orgs","repos_url":"https://api.github.com/users/eclipse-ee4j/repos","events_url":"https://api.github.com/users/eclipse-ee4j/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse-ee4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse-ee4j/eclipselink","description":"Eclipselink project","fork":false,"url":"https://api.github.com/repos/eclipse-ee4j/eclipselink","forks_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/forks","keys_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/teams","hooks_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/hooks","issue_events_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/events","assignees_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/tags","blobs_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/languages","stargazers_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/stargazers","contributors_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/contributors","subscribers_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/subscribers","subscription_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/subscription","commits_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/merges","archive_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/downloads","issues_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/labels{/name}","releases_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse-ee4j/eclipselink/deployments","created_at":"2018-03-09T19:53:46Z","updated_at":"2018-07-12T22:41:11Z","pushed_at":"2018-07-12T22:41:07Z","git_url":"git://github.com/eclipse-ee4j/eclipselink.git","ssh_url":"git@github.com:eclipse-ee4j/eclipselink.git","clone_url":"https://github.com/eclipse-ee4j/eclipselink.git","svn_url":"https://github.com/eclipse-ee4j/eclipselink","homepage":null,"size":227418,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":18,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179"},"html":{"href":"https://github.com/eclipse-ee4j/eclipselink/pull/179"},"issue":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/179"},"comments":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse-ee4j/eclipselink/statuses/035ca5a3f287199e3d0acb76c6a9697e2072ddfa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Tomas-Kraus"}}