{"action":"created","comment":{"url":"https://api.github.com/repos/apache/pulsar/pulls/comments/242366045","pull_request_review_id":185858578,"id":242366045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM2NjA0NQ==","diff_hunk":"@@ -784,15 +761,9 @@ private void testUpdateFunctionMissingArguments(\n             new Gson().toJson(functionConfig),\n                 null);\n \n-        if (expectedError == null) {\n-            assertEquals(Status.OK.getStatusCode(), response.getStatus());\n-        } else {\n-            assertEquals(Status.BAD_REQUEST.getStatusCode(), response.getStatus());","path":"pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2ResourceTest.java","position":482,"original_position":482,"commit_id":"a5ec6c570ce2ada5851e22a16eda38a2026370a7","original_commit_id":"a5ec6c570ce2ada5851e22a16eda38a2026370a7","user":{"login":"jerrypeng","id":3613359,"node_id":"MDQ6VXNlcjM2MTMzNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3613359?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrypeng","html_url":"https://github.com/jerrypeng","followers_url":"https://api.github.com/users/jerrypeng/followers","following_url":"https://api.github.com/users/jerrypeng/following{/other_user}","gists_url":"https://api.github.com/users/jerrypeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrypeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrypeng/subscriptions","organizations_url":"https://api.github.com/users/jerrypeng/orgs","repos_url":"https://api.github.com/users/jerrypeng/repos","events_url":"https://api.github.com/users/jerrypeng/events{/privacy}","received_events_url":"https://api.github.com/users/jerrypeng/received_events","type":"User","site_admin":false},"body":"we should check status code","created_at":"2018-12-18T00:16:57Z","updated_at":"2018-12-18T00:16:57Z","html_url":"https://github.com/apache/pulsar/pull/3168#discussion_r242366045","pull_request_url":"https://api.github.com/repos/apache/pulsar/pulls/3168","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/pulsar/pulls/comments/242366045"},"html":{"href":"https://github.com/apache/pulsar/pull/3168#discussion_r242366045"},"pull_request":{"href":"https://api.github.com/repos/apache/pulsar/pulls/3168"}}},"pull_request":{"url":"https://api.github.com/repos/apache/pulsar/pulls/3168","id":237877154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODc3MTU0","html_url":"https://github.com/apache/pulsar/pull/3168","diff_url":"https://github.com/apache/pulsar/pull/3168.diff","patch_url":"https://github.com/apache/pulsar/pull/3168.patch","issue_url":"https://api.github.com/repos/apache/pulsar/issues/3168","number":3168,"state":"open","locked":false,"title":"Refactor api commands","user":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"body":"We are deprecating the Response Object in favor data object responses.","created_at":"2018-12-12T00:47:17Z","updated_at":"2018-12-18T00:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f55b41db75ce63006fc5ec2b53f5bd6a412a3f56","assignee":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"assignees":[{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rdhabalia","id":2898254,"node_id":"MDQ6VXNlcjI4OTgyNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":853313264,"node_id":"MDU6TGFiZWw4NTMzMTMyNjQ=","url":"https://api.github.com/repos/apache/pulsar/labels/component/functions","name":"component/functions","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/pulsar/milestones/18","html_url":"https://github.com/apache/pulsar/milestone/18","labels_url":"https://api.github.com/repos/apache/pulsar/milestones/18/labels","id":3603038,"node_id":"MDk6TWlsZXN0b25lMzYwMzAzOA==","number":18,"title":"2.3.0","description":"","creator":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":267,"state":"open","created_at":"2018-08-28T07:03:59Z","updated_at":"2018-12-17T20:36:06Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/pulsar/pulls/3168/commits","review_comments_url":"https://api.github.com/repos/apache/pulsar/pulls/3168/comments","review_comment_url":"https://api.github.com/repos/apache/pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/pulsar/issues/3168/comments","statuses_url":"https://api.github.com/repos/apache/pulsar/statuses/a5ec6c570ce2ada5851e22a16eda38a2026370a7","head":{"label":"aahmed-se:refactorApiCommands","ref":"refactorApiCommands","sha":"a5ec6c570ce2ada5851e22a16eda38a2026370a7","user":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"repo":{"id":113290037,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyOTAwMzc=","name":"incubator-pulsar","full_name":"aahmed-se/incubator-pulsar","private":false,"owner":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aahmed-se/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/aahmed-se/incubator-pulsar","forks_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/deployments","created_at":"2017-12-06T08:34:39Z","updated_at":"2018-12-15T01:03:02Z","pushed_at":"2018-12-17T23:52:42Z","git_url":"git://github.com/aahmed-se/incubator-pulsar.git","ssh_url":"git@github.com:aahmed-se/incubator-pulsar.git","clone_url":"https://github.com/aahmed-se/incubator-pulsar.git","svn_url":"https://github.com/aahmed-se/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":44888,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"23a6622dd57aac1a02cedb26bdfcc8ef19564886","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxMg==","name":"pulsar","full_name":"apache/pulsar","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/pulsar","description":"Apache Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/pulsar","forks_url":"https://api.github.com/repos/apache/pulsar/forks","keys_url":"https://api.github.com/repos/apache/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/pulsar/teams","hooks_url":"https://api.github.com/repos/apache/pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/pulsar/events","assignees_url":"https://api.github.com/repos/apache/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/pulsar/tags","blobs_url":"https://api.github.com/repos/apache/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/pulsar/subscription","commits_url":"https://api.github.com/repos/apache/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/pulsar/merges","archive_url":"https://api.github.com/repos/apache/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/pulsar/downloads","issues_url":"https://api.github.com/repos/apache/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-12-17T18:47:15Z","pushed_at":"2018-12-17T23:52:44Z","git_url":"git://github.com/apache/pulsar.git","ssh_url":"git@github.com:apache/pulsar.git","clone_url":"https://github.com/apache/pulsar.git","svn_url":"https://github.com/apache/pulsar","homepage":"https://pulsar.apache.org","size":69427,"stargazers_count":2785,"watchers_count":2785,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":575,"open_issues":220,"watchers":2785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/pulsar/pulls/3168"},"html":{"href":"https://github.com/apache/pulsar/pull/3168"},"issue":{"href":"https://api.github.com/repos/apache/pulsar/issues/3168"},"comments":{"href":"https://api.github.com/repos/apache/pulsar/issues/3168/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/pulsar/pulls/3168/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/pulsar/pulls/3168/commits"},"statuses":{"href":"https://api.github.com/repos/apache/pulsar/statuses/a5ec6c570ce2ada5851e22a16eda38a2026370a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jerrypeng"}}