{"action":"created","issue":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2610","repository_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2610/labels{/name}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2610/comments","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2610/events","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2610","id":378356119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDgwODE2","number":2610,"title":"[Arms] Fixed MS castEfficiency on exec phase","user":{"login":"matardarix","id":10074100,"node_id":"MDQ6VXNlcjEwMDc0MTAw","avatar_url":"https://avatars0.githubusercontent.com/u/10074100?v=4","gravatar_id":"","url":"https://api.github.com/users/matardarix","html_url":"https://github.com/matardarix","followers_url":"https://api.github.com/users/matardarix/followers","following_url":"https://api.github.com/users/matardarix/following{/other_user}","gists_url":"https://api.github.com/users/matardarix/gists{/gist_id}","starred_url":"https://api.github.com/users/matardarix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matardarix/subscriptions","organizations_url":"https://api.github.com/users/matardarix/orgs","repos_url":"https://api.github.com/users/matardarix/repos","events_url":"https://api.github.com/users/matardarix/events{/privacy}","received_events_url":"https://api.github.com/users/matardarix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-07T16:07:33Z","updated_at":"2018-11-08T10:37:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/2610","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2610","diff_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2610.diff","patch_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2610.patch"},"body":"Fixed Mortal Strike castEfficiency with execution phase (as it shouldn't be cast during this, except if you have Executioner's Precision Trait).\r\n\r\nBefore: \r\n![image](https://user-images.githubusercontent.com/10074100/48143581-61a29800-e2af-11e8-9384-1e112fbdcbbe.png)\r\n\r\nNow: \r\n![image](https://user-images.githubusercontent.com/10074100/48143594-6b2c0000-e2af-11e8-988e-11bc708bbffb.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments/436949891","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2610#issuecomment-436949891","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2610","id":436949891,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjk0OTg5MQ==","user":{"login":"Gebuz","id":6773230,"node_id":"MDQ6VXNlcjY3NzMyMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6773230?v=4","gravatar_id":"","url":"https://api.github.com/users/Gebuz","html_url":"https://github.com/Gebuz","followers_url":"https://api.github.com/users/Gebuz/followers","following_url":"https://api.github.com/users/Gebuz/following{/other_user}","gists_url":"https://api.github.com/users/Gebuz/gists{/gist_id}","starred_url":"https://api.github.com/users/Gebuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gebuz/subscriptions","organizations_url":"https://api.github.com/users/Gebuz/orgs","repos_url":"https://api.github.com/users/Gebuz/repos","events_url":"https://api.github.com/users/Gebuz/events{/privacy}","received_events_url":"https://api.github.com/users/Gebuz/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T10:37:43Z","updated_at":"2018-11-08T10:37:43Z","author_association":"COLLABORATOR","body":"I think one way to go about it would be to find the amount of time spent hitting a target outside of execute range, and the percent of that spent with Mortal Strike off cooldown. I'm not sure exactly how best to do this, since only the dmg events have the HP of the target. \r\n\r\nMight be good enough to just start an execute interval as soon as there is a dmg event to a target in execute range, and then stop it on the first damage event to a target not in execute range after a minimum of X seconds has passed since the last hit on a target in execute range.\r\n\r\nI don't know how you'd then get time spent with MS off cooldown for those intervals, but if you just want something simple I guess you could start with just looking at average cooldown and amount of casts during them.\r\n\r\nThen you can throw that in a statistic box with \"Mortal Strike efficiency outside execute\" or something like that."}}
{"actor":{"display_login":"Gebuz"}}