{"action":"created","issue":{"url":"https://api.github.com/repos/fecgov/openFEC/issues/3248","repository_url":"https://api.github.com/repos/fecgov/openFEC","labels_url":"https://api.github.com/repos/fecgov/openFEC/issues/3248/labels{/name}","comments_url":"https://api.github.com/repos/fecgov/openFEC/issues/3248/comments","events_url":"https://api.github.com/repos/fecgov/openFEC/issues/3248/events","html_url":"https://github.com/fecgov/openFEC/issues/3248","id":336699655,"node_id":"MDU6SXNzdWUzMzY2OTk2NTU=","number":3248,"title":"Add committee_type filter to schedules/schedule_a endpoint","user":{"login":"JonellaCulmer","id":31663028,"node_id":"MDQ6VXNlcjMxNjYzMDI4","avatar_url":"https://avatars0.githubusercontent.com/u/31663028?v=4","gravatar_id":"","url":"https://api.github.com/users/JonellaCulmer","html_url":"https://github.com/JonellaCulmer","followers_url":"https://api.github.com/users/JonellaCulmer/followers","following_url":"https://api.github.com/users/JonellaCulmer/following{/other_user}","gists_url":"https://api.github.com/users/JonellaCulmer/gists{/gist_id}","starred_url":"https://api.github.com/users/JonellaCulmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonellaCulmer/subscriptions","organizations_url":"https://api.github.com/users/JonellaCulmer/orgs","repos_url":"https://api.github.com/users/JonellaCulmer/repos","events_url":"https://api.github.com/users/JonellaCulmer/events{/privacy}","received_events_url":"https://api.github.com/users/JonellaCulmer/received_events","type":"User","site_admin":false},"labels":[{"id":750297648,"node_id":"MDU6TGFiZWw3NTAyOTc2NDg=","url":"https://api.github.com/repos/fecgov/openFEC/labels/High%20priority","name":"High priority","color":"bc0bb0","default":false},{"id":406630722,"node_id":"MDU6TGFiZWw0MDY2MzA3MjI=","url":"https://api.github.com/repos/fecgov/openFEC/labels/Work:%20Back-end","name":"Work: Back-end","color":"F1F8FF","default":false},{"id":850298548,"node_id":"MDU6TGFiZWw4NTAyOTg1NDg=","url":"https://api.github.com/repos/fecgov/openFEC/labels/Work:%20Database","name":"Work: Database","color":"F1F8FF","default":false}],"state":"open","locked":false,"assignee":{"login":"rjayasekera","id":20324717,"node_id":"MDQ6VXNlcjIwMzI0NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/20324717?v=4","gravatar_id":"","url":"https://api.github.com/users/rjayasekera","html_url":"https://github.com/rjayasekera","followers_url":"https://api.github.com/users/rjayasekera/followers","following_url":"https://api.github.com/users/rjayasekera/following{/other_user}","gists_url":"https://api.github.com/users/rjayasekera/gists{/gist_id}","starred_url":"https://api.github.com/users/rjayasekera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjayasekera/subscriptions","organizations_url":"https://api.github.com/users/rjayasekera/orgs","repos_url":"https://api.github.com/users/rjayasekera/repos","events_url":"https://api.github.com/users/rjayasekera/events{/privacy}","received_events_url":"https://api.github.com/users/rjayasekera/received_events","type":"User","site_admin":false},"assignees":[{"login":"rjayasekera","id":20324717,"node_id":"MDQ6VXNlcjIwMzI0NzE3","avatar_url":"https://avatars3.githubusercontent.com/u/20324717?v=4","gravatar_id":"","url":"https://api.github.com/users/rjayasekera","html_url":"https://github.com/rjayasekera","followers_url":"https://api.github.com/users/rjayasekera/followers","following_url":"https://api.github.com/users/rjayasekera/following{/other_user}","gists_url":"https://api.github.com/users/rjayasekera/gists{/gist_id}","starred_url":"https://api.github.com/users/rjayasekera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjayasekera/subscriptions","organizations_url":"https://api.github.com/users/rjayasekera/orgs","repos_url":"https://api.github.com/users/rjayasekera/repos","events_url":"https://api.github.com/users/rjayasekera/events{/privacy}","received_events_url":"https://api.github.com/users/rjayasekera/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fecgov/openFEC/milestones/82","html_url":"https://github.com/fecgov/openFEC/milestone/82","labels_url":"https://api.github.com/repos/fecgov/openFEC/milestones/82/labels","id":3287067,"node_id":"MDk6TWlsZXN0b25lMzI4NzA2Nw==","number":82,"title":"Sprint 6.4","description":"","creator":{"login":"PaulClark2","id":11817734,"node_id":"MDQ6VXNlcjExODE3NzM0","avatar_url":"https://avatars1.githubusercontent.com/u/11817734?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulClark2","html_url":"https://github.com/PaulClark2","followers_url":"https://api.github.com/users/PaulClark2/followers","following_url":"https://api.github.com/users/PaulClark2/following{/other_user}","gists_url":"https://api.github.com/users/PaulClark2/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulClark2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulClark2/subscriptions","organizations_url":"https://api.github.com/users/PaulClark2/orgs","repos_url":"https://api.github.com/users/PaulClark2/repos","events_url":"https://api.github.com/users/PaulClark2/events{/privacy}","received_events_url":"https://api.github.com/users/PaulClark2/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":12,"state":"open","created_at":"2018-04-22T19:16:48Z","updated_at":"2018-07-19T18:52:04Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-06-28T16:49:13Z","updated_at":"2018-07-20T16:16:55Z","closed_at":null,"author_association":"NONE","body":"**What we're after:** In order to make it possible for users to search by committee type on the `All receipts` and `Individual contributions` data tables, we need to add a committee_type search filter to the schedules/schedule_a endpoint. \n\nRelevant issue: https://github.com/fecgov/fec-cms/issues/2129\nFront-end WIP PR: https://github.com/fecgov/fec-cms/pull/2150\n\n- [ ] Add the filter to `args.py`\n- [ ] Modify the query/MV as needed\n- [ ] Add indexes as needed"},"comment":{"url":"https://api.github.com/repos/fecgov/openFEC/issues/comments/406649920","html_url":"https://github.com/fecgov/openFEC/issues/3248#issuecomment-406649920","issue_url":"https://api.github.com/repos/fecgov/openFEC/issues/3248","id":406649920,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjY0OTkyMA==","user":{"login":"vrajmohan","id":2066204,"node_id":"MDQ6VXNlcjIwNjYyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2066204?v=4","gravatar_id":"","url":"https://api.github.com/users/vrajmohan","html_url":"https://github.com/vrajmohan","followers_url":"https://api.github.com/users/vrajmohan/followers","following_url":"https://api.github.com/users/vrajmohan/following{/other_user}","gists_url":"https://api.github.com/users/vrajmohan/gists{/gist_id}","starred_url":"https://api.github.com/users/vrajmohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrajmohan/subscriptions","organizations_url":"https://api.github.com/users/vrajmohan/orgs","repos_url":"https://api.github.com/users/vrajmohan/repos","events_url":"https://api.github.com/users/vrajmohan/events{/privacy}","received_events_url":"https://api.github.com/users/vrajmohan/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T16:16:55Z","updated_at":"2018-07-20T16:16:55Z","author_association":"CONTRIBUTOR","body":"While the linked PR provides some direction for the solution, we need to proceed carefully:\r\n1. We are refactoring the existing query and filters and should ensure that we are not breaking any fucntionality\r\n2. We should review existing tests and perhaps add tests where there is inadequate coverage.\r\n3. We should add tests for the `committee_type` filter.\r\n4. We should evaluate performance. We may need to add an index on `committee_type` filter.\r\n5. We should examine the rationale for why some committee columns are _already merged_ into the underlying materialized view while others are only available through a `JOIN`.\r\n6. We should confirm that the filter by `sub_id` does not need to be supported. It may be useful to see if it was intended to be supported and was accidentally dropped."}}
{"actor":{"display_login":"vrajmohan"}}