{"action":"created","issue":{"url":"https://api.github.com/repos/Gnucash/gnucash/issues/316","repository_url":"https://api.github.com/repos/Gnucash/gnucash","labels_url":"https://api.github.com/repos/Gnucash/gnucash/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/Gnucash/gnucash/issues/316/comments","events_url":"https://api.github.com/repos/Gnucash/gnucash/issues/316/events","html_url":"https://github.com/Gnucash/gnucash/pull/316","id":306003140,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1NTkwMjI1","number":316,"title":"[4.x] jqplot->chartjs and upgrade reports","user":{"login":"christopherlam","id":1975870,"node_id":"MDQ6VXNlcjE5NzU4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1975870?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherlam","html_url":"https://github.com/christopherlam","followers_url":"https://api.github.com/users/christopherlam/followers","following_url":"https://api.github.com/users/christopherlam/following{/other_user}","gists_url":"https://api.github.com/users/christopherlam/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherlam/subscriptions","organizations_url":"https://api.github.com/users/christopherlam/orgs","repos_url":"https://api.github.com/users/christopherlam/repos","events_url":"https://api.github.com/users/christopherlam/events{/privacy}","received_events_url":"https://api.github.com/users/christopherlam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2018-03-16T16:54:00Z","updated_at":"2018-11-05T20:02:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Gnucash/gnucash/pulls/316","html_url":"https://github.com/Gnucash/gnucash/pull/316","diff_url":"https://github.com/Gnucash/gnucash/pull/316.diff","patch_url":"https://github.com/Gnucash/gnucash/pull/316.patch"},"body":"**This PR will be slowly deconstructed**\r\n\r\n~I'm opening this PR for an alpha review - it won't be ready to merge yet. This is mainly the fruitful result of experimenting on html-barchart and linechart.~\r\n\r\n~I'm not entirely sure how to add borrowed/guile-json onto GUILE_LOAD_PATH. In my local machine I've installed guile-json onto /opt/share/guile/site, hence the hard-coded path in html-chart.scm. I think this is the main reason it'll fail on travis (also the tests haven't been updated for html-chart!). Please let me know how to allow html-chart.scm to find guile-json libdir.~\r\n\r\n~Barring this hurdle,~ this PR will:\r\n1. ~install guile-json as a general purpose scm<->json converter.~\r\n2. ~remove jqplot and replace it with the more flexible and reponsive chartjs~\r\n3. ~merge html-barchart/linechart/scatter/piechart all into html-chart.scm~\r\n4. html-chart will encompass common options and create the charts.\r\n5. options have been chosen to mimic jqplot style as far as possible (colours, fonts etc)\r\n6. ~restore the URL facility allowing inter-report jumps and jumps to the account register.~\r\n7. ~appropriate refactoring of standard-reports' piechart/barchart/linecharts to access the html-chart api~.\r\n8. copy some existing charts into the Utility menu, clearly labelled 'experimental'\r\n\r\n### Notes\r\n1. ~installation currently requires guile-json in /opt/share/guile/site~\r\n2. url feature is currently hacked via a fixed-position `<a href>` anchor - I cannot seem to trigger the Gnucash calls to gnc:register and gnc:report to create new reports on the fly. For now the `<a href>` seems the least intrusive method to trigger these jumps.\r\n3. html-piechart/barchart etc still exist - there are numerous reports using them.\r\n4. ~I can't see *any* rationale for using doubles - I'll eventually refactor to pass scheme numbers directly into guile-json which will fill the data fields correctly.~\r\n5. commits to test-graphing is not exactly reachable by UI but is included as an illustration how to change code. This is probably buggy because I cannot test it!"},"comment":{"url":"https://api.github.com/repos/Gnucash/gnucash/issues/comments/436015551","html_url":"https://github.com/Gnucash/gnucash/pull/316#issuecomment-436015551","issue_url":"https://api.github.com/repos/Gnucash/gnucash/issues/316","id":436015551,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjAxNTU1MQ==","user":{"login":"gjanssens","id":619393,"node_id":"MDQ6VXNlcjYxOTM5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/619393?v=4","gravatar_id":"","url":"https://api.github.com/users/gjanssens","html_url":"https://github.com/gjanssens","followers_url":"https://api.github.com/users/gjanssens/followers","following_url":"https://api.github.com/users/gjanssens/following{/other_user}","gists_url":"https://api.github.com/users/gjanssens/gists{/gist_id}","starred_url":"https://api.github.com/users/gjanssens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjanssens/subscriptions","organizations_url":"https://api.github.com/users/gjanssens/orgs","repos_url":"https://api.github.com/users/gjanssens/repos","events_url":"https://api.github.com/users/gjanssens/events{/privacy}","received_events_url":"https://api.github.com/users/gjanssens/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T20:02:36Z","updated_at":"2018-11-05T20:02:36Z","author_association":"MEMBER","body":"@GnuFiBux I haven't studied them in detail yet, but your tests look quite clean now."}}
{"actor":{"display_login":"gjanssens"}}