{"action":"created","issue":{"url":"https://api.github.com/repos/iov-one/weave/issues/180","repository_url":"https://api.github.com/repos/iov-one/weave","labels_url":"https://api.github.com/repos/iov-one/weave/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/iov-one/weave/issues/180/comments","events_url":"https://api.github.com/repos/iov-one/weave/issues/180/events","html_url":"https://github.com/iov-one/weave/issues/180","id":379835491,"node_id":"MDU6SXNzdWUzNzk4MzU0OTE=","number":180,"title":"Use bech32 for address encoding format","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"labels":[{"id":1143198823,"node_id":"MDU6TGFiZWwxMTQzMTk4ODIz","url":"https://api.github.com/repos/iov-one/weave/labels/validated","name":"validated","color":"bdd600","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-12T15:46:36Z","updated_at":"2018-12-10T14:06:09Z","closed_at":"2018-12-10T14:06:09Z","author_association":"MEMBER","body":"While addresses are handled as 20 byte binary objects internally, we currently use a hex-encoding for them to display to users and parse input.\r\nhttps://github.com/iov-one/weave/blob/master/conditions.go#L87-L107\r\n\r\nWe have updated the client side library in iov-core to use bech32 encoding, with `{iov,tiov}` prefix.\r\n\r\nThis make a bit of issues when feeding addresses from clients to the genesis file, and similar issues. And it would be nicer to standardize.\r\n\r\nSince we need to declare an output prefix for serialization (and ensure it in parsing), we will likely need a global (module-wide) variable to hold this, set up in app initialization. So `iov, tiov, or other`. This should be configurable from genesis, ideally building on #202\r\n\r\ncosmos-sdk uses this bech32 lib https://github.com/btcsuite/btcutil/tree/master/bech32\r\nwe can use it, extract it, or find another one\r\n"},"comment":{"url":"https://api.github.com/repos/iov-one/weave/issues/comments/445826598","html_url":"https://github.com/iov-one/weave/issues/180#issuecomment-445826598","issue_url":"https://api.github.com/repos/iov-one/weave/issues/180","id":445826598,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTgyNjU5OA==","user":{"login":"ethanfrey","id":5689864,"node_id":"MDQ6VXNlcjU2ODk4NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5689864?v=4","gravatar_id":"","url":"https://api.github.com/users/ethanfrey","html_url":"https://github.com/ethanfrey","followers_url":"https://api.github.com/users/ethanfrey/followers","following_url":"https://api.github.com/users/ethanfrey/following{/other_user}","gists_url":"https://api.github.com/users/ethanfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanfrey/subscriptions","organizations_url":"https://api.github.com/users/ethanfrey/orgs","repos_url":"https://api.github.com/users/ethanfrey/repos","events_url":"https://api.github.com/users/ethanfrey/events{/privacy}","received_events_url":"https://api.github.com/users/ethanfrey/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T14:06:09Z","updated_at":"2018-12-10T14:06:09Z","author_association":"MEMBER","body":"Closing in favor of https://github.com/iov-one/iov-core/issues/602"}}
{"actor":{"display_login":"ethanfrey"}}