{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/web3.py/issues/998","repository_url":"https://api.github.com/repos/ethereum/web3.py","labels_url":"https://api.github.com/repos/ethereum/web3.py/issues/998/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/web3.py/issues/998/comments","events_url":"https://api.github.com/repos/ethereum/web3.py/issues/998/events","html_url":"https://github.com/ethereum/web3.py/pull/998","id":349379096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTA5MTM4","number":998,"title":"[WIP] Convert setup.py to preferred style for dependencies","user":{"login":"azeemansar","id":457391,"node_id":"MDQ6VXNlcjQ1NzM5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/457391?v=4","gravatar_id":"","url":"https://api.github.com/users/azeemansar","html_url":"https://github.com/azeemansar","followers_url":"https://api.github.com/users/azeemansar/followers","following_url":"https://api.github.com/users/azeemansar/following{/other_user}","gists_url":"https://api.github.com/users/azeemansar/gists{/gist_id}","starred_url":"https://api.github.com/users/azeemansar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azeemansar/subscriptions","organizations_url":"https://api.github.com/users/azeemansar/orgs","repos_url":"https://api.github.com/users/azeemansar/repos","events_url":"https://api.github.com/users/azeemansar/events{/privacy}","received_events_url":"https://api.github.com/users/azeemansar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-10T05:17:16Z","updated_at":"2018-08-28T20:32:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/web3.py/pulls/998","html_url":"https://github.com/ethereum/web3.py/pull/998","diff_url":"https://github.com/ethereum/web3.py/pull/998.diff","patch_url":"https://github.com/ethereum/web3.py/pull/998.patch"},"body":"### What was wrong?\r\n'setup.py' style for dependencies does not conform to other ethereum python projects.\r\n\r\nRelated to Issue #962 \r\n\r\n### How was it fixed?\r\nAs suggested, I emulated 'setup.py' from another project and moved 'extras_require' out of 'setup'. \r\n\r\nA couple of thoughts/issues:\r\n1/ Running tests yields the following error: \"DistributionNotFound: The 'web3' distribution was not found and is required by the application\" -> very similar to the error discussed here: https://gitter.im/pipermerriam/web3.py/archives/2016/04/15\r\n\r\n2/ I was looking around for docs to update with this change as the issue suggests, but I'm a little lost.\r\n\r\nThanks in advance for the help. This is my first web3.py pull request. I am excited to learn more about this project + hopefully continue to contribute!\r\n\r\n/cc @pipermerriam \r\n\r\n\r\n#### Cute Animal Picture\r\n\r\n![Put a link to a cute animal picture inside the parenthesis-->](http://www.martianherald.com/sites/default/files/styles/article_image_mobile_adaptive/adaptive-image/public/red-panda-cutest-animals.jpg?itok=AjGdCTg9)\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/web3.py/issues/comments/416730429","html_url":"https://github.com/ethereum/web3.py/pull/998#issuecomment-416730429","issue_url":"https://api.github.com/repos/ethereum/web3.py/issues/998","id":416730429,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjczMDQyOQ==","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T20:32:20Z","updated_at":"2018-08-28T20:32:20Z","author_association":"MEMBER","body":"re-running failed job"}}
{"actor":{"display_login":"pipermerriam"}}