{"push_id":2933082373,"size":11,"distinct_size":11,"ref":"refs/heads/master","head":"5c4481cc9bf9dfec3c35aaf5d95b08542ab8970b","before":"b35334aa98b75e4e166d30d673fd3bf1238dc7b7","commits":[{"sha":"3f2cf4dcd578d60fcdbbc28e720badffe8c15661","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Remove some leftovers from complaints\n\nThere were a couple of leftovers from earlier patches in\ncomplaints.[ch].  This removes them.\n\ngdb/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* complaints.h (struct complaints): Remove declaration.\n\t* complaints.c (clear_complaints): Remove an unused variable.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/3f2cf4dcd578d60fcdbbc28e720badffe8c15661"},{"sha":"9fdd7193e7fd041e9ff311a69dc02aecef53070f","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Fix off-by-one error in complaint_internal\n\ncomplaint_internal had an off-by-one error, where it would allow one\nextra complaint to be issued.\n\ngdb/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* complaints.c (complaint_internal): Correctly check complaint\n\tcount.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/9fdd7193e7fd041e9ff311a69dc02aecef53070f"},{"sha":"22068491adac735905948fd4c2e9aaacf9e22e06","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Use filtered printing when reading symbols\n\nWhile working on this series, I found some unfiltered prints that\ndidn't make sense -- many things, like complaints, are filtered, while\ntheir context (in this case the \"Reading symbols ...\"  messages) may\nnot be.\n\nThis patch changes some spots in symbol reading to use filtered\nprints.  I think this is preferable overall; in fact I'd go farther\nand say that unfiltered printing should just be removed.\n\nOne of these spots was not strictly related (the change to\ndump_psymtab), but I left it in partly because it makes psymtab.c\n\"unfiltered-clean\", and partly because it is an example of filtered\nand unfiltered printing being mixed in the same function.\n\ngdb/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* symfile.c (symbol_file_add_with_addrs, symbol_file_clear)\n\t(separate_debug_file_exists, find_separate_debug_file)\n\t(add_symbol_file_command, reread_symbols, allocate_symtab)\n\t(allocate_compunit_symtab): Use filtered printing, not\n\tunfiltered.\n\t* psymtab.c (require_partial_symbols, dump_psymtab)\n\t(allocate_psymtab): Use filtered printing, not unfiltered.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/22068491adac735905948fd4c2e9aaacf9e22e06"},{"sha":"6afcf761c2d8ffcb04ede75d1e670042e196bc5b","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Make complaint output prettier\n\nCurrently complaints are not always printed with a newline.  For\nexample, when I run gdb on itself, I see output like:\n\n    (gdb) set complaints 5\n    (gdb) file ./gdb/gdb\n    Reading symbols from ./gdb/gdb...DW_AT_low_pc 0x0 is zero for DIE at 0x437dd4 [in module /home/tromey/gdb/build/gdb/gdb]....debug_line address at offset 0x21bf9 is 0 [in module /home/tromey/gdb/build/gdb/gdb]...DW_AT_low_pc 0x0 is zero for DIE at 0x5a85dd [in module /home/tromey/gdb/build/gdb/gdb]....debug_line address at offset 0x2dc2d is 0 [in module /home/tromey/gdb/build/gdb/gdb]...DW_AT_low_pc 0x0 is zero for DIE at 0xab6033 [in module /home/tromey/gdb/build/gdb/gdb]....debug_line address at offset 0x4f683 is 0 [in module /home/tromey/gdb/build/gdb/gdb]...DW_AT_low_pc 0x0 is zero for DIE at 0x10028f0 [in module /home/tromey/gdb/build/gdb/gdb]....debug_line address at offset 0x75edf is 0 [in module /home/tromey/gdb/build/gdb/gdb]...DW_AT_low_pc 0x0 is zero for DIE at 0x1021364 [in module /home/tromey/gdb/build/gdb/gdb]....debug_line address at offset 0x76f62 is 0 [in module /home/tromey/gdb/build/gdb/gdb]...done.\n\nThat's one very long line.  I find it quite difficult to read that,\nand I thought it would be better with some newlines, which is what\nthis patch does.  Now the output looks like:\n\n    (gdb) file ./gdb\n    Reading symbols from ./gdb...\n    DW_AT_low_pc 0x0 is zero for DIE at 0x437dd4 [in module /home/tromey/gdb/build/gdb/gdb]\n    .debug_line address at offset 0x21bf9 is 0 [in module /home/tromey/gdb/build/gdb/gdb]\n    DW_AT_low_pc 0x0 is zero for DIE at 0x5a85dd [in module /home/tromey/gdb/build/gdb/gdb]\n    .debug_line address at offset 0x2dc2d is 0 [in module /home/tromey/gdb/build/gdb/gdb]\n    done.\n\ngdb/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\tPR cli/22234:\n\t* complaints.c: Emit \\n.\n\ngdb/testsuite/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\tPR cli/22234:\n\t* gdb.dwarf2/dw2-stack-boundary.exp: Update expected output.\n\t* gdb.gdb/complaints.exp (test_short_complaints): Update expected\n\toutput.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/6afcf761c2d8ffcb04ede75d1e670042e196bc5b"},{"sha":"3453e7e409f44a79ac6695589836edb8a49bfb08","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Clean up \"Reading symbols\" output\n\nThis patch is another attempt to fix PR cli/19551.  Unlike my previous\nattempt, it doesn't print progress.  Instead, it just changes some\nmessages and adds newlines to make the output a bit nicer.\n\nIt also removes the \"done.\" text that was previously emitted.  The\nidea here is that it is obvious when gdb is done reading debug info,\nas it starts then doing something else; and that while this message\ndid not provide much benefit to users, it did make it harder to make\nthe output clean.\n\nAfter this change the output from \"./gdb -iex 'set complaint 1' -nx ./gdb\"\nreads:\n\n    Reading symbols from ./gdb...\n    .debug_ranges entry has start address of zero [in module /home/tromey/gdb/build/gdb/gdb]\n    DW_AT_low_pc 0x0 is zero for DIE at 0x17116c1 [in module /home/tromey/gdb/build/gdb/gdb]\n    .debug_line address at offset 0xa22f5 is 0 [in module /home/tromey/gdb/build/gdb/gdb]\n    During symbol reading, unsupported tag: 'DW_TAG_unspecified_type'.\n    During symbol reading, const value length mismatch for 'std::ratio<1, 1000000000>::num', got 8, expected 0.\n\ngdb/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\tPR cli/19551:\n\t* symfile.c (symbol_file_add_with_addrs): Update output.\n\t* psymtab.c (require_partial_symbols): Update output.\n\ngdb/testsuite/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\tPR cli/19551:\n\t* lib/mi-support.exp (mi_gdb_file_cmd): Update.\n\t* lib/gdb.exp (gdb_file_cmd): Update.\n\t* gdb.stabs/weird.exp (print_weird_var): Update.\n\t* gdb.server/solib-list.exp: Update.\n\t* gdb.multi/remove-inferiors.exp (test_remove_inferiors): Update.\n\t* gdb.mi/mi-cli.exp: Update.\n\t* gdb.linespec/linespec.exp: Update.\n\t* gdb.dwarf2/dw2-stack-boundary.exp: Update.\n\t* gdb.dwarf2/dw2-objfile-overlap.exp: Update.\n\t* gdb.cp/cp-relocate.exp: Update.\n\t* gdb.base/sym-file.exp: Update.\n\t* gdb.base/relocate.exp: Update.\n\t* gdb.base/readnever.exp: Update.\n\t* gdb.base/print-symbol-loading.exp (test_load_core): Update.\n\t* gdb.base/kill-detach-inferiors-cmd.exp: Update.\n\t* gdb.base/dbx.exp (gdb_file_cmd): Update.\n\t* gdb.base/code_elim.exp: Update.\n\t* gdb.base/break-unload-file.exp (test_break): Update.\n\t* gdb.base/break-interp.exp (test_attach_gdb): Update.\n\t* gdb.base/break-idempotent.exp (force_breakpoint_re_set):\n\tUpdate.\n\t* gdb.base/attach.exp (do_attach_tests): Update.\n\t* gdb.base/sepdebug.exp: Update.\n\t* gdb.python/py-section-script.exp: Update.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/3453e7e409f44a79ac6695589836edb8a49bfb08"},{"sha":"e79497a160f38368688107520d7d1bd0aeafc1c7","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Only print \"no debugging symbols\" message once\n\nThe \"no debugging symbols\" message can be confusing in some cases, for\nexample when gdb finds separate debug info for an objfile, but the\nseparate debug info does not contain symbols.\n\nFor example:\n\n    (gdb) file /bin/ls\n    Reading symbols from /bin/ls...\n    Reading symbols from .gnu_debugdata for /usr/bin/ls...\n    (No debugging symbols found in .gnu_debugdata for /usr/bin/ls)\n    (No debugging symbols found in /bin/ls)\n\nHere, I think the second \"no debugging symbols\" message is redundant\nand confusing.\n\nThis patch changes gdb to only emit this message when the objfile in\nquestion does not have a separate debug file.  So, in the example\nabove, the output would now read:\n\n    (gdb) file /bin/ls\n    Reading symbols from /bin/ls...\n    Reading symbols from .gnu_debugdata for /usr/bin/ls...\n    (No debugging symbols found in .gnu_debugdata for /usr/bin/ls)\n\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* symfile.c (symbol_file_add_with_addrs): Do not print \"no\n\tdebugging symbols\" message if there is a separate debug objfile.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/e79497a160f38368688107520d7d1bd0aeafc1c7"},{"sha":"5ca8c39f059b30991b7090e7a662e4eb35d11133","author":{"name":"Tom Tromey","email":"96835dd8bfa718bd6447ccc87af89ae1675daeca@tromey.com"},"message":"Simplify complaints even more\n\nThis removes the SHORT_FIRST_MESSAGE case from complaints, leaving\nonly a single case.  This allows for the removal of the last argument\nto clear_complaints, and also simplifies complaint_internal, removing\nan extra allocation in the process.\n\nAfter this, the \"./gdb -iex 'set complaint 1' -nx ./gdb\" example will\nshow:\n\n    Reading symbols from ./gdb...\n    During symbol reading: .debug_ranges entry has start address of zero [in module /home/tromey/gdb/build/gdb/gdb]\n    During symbol reading: DW_AT_low_pc 0x0 is zero for DIE at 0x17116c1 [in module /home/tromey/gdb/build/gdb/gdb]\n    During symbol reading: .debug_line address at offset 0xa22f5 is 0 [in module /home/tromey/gdb/build/gdb/gdb]\n    During symbol reading: unsupported tag: 'DW_TAG_unspecified_type'\n    During symbol reading: const value length mismatch for 'std::ratio<1, 1000000000>::num', got 8, expected 0\n\nThis is a bit wordier but, I think, a bit more clear, as the form of\nthe message no longer depends on precisely when it was emitted.  In\nparticular if you compare to the output from the 'Clean up \"Reading\nsymbols\" output' patch, you can see that earlier gdb would switch from\nthe prefix-less form to the \"During symbol reading\" form at a point\nthat is meaningless to the user (specifically, after psymtab reading\nis done and gdb tries to expand a CU).\n\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* symfile.c (syms_from_objfile_1, finish_new_objfile)\n\t(reread_symbols): Update.\n\t* complaints.h (clear_complaints): Remove argument.\n\t* complaints.c (enum complaint_series): Remove.\n\t(series): Remove global.\n\t(complaint_internal): Update.\n\t(clear_complaints): Remove argument.\n\ngdb/testsuite/ChangeLog\n2018-10-04  Tom Tromey  <tom@tromey.com>\n\n\t* gdb.cp/maint.exp (test_invalid_name): Update expected output.\n\t* gdb.gdb/complaints.exp (test_short_complaints): Remove.\n\t(test_initial_complaints, test_empty_complaints): Update.\n\t* gdb.dwarf2/dw2-stack-boundary.exp: Update.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/5ca8c39f059b30991b7090e7a662e4eb35d11133"},{"sha":"3e1b4df89cfa5171c52245d79434774f4b570ae1","author":{"name":"Jim Wilson","email":"fe9a0fb1a3713960ed8e536d397a90bc034f5164@sifive.com"},"message":"RISC-V: Delete zero-size .tdata.dyn section.\n\n\tbfd/\n\t* elfnn-riscv.c (riscv_elf_size_dynamic_sections): In dynobj->sections\n\tloop, handle htab->sdyntdata section.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/3e1b4df89cfa5171c52245d79434774f4b570ae1"},{"sha":"d2f7dcb218cc281288a5c3ea800a186c68f9d2ae","author":{"name":"Joel Brobecker","email":"c7e71725c97f9c37b4edbe71d193d6b3659aa171@adacore.com"},"message":"reformat parameters of gdb/psymtab.c::recursively_search_psymtabs\n\nThis is just to make sure one of the parameters doesn't end past\nthe 80 characters limit. And while at it, since all parameters were\non their own line except the first two that were listed on the same\nline, it felf more consistent to just split them to have each and\nevery parameter on their own line.\n\ngdb/ChangeLog:\n\n        * psymtab.c (recursively_search_psymtabs): Reformat parameters\n        to avoid exceeding 80 characters per line limit.\n\nTested by rebuilding GDB on x86_64-linux.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/d2f7dcb218cc281288a5c3ea800a186c68f9d2ae"},{"sha":"96b1ad866b1c861f772c5a11b556766c73c3d1ab","author":{"name":"Tom de Vries","email":"22731dc8ae0a9ff9ab14d7e7d3c3c5590eccb114@suse.de"},"message":"[gdb/python] Fix cpychecker error in recpy_bt_goto\n\nWhen using cpychecker, we run into this error:\n...\ngdb/python/py-record-btrace.c: \\\n  In function ‘PyObject* recpy_bt_goto(PyObject*, PyObject*)’:\ngdb/python/py-record-btrace.c:783:25: error: Mismatching type in call to \\\n  PyArg_ParseTuple with format code \"O\" [-Werror]\n   if (!PyArg_ParseTuple (args, \"O\", &obj))\n  argument 3 (\"&obj\") had type\n    \"const struct recpy_element_object * *\"\n  but was expecting\n    \"struct PyObject * *\"\n  for format code \"O\"\n...\n\nFix this by using a new variable of the expected type instead.\n\nBuild and reg-tested on x86_64-linux.\n\n2018-10-05  Tom de Vries  <tdevries@suse.de>\n\n\t* python/py-record-btrace.c (recpy_bt_goto): Fix type mismatch in\n\tPyArg_ParseTuple call.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/96b1ad866b1c861f772c5a11b556766c73c3d1ab"},{"sha":"5c4481cc9bf9dfec3c35aaf5d95b08542ab8970b","author":{"name":"Tom de Vries","email":"22731dc8ae0a9ff9ab14d7e7d3c3c5590eccb114@suse.de"},"message":"[gdb/python] Fix cpychecker error in pspy_solib_name\n\nWhen using cpychecker, we run into:\n...\ngdb/python/py-progspace.c: \\\n  In function ‘PyObject* pspy_solib_name(PyObject*, PyObject*)’:\ngdb/python/py-progspace.c:370:25: error: Mismatching type in call to \\\n  PyArg_ParseTuple with format code \"K\" [-Werror]\n   if (!PyArg_ParseTuple (args, GDB_PY_LLU_ARG, &pc))\n  argument 3 (\"&pc\") had type\n    \"gdb_py_longest *\" (pointing to 64 bits)\n  but was expecting\n    \"long long unsigned int *\" (pointing to 64 bits)\n  for format code \"K\"\n...\n\nFix this fixing the type of the variable.\n\nBuild and reg-tested on x86_64-linux.\n\n2018-10-05  Tom de Vries  <tdevries@suse.de>\n\n\t* python/py-progspace.c (pspy_solib_name): Fix type mismatch in\n\tPyArg_ParseTuple call.","distinct":true,"url":"https://api.github.com/repos/kraj/binutils-gdb/commits/5c4481cc9bf9dfec3c35aaf5d95b08542ab8970b"}]}
{"actor":{"display_login":"kraj"}}