{"action":"closed","number":272,"pull_request":{"url":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272","id":201770248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzcwMjQ4","html_url":"https://github.com/18F/fs-permit-platform/pull/272","diff_url":"https://github.com/18F/fs-permit-platform/pull/272.diff","patch_url":"https://github.com/18F/fs-permit-platform/pull/272.patch","issue_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/272","number":272,"state":"closed","locked":false,"title":"delete unused key to populate fields","user":{"login":"lauraGgit","id":5840989,"node_id":"MDQ6VXNlcjU4NDA5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/5840989?v=4","gravatar_id":"","url":"https://api.github.com/users/lauraGgit","html_url":"https://github.com/lauraGgit","followers_url":"https://api.github.com/users/lauraGgit/followers","following_url":"https://api.github.com/users/lauraGgit/following{/other_user}","gists_url":"https://api.github.com/users/lauraGgit/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraGgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraGgit/subscriptions","organizations_url":"https://api.github.com/users/lauraGgit/orgs","repos_url":"https://api.github.com/users/lauraGgit/repos","events_url":"https://api.github.com/users/lauraGgit/events{/privacy}","received_events_url":"https://api.github.com/users/lauraGgit/received_events","type":"User","site_admin":false},"body":"the angular API expects a 1:1 ratio for formControls and object keys, but we don't have a `controlNumber` at this point so the form breaks. Deleting that key works (and you can fully submit the app with this), but from an angular perspective, I'm not sure if this is the best way to handle that.\r\n\r\nThe other way would be to pass a hidden field? But seems like that's not particularly Angular 2 friendly as well.","created_at":"2018-07-16T21:51:00Z","updated_at":"2018-07-24T20:38:12Z","closed_at":"2018-07-24T20:38:12Z","merged_at":null,"merge_commit_sha":"ef43ca5f2158153d94bc00bc1971f303405e656f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272/commits","review_comments_url":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272/comments","review_comment_url":"https://api.github.com/repos/18F/fs-permit-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/272/comments","statuses_url":"https://api.github.com/repos/18F/fs-permit-platform/statuses/3b26aa93257bf84921d0892fa1f6c65340c504fc","head":{"label":"18F:161_event_name","ref":"161_event_name","sha":"3b26aa93257bf84921d0892fa1f6c65340c504fc","user":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":88538878,"node_id":"MDEwOlJlcG9zaXRvcnk4ODUzODg3OA==","name":"fs-permit-platform","full_name":"18F/fs-permit-platform","owner":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/fs-permit-platform","description":"Module for intake of special use applications for Forest Service Application Permits","fork":false,"url":"https://api.github.com/repos/18F/fs-permit-platform","forks_url":"https://api.github.com/repos/18F/fs-permit-platform/forks","keys_url":"https://api.github.com/repos/18F/fs-permit-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/fs-permit-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/fs-permit-platform/teams","hooks_url":"https://api.github.com/repos/18F/fs-permit-platform/hooks","issue_events_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/events{/number}","events_url":"https://api.github.com/repos/18F/fs-permit-platform/events","assignees_url":"https://api.github.com/repos/18F/fs-permit-platform/assignees{/user}","branches_url":"https://api.github.com/repos/18F/fs-permit-platform/branches{/branch}","tags_url":"https://api.github.com/repos/18F/fs-permit-platform/tags","blobs_url":"https://api.github.com/repos/18F/fs-permit-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/fs-permit-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/fs-permit-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/fs-permit-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/fs-permit-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/fs-permit-platform/languages","stargazers_url":"https://api.github.com/repos/18F/fs-permit-platform/stargazers","contributors_url":"https://api.github.com/repos/18F/fs-permit-platform/contributors","subscribers_url":"https://api.github.com/repos/18F/fs-permit-platform/subscribers","subscription_url":"https://api.github.com/repos/18F/fs-permit-platform/subscription","commits_url":"https://api.github.com/repos/18F/fs-permit-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/fs-permit-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/fs-permit-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/fs-permit-platform/contents/{+path}","compare_url":"https://api.github.com/repos/18F/fs-permit-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/fs-permit-platform/merges","archive_url":"https://api.github.com/repos/18F/fs-permit-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/fs-permit-platform/downloads","issues_url":"https://api.github.com/repos/18F/fs-permit-platform/issues{/number}","pulls_url":"https://api.github.com/repos/18F/fs-permit-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/fs-permit-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/fs-permit-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/fs-permit-platform/labels{/name}","releases_url":"https://api.github.com/repos/18F/fs-permit-platform/releases{/id}","deployments_url":"https://api.github.com/repos/18F/fs-permit-platform/deployments","created_at":"2017-04-17T18:40:09Z","updated_at":"2018-07-24T18:52:51Z","pushed_at":"2018-07-24T20:34:39Z","git_url":"git://github.com/18F/fs-permit-platform.git","ssh_url":"git@github.com:18F/fs-permit-platform.git","clone_url":"https://github.com/18F/fs-permit-platform.git","svn_url":"https://github.com/18F/fs-permit-platform","homepage":null,"size":353060,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":53,"watchers":7,"default_branch":"dev"}},"base":{"label":"18F:161_populate_form","ref":"161_populate_form","sha":"679fc9fc2d94f5b4e0576874111277f053362b36","user":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":88538878,"node_id":"MDEwOlJlcG9zaXRvcnk4ODUzODg3OA==","name":"fs-permit-platform","full_name":"18F/fs-permit-platform","owner":{"login":"18F","id":6233994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMzM5OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/fs-permit-platform","description":"Module for intake of special use applications for Forest Service Application Permits","fork":false,"url":"https://api.github.com/repos/18F/fs-permit-platform","forks_url":"https://api.github.com/repos/18F/fs-permit-platform/forks","keys_url":"https://api.github.com/repos/18F/fs-permit-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/fs-permit-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/fs-permit-platform/teams","hooks_url":"https://api.github.com/repos/18F/fs-permit-platform/hooks","issue_events_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/events{/number}","events_url":"https://api.github.com/repos/18F/fs-permit-platform/events","assignees_url":"https://api.github.com/repos/18F/fs-permit-platform/assignees{/user}","branches_url":"https://api.github.com/repos/18F/fs-permit-platform/branches{/branch}","tags_url":"https://api.github.com/repos/18F/fs-permit-platform/tags","blobs_url":"https://api.github.com/repos/18F/fs-permit-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/fs-permit-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/fs-permit-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/fs-permit-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/fs-permit-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/fs-permit-platform/languages","stargazers_url":"https://api.github.com/repos/18F/fs-permit-platform/stargazers","contributors_url":"https://api.github.com/repos/18F/fs-permit-platform/contributors","subscribers_url":"https://api.github.com/repos/18F/fs-permit-platform/subscribers","subscription_url":"https://api.github.com/repos/18F/fs-permit-platform/subscription","commits_url":"https://api.github.com/repos/18F/fs-permit-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/fs-permit-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/fs-permit-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/fs-permit-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/fs-permit-platform/contents/{+path}","compare_url":"https://api.github.com/repos/18F/fs-permit-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/fs-permit-platform/merges","archive_url":"https://api.github.com/repos/18F/fs-permit-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/fs-permit-platform/downloads","issues_url":"https://api.github.com/repos/18F/fs-permit-platform/issues{/number}","pulls_url":"https://api.github.com/repos/18F/fs-permit-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/fs-permit-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/fs-permit-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/fs-permit-platform/labels{/name}","releases_url":"https://api.github.com/repos/18F/fs-permit-platform/releases{/id}","deployments_url":"https://api.github.com/repos/18F/fs-permit-platform/deployments","created_at":"2017-04-17T18:40:09Z","updated_at":"2018-07-24T18:52:51Z","pushed_at":"2018-07-24T20:34:39Z","git_url":"git://github.com/18F/fs-permit-platform.git","ssh_url":"git@github.com:18F/fs-permit-platform.git","clone_url":"https://github.com/18F/fs-permit-platform.git","svn_url":"https://github.com/18F/fs-permit-platform","homepage":null,"size":353060,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":53,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272"},"html":{"href":"https://github.com/18F/fs-permit-platform/pull/272"},"issue":{"href":"https://api.github.com/repos/18F/fs-permit-platform/issues/272"},"comments":{"href":"https://api.github.com/repos/18F/fs-permit-platform/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/fs-permit-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/fs-permit-platform/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/18F/fs-permit-platform/statuses/3b26aa93257bf84921d0892fa1f6c65340c504fc"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"lauraGgit"}}