{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/1554","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/1554/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/1554/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/1554/events","html_url":"https://github.com/batfish/batfish/pull/1554","id":328628345,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTE3NjM3","number":1554,"title":"fix juniper wildcard handling","user":{"login":"arifogel","id":7737874,"node_id":"MDQ6VXNlcjc3Mzc4NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7737874?v=4","gravatar_id":"","url":"https://api.github.com/users/arifogel","html_url":"https://github.com/arifogel","followers_url":"https://api.github.com/users/arifogel/followers","following_url":"https://api.github.com/users/arifogel/following{/other_user}","gists_url":"https://api.github.com/users/arifogel/gists{/gist_id}","starred_url":"https://api.github.com/users/arifogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifogel/subscriptions","organizations_url":"https://api.github.com/users/arifogel/orgs","repos_url":"https://api.github.com/users/arifogel/repos","events_url":"https://api.github.com/users/arifogel/events{/privacy}","received_events_url":"https://api.github.com/users/arifogel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-01T19:05:23Z","updated_at":"2018-06-01T20:09:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/1554","html_url":"https://github.com/batfish/batfish/pull/1554","diff_url":"https://github.com/batfish/batfish/pull/1554.diff","patch_url":"https://github.com/batfish/batfish/pull/1554.patch"},"body":"Fix improper pruning of strings that look like wildcards but did not get generated via `apply-groups`.\r\n\r\nImplementation:\r\n- Create new virtual token called `WILDCARD_ARTIFACT` that is used instead of `WILDCARD` when generating lines.\r\n- Prune only lines with `WILDCARD_ARTIFACT` instead of `WILDCARD` as before\r\n- Update parser rules to allow `WILDCARD` or `WILDCARD_ARTIFACT` via new rule `wildcard` so parsing during group line generation phase still works\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/393995684","html_url":"https://github.com/batfish/batfish/pull/1554#issuecomment-393995684","issue_url":"https://api.github.com/repos/batfish/batfish/issues/1554","id":393995684,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzk5NTY4NA==","user":{"login":"arifogel","id":7737874,"node_id":"MDQ6VXNlcjc3Mzc4NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7737874?v=4","gravatar_id":"","url":"https://api.github.com/users/arifogel","html_url":"https://github.com/arifogel","followers_url":"https://api.github.com/users/arifogel/followers","following_url":"https://api.github.com/users/arifogel/following{/other_user}","gists_url":"https://api.github.com/users/arifogel/gists{/gist_id}","starred_url":"https://api.github.com/users/arifogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifogel/subscriptions","organizations_url":"https://api.github.com/users/arifogel/orgs","repos_url":"https://api.github.com/users/arifogel/repos","events_url":"https://api.github.com/users/arifogel/events{/privacy}","received_events_url":"https://api.github.com/users/arifogel/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T20:09:34Z","updated_at":"2018-06-01T20:09:34Z","author_association":"MEMBER","body":"\n\n\n\nReview status: 10 of 24 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers/ConfigurationMatchersImpl.java, line 161 at r1](https://reviewable.io/reviews/batfish/batfish/1554#-LDwkBco49-RoL-BwiyH:-LDwxc0s5MMae4Nk7dHp:b-886gsx) ([raw file](https://github.com/batfish/batfish/blob/3641c603edff35de3f2577ffdeb1fa55f25991cc/projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers/ConfigurationMatchersImpl.java#L161)):*\n<details><summary><i>Previously, dhalperi (Dan Halperin) wrote…</i></summary><blockquote>\n\n> ```\n> RouteFilterLists:\", \"routeFilterLists\"\n> ```\n\nwhat's the style recommendation here? are they supposed to be identical?  (`R` vs `r`?)\n</blockquote></details>\n\nFixed\n\n---\n\n*[projects/batfish/src/main/antlr4/org/batfish/grammar/flatjuniper/FlatJuniper_routing_instances.g4, line 229 at r1](https://reviewable.io/reviews/batfish/batfish/1554#-LDwkexG5KKVI0WNLO-r:-LDwxhDpBV8ePI3lq1XE:bpmpfqa) ([raw file](https://github.com/batfish/batfish/blob/3641c603edff35de3f2577ffdeb1fa55f25991cc/projects/batfish/src/main/antlr4/org/batfish/grammar/flatjuniper/FlatJuniper_routing_instances.g4#L229)):*\n<details><summary><i>Previously, dhalperi (Dan Halperin) wrote…</i></summary><blockquote>\n\n> ```\n> VARIABLE\n> ```\n\nvs `variable`? Remind me how you choose?\n</blockquote></details>\n\nOut of scope, but I generally avoid referring to `VARIABLE` ever, because it improperly prevents names that are built-in keywords. This should be changed to `variable`.\n\n---\n\n*[projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java, line 1333 at r1](https://reviewable.io/reviews/batfish/batfish/1554#-LDwlUBbEAQ3cuCt2ZTN:-LDwxuuw3xylzlt3dg8-:ba3dfob) ([raw file](https://github.com/batfish/batfish/blob/3641c603edff35de3f2577ffdeb1fa55f25991cc/projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java#L1333)):*\n<details><summary><i>Previously, dhalperi (Dan Halperin) wrote…</i></summary><blockquote>\n\nno println\n</blockquote></details>\n\nRemoved\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/batfish/batfish/1554)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"arifogel"}}