{"action":"created","comment":{"url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/comments/214190573","pull_request_review_id":151194252,"id":214190573,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE5MDU3Mw==","diff_hunk":"@@ -60,6 +60,26 @@ if (argv[0] == 'server') {\n   config.keys = keys\n   var server = createSbot(config)\n \n+  server.on('rpc:connect', function (rpc, isClient) {\n+    if (rpc.id == '@' + keys.public) return\n+\n+    pull(\n+      server.friends.hopStream(),","path":"bin.js","position":8,"original_position":8,"commit_id":"f6ff76e7c59a15ea93c30516caef24c65ae124cc","original_commit_id":"f6ff76e7c59a15ea93c30516caef24c65ae124cc","user":{"login":"cryptix","id":111202,"node_id":"MDQ6VXNlcjExMTIwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/111202?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptix","html_url":"https://github.com/cryptix","followers_url":"https://api.github.com/users/cryptix/followers","following_url":"https://api.github.com/users/cryptix/following{/other_user}","gists_url":"https://api.github.com/users/cryptix/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptix/subscriptions","organizations_url":"https://api.github.com/users/cryptix/orgs","repos_url":"https://api.github.com/users/cryptix/repos","events_url":"https://api.github.com/users/cryptix/events{/privacy}","received_events_url":"https://api.github.com/users/cryptix/received_events","type":"User","site_admin":false},"body":"do we have to worry about dangling streams of these?\r\n\r\nwill they emit values after the connection has been handled?","created_at":"2018-08-30T21:44:15Z","updated_at":"2018-08-30T21:45:23Z","html_url":"https://github.com/ssbc/scuttlebot/pull/530#discussion_r214190573","pull_request_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/comments/214190573"},"html":{"href":"https://github.com/ssbc/scuttlebot/pull/530#discussion_r214190573"},"pull_request":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530"}}},"pull_request":{"url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530","id":212213257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjEzMjU3","html_url":"https://github.com/ssbc/scuttlebot/pull/530","diff_url":"https://github.com/ssbc/scuttlebot/pull/530.diff","patch_url":"https://github.com/ssbc/scuttlebot/pull/530.patch","issue_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/530","number":530,"state":"open","locked":false,"title":"Respect hops for incoming and outgoing connections","user":{"login":"arj03","id":350682,"node_id":"MDQ6VXNlcjM1MDY4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/350682?v=4","gravatar_id":"","url":"https://api.github.com/users/arj03","html_url":"https://github.com/arj03","followers_url":"https://api.github.com/users/arj03/followers","following_url":"https://api.github.com/users/arj03/following{/other_user}","gists_url":"https://api.github.com/users/arj03/gists{/gist_id}","starred_url":"https://api.github.com/users/arj03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arj03/subscriptions","organizations_url":"https://api.github.com/users/arj03/orgs","repos_url":"https://api.github.com/users/arj03/repos","events_url":"https://api.github.com/users/arj03/events{/privacy}","received_events_url":"https://api.github.com/users/arj03/received_events","type":"User","site_admin":false},"body":"The idea with this pull request is that we shouldn't allow connections with any peers outside our hops. As it is now, sbot can connect to anyone but will only sync feeds within our hops. \r\n\r\nThe biggest reason for this change is that right now anyone can connect to any peer and start requesting all feeds and thus map the whole network and use this for whatever reason they might have.","created_at":"2018-08-30T21:14:26Z","updated_at":"2018-08-30T21:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60b1927b9aa0ed2c34a3a5a3fc736dfafd6c533e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530/commits","review_comments_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530/comments","review_comment_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/530/comments","statuses_url":"https://api.github.com/repos/ssbc/scuttlebot/statuses/f6ff76e7c59a15ea93c30516caef24c65ae124cc","head":{"label":"ssbc:respect-hops-in-connections","ref":"respect-hops-in-connections","sha":"f6ff76e7c59a15ea93c30516caef24c65ae124cc","user":{"login":"ssbc","id":10190339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTkwMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/10190339?v=4","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"repo":{"id":25894747,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg5NDc0Nw==","name":"scuttlebot","full_name":"ssbc/scuttlebot","owner":{"login":"ssbc","id":10190339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTkwMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/10190339?v=4","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ssbc/scuttlebot","description":"The gossip and replication server for Secure Scuttlebutt - a distributed social network","fork":false,"url":"https://api.github.com/repos/ssbc/scuttlebot","forks_url":"https://api.github.com/repos/ssbc/scuttlebot/forks","keys_url":"https://api.github.com/repos/ssbc/scuttlebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssbc/scuttlebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssbc/scuttlebot/teams","hooks_url":"https://api.github.com/repos/ssbc/scuttlebot/hooks","issue_events_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/events{/number}","events_url":"https://api.github.com/repos/ssbc/scuttlebot/events","assignees_url":"https://api.github.com/repos/ssbc/scuttlebot/assignees{/user}","branches_url":"https://api.github.com/repos/ssbc/scuttlebot/branches{/branch}","tags_url":"https://api.github.com/repos/ssbc/scuttlebot/tags","blobs_url":"https://api.github.com/repos/ssbc/scuttlebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssbc/scuttlebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssbc/scuttlebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssbc/scuttlebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssbc/scuttlebot/statuses/{sha}","languages_url":"https://api.github.com/repos/ssbc/scuttlebot/languages","stargazers_url":"https://api.github.com/repos/ssbc/scuttlebot/stargazers","contributors_url":"https://api.github.com/repos/ssbc/scuttlebot/contributors","subscribers_url":"https://api.github.com/repos/ssbc/scuttlebot/subscribers","subscription_url":"https://api.github.com/repos/ssbc/scuttlebot/subscription","commits_url":"https://api.github.com/repos/ssbc/scuttlebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssbc/scuttlebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssbc/scuttlebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssbc/scuttlebot/contents/{+path}","compare_url":"https://api.github.com/repos/ssbc/scuttlebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssbc/scuttlebot/merges","archive_url":"https://api.github.com/repos/ssbc/scuttlebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssbc/scuttlebot/downloads","issues_url":"https://api.github.com/repos/ssbc/scuttlebot/issues{/number}","pulls_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls{/number}","milestones_url":"https://api.github.com/repos/ssbc/scuttlebot/milestones{/number}","notifications_url":"https://api.github.com/repos/ssbc/scuttlebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssbc/scuttlebot/labels{/name}","releases_url":"https://api.github.com/repos/ssbc/scuttlebot/releases{/id}","deployments_url":"https://api.github.com/repos/ssbc/scuttlebot/deployments","created_at":"2014-10-28T23:23:16Z","updated_at":"2018-08-30T07:19:24Z","pushed_at":"2018-08-30T21:14:27Z","git_url":"git://github.com/ssbc/scuttlebot.git","ssh_url":"git@github.com:ssbc/scuttlebot.git","clone_url":"https://github.com/ssbc/scuttlebot.git","svn_url":"https://github.com/ssbc/scuttlebot","homepage":"http://scuttlebot.io/","size":2257,"stargazers_count":904,"watchers_count":904,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":141,"license":null,"forks":106,"open_issues":141,"watchers":904,"default_branch":"master"}},"base":{"label":"ssbc:master","ref":"master","sha":"314aaf9b9294deb41b1931a63c55a3573af37a64","user":{"login":"ssbc","id":10190339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTkwMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/10190339?v=4","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"repo":{"id":25894747,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg5NDc0Nw==","name":"scuttlebot","full_name":"ssbc/scuttlebot","owner":{"login":"ssbc","id":10190339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTkwMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/10190339?v=4","gravatar_id":"","url":"https://api.github.com/users/ssbc","html_url":"https://github.com/ssbc","followers_url":"https://api.github.com/users/ssbc/followers","following_url":"https://api.github.com/users/ssbc/following{/other_user}","gists_url":"https://api.github.com/users/ssbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ssbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssbc/subscriptions","organizations_url":"https://api.github.com/users/ssbc/orgs","repos_url":"https://api.github.com/users/ssbc/repos","events_url":"https://api.github.com/users/ssbc/events{/privacy}","received_events_url":"https://api.github.com/users/ssbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ssbc/scuttlebot","description":"The gossip and replication server for Secure Scuttlebutt - a distributed social network","fork":false,"url":"https://api.github.com/repos/ssbc/scuttlebot","forks_url":"https://api.github.com/repos/ssbc/scuttlebot/forks","keys_url":"https://api.github.com/repos/ssbc/scuttlebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssbc/scuttlebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssbc/scuttlebot/teams","hooks_url":"https://api.github.com/repos/ssbc/scuttlebot/hooks","issue_events_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/events{/number}","events_url":"https://api.github.com/repos/ssbc/scuttlebot/events","assignees_url":"https://api.github.com/repos/ssbc/scuttlebot/assignees{/user}","branches_url":"https://api.github.com/repos/ssbc/scuttlebot/branches{/branch}","tags_url":"https://api.github.com/repos/ssbc/scuttlebot/tags","blobs_url":"https://api.github.com/repos/ssbc/scuttlebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssbc/scuttlebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssbc/scuttlebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssbc/scuttlebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssbc/scuttlebot/statuses/{sha}","languages_url":"https://api.github.com/repos/ssbc/scuttlebot/languages","stargazers_url":"https://api.github.com/repos/ssbc/scuttlebot/stargazers","contributors_url":"https://api.github.com/repos/ssbc/scuttlebot/contributors","subscribers_url":"https://api.github.com/repos/ssbc/scuttlebot/subscribers","subscription_url":"https://api.github.com/repos/ssbc/scuttlebot/subscription","commits_url":"https://api.github.com/repos/ssbc/scuttlebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssbc/scuttlebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssbc/scuttlebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssbc/scuttlebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssbc/scuttlebot/contents/{+path}","compare_url":"https://api.github.com/repos/ssbc/scuttlebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssbc/scuttlebot/merges","archive_url":"https://api.github.com/repos/ssbc/scuttlebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssbc/scuttlebot/downloads","issues_url":"https://api.github.com/repos/ssbc/scuttlebot/issues{/number}","pulls_url":"https://api.github.com/repos/ssbc/scuttlebot/pulls{/number}","milestones_url":"https://api.github.com/repos/ssbc/scuttlebot/milestones{/number}","notifications_url":"https://api.github.com/repos/ssbc/scuttlebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssbc/scuttlebot/labels{/name}","releases_url":"https://api.github.com/repos/ssbc/scuttlebot/releases{/id}","deployments_url":"https://api.github.com/repos/ssbc/scuttlebot/deployments","created_at":"2014-10-28T23:23:16Z","updated_at":"2018-08-30T07:19:24Z","pushed_at":"2018-08-30T21:14:27Z","git_url":"git://github.com/ssbc/scuttlebot.git","ssh_url":"git@github.com:ssbc/scuttlebot.git","clone_url":"https://github.com/ssbc/scuttlebot.git","svn_url":"https://github.com/ssbc/scuttlebot","homepage":"http://scuttlebot.io/","size":2257,"stargazers_count":904,"watchers_count":904,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":141,"license":null,"forks":106,"open_issues":141,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530"},"html":{"href":"https://github.com/ssbc/scuttlebot/pull/530"},"issue":{"href":"https://api.github.com/repos/ssbc/scuttlebot/issues/530"},"comments":{"href":"https://api.github.com/repos/ssbc/scuttlebot/issues/530/comments"},"review_comments":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530/comments"},"review_comment":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ssbc/scuttlebot/pulls/530/commits"},"statuses":{"href":"https://api.github.com/repos/ssbc/scuttlebot/statuses/f6ff76e7c59a15ea93c30516caef24c65ae124cc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cryptix"}}