{"action":"created","comment":{"url":"https://api.github.com/repos/a-canary/trafficserver/pulls/comments/168863541","pull_request_review_id":97308339,"id":168863541,"diff_hunk":"@@ -0,0 +1,254 @@\n+#pragma once\n+#ifndef _PropertyBlock_h\n+#define _PropertyBlock_h\n+\n+#include \"stdint.h\"\n+#include <cstddef>\n+#include <atomic>\n+#include <cstring>\n+#include <vector>\n+#include <type_traits>\n+\n+#include \"ts/ink_assert.h\"\n+\n+/// runtime defined static container\n+/** The size of this structure is actually zero, so it will not change the size of your derived class.\n+ * But new and delete are overriden to use allocate enough bytes of the derived type + properties added\n+ * at run time using ioBufferAllocator.\n+ *\n+ * Also all bools are packed to save space using the *Bit methods.\n+ *\n+ * This is templated so static variables are instanced per Derived type. B/c we need to have different\n+ * size property sets.\n+ */\n+template <class Derived_t> ///< static members instance pey type.\n+struct PropertyBlock {\n+public:\n+  using self_t = PropertyBlock<Derived_t>;","path":"iocore/utils/PropertyBlock.h","position":27,"original_position":27,"commit_id":"b7ce4bc104cce1a92c92d821aac2e31b1aff4361","original_commit_id":"b7ce4bc104cce1a92c92d821aac2e31b1aff4361","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars2.githubusercontent.com/u/1545753?v=4","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"body":"Jason has forced us all to use `self_type` for this.","created_at":"2018-02-16T20:33:38Z","updated_at":"2018-02-16T20:33:38Z","html_url":"https://github.com/a-canary/trafficserver/pull/3#discussion_r168863541","pull_request_url":"https://api.github.com/repos/a-canary/trafficserver/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/comments/168863541"},"html":{"href":"https://github.com/a-canary/trafficserver/pull/3#discussion_r168863541"},"pull_request":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/a-canary/trafficserver/pulls/3","id":169714985,"html_url":"https://github.com/a-canary/trafficserver/pull/3","diff_url":"https://github.com/a-canary/trafficserver/pull/3.diff","patch_url":"https://github.com/a-canary/trafficserver/pull/3.patch","issue_url":"https://api.github.com/repos/a-canary/trafficserver/issues/3","number":3,"state":"open","locked":false,"title":"NextHop WIP PropertyBlocks and Host data structures.","user":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"body":"It's all written in header files right now. It should be more readable when I move the code to .cc files.\r\n\r\nI'll be concerned if there are no red flags. ","created_at":"2018-02-16T20:11:05Z","updated_at":"2018-02-16T20:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b98fee2d38c1ae9b50653523a7ea5ac7c1804973","assignee":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"assignees":[{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/a-canary/trafficserver/pulls/3/commits","review_comments_url":"https://api.github.com/repos/a-canary/trafficserver/pulls/3/comments","review_comment_url":"https://api.github.com/repos/a-canary/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/a-canary/trafficserver/issues/3/comments","statuses_url":"https://api.github.com/repos/a-canary/trafficserver/statuses/b7ce4bc104cce1a92c92d821aac2e31b1aff4361","head":{"label":"a-canary:NextHop.WIP","ref":"NextHop.WIP","sha":"b7ce4bc104cce1a92c92d821aac2e31b1aff4361","user":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"repo":{"id":91623083,"name":"trafficserver","full_name":"a-canary/trafficserver","owner":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-canary/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/a-canary/trafficserver","forks_url":"https://api.github.com/repos/a-canary/trafficserver/forks","keys_url":"https://api.github.com/repos/a-canary/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-canary/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-canary/trafficserver/teams","hooks_url":"https://api.github.com/repos/a-canary/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/a-canary/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/a-canary/trafficserver/events","assignees_url":"https://api.github.com/repos/a-canary/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/a-canary/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/a-canary/trafficserver/tags","blobs_url":"https://api.github.com/repos/a-canary/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-canary/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-canary/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-canary/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-canary/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/a-canary/trafficserver/languages","stargazers_url":"https://api.github.com/repos/a-canary/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/a-canary/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/a-canary/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/a-canary/trafficserver/subscription","commits_url":"https://api.github.com/repos/a-canary/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-canary/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-canary/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-canary/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-canary/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/a-canary/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-canary/trafficserver/merges","archive_url":"https://api.github.com/repos/a-canary/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-canary/trafficserver/downloads","issues_url":"https://api.github.com/repos/a-canary/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/a-canary/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/a-canary/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/a-canary/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-canary/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/a-canary/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/a-canary/trafficserver/deployments","created_at":"2017-05-17T21:49:33Z","updated_at":"2017-05-17T21:49:42Z","pushed_at":"2018-02-16T20:11:06Z","git_url":"git://github.com/a-canary/trafficserver.git","ssh_url":"git@github.com:a-canary/trafficserver.git","clone_url":"https://github.com/a-canary/trafficserver.git","svn_url":"https://github.com/a-canary/trafficserver","homepage":null,"size":78475,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"a-canary:master","ref":"master","sha":"5ed6a72d775d9e9521401eb2e112e4d8ea8af3d7","user":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"repo":{"id":91623083,"name":"trafficserver","full_name":"a-canary/trafficserver","owner":{"login":"a-canary","id":24980792,"avatar_url":"https://avatars1.githubusercontent.com/u/24980792?v=4","gravatar_id":"","url":"https://api.github.com/users/a-canary","html_url":"https://github.com/a-canary","followers_url":"https://api.github.com/users/a-canary/followers","following_url":"https://api.github.com/users/a-canary/following{/other_user}","gists_url":"https://api.github.com/users/a-canary/gists{/gist_id}","starred_url":"https://api.github.com/users/a-canary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-canary/subscriptions","organizations_url":"https://api.github.com/users/a-canary/orgs","repos_url":"https://api.github.com/users/a-canary/repos","events_url":"https://api.github.com/users/a-canary/events{/privacy}","received_events_url":"https://api.github.com/users/a-canary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-canary/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/a-canary/trafficserver","forks_url":"https://api.github.com/repos/a-canary/trafficserver/forks","keys_url":"https://api.github.com/repos/a-canary/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-canary/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-canary/trafficserver/teams","hooks_url":"https://api.github.com/repos/a-canary/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/a-canary/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/a-canary/trafficserver/events","assignees_url":"https://api.github.com/repos/a-canary/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/a-canary/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/a-canary/trafficserver/tags","blobs_url":"https://api.github.com/repos/a-canary/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-canary/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-canary/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-canary/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-canary/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/a-canary/trafficserver/languages","stargazers_url":"https://api.github.com/repos/a-canary/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/a-canary/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/a-canary/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/a-canary/trafficserver/subscription","commits_url":"https://api.github.com/repos/a-canary/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-canary/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-canary/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-canary/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-canary/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/a-canary/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-canary/trafficserver/merges","archive_url":"https://api.github.com/repos/a-canary/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-canary/trafficserver/downloads","issues_url":"https://api.github.com/repos/a-canary/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/a-canary/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/a-canary/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/a-canary/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-canary/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/a-canary/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/a-canary/trafficserver/deployments","created_at":"2017-05-17T21:49:33Z","updated_at":"2017-05-17T21:49:42Z","pushed_at":"2018-02-16T20:11:06Z","git_url":"git://github.com/a-canary/trafficserver.git","ssh_url":"git@github.com:a-canary/trafficserver.git","clone_url":"https://github.com/a-canary/trafficserver.git","svn_url":"https://github.com/a-canary/trafficserver","homepage":null,"size":78475,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/3"},"html":{"href":"https://github.com/a-canary/trafficserver/pull/3"},"issue":{"href":"https://api.github.com/repos/a-canary/trafficserver/issues/3"},"comments":{"href":"https://api.github.com/repos/a-canary/trafficserver/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/a-canary/trafficserver/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/a-canary/trafficserver/statuses/b7ce4bc104cce1a92c92d821aac2e31b1aff4361"}},"author_association":"OWNER"}}
{"actor":{"display_login":"SolidWallOfCode"}}