{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io/fin-site/pulls/comments/222724493","pull_request_review_id":161681200,"id":222724493,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjcyNDQ5Mw==","diff_hunk":"@@ -1,32 +1,47 @@\n-const path = require('path')\n+const path = require('path');\n+\n+const containers = path.resolve(`${__dirname}/pages`);\n+\n \n-const containers = path.resolve(`${__dirname}/pages`)\n \n module.exports = {\n-  getRoutes: ({ siteProps }) => {\n-    return [\n-      {\n-        path: '/',\n-        title: 'Home',\n-        component: `${containers}/Home`\n+\tgetRoutes: ({ siteProps }) => {\n+\t\t// Have to setup a redirect from /docs/getting-started to /getting-started\n+\t\tlet gettingStartedRoute = {}","path":"theme/landr-theme-fin/landr.conf.js","position":18,"original_position":18,"commit_id":"454cefd0ec8deaa5a91cbd4c2881630f4aab0bea","original_commit_id":"454cefd0ec8deaa5a91cbd4c2881630f4aab0bea","user":{"login":"thgreasi","id":1295829,"node_id":"MDQ6VXNlcjEyOTU4Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1295829?v=4","gravatar_id":"","url":"https://api.github.com/users/thgreasi","html_url":"https://github.com/thgreasi","followers_url":"https://api.github.com/users/thgreasi/followers","following_url":"https://api.github.com/users/thgreasi/following{/other_user}","gists_url":"https://api.github.com/users/thgreasi/gists{/gist_id}","starred_url":"https://api.github.com/users/thgreasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thgreasi/subscriptions","organizations_url":"https://api.github.com/users/thgreasi/orgs","repos_url":"https://api.github.com/users/thgreasi/repos","events_url":"https://api.github.com/users/thgreasi/events{/privacy}","received_events_url":"https://api.github.com/users/thgreasi/received_events","type":"User","site_admin":false},"body":"Is it ok to add a possibly empty object in the returned array?\r\nWould it make more sense to splice it in the second spot only if it exist?\r\nWould it make sense to use a ternary assignment with a `const`?","created_at":"2018-10-04T15:46:25Z","updated_at":"2018-10-04T15:46:25Z","html_url":"https://github.com/resin-io/fin-site/pull/8#discussion_r222724493","pull_request_url":"https://api.github.com/repos/resin-io/fin-site/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/comments/222724493"},"html":{"href":"https://github.com/resin-io/fin-site/pull/8#discussion_r222724493"},"pull_request":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io/fin-site/pulls/8","id":220416239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDE2MjM5","html_url":"https://github.com/resin-io/fin-site/pull/8","diff_url":"https://github.com/resin-io/fin-site/pull/8.diff","patch_url":"https://github.com/resin-io/fin-site/pull/8.patch","issue_url":"https://api.github.com/repos/resin-io/fin-site/issues/8","number":8,"state":"open","locked":false,"title":"docs: Fix path names containing trailing slashes","user":{"login":"dimitrisnl","id":4951004,"node_id":"MDQ6VXNlcjQ5NTEwMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4951004?v=4","gravatar_id":"","url":"https://api.github.com/users/dimitrisnl","html_url":"https://github.com/dimitrisnl","followers_url":"https://api.github.com/users/dimitrisnl/followers","following_url":"https://api.github.com/users/dimitrisnl/following{/other_user}","gists_url":"https://api.github.com/users/dimitrisnl/gists{/gist_id}","starred_url":"https://api.github.com/users/dimitrisnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimitrisnl/subscriptions","organizations_url":"https://api.github.com/users/dimitrisnl/orgs","repos_url":"https://api.github.com/users/dimitrisnl/repos","events_url":"https://api.github.com/users/dimitrisnl/events{/privacy}","received_events_url":"https://api.github.com/users/dimitrisnl/received_events","type":"User","site_admin":false},"body":"Change-type: minor\r\nSigned-off-by: Dimitrios Lytras <dimitrios@resin.io>","created_at":"2018-10-04T15:14:47Z","updated_at":"2018-10-04T15:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e971c0000c226e40448ed8f8990fae120fc8691e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ntzovanis","id":3798601,"node_id":"MDQ6VXNlcjM3OTg2MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3798601?v=4","gravatar_id":"","url":"https://api.github.com/users/ntzovanis","html_url":"https://github.com/ntzovanis","followers_url":"https://api.github.com/users/ntzovanis/followers","following_url":"https://api.github.com/users/ntzovanis/following{/other_user}","gists_url":"https://api.github.com/users/ntzovanis/gists{/gist_id}","starred_url":"https://api.github.com/users/ntzovanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntzovanis/subscriptions","organizations_url":"https://api.github.com/users/ntzovanis/orgs","repos_url":"https://api.github.com/users/ntzovanis/repos","events_url":"https://api.github.com/users/ntzovanis/events{/privacy}","received_events_url":"https://api.github.com/users/ntzovanis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io/fin-site/pulls/8/commits","review_comments_url":"https://api.github.com/repos/resin-io/fin-site/pulls/8/comments","review_comment_url":"https://api.github.com/repos/resin-io/fin-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io/fin-site/issues/8/comments","statuses_url":"https://api.github.com/repos/resin-io/fin-site/statuses/454cefd0ec8deaa5a91cbd4c2881630f4aab0bea","head":{"label":"resin-io:fix-trailing-slashes","ref":"fix-trailing-slashes","sha":"454cefd0ec8deaa5a91cbd4c2881630f4aab0bea","user":{"login":"resin-io","id":6157842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTc4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":141267816,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNjc4MTY=","name":"fin-site","full_name":"resin-io/fin-site","private":false,"owner":{"login":"resin-io","id":6157842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTc4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/resin-io/fin-site","description":"Marketing site for the Balena Fin board","fork":false,"url":"https://api.github.com/repos/resin-io/fin-site","forks_url":"https://api.github.com/repos/resin-io/fin-site/forks","keys_url":"https://api.github.com/repos/resin-io/fin-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/fin-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/fin-site/teams","hooks_url":"https://api.github.com/repos/resin-io/fin-site/hooks","issue_events_url":"https://api.github.com/repos/resin-io/fin-site/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/fin-site/events","assignees_url":"https://api.github.com/repos/resin-io/fin-site/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/fin-site/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/fin-site/tags","blobs_url":"https://api.github.com/repos/resin-io/fin-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/fin-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/fin-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/fin-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/fin-site/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/fin-site/languages","stargazers_url":"https://api.github.com/repos/resin-io/fin-site/stargazers","contributors_url":"https://api.github.com/repos/resin-io/fin-site/contributors","subscribers_url":"https://api.github.com/repos/resin-io/fin-site/subscribers","subscription_url":"https://api.github.com/repos/resin-io/fin-site/subscription","commits_url":"https://api.github.com/repos/resin-io/fin-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/fin-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/fin-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/fin-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/fin-site/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/fin-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/fin-site/merges","archive_url":"https://api.github.com/repos/resin-io/fin-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/fin-site/downloads","issues_url":"https://api.github.com/repos/resin-io/fin-site/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/fin-site/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/fin-site/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/fin-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/fin-site/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/fin-site/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/fin-site/deployments","created_at":"2018-07-17T09:40:29Z","updated_at":"2018-10-04T14:27:07Z","pushed_at":"2018-10-04T15:35:25Z","git_url":"git://github.com/resin-io/fin-site.git","ssh_url":"git@github.com:resin-io/fin-site.git","clone_url":"https://github.com/resin-io/fin-site.git","svn_url":"https://github.com/resin-io/fin-site","homepage":null,"size":14826,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"resin-io:master","ref":"master","sha":"4e2d9bca3bc479ad583a7a645e1a26f8f4090640","user":{"login":"resin-io","id":6157842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTc4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":141267816,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNjc4MTY=","name":"fin-site","full_name":"resin-io/fin-site","private":false,"owner":{"login":"resin-io","id":6157842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTc4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/resin-io/fin-site","description":"Marketing site for the Balena Fin board","fork":false,"url":"https://api.github.com/repos/resin-io/fin-site","forks_url":"https://api.github.com/repos/resin-io/fin-site/forks","keys_url":"https://api.github.com/repos/resin-io/fin-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/fin-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/fin-site/teams","hooks_url":"https://api.github.com/repos/resin-io/fin-site/hooks","issue_events_url":"https://api.github.com/repos/resin-io/fin-site/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/fin-site/events","assignees_url":"https://api.github.com/repos/resin-io/fin-site/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/fin-site/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/fin-site/tags","blobs_url":"https://api.github.com/repos/resin-io/fin-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/fin-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/fin-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/fin-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/fin-site/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/fin-site/languages","stargazers_url":"https://api.github.com/repos/resin-io/fin-site/stargazers","contributors_url":"https://api.github.com/repos/resin-io/fin-site/contributors","subscribers_url":"https://api.github.com/repos/resin-io/fin-site/subscribers","subscription_url":"https://api.github.com/repos/resin-io/fin-site/subscription","commits_url":"https://api.github.com/repos/resin-io/fin-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/fin-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/fin-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/fin-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/fin-site/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/fin-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/fin-site/merges","archive_url":"https://api.github.com/repos/resin-io/fin-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/fin-site/downloads","issues_url":"https://api.github.com/repos/resin-io/fin-site/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/fin-site/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/fin-site/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/fin-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/fin-site/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/fin-site/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/fin-site/deployments","created_at":"2018-07-17T09:40:29Z","updated_at":"2018-10-04T14:27:07Z","pushed_at":"2018-10-04T15:35:25Z","git_url":"git://github.com/resin-io/fin-site.git","ssh_url":"git@github.com:resin-io/fin-site.git","clone_url":"https://github.com/resin-io/fin-site.git","svn_url":"https://github.com/resin-io/fin-site","homepage":null,"size":14826,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/8"},"html":{"href":"https://github.com/resin-io/fin-site/pull/8"},"issue":{"href":"https://api.github.com/repos/resin-io/fin-site/issues/8"},"comments":{"href":"https://api.github.com/repos/resin-io/fin-site/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io/fin-site/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io/fin-site/statuses/454cefd0ec8deaa5a91cbd4c2881630f4aab0bea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thgreasi"}}