{"action":"created","issue":{"url":"https://api.github.com/repos/lagom/lagom/issues/1668","repository_url":"https://api.github.com/repos/lagom/lagom","labels_url":"https://api.github.com/repos/lagom/lagom/issues/1668/labels{/name}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1668/comments","events_url":"https://api.github.com/repos/lagom/lagom/issues/1668/events","html_url":"https://github.com/lagom/lagom/pull/1668","id":388846189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDE4NjYw","number":1668,"title":"[NOT-FOR-MERGE] Check versions alignment at compile","user":{"login":"renatocaval","id":502982,"node_id":"MDQ6VXNlcjUwMjk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-07T23:10:10Z","updated_at":"2018-12-09T18:32:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1668","html_url":"https://github.com/lagom/lagom/pull/1668","diff_url":"https://github.com/lagom/lagom/pull/1668.diff","patch_url":"https://github.com/lagom/lagom/pull/1668.patch"},"body":"This is a PoC to add a check at compile time that verifies that jars for a given project family (eg: akka, akka-http) are all on the same version. \r\n\r\nThis is based on Akka's `ManifestInfo`. I picked the code and made a few adaptations.\r\n\r\nDifferently than the Akka variant, this one checks the dependencies versions at compile time. \r\n\r\nIdeally, this...\r\n\r\n* should not be in the Lagom, but an apart utility lib, with an sbt plugin that we can add to Play and Lagom's plugin\r\n* Lagom's maven plugin should have a new mojo that adds this check at compile phase\r\n* projects requiring version alignment (eg: Akka, Akka-Http, Play, Lagom, etc) could provide a [`ProjectFamily`](https://github.com/lagom/lagom/pull/1668/files#diff-114b0f63e8385153896c7c22e0d6c192R182) impl with the list of modules to check\r\n* Libs could depend on this and provide warnings at runtime, like Akka is doing now\r\n\r\nRelates to: https://github.com/lagom/lagom/issues/1665 and https://github.com/lagom/lagom/issues/1652"},"comment":{"url":"https://api.github.com/repos/lagom/lagom/issues/comments/445560258","html_url":"https://github.com/lagom/lagom/pull/1668#issuecomment-445560258","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1668","id":445560258,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTU2MDI1OA==","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"created_at":"2018-12-09T18:32:27Z","updated_at":"2018-12-09T18:32:27Z","author_association":"CONTRIBUTOR","body":"Why isn't a runtime check enough? \r\nMaintaining build tools is far more complicated (or at least more unfamiliar to most of us) in my opinion than maintaining library code. I must have feature parity for Maven and Gradle too."}}
{"actor":{"display_login":"patriknw"}}