{"action":"created","comment":{"url":"https://api.github.com/repos/heketi/heketi/pulls/comments/194150888","pull_request_review_id":127276887,"id":194150888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDE1MDg4OA==","diff_hunk":"@@ -252,17 +252,22 @@ func (a *App) VolumeDelete(w http.ResponseWriter, r *http.Request) {\n \t\t\treturn nil\n \t\t}\n \n-\t\tif volume.Info.BlockInfo.BlockVolumes == nil {","path":"apps/glusterfs/app_volume.go","position":4,"original_position":4,"commit_id":"0f1c6469c23c530c2fcbfc03af375c2f0cfcc52c","original_commit_id":"0f1c6469c23c530c2fcbfc03af375c2f0cfcc52c","user":{"login":"obnoxxx","id":8081179,"node_id":"MDQ6VXNlcjgwODExNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8081179?v=4","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"body":"it prints\r\n```\r\nHello!\r\nBye...\r\n```","created_at":"2018-06-08T18:52:22Z","updated_at":"2018-06-08T18:52:22Z","html_url":"https://github.com/heketi/heketi/pull/1216#discussion_r194150888","pull_request_url":"https://api.github.com/repos/heketi/heketi/pulls/1216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/heketi/heketi/pulls/comments/194150888"},"html":{"href":"https://github.com/heketi/heketi/pull/1216#discussion_r194150888"},"pull_request":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1216"}},"in_reply_to_id":194146348},"pull_request":{"url":"https://api.github.com/repos/heketi/heketi/pulls/1216","id":193688188,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjg4MTg4","html_url":"https://github.com/heketi/heketi/pull/1216","diff_url":"https://github.com/heketi/heketi/pull/1216.diff","patch_url":"https://github.com/heketi/heketi/pull/1216.patch","issue_url":"https://api.github.com/repos/heketi/heketi/issues/1216","number":1216,"state":"open","locked":false,"title":"Ignore nonexistent block volumes in deletion of block-hosting volume.","user":{"login":"obnoxxx","id":8081179,"node_id":"MDQ6VXNlcjgwODExNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8081179?v=4","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"body":"### What does this PR achieve? Why do we need it?\r\n\r\nDon't fail the deletion of a block-hosting volume if\r\nit references a block volume id, that does not\r\nexist in the database.\r\n\r\n","created_at":"2018-06-08T18:19:14Z","updated_at":"2018-06-08T18:52:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8d41a9b01016dc5ef125d33d1d48c668dbd4145","assignee":null,"assignees":[],"requested_reviewers":[{"login":"raghavendra-talur","id":1446375,"node_id":"MDQ6VXNlcjE0NDYzNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1446375?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavendra-talur","html_url":"https://github.com/raghavendra-talur","followers_url":"https://api.github.com/users/raghavendra-talur/followers","following_url":"https://api.github.com/users/raghavendra-talur/following{/other_user}","gists_url":"https://api.github.com/users/raghavendra-talur/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavendra-talur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavendra-talur/subscriptions","organizations_url":"https://api.github.com/users/raghavendra-talur/orgs","repos_url":"https://api.github.com/users/raghavendra-talur/repos","events_url":"https://api.github.com/users/raghavendra-talur/events{/privacy}","received_events_url":"https://api.github.com/users/raghavendra-talur/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heketi/heketi/pulls/1216/commits","review_comments_url":"https://api.github.com/repos/heketi/heketi/pulls/1216/comments","review_comment_url":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heketi/heketi/issues/1216/comments","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/0f1c6469c23c530c2fcbfc03af375c2f0cfcc52c","head":{"label":"obnoxxx:fix-delete-block-hosting-volume","ref":"fix-delete-block-hosting-volume","sha":"0f1c6469c23c530c2fcbfc03af375c2f0cfcc52c","user":{"login":"obnoxxx","id":8081179,"node_id":"MDQ6VXNlcjgwODExNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8081179?v=4","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"repo":{"id":67208253,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIwODI1Mw==","name":"heketi","full_name":"obnoxxx/heketi","owner":{"login":"obnoxxx","id":8081179,"node_id":"MDQ6VXNlcjgwODExNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8081179?v=4","gravatar_id":"","url":"https://api.github.com/users/obnoxxx","html_url":"https://github.com/obnoxxx","followers_url":"https://api.github.com/users/obnoxxx/followers","following_url":"https://api.github.com/users/obnoxxx/following{/other_user}","gists_url":"https://api.github.com/users/obnoxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/obnoxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obnoxxx/subscriptions","organizations_url":"https://api.github.com/users/obnoxxx/orgs","repos_url":"https://api.github.com/users/obnoxxx/repos","events_url":"https://api.github.com/users/obnoxxx/events{/privacy}","received_events_url":"https://api.github.com/users/obnoxxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obnoxxx/heketi","description":"RESTful based volume management framework for GlusterFS","fork":true,"url":"https://api.github.com/repos/obnoxxx/heketi","forks_url":"https://api.github.com/repos/obnoxxx/heketi/forks","keys_url":"https://api.github.com/repos/obnoxxx/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obnoxxx/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obnoxxx/heketi/teams","hooks_url":"https://api.github.com/repos/obnoxxx/heketi/hooks","issue_events_url":"https://api.github.com/repos/obnoxxx/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/obnoxxx/heketi/events","assignees_url":"https://api.github.com/repos/obnoxxx/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/obnoxxx/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/obnoxxx/heketi/tags","blobs_url":"https://api.github.com/repos/obnoxxx/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obnoxxx/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obnoxxx/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/obnoxxx/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obnoxxx/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/obnoxxx/heketi/languages","stargazers_url":"https://api.github.com/repos/obnoxxx/heketi/stargazers","contributors_url":"https://api.github.com/repos/obnoxxx/heketi/contributors","subscribers_url":"https://api.github.com/repos/obnoxxx/heketi/subscribers","subscription_url":"https://api.github.com/repos/obnoxxx/heketi/subscription","commits_url":"https://api.github.com/repos/obnoxxx/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/obnoxxx/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/obnoxxx/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/obnoxxx/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/obnoxxx/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/obnoxxx/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obnoxxx/heketi/merges","archive_url":"https://api.github.com/repos/obnoxxx/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obnoxxx/heketi/downloads","issues_url":"https://api.github.com/repos/obnoxxx/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/obnoxxx/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/obnoxxx/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/obnoxxx/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obnoxxx/heketi/labels{/name}","releases_url":"https://api.github.com/repos/obnoxxx/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/obnoxxx/heketi/deployments","created_at":"2016-09-02T09:07:20Z","updated_at":"2016-09-02T09:07:22Z","pushed_at":"2018-06-08T18:25:28Z","git_url":"git://github.com/obnoxxx/heketi.git","ssh_url":"git@github.com:obnoxxx/heketi.git","clone_url":"https://github.com/obnoxxx/heketi.git","svn_url":"https://github.com/obnoxxx/heketi","homepage":"","size":20987,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heketi:master","ref":"master","sha":"be187e4aa4b23a45002cb1ef18ed12d6be4420ba","user":{"login":"heketi","id":12890374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODkwMzc0","avatar_url":"https://avatars0.githubusercontent.com/u/12890374?v=4","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"repo":{"id":37446835,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ0NjgzNQ==","name":"heketi","full_name":"heketi/heketi","owner":{"login":"heketi","id":12890374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODkwMzc0","avatar_url":"https://avatars0.githubusercontent.com/u/12890374?v=4","gravatar_id":"","url":"https://api.github.com/users/heketi","html_url":"https://github.com/heketi","followers_url":"https://api.github.com/users/heketi/followers","following_url":"https://api.github.com/users/heketi/following{/other_user}","gists_url":"https://api.github.com/users/heketi/gists{/gist_id}","starred_url":"https://api.github.com/users/heketi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heketi/subscriptions","organizations_url":"https://api.github.com/users/heketi/orgs","repos_url":"https://api.github.com/users/heketi/repos","events_url":"https://api.github.com/users/heketi/events{/privacy}","received_events_url":"https://api.github.com/users/heketi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heketi/heketi","description":"RESTful based volume management framework for GlusterFS","fork":false,"url":"https://api.github.com/repos/heketi/heketi","forks_url":"https://api.github.com/repos/heketi/heketi/forks","keys_url":"https://api.github.com/repos/heketi/heketi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heketi/heketi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heketi/heketi/teams","hooks_url":"https://api.github.com/repos/heketi/heketi/hooks","issue_events_url":"https://api.github.com/repos/heketi/heketi/issues/events{/number}","events_url":"https://api.github.com/repos/heketi/heketi/events","assignees_url":"https://api.github.com/repos/heketi/heketi/assignees{/user}","branches_url":"https://api.github.com/repos/heketi/heketi/branches{/branch}","tags_url":"https://api.github.com/repos/heketi/heketi/tags","blobs_url":"https://api.github.com/repos/heketi/heketi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heketi/heketi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heketi/heketi/git/refs{/sha}","trees_url":"https://api.github.com/repos/heketi/heketi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heketi/heketi/statuses/{sha}","languages_url":"https://api.github.com/repos/heketi/heketi/languages","stargazers_url":"https://api.github.com/repos/heketi/heketi/stargazers","contributors_url":"https://api.github.com/repos/heketi/heketi/contributors","subscribers_url":"https://api.github.com/repos/heketi/heketi/subscribers","subscription_url":"https://api.github.com/repos/heketi/heketi/subscription","commits_url":"https://api.github.com/repos/heketi/heketi/commits{/sha}","git_commits_url":"https://api.github.com/repos/heketi/heketi/git/commits{/sha}","comments_url":"https://api.github.com/repos/heketi/heketi/comments{/number}","issue_comment_url":"https://api.github.com/repos/heketi/heketi/issues/comments{/number}","contents_url":"https://api.github.com/repos/heketi/heketi/contents/{+path}","compare_url":"https://api.github.com/repos/heketi/heketi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heketi/heketi/merges","archive_url":"https://api.github.com/repos/heketi/heketi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heketi/heketi/downloads","issues_url":"https://api.github.com/repos/heketi/heketi/issues{/number}","pulls_url":"https://api.github.com/repos/heketi/heketi/pulls{/number}","milestones_url":"https://api.github.com/repos/heketi/heketi/milestones{/number}","notifications_url":"https://api.github.com/repos/heketi/heketi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heketi/heketi/labels{/name}","releases_url":"https://api.github.com/repos/heketi/heketi/releases{/id}","deployments_url":"https://api.github.com/repos/heketi/heketi/deployments","created_at":"2015-06-15T06:10:11Z","updated_at":"2018-06-08T17:42:45Z","pushed_at":"2018-06-08T18:25:30Z","git_url":"git://github.com/heketi/heketi.git","ssh_url":"git@github.com:heketi/heketi.git","clone_url":"https://github.com/heketi/heketi.git","svn_url":"https://github.com/heketi/heketi","homepage":"","size":20796,"stargazers_count":564,"watchers_count":564,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":172,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":172,"open_issues":159,"watchers":564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1216"},"html":{"href":"https://github.com/heketi/heketi/pull/1216"},"issue":{"href":"https://api.github.com/repos/heketi/heketi/issues/1216"},"comments":{"href":"https://api.github.com/repos/heketi/heketi/issues/1216/comments"},"review_comments":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1216/comments"},"review_comment":{"href":"https://api.github.com/repos/heketi/heketi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heketi/heketi/pulls/1216/commits"},"statuses":{"href":"https://api.github.com/repos/heketi/heketi/statuses/0f1c6469c23c530c2fcbfc03af375c2f0cfcc52c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"obnoxxx"}}