{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5355","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5355/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5355/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5355/events","html_url":"https://github.com/greenplum-db/gpdb/pull/5355","id":345720394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Nzc1NzIz","number":5355,"title":"Assorted node function fixups","user":{"login":"danielgustafsson","id":321790,"node_id":"MDQ6VXNlcjMyMTc5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/321790?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T11:35:53Z","updated_at":"2018-08-01T09:52:56Z","closed_at":"2018-08-01T09:52:56Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5355","html_url":"https://github.com/greenplum-db/gpdb/pull/5355","diff_url":"https://github.com/greenplum-db/gpdb/pull/5355.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/5355.patch"},"body":"A few fixes that came out of looking at 9.0 merge fixmes.\r\n\r\nThe `is_split_part member` is compared in `_equalIndexStmt()`, and is copied in `_copyIndexStmt()`, so we should include it in the read and write functions as well.\r\n\r\nThe `altconname` member defines an alternative name for the index if another name for a constraint was requested. Including it in the comparison is mostly for correctness, as the index name is compared, even if few (if any) situations would fail on this being omitted.\r\n\r\n`IndexStmt` is defined in `src/include/nodes/parsenodes.h` with `indexOid` before the `is_part_child` member. Reorder the node functions to match the definition."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/409519844","html_url":"https://github.com/greenplum-db/gpdb/pull/5355#issuecomment-409519844","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5355","id":409519844,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTUxOTg0NA==","user":{"login":"danielgustafsson","id":321790,"node_id":"MDQ6VXNlcjMyMTc5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/321790?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T09:52:56Z","updated_at":"2018-08-01T09:52:56Z","author_association":"MEMBER","body":"Pushed to master, thanks for review!"}}
{"actor":{"display_login":"danielgustafsson"}}