{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/187349520","pull_request_review_id":119111008,"id":187349520,"diff_hunk":"@@ -0,0 +1,106 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.nifi.processors.deeplearning4j;\n+import java.io.IOException;\n+import org.apache.nifi.annotation.lifecycle.OnStopped;\n+import org.apache.nifi.components.PropertyDescriptor;\n+import org.apache.nifi.expression.ExpressionLanguageScope;\n+import org.apache.nifi.processor.AbstractProcessor;\n+import org.apache.nifi.processor.ProcessContext;\n+import org.apache.nifi.processor.util.StandardValidators;\n+import org.deeplearning4j.nn.multilayer.MultiLayerNetwork;\n+import org.deeplearning4j.util.ModelSerializer;\n+\n+/**\n+ * Base class for deeplearning4j processors\n+ */\n+public abstract class AbstractDeepLearning4JProcessor extends AbstractProcessor {\n+\n+    public static final PropertyDescriptor CHARSET = new PropertyDescriptor.Builder()\n+            .name(\"deeplearning4j-charset\")\n+            .displayName(\"Character Set\")\n+            .description(\"Specifies the character set of the document data.\")\n+            .required(true)\n+            .defaultValue(\"UTF-8\")\n+            .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)\n+            .addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)\n+            .build();\n+\n+    public static final PropertyDescriptor FIELD_SEPARATOR = new PropertyDescriptor.Builder()\n+            .name(\"deeplearning4j-field-separator\")\n+            .displayName(\"Field Separator\")\n+            .description(\"Specifies the field separator in the records. (default is comma)\")\n+            .required(true)\n+            .defaultValue(\",\")\n+            .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)\n+            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)\n+            .build();\n+\n+    public static final PropertyDescriptor RECORD_SEPARATOR = new PropertyDescriptor.Builder()\n+            .name(\"deeplearning4j-record-separator\")\n+            .displayName(\"Record Separator\")\n+            .description(\"Specifies the records separator in the message body. (defaults to new line)\")\n+            .required(true)\n+            .defaultValue(System.lineSeparator())","path":"nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j/AbstractDeepLearning4JProcessor.java","position":58,"original_position":58,"commit_id":"f58316a906af820f9f056c6ebee171015685f86b","original_commit_id":"f58316a906af820f9f056c6ebee171015685f86b","user":{"login":"markap14","id":184268,"avatar_url":"https://avatars2.githubusercontent.com/u/184268?v=4","gravatar_id":"","url":"https://api.github.com/users/markap14","html_url":"https://github.com/markap14","followers_url":"https://api.github.com/users/markap14/followers","following_url":"https://api.github.com/users/markap14/following{/other_user}","gists_url":"https://api.github.com/users/markap14/gists{/gist_id}","starred_url":"https://api.github.com/users/markap14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markap14/subscriptions","organizations_url":"https://api.github.com/users/markap14/orgs","repos_url":"https://api.github.com/users/markap14/repos","events_url":"https://api.github.com/users/markap14/events{/privacy}","received_events_url":"https://api.github.com/users/markap14/received_events","type":"User","site_admin":false},"body":"I would recommend setting this explicitly to \"\\n\" so that the default behavior is the same across environments.","created_at":"2018-05-10T14:37:35Z","updated_at":"2018-05-10T15:02:18Z","html_url":"https://github.com/apache/nifi/pull/2686#discussion_r187349520","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/2686","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/187349520"},"html":{"href":"https://github.com/apache/nifi/pull/2686#discussion_r187349520"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/2686"}}},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2686","id":186528444,"html_url":"https://github.com/apache/nifi/pull/2686","diff_url":"https://github.com/apache/nifi/pull/2686.diff","patch_url":"https://github.com/apache/nifi/pull/2686.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/2686","number":2686,"state":"open","locked":false,"title":"NIFI-5166 - Deep learning classification and regression processor wit…","user":{"login":"mans2singh","id":8467404,"avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"body":"…h deeplearning4j\r\n\r\nThank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2018-05-08T05:16:01Z","updated_at":"2018-05-10T15:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4929446ab8d5d441edd7205c3afe9e5fbd4f15ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/2686/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/2686/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2686/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/f58316a906af820f9f056c6ebee171015685f86b","head":{"label":"mans2singh:NIFI-5166","ref":"NIFI-5166","sha":"f58316a906af820f9f056c6ebee171015685f86b","user":{"login":"mans2singh","id":8467404,"avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"repo":{"id":51235186,"name":"nifi","full_name":"mans2singh/nifi","owner":{"login":"mans2singh","id":8467404,"avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mans2singh/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/mans2singh/nifi","forks_url":"https://api.github.com/repos/mans2singh/nifi/forks","keys_url":"https://api.github.com/repos/mans2singh/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mans2singh/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mans2singh/nifi/teams","hooks_url":"https://api.github.com/repos/mans2singh/nifi/hooks","issue_events_url":"https://api.github.com/repos/mans2singh/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/mans2singh/nifi/events","assignees_url":"https://api.github.com/repos/mans2singh/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/mans2singh/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/mans2singh/nifi/tags","blobs_url":"https://api.github.com/repos/mans2singh/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mans2singh/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mans2singh/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/mans2singh/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mans2singh/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/mans2singh/nifi/languages","stargazers_url":"https://api.github.com/repos/mans2singh/nifi/stargazers","contributors_url":"https://api.github.com/repos/mans2singh/nifi/contributors","subscribers_url":"https://api.github.com/repos/mans2singh/nifi/subscribers","subscription_url":"https://api.github.com/repos/mans2singh/nifi/subscription","commits_url":"https://api.github.com/repos/mans2singh/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/mans2singh/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/mans2singh/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/mans2singh/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/mans2singh/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/mans2singh/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mans2singh/nifi/merges","archive_url":"https://api.github.com/repos/mans2singh/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mans2singh/nifi/downloads","issues_url":"https://api.github.com/repos/mans2singh/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/mans2singh/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/mans2singh/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/mans2singh/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mans2singh/nifi/labels{/name}","releases_url":"https://api.github.com/repos/mans2singh/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/mans2singh/nifi/deployments","created_at":"2016-02-07T04:22:11Z","updated_at":"2018-05-08T03:31:20Z","pushed_at":"2018-05-08T05:11:53Z","git_url":"git://github.com/mans2singh/nifi.git","ssh_url":"git@github.com:mans2singh/nifi.git","clone_url":"https://github.com/mans2singh/nifi.git","svn_url":"https://github.com/mans2singh/nifi","homepage":"","size":119589,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2094786ec83567a375a719adacc71341bd81408b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2018-05-10T09:05:36Z","pushed_at":"2018-05-10T11:22:56Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":121826,"stargazers_count":925,"watchers_count":925,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":885,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":885,"open_issues":126,"watchers":925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/2686"},"html":{"href":"https://github.com/apache/nifi/pull/2686"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/2686"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/2686/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/2686/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/2686/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/f58316a906af820f9f056c6ebee171015685f86b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markap14"}}