{"action":"created","issue":{"url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/1","repository_url":"https://api.github.com/repos/fowlmouth/nanovg.nim","labels_url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/1/comments","events_url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/1/events","html_url":"https://github.com/fowlmouth/nanovg.nim/pull/1","id":245881930,"node_id":"MDExOlB1bGxSZXF1ZXN0MTMyNjM1MDEw","number":1,"title":"Updates and Mac Support","user":{"login":"rayman22201","id":665285,"node_id":"MDQ6VXNlcjY2NTI4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/665285?v=4","gravatar_id":"","url":"https://api.github.com/users/rayman22201","html_url":"https://github.com/rayman22201","followers_url":"https://api.github.com/users/rayman22201/followers","following_url":"https://api.github.com/users/rayman22201/following{/other_user}","gists_url":"https://api.github.com/users/rayman22201/gists{/gist_id}","starred_url":"https://api.github.com/users/rayman22201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayman22201/subscriptions","organizations_url":"https://api.github.com/users/rayman22201/orgs","repos_url":"https://api.github.com/users/rayman22201/repos","events_url":"https://api.github.com/users/rayman22201/events{/privacy}","received_events_url":"https://api.github.com/users/rayman22201/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-07-26T23:17:11Z","updated_at":"2018-11-18T21:56:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/fowlmouth/nanovg.nim/pulls/1","html_url":"https://github.com/fowlmouth/nanovg.nim/pull/1","diff_url":"https://github.com/fowlmouth/nanovg.nim/pull/1.diff","patch_url":"https://github.com/fowlmouth/nanovg.nim/pull/1.patch"},"body":"Hi! I have started playing around with Nim, and I wanted to use the nanovg library.\r\nYou did all the hard work to make a nice wrapper for it! Thank you ❤️ \r\n\r\nIt seems that it hasn't been updated in a while though, so I took a crack at updating it.\r\n\r\nI updated the nanovg source repo to the latest version, which tentatively seems to have not had any big breaking api changes, because your wrapper code continued to just work when I swapped out the C sources.\r\n\r\nI made some modifications to make the latest version of nimble not throw warnings:\r\n- re-formatting the nanovg.nimble file to the new format\r\n- adding in the requirements for the ```opengl``` and ```glfw``` nimble packages\r\n- changing the name of ```nvg.nim``` to ```nanovg.nim``` and adding the ```example``` directory to the excluded folders list.\r\n\r\nI figured that the examples folder exclusion was ok, because technically the example is not part of the library itself, and people probably don't need the example code in the nimble library directory.\r\n\r\nThe example code itself had to be changed slightly:\r\n- a few new fonts and graphics had to be added to the example from nanovg itself.\r\n- The header paths had to be made relative from the nimcache directory because the example folder is no longer installed with the nanovg library (it's excluded).\r\n\r\nFinally, I am using this library on a Mac, so I had to make a few changes so that it would build on OSX, which I wrapped in an ifdef that you can see here:\r\nhttps://github.com/rayman22201/nanovg.nim/commit/7823387880ea0268ffc03a593910586cbc251253#diff-d25231fbfecaa673e431d6956360e8cfR64\r\n\r\nThanks,\r\nRay"},"comment":{"url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/comments/439729409","html_url":"https://github.com/fowlmouth/nanovg.nim/pull/1#issuecomment-439729409","issue_url":"https://api.github.com/repos/fowlmouth/nanovg.nim/issues/1","id":439729409,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTcyOTQwOQ==","user":{"login":"rayman22201","id":665285,"node_id":"MDQ6VXNlcjY2NTI4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/665285?v=4","gravatar_id":"","url":"https://api.github.com/users/rayman22201","html_url":"https://github.com/rayman22201","followers_url":"https://api.github.com/users/rayman22201/followers","following_url":"https://api.github.com/users/rayman22201/following{/other_user}","gists_url":"https://api.github.com/users/rayman22201/gists{/gist_id}","starred_url":"https://api.github.com/users/rayman22201/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayman22201/subscriptions","organizations_url":"https://api.github.com/users/rayman22201/orgs","repos_url":"https://api.github.com/users/rayman22201/repos","events_url":"https://api.github.com/users/rayman22201/events{/privacy}","received_events_url":"https://api.github.com/users/rayman22201/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T21:56:59Z","updated_at":"2018-11-18T21:56:59Z","author_association":"NONE","body":"Honestly don't know. @fowlmouth never merged the PR. I just kept using my fork at the time, and that did what I needed. You are welcome to use my fork. It might still work, but I haven't kept it updated as I no longer use mac."}}
{"actor":{"display_login":"rayman22201"}}