{"action":"created","issue":{"url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/33","repository_url":"https://api.github.com/repos/qlik-demo-team/qdt-components","labels_url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/33/comments","events_url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/33/events","html_url":"https://github.com/qlik-demo-team/qdt-components/pull/33","id":350775375,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTM3NTA3","number":33,"title":"Removed unncessary modification to the window object qApp function","user":{"login":"humean","id":1534676,"node_id":"MDQ6VXNlcjE1MzQ2NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1534676?v=4","gravatar_id":"","url":"https://api.github.com/users/humean","html_url":"https://github.com/humean","followers_url":"https://api.github.com/users/humean/followers","following_url":"https://api.github.com/users/humean/following{/other_user}","gists_url":"https://api.github.com/users/humean/gists{/gist_id}","starred_url":"https://api.github.com/users/humean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humean/subscriptions","organizations_url":"https://api.github.com/users/humean/orgs","repos_url":"https://api.github.com/users/humean/repos","events_url":"https://api.github.com/users/humean/events{/privacy}","received_events_url":"https://api.github.com/users/humean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-15T11:26:31Z","updated_at":"2018-08-15T12:33:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/qlik-demo-team/qdt-components/pulls/33","html_url":"https://github.com/qlik-demo-team/qdt-components/pull/33","diff_url":"https://github.com/qlik-demo-team/qdt-components/pull/33.diff","patch_url":"https://github.com/qlik-demo-team/qdt-components/pull/33.patch"},"body":"This PR removed the unnecessary modification to the window object to store a reference to the qlik object. Instead, the qlik object is stored within the module scope, and so doesn't pollute global scope."},"comment":{"url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/comments/413183926","html_url":"https://github.com/qlik-demo-team/qdt-components/pull/33#issuecomment-413183926","issue_url":"https://api.github.com/repos/qlik-demo-team/qdt-components/issues/33","id":413183926,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzE4MzkyNg==","user":{"login":"humean","id":1534676,"node_id":"MDQ6VXNlcjE1MzQ2NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1534676?v=4","gravatar_id":"","url":"https://api.github.com/users/humean","html_url":"https://github.com/humean","followers_url":"https://api.github.com/users/humean/followers","following_url":"https://api.github.com/users/humean/following{/other_user}","gists_url":"https://api.github.com/users/humean/gists{/gist_id}","starred_url":"https://api.github.com/users/humean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humean/subscriptions","organizations_url":"https://api.github.com/users/humean/orgs","repos_url":"https://api.github.com/users/humean/repos","events_url":"https://api.github.com/users/humean/events{/privacy}","received_events_url":"https://api.github.com/users/humean/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T12:33:34Z","updated_at":"2018-08-15T12:33:34Z","author_association":"NONE","body":"Another option is to have the QdtComponents constructor have an optional param that opt-outs of the Capability Apis injection."}}
{"actor":{"display_login":"humean"}}