{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/7012","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/7012/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/7012/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/7012/events","html_url":"https://github.com/status-im/status-react/pull/7012","id":387697708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTI2OTA2","number":7012,"title":"Use peers count","user":{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"assignees":[{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-12-05T10:47:03Z","updated_at":"2018-12-10T08:11:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/7012","html_url":"https://github.com/status-im/status-react/pull/7012","diff_url":"https://github.com/status-im/status-react/pull/7012.diff","patch_url":"https://github.com/status-im/status-react/pull/7012.patch"},"body":"This PR changes the behavior of `Offline` for sending messages and adds mailserver confirmations.\r\n\r\n\r\n### Offline/Online behavior\r\n\r\nWe now check that we are only connected to some `peers` instead of using `NetInfo` from `react-native`. \r\n\r\nThis is because it has been reported to be quite flaky at times, not reporting online status after sleeping, and for privacy concerns (on ios it pings `apple.com`, on desktop `google.com`).\r\n\r\nAdds a new banner `Wallet Offline` and change `Connecting to peers` to  `Chat offline`.\r\n\r\n### Mailserver confirmations\r\n\r\nA message will be marked as `Sent` only if it made it to the mailserver you are connected to, which will increase the guarantees that we can make about a message (if you see it as sent, it has reached at least a mailserver), this has the consequence that:\r\n\r\n- If you are not connected to any mailserver or the mailserver is non responsive/down, and you send a message, it will be marked as `Not sent`, although it might have been actually made it in the network.\r\n\r\nProbably this is something that we would like to communicate to the user through UX (i.e. tick if made it to at least a peer, double tick if it made to a mailserver )\r\n\r\nCurrently I have only enabled this feature in nightlies & devs, I would give it a run and see how we feel about it.\r\n\r\nfixes: #6889\r\n\r\nstatus: ready"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/445726802","html_url":"https://github.com/status-im/status-react/pull/7012#issuecomment-445726802","issue_url":"https://api.github.com/repos/status-im/status-react/issues/7012","id":445726802,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTcyNjgwMg==","user":{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T08:11:45Z","updated_at":"2018-12-10T08:11:45Z","author_association":"MEMBER","body":"@mandrigin done!"}}
{"actor":{"display_login":"cammellos"}}