{"action":"created","comment":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/228182625","pull_request_review_id":168390739,"id":228182625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE4MjYyNQ==","diff_hunk":"@@ -93,7 +89,8 @@ export default withRouter(injectIntl(withModalMounter(withTracker(({ router, int\n       if (isMeetingBreakout) {\n         Auth.clearCredentials().then(window.close);\n       } else {\n-        router.push(`/ended/${410}`);\n+        Session.set('codeError', '410');\n+        Session.set('isMeetingEnded', true);","path":"bigbluebutton-html5/imports/ui/components/app/container.jsx","position":62,"original_position":62,"commit_id":"cde6311a5d4dd2a7fef79434f21512663dc52cf5","original_commit_id":"cde6311a5d4dd2a7fef79434f21512663dc52cf5","user":{"login":"oswaldoacauan","id":1268518,"node_id":"MDQ6VXNlcjEyNjg1MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1268518?v=4","gravatar_id":"","url":"https://api.github.com/users/oswaldoacauan","html_url":"https://github.com/oswaldoacauan","followers_url":"https://api.github.com/users/oswaldoacauan/followers","following_url":"https://api.github.com/users/oswaldoacauan/following{/other_user}","gists_url":"https://api.github.com/users/oswaldoacauan/gists{/gist_id}","starred_url":"https://api.github.com/users/oswaldoacauan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oswaldoacauan/subscriptions","organizations_url":"https://api.github.com/users/oswaldoacauan/orgs","repos_url":"https://api.github.com/users/oswaldoacauan/repos","events_url":"https://api.github.com/users/oswaldoacauan/events{/privacy}","received_events_url":"https://api.github.com/users/oswaldoacauan/received_events","type":"User","site_admin":false},"body":"This code repeat in a lot of places. Maybe move it to a function?\r\n\r\n```js\r\nconst endMeeting = (code) => {\r\n  Session.set('codeError', code);\r\n  Session.set('isMeetingEnded', true);\r\n}\r\n```","created_at":"2018-10-25T13:55:36Z","updated_at":"2018-10-25T13:59:21Z","html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/6162#discussion_r228182625","pull_request_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/228182625"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/6162#discussion_r228182625"},"pull_request":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162"}}},"pull_request":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162","id":223343160,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzQzMTYw","html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/6162","diff_url":"https://github.com/bigbluebutton/bigbluebutton/pull/6162.diff","patch_url":"https://github.com/bigbluebutton/bigbluebutton/pull/6162.patch","issue_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/6162","number":6162,"state":"open","locked":false,"title":"Remove react router","user":{"login":"antobinary","id":6312397,"node_id":"MDQ6VXNlcjYzMTIzOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6312397?v=4","gravatar_id":"","url":"https://api.github.com/users/antobinary","html_url":"https://github.com/antobinary","followers_url":"https://api.github.com/users/antobinary/followers","following_url":"https://api.github.com/users/antobinary/following{/other_user}","gists_url":"https://api.github.com/users/antobinary/gists{/gist_id}","starred_url":"https://api.github.com/users/antobinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antobinary/subscriptions","organizations_url":"https://api.github.com/users/antobinary/orgs","repos_url":"https://api.github.com/users/antobinary/repos","events_url":"https://api.github.com/users/antobinary/events{/privacy}","received_events_url":"https://api.github.com/users/antobinary/received_events","type":"User","site_admin":false},"body":"Remaining items, perhaps addressable in consequent PR[s]\r\n- [ ] re-add Meteor.disconnect \r\n- [ ] revisit chat popup notifications (Chat seems to be broken on master atm)\r\n- [ ] improve on the callbacks / perhaps use Promises in auth.js\r\n","created_at":"2018-10-16T17:58:35Z","updated_at":"2018-10-25T13:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f7db05879e689cf5422346e13a2e40c2908ba84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":246901005,"node_id":"MDU6TGFiZWwyNDY5MDEwMDU=","url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels/HTML5%20Client","name":"HTML5 Client","color":"035418","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162/commits","review_comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162/comments","review_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/6162/comments","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/cde6311a5d4dd2a7fef79434f21512663dc52cf5","head":{"label":"antobinary:remove-react-router","ref":"remove-react-router","sha":"cde6311a5d4dd2a7fef79434f21512663dc52cf5","user":{"login":"antobinary","id":6312397,"node_id":"MDQ6VXNlcjYzMTIzOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6312397?v=4","gravatar_id":"","url":"https://api.github.com/users/antobinary","html_url":"https://github.com/antobinary","followers_url":"https://api.github.com/users/antobinary/followers","following_url":"https://api.github.com/users/antobinary/following{/other_user}","gists_url":"https://api.github.com/users/antobinary/gists{/gist_id}","starred_url":"https://api.github.com/users/antobinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antobinary/subscriptions","organizations_url":"https://api.github.com/users/antobinary/orgs","repos_url":"https://api.github.com/users/antobinary/repos","events_url":"https://api.github.com/users/antobinary/events{/privacy}","received_events_url":"https://api.github.com/users/antobinary/received_events","type":"User","site_admin":false},"repo":{"id":15679261,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3OTI2MQ==","name":"bigbluebutton","full_name":"antobinary/bigbluebutton","private":false,"owner":{"login":"antobinary","id":6312397,"node_id":"MDQ6VXNlcjYzMTIzOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6312397?v=4","gravatar_id":"","url":"https://api.github.com/users/antobinary","html_url":"https://github.com/antobinary","followers_url":"https://api.github.com/users/antobinary/followers","following_url":"https://api.github.com/users/antobinary/following{/other_user}","gists_url":"https://api.github.com/users/antobinary/gists{/gist_id}","starred_url":"https://api.github.com/users/antobinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antobinary/subscriptions","organizations_url":"https://api.github.com/users/antobinary/orgs","repos_url":"https://api.github.com/users/antobinary/repos","events_url":"https://api.github.com/users/antobinary/events{/privacy}","received_events_url":"https://api.github.com/users/antobinary/received_events","type":"User","site_admin":false},"html_url":"https://github.com/antobinary/bigbluebutton","description":"BigBlueButton is an open source web conferencing system for on-line learning.","fork":true,"url":"https://api.github.com/repos/antobinary/bigbluebutton","forks_url":"https://api.github.com/repos/antobinary/bigbluebutton/forks","keys_url":"https://api.github.com/repos/antobinary/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antobinary/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antobinary/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/antobinary/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/antobinary/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/antobinary/bigbluebutton/events","assignees_url":"https://api.github.com/repos/antobinary/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/antobinary/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/antobinary/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/antobinary/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antobinary/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antobinary/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/antobinary/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antobinary/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/antobinary/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/antobinary/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/antobinary/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/antobinary/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/antobinary/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/antobinary/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/antobinary/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/antobinary/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/antobinary/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/antobinary/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/antobinary/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antobinary/bigbluebutton/merges","archive_url":"https://api.github.com/repos/antobinary/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antobinary/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/antobinary/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/antobinary/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/antobinary/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/antobinary/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antobinary/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/antobinary/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/antobinary/bigbluebutton/deployments","created_at":"2014-01-06T16:43:46Z","updated_at":"2018-10-24T20:03:29Z","pushed_at":"2018-10-24T20:37:03Z","git_url":"git://github.com/antobinary/bigbluebutton.git","ssh_url":"git@github.com:antobinary/bigbluebutton.git","clone_url":"https://github.com/antobinary/bigbluebutton.git","svn_url":"https://github.com/antobinary/bigbluebutton","homepage":"www.bigbluebutton.org","size":655020,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"v2.0.x-release"}},"base":{"label":"bigbluebutton:master","ref":"master","sha":"2d1ad1fcd9181246be9cc0a9b722f5985610c338","user":{"login":"bigbluebutton","id":230228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDIyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/230228?v=4","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"repo":{"id":684382,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQzODI=","name":"bigbluebutton","full_name":"bigbluebutton/bigbluebutton","private":false,"owner":{"login":"bigbluebutton","id":230228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDIyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/230228?v=4","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bigbluebutton/bigbluebutton","description":"Complete open source web conferencing system.","fork":false,"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton","forks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/forks","keys_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/events","assignees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/merges","archive_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/deployments","created_at":"2010-05-25T01:42:41Z","updated_at":"2018-10-25T06:47:59Z","pushed_at":"2018-10-25T13:46:45Z","git_url":"git://github.com/bigbluebutton/bigbluebutton.git","ssh_url":"git@github.com:bigbluebutton/bigbluebutton.git","clone_url":"https://github.com/bigbluebutton/bigbluebutton.git","svn_url":"https://github.com/bigbluebutton/bigbluebutton","homepage":"http://www.bigbluebutton.org","size":650313,"stargazers_count":2194,"watchers_count":2194,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3623,"mirror_url":null,"archived":false,"open_issues_count":569,"license":null,"forks":3623,"open_issues":569,"watchers":2194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/6162"},"issue":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/6162"},"comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/6162/comments"},"review_comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162/comments"},"review_comment":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/6162/commits"},"statuses":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/cde6311a5d4dd2a7fef79434f21512663dc52cf5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"oswaldoacauan"}}