{"push_id":2632362519,"size":3,"distinct_size":1,"ref":"refs/heads/staging.tmp","head":"ee1ddc377dfcfb1392a4b0074a55232262a5e338","before":"ac6cecc249b71f4b4e27c78348f945486bf63e89","commits":[{"sha":"748d058b9ad2d1ffd9d99d40563fedb97d08e83e","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: test lease request MaxRaftIndex handling\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/748d058b9ad2d1ffd9d99d40563fedb97d08e83e"},{"sha":"79a72730b8d132be35f5390c62064de5533a260f","author":{"name":"Tobias Schottdorf","email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com"},"message":"storage: don't spuriously retry lease proposals\n\nWhen the Replica notices that an in-flight proposal has a\n`MaxLeaseIndex` not strictly ahead of the `LeaseAppliedIndex`, the\nproposal is considered failed (since it won't be able to apply\nsuccessfully).\n\nThe one exception are lease requests, for which `MaxLeaseIndex` is\nirrelevant. We weren't taking into account that exception, which\nresulted in the following odd sequence of events observed when a\nrange was woken up from a dormant state:\n\n1. lease gets proposed (at some bogus low `MaxLeaseIndex`)\n2. Raft group goes through elections\n3. refreshProposalsLocked deletes the proposal because it looked failed\n4. lease gets proposed again\n5. at apply time, previous lease request has already updated the lease,\n   so new proposal fails.\n\nIn effect, this caused an extra round of consensus.\n\nThe test added in this commit prevents regression of this problem.\nIt fails without the change in `refreshProposalsLocked`.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/79a72730b8d132be35f5390c62064de5533a260f"},{"sha":"ee1ddc377dfcfb1392a4b0074a55232262a5e338","author":{"name":"craig[bot]","email":"15684e4624bc7eae7b01fa1b5041cb4d6fa98fb6@users.noreply.github.com"},"message":"[ci skip] -bors-staging-tmp-26509","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ee1ddc377dfcfb1392a4b0074a55232262a5e338"}]}
{"actor":{"display_login":"craig"}}