{"action":"created","issue":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4794","repository_url":"https://api.github.com/repos/ankidroid/Anki-Android","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4794/labels{/name}","comments_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4794/comments","events_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4794/events","html_url":"https://github.com/ankidroid/Anki-Android/pull/4794","id":299575598,"number":4794,"title":"Change notifications to setRepeating, may fix issue #4525","user":{"login":"mikehardy","id":782704,"avatar_url":"https://avatars1.githubusercontent.com/u/782704?v=4","gravatar_id":"","url":"https://api.github.com/users/mikehardy","html_url":"https://github.com/mikehardy","followers_url":"https://api.github.com/users/mikehardy/followers","following_url":"https://api.github.com/users/mikehardy/following{/other_user}","gists_url":"https://api.github.com/users/mikehardy/gists{/gist_id}","starred_url":"https://api.github.com/users/mikehardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikehardy/subscriptions","organizations_url":"https://api.github.com/users/mikehardy/orgs","repos_url":"https://api.github.com/users/mikehardy/repos","events_url":"https://api.github.com/users/mikehardy/events{/privacy}","received_events_url":"https://api.github.com/users/mikehardy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-23T02:08:52Z","updated_at":"2018-02-25T01:16:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/pulls/4794","html_url":"https://github.com/ankidroid/Anki-Android/pull/4794","diff_url":"https://github.com/ankidroid/Anki-Android/pull/4794.diff","patch_url":"https://github.com/ankidroid/Anki-Android/pull/4794.patch"},"body":"simple change from setInexactRepeating to setRepeating\r\n\r\nI say it \"may\" fix issue #4525 because I am able to see notifications correctly firing at the expected time with and without the fix (on Nexus 5 API 23 stock emulator), but I it is obviously an issue for some\r\n\r\nThis will obviously need testing from the affected parties, and if it isn't sufficient the only alternative I see in AlarmManager is to implement recurrence in our code and call setWindow() to get closer to exact alarms"},"comment":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/comments/368274447","html_url":"https://github.com/ankidroid/Anki-Android/pull/4794#issuecomment-368274447","issue_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/4794","id":368274447,"user":{"login":"snowtimeglass","id":10436072,"avatar_url":"https://avatars3.githubusercontent.com/u/10436072?v=4","gravatar_id":"","url":"https://api.github.com/users/snowtimeglass","html_url":"https://github.com/snowtimeglass","followers_url":"https://api.github.com/users/snowtimeglass/followers","following_url":"https://api.github.com/users/snowtimeglass/following{/other_user}","gists_url":"https://api.github.com/users/snowtimeglass/gists{/gist_id}","starred_url":"https://api.github.com/users/snowtimeglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowtimeglass/subscriptions","organizations_url":"https://api.github.com/users/snowtimeglass/orgs","repos_url":"https://api.github.com/users/snowtimeglass/repos","events_url":"https://api.github.com/users/snowtimeglass/events{/privacy}","received_events_url":"https://api.github.com/users/snowtimeglass/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T01:16:29Z","updated_at":"2018-02-25T01:16:29Z","author_association":"CONTRIBUTOR","body":"@mikehardy \r\n\r\n>I would definitely like that. \r\n\r\nSure, I'll do that, if you still hope it. (I mean, I'm not sure you still hope it because you've already reproduced the issue on 4.3 emulator.) \r\n\r\n>It sounds like on 5.0 / 2.9alpha5 things work. \r\n\r\nYou mean there maybe aren't issues of #4525 on 5.0 / 2.9alpha**18**, right? \r\n\r\n>Are you able to build the app from source so you can test with the change in place, assuming you can reproduce the issue? \r\n\r\nI'm sorry but I can't build it.\r\n\r\n>If not, I could post a build of this pull request for you so you can see if it fixes it.\r\n\r\n>I think I witnessed it fixed with this pull request but I'd love to see someone else say the same.\r\n\r\nI'd love to try it!"}}
{"actor":{"display_login":"snowtimeglass"}}