{"action":"created","comment":{"url":"https://api.github.com/repos/TestRoots/watchdog/pulls/comments/184017899","pull_request_review_id":115126203,"id":184017899,"diff_hunk":"@@ -64,37 +64,37 @@ public void testCountSLOC() {\n \t}\n \n \t@Test\n-\tpublic void testHashFileNameEmpty() {\n+\tpublic void file_name_hash() {\n \t\tString expectedHash = \"\";\n \t\tassertEquals(expectedHash, WatchDogUtils.createFileNameHash(\"\"));\n \t\tassertEquals(expectedHash, WatchDogUtils.createFileNameHash(null));\n \t}\n \n \t@Test\n-\tpublic void testFileExtensionReplace() {\n+\tpublic void hash_ignores_extension() {\n \t\tString fileName = \"ATestClass\";\n \t\tString expected = WatchDogUtils.createFileNameHash(fileName + \".java\");\n \t\tassertEquals(expected, WatchDogUtils.createFileNameHash(fileName));\n \t}\n \n \t@Test\n-\tpublic void testMavenTestFileNotation() {\n+\tpublic void hash_can_handle_maven_notation() {\n \t\tString fileName = \"ATestClass\";\n \t\tString expected = WatchDogUtils.createFileNameHash(\"org.some.package.\"\n \t\t\t\t+ fileName);\n \t\tassertEquals(expected, WatchDogUtils.createFileNameHash(fileName));\n \t}\n \n \t@Test\n-\tpublic void testBugReplaceWithinStringDoesNotOccur() {\n+\tpublic void replace_within_string_does_not_throws_off_hash() {\n \t\tString unexpectedHash = WatchDogUtils\n \t\t\t\t.createFileNameHash(\"AClassTest.java\");\n \t\tassertTrue(!WatchDogUtils.createFileNameHash(\"ATestClassTest.java\")\n \t\t\t\t.equals(unexpectedHash));\n \t}\n \n \t@Test\n-\tpublic void testHashFileName() {\n+\tpublic void test_should_be_extracted_into_hash() {","path":"eclipse/tests/src/nl/tudelft/watchdog/util/WatchDogUtilsTest.java","position":null,"original_position":74,"commit_id":"89c3ce98dc8718e12e0d7ca4f8392c041a9357c4","original_commit_id":"9eedbbf4099505f8322f5088aca22f8c99972695","user":{"login":"TimvdLippe","id":5948271,"avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"body":"Done :+1: ","created_at":"2018-04-25T10:58:04Z","updated_at":"2018-04-25T10:58:04Z","html_url":"https://github.com/TestRoots/watchdog/pull/292#discussion_r184017899","pull_request_url":"https://api.github.com/repos/TestRoots/watchdog/pulls/292","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/comments/184017899"},"html":{"href":"https://github.com/TestRoots/watchdog/pull/292#discussion_r184017899"},"pull_request":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/292"}},"in_reply_to_id":183999910},"pull_request":{"url":"https://api.github.com/repos/TestRoots/watchdog/pulls/292","id":180281811,"html_url":"https://github.com/TestRoots/watchdog/pull/292","diff_url":"https://github.com/TestRoots/watchdog/pull/292.diff","patch_url":"https://github.com/TestRoots/watchdog/pull/292.patch","issue_url":"https://api.github.com/repos/TestRoots/watchdog/issues/292","number":292,"state":"open","locked":false,"title":"Enable checkstyle","user":{"login":"TimvdLippe","id":5948271,"avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"body":"Enable CheckStyle to make sure we maintain a uniform codebase. The configuration also comes with http://editorconfig.org/ which makes sure developers do not need to worry about formatting. The editor will do that automatically for you.\r\n\r\nAlso make all test method names uniform to snake_case, as that is more readable when analyzing CI logs.\r\n\r\nLastly, fix an issue with the persister tests, which had inter-dependency. This was first solved with a custom runner, but this is a brittle approach as single tests can then no longer be executed. Instead, 1 testcase should be used and for readability the logic should be split into multiple private methods.\r\n\r\nFixes #283 ","created_at":"2018-04-09T11:21:45Z","updated_at":"2018-04-25T10:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"062a2e2266311aa5aa5e4c6c3b1ef9c1dfc66197","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TestRoots/watchdog/pulls/292/commits","review_comments_url":"https://api.github.com/repos/TestRoots/watchdog/pulls/292/comments","review_comment_url":"https://api.github.com/repos/TestRoots/watchdog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TestRoots/watchdog/issues/292/comments","statuses_url":"https://api.github.com/repos/TestRoots/watchdog/statuses/89c3ce98dc8718e12e0d7ca4f8392c041a9357c4","head":{"label":"TestRoots:enable-checkstyle","ref":"enable-checkstyle","sha":"89c3ce98dc8718e12e0d7ca4f8392c041a9357c4","user":{"login":"TestRoots","id":6726508,"avatar_url":"https://avatars2.githubusercontent.com/u/6726508?v=4","gravatar_id":"","url":"https://api.github.com/users/TestRoots","html_url":"https://github.com/TestRoots","followers_url":"https://api.github.com/users/TestRoots/followers","following_url":"https://api.github.com/users/TestRoots/following{/other_user}","gists_url":"https://api.github.com/users/TestRoots/gists{/gist_id}","starred_url":"https://api.github.com/users/TestRoots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestRoots/subscriptions","organizations_url":"https://api.github.com/users/TestRoots/orgs","repos_url":"https://api.github.com/users/TestRoots/repos","events_url":"https://api.github.com/users/TestRoots/events{/privacy}","received_events_url":"https://api.github.com/users/TestRoots/received_events","type":"Organization","site_admin":false},"repo":{"id":16944185,"name":"watchdog","full_name":"TestRoots/watchdog","owner":{"login":"TestRoots","id":6726508,"avatar_url":"https://avatars2.githubusercontent.com/u/6726508?v=4","gravatar_id":"","url":"https://api.github.com/users/TestRoots","html_url":"https://github.com/TestRoots","followers_url":"https://api.github.com/users/TestRoots/followers","following_url":"https://api.github.com/users/TestRoots/following{/other_user}","gists_url":"https://api.github.com/users/TestRoots/gists{/gist_id}","starred_url":"https://api.github.com/users/TestRoots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestRoots/subscriptions","organizations_url":"https://api.github.com/users/TestRoots/orgs","repos_url":"https://api.github.com/users/TestRoots/repos","events_url":"https://api.github.com/users/TestRoots/events{/privacy}","received_events_url":"https://api.github.com/users/TestRoots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestRoots/watchdog","description":"IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested","fork":false,"url":"https://api.github.com/repos/TestRoots/watchdog","forks_url":"https://api.github.com/repos/TestRoots/watchdog/forks","keys_url":"https://api.github.com/repos/TestRoots/watchdog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestRoots/watchdog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestRoots/watchdog/teams","hooks_url":"https://api.github.com/repos/TestRoots/watchdog/hooks","issue_events_url":"https://api.github.com/repos/TestRoots/watchdog/issues/events{/number}","events_url":"https://api.github.com/repos/TestRoots/watchdog/events","assignees_url":"https://api.github.com/repos/TestRoots/watchdog/assignees{/user}","branches_url":"https://api.github.com/repos/TestRoots/watchdog/branches{/branch}","tags_url":"https://api.github.com/repos/TestRoots/watchdog/tags","blobs_url":"https://api.github.com/repos/TestRoots/watchdog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestRoots/watchdog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestRoots/watchdog/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestRoots/watchdog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestRoots/watchdog/statuses/{sha}","languages_url":"https://api.github.com/repos/TestRoots/watchdog/languages","stargazers_url":"https://api.github.com/repos/TestRoots/watchdog/stargazers","contributors_url":"https://api.github.com/repos/TestRoots/watchdog/contributors","subscribers_url":"https://api.github.com/repos/TestRoots/watchdog/subscribers","subscription_url":"https://api.github.com/repos/TestRoots/watchdog/subscription","commits_url":"https://api.github.com/repos/TestRoots/watchdog/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestRoots/watchdog/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestRoots/watchdog/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestRoots/watchdog/issues/comments{/number}","contents_url":"https://api.github.com/repos/TestRoots/watchdog/contents/{+path}","compare_url":"https://api.github.com/repos/TestRoots/watchdog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestRoots/watchdog/merges","archive_url":"https://api.github.com/repos/TestRoots/watchdog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestRoots/watchdog/downloads","issues_url":"https://api.github.com/repos/TestRoots/watchdog/issues{/number}","pulls_url":"https://api.github.com/repos/TestRoots/watchdog/pulls{/number}","milestones_url":"https://api.github.com/repos/TestRoots/watchdog/milestones{/number}","notifications_url":"https://api.github.com/repos/TestRoots/watchdog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestRoots/watchdog/labels{/name}","releases_url":"https://api.github.com/repos/TestRoots/watchdog/releases{/id}","deployments_url":"https://api.github.com/repos/TestRoots/watchdog/deployments","created_at":"2014-02-18T09:51:36Z","updated_at":"2018-04-25T09:51:29Z","pushed_at":"2018-04-25T10:57:54Z","git_url":"git://github.com/TestRoots/watchdog.git","ssh_url":"git@github.com:TestRoots/watchdog.git","clone_url":"https://github.com/TestRoots/watchdog.git","svn_url":"https://github.com/TestRoots/watchdog","homepage":"http://www.testroots.org","size":33286,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":16,"watchers":16,"default_branch":"master"}},"base":{"label":"TestRoots:master","ref":"master","sha":"511c138ac2198f518b186cc31bff44808ecc01ad","user":{"login":"TestRoots","id":6726508,"avatar_url":"https://avatars2.githubusercontent.com/u/6726508?v=4","gravatar_id":"","url":"https://api.github.com/users/TestRoots","html_url":"https://github.com/TestRoots","followers_url":"https://api.github.com/users/TestRoots/followers","following_url":"https://api.github.com/users/TestRoots/following{/other_user}","gists_url":"https://api.github.com/users/TestRoots/gists{/gist_id}","starred_url":"https://api.github.com/users/TestRoots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestRoots/subscriptions","organizations_url":"https://api.github.com/users/TestRoots/orgs","repos_url":"https://api.github.com/users/TestRoots/repos","events_url":"https://api.github.com/users/TestRoots/events{/privacy}","received_events_url":"https://api.github.com/users/TestRoots/received_events","type":"Organization","site_admin":false},"repo":{"id":16944185,"name":"watchdog","full_name":"TestRoots/watchdog","owner":{"login":"TestRoots","id":6726508,"avatar_url":"https://avatars2.githubusercontent.com/u/6726508?v=4","gravatar_id":"","url":"https://api.github.com/users/TestRoots","html_url":"https://github.com/TestRoots","followers_url":"https://api.github.com/users/TestRoots/followers","following_url":"https://api.github.com/users/TestRoots/following{/other_user}","gists_url":"https://api.github.com/users/TestRoots/gists{/gist_id}","starred_url":"https://api.github.com/users/TestRoots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestRoots/subscriptions","organizations_url":"https://api.github.com/users/TestRoots/orgs","repos_url":"https://api.github.com/users/TestRoots/repos","events_url":"https://api.github.com/users/TestRoots/events{/privacy}","received_events_url":"https://api.github.com/users/TestRoots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestRoots/watchdog","description":"IntelliJ & Eclipse plugin for monitoring how Java applications are developed and tested","fork":false,"url":"https://api.github.com/repos/TestRoots/watchdog","forks_url":"https://api.github.com/repos/TestRoots/watchdog/forks","keys_url":"https://api.github.com/repos/TestRoots/watchdog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestRoots/watchdog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestRoots/watchdog/teams","hooks_url":"https://api.github.com/repos/TestRoots/watchdog/hooks","issue_events_url":"https://api.github.com/repos/TestRoots/watchdog/issues/events{/number}","events_url":"https://api.github.com/repos/TestRoots/watchdog/events","assignees_url":"https://api.github.com/repos/TestRoots/watchdog/assignees{/user}","branches_url":"https://api.github.com/repos/TestRoots/watchdog/branches{/branch}","tags_url":"https://api.github.com/repos/TestRoots/watchdog/tags","blobs_url":"https://api.github.com/repos/TestRoots/watchdog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestRoots/watchdog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestRoots/watchdog/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestRoots/watchdog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestRoots/watchdog/statuses/{sha}","languages_url":"https://api.github.com/repos/TestRoots/watchdog/languages","stargazers_url":"https://api.github.com/repos/TestRoots/watchdog/stargazers","contributors_url":"https://api.github.com/repos/TestRoots/watchdog/contributors","subscribers_url":"https://api.github.com/repos/TestRoots/watchdog/subscribers","subscription_url":"https://api.github.com/repos/TestRoots/watchdog/subscription","commits_url":"https://api.github.com/repos/TestRoots/watchdog/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestRoots/watchdog/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestRoots/watchdog/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestRoots/watchdog/issues/comments{/number}","contents_url":"https://api.github.com/repos/TestRoots/watchdog/contents/{+path}","compare_url":"https://api.github.com/repos/TestRoots/watchdog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestRoots/watchdog/merges","archive_url":"https://api.github.com/repos/TestRoots/watchdog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestRoots/watchdog/downloads","issues_url":"https://api.github.com/repos/TestRoots/watchdog/issues{/number}","pulls_url":"https://api.github.com/repos/TestRoots/watchdog/pulls{/number}","milestones_url":"https://api.github.com/repos/TestRoots/watchdog/milestones{/number}","notifications_url":"https://api.github.com/repos/TestRoots/watchdog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestRoots/watchdog/labels{/name}","releases_url":"https://api.github.com/repos/TestRoots/watchdog/releases{/id}","deployments_url":"https://api.github.com/repos/TestRoots/watchdog/deployments","created_at":"2014-02-18T09:51:36Z","updated_at":"2018-04-25T09:51:29Z","pushed_at":"2018-04-25T10:57:54Z","git_url":"git://github.com/TestRoots/watchdog.git","ssh_url":"git@github.com:TestRoots/watchdog.git","clone_url":"https://github.com/TestRoots/watchdog.git","svn_url":"https://github.com/TestRoots/watchdog","homepage":"http://www.testroots.org","size":33286,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":16,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/292"},"html":{"href":"https://github.com/TestRoots/watchdog/pull/292"},"issue":{"href":"https://api.github.com/repos/TestRoots/watchdog/issues/292"},"comments":{"href":"https://api.github.com/repos/TestRoots/watchdog/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TestRoots/watchdog/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/TestRoots/watchdog/statuses/89c3ce98dc8718e12e0d7ca4f8392c041a9357c4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"TimvdLippe"}}