{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/211129172","pull_request_review_id":147486810,"id":211129172,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEyOTE3Mg==","diff_hunk":"@@ -341,6 +341,23 @@ reader.pipe(writer);\n reader.unpipe(writer);\n ```\n \n+##### writable.acquireStandardStream()","path":"doc/api/stream.md","position":4,"original_position":4,"commit_id":"1a071af63023f3fe5de64ba8b5a06428e5efee88","original_commit_id":"391489c0e6c6348fa80d41855a21a15f5e340332","user":{"login":"devsnek","id":5952481,"node_id":"MDQ6VXNlcjU5NTI0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"body":"I'm hopeful we can come up with something that isn't importing separate functions. I want to have as little friction as possible for people wanting to use whatwg streams, as there are quite a lot of locations where the interop needs to happen. I'm willing to continue bikeshedding this for as long as we need to for something that works for everyone, but it would seem we both have constraints here.","created_at":"2018-08-20T02:33:11Z","updated_at":"2018-08-20T02:33:11Z","html_url":"https://github.com/nodejs/node/pull/22352#discussion_r211129172","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/22352","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/211129172"},"html":{"href":"https://github.com/nodejs/node/pull/22352#discussion_r211129172"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/22352"}},"in_reply_to_id":211118136},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22352","id":208756232,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzU2MjMy","html_url":"https://github.com/nodejs/node/pull/22352","diff_url":"https://github.com/nodejs/node/pull/22352.diff","patch_url":"https://github.com/nodejs/node/pull/22352.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22352","number":22352,"state":"open","locked":false,"title":"stream-whatwg: add whatwg streams","user":{"login":"devsnek","id":5952481,"node_id":"MDQ6VXNlcjU5NTI0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"body":"This pr adds a whatwg stream implementation from chromium and a WPT test runner.\r\n\r\nI was inspired to work on this specifically because of the WebAssembly streaming PR that was recently opened but I think these streams stand well enough on their own.\r\n\r\nThis provides the a piece of the puzzle for wasm streaming, fetch, and some things I'd like to see used in esm.\r\n\r\nI realize that this isn't really in @nodejs/streams's plans and such so I'm marking this as discuss and in progress.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-08-16T06:23:06Z","updated_at":"2018-08-20T02:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc808b131395fb9efb529ae7601768bd576843ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":171787081,"node_id":"MDU6TGFiZWwxNzE3ODcwODE=","url":"https://api.github.com/repos/nodejs/node/labels/discuss","name":"discuss","color":"02d7e1","default":false},{"id":154312478,"node_id":"MDU6TGFiZWwxNTQzMTI0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/in%20progress","name":"in progress","color":"ffff00","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":169485514,"node_id":"MDU6TGFiZWwxNjk0ODU1MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22352/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22352/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22352/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/1a071af63023f3fe5de64ba8b5a06428e5efee88","head":{"label":"devsnek:feature/whatwg-streams","ref":"feature/whatwg-streams","sha":"1a071af63023f3fe5de64ba8b5a06428e5efee88","user":{"login":"devsnek","id":5952481,"node_id":"MDQ6VXNlcjU5NTI0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"repo":{"id":86208251,"node_id":"MDEwOlJlcG9zaXRvcnk4NjIwODI1MQ==","name":"node","full_name":"devsnek/node","owner":{"login":"devsnek","id":5952481,"node_id":"MDQ6VXNlcjU5NTI0ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5952481?v=4","gravatar_id":"","url":"https://api.github.com/users/devsnek","html_url":"https://github.com/devsnek","followers_url":"https://api.github.com/users/devsnek/followers","following_url":"https://api.github.com/users/devsnek/following{/other_user}","gists_url":"https://api.github.com/users/devsnek/gists{/gist_id}","starred_url":"https://api.github.com/users/devsnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devsnek/subscriptions","organizations_url":"https://api.github.com/users/devsnek/orgs","repos_url":"https://api.github.com/users/devsnek/repos","events_url":"https://api.github.com/users/devsnek/events{/privacy}","received_events_url":"https://api.github.com/users/devsnek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devsnek/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/devsnek/node","forks_url":"https://api.github.com/repos/devsnek/node/forks","keys_url":"https://api.github.com/repos/devsnek/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devsnek/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devsnek/node/teams","hooks_url":"https://api.github.com/repos/devsnek/node/hooks","issue_events_url":"https://api.github.com/repos/devsnek/node/issues/events{/number}","events_url":"https://api.github.com/repos/devsnek/node/events","assignees_url":"https://api.github.com/repos/devsnek/node/assignees{/user}","branches_url":"https://api.github.com/repos/devsnek/node/branches{/branch}","tags_url":"https://api.github.com/repos/devsnek/node/tags","blobs_url":"https://api.github.com/repos/devsnek/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devsnek/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devsnek/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/devsnek/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devsnek/node/statuses/{sha}","languages_url":"https://api.github.com/repos/devsnek/node/languages","stargazers_url":"https://api.github.com/repos/devsnek/node/stargazers","contributors_url":"https://api.github.com/repos/devsnek/node/contributors","subscribers_url":"https://api.github.com/repos/devsnek/node/subscribers","subscription_url":"https://api.github.com/repos/devsnek/node/subscription","commits_url":"https://api.github.com/repos/devsnek/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/devsnek/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/devsnek/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/devsnek/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/devsnek/node/contents/{+path}","compare_url":"https://api.github.com/repos/devsnek/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devsnek/node/merges","archive_url":"https://api.github.com/repos/devsnek/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devsnek/node/downloads","issues_url":"https://api.github.com/repos/devsnek/node/issues{/number}","pulls_url":"https://api.github.com/repos/devsnek/node/pulls{/number}","milestones_url":"https://api.github.com/repos/devsnek/node/milestones{/number}","notifications_url":"https://api.github.com/repos/devsnek/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devsnek/node/labels{/name}","releases_url":"https://api.github.com/repos/devsnek/node/releases{/id}","deployments_url":"https://api.github.com/repos/devsnek/node/deployments","created_at":"2017-03-26T04:48:23Z","updated_at":"2018-08-07T00:05:14Z","pushed_at":"2018-08-20T02:09:53Z","git_url":"git://github.com/devsnek/node.git","ssh_url":"git@github.com:devsnek/node.git","clone_url":"https://github.com/devsnek/node.git","svn_url":"https://github.com/devsnek/node","homepage":"https://nodejs.org","size":350331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"79642ae071bde3d0552566a31cc3867d85476795","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-08-20T02:19:13Z","pushed_at":"2018-08-20T02:15:10Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":402727,"stargazers_count":52416,"watchers_count":52416,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11076,"mirror_url":null,"archived":false,"open_issues_count":853,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11076,"open_issues":853,"watchers":52416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22352"},"html":{"href":"https://github.com/nodejs/node/pull/22352"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22352"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22352/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22352/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22352/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/1a071af63023f3fe5de64ba8b5a06428e5efee88"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"devsnek"}}