{"action":"created","issue":{"url":"https://api.github.com/repos/authorjapps/zerocode/issues/141","repository_url":"https://api.github.com/repos/authorjapps/zerocode","labels_url":"https://api.github.com/repos/authorjapps/zerocode/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/authorjapps/zerocode/issues/141/comments","events_url":"https://api.github.com/repos/authorjapps/zerocode/issues/141/events","html_url":"https://github.com/authorjapps/zerocode/issues/141","id":371774772,"node_id":"MDU6SXNzdWUzNzE3NzQ3NzI=","number":141,"title":"Support Content type \"application/x-www-form-urlencoded\" with sending KeyValue params","user":{"login":"arunvelusamyd","id":21174506,"node_id":"MDQ6VXNlcjIxMTc0NTA2","avatar_url":"https://avatars1.githubusercontent.com/u/21174506?v=4","gravatar_id":"","url":"https://api.github.com/users/arunvelusamyd","html_url":"https://github.com/arunvelusamyd","followers_url":"https://api.github.com/users/arunvelusamyd/followers","following_url":"https://api.github.com/users/arunvelusamyd/following{/other_user}","gists_url":"https://api.github.com/users/arunvelusamyd/gists{/gist_id}","starred_url":"https://api.github.com/users/arunvelusamyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunvelusamyd/subscriptions","organizations_url":"https://api.github.com/users/arunvelusamyd/orgs","repos_url":"https://api.github.com/users/arunvelusamyd/repos","events_url":"https://api.github.com/users/arunvelusamyd/events{/privacy}","received_events_url":"https://api.github.com/users/arunvelusamyd/received_events","type":"User","site_admin":false},"labels":[{"id":403253704,"node_id":"MDU6TGFiZWw0MDMyNTM3MDQ=","url":"https://api.github.com/repos/authorjapps/zerocode/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-10-19T01:40:35Z","updated_at":"2018-10-25T21:12:18Z","closed_at":null,"author_association":"NONE","body":"Content type \"application/x-www-form-urlencoded\" is not supported. Request body is always considered as Json or Multipart.\r\n\r\nMy rest controlled looks something like below, \r\n```\r\n@POST\r\n@Consumes({\"application/x-www-form-urlencoded\"})\r\npublic Response handleRequest(MultivaluedMap<String, String> params) {\r\n}\r\n```\r\n\r\nI tried using the below format. But it was failing. \r\n```\r\n\"request\": {\r\n  \"headers\": {\r\n    \"Content-Type\": \"application/x-www-form-urlencoded\"\r\n  },\r\n  \"body\": {\r\n    \"Name\": \"Larry Pg\",\r\n    \"Company\": \"Amazon\",\r\n    \"Title\": \"CEO\"\r\n  }\r\n}\r\n```\r\n\r\nLike to change the method createRequestBuilder of the class BasicHttpClient. \r\n"},"comment":{"url":"https://api.github.com/repos/authorjapps/zerocode/issues/comments/433207468","html_url":"https://github.com/authorjapps/zerocode/issues/141#issuecomment-433207468","issue_url":"https://api.github.com/repos/authorjapps/zerocode/issues/141","id":433207468,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzIwNzQ2OA==","user":{"login":"authorjapps","id":12598420,"node_id":"MDQ6VXNlcjEyNTk4NDIw","avatar_url":"https://avatars0.githubusercontent.com/u/12598420?v=4","gravatar_id":"","url":"https://api.github.com/users/authorjapps","html_url":"https://github.com/authorjapps","followers_url":"https://api.github.com/users/authorjapps/followers","following_url":"https://api.github.com/users/authorjapps/following{/other_user}","gists_url":"https://api.github.com/users/authorjapps/gists{/gist_id}","starred_url":"https://api.github.com/users/authorjapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/authorjapps/subscriptions","organizations_url":"https://api.github.com/users/authorjapps/orgs","repos_url":"https://api.github.com/users/authorjapps/repos","events_url":"https://api.github.com/users/authorjapps/events{/privacy}","received_events_url":"https://api.github.com/users/authorjapps/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T21:12:18Z","updated_at":"2018-10-25T21:12:18Z","author_association":"OWNER","body":"Folks, all concerns have been taken care now in the PR. Please have a look, review n approve-\r\nOverall the below things has been take care n will be available once merged - \r\n- Request `body` can be passed as key-value pair for this `header` type - let's keep this feature as this is a natural choice for users (we can add into readme 👍 @arunvelusamyd )\r\n- `queryParams` also now has been enhanced to take care of special chars - the similar logic from the PR has been implemented\r\n- BasicHttpClient some methods are `public` **intentionally** as they are already in use in the corporates, where put their custom logic/headers/request-builder/corporate-prosy etc via `@UseHttpClient`. Just a note of caution _not to make it private_\r\n- Better test coverage now for both `body` and `queryParams` handling\r\n- HelloWorld project has been verified with `1.2.9-SNAPSHOT` build 👍 \r\n\r\nI will keep it open for a day and merge it. If it is super urgent, let me know ! \r\n\r\n@officiallysameer @dinesh76in @macrocks @cooljavadev FYA please.\r\n"}}
{"actor":{"display_login":"authorjapps"}}