{"action":"created","comment":{"url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/comments/204857867","pull_request_review_id":140014271,"id":204857867,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg1Nzg2Nw==","diff_hunk":"@@ -315,10 +322,10 @@ <h3 class=\"modal-links\">\n                 var addtl_filter = $(this).attr('data');\n \n                 if(existing_q){\n-                    window.location.assign('/search/?'+existing_q+'&selected_facets='+encodeURIComponent(addtl_filter)+\"&_=\"+timestamp);","path":"councilmatic_core/templates/search/search.html","position":46,"original_position":39,"commit_id":"c7bb43719ecd5b503f7058b934200818cf686eef","original_commit_id":"3b8b2ace78b97f487d75ca9dfbb18cbf66ec1e73","user":{"login":"reginafcompton","id":13078679,"node_id":"MDQ6VXNlcjEzMDc4Njc5","avatar_url":"https://avatars1.githubusercontent.com/u/13078679?v=4","gravatar_id":"","url":"https://api.github.com/users/reginafcompton","html_url":"https://github.com/reginafcompton","followers_url":"https://api.github.com/users/reginafcompton/followers","following_url":"https://api.github.com/users/reginafcompton/following{/other_user}","gists_url":"https://api.github.com/users/reginafcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/reginafcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reginafcompton/subscriptions","organizations_url":"https://api.github.com/users/reginafcompton/orgs","repos_url":"https://api.github.com/users/reginafcompton/repos","events_url":"https://api.github.com/users/reginafcompton/events{/privacy}","received_events_url":"https://api.github.com/users/reginafcompton/received_events","type":"User","site_admin":false},"body":"I actually do not see any use of these timestamps. So, confidently removing them.","created_at":"2018-07-24T18:08:47Z","updated_at":"2018-07-24T18:08:47Z","html_url":"https://github.com/datamade/django-councilmatic/pull/210#discussion_r204857867","pull_request_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/comments/204857867"},"html":{"href":"https://github.com/datamade/django-councilmatic/pull/210#discussion_r204857867"},"pull_request":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210"}},"in_reply_to_id":204164059},"pull_request":{"url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210","id":201404222,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDA0MjIy","html_url":"https://github.com/datamade/django-councilmatic/pull/210","diff_url":"https://github.com/datamade/django-councilmatic/pull/210.diff","patch_url":"https://github.com/datamade/django-councilmatic/pull/210.patch","issue_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/210","number":210,"state":"open","locked":false,"title":"Refactor search-order","user":{"login":"reginafcompton","id":13078679,"node_id":"MDQ6VXNlcjEzMDc4Njc5","avatar_url":"https://avatars1.githubusercontent.com/u/13078679?v=4","gravatar_id":"","url":"https://api.github.com/users/reginafcompton","html_url":"https://github.com/reginafcompton","followers_url":"https://api.github.com/users/reginafcompton/followers","following_url":"https://api.github.com/users/reginafcompton/following{/other_user}","gists_url":"https://api.github.com/users/reginafcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/reginafcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reginafcompton/subscriptions","organizations_url":"https://api.github.com/users/reginafcompton/orgs","repos_url":"https://api.github.com/users/reginafcompton/repos","events_url":"https://api.github.com/users/reginafcompton/events{/privacy}","received_events_url":"https://api.github.com/users/reginafcompton/received_events","type":"User","site_admin":false},"body":"This PR addresses a few search-related code smells:\r\n1. it simplifies the template logic for showing sort and order options;\r\n2. it uses the conventions of urllib for url parsing and encoding;\r\n3. it removes the `full_text` from the the Solr index (which contains RTF) and instead uses only the `ocr_full_text`. \r\n\r\n@hancush - requesting your review....but @evz would welcome your feedback, too.\r\n\r\nRelates to https://github.com/datamade/la-metro-councilmatic/issues/309","created_at":"2018-07-13T21:27:02Z","updated_at":"2018-07-24T18:08:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b70a261573ac6c992db71ab44bc5f6b631abd746","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210/commits","review_comments_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210/comments","review_comment_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/210/comments","statuses_url":"https://api.github.com/repos/datamade/django-councilmatic/statuses/c7bb43719ecd5b503f7058b934200818cf686eef","head":{"label":"datamade:search-order","ref":"search-order","sha":"c7bb43719ecd5b503f7058b934200818cf686eef","user":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":43980639,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk4MDYzOQ==","name":"django-councilmatic","full_name":"datamade/django-councilmatic","owner":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datamade/django-councilmatic","description":":heartpulse: Django app providing core functions for *.councilmatic.org","fork":false,"url":"https://api.github.com/repos/datamade/django-councilmatic","forks_url":"https://api.github.com/repos/datamade/django-councilmatic/forks","keys_url":"https://api.github.com/repos/datamade/django-councilmatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/django-councilmatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/django-councilmatic/teams","hooks_url":"https://api.github.com/repos/datamade/django-councilmatic/hooks","issue_events_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/django-councilmatic/events","assignees_url":"https://api.github.com/repos/datamade/django-councilmatic/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/django-councilmatic/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/django-councilmatic/tags","blobs_url":"https://api.github.com/repos/datamade/django-councilmatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/django-councilmatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/django-councilmatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/django-councilmatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/django-councilmatic/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/django-councilmatic/languages","stargazers_url":"https://api.github.com/repos/datamade/django-councilmatic/stargazers","contributors_url":"https://api.github.com/repos/datamade/django-councilmatic/contributors","subscribers_url":"https://api.github.com/repos/datamade/django-councilmatic/subscribers","subscription_url":"https://api.github.com/repos/datamade/django-councilmatic/subscription","commits_url":"https://api.github.com/repos/datamade/django-councilmatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/django-councilmatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/django-councilmatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/django-councilmatic/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/django-councilmatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/django-councilmatic/merges","archive_url":"https://api.github.com/repos/datamade/django-councilmatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/django-councilmatic/downloads","issues_url":"https://api.github.com/repos/datamade/django-councilmatic/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/django-councilmatic/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/django-councilmatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/django-councilmatic/labels{/name}","releases_url":"https://api.github.com/repos/datamade/django-councilmatic/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/django-councilmatic/deployments","created_at":"2015-10-09T21:18:40Z","updated_at":"2018-06-29T13:30:35Z","pushed_at":"2018-07-24T14:24:07Z","git_url":"git://github.com/datamade/django-councilmatic.git","ssh_url":"git@github.com:datamade/django-councilmatic.git","clone_url":"https://github.com/datamade/django-councilmatic.git","svn_url":"https://github.com/datamade/django-councilmatic","homepage":"http://councilmatic.org","size":11728,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":40,"watchers":19,"default_branch":"master"}},"base":{"label":"datamade:master","ref":"master","sha":"ae059eb85708fb16e94490bf417cf16e5f9a0dfd","user":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":43980639,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk4MDYzOQ==","name":"django-councilmatic","full_name":"datamade/django-councilmatic","owner":{"login":"datamade","id":3723931,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjM5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datamade/django-councilmatic","description":":heartpulse: Django app providing core functions for *.councilmatic.org","fork":false,"url":"https://api.github.com/repos/datamade/django-councilmatic","forks_url":"https://api.github.com/repos/datamade/django-councilmatic/forks","keys_url":"https://api.github.com/repos/datamade/django-councilmatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/django-councilmatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/django-councilmatic/teams","hooks_url":"https://api.github.com/repos/datamade/django-councilmatic/hooks","issue_events_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/django-councilmatic/events","assignees_url":"https://api.github.com/repos/datamade/django-councilmatic/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/django-councilmatic/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/django-councilmatic/tags","blobs_url":"https://api.github.com/repos/datamade/django-councilmatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/django-councilmatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/django-councilmatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/django-councilmatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/django-councilmatic/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/django-councilmatic/languages","stargazers_url":"https://api.github.com/repos/datamade/django-councilmatic/stargazers","contributors_url":"https://api.github.com/repos/datamade/django-councilmatic/contributors","subscribers_url":"https://api.github.com/repos/datamade/django-councilmatic/subscribers","subscription_url":"https://api.github.com/repos/datamade/django-councilmatic/subscription","commits_url":"https://api.github.com/repos/datamade/django-councilmatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/django-councilmatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/django-councilmatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/django-councilmatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/django-councilmatic/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/django-councilmatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/django-councilmatic/merges","archive_url":"https://api.github.com/repos/datamade/django-councilmatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/django-councilmatic/downloads","issues_url":"https://api.github.com/repos/datamade/django-councilmatic/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/django-councilmatic/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/django-councilmatic/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/django-councilmatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/django-councilmatic/labels{/name}","releases_url":"https://api.github.com/repos/datamade/django-councilmatic/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/django-councilmatic/deployments","created_at":"2015-10-09T21:18:40Z","updated_at":"2018-06-29T13:30:35Z","pushed_at":"2018-07-24T14:24:07Z","git_url":"git://github.com/datamade/django-councilmatic.git","ssh_url":"git@github.com:datamade/django-councilmatic.git","clone_url":"https://github.com/datamade/django-councilmatic.git","svn_url":"https://github.com/datamade/django-councilmatic","homepage":"http://councilmatic.org","size":11728,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":40,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210"},"html":{"href":"https://github.com/datamade/django-councilmatic/pull/210"},"issue":{"href":"https://api.github.com/repos/datamade/django-councilmatic/issues/210"},"comments":{"href":"https://api.github.com/repos/datamade/django-councilmatic/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datamade/django-councilmatic/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/datamade/django-councilmatic/statuses/c7bb43719ecd5b503f7058b934200818cf686eef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reginafcompton"}}