{"action":"created","comment":{"url":"https://api.github.com/repos/usnistgov/ACVP/pulls/comments/189872930","pull_request_review_id":122133648,"id":189872930,"diff_hunk":"@@ -1400,7 +1392,7 @@\n \t\t\t\t\"kdfType\": \"asn1\",\n \t\t\t\t\"idServerLen\": 48,\n \t\t\t\t\"idServer\": \"434156536964\",\n-\t\t\t\t\"curveName\": \"p-256\",\n+\t\t\t\t\"curve\": \"p-256\",","path":"src/acvp_sub_kas_ecc.xml","position":267,"original_position":267,"commit_id":"d66a1370039057bc47efa6b3bb7cac111fe25e8d","original_commit_id":"d66a1370039057bc47efa6b3bb7cac111fe25e8d","user":{"login":"Kritner","id":8814983,"avatar_url":"https://avatars1.githubusercontent.com/u/8814983?v=4","gravatar_id":"","url":"https://api.github.com/users/Kritner","html_url":"https://github.com/Kritner","followers_url":"https://api.github.com/users/Kritner/followers","following_url":"https://api.github.com/users/Kritner/following{/other_user}","gists_url":"https://api.github.com/users/Kritner/gists{/gist_id}","starred_url":"https://api.github.com/users/Kritner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kritner/subscriptions","organizations_url":"https://api.github.com/users/Kritner/orgs","repos_url":"https://api.github.com/users/Kritner/repos","events_url":"https://api.github.com/users/Kritner/events{/privacy}","received_events_url":"https://api.github.com/users/Kritner/received_events","type":"User","site_admin":false},"body":"Perhaps the capitalized curve names could be in a separate PR? ECDSA is currently using lowered curves names as well, so at the least they're currently consistent.","created_at":"2018-05-22T11:56:41Z","updated_at":"2018-05-22T11:56:41Z","html_url":"https://github.com/usnistgov/ACVP/pull/355#discussion_r189872930","pull_request_url":"https://api.github.com/repos/usnistgov/ACVP/pulls/355","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/comments/189872930"},"html":{"href":"https://github.com/usnistgov/ACVP/pull/355#discussion_r189872930"},"pull_request":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/355"}},"in_reply_to_id":189723889},"pull_request":{"url":"https://api.github.com/repos/usnistgov/ACVP/pulls/355","id":189107250,"html_url":"https://github.com/usnistgov/ACVP/pull/355","diff_url":"https://github.com/usnistgov/ACVP/pull/355.diff","patch_url":"https://github.com/usnistgov/ACVP/pull/355.patch","issue_url":"https://api.github.com/repos/usnistgov/ACVP/issues/355","number":355,"state":"open","locked":false,"title":"Kas updates component breakout","user":{"login":"Kritner","id":8814983,"avatar_url":"https://avatars1.githubusercontent.com/u/8814983?v=4","gravatar_id":"","url":"https://api.github.com/users/Kritner","html_url":"https://github.com/Kritner","followers_url":"https://api.github.com/users/Kritner/followers","following_url":"https://api.github.com/users/Kritner/following{/other_user}","gists_url":"https://api.github.com/users/Kritner/gists{/gist_id}","starred_url":"https://api.github.com/users/Kritner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kritner/subscriptions","organizations_url":"https://api.github.com/users/Kritner/orgs","repos_url":"https://api.github.com/users/Kritner/repos","events_url":"https://api.github.com/users/Kritner/events{/privacy}","received_events_url":"https://api.github.com/users/Kritner/received_events","type":"User","site_admin":false},"body":"Breaking `NoKdfNoKc` modes of KAS-ECC and KAS-FFC into their own \"algorithm\" and \"mode\".\r\n\r\n`KdfNoKc` and `KdfKc` continue as they were, registered under \"KAS-FFC\" or \"KAS-ECC\".\r\n`NoKdfNoKc` as a component validation, is now registered separately under:\r\n\r\n* Algorithm: \"KAS-ECC\" or \"KAS-FFC\"\r\n* Mode: \"Component\"","created_at":"2018-05-18T18:52:52Z","updated_at":"2018-05-22T11:56:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"201fa2e51f73fa58a6d0e75b9ebefa26a03873bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usnistgov/ACVP/pulls/355/commits","review_comments_url":"https://api.github.com/repos/usnistgov/ACVP/pulls/355/comments","review_comment_url":"https://api.github.com/repos/usnistgov/ACVP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usnistgov/ACVP/issues/355/comments","statuses_url":"https://api.github.com/repos/usnistgov/ACVP/statuses/d66a1370039057bc47efa6b3bb7cac111fe25e8d","head":{"label":"Kritner:kasUpdatesComponentBreakout","ref":"kasUpdatesComponentBreakout","sha":"d66a1370039057bc47efa6b3bb7cac111fe25e8d","user":{"login":"Kritner","id":8814983,"avatar_url":"https://avatars1.githubusercontent.com/u/8814983?v=4","gravatar_id":"","url":"https://api.github.com/users/Kritner","html_url":"https://github.com/Kritner","followers_url":"https://api.github.com/users/Kritner/followers","following_url":"https://api.github.com/users/Kritner/following{/other_user}","gists_url":"https://api.github.com/users/Kritner/gists{/gist_id}","starred_url":"https://api.github.com/users/Kritner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kritner/subscriptions","organizations_url":"https://api.github.com/users/Kritner/orgs","repos_url":"https://api.github.com/users/Kritner/repos","events_url":"https://api.github.com/users/Kritner/events{/privacy}","received_events_url":"https://api.github.com/users/Kritner/received_events","type":"User","site_admin":false},"repo":{"id":69489516,"name":"ACVP","full_name":"Kritner/ACVP","owner":{"login":"Kritner","id":8814983,"avatar_url":"https://avatars1.githubusercontent.com/u/8814983?v=4","gravatar_id":"","url":"https://api.github.com/users/Kritner","html_url":"https://github.com/Kritner","followers_url":"https://api.github.com/users/Kritner/followers","following_url":"https://api.github.com/users/Kritner/following{/other_user}","gists_url":"https://api.github.com/users/Kritner/gists{/gist_id}","starred_url":"https://api.github.com/users/Kritner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kritner/subscriptions","organizations_url":"https://api.github.com/users/Kritner/orgs","repos_url":"https://api.github.com/users/Kritner/repos","events_url":"https://api.github.com/users/Kritner/events{/privacy}","received_events_url":"https://api.github.com/users/Kritner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kritner/ACVP","description":"Industry Working Group on Automated Cryptographic Algorithm Validation","fork":true,"url":"https://api.github.com/repos/Kritner/ACVP","forks_url":"https://api.github.com/repos/Kritner/ACVP/forks","keys_url":"https://api.github.com/repos/Kritner/ACVP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kritner/ACVP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kritner/ACVP/teams","hooks_url":"https://api.github.com/repos/Kritner/ACVP/hooks","issue_events_url":"https://api.github.com/repos/Kritner/ACVP/issues/events{/number}","events_url":"https://api.github.com/repos/Kritner/ACVP/events","assignees_url":"https://api.github.com/repos/Kritner/ACVP/assignees{/user}","branches_url":"https://api.github.com/repos/Kritner/ACVP/branches{/branch}","tags_url":"https://api.github.com/repos/Kritner/ACVP/tags","blobs_url":"https://api.github.com/repos/Kritner/ACVP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kritner/ACVP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kritner/ACVP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kritner/ACVP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kritner/ACVP/statuses/{sha}","languages_url":"https://api.github.com/repos/Kritner/ACVP/languages","stargazers_url":"https://api.github.com/repos/Kritner/ACVP/stargazers","contributors_url":"https://api.github.com/repos/Kritner/ACVP/contributors","subscribers_url":"https://api.github.com/repos/Kritner/ACVP/subscribers","subscription_url":"https://api.github.com/repos/Kritner/ACVP/subscription","commits_url":"https://api.github.com/repos/Kritner/ACVP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kritner/ACVP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kritner/ACVP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kritner/ACVP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kritner/ACVP/contents/{+path}","compare_url":"https://api.github.com/repos/Kritner/ACVP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kritner/ACVP/merges","archive_url":"https://api.github.com/repos/Kritner/ACVP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kritner/ACVP/downloads","issues_url":"https://api.github.com/repos/Kritner/ACVP/issues{/number}","pulls_url":"https://api.github.com/repos/Kritner/ACVP/pulls{/number}","milestones_url":"https://api.github.com/repos/Kritner/ACVP/milestones{/number}","notifications_url":"https://api.github.com/repos/Kritner/ACVP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kritner/ACVP/labels{/name}","releases_url":"https://api.github.com/repos/Kritner/ACVP/releases{/id}","deployments_url":"https://api.github.com/repos/Kritner/ACVP/deployments","created_at":"2016-09-28T17:57:08Z","updated_at":"2018-05-08T13:15:29Z","pushed_at":"2018-05-21T13:04:57Z","git_url":"git://github.com/Kritner/ACVP.git","ssh_url":"git@github.com:Kritner/ACVP.git","clone_url":"https://github.com/Kritner/ACVP.git","svn_url":"https://github.com/Kritner/ACVP","homepage":"","size":10449,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usnistgov:master","ref":"master","sha":"d66a8016286c39fce4249fe5e6535a96e778dfb9","user":{"login":"usnistgov","id":5330158,"avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"repo":{"id":60804128,"name":"ACVP","full_name":"usnistgov/ACVP","owner":{"login":"usnistgov","id":5330158,"avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usnistgov/ACVP","description":"Industry Working Group on Automated Cryptographic Algorithm Validation","fork":false,"url":"https://api.github.com/repos/usnistgov/ACVP","forks_url":"https://api.github.com/repos/usnistgov/ACVP/forks","keys_url":"https://api.github.com/repos/usnistgov/ACVP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usnistgov/ACVP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usnistgov/ACVP/teams","hooks_url":"https://api.github.com/repos/usnistgov/ACVP/hooks","issue_events_url":"https://api.github.com/repos/usnistgov/ACVP/issues/events{/number}","events_url":"https://api.github.com/repos/usnistgov/ACVP/events","assignees_url":"https://api.github.com/repos/usnistgov/ACVP/assignees{/user}","branches_url":"https://api.github.com/repos/usnistgov/ACVP/branches{/branch}","tags_url":"https://api.github.com/repos/usnistgov/ACVP/tags","blobs_url":"https://api.github.com/repos/usnistgov/ACVP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usnistgov/ACVP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usnistgov/ACVP/git/refs{/sha}","trees_url":"https://api.github.com/repos/usnistgov/ACVP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usnistgov/ACVP/statuses/{sha}","languages_url":"https://api.github.com/repos/usnistgov/ACVP/languages","stargazers_url":"https://api.github.com/repos/usnistgov/ACVP/stargazers","contributors_url":"https://api.github.com/repos/usnistgov/ACVP/contributors","subscribers_url":"https://api.github.com/repos/usnistgov/ACVP/subscribers","subscription_url":"https://api.github.com/repos/usnistgov/ACVP/subscription","commits_url":"https://api.github.com/repos/usnistgov/ACVP/commits{/sha}","git_commits_url":"https://api.github.com/repos/usnistgov/ACVP/git/commits{/sha}","comments_url":"https://api.github.com/repos/usnistgov/ACVP/comments{/number}","issue_comment_url":"https://api.github.com/repos/usnistgov/ACVP/issues/comments{/number}","contents_url":"https://api.github.com/repos/usnistgov/ACVP/contents/{+path}","compare_url":"https://api.github.com/repos/usnistgov/ACVP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usnistgov/ACVP/merges","archive_url":"https://api.github.com/repos/usnistgov/ACVP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usnistgov/ACVP/downloads","issues_url":"https://api.github.com/repos/usnistgov/ACVP/issues{/number}","pulls_url":"https://api.github.com/repos/usnistgov/ACVP/pulls{/number}","milestones_url":"https://api.github.com/repos/usnistgov/ACVP/milestones{/number}","notifications_url":"https://api.github.com/repos/usnistgov/ACVP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usnistgov/ACVP/labels{/name}","releases_url":"https://api.github.com/repos/usnistgov/ACVP/releases{/id}","deployments_url":"https://api.github.com/repos/usnistgov/ACVP/deployments","created_at":"2016-06-09T20:14:14Z","updated_at":"2018-05-18T14:16:54Z","pushed_at":"2018-05-21T13:04:58Z","git_url":"git://github.com/usnistgov/ACVP.git","ssh_url":"git@github.com:usnistgov/ACVP.git","clone_url":"https://github.com/usnistgov/ACVP.git","svn_url":"https://github.com/usnistgov/ACVP","homepage":"","size":10184,"stargazers_count":21,"watchers_count":21,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":12,"open_issues":39,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/355"},"html":{"href":"https://github.com/usnistgov/ACVP/pull/355"},"issue":{"href":"https://api.github.com/repos/usnistgov/ACVP/issues/355"},"comments":{"href":"https://api.github.com/repos/usnistgov/ACVP/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usnistgov/ACVP/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/usnistgov/ACVP/statuses/d66a1370039057bc47efa6b3bb7cac111fe25e8d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Kritner"}}