{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/205492653","pull_request_review_id":140769010,"id":205492653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTQ5MjY1Mw==","diff_hunk":"@@ -3226,32 +3273,15 @@ ftGdiGetGlyphOutline(\n     IntLockFreeType();\n \n     /* Scaling transform */\n-    /*if (aveWidth)*/\n+    if (widthRatio != 1.0)\n     {\n+        FT_Matrix scaleMat;\n+        scaleMat.xx = FT_FixedFromFloat(widthRatio);\n+        scaleMat.xy = 0;\n+        scaleMat.yx = 0;\n+        scaleMat.yy = FT_FixedFromFloat(1.0);\n \n-        FT_Matrix ftmatrix;\n-        FLOATOBJ efTemp;\n-\n-        PMATRIX pmx = DC_pmxWorldToDevice(dc);\n-\n-        /* Create a freetype matrix, by converting to 16.16 fixpoint format */\n-        efTemp = pmx->efM11;\n-        FLOATOBJ_MulLong(&efTemp, 0x00010000);\n-        ftmatrix.xx = FLOATOBJ_GetLong(&efTemp);\n-\n-        efTemp = pmx->efM12;\n-        FLOATOBJ_MulLong(&efTemp, 0x00010000);\n-        ftmatrix.xy = FLOATOBJ_GetLong(&efTemp);\n-\n-        efTemp = pmx->efM21;\n-        FLOATOBJ_MulLong(&efTemp, 0x00010000);\n-        ftmatrix.yx = FLOATOBJ_GetLong(&efTemp);\n-\n-        efTemp = pmx->efM22;\n-        FLOATOBJ_MulLong(&efTemp, 0x00010000);\n-        ftmatrix.yy = FLOATOBJ_GetLong(&efTemp);\n-\n-        FT_Matrix_Multiply(&ftmatrix, &transMat);\n+        FT_Matrix_Multiply(&scaleMat, &transMat);","path":"win32ss/gdi/ntgdi/freetype.c","position":184,"original_position":184,"commit_id":"2406b27452ea7ab031e591bfc5c3d64bff825455","original_commit_id":"2406b27452ea7ab031e591bfc5c3d64bff825455","user":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"body":"Shouldn't we take also into account any `DC_pmxWorldToDevice(dc);` ?","created_at":"2018-07-26T15:04:37Z","updated_at":"2018-07-26T15:13:39Z","html_url":"https://github.com/reactos/reactos/pull/706#discussion_r205492653","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/706","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/205492653"},"html":{"href":"https://github.com/reactos/reactos/pull/706#discussion_r205492653"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/706","id":204160528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTYwNTI4","html_url":"https://github.com/reactos/reactos/pull/706","diff_url":"https://github.com/reactos/reactos/pull/706.diff","patch_url":"https://github.com/reactos/reactos/pull/706.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/706","number":706,"state":"open","locked":false,"title":"[FONT][FREETYPE] Fix font metrics","user":{"login":"katahiromz","id":2107452,"node_id":"MDQ6VXNlcjIxMDc0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2107452?v=4","gravatar_id":"","url":"https://api.github.com/users/katahiromz","html_url":"https://github.com/katahiromz","followers_url":"https://api.github.com/users/katahiromz/followers","following_url":"https://api.github.com/users/katahiromz/following{/other_user}","gists_url":"https://api.github.com/users/katahiromz/gists{/gist_id}","starred_url":"https://api.github.com/users/katahiromz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katahiromz/subscriptions","organizations_url":"https://api.github.com/users/katahiromz/orgs","repos_url":"https://api.github.com/users/katahiromz/repos","events_url":"https://api.github.com/users/katahiromz/events{/privacy}","received_events_url":"https://api.github.com/users/katahiromz/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nThis PR will fix the font metrics.\r\nJIRA issue: [CORE-11536](https://jira.reactos.org/browse/CORE-11536)\r\n\r\n## Proposed changes\r\n\r\n- Modify FONTGDI structure in \"win32ss/gdi/eng/engobjects.h\".\r\n- Modify stock GDI objects at \"win32ss/gdi/ntgdi/stockobj.c\"\r\n- Improve the metric calculation.\r\n\r\n## TODO\r\n\r\n- [ ] Fix the dialog height.\r\n- [ ] Fix glitch in drawing highlight text.\r\n- [ ] Consider the case of lfWidth != 0.","created_at":"2018-07-26T14:26:11Z","updated_at":"2018-07-26T15:13:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea74ae6519f595c32e482f30b5dad709bc2163b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/706/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/706/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/706/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/2406b27452ea7ab031e591bfc5c3d64bff825455","head":{"label":"katahiromz:font-fix","ref":"font-fix","sha":"2406b27452ea7ab031e591bfc5c3d64bff825455","user":{"login":"katahiromz","id":2107452,"node_id":"MDQ6VXNlcjIxMDc0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2107452?v=4","gravatar_id":"","url":"https://api.github.com/users/katahiromz","html_url":"https://github.com/katahiromz","followers_url":"https://api.github.com/users/katahiromz/followers","following_url":"https://api.github.com/users/katahiromz/following{/other_user}","gists_url":"https://api.github.com/users/katahiromz/gists{/gist_id}","starred_url":"https://api.github.com/users/katahiromz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katahiromz/subscriptions","organizations_url":"https://api.github.com/users/katahiromz/orgs","repos_url":"https://api.github.com/users/katahiromz/repos","events_url":"https://api.github.com/users/katahiromz/events{/privacy}","received_events_url":"https://api.github.com/users/katahiromz/received_events","type":"User","site_admin":false},"repo":{"id":123541775,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1NDE3NzU=","name":"reactos","full_name":"katahiromz/reactos","owner":{"login":"katahiromz","id":2107452,"node_id":"MDQ6VXNlcjIxMDc0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2107452?v=4","gravatar_id":"","url":"https://api.github.com/users/katahiromz","html_url":"https://github.com/katahiromz","followers_url":"https://api.github.com/users/katahiromz/followers","following_url":"https://api.github.com/users/katahiromz/following{/other_user}","gists_url":"https://api.github.com/users/katahiromz/gists{/gist_id}","starred_url":"https://api.github.com/users/katahiromz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katahiromz/subscriptions","organizations_url":"https://api.github.com/users/katahiromz/orgs","repos_url":"https://api.github.com/users/katahiromz/repos","events_url":"https://api.github.com/users/katahiromz/events{/privacy}","received_events_url":"https://api.github.com/users/katahiromz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/katahiromz/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/katahiromz/reactos","forks_url":"https://api.github.com/repos/katahiromz/reactos/forks","keys_url":"https://api.github.com/repos/katahiromz/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/katahiromz/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/katahiromz/reactos/teams","hooks_url":"https://api.github.com/repos/katahiromz/reactos/hooks","issue_events_url":"https://api.github.com/repos/katahiromz/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/katahiromz/reactos/events","assignees_url":"https://api.github.com/repos/katahiromz/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/katahiromz/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/katahiromz/reactos/tags","blobs_url":"https://api.github.com/repos/katahiromz/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/katahiromz/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/katahiromz/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/katahiromz/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/katahiromz/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/katahiromz/reactos/languages","stargazers_url":"https://api.github.com/repos/katahiromz/reactos/stargazers","contributors_url":"https://api.github.com/repos/katahiromz/reactos/contributors","subscribers_url":"https://api.github.com/repos/katahiromz/reactos/subscribers","subscription_url":"https://api.github.com/repos/katahiromz/reactos/subscription","commits_url":"https://api.github.com/repos/katahiromz/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/katahiromz/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/katahiromz/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/katahiromz/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/katahiromz/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/katahiromz/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/katahiromz/reactos/merges","archive_url":"https://api.github.com/repos/katahiromz/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/katahiromz/reactos/downloads","issues_url":"https://api.github.com/repos/katahiromz/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/katahiromz/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/katahiromz/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/katahiromz/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/katahiromz/reactos/labels{/name}","releases_url":"https://api.github.com/repos/katahiromz/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/katahiromz/reactos/deployments","created_at":"2018-03-02T06:48:58Z","updated_at":"2018-07-26T12:26:37Z","pushed_at":"2018-07-26T14:23:37Z","git_url":"git://github.com/katahiromz/reactos.git","ssh_url":"git@github.com:katahiromz/reactos.git","clone_url":"https://github.com/katahiromz/reactos.git","svn_url":"https://github.com/katahiromz/reactos","homepage":null,"size":458382,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"bfc6b719cfccb199ce8b0f656dce174a1a9a3a79","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-07-26T14:58:22Z","pushed_at":"2018-07-26T14:26:11Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":457793,"stargazers_count":4779,"watchers_count":4779,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":377,"open_issues":82,"watchers":4779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/706"},"html":{"href":"https://github.com/reactos/reactos/pull/706"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/706"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/2406b27452ea7ab031e591bfc5c3d64bff825455"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HBelusca"}}