{"action":"created","comment":{"url":"https://api.github.com/repos/abrt/faf/pulls/comments/212324270","pull_request_review_id":148929932,"id":212324270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjMyNDI3MA==","diff_hunk":"@@ -192,11 +192,22 @@ def get_releases(self):\n     def get_components(self, release):\n         urls = [repo.replace(\"$releasever\", release)\n                 for repo in [self.base_repo_url, self.updates_repo_url]]\n-\n-        yum = Yum(self.name, *urls)\n-        components = list(set(pkg[\"name\"]\n-                              for pkg in yum.list_packages([\"src\"])))\n-        return components\n+        components = []\n+        if \"dnf\" in repo_types:\n+            from pyfaf.repos.dnf import Dnf\n+            dnf = Dnf(self.name, *urls)\n+            components.extend(list(set(pkg[\"name\"]\n+                                       for pkg in dnf.list_packages([\"src\"]))))\n+            return components","path":"src/pyfaf/opsys/centos.py","position":24,"original_position":24,"commit_id":"81ff1fbe5386bedcc68c29aa6814705e11c7e90b","original_commit_id":"81ff1fbe5386bedcc68c29aa6814705e11c7e90b","user":{"login":"ari3s","id":12557895,"node_id":"MDQ6VXNlcjEyNTU3ODk1","avatar_url":"https://avatars3.githubusercontent.com/u/12557895?v=4","gravatar_id":"","url":"https://api.github.com/users/ari3s","html_url":"https://github.com/ari3s","followers_url":"https://api.github.com/users/ari3s/followers","following_url":"https://api.github.com/users/ari3s/following{/other_user}","gists_url":"https://api.github.com/users/ari3s/gists{/gist_id}","starred_url":"https://api.github.com/users/ari3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ari3s/subscriptions","organizations_url":"https://api.github.com/users/ari3s/orgs","repos_url":"https://api.github.com/users/ari3s/repos","events_url":"https://api.github.com/users/ari3s/events{/privacy}","received_events_url":"https://api.github.com/users/ari3s/received_events","type":"User","site_admin":false},"body":"You are right, thanks, I will fix.","created_at":"2018-08-23T14:11:36Z","updated_at":"2018-08-23T14:11:36Z","html_url":"https://github.com/abrt/faf/pull/694#discussion_r212324270","pull_request_url":"https://api.github.com/repos/abrt/faf/pulls/694","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/abrt/faf/pulls/comments/212324270"},"html":{"href":"https://github.com/abrt/faf/pull/694#discussion_r212324270"},"pull_request":{"href":"https://api.github.com/repos/abrt/faf/pulls/694"}},"in_reply_to_id":212300564},"pull_request":{"url":"https://api.github.com/repos/abrt/faf/pulls/694","id":203510070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTEwMDcw","html_url":"https://github.com/abrt/faf/pull/694","diff_url":"https://github.com/abrt/faf/pull/694.diff","patch_url":"https://github.com/abrt/faf/pull/694.patch","issue_url":"https://api.github.com/repos/abrt/faf/issues/694","number":694,"state":"open","locked":false,"title":"WIP: py3 compatibility: Transfer from yum to dnf","user":{"login":"ari3s","id":12557895,"node_id":"MDQ6VXNlcjEyNTU3ODk1","avatar_url":"https://avatars3.githubusercontent.com/u/12557895?v=4","gravatar_id":"","url":"https://api.github.com/users/ari3s","html_url":"https://github.com/ari3s","followers_url":"https://api.github.com/users/ari3s/followers","following_url":"https://api.github.com/users/ari3s/following{/other_user}","gists_url":"https://api.github.com/users/ari3s/gists{/gist_id}","starred_url":"https://api.github.com/users/ari3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ari3s/subscriptions","organizations_url":"https://api.github.com/users/ari3s/orgs","repos_url":"https://api.github.com/users/ari3s/repos","events_url":"https://api.github.com/users/ari3s/events{/privacy}","received_events_url":"https://api.github.com/users/ari3s/received_events","type":"User","site_admin":false},"body":"yum is not available in Python 3 and is not developed any more.\r\nReplacement of yum with dnf solves the problem.\r\n\r\nThere are still two small issues:\r\n1. dnf does not provide old_avilable and reinstall_available packages.\r\n2. Package url is not provided for local packages by dnf directly, it is hacked from repo url.\r\n\r\nSigned-off-by: Jan Beran <jberan@redhat.com>","created_at":"2018-07-24T12:30:04Z","updated_at":"2018-08-23T14:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a67148cbc25158330a0e5ee1258f56df60dd7a26","assignee":{"login":"marusak","id":12330670,"node_id":"MDQ6VXNlcjEyMzMwNjcw","avatar_url":"https://avatars2.githubusercontent.com/u/12330670?v=4","gravatar_id":"","url":"https://api.github.com/users/marusak","html_url":"https://github.com/marusak","followers_url":"https://api.github.com/users/marusak/followers","following_url":"https://api.github.com/users/marusak/following{/other_user}","gists_url":"https://api.github.com/users/marusak/gists{/gist_id}","starred_url":"https://api.github.com/users/marusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marusak/subscriptions","organizations_url":"https://api.github.com/users/marusak/orgs","repos_url":"https://api.github.com/users/marusak/repos","events_url":"https://api.github.com/users/marusak/events{/privacy}","received_events_url":"https://api.github.com/users/marusak/received_events","type":"User","site_admin":false},"assignees":[{"login":"marusak","id":12330670,"node_id":"MDQ6VXNlcjEyMzMwNjcw","avatar_url":"https://avatars2.githubusercontent.com/u/12330670?v=4","gravatar_id":"","url":"https://api.github.com/users/marusak","html_url":"https://github.com/marusak","followers_url":"https://api.github.com/users/marusak/followers","following_url":"https://api.github.com/users/marusak/following{/other_user}","gists_url":"https://api.github.com/users/marusak/gists{/gist_id}","starred_url":"https://api.github.com/users/marusak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marusak/subscriptions","organizations_url":"https://api.github.com/users/marusak/orgs","repos_url":"https://api.github.com/users/marusak/repos","events_url":"https://api.github.com/users/marusak/events{/privacy}","received_events_url":"https://api.github.com/users/marusak/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/abrt/faf/pulls/694/commits","review_comments_url":"https://api.github.com/repos/abrt/faf/pulls/694/comments","review_comment_url":"https://api.github.com/repos/abrt/faf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abrt/faf/issues/694/comments","statuses_url":"https://api.github.com/repos/abrt/faf/statuses/81ff1fbe5386bedcc68c29aa6814705e11c7e90b","head":{"label":"ari3s:dnf","ref":"dnf","sha":"81ff1fbe5386bedcc68c29aa6814705e11c7e90b","user":{"login":"ari3s","id":12557895,"node_id":"MDQ6VXNlcjEyNTU3ODk1","avatar_url":"https://avatars3.githubusercontent.com/u/12557895?v=4","gravatar_id":"","url":"https://api.github.com/users/ari3s","html_url":"https://github.com/ari3s","followers_url":"https://api.github.com/users/ari3s/followers","following_url":"https://api.github.com/users/ari3s/following{/other_user}","gists_url":"https://api.github.com/users/ari3s/gists{/gist_id}","starred_url":"https://api.github.com/users/ari3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ari3s/subscriptions","organizations_url":"https://api.github.com/users/ari3s/orgs","repos_url":"https://api.github.com/users/ari3s/repos","events_url":"https://api.github.com/users/ari3s/events{/privacy}","received_events_url":"https://api.github.com/users/ari3s/received_events","type":"User","site_admin":false},"repo":{"id":127098886,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwOTg4ODY=","name":"faf","full_name":"ari3s/faf","owner":{"login":"ari3s","id":12557895,"node_id":"MDQ6VXNlcjEyNTU3ODk1","avatar_url":"https://avatars3.githubusercontent.com/u/12557895?v=4","gravatar_id":"","url":"https://api.github.com/users/ari3s","html_url":"https://github.com/ari3s","followers_url":"https://api.github.com/users/ari3s/followers","following_url":"https://api.github.com/users/ari3s/following{/other_user}","gists_url":"https://api.github.com/users/ari3s/gists{/gist_id}","starred_url":"https://api.github.com/users/ari3s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ari3s/subscriptions","organizations_url":"https://api.github.com/users/ari3s/orgs","repos_url":"https://api.github.com/users/ari3s/repos","events_url":"https://api.github.com/users/ari3s/events{/privacy}","received_events_url":"https://api.github.com/users/ari3s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ari3s/faf","description":"Platform for collection and analysis of packages and package crashes","fork":true,"url":"https://api.github.com/repos/ari3s/faf","forks_url":"https://api.github.com/repos/ari3s/faf/forks","keys_url":"https://api.github.com/repos/ari3s/faf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ari3s/faf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ari3s/faf/teams","hooks_url":"https://api.github.com/repos/ari3s/faf/hooks","issue_events_url":"https://api.github.com/repos/ari3s/faf/issues/events{/number}","events_url":"https://api.github.com/repos/ari3s/faf/events","assignees_url":"https://api.github.com/repos/ari3s/faf/assignees{/user}","branches_url":"https://api.github.com/repos/ari3s/faf/branches{/branch}","tags_url":"https://api.github.com/repos/ari3s/faf/tags","blobs_url":"https://api.github.com/repos/ari3s/faf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ari3s/faf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ari3s/faf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ari3s/faf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ari3s/faf/statuses/{sha}","languages_url":"https://api.github.com/repos/ari3s/faf/languages","stargazers_url":"https://api.github.com/repos/ari3s/faf/stargazers","contributors_url":"https://api.github.com/repos/ari3s/faf/contributors","subscribers_url":"https://api.github.com/repos/ari3s/faf/subscribers","subscription_url":"https://api.github.com/repos/ari3s/faf/subscription","commits_url":"https://api.github.com/repos/ari3s/faf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ari3s/faf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ari3s/faf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ari3s/faf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ari3s/faf/contents/{+path}","compare_url":"https://api.github.com/repos/ari3s/faf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ari3s/faf/merges","archive_url":"https://api.github.com/repos/ari3s/faf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ari3s/faf/downloads","issues_url":"https://api.github.com/repos/ari3s/faf/issues{/number}","pulls_url":"https://api.github.com/repos/ari3s/faf/pulls{/number}","milestones_url":"https://api.github.com/repos/ari3s/faf/milestones{/number}","notifications_url":"https://api.github.com/repos/ari3s/faf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ari3s/faf/labels{/name}","releases_url":"https://api.github.com/repos/ari3s/faf/releases{/id}","deployments_url":"https://api.github.com/repos/ari3s/faf/deployments","created_at":"2018-03-28T07:08:00Z","updated_at":"2018-08-22T12:47:59Z","pushed_at":"2018-08-22T12:47:55Z","git_url":"git://github.com/ari3s/faf.git","ssh_url":"git@github.com:ari3s/faf.git","clone_url":"https://github.com/ari3s/faf.git","svn_url":"https://github.com/ari3s/faf","homepage":null,"size":8049,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"abrt:master","ref":"master","sha":"7ade106a03cc9bfac5063ae807d1eb6e04edb718","user":{"login":"abrt","id":3449403,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDk0MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3449403?v=4","gravatar_id":"","url":"https://api.github.com/users/abrt","html_url":"https://github.com/abrt","followers_url":"https://api.github.com/users/abrt/followers","following_url":"https://api.github.com/users/abrt/following{/other_user}","gists_url":"https://api.github.com/users/abrt/gists{/gist_id}","starred_url":"https://api.github.com/users/abrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrt/subscriptions","organizations_url":"https://api.github.com/users/abrt/orgs","repos_url":"https://api.github.com/users/abrt/repos","events_url":"https://api.github.com/users/abrt/events{/privacy}","received_events_url":"https://api.github.com/users/abrt/received_events","type":"Organization","site_admin":false},"repo":{"id":7959759,"node_id":"MDEwOlJlcG9zaXRvcnk3OTU5NzU5","name":"faf","full_name":"abrt/faf","owner":{"login":"abrt","id":3449403,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDk0MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3449403?v=4","gravatar_id":"","url":"https://api.github.com/users/abrt","html_url":"https://github.com/abrt","followers_url":"https://api.github.com/users/abrt/followers","following_url":"https://api.github.com/users/abrt/following{/other_user}","gists_url":"https://api.github.com/users/abrt/gists{/gist_id}","starred_url":"https://api.github.com/users/abrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrt/subscriptions","organizations_url":"https://api.github.com/users/abrt/orgs","repos_url":"https://api.github.com/users/abrt/repos","events_url":"https://api.github.com/users/abrt/events{/privacy}","received_events_url":"https://api.github.com/users/abrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abrt/faf","description":"Platform for collection and analysis of packages and package crashes","fork":false,"url":"https://api.github.com/repos/abrt/faf","forks_url":"https://api.github.com/repos/abrt/faf/forks","keys_url":"https://api.github.com/repos/abrt/faf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrt/faf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrt/faf/teams","hooks_url":"https://api.github.com/repos/abrt/faf/hooks","issue_events_url":"https://api.github.com/repos/abrt/faf/issues/events{/number}","events_url":"https://api.github.com/repos/abrt/faf/events","assignees_url":"https://api.github.com/repos/abrt/faf/assignees{/user}","branches_url":"https://api.github.com/repos/abrt/faf/branches{/branch}","tags_url":"https://api.github.com/repos/abrt/faf/tags","blobs_url":"https://api.github.com/repos/abrt/faf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrt/faf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrt/faf/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrt/faf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrt/faf/statuses/{sha}","languages_url":"https://api.github.com/repos/abrt/faf/languages","stargazers_url":"https://api.github.com/repos/abrt/faf/stargazers","contributors_url":"https://api.github.com/repos/abrt/faf/contributors","subscribers_url":"https://api.github.com/repos/abrt/faf/subscribers","subscription_url":"https://api.github.com/repos/abrt/faf/subscription","commits_url":"https://api.github.com/repos/abrt/faf/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrt/faf/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrt/faf/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrt/faf/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrt/faf/contents/{+path}","compare_url":"https://api.github.com/repos/abrt/faf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrt/faf/merges","archive_url":"https://api.github.com/repos/abrt/faf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrt/faf/downloads","issues_url":"https://api.github.com/repos/abrt/faf/issues{/number}","pulls_url":"https://api.github.com/repos/abrt/faf/pulls{/number}","milestones_url":"https://api.github.com/repos/abrt/faf/milestones{/number}","notifications_url":"https://api.github.com/repos/abrt/faf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrt/faf/labels{/name}","releases_url":"https://api.github.com/repos/abrt/faf/releases{/id}","deployments_url":"https://api.github.com/repos/abrt/faf/deployments","created_at":"2013-02-01T14:45:12Z","updated_at":"2018-08-14T10:22:43Z","pushed_at":"2018-08-23T11:35:40Z","git_url":"git://github.com/abrt/faf.git","ssh_url":"git@github.com:abrt/faf.git","clone_url":"https://github.com/abrt/faf.git","svn_url":"https://github.com/abrt/faf","homepage":null,"size":8014,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":27,"open_issues":102,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abrt/faf/pulls/694"},"html":{"href":"https://github.com/abrt/faf/pull/694"},"issue":{"href":"https://api.github.com/repos/abrt/faf/issues/694"},"comments":{"href":"https://api.github.com/repos/abrt/faf/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/abrt/faf/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/abrt/faf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abrt/faf/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/abrt/faf/statuses/81ff1fbe5386bedcc68c29aa6814705e11c7e90b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ari3s"}}