{"action":"closed","number":1012,"pull_request":{"url":"https://api.github.com/repos/feathersjs/feathers/pulls/1012","id":217176835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTc2ODM1","html_url":"https://github.com/feathersjs/feathers/pull/1012","diff_url":"https://github.com/feathersjs/feathers/pull/1012.diff","patch_url":"https://github.com/feathersjs/feathers/pull/1012.patch","issue_url":"https://api.github.com/repos/feathersjs/feathers/issues/1012","number":1012,"state":"closed","locked":false,"title":"Normalize params to object even when it is falsy","user":{"login":"daffl","id":338316,"node_id":"MDQ6VXNlcjMzODMxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/338316?v=4","gravatar_id":"","url":"https://api.github.com/users/daffl","html_url":"https://github.com/daffl","followers_url":"https://api.github.com/users/daffl/followers","following_url":"https://api.github.com/users/daffl/following{/other_user}","gists_url":"https://api.github.com/users/daffl/gists{/gist_id}","starred_url":"https://api.github.com/users/daffl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daffl/subscriptions","organizations_url":"https://api.github.com/users/daffl/orgs","repos_url":"https://api.github.com/users/daffl/repos","events_url":"https://api.github.com/users/daffl/events{/privacy}","received_events_url":"https://api.github.com/users/daffl/received_events","type":"User","site_admin":false},"body":"This is a regression where things like `.find(null)` previously still turned `params` into an object. The new argument normalization overwrote it with any other value.\r\n\r\nCloses #1001, closes #1011, closes https://github.com/feathersjs/authentication-client/issues/114","created_at":"2018-09-21T05:43:14Z","updated_at":"2018-09-21T06:11:58Z","closed_at":"2018-09-21T06:11:58Z","merged_at":"2018-09-21T06:11:58Z","merge_commit_sha":"af9781803bcf824068a7d46f2d44cc02c0a4d233","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bertho-zero","id":8525267,"node_id":"MDQ6VXNlcjg1MjUyNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/8525267?v=4","gravatar_id":"","url":"https://api.github.com/users/bertho-zero","html_url":"https://github.com/bertho-zero","followers_url":"https://api.github.com/users/bertho-zero/followers","following_url":"https://api.github.com/users/bertho-zero/following{/other_user}","gists_url":"https://api.github.com/users/bertho-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/bertho-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertho-zero/subscriptions","organizations_url":"https://api.github.com/users/bertho-zero/orgs","repos_url":"https://api.github.com/users/bertho-zero/repos","events_url":"https://api.github.com/users/bertho-zero/events{/privacy}","received_events_url":"https://api.github.com/users/bertho-zero/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/feathersjs/feathers/pulls/1012/commits","review_comments_url":"https://api.github.com/repos/feathersjs/feathers/pulls/1012/comments","review_comment_url":"https://api.github.com/repos/feathersjs/feathers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feathersjs/feathers/issues/1012/comments","statuses_url":"https://api.github.com/repos/feathersjs/feathers/statuses/4fdc7a8327f654de37a5b80002dcfc23c4bba3d4","head":{"label":"feathersjs:params-object-1001","ref":"params-object-1001","sha":"4fdc7a8327f654de37a5b80002dcfc23c4bba3d4","user":{"login":"feathersjs","id":5321853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMjE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321853?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2609642,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA5NjQy","name":"feathers","full_name":"feathersjs/feathers","private":false,"owner":{"login":"feathersjs","id":5321853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMjE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321853?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/feathersjs/feathers","description":"A REST and realtime API layer for modern applications.","fork":false,"url":"https://api.github.com/repos/feathersjs/feathers","forks_url":"https://api.github.com/repos/feathersjs/feathers/forks","keys_url":"https://api.github.com/repos/feathersjs/feathers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs/feathers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs/feathers/teams","hooks_url":"https://api.github.com/repos/feathersjs/feathers/hooks","issue_events_url":"https://api.github.com/repos/feathersjs/feathers/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs/feathers/events","assignees_url":"https://api.github.com/repos/feathersjs/feathers/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs/feathers/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs/feathers/tags","blobs_url":"https://api.github.com/repos/feathersjs/feathers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs/feathers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs/feathers/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs/feathers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs/feathers/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs/feathers/languages","stargazers_url":"https://api.github.com/repos/feathersjs/feathers/stargazers","contributors_url":"https://api.github.com/repos/feathersjs/feathers/contributors","subscribers_url":"https://api.github.com/repos/feathersjs/feathers/subscribers","subscription_url":"https://api.github.com/repos/feathersjs/feathers/subscription","commits_url":"https://api.github.com/repos/feathersjs/feathers/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs/feathers/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs/feathers/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs/feathers/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs/feathers/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs/feathers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs/feathers/merges","archive_url":"https://api.github.com/repos/feathersjs/feathers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs/feathers/downloads","issues_url":"https://api.github.com/repos/feathersjs/feathers/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs/feathers/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs/feathers/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs/feathers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs/feathers/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs/feathers/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs/feathers/deployments","created_at":"2011-10-19T22:45:16Z","updated_at":"2018-09-21T06:11:25Z","pushed_at":"2018-09-21T06:11:58Z","git_url":"git://github.com/feathersjs/feathers.git","ssh_url":"git@github.com:feathersjs/feathers.git","clone_url":"https://github.com/feathersjs/feathers.git","svn_url":"https://github.com/feathersjs/feathers","homepage":"https://feathersjs.com","size":5310,"stargazers_count":9702,"watchers_count":9702,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":362,"open_issues":54,"watchers":9702,"default_branch":"master"}},"base":{"label":"feathersjs:master","ref":"master","sha":"1b866ea3a660b62433f00cd8c1b6c695c782117b","user":{"login":"feathersjs","id":5321853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMjE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321853?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2609642,"node_id":"MDEwOlJlcG9zaXRvcnkyNjA5NjQy","name":"feathers","full_name":"feathersjs/feathers","private":false,"owner":{"login":"feathersjs","id":5321853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMjE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5321853?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/feathersjs/feathers","description":"A REST and realtime API layer for modern applications.","fork":false,"url":"https://api.github.com/repos/feathersjs/feathers","forks_url":"https://api.github.com/repos/feathersjs/feathers/forks","keys_url":"https://api.github.com/repos/feathersjs/feathers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs/feathers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs/feathers/teams","hooks_url":"https://api.github.com/repos/feathersjs/feathers/hooks","issue_events_url":"https://api.github.com/repos/feathersjs/feathers/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs/feathers/events","assignees_url":"https://api.github.com/repos/feathersjs/feathers/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs/feathers/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs/feathers/tags","blobs_url":"https://api.github.com/repos/feathersjs/feathers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs/feathers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs/feathers/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs/feathers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs/feathers/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs/feathers/languages","stargazers_url":"https://api.github.com/repos/feathersjs/feathers/stargazers","contributors_url":"https://api.github.com/repos/feathersjs/feathers/contributors","subscribers_url":"https://api.github.com/repos/feathersjs/feathers/subscribers","subscription_url":"https://api.github.com/repos/feathersjs/feathers/subscription","commits_url":"https://api.github.com/repos/feathersjs/feathers/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs/feathers/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs/feathers/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs/feathers/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs/feathers/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs/feathers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs/feathers/merges","archive_url":"https://api.github.com/repos/feathersjs/feathers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs/feathers/downloads","issues_url":"https://api.github.com/repos/feathersjs/feathers/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs/feathers/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs/feathers/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs/feathers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs/feathers/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs/feathers/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs/feathers/deployments","created_at":"2011-10-19T22:45:16Z","updated_at":"2018-09-21T06:11:25Z","pushed_at":"2018-09-21T06:11:58Z","git_url":"git://github.com/feathersjs/feathers.git","ssh_url":"git@github.com:feathersjs/feathers.git","clone_url":"https://github.com/feathersjs/feathers.git","svn_url":"https://github.com/feathersjs/feathers","homepage":"https://feathersjs.com","size":5310,"stargazers_count":9702,"watchers_count":9702,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":362,"open_issues":54,"watchers":9702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feathersjs/feathers/pulls/1012"},"html":{"href":"https://github.com/feathersjs/feathers/pull/1012"},"issue":{"href":"https://api.github.com/repos/feathersjs/feathers/issues/1012"},"comments":{"href":"https://api.github.com/repos/feathersjs/feathers/issues/1012/comments"},"review_comments":{"href":"https://api.github.com/repos/feathersjs/feathers/pulls/1012/comments"},"review_comment":{"href":"https://api.github.com/repos/feathersjs/feathers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feathersjs/feathers/pulls/1012/commits"},"statuses":{"href":"https://api.github.com/repos/feathersjs/feathers/statuses/4fdc7a8327f654de37a5b80002dcfc23c4bba3d4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"daffl","id":338316,"node_id":"MDQ6VXNlcjMzODMxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/338316?v=4","gravatar_id":"","url":"https://api.github.com/users/daffl","html_url":"https://github.com/daffl","followers_url":"https://api.github.com/users/daffl/followers","following_url":"https://api.github.com/users/daffl/following{/other_user}","gists_url":"https://api.github.com/users/daffl/gists{/gist_id}","starred_url":"https://api.github.com/users/daffl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daffl/subscriptions","organizations_url":"https://api.github.com/users/daffl/orgs","repos_url":"https://api.github.com/users/daffl/repos","events_url":"https://api.github.com/users/daffl/events{/privacy}","received_events_url":"https://api.github.com/users/daffl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"daffl"}}