{"action":"closed","issue":{"url":"https://api.github.com/repos/auth0/cosmos/issues/594","repository_url":"https://api.github.com/repos/auth0/cosmos","labels_url":"https://api.github.com/repos/auth0/cosmos/issues/594/labels{/name}","comments_url":"https://api.github.com/repos/auth0/cosmos/issues/594/comments","events_url":"https://api.github.com/repos/auth0/cosmos/issues/594/events","html_url":"https://github.com/auth0/cosmos/issues/594","id":329936223,"node_id":"MDU6SXNzdWUzMjk5MzYyMjM=","number":594,"title":"Add large spinner (with logo) to Spinner component","user":{"login":"landitus","id":239215,"node_id":"MDQ6VXNlcjIzOTIxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/239215?v=4","gravatar_id":"","url":"https://api.github.com/users/landitus","html_url":"https://github.com/landitus","followers_url":"https://api.github.com/users/landitus/followers","following_url":"https://api.github.com/users/landitus/following{/other_user}","gists_url":"https://api.github.com/users/landitus/gists{/gist_id}","starred_url":"https://api.github.com/users/landitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landitus/subscriptions","organizations_url":"https://api.github.com/users/landitus/orgs","repos_url":"https://api.github.com/users/landitus/repos","events_url":"https://api.github.com/users/landitus/events{/privacy}","received_events_url":"https://api.github.com/users/landitus/received_events","type":"User","site_admin":false},"labels":[{"id":737624614,"node_id":"MDU6TGFiZWw3Mzc2MjQ2MTQ=","url":"https://api.github.com/repos/auth0/cosmos/labels/%E2%9A%A1enhancement","name":"⚡enhancement","color":"0e8a16","default":false},{"id":859254506,"node_id":"MDU6TGFiZWw4NTkyNTQ1MDY=","url":"https://api.github.com/repos/auth0/cosmos/labels/%F0%9F%92%94breaking%20change","name":"💔breaking change","color":"e99695","default":false},{"id":796287021,"node_id":"MDU6TGFiZWw3OTYyODcwMjE=","url":"https://api.github.com/repos/auth0/cosmos/labels/%F0%9F%96%A5%EF%B8%8Fapi%20/%20dx","name":"🖥️api / dx","color":"f9d0c4","default":false}],"state":"closed","locked":false,"assignee":{"login":"francocorreasosa","id":4152942,"node_id":"MDQ6VXNlcjQxNTI5NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4152942?v=4","gravatar_id":"","url":"https://api.github.com/users/francocorreasosa","html_url":"https://github.com/francocorreasosa","followers_url":"https://api.github.com/users/francocorreasosa/followers","following_url":"https://api.github.com/users/francocorreasosa/following{/other_user}","gists_url":"https://api.github.com/users/francocorreasosa/gists{/gist_id}","starred_url":"https://api.github.com/users/francocorreasosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francocorreasosa/subscriptions","organizations_url":"https://api.github.com/users/francocorreasosa/orgs","repos_url":"https://api.github.com/users/francocorreasosa/repos","events_url":"https://api.github.com/users/francocorreasosa/events{/privacy}","received_events_url":"https://api.github.com/users/francocorreasosa/received_events","type":"User","site_admin":false},"assignees":[{"login":"francocorreasosa","id":4152942,"node_id":"MDQ6VXNlcjQxNTI5NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4152942?v=4","gravatar_id":"","url":"https://api.github.com/users/francocorreasosa","html_url":"https://github.com/francocorreasosa","followers_url":"https://api.github.com/users/francocorreasosa/followers","following_url":"https://api.github.com/users/francocorreasosa/following{/other_user}","gists_url":"https://api.github.com/users/francocorreasosa/gists{/gist_id}","starred_url":"https://api.github.com/users/francocorreasosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francocorreasosa/subscriptions","organizations_url":"https://api.github.com/users/francocorreasosa/orgs","repos_url":"https://api.github.com/users/francocorreasosa/repos","events_url":"https://api.github.com/users/francocorreasosa/events{/privacy}","received_events_url":"https://api.github.com/users/francocorreasosa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-06-06T16:09:45Z","updated_at":"2018-10-08T13:03:06Z","closed_at":"2018-10-08T13:03:06Z","author_association":"COLLABORATOR","body":"The large spinner is primarily used for loading states between pages. The existing small spinner is used for loading states inside buttons.\r\n\r\nI believe the large spinner should be the default one, so that would make a breaking change.\r\n\r\n### Actual implementation\r\nhttps://auth0-cosmos.now.sh/docs/spinner\r\n\r\n### Design reference\r\n<img width=\"659\" alt=\"screen shot 2018-06-08 at 16 24 55\" src=\"https://user-images.githubusercontent.com/239215/41176911-89e80d2a-6b38-11e8-8a62-66ae28e61213.png\">\r\n\r\n### The API for the spinner could be:\r\n\r\n**size: enum**\r\n`default`: spinner with logo \r\n`small` : spinner without logo\r\n\r\nFor the light and dark version at first I thought of an `appearance` prop, that defaults to `light`? wdyt?\r\n\r\nThe docs could use some love and we will now have a Props table in there!"}}
{"actor":{"display_login":"landitus"}}