{"action":"created","issue":{"url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/80","repository_url":"https://api.github.com/repos/james-proxy/james-browser-launcher","labels_url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/80/comments","events_url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/80/events","html_url":"https://github.com/james-proxy/james-browser-launcher/pull/80","id":377090367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTM5NTY5","number":80,"title":"Allow overriding the default browser profile directory","user":{"login":"pimterry","id":1526883,"node_id":"MDQ6VXNlcjE1MjY4ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1526883?v=4","gravatar_id":"","url":"https://api.github.com/users/pimterry","html_url":"https://github.com/pimterry","followers_url":"https://api.github.com/users/pimterry/followers","following_url":"https://api.github.com/users/pimterry/following{/other_user}","gists_url":"https://api.github.com/users/pimterry/gists{/gist_id}","starred_url":"https://api.github.com/users/pimterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimterry/subscriptions","organizations_url":"https://api.github.com/users/pimterry/orgs","repos_url":"https://api.github.com/users/pimterry/repos","events_url":"https://api.github.com/users/pimterry/events{/privacy}","received_events_url":"https://api.github.com/users/pimterry/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-03T20:30:02Z","updated_at":"2018-11-28T03:46:40Z","closed_at":"2018-11-28T03:34:25Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/james-proxy/james-browser-launcher/pulls/80","html_url":"https://github.com/james-proxy/james-browser-launcher/pull/80","diff_url":"https://github.com/james-proxy/james-browser-launcher/pull/80.diff","patch_url":"https://github.com/james-proxy/james-browser-launcher/pull/80.patch"},"body":"I need this because the Firefox setup creates a temp folder every time. This fixed https://github.com/benderjs/browser-launcher2/issues/21, because repeatedly killing a firefox instance using a profile folder can corrupt it.\r\n\r\nIn my case though, I'm launching a Firefox instance that I expect the user to close manually most of the time, so this isn't necessary, and I'd like the profile to persist between runs, which this currently breaks. Being able to override the profile to provide a fixed directory solves this nicely for me, and doesn't change the existing behaviour.\r\n\r\nAs a bonus, rather than create a firefox-specific option, I've updated all the other setups too, so that you can now override the profile directory everywhere, if you want to for some reason."},"comment":{"url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/comments/442309220","html_url":"https://github.com/james-proxy/james-browser-launcher/pull/80#issuecomment-442309220","issue_url":"https://api.github.com/repos/james-proxy/james-browser-launcher/issues/80","id":442309220,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjMwOTIyMA==","user":{"login":"mitchhentges","id":7784737,"node_id":"MDQ6VXNlcjc3ODQ3Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/7784737?v=4","gravatar_id":"","url":"https://api.github.com/users/mitchhentges","html_url":"https://github.com/mitchhentges","followers_url":"https://api.github.com/users/mitchhentges/followers","following_url":"https://api.github.com/users/mitchhentges/following{/other_user}","gists_url":"https://api.github.com/users/mitchhentges/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchhentges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchhentges/subscriptions","organizations_url":"https://api.github.com/users/mitchhentges/orgs","repos_url":"https://api.github.com/users/mitchhentges/repos","events_url":"https://api.github.com/users/mitchhentges/events{/privacy}","received_events_url":"https://api.github.com/users/mitchhentges/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T03:46:40Z","updated_at":"2018-11-28T03:46:40Z","author_association":"MEMBER","body":"`v1.3.3` has been released :package: "}}
{"actor":{"display_login":"mitchhentges"}}