{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/234985822","pull_request_review_id":176745146,"id":234985822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk4NTgyMg==","diff_hunk":"@@ -0,0 +1,98 @@\n+// ============================================================================\n+//                 SeqAn - The Library for Sequence Analysis\n+// ============================================================================\n+//\n+// Copyright (c) 2006-2018, Knut Reinert & Freie Universitaet Berlin\n+// Copyright (c) 2016-2018, Knut Reinert & MPI Molekulare Genetik\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions are met:\n+//\n+//     * Redistributions of source code must retain the above copyright\n+//       notice, this list of conditions and the following disclaimer.\n+//     * Redistributions in binary form must reproduce the above copyright\n+//       notice, this list of conditions and the following disclaimer in the\n+//       documentation and/or other materials provided with the distribution.\n+//     * Neither the name of Knut Reinert or the FU Berlin nor the names of\n+//       its contributors may be used to endorse or promote products derived\n+//       from this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+// ARE DISCLAIMED. IN NO EVENT SHALL KNUT REINERT OR THE FU BERLIN BE LIABLE\n+// FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+// DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+// SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY\n+// OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH\n+// DAMAGE.\n+//\n+// ============================================================================\n+\n+/*!\\file\n+ * \\author Enrico Seiler <enrico.seiler AT fu-berlin.de>\n+ * \\brief Provides overloads for std::hash.\n+ */\n+\n+#pragma once\n+\n+#include <seqan3/core/metafunction/range.hpp>\n+#include <seqan3/std/ranges>\n+\n+namespace std\n+{\n+/*!\\brief Struct for hashing a character.\n+ * \\ingroup alphabet\n+ * \\tparam alphabet_t The type of character to hash; Must model seqan3::semi_alphabet_concept.\n+ */\n+template <seqan3::semi_alphabet_concept alphabet_t>\n+struct hash<alphabet_t>\n+{\n+    /*!\\brief Compute the hash for a character.\n+     * \\ingroup alphabet\n+     * \\param[in] character The character to process. Must model seqan3::semi_alphabet_concept.\n+     *\n+     * \\returns size_t.\n+     * \\sa seqan3::to_rank.\n+     */\n+    size_t operator()(alphabet_t const & character) const noexcept\n+    {\n+        using seqan3::to_rank;\n+        return to_rank(character);\n+    }\n+};\n+\n+/*!\\brief Struct for hashing a range of characters.\n+ * \\ingroup alphabet\n+ * \\tparam urng_t The type of the range; Must model std::ranges::InputRange and the reference type of the range of the\n+                  range must model seqan3::semi_alphabet_concept.\n+ */\n+template <ranges::InputRange urng_t>\n+    //!\\cond\n+    requires seqan3::semi_alphabet_concept<seqan3::reference_t<urng_t>>\n+    //!\\endcond\n+struct hash<urng_t>\n+{\n+    /*!\\brief Compute the hash for a range of characters.\n+     * \\ingroup alphabet\n+     * \\param[in] range The input range to process. Must model std::ranges::InputRange and the reference type of the\n+                        range of the range must model seqan3::semi_alphabet_concept.\n+     * \\returns size_t.\n+     */\n+    size_t operator()(urng_t const & range) const noexcept\n+    {\n+        using alphabet_t = seqan3::value_type_t<urng_t>;\n+        size_t result{0};\n+        hash<alphabet_t> h{};\n+        for (auto it = begin(range); it != end(range); ++it)","path":"include/seqan3/alphabet/detail/hash.hpp","position":90,"original_position":90,"commit_id":"2baf389ba9ea2ccccd40fcd12df9b4729103b41d","original_commit_id":"2baf389ba9ea2ccccd40fcd12df9b4729103b41d","user":{"login":"h-2","id":2996863,"node_id":"MDQ6VXNlcjI5OTY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"body":"You can use a range-based for loop here :nail_care: ","created_at":"2018-11-20T12:40:29Z","updated_at":"2018-11-20T12:53:56Z","html_url":"https://github.com/seqan/seqan3/pull/539#discussion_r234985822","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/539","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/234985822"},"html":{"href":"https://github.com/seqan/seqan3/pull/539#discussion_r234985822"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/539","id":229035081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDM1MDgx","html_url":"https://github.com/seqan/seqan3/pull/539","diff_url":"https://github.com/seqan/seqan3/pull/539.diff","patch_url":"https://github.com/seqan/seqan3/pull/539.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/539","number":539,"state":"open","locked":false,"title":"[FEATURE] Add std::hash for semi_alphabets and view::kmer_hash","user":{"login":"eseiler","id":12967715,"node_id":"MDQ6VXNlcjEyOTY3NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/12967715?v=4","gravatar_id":"","url":"https://api.github.com/users/eseiler","html_url":"https://github.com/eseiler","followers_url":"https://api.github.com/users/eseiler/followers","following_url":"https://api.github.com/users/eseiler/following{/other_user}","gists_url":"https://api.github.com/users/eseiler/gists{/gist_id}","starred_url":"https://api.github.com/users/eseiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseiler/subscriptions","organizations_url":"https://api.github.com/users/eseiler/orgs","repos_url":"https://api.github.com/users/eseiler/repos","events_url":"https://api.github.com/users/eseiler/events{/privacy}","received_events_url":"https://api.github.com/users/eseiler/received_events","type":"User","site_admin":false},"body":"TODO:\r\n\r\n- [ ] Docs\r\n- [x] Tests\n- [x] alphabetical ordering of includes ","created_at":"2018-11-07T13:55:34Z","updated_at":"2018-11-20T12:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01bd6d1fe5254b7d27bb7bc5feb362dda2b058bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":581690505,"node_id":"MDU6TGFiZWw1ODE2OTA1MDU=","url":"https://api.github.com/repos/seqan/seqan3/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/539/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/539/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/539/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/2baf389ba9ea2ccccd40fcd12df9b4729103b41d","head":{"label":"eseiler:feature/hashes","ref":"feature/hashes","sha":"2baf389ba9ea2ccccd40fcd12df9b4729103b41d","user":{"login":"eseiler","id":12967715,"node_id":"MDQ6VXNlcjEyOTY3NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/12967715?v=4","gravatar_id":"","url":"https://api.github.com/users/eseiler","html_url":"https://github.com/eseiler","followers_url":"https://api.github.com/users/eseiler/followers","following_url":"https://api.github.com/users/eseiler/following{/other_user}","gists_url":"https://api.github.com/users/eseiler/gists{/gist_id}","starred_url":"https://api.github.com/users/eseiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseiler/subscriptions","organizations_url":"https://api.github.com/users/eseiler/orgs","repos_url":"https://api.github.com/users/eseiler/repos","events_url":"https://api.github.com/users/eseiler/events{/privacy}","received_events_url":"https://api.github.com/users/eseiler/received_events","type":"User","site_admin":false},"repo":{"id":121257402,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNTc0MDI=","name":"seqan3","full_name":"eseiler/seqan3","private":false,"owner":{"login":"eseiler","id":12967715,"node_id":"MDQ6VXNlcjEyOTY3NzE1","avatar_url":"https://avatars0.githubusercontent.com/u/12967715?v=4","gravatar_id":"","url":"https://api.github.com/users/eseiler","html_url":"https://github.com/eseiler","followers_url":"https://api.github.com/users/eseiler/followers","following_url":"https://api.github.com/users/eseiler/following{/other_user}","gists_url":"https://api.github.com/users/eseiler/gists{/gist_id}","starred_url":"https://api.github.com/users/eseiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eseiler/subscriptions","organizations_url":"https://api.github.com/users/eseiler/orgs","repos_url":"https://api.github.com/users/eseiler/repos","events_url":"https://api.github.com/users/eseiler/events{/privacy}","received_events_url":"https://api.github.com/users/eseiler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eseiler/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/eseiler/seqan3","forks_url":"https://api.github.com/repos/eseiler/seqan3/forks","keys_url":"https://api.github.com/repos/eseiler/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eseiler/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eseiler/seqan3/teams","hooks_url":"https://api.github.com/repos/eseiler/seqan3/hooks","issue_events_url":"https://api.github.com/repos/eseiler/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/eseiler/seqan3/events","assignees_url":"https://api.github.com/repos/eseiler/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/eseiler/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/eseiler/seqan3/tags","blobs_url":"https://api.github.com/repos/eseiler/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eseiler/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eseiler/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/eseiler/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eseiler/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/eseiler/seqan3/languages","stargazers_url":"https://api.github.com/repos/eseiler/seqan3/stargazers","contributors_url":"https://api.github.com/repos/eseiler/seqan3/contributors","subscribers_url":"https://api.github.com/repos/eseiler/seqan3/subscribers","subscription_url":"https://api.github.com/repos/eseiler/seqan3/subscription","commits_url":"https://api.github.com/repos/eseiler/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/eseiler/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/eseiler/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/eseiler/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/eseiler/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/eseiler/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eseiler/seqan3/merges","archive_url":"https://api.github.com/repos/eseiler/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eseiler/seqan3/downloads","issues_url":"https://api.github.com/repos/eseiler/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/eseiler/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/eseiler/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/eseiler/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eseiler/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/eseiler/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/eseiler/seqan3/deployments","created_at":"2018-02-12T14:35:33Z","updated_at":"2018-11-05T10:07:30Z","pushed_at":"2018-11-20T06:00:23Z","git_url":"git://github.com/eseiler/seqan3.git","ssh_url":"git@github.com:eseiler/seqan3.git","clone_url":"https://github.com/eseiler/seqan3.git","svn_url":"https://github.com/eseiler/seqan3","homepage":"http://www.seqan.de","size":2032,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"c14ce2f2f50c4413cad693edfbca4885e4baa782","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","private":false,"owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2018-11-19T17:41:43Z","pushed_at":"2018-11-20T12:47:16Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":2080,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":137,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/539"},"html":{"href":"https://github.com/seqan/seqan3/pull/539"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/539"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/2baf389ba9ea2ccccd40fcd12df9b4729103b41d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"h-2"}}