{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/comments/195598298","pull_request_review_id":129001258,"id":195598298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU5ODI5OA==","diff_hunk":"@@ -25,7 +25,9 @@\n \n When(\"we run the rails command line with:\") do |cmd|\n   if cmd.start_with?('g aws_record:model')\n-    @table_name = cmd.split(' ')[2]\n+    @model_name = cmd.split(' ')[2]\n+    @table_name = SecureRandom.uuid","path":"features/model/step_definitions.rb","position":6,"original_position":6,"commit_id":"3ca1ee6a9c9f9dc7ebcde5a67bc9dfe4430e8c5f","original_commit_id":"3ca1ee6a9c9f9dc7ebcde5a67bc9dfe4430e8c5f","user":{"login":"awood45","id":2114465,"node_id":"MDQ6VXNlcjIxMTQ0NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2114465?v=4","gravatar_id":"","url":"https://api.github.com/users/awood45","html_url":"https://github.com/awood45","followers_url":"https://api.github.com/users/awood45/followers","following_url":"https://api.github.com/users/awood45/following{/other_user}","gists_url":"https://api.github.com/users/awood45/gists{/gist_id}","starred_url":"https://api.github.com/users/awood45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awood45/subscriptions","organizations_url":"https://api.github.com/users/awood45/orgs","repos_url":"https://api.github.com/users/awood45/repos","events_url":"https://api.github.com/users/awood45/events{/privacy}","received_events_url":"https://api.github.com/users/awood45/received_events","type":"User","site_admin":false},"body":"As a matter of course, I'd do:\r\n\r\n```ruby\r\n@table_name = \"#{@model_name}_#{SecureRandom.uuid}\"\r\n```\r\n\r\nThat way, you keep the model name for readability.","created_at":"2018-06-14T23:15:32Z","updated_at":"2018-06-14T23:16:59Z","html_url":"https://github.com/awslabs/aws-record-generator-rails/pull/7#discussion_r195598298","pull_request_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/comments/195598298"},"html":{"href":"https://github.com/awslabs/aws-record-generator-rails/pull/7#discussion_r195598298"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7","id":194739286,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzM5Mjg2","html_url":"https://github.com/awslabs/aws-record-generator-rails/pull/7","diff_url":"https://github.com/awslabs/aws-record-generator-rails/pull/7.diff","patch_url":"https://github.com/awslabs/aws-record-generator-rails/pull/7.patch","issue_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/7","number":7,"state":"open","locked":false,"title":"Added table_name option","user":{"login":"YashoSharma","id":20632446,"node_id":"MDQ6VXNlcjIwNjMyNDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/20632446?v=4","gravatar_id":"","url":"https://api.github.com/users/YashoSharma","html_url":"https://github.com/YashoSharma","followers_url":"https://api.github.com/users/YashoSharma/followers","following_url":"https://api.github.com/users/YashoSharma/following{/other_user}","gists_url":"https://api.github.com/users/YashoSharma/gists{/gist_id}","starred_url":"https://api.github.com/users/YashoSharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YashoSharma/subscriptions","organizations_url":"https://api.github.com/users/YashoSharma/orgs","repos_url":"https://api.github.com/users/YashoSharma/repos","events_url":"https://api.github.com/users/YashoSharma/events{/privacy}","received_events_url":"https://api.github.com/users/YashoSharma/received_events","type":"User","site_admin":false},"body":"*Description of changes:*\r\n- [x] Allows the DynamoDB table name for a model to be set with the model generator\r\n- [x] Integration tests generate random table names\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.","created_at":"2018-06-13T23:05:37Z","updated_at":"2018-06-14T23:16:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a025b850c9128e8a6f648dc4d83e595683233b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/7/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/statuses/3ca1ee6a9c9f9dc7ebcde5a67bc9dfe4430e8c5f","head":{"label":"awslabs:TableNameOpt","ref":"TableNameOpt","sha":"3ca1ee6a9c9f9dc7ebcde5a67bc9dfe4430e8c5f","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135116888,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMTY4ODg=","name":"aws-record-generator-rails","full_name":"awslabs/aws-record-generator-rails","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-record-generator-rails","description":"Allows the generation of aws-record models using a Rails generator","fork":false,"url":"https://api.github.com/repos/awslabs/aws-record-generator-rails","forks_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/forks","keys_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/events","assignees_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/merges","archive_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/deployments","created_at":"2018-05-28T06:11:41Z","updated_at":"2018-06-13T20:17:47Z","pushed_at":"2018-06-13T23:05:37Z","git_url":"git://github.com/awslabs/aws-record-generator-rails.git","ssh_url":"git@github.com:awslabs/aws-record-generator-rails.git","clone_url":"https://github.com/awslabs/aws-record-generator-rails.git","svn_url":"https://github.com/awslabs/aws-record-generator-rails","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"9ffcf94b18a8545a257c5dcb0da100efd0eb85c1","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135116888,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMTY4ODg=","name":"aws-record-generator-rails","full_name":"awslabs/aws-record-generator-rails","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-record-generator-rails","description":"Allows the generation of aws-record models using a Rails generator","fork":false,"url":"https://api.github.com/repos/awslabs/aws-record-generator-rails","forks_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/forks","keys_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/events","assignees_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/merges","archive_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-record-generator-rails/deployments","created_at":"2018-05-28T06:11:41Z","updated_at":"2018-06-13T20:17:47Z","pushed_at":"2018-06-13T23:05:37Z","git_url":"git://github.com/awslabs/aws-record-generator-rails.git","ssh_url":"git@github.com:awslabs/aws-record-generator-rails.git","clone_url":"https://github.com/awslabs/aws-record-generator-rails.git","svn_url":"https://github.com/awslabs/aws-record-generator-rails","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7"},"html":{"href":"https://github.com/awslabs/aws-record-generator-rails/pull/7"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/7"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-record-generator-rails/statuses/3ca1ee6a9c9f9dc7ebcde5a67bc9dfe4430e8c5f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"awood45"}}