{"action":"created","issue":{"url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/5","repository_url":"https://api.github.com/repos/convexengineering/heatexchanger","labels_url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/5/comments","events_url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/5/events","html_url":"https://github.com/convexengineering/heatexchanger/pull/5","id":308295230,"number":5,"title":"fix rotation bugs","user":{"login":"bqpd","id":1482776,"avatar_url":"https://avatars2.githubusercontent.com/u/1482776?v=4","gravatar_id":"","url":"https://api.github.com/users/bqpd","html_url":"https://github.com/bqpd","followers_url":"https://api.github.com/users/bqpd/followers","following_url":"https://api.github.com/users/bqpd/following{/other_user}","gists_url":"https://api.github.com/users/bqpd/gists{/gist_id}","starred_url":"https://api.github.com/users/bqpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bqpd/subscriptions","organizations_url":"https://api.github.com/users/bqpd/orgs","repos_url":"https://api.github.com/users/bqpd/repos","events_url":"https://api.github.com/users/bqpd/events{/privacy}","received_events_url":"https://api.github.com/users/bqpd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-24T20:13:55Z","updated_at":"2018-04-10T20:37:54Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/convexengineering/heatexchanger/pulls/5","html_url":"https://github.com/convexengineering/heatexchanger/pull/5","diff_url":"https://github.com/convexengineering/heatexchanger/pull/5.diff","patch_url":"https://github.com/convexengineering/heatexchanger/pull/5.patch"},"body":"When I tried having inequal numbers of water and air pipes (trying (3,5) and (5,3), among other combinations), some errors occurred; I believe these represent some small model errors, fixed in this commit."},"comment":{"url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/comments/380238625","html_url":"https://github.com/convexengineering/heatexchanger/pull/5#issuecomment-380238625","issue_url":"https://api.github.com/repos/convexengineering/heatexchanger/issues/5","id":380238625,"user":{"login":"bqpd","id":1482776,"avatar_url":"https://avatars2.githubusercontent.com/u/1482776?v=4","gravatar_id":"","url":"https://api.github.com/users/bqpd","html_url":"https://github.com/bqpd","followers_url":"https://api.github.com/users/bqpd/followers","following_url":"https://api.github.com/users/bqpd/following{/other_user}","gists_url":"https://api.github.com/users/bqpd/gists{/gist_id}","starred_url":"https://api.github.com/users/bqpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bqpd/subscriptions","organizations_url":"https://api.github.com/users/bqpd/orgs","repos_url":"https://api.github.com/users/bqpd/repos","events_url":"https://api.github.com/users/bqpd/events{/privacy}","received_events_url":"https://api.github.com/users/bqpd/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T20:37:54Z","updated_at":"2018-04-10T20:37:54Z","author_association":"OWNER","body":"Putting the following at the bottom of layer (and disabling rectpipes verification)\r\n\r\n```python\r\nNcoldpipes, Nhotpipes = 5, 6\r\ncoldFluid = Air()\r\nhotFluid = Water()\r\nmaterial = StainlessSteel()\r\nn_fins = 5\r\nwith Vectorize(Nhotpipes):\r\n     hotpipes = RectangularPipe(Ncoldpipes, n_fins, hotFluid, increasingT=False,\r\n                                         substitutions={\"T_in\": 500,\r\n                                                        \"v_in\": 1})\r\nprint len(hotpipes.dQ), hotpipes.dQ.shape\r\n```\r\nIt prints out `5 (5, 6)`, yeah. That's...correct? The first index is the number of coldpipes, the second the number of hotpipes; this is working as it has to in order for vector access within rectpipes to work."}}
{"actor":{"display_login":"bqpd"}}