{"action":"created","issue":{"url":"https://api.github.com/repos/directus/api/issues/336","repository_url":"https://api.github.com/repos/directus/api","labels_url":"https://api.github.com/repos/directus/api/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/directus/api/issues/336/comments","events_url":"https://api.github.com/repos/directus/api/issues/336/events","html_url":"https://github.com/directus/api/issues/336","id":352995001,"node_id":"MDU6SXNzdWUzNTI5OTUwMDE=","number":336,"title":"Rename Date/User Columns","user":{"login":"benhaynes","id":522079,"node_id":"MDQ6VXNlcjUyMjA3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/522079?v=4","gravatar_id":"","url":"https://api.github.com/users/benhaynes","html_url":"https://github.com/benhaynes","followers_url":"https://api.github.com/users/benhaynes/followers","following_url":"https://api.github.com/users/benhaynes/following{/other_user}","gists_url":"https://api.github.com/users/benhaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/benhaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhaynes/subscriptions","organizations_url":"https://api.github.com/users/benhaynes/orgs","repos_url":"https://api.github.com/users/benhaynes/repos","events_url":"https://api.github.com/users/benhaynes/events{/privacy}","received_events_url":"https://api.github.com/users/benhaynes/received_events","type":"User","site_admin":false},"labels":[{"id":838688387,"node_id":"MDU6TGFiZWw4Mzg2ODgzODc=","url":"https://api.github.com/repos/directus/api/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-22T15:01:35Z","updated_at":"2018-08-22T15:29:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"For consistency, let's update the following and add a note in the API Contributor Docs with `*_on` (datetime) and `*_by` (user) naming conventions.\r\n\r\n* `directus_activity.datetime` -> `directus_activity.action_on` (**thoughts on this?**)\r\n* `directus_activity.user` -> `directus_activity.action_by` (**thoughts on this?**)\r\n* `directus_activity.datetime_edited` -> `directus_activity.edited_on`\r\n* `directus_activity.deleted_comment` -> `directus_activity.comment_deleted_on`\r\n\r\n* `directus_activity_seen.seen` -> `directus_activity_seen.seen_on`\r\n\r\n* `directus_files.upload_user` -> `directus_files.uploaded_by`\r\n* `directus_files.upload_date` -> `directus_files.uploaded_on`\r\n\r\n* `directus_users.last_access` -> `directus_users.last_access_on`\r\n* `directus_users.last_login` -> `directus_users.last_login_on`\r\n\r\n@rijkvanzanten @WellingGuzman – thoughts?"},"comment":{"url":"https://api.github.com/repos/directus/api/issues/comments/415074220","html_url":"https://github.com/directus/api/issues/336#issuecomment-415074220","issue_url":"https://api.github.com/repos/directus/api/issues/336","id":415074220,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTA3NDIyMA==","user":{"login":"WellingGuzman","id":1531291,"node_id":"MDQ6VXNlcjE1MzEyOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1531291?v=4","gravatar_id":"","url":"https://api.github.com/users/WellingGuzman","html_url":"https://github.com/WellingGuzman","followers_url":"https://api.github.com/users/WellingGuzman/followers","following_url":"https://api.github.com/users/WellingGuzman/following{/other_user}","gists_url":"https://api.github.com/users/WellingGuzman/gists{/gist_id}","starred_url":"https://api.github.com/users/WellingGuzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WellingGuzman/subscriptions","organizations_url":"https://api.github.com/users/WellingGuzman/orgs","repos_url":"https://api.github.com/users/WellingGuzman/repos","events_url":"https://api.github.com/users/WellingGuzman/events{/privacy}","received_events_url":"https://api.github.com/users/WellingGuzman/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T15:29:46Z","updated_at":"2018-08-22T15:29:46Z","author_association":"CONTRIBUTOR","body":"I prefer `*_at` better for datetime, Ex: `uploaded_at` rather than `uploaded_on`.\r\n\r\n> `directus_activity.user` -> `directus_activity.action_by` (**thoughts on this?**)\r\n\r\nIn this case I still prefer `user`, over `action_by`. Maybe `created_by` and `created_at` rather than `action_on` and `action_by`\r\n\r\n\r\n> `directus_activity.deleted_comment` -> `directus_activity.comment_deleted_on`\r\n> `directus_activity_seen.seen` -> `directus_activity_seen.seen_on`\r\n\r\nThese are boolean fields, and not a date time, unless you are suggesting changing their type as well.\r\n\r\n> `directus_users.last_access` -> `directus_users.last_access_on`\r\n\r\nEven though the new name makes total sense, I believe `last_access` means \"when\".\r\n\r\n> `directus_users.last_login` -> `directus_users.last_login_on`\r\n\r\nIs this a new field?"}}
{"actor":{"display_login":"WellingGuzman"}}