{"action":"created","issue":{"url":"https://api.github.com/repos/christiansandberg/canopen/issues/101","repository_url":"https://api.github.com/repos/christiansandberg/canopen","labels_url":"https://api.github.com/repos/christiansandberg/canopen/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/christiansandberg/canopen/issues/101/comments","events_url":"https://api.github.com/repos/christiansandberg/canopen/issues/101/events","html_url":"https://github.com/christiansandberg/canopen/pull/101","id":348825305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDg1MTAw","number":101,"title":"implemented the node guarding mechanism in the NMT object ","user":{"login":"af-silva","id":11874980,"node_id":"MDQ6VXNlcjExODc0OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/11874980?v=4","gravatar_id":"","url":"https://api.github.com/users/af-silva","html_url":"https://github.com/af-silva","followers_url":"https://api.github.com/users/af-silva/followers","following_url":"https://api.github.com/users/af-silva/following{/other_user}","gists_url":"https://api.github.com/users/af-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/af-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/af-silva/subscriptions","organizations_url":"https://api.github.com/users/af-silva/orgs","repos_url":"https://api.github.com/users/af-silva/repos","events_url":"https://api.github.com/users/af-silva/events{/privacy}","received_events_url":"https://api.github.com/users/af-silva/received_events","type":"User","site_admin":false},"labels":[{"id":446250657,"node_id":"MDU6TGFiZWw0NDYyNTA2NTc=","url":"https://api.github.com/repos/christiansandberg/canopen/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":472175135,"node_id":"MDU6TGFiZWw0NzIxNzUxMzU=","url":"https://api.github.com/repos/christiansandberg/canopen/labels/nmt","name":"nmt","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":{"login":"christiansandberg","id":3647996,"node_id":"MDQ6VXNlcjM2NDc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3647996?v=4","gravatar_id":"","url":"https://api.github.com/users/christiansandberg","html_url":"https://github.com/christiansandberg","followers_url":"https://api.github.com/users/christiansandberg/followers","following_url":"https://api.github.com/users/christiansandberg/following{/other_user}","gists_url":"https://api.github.com/users/christiansandberg/gists{/gist_id}","starred_url":"https://api.github.com/users/christiansandberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiansandberg/subscriptions","organizations_url":"https://api.github.com/users/christiansandberg/orgs","repos_url":"https://api.github.com/users/christiansandberg/repos","events_url":"https://api.github.com/users/christiansandberg/events{/privacy}","received_events_url":"https://api.github.com/users/christiansandberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"christiansandberg","id":3647996,"node_id":"MDQ6VXNlcjM2NDc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3647996?v=4","gravatar_id":"","url":"https://api.github.com/users/christiansandberg","html_url":"https://github.com/christiansandberg","followers_url":"https://api.github.com/users/christiansandberg/followers","following_url":"https://api.github.com/users/christiansandberg/following{/other_user}","gists_url":"https://api.github.com/users/christiansandberg/gists{/gist_id}","starred_url":"https://api.github.com/users/christiansandberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiansandberg/subscriptions","organizations_url":"https://api.github.com/users/christiansandberg/orgs","repos_url":"https://api.github.com/users/christiansandberg/repos","events_url":"https://api.github.com/users/christiansandberg/events{/privacy}","received_events_url":"https://api.github.com/users/christiansandberg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/christiansandberg/canopen/milestones/3","html_url":"https://github.com/christiansandberg/canopen/milestone/3","labels_url":"https://api.github.com/repos/christiansandberg/canopen/milestones/3/labels","id":3550361,"node_id":"MDk6TWlsZXN0b25lMzU1MDM2MQ==","number":3,"title":"v0.8.0","description":"","creator":{"login":"christiansandberg","id":3647996,"node_id":"MDQ6VXNlcjM2NDc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3647996?v=4","gravatar_id":"","url":"https://api.github.com/users/christiansandberg","html_url":"https://github.com/christiansandberg","followers_url":"https://api.github.com/users/christiansandberg/followers","following_url":"https://api.github.com/users/christiansandberg/following{/other_user}","gists_url":"https://api.github.com/users/christiansandberg/gists{/gist_id}","starred_url":"https://api.github.com/users/christiansandberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiansandberg/subscriptions","organizations_url":"https://api.github.com/users/christiansandberg/orgs","repos_url":"https://api.github.com/users/christiansandberg/repos","events_url":"https://api.github.com/users/christiansandberg/events{/privacy}","received_events_url":"https://api.github.com/users/christiansandberg/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2018-08-06T19:45:49Z","updated_at":"2018-08-09T11:07:21Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-08-08T17:41:42Z","updated_at":"2018-08-09T14:10:05Z","closed_at":"2018-08-09T11:07:21Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/christiansandberg/canopen/pulls/101","html_url":"https://github.com/christiansandberg/canopen/pull/101","diff_url":"https://github.com/christiansandberg/canopen/pull/101.diff","patch_url":"https://github.com/christiansandberg/canopen/pull/101.patch"},"body":"\r\n"},"comment":{"url":"https://api.github.com/repos/christiansandberg/canopen/issues/comments/411771143","html_url":"https://github.com/christiansandberg/canopen/pull/101#issuecomment-411771143","issue_url":"https://api.github.com/repos/christiansandberg/canopen/issues/101","id":411771143,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTc3MTE0Mw==","user":{"login":"af-silva","id":11874980,"node_id":"MDQ6VXNlcjExODc0OTgw","avatar_url":"https://avatars2.githubusercontent.com/u/11874980?v=4","gravatar_id":"","url":"https://api.github.com/users/af-silva","html_url":"https://github.com/af-silva","followers_url":"https://api.github.com/users/af-silva/followers","following_url":"https://api.github.com/users/af-silva/following{/other_user}","gists_url":"https://api.github.com/users/af-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/af-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/af-silva/subscriptions","organizations_url":"https://api.github.com/users/af-silva/orgs","repos_url":"https://api.github.com/users/af-silva/repos","events_url":"https://api.github.com/users/af-silva/events{/privacy}","received_events_url":"https://api.github.com/users/af-silva/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T14:10:05Z","updated_at":"2018-08-09T14:10:05Z","author_association":"CONTRIBUTOR","body":"I will look into the Object Dictionary first then, since I need it and I can contribute. Regarding the PDOs I will take a look again to your implementation in the branch local-nodes and test with my hardware (in this case I will only look into the remote nodes).\r\n\r\nIn my opinion I agree in separating the local and remote nodes, but in the case of the PDOs and looking at @TobiasPleyer implementation it seems solid, a bit confusing with the classes RemotePdoNode and LocalPdoNode but I will try to use that and go from there. I also think that the PDO implementation should follow what you did with the SDO implementation. \r\n-- pdo (pkg) \r\n   -- __init__.py\r\n   -- base.py\r\n   -- tpdo.py\r\n   -- rpdo.py\r\n   -- exceptions.py\r\n\r\nIt would represent a cleaner structure and follow a great deal of documentation out there (at least the ones that a read separate the object in this way, like the SDO client/server mechanism)\r\n\r\nWhat do you think? \r\nO don't know if I explained myself in the best way xD \r\n\r\nThanks again, ;)"}}
{"actor":{"display_login":"af-silva"}}