{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/204055837","pull_request_review_id":139071222,"id":204055837,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA1NTgzNw==","diff_hunk":"@@ -55,6 +55,10 @@ struct zsock_pollfd {\n  * specific socket\n  */\n #define TLS_SEC_TAG_LIST 1\n+/* Write-only socket option to set hostname. It accepts and string containing","path":"include/net/socket.h","position":null,"original_position":4,"commit_id":"d57339118e7ab758ac012cf582a6f8dafc38da34","original_commit_id":"2b2140230d694245ffdcff3ea1ebb1548b63f86a","user":{"login":"pfalcon","id":500451,"node_id":"MDQ6VXNlcjUwMDQ1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"s/and/a/.\r\n\r\n","created_at":"2018-07-20T14:06:39Z","updated_at":"2018-07-20T14:06:40Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9007#discussion_r204055837","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/204055837"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9007#discussion_r204055837"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007","id":202245330,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjQ1MzMw","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9007","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9007.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9007.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9007","number":9007,"state":"open","locked":false,"title":"net: tls: Implement TLS socket options","user":{"login":"rlubos","id":22167799,"node_id":"MDQ6VXNlcjIyMTY3Nzk5","avatar_url":"https://avatars0.githubusercontent.com/u/22167799?v=4","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"body":"This PR is a follow up of #7118 \r\n\r\nIt adds a set of TLS socket options that can be used for TLS connection configuration:\r\n* `TLS_SEC_TAG_LIST` for setting TLS credentials\r\n* `TLS_HOSTNAME` for setting hostname for peer verification\r\n* `TLS_CIPHERSUITE_LIST` for setting ciphersuites allowed on a socket\r\n* `TLS_CIPHERSUITE_USED` for reading ciphersuite selected during handshake\r\n* `TLS_PEER_VERIFY` for setting peer verification level\r\n\r\nFor TLS credential configuration a simple network lib was added. \r\n\r\nSocket options were tested with http_get, big_http_download (they now verify certificates) and socket echo_client/echo_server (these two can be tested with `net-tools` utils, as they use the same credentials as their net_app counterparts, or simply client vs server).\r\n\r\nWith this PR, #7118 is pretty much covered (some test would be needed for new code though).","created_at":"2018-07-18T13:01:45Z","updated_at":"2018-07-20T14:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c68a3ebaa8668f3f9feac3f42561760f98613bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"d3zd3z","id":90349,"node_id":"MDQ6VXNlcjkwMzQ5","avatar_url":"https://avatars3.githubusercontent.com/u/90349?v=4","gravatar_id":"","url":"https://api.github.com/users/d3zd3z","html_url":"https://github.com/d3zd3z","followers_url":"https://api.github.com/users/d3zd3z/followers","following_url":"https://api.github.com/users/d3zd3z/following{/other_user}","gists_url":"https://api.github.com/users/d3zd3z/gists{/gist_id}","starred_url":"https://api.github.com/users/d3zd3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3zd3z/subscriptions","organizations_url":"https://api.github.com/users/d3zd3z/orgs","repos_url":"https://api.github.com/users/d3zd3z/repos","events_url":"https://api.github.com/users/d3zd3z/events{/privacy}","received_events_url":"https://api.github.com/users/d3zd3z/received_events","type":"User","site_admin":false},{"login":"pfl","id":1098363,"node_id":"MDQ6VXNlcjEwOTgzNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1098363?v=4","gravatar_id":"","url":"https://api.github.com/users/pfl","html_url":"https://github.com/pfl","followers_url":"https://api.github.com/users/pfl/followers","following_url":"https://api.github.com/users/pfl/following{/other_user}","gists_url":"https://api.github.com/users/pfl/gists{/gist_id}","starred_url":"https://api.github.com/users/pfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfl/subscriptions","organizations_url":"https://api.github.com/users/pfl/orgs","repos_url":"https://api.github.com/users/pfl/repos","events_url":"https://api.github.com/users/pfl/events{/privacy}","received_events_url":"https://api.github.com/users/pfl/received_events","type":"User","site_admin":false},{"login":"tbursztyka","id":1608406,"node_id":"MDQ6VXNlcjE2MDg0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":700751655,"node_id":"MDU6TGFiZWw3MDA3NTE2NTU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Networking","name":"area: Networking","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9007/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/d57339118e7ab758ac012cf582a6f8dafc38da34","head":{"label":"rlubos:tls-socket-options","ref":"tls-socket-options","sha":"d57339118e7ab758ac012cf582a6f8dafc38da34","user":{"login":"rlubos","id":22167799,"node_id":"MDQ6VXNlcjIyMTY3Nzk5","avatar_url":"https://avatars0.githubusercontent.com/u/22167799?v=4","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"repo":{"id":130689273,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2ODkyNzM=","name":"zephyr","full_name":"rlubos/zephyr","owner":{"login":"rlubos","id":22167799,"node_id":"MDQ6VXNlcjIyMTY3Nzk5","avatar_url":"https://avatars0.githubusercontent.com/u/22167799?v=4","gravatar_id":"","url":"https://api.github.com/users/rlubos","html_url":"https://github.com/rlubos","followers_url":"https://api.github.com/users/rlubos/followers","following_url":"https://api.github.com/users/rlubos/following{/other_user}","gists_url":"https://api.github.com/users/rlubos/gists{/gist_id}","starred_url":"https://api.github.com/users/rlubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlubos/subscriptions","organizations_url":"https://api.github.com/users/rlubos/orgs","repos_url":"https://api.github.com/users/rlubos/repos","events_url":"https://api.github.com/users/rlubos/events{/privacy}","received_events_url":"https://api.github.com/users/rlubos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rlubos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/rlubos/zephyr","forks_url":"https://api.github.com/repos/rlubos/zephyr/forks","keys_url":"https://api.github.com/repos/rlubos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlubos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlubos/zephyr/teams","hooks_url":"https://api.github.com/repos/rlubos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/rlubos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/rlubos/zephyr/events","assignees_url":"https://api.github.com/repos/rlubos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/rlubos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/rlubos/zephyr/tags","blobs_url":"https://api.github.com/repos/rlubos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlubos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlubos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlubos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlubos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/rlubos/zephyr/languages","stargazers_url":"https://api.github.com/repos/rlubos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/rlubos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/rlubos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/rlubos/zephyr/subscription","commits_url":"https://api.github.com/repos/rlubos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlubos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlubos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlubos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlubos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/rlubos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlubos/zephyr/merges","archive_url":"https://api.github.com/repos/rlubos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlubos/zephyr/downloads","issues_url":"https://api.github.com/repos/rlubos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/rlubos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/rlubos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/rlubos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlubos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/rlubos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/rlubos/zephyr/deployments","created_at":"2018-04-23T11:54:42Z","updated_at":"2018-04-23T11:55:23Z","pushed_at":"2018-07-20T13:47:34Z","git_url":"git://github.com/rlubos/zephyr.git","ssh_url":"git@github.com:rlubos/zephyr.git","clone_url":"https://github.com/rlubos/zephyr.git","svn_url":"https://github.com/rlubos/zephyr","homepage":"https://zephyrproject.org/doc","size":122497,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"be9966f3aee49df43f9e738c4ae07f9d9e513c83","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-07-20T13:59:57Z","pushed_at":"2018-07-20T13:59:15Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":122636,"stargazers_count":960,"watchers_count":960,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"archived":false,"open_issues_count":1011,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":700,"open_issues":1011,"watchers":960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/9007"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9007"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9007/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9007/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/d57339118e7ab758ac012cf582a6f8dafc38da34"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pfalcon"}}