{"action":"closed","number":4237,"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237","id":238811166,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODExMTY2","html_url":"https://github.com/apollographql/apollo-client/pull/4237","diff_url":"https://github.com/apollographql/apollo-client/pull/4237.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/4237.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4237","number":4237,"state":"closed","locked":false,"title":"Fix incorrect documentation on error handling","user":{"login":"tobobo","id":796548,"node_id":"MDQ6VXNlcjc5NjU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/796548?v=4","gravatar_id":"","url":"https://api.github.com/users/tobobo","html_url":"https://github.com/tobobo","followers_url":"https://api.github.com/users/tobobo/followers","following_url":"https://api.github.com/users/tobobo/following{/other_user}","gists_url":"https://api.github.com/users/tobobo/gists{/gist_id}","starred_url":"https://api.github.com/users/tobobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobobo/subscriptions","organizations_url":"https://api.github.com/users/tobobo/orgs","repos_url":"https://api.github.com/users/tobobo/repos","events_url":"https://api.github.com/users/tobobo/events{/privacy}","received_events_url":"https://api.github.com/users/tobobo/received_events","type":"User","site_admin":false},"body":"The documentation on `errorPolicy` was incorrect with respect to the way errors are cached. This updates the docs for parity with Apollo's current functionality.\r\n\r\nFixing this so that future developers do not spend too much time trying to figure out why error cacheing isn't working for them.\r\n\r\n<!--\r\n  Thanks for filing a pull request on Apollo Client!\r\n\r\n  A few automated bots may chime in on your PR. They are here to help\r\n  with reviewing and ensuring Apollo Client is production ready after each\r\n  pull request merge.\r\n\r\n    - meteor-bot will respond asking you to sign the CLA if this is your first PR.\r\n      It may also respond with warnings, messages, or fail the build if something is off.\r\n      Don't worry, it'll help you to fix what is broken!\r\n\r\n    - bundlesize is a status check to keep the footprint of Apollo Client as small as possible.\r\n\r\n    - travis-ci will run tests, checking style of code, and generally make\r\n      sure everything is working as expected\r\n\r\n  Please look at the following checklist to ensure that your PR\r\n  can be accepted quickly:\r\n-->","created_at":"2018-12-14T18:53:15Z","updated_at":"2019-01-02T13:08:05Z","closed_at":"2019-01-02T13:08:04Z","merged_at":null,"merge_commit_sha":"0b8c639666b457b2ab3280e1109a296728bc934f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjamn","id":5750,"node_id":"MDQ6VXNlcjU3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},{"login":"hwillson","id":137740,"node_id":"MDQ6VXNlcjEzNzc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/137740?v=4","gravatar_id":"","url":"https://api.github.com/users/hwillson","html_url":"https://github.com/hwillson","followers_url":"https://api.github.com/users/hwillson/followers","following_url":"https://api.github.com/users/hwillson/following{/other_user}","gists_url":"https://api.github.com/users/hwillson/gists{/gist_id}","starred_url":"https://api.github.com/users/hwillson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwillson/subscriptions","organizations_url":"https://api.github.com/users/hwillson/orgs","repos_url":"https://api.github.com/users/hwillson/repos","events_url":"https://api.github.com/users/hwillson/events{/privacy}","received_events_url":"https://api.github.com/users/hwillson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/4237/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/141f459c9cf8474f5f85ab19015b36ec99bb66c1","head":{"label":"tobobo:patch-1","ref":"patch-1","sha":"141f459c9cf8474f5f85ab19015b36ec99bb66c1","user":{"login":"tobobo","id":796548,"node_id":"MDQ6VXNlcjc5NjU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/796548?v=4","gravatar_id":"","url":"https://api.github.com/users/tobobo","html_url":"https://github.com/tobobo","followers_url":"https://api.github.com/users/tobobo/followers","following_url":"https://api.github.com/users/tobobo/following{/other_user}","gists_url":"https://api.github.com/users/tobobo/gists{/gist_id}","starred_url":"https://api.github.com/users/tobobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobobo/subscriptions","organizations_url":"https://api.github.com/users/tobobo/orgs","repos_url":"https://api.github.com/users/tobobo/repos","events_url":"https://api.github.com/users/tobobo/events{/privacy}","received_events_url":"https://api.github.com/users/tobobo/received_events","type":"User","site_admin":false},"repo":{"id":161827188,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MjcxODg=","name":"apollo-client","full_name":"tobobo/apollo-client","private":false,"owner":{"login":"tobobo","id":796548,"node_id":"MDQ6VXNlcjc5NjU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/796548?v=4","gravatar_id":"","url":"https://api.github.com/users/tobobo","html_url":"https://github.com/tobobo","followers_url":"https://api.github.com/users/tobobo/followers","following_url":"https://api.github.com/users/tobobo/following{/other_user}","gists_url":"https://api.github.com/users/tobobo/gists{/gist_id}","starred_url":"https://api.github.com/users/tobobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobobo/subscriptions","organizations_url":"https://api.github.com/users/tobobo/orgs","repos_url":"https://api.github.com/users/tobobo/repos","events_url":"https://api.github.com/users/tobobo/events{/privacy}","received_events_url":"https://api.github.com/users/tobobo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tobobo/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":true,"url":"https://api.github.com/repos/tobobo/apollo-client","forks_url":"https://api.github.com/repos/tobobo/apollo-client/forks","keys_url":"https://api.github.com/repos/tobobo/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobobo/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobobo/apollo-client/teams","hooks_url":"https://api.github.com/repos/tobobo/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/tobobo/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/tobobo/apollo-client/events","assignees_url":"https://api.github.com/repos/tobobo/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/tobobo/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/tobobo/apollo-client/tags","blobs_url":"https://api.github.com/repos/tobobo/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobobo/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobobo/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobobo/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobobo/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/tobobo/apollo-client/languages","stargazers_url":"https://api.github.com/repos/tobobo/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/tobobo/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/tobobo/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/tobobo/apollo-client/subscription","commits_url":"https://api.github.com/repos/tobobo/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobobo/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobobo/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobobo/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobobo/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/tobobo/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobobo/apollo-client/merges","archive_url":"https://api.github.com/repos/tobobo/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobobo/apollo-client/downloads","issues_url":"https://api.github.com/repos/tobobo/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/tobobo/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/tobobo/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/tobobo/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobobo/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/tobobo/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/tobobo/apollo-client/deployments","created_at":"2018-12-14T18:46:58Z","updated_at":"2018-12-14T18:47:02Z","pushed_at":"2018-12-14T18:52:26Z","git_url":"git://github.com/tobobo/apollo-client.git","ssh_url":"git@github.com:tobobo/apollo-client.git","clone_url":"https://github.com/tobobo/apollo-client.git","svn_url":"https://github.com/tobobo/apollo-client","homepage":"http://dev.apollodata.com/","size":12968,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"701ab756e0fdef325331bdcbd1495a0d189fab1d","user":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":52630616,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYzMDYxNg==","name":"apollo-client","full_name":"apollographql/apollo-client","private":false,"owner":{"login":"apollographql","id":17189275,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTg5Mjc1","avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apollographql/apollo-client","description":":rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-client","forks_url":"https://api.github.com/repos/apollographql/apollo-client/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-client/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-client/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-client/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-client/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-client/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-client/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-client/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-client/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-client/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-client/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-client/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-client/deployments","created_at":"2016-02-26T20:25:00Z","updated_at":"2019-01-02T13:03:32Z","pushed_at":"2019-01-02T13:05:53Z","git_url":"git://github.com/apollographql/apollo-client.git","ssh_url":"git@github.com:apollographql/apollo-client.git","clone_url":"https://github.com/apollographql/apollo-client.git","svn_url":"https://github.com/apollographql/apollo-client","homepage":"http://dev.apollodata.com/","size":13458,"stargazers_count":9568,"watchers_count":9568,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1085,"mirror_url":null,"archived":false,"open_issues_count":272,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1085,"open_issues":272,"watchers":9568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237"},"html":{"href":"https://github.com/apollographql/apollo-client/pull/4237"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4237"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/issues/4237/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-client/pulls/4237/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-client/statuses/141f459c9cf8474f5f85ab19015b36ec99bb66c1"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"hwillson"}}