{"action":"created","comment":{"url":"https://api.github.com/repos/diffplug/spotless/pulls/comments/216483917","pull_request_review_id":153976656,"id":216483917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ4MzkxNw==","diff_hunk":"@@ -53,10 +56,18 @@ public ArtifactResolver(RepositorySystem repositorySystem, RepositorySystemSessi\n \t\tthis.log = Objects.requireNonNull(log);\n \t}\n \n+\t/** Use {@link ArtifactResolver#resolve(Collection) instead.} */\n+\t@Deprecated\n \tpublic Set<File> resolve(String mavenCoordinate) {","path":"plugin-maven/src/main/java/com/diffplug/spotless/maven/ArtifactResolver.java","position":19,"original_position":19,"commit_id":"41d7f2d7baef1eebd0ac82aff6d7bdddc0f98d35","original_commit_id":"15de0b2108922285ff67cec72377dc90811f4a42","user":{"login":"nedtwigg","id":2924992,"node_id":"MDQ6VXNlcjI5MjQ5OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2924992?v=4","gravatar_id":"","url":"https://api.github.com/users/nedtwigg","html_url":"https://github.com/nedtwigg","followers_url":"https://api.github.com/users/nedtwigg/followers","following_url":"https://api.github.com/users/nedtwigg/following{/other_user}","gists_url":"https://api.github.com/users/nedtwigg/gists{/gist_id}","starred_url":"https://api.github.com/users/nedtwigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedtwigg/subscriptions","organizations_url":"https://api.github.com/users/nedtwigg/orgs","repos_url":"https://api.github.com/users/nedtwigg/repos","events_url":"https://api.github.com/users/nedtwigg/events{/privacy}","received_events_url":"https://api.github.com/users/nedtwigg/received_events","type":"User","site_admin":false},"body":"Because gradle scripts are programs, any public method in `lib`, `lib-extra`, or `plugin-gradle` might reasonably be called by somebody's build script, which is why I'm a stickler for those projects.  For `plugin-maven`, we can probably get away with being more loose, but when it's easy to keep back-compat, I think it's best to do so.  Just a good habit to be in for a project that aspires to help lots of people but cause few headaches.","created_at":"2018-09-10T21:47:50Z","updated_at":"2018-09-10T21:47:50Z","html_url":"https://github.com/diffplug/spotless/pull/296#discussion_r216483917","pull_request_url":"https://api.github.com/repos/diffplug/spotless/pulls/296","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/comments/216483917"},"html":{"href":"https://github.com/diffplug/spotless/pull/296#discussion_r216483917"},"pull_request":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/296"}},"in_reply_to_id":216252088},"pull_request":{"url":"https://api.github.com/repos/diffplug/spotless/pulls/296","id":214095234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDk1MjM0","html_url":"https://github.com/diffplug/spotless/pull/296","diff_url":"https://github.com/diffplug/spotless/pull/296.diff","patch_url":"https://github.com/diffplug/spotless/pull/296.patch","issue_url":"https://api.github.com/repos/diffplug/spotless/issues/296","number":296,"state":"open","locked":false,"title":"Using Maven dependency mediation","user":{"login":"fvgh","id":10271755,"node_id":"MDQ6VXNlcjEwMjcxNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10271755?v=4","gravatar_id":"","url":"https://api.github.com/users/fvgh","html_url":"https://github.com/fvgh","followers_url":"https://api.github.com/users/fvgh/followers","following_url":"https://api.github.com/users/fvgh/following{/other_user}","gists_url":"https://api.github.com/users/fvgh/gists{/gist_id}","starred_url":"https://api.github.com/users/fvgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvgh/subscriptions","organizations_url":"https://api.github.com/users/fvgh/orgs","repos_url":"https://api.github.com/users/fvgh/repos","events_url":"https://api.github.com/users/fvgh/events{/privacy}","received_events_url":"https://api.github.com/users/fvgh/received_events","type":"User","site_admin":false},"body":"Currently Spotless uses 2 kinds of dependencies:\r\n\r\n- Resolved dependency list without any transitives (not fully implemented yet)\r\n- Single (\"root\") dependencies\r\n\r\nThe `Provisioner` interface supports \"dependency lists\" (currently always resolving transitives).\r\nThe previous  `MavenProvisioner` implementation took individually each dependency as a root dependency, resolves it (and its transitives) and puts the JARs into a hash set.\r\n\r\nThere had been quite an evolution how Maven resolves transitives. Please refer to the [Transitive Dependencies documentation](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Transitive_Dependencies) for details.\r\n\r\nThe whole issue is NOT affecting the current formatters (due to the simple dependency structure of current formatters). However, the `maven-plugin` `Provisioner` should not interfere with the dependency resolution of `Maven` to avoid bugs in future evolution of `Spotless`.","created_at":"2018-09-08T13:21:52Z","updated_at":"2018-09-10T21:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6836d9f92325386dc36b0de661aefc29007f18c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffplug/spotless/pulls/296/commits","review_comments_url":"https://api.github.com/repos/diffplug/spotless/pulls/296/comments","review_comment_url":"https://api.github.com/repos/diffplug/spotless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffplug/spotless/issues/296/comments","statuses_url":"https://api.github.com/repos/diffplug/spotless/statuses/41d7f2d7baef1eebd0ac82aff6d7bdddc0f98d35","head":{"label":"diffplug:deterministic_mvn_dependencies","ref":"deterministic_mvn_dependencies","sha":"41d7f2d7baef1eebd0ac82aff6d7bdddc0f98d35","user":{"login":"diffplug","id":6572898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzI4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"repo":{"id":34685800,"node_id":"MDEwOlJlcG9zaXRvcnkzNDY4NTgwMA==","name":"spotless","full_name":"diffplug/spotless","owner":{"login":"diffplug","id":6572898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzI4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffplug/spotless","description":"Keep your code spotless","fork":false,"url":"https://api.github.com/repos/diffplug/spotless","forks_url":"https://api.github.com/repos/diffplug/spotless/forks","keys_url":"https://api.github.com/repos/diffplug/spotless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffplug/spotless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffplug/spotless/teams","hooks_url":"https://api.github.com/repos/diffplug/spotless/hooks","issue_events_url":"https://api.github.com/repos/diffplug/spotless/issues/events{/number}","events_url":"https://api.github.com/repos/diffplug/spotless/events","assignees_url":"https://api.github.com/repos/diffplug/spotless/assignees{/user}","branches_url":"https://api.github.com/repos/diffplug/spotless/branches{/branch}","tags_url":"https://api.github.com/repos/diffplug/spotless/tags","blobs_url":"https://api.github.com/repos/diffplug/spotless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffplug/spotless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffplug/spotless/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffplug/spotless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffplug/spotless/statuses/{sha}","languages_url":"https://api.github.com/repos/diffplug/spotless/languages","stargazers_url":"https://api.github.com/repos/diffplug/spotless/stargazers","contributors_url":"https://api.github.com/repos/diffplug/spotless/contributors","subscribers_url":"https://api.github.com/repos/diffplug/spotless/subscribers","subscription_url":"https://api.github.com/repos/diffplug/spotless/subscription","commits_url":"https://api.github.com/repos/diffplug/spotless/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffplug/spotless/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffplug/spotless/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffplug/spotless/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffplug/spotless/contents/{+path}","compare_url":"https://api.github.com/repos/diffplug/spotless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffplug/spotless/merges","archive_url":"https://api.github.com/repos/diffplug/spotless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffplug/spotless/downloads","issues_url":"https://api.github.com/repos/diffplug/spotless/issues{/number}","pulls_url":"https://api.github.com/repos/diffplug/spotless/pulls{/number}","milestones_url":"https://api.github.com/repos/diffplug/spotless/milestones{/number}","notifications_url":"https://api.github.com/repos/diffplug/spotless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffplug/spotless/labels{/name}","releases_url":"https://api.github.com/repos/diffplug/spotless/releases{/id}","deployments_url":"https://api.github.com/repos/diffplug/spotless/deployments","created_at":"2015-04-27T19:10:58Z","updated_at":"2018-09-10T12:57:50Z","pushed_at":"2018-09-10T18:25:51Z","git_url":"git://github.com/diffplug/spotless.git","ssh_url":"git@github.com:diffplug/spotless.git","clone_url":"https://github.com/diffplug/spotless.git","svn_url":"https://github.com/diffplug/spotless","homepage":"","size":19902,"stargazers_count":410,"watchers_count":410,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":59,"open_issues":37,"watchers":410,"default_branch":"master"}},"base":{"label":"diffplug:master","ref":"master","sha":"9b2f3e3dc66e6515b01cfb6fdd31e3c7c517b113","user":{"login":"diffplug","id":6572898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzI4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"repo":{"id":34685800,"node_id":"MDEwOlJlcG9zaXRvcnkzNDY4NTgwMA==","name":"spotless","full_name":"diffplug/spotless","owner":{"login":"diffplug","id":6572898,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzI4OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6572898?v=4","gravatar_id":"","url":"https://api.github.com/users/diffplug","html_url":"https://github.com/diffplug","followers_url":"https://api.github.com/users/diffplug/followers","following_url":"https://api.github.com/users/diffplug/following{/other_user}","gists_url":"https://api.github.com/users/diffplug/gists{/gist_id}","starred_url":"https://api.github.com/users/diffplug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffplug/subscriptions","organizations_url":"https://api.github.com/users/diffplug/orgs","repos_url":"https://api.github.com/users/diffplug/repos","events_url":"https://api.github.com/users/diffplug/events{/privacy}","received_events_url":"https://api.github.com/users/diffplug/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffplug/spotless","description":"Keep your code spotless","fork":false,"url":"https://api.github.com/repos/diffplug/spotless","forks_url":"https://api.github.com/repos/diffplug/spotless/forks","keys_url":"https://api.github.com/repos/diffplug/spotless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffplug/spotless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffplug/spotless/teams","hooks_url":"https://api.github.com/repos/diffplug/spotless/hooks","issue_events_url":"https://api.github.com/repos/diffplug/spotless/issues/events{/number}","events_url":"https://api.github.com/repos/diffplug/spotless/events","assignees_url":"https://api.github.com/repos/diffplug/spotless/assignees{/user}","branches_url":"https://api.github.com/repos/diffplug/spotless/branches{/branch}","tags_url":"https://api.github.com/repos/diffplug/spotless/tags","blobs_url":"https://api.github.com/repos/diffplug/spotless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffplug/spotless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffplug/spotless/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffplug/spotless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffplug/spotless/statuses/{sha}","languages_url":"https://api.github.com/repos/diffplug/spotless/languages","stargazers_url":"https://api.github.com/repos/diffplug/spotless/stargazers","contributors_url":"https://api.github.com/repos/diffplug/spotless/contributors","subscribers_url":"https://api.github.com/repos/diffplug/spotless/subscribers","subscription_url":"https://api.github.com/repos/diffplug/spotless/subscription","commits_url":"https://api.github.com/repos/diffplug/spotless/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffplug/spotless/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffplug/spotless/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffplug/spotless/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffplug/spotless/contents/{+path}","compare_url":"https://api.github.com/repos/diffplug/spotless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffplug/spotless/merges","archive_url":"https://api.github.com/repos/diffplug/spotless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffplug/spotless/downloads","issues_url":"https://api.github.com/repos/diffplug/spotless/issues{/number}","pulls_url":"https://api.github.com/repos/diffplug/spotless/pulls{/number}","milestones_url":"https://api.github.com/repos/diffplug/spotless/milestones{/number}","notifications_url":"https://api.github.com/repos/diffplug/spotless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffplug/spotless/labels{/name}","releases_url":"https://api.github.com/repos/diffplug/spotless/releases{/id}","deployments_url":"https://api.github.com/repos/diffplug/spotless/deployments","created_at":"2015-04-27T19:10:58Z","updated_at":"2018-09-10T12:57:50Z","pushed_at":"2018-09-10T18:25:51Z","git_url":"git://github.com/diffplug/spotless.git","ssh_url":"git@github.com:diffplug/spotless.git","clone_url":"https://github.com/diffplug/spotless.git","svn_url":"https://github.com/diffplug/spotless","homepage":"","size":19902,"stargazers_count":410,"watchers_count":410,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":59,"open_issues":37,"watchers":410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/296"},"html":{"href":"https://github.com/diffplug/spotless/pull/296"},"issue":{"href":"https://api.github.com/repos/diffplug/spotless/issues/296"},"comments":{"href":"https://api.github.com/repos/diffplug/spotless/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffplug/spotless/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/diffplug/spotless/statuses/41d7f2d7baef1eebd0ac82aff6d7bdddc0f98d35"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nedtwigg"}}