{"action":"created","issue":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/1288","repository_url":"https://api.github.com/repos/apache/bookkeeper","labels_url":"https://api.github.com/repos/apache/bookkeeper/issues/1288/labels{/name}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1288/comments","events_url":"https://api.github.com/repos/apache/bookkeeper/issues/1288/events","html_url":"https://github.com/apache/bookkeeper/pull/1288","id":308144995,"number":1288,"title":"Add sync variants of all methods in handles","user":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"assignees":[{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-23T18:59:30Z","updated_at":"2018-03-24T21:43:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1288","html_url":"https://github.com/apache/bookkeeper/pull/1288","diff_url":"https://github.com/apache/bookkeeper/pull/1288.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1288.patch"},"body":"As discussed on the mailing list [1], this patch removes the\r\ninconsistency around the naming of the close call on the new handle\r\nAPIs, by creating sync versions of each async calls, and renaming the\r\nasync versions to have the suffix \"Async\".\r\n\r\nMost of the changes are very mechanical - just a copy of the old\r\nmethod and some small fixups the javadoc. One thing to note is that\r\nI've made a copy of the close and closeAsync methods in the\r\nWriteHandle interface, so that the ReadHandle and Handle javadoc for\r\nthese methods do not have to talk about what it means to close/seal a\r\nledger.\r\n\r\nAnother change is that I've removed the SneakyThrows from close, that\r\nwould have also been needed on the other sync methods. Instead, I pass a\r\nexception handler to FutureUtils which generates a BKException.\r\n\r\n[1] https://lists.apache.org/thread.html/c3784cffb949438510d21e5eac8c0351865c6748c42c380e673a60db@%3Cdev.bookkeeper.apache.org%3E\r\n"},"comment":{"url":"https://api.github.com/repos/apache/bookkeeper/issues/comments/375927015","html_url":"https://github.com/apache/bookkeeper/pull/1288#issuecomment-375927015","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1288","id":375927015,"user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T21:43:12Z","updated_at":"2018-03-24T21:43:12Z","author_association":"CONTRIBUTOR","body":"@ivankelly you need to fix some tests."}}
{"actor":{"display_login":"sijie"}}