{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/19922","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/19922/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19922/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/19922/events","html_url":"https://github.com/guardian/frontend/pull/19922","id":336215724,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzIxODIz","number":19922,"title":"Always get blocks for articles from CAPI","user":{"login":"MatthewJWalls","id":1218561,"node_id":"MDQ6VXNlcjEyMTg1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1218561?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewJWalls","html_url":"https://github.com/MatthewJWalls","followers_url":"https://api.github.com/users/MatthewJWalls/followers","following_url":"https://api.github.com/users/MatthewJWalls/following{/other_user}","gists_url":"https://api.github.com/users/MatthewJWalls/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewJWalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewJWalls/subscriptions","organizations_url":"https://api.github.com/users/MatthewJWalls/orgs","repos_url":"https://api.github.com/users/MatthewJWalls/repos","events_url":"https://api.github.com/users/MatthewJWalls/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewJWalls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-27T12:50:35Z","updated_at":"2018-06-27T14:51:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19922","html_url":"https://github.com/guardian/frontend/pull/19922","diff_url":"https://github.com/guardian/frontend/pull/19922.diff","patch_url":"https://github.com/guardian/frontend/pull/19922.patch"},"body":"## What does this change?\r\n\r\nMake sure we always get blocks for articles in the capi model, so the render tier picker can function properly.\r\n\r\nThis shouldn't change the behaviour of the existing article since we're not processing the blocks anyway. Liveblogs *do* process blocks, but they are handled differently. \r\n\r\nThere is a chance this might mean we get marginally more data going across the wire from capi so I'll keep an eye on our performance metrics. We should see any difference in render time reflected in the rendering time cloudwatch metrics.\r\n\r\nI also wrapped hasOnlySupportedElements in a check to make sure there are blocks before processing them just in case this function is ever called directly.\r\n\r\n## Screenshots\r\n\r\n## What is the value of this and can you measure success?\r\n\r\n## Checklist\r\n\r\n### Does this affect other platforms?\r\n\r\n- [ ] AMP <!-- AMP question? https://git.io/v9zIE -->\r\n- [ ] Apps\r\n- [ ] Other (please specify)\r\n\r\n### Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\n\r\n<!-- if there are versions of this content with the paid styling (teal and grey) then they will need to be checked -->\r\n<!-- content can be found here: https://www.theguardian.com/tone/advertisement-features -->\r\n\r\n- [ ] No\r\n- [ ] Yes (please give details)\r\n\r\n### Accessibility test checklist\r\n\r\n<!-- for changes that affect how a page appears in the browser -->\r\n\r\n- [ ] [Tested with screen reader](https://accessibility.gutools.co.uk/testing/web/screen-readers/)\r\n- [ ] [Navigable with keyboard](https://accessibility.gutools.co.uk/testing/web/keyboard-navigation/)\r\n- [ ] [Colour contrast passed](https://accessibility.gutools.co.uk/testing/web/colour-contrast/)\r\n\r\n### Tested\r\n\r\n- [ ] Locally\r\n- [ ] On CODE (optional)\r\n\r\n<!-- AB test? https://git.io/v1V0x -->\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/400701367","html_url":"https://github.com/guardian/frontend/pull/19922#issuecomment-400701367","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19922","id":400701367,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDcwMTM2Nw==","user":{"login":"MatthewJWalls","id":1218561,"node_id":"MDQ6VXNlcjEyMTg1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1218561?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewJWalls","html_url":"https://github.com/MatthewJWalls","followers_url":"https://api.github.com/users/MatthewJWalls/followers","following_url":"https://api.github.com/users/MatthewJWalls/following{/other_user}","gists_url":"https://api.github.com/users/MatthewJWalls/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewJWalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewJWalls/subscriptions","organizations_url":"https://api.github.com/users/MatthewJWalls/orgs","repos_url":"https://api.github.com/users/MatthewJWalls/repos","events_url":"https://api.github.com/users/MatthewJWalls/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewJWalls/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T14:51:31Z","updated_at":"2018-06-27T14:51:31Z","author_association":"CONTRIBUTOR","body":"I've brushed up against a problem with the articleController with this change. \r\n\r\nIt's a bit spaghetti but basically our logic for controlling liveblog rendering is tied up with the presence of blocks (in a way that I don't think it should be). Passing through blocks in every case upsets that logic."}}
{"actor":{"display_login":"MatthewJWalls"}}