{"action":"created","issue":{"url":"https://api.github.com/repos/choria-io/go-security/issues/22","repository_url":"https://api.github.com/repos/choria-io/go-security","labels_url":"https://api.github.com/repos/choria-io/go-security/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/choria-io/go-security/issues/22/comments","events_url":"https://api.github.com/repos/choria-io/go-security/issues/22/events","html_url":"https://github.com/choria-io/go-security/issues/22","id":382999232,"node_id":"MDU6SXNzdWUzODI5OTkyMzI=","number":22,"title":"support regex enclosed in slashes for certname_whitelist config","user":{"login":"rjd1","id":13651417,"node_id":"MDQ6VXNlcjEzNjUxNDE3","avatar_url":"https://avatars2.githubusercontent.com/u/13651417?v=4","gravatar_id":"","url":"https://api.github.com/users/rjd1","html_url":"https://github.com/rjd1","followers_url":"https://api.github.com/users/rjd1/followers","following_url":"https://api.github.com/users/rjd1/following{/other_user}","gists_url":"https://api.github.com/users/rjd1/gists{/gist_id}","starred_url":"https://api.github.com/users/rjd1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjd1/subscriptions","organizations_url":"https://api.github.com/users/rjd1/orgs","repos_url":"https://api.github.com/users/rjd1/repos","events_url":"https://api.github.com/users/rjd1/events{/privacy}","received_events_url":"https://api.github.com/users/rjd1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-20T10:28:47Z","updated_at":"2018-11-21T08:07:58Z","closed_at":null,"author_association":"NONE","body":"To maintain consistency with mcollectived config, the regex string for this option should work with or without surrounding forward slashes. E.g.: \r\n\r\n`plugin.choria.security.certname_whitelist = /\\.mcollective$/, /\\.mco$/`\r\n\r\nor\r\n\r\n`plugin.choria.security.certname_whitelist = \\.mcollective$, \\.mco$`\r\n\r\nCurrently only the latter works. "},"comment":{"url":"https://api.github.com/repos/choria-io/go-security/issues/comments/440573020","html_url":"https://github.com/choria-io/go-security/issues/22#issuecomment-440573020","issue_url":"https://api.github.com/repos/choria-io/go-security/issues/22","id":440573020,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDU3MzAyMA==","user":{"login":"ripienaar","id":82342,"node_id":"MDQ6VXNlcjgyMzQy","avatar_url":"https://avatars0.githubusercontent.com/u/82342?v=4","gravatar_id":"","url":"https://api.github.com/users/ripienaar","html_url":"https://github.com/ripienaar","followers_url":"https://api.github.com/users/ripienaar/followers","following_url":"https://api.github.com/users/ripienaar/following{/other_user}","gists_url":"https://api.github.com/users/ripienaar/gists{/gist_id}","starred_url":"https://api.github.com/users/ripienaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripienaar/subscriptions","organizations_url":"https://api.github.com/users/ripienaar/orgs","repos_url":"https://api.github.com/users/ripienaar/repos","events_url":"https://api.github.com/users/ripienaar/events{/privacy}","received_events_url":"https://api.github.com/users/ripienaar/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T08:07:58Z","updated_at":"2018-11-21T08:07:58Z","author_association":"MEMBER","body":"Need to expand this code:\r\n\r\nhttps://github.com/choria-io/go-security/blob/9c90c6ebc9548a8300fff479716bad9c739d6717/filesec/util.go#L10\r\n\r\nto be more like this code:\r\n\r\nhttps://github.com/choria-io/mcollective-choria/blob/13db0c473d6fc91218db5d1d49f75d61bfb833f3/lib/mcollective/security/choria.rb#L281"}}
{"actor":{"display_login":"ripienaar"}}