{"action":"created","comment":{"url":"https://api.github.com/repos/effil/effil/pulls/comments/226955374","pull_request_review_id":166885056,"id":226955374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk1NTM3NA==","diff_hunk":"@@ -280,7 +280,8 @@ SharedTable SharedTable::luaSetMetatable(const sol::stack_object& tbl, const sol\n         stable.ctx_->metatable = GCNull;\n     }\n \n-    stable.ctx_->metatable = createStoredObject(mt)->gcHandle();\n+    const auto mtObj = createStoredObject(mt);","path":"src/cpp/shared-table.cpp","position":5,"original_position":5,"commit_id":"f0ce6d1ddbec476b47b8bad1129bf84e60909605","original_commit_id":"f0ce6d1ddbec476b47b8bad1129bf84e60909605","user":{"login":"mihacooper","id":5420190,"node_id":"MDQ6VXNlcjU0MjAxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5420190?v=4","gravatar_id":"","url":"https://api.github.com/users/mihacooper","html_url":"https://github.com/mihacooper","followers_url":"https://api.github.com/users/mihacooper/followers","following_url":"https://api.github.com/users/mihacooper/following{/other_user}","gists_url":"https://api.github.com/users/mihacooper/gists{/gist_id}","starred_url":"https://api.github.com/users/mihacooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihacooper/subscriptions","organizations_url":"https://api.github.com/users/mihacooper/orgs","repos_url":"https://api.github.com/users/mihacooper/repos","events_url":"https://api.github.com/users/mihacooper/events{/privacy}","received_events_url":"https://api.github.com/users/mihacooper/received_events","type":"User","site_admin":false},"body":"returned stored object could be destroyed by GC before we add it using `addReference`","created_at":"2018-10-22T10:47:19Z","updated_at":"2018-10-22T10:47:22Z","html_url":"https://github.com/effil/effil/pull/113#discussion_r226955374","pull_request_url":"https://api.github.com/repos/effil/effil/pulls/113","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/effil/effil/pulls/comments/226955374"},"html":{"href":"https://github.com/effil/effil/pull/113#discussion_r226955374"},"pull_request":{"href":"https://api.github.com/repos/effil/effil/pulls/113"}},"in_reply_to_id":226876917},"pull_request":{"url":"https://api.github.com/repos/effil/effil/pulls/113","id":224231325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjMxMzI1","html_url":"https://github.com/effil/effil/pull/113","diff_url":"https://github.com/effil/effil/pull/113.diff","patch_url":"https://github.com/effil/effil/pull/113.patch","issue_url":"https://api.github.com/repos/effil/effil/issues/113","number":113,"state":"open","locked":false,"title":"Fix race condition in SharedTable","user":{"login":"mihacooper","id":5420190,"node_id":"MDQ6VXNlcjU0MjAxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5420190?v=4","gravatar_id":"","url":"https://api.github.com/users/mihacooper","html_url":"https://github.com/mihacooper","followers_url":"https://api.github.com/users/mihacooper/followers","following_url":"https://api.github.com/users/mihacooper/following{/other_user}","gists_url":"https://api.github.com/users/mihacooper/gists{/gist_id}","starred_url":"https://api.github.com/users/mihacooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihacooper/subscriptions","organizations_url":"https://api.github.com/users/mihacooper/orgs","repos_url":"https://api.github.com/users/mihacooper/repos","events_url":"https://api.github.com/users/mihacooper/events{/privacy}","received_events_url":"https://api.github.com/users/mihacooper/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-19T09:54:30Z","updated_at":"2018-10-22T10:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e7632f3a34e200cfbebb29d287fec1f3a09f22f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/effil/effil/milestones/3","html_url":"https://github.com/effil/effil/milestone/3","labels_url":"https://api.github.com/repos/effil/effil/milestones/3/labels","id":2808629,"node_id":"MDk6TWlsZXN0b25lMjgwODYyOQ==","number":3,"title":"v1.1-0","description":"","creator":{"login":"mihacooper","id":5420190,"node_id":"MDQ6VXNlcjU0MjAxOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5420190?v=4","gravatar_id":"","url":"https://api.github.com/users/mihacooper","html_url":"https://github.com/mihacooper","followers_url":"https://api.github.com/users/mihacooper/followers","following_url":"https://api.github.com/users/mihacooper/following{/other_user}","gists_url":"https://api.github.com/users/mihacooper/gists{/gist_id}","starred_url":"https://api.github.com/users/mihacooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihacooper/subscriptions","organizations_url":"https://api.github.com/users/mihacooper/orgs","repos_url":"https://api.github.com/users/mihacooper/repos","events_url":"https://api.github.com/users/mihacooper/events{/privacy}","received_events_url":"https://api.github.com/users/mihacooper/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":13,"state":"open","created_at":"2017-10-02T21:38:24Z","updated_at":"2018-10-19T11:38:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/effil/effil/pulls/113/commits","review_comments_url":"https://api.github.com/repos/effil/effil/pulls/113/comments","review_comment_url":"https://api.github.com/repos/effil/effil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/effil/effil/issues/113/comments","statuses_url":"https://api.github.com/repos/effil/effil/statuses/f0ce6d1ddbec476b47b8bad1129bf84e60909605","head":{"label":"effil:fix_race_in_table","ref":"fix_race_in_table","sha":"f0ce6d1ddbec476b47b8bad1129bf84e60909605","user":{"login":"effil","id":25184673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTg0Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/25184673?v=4","gravatar_id":"","url":"https://api.github.com/users/effil","html_url":"https://github.com/effil","followers_url":"https://api.github.com/users/effil/followers","following_url":"https://api.github.com/users/effil/following{/other_user}","gists_url":"https://api.github.com/users/effil/gists{/gist_id}","starred_url":"https://api.github.com/users/effil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effil/subscriptions","organizations_url":"https://api.github.com/users/effil/orgs","repos_url":"https://api.github.com/users/effil/repos","events_url":"https://api.github.com/users/effil/events{/privacy}","received_events_url":"https://api.github.com/users/effil/received_events","type":"Organization","site_admin":false},"repo":{"id":79269639,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTYzOQ==","name":"effil","full_name":"effil/effil","private":false,"owner":{"login":"effil","id":25184673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTg0Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/25184673?v=4","gravatar_id":"","url":"https://api.github.com/users/effil","html_url":"https://github.com/effil","followers_url":"https://api.github.com/users/effil/followers","following_url":"https://api.github.com/users/effil/following{/other_user}","gists_url":"https://api.github.com/users/effil/gists{/gist_id}","starred_url":"https://api.github.com/users/effil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effil/subscriptions","organizations_url":"https://api.github.com/users/effil/orgs","repos_url":"https://api.github.com/users/effil/repos","events_url":"https://api.github.com/users/effil/events{/privacy}","received_events_url":"https://api.github.com/users/effil/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/effil/effil","description":"Multithreading support for Lua","fork":false,"url":"https://api.github.com/repos/effil/effil","forks_url":"https://api.github.com/repos/effil/effil/forks","keys_url":"https://api.github.com/repos/effil/effil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/effil/effil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/effil/effil/teams","hooks_url":"https://api.github.com/repos/effil/effil/hooks","issue_events_url":"https://api.github.com/repos/effil/effil/issues/events{/number}","events_url":"https://api.github.com/repos/effil/effil/events","assignees_url":"https://api.github.com/repos/effil/effil/assignees{/user}","branches_url":"https://api.github.com/repos/effil/effil/branches{/branch}","tags_url":"https://api.github.com/repos/effil/effil/tags","blobs_url":"https://api.github.com/repos/effil/effil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/effil/effil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/effil/effil/git/refs{/sha}","trees_url":"https://api.github.com/repos/effil/effil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/effil/effil/statuses/{sha}","languages_url":"https://api.github.com/repos/effil/effil/languages","stargazers_url":"https://api.github.com/repos/effil/effil/stargazers","contributors_url":"https://api.github.com/repos/effil/effil/contributors","subscribers_url":"https://api.github.com/repos/effil/effil/subscribers","subscription_url":"https://api.github.com/repos/effil/effil/subscription","commits_url":"https://api.github.com/repos/effil/effil/commits{/sha}","git_commits_url":"https://api.github.com/repos/effil/effil/git/commits{/sha}","comments_url":"https://api.github.com/repos/effil/effil/comments{/number}","issue_comment_url":"https://api.github.com/repos/effil/effil/issues/comments{/number}","contents_url":"https://api.github.com/repos/effil/effil/contents/{+path}","compare_url":"https://api.github.com/repos/effil/effil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/effil/effil/merges","archive_url":"https://api.github.com/repos/effil/effil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/effil/effil/downloads","issues_url":"https://api.github.com/repos/effil/effil/issues{/number}","pulls_url":"https://api.github.com/repos/effil/effil/pulls{/number}","milestones_url":"https://api.github.com/repos/effil/effil/milestones{/number}","notifications_url":"https://api.github.com/repos/effil/effil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/effil/effil/labels{/name}","releases_url":"https://api.github.com/repos/effil/effil/releases{/id}","deployments_url":"https://api.github.com/repos/effil/effil/deployments","created_at":"2017-01-17T20:39:22Z","updated_at":"2018-10-22T03:18:17Z","pushed_at":"2018-10-19T16:31:16Z","git_url":"git://github.com/effil/effil.git","ssh_url":"git@github.com:effil/effil.git","clone_url":"https://github.com/effil/effil.git","svn_url":"https://github.com/effil/effil","homepage":"","size":225,"stargazers_count":141,"watchers_count":141,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":10,"watchers":141,"default_branch":"master"}},"base":{"label":"effil:master","ref":"master","sha":"2e4e219b850df50f8c68cbca81efb17c20629be2","user":{"login":"effil","id":25184673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTg0Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/25184673?v=4","gravatar_id":"","url":"https://api.github.com/users/effil","html_url":"https://github.com/effil","followers_url":"https://api.github.com/users/effil/followers","following_url":"https://api.github.com/users/effil/following{/other_user}","gists_url":"https://api.github.com/users/effil/gists{/gist_id}","starred_url":"https://api.github.com/users/effil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effil/subscriptions","organizations_url":"https://api.github.com/users/effil/orgs","repos_url":"https://api.github.com/users/effil/repos","events_url":"https://api.github.com/users/effil/events{/privacy}","received_events_url":"https://api.github.com/users/effil/received_events","type":"Organization","site_admin":false},"repo":{"id":79269639,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTYzOQ==","name":"effil","full_name":"effil/effil","private":false,"owner":{"login":"effil","id":25184673,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTg0Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/25184673?v=4","gravatar_id":"","url":"https://api.github.com/users/effil","html_url":"https://github.com/effil","followers_url":"https://api.github.com/users/effil/followers","following_url":"https://api.github.com/users/effil/following{/other_user}","gists_url":"https://api.github.com/users/effil/gists{/gist_id}","starred_url":"https://api.github.com/users/effil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/effil/subscriptions","organizations_url":"https://api.github.com/users/effil/orgs","repos_url":"https://api.github.com/users/effil/repos","events_url":"https://api.github.com/users/effil/events{/privacy}","received_events_url":"https://api.github.com/users/effil/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/effil/effil","description":"Multithreading support for Lua","fork":false,"url":"https://api.github.com/repos/effil/effil","forks_url":"https://api.github.com/repos/effil/effil/forks","keys_url":"https://api.github.com/repos/effil/effil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/effil/effil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/effil/effil/teams","hooks_url":"https://api.github.com/repos/effil/effil/hooks","issue_events_url":"https://api.github.com/repos/effil/effil/issues/events{/number}","events_url":"https://api.github.com/repos/effil/effil/events","assignees_url":"https://api.github.com/repos/effil/effil/assignees{/user}","branches_url":"https://api.github.com/repos/effil/effil/branches{/branch}","tags_url":"https://api.github.com/repos/effil/effil/tags","blobs_url":"https://api.github.com/repos/effil/effil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/effil/effil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/effil/effil/git/refs{/sha}","trees_url":"https://api.github.com/repos/effil/effil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/effil/effil/statuses/{sha}","languages_url":"https://api.github.com/repos/effil/effil/languages","stargazers_url":"https://api.github.com/repos/effil/effil/stargazers","contributors_url":"https://api.github.com/repos/effil/effil/contributors","subscribers_url":"https://api.github.com/repos/effil/effil/subscribers","subscription_url":"https://api.github.com/repos/effil/effil/subscription","commits_url":"https://api.github.com/repos/effil/effil/commits{/sha}","git_commits_url":"https://api.github.com/repos/effil/effil/git/commits{/sha}","comments_url":"https://api.github.com/repos/effil/effil/comments{/number}","issue_comment_url":"https://api.github.com/repos/effil/effil/issues/comments{/number}","contents_url":"https://api.github.com/repos/effil/effil/contents/{+path}","compare_url":"https://api.github.com/repos/effil/effil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/effil/effil/merges","archive_url":"https://api.github.com/repos/effil/effil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/effil/effil/downloads","issues_url":"https://api.github.com/repos/effil/effil/issues{/number}","pulls_url":"https://api.github.com/repos/effil/effil/pulls{/number}","milestones_url":"https://api.github.com/repos/effil/effil/milestones{/number}","notifications_url":"https://api.github.com/repos/effil/effil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/effil/effil/labels{/name}","releases_url":"https://api.github.com/repos/effil/effil/releases{/id}","deployments_url":"https://api.github.com/repos/effil/effil/deployments","created_at":"2017-01-17T20:39:22Z","updated_at":"2018-10-22T03:18:17Z","pushed_at":"2018-10-19T16:31:16Z","git_url":"git://github.com/effil/effil.git","ssh_url":"git@github.com:effil/effil.git","clone_url":"https://github.com/effil/effil.git","svn_url":"https://github.com/effil/effil","homepage":"","size":225,"stargazers_count":141,"watchers_count":141,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":10,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/effil/effil/pulls/113"},"html":{"href":"https://github.com/effil/effil/pull/113"},"issue":{"href":"https://api.github.com/repos/effil/effil/issues/113"},"comments":{"href":"https://api.github.com/repos/effil/effil/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/effil/effil/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/effil/effil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/effil/effil/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/effil/effil/statuses/f0ce6d1ddbec476b47b8bad1129bf84e60909605"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mihacooper"}}