{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/199207189","pull_request_review_id":133285586,"id":199207189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTIwNzE4OQ==","diff_hunk":"@@ -39,22 +40,21 @@ static boolean isNullOrEmpty(Statistics stat) {\n    *\n    * @param stat parquet column statistics\n    * @param rowCount number of rows in the parquet file\n-   * @return True if all rows are null in the parquet file\n-   *          False if at least one row is not null.\n+   * @return <tt>true</tt> if all rows are null in the parquet file and <tt>false</tt> otherwise\n    */\n   static boolean isAllNulls(Statistics stat, long rowCount) {\n-    return stat.isNumNullsSet() && stat.getNumNulls() == rowCount;\n+    Preconditions.checkArgument(rowCount >= 0, String.format(\"negative rowCount %d is not valid\", rowCount));","path":"exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHelper.java","position":27,"original_position":27,"commit_id":"9c8ddef49c39b2f125de8cd1c7a526ad1b8eef13","original_commit_id":"9c8ddef49c39b2f125de8cd1c7a526ad1b8eef13","user":{"login":"arina-ielchiieva","id":15086720,"node_id":"MDQ6VXNlcjE1MDg2NzIw","avatar_url":"https://avatars3.githubusercontent.com/u/15086720?v=4","gravatar_id":"","url":"https://api.github.com/users/arina-ielchiieva","html_url":"https://github.com/arina-ielchiieva","followers_url":"https://api.github.com/users/arina-ielchiieva/followers","following_url":"https://api.github.com/users/arina-ielchiieva/following{/other_user}","gists_url":"https://api.github.com/users/arina-ielchiieva/gists{/gist_id}","starred_url":"https://api.github.com/users/arina-ielchiieva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arina-ielchiieva/subscriptions","organizations_url":"https://api.github.com/users/arina-ielchiieva/orgs","repos_url":"https://api.github.com/users/arina-ielchiieva/repos","events_url":"https://api.github.com/users/arina-ielchiieva/events{/privacy}","received_events_url":"https://api.github.com/users/arina-ielchiieva/received_events","type":"User","site_admin":false},"body":"I think this check is not needed here :) Why this method should check what was given to it? It's job just to compare row count and number of nulls.","created_at":"2018-06-29T16:01:35Z","updated_at":"2018-06-29T16:01:35Z","html_url":"https://github.com/apache/drill/pull/1349#discussion_r199207189","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/1349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/199207189"},"html":{"href":"https://github.com/apache/drill/pull/1349#discussion_r199207189"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/1349"}},"in_reply_to_id":199197499},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/1349","id":198153215,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTUzMjE1","html_url":"https://github.com/apache/drill/pull/1349","diff_url":"https://github.com/apache/drill/pull/1349.diff","patch_url":"https://github.com/apache/drill/pull/1349.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/1349","number":1349,"state":"open","locked":false,"title":"DRILL-6554: Minor code improvements in parquet statistics handling","user":{"login":"vrozov","id":12200381,"node_id":"MDQ6VXNlcjEyMjAwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12200381?v=4","gravatar_id":"","url":"https://api.github.com/users/vrozov","html_url":"https://github.com/vrozov","followers_url":"https://api.github.com/users/vrozov/followers","following_url":"https://api.github.com/users/vrozov/following{/other_user}","gists_url":"https://api.github.com/users/vrozov/gists{/gist_id}","starred_url":"https://api.github.com/users/vrozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrozov/subscriptions","organizations_url":"https://api.github.com/users/vrozov/orgs","repos_url":"https://api.github.com/users/vrozov/repos","events_url":"https://api.github.com/users/vrozov/events{/privacy}","received_events_url":"https://api.github.com/users/vrozov/received_events","type":"User","site_admin":false},"body":"@arina-ielchiieva Please review","created_at":"2018-06-28T21:06:02Z","updated_at":"2018-06-29T16:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28e8c18d7ed83e12a8fdc5397518e9cf49f160a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/1349/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/1349/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/1349/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/9c8ddef49c39b2f125de8cd1c7a526ad1b8eef13","head":{"label":"vrozov:DRILL-6554","ref":"DRILL-6554","sha":"9c8ddef49c39b2f125de8cd1c7a526ad1b8eef13","user":{"login":"vrozov","id":12200381,"node_id":"MDQ6VXNlcjEyMjAwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12200381?v=4","gravatar_id":"","url":"https://api.github.com/users/vrozov","html_url":"https://github.com/vrozov","followers_url":"https://api.github.com/users/vrozov/followers","following_url":"https://api.github.com/users/vrozov/following{/other_user}","gists_url":"https://api.github.com/users/vrozov/gists{/gist_id}","starred_url":"https://api.github.com/users/vrozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrozov/subscriptions","organizations_url":"https://api.github.com/users/vrozov/orgs","repos_url":"https://api.github.com/users/vrozov/repos","events_url":"https://api.github.com/users/vrozov/events{/privacy}","received_events_url":"https://api.github.com/users/vrozov/received_events","type":"User","site_admin":false},"repo":{"id":99496680,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQ5NjY4MA==","name":"drill","full_name":"vrozov/drill","owner":{"login":"vrozov","id":12200381,"node_id":"MDQ6VXNlcjEyMjAwMzgx","avatar_url":"https://avatars3.githubusercontent.com/u/12200381?v=4","gravatar_id":"","url":"https://api.github.com/users/vrozov","html_url":"https://github.com/vrozov","followers_url":"https://api.github.com/users/vrozov/followers","following_url":"https://api.github.com/users/vrozov/following{/other_user}","gists_url":"https://api.github.com/users/vrozov/gists{/gist_id}","starred_url":"https://api.github.com/users/vrozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrozov/subscriptions","organizations_url":"https://api.github.com/users/vrozov/orgs","repos_url":"https://api.github.com/users/vrozov/repos","events_url":"https://api.github.com/users/vrozov/events{/privacy}","received_events_url":"https://api.github.com/users/vrozov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrozov/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/vrozov/drill","forks_url":"https://api.github.com/repos/vrozov/drill/forks","keys_url":"https://api.github.com/repos/vrozov/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrozov/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrozov/drill/teams","hooks_url":"https://api.github.com/repos/vrozov/drill/hooks","issue_events_url":"https://api.github.com/repos/vrozov/drill/issues/events{/number}","events_url":"https://api.github.com/repos/vrozov/drill/events","assignees_url":"https://api.github.com/repos/vrozov/drill/assignees{/user}","branches_url":"https://api.github.com/repos/vrozov/drill/branches{/branch}","tags_url":"https://api.github.com/repos/vrozov/drill/tags","blobs_url":"https://api.github.com/repos/vrozov/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrozov/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrozov/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrozov/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrozov/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/vrozov/drill/languages","stargazers_url":"https://api.github.com/repos/vrozov/drill/stargazers","contributors_url":"https://api.github.com/repos/vrozov/drill/contributors","subscribers_url":"https://api.github.com/repos/vrozov/drill/subscribers","subscription_url":"https://api.github.com/repos/vrozov/drill/subscription","commits_url":"https://api.github.com/repos/vrozov/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrozov/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrozov/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrozov/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrozov/drill/contents/{+path}","compare_url":"https://api.github.com/repos/vrozov/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrozov/drill/merges","archive_url":"https://api.github.com/repos/vrozov/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrozov/drill/downloads","issues_url":"https://api.github.com/repos/vrozov/drill/issues{/number}","pulls_url":"https://api.github.com/repos/vrozov/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/vrozov/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/vrozov/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrozov/drill/labels{/name}","releases_url":"https://api.github.com/repos/vrozov/drill/releases{/id}","deployments_url":"https://api.github.com/repos/vrozov/drill/deployments","created_at":"2017-08-06T15:45:02Z","updated_at":"2018-06-28T18:27:39Z","pushed_at":"2018-06-28T21:04:10Z","git_url":"git://github.com/vrozov/drill.git","ssh_url":"git@github.com:vrozov/drill.git","clone_url":"https://github.com/vrozov/drill.git","svn_url":"https://github.com/vrozov/drill","homepage":"","size":38353,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3b34f0dfddade01220cee5cd299a62f012aea70a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgzNjUz","name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2018-06-29T12:24:32Z","pushed_at":"2018-06-29T14:59:20Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":61137,"stargazers_count":992,"watchers_count":992,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":673,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":673,"open_issues":112,"watchers":992,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/1349"},"html":{"href":"https://github.com/apache/drill/pull/1349"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/1349"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/1349/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/1349/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/1349/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/9c8ddef49c39b2f125de8cd1c7a526ad1b8eef13"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"arina-ielchiieva"}}