{"action":"created","comment":{"url":"https://api.github.com/repos/apache/maven/pulls/comments/242347955","pull_request_review_id":185837362,"id":242347955,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM0Nzk1NQ==","diff_hunk":"@@ -84,4 +87,39 @@ public void testVersionlessManagedDependency()\n             // this is expected\n         }\n     }\n+\n+    public void testResolveDependencies() throws Exception {","path":"maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java","position":22,"original_position":22,"commit_id":"501e2d88a7388d81f255b215e8590304290882e7","original_commit_id":"501e2d88a7388d81f255b215e8590304290882e7","user":{"login":"hboutemy","id":237462,"node_id":"MDQ6VXNlcjIzNzQ2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/237462?v=4","gravatar_id":"","url":"https://api.github.com/users/hboutemy","html_url":"https://github.com/hboutemy","followers_url":"https://api.github.com/users/hboutemy/followers","following_url":"https://api.github.com/users/hboutemy/following{/other_user}","gists_url":"https://api.github.com/users/hboutemy/gists{/gist_id}","starred_url":"https://api.github.com/users/hboutemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hboutemy/subscriptions","organizations_url":"https://api.github.com/users/hboutemy/orgs","repos_url":"https://api.github.com/users/hboutemy/repos","events_url":"https://api.github.com/users/hboutemy/events{/privacy}","received_events_url":"https://api.github.com/users/hboutemy/received_events","type":"User","site_admin":false},"body":"please format unit tests with common style: this will improve maintenance","created_at":"2018-12-17T22:52:48Z","updated_at":"2018-12-17T22:52:48Z","html_url":"https://github.com/apache/maven/pull/193#discussion_r242347955","pull_request_url":"https://api.github.com/repos/apache/maven/pulls/193","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/maven/pulls/comments/242347955"},"html":{"href":"https://github.com/apache/maven/pull/193#discussion_r242347955"},"pull_request":{"href":"https://api.github.com/repos/apache/maven/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/apache/maven/pulls/193","id":233942551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTQyNTUx","html_url":"https://github.com/apache/maven/pull/193","diff_url":"https://github.com/apache/maven/pull/193.diff","patch_url":"https://github.com/apache/maven/pull/193.patch","issue_url":"https://api.github.com/repos/apache/maven/issues/193","number":193,"state":"open","locked":false,"title":"MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()","user":{"login":"mickaelistria","id":469058,"node_id":"MDQ6VXNlcjQ2OTA1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/469058?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelistria","html_url":"https://github.com/mickaelistria","followers_url":"https://api.github.com/users/mickaelistria/followers","following_url":"https://api.github.com/users/mickaelistria/following{/other_user}","gists_url":"https://api.github.com/users/mickaelistria/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelistria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelistria/subscriptions","organizations_url":"https://api.github.com/users/mickaelistria/orgs","repos_url":"https://api.github.com/users/mickaelistria/repos","events_url":"https://api.github.com/users/mickaelistria/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelistria/received_events","type":"User","site_admin":false},"body":"This adds a (failing) unit test showcasing that ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies().\r\nAnd then it adds a fix that turns the test green.\r\n\r\n\r\n\r\nFollowing this checklist to help us incorporate your \r\ncontribution quickly and easily:\r\n\r\n - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed \r\n       for the change (usually before you start working on it).  Trivial changes like typos do not \r\n       require a JIRA issue.  Your pull request should address just this issue, without \r\n       pulling in other changes.\r\n - [x] Each commit in the pull request should have a meaningful subject line and body.\r\n - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,\r\n       where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice\r\n       is to use the JIRA issue title in the pull request title and in the first line of the \r\n       commit message.\r\n - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will \r\n       be performed on your pull request automatically.\r\n - [x] You have run the [Core IT][core-its] successfully.\r\n\r\nIf your pull request is about ~20 lines of code you don't need to sign an\r\n[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure\r\nplease ask on the developers list.\r\n\r\nTo make clear that you license your contribution under \r\nthe [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)\r\nyou have to acknowledge this by using the following check-box.\r\n\r\n - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)\r\n\r\n - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\n[core-its]: https://maven.apache.org/core-its/core-it-suite/\r\n","created_at":"2018-11-27T14:58:43Z","updated_at":"2018-12-17T22:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef830b12c5b499c9063cff4a4eb5d005441c386d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/maven/pulls/193/commits","review_comments_url":"https://api.github.com/repos/apache/maven/pulls/193/comments","review_comment_url":"https://api.github.com/repos/apache/maven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/maven/issues/193/comments","statuses_url":"https://api.github.com/repos/apache/maven/statuses/501e2d88a7388d81f255b215e8590304290882e7","head":{"label":"mickaelistria:MNG-6529-test","ref":"MNG-6529-test","sha":"501e2d88a7388d81f255b215e8590304290882e7","user":{"login":"mickaelistria","id":469058,"node_id":"MDQ6VXNlcjQ2OTA1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/469058?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelistria","html_url":"https://github.com/mickaelistria","followers_url":"https://api.github.com/users/mickaelistria/followers","following_url":"https://api.github.com/users/mickaelistria/following{/other_user}","gists_url":"https://api.github.com/users/mickaelistria/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelistria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelistria/subscriptions","organizations_url":"https://api.github.com/users/mickaelistria/orgs","repos_url":"https://api.github.com/users/mickaelistria/repos","events_url":"https://api.github.com/users/mickaelistria/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelistria/received_events","type":"User","site_admin":false},"repo":{"id":159352063,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzNTIwNjM=","name":"maven","full_name":"mickaelistria/maven","private":false,"owner":{"login":"mickaelistria","id":469058,"node_id":"MDQ6VXNlcjQ2OTA1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/469058?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelistria","html_url":"https://github.com/mickaelistria","followers_url":"https://api.github.com/users/mickaelistria/followers","following_url":"https://api.github.com/users/mickaelistria/following{/other_user}","gists_url":"https://api.github.com/users/mickaelistria/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelistria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelistria/subscriptions","organizations_url":"https://api.github.com/users/mickaelistria/orgs","repos_url":"https://api.github.com/users/mickaelistria/repos","events_url":"https://api.github.com/users/mickaelistria/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelistria/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mickaelistria/maven","description":"Apache Maven","fork":true,"url":"https://api.github.com/repos/mickaelistria/maven","forks_url":"https://api.github.com/repos/mickaelistria/maven/forks","keys_url":"https://api.github.com/repos/mickaelistria/maven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mickaelistria/maven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mickaelistria/maven/teams","hooks_url":"https://api.github.com/repos/mickaelistria/maven/hooks","issue_events_url":"https://api.github.com/repos/mickaelistria/maven/issues/events{/number}","events_url":"https://api.github.com/repos/mickaelistria/maven/events","assignees_url":"https://api.github.com/repos/mickaelistria/maven/assignees{/user}","branches_url":"https://api.github.com/repos/mickaelistria/maven/branches{/branch}","tags_url":"https://api.github.com/repos/mickaelistria/maven/tags","blobs_url":"https://api.github.com/repos/mickaelistria/maven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mickaelistria/maven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mickaelistria/maven/git/refs{/sha}","trees_url":"https://api.github.com/repos/mickaelistria/maven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mickaelistria/maven/statuses/{sha}","languages_url":"https://api.github.com/repos/mickaelistria/maven/languages","stargazers_url":"https://api.github.com/repos/mickaelistria/maven/stargazers","contributors_url":"https://api.github.com/repos/mickaelistria/maven/contributors","subscribers_url":"https://api.github.com/repos/mickaelistria/maven/subscribers","subscription_url":"https://api.github.com/repos/mickaelistria/maven/subscription","commits_url":"https://api.github.com/repos/mickaelistria/maven/commits{/sha}","git_commits_url":"https://api.github.com/repos/mickaelistria/maven/git/commits{/sha}","comments_url":"https://api.github.com/repos/mickaelistria/maven/comments{/number}","issue_comment_url":"https://api.github.com/repos/mickaelistria/maven/issues/comments{/number}","contents_url":"https://api.github.com/repos/mickaelistria/maven/contents/{+path}","compare_url":"https://api.github.com/repos/mickaelistria/maven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mickaelistria/maven/merges","archive_url":"https://api.github.com/repos/mickaelistria/maven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mickaelistria/maven/downloads","issues_url":"https://api.github.com/repos/mickaelistria/maven/issues{/number}","pulls_url":"https://api.github.com/repos/mickaelistria/maven/pulls{/number}","milestones_url":"https://api.github.com/repos/mickaelistria/maven/milestones{/number}","notifications_url":"https://api.github.com/repos/mickaelistria/maven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mickaelistria/maven/labels{/name}","releases_url":"https://api.github.com/repos/mickaelistria/maven/releases{/id}","deployments_url":"https://api.github.com/repos/mickaelistria/maven/deployments","created_at":"2018-11-27T14:55:14Z","updated_at":"2018-11-27T14:55:21Z","pushed_at":"2018-12-09T18:05:39Z","git_url":"git://github.com/mickaelistria/maven.git","ssh_url":"git@github.com:mickaelistria/maven.git","clone_url":"https://github.com/mickaelistria/maven.git","svn_url":"https://github.com/mickaelistria/maven","homepage":"https://maven.apache.org/","size":43599,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e4e33f73b8f089e443a3bcc678f509bf0daffb15","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206483,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0ODM=","name":"maven","full_name":"apache/maven","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/maven","description":"Apache Maven","fork":false,"url":"https://api.github.com/repos/apache/maven","forks_url":"https://api.github.com/repos/apache/maven/forks","keys_url":"https://api.github.com/repos/apache/maven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/maven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/maven/teams","hooks_url":"https://api.github.com/repos/apache/maven/hooks","issue_events_url":"https://api.github.com/repos/apache/maven/issues/events{/number}","events_url":"https://api.github.com/repos/apache/maven/events","assignees_url":"https://api.github.com/repos/apache/maven/assignees{/user}","branches_url":"https://api.github.com/repos/apache/maven/branches{/branch}","tags_url":"https://api.github.com/repos/apache/maven/tags","blobs_url":"https://api.github.com/repos/apache/maven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/maven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/maven/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/maven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/maven/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/maven/languages","stargazers_url":"https://api.github.com/repos/apache/maven/stargazers","contributors_url":"https://api.github.com/repos/apache/maven/contributors","subscribers_url":"https://api.github.com/repos/apache/maven/subscribers","subscription_url":"https://api.github.com/repos/apache/maven/subscription","commits_url":"https://api.github.com/repos/apache/maven/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/maven/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/maven/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/maven/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/maven/contents/{+path}","compare_url":"https://api.github.com/repos/apache/maven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/maven/merges","archive_url":"https://api.github.com/repos/apache/maven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/maven/downloads","issues_url":"https://api.github.com/repos/apache/maven/issues{/number}","pulls_url":"https://api.github.com/repos/apache/maven/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/maven/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/maven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/maven/labels{/name}","releases_url":"https://api.github.com/repos/apache/maven/releases{/id}","deployments_url":"https://api.github.com/repos/apache/maven/deployments","created_at":"2009-05-21T03:22:03Z","updated_at":"2018-12-17T12:05:38Z","pushed_at":"2018-12-16T06:35:49Z","git_url":"git://github.com/apache/maven.git","ssh_url":"git@github.com:apache/maven.git","clone_url":"https://github.com/apache/maven.git","svn_url":"https://github.com/apache/maven","homepage":"https://maven.apache.org/","size":43846,"stargazers_count":1421,"watchers_count":1421,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1064,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1064,"open_issues":47,"watchers":1421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/maven/pulls/193"},"html":{"href":"https://github.com/apache/maven/pull/193"},"issue":{"href":"https://api.github.com/repos/apache/maven/issues/193"},"comments":{"href":"https://api.github.com/repos/apache/maven/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/maven/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/maven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/maven/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/apache/maven/statuses/501e2d88a7388d81f255b215e8590304290882e7"}},"author_association":"NONE"}}
{"actor":{"display_login":"hboutemy"}}