{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/78","repository_url":"https://api.github.com/repos/kubernetes-csi/external-attacher","labels_url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/78/comments","events_url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/78/events","html_url":"https://github.com/kubernetes-csi/external-attacher/pull/78","id":370378456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDcwMDgz","number":78,"title":"Add CSI Migration logic for attach/detach","user":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"labels":[{"id":1031773252,"node_id":"MDU6TGFiZWwxMDMxNzczMjUy","url":"https://api.github.com/repos/kubernetes-csi/external-attacher/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1031777071,"node_id":"MDU6TGFiZWwxMDMxNzc3MDcx","url":"https://api.github.com/repos/kubernetes-csi/external-attacher/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"node_id":"MDQ6VXNlcjEwMDUyODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-15T23:12:14Z","updated_at":"2018-10-16T08:40:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-csi/external-attacher/pulls/78","html_url":"https://github.com/kubernetes-csi/external-attacher/pull/78","diff_url":"https://github.com/kubernetes-csi/external-attacher/pull/78.diff","patch_url":"https://github.com/kubernetes-csi/external-attacher/pull/78.patch"},"body":"This PR adds migration logic for attach/detach.\r\nThis logic will get called upon from the code-paths introduced in: https://github.com/kubernetes/kubernetes/pull/69830\r\n\r\n/assign @jsafrane @saad-ali \r\n\r\n/cc @lpabon"},"comment":{"url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/comments/430151910","html_url":"https://github.com/kubernetes-csi/external-attacher/pull/78#issuecomment-430151910","issue_url":"https://api.github.com/repos/kubernetes-csi/external-attacher/issues/78","id":430151910,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDE1MTkxMA==","user":{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T08:40:03Z","updated_at":"2018-10-16T08:40:03Z","author_association":"CONTRIBUTOR","body":"The code looks great, however, can you please add a test that creates PV \r\n with GCEPersistentDiskVolumeSource  and tests that CSI is called with the right arguments? You'll probably need to change `testAttacherName` to GCE, that's fine."}}
{"actor":{"display_login":"jsafrane"}}