{"action":"created","issue":{"url":"https://api.github.com/repos/afragen/github-updater/issues/746","repository_url":"https://api.github.com/repos/afragen/github-updater","labels_url":"https://api.github.com/repos/afragen/github-updater/issues/746/labels{/name}","comments_url":"https://api.github.com/repos/afragen/github-updater/issues/746/comments","events_url":"https://api.github.com/repos/afragen/github-updater/issues/746/events","html_url":"https://github.com/afragen/github-updater/issues/746","id":390793939,"node_id":"MDU6SXNzdWUzOTA3OTM5Mzk=","number":746,"title":"Disable fetching updates if on wp.org","user":{"login":"Raruto","id":9614886,"node_id":"MDQ6VXNlcjk2MTQ4ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/9614886?v=4","gravatar_id":"","url":"https://api.github.com/users/Raruto","html_url":"https://github.com/Raruto","followers_url":"https://api.github.com/users/Raruto/followers","following_url":"https://api.github.com/users/Raruto/following{/other_user}","gists_url":"https://api.github.com/users/Raruto/gists{/gist_id}","starred_url":"https://api.github.com/users/Raruto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raruto/subscriptions","organizations_url":"https://api.github.com/users/Raruto/orgs","repos_url":"https://api.github.com/users/Raruto/repos","events_url":"https://api.github.com/users/Raruto/events{/privacy}","received_events_url":"https://api.github.com/users/Raruto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-12-13T18:00:07Z","updated_at":"2018-12-13T23:34:50Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I realized that plugin is present on github with a major version number github updater adds it to the list of plugins to be updated and, of course, if you try to update it wordpress will fail trying...\r\n\r\n\r\n## Steps to reproduce:\r\n\r\n0. install: **GHU v. 8.5.2**  (with WP v. 5.0.1)\r\n1. install this plugin directly from wp.org: https://wordpress.org/plugins/geoip-detect/ (**v. 2.9.2**)\r\n2. visit your plugins.php page (or force **check of wordpress updates**)\r\n\r\n![geoip](https://user-images.githubusercontent.com/9614886/49957348-cdf46500-ff07-11e8-95b7-5e5b8cdbe494.png)\r\n\r\n3. now you should see a new update for the version **v. 2.9.3-beta** (current version for: https://github.com/yellowtree/wp-geoip-detect)\r\n4. if you try to install this update it will fail (because it does not exist in the wp.org directory...)\r\n\r\n## Actual Results:\r\n\r\n![geoip-2](https://user-images.githubusercontent.com/9614886/49957494-41967200-ff08-11e8-9e19-785bf7728e5c.png)\r\n\r\nthe plugin is not updated (ie. wordpress will still always notify an available update) or the update fails (with some older WP / GHU versions)\r\n\r\n## Expected Results:\r\n\r\n- avoid seeking for updates from GitHub if a plugin/theme is also on wp.org\r\n\r\n---\r\n\r\n**NB** I have not checked yet, but I think this problem is slightly different from the problem solved by using this filter: _github_updater_override_dot_org_\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/afragen/github-updater/issues/comments/447160126","html_url":"https://github.com/afragen/github-updater/issues/746#issuecomment-447160126","issue_url":"https://api.github.com/repos/afragen/github-updater/issues/746","id":447160126,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzE2MDEyNg==","user":{"login":"Raruto","id":9614886,"node_id":"MDQ6VXNlcjk2MTQ4ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/9614886?v=4","gravatar_id":"","url":"https://api.github.com/users/Raruto","html_url":"https://github.com/Raruto","followers_url":"https://api.github.com/users/Raruto/followers","following_url":"https://api.github.com/users/Raruto/following{/other_user}","gists_url":"https://api.github.com/users/Raruto/gists{/gist_id}","starred_url":"https://api.github.com/users/Raruto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raruto/subscriptions","organizations_url":"https://api.github.com/users/Raruto/orgs","repos_url":"https://api.github.com/users/Raruto/repos","events_url":"https://api.github.com/users/Raruto/events{/privacy}","received_events_url":"https://api.github.com/users/Raruto/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T23:34:50Z","updated_at":"2018-12-13T23:34:50Z","author_association":"CONTRIBUTOR","body":"Ok, so this is what would happen in this specific case (if the plugin was not also present on wp.org ...)\r\n\r\n> What happens is that the master branch has a higher version number than the installed version. **An update notice is shown, however, and the most recent tagged release is used as the download link.** If the tag is for the old version then it will be installed and an update notice will still show.\r\n\r\nBut this happens because you can not directly check the version of the plugin from the tagged release? (eg. because the github API doesn't allow a direct access to single files of the release, as instead happens for the branches, without first having to download the entire zip file?)"}}
{"actor":{"display_login":"Raruto"}}