{"action":"created","comment":{"url":"https://api.github.com/repos/heptio/ark/pulls/comments/198639465","pull_request_review_id":132606905,"id":198639465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYzOTQ2NQ==","diff_hunk":"@@ -170,6 +182,26 @@ ForEachVolume:\n \treturn volumeSnapshots, errs\n }\n \n+func volumeExists(pod *corev1api.Pod, volumeName string) bool {","path":"pkg/restic/backupper.go","position":23,"original_position":23,"commit_id":"b9efcc2b5ce806c3abef3dcba8bf5801a64ba834","original_commit_id":"b9efcc2b5ce806c3abef3dcba8bf5801a64ba834","user":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"Is it worth optimizing this into a single function so we don't have to range over pod.Spec.Volumes twice?","created_at":"2018-06-27T21:00:53Z","updated_at":"2018-06-27T21:01:09Z","html_url":"https://github.com/heptio/ark/pull/610#discussion_r198639465","pull_request_url":"https://api.github.com/repos/heptio/ark/pulls/610","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments/198639465"},"html":{"href":"https://github.com/heptio/ark/pull/610#discussion_r198639465"},"pull_request":{"href":"https://api.github.com/repos/heptio/ark/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/610","id":197253347,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjUzMzQ3","html_url":"https://github.com/heptio/ark/pull/610","diff_url":"https://github.com/heptio/ark/pull/610.diff","patch_url":"https://github.com/heptio/ark/pull/610.patch","issue_url":"https://api.github.com/repos/heptio/ark/issues/610","number":610,"state":"open","locked":false,"title":"log and skip backups for non-existent & hostPath volumes","user":{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Steve Kriss <steve@heptio.com>","created_at":"2018-06-25T22:29:06Z","updated_at":"2018-06-27T21:01:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dd5e8bcff20e2e306f01f2e1d279abb98781273","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/heptio/ark/milestones/6","html_url":"https://github.com/heptio/ark/milestone/6","labels_url":"https://api.github.com/repos/heptio/ark/milestones/6/labels","id":3259201,"node_id":"MDk6TWlsZXN0b25lMzI1OTIwMQ==","number":6,"title":"v0.9.0","description":"","creator":{"login":"nrb","id":321387,"node_id":"MDQ6VXNlcjMyMTM4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/321387?v=4","gravatar_id":"","url":"https://api.github.com/users/nrb","html_url":"https://github.com/nrb","followers_url":"https://api.github.com/users/nrb/followers","following_url":"https://api.github.com/users/nrb/following{/other_user}","gists_url":"https://api.github.com/users/nrb/gists{/gist_id}","starred_url":"https://api.github.com/users/nrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrb/subscriptions","organizations_url":"https://api.github.com/users/nrb/orgs","repos_url":"https://api.github.com/users/nrb/repos","events_url":"https://api.github.com/users/nrb/events{/privacy}","received_events_url":"https://api.github.com/users/nrb/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":35,"state":"open","created_at":"2018-04-11T14:49:32Z","updated_at":"2018-06-26T20:52:02Z","due_on":"2018-06-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/heptio/ark/pulls/610/commits","review_comments_url":"https://api.github.com/repos/heptio/ark/pulls/610/comments","review_comment_url":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/ark/issues/610/comments","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/b9efcc2b5ce806c3abef3dcba8bf5801a64ba834","head":{"label":"skriss:restic-skip-invalid-volumes","ref":"restic-skip-invalid-volumes","sha":"b9efcc2b5ce806c3abef3dcba8bf5801a64ba834","user":{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"repo":{"id":99252487,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI1MjQ4Nw==","name":"ark","full_name":"skriss/ark","owner":{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skriss/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":true,"url":"https://api.github.com/repos/skriss/ark","forks_url":"https://api.github.com/repos/skriss/ark/forks","keys_url":"https://api.github.com/repos/skriss/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skriss/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skriss/ark/teams","hooks_url":"https://api.github.com/repos/skriss/ark/hooks","issue_events_url":"https://api.github.com/repos/skriss/ark/issues/events{/number}","events_url":"https://api.github.com/repos/skriss/ark/events","assignees_url":"https://api.github.com/repos/skriss/ark/assignees{/user}","branches_url":"https://api.github.com/repos/skriss/ark/branches{/branch}","tags_url":"https://api.github.com/repos/skriss/ark/tags","blobs_url":"https://api.github.com/repos/skriss/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skriss/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skriss/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/skriss/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skriss/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/skriss/ark/languages","stargazers_url":"https://api.github.com/repos/skriss/ark/stargazers","contributors_url":"https://api.github.com/repos/skriss/ark/contributors","subscribers_url":"https://api.github.com/repos/skriss/ark/subscribers","subscription_url":"https://api.github.com/repos/skriss/ark/subscription","commits_url":"https://api.github.com/repos/skriss/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/skriss/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/skriss/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/skriss/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/skriss/ark/contents/{+path}","compare_url":"https://api.github.com/repos/skriss/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skriss/ark/merges","archive_url":"https://api.github.com/repos/skriss/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skriss/ark/downloads","issues_url":"https://api.github.com/repos/skriss/ark/issues{/number}","pulls_url":"https://api.github.com/repos/skriss/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/skriss/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/skriss/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skriss/ark/labels{/name}","releases_url":"https://api.github.com/repos/skriss/ark/releases{/id}","deployments_url":"https://api.github.com/repos/skriss/ark/deployments","created_at":"2017-08-03T16:18:24Z","updated_at":"2017-08-03T16:18:37Z","pushed_at":"2018-06-27T20:51:09Z","git_url":"git://github.com/skriss/ark.git","ssh_url":"git@github.com:skriss/ark.git","clone_url":"https://github.com/skriss/ark.git","svn_url":"https://github.com/skriss/ark","homepage":"http://www.heptio.com","size":21897,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heptio:master","ref":"master","sha":"ee5afe148ca416d2bd2ad8222fc5667a0f781a02","user":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99143276,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0MzI3Ng==","name":"ark","full_name":"heptio/ark","owner":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":false,"url":"https://api.github.com/repos/heptio/ark","forks_url":"https://api.github.com/repos/heptio/ark/forks","keys_url":"https://api.github.com/repos/heptio/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/ark/teams","hooks_url":"https://api.github.com/repos/heptio/ark/hooks","issue_events_url":"https://api.github.com/repos/heptio/ark/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/ark/events","assignees_url":"https://api.github.com/repos/heptio/ark/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/ark/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/ark/tags","blobs_url":"https://api.github.com/repos/heptio/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/ark/languages","stargazers_url":"https://api.github.com/repos/heptio/ark/stargazers","contributors_url":"https://api.github.com/repos/heptio/ark/contributors","subscribers_url":"https://api.github.com/repos/heptio/ark/subscribers","subscription_url":"https://api.github.com/repos/heptio/ark/subscription","commits_url":"https://api.github.com/repos/heptio/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/ark/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/ark/merges","archive_url":"https://api.github.com/repos/heptio/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/ark/downloads","issues_url":"https://api.github.com/repos/heptio/ark/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/ark/labels{/name}","releases_url":"https://api.github.com/repos/heptio/ark/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/ark/deployments","created_at":"2017-08-02T17:22:11Z","updated_at":"2018-06-27T20:44:06Z","pushed_at":"2018-06-27T20:54:18Z","git_url":"git://github.com/heptio/ark.git","ssh_url":"git@github.com:heptio/ark.git","clone_url":"https://github.com/heptio/ark.git","svn_url":"https://github.com/heptio/ark","homepage":"https://www.heptio.com","size":9537,"stargazers_count":1239,"watchers_count":1239,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":153,"watchers":1239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/610"},"html":{"href":"https://github.com/heptio/ark/pull/610"},"issue":{"href":"https://api.github.com/repos/heptio/ark/issues/610"},"comments":{"href":"https://api.github.com/repos/heptio/ark/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/ark/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/ark/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/ark/statuses/b9efcc2b5ce806c3abef3dcba8bf5801a64ba834"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ncdc"}}