{"action":"closed","number":2006,"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/2006","id":143236102,"html_url":"https://github.com/kubernetes/minikube/pull/2006","diff_url":"https://github.com/kubernetes/minikube/pull/2006.diff","patch_url":"https://github.com/kubernetes/minikube/pull/2006.patch","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/2006","number":2006,"state":"closed","locked":false,"title":"bootstraper: consider ServiceClusterIPRange for apiserver TLS","user":{"login":"donaldguy","id":43136,"avatar_url":"https://avatars3.githubusercontent.com/u/43136?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldguy","html_url":"https://github.com/donaldguy","followers_url":"https://api.github.com/users/donaldguy/followers","following_url":"https://api.github.com/users/donaldguy/following{/other_user}","gists_url":"https://api.github.com/users/donaldguy/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldguy/subscriptions","organizations_url":"https://api.github.com/users/donaldguy/orgs","repos_url":"https://api.github.com/users/donaldguy/repos","events_url":"https://api.github.com/users/donaldguy/events{/privacy}","received_events_url":"https://api.github.com/users/donaldguy/received_events","type":"User","site_admin":false},"body":"Fixes #2005\r\nFixes #1536\r\n\r\nThis is a minimal approach to the fix; it is probably not the ideal approach\r\nbecause it departs a unified usage of `util.DefaultServiceClusterIP`; a better\r\napproach would to be hoist the wrapping of `\"k8s.io/kubernetes/pkg/master\".DefaultServiceIPRange`\r\ninto minikube's util space and replace the hard-codes wholesale.\r\n\r\nGiven that the move to `kubeadm` is afoot, I'm not sure its worth the refactor\r\n\r\nfor what its worth, localkube seems to get the message fine from extraArgs as it stands","created_at":"2017-09-26T20:33:44Z","updated_at":"2018-03-12T03:14:33Z","closed_at":"2018-03-12T03:14:33Z","merged_at":null,"merge_commit_sha":"3579d8179d1d9e9f209386c20e527f5a3d243cac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484585353,"url":"https://api.github.com/repos/kubernetes/minikube/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778122702,"url":"https://api.github.com/repos/kubernetes/minikube/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false},{"id":676046503,"url":"https://api.github.com/repos/kubernetes/minikube/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/minikube/pulls/2006/commits","review_comments_url":"https://api.github.com/repos/kubernetes/minikube/pulls/2006/comments","review_comment_url":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/2006/comments","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/35a81d73f2b69313bf73f38c2b5263dd37d64449","head":{"label":"donaldguy:bootstaper.tls.svcRange","ref":"bootstaper.tls.svcRange","sha":"35a81d73f2b69313bf73f38c2b5263dd37d64449","user":{"login":"donaldguy","id":43136,"avatar_url":"https://avatars3.githubusercontent.com/u/43136?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldguy","html_url":"https://github.com/donaldguy","followers_url":"https://api.github.com/users/donaldguy/followers","following_url":"https://api.github.com/users/donaldguy/following{/other_user}","gists_url":"https://api.github.com/users/donaldguy/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldguy/subscriptions","organizations_url":"https://api.github.com/users/donaldguy/orgs","repos_url":"https://api.github.com/users/donaldguy/repos","events_url":"https://api.github.com/users/donaldguy/events{/privacy}","received_events_url":"https://api.github.com/users/donaldguy/received_events","type":"User","site_admin":false},"repo":{"id":104934522,"name":"minikube","full_name":"donaldguy/minikube","owner":{"login":"donaldguy","id":43136,"avatar_url":"https://avatars3.githubusercontent.com/u/43136?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldguy","html_url":"https://github.com/donaldguy","followers_url":"https://api.github.com/users/donaldguy/followers","following_url":"https://api.github.com/users/donaldguy/following{/other_user}","gists_url":"https://api.github.com/users/donaldguy/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldguy/subscriptions","organizations_url":"https://api.github.com/users/donaldguy/orgs","repos_url":"https://api.github.com/users/donaldguy/repos","events_url":"https://api.github.com/users/donaldguy/events{/privacy}","received_events_url":"https://api.github.com/users/donaldguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donaldguy/minikube","description":"Run Kubernetes locally","fork":true,"url":"https://api.github.com/repos/donaldguy/minikube","forks_url":"https://api.github.com/repos/donaldguy/minikube/forks","keys_url":"https://api.github.com/repos/donaldguy/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donaldguy/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donaldguy/minikube/teams","hooks_url":"https://api.github.com/repos/donaldguy/minikube/hooks","issue_events_url":"https://api.github.com/repos/donaldguy/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/donaldguy/minikube/events","assignees_url":"https://api.github.com/repos/donaldguy/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/donaldguy/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/donaldguy/minikube/tags","blobs_url":"https://api.github.com/repos/donaldguy/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donaldguy/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donaldguy/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/donaldguy/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donaldguy/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/donaldguy/minikube/languages","stargazers_url":"https://api.github.com/repos/donaldguy/minikube/stargazers","contributors_url":"https://api.github.com/repos/donaldguy/minikube/contributors","subscribers_url":"https://api.github.com/repos/donaldguy/minikube/subscribers","subscription_url":"https://api.github.com/repos/donaldguy/minikube/subscription","commits_url":"https://api.github.com/repos/donaldguy/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/donaldguy/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/donaldguy/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/donaldguy/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/donaldguy/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/donaldguy/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donaldguy/minikube/merges","archive_url":"https://api.github.com/repos/donaldguy/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donaldguy/minikube/downloads","issues_url":"https://api.github.com/repos/donaldguy/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/donaldguy/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/donaldguy/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/donaldguy/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donaldguy/minikube/labels{/name}","releases_url":"https://api.github.com/repos/donaldguy/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/donaldguy/minikube/deployments","created_at":"2017-09-26T20:29:43Z","updated_at":"2017-09-26T20:29:45Z","pushed_at":"2017-09-26T20:30:40Z","git_url":"git://github.com/donaldguy/minikube.git","ssh_url":"git@github.com:donaldguy/minikube.git","clone_url":"https://github.com/donaldguy/minikube.git","svn_url":"https://github.com/donaldguy/minikube","homepage":null,"size":36844,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"023aea13a24d1c8320d541974ed1d9d2fccb13ae","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":56353740,"name":"minikube","full_name":"kubernetes/minikube","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/minikube","description":"Run Kubernetes locally","fork":false,"url":"https://api.github.com/repos/kubernetes/minikube","forks_url":"https://api.github.com/repos/kubernetes/minikube/forks","keys_url":"https://api.github.com/repos/kubernetes/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/minikube/teams","hooks_url":"https://api.github.com/repos/kubernetes/minikube/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/minikube/events","assignees_url":"https://api.github.com/repos/kubernetes/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/minikube/tags","blobs_url":"https://api.github.com/repos/kubernetes/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/minikube/languages","stargazers_url":"https://api.github.com/repos/kubernetes/minikube/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/minikube/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/minikube/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/minikube/subscription","commits_url":"https://api.github.com/repos/kubernetes/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/minikube/merges","archive_url":"https://api.github.com/repos/kubernetes/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/minikube/downloads","issues_url":"https://api.github.com/repos/kubernetes/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/minikube/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/minikube/deployments","created_at":"2016-04-15T22:38:35Z","updated_at":"2018-03-12T03:06:28Z","pushed_at":"2018-03-11T20:41:31Z","git_url":"git://github.com/kubernetes/minikube.git","ssh_url":"git@github.com:kubernetes/minikube.git","clone_url":"https://github.com/kubernetes/minikube.git","svn_url":"https://github.com/kubernetes/minikube","homepage":null,"size":46518,"stargazers_count":7751,"watchers_count":7751,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1070,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1070,"open_issues":293,"watchers":7751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/2006"},"html":{"href":"https://github.com/kubernetes/minikube/pull/2006"},"issue":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/2006"},"comments":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/2006/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/2006/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/2006/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/minikube/statuses/35a81d73f2b69313bf73f38c2b5263dd37d64449"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":21,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"k8s-ci-robot"}}