{"action":"created","issue":{"url":"https://api.github.com/repos/lpil/mix-test.watch/issues/87","repository_url":"https://api.github.com/repos/lpil/mix-test.watch","labels_url":"https://api.github.com/repos/lpil/mix-test.watch/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/lpil/mix-test.watch/issues/87/comments","events_url":"https://api.github.com/repos/lpil/mix-test.watch/issues/87/events","html_url":"https://github.com/lpil/mix-test.watch/pull/87","id":317904186,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0MjQ1NzEy","number":87,"title":"don't start application","user":{"login":"steffkes","id":325361,"node_id":"MDQ6VXNlcjMyNTM2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/325361?v=4","gravatar_id":"","url":"https://api.github.com/users/steffkes","html_url":"https://github.com/steffkes","followers_url":"https://api.github.com/users/steffkes/followers","following_url":"https://api.github.com/users/steffkes/following{/other_user}","gists_url":"https://api.github.com/users/steffkes/gists{/gist_id}","starred_url":"https://api.github.com/users/steffkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffkes/subscriptions","organizations_url":"https://api.github.com/users/steffkes/orgs","repos_url":"https://api.github.com/users/steffkes/repos","events_url":"https://api.github.com/users/steffkes/events{/privacy}","received_events_url":"https://api.github.com/users/steffkes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-26T07:12:42Z","updated_at":"2018-07-30T15:52:47Z","closed_at":"2018-05-14T17:43:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lpil/mix-test.watch/pulls/87","html_url":"https://github.com/lpil/mix-test.watch/pull/87","diff_url":"https://github.com/lpil/mix-test.watch/pull/87.diff","patch_url":"https://github.com/lpil/mix-test.watch/pull/87.patch"},"body":"a bit of context for this change: i was using `mix test --no-start` before i switched to this project. when i switched i noticed, that some of my tests failed due to `process xy is already running` errors which was suspicious because beside adding & using this project nothing else happened.\r\n\r\nweeping through the code i found the relevant part in `PortRunner`. when executing\r\n\r\n```bash\r\nmix test.watch --no-start test/handler/types/entrypoint_test.exs\r\n```\r\n\r\nit gets transformed to the following command:\r\n\r\n```bash\r\nsh -c \"MIX_ENV=test mix do run -e 'Application.put_env(:elixir, :ansi_enabled, true);', \\\r\n                           test --no-start test/handler/types/entrypoint_test.exs\r\n```\r\n\r\nwhere you can see, that it passes `--no-start` to the underlying `mix test` command, but it does not for the previous `mix run` command which is in place to enable ansi colored printing - so in fact, while the `mix test` command _does not_ start the application, the `mix run` command actually does ..\r\n\r\ni can see the following options:\r\n\r\n1. passing all arguments we give to `mix test` to `mix run` as well. i'm hesitating to do this, since i'm pretty sure that `mix run` doesn't accept every argument that `mix test` is aware of - which would make it fail pretty hard.\r\n2. passing `--no-start` to `mix run` only in case that it's present in the process arguments\r\n3. always passing `--no-start` to `mix run`\r\n\r\nwhere i did the latter, because i couldn't see any change in behaviour at all. option 2 would be my other choice, in case that it's breaking any behaviour that i'm not aware of.\r\n\r\nWDYT @lpil ?\r\n"},"comment":{"url":"https://api.github.com/repos/lpil/mix-test.watch/issues/comments/408913293","html_url":"https://github.com/lpil/mix-test.watch/pull/87#issuecomment-408913293","issue_url":"https://api.github.com/repos/lpil/mix-test.watch/issues/87","id":408913293,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODkxMzI5Mw==","user":{"login":"lpil","id":6134406,"node_id":"MDQ6VXNlcjYxMzQ0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6134406?v=4","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T15:52:47Z","updated_at":"2018-07-30T15:52:47Z","author_association":"OWNER","body":"Seems this breaks a lot of projects, such as any using ecto migrations."}}
{"actor":{"display_login":"lpil"}}