{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506","repository_url":"https://api.github.com/repos/aws/aws-sdk-php","labels_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506/events","html_url":"https://github.com/aws/aws-sdk-php/pull/1506","id":302294669,"number":1506,"title":"CURLE_RECV_ERROR  error retry fixed","user":{"login":"Halama","id":903531,"avatar_url":"https://avatars3.githubusercontent.com/u/903531?v=4","gravatar_id":"","url":"https://api.github.com/users/Halama","html_url":"https://github.com/Halama","followers_url":"https://api.github.com/users/Halama/followers","following_url":"https://api.github.com/users/Halama/following{/other_user}","gists_url":"https://api.github.com/users/Halama/gists{/gist_id}","starred_url":"https://api.github.com/users/Halama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Halama/subscriptions","organizations_url":"https://api.github.com/users/Halama/orgs","repos_url":"https://api.github.com/users/Halama/repos","events_url":"https://api.github.com/users/Halama/events{/privacy}","received_events_url":"https://api.github.com/users/Halama/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-05T13:12:26Z","updated_at":"2018-03-05T13:28:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-php/pulls/1506","html_url":"https://github.com/aws/aws-sdk-php/pull/1506","diff_url":"https://github.com/aws/aws-sdk-php/pull/1506.diff","patch_url":"https://github.com/aws/aws-sdk-php/pull/1506.patch"},"body":"Hello,\r\nwe have upgraded to the latest AWS SDK because the retry of `CURLE_RECV_ERROR` was fixed in https://github.com/aws/aws-sdk-php/releases/tag/3.52.0\r\n\r\nUnfortunately after deploy of the new application version with updated AWS SDK we are still receiving occasional `CURLE_RECV_ERROR` errors.\r\n\r\nI've tried to debug a code and I've noticed that `GuzzleHttp\\Exception\\ConnectException` exception is expected in AWS SDK https://github.com/aws/aws-sdk-php/blob/299ac47ff5171d6a25f788dc333c0a3c8db40f69/src/RetryMiddleware.php#L104 but `GuzzleHttp\\Exception\\RequestException` is  thrown in Guzzle https://github.com/guzzle/guzzle/blob/748d67e23a984e7a2562847994fd133fd4e629a6/src/Handler/CurlFactory.php#L154 . \r\nSo I think that `CURLE_RECV_ERROR` is never retried. \r\nThis PR should fix it.\r\n\r\nthanks\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-php/issues/comments/370418578","html_url":"https://github.com/aws/aws-sdk-php/pull/1506#issuecomment-370418578","issue_url":"https://api.github.com/repos/aws/aws-sdk-php/issues/1506","id":370418578,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T13:28:31Z","updated_at":"2018-03-05T13:28:31Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=h1) Report\n> Merging [#1506](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=desc) into [master](https://codecov.io/gh/aws/aws-sdk-php/commit/299ac47ff5171d6a25f788dc333c0a3c8db40f69?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/aws/aws-sdk-php/pull/1506/graphs/tree.svg?token=0p8wqlGrg4&width=650&height=150&src=pr)](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master    #1506   +/-   ##\n=========================================\n  Coverage     94.16%   94.16%           \n  Complexity     2560     2560           \n=========================================\n  Files           160      160           \n  Lines          6803     6803           \n=========================================\n  Hits           6406     6406           \n  Misses          397      397\n```\n\n\n| [Impacted Files](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [src/RetryMiddleware.php](https://codecov.io/gh/aws/aws-sdk-php/pull/1506/diff?src=pr&el=tree#diff-c3JjL1JldHJ5TWlkZGxld2FyZS5waHA=) | `98.97% <100%> (ø)` | `58 <0> (ø)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=footer). Last update [299ac47...998e8f1](https://codecov.io/gh/aws/aws-sdk-php/pull/1506?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}