{"action":"closed","number":1112,"pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1112","id":181071664,"html_url":"https://github.com/alibaba/pouch/pull/1112","diff_url":"https://github.com/alibaba/pouch/pull/1112.diff","patch_url":"https://github.com/alibaba/pouch/pull/1112.patch","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1112","number":1112,"state":"closed","locked":false,"title":"bugfix: we should get image ID from containerd","user":{"login":"YaoZengzeng","id":8636562,"avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"body":"Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\n\r\nNow we get image ID by calculating ourself, unfortunately it's wrong.\r\n\r\nFor example `busybox:1-uclibc` and `busybox:1` should have same ID,  however:\r\n```\r\n[root@pouch-test pouch]# pouch images\r\nIMAGE ID       IMAGE NAME                                         SIZE\r\n58af67620523   registry.hub.docker.com/library/busybox:1          710.83 KB\r\nb2e60002262d   registry.hub.docker.com/library/busybox:1-uclibc   709.90 KB\r\n```\r\n\r\nSo with this PR we get it directly from containerd then:\r\n```\r\n[root@pouch-test pouch]# pouch images\r\nIMAGE ID       IMAGE NAME                                         SIZE\r\n8ac48589692a   registry.hub.docker.com/library/busybox:1          710.83 KB\r\n8ac48589692a   registry.hub.docker.com/library/busybox:1-uclibc   709.90 KB\r\n```\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n","created_at":"2018-04-12T01:59:56Z","updated_at":"2018-04-15T17:10:07Z","closed_at":"2018-04-15T17:10:07Z","merged_at":"2018-04-15T17:10:07Z","merge_commit_sha":"611837e1a496699a5f39635466355d3aa5d7d518","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722352215,"url":"https://api.github.com/repos/alibaba/pouch/labels/LGTM","name":"LGTM","color":"88f486","default":false},{"id":684575943,"url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":729586101,"url":"https://api.github.com/repos/alibaba/pouch/labels/size/M","name":"size/M","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/alibaba/pouch/pulls/1112/commits","review_comments_url":"https://api.github.com/repos/alibaba/pouch/pulls/1112/comments","review_comment_url":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1112/comments","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/1f0f2f5cae02cd7e05f5f8cbdbd4bb9387019d46","head":{"label":"YaoZengzeng:fix-digest","ref":"fix-digest","sha":"1f0f2f5cae02cd7e05f5f8cbdbd4bb9387019d46","user":{"login":"YaoZengzeng","id":8636562,"avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"repo":{"id":111785477,"name":"pouch","full_name":"YaoZengzeng/pouch","owner":{"login":"YaoZengzeng","id":8636562,"avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YaoZengzeng/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":true,"url":"https://api.github.com/repos/YaoZengzeng/pouch","forks_url":"https://api.github.com/repos/YaoZengzeng/pouch/forks","keys_url":"https://api.github.com/repos/YaoZengzeng/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YaoZengzeng/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YaoZengzeng/pouch/teams","hooks_url":"https://api.github.com/repos/YaoZengzeng/pouch/hooks","issue_events_url":"https://api.github.com/repos/YaoZengzeng/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/YaoZengzeng/pouch/events","assignees_url":"https://api.github.com/repos/YaoZengzeng/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/YaoZengzeng/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/YaoZengzeng/pouch/tags","blobs_url":"https://api.github.com/repos/YaoZengzeng/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YaoZengzeng/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YaoZengzeng/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/YaoZengzeng/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YaoZengzeng/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/YaoZengzeng/pouch/languages","stargazers_url":"https://api.github.com/repos/YaoZengzeng/pouch/stargazers","contributors_url":"https://api.github.com/repos/YaoZengzeng/pouch/contributors","subscribers_url":"https://api.github.com/repos/YaoZengzeng/pouch/subscribers","subscription_url":"https://api.github.com/repos/YaoZengzeng/pouch/subscription","commits_url":"https://api.github.com/repos/YaoZengzeng/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/YaoZengzeng/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/YaoZengzeng/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/YaoZengzeng/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/YaoZengzeng/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/YaoZengzeng/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YaoZengzeng/pouch/merges","archive_url":"https://api.github.com/repos/YaoZengzeng/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YaoZengzeng/pouch/downloads","issues_url":"https://api.github.com/repos/YaoZengzeng/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/YaoZengzeng/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/YaoZengzeng/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/YaoZengzeng/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YaoZengzeng/pouch/labels{/name}","releases_url":"https://api.github.com/repos/YaoZengzeng/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/YaoZengzeng/pouch/deployments","created_at":"2017-11-23T08:50:18Z","updated_at":"2017-11-23T08:50:21Z","pushed_at":"2018-04-12T10:17:51Z","git_url":"git://github.com/YaoZengzeng/pouch.git","ssh_url":"git@github.com:YaoZengzeng/pouch.git","clone_url":"https://github.com/YaoZengzeng/pouch.git","svn_url":"https://github.com/YaoZengzeng/pouch","homepage":"","size":10388,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alibaba:master","ref":"master","sha":"e1434826d4f275a7a487b977fb49bed737375a16","user":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"repo":{"id":102555965,"name":"pouch","full_name":"alibaba/pouch","owner":{"login":"alibaba","id":1961952,"avatar_url":"https://avatars1.githubusercontent.com/u/1961952?v=4","gravatar_id":"","url":"https://api.github.com/users/alibaba","html_url":"https://github.com/alibaba","followers_url":"https://api.github.com/users/alibaba/followers","following_url":"https://api.github.com/users/alibaba/following{/other_user}","gists_url":"https://api.github.com/users/alibaba/gists{/gist_id}","starred_url":"https://api.github.com/users/alibaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alibaba/subscriptions","organizations_url":"https://api.github.com/users/alibaba/orgs","repos_url":"https://api.github.com/users/alibaba/repos","events_url":"https://api.github.com/users/alibaba/events{/privacy}","received_events_url":"https://api.github.com/users/alibaba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alibaba/pouch","description":"Pouch is an open-source project created to promote the container technology movement.","fork":false,"url":"https://api.github.com/repos/alibaba/pouch","forks_url":"https://api.github.com/repos/alibaba/pouch/forks","keys_url":"https://api.github.com/repos/alibaba/pouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alibaba/pouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alibaba/pouch/teams","hooks_url":"https://api.github.com/repos/alibaba/pouch/hooks","issue_events_url":"https://api.github.com/repos/alibaba/pouch/issues/events{/number}","events_url":"https://api.github.com/repos/alibaba/pouch/events","assignees_url":"https://api.github.com/repos/alibaba/pouch/assignees{/user}","branches_url":"https://api.github.com/repos/alibaba/pouch/branches{/branch}","tags_url":"https://api.github.com/repos/alibaba/pouch/tags","blobs_url":"https://api.github.com/repos/alibaba/pouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alibaba/pouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alibaba/pouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/alibaba/pouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alibaba/pouch/statuses/{sha}","languages_url":"https://api.github.com/repos/alibaba/pouch/languages","stargazers_url":"https://api.github.com/repos/alibaba/pouch/stargazers","contributors_url":"https://api.github.com/repos/alibaba/pouch/contributors","subscribers_url":"https://api.github.com/repos/alibaba/pouch/subscribers","subscription_url":"https://api.github.com/repos/alibaba/pouch/subscription","commits_url":"https://api.github.com/repos/alibaba/pouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/alibaba/pouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/alibaba/pouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/alibaba/pouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/alibaba/pouch/contents/{+path}","compare_url":"https://api.github.com/repos/alibaba/pouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alibaba/pouch/merges","archive_url":"https://api.github.com/repos/alibaba/pouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alibaba/pouch/downloads","issues_url":"https://api.github.com/repos/alibaba/pouch/issues{/number}","pulls_url":"https://api.github.com/repos/alibaba/pouch/pulls{/number}","milestones_url":"https://api.github.com/repos/alibaba/pouch/milestones{/number}","notifications_url":"https://api.github.com/repos/alibaba/pouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alibaba/pouch/labels{/name}","releases_url":"https://api.github.com/repos/alibaba/pouch/releases{/id}","deployments_url":"https://api.github.com/repos/alibaba/pouch/deployments","created_at":"2017-09-06T03:01:51Z","updated_at":"2018-04-15T12:53:49Z","pushed_at":"2018-04-15T17:10:07Z","git_url":"git://github.com/alibaba/pouch.git","ssh_url":"git@github.com:alibaba/pouch.git","clone_url":"https://github.com/alibaba/pouch.git","svn_url":"https://github.com/alibaba/pouch","homepage":"","size":8331,"stargazers_count":2406,"watchers_count":2406,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":434,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":434,"open_issues":97,"watchers":2406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1112"},"html":{"href":"https://github.com/alibaba/pouch/pull/1112"},"issue":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1112"},"comments":{"href":"https://api.github.com/repos/alibaba/pouch/issues/1112/comments"},"review_comments":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1112/comments"},"review_comment":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alibaba/pouch/pulls/1112/commits"},"statuses":{"href":"https://api.github.com/repos/alibaba/pouch/statuses/1f0f2f5cae02cd7e05f5f8cbdbd4bb9387019d46"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"allencloud","id":9465626,"avatar_url":"https://avatars3.githubusercontent.com/u/9465626?v=4","gravatar_id":"","url":"https://api.github.com/users/allencloud","html_url":"https://github.com/allencloud","followers_url":"https://api.github.com/users/allencloud/followers","following_url":"https://api.github.com/users/allencloud/following{/other_user}","gists_url":"https://api.github.com/users/allencloud/gists{/gist_id}","starred_url":"https://api.github.com/users/allencloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allencloud/subscriptions","organizations_url":"https://api.github.com/users/allencloud/orgs","repos_url":"https://api.github.com/users/allencloud/repos","events_url":"https://api.github.com/users/allencloud/events{/privacy}","received_events_url":"https://api.github.com/users/allencloud/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":29,"deletions":17,"changed_files":3}}
{"actor":{"display_login":"allencloud"}}