{"action":"created","comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments/196169248","pull_request_review_id":129671271,"id":196169248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE2OTI0OA==","diff_hunk":"@@ -27,12 +35,14 @@ class NotificationManager {\n         extension.windows.update(popup.id, { focused: true })\n       } else {\n         // create new notification popup\n-        extension.windows.create({\n+        let popUp = extension.windows.create({\n           url: 'notification.html',\n           type: 'popup',\n           width,\n           height,\n         })\n+\n+        popUp.then(this._onCreated)","path":"app/scripts/lib/notification-manager.js","position":27,"original_position":27,"commit_id":"1609f52f0e7c711c188da84dbe5fad2a4964864b","original_commit_id":"1609f52f0e7c711c188da84dbe5fad2a4964864b","user":{"login":"danfinlay","id":542863,"node_id":"MDQ6VXNlcjU0Mjg2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/542863?v=4","gravatar_id":"","url":"https://api.github.com/users/danfinlay","html_url":"https://github.com/danfinlay","followers_url":"https://api.github.com/users/danfinlay/followers","following_url":"https://api.github.com/users/danfinlay/following{/other_user}","gists_url":"https://api.github.com/users/danfinlay/gists{/gist_id}","starred_url":"https://api.github.com/users/danfinlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfinlay/subscriptions","organizations_url":"https://api.github.com/users/danfinlay/orgs","repos_url":"https://api.github.com/users/danfinlay/repos","events_url":"https://api.github.com/users/danfinlay/events{/privacy}","received_events_url":"https://api.github.com/users/danfinlay/received_events","type":"User","site_admin":false},"body":"Should handle failure. At least a simple case like:\r\n`.catch(log.error)`","created_at":"2018-06-18T17:54:56Z","updated_at":"2018-06-18T17:56:07Z","html_url":"https://github.com/MetaMask/metamask-extension/pull/4597#discussion_r196169248","pull_request_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments/196169248"},"html":{"href":"https://github.com/MetaMask/metamask-extension/pull/4597#discussion_r196169248"},"pull_request":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597"}}},"pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597","id":195375872,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mzc1ODcy","html_url":"https://github.com/MetaMask/metamask-extension/pull/4597","diff_url":"https://github.com/MetaMask/metamask-extension/pull/4597.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/4597.patch","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4597","number":4597,"state":"open","locked":false,"title":"Save popup window ID to check when closing the popup","user":{"login":"shad-k","id":23720732,"node_id":"MDQ6VXNlcjIzNzIwNzMy","avatar_url":"https://avatars1.githubusercontent.com/u/23720732?v=4","gravatar_id":"","url":"https://api.github.com/users/shad-k","html_url":"https://github.com/shad-k","followers_url":"https://api.github.com/users/shad-k/followers","following_url":"https://api.github.com/users/shad-k/following{/other_user}","gists_url":"https://api.github.com/users/shad-k/gists{/gist_id}","starred_url":"https://api.github.com/users/shad-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shad-k/subscriptions","organizations_url":"https://api.github.com/users/shad-k/orgs","repos_url":"https://api.github.com/users/shad-k/repos","events_url":"https://api.github.com/users/shad-k/events{/privacy}","received_events_url":"https://api.github.com/users/shad-k/received_events","type":"User","site_admin":false},"body":"Saving the popup window id from the window object passed to the resolve callback of the Promise returned by `windows.create()`.\r\n\r\nWe can go a step further and remove the looping over windows array and straightaway close the window with that has the saved ID (please advise if this can be done).\r\n\r\nFixes #4553","created_at":"2018-06-17T12:41:03Z","updated_at":"2018-06-18T17:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7496b977396f7b464ee2af2d50a94b81fb9aa24e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597/commits","review_comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597/comments","review_comment_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4597/comments","statuses_url":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/1609f52f0e7c711c188da84dbe5fad2a4964864b","head":{"label":"shad-k:fix/issue-4553","ref":"fix/issue-4553","sha":"1609f52f0e7c711c188da84dbe5fad2a4964864b","user":{"login":"shad-k","id":23720732,"node_id":"MDQ6VXNlcjIzNzIwNzMy","avatar_url":"https://avatars1.githubusercontent.com/u/23720732?v=4","gravatar_id":"","url":"https://api.github.com/users/shad-k","html_url":"https://github.com/shad-k","followers_url":"https://api.github.com/users/shad-k/followers","following_url":"https://api.github.com/users/shad-k/following{/other_user}","gists_url":"https://api.github.com/users/shad-k/gists{/gist_id}","starred_url":"https://api.github.com/users/shad-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shad-k/subscriptions","organizations_url":"https://api.github.com/users/shad-k/orgs","repos_url":"https://api.github.com/users/shad-k/repos","events_url":"https://api.github.com/users/shad-k/events{/privacy}","received_events_url":"https://api.github.com/users/shad-k/received_events","type":"User","site_admin":false},"repo":{"id":137627086,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2MjcwODY=","name":"metamask-extension","full_name":"shad-k/metamask-extension","owner":{"login":"shad-k","id":23720732,"node_id":"MDQ6VXNlcjIzNzIwNzMy","avatar_url":"https://avatars1.githubusercontent.com/u/23720732?v=4","gravatar_id":"","url":"https://api.github.com/users/shad-k","html_url":"https://github.com/shad-k","followers_url":"https://api.github.com/users/shad-k/followers","following_url":"https://api.github.com/users/shad-k/following{/other_user}","gists_url":"https://api.github.com/users/shad-k/gists{/gist_id}","starred_url":"https://api.github.com/users/shad-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shad-k/subscriptions","organizations_url":"https://api.github.com/users/shad-k/orgs","repos_url":"https://api.github.com/users/shad-k/repos","events_url":"https://api.github.com/users/shad-k/events{/privacy}","received_events_url":"https://api.github.com/users/shad-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shad-k/metamask-extension","description":":globe_with_meridians: :electric_plug: The MetaMask browser extension, enables browsing Ethereum blockchain enabled websites.","fork":true,"url":"https://api.github.com/repos/shad-k/metamask-extension","forks_url":"https://api.github.com/repos/shad-k/metamask-extension/forks","keys_url":"https://api.github.com/repos/shad-k/metamask-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shad-k/metamask-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shad-k/metamask-extension/teams","hooks_url":"https://api.github.com/repos/shad-k/metamask-extension/hooks","issue_events_url":"https://api.github.com/repos/shad-k/metamask-extension/issues/events{/number}","events_url":"https://api.github.com/repos/shad-k/metamask-extension/events","assignees_url":"https://api.github.com/repos/shad-k/metamask-extension/assignees{/user}","branches_url":"https://api.github.com/repos/shad-k/metamask-extension/branches{/branch}","tags_url":"https://api.github.com/repos/shad-k/metamask-extension/tags","blobs_url":"https://api.github.com/repos/shad-k/metamask-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shad-k/metamask-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shad-k/metamask-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/shad-k/metamask-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shad-k/metamask-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/shad-k/metamask-extension/languages","stargazers_url":"https://api.github.com/repos/shad-k/metamask-extension/stargazers","contributors_url":"https://api.github.com/repos/shad-k/metamask-extension/contributors","subscribers_url":"https://api.github.com/repos/shad-k/metamask-extension/subscribers","subscription_url":"https://api.github.com/repos/shad-k/metamask-extension/subscription","commits_url":"https://api.github.com/repos/shad-k/metamask-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/shad-k/metamask-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/shad-k/metamask-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/shad-k/metamask-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/shad-k/metamask-extension/contents/{+path}","compare_url":"https://api.github.com/repos/shad-k/metamask-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shad-k/metamask-extension/merges","archive_url":"https://api.github.com/repos/shad-k/metamask-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shad-k/metamask-extension/downloads","issues_url":"https://api.github.com/repos/shad-k/metamask-extension/issues{/number}","pulls_url":"https://api.github.com/repos/shad-k/metamask-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/shad-k/metamask-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/shad-k/metamask-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shad-k/metamask-extension/labels{/name}","releases_url":"https://api.github.com/repos/shad-k/metamask-extension/releases{/id}","deployments_url":"https://api.github.com/repos/shad-k/metamask-extension/deployments","created_at":"2018-06-17T03:48:02Z","updated_at":"2018-06-17T03:48:06Z","pushed_at":"2018-06-17T15:10:58Z","git_url":"git://github.com/shad-k/metamask-extension.git","ssh_url":"git@github.com:shad-k/metamask-extension.git","clone_url":"https://github.com/shad-k/metamask-extension.git","svn_url":"https://github.com/shad-k/metamask-extension","homepage":"https://metamask.io/","size":25932,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MetaMask:develop","ref":"develop","sha":"01c9d81c9feda0f80d3c2006fac208a00c1a64cb","user":{"login":"MetaMask","id":11744586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQ0NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":42009758,"node_id":"MDEwOlJlcG9zaXRvcnk0MjAwOTc1OA==","name":"metamask-extension","full_name":"MetaMask/metamask-extension","owner":{"login":"MetaMask","id":11744586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQ0NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/metamask-extension","description":":globe_with_meridians: :electric_plug: The MetaMask browser extension, enables browsing Ethereum blockchain enabled websites.","fork":false,"url":"https://api.github.com/repos/MetaMask/metamask-extension","forks_url":"https://api.github.com/repos/MetaMask/metamask-extension/forks","keys_url":"https://api.github.com/repos/MetaMask/metamask-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/metamask-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/metamask-extension/teams","hooks_url":"https://api.github.com/repos/MetaMask/metamask-extension/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/events","assignees_url":"https://api.github.com/repos/MetaMask/metamask-extension/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/metamask-extension/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/tags","blobs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/metamask-extension/languages","stargazers_url":"https://api.github.com/repos/MetaMask/metamask-extension/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/metamask-extension/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscription","commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/metamask-extension/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/metamask-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/metamask-extension/merges","archive_url":"https://api.github.com/repos/MetaMask/metamask-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/metamask-extension/downloads","issues_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/metamask-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/metamask-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/metamask-extension/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/metamask-extension/deployments","created_at":"2015-09-06T16:34:48Z","updated_at":"2018-06-18T17:29:17Z","pushed_at":"2018-06-18T17:52:10Z","git_url":"git://github.com/MetaMask/metamask-extension.git","ssh_url":"git@github.com:MetaMask/metamask-extension.git","clone_url":"https://github.com/MetaMask/metamask-extension.git","svn_url":"https://github.com/MetaMask/metamask-extension","homepage":"https://metamask.io/","size":25939,"stargazers_count":2162,"watchers_count":2162,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":573,"mirror_url":null,"archived":false,"open_issues_count":748,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":573,"open_issues":748,"watchers":2162,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597"},"html":{"href":"https://github.com/MetaMask/metamask-extension/pull/4597"},"issue":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4597"},"comments":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/issues/4597/comments"},"review_comments":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597/comments"},"review_comment":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/4597/commits"},"statuses":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/1609f52f0e7c711c188da84dbe5fad2a4964864b"}},"author_association":"NONE"}}
{"actor":{"display_login":"danfinlay"}}