{"action":"opened","number":366,"pull_request":{"url":"https://api.github.com/repos/ligato/cn-infra/pulls/366","id":242260352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMjYwMzUy","html_url":"https://github.com/ligato/cn-infra/pull/366","diff_url":"https://github.com/ligato/cn-infra/pull/366.diff","patch_url":"https://github.com/ligato/cn-infra/pull/366.patch","issue_url":"https://api.github.com/repos/ligato/cn-infra/issues/366","number":366,"state":"open","locked":false,"title":"plugin lookup resolves slice-type fields","user":{"login":"VladoLavor","id":15376606,"node_id":"MDQ6VXNlcjE1Mzc2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"body":"Plugin lookup does not process slice-type fields (or interfaces where the inner type is slice). Such a field was skipped and all potential plugins inside were ignored, which is causing some cases where the plugin order is still important because the plugin dependency order is not correct.\r\n\r\nExample:\r\nVPP plugin defines Publishers with type KeyProtoValWriter, which is an interface representing a list of kvdbsync plugins. Since those plugins were not included, the top level plugin has to define ETCDDataSync (or any other data sync) before the VPP plugin, otherwise, the resolution will fail on unmet dependencies.\r\n\r\nThis change also causes that the loading order of status check plugin and data sync plugins is reverted (status check defines KeyProtoValWriter, which was skipped before), so the registration was moved to AfterInit().\r\n\r\nSigned-off-by: Vladimir Lavor <vlavor@cisco.com>","created_at":"2019-01-04T13:18:44Z","updated_at":"2019-01-04T13:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"VladoLavor","id":15376606,"node_id":"MDQ6VXNlcjE1Mzc2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"assignees":[{"login":"VladoLavor","id":15376606,"node_id":"MDQ6VXNlcjE1Mzc2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":630498698,"node_id":"MDU6TGFiZWw2MzA0OTg2OTg=","url":"https://api.github.com/repos/ligato/cn-infra/labels/:bug:%20bug","name":":bug: bug","color":"ee0701","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ligato/cn-infra/pulls/366/commits","review_comments_url":"https://api.github.com/repos/ligato/cn-infra/pulls/366/comments","review_comment_url":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligato/cn-infra/issues/366/comments","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/fe4e43ca199f868c3241c73cd781817dc2c20f43","head":{"label":"VladoLavor:lookup","ref":"lookup","sha":"fe4e43ca199f868c3241c73cd781817dc2c20f43","user":{"login":"VladoLavor","id":15376606,"node_id":"MDQ6VXNlcjE1Mzc2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"repo":{"id":98873097,"node_id":"MDEwOlJlcG9zaXRvcnk5ODg3MzA5Nw==","name":"cn-infra","full_name":"VladoLavor/cn-infra","private":false,"owner":{"login":"VladoLavor","id":15376606,"node_id":"MDQ6VXNlcjE1Mzc2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VladoLavor/cn-infra","description":"Cloud-native Virtual Network Function (VNF) framework","fork":true,"url":"https://api.github.com/repos/VladoLavor/cn-infra","forks_url":"https://api.github.com/repos/VladoLavor/cn-infra/forks","keys_url":"https://api.github.com/repos/VladoLavor/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladoLavor/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladoLavor/cn-infra/teams","hooks_url":"https://api.github.com/repos/VladoLavor/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/VladoLavor/cn-infra/events","assignees_url":"https://api.github.com/repos/VladoLavor/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/VladoLavor/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/tags","blobs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladoLavor/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/VladoLavor/cn-infra/languages","stargazers_url":"https://api.github.com/repos/VladoLavor/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/VladoLavor/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscription","commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladoLavor/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladoLavor/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/VladoLavor/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladoLavor/cn-infra/merges","archive_url":"https://api.github.com/repos/VladoLavor/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladoLavor/cn-infra/downloads","issues_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/VladoLavor/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/VladoLavor/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/VladoLavor/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladoLavor/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/VladoLavor/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/VladoLavor/cn-infra/deployments","created_at":"2017-07-31T09:40:33Z","updated_at":"2018-12-12T08:46:56Z","pushed_at":"2019-01-04T13:04:49Z","git_url":"git://github.com/VladoLavor/cn-infra.git","ssh_url":"git@github.com:VladoLavor/cn-infra.git","clone_url":"https://github.com/VladoLavor/cn-infra.git","svn_url":"https://github.com/VladoLavor/cn-infra","homepage":"","size":76592,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ligato:master","ref":"master","sha":"f597195a15762fa2bb1ce5bfdd875ec96c63d153","user":{"login":"ligato","id":28989152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTg5MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"repo":{"id":94889501,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg4OTUwMQ==","name":"cn-infra","full_name":"ligato/cn-infra","private":false,"owner":{"login":"ligato","id":28989152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTg5MTUy","avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ligato/cn-infra","description":"Cloud-native platform for developing pluggable service agents ","fork":false,"url":"https://api.github.com/repos/ligato/cn-infra","forks_url":"https://api.github.com/repos/ligato/cn-infra/forks","keys_url":"https://api.github.com/repos/ligato/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligato/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligato/cn-infra/teams","hooks_url":"https://api.github.com/repos/ligato/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/ligato/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ligato/cn-infra/events","assignees_url":"https://api.github.com/repos/ligato/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ligato/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ligato/cn-infra/tags","blobs_url":"https://api.github.com/repos/ligato/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligato/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligato/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligato/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ligato/cn-infra/languages","stargazers_url":"https://api.github.com/repos/ligato/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/ligato/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/ligato/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/ligato/cn-infra/subscription","commits_url":"https://api.github.com/repos/ligato/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligato/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligato/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligato/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligato/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ligato/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligato/cn-infra/merges","archive_url":"https://api.github.com/repos/ligato/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligato/cn-infra/downloads","issues_url":"https://api.github.com/repos/ligato/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ligato/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ligato/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ligato/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligato/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/ligato/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ligato/cn-infra/deployments","created_at":"2017-06-20T12:37:37Z","updated_at":"2018-12-12T11:57:46Z","pushed_at":"2019-01-04T11:24:08Z","git_url":"git://github.com/ligato/cn-infra.git","ssh_url":"git@github.com:ligato/cn-infra.git","clone_url":"https://github.com/ligato/cn-infra.git","svn_url":"https://github.com/ligato/cn-infra","homepage":"","size":77063,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":28,"open_issues":6,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/366"},"html":{"href":"https://github.com/ligato/cn-infra/pull/366"},"issue":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/366"},"comments":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/ligato/cn-infra/statuses/fe4e43ca199f868c3241c73cd781817dc2c20f43"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":166,"deletions":89,"changed_files":6}}
{"actor":{"display_login":"VladoLavor"}}