{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/17884","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/17884/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/17884/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/17884/events","html_url":"https://github.com/facebook/react-native/pull/17884","id":294972605,"number":17884,"title":"Use ConcurrentHashMap for handling concurrent Android websockets, and…","user":{"login":"sunweiyang","id":12490625,"avatar_url":"https://avatars2.githubusercontent.com/u/12490625?v=4","gravatar_id":"","url":"https://api.github.com/users/sunweiyang","html_url":"https://github.com/sunweiyang","followers_url":"https://api.github.com/users/sunweiyang/followers","following_url":"https://api.github.com/users/sunweiyang/following{/other_user}","gists_url":"https://api.github.com/users/sunweiyang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunweiyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunweiyang/subscriptions","organizations_url":"https://api.github.com/users/sunweiyang/orgs","repos_url":"https://api.github.com/users/sunweiyang/repos","events_url":"https://api.github.com/users/sunweiyang/events{/privacy}","received_events_url":"https://api.github.com/users/sunweiyang/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":358768107,"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Started","name":"Import Started","color":"eeeeee","default":false},{"id":796430375,"url":"https://api.github.com/repos/facebook/react-native/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-07T01:19:31Z","updated_at":"2018-02-12T10:44:22Z","closed_at":"2018-02-09T22:48:58Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/17884","html_url":"https://github.com/facebook/react-native/pull/17884","diff_url":"https://github.com/facebook/react-native/pull/17884.diff","patch_url":"https://github.com/facebook/react-native/pull/17884.patch"},"body":"… prevent unknown websocket IDs from crashing on Android (show warning on development builds instead)\r\n\r\n## Motivation\r\n\r\nThis PR addresses #3346; an unknown websocket ID should produce a warning during development, but not cause crashes in production RN apps. This PR was created by @satya164's request, and was inspired by @tanthanh289's suggestion on #3346's thread.\r\n\r\n## Test Plan\r\n\r\nOn Android, create a websocket using a service like Pusher (`pusher-js` npm package) or manually, and then induce removal of its websocket ID. Result should be a red warning screen during development, and no crash in the app's release variant.\r\n\r\n## Release Notes\r\n\r\n [ANDROID] [BUGFIX] [WebSocket] - Prevent unknown websocket IDs from crashing on Android\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/364886391","html_url":"https://github.com/facebook/react-native/pull/17884#issuecomment-364886391","issue_url":"https://api.github.com/repos/facebook/react-native/issues/17884","id":364886391,"user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars2.githubusercontent.com/u/1174278?v=4","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T10:44:22Z","updated_at":"2018-02-12T10:44:22Z","author_association":"COLLABORATOR","body":"@yewenxiang23 modifying the files is not enough. you also need to compile from source https://facebook.github.io/react-native/docs/android-building-from-source.html"}}
{"actor":{"display_login":"satya164"}}