{"action":"created","comment":{"url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/comments/242685462","pull_request_review_id":186256803,"id":242685462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY4NTQ2Mg==","diff_hunk":"@@ -0,0 +1,17 @@\n+﻿using System.Threading.Tasks;\n+using Microsoft.Azure.KeyVault;\n+\n+namespace Arcus.Security.KeyVault.Factories\n+{\n+    /// <summary>\n+    /// Abstract class to create <see cref=\"KeyVaultClient\"/> object\n+    /// </summary>\n+    public abstract class KeyVaultClientFactory","path":"src/Arcus.Security.KeyVault/Factories/KeyVaultClientFactory.cs","position":9,"original_position":9,"commit_id":"617a9721d92e57b986d80a802c9713280e67a152","original_commit_id":"0fa514c922c668e50d3c95ecaa978f391eb5ec0c","user":{"login":"SamVanhoutte","id":3539605,"node_id":"MDQ6VXNlcjM1Mzk2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3539605?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVanhoutte","html_url":"https://github.com/SamVanhoutte","followers_url":"https://api.github.com/users/SamVanhoutte/followers","following_url":"https://api.github.com/users/SamVanhoutte/following{/other_user}","gists_url":"https://api.github.com/users/SamVanhoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVanhoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVanhoutte/subscriptions","organizations_url":"https://api.github.com/users/SamVanhoutte/orgs","repos_url":"https://api.github.com/users/SamVanhoutte/repos","events_url":"https://api.github.com/users/SamVanhoutte/events{/privacy}","received_events_url":"https://api.github.com/users/SamVanhoutte/received_events","type":"User","site_admin":false},"body":"Because I think there might be common methods that can fit there.  I hesitated and went for the abstract class (which is also quite common in Factory patterns - at least in the good old times :))","created_at":"2018-12-18T20:02:04Z","updated_at":"2018-12-18T20:02:04Z","html_url":"https://github.com/arcus-azure/arcus.security/pull/35#discussion_r242685462","pull_request_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/comments/242685462"},"html":{"href":"https://github.com/arcus-azure/arcus.security/pull/35#discussion_r242685462"},"pull_request":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35"}},"in_reply_to_id":242580006},"pull_request":{"url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35","id":239503796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTAzNzk2","html_url":"https://github.com/arcus-azure/arcus.security/pull/35","diff_url":"https://github.com/arcus-azure/arcus.security/pull/35.diff","patch_url":"https://github.com/arcus-azure/arcus.security/pull/35.patch","issue_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/35","number":35,"state":"open","locked":false,"title":"Key vault support","user":{"login":"SamVanhoutte","id":3539605,"node_id":"MDQ6VXNlcjM1Mzk2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3539605?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVanhoutte","html_url":"https://github.com/SamVanhoutte","followers_url":"https://api.github.com/users/SamVanhoutte/followers","following_url":"https://api.github.com/users/SamVanhoutte/following{/other_user}","gists_url":"https://api.github.com/users/SamVanhoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVanhoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVanhoutte/subscriptions","organizations_url":"https://api.github.com/users/SamVanhoutte/orgs","repos_url":"https://api.github.com/users/SamVanhoutte/repos","events_url":"https://api.github.com/users/SamVanhoutte/events{/privacy}","received_events_url":"https://api.github.com/users/SamVanhoutte/received_events","type":"User","site_admin":false},"body":"PR to implement issue #7 ","created_at":"2018-12-18T14:14:17Z","updated_at":"2018-12-18T20:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32285d98739309600c66764c1212aea1bc72b5f8","assignee":{"login":"SamVanhoutte","id":3539605,"node_id":"MDQ6VXNlcjM1Mzk2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3539605?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVanhoutte","html_url":"https://github.com/SamVanhoutte","followers_url":"https://api.github.com/users/SamVanhoutte/followers","following_url":"https://api.github.com/users/SamVanhoutte/following{/other_user}","gists_url":"https://api.github.com/users/SamVanhoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVanhoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVanhoutte/subscriptions","organizations_url":"https://api.github.com/users/SamVanhoutte/orgs","repos_url":"https://api.github.com/users/SamVanhoutte/repos","events_url":"https://api.github.com/users/SamVanhoutte/events{/privacy}","received_events_url":"https://api.github.com/users/SamVanhoutte/received_events","type":"User","site_admin":false},"assignees":[{"login":"SamVanhoutte","id":3539605,"node_id":"MDQ6VXNlcjM1Mzk2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3539605?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVanhoutte","html_url":"https://github.com/SamVanhoutte","followers_url":"https://api.github.com/users/SamVanhoutte/followers","following_url":"https://api.github.com/users/SamVanhoutte/following{/other_user}","gists_url":"https://api.github.com/users/SamVanhoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVanhoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVanhoutte/subscriptions","organizations_url":"https://api.github.com/users/SamVanhoutte/orgs","repos_url":"https://api.github.com/users/SamVanhoutte/repos","events_url":"https://api.github.com/users/SamVanhoutte/events{/privacy}","received_events_url":"https://api.github.com/users/SamVanhoutte/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1083308872,"node_id":"MDU6TGFiZWwxMDgzMzA4ODcy","url":"https://api.github.com/repos/arcus-azure/arcus.security/labels/feature","name":"feature","color":"594ed3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35/commits","review_comments_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35/comments","review_comment_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/35/comments","statuses_url":"https://api.github.com/repos/arcus-azure/arcus.security/statuses/617a9721d92e57b986d80a802c9713280e67a152","head":{"label":"arcus-azure:key-vault-support","ref":"key-vault-support","sha":"617a9721d92e57b986d80a802c9713280e67a152","user":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"repo":{"id":152071995,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNzE5OTU=","name":"arcus.security","full_name":"arcus-azure/arcus.security","private":false,"owner":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arcus-azure/arcus.security","description":"Security for Azure development in a breeze.","fork":false,"url":"https://api.github.com/repos/arcus-azure/arcus.security","forks_url":"https://api.github.com/repos/arcus-azure/arcus.security/forks","keys_url":"https://api.github.com/repos/arcus-azure/arcus.security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcus-azure/arcus.security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcus-azure/arcus.security/teams","hooks_url":"https://api.github.com/repos/arcus-azure/arcus.security/hooks","issue_events_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/events{/number}","events_url":"https://api.github.com/repos/arcus-azure/arcus.security/events","assignees_url":"https://api.github.com/repos/arcus-azure/arcus.security/assignees{/user}","branches_url":"https://api.github.com/repos/arcus-azure/arcus.security/branches{/branch}","tags_url":"https://api.github.com/repos/arcus-azure/arcus.security/tags","blobs_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcus-azure/arcus.security/statuses/{sha}","languages_url":"https://api.github.com/repos/arcus-azure/arcus.security/languages","stargazers_url":"https://api.github.com/repos/arcus-azure/arcus.security/stargazers","contributors_url":"https://api.github.com/repos/arcus-azure/arcus.security/contributors","subscribers_url":"https://api.github.com/repos/arcus-azure/arcus.security/subscribers","subscription_url":"https://api.github.com/repos/arcus-azure/arcus.security/subscription","commits_url":"https://api.github.com/repos/arcus-azure/arcus.security/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcus-azure/arcus.security/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/comments{/number}","contents_url":"https://api.github.com/repos/arcus-azure/arcus.security/contents/{+path}","compare_url":"https://api.github.com/repos/arcus-azure/arcus.security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcus-azure/arcus.security/merges","archive_url":"https://api.github.com/repos/arcus-azure/arcus.security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcus-azure/arcus.security/downloads","issues_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues{/number}","pulls_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls{/number}","milestones_url":"https://api.github.com/repos/arcus-azure/arcus.security/milestones{/number}","notifications_url":"https://api.github.com/repos/arcus-azure/arcus.security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcus-azure/arcus.security/labels{/name}","releases_url":"https://api.github.com/repos/arcus-azure/arcus.security/releases{/id}","deployments_url":"https://api.github.com/repos/arcus-azure/arcus.security/deployments","created_at":"2018-10-08T11:56:35Z","updated_at":"2018-12-17T12:27:06Z","pushed_at":"2018-12-18T18:13:21Z","git_url":"git://github.com/arcus-azure/arcus.security.git","ssh_url":"git@github.com:arcus-azure/arcus.security.git","clone_url":"https://github.com/arcus-azure/arcus.security.git","svn_url":"https://github.com/arcus-azure/arcus.security","homepage":"https://security.arcus-azure.net/","size":36,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"arcus-azure:master","ref":"master","sha":"70dda43e29fa62e4ff7098e28403d9b621f95be6","user":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"repo":{"id":152071995,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwNzE5OTU=","name":"arcus.security","full_name":"arcus-azure/arcus.security","private":false,"owner":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arcus-azure/arcus.security","description":"Security for Azure development in a breeze.","fork":false,"url":"https://api.github.com/repos/arcus-azure/arcus.security","forks_url":"https://api.github.com/repos/arcus-azure/arcus.security/forks","keys_url":"https://api.github.com/repos/arcus-azure/arcus.security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcus-azure/arcus.security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcus-azure/arcus.security/teams","hooks_url":"https://api.github.com/repos/arcus-azure/arcus.security/hooks","issue_events_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/events{/number}","events_url":"https://api.github.com/repos/arcus-azure/arcus.security/events","assignees_url":"https://api.github.com/repos/arcus-azure/arcus.security/assignees{/user}","branches_url":"https://api.github.com/repos/arcus-azure/arcus.security/branches{/branch}","tags_url":"https://api.github.com/repos/arcus-azure/arcus.security/tags","blobs_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcus-azure/arcus.security/statuses/{sha}","languages_url":"https://api.github.com/repos/arcus-azure/arcus.security/languages","stargazers_url":"https://api.github.com/repos/arcus-azure/arcus.security/stargazers","contributors_url":"https://api.github.com/repos/arcus-azure/arcus.security/contributors","subscribers_url":"https://api.github.com/repos/arcus-azure/arcus.security/subscribers","subscription_url":"https://api.github.com/repos/arcus-azure/arcus.security/subscription","commits_url":"https://api.github.com/repos/arcus-azure/arcus.security/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcus-azure/arcus.security/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcus-azure/arcus.security/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues/comments{/number}","contents_url":"https://api.github.com/repos/arcus-azure/arcus.security/contents/{+path}","compare_url":"https://api.github.com/repos/arcus-azure/arcus.security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcus-azure/arcus.security/merges","archive_url":"https://api.github.com/repos/arcus-azure/arcus.security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcus-azure/arcus.security/downloads","issues_url":"https://api.github.com/repos/arcus-azure/arcus.security/issues{/number}","pulls_url":"https://api.github.com/repos/arcus-azure/arcus.security/pulls{/number}","milestones_url":"https://api.github.com/repos/arcus-azure/arcus.security/milestones{/number}","notifications_url":"https://api.github.com/repos/arcus-azure/arcus.security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcus-azure/arcus.security/labels{/name}","releases_url":"https://api.github.com/repos/arcus-azure/arcus.security/releases{/id}","deployments_url":"https://api.github.com/repos/arcus-azure/arcus.security/deployments","created_at":"2018-10-08T11:56:35Z","updated_at":"2018-12-17T12:27:06Z","pushed_at":"2018-12-18T18:13:21Z","git_url":"git://github.com/arcus-azure/arcus.security.git","ssh_url":"git@github.com:arcus-azure/arcus.security.git","clone_url":"https://github.com/arcus-azure/arcus.security.git","svn_url":"https://github.com/arcus-azure/arcus.security","homepage":"https://security.arcus-azure.net/","size":36,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35"},"html":{"href":"https://github.com/arcus-azure/arcus.security/pull/35"},"issue":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/issues/35"},"comments":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/arcus-azure/arcus.security/statuses/617a9721d92e57b986d80a802c9713280e67a152"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SamVanhoutte"}}