{"action":"created","comment":{"url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/comments/228107625","pull_request_review_id":168297947,"id":228107625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODEwNzYyNQ==","diff_hunk":"@@ -19,11 +19,17 @@ public enum RecordingMode {\n     case missingVinyl(recordingPath: String?)\n }\n \n+public enum RecordingStrategy {\n+    case always\n+    case nonEmpty\n+}\n+\n public struct TurntableConfiguration {\n     \n     public let matchingStrategy: MatchingStrategy\n     public let recordingMode: RecordingMode\n-    \n+    public let recordingStrategy: RecordingStrategy","path":"Vinyl/TurntableConfiguration.swift","position":14,"original_position":14,"commit_id":"3b91222cbe1fc72a5750e1b2478a065eb174f9d4","original_commit_id":"3b91222cbe1fc72a5750e1b2478a065eb174f9d4","user":{"login":"ilyapuchka","id":1488293,"node_id":"MDQ6VXNlcjE0ODgyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1488293?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyapuchka","html_url":"https://github.com/ilyapuchka","followers_url":"https://api.github.com/users/ilyapuchka/followers","following_url":"https://api.github.com/users/ilyapuchka/following{/other_user}","gists_url":"https://api.github.com/users/ilyapuchka/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyapuchka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyapuchka/subscriptions","organizations_url":"https://api.github.com/users/ilyapuchka/orgs","repos_url":"https://api.github.com/users/ilyapuchka/repos","events_url":"https://api.github.com/users/ilyapuchka/events{/privacy}","received_events_url":"https://api.github.com/users/ilyapuchka/received_events","type":"User","site_admin":false},"body":"I'm fine with making it a default behaviour without any flag, if we would add a flag into recording mode it would be a breaking change that's why I went with another property. I'll update implementation.","created_at":"2018-10-25T09:52:34Z","updated_at":"2018-10-25T09:52:34Z","html_url":"https://github.com/Velhotes/Vinyl/pull/88#discussion_r228107625","pull_request_url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/comments/228107625"},"html":{"href":"https://github.com/Velhotes/Vinyl/pull/88#discussion_r228107625"},"pull_request":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88"}},"in_reply_to_id":228101129},"pull_request":{"url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88","id":225226228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjI2MjI4","html_url":"https://github.com/Velhotes/Vinyl/pull/88","diff_url":"https://github.com/Velhotes/Vinyl/pull/88.diff","patch_url":"https://github.com/Velhotes/Vinyl/pull/88.patch","issue_url":"https://api.github.com/repos/Velhotes/Vinyl/issues/88","number":88,"state":"open","locked":false,"title":"Add configuration to allow recording empty tracks","user":{"login":"ilyapuchka","id":1488293,"node_id":"MDQ6VXNlcjE0ODgyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1488293?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyapuchka","html_url":"https://github.com/ilyapuchka","followers_url":"https://api.github.com/users/ilyapuchka/followers","following_url":"https://api.github.com/users/ilyapuchka/following{/other_user}","gists_url":"https://api.github.com/users/ilyapuchka/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyapuchka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyapuchka/subscriptions","organizations_url":"https://api.github.com/users/ilyapuchka/orgs","repos_url":"https://api.github.com/users/ilyapuchka/repos","events_url":"https://api.github.com/users/ilyapuchka/events{/privacy}","received_events_url":"https://api.github.com/users/ilyapuchka/received_events","type":"User","site_admin":false},"body":"Resolves #86 ","created_at":"2018-10-24T00:11:34Z","updated_at":"2018-10-25T09:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"307e3c1cef33444bccbc1b4b2e69c037402e2bd4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88/commits","review_comments_url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88/comments","review_comment_url":"https://api.github.com/repos/Velhotes/Vinyl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Velhotes/Vinyl/issues/88/comments","statuses_url":"https://api.github.com/repos/Velhotes/Vinyl/statuses/3b91222cbe1fc72a5750e1b2478a065eb174f9d4","head":{"label":"ilyapuchka:record-empty","ref":"record-empty","sha":"3b91222cbe1fc72a5750e1b2478a065eb174f9d4","user":{"login":"ilyapuchka","id":1488293,"node_id":"MDQ6VXNlcjE0ODgyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1488293?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyapuchka","html_url":"https://github.com/ilyapuchka","followers_url":"https://api.github.com/users/ilyapuchka/followers","following_url":"https://api.github.com/users/ilyapuchka/following{/other_user}","gists_url":"https://api.github.com/users/ilyapuchka/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyapuchka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyapuchka/subscriptions","organizations_url":"https://api.github.com/users/ilyapuchka/orgs","repos_url":"https://api.github.com/users/ilyapuchka/repos","events_url":"https://api.github.com/users/ilyapuchka/events{/privacy}","received_events_url":"https://api.github.com/users/ilyapuchka/received_events","type":"User","site_admin":false},"repo":{"id":144863184,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4NjMxODQ=","name":"Vinyl","full_name":"ilyapuchka/Vinyl","private":false,"owner":{"login":"ilyapuchka","id":1488293,"node_id":"MDQ6VXNlcjE0ODgyOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1488293?v=4","gravatar_id":"","url":"https://api.github.com/users/ilyapuchka","html_url":"https://github.com/ilyapuchka","followers_url":"https://api.github.com/users/ilyapuchka/followers","following_url":"https://api.github.com/users/ilyapuchka/following{/other_user}","gists_url":"https://api.github.com/users/ilyapuchka/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyapuchka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyapuchka/subscriptions","organizations_url":"https://api.github.com/users/ilyapuchka/orgs","repos_url":"https://api.github.com/users/ilyapuchka/repos","events_url":"https://api.github.com/users/ilyapuchka/events{/privacy}","received_events_url":"https://api.github.com/users/ilyapuchka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ilyapuchka/Vinyl","description":"Network testing à la VCR in Swift ","fork":true,"url":"https://api.github.com/repos/ilyapuchka/Vinyl","forks_url":"https://api.github.com/repos/ilyapuchka/Vinyl/forks","keys_url":"https://api.github.com/repos/ilyapuchka/Vinyl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilyapuchka/Vinyl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilyapuchka/Vinyl/teams","hooks_url":"https://api.github.com/repos/ilyapuchka/Vinyl/hooks","issue_events_url":"https://api.github.com/repos/ilyapuchka/Vinyl/issues/events{/number}","events_url":"https://api.github.com/repos/ilyapuchka/Vinyl/events","assignees_url":"https://api.github.com/repos/ilyapuchka/Vinyl/assignees{/user}","branches_url":"https://api.github.com/repos/ilyapuchka/Vinyl/branches{/branch}","tags_url":"https://api.github.com/repos/ilyapuchka/Vinyl/tags","blobs_url":"https://api.github.com/repos/ilyapuchka/Vinyl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilyapuchka/Vinyl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilyapuchka/Vinyl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilyapuchka/Vinyl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilyapuchka/Vinyl/statuses/{sha}","languages_url":"https://api.github.com/repos/ilyapuchka/Vinyl/languages","stargazers_url":"https://api.github.com/repos/ilyapuchka/Vinyl/stargazers","contributors_url":"https://api.github.com/repos/ilyapuchka/Vinyl/contributors","subscribers_url":"https://api.github.com/repos/ilyapuchka/Vinyl/subscribers","subscription_url":"https://api.github.com/repos/ilyapuchka/Vinyl/subscription","commits_url":"https://api.github.com/repos/ilyapuchka/Vinyl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilyapuchka/Vinyl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilyapuchka/Vinyl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilyapuchka/Vinyl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilyapuchka/Vinyl/contents/{+path}","compare_url":"https://api.github.com/repos/ilyapuchka/Vinyl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilyapuchka/Vinyl/merges","archive_url":"https://api.github.com/repos/ilyapuchka/Vinyl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilyapuchka/Vinyl/downloads","issues_url":"https://api.github.com/repos/ilyapuchka/Vinyl/issues{/number}","pulls_url":"https://api.github.com/repos/ilyapuchka/Vinyl/pulls{/number}","milestones_url":"https://api.github.com/repos/ilyapuchka/Vinyl/milestones{/number}","notifications_url":"https://api.github.com/repos/ilyapuchka/Vinyl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilyapuchka/Vinyl/labels{/name}","releases_url":"https://api.github.com/repos/ilyapuchka/Vinyl/releases{/id}","deployments_url":"https://api.github.com/repos/ilyapuchka/Vinyl/deployments","created_at":"2018-08-15T14:25:50Z","updated_at":"2018-08-15T14:25:52Z","pushed_at":"2018-10-24T00:11:07Z","git_url":"git://github.com/ilyapuchka/Vinyl.git","ssh_url":"git@github.com:ilyapuchka/Vinyl.git","clone_url":"https://github.com/ilyapuchka/Vinyl.git","svn_url":"https://github.com/ilyapuchka/Vinyl","homepage":"","size":241,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Velhotes:master","ref":"master","sha":"96cd2a9131bc5ea1ea3217da4486d0091d9d00a9","user":{"login":"Velhotes","id":17044788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQ0Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/17044788?v=4","gravatar_id":"","url":"https://api.github.com/users/Velhotes","html_url":"https://github.com/Velhotes","followers_url":"https://api.github.com/users/Velhotes/followers","following_url":"https://api.github.com/users/Velhotes/following{/other_user}","gists_url":"https://api.github.com/users/Velhotes/gists{/gist_id}","starred_url":"https://api.github.com/users/Velhotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Velhotes/subscriptions","organizations_url":"https://api.github.com/users/Velhotes/orgs","repos_url":"https://api.github.com/users/Velhotes/repos","events_url":"https://api.github.com/users/Velhotes/events{/privacy}","received_events_url":"https://api.github.com/users/Velhotes/received_events","type":"Organization","site_admin":false},"repo":{"id":51582217,"node_id":"MDEwOlJlcG9zaXRvcnk1MTU4MjIxNw==","name":"Vinyl","full_name":"Velhotes/Vinyl","private":false,"owner":{"login":"Velhotes","id":17044788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDQ0Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/17044788?v=4","gravatar_id":"","url":"https://api.github.com/users/Velhotes","html_url":"https://github.com/Velhotes","followers_url":"https://api.github.com/users/Velhotes/followers","following_url":"https://api.github.com/users/Velhotes/following{/other_user}","gists_url":"https://api.github.com/users/Velhotes/gists{/gist_id}","starred_url":"https://api.github.com/users/Velhotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Velhotes/subscriptions","organizations_url":"https://api.github.com/users/Velhotes/orgs","repos_url":"https://api.github.com/users/Velhotes/repos","events_url":"https://api.github.com/users/Velhotes/events{/privacy}","received_events_url":"https://api.github.com/users/Velhotes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Velhotes/Vinyl","description":"Network testing à la VCR in Swift ","fork":false,"url":"https://api.github.com/repos/Velhotes/Vinyl","forks_url":"https://api.github.com/repos/Velhotes/Vinyl/forks","keys_url":"https://api.github.com/repos/Velhotes/Vinyl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Velhotes/Vinyl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Velhotes/Vinyl/teams","hooks_url":"https://api.github.com/repos/Velhotes/Vinyl/hooks","issue_events_url":"https://api.github.com/repos/Velhotes/Vinyl/issues/events{/number}","events_url":"https://api.github.com/repos/Velhotes/Vinyl/events","assignees_url":"https://api.github.com/repos/Velhotes/Vinyl/assignees{/user}","branches_url":"https://api.github.com/repos/Velhotes/Vinyl/branches{/branch}","tags_url":"https://api.github.com/repos/Velhotes/Vinyl/tags","blobs_url":"https://api.github.com/repos/Velhotes/Vinyl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Velhotes/Vinyl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Velhotes/Vinyl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Velhotes/Vinyl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Velhotes/Vinyl/statuses/{sha}","languages_url":"https://api.github.com/repos/Velhotes/Vinyl/languages","stargazers_url":"https://api.github.com/repos/Velhotes/Vinyl/stargazers","contributors_url":"https://api.github.com/repos/Velhotes/Vinyl/contributors","subscribers_url":"https://api.github.com/repos/Velhotes/Vinyl/subscribers","subscription_url":"https://api.github.com/repos/Velhotes/Vinyl/subscription","commits_url":"https://api.github.com/repos/Velhotes/Vinyl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Velhotes/Vinyl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Velhotes/Vinyl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Velhotes/Vinyl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Velhotes/Vinyl/contents/{+path}","compare_url":"https://api.github.com/repos/Velhotes/Vinyl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Velhotes/Vinyl/merges","archive_url":"https://api.github.com/repos/Velhotes/Vinyl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Velhotes/Vinyl/downloads","issues_url":"https://api.github.com/repos/Velhotes/Vinyl/issues{/number}","pulls_url":"https://api.github.com/repos/Velhotes/Vinyl/pulls{/number}","milestones_url":"https://api.github.com/repos/Velhotes/Vinyl/milestones{/number}","notifications_url":"https://api.github.com/repos/Velhotes/Vinyl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Velhotes/Vinyl/labels{/name}","releases_url":"https://api.github.com/repos/Velhotes/Vinyl/releases{/id}","deployments_url":"https://api.github.com/repos/Velhotes/Vinyl/deployments","created_at":"2016-02-12T10:58:16Z","updated_at":"2018-10-12T07:40:42Z","pushed_at":"2018-10-24T00:11:35Z","git_url":"git://github.com/Velhotes/Vinyl.git","ssh_url":"git@github.com:Velhotes/Vinyl.git","clone_url":"https://github.com/Velhotes/Vinyl.git","svn_url":"https://github.com/Velhotes/Vinyl","homepage":"","size":246,"stargazers_count":219,"watchers_count":219,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":10,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88"},"html":{"href":"https://github.com/Velhotes/Vinyl/pull/88"},"issue":{"href":"https://api.github.com/repos/Velhotes/Vinyl/issues/88"},"comments":{"href":"https://api.github.com/repos/Velhotes/Vinyl/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Velhotes/Vinyl/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/Velhotes/Vinyl/statuses/3b91222cbe1fc72a5750e1b2478a065eb174f9d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilyapuchka"}}