{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/3947","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/3947/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/3947/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/3947/events","html_url":"https://github.com/LMMS/lmms/pull/3947","id":271648673,"number":3947,"title":"Enable sample track recording","user":{"login":"Reflexe","id":22856488,"avatar_url":"https://avatars1.githubusercontent.com/u/22856488?v=4","gravatar_id":"","url":"https://api.github.com/users/Reflexe","html_url":"https://github.com/Reflexe","followers_url":"https://api.github.com/users/Reflexe/followers","following_url":"https://api.github.com/users/Reflexe/following{/other_user}","gists_url":"https://api.github.com/users/Reflexe/gists{/gist_id}","starred_url":"https://api.github.com/users/Reflexe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reflexe/subscriptions","organizations_url":"https://api.github.com/users/Reflexe/orgs","repos_url":"https://api.github.com/users/Reflexe/repos","events_url":"https://api.github.com/users/Reflexe/events{/privacy}","received_events_url":"https://api.github.com/users/Reflexe/received_events","type":"User","site_admin":false},"labels":[{"id":74198045,"url":"https://api.github.com/repos/LMMS/lmms/labels/enhancement","name":"enhancement","color":"0052cc","default":true},{"id":322422033,"url":"https://api.github.com/repos/LMMS/lmms/labels/in%20progress","name":"in progress","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/LMMS/lmms/milestones/4","html_url":"https://github.com/LMMS/lmms/milestone/4","labels_url":"https://api.github.com/repos/LMMS/lmms/milestones/4/labels","id":614544,"number":4,"title":"1.3.0","description":"","creator":{"login":"diizy","id":6368868,"avatar_url":"https://avatars3.githubusercontent.com/u/6368868?v=4","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"open_issues":104,"closed_issues":53,"state":"open","created_at":"2014-03-30T19:00:44Z","updated_at":"2018-05-18T17:40:22Z","due_on":null,"closed_at":null},"comments":42,"created_at":"2017-11-06T22:48:26Z","updated_at":"2018-05-22T13:19:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/3947","html_url":"https://github.com/LMMS/lmms/pull/3947","diff_url":"https://github.com/LMMS/lmms/pull/3947.diff","patch_url":"https://github.com/LMMS/lmms/pull/3947.patch"},"body":"## Download links for testing: \r\n[here](https://github.com/Reflexe/lmms/releases/tag/recording-2).\r\n\r\nmany thanks to @tresf!\r\n\r\n## Progress\r\n- [x] Make recording work.\r\n- [x] Support capture in major interfaces:\r\n  - [x] JACK\r\n  - [x] PulseAudio\r\n  - [x] SDL\r\n- [x] Make recording usable for humans\r\n    - [x] Recording should record into a new TCO in the *track* or tracks that has been marked as record.  \r\n        - [x] ~~If no track was marked, it shall create a new track and mark it as record~~.\r\n    - [x] (Optional) Leave a way to record into a specific TCO (the current behaviour).\r\n         -  [x] (Optional) Change the color of a TCO that has been set as record.\r\n    - [x] ~~(Need to decide about the correct behaviour) Record according to another sample track: start and stop according to it.~~\r\n    - [x] ~~Add per sample track audio channel modifiers (e.g. solo right, right both).~~\r\n    - [x] Hide the regular record button on the song editor.\r\n\r\n## Issues\r\n - [x] JACK does not connect lmms to the system input by default.\r\n - [x] Sometimes with SDL, a few seconds last does not get captured by lmms. (most of the times)\r\n - [x] For some reason, choosing a global record channel does not work correctly. \r\nCloses #3943\r\n  "},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/390986657","html_url":"https://github.com/LMMS/lmms/pull/3947#issuecomment-390986657","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/3947","id":390986657,"user":{"login":"PhysSong","id":12591074,"avatar_url":"https://avatars3.githubusercontent.com/u/12591074?v=4","gravatar_id":"","url":"https://api.github.com/users/PhysSong","html_url":"https://github.com/PhysSong","followers_url":"https://api.github.com/users/PhysSong/followers","following_url":"https://api.github.com/users/PhysSong/following{/other_user}","gists_url":"https://api.github.com/users/PhysSong/gists{/gist_id}","starred_url":"https://api.github.com/users/PhysSong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhysSong/subscriptions","organizations_url":"https://api.github.com/users/PhysSong/orgs","repos_url":"https://api.github.com/users/PhysSong/repos","events_url":"https://api.github.com/users/PhysSong/events{/privacy}","received_events_url":"https://api.github.com/users/PhysSong/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T13:19:15Z","updated_at":"2018-05-22T13:19:15Z","author_association":"MEMBER","body":"In current implementation, every `SampleBuffer` instance will resample its data when processing sample rate is changed. For recorded data, I wonder if repetitive resampling may affect audio quality."}}
{"actor":{"display_login":"PhysSong"}}