{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/3655","repository_url":"https://api.github.com/repos/palantir/atlasdb","labels_url":"https://api.github.com/repos/palantir/atlasdb/issues/3655/labels{/name}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/3655/comments","events_url":"https://api.github.com/repos/palantir/atlasdb/issues/3655/events","html_url":"https://github.com/palantir/atlasdb/pull/3655","id":384392646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjA1ODM4","number":3655,"title":"Quick attempt at shutdown hooks.","user":{"login":"jkozlowski","id":690973,"node_id":"MDQ6VXNlcjY5MDk3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/690973?v=4","gravatar_id":"","url":"https://api.github.com/users/jkozlowski","html_url":"https://github.com/jkozlowski","followers_url":"https://api.github.com/users/jkozlowski/followers","following_url":"https://api.github.com/users/jkozlowski/following{/other_user}","gists_url":"https://api.github.com/users/jkozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jkozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkozlowski/subscriptions","organizations_url":"https://api.github.com/users/jkozlowski/orgs","repos_url":"https://api.github.com/users/jkozlowski/repos","events_url":"https://api.github.com/users/jkozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/jkozlowski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-26T15:51:57Z","updated_at":"2018-11-27T12:15:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/3655","html_url":"https://github.com/palantir/atlasdb/pull/3655","diff_url":"https://github.com/palantir/atlasdb/pull/3655.diff","patch_url":"https://github.com/palantir/atlasdb/pull/3655.patch"},"body":"**Goals (and why)**:\r\n\r\nThis might be buggy, but wanted to throw something together before I leave.\r\n\r\n**Implementation Description (bullets)**:\r\n\r\n**Testing (What was existing testing like?  What have you done to improve it?)**:\r\n\r\n**Concerns (what feedback would you like?)**:\r\n\r\n* I'm wondering though how important these are vs. hooking into the web server hooks to actually shutdown cleanly. This kind of functionality should really live there and TransactionManager should really be just another thing that needs to be shutdown cleanly. So maybe we should instead make sure TransactionManager can be cleanly hooked into the server's lifetime: make some sort of a dev break that forces you to hook into some sort of lifecycle manager.\r\n\r\n**Where should we start reviewing?**:\r\n\r\n**Priority (whenever / two weeks / yesterday)**:\r\n\r\n<!---\r\nPlease remember to:\r\n- Add any necessary release notes (including breaking changes)\r\n- Make sure the documentation is up to date for your change\r\n--->\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/atlasdb/issues/comments/442037595","html_url":"https://github.com/palantir/atlasdb/pull/3655#issuecomment-442037595","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/3655","id":442037595,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjAzNzU5NQ==","user":{"login":"jkozlowski","id":690973,"node_id":"MDQ6VXNlcjY5MDk3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/690973?v=4","gravatar_id":"","url":"https://api.github.com/users/jkozlowski","html_url":"https://github.com/jkozlowski","followers_url":"https://api.github.com/users/jkozlowski/followers","following_url":"https://api.github.com/users/jkozlowski/following{/other_user}","gists_url":"https://api.github.com/users/jkozlowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jkozlowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkozlowski/subscriptions","organizations_url":"https://api.github.com/users/jkozlowski/orgs","repos_url":"https://api.github.com/users/jkozlowski/repos","events_url":"https://api.github.com/users/jkozlowski/events{/privacy}","received_events_url":"https://api.github.com/users/jkozlowski/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T12:15:11Z","updated_at":"2018-11-27T12:15:11Z","author_association":"CONTRIBUTOR","body":"Ok, are we good to close this then and agree that the state of the world is now OK with my previous change? Or is there some followup to be had"}}
{"actor":{"display_login":"jkozlowski"}}