{"action":"closed","number":397,"pull_request":{"url":"https://api.github.com/repos/poetapp/explorer-web/pulls/397","id":229543387,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTQzMzg3","html_url":"https://github.com/poetapp/explorer-web/pull/397","diff_url":"https://github.com/poetapp/explorer-web/pull/397.diff","patch_url":"https://github.com/poetapp/explorer-web/pull/397.patch","issue_url":"https://api.github.com/repos/poetapp/explorer-web/issues/397","number":397,"state":"closed","locked":false,"title":"Allow ENV Variables","user":{"login":"jwicks31","id":33884732,"node_id":"MDQ6VXNlcjMzODg0NzMy","avatar_url":"https://avatars3.githubusercontent.com/u/33884732?v=4","gravatar_id":"","url":"https://api.github.com/users/jwicks31","html_url":"https://github.com/jwicks31","followers_url":"https://api.github.com/users/jwicks31/followers","following_url":"https://api.github.com/users/jwicks31/following{/other_user}","gists_url":"https://api.github.com/users/jwicks31/gists{/gist_id}","starred_url":"https://api.github.com/users/jwicks31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwicks31/subscriptions","organizations_url":"https://api.github.com/users/jwicks31/orgs","repos_url":"https://api.github.com/users/jwicks31/repos","events_url":"https://api.github.com/users/jwicks31/events{/privacy}","received_events_url":"https://api.github.com/users/jwicks31/received_events","type":"User","site_admin":false},"body":"[PR Process](https://github.com/poetapp/documentation/blob/master/process/pr-review.md#pr-process) - [PR Review Checklist](https://github.com/poetapp/documentation/blob/master/process/pr-review.md#pr-review-checklist)\r\n\r\n## Description of Changes\r\n\r\nThe Following Changes Are Introduced In [ANOTHER PR](https://github.com/poetapp/explorer-web/pull/376). I needed those changes to continue with this PR. To make this PR easier to review, it will probably be best to review [the first pr](https://github.com/poetapp/explorer-web/pull/376) and merge it in. \r\n- Removed Netlify Redirects and Proxy for Frost-Api \r\n\r\nThese Changes Are New to THIS PR. The bulk of which is in the `Configuration.ts` file\r\n- Added `FROST_API_URL` and `API_URL` to `webpack.DefinePlugin`\r\n- Added getConfigurationWithDefaults function to the Configuration file. This merges the defaultConfiguration and the configuration from the `webpack.DefinePlugin`. This allows us to pass in the `FROST_API_URL` and `API_URL` or any other environment variables we wish to define in `webpack.DefinePlugin`. The files are overridden in the order they are listed. `getConfigurationWithDefaults` is  mostly the same as frost-api/node.\r\n- Added unit tests for getConfigurationWithDefaults\r\n\r\n<!-- Remove the back-ticks (`) to link one or more issues fixed/resolved by this PR (or delete if not applicable) -->\r\nResolves #398 \r\n\r\n<!-- Describe your changes below in a reasonable amount of detail -->\r\n\r\nAny new variables that need to be handled this way will have to be defined in the `webpack.DefinePlugin` and the `defaultConfiguration`\r\n\r\n### Warning\r\n\r\nMerging to `master` automatically triggers a deploy in production.\r\n","created_at":"2018-11-08T23:34:56Z","updated_at":"2018-11-14T15:40:46Z","closed_at":"2018-11-14T15:40:45Z","merged_at":"2018-11-14T15:40:45Z","merge_commit_sha":"69909548ba658b822b6ced191f2b5ef4d3474653","assignee":{"login":"jwicks31","id":33884732,"node_id":"MDQ6VXNlcjMzODg0NzMy","avatar_url":"https://avatars3.githubusercontent.com/u/33884732?v=4","gravatar_id":"","url":"https://api.github.com/users/jwicks31","html_url":"https://github.com/jwicks31","followers_url":"https://api.github.com/users/jwicks31/followers","following_url":"https://api.github.com/users/jwicks31/following{/other_user}","gists_url":"https://api.github.com/users/jwicks31/gists{/gist_id}","starred_url":"https://api.github.com/users/jwicks31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwicks31/subscriptions","organizations_url":"https://api.github.com/users/jwicks31/orgs","repos_url":"https://api.github.com/users/jwicks31/repos","events_url":"https://api.github.com/users/jwicks31/events{/privacy}","received_events_url":"https://api.github.com/users/jwicks31/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwicks31","id":33884732,"node_id":"MDQ6VXNlcjMzODg0NzMy","avatar_url":"https://avatars3.githubusercontent.com/u/33884732?v=4","gravatar_id":"","url":"https://api.github.com/users/jwicks31","html_url":"https://github.com/jwicks31","followers_url":"https://api.github.com/users/jwicks31/followers","following_url":"https://api.github.com/users/jwicks31/following{/other_user}","gists_url":"https://api.github.com/users/jwicks31/gists{/gist_id}","starred_url":"https://api.github.com/users/jwicks31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwicks31/subscriptions","organizations_url":"https://api.github.com/users/jwicks31/orgs","repos_url":"https://api.github.com/users/jwicks31/repos","events_url":"https://api.github.com/users/jwicks31/events{/privacy}","received_events_url":"https://api.github.com/users/jwicks31/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lautarodragan","id":2279687,"node_id":"MDQ6VXNlcjIyNzk2ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/2279687?v=4","gravatar_id":"","url":"https://api.github.com/users/lautarodragan","html_url":"https://github.com/lautarodragan","followers_url":"https://api.github.com/users/lautarodragan/followers","following_url":"https://api.github.com/users/lautarodragan/following{/other_user}","gists_url":"https://api.github.com/users/lautarodragan/gists{/gist_id}","starred_url":"https://api.github.com/users/lautarodragan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lautarodragan/subscriptions","organizations_url":"https://api.github.com/users/lautarodragan/orgs","repos_url":"https://api.github.com/users/lautarodragan/repos","events_url":"https://api.github.com/users/lautarodragan/events{/privacy}","received_events_url":"https://api.github.com/users/lautarodragan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poetapp/explorer-web/pulls/397/commits","review_comments_url":"https://api.github.com/repos/poetapp/explorer-web/pulls/397/comments","review_comment_url":"https://api.github.com/repos/poetapp/explorer-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poetapp/explorer-web/issues/397/comments","statuses_url":"https://api.github.com/repos/poetapp/explorer-web/statuses/4061da7ab29e1bafa8f6f8132a39424c2c2e2f4f","head":{"label":"poetapp:env-variables","ref":"env-variables","sha":"4061da7ab29e1bafa8f6f8132a39424c2c2e2f4f","user":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"repo":{"id":95156438,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE1NjQzOA==","name":"explorer-web","full_name":"poetapp/explorer-web","private":false,"owner":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poetapp/explorer-web","description":"Po.et's web application to view claims on the Po.et Network","fork":false,"url":"https://api.github.com/repos/poetapp/explorer-web","forks_url":"https://api.github.com/repos/poetapp/explorer-web/forks","keys_url":"https://api.github.com/repos/poetapp/explorer-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poetapp/explorer-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poetapp/explorer-web/teams","hooks_url":"https://api.github.com/repos/poetapp/explorer-web/hooks","issue_events_url":"https://api.github.com/repos/poetapp/explorer-web/issues/events{/number}","events_url":"https://api.github.com/repos/poetapp/explorer-web/events","assignees_url":"https://api.github.com/repos/poetapp/explorer-web/assignees{/user}","branches_url":"https://api.github.com/repos/poetapp/explorer-web/branches{/branch}","tags_url":"https://api.github.com/repos/poetapp/explorer-web/tags","blobs_url":"https://api.github.com/repos/poetapp/explorer-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poetapp/explorer-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poetapp/explorer-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/poetapp/explorer-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poetapp/explorer-web/statuses/{sha}","languages_url":"https://api.github.com/repos/poetapp/explorer-web/languages","stargazers_url":"https://api.github.com/repos/poetapp/explorer-web/stargazers","contributors_url":"https://api.github.com/repos/poetapp/explorer-web/contributors","subscribers_url":"https://api.github.com/repos/poetapp/explorer-web/subscribers","subscription_url":"https://api.github.com/repos/poetapp/explorer-web/subscription","commits_url":"https://api.github.com/repos/poetapp/explorer-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/poetapp/explorer-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/poetapp/explorer-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/poetapp/explorer-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/poetapp/explorer-web/contents/{+path}","compare_url":"https://api.github.com/repos/poetapp/explorer-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poetapp/explorer-web/merges","archive_url":"https://api.github.com/repos/poetapp/explorer-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poetapp/explorer-web/downloads","issues_url":"https://api.github.com/repos/poetapp/explorer-web/issues{/number}","pulls_url":"https://api.github.com/repos/poetapp/explorer-web/pulls{/number}","milestones_url":"https://api.github.com/repos/poetapp/explorer-web/milestones{/number}","notifications_url":"https://api.github.com/repos/poetapp/explorer-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poetapp/explorer-web/labels{/name}","releases_url":"https://api.github.com/repos/poetapp/explorer-web/releases{/id}","deployments_url":"https://api.github.com/repos/poetapp/explorer-web/deployments","created_at":"2017-06-22T21:04:58Z","updated_at":"2018-11-14T15:00:10Z","pushed_at":"2018-11-14T15:40:45Z","git_url":"git://github.com/poetapp/explorer-web.git","ssh_url":"git@github.com:poetapp/explorer-web.git","clone_url":"https://github.com/poetapp/explorer-web.git","svn_url":"https://github.com/poetapp/explorer-web","homepage":"https://explorer.po.et","size":5661,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":15,"watchers":22,"default_branch":"master"}},"base":{"label":"poetapp:master","ref":"master","sha":"cbcc7e8cddf30c558cdeac8f43dc390c62521eba","user":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"repo":{"id":95156438,"node_id":"MDEwOlJlcG9zaXRvcnk5NTE1NjQzOA==","name":"explorer-web","full_name":"poetapp/explorer-web","private":false,"owner":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poetapp/explorer-web","description":"Po.et's web application to view claims on the Po.et Network","fork":false,"url":"https://api.github.com/repos/poetapp/explorer-web","forks_url":"https://api.github.com/repos/poetapp/explorer-web/forks","keys_url":"https://api.github.com/repos/poetapp/explorer-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poetapp/explorer-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poetapp/explorer-web/teams","hooks_url":"https://api.github.com/repos/poetapp/explorer-web/hooks","issue_events_url":"https://api.github.com/repos/poetapp/explorer-web/issues/events{/number}","events_url":"https://api.github.com/repos/poetapp/explorer-web/events","assignees_url":"https://api.github.com/repos/poetapp/explorer-web/assignees{/user}","branches_url":"https://api.github.com/repos/poetapp/explorer-web/branches{/branch}","tags_url":"https://api.github.com/repos/poetapp/explorer-web/tags","blobs_url":"https://api.github.com/repos/poetapp/explorer-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poetapp/explorer-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poetapp/explorer-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/poetapp/explorer-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poetapp/explorer-web/statuses/{sha}","languages_url":"https://api.github.com/repos/poetapp/explorer-web/languages","stargazers_url":"https://api.github.com/repos/poetapp/explorer-web/stargazers","contributors_url":"https://api.github.com/repos/poetapp/explorer-web/contributors","subscribers_url":"https://api.github.com/repos/poetapp/explorer-web/subscribers","subscription_url":"https://api.github.com/repos/poetapp/explorer-web/subscription","commits_url":"https://api.github.com/repos/poetapp/explorer-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/poetapp/explorer-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/poetapp/explorer-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/poetapp/explorer-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/poetapp/explorer-web/contents/{+path}","compare_url":"https://api.github.com/repos/poetapp/explorer-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poetapp/explorer-web/merges","archive_url":"https://api.github.com/repos/poetapp/explorer-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poetapp/explorer-web/downloads","issues_url":"https://api.github.com/repos/poetapp/explorer-web/issues{/number}","pulls_url":"https://api.github.com/repos/poetapp/explorer-web/pulls{/number}","milestones_url":"https://api.github.com/repos/poetapp/explorer-web/milestones{/number}","notifications_url":"https://api.github.com/repos/poetapp/explorer-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poetapp/explorer-web/labels{/name}","releases_url":"https://api.github.com/repos/poetapp/explorer-web/releases{/id}","deployments_url":"https://api.github.com/repos/poetapp/explorer-web/deployments","created_at":"2017-06-22T21:04:58Z","updated_at":"2018-11-14T15:00:10Z","pushed_at":"2018-11-14T15:40:45Z","git_url":"git://github.com/poetapp/explorer-web.git","ssh_url":"git@github.com:poetapp/explorer-web.git","clone_url":"https://github.com/poetapp/explorer-web.git","svn_url":"https://github.com/poetapp/explorer-web","homepage":"https://explorer.po.et","size":5661,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":15,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poetapp/explorer-web/pulls/397"},"html":{"href":"https://github.com/poetapp/explorer-web/pull/397"},"issue":{"href":"https://api.github.com/repos/poetapp/explorer-web/issues/397"},"comments":{"href":"https://api.github.com/repos/poetapp/explorer-web/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/poetapp/explorer-web/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/poetapp/explorer-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poetapp/explorer-web/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/poetapp/explorer-web/statuses/4061da7ab29e1bafa8f6f8132a39424c2c2e2f4f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jwicks31","id":33884732,"node_id":"MDQ6VXNlcjMzODg0NzMy","avatar_url":"https://avatars3.githubusercontent.com/u/33884732?v=4","gravatar_id":"","url":"https://api.github.com/users/jwicks31","html_url":"https://github.com/jwicks31","followers_url":"https://api.github.com/users/jwicks31/followers","following_url":"https://api.github.com/users/jwicks31/following{/other_user}","gists_url":"https://api.github.com/users/jwicks31/gists{/gist_id}","starred_url":"https://api.github.com/users/jwicks31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwicks31/subscriptions","organizations_url":"https://api.github.com/users/jwicks31/orgs","repos_url":"https://api.github.com/users/jwicks31/repos","events_url":"https://api.github.com/users/jwicks31/events{/privacy}","received_events_url":"https://api.github.com/users/jwicks31/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":19,"additions":153,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"jwicks31"}}