{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hive/pulls/comments/241703952","pull_request_review_id":185043363,"id":241703952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTcwMzk1Mg==","diff_hunk":"@@ -371,22 +374,45 @@ private void analyzeReplLoad(ASTNode ast) throws SemanticException {\n       DumpMetaData dmd = new DumpMetaData(loadPath, conf);\n \n       boolean evDump = false;\n-      if (dmd.isIncrementalDump()){\n+      // we will decide what hdfs locations needs to be copied over here as well.\n+      if (dmd.isIncrementalDump()) {\n         LOG.debug(\"{} contains an incremental dump\", loadPath);\n         evDump = true;\n       } else {\n         LOG.debug(\"{} contains an bootstrap dump\", loadPath);\n       }\n-\n       ReplLoadWork replLoadWork = new ReplLoadWork(conf, loadPath.toString(), dbNameOrPattern,\n-              tblNameOrPattern, queryState.getLineageState(), evDump, dmd.getEventTo());\n+          tblNameOrPattern, queryState.getLineageState(), evDump, dmd.getEventTo(),\n+          //this toLowerCase is the weird case of db's being loaded from rdbms all being in lowercase.\n+          //however the dbNameOrPattern is a user input in the repl load command hence can be NOT all be in lower case.\n+          dirLocationsToCopy(loadPath, evDump));","path":"ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java","position":49,"original_position":49,"commit_id":"92a165bf05ce351b6f6c204c4b6730d9ba6b0469","original_commit_id":"57fa9f0c2c3e00e92b8ba472b05668ff3767c5f4","user":{"login":"anishek","id":515967,"node_id":"MDQ6VXNlcjUxNTk2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/515967?v=4","gravatar_id":"","url":"https://api.github.com/users/anishek","html_url":"https://github.com/anishek","followers_url":"https://api.github.com/users/anishek/followers","following_url":"https://api.github.com/users/anishek/following{/other_user}","gists_url":"https://api.github.com/users/anishek/gists{/gist_id}","starred_url":"https://api.github.com/users/anishek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anishek/subscriptions","organizations_url":"https://api.github.com/users/anishek/orgs","repos_url":"https://api.github.com/users/anishek/repos","events_url":"https://api.github.com/users/anishek/events{/privacy}","received_events_url":"https://api.github.com/users/anishek/received_events","type":"User","site_admin":false},"body":"yeh looks like that have removed this","created_at":"2018-12-14T10:14:03Z","updated_at":"2018-12-14T10:14:03Z","html_url":"https://github.com/apache/hive/pull/506#discussion_r241703952","pull_request_url":"https://api.github.com/repos/apache/hive/pulls/506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/comments/241703952"},"html":{"href":"https://github.com/apache/hive/pull/506#discussion_r241703952"},"pull_request":{"href":"https://api.github.com/repos/apache/hive/pulls/506"}},"in_reply_to_id":241313946},"pull_request":{"url":"https://api.github.com/repos/apache/hive/pulls/506","id":237918355,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTE4MzU1","html_url":"https://github.com/apache/hive/pull/506","diff_url":"https://github.com/apache/hive/pull/506.diff","patch_url":"https://github.com/apache/hive/pull/506.patch","issue_url":"https://api.github.com/repos/apache/hive/issues/506","number":506,"state":"open","locked":false,"title":"HIVE-20911: External Table Replication for Hive","user":{"login":"anishek","id":515967,"node_id":"MDQ6VXNlcjUxNTk2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/515967?v=4","gravatar_id":"","url":"https://api.github.com/users/anishek","html_url":"https://github.com/anishek","followers_url":"https://api.github.com/users/anishek/followers","following_url":"https://api.github.com/users/anishek/following{/other_user}","gists_url":"https://api.github.com/users/anishek/gists{/gist_id}","starred_url":"https://api.github.com/users/anishek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anishek/subscriptions","organizations_url":"https://api.github.com/users/anishek/orgs","repos_url":"https://api.github.com/users/anishek/repos","events_url":"https://api.github.com/users/anishek/events{/privacy}","received_events_url":"https://api.github.com/users/anishek/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-12T05:39:44Z","updated_at":"2018-12-14T10:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84b632ba1c5d8af719547c595773d008d6fbc261","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hive/pulls/506/commits","review_comments_url":"https://api.github.com/repos/apache/hive/pulls/506/comments","review_comment_url":"https://api.github.com/repos/apache/hive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hive/issues/506/comments","statuses_url":"https://api.github.com/repos/apache/hive/statuses/92a165bf05ce351b6f6c204c4b6730d9ba6b0469","head":{"label":"anishek:HIVE-20911","ref":"HIVE-20911","sha":"92a165bf05ce351b6f6c204c4b6730d9ba6b0469","user":{"login":"anishek","id":515967,"node_id":"MDQ6VXNlcjUxNTk2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/515967?v=4","gravatar_id":"","url":"https://api.github.com/users/anishek","html_url":"https://github.com/anishek","followers_url":"https://api.github.com/users/anishek/followers","following_url":"https://api.github.com/users/anishek/following{/other_user}","gists_url":"https://api.github.com/users/anishek/gists{/gist_id}","starred_url":"https://api.github.com/users/anishek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anishek/subscriptions","organizations_url":"https://api.github.com/users/anishek/orgs","repos_url":"https://api.github.com/users/anishek/repos","events_url":"https://api.github.com/users/anishek/events{/privacy}","received_events_url":"https://api.github.com/users/anishek/received_events","type":"User","site_admin":false},"repo":{"id":74741210,"node_id":"MDEwOlJlcG9zaXRvcnk3NDc0MTIxMA==","name":"hive","full_name":"anishek/hive","private":false,"owner":{"login":"anishek","id":515967,"node_id":"MDQ6VXNlcjUxNTk2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/515967?v=4","gravatar_id":"","url":"https://api.github.com/users/anishek","html_url":"https://github.com/anishek","followers_url":"https://api.github.com/users/anishek/followers","following_url":"https://api.github.com/users/anishek/following{/other_user}","gists_url":"https://api.github.com/users/anishek/gists{/gist_id}","starred_url":"https://api.github.com/users/anishek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anishek/subscriptions","organizations_url":"https://api.github.com/users/anishek/orgs","repos_url":"https://api.github.com/users/anishek/repos","events_url":"https://api.github.com/users/anishek/events{/privacy}","received_events_url":"https://api.github.com/users/anishek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anishek/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/anishek/hive","forks_url":"https://api.github.com/repos/anishek/hive/forks","keys_url":"https://api.github.com/repos/anishek/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anishek/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anishek/hive/teams","hooks_url":"https://api.github.com/repos/anishek/hive/hooks","issue_events_url":"https://api.github.com/repos/anishek/hive/issues/events{/number}","events_url":"https://api.github.com/repos/anishek/hive/events","assignees_url":"https://api.github.com/repos/anishek/hive/assignees{/user}","branches_url":"https://api.github.com/repos/anishek/hive/branches{/branch}","tags_url":"https://api.github.com/repos/anishek/hive/tags","blobs_url":"https://api.github.com/repos/anishek/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anishek/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anishek/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/anishek/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anishek/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/anishek/hive/languages","stargazers_url":"https://api.github.com/repos/anishek/hive/stargazers","contributors_url":"https://api.github.com/repos/anishek/hive/contributors","subscribers_url":"https://api.github.com/repos/anishek/hive/subscribers","subscription_url":"https://api.github.com/repos/anishek/hive/subscription","commits_url":"https://api.github.com/repos/anishek/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/anishek/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/anishek/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/anishek/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/anishek/hive/contents/{+path}","compare_url":"https://api.github.com/repos/anishek/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anishek/hive/merges","archive_url":"https://api.github.com/repos/anishek/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anishek/hive/downloads","issues_url":"https://api.github.com/repos/anishek/hive/issues{/number}","pulls_url":"https://api.github.com/repos/anishek/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/anishek/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/anishek/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anishek/hive/labels{/name}","releases_url":"https://api.github.com/repos/anishek/hive/releases{/id}","deployments_url":"https://api.github.com/repos/anishek/hive/deployments","created_at":"2016-11-25T08:50:49Z","updated_at":"2018-12-12T04:33:43Z","pushed_at":"2018-12-13T10:24:44Z","git_url":"git://github.com/anishek/hive.git","ssh_url":"git@github.com:anishek/hive.git","clone_url":"https://github.com/anishek/hive.git","svn_url":"https://github.com/anishek/hive","homepage":null,"size":438491,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b650083f13daeffba063511ad991a5ac8af9f3cc","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206444,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY0NDQ=","name":"hive","full_name":"apache/hive","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/hive","description":"Mirror of Apache Hive","fork":false,"url":"https://api.github.com/repos/apache/hive","forks_url":"https://api.github.com/repos/apache/hive/forks","keys_url":"https://api.github.com/repos/apache/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hive/teams","hooks_url":"https://api.github.com/repos/apache/hive/hooks","issue_events_url":"https://api.github.com/repos/apache/hive/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hive/events","assignees_url":"https://api.github.com/repos/apache/hive/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hive/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hive/tags","blobs_url":"https://api.github.com/repos/apache/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hive/languages","stargazers_url":"https://api.github.com/repos/apache/hive/stargazers","contributors_url":"https://api.github.com/repos/apache/hive/contributors","subscribers_url":"https://api.github.com/repos/apache/hive/subscribers","subscription_url":"https://api.github.com/repos/apache/hive/subscription","commits_url":"https://api.github.com/repos/apache/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hive/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hive/merges","archive_url":"https://api.github.com/repos/apache/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hive/downloads","issues_url":"https://api.github.com/repos/apache/hive/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hive/labels{/name}","releases_url":"https://api.github.com/repos/apache/hive/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hive/deployments","created_at":"2009-05-21T02:31:01Z","updated_at":"2018-12-14T08:29:30Z","pushed_at":"2018-12-14T09:00:19Z","git_url":"git://github.com/apache/hive.git","ssh_url":"git@github.com:apache/hive.git","clone_url":"https://github.com/apache/hive.git","svn_url":"https://github.com/apache/hive","homepage":null,"size":454787,"stargazers_count":2254,"watchers_count":2254,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2266,"mirror_url":null,"archived":false,"open_issues_count":207,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2266,"open_issues":207,"watchers":2254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/506"},"html":{"href":"https://github.com/apache/hive/pull/506"},"issue":{"href":"https://api.github.com/repos/apache/hive/issues/506"},"comments":{"href":"https://api.github.com/repos/apache/hive/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hive/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hive/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hive/statuses/92a165bf05ce351b6f6c204c4b6730d9ba6b0469"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anishek"}}