{"action":"opened","number":4352,"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/4352","id":235665994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjY1OTk0","html_url":"https://github.com/corda/corda/pull/4352","diff_url":"https://github.com/corda/corda/pull/4352.diff","patch_url":"https://github.com/corda/corda/pull/4352.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/4352","number":4352,"state":"open","locked":false,"title":"In docs:key-concepts, transactions should come before contracts","user":{"login":"siyopao","id":28915792,"node_id":"MDQ6VXNlcjI4OTE1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/28915792?v=4","gravatar_id":"","url":"https://api.github.com/users/siyopao","html_url":"https://github.com/siyopao","followers_url":"https://api.github.com/users/siyopao/followers","following_url":"https://api.github.com/users/siyopao/following{/other_user}","gists_url":"https://api.github.com/users/siyopao/gists{/gist_id}","starred_url":"https://api.github.com/users/siyopao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siyopao/subscriptions","organizations_url":"https://api.github.com/users/siyopao/orgs","repos_url":"https://api.github.com/users/siyopao/repos","events_url":"https://api.github.com/users/siyopao/events{/privacy}","received_events_url":"https://api.github.com/users/siyopao/received_events","type":"User","site_admin":false},"body":"👮🏻👮🏻👮🏻 !!!! DESCRIBE YOUR CHANGES HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻\r\n\r\nI am reading through the key-concepts in V3.3 of your docs [here](https://docs.corda.net/key-concepts.html) and I think that transactions should appear before contracts. Especially since the video for transactions is labeled Key Concepts 3 and the video for contracts as Key Concepts 4.\r\n\r\n“I hereby certify that my contribution is in accordance with the Developer Certificate of Origin (https://developercertificate.org/).”\r\n\r\n\r\n# PR Checklist:\r\n\r\n- [ x - didn't change code] Have you run the unit, integration and smoke tests as described [here](https://docs.corda.net/head/testing.html)?\r\n- [x ] If you added public APIs, did you write the JavaDocs?\r\n- [x] If the changes are of interest to application developers, have you added them to the [changelog](https://github.com/corda/corda/blob/master/docs/source/changelog.rst), and potentially the [release notes](https://github.com/corda/corda/blob/master/docs/source/release-notes.rst)?\r\n- [x] If you are contributing for the first time, please read the agreement in [CONTRIBUTING.md](https://github.com/corda/corda/blob/master/CONTRIBUTING.md) now and add a comment to this pull request stating that your PR is in accordance with the [Developer's Certificate of Origin](https://github.com/corda/corda/blob/master/CONTRIBUTING.md#developer-certificate-of-origin).\r\n\r\nThanks for your code, it's appreciated! :)\r\n","created_at":"2018-12-04T03:16:09Z","updated_at":"2018-12-04T03:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/4352/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/4352/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/4352/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/c8870310924366d93f797243b8884227da4124ac","head":{"label":"siyopao:patch-1","ref":"patch-1","sha":"c8870310924366d93f797243b8884227da4124ac","user":{"login":"siyopao","id":28915792,"node_id":"MDQ6VXNlcjI4OTE1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/28915792?v=4","gravatar_id":"","url":"https://api.github.com/users/siyopao","html_url":"https://github.com/siyopao","followers_url":"https://api.github.com/users/siyopao/followers","following_url":"https://api.github.com/users/siyopao/following{/other_user}","gists_url":"https://api.github.com/users/siyopao/gists{/gist_id}","starred_url":"https://api.github.com/users/siyopao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siyopao/subscriptions","organizations_url":"https://api.github.com/users/siyopao/orgs","repos_url":"https://api.github.com/users/siyopao/repos","events_url":"https://api.github.com/users/siyopao/events{/privacy}","received_events_url":"https://api.github.com/users/siyopao/received_events","type":"User","site_admin":false},"repo":{"id":160288011,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyODgwMTE=","name":"corda","full_name":"siyopao/corda","private":false,"owner":{"login":"siyopao","id":28915792,"node_id":"MDQ6VXNlcjI4OTE1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/28915792?v=4","gravatar_id":"","url":"https://api.github.com/users/siyopao","html_url":"https://github.com/siyopao","followers_url":"https://api.github.com/users/siyopao/followers","following_url":"https://api.github.com/users/siyopao/following{/other_user}","gists_url":"https://api.github.com/users/siyopao/gists{/gist_id}","starred_url":"https://api.github.com/users/siyopao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siyopao/subscriptions","organizations_url":"https://api.github.com/users/siyopao/orgs","repos_url":"https://api.github.com/users/siyopao/repos","events_url":"https://api.github.com/users/siyopao/events{/privacy}","received_events_url":"https://api.github.com/users/siyopao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/siyopao/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":true,"url":"https://api.github.com/repos/siyopao/corda","forks_url":"https://api.github.com/repos/siyopao/corda/forks","keys_url":"https://api.github.com/repos/siyopao/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siyopao/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siyopao/corda/teams","hooks_url":"https://api.github.com/repos/siyopao/corda/hooks","issue_events_url":"https://api.github.com/repos/siyopao/corda/issues/events{/number}","events_url":"https://api.github.com/repos/siyopao/corda/events","assignees_url":"https://api.github.com/repos/siyopao/corda/assignees{/user}","branches_url":"https://api.github.com/repos/siyopao/corda/branches{/branch}","tags_url":"https://api.github.com/repos/siyopao/corda/tags","blobs_url":"https://api.github.com/repos/siyopao/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siyopao/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siyopao/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/siyopao/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siyopao/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/siyopao/corda/languages","stargazers_url":"https://api.github.com/repos/siyopao/corda/stargazers","contributors_url":"https://api.github.com/repos/siyopao/corda/contributors","subscribers_url":"https://api.github.com/repos/siyopao/corda/subscribers","subscription_url":"https://api.github.com/repos/siyopao/corda/subscription","commits_url":"https://api.github.com/repos/siyopao/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/siyopao/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/siyopao/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/siyopao/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/siyopao/corda/contents/{+path}","compare_url":"https://api.github.com/repos/siyopao/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siyopao/corda/merges","archive_url":"https://api.github.com/repos/siyopao/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siyopao/corda/downloads","issues_url":"https://api.github.com/repos/siyopao/corda/issues{/number}","pulls_url":"https://api.github.com/repos/siyopao/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/siyopao/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/siyopao/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siyopao/corda/labels{/name}","releases_url":"https://api.github.com/repos/siyopao/corda/releases{/id}","deployments_url":"https://api.github.com/repos/siyopao/corda/deployments","created_at":"2018-12-04T03:01:51Z","updated_at":"2018-12-04T03:01:59Z","pushed_at":"2018-12-04T03:10:45Z","git_url":"git://github.com/siyopao/corda.git","ssh_url":"git@github.com:siyopao/corda.git","clone_url":"https://github.com/siyopao/corda.git","svn_url":"https://github.com/siyopao/corda","homepage":"https://www.corda.net","size":167922,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"9232b3637b91fc484e37a38a65ef0046e3c46e91","user":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNzQxNw==","name":"corda","full_name":"corda/corda","private":false,"owner":{"login":"corda","id":22600631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjAwNjMx","avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/corda/corda","description":"Corda is an open source blockchain project, designed for business from the start. Only Corda allows you to build interoperable blockchain networks that transact in strict privacy. Corda's smart contract technology allows businesses to transact directly, with value.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-12-04T00:53:23Z","pushed_at":"2018-12-03T22:30:18Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":167922,"stargazers_count":2538,"watchers_count":2538,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":648,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":648,"open_issues":92,"watchers":2538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/4352"},"html":{"href":"https://github.com/corda/corda/pull/4352"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/4352"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/4352/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/4352/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/4352/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/c8870310924366d93f797243b8884227da4124ac"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"siyopao"}}