{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/172921415","pull_request_review_id":102023077,"id":172921415,"diff_hunk":"@@ -18,12 +18,20 @@\n import com.google.api.codegen.config.PackageMetadataConfig;\n import com.google.api.codegen.discovery.Document;\n import com.google.api.codegen.gapic.GapicGeneratorConfig;\n+import com.google.api.codegen.gapic.GapicProvider;\n import java.util.List;\n \n+/** A factory for DiscoGapicProviders which perform code generation. */\n public interface DiscoGapicProviderFactory {\n-  List<DiscoGapicProvider> create(\n+  /**\n+   * Create the provider from the given model, configs and the output path.\n+   *\n+   * <p>The outputPath is used for copying static files from resources into the output directory.\n+   */\n+  List<GapicProvider<? extends Object>> create(","path":"src/main/java/com/google/api/codegen/discogapic/DiscoGapicProviderFactory.java","position":15,"original_position":15,"commit_id":"7c54089eedaedd3e9e44da60dc5b84d937d36dea","original_commit_id":"7c54089eedaedd3e9e44da60dc5b84d937d36dea","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"Out of curiosity - was there something that forced us to make the element type here more generic?","created_at":"2018-03-07T17:29:52Z","updated_at":"2018-03-07T17:58:14Z","html_url":"https://github.com/googleapis/toolkit/pull/1859#discussion_r172921415","pull_request_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1859","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/172921415"},"html":{"href":"https://github.com/googleapis/toolkit/pull/1859#discussion_r172921415"},"pull_request":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1859"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/1859","id":172642894,"html_url":"https://github.com/googleapis/toolkit/pull/1859","diff_url":"https://github.com/googleapis/toolkit/pull/1859.diff","patch_url":"https://github.com/googleapis/toolkit/pull/1859.patch","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/1859","number":1859,"state":"open","locked":false,"title":"Generate unit tests for discogapic","user":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-03T01:46:47Z","updated_at":"2018-03-07T17:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc157a0f506d53941ac4d5cb8b48b463dfc2942c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/1859/comments","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/7c54089eedaedd3e9e44da60dc5b84d937d36dea","head":{"label":"andreamlin:unit_tests","ref":"unit_tests","sha":"7c54089eedaedd3e9e44da60dc5b84d937d36dea","user":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"repo":{"id":90909131,"name":"toolkit","full_name":"andreamlin/toolkit","owner":{"login":"andreamlin","id":4016818,"avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreamlin/toolkit","description":null,"fork":true,"url":"https://api.github.com/repos/andreamlin/toolkit","forks_url":"https://api.github.com/repos/andreamlin/toolkit/forks","keys_url":"https://api.github.com/repos/andreamlin/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreamlin/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreamlin/toolkit/teams","hooks_url":"https://api.github.com/repos/andreamlin/toolkit/hooks","issue_events_url":"https://api.github.com/repos/andreamlin/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/andreamlin/toolkit/events","assignees_url":"https://api.github.com/repos/andreamlin/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/andreamlin/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/andreamlin/toolkit/tags","blobs_url":"https://api.github.com/repos/andreamlin/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreamlin/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreamlin/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreamlin/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreamlin/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/andreamlin/toolkit/languages","stargazers_url":"https://api.github.com/repos/andreamlin/toolkit/stargazers","contributors_url":"https://api.github.com/repos/andreamlin/toolkit/contributors","subscribers_url":"https://api.github.com/repos/andreamlin/toolkit/subscribers","subscription_url":"https://api.github.com/repos/andreamlin/toolkit/subscription","commits_url":"https://api.github.com/repos/andreamlin/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreamlin/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreamlin/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreamlin/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreamlin/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/andreamlin/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreamlin/toolkit/merges","archive_url":"https://api.github.com/repos/andreamlin/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreamlin/toolkit/downloads","issues_url":"https://api.github.com/repos/andreamlin/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/andreamlin/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/andreamlin/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/andreamlin/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreamlin/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/andreamlin/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/andreamlin/toolkit/deployments","created_at":"2017-05-10T21:16:54Z","updated_at":"2017-05-10T21:16:59Z","pushed_at":"2018-03-07T01:58:46Z","git_url":"git://github.com/andreamlin/toolkit.git","ssh_url":"git@github.com:andreamlin/toolkit.git","clone_url":"https://github.com/andreamlin/toolkit.git","svn_url":"https://github.com/andreamlin/toolkit","homepage":null,"size":20385,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"aeb48801533a6eccbcea5911d35446677af2a323","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":56533838,"name":"toolkit","full_name":"googleapis/toolkit","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/googleapis/toolkit","forks_url":"https://api.github.com/repos/googleapis/toolkit/forks","keys_url":"https://api.github.com/repos/googleapis/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/toolkit/teams","hooks_url":"https://api.github.com/repos/googleapis/toolkit/hooks","issue_events_url":"https://api.github.com/repos/googleapis/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/toolkit/events","assignees_url":"https://api.github.com/repos/googleapis/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/toolkit/tags","blobs_url":"https://api.github.com/repos/googleapis/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/toolkit/languages","stargazers_url":"https://api.github.com/repos/googleapis/toolkit/stargazers","contributors_url":"https://api.github.com/repos/googleapis/toolkit/contributors","subscribers_url":"https://api.github.com/repos/googleapis/toolkit/subscribers","subscription_url":"https://api.github.com/repos/googleapis/toolkit/subscription","commits_url":"https://api.github.com/repos/googleapis/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/toolkit/merges","archive_url":"https://api.github.com/repos/googleapis/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/toolkit/downloads","issues_url":"https://api.github.com/repos/googleapis/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/toolkit/deployments","created_at":"2016-04-18T18:58:04Z","updated_at":"2018-02-28T15:14:54Z","pushed_at":"2018-03-07T16:27:03Z","git_url":"git://github.com/googleapis/toolkit.git","ssh_url":"git@github.com:googleapis/toolkit.git","clone_url":"https://github.com/googleapis/toolkit.git","svn_url":"https://github.com/googleapis/toolkit","homepage":null,"size":19791,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":141,"license":null,"forks":48,"open_issues":141,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1859"},"html":{"href":"https://github.com/googleapis/toolkit/pull/1859"},"issue":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/1859"},"comments":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/toolkit/statuses/7c54089eedaedd3e9e44da60dc5b84d937d36dea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garrettjonesgoogle"}}