{"action":"created","issue":{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1911","repository_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer","labels_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1911/labels{/name}","comments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1911/comments","events_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1911/events","html_url":"https://github.com/squizlabs/PHP_CodeSniffer/issues/1911","id":299528308,"number":1911,"title":"[3.2.3 BC break] New error reporting added in MultipleStatementAlignment","user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars2.githubusercontent.com/u/144181?v=4","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T22:15:04Z","updated_at":"2018-02-22T23:03:40Z","closed_at":null,"author_association":"NONE","body":"This code worked fine in 3.2.2:\r\n```php\r\n<?php\r\n\r\n$indentation = str_repeat(self::INDENTATION, $indentationLevel);\r\n$longestKey  = array_reduce(array_keys($value), function ($k, $v) {\r\n    return (string) (strlen((string) $k) > strlen((string) $v) ? $k : $v);\r\n});\r\n$maxKeyLength = strlen($longestKey) + (is_numeric($longestKey) ? 0 : 2);\r\n```\r\nNow reports an error in 3.2.3:\r\n```\r\n 3 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space (Generic.Formatting.MultipleStatementAlignment.NotSame)\r\n 4 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 3 spaces but found 2 spaces (Generic.Formatting.MultipleStatementAlignment.NotSame)\r\n```\r\n\r\nAs much as I understand that it could be considered as a one assignment group, introducing new error for this in a bugfix release is a BC break."},"comment":{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/comments/367853049","html_url":"https://github.com/squizlabs/PHP_CodeSniffer/issues/1911#issuecomment-367853049","issue_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1911","id":367853049,"user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T23:03:40Z","updated_at":"2018-02-22T23:03:40Z","author_association":"CONTRIBUTOR","body":"The fact that it previously wasn't being reported was a bug - see #1870, so why shouldn't have been in a bugfix release ?"}}
{"actor":{"display_login":"jrfnl"}}