{"action":"created","comment":{"url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/comments/168714098","pull_request_review_id":97127140,"id":168714098,"diff_hunk":"@@ -0,0 +1,178 @@\n+﻿using System;\n+\n+namespace JulMar.Atapi\n+{\n+    /// <summary>\n+    /// This class represents a single Tapi Address object.\n+    /// </summary>\n+    public interface ITapiAddress\n+    {\n+        /// <summary>\n+        /// The Dialable number for the address. This will never be blank.\n+        /// </summary>\n+        string Address { get; }\n+\n+        /// <summary>\n+        /// This gets or sets the number of rings that must occur before an incoming call is answered.  This can be used to implement a \"toll-saver\" style application.\n+        /// </summary>\n+        int AnswerRingCount { get; set; }\n+\n+        /// <summary>\n+        /// Returns the list of active calls on the address.\n+        /// </summary>\n+        ITapiCall[] Calls { get; }\n+\n+        /// <summary>\n+        /// Returns the <see>AddressCapabilities</see> capabilities structure.\n+        /// </summary>\n+        AddressCapabilities Capabilities { get; }\n+\n+        /// <summary>\n+        /// The numeric address ID\n+        /// </summary>\n+        int Id { get; }\n+\n+        /// <summary>\n+        /// The <see>TapiLine</see> associated with the address.\n+        /// </summary>\n+        TapiLine Line { get; }","path":"src/src/Interfaces/ITapiAddress.cs","position":38,"original_position":38,"commit_id":"6a8eda00f13249be972e7a57b7854bf838330c2d","original_commit_id":"6a8eda00f13249be972e7a57b7854bf838330c2d","user":{"login":"vfabregat","id":6525021,"avatar_url":"https://avatars1.githubusercontent.com/u/6525021?v=4","gravatar_id":"","url":"https://api.github.com/users/vfabregat","html_url":"https://github.com/vfabregat","followers_url":"https://api.github.com/users/vfabregat/followers","following_url":"https://api.github.com/users/vfabregat/following{/other_user}","gists_url":"https://api.github.com/users/vfabregat/gists{/gist_id}","starred_url":"https://api.github.com/users/vfabregat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfabregat/subscriptions","organizations_url":"https://api.github.com/users/vfabregat/orgs","repos_url":"https://api.github.com/users/vfabregat/repos","events_url":"https://api.github.com/users/vfabregat/events{/privacy}","received_events_url":"https://api.github.com/users/vfabregat/received_events","type":"User","site_admin":false},"body":"Yes, you're right, should be using the abstractions. The purpose is to allow mocking it for unit testing. I'll fix this and send the update.","created_at":"2018-02-16T09:57:50Z","updated_at":"2018-02-16T09:57:50Z","html_url":"https://github.com/markjulmar/atapi.net/pull/4#discussion_r168714098","pull_request_url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/comments/168714098"},"html":{"href":"https://github.com/markjulmar/atapi.net/pull/4#discussion_r168714098"},"pull_request":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4"}},"in_reply_to_id":168552209},"pull_request":{"url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4","id":144021876,"html_url":"https://github.com/markjulmar/atapi.net/pull/4","diff_url":"https://github.com/markjulmar/atapi.net/pull/4.diff","patch_url":"https://github.com/markjulmar/atapi.net/pull/4.patch","issue_url":"https://api.github.com/repos/markjulmar/atapi.net/issues/4","number":4,"state":"open","locked":false,"title":"Add abstractions and Guid for TapiCall","user":{"login":"vfabregat","id":6525021,"avatar_url":"https://avatars1.githubusercontent.com/u/6525021?v=4","gravatar_id":"","url":"https://api.github.com/users/vfabregat","html_url":"https://github.com/vfabregat","followers_url":"https://api.github.com/users/vfabregat/followers","following_url":"https://api.github.com/users/vfabregat/following{/other_user}","gists_url":"https://api.github.com/users/vfabregat/gists{/gist_id}","starred_url":"https://api.github.com/users/vfabregat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfabregat/subscriptions","organizations_url":"https://api.github.com/users/vfabregat/orgs","repos_url":"https://api.github.com/users/vfabregat/repos","events_url":"https://api.github.com/users/vfabregat/events{/privacy}","received_events_url":"https://api.github.com/users/vfabregat/received_events","type":"User","site_admin":false},"body":"Added a Guid, generated in the TapiCall constructor to allow identify each instance call.\r\nAdded interfaces to TapiCall, TapiAddress, CallFeatureSet\r\n\r\nThis pull request resolve #1 ","created_at":"2017-09-30T09:28:42Z","updated_at":"2018-02-16T09:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe238f4c1570752c15d6530a9e33cc7ba825056","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4/commits","review_comments_url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4/comments","review_comment_url":"https://api.github.com/repos/markjulmar/atapi.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/markjulmar/atapi.net/issues/4/comments","statuses_url":"https://api.github.com/repos/markjulmar/atapi.net/statuses/6a8eda00f13249be972e7a57b7854bf838330c2d","head":{"label":"vfabregat:add-abstractions","ref":"add-abstractions","sha":"6a8eda00f13249be972e7a57b7854bf838330c2d","user":{"login":"vfabregat","id":6525021,"avatar_url":"https://avatars1.githubusercontent.com/u/6525021?v=4","gravatar_id":"","url":"https://api.github.com/users/vfabregat","html_url":"https://github.com/vfabregat","followers_url":"https://api.github.com/users/vfabregat/followers","following_url":"https://api.github.com/users/vfabregat/following{/other_user}","gists_url":"https://api.github.com/users/vfabregat/gists{/gist_id}","starred_url":"https://api.github.com/users/vfabregat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfabregat/subscriptions","organizations_url":"https://api.github.com/users/vfabregat/orgs","repos_url":"https://api.github.com/users/vfabregat/repos","events_url":"https://api.github.com/users/vfabregat/events{/privacy}","received_events_url":"https://api.github.com/users/vfabregat/received_events","type":"User","site_admin":false},"repo":{"id":103972024,"name":"atapi.net","full_name":"vfabregat/atapi.net","owner":{"login":"vfabregat","id":6525021,"avatar_url":"https://avatars1.githubusercontent.com/u/6525021?v=4","gravatar_id":"","url":"https://api.github.com/users/vfabregat","html_url":"https://github.com/vfabregat","followers_url":"https://api.github.com/users/vfabregat/followers","following_url":"https://api.github.com/users/vfabregat/following{/other_user}","gists_url":"https://api.github.com/users/vfabregat/gists{/gist_id}","starred_url":"https://api.github.com/users/vfabregat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfabregat/subscriptions","organizations_url":"https://api.github.com/users/vfabregat/orgs","repos_url":"https://api.github.com/users/vfabregat/repos","events_url":"https://api.github.com/users/vfabregat/events{/privacy}","received_events_url":"https://api.github.com/users/vfabregat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vfabregat/atapi.net","description":"Managed library for TAPI development with .NET","fork":true,"url":"https://api.github.com/repos/vfabregat/atapi.net","forks_url":"https://api.github.com/repos/vfabregat/atapi.net/forks","keys_url":"https://api.github.com/repos/vfabregat/atapi.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vfabregat/atapi.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vfabregat/atapi.net/teams","hooks_url":"https://api.github.com/repos/vfabregat/atapi.net/hooks","issue_events_url":"https://api.github.com/repos/vfabregat/atapi.net/issues/events{/number}","events_url":"https://api.github.com/repos/vfabregat/atapi.net/events","assignees_url":"https://api.github.com/repos/vfabregat/atapi.net/assignees{/user}","branches_url":"https://api.github.com/repos/vfabregat/atapi.net/branches{/branch}","tags_url":"https://api.github.com/repos/vfabregat/atapi.net/tags","blobs_url":"https://api.github.com/repos/vfabregat/atapi.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vfabregat/atapi.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vfabregat/atapi.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/vfabregat/atapi.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vfabregat/atapi.net/statuses/{sha}","languages_url":"https://api.github.com/repos/vfabregat/atapi.net/languages","stargazers_url":"https://api.github.com/repos/vfabregat/atapi.net/stargazers","contributors_url":"https://api.github.com/repos/vfabregat/atapi.net/contributors","subscribers_url":"https://api.github.com/repos/vfabregat/atapi.net/subscribers","subscription_url":"https://api.github.com/repos/vfabregat/atapi.net/subscription","commits_url":"https://api.github.com/repos/vfabregat/atapi.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/vfabregat/atapi.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/vfabregat/atapi.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/vfabregat/atapi.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/vfabregat/atapi.net/contents/{+path}","compare_url":"https://api.github.com/repos/vfabregat/atapi.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vfabregat/atapi.net/merges","archive_url":"https://api.github.com/repos/vfabregat/atapi.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vfabregat/atapi.net/downloads","issues_url":"https://api.github.com/repos/vfabregat/atapi.net/issues{/number}","pulls_url":"https://api.github.com/repos/vfabregat/atapi.net/pulls{/number}","milestones_url":"https://api.github.com/repos/vfabregat/atapi.net/milestones{/number}","notifications_url":"https://api.github.com/repos/vfabregat/atapi.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vfabregat/atapi.net/labels{/name}","releases_url":"https://api.github.com/repos/vfabregat/atapi.net/releases{/id}","deployments_url":"https://api.github.com/repos/vfabregat/atapi.net/deployments","created_at":"2017-09-18T17:47:18Z","updated_at":"2017-09-18T17:47:20Z","pushed_at":"2017-09-30T09:27:00Z","git_url":"git://github.com/vfabregat/atapi.net.git","ssh_url":"git@github.com:vfabregat/atapi.net.git","clone_url":"https://github.com/vfabregat/atapi.net.git","svn_url":"https://github.com/vfabregat/atapi.net","homepage":"http://www.julmar.com","size":1057,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"markjulmar:master","ref":"master","sha":"97e0a84dfb14a85eef33657ee2b48cf59afce511","user":{"login":"markjulmar","id":5099741,"avatar_url":"https://avatars1.githubusercontent.com/u/5099741?v=4","gravatar_id":"","url":"https://api.github.com/users/markjulmar","html_url":"https://github.com/markjulmar","followers_url":"https://api.github.com/users/markjulmar/followers","following_url":"https://api.github.com/users/markjulmar/following{/other_user}","gists_url":"https://api.github.com/users/markjulmar/gists{/gist_id}","starred_url":"https://api.github.com/users/markjulmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markjulmar/subscriptions","organizations_url":"https://api.github.com/users/markjulmar/orgs","repos_url":"https://api.github.com/users/markjulmar/repos","events_url":"https://api.github.com/users/markjulmar/events{/privacy}","received_events_url":"https://api.github.com/users/markjulmar/received_events","type":"User","site_admin":false},"repo":{"id":102845741,"name":"atapi.net","full_name":"markjulmar/atapi.net","owner":{"login":"markjulmar","id":5099741,"avatar_url":"https://avatars1.githubusercontent.com/u/5099741?v=4","gravatar_id":"","url":"https://api.github.com/users/markjulmar","html_url":"https://github.com/markjulmar","followers_url":"https://api.github.com/users/markjulmar/followers","following_url":"https://api.github.com/users/markjulmar/following{/other_user}","gists_url":"https://api.github.com/users/markjulmar/gists{/gist_id}","starred_url":"https://api.github.com/users/markjulmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markjulmar/subscriptions","organizations_url":"https://api.github.com/users/markjulmar/orgs","repos_url":"https://api.github.com/users/markjulmar/repos","events_url":"https://api.github.com/users/markjulmar/events{/privacy}","received_events_url":"https://api.github.com/users/markjulmar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markjulmar/atapi.net","description":"Managed library for TAPI development with .NET","fork":false,"url":"https://api.github.com/repos/markjulmar/atapi.net","forks_url":"https://api.github.com/repos/markjulmar/atapi.net/forks","keys_url":"https://api.github.com/repos/markjulmar/atapi.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markjulmar/atapi.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markjulmar/atapi.net/teams","hooks_url":"https://api.github.com/repos/markjulmar/atapi.net/hooks","issue_events_url":"https://api.github.com/repos/markjulmar/atapi.net/issues/events{/number}","events_url":"https://api.github.com/repos/markjulmar/atapi.net/events","assignees_url":"https://api.github.com/repos/markjulmar/atapi.net/assignees{/user}","branches_url":"https://api.github.com/repos/markjulmar/atapi.net/branches{/branch}","tags_url":"https://api.github.com/repos/markjulmar/atapi.net/tags","blobs_url":"https://api.github.com/repos/markjulmar/atapi.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markjulmar/atapi.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markjulmar/atapi.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/markjulmar/atapi.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markjulmar/atapi.net/statuses/{sha}","languages_url":"https://api.github.com/repos/markjulmar/atapi.net/languages","stargazers_url":"https://api.github.com/repos/markjulmar/atapi.net/stargazers","contributors_url":"https://api.github.com/repos/markjulmar/atapi.net/contributors","subscribers_url":"https://api.github.com/repos/markjulmar/atapi.net/subscribers","subscription_url":"https://api.github.com/repos/markjulmar/atapi.net/subscription","commits_url":"https://api.github.com/repos/markjulmar/atapi.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/markjulmar/atapi.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/markjulmar/atapi.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/markjulmar/atapi.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/markjulmar/atapi.net/contents/{+path}","compare_url":"https://api.github.com/repos/markjulmar/atapi.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markjulmar/atapi.net/merges","archive_url":"https://api.github.com/repos/markjulmar/atapi.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markjulmar/atapi.net/downloads","issues_url":"https://api.github.com/repos/markjulmar/atapi.net/issues{/number}","pulls_url":"https://api.github.com/repos/markjulmar/atapi.net/pulls{/number}","milestones_url":"https://api.github.com/repos/markjulmar/atapi.net/milestones{/number}","notifications_url":"https://api.github.com/repos/markjulmar/atapi.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markjulmar/atapi.net/labels{/name}","releases_url":"https://api.github.com/repos/markjulmar/atapi.net/releases{/id}","deployments_url":"https://api.github.com/repos/markjulmar/atapi.net/deployments","created_at":"2017-09-08T09:42:56Z","updated_at":"2018-01-30T12:07:55Z","pushed_at":"2017-09-30T09:28:43Z","git_url":"git://github.com/markjulmar/atapi.net.git","ssh_url":"git@github.com:markjulmar/atapi.net.git","clone_url":"https://github.com/markjulmar/atapi.net.git","svn_url":"https://github.com/markjulmar/atapi.net","homepage":"http://www.julmar.com","size":1061,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4"},"html":{"href":"https://github.com/markjulmar/atapi.net/pull/4"},"issue":{"href":"https://api.github.com/repos/markjulmar/atapi.net/issues/4"},"comments":{"href":"https://api.github.com/repos/markjulmar/atapi.net/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/markjulmar/atapi.net/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/markjulmar/atapi.net/statuses/6a8eda00f13249be972e7a57b7854bf838330c2d"}},"author_association":"NONE"}}
{"actor":{"display_login":"vfabregat"}}