{"action":"created","issue":{"url":"https://api.github.com/repos/opendatakit/collect/issues/2095","repository_url":"https://api.github.com/repos/opendatakit/collect","labels_url":"https://api.github.com/repos/opendatakit/collect/issues/2095/labels{/name}","comments_url":"https://api.github.com/repos/opendatakit/collect/issues/2095/comments","events_url":"https://api.github.com/repos/opendatakit/collect/issues/2095/events","html_url":"https://github.com/opendatakit/collect/pull/2095","id":311573606,"number":2095,"title":"Form update notifications","user":{"login":"grzesiek2010","id":3276264,"avatar_url":"https://avatars1.githubusercontent.com/u/3276264?v=4","gravatar_id":"","url":"https://api.github.com/users/grzesiek2010","html_url":"https://github.com/grzesiek2010","followers_url":"https://api.github.com/users/grzesiek2010/followers","following_url":"https://api.github.com/users/grzesiek2010/following{/other_user}","gists_url":"https://api.github.com/users/grzesiek2010/gists{/gist_id}","starred_url":"https://api.github.com/users/grzesiek2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzesiek2010/subscriptions","organizations_url":"https://api.github.com/users/grzesiek2010/orgs","repos_url":"https://api.github.com/users/grzesiek2010/repos","events_url":"https://api.github.com/users/grzesiek2010/events{/privacy}","received_events_url":"https://api.github.com/users/grzesiek2010/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-04-05T11:31:17Z","updated_at":"2018-05-09T12:17:52Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/opendatakit/collect/pulls/2095","html_url":"https://github.com/opendatakit/collect/pull/2095","diff_url":"https://github.com/opendatakit/collect/pull/2095.diff","patch_url":"https://github.com/opendatakit/collect/pull/2095.patch"},"body":"Closes #1668 \r\n\r\n#### What has been done to verify that this works as intended?\r\nTested scenarios:\r\n\r\n1. Upgrading the database\r\n2. Importing/exporting settings using QRCode and a settings file - if an appropriate option is selected and the job is rescheduled\r\n3. Showing notifications - only for forms not recognized before\r\n4. Forms displayed after clicking on the notification - only updated forms\r\n5. Behavior when the internet is not available\r\n\r\n#### Why is this the best possible solution? Were any other approaches considered?\r\nI used https://github.com/evernote/android-job because as the said:\r\n\r\n>Depending on the Android version either the JobScheduler, GcmNetworkManager or AlarmManager is getting used\r\n\r\nso it's really convenient way.\r\n\r\n#### Are there any risks to merging this code? If so, what are they?\r\nUpgrading database - it's always risky.\r\nI also had to refactor FormsDownloadTask and move the code out of this class in order to share it so it might be risky also.\r\n\r\nThe job itself shouldn't be risky since even if something goes wrong it doesn't affect the main thread and the app is still able to work, so in the worst case the job is just not performed.\r\n\r\n#### Do we need any specific form for testing your changes? If so, please attach one.\r\nNo, it may be any form."},"comment":{"url":"https://api.github.com/repos/opendatakit/collect/issues/comments/387719820","html_url":"https://github.com/opendatakit/collect/pull/2095#issuecomment-387719820","issue_url":"https://api.github.com/repos/opendatakit/collect/issues/2095","id":387719820,"user":{"login":"ukanga","id":85585,"avatar_url":"https://avatars0.githubusercontent.com/u/85585?v=4","gravatar_id":"","url":"https://api.github.com/users/ukanga","html_url":"https://github.com/ukanga","followers_url":"https://api.github.com/users/ukanga/followers","following_url":"https://api.github.com/users/ukanga/following{/other_user}","gists_url":"https://api.github.com/users/ukanga/gists{/gist_id}","starred_url":"https://api.github.com/users/ukanga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukanga/subscriptions","organizations_url":"https://api.github.com/users/ukanga/orgs","repos_url":"https://api.github.com/users/ukanga/repos","events_url":"https://api.github.com/users/ukanga/events{/privacy}","received_events_url":"https://api.github.com/users/ukanga/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T12:17:52Z","updated_at":"2018-05-09T12:17:52Z","author_association":"NONE","body":"When the option `Automatic update` is enabled, it shows the same notification after every 15 minutes even after it had already downloaded the form and there has been no change to the form. Should this notification only show up once?"}}
{"actor":{"display_login":"ukanga"}}