{"action":"created","issue":{"url":"https://api.github.com/repos/ole/SortedArray/issues/22","repository_url":"https://api.github.com/repos/ole/SortedArray","labels_url":"https://api.github.com/repos/ole/SortedArray/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/ole/SortedArray/issues/22/comments","events_url":"https://api.github.com/repos/ole/SortedArray/issues/22/events","html_url":"https://github.com/ole/SortedArray/pull/22","id":331177719,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTcyNzU2","number":22,"title":"Swift 4.2","user":{"login":"klaaspieter","id":98880,"node_id":"MDQ6VXNlcjk4ODgw","avatar_url":"https://avatars2.githubusercontent.com/u/98880?v=4","gravatar_id":"","url":"https://api.github.com/users/klaaspieter","html_url":"https://github.com/klaaspieter","followers_url":"https://api.github.com/users/klaaspieter/followers","following_url":"https://api.github.com/users/klaaspieter/following{/other_user}","gists_url":"https://api.github.com/users/klaaspieter/gists{/gist_id}","starred_url":"https://api.github.com/users/klaaspieter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaaspieter/subscriptions","organizations_url":"https://api.github.com/users/klaaspieter/orgs","repos_url":"https://api.github.com/users/klaaspieter/repos","events_url":"https://api.github.com/users/klaaspieter/events{/privacy}","received_events_url":"https://api.github.com/users/klaaspieter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-11T12:56:58Z","updated_at":"2018-06-17T22:12:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ole/SortedArray/pulls/22","html_url":"https://github.com/ole/SortedArray/pull/22","diff_url":"https://github.com/ole/SortedArray/pull/22.diff","patch_url":"https://github.com/ole/SortedArray/pull/22.patch"},"body":"Fixed all Swift 4.2 build errors and warnings. More info in the individual commits."},"comment":{"url":"https://api.github.com/repos/ole/SortedArray/issues/comments/397909975","html_url":"https://github.com/ole/SortedArray/pull/22#issuecomment-397909975","issue_url":"https://api.github.com/repos/ole/SortedArray/issues/22","id":397909975,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzkwOTk3NQ==","user":{"login":"ole","id":5010,"node_id":"MDQ6VXNlcjUwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5010?v=4","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T22:12:14Z","updated_at":"2018-06-17T22:12:14Z","author_association":"OWNER","body":"I'm looking at this now.\r\n\r\n> I think it's weird to have a if #swift block that's empty, but I don't think there is another option.\r\n\r\nYou can negate the conditions, so this seems to work:\r\n\r\n    #if !swift(>=4.2) && !swift(>=3.4)\r\n    public mutating func removeSubrange(_ bounds: CountableRange<Int>) {\r\n        _elements.removeSubrange(bounds)\r\n    }\r\n\r\n    public mutating func removeSubrange(_ bounds: CountableClosedRange<Int>) {\r\n        _elements.removeSubrange(bounds)\r\n    }\r\n    #endif\r\n\r\nI agree that it isn't pretty though."}}
{"actor":{"display_login":"ole"}}