{"action":"created","comment":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments/169252587","pull_request_review_id":97746377,"id":169252587,"diff_hunk":"@@ -28,4 +28,10 @@ public static boolean hasStackTraceElementRelatedToAssertJ(Throwable throwable)\n     return false;\n   }\n \n+  /**\n+   * Returns regex which match stack trace.\n+   */\n+  public static String getStackTraceRegex() {\n+    return \"\\\\[(?s).*[\\\\n\\\\r].*\\\\]\";","path":"src/test/java/org/assertj/core/util/StackTraceUtils.java","position":8,"original_position":8,"commit_id":"8487b191ba877cd9945d21add5b86b5288ac57d3","original_commit_id":"8487b191ba877cd9945d21add5b86b5288ac57d3","user":{"login":"joel-costigliola","id":382613,"avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"body":"let's avoid regex as much as we can, I only use regex when everything else fails since they are really unreadable and easy to screw up.","created_at":"2018-02-20T09:03:27Z","updated_at":"2018-02-20T09:03:27Z","html_url":"https://github.com/joel-costigliola/assertj-core/pull/1179#discussion_r169252587","pull_request_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments/169252587"},"html":{"href":"https://github.com/joel-costigliola/assertj-core/pull/1179#discussion_r169252587"},"pull_request":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179"}}},"pull_request":{"url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179","id":167961890,"html_url":"https://github.com/joel-costigliola/assertj-core/pull/1179","diff_url":"https://github.com/joel-costigliola/assertj-core/pull/1179.diff","patch_url":"https://github.com/joel-costigliola/assertj-core/pull/1179.patch","issue_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1179","number":1179,"state":"open","locked":false,"title":"Fixes: #1167 CompletionStage should print stacktrace on failed assert…","user":{"login":"pswiatowski","id":5804735,"avatar_url":"https://avatars3.githubusercontent.com/u/5804735?v=4","gravatar_id":"","url":"https://api.github.com/users/pswiatowski","html_url":"https://github.com/pswiatowski","followers_url":"https://api.github.com/users/pswiatowski/followers","following_url":"https://api.github.com/users/pswiatowski/following{/other_user}","gists_url":"https://api.github.com/users/pswiatowski/gists{/gist_id}","starred_url":"https://api.github.com/users/pswiatowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pswiatowski/subscriptions","organizations_url":"https://api.github.com/users/pswiatowski/orgs","repos_url":"https://api.github.com/users/pswiatowski/repos","events_url":"https://api.github.com/users/pswiatowski/events{/privacy}","received_events_url":"https://api.github.com/users/pswiatowski/received_events","type":"User","site_admin":false},"body":"…ion with failed-future\r\n\r\n#### Check List:\r\n* Fixes #1167 \r\n* Unit tests : YES\r\n* Javadoc with a code example (API only) : NA\r\n\r\n\r\n","created_at":"2018-02-08T12:45:13Z","updated_at":"2018-02-20T09:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec548cec41c0ee213a91ec6b1b60c6c375c8a93a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1179/comments","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/8487b191ba877cd9945d21add5b86b5288ac57d3","head":{"label":"pswiatowski:fix_1167","ref":"fix_1167","sha":"8487b191ba877cd9945d21add5b86b5288ac57d3","user":{"login":"pswiatowski","id":5804735,"avatar_url":"https://avatars3.githubusercontent.com/u/5804735?v=4","gravatar_id":"","url":"https://api.github.com/users/pswiatowski","html_url":"https://github.com/pswiatowski","followers_url":"https://api.github.com/users/pswiatowski/followers","following_url":"https://api.github.com/users/pswiatowski/following{/other_user}","gists_url":"https://api.github.com/users/pswiatowski/gists{/gist_id}","starred_url":"https://api.github.com/users/pswiatowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pswiatowski/subscriptions","organizations_url":"https://api.github.com/users/pswiatowski/orgs","repos_url":"https://api.github.com/users/pswiatowski/repos","events_url":"https://api.github.com/users/pswiatowski/events{/privacy}","received_events_url":"https://api.github.com/users/pswiatowski/received_events","type":"User","site_admin":false},"repo":{"id":74980788,"name":"assertj-core","full_name":"pswiatowski/assertj-core","owner":{"login":"pswiatowski","id":5804735,"avatar_url":"https://avatars3.githubusercontent.com/u/5804735?v=4","gravatar_id":"","url":"https://api.github.com/users/pswiatowski","html_url":"https://github.com/pswiatowski","followers_url":"https://api.github.com/users/pswiatowski/followers","following_url":"https://api.github.com/users/pswiatowski/following{/other_user}","gists_url":"https://api.github.com/users/pswiatowski/gists{/gist_id}","starred_url":"https://api.github.com/users/pswiatowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pswiatowski/subscriptions","organizations_url":"https://api.github.com/users/pswiatowski/orgs","repos_url":"https://api.github.com/users/pswiatowski/repos","events_url":"https://api.github.com/users/pswiatowski/events{/privacy}","received_events_url":"https://api.github.com/users/pswiatowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pswiatowski/assertj-core","description":"AssertJ is a library providing easy to use rich typed assertions ","fork":true,"url":"https://api.github.com/repos/pswiatowski/assertj-core","forks_url":"https://api.github.com/repos/pswiatowski/assertj-core/forks","keys_url":"https://api.github.com/repos/pswiatowski/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pswiatowski/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pswiatowski/assertj-core/teams","hooks_url":"https://api.github.com/repos/pswiatowski/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/pswiatowski/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/pswiatowski/assertj-core/events","assignees_url":"https://api.github.com/repos/pswiatowski/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/pswiatowski/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/pswiatowski/assertj-core/tags","blobs_url":"https://api.github.com/repos/pswiatowski/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pswiatowski/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pswiatowski/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pswiatowski/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pswiatowski/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pswiatowski/assertj-core/languages","stargazers_url":"https://api.github.com/repos/pswiatowski/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/pswiatowski/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/pswiatowski/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/pswiatowski/assertj-core/subscription","commits_url":"https://api.github.com/repos/pswiatowski/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pswiatowski/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pswiatowski/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pswiatowski/assertj-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pswiatowski/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/pswiatowski/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pswiatowski/assertj-core/merges","archive_url":"https://api.github.com/repos/pswiatowski/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pswiatowski/assertj-core/downloads","issues_url":"https://api.github.com/repos/pswiatowski/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/pswiatowski/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pswiatowski/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pswiatowski/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pswiatowski/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/pswiatowski/assertj-core/releases{/id}","deployments_url":"https://api.github.com/repos/pswiatowski/assertj-core/deployments","created_at":"2016-11-28T14:27:07Z","updated_at":"2016-11-28T14:27:13Z","pushed_at":"2018-02-19T23:27:35Z","git_url":"git://github.com/pswiatowski/assertj-core.git","ssh_url":"git@github.com:pswiatowski/assertj-core.git","clone_url":"https://github.com/pswiatowski/assertj-core.git","svn_url":"https://github.com/pswiatowski/assertj-core","homepage":"http://joel-costigliola.github.io/assertj/index.html","size":22756,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joel-costigliola:master","ref":"master","sha":"be642304d0f67885c2f62d86531de29b69c1f30d","user":{"login":"joel-costigliola","id":382613,"avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"repo":{"id":8779606,"name":"assertj-core","full_name":"joel-costigliola/assertj-core","owner":{"login":"joel-costigliola","id":382613,"avatar_url":"https://avatars2.githubusercontent.com/u/382613?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-costigliola","html_url":"https://github.com/joel-costigliola","followers_url":"https://api.github.com/users/joel-costigliola/followers","following_url":"https://api.github.com/users/joel-costigliola/following{/other_user}","gists_url":"https://api.github.com/users/joel-costigliola/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-costigliola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-costigliola/subscriptions","organizations_url":"https://api.github.com/users/joel-costigliola/orgs","repos_url":"https://api.github.com/users/joel-costigliola/repos","events_url":"https://api.github.com/users/joel-costigliola/events{/privacy}","received_events_url":"https://api.github.com/users/joel-costigliola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joel-costigliola/assertj-core","description":"AssertJ is a library providing easy to use rich typed assertions ","fork":false,"url":"https://api.github.com/repos/joel-costigliola/assertj-core","forks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/forks","keys_url":"https://api.github.com/repos/joel-costigliola/assertj-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joel-costigliola/assertj-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joel-costigliola/assertj-core/teams","hooks_url":"https://api.github.com/repos/joel-costigliola/assertj-core/hooks","issue_events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/events{/number}","events_url":"https://api.github.com/repos/joel-costigliola/assertj-core/events","assignees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/assignees{/user}","branches_url":"https://api.github.com/repos/joel-costigliola/assertj-core/branches{/branch}","tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/tags","blobs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/{sha}","languages_url":"https://api.github.com/repos/joel-costigliola/assertj-core/languages","stargazers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/stargazers","contributors_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contributors","subscribers_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscribers","subscription_url":"https://api.github.com/repos/joel-costigliola/assertj-core/subscription","commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/joel-costigliola/assertj-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/joel-costigliola/assertj-core/contents/{+path}","compare_url":"https://api.github.com/repos/joel-costigliola/assertj-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joel-costigliola/assertj-core/merges","archive_url":"https://api.github.com/repos/joel-costigliola/assertj-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joel-costigliola/assertj-core/downloads","issues_url":"https://api.github.com/repos/joel-costigliola/assertj-core/issues{/number}","pulls_url":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls{/number}","milestones_url":"https://api.github.com/repos/joel-costigliola/assertj-core/milestones{/number}","notifications_url":"https://api.github.com/repos/joel-costigliola/assertj-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joel-costigliola/assertj-core/labels{/name}","releases_url":"https://api.github.com/repos/joel-costigliola/assertj-core/releases{/id}","deployments_url":"https://api.github.com/repos/joel-costigliola/assertj-core/deployments","created_at":"2013-03-14T16:18:49Z","updated_at":"2018-02-17T23:11:53Z","pushed_at":"2018-02-19T23:28:24Z","git_url":"git://github.com/joel-costigliola/assertj-core.git","ssh_url":"git@github.com:joel-costigliola/assertj-core.git","clone_url":"https://github.com/joel-costigliola/assertj-core.git","svn_url":"https://github.com/joel-costigliola/assertj-core","homepage":"http://joel-costigliola.github.io/assertj/index.html","size":22714,"stargazers_count":1075,"watchers_count":1075,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":257,"open_issues":59,"watchers":1075,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179"},"html":{"href":"https://github.com/joel-costigliola/assertj-core/pull/1179"},"issue":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1179"},"comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/joel-costigliola/assertj-core/statuses/8487b191ba877cd9945d21add5b86b5288ac57d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joel-costigliola"}}