{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/5255","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5255/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5255/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5255/events","html_url":"https://github.com/mne-tools/mne-python/pull/5255","id":328262542,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODQ3NjA0","number":5255,"title":"CTF support for ds bad channels and bad segments","user":{"login":"bloyl","id":5585821,"node_id":"MDQ6VXNlcjU1ODU4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/5585821?v=4","gravatar_id":"","url":"https://api.github.com/users/bloyl","html_url":"https://github.com/bloyl","followers_url":"https://api.github.com/users/bloyl/followers","following_url":"https://api.github.com/users/bloyl/following{/other_user}","gists_url":"https://api.github.com/users/bloyl/gists{/gist_id}","starred_url":"https://api.github.com/users/bloyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloyl/subscriptions","organizations_url":"https://api.github.com/users/bloyl/orgs","repos_url":"https://api.github.com/users/bloyl/repos","events_url":"https://api.github.com/users/bloyl/events{/privacy}","received_events_url":"https://api.github.com/users/bloyl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-05-31T19:13:46Z","updated_at":"2018-06-15T16:16:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5255","html_url":"https://github.com/mne-tools/mne-python/pull/5255","diff_url":"https://github.com/mne-tools/mne-python/pull/5255.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5255.patch"},"body":"Current CTF IO doesn't read in bad channels or segments from *.ds/BadChannels and *.ds/bad.segments files.\r\n\r\nThis PR should address that.\r\n\r\nI stuck the new methods in `info.py` without a strong reason so if anyone thinks they make more sense somewhere else I'm happy to move them,\r\n\r\nHow should I test this?\r\n1) I could make a new version of `MNE-testing-data/CTF/testdata_ctf_short.ds `with a bad segment and a bad channel marked.\r\n\r\n2) I could alter an exists ds folder in `MNE-testing-data/CTF/` to have a bad segment and channel. \r\n\r\nDownside to option 1 is that it'll add ~10M to `MNE-testing-data`. Downside to option 2 is that it would potentially break/alter existing tests."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/397671240","html_url":"https://github.com/mne-tools/mne-python/pull/5255#issuecomment-397671240","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5255","id":397671240,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzY3MTI0MA==","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T16:16:59Z","updated_at":"2018-06-15T16:16:59Z","author_association":"MEMBER","body":"I see it as more of a bugfix / something we should have been doing all along. Do you think it's likely that people had bad channels and/or segments marked during acq that they wouldn't want marked during offline analysis? "}}
{"actor":{"display_login":"larsoner"}}