{"action":"created","comment":{"url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/comments/225371967","pull_request_review_id":164957933,"id":225371967,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTM3MTk2Nw==","diff_hunk":"@@ -9,6 +9,7 @@ const expandLocales = require('./lib/expand-locales');\n const extractPluralRules = require('./lib/extract-plurals');\n const getAllLocales = require('./lib/locales').getAllLocales;\n const extractRelativeFields = require('./lib/extract-relative');\n+const extractRelativeNumbers = require('./lib/extract-numbers');","path":"index.js","position":4,"original_position":4,"commit_id":"c2330825d0df3a14adfe273b1d5374534fba43b6","original_commit_id":"c2330825d0df3a14adfe273b1d5374534fba43b6","user":{"login":"jasonmit","id":3108309,"node_id":"MDQ6VXNlcjMxMDgzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/3108309?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"body":"`extractRelativeNumbers` should be `extractNumbers`","created_at":"2018-10-16T01:50:23Z","updated_at":"2018-10-16T01:50:24Z","html_url":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2#discussion_r225371967","pull_request_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/comments/225371967"},"html":{"href":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2#discussion_r225371967"},"pull_request":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2","id":216035945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDM1OTQ1","html_url":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2","diff_url":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2.diff","patch_url":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2.patch","issue_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/2","number":2,"state":"open","locked":false,"title":"Extract numberFields from cldr-numbers-full","user":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"body":"WIP - need to add more tests + refactor some methods (i.e. `findGreatestAncestor`) but basic structure is there.\r\n\r\nA few thoughts/questions before I finish this PR...\r\n\r\n1.  With the addition of relativeNumbers, `relativeFields` sounds redundant or perhaps not too specific.\r\n2. We are generating all locales by merging in the locales from the dates && numbers cldr package.  Seems redundant, but perhaps desire is to be \"safe\"?\r\n3.  Does `relativeNumbers` sound like a correct variable name to you? ","created_at":"2018-09-17T16:08:54Z","updated_at":"2018-10-16T01:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"375b6325741aeb88a6328969d05190429350aee3","assignee":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"assignees":[{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":662392620,"node_id":"MDU6TGFiZWw2NjIzOTI2MjA=","url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/2/comments","statuses_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/statuses/c2330825d0df3a14adfe273b1d5374534fba43b6","head":{"label":"snewcomer:sn/number-fields","ref":"sn/number-fields","sha":"c2330825d0df3a14adfe273b1d5374534fba43b6","user":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"repo":{"id":148540004,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NDAwMDQ=","name":"formatjs-extract-cldr-data","full_name":"snewcomer/formatjs-extract-cldr-data","private":false,"owner":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snewcomer/formatjs-extract-cldr-data","description":"Utility library that extracts the CLDR data that's needed by the FormatJS libraries.","fork":true,"url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data","forks_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/forks","keys_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/teams","hooks_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/hooks","issue_events_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/issues/events{/number}","events_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/events","assignees_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/assignees{/user}","branches_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/branches{/branch}","tags_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/tags","blobs_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/statuses/{sha}","languages_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/languages","stargazers_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/stargazers","contributors_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/contributors","subscribers_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/subscribers","subscription_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/subscription","commits_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/contents/{+path}","compare_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/merges","archive_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/downloads","issues_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/issues{/number}","pulls_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/pulls{/number}","milestones_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/milestones{/number}","notifications_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/labels{/name}","releases_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/releases{/id}","deployments_url":"https://api.github.com/repos/snewcomer/formatjs-extract-cldr-data/deployments","created_at":"2018-09-12T20:45:58Z","updated_at":"2018-09-12T20:46:00Z","pushed_at":"2018-10-13T08:20:14Z","git_url":"git://github.com/snewcomer/formatjs-extract-cldr-data.git","ssh_url":"git@github.com:snewcomer/formatjs-extract-cldr-data.git","clone_url":"https://github.com/snewcomer/formatjs-extract-cldr-data.git","svn_url":"https://github.com/snewcomer/formatjs-extract-cldr-data","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-intl:master","ref":"master","sha":"3a7e36b14f4a3fcdd3b2ecfe3b3d7ce59465f92f","user":{"login":"ember-intl","id":25829852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODI5ODUy","avatar_url":"https://avatars0.githubusercontent.com/u/25829852?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-intl","html_url":"https://github.com/ember-intl","followers_url":"https://api.github.com/users/ember-intl/followers","following_url":"https://api.github.com/users/ember-intl/following{/other_user}","gists_url":"https://api.github.com/users/ember-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-intl/subscriptions","organizations_url":"https://api.github.com/users/ember-intl/orgs","repos_url":"https://api.github.com/users/ember-intl/repos","events_url":"https://api.github.com/users/ember-intl/events{/privacy}","received_events_url":"https://api.github.com/users/ember-intl/received_events","type":"Organization","site_admin":false},"repo":{"id":99412133,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQxMjEzMw==","name":"formatjs-extract-cldr-data","full_name":"ember-intl/formatjs-extract-cldr-data","private":false,"owner":{"login":"ember-intl","id":25829852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1ODI5ODUy","avatar_url":"https://avatars0.githubusercontent.com/u/25829852?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-intl","html_url":"https://github.com/ember-intl","followers_url":"https://api.github.com/users/ember-intl/followers","following_url":"https://api.github.com/users/ember-intl/following{/other_user}","gists_url":"https://api.github.com/users/ember-intl/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-intl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-intl/subscriptions","organizations_url":"https://api.github.com/users/ember-intl/orgs","repos_url":"https://api.github.com/users/ember-intl/repos","events_url":"https://api.github.com/users/ember-intl/events{/privacy}","received_events_url":"https://api.github.com/users/ember-intl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ember-intl/formatjs-extract-cldr-data","description":"Utility library that extracts the CLDR data that's needed by the FormatJS libraries.","fork":true,"url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data","forks_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/forks","keys_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/teams","hooks_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/hooks","issue_events_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/events{/number}","events_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/events","assignees_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/assignees{/user}","branches_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/branches{/branch}","tags_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/tags","blobs_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/languages","stargazers_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/stargazers","contributors_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/contributors","subscribers_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/subscribers","subscription_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/subscription","commits_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/contents/{+path}","compare_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/merges","archive_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/downloads","issues_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues{/number}","pulls_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/labels{/name}","releases_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/releases{/id}","deployments_url":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/deployments","created_at":"2017-08-05T09:12:02Z","updated_at":"2018-09-13T15:16:30Z","pushed_at":"2018-10-13T08:20:12Z","git_url":"git://github.com/ember-intl/formatjs-extract-cldr-data.git","ssh_url":"git@github.com:ember-intl/formatjs-extract-cldr-data.git","clone_url":"https://github.com/ember-intl/formatjs-extract-cldr-data.git","svn_url":"https://github.com/ember-intl/formatjs-extract-cldr-data","homepage":null,"size":302,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2"},"html":{"href":"https://github.com/ember-intl/formatjs-extract-cldr-data/pull/2"},"issue":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/2"},"comments":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ember-intl/formatjs-extract-cldr-data/statuses/c2330825d0df3a14adfe273b1d5374534fba43b6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jasonmit"}}