{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/225754963","pull_request_review_id":165425074,"id":225754963,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTc1NDk2Mw==","diff_hunk":"@@ -548,24 +548,15 @@ object Validate {\n       block: BlockMessage,\n       dag: BlockDag,\n       emptyStateHash: StateHash,\n-      runtimeManager: RuntimeManager,\n-      knownStateHashesContainer: AtomicSyncVarF[F, Set[StateHash]]\n+      runtimeManager: RuntimeManager\n   )(implicit scheduler: Scheduler): F[Either[BlockStatus, ValidBlock]] =\n     for {\n-      maybeStateHash <- knownStateHashesContainer\n-                         .modify[Either[BlockException, Option[StateHash]]] { knownStateHashes =>\n-                           for {\n-                             //invalid blocks return None and don't update the checkpoints\n-                             validateBlockCheckpointResult <- InterpreterUtil\n-                                                               .validateBlockCheckpoint[F](\n-                                                                 block,\n-                                                                 dag,\n-                                                                 knownStateHashes,\n-                                                                 runtimeManager\n-                                                               )\n-                             (maybeStateHash, updatedknownStateHashes) = validateBlockCheckpointResult\n-                           } yield (updatedknownStateHashes, maybeStateHash)\n-                         }\n+      maybeStateHash <- InterpreterUtil\n+                         .validateBlockCheckpoint[F](\n+                           block,\n+                           dag,\n+                           runtimeManager\n+                         )","path":"casper/src/main/scala/coop/rchain/casper/Validate.scala","position":28,"original_position":28,"commit_id":"34933e1165ccac0edc3a21adfb32ee786841321b","original_commit_id":"34933e1165ccac0edc3a21adfb32ee786841321b","user":{"login":"KentShikama","id":6329898,"node_id":"MDQ6VXNlcjYzMjk4OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6329898?v=4","gravatar_id":"","url":"https://api.github.com/users/KentShikama","html_url":"https://github.com/KentShikama","followers_url":"https://api.github.com/users/KentShikama/followers","following_url":"https://api.github.com/users/KentShikama/following{/other_user}","gists_url":"https://api.github.com/users/KentShikama/gists{/gist_id}","starred_url":"https://api.github.com/users/KentShikama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KentShikama/subscriptions","organizations_url":"https://api.github.com/users/KentShikama/orgs","repos_url":"https://api.github.com/users/KentShikama/repos","events_url":"https://api.github.com/users/KentShikama/events{/privacy}","received_events_url":"https://api.github.com/users/KentShikama/received_events","type":"User","site_admin":false},"body":"That is a good point. The test shouldn't be necessary then. If you're bored enough, I would rather just see integration tests that will most likely force a bunch of blocks to be validated simultaneously. ","created_at":"2018-10-17T01:12:38Z","updated_at":"2018-10-17T01:12:38Z","html_url":"https://github.com/rchain/rchain/pull/1690#discussion_r225754963","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/1690","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/225754963"},"html":{"href":"https://github.com/rchain/rchain/pull/1690#discussion_r225754963"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1690"}},"in_reply_to_id":225600558},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/1690","id":223155427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTU1NDI3","html_url":"https://github.com/rchain/rchain/pull/1690","diff_url":"https://github.com/rchain/rchain/pull/1690.diff","patch_url":"https://github.com/rchain/rchain/pull/1690.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/1690","number":1690,"state":"open","locked":false,"title":"Remove known state hashes","user":{"login":"itegulov","id":7879134,"node_id":"MDQ6VXNlcjc4NzkxMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7879134?v=4","gravatar_id":"","url":"https://api.github.com/users/itegulov","html_url":"https://github.com/itegulov","followers_url":"https://api.github.com/users/itegulov/followers","following_url":"https://api.github.com/users/itegulov/following{/other_user}","gists_url":"https://api.github.com/users/itegulov/gists{/gist_id}","starred_url":"https://api.github.com/users/itegulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itegulov/subscriptions","organizations_url":"https://api.github.com/users/itegulov/orgs","repos_url":"https://api.github.com/users/itegulov/repos","events_url":"https://api.github.com/users/itegulov/events{/privacy}","received_events_url":"https://api.github.com/users/itegulov/received_events","type":"User","site_admin":false},"body":"## Overview\r\nAs per discussion with @KentShikama, assuming our state trie hasn't been corrupted, we aren't allowed to add a block until its parent has been processed. Thus, the known state hashes work only as a sanity check right now and need to be removed for the successful migration to the new BlockDagStorage API.\r\n\r\n### Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.\r\nhttps://rchain.atlassian.net/browse/RHOL-540\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] If this PR adds a new feature, this PR includes tests related to this feature.\r\n- [x] You assigned one person to review this PR\r\n\r\n### If you are not a member of the core development team, please confirm:\r\n- [ ] You signed the commit. Merging requires a signature. Please see the [developer wiki](https://rchain.atlassian.net/wiki/spaces/DOC/pages/498630673/How+to+sign+commits+to+rchain+rchain) for instructions.\r\n- [ ] Your GitHub account is also an account with [Travis CI](https://travis-ci.org). Unit tests will not run on your PR unless you have an account with Travis. Merge requires passed unit tests.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n","created_at":"2018-10-16T08:19:47Z","updated_at":"2018-10-17T01:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db9b3980fc9c29f5f76e725857ccf672b1fca7ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"birchmd","id":13788876,"node_id":"MDQ6VXNlcjEzNzg4ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/1690/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/1690/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/1690/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/34933e1165ccac0edc3a21adfb32ee786841321b","head":{"label":"itegulov:known-hashes-removal","ref":"known-hashes-removal","sha":"34933e1165ccac0edc3a21adfb32ee786841321b","user":{"login":"itegulov","id":7879134,"node_id":"MDQ6VXNlcjc4NzkxMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7879134?v=4","gravatar_id":"","url":"https://api.github.com/users/itegulov","html_url":"https://github.com/itegulov","followers_url":"https://api.github.com/users/itegulov/followers","following_url":"https://api.github.com/users/itegulov/following{/other_user}","gists_url":"https://api.github.com/users/itegulov/gists{/gist_id}","starred_url":"https://api.github.com/users/itegulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itegulov/subscriptions","organizations_url":"https://api.github.com/users/itegulov/orgs","repos_url":"https://api.github.com/users/itegulov/repos","events_url":"https://api.github.com/users/itegulov/events{/privacy}","received_events_url":"https://api.github.com/users/itegulov/received_events","type":"User","site_admin":false},"repo":{"id":141270456,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNzA0NTY=","name":"rchain","full_name":"itegulov/rchain","private":false,"owner":{"login":"itegulov","id":7879134,"node_id":"MDQ6VXNlcjc4NzkxMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7879134?v=4","gravatar_id":"","url":"https://api.github.com/users/itegulov","html_url":"https://github.com/itegulov","followers_url":"https://api.github.com/users/itegulov/followers","following_url":"https://api.github.com/users/itegulov/following{/other_user}","gists_url":"https://api.github.com/users/itegulov/gists{/gist_id}","starred_url":"https://api.github.com/users/itegulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itegulov/subscriptions","organizations_url":"https://api.github.com/users/itegulov/orgs","repos_url":"https://api.github.com/users/itegulov/repos","events_url":"https://api.github.com/users/itegulov/events{/privacy}","received_events_url":"https://api.github.com/users/itegulov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/itegulov/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/itegulov/rchain","forks_url":"https://api.github.com/repos/itegulov/rchain/forks","keys_url":"https://api.github.com/repos/itegulov/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itegulov/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itegulov/rchain/teams","hooks_url":"https://api.github.com/repos/itegulov/rchain/hooks","issue_events_url":"https://api.github.com/repos/itegulov/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/itegulov/rchain/events","assignees_url":"https://api.github.com/repos/itegulov/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/itegulov/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/itegulov/rchain/tags","blobs_url":"https://api.github.com/repos/itegulov/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itegulov/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itegulov/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/itegulov/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itegulov/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/itegulov/rchain/languages","stargazers_url":"https://api.github.com/repos/itegulov/rchain/stargazers","contributors_url":"https://api.github.com/repos/itegulov/rchain/contributors","subscribers_url":"https://api.github.com/repos/itegulov/rchain/subscribers","subscription_url":"https://api.github.com/repos/itegulov/rchain/subscription","commits_url":"https://api.github.com/repos/itegulov/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/itegulov/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/itegulov/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/itegulov/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/itegulov/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/itegulov/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itegulov/rchain/merges","archive_url":"https://api.github.com/repos/itegulov/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itegulov/rchain/downloads","issues_url":"https://api.github.com/repos/itegulov/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/itegulov/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/itegulov/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/itegulov/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itegulov/rchain/labels{/name}","releases_url":"https://api.github.com/repos/itegulov/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/itegulov/rchain/deployments","created_at":"2018-07-17T10:01:04Z","updated_at":"2018-07-17T10:01:07Z","pushed_at":"2018-10-16T08:15:14Z","git_url":"git://github.com/itegulov/rchain.git","ssh_url":"git@github.com:itegulov/rchain.git","clone_url":"https://github.com/itegulov/rchain.git","svn_url":"https://github.com/itegulov/rchain","homepage":null,"size":18358,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"4877c38cb744c9ed0d3e765c20606268cf426d49","user":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ5MzY5MQ==","name":"rchain","full_name":"rchain/rchain","private":false,"owner":{"login":"rchain","id":20671765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjcxNzY1","avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-10-17T00:58:48Z","pushed_at":"2018-10-17T00:59:28Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":18386,"stargazers_count":460,"watchers_count":460,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":129,"open_issues":30,"watchers":460,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1690"},"html":{"href":"https://github.com/rchain/rchain/pull/1690"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/1690"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/1690/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1690/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/1690/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/34933e1165ccac0edc3a21adfb32ee786841321b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"KentShikama"}}