{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/33649","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/33649/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33649/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/33649/events","html_url":"https://github.com/dotnet/corefx/pull/33649","id":383172414,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzA2MjU4","number":33649,"title":"Add ImmutableInterlocked.GetOrAdd for sets","user":{"login":"drewnoakes","id":350947,"node_id":"MDQ6VXNlcjM1MDk0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/350947?v=4","gravatar_id":"","url":"https://api.github.com/users/drewnoakes","html_url":"https://github.com/drewnoakes","followers_url":"https://api.github.com/users/drewnoakes/followers","following_url":"https://api.github.com/users/drewnoakes/following{/other_user}","gists_url":"https://api.github.com/users/drewnoakes/gists{/gist_id}","starred_url":"https://api.github.com/users/drewnoakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewnoakes/subscriptions","organizations_url":"https://api.github.com/users/drewnoakes/orgs","repos_url":"https://api.github.com/users/drewnoakes/repos","events_url":"https://api.github.com/users/drewnoakes/events{/privacy}","received_events_url":"https://api.github.com/users/drewnoakes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-21T15:32:52Z","updated_at":"2018-11-21T19:53:14Z","closed_at":"2018-11-21T19:53:14Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33649","html_url":"https://github.com/dotnet/corefx/pull/33649","diff_url":"https://github.com/dotnet/corefx/pull/33649.diff","patch_url":"https://github.com/dotnet/corefx/pull/33649.patch"},"body":"This brings support for interlocked updates to `ImmutableHashSet<T>` and `ImmutableOrderedSet<T>`.\r\n\r\nSuch a pattern is particularly useful for object pools/caches. We use something similar in `dotnet/project-system` to consolidate object references and reduce retained memory.\r\n\r\nShould thes new methods have type constraint `where T : class`? I don't think they makes much sense for value types."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/440790123","html_url":"https://github.com/dotnet/corefx/pull/33649#issuecomment-440790123","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33649","id":440790123,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDc5MDEyMw==","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T19:53:14Z","updated_at":"2018-11-21T19:53:14Z","author_association":"MEMBER","body":"@drewnoakes, thanks, but as this is adding new public surface area, could you please follow the steps in https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/api-review-process.md? It starts with opening an issue proposing the new APIs, and only one they're approved do we like to see/review PRs. Thanks! In the meantime, I'm going to close this."}}
{"actor":{"display_login":"stephentoub"}}