{"action":"created","comment":{"url":"https://api.github.com/repos/gofrs/uuid/pulls/comments/229132195","pull_request_review_id":169559234,"id":229132195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTEzMjE5NQ==","diff_hunk":"@@ -193,6 +194,21 @@ func testNullUUIDScanValid(t *testing.T) {\n \t}\n }\n \n+func testNullUUIDScanUUID(t *testing.T) {\n+\ts := UUID{}","path":"sql_test.go","position":13,"original_position":13,"commit_id":"8719eca9965f0dde0acdf42c6a5b06ef0da0b85d","original_commit_id":"8719eca9965f0dde0acdf42c6a5b06ef0da0b85d","user":{"login":"acln0","id":3393388,"node_id":"MDQ6VXNlcjMzOTMzODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3393388?v=4","gravatar_id":"","url":"https://api.github.com/users/acln0","html_url":"https://github.com/acln0","followers_url":"https://api.github.com/users/acln0/followers","following_url":"https://api.github.com/users/acln0/following{/other_user}","gists_url":"https://api.github.com/users/acln0/gists{/gist_id}","starred_url":"https://api.github.com/users/acln0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acln0/subscriptions","organizations_url":"https://api.github.com/users/acln0/orgs","repos_url":"https://api.github.com/users/acln0/repos","events_url":"https://api.github.com/users/acln0/events{/privacy}","received_events_url":"https://api.github.com/users/acln0/received_events","type":"User","site_admin":false},"body":"Let's not use the zero value here. It could lead to confusion. Please use `codecTestUUID` instead.","created_at":"2018-10-29T23:22:21Z","updated_at":"2018-10-29T23:22:49Z","html_url":"https://github.com/gofrs/uuid/pull/58#discussion_r229132195","pull_request_url":"https://api.github.com/repos/gofrs/uuid/pulls/58","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/comments/229132195"},"html":{"href":"https://github.com/gofrs/uuid/pull/58#discussion_r229132195"},"pull_request":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/gofrs/uuid/pulls/58","id":226221493,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjIxNDkz","html_url":"https://github.com/gofrs/uuid/pull/58","diff_url":"https://github.com/gofrs/uuid/pull/58.diff","patch_url":"https://github.com/gofrs/uuid/pull/58.patch","issue_url":"https://api.github.com/repos/gofrs/uuid/issues/58","number":58,"state":"open","locked":false,"title":"Change (*UUID) Scan to accept type UUID argument","user":{"login":"nanjj","id":640746,"node_id":"MDQ6VXNlcjY0MDc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/640746?v=4","gravatar_id":"","url":"https://api.github.com/users/nanjj","html_url":"https://github.com/nanjj","followers_url":"https://api.github.com/users/nanjj/followers","following_url":"https://api.github.com/users/nanjj/following{/other_user}","gists_url":"https://api.github.com/users/nanjj/gists{/gist_id}","starred_url":"https://api.github.com/users/nanjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanjj/subscriptions","organizations_url":"https://api.github.com/users/nanjj/orgs","repos_url":"https://api.github.com/users/nanjj/repos","events_url":"https://api.github.com/users/nanjj/events{/privacy}","received_events_url":"https://api.github.com/users/nanjj/received_events","type":"User","site_admin":false},"body":"Type UUID can not used as primary key, which is not NULL in table. Type\r\nNullUUID can be used as reference to the primary key in another table,\r\nwhich may be NULL. If we use jinzhu/gorm to implement the usage\r\nscenario, jinzhu/gorm convert UUID to NullUUID via NullUUID Scan\r\ncall. Without the fix below error may be found: uuid: cannot convert\r\nuuid.UUID to UUID.\r\n\r\nThis fix changes (*UUID) scan to accept UUID argument.\r\n","created_at":"2018-10-26T20:46:34Z","updated_at":"2018-10-29T23:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e87523c94b57f00c06b931e7b16e11a6cbe4259c","assignee":{"login":"acln0","id":3393388,"node_id":"MDQ6VXNlcjMzOTMzODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3393388?v=4","gravatar_id":"","url":"https://api.github.com/users/acln0","html_url":"https://github.com/acln0","followers_url":"https://api.github.com/users/acln0/followers","following_url":"https://api.github.com/users/acln0/following{/other_user}","gists_url":"https://api.github.com/users/acln0/gists{/gist_id}","starred_url":"https://api.github.com/users/acln0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acln0/subscriptions","organizations_url":"https://api.github.com/users/acln0/orgs","repos_url":"https://api.github.com/users/acln0/repos","events_url":"https://api.github.com/users/acln0/events{/privacy}","received_events_url":"https://api.github.com/users/acln0/received_events","type":"User","site_admin":false},"assignees":[{"login":"acln0","id":3393388,"node_id":"MDQ6VXNlcjMzOTMzODg=","avatar_url":"https://avatars0.githubusercontent.com/u/3393388?v=4","gravatar_id":"","url":"https://api.github.com/users/acln0","html_url":"https://github.com/acln0","followers_url":"https://api.github.com/users/acln0/followers","following_url":"https://api.github.com/users/acln0/following{/other_user}","gists_url":"https://api.github.com/users/acln0/gists{/gist_id}","starred_url":"https://api.github.com/users/acln0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acln0/subscriptions","organizations_url":"https://api.github.com/users/acln0/orgs","repos_url":"https://api.github.com/users/acln0/repos","events_url":"https://api.github.com/users/acln0/events{/privacy}","received_events_url":"https://api.github.com/users/acln0/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gofrs/uuid/pulls/58/commits","review_comments_url":"https://api.github.com/repos/gofrs/uuid/pulls/58/comments","review_comment_url":"https://api.github.com/repos/gofrs/uuid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gofrs/uuid/issues/58/comments","statuses_url":"https://api.github.com/repos/gofrs/uuid/statuses/8719eca9965f0dde0acdf42c6a5b06ef0da0b85d","head":{"label":"nanjj:sqlscan","ref":"sqlscan","sha":"8719eca9965f0dde0acdf42c6a5b06ef0da0b85d","user":{"login":"nanjj","id":640746,"node_id":"MDQ6VXNlcjY0MDc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/640746?v=4","gravatar_id":"","url":"https://api.github.com/users/nanjj","html_url":"https://github.com/nanjj","followers_url":"https://api.github.com/users/nanjj/followers","following_url":"https://api.github.com/users/nanjj/following{/other_user}","gists_url":"https://api.github.com/users/nanjj/gists{/gist_id}","starred_url":"https://api.github.com/users/nanjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanjj/subscriptions","organizations_url":"https://api.github.com/users/nanjj/orgs","repos_url":"https://api.github.com/users/nanjj/repos","events_url":"https://api.github.com/users/nanjj/events{/privacy}","received_events_url":"https://api.github.com/users/nanjj/received_events","type":"User","site_admin":false},"repo":{"id":154891215,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4OTEyMTU=","name":"uuid","full_name":"nanjj/uuid","private":false,"owner":{"login":"nanjj","id":640746,"node_id":"MDQ6VXNlcjY0MDc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/640746?v=4","gravatar_id":"","url":"https://api.github.com/users/nanjj","html_url":"https://github.com/nanjj","followers_url":"https://api.github.com/users/nanjj/followers","following_url":"https://api.github.com/users/nanjj/following{/other_user}","gists_url":"https://api.github.com/users/nanjj/gists{/gist_id}","starred_url":"https://api.github.com/users/nanjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanjj/subscriptions","organizations_url":"https://api.github.com/users/nanjj/orgs","repos_url":"https://api.github.com/users/nanjj/repos","events_url":"https://api.github.com/users/nanjj/events{/privacy}","received_events_url":"https://api.github.com/users/nanjj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nanjj/uuid","description":"A UUID package originally forked from github.com/satori/go.uuid","fork":true,"url":"https://api.github.com/repos/nanjj/uuid","forks_url":"https://api.github.com/repos/nanjj/uuid/forks","keys_url":"https://api.github.com/repos/nanjj/uuid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanjj/uuid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanjj/uuid/teams","hooks_url":"https://api.github.com/repos/nanjj/uuid/hooks","issue_events_url":"https://api.github.com/repos/nanjj/uuid/issues/events{/number}","events_url":"https://api.github.com/repos/nanjj/uuid/events","assignees_url":"https://api.github.com/repos/nanjj/uuid/assignees{/user}","branches_url":"https://api.github.com/repos/nanjj/uuid/branches{/branch}","tags_url":"https://api.github.com/repos/nanjj/uuid/tags","blobs_url":"https://api.github.com/repos/nanjj/uuid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanjj/uuid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanjj/uuid/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanjj/uuid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanjj/uuid/statuses/{sha}","languages_url":"https://api.github.com/repos/nanjj/uuid/languages","stargazers_url":"https://api.github.com/repos/nanjj/uuid/stargazers","contributors_url":"https://api.github.com/repos/nanjj/uuid/contributors","subscribers_url":"https://api.github.com/repos/nanjj/uuid/subscribers","subscription_url":"https://api.github.com/repos/nanjj/uuid/subscription","commits_url":"https://api.github.com/repos/nanjj/uuid/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanjj/uuid/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanjj/uuid/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanjj/uuid/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanjj/uuid/contents/{+path}","compare_url":"https://api.github.com/repos/nanjj/uuid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanjj/uuid/merges","archive_url":"https://api.github.com/repos/nanjj/uuid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanjj/uuid/downloads","issues_url":"https://api.github.com/repos/nanjj/uuid/issues{/number}","pulls_url":"https://api.github.com/repos/nanjj/uuid/pulls{/number}","milestones_url":"https://api.github.com/repos/nanjj/uuid/milestones{/number}","notifications_url":"https://api.github.com/repos/nanjj/uuid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanjj/uuid/labels{/name}","releases_url":"https://api.github.com/repos/nanjj/uuid/releases{/id}","deployments_url":"https://api.github.com/repos/nanjj/uuid/deployments","created_at":"2018-10-26T20:32:22Z","updated_at":"2018-10-26T20:34:24Z","pushed_at":"2018-10-29T16:35:21Z","git_url":"git://github.com/nanjj/uuid.git","ssh_url":"git@github.com:nanjj/uuid.git","clone_url":"https://github.com/nanjj/uuid.git","svn_url":"https://github.com/nanjj/uuid","homepage":"https://gof.rs/projects/uuid/","size":179,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gofrs:master","ref":"master","sha":"48eeef780dd5510f08637709bf3e700fc00f4f10","user":{"login":"gofrs","id":41122364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTIyMzY0","avatar_url":"https://avatars2.githubusercontent.com/u/41122364?v=4","gravatar_id":"","url":"https://api.github.com/users/gofrs","html_url":"https://github.com/gofrs","followers_url":"https://api.github.com/users/gofrs/followers","following_url":"https://api.github.com/users/gofrs/following{/other_user}","gists_url":"https://api.github.com/users/gofrs/gists{/gist_id}","starred_url":"https://api.github.com/users/gofrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gofrs/subscriptions","organizations_url":"https://api.github.com/users/gofrs/orgs","repos_url":"https://api.github.com/users/gofrs/repos","events_url":"https://api.github.com/users/gofrs/events{/privacy}","received_events_url":"https://api.github.com/users/gofrs/received_events","type":"Organization","site_admin":false},"repo":{"id":140785428,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3ODU0Mjg=","name":"uuid","full_name":"gofrs/uuid","private":false,"owner":{"login":"gofrs","id":41122364,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTIyMzY0","avatar_url":"https://avatars2.githubusercontent.com/u/41122364?v=4","gravatar_id":"","url":"https://api.github.com/users/gofrs","html_url":"https://github.com/gofrs","followers_url":"https://api.github.com/users/gofrs/followers","following_url":"https://api.github.com/users/gofrs/following{/other_user}","gists_url":"https://api.github.com/users/gofrs/gists{/gist_id}","starred_url":"https://api.github.com/users/gofrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gofrs/subscriptions","organizations_url":"https://api.github.com/users/gofrs/orgs","repos_url":"https://api.github.com/users/gofrs/repos","events_url":"https://api.github.com/users/gofrs/events{/privacy}","received_events_url":"https://api.github.com/users/gofrs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gofrs/uuid","description":"A UUID package originally forked from github.com/satori/go.uuid","fork":false,"url":"https://api.github.com/repos/gofrs/uuid","forks_url":"https://api.github.com/repos/gofrs/uuid/forks","keys_url":"https://api.github.com/repos/gofrs/uuid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gofrs/uuid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gofrs/uuid/teams","hooks_url":"https://api.github.com/repos/gofrs/uuid/hooks","issue_events_url":"https://api.github.com/repos/gofrs/uuid/issues/events{/number}","events_url":"https://api.github.com/repos/gofrs/uuid/events","assignees_url":"https://api.github.com/repos/gofrs/uuid/assignees{/user}","branches_url":"https://api.github.com/repos/gofrs/uuid/branches{/branch}","tags_url":"https://api.github.com/repos/gofrs/uuid/tags","blobs_url":"https://api.github.com/repos/gofrs/uuid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gofrs/uuid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gofrs/uuid/git/refs{/sha}","trees_url":"https://api.github.com/repos/gofrs/uuid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gofrs/uuid/statuses/{sha}","languages_url":"https://api.github.com/repos/gofrs/uuid/languages","stargazers_url":"https://api.github.com/repos/gofrs/uuid/stargazers","contributors_url":"https://api.github.com/repos/gofrs/uuid/contributors","subscribers_url":"https://api.github.com/repos/gofrs/uuid/subscribers","subscription_url":"https://api.github.com/repos/gofrs/uuid/subscription","commits_url":"https://api.github.com/repos/gofrs/uuid/commits{/sha}","git_commits_url":"https://api.github.com/repos/gofrs/uuid/git/commits{/sha}","comments_url":"https://api.github.com/repos/gofrs/uuid/comments{/number}","issue_comment_url":"https://api.github.com/repos/gofrs/uuid/issues/comments{/number}","contents_url":"https://api.github.com/repos/gofrs/uuid/contents/{+path}","compare_url":"https://api.github.com/repos/gofrs/uuid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gofrs/uuid/merges","archive_url":"https://api.github.com/repos/gofrs/uuid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gofrs/uuid/downloads","issues_url":"https://api.github.com/repos/gofrs/uuid/issues{/number}","pulls_url":"https://api.github.com/repos/gofrs/uuid/pulls{/number}","milestones_url":"https://api.github.com/repos/gofrs/uuid/milestones{/number}","notifications_url":"https://api.github.com/repos/gofrs/uuid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gofrs/uuid/labels{/name}","releases_url":"https://api.github.com/repos/gofrs/uuid/releases{/id}","deployments_url":"https://api.github.com/repos/gofrs/uuid/deployments","created_at":"2018-07-13T02:13:28Z","updated_at":"2018-10-27T14:32:53Z","pushed_at":"2018-10-29T16:35:23Z","git_url":"git://github.com/gofrs/uuid.git","ssh_url":"git@github.com:gofrs/uuid.git","clone_url":"https://github.com/gofrs/uuid.git","svn_url":"https://github.com/gofrs/uuid","homepage":"https://gof.rs/projects/uuid/","size":179,"stargazers_count":313,"watchers_count":313,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":3,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/58"},"html":{"href":"https://github.com/gofrs/uuid/pull/58"},"issue":{"href":"https://api.github.com/repos/gofrs/uuid/issues/58"},"comments":{"href":"https://api.github.com/repos/gofrs/uuid/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gofrs/uuid/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/gofrs/uuid/statuses/8719eca9965f0dde0acdf42c6a5b06ef0da0b85d"}},"author_association":"NONE"}}
{"actor":{"display_login":"acln0"}}