{"action":"created","issue":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/792","repository_url":"https://api.github.com/repos/TextureGroup/Texture","labels_url":"https://api.github.com/repos/TextureGroup/Texture/issues/792/labels{/name}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/792/comments","events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/792/events","html_url":"https://github.com/TextureGroup/Texture/pull/792","id":294904984,"number":792,"title":"[ASDisplayNode layout] Fix an issue that sometimes causes a node's pending layout to not be applied","user":{"login":"nguyenhuy","id":587874,"avatar_url":"https://avatars1.githubusercontent.com/u/587874?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-06T20:37:43Z","updated_at":"2018-02-12T21:04:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/792","html_url":"https://github.com/TextureGroup/Texture/pull/792","diff_url":"https://github.com/TextureGroup/Texture/pull/792.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/792.patch"},"body":"- Since the implementation of layout version (#428), if a node's pending and calculated layouts have the same current version as well as the same constrained size, the 2 layouts are considered equal and can be used interchangeably. A layout version check between the 2 layouts was added in #695. This PR adds a missing constrained size check.\r\n- If the pending layout has the same version but a different constrained size compare to the calculated layout's, we can assume that the pending layout is newer and should be preferred over the calculated one. That is because layout operations always register their new layout as pending, which then (immediately or eventually) get applied to the node as calculated layout."},"comment":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments/365061408","html_url":"https://github.com/TextureGroup/Texture/pull/792#issuecomment-365061408","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/792","id":365061408,"user":{"login":"nguyenhuy","id":587874,"avatar_url":"https://avatars1.githubusercontent.com/u/587874?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T21:04:47Z","updated_at":"2018-02-12T21:04:47Z","author_association":"MEMBER","body":"Awesome. Thank you!"}}
{"actor":{"display_login":"nguyenhuy"}}