{"action":"created","issue":{"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/545","repository_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe","labels_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/545/labels{/name}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/545/comments","events_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/545/events","html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/545","id":297393256,"number":545,"title":"Proposal Updater + Update meta_key name","user":{"login":"rvola","id":6870615,"avatar_url":"https://avatars2.githubusercontent.com/u/6870615?v=4","gravatar_id":"","url":"https://api.github.com/users/rvola","html_url":"https://github.com/rvola","followers_url":"https://api.github.com/users/rvola/followers","following_url":"https://api.github.com/users/rvola/following{/other_user}","gists_url":"https://api.github.com/users/rvola/gists{/gist_id}","starred_url":"https://api.github.com/users/rvola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvola/subscriptions","organizations_url":"https://api.github.com/users/rvola/orgs","repos_url":"https://api.github.com/users/rvola/repos","events_url":"https://api.github.com/users/rvola/events{/privacy}","received_events_url":"https://api.github.com/users/rvola/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-15T10:22:15Z","updated_at":"2018-02-15T17:46:33Z","closed_at":"2018-02-15T17:46:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/pulls/545","html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/545","diff_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/545.diff","patch_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/545.patch"},"body":"Hello team and hello @roykho\r\n\r\nBefore quickly closing my PR, I ask you to try to look calmly.\r\n\r\nIndeed, the extension Stripe really use a bad name meta_key to save the Fees and Net.\r\n\r\nI wondered how to evolve this, for something more conventional.\r\n\r\nI then create the \"bases\" of a class Updater, which would also allow in the future of this extension to be able to modify certain data in SQL.\r\n\r\nI ask you to judge the relevance of this PR, and to guide me to improve this code.\r\n\r\nI first made the conventions of WordPress writing.\r\n-------------------\r\n- [x] Make sure your changes respect [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/).\r\n- [ ] Did you make changes, or create a **new .js file**? If **Gruntfile.js** exists in the repo, make sure to run `grunt`.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/comments/366006435","html_url":"https://github.com/woocommerce/woocommerce-gateway-stripe/pull/545#issuecomment-366006435","issue_url":"https://api.github.com/repos/woocommerce/woocommerce-gateway-stripe/issues/545","id":366006435,"user":{"login":"roykho","id":2132595,"avatar_url":"https://avatars3.githubusercontent.com/u/2132595?v=4","gravatar_id":"","url":"https://api.github.com/users/roykho","html_url":"https://github.com/roykho","followers_url":"https://api.github.com/users/roykho/followers","following_url":"https://api.github.com/users/roykho/following{/other_user}","gists_url":"https://api.github.com/users/roykho/gists{/gist_id}","starred_url":"https://api.github.com/users/roykho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roykho/subscriptions","organizations_url":"https://api.github.com/users/roykho/orgs","repos_url":"https://api.github.com/users/roykho/repos","events_url":"https://api.github.com/users/roykho/events{/privacy}","received_events_url":"https://api.github.com/users/roykho/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T17:46:33Z","updated_at":"2018-02-15T17:46:33Z","author_association":"OWNER","body":"Hello, thanks for the PR however we follow the lead on WooCommerce for that. They use the same idea https://github.com/woocommerce/woocommerce/blob/master/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php#L210\r\n\r\nSo perhaps you want to first convince them to use your approach and then we can follow suit."}}
{"actor":{"display_login":"roykho"}}