{"action":"closed","number":1833,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833","id":239240519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjQwNTE5","html_url":"https://github.com/ArkEcosystem/core/pull/1833","diff_url":"https://github.com/ArkEcosystem/core/pull/1833.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/1833.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1833","number":1833,"state":"closed","locked":false,"title":"Package up core-logger types","user":{"login":"paroxysm","id":2207711,"node_id":"MDQ6VXNlcjIyMDc3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2207711?v=4","gravatar_id":"","url":"https://api.github.com/users/paroxysm","html_url":"https://github.com/paroxysm","followers_url":"https://api.github.com/users/paroxysm/followers","following_url":"https://api.github.com/users/paroxysm/following{/other_user}","gists_url":"https://api.github.com/users/paroxysm/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxysm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxysm/subscriptions","organizations_url":"https://api.github.com/users/paroxysm/orgs","repos_url":"https://api.github.com/users/paroxysm/repos","events_url":"https://api.github.com/users/paroxysm/events{/privacy}","received_events_url":"https://api.github.com/users/paroxysm/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\nAddresses #1807\r\nExports core-logger types to introduce type-safety to modules that depend on it.\r\nAccording to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html\r\nWe have two options, we can package up the types in the module itself leveraging https://basarat.gitbooks.io/typescript/docs/tips/barrel.html to export all types that other dependencies might reference OR publish a separate @types/<ark_module> to npm for each module. The former just works and resolves locally(w/o having to go through NPM to resolve things) so we can adopt that for the rest of the modules.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [ ] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Build (changes that affect the build system)\r\n- [ ] Docs (documentation only changes)\r\n- [ ] Test (adding missing tests or fixing existing tests)\r\n- [ ] Other... Please describe:\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n<!--\r\n","created_at":"2018-12-17T18:24:09Z","updated_at":"2018-12-19T04:14:14Z","closed_at":"2018-12-19T04:14:14Z","merged_at":"2018-12-19T04:14:14Z","merge_commit_sha":"ef2d32182fafcec9842fddd8f1b54553ffdb27ba","assignee":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"assignees":[{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1101101126,"node_id":"MDU6TGFiZWwxMTAxMTAxMTI2","url":"https://api.github.com/repos/ArkEcosystem/core/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1833/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/b55bfffee854421f753d43c1ee24fa7d6f77454c","head":{"label":"paroxysm:feat/export-core-logger-types","ref":"feat/export-core-logger-types","sha":"b55bfffee854421f753d43c1ee24fa7d6f77454c","user":{"login":"paroxysm","id":2207711,"node_id":"MDQ6VXNlcjIyMDc3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2207711?v=4","gravatar_id":"","url":"https://api.github.com/users/paroxysm","html_url":"https://github.com/paroxysm","followers_url":"https://api.github.com/users/paroxysm/followers","following_url":"https://api.github.com/users/paroxysm/following{/other_user}","gists_url":"https://api.github.com/users/paroxysm/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxysm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxysm/subscriptions","organizations_url":"https://api.github.com/users/paroxysm/orgs","repos_url":"https://api.github.com/users/paroxysm/repos","events_url":"https://api.github.com/users/paroxysm/events{/privacy}","received_events_url":"https://api.github.com/users/paroxysm/received_events","type":"User","site_admin":false},"repo":{"id":140896963,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4OTY5NjM=","name":"core","full_name":"paroxysm/core","private":false,"owner":{"login":"paroxysm","id":2207711,"node_id":"MDQ6VXNlcjIyMDc3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2207711?v=4","gravatar_id":"","url":"https://api.github.com/users/paroxysm","html_url":"https://github.com/paroxysm","followers_url":"https://api.github.com/users/paroxysm/followers","following_url":"https://api.github.com/users/paroxysm/following{/other_user}","gists_url":"https://api.github.com/users/paroxysm/gists{/gist_id}","starred_url":"https://api.github.com/users/paroxysm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paroxysm/subscriptions","organizations_url":"https://api.github.com/users/paroxysm/orgs","repos_url":"https://api.github.com/users/paroxysm/repos","events_url":"https://api.github.com/users/paroxysm/events{/privacy}","received_events_url":"https://api.github.com/users/paroxysm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paroxysm/core","description":"The WP of Blockchains :fireworks:","fork":true,"url":"https://api.github.com/repos/paroxysm/core","forks_url":"https://api.github.com/repos/paroxysm/core/forks","keys_url":"https://api.github.com/repos/paroxysm/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paroxysm/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paroxysm/core/teams","hooks_url":"https://api.github.com/repos/paroxysm/core/hooks","issue_events_url":"https://api.github.com/repos/paroxysm/core/issues/events{/number}","events_url":"https://api.github.com/repos/paroxysm/core/events","assignees_url":"https://api.github.com/repos/paroxysm/core/assignees{/user}","branches_url":"https://api.github.com/repos/paroxysm/core/branches{/branch}","tags_url":"https://api.github.com/repos/paroxysm/core/tags","blobs_url":"https://api.github.com/repos/paroxysm/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paroxysm/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paroxysm/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/paroxysm/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paroxysm/core/statuses/{sha}","languages_url":"https://api.github.com/repos/paroxysm/core/languages","stargazers_url":"https://api.github.com/repos/paroxysm/core/stargazers","contributors_url":"https://api.github.com/repos/paroxysm/core/contributors","subscribers_url":"https://api.github.com/repos/paroxysm/core/subscribers","subscription_url":"https://api.github.com/repos/paroxysm/core/subscription","commits_url":"https://api.github.com/repos/paroxysm/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/paroxysm/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/paroxysm/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/paroxysm/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/paroxysm/core/contents/{+path}","compare_url":"https://api.github.com/repos/paroxysm/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paroxysm/core/merges","archive_url":"https://api.github.com/repos/paroxysm/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paroxysm/core/downloads","issues_url":"https://api.github.com/repos/paroxysm/core/issues{/number}","pulls_url":"https://api.github.com/repos/paroxysm/core/pulls{/number}","milestones_url":"https://api.github.com/repos/paroxysm/core/milestones{/number}","notifications_url":"https://api.github.com/repos/paroxysm/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paroxysm/core/labels{/name}","releases_url":"https://api.github.com/repos/paroxysm/core/releases{/id}","deployments_url":"https://api.github.com/repos/paroxysm/core/deployments","created_at":"2018-07-13T22:10:05Z","updated_at":"2018-08-23T02:33:28Z","pushed_at":"2018-12-19T03:56:26Z","git_url":"git://github.com/paroxysm/core.git","ssh_url":"git@github.com:paroxysm/core.git","clone_url":"https://github.com/paroxysm/core.git","svn_url":"https://github.com/paroxysm/core","homepage":"https://ark.io","size":12038,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:develop","ref":"develop","sha":"b172743953d8f32051b7b84dbabf71910b0db5b7","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":111684364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2ODQzNjQ=","name":"core","full_name":"ArkEcosystem/core","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/core","description":"The Ark Blockchain :fireworks:. Check https://docs.ark.io/guidebook/ for more information.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/core","forks_url":"https://api.github.com/repos/ArkEcosystem/core/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/core/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/core/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/core/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/core/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/core/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/core/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/core/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/core/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/core/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/core/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/core/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/core/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/core/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/core/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/core/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/core/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/core/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/core/deployments","created_at":"2017-11-22T12:57:35Z","updated_at":"2018-12-17T14:01:37Z","pushed_at":"2018-12-19T04:14:14Z","git_url":"git://github.com/ArkEcosystem/core.git","ssh_url":"git@github.com:ArkEcosystem/core.git","clone_url":"https://github.com/ArkEcosystem/core.git","svn_url":"https://github.com/ArkEcosystem/core","homepage":"https://ark.io","size":12256,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":65,"open_issues":127,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833"},"html":{"href":"https://github.com/ArkEcosystem/core/pull/1833"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1833"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1833/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1833/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/core/statuses/b55bfffee854421f753d43c1ee24fa7d6f77454c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"comments":3,"review_comments":11,"maintainer_can_modify":false,"commits":5,"additions":21,"deletions":18,"changed_files":7}}
{"actor":{"display_login":"faustbrian"}}