{"action":"created","comment":{"url":"https://api.github.com/repos/cadets/freebsd/pulls/comments/216888368","pull_request_review_id":154473641,"id":216888368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjg4ODM2OA==","diff_hunk":"@@ -428,14 +435,22 @@ dt_dis(const dtrace_difo_t *dp, FILE *fp)\n \t\t{ \"rldx\", dt_dis_load },\t/* DIF_OP_RLDX */\n \t\t{ \"xlate\", dt_dis_xlate },\t/* DIF_OP_XLATE */\n \t\t{ \"xlarg\", dt_dis_xlate },\t/* DIF_OP_XLARG */\n+\t\t{ \"hcall\", dt_dis_str },\t/* DIF_OP_HCALL */","path":"cddl/contrib/opensolaris/lib/libdtrace/common/dt_dis.c","position":18,"original_position":18,"commit_id":"aaa404d1b568c76ac04508e144fd3882c263c58c","original_commit_id":"aaa404d1b568c76ac04508e144fd3882c263c58c","user":{"login":"rwatson","id":186862,"node_id":"MDQ6VXNlcjE4Njg2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/186862?v=4","gravatar_id":"","url":"https://api.github.com/users/rwatson","html_url":"https://github.com/rwatson","followers_url":"https://api.github.com/users/rwatson/followers","following_url":"https://api.github.com/users/rwatson/following{/other_user}","gists_url":"https://api.github.com/users/rwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/rwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwatson/subscriptions","organizations_url":"https://api.github.com/users/rwatson/orgs","repos_url":"https://api.github.com/users/rwatson/repos","events_url":"https://api.github.com/users/rwatson/events{/privacy}","received_events_url":"https://api.github.com/users/rwatson/received_events","type":"User","site_admin":false},"body":"In general, consider being consistent about whether the “h” and “g” additions going before or after current names, and whether to use underscores. I would suggest before, and with underscores — e.g., “hh_scmp” here, and similar changes throughout for symbols, macros, function names, etc. That will make them easier to search for / search and replace.","created_at":"2018-09-12T03:39:55Z","updated_at":"2018-09-12T03:41:19Z","html_url":"https://github.com/cadets/freebsd/pull/103#discussion_r216888368","pull_request_url":"https://api.github.com/repos/cadets/freebsd/pulls/103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/comments/216888368"},"html":{"href":"https://github.com/cadets/freebsd/pull/103#discussion_r216888368"},"pull_request":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/cadets/freebsd/pulls/103","id":214600610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjAwNjEw","html_url":"https://github.com/cadets/freebsd/pull/103","diff_url":"https://github.com/cadets/freebsd/pull/103.diff","patch_url":"https://github.com/cadets/freebsd/pull/103.patch","issue_url":"https://api.github.com/repos/cadets/freebsd/issues/103","number":103,"state":"open","locked":false,"title":"VM prototype","user":{"login":"dstolfa","id":6237979,"node_id":"MDQ6VXNlcjYyMzc5Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6237979?v=4","gravatar_id":"","url":"https://api.github.com/users/dstolfa","html_url":"https://github.com/dstolfa","followers_url":"https://api.github.com/users/dstolfa/followers","following_url":"https://api.github.com/users/dstolfa/following{/other_user}","gists_url":"https://api.github.com/users/dstolfa/gists{/gist_id}","starred_url":"https://api.github.com/users/dstolfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstolfa/subscriptions","organizations_url":"https://api.github.com/users/dstolfa/orgs","repos_url":"https://api.github.com/users/dstolfa/repos","events_url":"https://api.github.com/users/dstolfa/events{/privacy}","received_events_url":"https://api.github.com/users/dstolfa/received_events","type":"User","site_admin":false},"body":"This pull request serves as a means of diffing the current CADETS branch and my changes that make the virtualisation parts work on a homogeneous system.\r\n\r\n**DO NOT MERGE**.","created_at":"2018-09-11T11:28:46Z","updated_at":"2018-09-12T03:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50760b50ff75c7389b2a010571f0d720ca7e626b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cadets/freebsd/pulls/103/commits","review_comments_url":"https://api.github.com/repos/cadets/freebsd/pulls/103/comments","review_comment_url":"https://api.github.com/repos/cadets/freebsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cadets/freebsd/issues/103/comments","statuses_url":"https://api.github.com/repos/cadets/freebsd/statuses/aaa404d1b568c76ac04508e144fd3882c263c58c","head":{"label":"cadets:cadets-e4-plus-vm","ref":"cadets-e4-plus-vm","sha":"aaa404d1b568c76ac04508e144fd3882c263c58c","user":{"login":"cadets","id":12035088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDM1MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/12035088?v=4","gravatar_id":"","url":"https://api.github.com/users/cadets","html_url":"https://github.com/cadets","followers_url":"https://api.github.com/users/cadets/followers","following_url":"https://api.github.com/users/cadets/following{/other_user}","gists_url":"https://api.github.com/users/cadets/gists{/gist_id}","starred_url":"https://api.github.com/users/cadets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadets/subscriptions","organizations_url":"https://api.github.com/users/cadets/orgs","repos_url":"https://api.github.com/users/cadets/repos","events_url":"https://api.github.com/users/cadets/events{/privacy}","received_events_url":"https://api.github.com/users/cadets/received_events","type":"Organization","site_admin":false},"repo":{"id":39952553,"node_id":"MDEwOlJlcG9zaXRvcnkzOTk1MjU1Mw==","name":"freebsd","full_name":"cadets/freebsd","owner":{"login":"cadets","id":12035088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDM1MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/12035088?v=4","gravatar_id":"","url":"https://api.github.com/users/cadets","html_url":"https://github.com/cadets","followers_url":"https://api.github.com/users/cadets/followers","following_url":"https://api.github.com/users/cadets/following{/other_user}","gists_url":"https://api.github.com/users/cadets/gists{/gist_id}","starred_url":"https://api.github.com/users/cadets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadets/subscriptions","organizations_url":"https://api.github.com/users/cadets/orgs","repos_url":"https://api.github.com/users/cadets/repos","events_url":"https://api.github.com/users/cadets/events{/privacy}","received_events_url":"https://api.github.com/users/cadets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cadets/freebsd","description":" FreeBSD src tree http://www.FreeBSD.org/","fork":false,"url":"https://api.github.com/repos/cadets/freebsd","forks_url":"https://api.github.com/repos/cadets/freebsd/forks","keys_url":"https://api.github.com/repos/cadets/freebsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cadets/freebsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cadets/freebsd/teams","hooks_url":"https://api.github.com/repos/cadets/freebsd/hooks","issue_events_url":"https://api.github.com/repos/cadets/freebsd/issues/events{/number}","events_url":"https://api.github.com/repos/cadets/freebsd/events","assignees_url":"https://api.github.com/repos/cadets/freebsd/assignees{/user}","branches_url":"https://api.github.com/repos/cadets/freebsd/branches{/branch}","tags_url":"https://api.github.com/repos/cadets/freebsd/tags","blobs_url":"https://api.github.com/repos/cadets/freebsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cadets/freebsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cadets/freebsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cadets/freebsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cadets/freebsd/statuses/{sha}","languages_url":"https://api.github.com/repos/cadets/freebsd/languages","stargazers_url":"https://api.github.com/repos/cadets/freebsd/stargazers","contributors_url":"https://api.github.com/repos/cadets/freebsd/contributors","subscribers_url":"https://api.github.com/repos/cadets/freebsd/subscribers","subscription_url":"https://api.github.com/repos/cadets/freebsd/subscription","commits_url":"https://api.github.com/repos/cadets/freebsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cadets/freebsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cadets/freebsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cadets/freebsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cadets/freebsd/contents/{+path}","compare_url":"https://api.github.com/repos/cadets/freebsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cadets/freebsd/merges","archive_url":"https://api.github.com/repos/cadets/freebsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cadets/freebsd/downloads","issues_url":"https://api.github.com/repos/cadets/freebsd/issues{/number}","pulls_url":"https://api.github.com/repos/cadets/freebsd/pulls{/number}","milestones_url":"https://api.github.com/repos/cadets/freebsd/milestones{/number}","notifications_url":"https://api.github.com/repos/cadets/freebsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cadets/freebsd/labels{/name}","releases_url":"https://api.github.com/repos/cadets/freebsd/releases{/id}","deployments_url":"https://api.github.com/repos/cadets/freebsd/deployments","created_at":"2015-07-30T13:39:36Z","updated_at":"2018-08-29T18:28:37Z","pushed_at":"2018-09-11T11:28:47Z","git_url":"git://github.com/cadets/freebsd.git","ssh_url":"git@github.com:cadets/freebsd.git","clone_url":"https://github.com/cadets/freebsd.git","svn_url":"https://github.com/cadets/freebsd","homepage":null,"size":1738503,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":61,"watchers":6,"default_branch":"cadets"}},"base":{"label":"cadets:cadets","ref":"cadets","sha":"080b110520c862bf1a15a9f952079f6500d229ca","user":{"login":"cadets","id":12035088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDM1MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/12035088?v=4","gravatar_id":"","url":"https://api.github.com/users/cadets","html_url":"https://github.com/cadets","followers_url":"https://api.github.com/users/cadets/followers","following_url":"https://api.github.com/users/cadets/following{/other_user}","gists_url":"https://api.github.com/users/cadets/gists{/gist_id}","starred_url":"https://api.github.com/users/cadets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadets/subscriptions","organizations_url":"https://api.github.com/users/cadets/orgs","repos_url":"https://api.github.com/users/cadets/repos","events_url":"https://api.github.com/users/cadets/events{/privacy}","received_events_url":"https://api.github.com/users/cadets/received_events","type":"Organization","site_admin":false},"repo":{"id":39952553,"node_id":"MDEwOlJlcG9zaXRvcnkzOTk1MjU1Mw==","name":"freebsd","full_name":"cadets/freebsd","owner":{"login":"cadets","id":12035088,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDM1MDg4","avatar_url":"https://avatars3.githubusercontent.com/u/12035088?v=4","gravatar_id":"","url":"https://api.github.com/users/cadets","html_url":"https://github.com/cadets","followers_url":"https://api.github.com/users/cadets/followers","following_url":"https://api.github.com/users/cadets/following{/other_user}","gists_url":"https://api.github.com/users/cadets/gists{/gist_id}","starred_url":"https://api.github.com/users/cadets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cadets/subscriptions","organizations_url":"https://api.github.com/users/cadets/orgs","repos_url":"https://api.github.com/users/cadets/repos","events_url":"https://api.github.com/users/cadets/events{/privacy}","received_events_url":"https://api.github.com/users/cadets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cadets/freebsd","description":" FreeBSD src tree http://www.FreeBSD.org/","fork":false,"url":"https://api.github.com/repos/cadets/freebsd","forks_url":"https://api.github.com/repos/cadets/freebsd/forks","keys_url":"https://api.github.com/repos/cadets/freebsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cadets/freebsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cadets/freebsd/teams","hooks_url":"https://api.github.com/repos/cadets/freebsd/hooks","issue_events_url":"https://api.github.com/repos/cadets/freebsd/issues/events{/number}","events_url":"https://api.github.com/repos/cadets/freebsd/events","assignees_url":"https://api.github.com/repos/cadets/freebsd/assignees{/user}","branches_url":"https://api.github.com/repos/cadets/freebsd/branches{/branch}","tags_url":"https://api.github.com/repos/cadets/freebsd/tags","blobs_url":"https://api.github.com/repos/cadets/freebsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cadets/freebsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cadets/freebsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/cadets/freebsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cadets/freebsd/statuses/{sha}","languages_url":"https://api.github.com/repos/cadets/freebsd/languages","stargazers_url":"https://api.github.com/repos/cadets/freebsd/stargazers","contributors_url":"https://api.github.com/repos/cadets/freebsd/contributors","subscribers_url":"https://api.github.com/repos/cadets/freebsd/subscribers","subscription_url":"https://api.github.com/repos/cadets/freebsd/subscription","commits_url":"https://api.github.com/repos/cadets/freebsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/cadets/freebsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/cadets/freebsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/cadets/freebsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/cadets/freebsd/contents/{+path}","compare_url":"https://api.github.com/repos/cadets/freebsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cadets/freebsd/merges","archive_url":"https://api.github.com/repos/cadets/freebsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cadets/freebsd/downloads","issues_url":"https://api.github.com/repos/cadets/freebsd/issues{/number}","pulls_url":"https://api.github.com/repos/cadets/freebsd/pulls{/number}","milestones_url":"https://api.github.com/repos/cadets/freebsd/milestones{/number}","notifications_url":"https://api.github.com/repos/cadets/freebsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cadets/freebsd/labels{/name}","releases_url":"https://api.github.com/repos/cadets/freebsd/releases{/id}","deployments_url":"https://api.github.com/repos/cadets/freebsd/deployments","created_at":"2015-07-30T13:39:36Z","updated_at":"2018-08-29T18:28:37Z","pushed_at":"2018-09-11T11:28:47Z","git_url":"git://github.com/cadets/freebsd.git","ssh_url":"git@github.com:cadets/freebsd.git","clone_url":"https://github.com/cadets/freebsd.git","svn_url":"https://github.com/cadets/freebsd","homepage":null,"size":1738503,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":61,"watchers":6,"default_branch":"cadets"}},"_links":{"self":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/103"},"html":{"href":"https://github.com/cadets/freebsd/pull/103"},"issue":{"href":"https://api.github.com/repos/cadets/freebsd/issues/103"},"comments":{"href":"https://api.github.com/repos/cadets/freebsd/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cadets/freebsd/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/cadets/freebsd/statuses/aaa404d1b568c76ac04508e144fd3882c263c58c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwatson"}}