{"action":"created","comment":{"url":"https://api.github.com/repos/dfki-ric/phobos/pulls/comments/241501023","pull_request_review_id":184790413,"id":241501023,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTUwMTAyMw==","diff_hunk":"@@ -86,8 +86,8 @@ def safelyName(obj, name, phobostype=None):\n     # use custom property if the object.name can not be set properly\n     if objectname != name:\n         obj[phobostype + '/name'] = name\n-    elif phobostype + '/name' in obj:\n-        del obj[phobostype + '/name']\n+    #elif phobostype + '/name' in obj:","path":"phobos/utils/naming.py","position":6,"original_position":6,"commit_id":"9bd39d02d6b1d3a40664278d038706b75d636464","original_commit_id":"9bd39d02d6b1d3a40664278d038706b75d636464","user":{"login":"Amudtogal","id":18306764,"node_id":"MDQ6VXNlcjE4MzA2NzY0","avatar_url":"https://avatars1.githubusercontent.com/u/18306764?v=4","gravatar_id":"","url":"https://api.github.com/users/Amudtogal","html_url":"https://github.com/Amudtogal","followers_url":"https://api.github.com/users/Amudtogal/followers","following_url":"https://api.github.com/users/Amudtogal/following{/other_user}","gists_url":"https://api.github.com/users/Amudtogal/gists{/gist_id}","starred_url":"https://api.github.com/users/Amudtogal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amudtogal/subscriptions","organizations_url":"https://api.github.com/users/Amudtogal/orgs","repos_url":"https://api.github.com/users/Amudtogal/repos","events_url":"https://api.github.com/users/Amudtogal/events{/privacy}","received_events_url":"https://api.github.com/users/Amudtogal/received_events","type":"User","site_admin":false},"body":"These two lines are an essential element of the current Phobos version.\r\n\r\nBasically every Phobostype is labelled here.\r\nWe can't comment out these lines.\r\n\r\nI would rather suggest adjusting the DROCK-addon, as we can not provide backwards compatibility from within Phobos (too much happened since January).\r\nIn addition, the submodel functionality of Phobos is not the same as submodels in the DROCK-plugin.","created_at":"2018-12-13T17:53:40Z","updated_at":"2018-12-13T17:53:40Z","html_url":"https://github.com/dfki-ric/phobos/pull/171#discussion_r241501023","pull_request_url":"https://api.github.com/repos/dfki-ric/phobos/pulls/171","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/comments/241501023"},"html":{"href":"https://github.com/dfki-ric/phobos/pull/171#discussion_r241501023"},"pull_request":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/dfki-ric/phobos/pulls/171","id":237251538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjUxNTM4","html_url":"https://github.com/dfki-ric/phobos/pull/171","diff_url":"https://github.com/dfki-ric/phobos/pull/171.diff","patch_url":"https://github.com/dfki-ric/phobos/pull/171.patch","issue_url":"https://api.github.com/repos/dfki-ric/phobos/issues/171","number":171,"state":"closed","locked":false,"title":"Adaptation of submodel handling","user":{"login":"malter","id":7878454,"node_id":"MDQ6VXNlcjc4Nzg0NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7878454?v=4","gravatar_id":"","url":"https://api.github.com/users/malter","html_url":"https://github.com/malter","followers_url":"https://api.github.com/users/malter/followers","following_url":"https://api.github.com/users/malter/following{/other_user}","gists_url":"https://api.github.com/users/malter/gists{/gist_id}","starred_url":"https://api.github.com/users/malter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malter/subscriptions","organizations_url":"https://api.github.com/users/malter/orgs","repos_url":"https://api.github.com/users/malter/repos","events_url":"https://api.github.com/users/malter/events{/privacy}","received_events_url":"https://api.github.com/users/malter/received_events","type":"User","site_admin":false},"body":"<!--- Describe your changes in detail -->\n\n<!--- This project only accepts pull requests related to open issues -->\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\n<!--- Please link to the issue here: -->\n\n<!--- Why is this change required? What problem does it solve? -->\n\n<!--- Please describe in detail how you tested your changes. -->\n<!--- Include details of your testing environment, and the tests you ran to -->\n<!--- see how your change affects other areas of the code, etc. -->\n\n\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\n- [x] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\n- [ ] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n- [ ] I have read the **CONTRIBUTING** document.","created_at":"2018-12-10T09:34:32Z","updated_at":"2018-12-13T17:53:40Z","closed_at":"2018-12-10T14:41:19Z","merged_at":null,"merge_commit_sha":"29424546c0396dd52bf32ccfbec5535992c1c666","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dfki-ric/phobos/pulls/171/commits","review_comments_url":"https://api.github.com/repos/dfki-ric/phobos/pulls/171/comments","review_comment_url":"https://api.github.com/repos/dfki-ric/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dfki-ric/phobos/issues/171/comments","statuses_url":"https://api.github.com/repos/dfki-ric/phobos/statuses/9bd39d02d6b1d3a40664278d038706b75d636464","head":{"label":"malter:master","ref":"master","sha":"9bd39d02d6b1d3a40664278d038706b75d636464","user":{"login":"malter","id":7878454,"node_id":"MDQ6VXNlcjc4Nzg0NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7878454?v=4","gravatar_id":"","url":"https://api.github.com/users/malter","html_url":"https://github.com/malter","followers_url":"https://api.github.com/users/malter/followers","following_url":"https://api.github.com/users/malter/following{/other_user}","gists_url":"https://api.github.com/users/malter/gists{/gist_id}","starred_url":"https://api.github.com/users/malter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malter/subscriptions","organizations_url":"https://api.github.com/users/malter/orgs","repos_url":"https://api.github.com/users/malter/repos","events_url":"https://api.github.com/users/malter/events{/privacy}","received_events_url":"https://api.github.com/users/malter/received_events","type":"User","site_admin":false},"repo":{"id":161150597,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNTA1OTc=","name":"phobos","full_name":"malter/phobos","private":false,"owner":{"login":"malter","id":7878454,"node_id":"MDQ6VXNlcjc4Nzg0NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7878454?v=4","gravatar_id":"","url":"https://api.github.com/users/malter","html_url":"https://github.com/malter","followers_url":"https://api.github.com/users/malter/followers","following_url":"https://api.github.com/users/malter/following{/other_user}","gists_url":"https://api.github.com/users/malter/gists{/gist_id}","starred_url":"https://api.github.com/users/malter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malter/subscriptions","organizations_url":"https://api.github.com/users/malter/orgs","repos_url":"https://api.github.com/users/malter/repos","events_url":"https://api.github.com/users/malter/events{/privacy}","received_events_url":"https://api.github.com/users/malter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/malter/phobos","description":"An add-on for Blender allowing to create URDF and SMURF robot models in a WYSIWYG environment.","fork":true,"url":"https://api.github.com/repos/malter/phobos","forks_url":"https://api.github.com/repos/malter/phobos/forks","keys_url":"https://api.github.com/repos/malter/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/malter/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/malter/phobos/teams","hooks_url":"https://api.github.com/repos/malter/phobos/hooks","issue_events_url":"https://api.github.com/repos/malter/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/malter/phobos/events","assignees_url":"https://api.github.com/repos/malter/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/malter/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/malter/phobos/tags","blobs_url":"https://api.github.com/repos/malter/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/malter/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/malter/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/malter/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/malter/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/malter/phobos/languages","stargazers_url":"https://api.github.com/repos/malter/phobos/stargazers","contributors_url":"https://api.github.com/repos/malter/phobos/contributors","subscribers_url":"https://api.github.com/repos/malter/phobos/subscribers","subscription_url":"https://api.github.com/repos/malter/phobos/subscription","commits_url":"https://api.github.com/repos/malter/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/malter/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/malter/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/malter/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/malter/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/malter/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/malter/phobos/merges","archive_url":"https://api.github.com/repos/malter/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/malter/phobos/downloads","issues_url":"https://api.github.com/repos/malter/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/malter/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/malter/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/malter/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/malter/phobos/labels{/name}","releases_url":"https://api.github.com/repos/malter/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/malter/phobos/deployments","created_at":"2018-12-10T09:33:19Z","updated_at":"2018-12-10T09:33:42Z","pushed_at":"2018-12-10T09:33:41Z","git_url":"git://github.com/malter/phobos.git","ssh_url":"git@github.com:malter/phobos.git","clone_url":"https://github.com/malter/phobos.git","svn_url":"https://github.com/malter/phobos","homepage":"","size":12147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dfki-ric:master","ref":"master","sha":"db539e61ee92646c5555c292581f8b016b7e7cd8","user":{"login":"dfki-ric","id":37366708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzY2NzA4","avatar_url":"https://avatars2.githubusercontent.com/u/37366708?v=4","gravatar_id":"","url":"https://api.github.com/users/dfki-ric","html_url":"https://github.com/dfki-ric","followers_url":"https://api.github.com/users/dfki-ric/followers","following_url":"https://api.github.com/users/dfki-ric/following{/other_user}","gists_url":"https://api.github.com/users/dfki-ric/gists{/gist_id}","starred_url":"https://api.github.com/users/dfki-ric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfki-ric/subscriptions","organizations_url":"https://api.github.com/users/dfki-ric/orgs","repos_url":"https://api.github.com/users/dfki-ric/repos","events_url":"https://api.github.com/users/dfki-ric/events{/privacy}","received_events_url":"https://api.github.com/users/dfki-ric/received_events","type":"Organization","site_admin":false},"repo":{"id":22949566,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk0OTU2Ng==","name":"phobos","full_name":"dfki-ric/phobos","private":false,"owner":{"login":"dfki-ric","id":37366708,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzY2NzA4","avatar_url":"https://avatars2.githubusercontent.com/u/37366708?v=4","gravatar_id":"","url":"https://api.github.com/users/dfki-ric","html_url":"https://github.com/dfki-ric","followers_url":"https://api.github.com/users/dfki-ric/followers","following_url":"https://api.github.com/users/dfki-ric/following{/other_user}","gists_url":"https://api.github.com/users/dfki-ric/gists{/gist_id}","starred_url":"https://api.github.com/users/dfki-ric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfki-ric/subscriptions","organizations_url":"https://api.github.com/users/dfki-ric/orgs","repos_url":"https://api.github.com/users/dfki-ric/repos","events_url":"https://api.github.com/users/dfki-ric/events{/privacy}","received_events_url":"https://api.github.com/users/dfki-ric/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dfki-ric/phobos","description":"An add-on for Blender allowing to create URDF and SMURF robot models in a WYSIWYG environment.","fork":false,"url":"https://api.github.com/repos/dfki-ric/phobos","forks_url":"https://api.github.com/repos/dfki-ric/phobos/forks","keys_url":"https://api.github.com/repos/dfki-ric/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfki-ric/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfki-ric/phobos/teams","hooks_url":"https://api.github.com/repos/dfki-ric/phobos/hooks","issue_events_url":"https://api.github.com/repos/dfki-ric/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dfki-ric/phobos/events","assignees_url":"https://api.github.com/repos/dfki-ric/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dfki-ric/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dfki-ric/phobos/tags","blobs_url":"https://api.github.com/repos/dfki-ric/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfki-ric/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfki-ric/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfki-ric/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfki-ric/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dfki-ric/phobos/languages","stargazers_url":"https://api.github.com/repos/dfki-ric/phobos/stargazers","contributors_url":"https://api.github.com/repos/dfki-ric/phobos/contributors","subscribers_url":"https://api.github.com/repos/dfki-ric/phobos/subscribers","subscription_url":"https://api.github.com/repos/dfki-ric/phobos/subscription","commits_url":"https://api.github.com/repos/dfki-ric/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfki-ric/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfki-ric/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfki-ric/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfki-ric/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dfki-ric/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfki-ric/phobos/merges","archive_url":"https://api.github.com/repos/dfki-ric/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfki-ric/phobos/downloads","issues_url":"https://api.github.com/repos/dfki-ric/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dfki-ric/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dfki-ric/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dfki-ric/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfki-ric/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dfki-ric/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dfki-ric/phobos/deployments","created_at":"2014-08-14T10:08:49Z","updated_at":"2018-11-29T03:22:48Z","pushed_at":"2018-12-10T09:34:32Z","git_url":"git://github.com/dfki-ric/phobos.git","ssh_url":"git@github.com:dfki-ric/phobos.git","clone_url":"https://github.com/dfki-ric/phobos.git","svn_url":"https://github.com/dfki-ric/phobos","homepage":"","size":12146,"stargazers_count":98,"watchers_count":98,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":34,"open_issues":16,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/171"},"html":{"href":"https://github.com/dfki-ric/phobos/pull/171"},"issue":{"href":"https://api.github.com/repos/dfki-ric/phobos/issues/171"},"comments":{"href":"https://api.github.com/repos/dfki-ric/phobos/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dfki-ric/phobos/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/dfki-ric/phobos/statuses/9bd39d02d6b1d3a40664278d038706b75d636464"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Amudtogal"}}