{"action":"created","comment":{"url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/comments/172157232","pull_request_review_id":101125714,"id":172157232,"diff_hunk":"@@ -0,0 +1,102 @@\n+<?php\n+\n+\n+namespace BreiteSeite\\LidlDigital\\Aviation\\Entity;\n+\n+use BreiteSeite\\LidlDigital\\Aviation\\Entity\\Airport\\AirTrafficControlTower\\AirControl\\LandingClearance;\n+use BreiteSeite\\LidlDigital\\Aviation\\Entity\\Airport\\AirTrafficControlTower\\GroundControl\\RampService\\TowRequest;\n+use BreiteSeite\\LidlDigital\\Aviation\\Entity\\Airport\\Gate;\n+use BreiteSeite\\LidlDigital\\Aviation\\Entity\\Airport\\Location;\n+use Ramsey\\Uuid\\Uuid;\n+\n+class Aircraft\n+{\n+    /** @var Uuid */\n+    private $id;\n+\n+    /** @var string */\n+    private $manufacturer;\n+\n+    /** @var string */\n+    private $model;\n+\n+    /** @var Passenger[]  */\n+    private $passengers = [];\n+\n+    /** @var Location */\n+    private $currentLocation;\n+\n+    /**\n+     * Aircraft constructor.\n+     * @param string $manufacturer\n+     * @param string $model\n+     */\n+    public function __construct(string $manufacturer, string $model)\n+    {\n+        $this->id = Uuid::uuid4();\n+        $this->manufacturer = $manufacturer;\n+        $this->model = $model;\n+    }\n+\n+    /**\n+     * @param Passenger[] $passengers\n+     */\n+    public function enplanePassengers(array $passengers)","path":"src/Aviation/Entity/Aircraft.php","position":44,"original_position":44,"commit_id":"c8a6fff935259adbb858a3945085c63ef9b842fd","original_commit_id":"c8a6fff935259adbb858a3945085c63ef9b842fd","user":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"body":"Das Flugzeug enthält ja Reisegäste. Aus Sicht des Flugzeugs sollten die also ja irgendwie an Board kommen. Perspektivisch muss ein Flugzeug dafür ja auch gewisse Dinge tun oder prüfen (Tür öffnen, Flugzeug muss gereinigt sein, Reinigungscrew muss absent sein, Pilot muss Flugzeug zum Boarding freigeben, Crew muss an board sein ...).\r\n\r\nIch denke, es macht schon auf beiden Seiten Sinn. Ein Passagier betritt ein Flugzeug und ein Flugzeug empfängt Passagiere. Wenn ich das so erkläre, wäre wohl ein Methoden-Name `receivePassengers()` o.ä. etwas klarer.","created_at":"2018-03-05T11:25:46Z","updated_at":"2018-03-05T11:25:47Z","html_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1#discussion_r172157232","pull_request_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/comments/172157232"},"html":{"href":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1#discussion_r172157232"},"pull_request":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1"}},"in_reply_to_id":172134520},"pull_request":{"url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1","id":172758072,"html_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1","diff_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1.diff","patch_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1.patch","issue_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/1","number":1,"state":"open","locked":false,"title":"Feature/initial implementation","user":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"body":"TODOs:\r\n\r\n* Use own exception classes","created_at":"2018-03-05T02:00:04Z","updated_at":"2018-03-05T11:25:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45553c3e1a2056c0e25a20601e283469091a723c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/1/comments","statuses_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/statuses/c8a6fff935259adbb858a3945085c63ef9b842fd","head":{"label":"BreiteSeite:feature/initial-implementation","ref":"feature/initial-implementation","sha":"c8a6fff935259adbb858a3945085c63ef9b842fd","user":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"repo":{"id":123850186,"name":"lidl-digital-codingchallenge-aviation","full_name":"BreiteSeite/lidl-digital-codingchallenge-aviation","owner":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation","description":"Repo for coding-challenge for PHP position at LIDL Digital","fork":false,"url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation","forks_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/forks","keys_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/teams","hooks_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/hooks","issue_events_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/events{/number}","events_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/events","assignees_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/assignees{/user}","branches_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/branches{/branch}","tags_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/tags","blobs_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/statuses/{sha}","languages_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/languages","stargazers_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/stargazers","contributors_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/contributors","subscribers_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/subscribers","subscription_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/subscription","commits_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/contents/{+path}","compare_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/merges","archive_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/downloads","issues_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues{/number}","pulls_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls{/number}","milestones_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/milestones{/number}","notifications_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/labels{/name}","releases_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/releases{/id}","deployments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/deployments","created_at":"2018-03-05T01:57:13Z","updated_at":"2018-03-05T01:57:13Z","pushed_at":"2018-03-05T02:03:57Z","git_url":"git://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation.git","ssh_url":"git@github.com:BreiteSeite/lidl-digital-codingchallenge-aviation.git","clone_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation.git","svn_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"BreiteSeite:master","ref":"master","sha":"3ebb3d3a977202469c7af4fda0eb3e67b96d6995","user":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"repo":{"id":123850186,"name":"lidl-digital-codingchallenge-aviation","full_name":"BreiteSeite/lidl-digital-codingchallenge-aviation","owner":{"login":"BreiteSeite","id":2171105,"avatar_url":"https://avatars3.githubusercontent.com/u/2171105?v=4","gravatar_id":"","url":"https://api.github.com/users/BreiteSeite","html_url":"https://github.com/BreiteSeite","followers_url":"https://api.github.com/users/BreiteSeite/followers","following_url":"https://api.github.com/users/BreiteSeite/following{/other_user}","gists_url":"https://api.github.com/users/BreiteSeite/gists{/gist_id}","starred_url":"https://api.github.com/users/BreiteSeite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BreiteSeite/subscriptions","organizations_url":"https://api.github.com/users/BreiteSeite/orgs","repos_url":"https://api.github.com/users/BreiteSeite/repos","events_url":"https://api.github.com/users/BreiteSeite/events{/privacy}","received_events_url":"https://api.github.com/users/BreiteSeite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation","description":"Repo for coding-challenge for PHP position at LIDL Digital","fork":false,"url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation","forks_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/forks","keys_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/teams","hooks_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/hooks","issue_events_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/events{/number}","events_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/events","assignees_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/assignees{/user}","branches_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/branches{/branch}","tags_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/tags","blobs_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/statuses/{sha}","languages_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/languages","stargazers_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/stargazers","contributors_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/contributors","subscribers_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/subscribers","subscription_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/subscription","commits_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/contents/{+path}","compare_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/merges","archive_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/downloads","issues_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues{/number}","pulls_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls{/number}","milestones_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/milestones{/number}","notifications_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/labels{/name}","releases_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/releases{/id}","deployments_url":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/deployments","created_at":"2018-03-05T01:57:13Z","updated_at":"2018-03-05T01:57:13Z","pushed_at":"2018-03-05T02:03:57Z","git_url":"git://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation.git","ssh_url":"git@github.com:BreiteSeite/lidl-digital-codingchallenge-aviation.git","clone_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation.git","svn_url":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1"},"html":{"href":"https://github.com/BreiteSeite/lidl-digital-codingchallenge-aviation/pull/1"},"issue":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/1"},"comments":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BreiteSeite/lidl-digital-codingchallenge-aviation/statuses/c8a6fff935259adbb858a3945085c63ef9b842fd"}},"author_association":"OWNER"}}
{"actor":{"display_login":"BreiteSeite"}}