{"action":"created","comment":{"url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/comments/244326917","pull_request_review_id":188293856,"id":244326917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDMyNjkxNw==","diff_hunk":"@@ -118,3 +124,12 @@ def generated_pipeline_vars\n     end\n   end\n end\n+\n+# rubocop:disable all\n+class ::Hash","path":"lib/coa_env_bootstrapper/runner.rb","position":56,"original_position":56,"commit_id":"a1990e3f618ae16f88c6c53ef0f8bfac64d90e20","original_commit_id":"a1990e3f618ae16f88c6c53ef0f8bfac64d90e20","user":{"login":"o-orand","id":976115,"node_id":"MDQ6VXNlcjk3NjExNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/976115?v=4","gravatar_id":"","url":"https://api.github.com/users/o-orand","html_url":"https://github.com/o-orand","followers_url":"https://api.github.com/users/o-orand/followers","following_url":"https://api.github.com/users/o-orand/following{/other_user}","gists_url":"https://api.github.com/users/o-orand/gists{/gist_id}","starred_url":"https://api.github.com/users/o-orand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o-orand/subscriptions","organizations_url":"https://api.github.com/users/o-orand/orgs","repos_url":"https://api.github.com/users/o-orand/repos","events_url":"https://api.github.com/users/o-orand/events{/privacy}","received_events_url":"https://api.github.com/users/o-orand/received_events","type":"User","site_admin":false},"body":"this function is not obvious for me, is it  different from deep_merge in `lib/active_support_copy_deep_merge.rb` ? If yes, could you please rename it to avoid confusion ?","created_at":"2018-12-28T13:58:26Z","updated_at":"2018-12-28T13:59:25Z","html_url":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221#discussion_r244326917","pull_request_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/comments/244326917"},"html":{"href":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221#discussion_r244326917"},"pull_request":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221","id":241167959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTY3OTU5","html_url":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221","diff_url":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221.diff","patch_url":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221.patch","issue_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/221","number":221,"state":"open","locked":false,"title":"220 github-release resource type","user":{"login":"lucaspinto","id":157468,"node_id":"MDQ6VXNlcjE1NzQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/157468?v=4","gravatar_id":"","url":"https://api.github.com/users/lucaspinto","html_url":"https://github.com/lucaspinto","followers_url":"https://api.github.com/users/lucaspinto/followers","following_url":"https://api.github.com/users/lucaspinto/following{/other_user}","gists_url":"https://api.github.com/users/lucaspinto/gists{/gist_id}","starred_url":"https://api.github.com/users/lucaspinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucaspinto/subscriptions","organizations_url":"https://api.github.com/users/lucaspinto/orgs","repos_url":"https://api.github.com/users/lucaspinto/repos","events_url":"https://api.github.com/users/lucaspinto/events{/privacy}","received_events_url":"https://api.github.com/users/lucaspinto/received_events","type":"User","site_admin":false},"body":"Fixes #219, #220 .\r\n\r\nChanges proposed in this pull-request:\r\n- allow user to pass their github token in order the extend the possibility of using the github-release resource without hitting the API requests limit\r\n- fix issue (i.e. make it more consistent) with the way we're using the bosh-io-releases resource.\r\n\r\nThis PR is still a WIP, since I am still currently testing the second part.","created_at":"2018-12-27T14:51:06Z","updated_at":"2018-12-28T13:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c48070f24c79396a29763b2ed0c72bebba57e48e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221/commits","review_comments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221/comments","review_comment_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/221/comments","statuses_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/statuses/a1990e3f618ae16f88c6c53ef0f8bfac64d90e20","head":{"label":"orange-cloudfoundry:220_github_release_resource_type","ref":"220_github_release_resource_type","sha":"a1990e3f618ae16f88c6c53ef0f8bfac64d90e20","user":{"login":"orange-cloudfoundry","id":6417290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTcyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6417290?v=4","gravatar_id":"","url":"https://api.github.com/users/orange-cloudfoundry","html_url":"https://github.com/orange-cloudfoundry","followers_url":"https://api.github.com/users/orange-cloudfoundry/followers","following_url":"https://api.github.com/users/orange-cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/orange-cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/orange-cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orange-cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/orange-cloudfoundry/orgs","repos_url":"https://api.github.com/users/orange-cloudfoundry/repos","events_url":"https://api.github.com/users/orange-cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/orange-cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":99213306,"node_id":"MDEwOlJlcG9zaXRvcnk5OTIxMzMwNg==","name":"cf-ops-automation","full_name":"orange-cloudfoundry/cf-ops-automation","private":false,"owner":{"login":"orange-cloudfoundry","id":6417290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTcyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6417290?v=4","gravatar_id":"","url":"https://api.github.com/users/orange-cloudfoundry","html_url":"https://github.com/orange-cloudfoundry","followers_url":"https://api.github.com/users/orange-cloudfoundry/followers","following_url":"https://api.github.com/users/orange-cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/orange-cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/orange-cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orange-cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/orange-cloudfoundry/orgs","repos_url":"https://api.github.com/users/orange-cloudfoundry/repos","events_url":"https://api.github.com/users/orange-cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/orange-cloudfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orange-cloudfoundry/cf-ops-automation","description":"a collaboration framework for operating cloudfoundry and services at scale","fork":false,"url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation","forks_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/forks","keys_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/teams","hooks_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/hooks","issue_events_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/events{/number}","events_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/events","assignees_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/assignees{/user}","branches_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/branches{/branch}","tags_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/tags","blobs_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/languages","stargazers_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/stargazers","contributors_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/contributors","subscribers_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/subscribers","subscription_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/subscription","commits_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/contents/{+path}","compare_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/merges","archive_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/downloads","issues_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues{/number}","pulls_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/labels{/name}","releases_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/releases{/id}","deployments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/deployments","created_at":"2017-08-03T09:06:57Z","updated_at":"2018-12-21T17:27:22Z","pushed_at":"2018-12-28T10:48:38Z","git_url":"git://github.com/orange-cloudfoundry/cf-ops-automation.git","ssh_url":"git@github.com:orange-cloudfoundry/cf-ops-automation.git","clone_url":"https://github.com/orange-cloudfoundry/cf-ops-automation.git","svn_url":"https://github.com/orange-cloudfoundry/cf-ops-automation","homepage":"","size":1428,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":80,"watchers":13,"default_branch":"develop"}},"base":{"label":"orange-cloudfoundry:develop","ref":"develop","sha":"2f17e01861ce7e65261e50f48d87baa500933670","user":{"login":"orange-cloudfoundry","id":6417290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTcyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6417290?v=4","gravatar_id":"","url":"https://api.github.com/users/orange-cloudfoundry","html_url":"https://github.com/orange-cloudfoundry","followers_url":"https://api.github.com/users/orange-cloudfoundry/followers","following_url":"https://api.github.com/users/orange-cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/orange-cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/orange-cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orange-cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/orange-cloudfoundry/orgs","repos_url":"https://api.github.com/users/orange-cloudfoundry/repos","events_url":"https://api.github.com/users/orange-cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/orange-cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":99213306,"node_id":"MDEwOlJlcG9zaXRvcnk5OTIxMzMwNg==","name":"cf-ops-automation","full_name":"orange-cloudfoundry/cf-ops-automation","private":false,"owner":{"login":"orange-cloudfoundry","id":6417290,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTcyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6417290?v=4","gravatar_id":"","url":"https://api.github.com/users/orange-cloudfoundry","html_url":"https://github.com/orange-cloudfoundry","followers_url":"https://api.github.com/users/orange-cloudfoundry/followers","following_url":"https://api.github.com/users/orange-cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/orange-cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/orange-cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orange-cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/orange-cloudfoundry/orgs","repos_url":"https://api.github.com/users/orange-cloudfoundry/repos","events_url":"https://api.github.com/users/orange-cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/orange-cloudfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orange-cloudfoundry/cf-ops-automation","description":"a collaboration framework for operating cloudfoundry and services at scale","fork":false,"url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation","forks_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/forks","keys_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/teams","hooks_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/hooks","issue_events_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/events{/number}","events_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/events","assignees_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/assignees{/user}","branches_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/branches{/branch}","tags_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/tags","blobs_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/statuses/{sha}","languages_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/languages","stargazers_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/stargazers","contributors_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/contributors","subscribers_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/subscribers","subscription_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/subscription","commits_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/contents/{+path}","compare_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/merges","archive_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/downloads","issues_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues{/number}","pulls_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls{/number}","milestones_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/milestones{/number}","notifications_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/labels{/name}","releases_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/releases{/id}","deployments_url":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/deployments","created_at":"2017-08-03T09:06:57Z","updated_at":"2018-12-21T17:27:22Z","pushed_at":"2018-12-28T10:48:38Z","git_url":"git://github.com/orange-cloudfoundry/cf-ops-automation.git","ssh_url":"git@github.com:orange-cloudfoundry/cf-ops-automation.git","clone_url":"https://github.com/orange-cloudfoundry/cf-ops-automation.git","svn_url":"https://github.com/orange-cloudfoundry/cf-ops-automation","homepage":"","size":1428,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":80,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221"},"html":{"href":"https://github.com/orange-cloudfoundry/cf-ops-automation/pull/221"},"issue":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/221"},"comments":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/orange-cloudfoundry/cf-ops-automation/statuses/a1990e3f618ae16f88c6c53ef0f8bfac64d90e20"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"o-orand"}}