{"action":"created","issue":{"url":"https://api.github.com/repos/nextic/IC/issues/517","repository_url":"https://api.github.com/repos/nextic/IC","labels_url":"https://api.github.com/repos/nextic/IC/issues/517/labels{/name}","comments_url":"https://api.github.com/repos/nextic/IC/issues/517/comments","events_url":"https://api.github.com/repos/nextic/IC/issues/517/events","html_url":"https://github.com/nextic/IC/pull/517","id":345836580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODYyMDIw","number":517,"title":"Fix test_inverse_cdf_index_hypothesis_generated","user":{"login":"jacg","id":2570854,"node_id":"MDQ6VXNlcjI1NzA4NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2570854?v=4","gravatar_id":"","url":"https://api.github.com/users/jacg","html_url":"https://github.com/jacg","followers_url":"https://api.github.com/users/jacg/followers","following_url":"https://api.github.com/users/jacg/following{/other_user}","gists_url":"https://api.github.com/users/jacg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacg/subscriptions","organizations_url":"https://api.github.com/users/jacg/orgs","repos_url":"https://api.github.com/users/jacg/repos","events_url":"https://api.github.com/users/jacg/events{/privacy}","received_events_url":"https://api.github.com/users/jacg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T16:34:22Z","updated_at":"2018-07-30T20:50:37Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/nextic/IC/pulls/517","html_url":"https://github.com/nextic/IC/pull/517","diff_url":"https://github.com/nextic/IC/pull/517.diff","patch_url":"https://github.com/nextic/IC/pull/517.patch"},"body":"`test_inverse_cdf_index_hypothesis_generated` fails on, very roughly, half of our Travis builds.\r\n\r\nThis probably means one of two things:\r\n\r\n1. There is a subtle bug in our code (which needs fixing).\r\n2. The hypothesis generators used in the test find spurious examples (which need eliminating).\r\n\r\nEither way, this wastes a lot of developer time when it comes to merging PRs and Travis builds in general (it has wasted about half of my waking hours over the last 2 days), so getting it sorted out sooner rather than later is quite important.\r\n\r\nThe original author of the test was @gonzaponte: in his absence, is there anyone else who is familiar with it?\r\n\r\nThe chances are that you don't see the failure when running tests locally, as it only shows up in about 50% of `hard` profile test runs, so the chances of our (very weak) `dev` profile finding it are quite slim. To work on this problem, run the test with the `hard` profile locally, repeatedly, until the test fails. After that the hypothesis database (which is stored locally on your machine) should ensure that the counterexample that was found gets used by the `dev` profile every time, allowing you to get a much quicker turnaround.\r\n\r\nLet me reiterate: this is a huge PITA, and it will annoy you with spurious Travis failures of your bulids, so it is en evyrone's interest to get it sorted out ASAP. Does anyone feel qualified to have a look at this?\r\n"},"comment":{"url":"https://api.github.com/repos/nextic/IC/issues/comments/409005699","html_url":"https://github.com/nextic/IC/pull/517#issuecomment-409005699","issue_url":"https://api.github.com/repos/nextic/IC/issues/517","id":409005699,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTAwNTY5OQ==","user":{"login":"jjgomezcadenas","id":8070159,"node_id":"MDQ6VXNlcjgwNzAxNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8070159?v=4","gravatar_id":"","url":"https://api.github.com/users/jjgomezcadenas","html_url":"https://github.com/jjgomezcadenas","followers_url":"https://api.github.com/users/jjgomezcadenas/followers","following_url":"https://api.github.com/users/jjgomezcadenas/following{/other_user}","gists_url":"https://api.github.com/users/jjgomezcadenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgomezcadenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgomezcadenas/subscriptions","organizations_url":"https://api.github.com/users/jjgomezcadenas/orgs","repos_url":"https://api.github.com/users/jjgomezcadenas/repos","events_url":"https://api.github.com/users/jjgomezcadenas/events{/privacy}","received_events_url":"https://api.github.com/users/jjgomezcadenas/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T20:50:37Z","updated_at":"2018-07-30T20:50:37Z","author_association":"COLLABORATOR","body":"This falls directly into the domain of @gonzaponte. It is part of a set of tests which do not affect the main stream of current development. It is complex and totally his responsibility. It is not justified that other developers loose essential time (we are really up to our neck here) with this stuff. \r\n\r\nIt is my understanding that @gonzaponte is not available until some time in September. Therefore, and unless he can find a couple of hours to work in this problem, please **comment out** the test until he can fix it. We can then approve a PR implementing this (no)-solution, but curing the symptoms and open a new one that will be closed only when @gonzaponte can fix the problem.\r\n"}}
{"actor":{"display_login":"jjgomezcadenas"}}