{"action":"reopened","number":47700,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47700","id":188712003,"html_url":"https://github.com/saltstack/salt/pull/47700","diff_url":"https://github.com/saltstack/salt/pull/47700.diff","patch_url":"https://github.com/saltstack/salt/pull/47700.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47700","number":47700,"state":"open","locked":false,"title":"fix roots modification time check","user":{"login":"yannj-fr","id":4557670,"avatar_url":"https://avatars1.githubusercontent.com/u/4557670?v=4","gravatar_id":"","url":"https://api.github.com/users/yannj-fr","html_url":"https://github.com/yannj-fr","followers_url":"https://api.github.com/users/yannj-fr/followers","following_url":"https://api.github.com/users/yannj-fr/following{/other_user}","gists_url":"https://api.github.com/users/yannj-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannj-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannj-fr/subscriptions","organizations_url":"https://api.github.com/users/yannj-fr/orgs","repos_url":"https://api.github.com/users/yannj-fr/repos","events_url":"https://api.github.com/users/yannj-fr/events{/privacy}","received_events_url":"https://api.github.com/users/yannj-fr/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nFix cache modification time comparison. When converting the modification from os.path.getmtime to string, the number is stripped and the comparison is always false. the hash is recomputed everytime\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\nhash was compute everytime like if the cache was not present\r\n### New Behavior\r\ncache is used\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\n### Commits signed with GPG?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n","created_at":"2018-05-17T11:54:38Z","updated_at":"2018-05-18T15:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a49bf489460ae0ecd774885a0d9ee0bc59ec8747","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":864901542,"url":"https://api.github.com/repos/saltstack/salt/labels/2017.7.6","name":"2017.7.6","color":"fbca04","default":false},{"id":853105682,"url":"https://api.github.com/repos/saltstack/salt/labels/2018.3.1","name":"2018.3.1","color":"fbca04","default":false},{"id":78034416,"url":"https://api.github.com/repos/saltstack/salt/labels/Bugfix%20-%20back-port","name":"Bugfix - back-port","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47700/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47700/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47700/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/20d978524430baf4f164ec4c5f2f743af3246c18","head":{"label":"yannj-fr:2017.7.6","ref":"2017.7.6","sha":"20d978524430baf4f164ec4c5f2f743af3246c18","user":{"login":"yannj-fr","id":4557670,"avatar_url":"https://avatars1.githubusercontent.com/u/4557670?v=4","gravatar_id":"","url":"https://api.github.com/users/yannj-fr","html_url":"https://github.com/yannj-fr","followers_url":"https://api.github.com/users/yannj-fr/followers","following_url":"https://api.github.com/users/yannj-fr/following{/other_user}","gists_url":"https://api.github.com/users/yannj-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannj-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannj-fr/subscriptions","organizations_url":"https://api.github.com/users/yannj-fr/orgs","repos_url":"https://api.github.com/users/yannj-fr/repos","events_url":"https://api.github.com/users/yannj-fr/events{/privacy}","received_events_url":"https://api.github.com/users/yannj-fr/received_events","type":"User","site_admin":false},"repo":{"id":93842770,"name":"salt","full_name":"yannj-fr/salt","owner":{"login":"yannj-fr","id":4557670,"avatar_url":"https://avatars1.githubusercontent.com/u/4557670?v=4","gravatar_id":"","url":"https://api.github.com/users/yannj-fr","html_url":"https://github.com/yannj-fr","followers_url":"https://api.github.com/users/yannj-fr/followers","following_url":"https://api.github.com/users/yannj-fr/following{/other_user}","gists_url":"https://api.github.com/users/yannj-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/yannj-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannj-fr/subscriptions","organizations_url":"https://api.github.com/users/yannj-fr/orgs","repos_url":"https://api.github.com/users/yannj-fr/repos","events_url":"https://api.github.com/users/yannj-fr/events{/privacy}","received_events_url":"https://api.github.com/users/yannj-fr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yannj-fr/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/yannj-fr/salt","forks_url":"https://api.github.com/repos/yannj-fr/salt/forks","keys_url":"https://api.github.com/repos/yannj-fr/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yannj-fr/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yannj-fr/salt/teams","hooks_url":"https://api.github.com/repos/yannj-fr/salt/hooks","issue_events_url":"https://api.github.com/repos/yannj-fr/salt/issues/events{/number}","events_url":"https://api.github.com/repos/yannj-fr/salt/events","assignees_url":"https://api.github.com/repos/yannj-fr/salt/assignees{/user}","branches_url":"https://api.github.com/repos/yannj-fr/salt/branches{/branch}","tags_url":"https://api.github.com/repos/yannj-fr/salt/tags","blobs_url":"https://api.github.com/repos/yannj-fr/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yannj-fr/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yannj-fr/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/yannj-fr/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yannj-fr/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/yannj-fr/salt/languages","stargazers_url":"https://api.github.com/repos/yannj-fr/salt/stargazers","contributors_url":"https://api.github.com/repos/yannj-fr/salt/contributors","subscribers_url":"https://api.github.com/repos/yannj-fr/salt/subscribers","subscription_url":"https://api.github.com/repos/yannj-fr/salt/subscription","commits_url":"https://api.github.com/repos/yannj-fr/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/yannj-fr/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/yannj-fr/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/yannj-fr/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/yannj-fr/salt/contents/{+path}","compare_url":"https://api.github.com/repos/yannj-fr/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yannj-fr/salt/merges","archive_url":"https://api.github.com/repos/yannj-fr/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yannj-fr/salt/downloads","issues_url":"https://api.github.com/repos/yannj-fr/salt/issues{/number}","pulls_url":"https://api.github.com/repos/yannj-fr/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/yannj-fr/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/yannj-fr/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yannj-fr/salt/labels{/name}","releases_url":"https://api.github.com/repos/yannj-fr/salt/releases{/id}","deployments_url":"https://api.github.com/repos/yannj-fr/salt/deployments","created_at":"2017-06-09T09:31:11Z","updated_at":"2017-06-09T09:31:29Z","pushed_at":"2018-05-17T11:51:00Z","git_url":"git://github.com/yannj-fr/salt.git","ssh_url":"git@github.com:yannj-fr/salt.git","clone_url":"https://github.com/yannj-fr/salt.git","svn_url":"https://github.com/yannj-fr/salt","homepage":"https://repo.saltstack.com/","size":330392,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2017.7.6","ref":"2017.7.6","sha":"16c21533851e76454cc3aab125ee1cf0ba07606e","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-05-18T15:34:06Z","pushed_at":"2018-05-18T15:51:46Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":401869,"stargazers_count":8855,"watchers_count":8855,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4148,"mirror_url":null,"archived":false,"open_issues_count":3382,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4148,"open_issues":3382,"watchers":8855,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47700"},"html":{"href":"https://github.com/saltstack/salt/pull/47700"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47700"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47700/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47700/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47700/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/20d978524430baf4f164ec4c5f2f743af3246c18"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":8,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"yannj-fr"}}