{"action":"created","comment":{"url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/comments/186869948","pull_request_review_id":118536475,"id":186869948,"diff_hunk":"@@ -4,16 +4,26 @@\n \n import org.controlsfx.tools.Utils;\n \n+import java.util.Random;\n+\n import javafx.fxml.FXML;\n import javafx.scene.control.Label;\n import javafx.scene.control.ProgressBar;\n import javafx.scene.layout.Pane;\n+import javafx.scene.paint.Color;\n \n public class PreloaderController {\n \n+  private static final Color primaryColor = Color.rgb(39, 39, 247);\n+  private static final Color secondaryColor = Color.rgb(64, 64, 255);","path":"app/src/main/java/edu/wpi/first/shuffleboard/app/PreloaderController.java","position":15,"original_position":15,"commit_id":"1d8502bc35ce15b8093cf640af82bcf91931778e","original_commit_id":"1d8502bc35ce15b8093cf640af82bcf91931778e","user":{"login":"SamCarlberg","id":6320992,"avatar_url":"https://avatars2.githubusercontent.com/u/6320992?v=4","gravatar_id":"","url":"https://api.github.com/users/SamCarlberg","html_url":"https://github.com/SamCarlberg","followers_url":"https://api.github.com/users/SamCarlberg/followers","following_url":"https://api.github.com/users/SamCarlberg/following{/other_user}","gists_url":"https://api.github.com/users/SamCarlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/SamCarlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamCarlberg/subscriptions","organizations_url":"https://api.github.com/users/SamCarlberg/orgs","repos_url":"https://api.github.com/users/SamCarlberg/repos","events_url":"https://api.github.com/users/SamCarlberg/events{/privacy}","received_events_url":"https://api.github.com/users/SamCarlberg/received_events","type":"User","site_admin":false},"body":"This color scheme matches the default theme.  It'd be a bit weird to have a red-and-gray preloader switch to a blue-and-white theme when shuffleboard is launched.\r\n\r\nIf the WPILib logo is added, I would switch to a red color scheme.  I don't know where the logo is actually used besides the developer shirts; it's definitely not in any other desktop tool, so it's not something that people would recognize and immediately recognize as \"WPILib\"","created_at":"2018-05-08T21:14:30Z","updated_at":"2018-05-08T21:14:31Z","html_url":"https://github.com/wpilibsuite/shuffleboard/pull/466#discussion_r186869948","pull_request_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/comments/186869948"},"html":{"href":"https://github.com/wpilibsuite/shuffleboard/pull/466#discussion_r186869948"},"pull_request":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466"}},"in_reply_to_id":186817884},"pull_request":{"url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466","id":186708227,"html_url":"https://github.com/wpilibsuite/shuffleboard/pull/466","diff_url":"https://github.com/wpilibsuite/shuffleboard/pull/466.diff","patch_url":"https://github.com/wpilibsuite/shuffleboard/pull/466.patch","issue_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/466","number":466,"state":"open","locked":false,"title":"Improve startup times and make the preloader nicer ","user":{"login":"SamCarlberg","id":6320992,"avatar_url":"https://avatars2.githubusercontent.com/u/6320992?v=4","gravatar_id":"","url":"https://api.github.com/users/SamCarlberg","html_url":"https://github.com/SamCarlberg","followers_url":"https://api.github.com/users/SamCarlberg/followers","following_url":"https://api.github.com/users/SamCarlberg/following{/other_user}","gists_url":"https://api.github.com/users/SamCarlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/SamCarlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamCarlberg/subscriptions","organizations_url":"https://api.github.com/users/SamCarlberg/orgs","repos_url":"https://api.github.com/users/SamCarlberg/repos","events_url":"https://api.github.com/users/SamCarlberg/events{/privacy}","received_events_url":"https://api.github.com/users/SamCarlberg/received_events","type":"User","site_admin":false},"body":"- Lazily initialize FXML helper dialogs (plugins pane, various update prrompts, \"about\" dialog) instead of loading them all at startup\r\n  - Reduction of ~30% in FXML load times\r\n- Do not start a NetworkTable client before setting the server ID (which itself starts the clients)\r\n\r\nAdditionally, using pre-extracted JNI libraries reduces NetworkTable load times from ~260ms to ~10ms and CameraServer from ~450ms to ~10ms on my desktop computer, and total startup time from ~3.3 seconds to ~2.7 seconds. This PR does not add JNI pre-extraction, since ntcore and cscore will handle that process.\r\n\r\n# Screenshot\r\n![image](https://user-images.githubusercontent.com/6320992/39770900-67ca3034-52be-11e8-8e96-7ea7d3b91dc7.png)\r\n","created_at":"2018-05-08T17:49:52Z","updated_at":"2018-05-08T21:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5250821cdd5e286ab520b1f9319e90f3d4e7bb7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":609125224,"url":"https://api.github.com/repos/wpilibsuite/shuffleboard/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":621978679,"url":"https://api.github.com/repos/wpilibsuite/shuffleboard/labels/ui","name":"ui","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466/commits","review_comments_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466/comments","review_comment_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/466/comments","statuses_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/statuses/1d8502bc35ce15b8093cf640af82bcf91931778e","head":{"label":"SamCarlberg:fancy-preloader","ref":"fancy-preloader","sha":"1d8502bc35ce15b8093cf640af82bcf91931778e","user":{"login":"SamCarlberg","id":6320992,"avatar_url":"https://avatars2.githubusercontent.com/u/6320992?v=4","gravatar_id":"","url":"https://api.github.com/users/SamCarlberg","html_url":"https://github.com/SamCarlberg","followers_url":"https://api.github.com/users/SamCarlberg/followers","following_url":"https://api.github.com/users/SamCarlberg/following{/other_user}","gists_url":"https://api.github.com/users/SamCarlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/SamCarlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamCarlberg/subscriptions","organizations_url":"https://api.github.com/users/SamCarlberg/orgs","repos_url":"https://api.github.com/users/SamCarlberg/repos","events_url":"https://api.github.com/users/SamCarlberg/events{/privacy}","received_events_url":"https://api.github.com/users/SamCarlberg/received_events","type":"User","site_admin":false},"repo":{"id":97523074,"name":"shuffleboard","full_name":"SamCarlberg/shuffleboard","owner":{"login":"SamCarlberg","id":6320992,"avatar_url":"https://avatars2.githubusercontent.com/u/6320992?v=4","gravatar_id":"","url":"https://api.github.com/users/SamCarlberg","html_url":"https://github.com/SamCarlberg","followers_url":"https://api.github.com/users/SamCarlberg/followers","following_url":"https://api.github.com/users/SamCarlberg/following{/other_user}","gists_url":"https://api.github.com/users/SamCarlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/SamCarlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamCarlberg/subscriptions","organizations_url":"https://api.github.com/users/SamCarlberg/orgs","repos_url":"https://api.github.com/users/SamCarlberg/repos","events_url":"https://api.github.com/users/SamCarlberg/events{/privacy}","received_events_url":"https://api.github.com/users/SamCarlberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamCarlberg/shuffleboard","description":null,"fork":true,"url":"https://api.github.com/repos/SamCarlberg/shuffleboard","forks_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/forks","keys_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/teams","hooks_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/hooks","issue_events_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/issues/events{/number}","events_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/events","assignees_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/assignees{/user}","branches_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/branches{/branch}","tags_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/tags","blobs_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/statuses/{sha}","languages_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/languages","stargazers_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/stargazers","contributors_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/contributors","subscribers_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/subscribers","subscription_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/subscription","commits_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/contents/{+path}","compare_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/merges","archive_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/downloads","issues_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/issues{/number}","pulls_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/pulls{/number}","milestones_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/milestones{/number}","notifications_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/labels{/name}","releases_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/releases{/id}","deployments_url":"https://api.github.com/repos/SamCarlberg/shuffleboard/deployments","created_at":"2017-07-17T21:17:01Z","updated_at":"2018-04-04T19:14:53Z","pushed_at":"2018-05-08T17:36:38Z","git_url":"git://github.com/SamCarlberg/shuffleboard.git","ssh_url":"git@github.com:SamCarlberg/shuffleboard.git","clone_url":"https://github.com/SamCarlberg/shuffleboard.git","svn_url":"https://github.com/SamCarlberg/shuffleboard","homepage":null,"size":1931,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpilibsuite:master","ref":"master","sha":"5c7f7068d1021384e5a9558e43481a98fdb0f37f","user":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars3.githubusercontent.com/u/19267233?v=4","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":91855299,"name":"shuffleboard","full_name":"wpilibsuite/shuffleboard","owner":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars3.githubusercontent.com/u/19267233?v=4","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpilibsuite/shuffleboard","description":"A modern dashboard for FRC","fork":false,"url":"https://api.github.com/repos/wpilibsuite/shuffleboard","forks_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/forks","keys_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/teams","hooks_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/hooks","issue_events_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/events{/number}","events_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/events","assignees_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/assignees{/user}","branches_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/branches{/branch}","tags_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/tags","blobs_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/statuses/{sha}","languages_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/languages","stargazers_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/stargazers","contributors_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/contributors","subscribers_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/subscribers","subscription_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/subscription","commits_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/contents/{+path}","compare_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/merges","archive_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/downloads","issues_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues{/number}","pulls_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls{/number}","milestones_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/milestones{/number}","notifications_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/labels{/name}","releases_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/releases{/id}","deployments_url":"https://api.github.com/repos/wpilibsuite/shuffleboard/deployments","created_at":"2017-05-20T00:38:25Z","updated_at":"2018-04-29T13:33:07Z","pushed_at":"2018-05-08T17:49:53Z","git_url":"git://github.com/wpilibsuite/shuffleboard.git","ssh_url":"git@github.com:wpilibsuite/shuffleboard.git","clone_url":"https://github.com/wpilibsuite/shuffleboard.git","svn_url":"https://github.com/wpilibsuite/shuffleboard","homepage":"","size":1579,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":22,"open_issues":75,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466"},"html":{"href":"https://github.com/wpilibsuite/shuffleboard/pull/466"},"issue":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/466"},"comments":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/wpilibsuite/shuffleboard/statuses/1d8502bc35ce15b8093cf640af82bcf91931778e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"SamCarlberg"}}