{"action":"created","comment":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/179527550","pull_request_review_id":109787907,"id":179527550,"diff_hunk":"@@ -880,6 +889,69 @@ mainCommand[std::unique_ptr<CVC4::Command>* cmd]\n   | CONTINUE_TOK\n     { UNSUPPORTED(\"CONTINUE command\"); }\n   | RESTART_TOK formula[f] { UNSUPPORTED(\"RESTART command\"); }\n+  | RECURSIVE_FUNCTION_TOK (identifier[id,CHECK_NONE,SYM_VARIABLE] \n+    {\n+      if(idCommaFlag){\n+        idCommaFlag=false;\n+      }\n+      else{\n+        PARSER_STATE->parseError(\"Identifiers need to be comma separated\");\n+      }\n+    }\n+    COLON type[t,CHECK_DECLARED] (COMMA {\n+      idCommaFlag=true;\n+      })? \n+    {\n+      func = PARSER_STATE->mkVar(id, t, ExprManager::VAR_FLAG_NONE, true);\n+      ids.push_back(id);\n+      types.push_back(t);\n+      funcs.push_back(func);\n+    })+\n+    EQUAL_TOK (formula[f]\n+    {\n+      if(formCommaFlag){\n+        formCommaFlag=false;\n+      }\n+      else{\n+        PARSER_STATE->parseError(\"Function definitions need to be comma separated\");\n+      }\n+    }\n+    (COMMA{\n+      formCommaFlag=true;\n+    })?\n+    {\n+      if( f.getKind()==kind::LAMBDA ){\n+        for( unsigned i=0,size=f[0].getNumChildren(); i<size; i++)\n+        {\n+          bvs.push_back( f[0][i] );\n+        }","path":"src/parser/cvc/Cvc.g","position":78,"original_position":78,"commit_id":"ede65af9c2d8383d09970a16088667dc24408fa4","original_commit_id":"ede65af9c2d8383d09970a16088667dc24408fa4","user":{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false},"body":"You can use `bvs.insert{bvs.end(), f[0].begin(), f[0].end())` instead of the for loop.","created_at":"2018-04-05T16:43:09Z","updated_at":"2018-04-05T16:48:17Z","html_url":"https://github.com/CVC4/CVC4/pull/1738#discussion_r179527550","pull_request_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1738","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments/179527550"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1738#discussion_r179527550"},"pull_request":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1738"}}},"pull_request":{"url":"https://api.github.com/repos/CVC4/CVC4/pulls/1738","id":179158273,"html_url":"https://github.com/CVC4/CVC4/pull/1738","diff_url":"https://github.com/CVC4/CVC4/pull/1738.diff","patch_url":"https://github.com/CVC4/CVC4/pull/1738.patch","issue_url":"https://api.github.com/repos/CVC4/CVC4/issues/1738","number":1738,"state":"open","locked":false,"title":"Add define rec fun to cvc parser","user":{"login":"arjunvish","id":21977510,"avatar_url":"https://avatars3.githubusercontent.com/u/21977510?v=4","gravatar_id":"","url":"https://api.github.com/users/arjunvish","html_url":"https://github.com/arjunvish","followers_url":"https://api.github.com/users/arjunvish/followers","following_url":"https://api.github.com/users/arjunvish/following{/other_user}","gists_url":"https://api.github.com/users/arjunvish/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunvish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunvish/subscriptions","organizations_url":"https://api.github.com/users/arjunvish/orgs","repos_url":"https://api.github.com/users/arjunvish/repos","events_url":"https://api.github.com/users/arjunvish/events{/privacy}","received_events_url":"https://api.github.com/users/arjunvish/received_events","type":"User","site_admin":false},"body":"CVC Front end for recursive functions (Issue #1316)","created_at":"2018-04-03T16:50:52Z","updated_at":"2018-04-05T16:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8525ff27acfaabd5c1859d9f22adb1a77ba9dd6c","assignee":{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars0.githubusercontent.com/u/2973467?v=4","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},"assignees":[{"login":"ajreynol","id":2973467,"avatar_url":"https://avatars0.githubusercontent.com/u/2973467?v=4","gravatar_id":"","url":"https://api.github.com/users/ajreynol","html_url":"https://github.com/ajreynol","followers_url":"https://api.github.com/users/ajreynol/followers","following_url":"https://api.github.com/users/ajreynol/following{/other_user}","gists_url":"https://api.github.com/users/ajreynol/gists{/gist_id}","starred_url":"https://api.github.com/users/ajreynol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajreynol/subscriptions","organizations_url":"https://api.github.com/users/ajreynol/orgs","repos_url":"https://api.github.com/users/ajreynol/repos","events_url":"https://api.github.com/users/ajreynol/events{/privacy}","received_events_url":"https://api.github.com/users/ajreynol/received_events","type":"User","site_admin":false},{"login":"mpreiner","id":4653598,"avatar_url":"https://avatars0.githubusercontent.com/u/4653598?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreiner","html_url":"https://github.com/mpreiner","followers_url":"https://api.github.com/users/mpreiner/followers","following_url":"https://api.github.com/users/mpreiner/following{/other_user}","gists_url":"https://api.github.com/users/mpreiner/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreiner/subscriptions","organizations_url":"https://api.github.com/users/mpreiner/orgs","repos_url":"https://api.github.com/users/mpreiner/repos","events_url":"https://api.github.com/users/mpreiner/events{/privacy}","received_events_url":"https://api.github.com/users/mpreiner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":671892488,"url":"https://api.github.com/repos/CVC4/CVC4/labels/minor","name":"minor","color":"fef2c0","default":false},{"id":717338434,"url":"https://api.github.com/repos/CVC4/CVC4/labels/moderate","name":"moderate","color":"88ccf5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1738/commits","review_comments_url":"https://api.github.com/repos/CVC4/CVC4/pulls/1738/comments","review_comment_url":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CVC4/CVC4/issues/1738/comments","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/ede65af9c2d8383d09970a16088667dc24408fa4","head":{"label":"arjunvish:define-rec-fun","ref":"define-rec-fun","sha":"ede65af9c2d8383d09970a16088667dc24408fa4","user":{"login":"arjunvish","id":21977510,"avatar_url":"https://avatars3.githubusercontent.com/u/21977510?v=4","gravatar_id":"","url":"https://api.github.com/users/arjunvish","html_url":"https://github.com/arjunvish","followers_url":"https://api.github.com/users/arjunvish/followers","following_url":"https://api.github.com/users/arjunvish/following{/other_user}","gists_url":"https://api.github.com/users/arjunvish/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunvish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunvish/subscriptions","organizations_url":"https://api.github.com/users/arjunvish/orgs","repos_url":"https://api.github.com/users/arjunvish/repos","events_url":"https://api.github.com/users/arjunvish/events{/privacy}","received_events_url":"https://api.github.com/users/arjunvish/received_events","type":"User","site_admin":false},"repo":{"id":109021211,"name":"CVC4","full_name":"arjunvish/CVC4","owner":{"login":"arjunvish","id":21977510,"avatar_url":"https://avatars3.githubusercontent.com/u/21977510?v=4","gravatar_id":"","url":"https://api.github.com/users/arjunvish","html_url":"https://github.com/arjunvish","followers_url":"https://api.github.com/users/arjunvish/followers","following_url":"https://api.github.com/users/arjunvish/following{/other_user}","gists_url":"https://api.github.com/users/arjunvish/gists{/gist_id}","starred_url":"https://api.github.com/users/arjunvish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjunvish/subscriptions","organizations_url":"https://api.github.com/users/arjunvish/orgs","repos_url":"https://api.github.com/users/arjunvish/repos","events_url":"https://api.github.com/users/arjunvish/events{/privacy}","received_events_url":"https://api.github.com/users/arjunvish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arjunvish/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":true,"url":"https://api.github.com/repos/arjunvish/CVC4","forks_url":"https://api.github.com/repos/arjunvish/CVC4/forks","keys_url":"https://api.github.com/repos/arjunvish/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arjunvish/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arjunvish/CVC4/teams","hooks_url":"https://api.github.com/repos/arjunvish/CVC4/hooks","issue_events_url":"https://api.github.com/repos/arjunvish/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/arjunvish/CVC4/events","assignees_url":"https://api.github.com/repos/arjunvish/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/arjunvish/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/arjunvish/CVC4/tags","blobs_url":"https://api.github.com/repos/arjunvish/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arjunvish/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arjunvish/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/arjunvish/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arjunvish/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/arjunvish/CVC4/languages","stargazers_url":"https://api.github.com/repos/arjunvish/CVC4/stargazers","contributors_url":"https://api.github.com/repos/arjunvish/CVC4/contributors","subscribers_url":"https://api.github.com/repos/arjunvish/CVC4/subscribers","subscription_url":"https://api.github.com/repos/arjunvish/CVC4/subscription","commits_url":"https://api.github.com/repos/arjunvish/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/arjunvish/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/arjunvish/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/arjunvish/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/arjunvish/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/arjunvish/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arjunvish/CVC4/merges","archive_url":"https://api.github.com/repos/arjunvish/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arjunvish/CVC4/downloads","issues_url":"https://api.github.com/repos/arjunvish/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/arjunvish/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/arjunvish/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/arjunvish/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arjunvish/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/arjunvish/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/arjunvish/CVC4/deployments","created_at":"2017-10-31T16:14:06Z","updated_at":"2018-04-02T16:10:45Z","pushed_at":"2018-04-03T02:21:51Z","git_url":"git://github.com/arjunvish/CVC4.git","ssh_url":"git@github.com:arjunvish/CVC4.git","clone_url":"https://github.com/arjunvish/CVC4.git","svn_url":"https://github.com/arjunvish/CVC4","homepage":null,"size":43234,"stargazers_count":0,"watchers_count":0,"language":"SMT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CVC4:master","ref":"master","sha":"77c09d4c79224b726183cfd59df3cf5eff3ff4ea","user":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"repo":{"id":7040894,"name":"CVC4","full_name":"CVC4/CVC4","owner":{"login":"CVC4","id":2973223,"avatar_url":"https://avatars0.githubusercontent.com/u/2973223?v=4","gravatar_id":"","url":"https://api.github.com/users/CVC4","html_url":"https://github.com/CVC4","followers_url":"https://api.github.com/users/CVC4/followers","following_url":"https://api.github.com/users/CVC4/following{/other_user}","gists_url":"https://api.github.com/users/CVC4/gists{/gist_id}","starred_url":"https://api.github.com/users/CVC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CVC4/subscriptions","organizations_url":"https://api.github.com/users/CVC4/orgs","repos_url":"https://api.github.com/users/CVC4/repos","events_url":"https://api.github.com/users/CVC4/events{/privacy}","received_events_url":"https://api.github.com/users/CVC4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CVC4/CVC4","description":"CVC4 is an efficient open-source automatic theorem prover for satisfiability modulo theories (SMT) problems.","fork":false,"url":"https://api.github.com/repos/CVC4/CVC4","forks_url":"https://api.github.com/repos/CVC4/CVC4/forks","keys_url":"https://api.github.com/repos/CVC4/CVC4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CVC4/CVC4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CVC4/CVC4/teams","hooks_url":"https://api.github.com/repos/CVC4/CVC4/hooks","issue_events_url":"https://api.github.com/repos/CVC4/CVC4/issues/events{/number}","events_url":"https://api.github.com/repos/CVC4/CVC4/events","assignees_url":"https://api.github.com/repos/CVC4/CVC4/assignees{/user}","branches_url":"https://api.github.com/repos/CVC4/CVC4/branches{/branch}","tags_url":"https://api.github.com/repos/CVC4/CVC4/tags","blobs_url":"https://api.github.com/repos/CVC4/CVC4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CVC4/CVC4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CVC4/CVC4/git/refs{/sha}","trees_url":"https://api.github.com/repos/CVC4/CVC4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CVC4/CVC4/statuses/{sha}","languages_url":"https://api.github.com/repos/CVC4/CVC4/languages","stargazers_url":"https://api.github.com/repos/CVC4/CVC4/stargazers","contributors_url":"https://api.github.com/repos/CVC4/CVC4/contributors","subscribers_url":"https://api.github.com/repos/CVC4/CVC4/subscribers","subscription_url":"https://api.github.com/repos/CVC4/CVC4/subscription","commits_url":"https://api.github.com/repos/CVC4/CVC4/commits{/sha}","git_commits_url":"https://api.github.com/repos/CVC4/CVC4/git/commits{/sha}","comments_url":"https://api.github.com/repos/CVC4/CVC4/comments{/number}","issue_comment_url":"https://api.github.com/repos/CVC4/CVC4/issues/comments{/number}","contents_url":"https://api.github.com/repos/CVC4/CVC4/contents/{+path}","compare_url":"https://api.github.com/repos/CVC4/CVC4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CVC4/CVC4/merges","archive_url":"https://api.github.com/repos/CVC4/CVC4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CVC4/CVC4/downloads","issues_url":"https://api.github.com/repos/CVC4/CVC4/issues{/number}","pulls_url":"https://api.github.com/repos/CVC4/CVC4/pulls{/number}","milestones_url":"https://api.github.com/repos/CVC4/CVC4/milestones{/number}","notifications_url":"https://api.github.com/repos/CVC4/CVC4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CVC4/CVC4/labels{/name}","releases_url":"https://api.github.com/repos/CVC4/CVC4/releases{/id}","deployments_url":"https://api.github.com/repos/CVC4/CVC4/deployments","created_at":"2012-12-06T18:45:04Z","updated_at":"2018-04-05T05:43:52Z","pushed_at":"2018-04-05T16:28:46Z","git_url":"git://github.com/CVC4/CVC4.git","ssh_url":"git@github.com:CVC4/CVC4.git","clone_url":"https://github.com/CVC4/CVC4.git","svn_url":"https://github.com/CVC4/CVC4","homepage":null,"size":43275,"stargazers_count":189,"watchers_count":189,"language":"SMT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":80,"open_issues":196,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1738"},"html":{"href":"https://github.com/CVC4/CVC4/pull/1738"},"issue":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1738"},"comments":{"href":"https://api.github.com/repos/CVC4/CVC4/issues/1738/comments"},"review_comments":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1738/comments"},"review_comment":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CVC4/CVC4/pulls/1738/commits"},"statuses":{"href":"https://api.github.com/repos/CVC4/CVC4/statuses/ede65af9c2d8383d09970a16088667dc24408fa4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpreiner"}}