{"action":"created","comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/243985776","pull_request_review_id":187882838,"id":243985776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzk4NTc3Ng==","diff_hunk":"@@ -199,6 +199,8 @@ list(APPEND gr_blocks_sources\n     wavfile_source_impl.cc\n )\n \n+set_source_files_properties(file_source_impl.cc PROPERTIES COMPILE_FLAGS -D_FILE_OFFSET_BITS=64)","path":"gr-blocks/lib/CMakeLists.txt","position":10,"original_position":10,"commit_id":"014b9c5d9f9b9f46d1374091165c178937e1192f","original_commit_id":"014b9c5d9f9b9f46d1374091165c178937e1192f","user":{"login":"noc0lour","id":4438327,"node_id":"MDQ6VXNlcjQ0MzgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4438327?v=4","gravatar_id":"","url":"https://api.github.com/users/noc0lour","html_url":"https://github.com/noc0lour","followers_url":"https://api.github.com/users/noc0lour/followers","following_url":"https://api.github.com/users/noc0lour/following{/other_user}","gists_url":"https://api.github.com/users/noc0lour/gists{/gist_id}","starred_url":"https://api.github.com/users/noc0lour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noc0lour/subscriptions","organizations_url":"https://api.github.com/users/noc0lour/orgs","repos_url":"https://api.github.com/users/noc0lour/repos","events_url":"https://api.github.com/users/noc0lour/events{/privacy}","received_events_url":"https://api.github.com/users/noc0lour/received_events","type":"User","site_admin":false},"body":"I'm wondering if a `#define` in the implementation would be better?","created_at":"2018-12-26T11:47:08Z","updated_at":"2018-12-26T11:47:08Z","html_url":"https://github.com/gnuradio/gnuradio/pull/2263#discussion_r243985776","pull_request_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/243985776"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/2263#discussion_r243985776"},"pull_request":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263"}}},"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263","id":240876627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODc2NjI3","html_url":"https://github.com/gnuradio/gnuradio/pull/2263","diff_url":"https://github.com/gnuradio/gnuradio/pull/2263.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/2263.patch","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/2263","number":2263,"state":"open","locked":false,"title":"blocks: Fix file_source offset/length to properly access large files.","user":{"login":"drmpeg","id":5397196,"node_id":"MDQ6VXNlcjUzOTcxOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5397196?v=4","gravatar_id":"","url":"https://api.github.com/users/drmpeg","html_url":"https://github.com/drmpeg","followers_url":"https://api.github.com/users/drmpeg/followers","following_url":"https://api.github.com/users/drmpeg/following{/other_user}","gists_url":"https://api.github.com/users/drmpeg/gists{/gist_id}","starred_url":"https://api.github.com/users/drmpeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmpeg/subscriptions","organizations_url":"https://api.github.com/users/drmpeg/orgs","repos_url":"https://api.github.com/users/drmpeg/repos","events_url":"https://api.github.com/users/drmpeg/events{/privacy}","received_events_url":"https://api.github.com/users/drmpeg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-25T14:03:16Z","updated_at":"2018-12-26T11:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e04b0eb593116ab28931f0457124be91cf9033","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263/commits","review_comments_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263/comments","review_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/2263/comments","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/014b9c5d9f9b9f46d1374091165c178937e1192f","head":{"label":"drmpeg:filesource-fix","ref":"filesource-fix","sha":"014b9c5d9f9b9f46d1374091165c178937e1192f","user":{"login":"drmpeg","id":5397196,"node_id":"MDQ6VXNlcjUzOTcxOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5397196?v=4","gravatar_id":"","url":"https://api.github.com/users/drmpeg","html_url":"https://github.com/drmpeg","followers_url":"https://api.github.com/users/drmpeg/followers","following_url":"https://api.github.com/users/drmpeg/following{/other_user}","gists_url":"https://api.github.com/users/drmpeg/gists{/gist_id}","starred_url":"https://api.github.com/users/drmpeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmpeg/subscriptions","organizations_url":"https://api.github.com/users/drmpeg/orgs","repos_url":"https://api.github.com/users/drmpeg/repos","events_url":"https://api.github.com/users/drmpeg/events{/privacy}","received_events_url":"https://api.github.com/users/drmpeg/received_events","type":"User","site_admin":false},"repo":{"id":162204428,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIyMDQ0Mjg=","name":"gnuradio","full_name":"drmpeg/gnuradio","private":false,"owner":{"login":"drmpeg","id":5397196,"node_id":"MDQ6VXNlcjUzOTcxOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5397196?v=4","gravatar_id":"","url":"https://api.github.com/users/drmpeg","html_url":"https://github.com/drmpeg","followers_url":"https://api.github.com/users/drmpeg/followers","following_url":"https://api.github.com/users/drmpeg/following{/other_user}","gists_url":"https://api.github.com/users/drmpeg/gists{/gist_id}","starred_url":"https://api.github.com/users/drmpeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drmpeg/subscriptions","organizations_url":"https://api.github.com/users/drmpeg/orgs","repos_url":"https://api.github.com/users/drmpeg/repos","events_url":"https://api.github.com/users/drmpeg/events{/privacy}","received_events_url":"https://api.github.com/users/drmpeg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drmpeg/gnuradio","description":"GNU Radio","fork":true,"url":"https://api.github.com/repos/drmpeg/gnuradio","forks_url":"https://api.github.com/repos/drmpeg/gnuradio/forks","keys_url":"https://api.github.com/repos/drmpeg/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drmpeg/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drmpeg/gnuradio/teams","hooks_url":"https://api.github.com/repos/drmpeg/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/drmpeg/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/drmpeg/gnuradio/events","assignees_url":"https://api.github.com/repos/drmpeg/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/drmpeg/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/drmpeg/gnuradio/tags","blobs_url":"https://api.github.com/repos/drmpeg/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drmpeg/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drmpeg/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/drmpeg/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drmpeg/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/drmpeg/gnuradio/languages","stargazers_url":"https://api.github.com/repos/drmpeg/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/drmpeg/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/drmpeg/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/drmpeg/gnuradio/subscription","commits_url":"https://api.github.com/repos/drmpeg/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/drmpeg/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/drmpeg/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/drmpeg/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/drmpeg/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/drmpeg/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drmpeg/gnuradio/merges","archive_url":"https://api.github.com/repos/drmpeg/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drmpeg/gnuradio/downloads","issues_url":"https://api.github.com/repos/drmpeg/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/drmpeg/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/drmpeg/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/drmpeg/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drmpeg/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/drmpeg/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/drmpeg/gnuradio/deployments","created_at":"2018-12-17T23:52:16Z","updated_at":"2018-12-17T23:52:27Z","pushed_at":"2018-12-26T02:37:26Z","git_url":"git://github.com/drmpeg/gnuradio.git","ssh_url":"git@github.com:drmpeg/gnuradio.git","clone_url":"https://github.com/drmpeg/gnuradio.git","svn_url":"https://github.com/drmpeg/gnuradio","homepage":"https://gnuradio.org","size":50663,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gnuradio:master","ref":"master","sha":"8b353303ab338abd302af088582d5c47bd1ccdf0","user":{"login":"gnuradio","id":1278659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1278659?v=4","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"repo":{"id":3030065,"node_id":"MDEwOlJlcG9zaXRvcnkzMDMwMDY1","name":"gnuradio","full_name":"gnuradio/gnuradio","private":false,"owner":{"login":"gnuradio","id":1278659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1278659?v=4","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gnuradio/gnuradio","description":"GNU Radio","fork":false,"url":"https://api.github.com/repos/gnuradio/gnuradio","forks_url":"https://api.github.com/repos/gnuradio/gnuradio/forks","keys_url":"https://api.github.com/repos/gnuradio/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnuradio/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnuradio/gnuradio/teams","hooks_url":"https://api.github.com/repos/gnuradio/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/gnuradio/gnuradio/events","assignees_url":"https://api.github.com/repos/gnuradio/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/gnuradio/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/gnuradio/gnuradio/tags","blobs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnuradio/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnuradio/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/gnuradio/gnuradio/languages","stargazers_url":"https://api.github.com/repos/gnuradio/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/gnuradio/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/gnuradio/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/gnuradio/gnuradio/subscription","commits_url":"https://api.github.com/repos/gnuradio/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnuradio/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnuradio/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/gnuradio/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnuradio/gnuradio/merges","archive_url":"https://api.github.com/repos/gnuradio/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnuradio/gnuradio/downloads","issues_url":"https://api.github.com/repos/gnuradio/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/gnuradio/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/gnuradio/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/gnuradio/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/gnuradio/gnuradio/deployments","created_at":"2011-12-21T22:05:37Z","updated_at":"2018-12-26T11:10:21Z","pushed_at":"2018-12-26T02:37:27Z","git_url":"git://github.com/gnuradio/gnuradio.git","ssh_url":"git@github.com:gnuradio/gnuradio.git","clone_url":"https://github.com/gnuradio/gnuradio.git","svn_url":"https://github.com/gnuradio/gnuradio","homepage":"https://gnuradio.org","size":50699,"stargazers_count":1455,"watchers_count":1455,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":910,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":910,"open_issues":293,"watchers":1455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/2263"},"issue":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/2263"},"comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/2263/comments"},"review_comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263/comments"},"review_comment":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/2263/commits"},"statuses":{"href":"https://api.github.com/repos/gnuradio/gnuradio/statuses/014b9c5d9f9b9f46d1374091165c178937e1192f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"noc0lour"}}