{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/169563278","pull_request_review_id":98106731,"id":169563278,"diff_hunk":"@@ -0,0 +1,5 @@\n+class DependencyCollector\n+  def xz_dep_if_needed(tags)\n+    Dependency.new(\"xz\", tags) unless which(\"xz\")","path":"Library/Homebrew/extend/os/linux/dependency_collector.rb","position":3,"original_position":3,"commit_id":"14d7a7a08c9aab7db14ea03f59ec85899e5e3ba6","original_commit_id":"14d7a7a08c9aab7db14ea03f59ec85899e5e3ba6","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"I'm 👍 on changing the default implementation in `Library/Homebrew/dependency_collector.rb` to do this for consistency. Could also do `cvs_dep_if_needed` if desired. The only potential gotcha is `self.tar_needs_xz_dependency?`; is it a safe assumption that `xz` in the `PATH` means `tar` is built with `xz` support? CC @sjackman ","created_at":"2018-02-21T08:31:57Z","updated_at":"2018-02-21T08:31:58Z","html_url":"https://github.com/Homebrew/brew/pull/3813#discussion_r169563278","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/3813","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/169563278"},"html":{"href":"https://github.com/Homebrew/brew/pull/3813#discussion_r169563278"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3813"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/3813","id":169728535,"html_url":"https://github.com/Homebrew/brew/pull/3813","diff_url":"https://github.com/Homebrew/brew/pull/3813.diff","patch_url":"https://github.com/Homebrew/brew/pull/3813.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/3813","number":3813,"state":"open","locked":false,"title":"bzip2 and zip dependencies_if_needed","user":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [x] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nContinuing to merge changes from Linuxbrew to Homebrew. Therefore, mentioning @sjackman @imichka\r\n\r\nBrining `zip` and `bzip2` related changes from Linux. The PR addresses the issue that not all  distros are created equal and lack `bzip2` and `zip`.\r\n\r\nI have written simple tests based on `p7zip` example.","created_at":"2018-02-16T21:21:50Z","updated_at":"2018-02-21T08:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3afb94650d1f120203744b4d39f21f2c5d47b91e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/3813/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/3813/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/3813/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/14d7a7a08c9aab7db14ea03f59ec85899e5e3ba6","head":{"label":"maxim-belkin:brew-unix-2","ref":"brew-unix-2","sha":"14d7a7a08c9aab7db14ea03f59ec85899e5e3ba6","user":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"repo":{"id":101780676,"name":"brew-macOS","full_name":"maxim-belkin/brew-macOS","owner":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxim-belkin/brew-macOS","description":"🍺 The missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/maxim-belkin/brew-macOS","forks_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/forks","keys_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/teams","hooks_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/hooks","issue_events_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/issues/events{/number}","events_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/events","assignees_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/assignees{/user}","branches_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/branches{/branch}","tags_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/tags","blobs_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/statuses/{sha}","languages_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/languages","stargazers_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/stargazers","contributors_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/contributors","subscribers_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/subscribers","subscription_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/subscription","commits_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/contents/{+path}","compare_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/merges","archive_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/downloads","issues_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/issues{/number}","pulls_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/pulls{/number}","milestones_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/milestones{/number}","notifications_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/labels{/name}","releases_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/releases{/id}","deployments_url":"https://api.github.com/repos/maxim-belkin/brew-macOS/deployments","created_at":"2017-08-29T16:06:48Z","updated_at":"2017-08-29T16:07:12Z","pushed_at":"2018-02-20T21:33:49Z","git_url":"git://github.com/maxim-belkin/brew-macOS.git","ssh_url":"git@github.com:maxim-belkin/brew-macOS.git","clone_url":"https://github.com/maxim-belkin/brew-macOS.git","svn_url":"https://github.com/maxim-belkin/brew-macOS","homepage":"https://brew.sh","size":22812,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"ef1924e1f3f2becefe68e4ee6c3967eeee998fcf","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":"🍺 The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2018-02-21T08:30:32Z","pushed_at":"2018-02-21T05:05:34Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"https://brew.sh","size":22797,"stargazers_count":11123,"watchers_count":11123,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2640,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":2640,"open_issues":24,"watchers":11123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3813"},"html":{"href":"https://github.com/Homebrew/brew/pull/3813"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3813"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3813/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3813/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3813/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/14d7a7a08c9aab7db14ea03f59ec85899e5e3ba6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MikeMcQuaid"}}