{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/225972888","pull_request_review_id":165685261,"id":225972888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTk3Mjg4OA==","diff_hunk":"@@ -1076,8 +1076,20 @@ PCODE COMDelegate::ConvertToCallback(MethodDesc* pMD)\n     if (NDirect::MarshalingRequired(pMD, pMD->GetSig(), pMD->GetModule()))\n         COMPlusThrow(kNotSupportedException, W(\"NotSupported_NonBlittableTypes\"));\n \n-    // Get UMEntryThunk from appdomain thunkcache cache.\n-    UMEntryThunk *pUMEntryThunk = GetAppDomain()->GetUMEntryThunkCache()->GetUMEntryThunk(pMD);\n+    UMEntryThunkCache* pCache;\n+    LoaderAllocator* pLoaderAllocator = pMD->GetLoaderAllocator();\n+    if (pLoaderAllocator->IsCollectible())","path":"src/vm/comdelegate.cpp","position":8,"original_position":8,"commit_id":"44e7590706d7c2f2c083de3884332dedd855e1f9","original_commit_id":"44e7590706d7c2f2c083de3884332dedd855e1f9","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Right.\r\n\r\n> we could possibly end up with more instances of the cache\r\n\r\nI do not think we would end up with more instances of the cache.","created_at":"2018-10-17T15:10:42Z","updated_at":"2018-10-17T15:10:43Z","html_url":"https://github.com/dotnet/coreclr/pull/20438#discussion_r225972888","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/20438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/225972888"},"html":{"href":"https://github.com/dotnet/coreclr/pull/20438#discussion_r225972888"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20438"}},"in_reply_to_id":225776015},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/20438","id":223308711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzA4NzEx","html_url":"https://github.com/dotnet/coreclr/pull/20438","diff_url":"https://github.com/dotnet/coreclr/pull/20438.diff","patch_url":"https://github.com/dotnet/coreclr/pull/20438.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/20438","number":20438,"state":"open","locked":false,"title":"Fix collectible NativeCallable UMThunkEntry lifetime","user":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"The UMEntryThunk cache entries created for NativeCallable target methods\r\nfor collectible classes were not properly cleaned up at the unload time.\r\nThis change fixes that by adding UMEntryThunkCache on LoaderAllocator\r\nand using it for entries belonging to NativeCallable targets on\r\ncollectible classes. The cache is created lazily.","created_at":"2018-10-16T16:05:05Z","updated_at":"2018-10-17T15:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad5a1de34624cade3a9a5d4cbe1118095822b7a3","assignee":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"assignees":[{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":275722914,"node_id":"MDU6TGFiZWwyNzU3MjI5MTQ=","url":"https://api.github.com/repos/dotnet/coreclr/labels/area-VM","name":"area-VM","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/coreclr/milestones/18","html_url":"https://github.com/dotnet/coreclr/milestone/18","labels_url":"https://api.github.com/repos/dotnet/coreclr/milestones/18/labels","id":3246413,"node_id":"MDk6TWlsZXN0b25lMzI0NjQxMw==","number":18,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":218,"closed_issues":259,"state":"open","created_at":"2018-04-05T22:09:22Z","updated_at":"2018-10-17T00:10:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/20438/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/20438/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/20438/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/44e7590706d7c2f2c083de3884332dedd855e1f9","head":{"label":"janvorli:fix-native-callable-collectible","ref":"fix-native-callable-collectible","sha":"44e7590706d7c2f2c083de3884332dedd855e1f9","user":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"repo":{"id":30583176,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU4MzE3Ng==","name":"coreclr","full_name":"janvorli/coreclr","private":false,"owner":{"login":"janvorli","id":10758568,"node_id":"MDQ6VXNlcjEwNzU4NTY4","avatar_url":"https://avatars3.githubusercontent.com/u/10758568?v=4","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janvorli/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/janvorli/coreclr","forks_url":"https://api.github.com/repos/janvorli/coreclr/forks","keys_url":"https://api.github.com/repos/janvorli/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janvorli/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janvorli/coreclr/teams","hooks_url":"https://api.github.com/repos/janvorli/coreclr/hooks","issue_events_url":"https://api.github.com/repos/janvorli/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/janvorli/coreclr/events","assignees_url":"https://api.github.com/repos/janvorli/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/janvorli/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/janvorli/coreclr/tags","blobs_url":"https://api.github.com/repos/janvorli/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janvorli/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janvorli/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/janvorli/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janvorli/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/janvorli/coreclr/languages","stargazers_url":"https://api.github.com/repos/janvorli/coreclr/stargazers","contributors_url":"https://api.github.com/repos/janvorli/coreclr/contributors","subscribers_url":"https://api.github.com/repos/janvorli/coreclr/subscribers","subscription_url":"https://api.github.com/repos/janvorli/coreclr/subscription","commits_url":"https://api.github.com/repos/janvorli/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/janvorli/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/janvorli/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/janvorli/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/janvorli/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/janvorli/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janvorli/coreclr/merges","archive_url":"https://api.github.com/repos/janvorli/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janvorli/coreclr/downloads","issues_url":"https://api.github.com/repos/janvorli/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/janvorli/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/janvorli/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/janvorli/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janvorli/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/janvorli/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/janvorli/coreclr/deployments","created_at":"2015-02-10T08:49:34Z","updated_at":"2018-10-09T16:01:27Z","pushed_at":"2018-10-17T14:58:26Z","git_url":"git://github.com/janvorli/coreclr.git","ssh_url":"git@github.com:janvorli/coreclr.git","clone_url":"https://github.com/janvorli/coreclr.git","svn_url":"https://github.com/janvorli/coreclr","homepage":"","size":244683,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"142e77d60e60442b6f31fcea0f06e0c904140337","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-10-17T14:31:12Z","pushed_at":"2018-10-17T14:30:56Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":246778,"stargazers_count":10207,"watchers_count":10207,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2472,"mirror_url":null,"archived":false,"open_issues_count":1949,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2472,"open_issues":1949,"watchers":10207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20438"},"html":{"href":"https://github.com/dotnet/coreclr/pull/20438"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/20438"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/20438/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20438/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20438/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/44e7590706d7c2f2c083de3884332dedd855e1f9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotas"}}