{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/209376365","pull_request_review_id":145387762,"id":209376365,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM3NjM2NQ==","diff_hunk":"@@ -201,40 +233,50 @@ func (o *AppJSONOptions) Run() error {\n \t\treturn err\n \t}\n \n-\ttemplate.ObjectLabels = map[string]string{\"app.json\": template.Name}\n-\n-\t// all the types generated into the template should be known\n-\tif errs := app.AsVersionedObjects(template.Objects, legacyscheme.Scheme, legacyscheme.Scheme, o.OutputVersions...); len(errs) > 0 {\n-\t\tfor _, err := range errs {\n-\t\t\tfmt.Fprintf(o.bulkAction.ErrOut, \"error: %v\\n\", err)\n-\t\t}\n+\texternalTemplate := &templatev1.Template{}","path":"pkg/oc/cli/importer/appjson/appjson.go","position":172,"original_position":172,"commit_id":"09ccd3ce4dfb473e4eb715799289fb309dd13d4b","original_commit_id":"4d8ea2ae6fa209662c0f339db30913116d352ff6","user":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"The generator depends on a lot of [oc/lib/newapp/app helpers](https://github.com/openshift/origin/blob/master/pkg/oc/lib/newapp/appjson/appjson.go#L173).\r\n\r\nWe should switch those to use external versions (and all their callers) first","created_at":"2018-08-10T20:28:13Z","updated_at":"2018-08-10T20:28:13Z","html_url":"https://github.com/openshift/origin/pull/20567#discussion_r209376365","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/20567","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/209376365"},"html":{"href":"https://github.com/openshift/origin/pull/20567#discussion_r209376365"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/20567"}},"in_reply_to_id":209287671},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20567","id":206822146,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODIyMTQ2","html_url":"https://github.com/openshift/origin/pull/20567","diff_url":"https://github.com/openshift/origin/pull/20567.diff","patch_url":"https://github.com/openshift/origin/pull/20567.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/20567","number":20567,"state":"open","locked":false,"title":"switch more commands to external versions","user":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"cc @deads2k @soltysh \r\n\r\n~~Work in progress...~~","created_at":"2018-08-07T20:47:46Z","updated_at":"2018-08-10T20:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3a66033bcd04e1b7c152c6716a59477383dcb2f","assignee":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"enj","id":7001223,"node_id":"MDQ6VXNlcjcwMDEyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":640548394,"node_id":"MDU6TGFiZWw2NDA1NDgzOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/20567/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/20567/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20567/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/09ccd3ce4dfb473e4eb715799289fb309dd13d4b","head":{"label":"juanvallejo:jvallejo/switch-more-cmds-externals","ref":"jvallejo/switch-more-cmds-externals","sha":"09ccd3ce4dfb473e4eb715799289fb309dd13d4b","user":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":50698131,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY5ODEzMQ==","name":"origin","full_name":"juanvallejo/origin","owner":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/juanvallejo/origin","forks_url":"https://api.github.com/repos/juanvallejo/origin/forks","keys_url":"https://api.github.com/repos/juanvallejo/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/origin/teams","hooks_url":"https://api.github.com/repos/juanvallejo/origin/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/origin/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/origin/events","assignees_url":"https://api.github.com/repos/juanvallejo/origin/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/origin/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/origin/tags","blobs_url":"https://api.github.com/repos/juanvallejo/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/origin/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/origin/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/origin/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/origin/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/origin/subscription","commits_url":"https://api.github.com/repos/juanvallejo/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/origin/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/origin/merges","archive_url":"https://api.github.com/repos/juanvallejo/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/origin/downloads","issues_url":"https://api.github.com/repos/juanvallejo/origin/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/origin/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/origin/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/origin/deployments","created_at":"2016-01-29T23:22:53Z","updated_at":"2018-07-06T21:16:47Z","pushed_at":"2018-08-10T20:20:19Z","git_url":"git://github.com/juanvallejo/origin.git","ssh_url":"git@github.com:juanvallejo/origin.git","clone_url":"https://github.com/juanvallejo/origin.git","svn_url":"https://github.com/juanvallejo/origin","homepage":"http://www.openshift.org","size":923641,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"48a1596095f86680652eabcbbe5b6bc32357fe98","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-08-10T20:18:10Z","pushed_at":"2018-08-10T20:26:47Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":973763,"stargazers_count":4912,"watchers_count":4912,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3033,"mirror_url":null,"archived":false,"open_issues_count":609,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3033,"open_issues":609,"watchers":4912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/20567"},"html":{"href":"https://github.com/openshift/origin/pull/20567"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/20567"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/20567/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/20567/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/20567/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/09ccd3ce4dfb473e4eb715799289fb309dd13d4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"juanvallejo"}}