{"action":"created","comment":{"url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/comments/167407642","pull_request_review_id":95630118,"id":167407642,"diff_hunk":"@@ -95,15 +103,16 @@ task CollectDuplicationMetrics {\n        METRICS_FILE=\"${output_filename}.duplicate_metrics.txt\" \\\n        REMOVE_DUPLICATES=false\n   }\n+\n   runtime {","path":"library/tasks/Picard.wdl","position":72,"original_position":72,"commit_id":"a59a720ee8207d4fc92612059f55969ac9130266","original_commit_id":"df1d4886f3275f1103ae8f91d512ddc195856225","user":{"login":"ambrosejcarr","id":5239152,"avatar_url":"https://avatars1.githubusercontent.com/u/5239152?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrosejcarr","html_url":"https://github.com/ambrosejcarr","followers_url":"https://api.github.com/users/ambrosejcarr/followers","following_url":"https://api.github.com/users/ambrosejcarr/following{/other_user}","gists_url":"https://api.github.com/users/ambrosejcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrosejcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrosejcarr/subscriptions","organizations_url":"https://api.github.com/users/ambrosejcarr/orgs","repos_url":"https://api.github.com/users/ambrosejcarr/repos","events_url":"https://api.github.com/users/ambrosejcarr/events{/privacy}","received_events_url":"https://api.github.com/users/ambrosejcarr/received_events","type":"User","site_admin":false},"body":"I guess I'm thinking about this in terms of dependencies. You put inputs first because it tells you what data and information you have access to. In the same way, I'd argue that runtime comes next because you want to know how much ram/cpu/disk resource you're able to consume before you see the actual command that gets run. \r\n\r\nThen, once you've run something, output comes last. \r\n\r\n","created_at":"2018-02-10T18:50:27Z","updated_at":"2018-02-10T18:50:27Z","html_url":"https://github.com/HumanCellAtlas/skylab/pull/77#discussion_r167407642","pull_request_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/comments/167407642"},"html":{"href":"https://github.com/HumanCellAtlas/skylab/pull/77#discussion_r167407642"},"pull_request":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77"}},"in_reply_to_id":167278705},"pull_request":{"url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77","id":166847902,"html_url":"https://github.com/HumanCellAtlas/skylab/pull/77","diff_url":"https://github.com/HumanCellAtlas/skylab/pull/77.diff","patch_url":"https://github.com/HumanCellAtlas/skylab/pull/77.patch","issue_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/77","number":77,"state":"open","locked":false,"title":"[Do Not Merge] First stab at a Mint wdl style'ish guide...ish","user":{"login":"jsotobroad","id":13023616,"avatar_url":"https://avatars0.githubusercontent.com/u/13023616?v=4","gravatar_id":"","url":"https://api.github.com/users/jsotobroad","html_url":"https://github.com/jsotobroad","followers_url":"https://api.github.com/users/jsotobroad/followers","following_url":"https://api.github.com/users/jsotobroad/following{/other_user}","gists_url":"https://api.github.com/users/jsotobroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jsotobroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsotobroad/subscriptions","organizations_url":"https://api.github.com/users/jsotobroad/orgs","repos_url":"https://api.github.com/users/jsotobroad/repos","events_url":"https://api.github.com/users/jsotobroad/events{/privacy}","received_events_url":"https://api.github.com/users/jsotobroad/received_events","type":"User","site_admin":false},"body":"I wanted to try to take a stab at what kind of style guide the team might want to follow for our wdls.\r\nI've put most of my suggestions in `SS2SingleSample.wdl` but you can find anything I've added by looking for the pattern`## **`.  I've stated some things and have also asked a few questions about things I am not sure about but comments on anything would be really awesome and I fully expect for whats written here to change quite a bit.\r\n\r\nI also took the styles I wrote up (totally biased on how I like to write my wdls) and applied them to the SS2 workflow as a whole in this PR as well so at least we could get an idea of what they look like.\r\n\r\nI don't plan on merging this in ever but it might be a good first step in figuring out what we want to make our WDLs look like and then we can go back and apply those guidelines to already written WDLs and future WDLs.\r\n\r\nThis will also be good feedback for the WDL team as I know they are looking to work on a wdl style/possibly linter in the near future.","created_at":"2018-02-02T16:38:37Z","updated_at":"2018-02-10T18:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74fdd30d704ad71f5a6c5451d34bcbd3c808a934","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77/commits","review_comments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77/comments","review_comment_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/77/comments","statuses_url":"https://api.github.com/repos/HumanCellAtlas/skylab/statuses/a59a720ee8207d4fc92612059f55969ac9130266","head":{"label":"HumanCellAtlas:js-style-guide","ref":"js-style-guide","sha":"a59a720ee8207d4fc92612059f55969ac9130266","user":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":99818644,"name":"skylab","full_name":"HumanCellAtlas/skylab","owner":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HumanCellAtlas/skylab","description":"Secondary analysis pipelines","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/skylab","forks_url":"https://api.github.com/repos/HumanCellAtlas/skylab/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/skylab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/skylab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/skylab/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/skylab/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/skylab/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/skylab/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/skylab/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/skylab/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/skylab/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/skylab/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/skylab/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/skylab/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/skylab/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/skylab/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/skylab/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/skylab/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/skylab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/skylab/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/skylab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/skylab/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/skylab/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/skylab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/skylab/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/skylab/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/deployments","created_at":"2017-08-09T14:38:00Z","updated_at":"2018-02-09T16:52:01Z","pushed_at":"2018-02-10T18:21:48Z","git_url":"git://github.com/HumanCellAtlas/skylab.git","ssh_url":"git@github.com:HumanCellAtlas/skylab.git","clone_url":"https://github.com/HumanCellAtlas/skylab.git","svn_url":"https://github.com/HumanCellAtlas/skylab","homepage":null,"size":9062,"stargazers_count":5,"watchers_count":5,"language":"wdl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"HumanCellAtlas:master","ref":"master","sha":"71019e8cdeef4dfcc421a332faa5057525c5eeee","user":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":99818644,"name":"skylab","full_name":"HumanCellAtlas/skylab","owner":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HumanCellAtlas/skylab","description":"Secondary analysis pipelines","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/skylab","forks_url":"https://api.github.com/repos/HumanCellAtlas/skylab/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/skylab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/skylab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/skylab/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/skylab/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/skylab/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/skylab/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/skylab/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/skylab/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/skylab/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/skylab/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/skylab/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/skylab/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/skylab/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/skylab/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/skylab/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/skylab/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/skylab/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/skylab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/skylab/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/skylab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/skylab/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/skylab/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/skylab/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/skylab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/skylab/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/skylab/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/skylab/deployments","created_at":"2017-08-09T14:38:00Z","updated_at":"2018-02-09T16:52:01Z","pushed_at":"2018-02-10T18:21:48Z","git_url":"git://github.com/HumanCellAtlas/skylab.git","ssh_url":"git@github.com:HumanCellAtlas/skylab.git","clone_url":"https://github.com/HumanCellAtlas/skylab.git","svn_url":"https://github.com/HumanCellAtlas/skylab","homepage":null,"size":9062,"stargazers_count":5,"watchers_count":5,"language":"wdl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":3,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77"},"html":{"href":"https://github.com/HumanCellAtlas/skylab/pull/77"},"issue":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/77"},"comments":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/HumanCellAtlas/skylab/statuses/a59a720ee8207d4fc92612059f55969ac9130266"}},"author_association":"NONE"}}
{"actor":{"display_login":"ambrosejcarr"}}