{"action":"created","comment":{"url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/comments/244229533","pull_request_review_id":188181645,"id":244229533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDIyOTUzMw==","diff_hunk":"@@ -744,8 +745,11 @@ static void esp_mqtt_task(void *pv)\n                     client->state = MQTT_STATE_INIT;\n                     client->reconnect_tick = platform_tick_get_ms();\n                     ESP_LOGD(TAG, \"Reconnecting...\");\n+                    break;\n                 }\n-                vTaskDelay(client->wait_timeout_ms / 2 / portTICK_RATE_MS);\n+                xEventGroupClearBits(client->status_bits, RECONNECT_BIT);","path":"mqtt_client.c","position":15,"original_position":15,"commit_id":"6ee7f9193c26c11d4bb538c2ae2cefdcd23effc8","original_commit_id":"6ee7f9193c26c11d4bb538c2ae2cefdcd23effc8","user":{"login":"kanstrup","id":3457363,"node_id":"MDQ6VXNlcjM0NTczNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3457363?v=4","gravatar_id":"","url":"https://api.github.com/users/kanstrup","html_url":"https://github.com/kanstrup","followers_url":"https://api.github.com/users/kanstrup/followers","following_url":"https://api.github.com/users/kanstrup/following{/other_user}","gists_url":"https://api.github.com/users/kanstrup/gists{/gist_id}","starred_url":"https://api.github.com/users/kanstrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanstrup/subscriptions","organizations_url":"https://api.github.com/users/kanstrup/orgs","repos_url":"https://api.github.com/users/kanstrup/repos","events_url":"https://api.github.com/users/kanstrup/events{/privacy}","received_events_url":"https://api.github.com/users/kanstrup/received_events","type":"User","site_admin":false},"body":"Indeed clearing RECONNECT_BIT here looks fishy. I've been running with this patch applied locally for quite some time so can't remember why I decided to clear it here. I think I just needed the bit to be cleared somewhere for subsequent reconnects to function properly.\r\n\r\nAgree that it makes more sense to put it under MQTT_STATE_INIT instead. Will upload an updated version shortly.","created_at":"2018-12-27T21:40:31Z","updated_at":"2018-12-27T21:40:32Z","html_url":"https://github.com/espressif/esp-mqtt/pull/83#discussion_r244229533","pull_request_url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/comments/244229533"},"html":{"href":"https://github.com/espressif/esp-mqtt/pull/83#discussion_r244229533"},"pull_request":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83"}},"in_reply_to_id":243773720},"pull_request":{"url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83","id":225667060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjY3MDYw","html_url":"https://github.com/espressif/esp-mqtt/pull/83","diff_url":"https://github.com/espressif/esp-mqtt/pull/83.diff","patch_url":"https://github.com/espressif/esp-mqtt/pull/83.patch","issue_url":"https://api.github.com/repos/espressif/esp-mqtt/issues/83","number":83,"state":"open","locked":false,"title":"mqtt reconnect improvements","user":{"login":"kanstrup","id":3457363,"node_id":"MDQ6VXNlcjM0NTczNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3457363?v=4","gravatar_id":"","url":"https://api.github.com/users/kanstrup","html_url":"https://github.com/kanstrup","followers_url":"https://api.github.com/users/kanstrup/followers","following_url":"https://api.github.com/users/kanstrup/following{/other_user}","gists_url":"https://api.github.com/users/kanstrup/gists{/gist_id}","starred_url":"https://api.github.com/users/kanstrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanstrup/subscriptions","organizations_url":"https://api.github.com/users/kanstrup/orgs","repos_url":"https://api.github.com/users/kanstrup/repos","events_url":"https://api.github.com/users/kanstrup/events{/privacy}","received_events_url":"https://api.github.com/users/kanstrup/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-25T08:30:52Z","updated_at":"2018-12-27T21:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab9bdb04be58d418bb0a50e3bd765bf37edec346","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83/commits","review_comments_url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83/comments","review_comment_url":"https://api.github.com/repos/espressif/esp-mqtt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressif/esp-mqtt/issues/83/comments","statuses_url":"https://api.github.com/repos/espressif/esp-mqtt/statuses/6ee7f9193c26c11d4bb538c2ae2cefdcd23effc8","head":{"label":"kanstrup:idf","ref":"idf","sha":"6ee7f9193c26c11d4bb538c2ae2cefdcd23effc8","user":{"login":"kanstrup","id":3457363,"node_id":"MDQ6VXNlcjM0NTczNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3457363?v=4","gravatar_id":"","url":"https://api.github.com/users/kanstrup","html_url":"https://github.com/kanstrup","followers_url":"https://api.github.com/users/kanstrup/followers","following_url":"https://api.github.com/users/kanstrup/following{/other_user}","gists_url":"https://api.github.com/users/kanstrup/gists{/gist_id}","starred_url":"https://api.github.com/users/kanstrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanstrup/subscriptions","organizations_url":"https://api.github.com/users/kanstrup/orgs","repos_url":"https://api.github.com/users/kanstrup/repos","events_url":"https://api.github.com/users/kanstrup/events{/privacy}","received_events_url":"https://api.github.com/users/kanstrup/received_events","type":"User","site_admin":false},"repo":{"id":154471915,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0NzE5MTU=","name":"esp-mqtt","full_name":"kanstrup/esp-mqtt","private":false,"owner":{"login":"kanstrup","id":3457363,"node_id":"MDQ6VXNlcjM0NTczNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3457363?v=4","gravatar_id":"","url":"https://api.github.com/users/kanstrup","html_url":"https://github.com/kanstrup","followers_url":"https://api.github.com/users/kanstrup/followers","following_url":"https://api.github.com/users/kanstrup/following{/other_user}","gists_url":"https://api.github.com/users/kanstrup/gists{/gist_id}","starred_url":"https://api.github.com/users/kanstrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanstrup/subscriptions","organizations_url":"https://api.github.com/users/kanstrup/orgs","repos_url":"https://api.github.com/users/kanstrup/repos","events_url":"https://api.github.com/users/kanstrup/events{/privacy}","received_events_url":"https://api.github.com/users/kanstrup/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kanstrup/esp-mqtt","description":"ESP32 mqtt component","fork":true,"url":"https://api.github.com/repos/kanstrup/esp-mqtt","forks_url":"https://api.github.com/repos/kanstrup/esp-mqtt/forks","keys_url":"https://api.github.com/repos/kanstrup/esp-mqtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanstrup/esp-mqtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanstrup/esp-mqtt/teams","hooks_url":"https://api.github.com/repos/kanstrup/esp-mqtt/hooks","issue_events_url":"https://api.github.com/repos/kanstrup/esp-mqtt/issues/events{/number}","events_url":"https://api.github.com/repos/kanstrup/esp-mqtt/events","assignees_url":"https://api.github.com/repos/kanstrup/esp-mqtt/assignees{/user}","branches_url":"https://api.github.com/repos/kanstrup/esp-mqtt/branches{/branch}","tags_url":"https://api.github.com/repos/kanstrup/esp-mqtt/tags","blobs_url":"https://api.github.com/repos/kanstrup/esp-mqtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanstrup/esp-mqtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanstrup/esp-mqtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanstrup/esp-mqtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanstrup/esp-mqtt/statuses/{sha}","languages_url":"https://api.github.com/repos/kanstrup/esp-mqtt/languages","stargazers_url":"https://api.github.com/repos/kanstrup/esp-mqtt/stargazers","contributors_url":"https://api.github.com/repos/kanstrup/esp-mqtt/contributors","subscribers_url":"https://api.github.com/repos/kanstrup/esp-mqtt/subscribers","subscription_url":"https://api.github.com/repos/kanstrup/esp-mqtt/subscription","commits_url":"https://api.github.com/repos/kanstrup/esp-mqtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanstrup/esp-mqtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanstrup/esp-mqtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanstrup/esp-mqtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanstrup/esp-mqtt/contents/{+path}","compare_url":"https://api.github.com/repos/kanstrup/esp-mqtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanstrup/esp-mqtt/merges","archive_url":"https://api.github.com/repos/kanstrup/esp-mqtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanstrup/esp-mqtt/downloads","issues_url":"https://api.github.com/repos/kanstrup/esp-mqtt/issues{/number}","pulls_url":"https://api.github.com/repos/kanstrup/esp-mqtt/pulls{/number}","milestones_url":"https://api.github.com/repos/kanstrup/esp-mqtt/milestones{/number}","notifications_url":"https://api.github.com/repos/kanstrup/esp-mqtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanstrup/esp-mqtt/labels{/name}","releases_url":"https://api.github.com/repos/kanstrup/esp-mqtt/releases{/id}","deployments_url":"https://api.github.com/repos/kanstrup/esp-mqtt/deployments","created_at":"2018-10-24T09:10:37Z","updated_at":"2018-10-24T09:10:39Z","pushed_at":"2018-10-25T08:28:46Z","git_url":"git://github.com/kanstrup/esp-mqtt.git","ssh_url":"git@github.com:kanstrup/esp-mqtt.git","clone_url":"https://github.com/kanstrup/esp-mqtt.git","svn_url":"https://github.com/kanstrup/esp-mqtt","homepage":"","size":1347,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressif:idf","ref":"idf","sha":"52cb6980b003b1b9901a7f3ede5116da92c4de82","user":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"repo":{"id":67817197,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgxNzE5Nw==","name":"esp-mqtt","full_name":"espressif/esp-mqtt","private":false,"owner":{"login":"espressif","id":9460735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NjA3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espressif/esp-mqtt","description":"ESP32 mqtt component","fork":false,"url":"https://api.github.com/repos/espressif/esp-mqtt","forks_url":"https://api.github.com/repos/espressif/esp-mqtt/forks","keys_url":"https://api.github.com/repos/espressif/esp-mqtt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressif/esp-mqtt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressif/esp-mqtt/teams","hooks_url":"https://api.github.com/repos/espressif/esp-mqtt/hooks","issue_events_url":"https://api.github.com/repos/espressif/esp-mqtt/issues/events{/number}","events_url":"https://api.github.com/repos/espressif/esp-mqtt/events","assignees_url":"https://api.github.com/repos/espressif/esp-mqtt/assignees{/user}","branches_url":"https://api.github.com/repos/espressif/esp-mqtt/branches{/branch}","tags_url":"https://api.github.com/repos/espressif/esp-mqtt/tags","blobs_url":"https://api.github.com/repos/espressif/esp-mqtt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressif/esp-mqtt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressif/esp-mqtt/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressif/esp-mqtt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressif/esp-mqtt/statuses/{sha}","languages_url":"https://api.github.com/repos/espressif/esp-mqtt/languages","stargazers_url":"https://api.github.com/repos/espressif/esp-mqtt/stargazers","contributors_url":"https://api.github.com/repos/espressif/esp-mqtt/contributors","subscribers_url":"https://api.github.com/repos/espressif/esp-mqtt/subscribers","subscription_url":"https://api.github.com/repos/espressif/esp-mqtt/subscription","commits_url":"https://api.github.com/repos/espressif/esp-mqtt/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressif/esp-mqtt/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressif/esp-mqtt/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressif/esp-mqtt/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressif/esp-mqtt/contents/{+path}","compare_url":"https://api.github.com/repos/espressif/esp-mqtt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressif/esp-mqtt/merges","archive_url":"https://api.github.com/repos/espressif/esp-mqtt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressif/esp-mqtt/downloads","issues_url":"https://api.github.com/repos/espressif/esp-mqtt/issues{/number}","pulls_url":"https://api.github.com/repos/espressif/esp-mqtt/pulls{/number}","milestones_url":"https://api.github.com/repos/espressif/esp-mqtt/milestones{/number}","notifications_url":"https://api.github.com/repos/espressif/esp-mqtt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressif/esp-mqtt/labels{/name}","releases_url":"https://api.github.com/repos/espressif/esp-mqtt/releases{/id}","deployments_url":"https://api.github.com/repos/espressif/esp-mqtt/deployments","created_at":"2016-09-09T17:06:21Z","updated_at":"2018-12-25T08:23:41Z","pushed_at":"2018-12-04T14:30:59Z","git_url":"git://github.com/espressif/esp-mqtt.git","ssh_url":"git@github.com:espressif/esp-mqtt.git","clone_url":"https://github.com/espressif/esp-mqtt.git","svn_url":"https://github.com/espressif/esp-mqtt","homepage":"","size":1342,"stargazers_count":200,"watchers_count":200,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":114,"open_issues":27,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83"},"html":{"href":"https://github.com/espressif/esp-mqtt/pull/83"},"issue":{"href":"https://api.github.com/repos/espressif/esp-mqtt/issues/83"},"comments":{"href":"https://api.github.com/repos/espressif/esp-mqtt/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressif/esp-mqtt/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/espressif/esp-mqtt/statuses/6ee7f9193c26c11d4bb538c2ae2cefdcd23effc8"}},"author_association":"NONE"}}
{"actor":{"display_login":"kanstrup"}}