{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1902","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1902/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1902/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1902/events","html_url":"https://github.com/shopware/shopware/pull/1902","id":385635527,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTU4NDg2","number":1902,"title":"Fixed missing attributes in sORDER mail","user":{"login":"FiveDigital","id":2051198,"node_id":"MDQ6VXNlcjIwNTExOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2051198?v=4","gravatar_id":"","url":"https://api.github.com/users/FiveDigital","html_url":"https://github.com/FiveDigital","followers_url":"https://api.github.com/users/FiveDigital/followers","following_url":"https://api.github.com/users/FiveDigital/following{/other_user}","gists_url":"https://api.github.com/users/FiveDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/FiveDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiveDigital/subscriptions","organizations_url":"https://api.github.com/users/FiveDigital/orgs","repos_url":"https://api.github.com/users/FiveDigital/repos","events_url":"https://api.github.com/users/FiveDigital/events{/privacy}","received_events_url":"https://api.github.com/users/FiveDigital/received_events","type":"User","site_admin":false},"labels":[{"id":571966309,"node_id":"MDU6TGFiZWw1NzE5NjYzMDk=","url":"https://api.github.com/repos/shopware/shopware/labels/Incomplete","name":"Incomplete","color":"cccccc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-29T09:10:17Z","updated_at":"2018-12-03T08:31:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1902","html_url":"https://github.com/shopware/shopware/pull/1902","diff_url":"https://github.com/shopware/shopware/pull/1902.diff","patch_url":"https://github.com/shopware/shopware/pull/1902.patch"},"body":"### 1. Why is this change necessary?\r\nThis is a re-implementation of my initial approach in #1616 that broke after commit ece4a0798cab956e551829b52f0ca3413b99dab8. \r\n\r\nWithout this fix the variables `{$billingaddress.attributes}` and `{$shippingaddress.attributes}` are always null because `html_entity_decode([])` returns `null`.\r\n\r\n### 2. What does this change do, exactly?\r\nRecursively `apply html_entity_decode()` to the passed data.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\nPlace an order in the frontend. After that, look at the variables for the sORDER mail.\r\n\r\n\r\n### 4. Please link to the relevant issues (if any).\r\nNo\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nNone\r\n\r\n### 6. Checklist\r\n\r\n- [X] I have written tests and verified that they fail without my change\r\n- [X] I have squashed any insignificant commits\r\n- [X] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [X] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/443628347","html_url":"https://github.com/shopware/shopware/pull/1902#issuecomment-443628347","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1902","id":443628347,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzYyODM0Nw==","user":{"login":"FiveDigital","id":2051198,"node_id":"MDQ6VXNlcjIwNTExOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2051198?v=4","gravatar_id":"","url":"https://api.github.com/users/FiveDigital","html_url":"https://github.com/FiveDigital","followers_url":"https://api.github.com/users/FiveDigital/followers","following_url":"https://api.github.com/users/FiveDigital/following{/other_user}","gists_url":"https://api.github.com/users/FiveDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/FiveDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiveDigital/subscriptions","organizations_url":"https://api.github.com/users/FiveDigital/orgs","repos_url":"https://api.github.com/users/FiveDigital/repos","events_url":"https://api.github.com/users/FiveDigital/events{/privacy}","received_events_url":"https://api.github.com/users/FiveDigital/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T08:31:25Z","updated_at":"2018-12-03T08:31:25Z","author_association":"CONTRIBUTOR","body":"```\r\ngit rebase upstream/5.5\r\nCurrent branch fix-sorder-mail-attributes is up to date.\r\n```\r\n\r\n🤷‍♂️ "}}
{"actor":{"display_login":"FiveDigital"}}