{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/6785","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/6785/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/6785/comments","events_url":"https://api.github.com/repos/apache/flink/issues/6785/events","html_url":"https://github.com/apache/flink/pull/6785","id":365844062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjYyNTI3","number":6785,"title":"[FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations","user":{"login":"GJL","id":1681921,"node_id":"MDQ6VXNlcjE2ODE5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"assignees":[{"login":"zentol","id":5725237,"node_id":"MDQ6VXNlcjU3MjUyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5725237?v=4","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-10-02T10:56:19Z","updated_at":"2018-10-18T16:39:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6785","html_url":"https://github.com/apache/flink/pull/6785","diff_url":"https://github.com/apache/flink/pull/6785.diff","patch_url":"https://github.com/apache/flink/pull/6785.patch"},"body":"## What is the purpose of the change\r\n\r\n*Wait for the result of asynchronous operations to be served before shutting down the cluster.  This is necessary for the _\"cancel with savepoint\"_ operation. If we do not wait for the result to be accessed by the client, we may shutdown the cluster, and the client gets a `ConnectionException`.*\r\n\r\ncc: @zentol @tillrohrmann \r\n\r\n## Brief change log\r\n\r\n  - *Before shutting down cluster, wait for asynchronous operations.*\r\n  - *Log stacktrace if checkpoint cannot be ack'ed.*\r\n\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - *Added test to `RestServerEndpointITCase` to verify that handlers are closed first.*\r\n  - *Added unit tests for `CompletedOperationCache`.*\r\n  - *Verified the changes by submitting and cancelling with savepoint of a job in a loop.*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n  - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/431078873","html_url":"https://github.com/apache/flink/pull/6785#issuecomment-431078873","issue_url":"https://api.github.com/repos/apache/flink/issues/6785","id":431078873,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTA3ODg3Mw==","user":{"login":"GJL","id":1681921,"node_id":"MDQ6VXNlcjE2ODE5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T16:39:01Z","updated_at":"2018-10-18T16:39:01Z","author_association":"MEMBER","body":"@zentol Thanks for reviewing. I will keep the refactoring in a separate commit."}}
{"actor":{"display_login":"GJL"}}