{"action":"created","issue":{"url":"https://api.github.com/repos/camchenry/sock.lua/issues/13","repository_url":"https://api.github.com/repos/camchenry/sock.lua","labels_url":"https://api.github.com/repos/camchenry/sock.lua/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/camchenry/sock.lua/issues/13/comments","events_url":"https://api.github.com/repos/camchenry/sock.lua/issues/13/events","html_url":"https://github.com/camchenry/sock.lua/issues/13","id":344282496,"node_id":"MDU6SXNzdWUzNDQyODI0OTY=","number":13,"title":"can you add a Client:sendToAll(event, data) and Client:sendToAllBut(client, event, data)","user":{"login":"Shadowblitz16","id":2453707,"node_id":"MDQ6VXNlcjI0NTM3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2453707?v=4","gravatar_id":"","url":"https://api.github.com/users/Shadowblitz16","html_url":"https://github.com/Shadowblitz16","followers_url":"https://api.github.com/users/Shadowblitz16/followers","following_url":"https://api.github.com/users/Shadowblitz16/following{/other_user}","gists_url":"https://api.github.com/users/Shadowblitz16/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowblitz16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowblitz16/subscriptions","organizations_url":"https://api.github.com/users/Shadowblitz16/orgs","repos_url":"https://api.github.com/users/Shadowblitz16/repos","events_url":"https://api.github.com/users/Shadowblitz16/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowblitz16/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-25T03:50:03Z","updated_at":"2018-08-01T19:44:35Z","closed_at":null,"author_association":"NONE","body":"can you add the following to make networking a bit easier \r\nClient:sendToAll(event, data) <-- sends to all clients on the server\r\nClient:sendToAllBut(client, event, data) <- sends to all clients on the server but the specified one"},"comment":{"url":"https://api.github.com/repos/camchenry/sock.lua/issues/comments/409697974","html_url":"https://github.com/camchenry/sock.lua/issues/13#issuecomment-409697974","issue_url":"https://api.github.com/repos/camchenry/sock.lua/issues/13","id":409697974,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTY5Nzk3NA==","user":{"login":"camchenry","id":1514176,"node_id":"MDQ6VXNlcjE1MTQxNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1514176?v=4","gravatar_id":"","url":"https://api.github.com/users/camchenry","html_url":"https://github.com/camchenry","followers_url":"https://api.github.com/users/camchenry/followers","following_url":"https://api.github.com/users/camchenry/following{/other_user}","gists_url":"https://api.github.com/users/camchenry/gists{/gist_id}","starred_url":"https://api.github.com/users/camchenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camchenry/subscriptions","organizations_url":"https://api.github.com/users/camchenry/orgs","repos_url":"https://api.github.com/users/camchenry/repos","events_url":"https://api.github.com/users/camchenry/events{/privacy}","received_events_url":"https://api.github.com/users/camchenry/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T19:44:35Z","updated_at":"2018-08-01T19:44:35Z","author_association":"OWNER","body":"Hi, sorry for taking some time to respond.\r\n\r\nI do not think I will be adding these functions, and here's why. Adding these would introduce a lot of extra complexity and potentially new vulnerabilities to the library. You need to implement custom logic on the server that decides how/when to forward messages to other clients. If a client were allowed to send messages generically to all other clients, then it essentially acts like built-in DDoS capability. So, you would end up having to write logic to prevent that, unless sock.lua handled that for you, which would add a lot of unnecessary complexity.\r\n\r\nIf you could give some more information on what you writing and what issues you are having, I'd be glad to help you out. I hope this makes sense, thanks for submitting an issue."}}
{"actor":{"display_login":"camchenry"}}