{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/190059495","pull_request_review_id":122360759,"id":190059495,"diff_hunk":"@@ -143,7 +143,8 @@ func getAPIServerCommand(cfg *kubeadmapi.MasterConfiguration) []string {\n \tdefaultArguments := map[string]string{\n \t\t\"advertise-address\":               cfg.API.AdvertiseAddress,\n \t\t\"insecure-port\":                   \"0\",\n-\t\t\"admission-control\":               defaultAdmissionControl,","path":"cmd/kubeadm/app/phases/controlplane/manifests.go","position":4,"original_position":4,"commit_id":"3cad80a3d852c6aedf99a619f5e9b9021cd2ffaf","original_commit_id":"3cad80a3d852c6aedf99a619f5e9b9021cd2ffaf","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"body":"will do.","created_at":"2018-05-22T21:30:12Z","updated_at":"2018-05-22T21:30:12Z","html_url":"https://github.com/kubernetes/kubernetes/pull/64165#discussion_r190059495","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/190059495"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/64165#discussion_r190059495"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165"}},"in_reply_to_id":190051818},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165","id":189773139,"html_url":"https://github.com/kubernetes/kubernetes/pull/64165","diff_url":"https://github.com/kubernetes/kubernetes/pull/64165.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/64165.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64165","number":64165,"state":"open","locked":false,"title":"kubeadm: do not use --admission-control for the API server","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nThe API server argument --admission-control is deprecated.\r\nUse the following arguments instead:\r\n  --enable-admission-plugin=NodeRestriction\r\n  --disable-admission-plugin=PersistentVolumeLabel\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes kubernetes/kubeadm#840\r\n\r\n**Special notes for your reviewer**:\r\nNONE\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nkubeadm: when starting the API server use the arguments --enable-admission-plugin and --disable-admission-plugin instead of the deprecated --admission-control.\r\n```\r\n\r\n@luxas\r\n@kubernetes/sig-cluster-lifecycle-pr-reviews \r\n/area kubeadm\r\n","created_at":"2018-05-22T19:50:55Z","updated_at":"2018-05-22T21:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ef232696bb91319fadd69c16a7c2ca36e55fddf","assignee":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":451459590,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/64165/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3cad80a3d852c6aedf99a619f5e9b9021cd2ffaf","head":{"label":"neolit123:admission-control","ref":"admission-control","sha":"3cad80a3d852c6aedf99a619f5e9b9021cd2ffaf","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"repo":{"id":104209335,"name":"kubernetes","full_name":"neolit123/kubernetes","owner":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neolit123/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/neolit123/kubernetes","forks_url":"https://api.github.com/repos/neolit123/kubernetes/forks","keys_url":"https://api.github.com/repos/neolit123/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neolit123/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neolit123/kubernetes/teams","hooks_url":"https://api.github.com/repos/neolit123/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/neolit123/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/neolit123/kubernetes/events","assignees_url":"https://api.github.com/repos/neolit123/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/neolit123/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/neolit123/kubernetes/tags","blobs_url":"https://api.github.com/repos/neolit123/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neolit123/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neolit123/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/neolit123/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neolit123/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/neolit123/kubernetes/languages","stargazers_url":"https://api.github.com/repos/neolit123/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/neolit123/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/neolit123/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/neolit123/kubernetes/subscription","commits_url":"https://api.github.com/repos/neolit123/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/neolit123/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/neolit123/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/neolit123/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/neolit123/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/neolit123/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neolit123/kubernetes/merges","archive_url":"https://api.github.com/repos/neolit123/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neolit123/kubernetes/downloads","issues_url":"https://api.github.com/repos/neolit123/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/neolit123/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/neolit123/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/neolit123/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neolit123/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/neolit123/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/neolit123/kubernetes/deployments","created_at":"2017-09-20T11:53:57Z","updated_at":"2017-09-20T11:54:40Z","pushed_at":"2018-05-22T19:45:24Z","git_url":"git://github.com/neolit123/kubernetes.git","ssh_url":"git@github.com:neolit123/kubernetes.git","clone_url":"https://github.com/neolit123/kubernetes.git","svn_url":"https://github.com/neolit123/kubernetes","homepage":"http://kubernetes.io","size":553186,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"10b8665a1c9dd5714b13130fcbf5c04f7f658178","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-22T21:01:16Z","pushed_at":"2018-05-22T21:19:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":779613,"stargazers_count":36633,"watchers_count":36633,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12888,"mirror_url":null,"archived":false,"open_issues_count":3256,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12888,"open_issues":3256,"watchers":36633,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/64165"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/64165"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/64165/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/64165/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3cad80a3d852c6aedf99a619f5e9b9021cd2ffaf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"neolit123"}}