{"action":"created","comment":{"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments/239020704","pull_request_review_id":181699572,"id":239020704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAyMDcwNA==","diff_hunk":"@@ -61,7 +61,7 @@ protected void paused(BaseDownloadTask baseDownloadTask, long soFarBytes, long t\n       Logger.getInstance()\n           .d(TAG, \" Download error\");\n       fileDownloadTaskStatus =\n-          new FileDownloadTaskStatus(AppDownloadStatus.AppDownloadState.ERROR, md5);\n+          new FileDownloadTaskStatus(AppDownloadStatus.AppDownloadState.ERROR, md5, null);","path":"app/src/main/java/cm/aptoide/pt/download/FileDownloadTask.java","position":null,"original_position":5,"commit_id":"f7731f1f76c7e4bfac34816dec84cb243dac6a48","original_commit_id":"b005e623bad2bc439efd70c0697056011af3a182","user":{"login":"phillipsgoncalves","id":14911637,"node_id":"MDQ6VXNlcjE0OTExNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/14911637?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipsgoncalves","html_url":"https://github.com/phillipsgoncalves","followers_url":"https://api.github.com/users/phillipsgoncalves/followers","following_url":"https://api.github.com/users/phillipsgoncalves/following{/other_user}","gists_url":"https://api.github.com/users/phillipsgoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipsgoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipsgoncalves/subscriptions","organizations_url":"https://api.github.com/users/phillipsgoncalves/orgs","repos_url":"https://api.github.com/users/phillipsgoncalves/repos","events_url":"https://api.github.com/users/phillipsgoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/phillipsgoncalves/received_events","type":"User","site_admin":false},"body":"With this, errors while trying to calculate the md5 will not be logged. ","created_at":"2018-12-05T11:02:10Z","updated_at":"2018-12-05T11:37:54Z","html_url":"https://github.com/Aptoide/aptoide-client-v8/pull/797#discussion_r239020704","pull_request_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments/239020704"},"html":{"href":"https://github.com/Aptoide/aptoide-client-v8/pull/797#discussion_r239020704"},"pull_request":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797"}}},"pull_request":{"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797","id":235844866,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1ODQ0ODY2","html_url":"https://github.com/Aptoide/aptoide-client-v8/pull/797","diff_url":"https://github.com/Aptoide/aptoide-client-v8/pull/797.diff","patch_url":"https://github.com/Aptoide/aptoide-client-v8/pull/797.patch","issue_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/797","number":797,"state":"open","locked":false,"title":"[ASV-1153] downloads metrics","user":{"login":"JDSM01","id":30080580,"node_id":"MDQ6VXNlcjMwMDgwNTgw","avatar_url":"https://avatars2.githubusercontent.com/u/30080580?v=4","gravatar_id":"","url":"https://api.github.com/users/JDSM01","html_url":"https://github.com/JDSM01","followers_url":"https://api.github.com/users/JDSM01/followers","following_url":"https://api.github.com/users/JDSM01/following{/other_user}","gists_url":"https://api.github.com/users/JDSM01/gists{/gist_id}","starred_url":"https://api.github.com/users/JDSM01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDSM01/subscriptions","organizations_url":"https://api.github.com/users/JDSM01/orgs","repos_url":"https://api.github.com/users/JDSM01/repos","events_url":"https://api.github.com/users/JDSM01/events{/privacy}","received_events_url":"https://api.github.com/users/JDSM01/received_events","type":"User","site_admin":false},"body":"**What does this PR do?**\r\n\r\n Adds the missing install complete event to facebook and flurry. Also adds the error event due to root that was missing since april 4th.\r\n \r\n**Database changed?**\r\n\r\nNo\r\n\r\n**Where should the reviewer start?**\r\n\r\n-InstallAnalytics.java\r\n\r\n**How should this be manually tested?**\r\n\r\nDo a download in a non-editorial app (app view and apps) and check if the application install was sent to facebook and flurry and if the INSTALL event was sent to the BI.\r\n \r\n**What are the relevant tickets?**\r\n\r\nhttps://aptoide.atlassian.net/browse/ASV-1153\r\n\r\n**Questions:**\r\n\r\n   Does this add new dependencies which need to be added? (Eg. new libs, new keys, etc.) \r\n\r\n\r\n\r\n\r\n**Code Review Checklist**\r\n\r\n- [ ] Architecture\r\n- [ ] Documentation on public interfaces\r\n- [ ] Database changed?\r\n- [ ] If yes - Database migration?\r\n- [ ] Remove comments & unused code & forgotten testing Logs\r\n- [ ] Codestyle\r\n- [ ] Partners build\r\n- [ ] Unit tests pass\r\n- [ ] Functional QA tests pass","created_at":"2018-12-04T15:11:36Z","updated_at":"2018-12-05T11:37:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8b1ceb971765086aa1d4aca1156c57f746190ad","assignee":{"login":"phillipsgoncalves","id":14911637,"node_id":"MDQ6VXNlcjE0OTExNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/14911637?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipsgoncalves","html_url":"https://github.com/phillipsgoncalves","followers_url":"https://api.github.com/users/phillipsgoncalves/followers","following_url":"https://api.github.com/users/phillipsgoncalves/following{/other_user}","gists_url":"https://api.github.com/users/phillipsgoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipsgoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipsgoncalves/subscriptions","organizations_url":"https://api.github.com/users/phillipsgoncalves/orgs","repos_url":"https://api.github.com/users/phillipsgoncalves/repos","events_url":"https://api.github.com/users/phillipsgoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/phillipsgoncalves/received_events","type":"User","site_admin":false},"assignees":[{"login":"phillipsgoncalves","id":14911637,"node_id":"MDQ6VXNlcjE0OTExNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/14911637?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipsgoncalves","html_url":"https://github.com/phillipsgoncalves","followers_url":"https://api.github.com/users/phillipsgoncalves/followers","following_url":"https://api.github.com/users/phillipsgoncalves/following{/other_user}","gists_url":"https://api.github.com/users/phillipsgoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipsgoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipsgoncalves/subscriptions","organizations_url":"https://api.github.com/users/phillipsgoncalves/orgs","repos_url":"https://api.github.com/users/phillipsgoncalves/repos","events_url":"https://api.github.com/users/phillipsgoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/phillipsgoncalves/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797/commits","review_comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797/comments","review_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/797/comments","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/f7731f1f76c7e4bfac34816dec84cb243dac6a48","head":{"label":"Aptoide:feature/ASV-1153_DownloadsMetrics","ref":"feature/ASV-1153_DownloadsMetrics","sha":"f7731f1f76c7e4bfac34816dec84cb243dac6a48","user":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"repo":{"id":56278667,"node_id":"MDEwOlJlcG9zaXRvcnk1NjI3ODY2Nw==","name":"aptoide-client-v8","full_name":"Aptoide/aptoide-client-v8","private":false,"owner":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Aptoide/aptoide-client-v8","description":"All the Apps you need. Discover your new Android App Store.","fork":false,"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8","forks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/forks","keys_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/teams","hooks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/hooks","issue_events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/events{/number}","events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/events","assignees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/assignees{/user}","branches_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/branches{/branch}","tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/tags","blobs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/{sha}","languages_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/languages","stargazers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/stargazers","contributors_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contributors","subscribers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscribers","subscription_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscription","commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contents/{+path}","compare_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/merges","archive_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/downloads","issues_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues{/number}","pulls_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls{/number}","milestones_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/milestones{/number}","notifications_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/labels{/name}","releases_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/releases{/id}","deployments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/deployments","created_at":"2016-04-15T00:32:20Z","updated_at":"2018-12-03T23:58:23Z","pushed_at":"2018-12-05T11:34:59Z","git_url":"git://github.com/Aptoide/aptoide-client-v8.git","ssh_url":"git@github.com:Aptoide/aptoide-client-v8.git","clone_url":"https://github.com/Aptoide/aptoide-client-v8.git","svn_url":"https://github.com/Aptoide/aptoide-client-v8","homepage":"http://en.aptoide.com","size":94632,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":7,"watchers":67,"default_branch":"master"}},"base":{"label":"Aptoide:feature/ASV-864_DownloadsRefactor","ref":"feature/ASV-864_DownloadsRefactor","sha":"37dc80a8a30bca180be6a0f6b6d921aca1403e55","user":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"repo":{"id":56278667,"node_id":"MDEwOlJlcG9zaXRvcnk1NjI3ODY2Nw==","name":"aptoide-client-v8","full_name":"Aptoide/aptoide-client-v8","private":false,"owner":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Aptoide/aptoide-client-v8","description":"All the Apps you need. Discover your new Android App Store.","fork":false,"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8","forks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/forks","keys_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/teams","hooks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/hooks","issue_events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/events{/number}","events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/events","assignees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/assignees{/user}","branches_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/branches{/branch}","tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/tags","blobs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/{sha}","languages_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/languages","stargazers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/stargazers","contributors_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contributors","subscribers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscribers","subscription_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscription","commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contents/{+path}","compare_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/merges","archive_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/downloads","issues_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues{/number}","pulls_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls{/number}","milestones_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/milestones{/number}","notifications_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/labels{/name}","releases_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/releases{/id}","deployments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/deployments","created_at":"2016-04-15T00:32:20Z","updated_at":"2018-12-03T23:58:23Z","pushed_at":"2018-12-05T11:34:59Z","git_url":"git://github.com/Aptoide/aptoide-client-v8.git","ssh_url":"git@github.com:Aptoide/aptoide-client-v8.git","clone_url":"https://github.com/Aptoide/aptoide-client-v8.git","svn_url":"https://github.com/Aptoide/aptoide-client-v8","homepage":"http://en.aptoide.com","size":94632,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":7,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797"},"html":{"href":"https://github.com/Aptoide/aptoide-client-v8/pull/797"},"issue":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/797"},"comments":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/f7731f1f76c7e4bfac34816dec84cb243dac6a48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"phillipsgoncalves"}}