{"action":"created","comment":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/235610132","pull_request_review_id":177511193,"id":235610132,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTYxMDEzMg==","diff_hunk":"@@ -0,0 +1,85 @@\n+package acceptance\n+\n+import (\n+\t\"bytes\"\n+\t\"context\"\n+\t\"github.com/orbs-network/orbs-network-go/test/builders\"\n+\t\"github.com/orbs-network/orbs-network-go/test/harness\"\n+\t\"github.com/orbs-network/orbs-spec/types/go/protocol\"\n+\t\"github.com/stretchr/testify/require\"\n+\t\"testing\"\n+\t\"time\"\n+)\n+\n+func TestSendSameTransactionMoreThanOnce1(t *testing.T) {\n+\tharness.Network(t).AllowingErrors(\n+\t\t\"error adding transaction to pending pool\",\n+\t\t\"error adding forwarded transaction to pending pool\",\n+\t\t\"error sending transaction\",\n+\t).Start(func(ctx context.Context, network harness.TestNetworkDriver) {\n+\t\tts := time.Now()\n+\n+\t\tcontract := network.GetBenchmarkTokenContract()\n+\t\tcontract.DeployBenchmarkToken(ctx, 1)\n+\n+\t\t// send three identical transactions to two nodes\n+\t\tnetwork.SendTransactionInBackground(ctx, builders.TransferTransaction().WithTimestamp(ts).Builder(), 0)\n+\t\tresponse0 := <- network.SendTransaction(ctx, builders.TransferTransaction().WithTimestamp(ts).Builder(), 1)\n+\t\tresponse1 := <- network.SendTransaction(ctx, builders.TransferTransaction().WithTimestamp(ts).Builder(), 1)\n+\n+\t\t// second transaction will be accepted into the pool and committed by the internode sync","path":"test/acceptance/duplicate_tx_test.go","position":30,"original_position":30,"commit_id":"a50788b15971b7c3a8ed4d0998ec67cff2446d15","original_commit_id":"a50788b15971b7c3a8ed4d0998ec67cff2446d15","user":{"login":"electricmonk","id":912517,"node_id":"MDQ6VXNlcjkxMjUxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/912517?v=4","gravatar_id":"","url":"https://api.github.com/users/electricmonk","html_url":"https://github.com/electricmonk","followers_url":"https://api.github.com/users/electricmonk/followers","following_url":"https://api.github.com/users/electricmonk/following{/other_user}","gists_url":"https://api.github.com/users/electricmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/electricmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electricmonk/subscriptions","organizations_url":"https://api.github.com/users/electricmonk/orgs","repos_url":"https://api.github.com/users/electricmonk/repos","events_url":"https://api.github.com/users/electricmonk/events{/privacy}","received_events_url":"https://api.github.com/users/electricmonk/received_events","type":"User","site_admin":false},"body":"instead of comments, add messages to the assertion so that if they fail, the message appears in the log: \"second transaction should be accepted into the pool and committed by the internode sync\"","created_at":"2018-11-22T06:06:47Z","updated_at":"2018-11-22T06:07:53Z","html_url":"https://github.com/orbs-network/orbs-network-go/pull/517#discussion_r235610132","pull_request_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/235610132"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/517#discussion_r235610132"},"pull_request":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517"}}},"pull_request":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517","id":232742871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzQyODcx","html_url":"https://github.com/orbs-network/orbs-network-go/pull/517","diff_url":"https://github.com/orbs-network/orbs-network-go/pull/517.diff","patch_url":"https://github.com/orbs-network/orbs-network-go/pull/517.patch","issue_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/517","number":517,"state":"open","locked":false,"title":"Feature/intra node sync","user":{"login":"ronnno","id":15799888,"node_id":"MDQ6VXNlcjE1Nzk5ODg4","avatar_url":"https://avatars3.githubusercontent.com/u/15799888?v=4","gravatar_id":"","url":"https://api.github.com/users/ronnno","html_url":"https://github.com/ronnno","followers_url":"https://api.github.com/users/ronnno/followers","following_url":"https://api.github.com/users/ronnno/following{/other_user}","gists_url":"https://api.github.com/users/ronnno/gists{/gist_id}","starred_url":"https://api.github.com/users/ronnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronnno/subscriptions","organizations_url":"https://api.github.com/users/ronnno/orgs","repos_url":"https://api.github.com/users/ronnno/repos","events_url":"https://api.github.com/users/ronnno/events{/privacy}","received_events_url":"https://api.github.com/users/ronnno/received_events","type":"User","site_admin":false},"body":"Two go routines sync transaction pool and state storage services asynchronously consistently.\r\n\r\nrenamed block sync to internodesync and named intra node sync package servicesync","created_at":"2018-11-21T17:18:04Z","updated_at":"2018-11-22T06:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ae3cd5769b517bbc83c0d8a3509aacbf4bc649c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"talkol","id":6762255,"node_id":"MDQ6VXNlcjY3NjIyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6762255?v=4","gravatar_id":"","url":"https://api.github.com/users/talkol","html_url":"https://github.com/talkol","followers_url":"https://api.github.com/users/talkol/followers","following_url":"https://api.github.com/users/talkol/following{/other_user}","gists_url":"https://api.github.com/users/talkol/gists{/gist_id}","starred_url":"https://api.github.com/users/talkol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talkol/subscriptions","organizations_url":"https://api.github.com/users/talkol/orgs","repos_url":"https://api.github.com/users/talkol/repos","events_url":"https://api.github.com/users/talkol/events{/privacy}","received_events_url":"https://api.github.com/users/talkol/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517/commits","review_comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517/comments","review_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/517/comments","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/a50788b15971b7c3a8ed4d0998ec67cff2446d15","head":{"label":"orbs-network:feature/intra-node-sync","ref":"feature/intra-node-sync","sha":"a50788b15971b7c3a8ed4d0998ec67cff2446d15","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","private":false,"owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-11-21T18:55:29Z","pushed_at":"2018-11-22T01:38:58Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":7907,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":67,"watchers":41,"default_branch":"master"}},"base":{"label":"orbs-network:master","ref":"master","sha":"49e1e18553a53dd02d78947278e84e1e92fe49a4","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","private":false,"owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-11-21T18:55:29Z","pushed_at":"2018-11-22T01:38:58Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":7907,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":67,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/517"},"issue":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/517"},"comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/517/comments"},"review_comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517/comments"},"review_comment":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/517/commits"},"statuses":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/a50788b15971b7c3a8ed4d0998ec67cff2446d15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"electricmonk"}}