{"action":"closed","number":8137,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137","id":192758662,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzU4NjYy","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/8137","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/8137.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/8137.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8137","number":8137,"state":"closed","locked":false,"title":"DOCS fix 4.0.0 changelog example code for findThemedResource","user":{"login":"christopherdarling","id":178039,"node_id":"MDQ6VXNlcjE3ODAzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/178039?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherdarling","html_url":"https://github.com/christopherdarling","followers_url":"https://api.github.com/users/christopherdarling/followers","following_url":"https://api.github.com/users/christopherdarling/following{/other_user}","gists_url":"https://api.github.com/users/christopherdarling/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherdarling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherdarling/subscriptions","organizations_url":"https://api.github.com/users/christopherdarling/orgs","repos_url":"https://api.github.com/users/christopherdarling/repos","events_url":"https://api.github.com/users/christopherdarling/events{/privacy}","received_events_url":"https://api.github.com/users/christopherdarling/received_events","type":"User","site_admin":false},"body":"ThemeResourceLoader::inst()->findThemedResource() requires two arguments https://github.com/silverstripe/silverstripe-framework/blob/af2c3886b90bcb2c2964633c9dcc33c91d960140/src/View/ThemeResourceLoader.php#L286-L294\r\n\r\nThanks for contributing, you're awesome! :star:\r\nPlease describe expected and observed behaviour, and what you're fixing.\r\nFor visual fixes, please include tested browsers and screenshots.\r\nSearch for related existing issues and link to them if possible.\r\nPlease read https://docs.silverstripe.org/en/contributing/code/","created_at":"2018-06-05T16:01:19Z","updated_at":"2018-06-05T16:18:48Z","closed_at":"2018-06-05T16:18:48Z","merged_at":"2018-06-05T16:18:48Z","merge_commit_sha":"73c6c61ff705d611894e04479cb2e14ae940d830","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8137/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/cab1ea0dbe4ed17425aaa4debd715450d934c203","head":{"label":"christopherdarling:patch-11","ref":"patch-11","sha":"cab1ea0dbe4ed17425aaa4debd715450d934c203","user":{"login":"christopherdarling","id":178039,"node_id":"MDQ6VXNlcjE3ODAzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/178039?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherdarling","html_url":"https://github.com/christopherdarling","followers_url":"https://api.github.com/users/christopherdarling/followers","following_url":"https://api.github.com/users/christopherdarling/following{/other_user}","gists_url":"https://api.github.com/users/christopherdarling/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherdarling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherdarling/subscriptions","organizations_url":"https://api.github.com/users/christopherdarling/orgs","repos_url":"https://api.github.com/users/christopherdarling/repos","events_url":"https://api.github.com/users/christopherdarling/events{/privacy}","received_events_url":"https://api.github.com/users/christopherdarling/received_events","type":"User","site_admin":false},"repo":{"id":19794010,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5NDAxMA==","name":"silverstripe-framework","full_name":"christopherdarling/silverstripe-framework","owner":{"login":"christopherdarling","id":178039,"node_id":"MDQ6VXNlcjE3ODAzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/178039?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherdarling","html_url":"https://github.com/christopherdarling","followers_url":"https://api.github.com/users/christopherdarling/followers","following_url":"https://api.github.com/users/christopherdarling/following{/other_user}","gists_url":"https://api.github.com/users/christopherdarling/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherdarling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherdarling/subscriptions","organizations_url":"https://api.github.com/users/christopherdarling/orgs","repos_url":"https://api.github.com/users/christopherdarling/repos","events_url":"https://api.github.com/users/christopherdarling/events{/privacy}","received_events_url":"https://api.github.com/users/christopherdarling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christopherdarling/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/christopherdarling/silverstripe-framework","forks_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/christopherdarling/silverstripe-framework/deployments","created_at":"2014-05-14T19:55:16Z","updated_at":"2014-08-21T13:31:55Z","pushed_at":"2018-06-05T15:58:38Z","git_url":"git://github.com/christopherdarling/silverstripe-framework.git","ssh_url":"git@github.com:christopherdarling/silverstripe-framework.git","clone_url":"https://github.com/christopherdarling/silverstripe-framework.git","svn_url":"https://github.com/christopherdarling/silverstripe-framework","homepage":"http://silverstripe.org/","size":97846,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"silverstripe:4","ref":"4","sha":"0bec6e07dc62d30684687a2f0a35a787fbdeb37e","user":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODky","name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2018-06-04T11:48:05Z","pushed_at":"2018-06-05T16:18:47Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":99785,"stargazers_count":601,"watchers_count":601,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":696,"mirror_url":null,"archived":false,"open_issues_count":534,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":696,"open_issues":534,"watchers":601,"default_branch":"4"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/8137"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8137"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8137/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8137/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/cab1ea0dbe4ed17425aaa4debd715450d934c203"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dhensby","id":563596,"node_id":"MDQ6VXNlcjU2MzU5Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/563596?v=4","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"dhensby"}}