{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16","id":214257592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MjU3NTky","html_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server/pull/16","diff_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server/pull/16.diff","patch_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server/pull/16.patch","issue_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/16","number":16,"state":"open","locked":false,"title":"fix: pass in secret and not web3","user":{"login":"d1no007","id":10410068,"node_id":"MDQ6VXNlcjEwNDEwMDY4","avatar_url":"https://avatars2.githubusercontent.com/u/10410068?v=4","gravatar_id":"","url":"https://api.github.com/users/d1no007","html_url":"https://github.com/d1no007","followers_url":"https://api.github.com/users/d1no007/followers","following_url":"https://api.github.com/users/d1no007/following{/other_user}","gists_url":"https://api.github.com/users/d1no007/gists{/gist_id}","starred_url":"https://api.github.com/users/d1no007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1no007/subscriptions","organizations_url":"https://api.github.com/users/d1no007/orgs","repos_url":"https://api.github.com/users/d1no007/repos","events_url":"https://api.github.com/users/d1no007/events{/privacy}","received_events_url":"https://api.github.com/users/d1no007/received_events","type":"User","site_admin":false},"body":"We can't pass in web 3 because plugin parameters get stringified by moneyd/the connector. Web3 contains functions that can't be stringified, so we need to create it inside. Also fixed a parameter for a contract open method which did not accept a bignumber.","created_at":"2018-09-10T09:53:21Z","updated_at":"2018-09-10T09:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16/commits","review_comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16/comments","review_comment_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/16/comments","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/statuses/5bd3af9aa233a1c65f2f11320d2c2444c6e8a9aa","head":{"label":"strata-labs:dr-eth-deploy","ref":"dr-eth-deploy","sha":"5bd3af9aa233a1c65f2f11320d2c2444c6e8a9aa","user":{"login":"strata-labs","id":42482716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDgyNzE2","avatar_url":"https://avatars2.githubusercontent.com/u/42482716?v=4","gravatar_id":"","url":"https://api.github.com/users/strata-labs","html_url":"https://github.com/strata-labs","followers_url":"https://api.github.com/users/strata-labs/followers","following_url":"https://api.github.com/users/strata-labs/following{/other_user}","gists_url":"https://api.github.com/users/strata-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/strata-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strata-labs/subscriptions","organizations_url":"https://api.github.com/users/strata-labs/orgs","repos_url":"https://api.github.com/users/strata-labs/repos","events_url":"https://api.github.com/users/strata-labs/events{/privacy}","received_events_url":"https://api.github.com/users/strata-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":148104733,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxMDQ3MzM=","name":"ilp-plugin-ethereum-asym-server","full_name":"strata-labs/ilp-plugin-ethereum-asym-server","owner":{"login":"strata-labs","id":42482716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDgyNzE2","avatar_url":"https://avatars2.githubusercontent.com/u/42482716?v=4","gravatar_id":"","url":"https://api.github.com/users/strata-labs","html_url":"https://github.com/strata-labs","followers_url":"https://api.github.com/users/strata-labs/followers","following_url":"https://api.github.com/users/strata-labs/following{/other_user}","gists_url":"https://api.github.com/users/strata-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/strata-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strata-labs/subscriptions","organizations_url":"https://api.github.com/users/strata-labs/orgs","repos_url":"https://api.github.com/users/strata-labs/repos","events_url":"https://api.github.com/users/strata-labs/events{/privacy}","received_events_url":"https://api.github.com/users/strata-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strata-labs/ilp-plugin-ethereum-asym-server","description":"Ethereum payment channels server","fork":true,"url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server","forks_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/forks","keys_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/teams","hooks_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/hooks","issue_events_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/issues/events{/number}","events_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/events","assignees_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/assignees{/user}","branches_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/branches{/branch}","tags_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/tags","blobs_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/statuses/{sha}","languages_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/languages","stargazers_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/stargazers","contributors_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/contributors","subscribers_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/subscribers","subscription_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/subscription","commits_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/contents/{+path}","compare_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/merges","archive_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/downloads","issues_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/issues{/number}","pulls_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/pulls{/number}","milestones_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/milestones{/number}","notifications_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/labels{/name}","releases_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/releases{/id}","deployments_url":"https://api.github.com/repos/strata-labs/ilp-plugin-ethereum-asym-server/deployments","created_at":"2018-09-10T05:43:29Z","updated_at":"2018-09-10T05:43:30Z","pushed_at":"2018-09-10T09:50:22Z","git_url":"git://github.com/strata-labs/ilp-plugin-ethereum-asym-server.git","ssh_url":"git@github.com:strata-labs/ilp-plugin-ethereum-asym-server.git","clone_url":"https://github.com/strata-labs/ilp-plugin-ethereum-asym-server.git","svn_url":"https://github.com/strata-labs/ilp-plugin-ethereum-asym-server","homepage":null,"size":422,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledgerjs:ko-refactor","ref":"ko-refactor","sha":"f0e9831b933453bb458006f80d40001e33f605e5","user":{"login":"interledgerjs","id":22465593,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDY1NTkz","avatar_url":"https://avatars1.githubusercontent.com/u/22465593?v=4","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":119129751,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMjk3NTE=","name":"ilp-plugin-ethereum-asym-server","full_name":"interledgerjs/ilp-plugin-ethereum-asym-server","owner":{"login":"interledgerjs","id":22465593,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDY1NTkz","avatar_url":"https://avatars1.githubusercontent.com/u/22465593?v=4","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server","description":"Ethereum payment channels server","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server","forks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/deployments","created_at":"2018-01-27T03:44:05Z","updated_at":"2018-08-29T21:24:57Z","pushed_at":"2018-09-07T14:50:48Z","git_url":"git://github.com/interledgerjs/ilp-plugin-ethereum-asym-server.git","ssh_url":"git@github.com:interledgerjs/ilp-plugin-ethereum-asym-server.git","clone_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server.git","svn_url":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server","homepage":null,"size":682,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":3,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16"},"html":{"href":"https://github.com/interledgerjs/ilp-plugin-ethereum-asym-server/pull/16"},"issue":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/16"},"comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/interledgerjs/ilp-plugin-ethereum-asym-server/statuses/5bd3af9aa233a1c65f2f11320d2c2444c6e8a9aa"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":7,"additions":639,"deletions":2125,"changed_files":4}}
{"actor":{"display_login":"d1no007"}}