{"action":"created","comment":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/173132837","pull_request_review_id":102268070,"id":173132837,"diff_hunk":"@@ -43,15 +43,21 @@ start(Host, Opts0) ->\n stop(Host) ->\n     mod_global_distrib_utils:stop(?MODULE, Host, fun stop/0).\n \n--spec get_metadata(mongoose_acc:t(), Key :: term(), Default :: term()) -> Value :: term().\n+-spec get_metadata(mongoose_acc:t(), Key :: term(), Default :: term()) ->","path":"src/global_distrib/mod_global_distrib.erl","position":5,"original_position":5,"commit_id":"8517ed0bd19f813bc462eaef6e4c1d67d7325469","original_commit_id":"8517ed0bd19f813bc462eaef6e4c1d67d7325469","user":{"login":"arcusfelis","id":639796,"avatar_url":"https://avatars0.githubusercontent.com/u/639796?v=4","gravatar_id":"","url":"https://api.github.com/users/arcusfelis","html_url":"https://github.com/arcusfelis","followers_url":"https://api.github.com/users/arcusfelis/followers","following_url":"https://api.github.com/users/arcusfelis/following{/other_user}","gists_url":"https://api.github.com/users/arcusfelis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcusfelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcusfelis/subscriptions","organizations_url":"https://api.github.com/users/arcusfelis/orgs","repos_url":"https://api.github.com/users/arcusfelis/repos","events_url":"https://api.github.com/users/arcusfelis/events{/privacy}","received_events_url":"https://api.github.com/users/arcusfelis/received_events","type":"User","site_admin":false},"body":"Feels like it makes sense to start using `{ok, Value} | {error, Reason}` return format.","created_at":"2018-03-08T11:27:45Z","updated_at":"2018-03-08T11:27:45Z","html_url":"https://github.com/esl/MongooseIM/pull/1763#discussion_r173132837","pull_request_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1763","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/173132837"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1763#discussion_r173132837"},"pull_request":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1763"}}},"pull_request":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/1763","id":173690974,"html_url":"https://github.com/esl/MongooseIM/pull/1763","diff_url":"https://github.com/esl/MongooseIM/pull/1763.diff","patch_url":"https://github.com/esl/MongooseIM/pull/1763.patch","issue_url":"https://api.github.com/repos/esl/MongooseIM/issues/1763","number":1763,"state":"open","locked":false,"title":"Make packet_to_component GD handler more robust","user":{"login":"fenek","id":548816,"avatar_url":"https://avatars0.githubusercontent.com/u/548816?v=4","gravatar_id":"","url":"https://api.github.com/users/fenek","html_url":"https://github.com/fenek","followers_url":"https://api.github.com/users/fenek/followers","following_url":"https://api.github.com/users/fenek/following{/other_user}","gists_url":"https://api.github.com/users/fenek/gists{/gist_id}","starred_url":"https://api.github.com/users/fenek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenek/subscriptions","organizations_url":"https://api.github.com/users/fenek/orgs","repos_url":"https://api.github.com/users/fenek/repos","events_url":"https://api.github.com/users/fenek/events{/privacy}","received_events_url":"https://api.github.com/users/fenek/received_events","type":"User","site_admin":false},"body":"* `mod_global_distrib:get_metadata/2,3` now may return `{error, missing_gd_structure}` error.\r\n* Fixed ETS creation in `mod_global_distrib_utils` - `{heir, none, testing}` parameter is illegal.\r\n* `maybe_update_mapping/2` won't crash now if `global_distrib` structure is missing in acc.\r\n* New integration test is a byproduct of attempts to reproduce the issue; since it covers a new scenario, I haven't removed it.\r\n* Fixed `component_SUITE:connect_component/2` as it was returning invalid component address.","created_at":"2018-03-08T09:56:28Z","updated_at":"2018-03-08T11:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"697345184bc9275dcb6a0a835ab8e35048949878","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kzemek","id":1658995,"avatar_url":"https://avatars1.githubusercontent.com/u/1658995?v=4","gravatar_id":"","url":"https://api.github.com/users/kzemek","html_url":"https://github.com/kzemek","followers_url":"https://api.github.com/users/kzemek/followers","following_url":"https://api.github.com/users/kzemek/following{/other_user}","gists_url":"https://api.github.com/users/kzemek/gists{/gist_id}","starred_url":"https://api.github.com/users/kzemek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzemek/subscriptions","organizations_url":"https://api.github.com/users/kzemek/orgs","repos_url":"https://api.github.com/users/kzemek/repos","events_url":"https://api.github.com/users/kzemek/events{/privacy}","received_events_url":"https://api.github.com/users/kzemek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":813161865,"url":"https://api.github.com/repos/esl/MongooseIM/labels/global%20distribution","name":"global distribution","color":"68d8d1","default":false},{"id":275953800,"url":"https://api.github.com/repos/esl/MongooseIM/labels/waiting-for-review","name":"waiting-for-review","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/esl/MongooseIM/milestones/9","html_url":"https://github.com/esl/MongooseIM/milestone/9","labels_url":"https://api.github.com/repos/esl/MongooseIM/milestones/9/labels","id":3054144,"number":9,"title":"3.0.0","description":"","creator":{"login":"fenek","id":548816,"avatar_url":"https://avatars0.githubusercontent.com/u/548816?v=4","gravatar_id":"","url":"https://api.github.com/users/fenek","html_url":"https://github.com/fenek","followers_url":"https://api.github.com/users/fenek/followers","following_url":"https://api.github.com/users/fenek/following{/other_user}","gists_url":"https://api.github.com/users/fenek/gists{/gist_id}","starred_url":"https://api.github.com/users/fenek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenek/subscriptions","organizations_url":"https://api.github.com/users/fenek/orgs","repos_url":"https://api.github.com/users/fenek/repos","events_url":"https://api.github.com/users/fenek/events{/privacy}","received_events_url":"https://api.github.com/users/fenek/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":30,"state":"open","created_at":"2018-01-22T14:50:02Z","updated_at":"2018-03-08T09:56:28Z","due_on":"2018-04-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1763/commits","review_comments_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1763/comments","review_comment_url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esl/MongooseIM/issues/1763/comments","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/8517ed0bd19f813bc462eaef6e4c1d67d7325469","head":{"label":"esl:reorderable-component-routers","ref":"reorderable-component-routers","sha":"8517ed0bd19f813bc462eaef6e4c1d67d7325469","user":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2018-03-07T18:37:49Z","pushed_at":"2018-03-08T11:00:24Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":29781,"stargazers_count":875,"watchers_count":875,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":304,"open_issues":143,"watchers":875,"default_branch":"master"}},"base":{"label":"esl:master","ref":"master","sha":"ac965cae27f368dbd79cafbd1ecaf78bef0255b4","user":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2018-03-07T18:37:49Z","pushed_at":"2018-03-08T11:00:24Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":29781,"stargazers_count":875,"watchers_count":875,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":304,"open_issues":143,"watchers":875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1763"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1763"},"issue":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1763"},"comments":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1763/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1763/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1763/commits"},"statuses":{"href":"https://api.github.com/repos/esl/MongooseIM/statuses/8517ed0bd19f813bc462eaef6e4c1d67d7325469"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"arcusfelis"}}