{"action":"opened","number":6465,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/6465","id":234837587,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODM3NTg3","html_url":"https://github.com/apache/incubator-superset/pull/6465","diff_url":"https://github.com/apache/incubator-superset/pull/6465.diff","patch_url":"https://github.com/apache/incubator-superset/pull/6465.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/6465","number":6465,"state":"open","locked":false,"title":"Fixing error when clearing big number metric","user":{"login":"michellethomas","id":817955,"node_id":"MDQ6VXNlcjgxNzk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/817955?v=4","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"body":"Fixes the error we were seeing when clearing the metric on big number. `transformProps` gets run every time the chart or chart controls changes, so when you clear a metric, instead of showing the overlay, we'll show NaN until the user selects a new metric. I'll create a separate issue so that moving forward we can handle this case better (and possibly move this logic out of transformProps).\r\n\r\nFixes #6447\r\n\r\nTested big number with:\r\nSaved metric\r\nAdhoc metric\r\nCleared metric and added new ","created_at":"2018-11-30T00:56:05Z","updated_at":"2018-11-30T00:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/6465/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/6465/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/6465/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/972bfa16b19d959eb910442c1548825c261f06ad","head":{"label":"michellethomas:fix_big_number_clearing_metric","ref":"fix_big_number_clearing_metric","sha":"972bfa16b19d959eb910442c1548825c261f06ad","user":{"login":"michellethomas","id":817955,"node_id":"MDQ6VXNlcjgxNzk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/817955?v=4","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"repo":{"id":48074650,"node_id":"MDEwOlJlcG9zaXRvcnk0ODA3NDY1MA==","name":"panoramix","full_name":"michellethomas/panoramix","private":false,"owner":{"login":"michellethomas","id":817955,"node_id":"MDQ6VXNlcjgxNzk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/817955?v=4","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michellethomas/panoramix","description":"Panoramix is a data exploration platform designed to be visual, intuitive and interactive","fork":true,"url":"https://api.github.com/repos/michellethomas/panoramix","forks_url":"https://api.github.com/repos/michellethomas/panoramix/forks","keys_url":"https://api.github.com/repos/michellethomas/panoramix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michellethomas/panoramix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michellethomas/panoramix/teams","hooks_url":"https://api.github.com/repos/michellethomas/panoramix/hooks","issue_events_url":"https://api.github.com/repos/michellethomas/panoramix/issues/events{/number}","events_url":"https://api.github.com/repos/michellethomas/panoramix/events","assignees_url":"https://api.github.com/repos/michellethomas/panoramix/assignees{/user}","branches_url":"https://api.github.com/repos/michellethomas/panoramix/branches{/branch}","tags_url":"https://api.github.com/repos/michellethomas/panoramix/tags","blobs_url":"https://api.github.com/repos/michellethomas/panoramix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michellethomas/panoramix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michellethomas/panoramix/git/refs{/sha}","trees_url":"https://api.github.com/repos/michellethomas/panoramix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michellethomas/panoramix/statuses/{sha}","languages_url":"https://api.github.com/repos/michellethomas/panoramix/languages","stargazers_url":"https://api.github.com/repos/michellethomas/panoramix/stargazers","contributors_url":"https://api.github.com/repos/michellethomas/panoramix/contributors","subscribers_url":"https://api.github.com/repos/michellethomas/panoramix/subscribers","subscription_url":"https://api.github.com/repos/michellethomas/panoramix/subscription","commits_url":"https://api.github.com/repos/michellethomas/panoramix/commits{/sha}","git_commits_url":"https://api.github.com/repos/michellethomas/panoramix/git/commits{/sha}","comments_url":"https://api.github.com/repos/michellethomas/panoramix/comments{/number}","issue_comment_url":"https://api.github.com/repos/michellethomas/panoramix/issues/comments{/number}","contents_url":"https://api.github.com/repos/michellethomas/panoramix/contents/{+path}","compare_url":"https://api.github.com/repos/michellethomas/panoramix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michellethomas/panoramix/merges","archive_url":"https://api.github.com/repos/michellethomas/panoramix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michellethomas/panoramix/downloads","issues_url":"https://api.github.com/repos/michellethomas/panoramix/issues{/number}","pulls_url":"https://api.github.com/repos/michellethomas/panoramix/pulls{/number}","milestones_url":"https://api.github.com/repos/michellethomas/panoramix/milestones{/number}","notifications_url":"https://api.github.com/repos/michellethomas/panoramix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michellethomas/panoramix/labels{/name}","releases_url":"https://api.github.com/repos/michellethomas/panoramix/releases{/id}","deployments_url":"https://api.github.com/repos/michellethomas/panoramix/deployments","created_at":"2015-12-15T23:19:58Z","updated_at":"2018-10-19T22:17:24Z","pushed_at":"2018-11-30T00:50:08Z","git_url":"git://github.com/michellethomas/panoramix.git","ssh_url":"git@github.com:michellethomas/panoramix.git","clone_url":"https://github.com/michellethomas/panoramix.git","svn_url":"https://github.com/michellethomas/panoramix","homepage":"","size":89546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e715cdb9ac3b1c2ea6c0802a3ce57f9ebcb971c5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2NDAxOA==","name":"incubator-superset","full_name":"apache/incubator-superset","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2018-11-30T00:34:01Z","pushed_at":"2018-11-29T23:18:27Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":96041,"stargazers_count":22078,"watchers_count":22078,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3969,"mirror_url":null,"archived":false,"open_issues_count":1082,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3969,"open_issues":1082,"watchers":22078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6465"},"html":{"href":"https://github.com/apache/incubator-superset/pull/6465"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/6465"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/6465/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6465/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/6465/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/972bfa16b19d959eb910442c1548825c261f06ad"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"michellethomas"}}