{"action":"created","comment":{"url":"https://api.github.com/repos/xapian/xapian/pulls/comments/245475930","pull_request_review_id":189595050,"id":245475930,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ3NTkzMA==","diff_hunk":"@@ -31,14 +31,18 @@\n using namespace std;\n \n #define COUNT_CLOSEDEXC(CODE) \\\n-    try { CODE; } catch (const Xapian::DatabaseError &) { ++closedexc_count; }\n+    try { \\\n+\t\tCODE; \\\n+\t} catch (const Xapian::DatabaseClosedError &) { \\\n+\t\t++closedexc_count; \\","path":"xapian-core/tests/api_closedb.cc","position":8,"original_position":8,"commit_id":"38a928b40f58b6953f72ef5ed0432e8c1e21c795","original_commit_id":"38a928b40f58b6953f72ef5ed0432e8c1e21c795","user":{"login":"VaibhavKansagara","id":29653741,"node_id":"MDQ6VXNlcjI5NjUzNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/29653741?v=4","gravatar_id":"","url":"https://api.github.com/users/VaibhavKansagara","html_url":"https://github.com/VaibhavKansagara","followers_url":"https://api.github.com/users/VaibhavKansagara/followers","following_url":"https://api.github.com/users/VaibhavKansagara/following{/other_user}","gists_url":"https://api.github.com/users/VaibhavKansagara/gists{/gist_id}","starred_url":"https://api.github.com/users/VaibhavKansagara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaibhavKansagara/subscriptions","organizations_url":"https://api.github.com/users/VaibhavKansagara/orgs","repos_url":"https://api.github.com/users/VaibhavKansagara/repos","events_url":"https://api.github.com/users/VaibhavKansagara/events{/privacy}","received_events_url":"https://api.github.com/users/VaibhavKansagara/received_events","type":"User","site_admin":false},"body":"Thanks for pointing this out.I will push the changes.","created_at":"2019-01-05T12:05:28Z","updated_at":"2019-01-05T12:05:28Z","html_url":"https://github.com/xapian/xapian/pull/214#discussion_r245475930","pull_request_url":"https://api.github.com/repos/xapian/xapian/pulls/214","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments/245475930"},"html":{"href":"https://github.com/xapian/xapian/pull/214#discussion_r245475930"},"pull_request":{"href":"https://api.github.com/repos/xapian/xapian/pulls/214"}},"in_reply_to_id":245447437},"pull_request":{"url":"https://api.github.com/repos/xapian/xapian/pulls/214","id":241648298,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjQ4Mjk4","html_url":"https://github.com/xapian/xapian/pull/214","diff_url":"https://github.com/xapian/xapian/pull/214.diff","patch_url":"https://github.com/xapian/xapian/pull/214.patch","issue_url":"https://api.github.com/repos/xapian/xapian/issues/214","number":214,"state":"open","locked":false,"title":"Explicit DatabaseClosedError exception(ticket #772)","user":{"login":"VaibhavKansagara","id":29653741,"node_id":"MDQ6VXNlcjI5NjUzNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/29653741?v=4","gravatar_id":"","url":"https://api.github.com/users/VaibhavKansagara","html_url":"https://github.com/VaibhavKansagara","followers_url":"https://api.github.com/users/VaibhavKansagara/followers","following_url":"https://api.github.com/users/VaibhavKansagara/following{/other_user}","gists_url":"https://api.github.com/users/VaibhavKansagara/gists{/gist_id}","starred_url":"https://api.github.com/users/VaibhavKansagara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaibhavKansagara/subscriptions","organizations_url":"https://api.github.com/users/VaibhavKansagara/orgs","repos_url":"https://api.github.com/users/VaibhavKansagara/repos","events_url":"https://api.github.com/users/VaibhavKansagara/events{/privacy}","received_events_url":"https://api.github.com/users/VaibhavKansagara/received_events","type":"User","site_admin":false},"body":"This PR adds a new class DatabaseClosedError. Refer to ticket #772 for more details.\r\nPlease review this PR when you have time.","created_at":"2019-01-01T19:49:49Z","updated_at":"2019-01-05T12:05:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a291277a765e9e87e5947ec6d99f1fc6c07e4a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapian/xapian/pulls/214/commits","review_comments_url":"https://api.github.com/repos/xapian/xapian/pulls/214/comments","review_comment_url":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapian/xapian/issues/214/comments","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/38a928b40f58b6953f72ef5ed0432e8c1e21c795","head":{"label":"VaibhavKansagara:kansagara_vaibhav","ref":"kansagara_vaibhav","sha":"38a928b40f58b6953f72ef5ed0432e8c1e21c795","user":{"login":"VaibhavKansagara","id":29653741,"node_id":"MDQ6VXNlcjI5NjUzNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/29653741?v=4","gravatar_id":"","url":"https://api.github.com/users/VaibhavKansagara","html_url":"https://github.com/VaibhavKansagara","followers_url":"https://api.github.com/users/VaibhavKansagara/followers","following_url":"https://api.github.com/users/VaibhavKansagara/following{/other_user}","gists_url":"https://api.github.com/users/VaibhavKansagara/gists{/gist_id}","starred_url":"https://api.github.com/users/VaibhavKansagara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaibhavKansagara/subscriptions","organizations_url":"https://api.github.com/users/VaibhavKansagara/orgs","repos_url":"https://api.github.com/users/VaibhavKansagara/repos","events_url":"https://api.github.com/users/VaibhavKansagara/events{/privacy}","received_events_url":"https://api.github.com/users/VaibhavKansagara/received_events","type":"User","site_admin":false},"repo":{"id":162866266,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4NjYyNjY=","name":"xapian","full_name":"VaibhavKansagara/xapian","private":false,"owner":{"login":"VaibhavKansagara","id":29653741,"node_id":"MDQ6VXNlcjI5NjUzNzQx","avatar_url":"https://avatars1.githubusercontent.com/u/29653741?v=4","gravatar_id":"","url":"https://api.github.com/users/VaibhavKansagara","html_url":"https://github.com/VaibhavKansagara","followers_url":"https://api.github.com/users/VaibhavKansagara/followers","following_url":"https://api.github.com/users/VaibhavKansagara/following{/other_user}","gists_url":"https://api.github.com/users/VaibhavKansagara/gists{/gist_id}","starred_url":"https://api.github.com/users/VaibhavKansagara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VaibhavKansagara/subscriptions","organizations_url":"https://api.github.com/users/VaibhavKansagara/orgs","repos_url":"https://api.github.com/users/VaibhavKansagara/repos","events_url":"https://api.github.com/users/VaibhavKansagara/events{/privacy}","received_events_url":"https://api.github.com/users/VaibhavKansagara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VaibhavKansagara/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":true,"url":"https://api.github.com/repos/VaibhavKansagara/xapian","forks_url":"https://api.github.com/repos/VaibhavKansagara/xapian/forks","keys_url":"https://api.github.com/repos/VaibhavKansagara/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VaibhavKansagara/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VaibhavKansagara/xapian/teams","hooks_url":"https://api.github.com/repos/VaibhavKansagara/xapian/hooks","issue_events_url":"https://api.github.com/repos/VaibhavKansagara/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/VaibhavKansagara/xapian/events","assignees_url":"https://api.github.com/repos/VaibhavKansagara/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/VaibhavKansagara/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/VaibhavKansagara/xapian/tags","blobs_url":"https://api.github.com/repos/VaibhavKansagara/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VaibhavKansagara/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VaibhavKansagara/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/VaibhavKansagara/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VaibhavKansagara/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/VaibhavKansagara/xapian/languages","stargazers_url":"https://api.github.com/repos/VaibhavKansagara/xapian/stargazers","contributors_url":"https://api.github.com/repos/VaibhavKansagara/xapian/contributors","subscribers_url":"https://api.github.com/repos/VaibhavKansagara/xapian/subscribers","subscription_url":"https://api.github.com/repos/VaibhavKansagara/xapian/subscription","commits_url":"https://api.github.com/repos/VaibhavKansagara/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/VaibhavKansagara/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/VaibhavKansagara/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/VaibhavKansagara/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/VaibhavKansagara/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/VaibhavKansagara/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VaibhavKansagara/xapian/merges","archive_url":"https://api.github.com/repos/VaibhavKansagara/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VaibhavKansagara/xapian/downloads","issues_url":"https://api.github.com/repos/VaibhavKansagara/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/VaibhavKansagara/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/VaibhavKansagara/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/VaibhavKansagara/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VaibhavKansagara/xapian/labels{/name}","releases_url":"https://api.github.com/repos/VaibhavKansagara/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/VaibhavKansagara/xapian/deployments","created_at":"2018-12-23T05:56:54Z","updated_at":"2018-12-23T05:57:02Z","pushed_at":"2019-01-04T10:42:06Z","git_url":"git://github.com/VaibhavKansagara/xapian.git","ssh_url":"git@github.com:VaibhavKansagara/xapian.git","clone_url":"https://github.com/VaibhavKansagara/xapian.git","svn_url":"https://github.com/VaibhavKansagara/xapian","homepage":"https://xapian.org/","size":87697,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapian:master","ref":"master","sha":"eec792856a6ee5a985cc281788dac0c57781e93e","user":{"login":"xapian","id":312861,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjg2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/312861?v=4","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"repo":{"id":735981,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5ODE=","name":"xapian","full_name":"xapian/xapian","private":false,"owner":{"login":"xapian","id":312861,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjg2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/312861?v=4","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xapian/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":false,"url":"https://api.github.com/repos/xapian/xapian","forks_url":"https://api.github.com/repos/xapian/xapian/forks","keys_url":"https://api.github.com/repos/xapian/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapian/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapian/xapian/teams","hooks_url":"https://api.github.com/repos/xapian/xapian/hooks","issue_events_url":"https://api.github.com/repos/xapian/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/xapian/xapian/events","assignees_url":"https://api.github.com/repos/xapian/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/xapian/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/xapian/xapian/tags","blobs_url":"https://api.github.com/repos/xapian/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapian/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapian/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapian/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/xapian/xapian/languages","stargazers_url":"https://api.github.com/repos/xapian/xapian/stargazers","contributors_url":"https://api.github.com/repos/xapian/xapian/contributors","subscribers_url":"https://api.github.com/repos/xapian/xapian/subscribers","subscription_url":"https://api.github.com/repos/xapian/xapian/subscription","commits_url":"https://api.github.com/repos/xapian/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapian/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapian/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapian/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapian/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/xapian/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapian/xapian/merges","archive_url":"https://api.github.com/repos/xapian/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapian/xapian/downloads","issues_url":"https://api.github.com/repos/xapian/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/xapian/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/xapian/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/xapian/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapian/xapian/labels{/name}","releases_url":"https://api.github.com/repos/xapian/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/xapian/xapian/deployments","created_at":"2010-06-23T15:51:03Z","updated_at":"2019-01-05T00:37:31Z","pushed_at":"2019-01-05T00:37:27Z","git_url":"git://github.com/xapian/xapian.git","ssh_url":"git@github.com:xapian/xapian.git","clone_url":"https://github.com/xapian/xapian.git","svn_url":"https://github.com/xapian/xapian","homepage":"https://xapian.org/","size":87674,"stargazers_count":455,"watchers_count":455,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":211,"open_issues":13,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/214"},"html":{"href":"https://github.com/xapian/xapian/pull/214"},"issue":{"href":"https://api.github.com/repos/xapian/xapian/issues/214"},"comments":{"href":"https://api.github.com/repos/xapian/xapian/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/xapian/xapian/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapian/xapian/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/xapian/xapian/statuses/38a928b40f58b6953f72ef5ed0432e8c1e21c795"}},"author_association":"NONE"}}
{"actor":{"display_login":"VaibhavKansagara"}}