{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/comments/232299003","pull_request_review_id":173459141,"id":232299003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjI5OTAwMw==","diff_hunk":"@@ -311,7 +313,12 @@ def finalize_deposit_claim(\n     )\n \n     if deposit_claim:\n-        bankster.finalize_payment(deposit_claim)\n+        tx_hash = bankster.finalize_payment(deposit_claim)\n+        payment_interface = PaymentInterface()  # new object is NOT created, it is singleton and its instance is returned\n+        payment_interface.on_transaction_confirmed(   # type: ignore  # pylint: disable=no-member\n+            tx_hash=tx_hash,\n+            cb=lambda: discard_claim(deposit_claim)\n+        )","path":"concent_api/core/subtask_helpers.py","position":28,"original_position":28,"commit_id":"964790718cf36edaeb3998d36701bd9db65d59c2","original_commit_id":"964790718cf36edaeb3998d36701bd9db65d59c2","user":{"login":"cameel","id":137030,"node_id":"MDQ6VXNlcjEzNzAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/137030?v=4","gravatar_id":"","url":"https://api.github.com/users/cameel","html_url":"https://github.com/cameel","followers_url":"https://api.github.com/users/cameel/followers","following_url":"https://api.github.com/users/cameel/following{/other_user}","gists_url":"https://api.github.com/users/cameel/gists{/gist_id}","starred_url":"https://api.github.com/users/cameel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameel/subscriptions","organizations_url":"https://api.github.com/users/cameel/orgs","repos_url":"https://api.github.com/users/cameel/repos","events_url":"https://api.github.com/users/cameel/events{/privacy}","received_events_url":"https://api.github.com/users/cameel/received_events","type":"User","site_admin":false},"body":"Please make sure that `discard_claim()` does not fail if two processes try to do it at the same time (i.e. first gets a lock, seconds waits on the lock, first runs `delete()` and releases the lock, second runs `delete()` on the same, already deleted object). I think it won't fail on the SQL level (the `WHERE` clause in the second `DELETE` will simply match no rows) but I'm not sure how Django will behave.","created_at":"2018-11-09T15:49:34Z","updated_at":"2018-11-09T15:52:05Z","html_url":"https://github.com/golemfactory/concent/pull/927#discussion_r232299003","pull_request_url":"https://api.github.com/repos/golemfactory/concent/pulls/927","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments/232299003"},"html":{"href":"https://github.com/golemfactory/concent/pull/927#discussion_r232299003"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/927"}}},"pull_request":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/927","id":229274887,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Mjc0ODg3","html_url":"https://github.com/golemfactory/concent/pull/927","diff_url":"https://github.com/golemfactory/concent/pull/927.diff","patch_url":"https://github.com/golemfactory/concent/pull/927.patch","issue_url":"https://api.github.com/repos/golemfactory/concent/issues/927","number":927,"state":"open","locked":false,"title":"Feature blockchain event subsciption","user":{"login":"pawelkisielewicz","id":36702174,"node_id":"MDQ6VXNlcjM2NzAyMTc0","avatar_url":"https://avatars3.githubusercontent.com/u/36702174?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelkisielewicz","html_url":"https://github.com/pawelkisielewicz","followers_url":"https://api.github.com/users/pawelkisielewicz/followers","following_url":"https://api.github.com/users/pawelkisielewicz/following{/other_user}","gists_url":"https://api.github.com/users/pawelkisielewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelkisielewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelkisielewicz/subscriptions","organizations_url":"https://api.github.com/users/pawelkisielewicz/orgs","repos_url":"https://api.github.com/users/pawelkisielewicz/repos","events_url":"https://api.github.com/users/pawelkisielewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pawelkisielewicz/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/golemfactory/concent/issues/899\r\n\r\nPlease check careful this pull request, the main part is to add callback in `finalize_deposit_claim`. It is not possible to test it local and without @kbeker I don't think we can test it with blockchain.  \r\n\r\nThere is also added test for function removing deposit_claim. But this function actually checks if object exists in database and calls other function, which is tested. I would remove this (my) test, but please comment ","created_at":"2018-11-08T07:42:16Z","updated_at":"2018-11-09T15:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f860f927ee1713b1afb1807f974d8fe3910a90eb","assignee":{"login":"pawelkisielewicz","id":36702174,"node_id":"MDQ6VXNlcjM2NzAyMTc0","avatar_url":"https://avatars3.githubusercontent.com/u/36702174?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelkisielewicz","html_url":"https://github.com/pawelkisielewicz","followers_url":"https://api.github.com/users/pawelkisielewicz/followers","following_url":"https://api.github.com/users/pawelkisielewicz/following{/other_user}","gists_url":"https://api.github.com/users/pawelkisielewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelkisielewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelkisielewicz/subscriptions","organizations_url":"https://api.github.com/users/pawelkisielewicz/orgs","repos_url":"https://api.github.com/users/pawelkisielewicz/repos","events_url":"https://api.github.com/users/pawelkisielewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pawelkisielewicz/received_events","type":"User","site_admin":false},"assignees":[{"login":"pawelkisielewicz","id":36702174,"node_id":"MDQ6VXNlcjM2NzAyMTc0","avatar_url":"https://avatars3.githubusercontent.com/u/36702174?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelkisielewicz","html_url":"https://github.com/pawelkisielewicz","followers_url":"https://api.github.com/users/pawelkisielewicz/followers","following_url":"https://api.github.com/users/pawelkisielewicz/following{/other_user}","gists_url":"https://api.github.com/users/pawelkisielewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelkisielewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelkisielewicz/subscriptions","organizations_url":"https://api.github.com/users/pawelkisielewicz/orgs","repos_url":"https://api.github.com/users/pawelkisielewicz/repos","events_url":"https://api.github.com/users/pawelkisielewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pawelkisielewicz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":822556027,"node_id":"MDU6TGFiZWw4MjI1NTYwMjc=","url":"https://api.github.com/repos/golemfactory/concent/labels/feature","name":"feature","color":"f2dc15","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/concent/pulls/927/commits","review_comments_url":"https://api.github.com/repos/golemfactory/concent/pulls/927/comments","review_comment_url":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/concent/issues/927/comments","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/964790718cf36edaeb3998d36701bd9db65d59c2","head":{"label":"golemfactory:feature-blockchain-event-subsciption","ref":"feature-blockchain-event-subsciption","sha":"964790718cf36edaeb3998d36701bd9db65d59c2","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-11-08T15:26:39Z","pushed_at":"2018-11-09T13:38:32Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":4272,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":99,"license":null,"forks":2,"open_issues":99,"watchers":4,"default_branch":"master"}},"base":{"label":"golemfactory:feature-bankster-claim-deposit-operation-changes","ref":"feature-bankster-claim-deposit-operation-changes","sha":"a8a5ef3810ea3c3c2952354e40c8d843b4b105bc","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","private":false,"owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-11-08T15:26:39Z","pushed_at":"2018-11-09T13:38:32Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":4272,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":99,"license":null,"forks":2,"open_issues":99,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/927"},"html":{"href":"https://github.com/golemfactory/concent/pull/927"},"issue":{"href":"https://api.github.com/repos/golemfactory/concent/issues/927"},"comments":{"href":"https://api.github.com/repos/golemfactory/concent/issues/927/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/927/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/927/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/concent/statuses/964790718cf36edaeb3998d36701bd9db65d59c2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cameel"}}