{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/189078710","pull_request_review_id":121188906,"id":189078710,"diff_hunk":"@@ -0,0 +1,24 @@\n+# Default values for distributed-tensorflow.\n+# This is a YAML-formatted file.\n+# Declare variables to be passed into your templates.\n+worker:\n+  number: 2\n+  podManagementPolicy: Parallel\n+  image:\n+    repository: cheyang/distributed-tf","path":"stable/distributed-tensorflow/values.yaml","position":8,"original_position":8,"commit_id":"675f2c04f8860e912eabef5042dfbab57e319da7","original_commit_id":"675f2c04f8860e912eabef5042dfbab57e319da7","user":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"body":"Let's discuss images again. Can't you use official ones?","created_at":"2018-05-17T19:45:02Z","updated_at":"2018-05-17T19:46:32Z","html_url":"https://github.com/kubernetes/charts/pull/5187#discussion_r189078710","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/5187","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/189078710"},"html":{"href":"https://github.com/kubernetes/charts/pull/5187#discussion_r189078710"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5187"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/5187","id":183256788,"html_url":"https://github.com/kubernetes/charts/pull/5187","diff_url":"https://github.com/kubernetes/charts/pull/5187.diff","patch_url":"https://github.com/kubernetes/charts/pull/5187.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/5187","number":5187,"state":"open","locked":false,"title":"Add distributed tensorflow","user":{"login":"cheyang","id":3724388,"avatar_url":"https://avatars2.githubusercontent.com/u/3724388?v=4","gravatar_id":"","url":"https://api.github.com/users/cheyang","html_url":"https://github.com/cheyang","followers_url":"https://api.github.com/users/cheyang/followers","following_url":"https://api.github.com/users/cheyang/following{/other_user}","gists_url":"https://api.github.com/users/cheyang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheyang/subscriptions","organizations_url":"https://api.github.com/users/cheyang/orgs","repos_url":"https://api.github.com/users/cheyang/repos","events_url":"https://api.github.com/users/cheyang/events{/privacy}","received_events_url":"https://api.github.com/users/cheyang/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-04-22T05:39:26Z","updated_at":"2018-05-17T19:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a258b22336590235dd99f6ab769afabee4acaf2d","assignee":{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676596499,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/5187/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/5187/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/5187/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/675f2c04f8860e912eabef5042dfbab57e319da7","head":{"label":"cheyang:distributed_tensorflow","ref":"distributed_tensorflow","sha":"675f2c04f8860e912eabef5042dfbab57e319da7","user":{"login":"cheyang","id":3724388,"avatar_url":"https://avatars2.githubusercontent.com/u/3724388?v=4","gravatar_id":"","url":"https://api.github.com/users/cheyang","html_url":"https://github.com/cheyang","followers_url":"https://api.github.com/users/cheyang/followers","following_url":"https://api.github.com/users/cheyang/following{/other_user}","gists_url":"https://api.github.com/users/cheyang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheyang/subscriptions","organizations_url":"https://api.github.com/users/cheyang/orgs","repos_url":"https://api.github.com/users/cheyang/repos","events_url":"https://api.github.com/users/cheyang/events{/privacy}","received_events_url":"https://api.github.com/users/cheyang/received_events","type":"User","site_admin":false},"repo":{"id":125590635,"name":"charts","full_name":"cheyang/charts","owner":{"login":"cheyang","id":3724388,"avatar_url":"https://avatars2.githubusercontent.com/u/3724388?v=4","gravatar_id":"","url":"https://api.github.com/users/cheyang","html_url":"https://github.com/cheyang","followers_url":"https://api.github.com/users/cheyang/followers","following_url":"https://api.github.com/users/cheyang/following{/other_user}","gists_url":"https://api.github.com/users/cheyang/gists{/gist_id}","starred_url":"https://api.github.com/users/cheyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheyang/subscriptions","organizations_url":"https://api.github.com/users/cheyang/orgs","repos_url":"https://api.github.com/users/cheyang/repos","events_url":"https://api.github.com/users/cheyang/events{/privacy}","received_events_url":"https://api.github.com/users/cheyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cheyang/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/cheyang/charts","forks_url":"https://api.github.com/repos/cheyang/charts/forks","keys_url":"https://api.github.com/repos/cheyang/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cheyang/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cheyang/charts/teams","hooks_url":"https://api.github.com/repos/cheyang/charts/hooks","issue_events_url":"https://api.github.com/repos/cheyang/charts/issues/events{/number}","events_url":"https://api.github.com/repos/cheyang/charts/events","assignees_url":"https://api.github.com/repos/cheyang/charts/assignees{/user}","branches_url":"https://api.github.com/repos/cheyang/charts/branches{/branch}","tags_url":"https://api.github.com/repos/cheyang/charts/tags","blobs_url":"https://api.github.com/repos/cheyang/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cheyang/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cheyang/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/cheyang/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cheyang/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/cheyang/charts/languages","stargazers_url":"https://api.github.com/repos/cheyang/charts/stargazers","contributors_url":"https://api.github.com/repos/cheyang/charts/contributors","subscribers_url":"https://api.github.com/repos/cheyang/charts/subscribers","subscription_url":"https://api.github.com/repos/cheyang/charts/subscription","commits_url":"https://api.github.com/repos/cheyang/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/cheyang/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/cheyang/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/cheyang/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/cheyang/charts/contents/{+path}","compare_url":"https://api.github.com/repos/cheyang/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cheyang/charts/merges","archive_url":"https://api.github.com/repos/cheyang/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cheyang/charts/downloads","issues_url":"https://api.github.com/repos/cheyang/charts/issues{/number}","pulls_url":"https://api.github.com/repos/cheyang/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/cheyang/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/cheyang/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cheyang/charts/labels{/name}","releases_url":"https://api.github.com/repos/cheyang/charts/releases{/id}","deployments_url":"https://api.github.com/repos/cheyang/charts/deployments","created_at":"2018-03-17T02:41:15Z","updated_at":"2018-05-16T22:58:12Z","pushed_at":"2018-05-16T23:03:23Z","git_url":"git://github.com/cheyang/charts.git","ssh_url":"git@github.com:cheyang/charts.git","clone_url":"https://github.com/cheyang/charts.git","svn_url":"https://github.com/cheyang/charts","homepage":"","size":7772,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3f56ab265b1a24110f7e9b153ccf72efcee52d61","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-05-17T19:36:29Z","pushed_at":"2018-05-17T19:39:07Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":7553,"stargazers_count":3162,"watchers_count":3162,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2697,"mirror_url":null,"archived":false,"open_issues_count":621,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2697,"open_issues":621,"watchers":3162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5187"},"html":{"href":"https://github.com/kubernetes/charts/pull/5187"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5187"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5187/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5187/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5187/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/675f2c04f8860e912eabef5042dfbab57e319da7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"unguiculus"}}