{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/comments/229672978","pull_request_review_id":170225113,"id":229672978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY3Mjk3OA==","diff_hunk":"@@ -8,26 +8,60 @@ enable_language(CXX)\n \n find_package(Kodi REQUIRED)\n find_package(CXX11 REQUIRED)\n+\n if(NOT WIN32)\n-  find_package(OpenGL REQUIRED)\n-  set(DEPLIBS ${OPENGL_LIBRARIES})\n+  find_package(EMBEDDED)\n+  if((APP_RENDER_SYSTEM STREQUAL \"gl\" OR NOT APP_RENDER_SYSTEM) AND NOT EMBEDDED_FOUND)","path":"CMakeLists.txt","position":9,"original_position":9,"commit_id":"e3e4737fd727203891d8b9f142025f43f5f77daa","original_commit_id":"e3e4737fd727203891d8b9f142025f43f5f77daa","user":{"login":"AlwinEsch","id":6879739,"node_id":"MDQ6VXNlcjY4Nzk3Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6879739?v=4","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"Has taken it from [pvr.vdr.vnsi](https://github.com/FernetMenta/pvr.vdr.vnsi) and was added there with https://github.com/FernetMenta/pvr.vdr.vnsi/commit/66050a984a07aeea7837c0f02e3a961bdd9a8457#diff-af3b638bc2a3e6c650974192a53c7291","created_at":"2018-10-31T12:30:11Z","updated_at":"2018-10-31T12:30:11Z","html_url":"https://github.com/xbmc/screensaver.asteroids/pull/10#discussion_r229672978","pull_request_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/comments/229672978"},"html":{"href":"https://github.com/xbmc/screensaver.asteroids/pull/10#discussion_r229672978"},"pull_request":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10"}},"in_reply_to_id":229671719},"pull_request":{"url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10","id":220151033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTUxMDMz","html_url":"https://github.com/xbmc/screensaver.asteroids/pull/10","diff_url":"https://github.com/xbmc/screensaver.asteroids/pull/10.diff","patch_url":"https://github.com/xbmc/screensaver.asteroids/pull/10.patch","issue_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/10","number":10,"state":"closed","locked":false,"title":"Fix OpenGL Rendering","user":{"login":"AlwinEsch","id":6879739,"node_id":"MDQ6VXNlcjY4Nzk3Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6879739?v=4","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"Here a commit to fix OpenGL Rendering about the screensaver addon.\r\n\r\nWith this here is it works on my system. But impossible for me to check on other systems.\r\n\r\nSince on Kodi the OpenGL system is updated, most visualization addons do not work anymore.\r\n\r\nMy System is:\r\n- Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz\r\n- NVIDIA Corporation GM107M [GeForce GTX 960M] (rev a2) on Laptop\r\n- NVIDIA Driver Version: [390.87](https://www.nvidia.de/Download/driverResults.aspx/137429/)\r\n- Ubuntu 18.4\r\n\r\n@pkerling says that a rewrite with shaders is needed (https://github.com/AlwinEsch/screensaver.asteroids/pull/1). Hard for me is only my missing experience with OpenGL and my Stupid Graphic System (not found a working way to debug this closed source nvidia). Have changed a bit the fix since his comments there.\r\n\r\n**Can the fix of this request be tested by others on their systems and give their result and system names to me.**\r\n\r\nIf I become it working must it be done on all others.","created_at":"2018-10-03T19:23:13Z","updated_at":"2018-10-31T12:30:11Z","closed_at":"2018-10-31T12:11:19Z","merged_at":"2018-10-31T12:11:19Z","merge_commit_sha":"b3341ec9d94192962bd4220ce6777c7baf8832db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10/commits","review_comments_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10/comments","review_comment_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/10/comments","statuses_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/statuses/e3e4737fd727203891d8b9f142025f43f5f77daa","head":{"label":"AlwinEsch:fix-rendering","ref":"fix-rendering","sha":"e3e4737fd727203891d8b9f142025f43f5f77daa","user":{"login":"AlwinEsch","id":6879739,"node_id":"MDQ6VXNlcjY4Nzk3Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6879739?v=4","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"repo":{"id":65512909,"node_id":"MDEwOlJlcG9zaXRvcnk2NTUxMjkwOQ==","name":"screensaver.asteroids","full_name":"AlwinEsch/screensaver.asteroids","private":false,"owner":{"login":"AlwinEsch","id":6879739,"node_id":"MDQ6VXNlcjY4Nzk3Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6879739?v=4","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlwinEsch/screensaver.asteroids","description":"Asteroids screensaver for Kodi","fork":true,"url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids","forks_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/forks","keys_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/teams","hooks_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/hooks","issue_events_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/issues/events{/number}","events_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/events","assignees_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/assignees{/user}","branches_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/branches{/branch}","tags_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/tags","blobs_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/statuses/{sha}","languages_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/languages","stargazers_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/stargazers","contributors_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/contributors","subscribers_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/subscribers","subscription_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/subscription","commits_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/contents/{+path}","compare_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/merges","archive_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/downloads","issues_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/issues{/number}","pulls_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/pulls{/number}","milestones_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/milestones{/number}","notifications_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/labels{/name}","releases_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/releases{/id}","deployments_url":"https://api.github.com/repos/AlwinEsch/screensaver.asteroids/deployments","created_at":"2016-08-12T01:21:59Z","updated_at":"2018-10-15T11:31:26Z","pushed_at":"2018-10-21T16:59:05Z","git_url":"git://github.com/AlwinEsch/screensaver.asteroids.git","ssh_url":"git@github.com:AlwinEsch/screensaver.asteroids.git","clone_url":"https://github.com/AlwinEsch/screensaver.asteroids.git","svn_url":"https://github.com/AlwinEsch/screensaver.asteroids","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"cc5facbe57c0a504ff768637c43a3191ffc0483b","user":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":24697813,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY5NzgxMw==","name":"screensaver.asteroids","full_name":"xbmc/screensaver.asteroids","private":false,"owner":{"login":"xbmc","id":199122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTEyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/199122?v=4","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xbmc/screensaver.asteroids","description":"Asteroids screensaver for Kodi","fork":false,"url":"https://api.github.com/repos/xbmc/screensaver.asteroids","forks_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/forks","keys_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/teams","hooks_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/hooks","issue_events_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/events","assignees_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/tags","blobs_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/languages","stargazers_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/stargazers","contributors_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/contributors","subscribers_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/subscribers","subscription_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/subscription","commits_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/merges","archive_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/downloads","issues_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/screensaver.asteroids/deployments","created_at":"2014-10-01T22:28:35Z","updated_at":"2018-10-31T12:18:04Z","pushed_at":"2018-10-31T12:24:45Z","git_url":"git://github.com/xbmc/screensaver.asteroids.git","ssh_url":"git@github.com:xbmc/screensaver.asteroids.git","clone_url":"https://github.com/xbmc/screensaver.asteroids.git","svn_url":"https://github.com/xbmc/screensaver.asteroids","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10"},"html":{"href":"https://github.com/xbmc/screensaver.asteroids/pull/10"},"issue":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/10"},"comments":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/screensaver.asteroids/statuses/e3e4737fd727203891d8b9f142025f43f5f77daa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AlwinEsch"}}