{"action":"closed","issue":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/642","repository_url":"https://api.github.com/repos/MozillaReality/FirefoxReality","labels_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/642/labels{/name}","comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/642/comments","events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/642/events","html_url":"https://github.com/MozillaReality/FirefoxReality/issues/642","id":371208639,"node_id":"MDU6SXNzdWUzNzEyMDg2Mzk=","number":642,"title":"Make Error pages localizable","user":{"login":"Delphine","id":399020,"node_id":"MDQ6VXNlcjM5OTAyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/399020?v=4","gravatar_id":"","url":"https://api.github.com/users/Delphine","html_url":"https://github.com/Delphine","followers_url":"https://api.github.com/users/Delphine/followers","following_url":"https://api.github.com/users/Delphine/following{/other_user}","gists_url":"https://api.github.com/users/Delphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Delphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delphine/subscriptions","organizations_url":"https://api.github.com/users/Delphine/orgs","repos_url":"https://api.github.com/users/Delphine/repos","events_url":"https://api.github.com/users/Delphine/events{/privacy}","received_events_url":"https://api.github.com/users/Delphine/received_events","type":"User","site_admin":false},"labels":[{"id":1016287019,"node_id":"MDU6TGFiZWwxMDE2Mjg3MDE5","url":"https://api.github.com/repos/MozillaReality/FirefoxReality/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"cvan","id":203725,"node_id":"MDQ6VXNlcjIwMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/203725?v=4","gravatar_id":"","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},"assignees":[{"login":"cvan","id":203725,"node_id":"MDQ6VXNlcjIwMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/203725?v=4","gravatar_id":"","url":"https://api.github.com/users/cvan","html_url":"https://github.com/cvan","followers_url":"https://api.github.com/users/cvan/followers","following_url":"https://api.github.com/users/cvan/following{/other_user}","gists_url":"https://api.github.com/users/cvan/gists{/gist_id}","starred_url":"https://api.github.com/users/cvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvan/subscriptions","organizations_url":"https://api.github.com/users/cvan/orgs","repos_url":"https://api.github.com/users/cvan/repos","events_url":"https://api.github.com/users/cvan/events{/privacy}","received_events_url":"https://api.github.com/users/cvan/received_events","type":"User","site_admin":false},{"login":"keianhzo","id":837184,"node_id":"MDQ6VXNlcjgzNzE4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/837184?v=4","gravatar_id":"","url":"https://api.github.com/users/keianhzo","html_url":"https://github.com/keianhzo","followers_url":"https://api.github.com/users/keianhzo/followers","following_url":"https://api.github.com/users/keianhzo/following{/other_user}","gists_url":"https://api.github.com/users/keianhzo/gists{/gist_id}","starred_url":"https://api.github.com/users/keianhzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keianhzo/subscriptions","organizations_url":"https://api.github.com/users/keianhzo/orgs","repos_url":"https://api.github.com/users/keianhzo/repos","events_url":"https://api.github.com/users/keianhzo/events{/privacy}","received_events_url":"https://api.github.com/users/keianhzo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-17T18:25:46Z","updated_at":"2018-10-25T11:09:31Z","closed_at":"2018-10-25T11:09:31Z","author_association":"NONE","body":"So I've had a few conversations with a number of people, and I get different information on what needs to be localized for error pages.\r\n\r\nSeems like you guys have Error pages here: \r\n* https://github.com/MozillaReality/FirefoxReality/blob/master/app/src/main/res/values/localpages.xml\r\nbut then there's also Android-Components here:\r\n* https://github.com/mozilla-mobile/android-components/blob/master/components/browser/errorpages/src/main/res/values/strings.xml\r\n\r\nThe Android-Components ErrorPages need to be localized no matter what, so since that's the first info I got (ie., that it was also needed for Reality), we started working on making it localizable. The work is, I believe, basically done (they fixed strings and added localization comments).\r\n\r\nMy question is: since these strings are basically the same, could you backport this work here? Isn't the plan to use a-c across mobile products as much as possible anyways?\r\nIf we can't do that, I'll open another issue and the same work will have to be done on the localpages.xml\r\n\r\nalso CC @pike"}}
{"actor":{"display_login":"keianhzo"}}