{"action":"created","issue":{"url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/107","repository_url":"https://api.github.com/repos/jaggedsoft/node-binance-api","labels_url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/107/comments","events_url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/107/events","html_url":"https://github.com/jaggedsoft/node-binance-api/issues/107","id":294799669,"number":107,"title":"Trade updates (websocket) are in fact Aggregate Trade streams","user":{"login":"aviggiano","id":3029017,"avatar_url":"https://avatars2.githubusercontent.com/u/3029017?v=4","gravatar_id":"","url":"https://api.github.com/users/aviggiano","html_url":"https://github.com/aviggiano","followers_url":"https://api.github.com/users/aviggiano/followers","following_url":"https://api.github.com/users/aviggiano/following{/other_user}","gists_url":"https://api.github.com/users/aviggiano/gists{/gist_id}","starred_url":"https://api.github.com/users/aviggiano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviggiano/subscriptions","organizations_url":"https://api.github.com/users/aviggiano/orgs","repos_url":"https://api.github.com/users/aviggiano/repos","events_url":"https://api.github.com/users/aviggiano/events{/privacy}","received_events_url":"https://api.github.com/users/aviggiano/received_events","type":"User","site_admin":false},"labels":[{"id":711853013,"url":"https://api.github.com/repos/jaggedsoft/node-binance-api/labels/feature-request","name":"feature-request","color":"7057ff","default":false}],"state":"open","locked":false,"assignee":{"login":"jaggedsoft","id":4283360,"avatar_url":"https://avatars3.githubusercontent.com/u/4283360?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggedsoft","html_url":"https://github.com/jaggedsoft","followers_url":"https://api.github.com/users/jaggedsoft/followers","following_url":"https://api.github.com/users/jaggedsoft/following{/other_user}","gists_url":"https://api.github.com/users/jaggedsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggedsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggedsoft/subscriptions","organizations_url":"https://api.github.com/users/jaggedsoft/orgs","repos_url":"https://api.github.com/users/jaggedsoft/repos","events_url":"https://api.github.com/users/jaggedsoft/events{/privacy}","received_events_url":"https://api.github.com/users/jaggedsoft/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaggedsoft","id":4283360,"avatar_url":"https://avatars3.githubusercontent.com/u/4283360?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggedsoft","html_url":"https://github.com/jaggedsoft","followers_url":"https://api.github.com/users/jaggedsoft/followers","following_url":"https://api.github.com/users/jaggedsoft/following{/other_user}","gists_url":"https://api.github.com/users/jaggedsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggedsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggedsoft/subscriptions","organizations_url":"https://api.github.com/users/jaggedsoft/orgs","repos_url":"https://api.github.com/users/jaggedsoft/repos","events_url":"https://api.github.com/users/jaggedsoft/events{/privacy}","received_events_url":"https://api.github.com/users/jaggedsoft/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-02-06T15:25:26Z","updated_at":"2018-02-06T21:32:16Z","closed_at":null,"author_association":"NONE","body":"Currently the `binance.websockets.trades` function subscribes to the [@aggTrade](https://github.com/jaggedsoft/node-binance-api/blob/master/node-binance-api.js#L906) stream, while there is a separate [@trade](https://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md#trade-streams) stream on the Binance API documentation.\r\n\r\nIt would be better if the current method was renamed `binance.websockets.aggTrades` and a new `binance.websockets.trades` was created, but I guess this would break the compatibility of this module. \r\n\r\nI propose then implementing a `binance.websockets.recentTrades` method (to maintain [this convention](https://github.com/jaggedsoft/node-binance-api/blob/master/node-binance-api.js#L752)) on the current version and maybe reevaluating if it is worth breaking the compatibility on the next major version of this module.\r\n\r\nWhat do you think about it? I can submit a PR."},"comment":{"url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/comments/363571544","html_url":"https://github.com/jaggedsoft/node-binance-api/issues/107#issuecomment-363571544","issue_url":"https://api.github.com/repos/jaggedsoft/node-binance-api/issues/107","id":363571544,"user":{"login":"jaggedsoft","id":4283360,"avatar_url":"https://avatars3.githubusercontent.com/u/4283360?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggedsoft","html_url":"https://github.com/jaggedsoft","followers_url":"https://api.github.com/users/jaggedsoft/followers","following_url":"https://api.github.com/users/jaggedsoft/following{/other_user}","gists_url":"https://api.github.com/users/jaggedsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggedsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggedsoft/subscriptions","organizations_url":"https://api.github.com/users/jaggedsoft/orgs","repos_url":"https://api.github.com/users/jaggedsoft/repos","events_url":"https://api.github.com/users/jaggedsoft/events{/privacy}","received_events_url":"https://api.github.com/users/jaggedsoft/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T21:32:16Z","updated_at":"2018-02-06T21:32:16Z","author_association":"OWNER","body":"More importantly, we need to support the `(symbol)@trade` websocket functionality\r\nhttps://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md#trade-streams"}}
{"actor":{"display_login":"jaggedsoft"}}