{"action":"created","comment":{"url":"https://api.github.com/repos/kubic-project/velum/pulls/comments/198080083","pull_request_review_id":131942051,"id":198080083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODA4MDA4Mw==","diff_hunk":"@@ -246,7 +246,7 @@ def proxy_enabled\n   end\n \n   def redirect_to_dashboard\n-    redirect_to root_path if setup_done?\n+    # redirect_to root_path if setup_done?","path":"app/controllers/setup_controller.rb","position":null,"original_position":5,"commit_id":"dd8714332688acd025cc73c7d94178dee95b687f","original_commit_id":"26054b7cfd8edae1835b43f32b99339ca756075e","user":{"login":"vitoravelino","id":188554,"node_id":"MDQ6VXNlcjE4ODU1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/188554?v=4","gravatar_id":"","url":"https://api.github.com/users/vitoravelino","html_url":"https://github.com/vitoravelino","followers_url":"https://api.github.com/users/vitoravelino/followers","following_url":"https://api.github.com/users/vitoravelino/following{/other_user}","gists_url":"https://api.github.com/users/vitoravelino/gists{/gist_id}","starred_url":"https://api.github.com/users/vitoravelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitoravelino/subscriptions","organizations_url":"https://api.github.com/users/vitoravelino/orgs","repos_url":"https://api.github.com/users/vitoravelino/repos","events_url":"https://api.github.com/users/vitoravelino/events{/privacy}","received_events_url":"https://api.github.com/users/vitoravelino/received_events","type":"User","site_admin":false},"body":"Yeah... Reverted. Thanks again! :sweat_smile: ","created_at":"2018-06-26T09:45:32Z","updated_at":"2018-06-26T09:45:32Z","html_url":"https://github.com/kubic-project/velum/pull/590#discussion_r198080083","pull_request_url":"https://api.github.com/repos/kubic-project/velum/pulls/590","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/comments/198080083"},"html":{"href":"https://github.com/kubic-project/velum/pull/590#discussion_r198080083"},"pull_request":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/590"}},"in_reply_to_id":198048697},"pull_request":{"url":"https://api.github.com/repos/kubic-project/velum/pulls/590","id":195853830,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODUzODMw","html_url":"https://github.com/kubic-project/velum/pull/590","diff_url":"https://github.com/kubic-project/velum/pull/590.diff","patch_url":"https://github.com/kubic-project/velum/pull/590.patch","issue_url":"https://api.github.com/repos/kubic-project/velum/issues/590","number":590,"state":"open","locked":false,"title":"Introduce admission webhook settings page","user":{"login":"flavio","id":22728,"node_id":"MDQ6VXNlcjIyNzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22728?v=4","gravatar_id":"","url":"https://api.github.com/users/flavio","html_url":"https://github.com/flavio","followers_url":"https://api.github.com/users/flavio/followers","following_url":"https://api.github.com/users/flavio/following{/other_user}","gists_url":"https://api.github.com/users/flavio/gists{/gist_id}","starred_url":"https://api.github.com/users/flavio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavio/subscriptions","organizations_url":"https://api.github.com/users/flavio/orgs","repos_url":"https://api.github.com/users/flavio/repos","events_url":"https://api.github.com/users/flavio/events{/privacy}","received_events_url":"https://api.github.com/users/flavio/received_events","type":"User","site_admin":false},"body":"Allow user to enable AdmissionWebhook by using a new dedicated page.\r\n\r\nTo work this requires the following PR merged into the salt repo: https://github.com/kubic-project/salt/pull/555\r\n\r\nThe new UI has to be improved by @vitoravelino, right now it looks something like that:\r\n\r\n![image](https://user-images.githubusercontent.com/22728/41604644-044be46a-73e0-11e8-850e-98d8d19f875a.png)\r\n\r\nThe workflow is the following one:\r\n  * go this new page\r\n  * upload key and certificate\r\n  * enable the feature\r\n  * deploy the cluster\r\n\r\nNotable things missing:\r\n- [X] Validate input (required)\r\n- [X] Fix UI\r\n- [X] Add tests\r\n- [x] Fix coverage\r\n","created_at":"2018-06-19T14:46:51Z","updated_at":"2018-06-26T09:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d99979d068bfd0e8527477afdd0cb9e800ee734a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubic-project/velum/pulls/590/commits","review_comments_url":"https://api.github.com/repos/kubic-project/velum/pulls/590/comments","review_comment_url":"https://api.github.com/repos/kubic-project/velum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubic-project/velum/issues/590/comments","statuses_url":"https://api.github.com/repos/kubic-project/velum/statuses/dd8714332688acd025cc73c7d94178dee95b687f","head":{"label":"kubic-project:admission_webhook","ref":"admission_webhook","sha":"dd8714332688acd025cc73c7d94178dee95b687f","user":{"login":"kubic-project","id":25507587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NTg3","avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"repo":{"id":78631630,"node_id":"MDEwOlJlcG9zaXRvcnk3ODYzMTYzMA==","name":"velum","full_name":"kubic-project/velum","owner":{"login":"kubic-project","id":25507587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NTg3","avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubic-project/velum","description":"Dashboard for CaaSP clusters","fork":false,"url":"https://api.github.com/repos/kubic-project/velum","forks_url":"https://api.github.com/repos/kubic-project/velum/forks","keys_url":"https://api.github.com/repos/kubic-project/velum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubic-project/velum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubic-project/velum/teams","hooks_url":"https://api.github.com/repos/kubic-project/velum/hooks","issue_events_url":"https://api.github.com/repos/kubic-project/velum/issues/events{/number}","events_url":"https://api.github.com/repos/kubic-project/velum/events","assignees_url":"https://api.github.com/repos/kubic-project/velum/assignees{/user}","branches_url":"https://api.github.com/repos/kubic-project/velum/branches{/branch}","tags_url":"https://api.github.com/repos/kubic-project/velum/tags","blobs_url":"https://api.github.com/repos/kubic-project/velum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubic-project/velum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubic-project/velum/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubic-project/velum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubic-project/velum/statuses/{sha}","languages_url":"https://api.github.com/repos/kubic-project/velum/languages","stargazers_url":"https://api.github.com/repos/kubic-project/velum/stargazers","contributors_url":"https://api.github.com/repos/kubic-project/velum/contributors","subscribers_url":"https://api.github.com/repos/kubic-project/velum/subscribers","subscription_url":"https://api.github.com/repos/kubic-project/velum/subscription","commits_url":"https://api.github.com/repos/kubic-project/velum/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubic-project/velum/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubic-project/velum/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubic-project/velum/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubic-project/velum/contents/{+path}","compare_url":"https://api.github.com/repos/kubic-project/velum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubic-project/velum/merges","archive_url":"https://api.github.com/repos/kubic-project/velum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubic-project/velum/downloads","issues_url":"https://api.github.com/repos/kubic-project/velum/issues{/number}","pulls_url":"https://api.github.com/repos/kubic-project/velum/pulls{/number}","milestones_url":"https://api.github.com/repos/kubic-project/velum/milestones{/number}","notifications_url":"https://api.github.com/repos/kubic-project/velum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubic-project/velum/labels{/name}","releases_url":"https://api.github.com/repos/kubic-project/velum/releases{/id}","deployments_url":"https://api.github.com/repos/kubic-project/velum/deployments","created_at":"2017-01-11T11:14:34Z","updated_at":"2018-06-22T14:09:14Z","pushed_at":"2018-06-26T09:22:53Z","git_url":"git://github.com/kubic-project/velum.git","ssh_url":"git@github.com:kubic-project/velum.git","clone_url":"https://github.com/kubic-project/velum.git","svn_url":"https://github.com/kubic-project/velum","homepage":"https://www.suse.com/","size":2006,"stargazers_count":45,"watchers_count":45,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":19,"watchers":45,"default_branch":"master"}},"base":{"label":"kubic-project:master","ref":"master","sha":"80000d63fed98ba9f7c2320f8180856e0d756e64","user":{"login":"kubic-project","id":25507587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NTg3","avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"repo":{"id":78631630,"node_id":"MDEwOlJlcG9zaXRvcnk3ODYzMTYzMA==","name":"velum","full_name":"kubic-project/velum","owner":{"login":"kubic-project","id":25507587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NTg3","avatar_url":"https://avatars2.githubusercontent.com/u/25507587?v=4","gravatar_id":"","url":"https://api.github.com/users/kubic-project","html_url":"https://github.com/kubic-project","followers_url":"https://api.github.com/users/kubic-project/followers","following_url":"https://api.github.com/users/kubic-project/following{/other_user}","gists_url":"https://api.github.com/users/kubic-project/gists{/gist_id}","starred_url":"https://api.github.com/users/kubic-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubic-project/subscriptions","organizations_url":"https://api.github.com/users/kubic-project/orgs","repos_url":"https://api.github.com/users/kubic-project/repos","events_url":"https://api.github.com/users/kubic-project/events{/privacy}","received_events_url":"https://api.github.com/users/kubic-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubic-project/velum","description":"Dashboard for CaaSP clusters","fork":false,"url":"https://api.github.com/repos/kubic-project/velum","forks_url":"https://api.github.com/repos/kubic-project/velum/forks","keys_url":"https://api.github.com/repos/kubic-project/velum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubic-project/velum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubic-project/velum/teams","hooks_url":"https://api.github.com/repos/kubic-project/velum/hooks","issue_events_url":"https://api.github.com/repos/kubic-project/velum/issues/events{/number}","events_url":"https://api.github.com/repos/kubic-project/velum/events","assignees_url":"https://api.github.com/repos/kubic-project/velum/assignees{/user}","branches_url":"https://api.github.com/repos/kubic-project/velum/branches{/branch}","tags_url":"https://api.github.com/repos/kubic-project/velum/tags","blobs_url":"https://api.github.com/repos/kubic-project/velum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubic-project/velum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubic-project/velum/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubic-project/velum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubic-project/velum/statuses/{sha}","languages_url":"https://api.github.com/repos/kubic-project/velum/languages","stargazers_url":"https://api.github.com/repos/kubic-project/velum/stargazers","contributors_url":"https://api.github.com/repos/kubic-project/velum/contributors","subscribers_url":"https://api.github.com/repos/kubic-project/velum/subscribers","subscription_url":"https://api.github.com/repos/kubic-project/velum/subscription","commits_url":"https://api.github.com/repos/kubic-project/velum/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubic-project/velum/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubic-project/velum/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubic-project/velum/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubic-project/velum/contents/{+path}","compare_url":"https://api.github.com/repos/kubic-project/velum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubic-project/velum/merges","archive_url":"https://api.github.com/repos/kubic-project/velum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubic-project/velum/downloads","issues_url":"https://api.github.com/repos/kubic-project/velum/issues{/number}","pulls_url":"https://api.github.com/repos/kubic-project/velum/pulls{/number}","milestones_url":"https://api.github.com/repos/kubic-project/velum/milestones{/number}","notifications_url":"https://api.github.com/repos/kubic-project/velum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubic-project/velum/labels{/name}","releases_url":"https://api.github.com/repos/kubic-project/velum/releases{/id}","deployments_url":"https://api.github.com/repos/kubic-project/velum/deployments","created_at":"2017-01-11T11:14:34Z","updated_at":"2018-06-22T14:09:14Z","pushed_at":"2018-06-26T09:22:53Z","git_url":"git://github.com/kubic-project/velum.git","ssh_url":"git@github.com:kubic-project/velum.git","clone_url":"https://github.com/kubic-project/velum.git","svn_url":"https://github.com/kubic-project/velum","homepage":"https://www.suse.com/","size":2006,"stargazers_count":45,"watchers_count":45,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":19,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/590"},"html":{"href":"https://github.com/kubic-project/velum/pull/590"},"issue":{"href":"https://api.github.com/repos/kubic-project/velum/issues/590"},"comments":{"href":"https://api.github.com/repos/kubic-project/velum/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubic-project/velum/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/kubic-project/velum/statuses/dd8714332688acd025cc73c7d94178dee95b687f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vitoravelino"}}