{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3605","repository_url":"https://api.github.com/repos/scikit-image/scikit-image","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3605/labels{/name}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3605/comments","events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3605/events","html_url":"https://github.com/scikit-image/scikit-image/issues/3605","id":392226610,"node_id":"MDU6SXNzdWUzOTIyMjY2MTA=","number":3605,"title":"threshold_li changed from version 0.14.0 to version 0.14.1","user":{"login":"paulmueller","id":2853022,"node_id":"MDQ6VXNlcjI4NTMwMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/2853022?v=4","gravatar_id":"","url":"https://api.github.com/users/paulmueller","html_url":"https://github.com/paulmueller","followers_url":"https://api.github.com/users/paulmueller/followers","following_url":"https://api.github.com/users/paulmueller/following{/other_user}","gists_url":"https://api.github.com/users/paulmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmueller/subscriptions","organizations_url":"https://api.github.com/users/paulmueller/orgs","repos_url":"https://api.github.com/users/paulmueller/repos","events_url":"https://api.github.com/users/paulmueller/events{/privacy}","received_events_url":"https://api.github.com/users/paulmueller/received_events","type":"User","site_admin":false},"labels":[{"id":1082881036,"node_id":"MDU6TGFiZWwxMDgyODgxMDM2","url":"https://api.github.com/repos/scikit-image/scikit-image/labels/priority:%20critical","name":"priority: critical","color":"ff0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/11","html_url":"https://github.com/scikit-image/scikit-image/milestone/11","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones/11/labels","id":3582934,"node_id":"MDk6TWlsZXN0b25lMzU4MjkzNA==","number":11,"title":"0.14.2","description":"","creator":{"login":"soupault","id":1315589,"node_id":"MDQ6VXNlcjEzMTU1ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1315589?v=4","gravatar_id":"","url":"https://api.github.com/users/soupault","html_url":"https://github.com/soupault","followers_url":"https://api.github.com/users/soupault/followers","following_url":"https://api.github.com/users/soupault/following{/other_user}","gists_url":"https://api.github.com/users/soupault/gists{/gist_id}","starred_url":"https://api.github.com/users/soupault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupault/subscriptions","organizations_url":"https://api.github.com/users/soupault/orgs","repos_url":"https://api.github.com/users/soupault/repos","events_url":"https://api.github.com/users/soupault/events{/privacy}","received_events_url":"https://api.github.com/users/soupault/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":18,"state":"open","created_at":"2018-08-20T10:23:00Z","updated_at":"2018-12-20T06:45:40Z","due_on":"2018-12-01T08:00:00Z","closed_at":null},"comments":7,"created_at":"2018-12-18T16:09:24Z","updated_at":"2018-12-20T07:03:00Z","closed_at":null,"author_association":"NONE","body":"## Description\r\nThe code for threshold_li in filters/thresholding.py changed from version 0.14.0 to 0.14.1. The new method does not work at all for my images.\r\n\r\nExample data (test.npy must be unzipped): [test.zip](https://github.com/scikit-image/scikit-image/files/2691279/test.zip)\r\n\r\n```python\r\nimport matplotlib.pylab as plt\r\nimport numpy as np\r\nfrom skimage.filters import threshold_li\r\n\r\nimage = np.load(\"test.npy\")\r\nthresh = threshold_li(image)\r\n\r\nax1 = plt.subplot(121)\r\nax1.imshow(image)\r\n\r\nax2 = plt.subplot(122)\r\nax2 = plt.imshow(image > thresh)\r\n\r\nplt.savefig(\"result.png\")\r\n```\r\n\r\nOld code (0.14.0):\r\nhttps://github.com/scikit-image/scikit-image/blob/v0.14.0/skimage/filters/thresholding.py#L519-L533\r\n![result_14 0](https://user-images.githubusercontent.com/2853022/50166366-374ced00-02e7-11e9-8150-adf119dc6774.png)\r\n\r\nNew code (0.14.1):\r\nhttps://github.com/scikit-image/scikit-image/blob/v0.14.1/skimage/filters/thresholding.py#L594-L604\r\n![result_14 1](https://user-images.githubusercontent.com/2853022/50166481-754a1100-02e7-11e9-8e8f-8fffb079424d.png)\r\n\r\nNot sure whether this change is intended. The while loop in the new code seems to be different. For one, the parameter ``threshold`` is not used there."},"comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments/448895402","html_url":"https://github.com/scikit-image/scikit-image/issues/3605#issuecomment-448895402","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/3605","id":448895402,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODg5NTQwMg==","user":{"login":"stefanv","id":45071,"node_id":"MDQ6VXNlcjQ1MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/45071?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanv","html_url":"https://github.com/stefanv","followers_url":"https://api.github.com/users/stefanv/followers","following_url":"https://api.github.com/users/stefanv/following{/other_user}","gists_url":"https://api.github.com/users/stefanv/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanv/subscriptions","organizations_url":"https://api.github.com/users/stefanv/orgs","repos_url":"https://api.github.com/users/stefanv/repos","events_url":"https://api.github.com/users/stefanv/events{/privacy}","received_events_url":"https://api.github.com/users/stefanv/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T07:03:00Z","updated_at":"2018-12-20T07:03:00Z","author_association":"MEMBER","body":"On Wed, 19 Dec 2018 22:37:17 -0800, François Boulogne wrote:\n> My opinion: Keep the new version that sticks to the original\n> implementation. Change the default tolerance (It's not problematic\n> since we changed the implementation). Backport in 0.14.2. Add all this\n> in the notes :)\n\nChanging public API in a point release is problematic.  Even if we\nconsider this a bug-fix of sorts, I recommend a warning to the user.\n"}}
{"actor":{"display_login":"stefanv"}}