{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/244964036","pull_request_review_id":188966101,"id":244964036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk2NDAzNg==","diff_hunk":"@@ -4376,37 +4376,6 @@ def __repr__(self):\n         return self.label\n \n \n-class KnownEventType(Base):","path":"airflow/models/__init__.py","position":4,"original_position":4,"commit_id":"3456efbd1bc75504cd76867e242c2fbddfe88ac3","original_commit_id":"3456efbd1bc75504cd76867e242c2fbddfe88ac3","user":{"login":"XD-DENG","id":11539188,"node_id":"MDQ6VXNlcjExNTM5MTg4","avatar_url":"https://avatars1.githubusercontent.com/u/11539188?v=4","gravatar_id":"","url":"https://api.github.com/users/XD-DENG","html_url":"https://github.com/XD-DENG","followers_url":"https://api.github.com/users/XD-DENG/followers","following_url":"https://api.github.com/users/XD-DENG/following{/other_user}","gists_url":"https://api.github.com/users/XD-DENG/gists{/gist_id}","starred_url":"https://api.github.com/users/XD-DENG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XD-DENG/subscriptions","organizations_url":"https://api.github.com/users/XD-DENG/orgs","repos_url":"https://api.github.com/users/XD-DENG/repos","events_url":"https://api.github.com/users/XD-DENG/events{/privacy}","received_events_url":"https://api.github.com/users/XD-DENG/received_events","type":"User","site_admin":false},"body":"Makes sense to me.","created_at":"2019-01-03T10:50:18Z","updated_at":"2019-01-03T10:50:18Z","html_url":"https://github.com/apache/incubator-airflow/pull/4421#discussion_r244964036","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/244964036"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/4421#discussion_r244964036"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421"}},"in_reply_to_id":244755307},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421","id":241692855,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjkyODU1","html_url":"https://github.com/apache/incubator-airflow/pull/4421","diff_url":"https://github.com/apache/incubator-airflow/pull/4421.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/4421.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4421","number":4421,"state":"open","locked":false,"title":"[AIRFLOW-3468] Remove KnownEvent(Event)?","user":{"login":"Fokko","id":1134248,"node_id":"MDQ6VXNlcjExMzQyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1134248?v=4","gravatar_id":"","url":"https://api.github.com/users/Fokko","html_url":"https://github.com/Fokko","followers_url":"https://api.github.com/users/Fokko/followers","following_url":"https://api.github.com/users/Fokko/following{/other_user}","gists_url":"https://api.github.com/users/Fokko/gists{/gist_id}","starred_url":"https://api.github.com/users/Fokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fokko/subscriptions","organizations_url":"https://api.github.com/users/Fokko/orgs","repos_url":"https://api.github.com/users/Fokko/repos","events_url":"https://api.github.com/users/Fokko/events{/privacy}","received_events_url":"https://api.github.com/users/Fokko/received_events","type":"User","site_admin":false},"body":"The KnownEvent and KnownEventType aren't used by 99% of the companies and therefore we would like to deprecate this for Airflow 2.0. Also, this isn't available in the new RBAC view.\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-3468\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-XXX\r\n  - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-3468\\], code changes always need a Jira issue.\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n  - All the public functions and the classes in the PR contain docstrings that explain what it does\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `flake8`\r\n","created_at":"2019-01-02T08:33:17Z","updated_at":"2019-01-03T10:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20f605dd3d68c427307dccf5401c6bc1e5f66264","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4421/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/3456efbd1bc75504cd76867e242c2fbddfe88ac3","head":{"label":"Fokko:AIRFLOW-3468","ref":"AIRFLOW-3468","sha":"3456efbd1bc75504cd76867e242c2fbddfe88ac3","user":{"login":"Fokko","id":1134248,"node_id":"MDQ6VXNlcjExMzQyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1134248?v=4","gravatar_id":"","url":"https://api.github.com/users/Fokko","html_url":"https://github.com/Fokko","followers_url":"https://api.github.com/users/Fokko/followers","following_url":"https://api.github.com/users/Fokko/following{/other_user}","gists_url":"https://api.github.com/users/Fokko/gists{/gist_id}","starred_url":"https://api.github.com/users/Fokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fokko/subscriptions","organizations_url":"https://api.github.com/users/Fokko/orgs","repos_url":"https://api.github.com/users/Fokko/repos","events_url":"https://api.github.com/users/Fokko/events{/privacy}","received_events_url":"https://api.github.com/users/Fokko/received_events","type":"User","site_admin":false},"repo":{"id":60533353,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzMzM1Mw==","name":"incubator-airflow","full_name":"Fokko/incubator-airflow","private":false,"owner":{"login":"Fokko","id":1134248,"node_id":"MDQ6VXNlcjExMzQyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1134248?v=4","gravatar_id":"","url":"https://api.github.com/users/Fokko","html_url":"https://github.com/Fokko","followers_url":"https://api.github.com/users/Fokko/followers","following_url":"https://api.github.com/users/Fokko/following{/other_user}","gists_url":"https://api.github.com/users/Fokko/gists{/gist_id}","starred_url":"https://api.github.com/users/Fokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fokko/subscriptions","organizations_url":"https://api.github.com/users/Fokko/orgs","repos_url":"https://api.github.com/users/Fokko/repos","events_url":"https://api.github.com/users/Fokko/events{/privacy}","received_events_url":"https://api.github.com/users/Fokko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fokko/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/Fokko/incubator-airflow","forks_url":"https://api.github.com/repos/Fokko/incubator-airflow/forks","keys_url":"https://api.github.com/repos/Fokko/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fokko/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fokko/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/Fokko/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/Fokko/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/Fokko/incubator-airflow/events","assignees_url":"https://api.github.com/repos/Fokko/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/Fokko/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/Fokko/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/Fokko/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fokko/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fokko/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fokko/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fokko/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/Fokko/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/Fokko/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/Fokko/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/Fokko/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/Fokko/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/Fokko/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fokko/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fokko/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fokko/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fokko/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/Fokko/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fokko/incubator-airflow/merges","archive_url":"https://api.github.com/repos/Fokko/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fokko/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/Fokko/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/Fokko/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/Fokko/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/Fokko/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fokko/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/Fokko/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/Fokko/incubator-airflow/deployments","created_at":"2016-06-06T14:12:07Z","updated_at":"2019-01-02T08:25:39Z","pushed_at":"2019-01-02T12:57:00Z","git_url":"git://github.com/Fokko/incubator-airflow.git","ssh_url":"git@github.com:Fokko/incubator-airflow.git","clone_url":"https://github.com/Fokko/incubator-airflow.git","svn_url":"https://github.com/Fokko/incubator-airflow","homepage":"","size":32558,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ecc77c2bf706a61d1dd77b1a95a00b74f29f74e3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"incubator-airflow","full_name":"apache/incubator-airflow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2019-01-03T10:14:32Z","pushed_at":"2019-01-03T10:14:55Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"https://airflow.apache.org","size":29229,"stargazers_count":10426,"watchers_count":10426,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3660,"mirror_url":null,"archived":false,"open_issues_count":267,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3660,"open_issues":267,"watchers":10426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/4421"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/4421"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/4421/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/4421/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/3456efbd1bc75504cd76867e242c2fbddfe88ac3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"XD-DENG"}}