{"action":"created","comment":{"url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/comments/211106332","pull_request_review_id":147462255,"id":211106332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEwNjMzMg==","diff_hunk":"@@ -460,13 +461,67 @@ IOAudioStream *kXAudioEngine::createNewAudioStream(int chn,IOAudioStreamDirectio\n \t\t\tif(sampleBuffer && sampleBufferSize)\n \t\t\t\taudioStream->setSampleBuffer(sampleBuffer, sampleBufferSize);\n             \n-\t\t\t\t// This device only allows a single format and a choice of 2 different sample rates\n-            rate.fraction = 0;\n-            rate.whole = sampling_rate;\n-            audioStream->addAvailableFormat(&format, &rate, &rate);\n-            \n-\t\t\t\t// Finally, the IOAudioStream's current format needs to be indicated\n-            audioStream->setFormat(&format);\n+            if(hw->is_10k2){\n+                rate.fraction = 0;\n+                rate.whole = sampling_rate;\n+                format.fBitDepth = 24;\n+                format.fBitWidth = 32;\n+                audioStream->addAvailableFormat(&format, &rate, &rate);\n+                \n+                // Finally, the IOAudioStream's current format needs to be indicated\n+                audioStream->setFormat(&format);\n+                \n+                rate.whole = 44100;\n+                format.fBitDepth = 24;\n+                format.fBitWidth = 32;\n+                audioStream->addAvailableFormat(&format, &rate, &rate);\n+                \n+                if(!hw->is_edsp){\n+                    rate.whole = 88200;\n+                    format.fBitDepth = 24;\n+                    format.fBitWidth = 32;\n+                    audioStream->addAvailableFormat(&format, &rate, &rate);\n+                    \n+                    rate.whole = 96000;\n+                    format.fBitDepth = 24;\n+                    format.fBitWidth = 32;\n+                    audioStream->addAvailableFormat(&format, &rate, &rate);\n+                    \n+                    rate.whole = 176400;\n+                    format.fBitDepth = 24;\n+                    format.fBitWidth = 32;\n+                    audioStream->addAvailableFormat(&format, &rate, &rate);\n+                }\n+            }else{\n+                rate.fraction = 0;\n+                rate.whole = sampling_rate;\n+                format.fBitDepth = 16;\n+                format.fBitWidth = 16;\n+                audioStream->addAvailableFormat(&format, &rate, &rate);\n+                \n+                // Finally, the IOAudioStream's current format needs to be indicated\n+                audioStream->setFormat(&format);\n+                \n+                rate.whole = 44100;","path":"macosx/kext/AudioEngine.cpp","position":474,"original_position":60,"commit_id":"05ecab2f894f7d04ba3c70ef3294491c951f6d6b","original_commit_id":"b7659261b11a1067537a5b42a89c58c5061abb6f","user":{"login":"kxproject","id":4704238,"node_id":"MDQ6VXNlcjQ3MDQyMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4704238?v=4","gravatar_id":"","url":"https://api.github.com/users/kxproject","html_url":"https://github.com/kxproject","followers_url":"https://api.github.com/users/kxproject/followers","following_url":"https://api.github.com/users/kxproject/following{/other_user}","gists_url":"https://api.github.com/users/kxproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kxproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxproject/subscriptions","organizations_url":"https://api.github.com/users/kxproject/orgs","repos_url":"https://api.github.com/users/kxproject/repos","events_url":"https://api.github.com/users/kxproject/events{/privacy}","received_events_url":"https://api.github.com/users/kxproject/received_events","type":"User","site_admin":false},"body":"44.1 is not supported on 10k1 devices without hardware SRC\r\nhardware SRC is much worse than modern software SRC implemented by apple in CoreAudio\r\nI doubt we need to support 44.1 on 10k1 devices\r\nThe same applies to 88.2, 96 and 176.4 below","created_at":"2018-08-19T15:19:17Z","updated_at":"2018-08-19T15:27:04Z","html_url":"https://github.com/kxproject/kx-audio-driver/pull/17#discussion_r211106332","pull_request_url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/comments/211106332"},"html":{"href":"https://github.com/kxproject/kx-audio-driver/pull/17#discussion_r211106332"},"pull_request":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17","id":209350618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzUwNjE4","html_url":"https://github.com/kxproject/kx-audio-driver/pull/17","diff_url":"https://github.com/kxproject/kx-audio-driver/pull/17.diff","patch_url":"https://github.com/kxproject/kx-audio-driver/pull/17.patch","issue_url":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/17","number":17,"state":"open","locked":false,"title":"Added support for inputs and sample rates(macOS)","user":{"login":"c0deSpace","id":38812709,"node_id":"MDQ6VXNlcjM4ODEyNzA5","avatar_url":"https://avatars0.githubusercontent.com/u/38812709?v=4","gravatar_id":"","url":"https://api.github.com/users/c0deSpace","html_url":"https://github.com/c0deSpace","followers_url":"https://api.github.com/users/c0deSpace/followers","following_url":"https://api.github.com/users/c0deSpace/following{/other_user}","gists_url":"https://api.github.com/users/c0deSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/c0deSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0deSpace/subscriptions","organizations_url":"https://api.github.com/users/c0deSpace/orgs","repos_url":"https://api.github.com/users/c0deSpace/repos","events_url":"https://api.github.com/users/c0deSpace/events{/privacy}","received_events_url":"https://api.github.com/users/c0deSpace/received_events","type":"User","site_admin":false},"body":"Added analog inputs and sample rates.\r\nThe buffer size is reduced, otherwise the recorded sound is cracked. Playback does not crack with increased and decreased buffer size. Tested on my E-MU 1616m. According to reports, Audigy (sb0092), SB Live (sb0102) also work well.","created_at":"2018-08-19T09:12:09Z","updated_at":"2018-08-19T15:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17/commits","review_comments_url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17/comments","review_comment_url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/17/comments","statuses_url":"https://api.github.com/repos/kxproject/kx-audio-driver/statuses/05ecab2f894f7d04ba3c70ef3294491c951f6d6b","head":{"label":"c0deSpace:master","ref":"master","sha":"05ecab2f894f7d04ba3c70ef3294491c951f6d6b","user":{"login":"c0deSpace","id":38812709,"node_id":"MDQ6VXNlcjM4ODEyNzA5","avatar_url":"https://avatars0.githubusercontent.com/u/38812709?v=4","gravatar_id":"","url":"https://api.github.com/users/c0deSpace","html_url":"https://github.com/c0deSpace","followers_url":"https://api.github.com/users/c0deSpace/followers","following_url":"https://api.github.com/users/c0deSpace/following{/other_user}","gists_url":"https://api.github.com/users/c0deSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/c0deSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0deSpace/subscriptions","organizations_url":"https://api.github.com/users/c0deSpace/orgs","repos_url":"https://api.github.com/users/c0deSpace/repos","events_url":"https://api.github.com/users/c0deSpace/events{/privacy}","received_events_url":"https://api.github.com/users/c0deSpace/received_events","type":"User","site_admin":false},"repo":{"id":136276581,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNzY1ODE=","name":"kx-audio-driver","full_name":"c0deSpace/kx-audio-driver","owner":{"login":"c0deSpace","id":38812709,"node_id":"MDQ6VXNlcjM4ODEyNzA5","avatar_url":"https://avatars0.githubusercontent.com/u/38812709?v=4","gravatar_id":"","url":"https://api.github.com/users/c0deSpace","html_url":"https://github.com/c0deSpace","followers_url":"https://api.github.com/users/c0deSpace/followers","following_url":"https://api.github.com/users/c0deSpace/following{/other_user}","gists_url":"https://api.github.com/users/c0deSpace/gists{/gist_id}","starred_url":"https://api.github.com/users/c0deSpace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0deSpace/subscriptions","organizations_url":"https://api.github.com/users/c0deSpace/orgs","repos_url":"https://api.github.com/users/c0deSpace/repos","events_url":"https://api.github.com/users/c0deSpace/events{/privacy}","received_events_url":"https://api.github.com/users/c0deSpace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c0deSpace/kx-audio-driver","description":"kX driver source code (for Windows and Mac)","fork":true,"url":"https://api.github.com/repos/c0deSpace/kx-audio-driver","forks_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/forks","keys_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/teams","hooks_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/hooks","issue_events_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/issues/events{/number}","events_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/events","assignees_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/assignees{/user}","branches_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/branches{/branch}","tags_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/tags","blobs_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/languages","stargazers_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/stargazers","contributors_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/contributors","subscribers_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/subscribers","subscription_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/subscription","commits_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/contents/{+path}","compare_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/merges","archive_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/downloads","issues_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/issues{/number}","pulls_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/labels{/name}","releases_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/releases{/id}","deployments_url":"https://api.github.com/repos/c0deSpace/kx-audio-driver/deployments","created_at":"2018-06-06T05:31:11Z","updated_at":"2018-08-18T16:48:53Z","pushed_at":"2018-08-18T16:48:52Z","git_url":"git://github.com/c0deSpace/kx-audio-driver.git","ssh_url":"git@github.com:c0deSpace/kx-audio-driver.git","clone_url":"https://github.com/c0deSpace/kx-audio-driver.git","svn_url":"https://github.com/c0deSpace/kx-audio-driver","homepage":"","size":13852,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kxproject:master","ref":"master","sha":"19d1e856533e475b702121c42fd9463855808947","user":{"login":"kxproject","id":4704238,"node_id":"MDQ6VXNlcjQ3MDQyMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4704238?v=4","gravatar_id":"","url":"https://api.github.com/users/kxproject","html_url":"https://github.com/kxproject","followers_url":"https://api.github.com/users/kxproject/followers","following_url":"https://api.github.com/users/kxproject/following{/other_user}","gists_url":"https://api.github.com/users/kxproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kxproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxproject/subscriptions","organizations_url":"https://api.github.com/users/kxproject/orgs","repos_url":"https://api.github.com/users/kxproject/repos","events_url":"https://api.github.com/users/kxproject/events{/privacy}","received_events_url":"https://api.github.com/users/kxproject/received_events","type":"User","site_admin":false},"repo":{"id":10704814,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwNDgxNA==","name":"kx-audio-driver","full_name":"kxproject/kx-audio-driver","owner":{"login":"kxproject","id":4704238,"node_id":"MDQ6VXNlcjQ3MDQyMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4704238?v=4","gravatar_id":"","url":"https://api.github.com/users/kxproject","html_url":"https://github.com/kxproject","followers_url":"https://api.github.com/users/kxproject/followers","following_url":"https://api.github.com/users/kxproject/following{/other_user}","gists_url":"https://api.github.com/users/kxproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kxproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kxproject/subscriptions","organizations_url":"https://api.github.com/users/kxproject/orgs","repos_url":"https://api.github.com/users/kxproject/repos","events_url":"https://api.github.com/users/kxproject/events{/privacy}","received_events_url":"https://api.github.com/users/kxproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kxproject/kx-audio-driver","description":"kX driver source code (for Windows and Mac)","fork":false,"url":"https://api.github.com/repos/kxproject/kx-audio-driver","forks_url":"https://api.github.com/repos/kxproject/kx-audio-driver/forks","keys_url":"https://api.github.com/repos/kxproject/kx-audio-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kxproject/kx-audio-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kxproject/kx-audio-driver/teams","hooks_url":"https://api.github.com/repos/kxproject/kx-audio-driver/hooks","issue_events_url":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/events{/number}","events_url":"https://api.github.com/repos/kxproject/kx-audio-driver/events","assignees_url":"https://api.github.com/repos/kxproject/kx-audio-driver/assignees{/user}","branches_url":"https://api.github.com/repos/kxproject/kx-audio-driver/branches{/branch}","tags_url":"https://api.github.com/repos/kxproject/kx-audio-driver/tags","blobs_url":"https://api.github.com/repos/kxproject/kx-audio-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kxproject/kx-audio-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kxproject/kx-audio-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/kxproject/kx-audio-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kxproject/kx-audio-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/kxproject/kx-audio-driver/languages","stargazers_url":"https://api.github.com/repos/kxproject/kx-audio-driver/stargazers","contributors_url":"https://api.github.com/repos/kxproject/kx-audio-driver/contributors","subscribers_url":"https://api.github.com/repos/kxproject/kx-audio-driver/subscribers","subscription_url":"https://api.github.com/repos/kxproject/kx-audio-driver/subscription","commits_url":"https://api.github.com/repos/kxproject/kx-audio-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/kxproject/kx-audio-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/kxproject/kx-audio-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/kxproject/kx-audio-driver/contents/{+path}","compare_url":"https://api.github.com/repos/kxproject/kx-audio-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kxproject/kx-audio-driver/merges","archive_url":"https://api.github.com/repos/kxproject/kx-audio-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kxproject/kx-audio-driver/downloads","issues_url":"https://api.github.com/repos/kxproject/kx-audio-driver/issues{/number}","pulls_url":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/kxproject/kx-audio-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/kxproject/kx-audio-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kxproject/kx-audio-driver/labels{/name}","releases_url":"https://api.github.com/repos/kxproject/kx-audio-driver/releases{/id}","deployments_url":"https://api.github.com/repos/kxproject/kx-audio-driver/deployments","created_at":"2013-06-15T10:14:37Z","updated_at":"2018-08-12T15:14:18Z","pushed_at":"2018-08-19T09:12:10Z","git_url":"git://github.com/kxproject/kx-audio-driver.git","ssh_url":"git@github.com:kxproject/kx-audio-driver.git","clone_url":"https://github.com/kxproject/kx-audio-driver.git","svn_url":"https://github.com/kxproject/kx-audio-driver","homepage":"","size":13785,"stargazers_count":68,"watchers_count":68,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":37,"open_issues":7,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17"},"html":{"href":"https://github.com/kxproject/kx-audio-driver/pull/17"},"issue":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/17"},"comments":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/kxproject/kx-audio-driver/statuses/05ecab2f894f7d04ba3c70ef3294491c951f6d6b"}},"author_association":"NONE"}}
{"actor":{"display_login":"kxproject"}}