{"action":"created","issue":{"url":"https://api.github.com/repos/4teamwork/opengever.core/issues/4397","repository_url":"https://api.github.com/repos/4teamwork/opengever.core","labels_url":"https://api.github.com/repos/4teamwork/opengever.core/issues/4397/labels{/name}","comments_url":"https://api.github.com/repos/4teamwork/opengever.core/issues/4397/comments","events_url":"https://api.github.com/repos/4teamwork/opengever.core/issues/4397/events","html_url":"https://github.com/4teamwork/opengever.core/pull/4397","id":329023695,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzgzNzMw","number":4397,"title":"Drop non-word meeting feature.","user":{"login":"deiferni","id":736583,"node_id":"MDQ6VXNlcjczNjU4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/736583?v=4","gravatar_id":"","url":"https://api.github.com/users/deiferni","html_url":"https://github.com/deiferni","followers_url":"https://api.github.com/users/deiferni/followers","following_url":"https://api.github.com/users/deiferni/following{/other_user}","gists_url":"https://api.github.com/users/deiferni/gists{/gist_id}","starred_url":"https://api.github.com/users/deiferni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deiferni/subscriptions","organizations_url":"https://api.github.com/users/deiferni/orgs","repos_url":"https://api.github.com/users/deiferni/repos","events_url":"https://api.github.com/users/deiferni/events{/privacy}","received_events_url":"https://api.github.com/users/deiferni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-04T11:54:56Z","updated_at":"2018-06-04T15:19:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/4teamwork/opengever.core/pulls/4397","html_url":"https://github.com/4teamwork/opengever.core/pull/4397","diff_url":"https://github.com/4teamwork/opengever.core/pull/4397.diff","patch_url":"https://github.com/4teamwork/opengever.core/pull/4397.patch"},"body":"With this PR there is only one way to do meetings, with word. We remove the non-word meeting features and different code-paths for non-word and word. Changes in this PR include but are not limited to:\r\n- remove `is_word_implementation_enabled` check and registry setting, replace with `is_meeting_feature_enabled` if needed or make sure we only use the word meeting code path that was protected with a check for the flag\r\n- port tests so that they work with the word based implementation, drop tests that tested no longer used features\r\n- drop trix editor, widgets, javascript, …. we no longer use trix in any other places, so i decided to yank it out entirely\r\n- running the upgrade will require `IMeetingSettings.is_word_implementation_enabled` to be `True` (only when `IMeetingSettings.is_feature_enabled` is `True`, of course), this is a necessary precondition to remove the non-word meeting stuff as otherwise data-loss will occur. if the flag is `False` a per-customer migration needs to be run first. The first upgrade acts as a guard and aborts if this condition is not met.\r\n- upgrades will then delete no longer used fields from objects and columns from the relational database. that data is already stored in annotations of files generated in an upgrade, see https://github.com/4teamwork/opengever.duerrenaesch/pull/30 for an example of a per-customer migration.\r\n- I have attempted split removal of functionality by subject area to maximise traceability, thus there are multiple upgrade-steps that migrate a separate content-type. This is necessary in any case as there is a mix of `UpgradeStep` and `SchemaMigration`.\r\n\r\nThis is a first batch that can be merged standalone and that gets a blocker out of the way. There will be follow-ups to rewrite ad merge some of the tests.\r\n\r\n⚠️ i will need to manually test:\r\n- [x] run the upgrades  content created on `master` (again)\r\n- [ ] manually test the whole meeting process in case there are gaps in our tests\r\n- [ ] test javascript as we removed a bunch of files\r\n\r\nCloses #3948."},"comment":{"url":"https://api.github.com/repos/4teamwork/opengever.core/issues/comments/394392894","html_url":"https://github.com/4teamwork/opengever.core/pull/4397#issuecomment-394392894","issue_url":"https://api.github.com/repos/4teamwork/opengever.core/issues/4397","id":394392894,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDM5Mjg5NA==","user":{"login":"deiferni","id":736583,"node_id":"MDQ6VXNlcjczNjU4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/736583?v=4","gravatar_id":"","url":"https://api.github.com/users/deiferni","html_url":"https://github.com/deiferni","followers_url":"https://api.github.com/users/deiferni/followers","following_url":"https://api.github.com/users/deiferni/following{/other_user}","gists_url":"https://api.github.com/users/deiferni/gists{/gist_id}","starred_url":"https://api.github.com/users/deiferni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deiferni/subscriptions","organizations_url":"https://api.github.com/users/deiferni/orgs","repos_url":"https://api.github.com/users/deiferni/repos","events_url":"https://api.github.com/users/deiferni/events{/privacy}","received_events_url":"https://api.github.com/users/deiferni/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T15:19:03Z","updated_at":"2018-06-04T15:19:03Z","author_association":"MEMBER","body":"❌ the committee select is not searchable any more ![screen shot 2018-06-04 at 17 18 28](https://user-images.githubusercontent.com/736583/40925973-5449ad56-681b-11e8-938e-4284032ed259.png)\r\n"}}
{"actor":{"display_login":"deiferni"}}