{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/7408","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/7408/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/7408/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/7408/events","html_url":"https://github.com/webpack/webpack/pull/7408","id":326770655,"number":7408,"title":"SideEffectsPlugin don't modify cache entries","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"labels":[{"id":572709861,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-not-ok","name":"PR: CI-not-ok","color":"d93f0b","default":false},{"id":572817354,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-26T22:10:16Z","updated_at":"2018-05-27T20:11:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/7408","html_url":"https://github.com/webpack/webpack/pull/7408","diff_url":"https://github.com/webpack/webpack/pull/7408.diff","patch_url":"https://github.com/webpack/webpack/pull/7408.patch"},"body":"fix bug where modules are incorrectly including in chunks\r\n\r\nfixes #7400\r\n\r\n<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n\r\n<!-- In addition to that please answer these questions: -->\r\n\r\n**What kind of change does this PR introduce?**\r\nbugfix\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\n**Did you add tests for your changes?**\r\nyes\r\n<!-- Note that we won't merge your changes if you don't add tests -->\r\n\r\n**Does this PR introduce a breaking change?**\r\nyes, but its a bugfix\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n**What needs to be documented once your changes are merged?**\r\nnothing\r\n<!-- List all the information that needs to be added to the documentation after merge -->\r\n<!-- When your changes are merged you will be asked to contribute this to the documentation -->\r\n"},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/392362660","html_url":"https://github.com/webpack/webpack/pull/7408#issuecomment-392362660","issue_url":"https://api.github.com/repos/webpack/webpack/issues/7408","id":392362660,"user":{"login":"webpack-bot","id":26676291,"avatar_url":"https://avatars0.githubusercontent.com/u/26676291?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-bot","html_url":"https://github.com/webpack-bot","followers_url":"https://api.github.com/users/webpack-bot/followers","following_url":"https://api.github.com/users/webpack-bot/following{/other_user}","gists_url":"https://api.github.com/users/webpack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-bot/subscriptions","organizations_url":"https://api.github.com/users/webpack-bot/orgs","repos_url":"https://api.github.com/users/webpack-bot/repos","events_url":"https://api.github.com/users/webpack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T20:11:05Z","updated_at":"2018-05-27T20:11:05Z","author_association":"NONE","body":"<!-- identifier: ci-result -->\n\nThe basic integration tests succeeded, but the full suite failed.\n\n@sokra Please review the following output log for errors:\n\n```text\n$ rimraf coverage\n(node:3890) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead\n(node:3890) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead\nFAIL test/MultiCompiler.test.js (24.725s)\n  ● MultiCompiler › should trigger 'run' for each child compiler\n\n    Timeout - Async callback was not invoked within the 20000ms timeout specified by jest.setTimeout.\n\n      24 | \tjest.setTimeout(20000);\n      25 | \n    > 26 | \tit(\"should trigger 'run' for each child compiler\", done => {\n         | \t^\n      27 | \t\tconst compiler = createMultiCompiler();\n      28 | \t\tlet called = 0;\n      29 | \n\n      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)\n      at Suite.<anonymous> (test/MultiCompiler.test.js:26:2)\n\nFAIL test/NodeTemplatePlugin.test.js (8.261s)\n  ● NodeTemplatePlugin › should compile and run a simple module\n\n    Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.\n\n       6 | \n       7 | describe(\"NodeTemplatePlugin\", () => {\n    >  8 | \tit(\"should compile and run a simple module\", done => {\n         | \t^\n       9 | \t\twebpack(\n      10 | \t\t\t{\n      11 | \t\t\t\tmode: \"production\",\n\n      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)\n      at Suite.Object.<anonymous>.describe (test/NodeTemplatePlugin.test.js:8:2)\n\n\n=============================== Coverage summary ===============================\nStatements   : 89.8% ( 13123/14613 )\nBranches     : 81.17% ( 5909/7280 )\nFunctions    : 89.15% ( 2203/2471 )\nLines        : 91.32% ( 12461/13645 )\n================================================================================\n\nSummary of all failing tests\nFAIL test/MultiCompiler.test.js (24.725s)\n  ● MultiCompiler › should trigger 'run' for each child compiler\n\n    Timeout - Async callback was not invoked within the 20000ms timeout specified by jest.setTimeout.\n\n      24 | \tjest.setTimeout(20000);\n      25 | \n    > 26 | \tit(\"should trigger 'run' for each child compiler\", done => {\n         | \t^\n      27 | \t\tconst compiler = createMultiCompiler();\n      28 | \t\tlet called = 0;\n      29 | \n\n      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)\n      at Suite.<anonymous> (test/MultiCompiler.test.js:26:2)\n\nFAIL test/NodeTemplatePlugin.test.js (8.261s)\n  ● NodeTemplatePlugin › should compile and run a simple module\n\n    Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.\n\n       6 | \n       7 | describe(\"NodeTemplatePlugin\", () => {\n    >  8 | \tit(\"should compile and run a simple module\", done => {\n         | \t^\n       9 | \t\twebpack(\n      10 | \t\t\t{\n      11 | \t\t\t\tmode: \"production\",\n\n      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:85:20)\n      at Suite.Object.<anonymous>.describe (test/NodeTemplatePlugin.test.js:8:2)\n```\n\n```text\nTest Suites: 2 failed, 3 skipped, 22 passed, 24 of 27 total\nTests:       2 failed, 63 skipped, 7033 passed, 7098 total\nSnapshots:   79 passed, 79 total\nTime:        249.632s\nRan all test suites matching /test\\/((?!TestCases)|TestCasesD)/i.\nForce exiting Jest\n\nHave you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?\nerror Command failed with exit code 1.\ninfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\nerror Command failed with exit code 1.\ninfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\n```\n\nSee [complete report here](https://travis-ci.org/webpack/webpack/builds/384470443?utm_source&#x3D;github_status&amp;utm_medium&#x3D;notification)."}}
{"actor":{"display_login":"webpack-bot"}}