{"action":"created","comment":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/232437940","pull_request_review_id":173644392,"id":232437940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQzNzk0MA==","diff_hunk":"@@ -661,6 +728,31 @@ void ILibraryAppletCreator::CreateStorage(Kernel::HLERequestContext& ctx) {\n     LOG_DEBUG(Service_AM, \"called, size={}\", size);\n }\n \n+void ILibraryAppletCreator::CreateTransferMemoryStorage(Kernel::HLERequestContext& ctx) {\n+    IPC::RequestParser rp{ctx};\n+\n+    rp.SetCurrentOffset(3);\n+    const auto handle{rp.Pop<Kernel::Handle>()};\n+\n+    const auto shared_mem =\n+        Core::System::GetInstance().CurrentProcess()->GetHandleTable().Get<Kernel::SharedMemory>(\n+            handle);\n+\n+    if (shared_mem == nullptr) {\n+        IPC::ResponseBuilder rb{ctx, 2};\n+        rb.Push(ResultCode(-1));\n+        return;\n+    }\n+\n+    std::vector<u8> memory(shared_mem->size);","path":"src/core/hle/service/am/am.cpp","position":379,"original_position":379,"commit_id":"3b360fd9b1eaef98f37c69f41dab5b55595b2f3a","original_commit_id":"3b360fd9b1eaef98f37c69f41dab5b55595b2f3a","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"```cpp\r\nconst auto begin = shared_mem->backing_block.begin() + shared_mem->backing_block_offset;\r\nconst auto end = begin + shared_mem->size;\r\nstd::vector<u8> memory{begin, end};\r\n```\r\n\r\nwill do the same thing without the need to initialize a zeroed out container first.","created_at":"2018-11-10T02:18:53Z","updated_at":"2018-11-10T02:33:23Z","html_url":"https://github.com/yuzu-emu/yuzu/pull/1667#discussion_r232437940","pull_request_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/232437940"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1667#discussion_r232437940"},"pull_request":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667"}}},"pull_request":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667","id":229861758,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODYxNzU4","html_url":"https://github.com/yuzu-emu/yuzu/pull/1667","diff_url":"https://github.com/yuzu-emu/yuzu/pull/1667.diff","patch_url":"https://github.com/yuzu-emu/yuzu/pull/1667.patch","issue_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1667","number":1667,"state":"open","locked":false,"title":"am: Implement HLE software keyboard applet","user":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"body":"Used by Minecraft, Pokken Tournament, Stardew Valley, and some other indie games.\r\nPrompts a dialog when the game requests the swkbd, uses the same validation as the real game.\r\n\r\nBig thanks to @misson20000 for his help with understanding applets and hwtest (https://github.com/misson20000/swkbd-demo)\r\n\r\nAlso adds TransferMemory, as this is used by the swkbd for some of the data transfer.","created_at":"2018-11-10T01:44:54Z","updated_at":"2018-11-10T02:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40366ea60ec7158d3ba89aad1c306a28059e6342","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1102847179,"node_id":"MDU6TGFiZWwxMTAyODQ3MTc5","url":"https://api.github.com/repos/yuzu-emu/yuzu/labels/frontend","name":"frontend","color":"d33f84","default":false},{"id":1110454061,"node_id":"MDU6TGFiZWwxMTEwNDU0MDYx","url":"https://api.github.com/repos/yuzu-emu/yuzu/labels/hle","name":"hle","color":"86e542","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667/commits","review_comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667/comments","review_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1667/comments","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/3b360fd9b1eaef98f37c69f41dab5b55595b2f3a","head":{"label":"DarkLordZach:swkbd","ref":"swkbd","sha":"3b360fd9b1eaef98f37c69f41dab5b55595b2f3a","user":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"repo":{"id":137008966,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwMDg5NjY=","name":"yuzu","full_name":"DarkLordZach/yuzu","private":false,"owner":{"login":"DarkLordZach","id":5064800,"node_id":"MDQ6VXNlcjUwNjQ4MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5064800?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkLordZach","html_url":"https://github.com/DarkLordZach","followers_url":"https://api.github.com/users/DarkLordZach/followers","following_url":"https://api.github.com/users/DarkLordZach/following{/other_user}","gists_url":"https://api.github.com/users/DarkLordZach/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkLordZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkLordZach/subscriptions","organizations_url":"https://api.github.com/users/DarkLordZach/orgs","repos_url":"https://api.github.com/users/DarkLordZach/repos","events_url":"https://api.github.com/users/DarkLordZach/events{/privacy}","received_events_url":"https://api.github.com/users/DarkLordZach/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DarkLordZach/yuzu","description":"Nintendo Switch Emulator","fork":true,"url":"https://api.github.com/repos/DarkLordZach/yuzu","forks_url":"https://api.github.com/repos/DarkLordZach/yuzu/forks","keys_url":"https://api.github.com/repos/DarkLordZach/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkLordZach/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkLordZach/yuzu/teams","hooks_url":"https://api.github.com/repos/DarkLordZach/yuzu/hooks","issue_events_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/DarkLordZach/yuzu/events","assignees_url":"https://api.github.com/repos/DarkLordZach/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/DarkLordZach/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/DarkLordZach/yuzu/tags","blobs_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkLordZach/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkLordZach/yuzu/languages","stargazers_url":"https://api.github.com/repos/DarkLordZach/yuzu/stargazers","contributors_url":"https://api.github.com/repos/DarkLordZach/yuzu/contributors","subscribers_url":"https://api.github.com/repos/DarkLordZach/yuzu/subscribers","subscription_url":"https://api.github.com/repos/DarkLordZach/yuzu/subscription","commits_url":"https://api.github.com/repos/DarkLordZach/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkLordZach/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkLordZach/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkLordZach/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/DarkLordZach/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkLordZach/yuzu/merges","archive_url":"https://api.github.com/repos/DarkLordZach/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkLordZach/yuzu/downloads","issues_url":"https://api.github.com/repos/DarkLordZach/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/DarkLordZach/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkLordZach/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkLordZach/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkLordZach/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/DarkLordZach/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/DarkLordZach/yuzu/deployments","created_at":"2018-06-12T02:55:08Z","updated_at":"2018-09-23T13:19:09Z","pushed_at":"2018-11-10T01:38:22Z","git_url":"git://github.com/DarkLordZach/yuzu.git","ssh_url":"git@github.com:DarkLordZach/yuzu.git","clone_url":"https://github.com/DarkLordZach/yuzu.git","svn_url":"https://github.com/DarkLordZach/yuzu","homepage":"","size":25718,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"yuzu-emu:master","ref":"master","sha":"29f082775b400c56d7afe45b84ad8821e255f127","user":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":116167731,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjc3MzE=","name":"yuzu","full_name":"yuzu-emu/yuzu","private":false,"owner":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yuzu-emu/yuzu","description":"Nintendo Switch Emulator","fork":false,"url":"https://api.github.com/repos/yuzu-emu/yuzu","forks_url":"https://api.github.com/repos/yuzu-emu/yuzu/forks","keys_url":"https://api.github.com/repos/yuzu-emu/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzu-emu/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzu-emu/yuzu/teams","hooks_url":"https://api.github.com/repos/yuzu-emu/yuzu/hooks","issue_events_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/yuzu-emu/yuzu/events","assignees_url":"https://api.github.com/repos/yuzu-emu/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/yuzu-emu/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/tags","blobs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzu-emu/yuzu/languages","stargazers_url":"https://api.github.com/repos/yuzu-emu/yuzu/stargazers","contributors_url":"https://api.github.com/repos/yuzu-emu/yuzu/contributors","subscribers_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscribers","subscription_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscription","commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzu-emu/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/yuzu-emu/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzu-emu/yuzu/merges","archive_url":"https://api.github.com/repos/yuzu-emu/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzu-emu/yuzu/downloads","issues_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzu-emu/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzu-emu/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzu-emu/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/yuzu-emu/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/yuzu-emu/yuzu/deployments","created_at":"2018-01-03T18:13:57Z","updated_at":"2018-11-09T21:44:54Z","pushed_at":"2018-11-10T01:44:54Z","git_url":"git://github.com/yuzu-emu/yuzu.git","ssh_url":"git@github.com:yuzu-emu/yuzu.git","clone_url":"https://github.com/yuzu-emu/yuzu.git","svn_url":"https://github.com/yuzu-emu/yuzu","homepage":"","size":25265,"stargazers_count":5430,"watchers_count":5430,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":328,"open_issues":72,"watchers":5430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1667"},"issue":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1667"},"comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1667/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1667/commits"},"statuses":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/3b360fd9b1eaef98f37c69f41dab5b55595b2f3a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lioncash"}}