{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4993","repository_url":"https://api.github.com/repos/FreeRDP/FreeRDP","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4993/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4993/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4993/events","html_url":"https://github.com/FreeRDP/FreeRDP/issues/4993","id":378340804,"node_id":"MDU6SXNzdWUzNzgzNDA4MDQ=","number":4993,"title":"FreeRDP x64 crashes on null pointer in TLS and NLA negotiation","user":{"login":"rpes","id":5822023,"node_id":"MDQ6VXNlcjU4MjIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5822023?v=4","gravatar_id":"","url":"https://api.github.com/users/rpes","html_url":"https://github.com/rpes","followers_url":"https://api.github.com/users/rpes/followers","following_url":"https://api.github.com/users/rpes/following{/other_user}","gists_url":"https://api.github.com/users/rpes/gists{/gist_id}","starred_url":"https://api.github.com/users/rpes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpes/subscriptions","organizations_url":"https://api.github.com/users/rpes/orgs","repos_url":"https://api.github.com/users/rpes/repos","events_url":"https://api.github.com/users/rpes/events{/privacy}","received_events_url":"https://api.github.com/users/rpes/received_events","type":"User","site_admin":false},"labels":[{"id":204739,"node_id":"MDU6TGFiZWwyMDQ3Mzk=","url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels/fixed-waiting-test","name":"fixed-waiting-test","color":"ff6600","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-07T15:34:39Z","updated_at":"2018-11-08T10:20:21Z","closed_at":"2018-11-08T10:08:09Z","author_association":"NONE","body":"Environment:\r\n* Windows 10 Home 64-bit w/ OpenSSL 1.1.1\r\n* Latest FreeRDP master code (2.0.0-dev4) downloaded on 6 Nov 2018.\r\n* MS Visual Studio 2015 Community\r\n\r\nSet up for 32-bit building under VS 2015 using:\r\n  cmake.exe .\r\n\r\nThe project builds in VS 2015 without any issues. A connection to a Windows 10 Pro system running as local VirtualBox VM succeeds and works as expected:\r\n\r\n  wfreerdp.exe /v:127.0.0.1\r\n\r\nNow set up the same code for 64-bit under VS 2015 using:\r\n  cmake.exe . -G\"Visual Studio 14 Win64\"\r\n\r\nThe project builds without any issues again. A connection to the Win 10 VM crashes. The only debug log printed out into the terminal is:\r\n\r\n[ERROR][com.freerdp.core.nego] - Error: SSL_CERT_NOT_ON_SERVER\r\n\r\nStarting in the VS debugger displays:\r\n\r\nException thrown: read access violation.\r\nptr was nullptr.\r\n\r\nThe ptr in question is in transport_bio_simple_uninit(bio_st *) line 391:\r\n\r\n\tif (ptr->hEvent)\r\n\r\nThe stack is:\r\n\r\n \tfreerdp2.dll!transport_bio_simple_uninit(bio_st * bio) Line 391\tC\r\n\tfreerdp2.dll!transport_bio_simple_free(bio_st * bio) Line 423\tC\r\n \tlibcrypto-1_1-x64.dll!00007ffe52ae5de6()\tUnknown\r\n \tfreerdp2.dll!transport_disconnect(rdp_transport * transport) Line 1107\tC\r\n \tfreerdp2.dll!nego_transport_disconnect(rdp_nego * nego) Line 309\tC\r\n \tfreerdp2.dll!nego_attempt_nla(rdp_nego * nego) Line 453\tC\r\n \tfreerdp2.dll!nego_send(rdp_nego * nego) Line 788\tC\r\n \tfreerdp2.dll!nego_connect(rdp_nego * nego) Line 162\tC\r\n \tfreerdp2.dll!rdp_client_connect(rdp_rdp * rdp) Line 297\tC\r\n \tfreerdp2.dll!freerdp_connect(rdp_freerdp * instance) Line 191\tC\r\n \twfreerdp.exe!wf_client_thread(void * lpParam) Line 595\tC\r\n \t\r\nSince the crash apparently happens in the NLA attempt I disabled it from the CLI:\r\n\r\n  wfreerdp.exe /v:127.0.0.1 -sec-nla\r\n\r\nThe app crashed again in the same line but this time in the TLS attempt:\r\n\r\n\tfreerdp2.dll!transport_bio_simple_uninit(bio_st * bio) Line 391\tC\r\n \tfreerdp2.dll!transport_bio_simple_free(bio_st * bio) Line 423\tC\r\n \tlibcrypto-1_1-x64.dll!00007ffe54355de6()\tUnknown\r\n \tfreerdp2.dll!transport_disconnect(rdp_transport * transport) Line 1107\tC\r\n \tfreerdp2.dll!nego_transport_disconnect(rdp_nego * nego) Line 309\tC\r\n \tfreerdp2.dll!nego_attempt_tls(rdp_nego * nego) Line 494\tC\r\n \tfreerdp2.dll!nego_send(rdp_nego * nego) Line 790\tC\r\n \tfreerdp2.dll!nego_connect(rdp_nego * nego) Line 162\tC\r\n \tfreerdp2.dll!rdp_client_connect(rdp_rdp * rdp) Line 297\tC\r\n \tfreerdp2.dll!freerdp_connect(rdp_freerdp * instance) Line 191\tC\r\n \twfreerdp.exe!wf_client_thread(void * lpParam) Line 595\tC\r\n\r\nWhen both NLA and TLS are disabled (-sec-tls -sec-nla) the viewer finally succeeded - the core did not try out NLA and TLS  and went to RDP security right away.\r\n\r\nIt appears that NLA and TLS are broken on 64-bit. Or is it a problem of MS Visual Studio?"},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/436945016","html_url":"https://github.com/FreeRDP/FreeRDP/issues/4993#issuecomment-436945016","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4993","id":436945016,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjk0NTAxNg==","user":{"login":"rpes","id":5822023,"node_id":"MDQ6VXNlcjU4MjIwMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5822023?v=4","gravatar_id":"","url":"https://api.github.com/users/rpes","html_url":"https://github.com/rpes","followers_url":"https://api.github.com/users/rpes/followers","following_url":"https://api.github.com/users/rpes/following{/other_user}","gists_url":"https://api.github.com/users/rpes/gists{/gist_id}","starred_url":"https://api.github.com/users/rpes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpes/subscriptions","organizations_url":"https://api.github.com/users/rpes/orgs","repos_url":"https://api.github.com/users/rpes/repos","events_url":"https://api.github.com/users/rpes/events{/privacy}","received_events_url":"https://api.github.com/users/rpes/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T10:20:21Z","updated_at":"2018-11-08T10:20:21Z","author_association":"NONE","body":"Can you pls provide some kind of explanation on why the issue got closed? The fix did NOT resolve the problem on my environment. It keeps crashing."}}
{"actor":{"display_login":"rpes"}}