{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/209549069","pull_request_review_id":145581842,"id":209549069,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU0OTA2OQ==","diff_hunk":"@@ -56,6 +56,7 @@ class DSLFormDropdownPanel extends React.Component {\n    */\n   handleChange(expression) {\n     this.setState({ expression });\n+    this.props.onChange(expression);","path":"src/js/components/DSLFormDropdownPanel.js","position":4,"original_position":4,"commit_id":"0caa23b51934774eba0495d980fdbe8eb7ea1030","original_commit_id":"0caa23b51934774eba0495d980fdbe8eb7ea1030","user":{"login":"nLight","id":186223,"node_id":"MDQ6VXNlcjE4NjIyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/186223?v=4","gravatar_id":"","url":"https://api.github.com/users/nLight","html_url":"https://github.com/nLight","followers_url":"https://api.github.com/users/nLight/followers","following_url":"https://api.github.com/users/nLight/following{/other_user}","gists_url":"https://api.github.com/users/nLight/gists{/gist_id}","starred_url":"https://api.github.com/users/nLight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nLight/subscriptions","organizations_url":"https://api.github.com/users/nLight/orgs","repos_url":"https://api.github.com/users/nLight/repos","events_url":"https://api.github.com/users/nLight/events{/privacy}","received_events_url":"https://api.github.com/users/nLight/received_events","type":"User","site_admin":false},"body":"I expected this to be a cherry-pick, yes. I just wonder if it's ok to have those values out of sync because `setState` is an async function. Sometimes it leads to interesting bugs. So I'm just asking whether we should change it or we totally sure values being out of sync is not an issue.","created_at":"2018-08-13T09:46:36Z","updated_at":"2018-08-13T09:46:36Z","html_url":"https://github.com/dcos/dcos-ui/pull/3135#discussion_r209549069","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/209549069"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/3135#discussion_r209549069"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135"}},"in_reply_to_id":209533746},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135","id":206360344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzYwMzQ0","html_url":"https://github.com/dcos/dcos-ui/pull/3135","diff_url":"https://github.com/dcos/dcos-ui/pull/3135.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/3135.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3135","number":3135,"state":"open","locked":false,"title":"[1.11] DCOS-39877: remove flickering filter bug","user":{"login":"DanielMSchmidt","id":1337046,"node_id":"MDQ6VXNlcjEzMzcwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1337046?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielMSchmidt","html_url":"https://github.com/DanielMSchmidt","followers_url":"https://api.github.com/users/DanielMSchmidt/followers","following_url":"https://api.github.com/users/DanielMSchmidt/following{/other_user}","gists_url":"https://api.github.com/users/DanielMSchmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielMSchmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielMSchmidt/subscriptions","organizations_url":"https://api.github.com/users/DanielMSchmidt/orgs","repos_url":"https://api.github.com/users/DanielMSchmidt/repos","events_url":"https://api.github.com/users/DanielMSchmidt/events{/privacy}","received_events_url":"https://api.github.com/users/DanielMSchmidt/received_events","type":"User","site_admin":false},"body":"## Testing\r\n\r\n<!--\r\nWhat is needed to test the changes? e.g. specific cluster, service definitions\r\nHow can one see the result of your work? e.g. configurations, URLs\r\n-->\r\n\r\n- Check the tasks page for a service and verify that the fuzzy search loses it's content if \"apply\" is not pressed directly\r\n- Check this branch out and verify that the content of the fuzzy search is directly applied\r\n\r\n### Before\r\n![old](https://user-images.githubusercontent.com/1337046/43764369-90dce2c6-9a2d-11e8-92fe-90ced7c91d88.gif)\r\n\r\n### After\r\n\r\n![new](https://user-images.githubusercontent.com/1337046/43764378-99b9da7a-9a2d-11e8-8335-7206efe11c9e.gif)\r\n\r\n\r\n## Trade-offs\r\n\r\n<!--\r\nAre you aware of any weak spots? e.g. performance, functionality\r\nDid you decide anything noteworthy? e.g. algorithms, data structures, tools\r\n-->\r\n\r\n- There might have been a way to fix the bug without applying the fuzzy search directly to the search, but this was inconsistent with the buttons already (they apply directly) I decided to fix forward here and change the behavior (from my point of view) to the benefit of the customer.\r\n- Decided for integration tests as there were no tests at all for this area. I thought system tests might not be necessary as it's more of a UI-only problem.\r\n\r\n\r\n## Dependencies\r\n\r\n<!--\r\nWhat needs to happen before this can be merged? e.g. PRs merged, other events\r\n-->\r\n\r\n- [x] Would like to have a small nod from @AmrAbdelrazik, @lilysamimi or @leemunroe as we have a little behaviour change here","created_at":"2018-08-06T10:49:53Z","updated_at":"2018-08-13T09:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75783d6ec63502c0e69e2a3dad312e7a98f173b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3135/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/0caa23b51934774eba0495d980fdbe8eb7ea1030","head":{"label":"dcos:danielmschmidt/DCOS-39877","ref":"danielmschmidt/DCOS-39877","sha":"0caa23b51934774eba0495d980fdbe8eb7ea1030","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU0NzUwNA==","name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-08-10T11:31:08Z","pushed_at":"2018-08-13T09:40:09Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":44436,"stargazers_count":183,"watchers_count":183,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":70,"open_issues":15,"watchers":183,"default_branch":"master"}},"base":{"label":"dcos:release/1.11","ref":"release/1.11","sha":"e63017e567ca8f508cf725216f4e6c2563f9293e","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU0NzUwNA==","name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-08-10T11:31:08Z","pushed_at":"2018-08-13T09:40:09Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":44436,"stargazers_count":183,"watchers_count":183,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":70,"open_issues":15,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/3135"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/3135"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/3135/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3135/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/0caa23b51934774eba0495d980fdbe8eb7ea1030"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nLight"}}