{"action":"created","comment":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/216778088","pull_request_review_id":154272174,"id":216778088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc3ODA4OA==","diff_hunk":"@@ -184,17 +208,69 @@ AS_IF([test \"x$MPI_IMPL\" != x],\n                     [\n                        MPI_IMPL=\"built-in\"\n                        AC_MSG_RESULT( [$CXX Compiler Supports MPI] )\n-                       AC_DEFINE(HAVE_MPI, 1, [Flag indicating whether or not MPI is available])\n                     ],\n                     [AC_MSG_RESULT([$CXX Compiler Does NOT Support MPI...]); enablempi=no])\n       ])\n+     dnl Save variables...\n+     AC_SUBST(MPI)\n+     AC_SUBST(MPI_IMPL)\n+     AC_SUBST(MPI_LIBS)\n+     AC_SUBST(MPI_LIBS_PATH)\n+     AC_SUBST(MPI_LIBS_PATHS)\n+     AC_SUBST(MPI_INCLUDES_PATH)\n+     AC_SUBST(MPI_INCLUDES_PATHS)\n+\n+     VERSION_MPI\n+])\n+\n+\n+AC_DEFUN([VERSION_MPI], [\n \n-dnl Save variables...\n-AC_SUBST(MPI)\n-AC_SUBST(MPI_IMPL)\n-AC_SUBST(MPI_LIBS)\n-AC_SUBST(MPI_LIBS_PATH)\n-AC_SUBST(MPI_LIBS_PATHS)\n-AC_SUBST(MPI_INCLUDES_PATH)\n-AC_SUBST(MPI_INCLUDES_PATHS)\n+  AS_IF([test \"x$enablempi\" != xno],\n+  [\n+        dnl check that MPI_VERSION and MPI_SUBVERSION are defined.\n+        AC_LANG_SAVE\n+        AC_LANG_CPLUSPLUS\n+        AC_TRY_LINK([@%:@include <mpi.h>],\n+                    [#ifndef MPI_VERSION\n+                     #error \"MPI-Version undefined.\"\n+                    #endif\n+                    ],\n+                    [ dnl true: Check which version it is:\n+                    dnl check that MPI_VERSION is not 1; else disable MPI\n+                    AC_TRY_LINK([@%:@include <mpi.h>],\n+                                [\n+                                #if MPI_VERSION == 1\n+                                #error \"Bad MPI-version\"\n+                                #endif\n+                                int np; MPI_Comm_size (MPI_COMM_WORLD, &np)\n+                                ],\n+                                [ dnl it gives true if MPI_VERSION !=1...\n+                                 dnl check that MPI_VERSION is not 2; else through a warning\n+                                 AC_TRY_LINK([@%:@include <mpi.h>],\n+                                             [\n+                                             #if MPI_VERSION == 2\n+                                             #error \"deprecated MPI-version\"\n+                                             #endif\n+                                             int np; MPI_Comm_size (MPI_COMM_WORLD, &np)\n+                                             ],\n+                                             [\n+                                               dnl MPI_VERSION >2: Be happy and configure with MPI.\n+                                              AC_MSG_RESULT([ The MPI found has version >= 3.0. ]);","path":"m4/mpi.m4","position":131,"original_position":131,"commit_id":"d537ccc006aaad9ea3e7f93d7843676055208123","original_commit_id":"d537ccc006aaad9ea3e7f93d7843676055208123","user":{"login":"jwpeterson","id":1775907,"node_id":"MDQ6VXNlcjE3NzU5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1775907?v=4","gravatar_id":"","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"Not sure I understand the logic here? If the previous two tests for `MPI_VERSION==1` and `2` fail, it is assumed to be version `3`? That seems dangerous, perhaps there is just something wrong with the MPI installation that caused the preceding two tests to fail... I'd rather have a successful test for `MPI_VERSION==3` along with (eventually) some API tests for `MPI_VERSION==3` only code before concluding that we have MPI-3 support.","created_at":"2018-09-11T18:41:57Z","updated_at":"2018-09-11T18:46:03Z","html_url":"https://github.com/libMesh/libmesh/pull/1822#discussion_r216778088","pull_request_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1822","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments/216778088"},"html":{"href":"https://github.com/libMesh/libmesh/pull/1822#discussion_r216778088"},"pull_request":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1822"}}},"pull_request":{"url":"https://api.github.com/repos/libMesh/libmesh/pulls/1822","id":207525388,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTI1Mzg4","html_url":"https://github.com/libMesh/libmesh/pull/1822","diff_url":"https://github.com/libMesh/libmesh/pull/1822.diff","patch_url":"https://github.com/libMesh/libmesh/pull/1822.patch","issue_url":"https://api.github.com/repos/libMesh/libmesh/issues/1822","number":1822,"state":"open","locked":false,"title":"Add version-check of MPI in configure","user":{"login":"BalticPinguin","id":2708704,"node_id":"MDQ6VXNlcjI3MDg3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2708704?v=4","gravatar_id":"","url":"https://api.github.com/users/BalticPinguin","html_url":"https://github.com/BalticPinguin","followers_url":"https://api.github.com/users/BalticPinguin/followers","following_url":"https://api.github.com/users/BalticPinguin/following{/other_user}","gists_url":"https://api.github.com/users/BalticPinguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BalticPinguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BalticPinguin/subscriptions","organizations_url":"https://api.github.com/users/BalticPinguin/orgs","repos_url":"https://api.github.com/users/BalticPinguin/repos","events_url":"https://api.github.com/users/BalticPinguin/events{/privacy}","received_events_url":"https://api.github.com/users/BalticPinguin/received_events","type":"User","site_admin":false},"body":"Hi,\r\nso this is a first attempt in fixing the bug #1816 , at least if the mpi is not just taken from petsc.\r\nI would like to get some comments whether this is the direction to go; since it is my first work with m4, maybe there are some ceveir issues in my approach.\r\n\r\nMoreover, if PETSc is used, (as I see it), the MPI-config is just taken from there without any checks, right?\r\nWhat do you think if we add a check similar to the TRY_RUN in this commit? Or is there a better way to solve it?","created_at":"2018-08-10T07:11:19Z","updated_at":"2018-09-11T18:46:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85f90be08d1b448d2aab91af59ed9b179602478","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1822/commits","review_comments_url":"https://api.github.com/repos/libMesh/libmesh/pulls/1822/comments","review_comment_url":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libMesh/libmesh/issues/1822/comments","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/d537ccc006aaad9ea3e7f93d7843676055208123","head":{"label":"BalticPinguin:master","ref":"master","sha":"d537ccc006aaad9ea3e7f93d7843676055208123","user":{"login":"BalticPinguin","id":2708704,"node_id":"MDQ6VXNlcjI3MDg3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2708704?v=4","gravatar_id":"","url":"https://api.github.com/users/BalticPinguin","html_url":"https://github.com/BalticPinguin","followers_url":"https://api.github.com/users/BalticPinguin/followers","following_url":"https://api.github.com/users/BalticPinguin/following{/other_user}","gists_url":"https://api.github.com/users/BalticPinguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BalticPinguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BalticPinguin/subscriptions","organizations_url":"https://api.github.com/users/BalticPinguin/orgs","repos_url":"https://api.github.com/users/BalticPinguin/repos","events_url":"https://api.github.com/users/BalticPinguin/events{/privacy}","received_events_url":"https://api.github.com/users/BalticPinguin/received_events","type":"User","site_admin":false},"repo":{"id":62052812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjA1MjgxMg==","name":"libmesh","full_name":"BalticPinguin/libmesh","owner":{"login":"BalticPinguin","id":2708704,"node_id":"MDQ6VXNlcjI3MDg3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2708704?v=4","gravatar_id":"","url":"https://api.github.com/users/BalticPinguin","html_url":"https://github.com/BalticPinguin","followers_url":"https://api.github.com/users/BalticPinguin/followers","following_url":"https://api.github.com/users/BalticPinguin/following{/other_user}","gists_url":"https://api.github.com/users/BalticPinguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BalticPinguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BalticPinguin/subscriptions","organizations_url":"https://api.github.com/users/BalticPinguin/orgs","repos_url":"https://api.github.com/users/BalticPinguin/repos","events_url":"https://api.github.com/users/BalticPinguin/events{/privacy}","received_events_url":"https://api.github.com/users/BalticPinguin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BalticPinguin/libmesh","description":"libMesh github repository","fork":true,"url":"https://api.github.com/repos/BalticPinguin/libmesh","forks_url":"https://api.github.com/repos/BalticPinguin/libmesh/forks","keys_url":"https://api.github.com/repos/BalticPinguin/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BalticPinguin/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BalticPinguin/libmesh/teams","hooks_url":"https://api.github.com/repos/BalticPinguin/libmesh/hooks","issue_events_url":"https://api.github.com/repos/BalticPinguin/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/BalticPinguin/libmesh/events","assignees_url":"https://api.github.com/repos/BalticPinguin/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/BalticPinguin/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/BalticPinguin/libmesh/tags","blobs_url":"https://api.github.com/repos/BalticPinguin/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BalticPinguin/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BalticPinguin/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/BalticPinguin/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BalticPinguin/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/BalticPinguin/libmesh/languages","stargazers_url":"https://api.github.com/repos/BalticPinguin/libmesh/stargazers","contributors_url":"https://api.github.com/repos/BalticPinguin/libmesh/contributors","subscribers_url":"https://api.github.com/repos/BalticPinguin/libmesh/subscribers","subscription_url":"https://api.github.com/repos/BalticPinguin/libmesh/subscription","commits_url":"https://api.github.com/repos/BalticPinguin/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/BalticPinguin/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/BalticPinguin/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/BalticPinguin/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/BalticPinguin/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/BalticPinguin/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BalticPinguin/libmesh/merges","archive_url":"https://api.github.com/repos/BalticPinguin/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BalticPinguin/libmesh/downloads","issues_url":"https://api.github.com/repos/BalticPinguin/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/BalticPinguin/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/BalticPinguin/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/BalticPinguin/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BalticPinguin/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/BalticPinguin/libmesh/releases{/id}","deployments_url":"https://api.github.com/repos/BalticPinguin/libmesh/deployments","created_at":"2016-06-27T11:56:18Z","updated_at":"2018-09-11T15:35:27Z","pushed_at":"2018-09-11T15:35:09Z","git_url":"git://github.com/BalticPinguin/libmesh.git","ssh_url":"git@github.com:BalticPinguin/libmesh.git","clone_url":"https://github.com/BalticPinguin/libmesh.git","svn_url":"https://github.com/BalticPinguin/libmesh","homepage":"http://libmesh.github.io","size":120901,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libMesh:master","ref":"master","sha":"db8e2b091ed6aae4e010a4df5a3b192adf95c5b0","user":{"login":"libMesh","id":2366757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2366757?v=4","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"repo":{"id":5850234,"node_id":"MDEwOlJlcG9zaXRvcnk1ODUwMjM0","name":"libmesh","full_name":"libMesh/libmesh","owner":{"login":"libMesh","id":2366757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/2366757?v=4","gravatar_id":"","url":"https://api.github.com/users/libMesh","html_url":"https://github.com/libMesh","followers_url":"https://api.github.com/users/libMesh/followers","following_url":"https://api.github.com/users/libMesh/following{/other_user}","gists_url":"https://api.github.com/users/libMesh/gists{/gist_id}","starred_url":"https://api.github.com/users/libMesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libMesh/subscriptions","organizations_url":"https://api.github.com/users/libMesh/orgs","repos_url":"https://api.github.com/users/libMesh/repos","events_url":"https://api.github.com/users/libMesh/events{/privacy}","received_events_url":"https://api.github.com/users/libMesh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libMesh/libmesh","description":"libMesh github repository","fork":false,"url":"https://api.github.com/repos/libMesh/libmesh","forks_url":"https://api.github.com/repos/libMesh/libmesh/forks","keys_url":"https://api.github.com/repos/libMesh/libmesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libMesh/libmesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libMesh/libmesh/teams","hooks_url":"https://api.github.com/repos/libMesh/libmesh/hooks","issue_events_url":"https://api.github.com/repos/libMesh/libmesh/issues/events{/number}","events_url":"https://api.github.com/repos/libMesh/libmesh/events","assignees_url":"https://api.github.com/repos/libMesh/libmesh/assignees{/user}","branches_url":"https://api.github.com/repos/libMesh/libmesh/branches{/branch}","tags_url":"https://api.github.com/repos/libMesh/libmesh/tags","blobs_url":"https://api.github.com/repos/libMesh/libmesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libMesh/libmesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libMesh/libmesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/libMesh/libmesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libMesh/libmesh/statuses/{sha}","languages_url":"https://api.github.com/repos/libMesh/libmesh/languages","stargazers_url":"https://api.github.com/repos/libMesh/libmesh/stargazers","contributors_url":"https://api.github.com/repos/libMesh/libmesh/contributors","subscribers_url":"https://api.github.com/repos/libMesh/libmesh/subscribers","subscription_url":"https://api.github.com/repos/libMesh/libmesh/subscription","commits_url":"https://api.github.com/repos/libMesh/libmesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/libMesh/libmesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/libMesh/libmesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/libMesh/libmesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/libMesh/libmesh/contents/{+path}","compare_url":"https://api.github.com/repos/libMesh/libmesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libMesh/libmesh/merges","archive_url":"https://api.github.com/repos/libMesh/libmesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libMesh/libmesh/downloads","issues_url":"https://api.github.com/repos/libMesh/libmesh/issues{/number}","pulls_url":"https://api.github.com/repos/libMesh/libmesh/pulls{/number}","milestones_url":"https://api.github.com/repos/libMesh/libmesh/milestones{/number}","notifications_url":"https://api.github.com/repos/libMesh/libmesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libMesh/libmesh/labels{/name}","releases_url":"https://api.github.com/repos/libMesh/libmesh/releases{/id}","deployments_url":"https://api.github.com/repos/libMesh/libmesh/deployments","created_at":"2012-09-18T02:12:18Z","updated_at":"2018-09-10T18:12:03Z","pushed_at":"2018-09-11T15:35:11Z","git_url":"git://github.com/libMesh/libmesh.git","ssh_url":"git@github.com:libMesh/libmesh.git","clone_url":"https://github.com/libMesh/libmesh.git","svn_url":"https://github.com/libMesh/libmesh","homepage":"http://libmesh.github.io","size":121038,"stargazers_count":241,"watchers_count":241,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":159,"open_issues":140,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1822"},"html":{"href":"https://github.com/libMesh/libmesh/pull/1822"},"issue":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/1822"},"comments":{"href":"https://api.github.com/repos/libMesh/libmesh/issues/1822/comments"},"review_comments":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1822/comments"},"review_comment":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libMesh/libmesh/pulls/1822/commits"},"statuses":{"href":"https://api.github.com/repos/libMesh/libmesh/statuses/d537ccc006aaad9ea3e7f93d7843676055208123"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jwpeterson"}}