{"action":"created","comment":{"url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments/202159343","pull_request_review_id":136804640,"id":202159343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE1OTM0Mw==","diff_hunk":"@@ -25,7 +25,8 @@\n \n #from .log import setup_logger, set_log_level\n from canmatrix.log import setup_logger, set_log_level\n-logger = setup_logger('root')\n+import logging\n+logger = logging.getLogger('root')","path":"canmatrix/convert.py","position":6,"original_position":6,"commit_id":"6df475d9a98abdf28685ee338e4f5386c97ad3b0","original_commit_id":"6df475d9a98abdf28685ee338e4f5386c97ad3b0","user":{"login":"altendky","id":543719,"node_id":"MDQ6VXNlcjU0MzcxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/543719?v=4","gravatar_id":"","url":"https://api.github.com/users/altendky","html_url":"https://github.com/altendky","followers_url":"https://api.github.com/users/altendky/followers","following_url":"https://api.github.com/users/altendky/following{/other_user}","gists_url":"https://api.github.com/users/altendky/gists{/gist_id}","starred_url":"https://api.github.com/users/altendky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/altendky/subscriptions","organizations_url":"https://api.github.com/users/altendky/orgs","repos_url":"https://api.github.com/users/altendky/repos","events_url":"https://api.github.com/users/altendky/events{/privacy}","received_events_url":"https://api.github.com/users/altendky/received_events","type":"User","site_admin":false},"body":"Maybe just:\r\n\r\n```python3\r\nlogger = logging.getLogger(__name__)\r\n```\r\nSo this file gets its own logger normally regardless of being imported or run.  Then below we configure the root logger which we don't use directly.\r\n\r\nhttps://docs.python.org/3/library/logging.html#logger-objects","created_at":"2018-07-12T19:55:55Z","updated_at":"2018-07-12T20:03:07Z","html_url":"https://github.com/ebroecker/canmatrix/pull/164#discussion_r202159343","pull_request_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments/202159343"},"html":{"href":"https://github.com/ebroecker/canmatrix/pull/164#discussion_r202159343"},"pull_request":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164","id":199260551,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjYwNTUx","html_url":"https://github.com/ebroecker/canmatrix/pull/164","diff_url":"https://github.com/ebroecker/canmatrix/pull/164.diff","patch_url":"https://github.com/ebroecker/canmatrix/pull/164.patch","issue_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/164","number":164,"state":"open","locked":false,"title":"Move the setup_logger call to __main__ section","user":{"login":"pierreluctg","id":1785698,"node_id":"MDQ6VXNlcjE3ODU2OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1785698?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreluctg","html_url":"https://github.com/pierreluctg","followers_url":"https://api.github.com/users/pierreluctg/followers","following_url":"https://api.github.com/users/pierreluctg/following{/other_user}","gists_url":"https://api.github.com/users/pierreluctg/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreluctg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreluctg/subscriptions","organizations_url":"https://api.github.com/users/pierreluctg/orgs","repos_url":"https://api.github.com/users/pierreluctg/repos","events_url":"https://api.github.com/users/pierreluctg/events{/privacy}","received_events_url":"https://api.github.com/users/pierreluctg/received_events","type":"User","site_admin":false},"body":"This will stop creating a log handler when importing from canmatrix","created_at":"2018-07-04T14:07:40Z","updated_at":"2018-07-12T20:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c222a9262abb6c40f4cdb136967f77a79f37041","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164/commits","review_comments_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164/comments","review_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/164/comments","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/6df475d9a98abdf28685ee338e4f5386c97ad3b0","head":{"label":"pierreluctg:patch-3","ref":"patch-3","sha":"6df475d9a98abdf28685ee338e4f5386c97ad3b0","user":{"login":"pierreluctg","id":1785698,"node_id":"MDQ6VXNlcjE3ODU2OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1785698?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreluctg","html_url":"https://github.com/pierreluctg","followers_url":"https://api.github.com/users/pierreluctg/followers","following_url":"https://api.github.com/users/pierreluctg/following{/other_user}","gists_url":"https://api.github.com/users/pierreluctg/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreluctg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreluctg/subscriptions","organizations_url":"https://api.github.com/users/pierreluctg/orgs","repos_url":"https://api.github.com/users/pierreluctg/repos","events_url":"https://api.github.com/users/pierreluctg/events{/privacy}","received_events_url":"https://api.github.com/users/pierreluctg/received_events","type":"User","site_admin":false},"repo":{"id":116854647,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4NTQ2NDc=","name":"canmatrix","full_name":"pierreluctg/canmatrix","owner":{"login":"pierreluctg","id":1785698,"node_id":"MDQ6VXNlcjE3ODU2OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1785698?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreluctg","html_url":"https://github.com/pierreluctg","followers_url":"https://api.github.com/users/pierreluctg/followers","following_url":"https://api.github.com/users/pierreluctg/following{/other_user}","gists_url":"https://api.github.com/users/pierreluctg/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreluctg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreluctg/subscriptions","organizations_url":"https://api.github.com/users/pierreluctg/orgs","repos_url":"https://api.github.com/users/pierreluctg/repos","events_url":"https://api.github.com/users/pierreluctg/events{/privacy}","received_events_url":"https://api.github.com/users/pierreluctg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierreluctg/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":true,"url":"https://api.github.com/repos/pierreluctg/canmatrix","forks_url":"https://api.github.com/repos/pierreluctg/canmatrix/forks","keys_url":"https://api.github.com/repos/pierreluctg/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierreluctg/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierreluctg/canmatrix/teams","hooks_url":"https://api.github.com/repos/pierreluctg/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/pierreluctg/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/pierreluctg/canmatrix/events","assignees_url":"https://api.github.com/repos/pierreluctg/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/pierreluctg/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/pierreluctg/canmatrix/tags","blobs_url":"https://api.github.com/repos/pierreluctg/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierreluctg/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierreluctg/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierreluctg/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierreluctg/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/pierreluctg/canmatrix/languages","stargazers_url":"https://api.github.com/repos/pierreluctg/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/pierreluctg/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/pierreluctg/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/pierreluctg/canmatrix/subscription","commits_url":"https://api.github.com/repos/pierreluctg/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierreluctg/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierreluctg/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierreluctg/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierreluctg/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/pierreluctg/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierreluctg/canmatrix/merges","archive_url":"https://api.github.com/repos/pierreluctg/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierreluctg/canmatrix/downloads","issues_url":"https://api.github.com/repos/pierreluctg/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/pierreluctg/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/pierreluctg/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/pierreluctg/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierreluctg/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/pierreluctg/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/pierreluctg/canmatrix/deployments","created_at":"2018-01-09T18:30:23Z","updated_at":"2018-01-09T18:30:25Z","pushed_at":"2018-07-12T15:20:54Z","git_url":"git://github.com/pierreluctg/canmatrix.git","ssh_url":"git@github.com:pierreluctg/canmatrix.git","clone_url":"https://github.com/pierreluctg/canmatrix.git","svn_url":"https://github.com/pierreluctg/canmatrix","homepage":"","size":3131,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ebroecker:development","ref":"development","sha":"82ece227cd2b5a7ced2e0f75610708ff1231ca04","user":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"repo":{"id":9304497,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NDk3","name":"canmatrix","full_name":"ebroecker/canmatrix","owner":{"login":"ebroecker","id":4096406,"node_id":"MDQ6VXNlcjQwOTY0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4096406?v=4","gravatar_id":"","url":"https://api.github.com/users/ebroecker","html_url":"https://github.com/ebroecker","followers_url":"https://api.github.com/users/ebroecker/followers","following_url":"https://api.github.com/users/ebroecker/following{/other_user}","gists_url":"https://api.github.com/users/ebroecker/gists{/gist_id}","starred_url":"https://api.github.com/users/ebroecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebroecker/subscriptions","organizations_url":"https://api.github.com/users/ebroecker/orgs","repos_url":"https://api.github.com/users/ebroecker/repos","events_url":"https://api.github.com/users/ebroecker/events{/privacy}","received_events_url":"https://api.github.com/users/ebroecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebroecker/canmatrix","description":"Converting Can (Controller Area Network) Database Formats .arxml .dbc .dbf .kcd ...","fork":false,"url":"https://api.github.com/repos/ebroecker/canmatrix","forks_url":"https://api.github.com/repos/ebroecker/canmatrix/forks","keys_url":"https://api.github.com/repos/ebroecker/canmatrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebroecker/canmatrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebroecker/canmatrix/teams","hooks_url":"https://api.github.com/repos/ebroecker/canmatrix/hooks","issue_events_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/events{/number}","events_url":"https://api.github.com/repos/ebroecker/canmatrix/events","assignees_url":"https://api.github.com/repos/ebroecker/canmatrix/assignees{/user}","branches_url":"https://api.github.com/repos/ebroecker/canmatrix/branches{/branch}","tags_url":"https://api.github.com/repos/ebroecker/canmatrix/tags","blobs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebroecker/canmatrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebroecker/canmatrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebroecker/canmatrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebroecker/canmatrix/statuses/{sha}","languages_url":"https://api.github.com/repos/ebroecker/canmatrix/languages","stargazers_url":"https://api.github.com/repos/ebroecker/canmatrix/stargazers","contributors_url":"https://api.github.com/repos/ebroecker/canmatrix/contributors","subscribers_url":"https://api.github.com/repos/ebroecker/canmatrix/subscribers","subscription_url":"https://api.github.com/repos/ebroecker/canmatrix/subscription","commits_url":"https://api.github.com/repos/ebroecker/canmatrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebroecker/canmatrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebroecker/canmatrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebroecker/canmatrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebroecker/canmatrix/contents/{+path}","compare_url":"https://api.github.com/repos/ebroecker/canmatrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebroecker/canmatrix/merges","archive_url":"https://api.github.com/repos/ebroecker/canmatrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebroecker/canmatrix/downloads","issues_url":"https://api.github.com/repos/ebroecker/canmatrix/issues{/number}","pulls_url":"https://api.github.com/repos/ebroecker/canmatrix/pulls{/number}","milestones_url":"https://api.github.com/repos/ebroecker/canmatrix/milestones{/number}","notifications_url":"https://api.github.com/repos/ebroecker/canmatrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebroecker/canmatrix/labels{/name}","releases_url":"https://api.github.com/repos/ebroecker/canmatrix/releases{/id}","deployments_url":"https://api.github.com/repos/ebroecker/canmatrix/deployments","created_at":"2013-04-08T19:08:14Z","updated_at":"2018-07-08T07:35:43Z","pushed_at":"2018-07-12T19:03:43Z","git_url":"git://github.com/ebroecker/canmatrix.git","ssh_url":"git@github.com:ebroecker/canmatrix.git","clone_url":"https://github.com/ebroecker/canmatrix.git","svn_url":"https://github.com/ebroecker/canmatrix","homepage":"","size":3147,"stargazers_count":192,"watchers_count":192,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":106,"open_issues":33,"watchers":192,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164"},"html":{"href":"https://github.com/ebroecker/canmatrix/pull/164"},"issue":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/164"},"comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebroecker/canmatrix/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/ebroecker/canmatrix/statuses/6df475d9a98abdf28685ee338e4f5386c97ad3b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"altendky"}}