{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/196586124","pull_request_review_id":130168552,"id":196586124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU4NjEyNA==","diff_hunk":"@@ -76,11 +76,18 @@\n   public final int storeDeletedMessageRetentionDays;\n \n   /**\n-   * The rate of I/O allowed for compaction and hard deletes.\n+   * The rate of I/O allowed for hard deletes.\n    */\n-  @Config(\"store.cleanup.operations.bytes.per.sec\")\n+  @Config(\"store.hard.delete.operations.bytes.per.sec\")\n   @Default(\"1*1024*1024\")\n-  public final int storeCleanupOperationsBytesPerSec;\n+  public final int storeHardDeleteOperationsBytesPerSec;\n+\n+  /**\n+   * The rate of I/O allowed for compaction.","path":"ambry-api/src/main/java/com.github.ambry/config/StoreConfig.java","position":14,"original_position":14,"commit_id":"448a64989f4f8ed23b13903510b26c803069ed8d","original_commit_id":"448a64989f4f8ed23b13903510b26c803069ed8d","user":{"login":"vgkholla","id":288834,"node_id":"MDQ6VXNlcjI4ODgzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/288834?v=4","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"body":"add \"per disk\"","created_at":"2018-06-19T21:33:50Z","updated_at":"2018-06-19T21:52:01Z","html_url":"https://github.com/linkedin/ambry/pull/957#discussion_r196586124","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/957","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/196586124"},"html":{"href":"https://github.com/linkedin/ambry/pull/957#discussion_r196586124"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/957"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/957","id":195649735,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjQ5NzM1","html_url":"https://github.com/linkedin/ambry/pull/957","diff_url":"https://github.com/linkedin/ambry/pull/957.diff","patch_url":"https://github.com/linkedin/ambry/pull/957.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/957","number":957,"state":"open","locked":false,"title":"Separate hard delete rate from compaction rate.","user":{"login":"zzmao","id":34247652,"node_id":"MDQ6VXNlcjM0MjQ3NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34247652?v=4","gravatar_id":"","url":"https://api.github.com/users/zzmao","html_url":"https://github.com/zzmao","followers_url":"https://api.github.com/users/zzmao/followers","following_url":"https://api.github.com/users/zzmao/following{/other_user}","gists_url":"https://api.github.com/users/zzmao/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmao/subscriptions","organizations_url":"https://api.github.com/users/zzmao/orgs","repos_url":"https://api.github.com/users/zzmao/repos","events_url":"https://api.github.com/users/zzmao/events{/privacy}","received_events_url":"https://api.github.com/users/zzmao/received_events","type":"User","site_admin":false},"body":"It would be convenient for experiment/test if separate them. ","created_at":"2018-06-18T21:11:47Z","updated_at":"2018-06-19T21:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0300d882fbe3cae3eaf7b01f7c594a0cb642fda1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/957/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/957/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/957/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/448a64989f4f8ed23b13903510b26c803069ed8d","head":{"label":"zzmao:hardD","ref":"hardD","sha":"448a64989f4f8ed23b13903510b26c803069ed8d","user":{"login":"zzmao","id":34247652,"node_id":"MDQ6VXNlcjM0MjQ3NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34247652?v=4","gravatar_id":"","url":"https://api.github.com/users/zzmao","html_url":"https://github.com/zzmao","followers_url":"https://api.github.com/users/zzmao/followers","following_url":"https://api.github.com/users/zzmao/following{/other_user}","gists_url":"https://api.github.com/users/zzmao/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmao/subscriptions","organizations_url":"https://api.github.com/users/zzmao/orgs","repos_url":"https://api.github.com/users/zzmao/repos","events_url":"https://api.github.com/users/zzmao/events{/privacy}","received_events_url":"https://api.github.com/users/zzmao/received_events","type":"User","site_admin":false},"repo":{"id":113078328,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwNzgzMjg=","name":"ambry","full_name":"zzmao/ambry","owner":{"login":"zzmao","id":34247652,"node_id":"MDQ6VXNlcjM0MjQ3NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34247652?v=4","gravatar_id":"","url":"https://api.github.com/users/zzmao","html_url":"https://github.com/zzmao","followers_url":"https://api.github.com/users/zzmao/followers","following_url":"https://api.github.com/users/zzmao/following{/other_user}","gists_url":"https://api.github.com/users/zzmao/gists{/gist_id}","starred_url":"https://api.github.com/users/zzmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzmao/subscriptions","organizations_url":"https://api.github.com/users/zzmao/orgs","repos_url":"https://api.github.com/users/zzmao/repos","events_url":"https://api.github.com/users/zzmao/events{/privacy}","received_events_url":"https://api.github.com/users/zzmao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zzmao/ambry","description":"Distributed object store","fork":true,"url":"https://api.github.com/repos/zzmao/ambry","forks_url":"https://api.github.com/repos/zzmao/ambry/forks","keys_url":"https://api.github.com/repos/zzmao/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zzmao/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zzmao/ambry/teams","hooks_url":"https://api.github.com/repos/zzmao/ambry/hooks","issue_events_url":"https://api.github.com/repos/zzmao/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/zzmao/ambry/events","assignees_url":"https://api.github.com/repos/zzmao/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/zzmao/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/zzmao/ambry/tags","blobs_url":"https://api.github.com/repos/zzmao/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zzmao/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zzmao/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/zzmao/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zzmao/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/zzmao/ambry/languages","stargazers_url":"https://api.github.com/repos/zzmao/ambry/stargazers","contributors_url":"https://api.github.com/repos/zzmao/ambry/contributors","subscribers_url":"https://api.github.com/repos/zzmao/ambry/subscribers","subscription_url":"https://api.github.com/repos/zzmao/ambry/subscription","commits_url":"https://api.github.com/repos/zzmao/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/zzmao/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/zzmao/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/zzmao/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/zzmao/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/zzmao/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zzmao/ambry/merges","archive_url":"https://api.github.com/repos/zzmao/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zzmao/ambry/downloads","issues_url":"https://api.github.com/repos/zzmao/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/zzmao/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/zzmao/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/zzmao/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zzmao/ambry/labels{/name}","releases_url":"https://api.github.com/repos/zzmao/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/zzmao/ambry/deployments","created_at":"2017-12-04T18:18:42Z","updated_at":"2018-06-18T22:27:55Z","pushed_at":"2018-06-19T21:27:18Z","git_url":"git://github.com/zzmao/ambry.git","ssh_url":"git@github.com:zzmao/ambry.git","clone_url":"https://github.com/zzmao/ambry.git","svn_url":"https://github.com/zzmao/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":13103,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"5919fa26780751302131ca40eed7811fe1559d0e","user":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MDg5Mw==","name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzA5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2018-06-19T21:12:10Z","pushed_at":"2018-06-19T21:27:20Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":12760,"stargazers_count":1066,"watchers_count":1066,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":206,"open_issues":100,"watchers":1066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/957"},"html":{"href":"https://github.com/linkedin/ambry/pull/957"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/957"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/448a64989f4f8ed23b13903510b26c803069ed8d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vgkholla"}}