{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/183659185","pull_request_review_id":114696342,"id":183659185,"diff_hunk":"@@ -0,0 +1,103 @@\n+#include \"JobPool.hpp\"\n+\n+JobPool::JobPool()\n+    : _shouldStop(false),\n+    _processing(0)","path":"src/openrct2/core/JobPool.cpp","position":5,"original_position":5,"commit_id":"588316eb9c4aad6a7c4b1a18e7c4ad69ae851635","original_commit_id":"588316eb9c4aad6a7c4b1a18e7c4ad69ae851635","user":{"login":"janisozaur","id":550290,"avatar_url":"https://avatars1.githubusercontent.com/u/550290?v=4","gravatar_id":"","url":"https://api.github.com/users/janisozaur","html_url":"https://github.com/janisozaur","followers_url":"https://api.github.com/users/janisozaur/followers","following_url":"https://api.github.com/users/janisozaur/following{/other_user}","gists_url":"https://api.github.com/users/janisozaur/gists{/gist_id}","starred_url":"https://api.github.com/users/janisozaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisozaur/subscriptions","organizations_url":"https://api.github.com/users/janisozaur/orgs","repos_url":"https://api.github.com/users/janisozaur/repos","events_url":"https://api.github.com/users/janisozaur/events{/privacy}","received_events_url":"https://api.github.com/users/janisozaur/received_events","type":"User","site_admin":false},"body":"They are specified in different order, fix either here or in the class declaration.","created_at":"2018-04-24T09:14:44Z","updated_at":"2018-04-24T09:14:45Z","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/7435#discussion_r183659185","pull_request_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments/183659185"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/7435#discussion_r183659185"},"pull_request":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435","id":183277547,"html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/7435","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/7435.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/7435.patch","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/7435","number":7435,"state":"open","locked":false,"title":"Use multiple threads to generate object index cache.","user":{"login":"ZehMatt","id":5415177,"avatar_url":"https://avatars0.githubusercontent.com/u/5415177?v=4","gravatar_id":"","url":"https://api.github.com/users/ZehMatt","html_url":"https://github.com/ZehMatt","followers_url":"https://api.github.com/users/ZehMatt/followers","following_url":"https://api.github.com/users/ZehMatt/following{/other_user}","gists_url":"https://api.github.com/users/ZehMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehMatt/subscriptions","organizations_url":"https://api.github.com/users/ZehMatt/orgs","repos_url":"https://api.github.com/users/ZehMatt/repos","events_url":"https://api.github.com/users/ZehMatt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehMatt/received_events","type":"User","site_admin":false},"body":"This leaves quite a remarkable performance boost on my end, the results:\r\n```\r\nRelease:\r\n\tbefore:\r\n\tFinished building object index in 11.13 seconds.\r\n\tafter:\r\n\tFinished building object index in 1.12 seconds.\r\n\t\r\nDebug:\r\n\tbefore:\r\n\tFinished building object index in 31.25 seconds.\r\n\tafter:\r\n\tFinished building object index in 23.00 seconds.\r\n```\r\nI had to remove the fancy progress in the console however.","created_at":"2018-04-22T15:02:53Z","updated_at":"2018-04-24T09:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f7a1f09fb524371e071848fca360462e64fd730","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":902697997,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels/changelog","name":"changelog","color":"83e2db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435/commits","review_comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435/comments","review_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/7435/comments","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/588316eb9c4aad6a7c4b1a18e7c4ad69ae851635","head":{"label":"ZehMatt:indexing-perf","ref":"indexing-perf","sha":"588316eb9c4aad6a7c4b1a18e7c4ad69ae851635","user":{"login":"ZehMatt","id":5415177,"avatar_url":"https://avatars0.githubusercontent.com/u/5415177?v=4","gravatar_id":"","url":"https://api.github.com/users/ZehMatt","html_url":"https://github.com/ZehMatt","followers_url":"https://api.github.com/users/ZehMatt/followers","following_url":"https://api.github.com/users/ZehMatt/following{/other_user}","gists_url":"https://api.github.com/users/ZehMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehMatt/subscriptions","organizations_url":"https://api.github.com/users/ZehMatt/orgs","repos_url":"https://api.github.com/users/ZehMatt/repos","events_url":"https://api.github.com/users/ZehMatt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehMatt/received_events","type":"User","site_admin":false},"repo":{"id":93884749,"name":"OpenRCT2","full_name":"ZehMatt/OpenRCT2","owner":{"login":"ZehMatt","id":5415177,"avatar_url":"https://avatars0.githubusercontent.com/u/5415177?v=4","gravatar_id":"","url":"https://api.github.com/users/ZehMatt","html_url":"https://github.com/ZehMatt","followers_url":"https://api.github.com/users/ZehMatt/followers","following_url":"https://api.github.com/users/ZehMatt/following{/other_user}","gists_url":"https://api.github.com/users/ZehMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/ZehMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZehMatt/subscriptions","organizations_url":"https://api.github.com/users/ZehMatt/orgs","repos_url":"https://api.github.com/users/ZehMatt/repos","events_url":"https://api.github.com/users/ZehMatt/events{/privacy}","received_events_url":"https://api.github.com/users/ZehMatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZehMatt/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":true,"url":"https://api.github.com/repos/ZehMatt/OpenRCT2","forks_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/forks","keys_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/events","assignees_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/merges","archive_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/ZehMatt/OpenRCT2/deployments","created_at":"2017-06-09T18:07:22Z","updated_at":"2018-01-06T08:05:41Z","pushed_at":"2018-04-24T08:51:01Z","git_url":"git://github.com/ZehMatt/OpenRCT2.git","ssh_url":"git@github.com:ZehMatt/OpenRCT2.git","clone_url":"https://github.com/ZehMatt/OpenRCT2.git","svn_url":"https://github.com/ZehMatt/OpenRCT2","homepage":"http://openrct2.website","size":74488,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenRCT2:develop","ref":"develop","sha":"d2402336710938546e7f0f8cbe485bfa64fb276e","user":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars0.githubusercontent.com/u/8473908?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"repo":{"id":18348651,"name":"OpenRCT2","full_name":"OpenRCT2/OpenRCT2","owner":{"login":"OpenRCT2","id":8473908,"avatar_url":"https://avatars0.githubusercontent.com/u/8473908?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRCT2","html_url":"https://github.com/OpenRCT2","followers_url":"https://api.github.com/users/OpenRCT2/followers","following_url":"https://api.github.com/users/OpenRCT2/following{/other_user}","gists_url":"https://api.github.com/users/OpenRCT2/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRCT2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRCT2/subscriptions","organizations_url":"https://api.github.com/users/OpenRCT2/orgs","repos_url":"https://api.github.com/users/OpenRCT2/repos","events_url":"https://api.github.com/users/OpenRCT2/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRCT2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRCT2/OpenRCT2","description":"An open source re-implementation of RollerCoaster Tycoon 2 🎢","fork":false,"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2","forks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/forks","keys_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/teams","hooks_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/hooks","issue_events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/events","assignees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/tags","blobs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/languages","stargazers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/stargazers","contributors_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contributors","subscribers_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscribers","subscription_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/subscription","commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/merges","archive_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/downloads","issues_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels{/name}","releases_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/deployments","created_at":"2014-04-01T23:32:25Z","updated_at":"2018-04-24T06:13:23Z","pushed_at":"2018-04-24T08:51:02Z","git_url":"git://github.com/OpenRCT2/OpenRCT2.git","ssh_url":"git@github.com:OpenRCT2/OpenRCT2.git","clone_url":"https://github.com/OpenRCT2/OpenRCT2.git","svn_url":"https://github.com/OpenRCT2/OpenRCT2","homepage":"https://openrct2.io","size":73491,"stargazers_count":5721,"watchers_count":5721,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":622,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":622,"open_issues":786,"watchers":5721,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435"},"html":{"href":"https://github.com/OpenRCT2/OpenRCT2/pull/7435"},"issue":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/7435"},"comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/7435/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/7435/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRCT2/OpenRCT2/statuses/588316eb9c4aad6a7c4b1a18e7c4ad69ae851635"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"janisozaur"}}