{"action":"created","comment":{"url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments/218869693","pull_request_review_id":156871122,"id":218869693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg2OTY5Mw==","diff_hunk":"@@ -109,20 +109,45 @@ namespace {\n     }\n   }\n \n+  /**\n+   * @brief      Beamforms the final samples\n+   *\n+   * @param      filtered_samples         A flat vector containing all the filtered samples.\n+   * @param      beamformed_samples_main  A vector where the beamformed main samples are placed.     ","path":"rx_signal_processing/dsp.cu","position":17,"original_position":17,"commit_id":"77c33d023053f9cdcd834ce3c15ef51d7eecf5dd","original_commit_id":"77c33d023053f9cdcd834ce3c15ef51d7eecf5dd","user":{"login":"mardet987","id":19413948,"node_id":"MDQ6VXNlcjE5NDEzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/19413948?v=4","gravatar_id":"","url":"https://api.github.com/users/mardet987","html_url":"https://github.com/mardet987","followers_url":"https://api.github.com/users/mardet987/followers","following_url":"https://api.github.com/users/mardet987/following{/other_user}","gists_url":"https://api.github.com/users/mardet987/gists{/gist_id}","starred_url":"https://api.github.com/users/mardet987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mardet987/subscriptions","organizations_url":"https://api.github.com/users/mardet987/orgs","repos_url":"https://api.github.com/users/mardet987/repos","events_url":"https://api.github.com/users/mardet987/events{/privacy}","received_events_url":"https://api.github.com/users/mardet987/received_events","type":"User","site_admin":false},"body":"can we be more clear in this docstring that the samples from each array are also combined here? maybe 'beamformed and combined main array samples' and similarly for intf","created_at":"2018-09-19T16:15:17Z","updated_at":"2018-09-19T16:30:42Z","html_url":"https://github.com/SuperDARNCanada/borealis/pull/26#discussion_r218869693","pull_request_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments/218869693"},"html":{"href":"https://github.com/SuperDARNCanada/borealis/pull/26#discussion_r218869693"},"pull_request":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26","id":216469299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDY5Mjk5","html_url":"https://github.com/SuperDARNCanada/borealis/pull/26","diff_url":"https://github.com/SuperDARNCanada/borealis/pull/26.diff","patch_url":"https://github.com/SuperDARNCanada/borealis/pull/26.patch","issue_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/26","number":26,"state":"open","locked":false,"title":"Add beamforming","user":{"login":"kkotyk","id":7105882,"node_id":"MDQ6VXNlcjcxMDU4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/7105882?v=4","gravatar_id":"","url":"https://api.github.com/users/kkotyk","html_url":"https://github.com/kkotyk","followers_url":"https://api.github.com/users/kkotyk/followers","following_url":"https://api.github.com/users/kkotyk/following{/other_user}","gists_url":"https://api.github.com/users/kkotyk/gists{/gist_id}","starred_url":"https://api.github.com/users/kkotyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkotyk/subscriptions","organizations_url":"https://api.github.com/users/kkotyk/orgs","repos_url":"https://api.github.com/users/kkotyk/repos","events_url":"https://api.github.com/users/kkotyk/events{/privacy}","received_events_url":"https://api.github.com/users/kkotyk/received_events","type":"User","site_admin":false},"body":"Lets try this smaller PR.","created_at":"2018-09-18T23:05:06Z","updated_at":"2018-09-19T16:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6660f9fcfe47411460d5e8b03ded28bedf619bd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26/commits","review_comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26/comments","review_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/26/comments","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/77c33d023053f9cdcd834ce3c15ef51d7eecf5dd","head":{"label":"SuperDARNCanada:add_beamforming","ref":"add_beamforming","sha":"77c33d023053f9cdcd834ce3c15ef51d7eecf5dd","user":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"repo":{"id":68139909,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEzOTkwOQ==","name":"borealis","full_name":"SuperDARNCanada/borealis","private":false,"owner":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SuperDARNCanada/borealis","description":"A control system for USRP based digital radars","fork":false,"url":"https://api.github.com/repos/SuperDARNCanada/borealis","forks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/forks","keys_url":"https://api.github.com/repos/SuperDARNCanada/borealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperDARNCanada/borealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperDARNCanada/borealis/teams","hooks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/hooks","issue_events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/events{/number}","events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/events","assignees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/assignees{/user}","branches_url":"https://api.github.com/repos/SuperDARNCanada/borealis/branches{/branch}","tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/tags","blobs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperDARNCanada/borealis/languages","stargazers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/stargazers","contributors_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contributors","subscribers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscribers","subscription_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscription","commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contents/{+path}","compare_url":"https://api.github.com/repos/SuperDARNCanada/borealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperDARNCanada/borealis/merges","archive_url":"https://api.github.com/repos/SuperDARNCanada/borealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperDARNCanada/borealis/downloads","issues_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues{/number}","pulls_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperDARNCanada/borealis/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperDARNCanada/borealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperDARNCanada/borealis/labels{/name}","releases_url":"https://api.github.com/repos/SuperDARNCanada/borealis/releases{/id}","deployments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/deployments","created_at":"2016-09-13T19:22:53Z","updated_at":"2018-09-07T21:10:31Z","pushed_at":"2018-09-18T23:05:06Z","git_url":"git://github.com/SuperDARNCanada/borealis.git","ssh_url":"git@github.com:SuperDARNCanada/borealis.git","clone_url":"https://github.com/SuperDARNCanada/borealis.git","svn_url":"https://github.com/SuperDARNCanada/borealis","homepage":null,"size":81605,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"SuperDARNCanada:process_filtered_samples","ref":"process_filtered_samples","sha":"b630943a893c53945bde7bc1efdb0b10f71a4333","user":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"repo":{"id":68139909,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEzOTkwOQ==","name":"borealis","full_name":"SuperDARNCanada/borealis","private":false,"owner":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SuperDARNCanada/borealis","description":"A control system for USRP based digital radars","fork":false,"url":"https://api.github.com/repos/SuperDARNCanada/borealis","forks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/forks","keys_url":"https://api.github.com/repos/SuperDARNCanada/borealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperDARNCanada/borealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperDARNCanada/borealis/teams","hooks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/hooks","issue_events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/events{/number}","events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/events","assignees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/assignees{/user}","branches_url":"https://api.github.com/repos/SuperDARNCanada/borealis/branches{/branch}","tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/tags","blobs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperDARNCanada/borealis/languages","stargazers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/stargazers","contributors_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contributors","subscribers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscribers","subscription_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscription","commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contents/{+path}","compare_url":"https://api.github.com/repos/SuperDARNCanada/borealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperDARNCanada/borealis/merges","archive_url":"https://api.github.com/repos/SuperDARNCanada/borealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperDARNCanada/borealis/downloads","issues_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues{/number}","pulls_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperDARNCanada/borealis/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperDARNCanada/borealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperDARNCanada/borealis/labels{/name}","releases_url":"https://api.github.com/repos/SuperDARNCanada/borealis/releases{/id}","deployments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/deployments","created_at":"2016-09-13T19:22:53Z","updated_at":"2018-09-07T21:10:31Z","pushed_at":"2018-09-18T23:05:06Z","git_url":"git://github.com/SuperDARNCanada/borealis.git","ssh_url":"git@github.com:SuperDARNCanada/borealis.git","clone_url":"https://github.com/SuperDARNCanada/borealis.git","svn_url":"https://github.com/SuperDARNCanada/borealis","homepage":null,"size":81605,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26"},"html":{"href":"https://github.com/SuperDARNCanada/borealis/pull/26"},"issue":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/26"},"comments":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/77c33d023053f9cdcd834ce3c15ef51d7eecf5dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mardet987"}}