{"action":"created","issue":{"url":"https://api.github.com/repos/ocornut/imgui/issues/1778","repository_url":"https://api.github.com/repos/ocornut/imgui","labels_url":"https://api.github.com/repos/ocornut/imgui/issues/1778/labels{/name}","comments_url":"https://api.github.com/repos/ocornut/imgui/issues/1778/comments","events_url":"https://api.github.com/repos/ocornut/imgui/issues/1778/events","html_url":"https://github.com/ocornut/imgui/pull/1778","id":318250795,"number":1778,"title":"Add CMake project","user":{"login":"podsvirov","id":8400779,"avatar_url":"https://avatars3.githubusercontent.com/u/8400779?v=4","gravatar_id":"","url":"https://api.github.com/users/podsvirov","html_url":"https://github.com/podsvirov","followers_url":"https://api.github.com/users/podsvirov/followers","following_url":"https://api.github.com/users/podsvirov/following{/other_user}","gists_url":"https://api.github.com/users/podsvirov/gists{/gist_id}","starred_url":"https://api.github.com/users/podsvirov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/podsvirov/subscriptions","organizations_url":"https://api.github.com/users/podsvirov/orgs","repos_url":"https://api.github.com/users/podsvirov/repos","events_url":"https://api.github.com/users/podsvirov/events{/privacy}","received_events_url":"https://api.github.com/users/podsvirov/received_events","type":"User","site_admin":false},"labels":[{"id":816486176,"url":"https://api.github.com/repos/ocornut/imgui/labels/build%20tools","name":"build tools","color":"6cd88e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-27T01:46:40Z","updated_at":"2018-05-02T15:12:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ocornut/imgui/pulls/1778","html_url":"https://github.com/ocornut/imgui/pull/1778","diff_url":"https://github.com/ocornut/imgui/pull/1778.diff","patch_url":"https://github.com/ocornut/imgui/pull/1778.patch"},"body":"Now implemented:\r\n- Build ImGui library (CMake's package);\r\n- Optionaly build implementation (ImGui_BUILD_IMPLEMENTATION option);\r\n- Optionaly build examples (ImGui_BUILD_EXAMPLES option);\r\n\r\nAdded examples:\r\n- opengl2_example;\r\n- sdl_opengl2_example.\r\n\r\nCMake's ImGui package contains targets:\r\n- ImGui::Library;\r\n- ImGui::Demo;\r\n- ImGui::ImplOpenGL2;\r\n- ImGui::ImplGlfw;\r\n- ImGui::ImplSDL2.\r\n\r\nUsers can easy link ImGui::Impl<Xxx> libraries and use example binding\r\nimplementation in custom projects.\r\n\r\nTested with MinGW-w64 and MSVC toolchains."},"comment":{"url":"https://api.github.com/repos/ocornut/imgui/issues/comments/386012986","html_url":"https://github.com/ocornut/imgui/pull/1778#issuecomment-386012986","issue_url":"https://api.github.com/repos/ocornut/imgui/issues/1778","id":386012986,"user":{"login":"OvermindDL1","id":401605,"avatar_url":"https://avatars1.githubusercontent.com/u/401605?v=4","gravatar_id":"","url":"https://api.github.com/users/OvermindDL1","html_url":"https://github.com/OvermindDL1","followers_url":"https://api.github.com/users/OvermindDL1/followers","following_url":"https://api.github.com/users/OvermindDL1/following{/other_user}","gists_url":"https://api.github.com/users/OvermindDL1/gists{/gist_id}","starred_url":"https://api.github.com/users/OvermindDL1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OvermindDL1/subscriptions","organizations_url":"https://api.github.com/users/OvermindDL1/orgs","repos_url":"https://api.github.com/users/OvermindDL1/repos","events_url":"https://api.github.com/users/OvermindDL1/events{/privacy}","received_events_url":"https://api.github.com/users/OvermindDL1/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T15:12:45Z","updated_at":"2018-05-02T15:12:45Z","author_association":"NONE","body":">  If users want to configure imgui they can use imconfig.h\r\n\r\nYeah this is still a horror.  We'd never ever ever be okay with editing third-party source just to set configs.  A configure script or CMakeLists file is definitely what should be done to generate such a file (this is why there needs to be a top-level CMakeLists.txt file who's sole purpose is to include the necessary source files and generate the configuration source based on the options specified, this would allow `add_subdirectory`'ing imgui into a project).\r\n\r\n> ImGui is really not designed to be packaged into a library, nor \"installed\" in system paths - I think it is often a mistake to do so because it often creates a situation that prevents users from actually configuring the library. We want to encourage people to configure the library to e.g. add the necessary defines to use their maths types and cast them to ImVec2 implicitly, or to modify the ImDrawIdx type, or the ImDrawVert layout.\r\n\r\nThis should all be done via a generated configuration file, all of it."}}
{"actor":{"display_login":"OvermindDL1"}}