{"action":"created","issue":{"url":"https://api.github.com/repos/node-serialport/node-serialport/issues/1742","repository_url":"https://api.github.com/repos/node-serialport/node-serialport","labels_url":"https://api.github.com/repos/node-serialport/node-serialport/issues/1742/labels{/name}","comments_url":"https://api.github.com/repos/node-serialport/node-serialport/issues/1742/comments","events_url":"https://api.github.com/repos/node-serialport/node-serialport/issues/1742/events","html_url":"https://github.com/node-serialport/node-serialport/issues/1742","id":391374185,"node_id":"MDU6SXNzdWUzOTEzNzQxODU=","number":1742,"title":"Incompatibility with Node 12/master","user":{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"labels":[{"id":65414281,"node_id":"MDU6TGFiZWw2NTQxNDI4MQ==","url":"https://api.github.com/repos/node-serialport/node-serialport/labels/feature-request","name":"feature-request","color":"1d76db","default":false},{"id":522895264,"node_id":"MDU6TGFiZWw1MjI4OTUyNjQ=","url":"https://api.github.com/repos/node-serialport/node-serialport/labels/help-wanted","name":"help-wanted","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-12-15T12:28:47Z","updated_at":"2018-12-19T19:39:19Z","closed_at":"2018-12-16T03:29:51Z","author_association":"NONE","body":"From our tests, this module will not work on Node 12/master, likely for the usage of some deprecated V8 APIs.\r\n\r\nWe are currently removing this from our CITGM suite: https://github.com/nodejs/citgm/pull/654."},"comment":{"url":"https://api.github.com/repos/node-serialport/node-serialport/issues/comments/448718915","html_url":"https://github.com/node-serialport/node-serialport/issues/1742#issuecomment-448718915","issue_url":"https://api.github.com/repos/node-serialport/node-serialport/issues/1742","id":448718915,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODcxODkxNQ==","user":{"login":"indutny","id":238531,"node_id":"MDQ6VXNlcjIzODUzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/238531?v=4","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T19:39:19Z","updated_at":"2018-12-19T19:39:19Z","author_association":"NONE","body":"You're right, @fivdi and @zbjornson . Having `AsyncResource` in general should be a good idea. What I was implying is that its use wasn't necessary for making things compile again. Good feature request, though!"}}
{"actor":{"display_login":"indutny"}}