{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/464","repository_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet","labels_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/464/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/464/comments","events_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/464/events","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/464","id":297525208,"number":464,"title":"Show localised error when user rejects transaction in MetaMask","user":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-15T17:10:28Z","updated_at":"2018-02-25T12:00:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/pulls/464","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/464","diff_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/464.diff","patch_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/464.patch"},"body":"At the moment, when the user rejects a transaction from within MetaMask, a stack trace of the error within the MetaMask extension is displayed. This gives very little value to the user as to what actually happened.\r\n\r\nChecking for `setTxStatusRejected` in the error message seems to be the safest way to check if the transaction was rejected from within MetaMask that works in all browsers since Firefox clips the start of the error message.\r\n\r\nI have translated the new message to German but left the other languages untouched since I speak neither of them. I don't know what the standard policy for that is and if they would be required for the PR to be accepted."},"comment":{"url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/comments/368303565","html_url":"https://github.com/ethereum/meteor-dapp-wallet/pull/464#issuecomment-368303565","issue_url":"https://api.github.com/repos/ethereum/meteor-dapp-wallet/issues/464","id":368303565,"user":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T12:00:00Z","updated_at":"2018-02-25T12:00:00Z","author_association":"NONE","body":"The entire check is pretty tailor-made for MetaMask, since I'm checking for `setTxStatusRejected`, which is a MetaMask-internal function that occurs in the error's stack trace. I can remove the reference to MetaMask, but don't think this will make the check any more general."}}
{"actor":{"display_login":"ahoppen"}}