{"action":"created","comment":{"url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/comments/181236019","pull_request_review_id":111813203,"id":181236019,"diff_hunk":"@@ -1,8 +1,10 @@\n 'use strict';\n \n-const Filter = require('broccoli-filter');\n+const Filter = require('broccoli-persistent-filter');\n const gql = require('graphql-tag');\n \n+gql.disableFragmentWarnings();","path":"lib/graphql-filter.js","position":7,"original_position":7,"commit_id":"711ee21e1d719a8125bf2f70063289b473cf64c1","original_commit_id":"711ee21e1d719a8125bf2f70063289b473cf64c1","user":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars2.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"body":"Ah, I totally forgot I'd made that change. I hadn't actually meant to include it in this PR, and I'm happy to pull it into a separate one if you'd like.\r\n\r\nApollo likes fragment names to be unique, and they pushed a warning about that into their parsing layer (it used to be at runtime, and you'd get a warning [if you used the same fragment twice](https://github.com/apollographql/apollo-client/issues/940) in different queries at all).\r\n\r\nBecause the lifetime of `gql-tag`'s module state spans multiple builds, if you make changes to a fragment, the rebuild issues a warning because it's now parsed multiple different versions of that fragment.","created_at":"2018-04-12T22:06:23Z","updated_at":"2018-04-12T22:06:23Z","html_url":"https://github.com/bgentry/ember-apollo-client/pull/126#discussion_r181236019","pull_request_url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/comments/181236019"},"html":{"href":"https://github.com/bgentry/ember-apollo-client/pull/126#discussion_r181236019"},"pull_request":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126"}},"in_reply_to_id":181230805},"pull_request":{"url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126","id":181026128,"html_url":"https://github.com/bgentry/ember-apollo-client/pull/126","diff_url":"https://github.com/bgentry/ember-apollo-client/pull/126.diff","patch_url":"https://github.com/bgentry/ember-apollo-client/pull/126.patch","issue_url":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/126","number":126,"state":"open","locked":false,"title":"Use broccoli-persistent-filter for faster rebuilds","user":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars2.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"body":"I noticed that `GraphQLFilter` was consistently showing up as a top culprit for runtime in our rebuild output.\r\n\r\nThis switches that over to use `broccoli-persistent-filter` as a base, which is much more intelligent about reusing existing results for files that haven't changed (and, I suspect more importantly for our case with a huge `app/` tree: it remembers when `canProcessFile` has returned `false` and doesn't bother asking again).","created_at":"2018-04-11T20:57:47Z","updated_at":"2018-04-12T22:06:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccdf8ccb85a80a87219d893231a815fea2efb757","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126/commits","review_comments_url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126/comments","review_comment_url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/126/comments","statuses_url":"https://api.github.com/repos/bgentry/ember-apollo-client/statuses/711ee21e1d719a8125bf2f70063289b473cf64c1","head":{"label":"dfreeman:faster-rebuilds","ref":"faster-rebuilds","sha":"711ee21e1d719a8125bf2f70063289b473cf64c1","user":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars2.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"repo":{"id":78480737,"name":"ember-apollo-client","full_name":"dfreeman/ember-apollo-client","owner":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars2.githubusercontent.com/u/108688?v=4","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfreeman/ember-apollo-client","description":"An ember-cli addon for apollo-client / graphql","fork":true,"url":"https://api.github.com/repos/dfreeman/ember-apollo-client","forks_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/forks","keys_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/teams","hooks_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/hooks","issue_events_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/events","assignees_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/tags","blobs_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/languages","stargazers_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/stargazers","contributors_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/contributors","subscribers_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/subscribers","subscription_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/subscription","commits_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/merges","archive_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/downloads","issues_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/dfreeman/ember-apollo-client/deployments","created_at":"2017-01-10T00:03:57Z","updated_at":"2017-01-10T00:03:58Z","pushed_at":"2018-04-12T19:47:33Z","git_url":"git://github.com/dfreeman/ember-apollo-client.git","ssh_url":"git@github.com:dfreeman/ember-apollo-client.git","clone_url":"https://github.com/dfreeman/ember-apollo-client.git","svn_url":"https://github.com/dfreeman/ember-apollo-client","homepage":"","size":634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bgentry:master","ref":"master","sha":"ecd25fa03b6c066530d5bdf530579eae54bf4841","user":{"login":"bgentry","id":114033,"avatar_url":"https://avatars2.githubusercontent.com/u/114033?v=4","gravatar_id":"","url":"https://api.github.com/users/bgentry","html_url":"https://github.com/bgentry","followers_url":"https://api.github.com/users/bgentry/followers","following_url":"https://api.github.com/users/bgentry/following{/other_user}","gists_url":"https://api.github.com/users/bgentry/gists{/gist_id}","starred_url":"https://api.github.com/users/bgentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgentry/subscriptions","organizations_url":"https://api.github.com/users/bgentry/orgs","repos_url":"https://api.github.com/users/bgentry/repos","events_url":"https://api.github.com/users/bgentry/events{/privacy}","received_events_url":"https://api.github.com/users/bgentry/received_events","type":"User","site_admin":false},"repo":{"id":78405075,"name":"ember-apollo-client","full_name":"bgentry/ember-apollo-client","owner":{"login":"bgentry","id":114033,"avatar_url":"https://avatars2.githubusercontent.com/u/114033?v=4","gravatar_id":"","url":"https://api.github.com/users/bgentry","html_url":"https://github.com/bgentry","followers_url":"https://api.github.com/users/bgentry/followers","following_url":"https://api.github.com/users/bgentry/following{/other_user}","gists_url":"https://api.github.com/users/bgentry/gists{/gist_id}","starred_url":"https://api.github.com/users/bgentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgentry/subscriptions","organizations_url":"https://api.github.com/users/bgentry/orgs","repos_url":"https://api.github.com/users/bgentry/repos","events_url":"https://api.github.com/users/bgentry/events{/privacy}","received_events_url":"https://api.github.com/users/bgentry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgentry/ember-apollo-client","description":"🚀 An ember-cli addon for Apollo Client and GraphQL","fork":false,"url":"https://api.github.com/repos/bgentry/ember-apollo-client","forks_url":"https://api.github.com/repos/bgentry/ember-apollo-client/forks","keys_url":"https://api.github.com/repos/bgentry/ember-apollo-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgentry/ember-apollo-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgentry/ember-apollo-client/teams","hooks_url":"https://api.github.com/repos/bgentry/ember-apollo-client/hooks","issue_events_url":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/events{/number}","events_url":"https://api.github.com/repos/bgentry/ember-apollo-client/events","assignees_url":"https://api.github.com/repos/bgentry/ember-apollo-client/assignees{/user}","branches_url":"https://api.github.com/repos/bgentry/ember-apollo-client/branches{/branch}","tags_url":"https://api.github.com/repos/bgentry/ember-apollo-client/tags","blobs_url":"https://api.github.com/repos/bgentry/ember-apollo-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgentry/ember-apollo-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgentry/ember-apollo-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgentry/ember-apollo-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgentry/ember-apollo-client/statuses/{sha}","languages_url":"https://api.github.com/repos/bgentry/ember-apollo-client/languages","stargazers_url":"https://api.github.com/repos/bgentry/ember-apollo-client/stargazers","contributors_url":"https://api.github.com/repos/bgentry/ember-apollo-client/contributors","subscribers_url":"https://api.github.com/repos/bgentry/ember-apollo-client/subscribers","subscription_url":"https://api.github.com/repos/bgentry/ember-apollo-client/subscription","commits_url":"https://api.github.com/repos/bgentry/ember-apollo-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgentry/ember-apollo-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgentry/ember-apollo-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgentry/ember-apollo-client/contents/{+path}","compare_url":"https://api.github.com/repos/bgentry/ember-apollo-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgentry/ember-apollo-client/merges","archive_url":"https://api.github.com/repos/bgentry/ember-apollo-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgentry/ember-apollo-client/downloads","issues_url":"https://api.github.com/repos/bgentry/ember-apollo-client/issues{/number}","pulls_url":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls{/number}","milestones_url":"https://api.github.com/repos/bgentry/ember-apollo-client/milestones{/number}","notifications_url":"https://api.github.com/repos/bgentry/ember-apollo-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgentry/ember-apollo-client/labels{/name}","releases_url":"https://api.github.com/repos/bgentry/ember-apollo-client/releases{/id}","deployments_url":"https://api.github.com/repos/bgentry/ember-apollo-client/deployments","created_at":"2017-01-09T07:36:20Z","updated_at":"2018-04-12T06:23:59Z","pushed_at":"2018-04-12T19:47:34Z","git_url":"git://github.com/bgentry/ember-apollo-client.git","ssh_url":"git@github.com:bgentry/ember-apollo-client.git","clone_url":"https://github.com/bgentry/ember-apollo-client.git","svn_url":"https://github.com/bgentry/ember-apollo-client","homepage":"","size":723,"stargazers_count":138,"watchers_count":138,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":28,"open_issues":12,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126"},"html":{"href":"https://github.com/bgentry/ember-apollo-client/pull/126"},"issue":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/126"},"comments":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/bgentry/ember-apollo-client/statuses/711ee21e1d719a8125bf2f70063289b473cf64c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dfreeman"}}