{"action":"closed","number":1085,"pull_request":{"url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085","id":167350091,"html_url":"https://github.com/espressif/arduino-esp32/pull/1085","diff_url":"https://github.com/espressif/arduino-esp32/pull/1085.diff","patch_url":"https://github.com/espressif/arduino-esp32/pull/1085.patch","issue_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1085","number":1085,"state":"closed","locked":false,"title":"Make ESPmDNS compatible to ESP8266mDNS","user":{"login":"beegee-tokyo","id":512690,"avatar_url":"https://avatars3.githubusercontent.com/u/512690?v=4","gravatar_id":"","url":"https://api.github.com/users/beegee-tokyo","html_url":"https://github.com/beegee-tokyo","followers_url":"https://api.github.com/users/beegee-tokyo/followers","following_url":"https://api.github.com/users/beegee-tokyo/following{/other_user}","gists_url":"https://api.github.com/users/beegee-tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/beegee-tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beegee-tokyo/subscriptions","organizations_url":"https://api.github.com/users/beegee-tokyo/orgs","repos_url":"https://api.github.com/users/beegee-tokyo/repos","events_url":"https://api.github.com/users/beegee-tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/beegee-tokyo/received_events","type":"User","site_admin":false},"body":"The ESP8266 version of the mDNS library expected service name and protocol **without** leading `_` (underscore). The ESP32 version expected service name and protocol **with** leading `_` (underscore).\r\n\r\nThis small change makes the ESP32 version compatible with the ESP8266 version and keeps backward compatibility with existing code by accepting service name and protocol either **with or without** leading `_` (underscore).\r\n\r\nSee issues #962 #387\r\n\r\nTested with following combinations:    \r\n```cpp\r\n  MDNS.addService(\"test1\",\"tcp\",9998);\r\n  MDNS.addServiceTxt(\"test1\", \"tcp\", \"id\", \"mDNS-Test\");\r\n\r\n  MDNS.addService(\"_test2\",\"tcp\",9998);\r\n  MDNS.addServiceTxt(\"_test2\", \"tcp\", \"id\", \"mDNS-Test\");\r\n\r\n  MDNS.addService(\"test3\",\"_tcp\",9998);\r\n  MDNS.addServiceTxt(\"test3\", \"_tcp\", \"id\", \"mDNS-Test\");\r\n\r\n  MDNS.addService(\"_test4\",\"_tcp\",9998);\r\n  MDNS.addServiceTxt(\"_test4\", \"_tcp\", \"id\", \"mDNS-Test\");\r\n```","created_at":"2018-02-06T08:41:17Z","updated_at":"2018-03-04T19:50:39Z","closed_at":"2018-03-04T19:50:39Z","merged_at":"2018-03-04T19:50:39Z","merge_commit_sha":"494ff217aabfc21db00d228c87d58028bb4c7498","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085/commits","review_comments_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085/comments","review_comment_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1085/comments","statuses_url":"https://api.github.com/repos/espressif/arduino-esp32/statuses/1c93c1befa587bb9294c9f27837964a5ede63d6a","head":{"label":"beegee-tokyo:master","ref":"master","sha":"1c93c1befa587bb9294c9f27837964a5ede63d6a","user":{"login":"beegee-tokyo","id":512690,"avatar_url":"https://avatars3.githubusercontent.com/u/512690?v=4","gravatar_id":"","url":"https://api.github.com/users/beegee-tokyo","html_url":"https://github.com/beegee-tokyo","followers_url":"https://api.github.com/users/beegee-tokyo/followers","following_url":"https://api.github.com/users/beegee-tokyo/following{/other_user}","gists_url":"https://api.github.com/users/beegee-tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/beegee-tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beegee-tokyo/subscriptions","organizations_url":"https://api.github.com/users/beegee-tokyo/orgs","repos_url":"https://api.github.com/users/beegee-tokyo/repos","events_url":"https://api.github.com/users/beegee-tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/beegee-tokyo/received_events","type":"User","site_admin":false},"repo":{"id":120388556,"name":"arduino-esp32","full_name":"beegee-tokyo/arduino-esp32","owner":{"login":"beegee-tokyo","id":512690,"avatar_url":"https://avatars3.githubusercontent.com/u/512690?v=4","gravatar_id":"","url":"https://api.github.com/users/beegee-tokyo","html_url":"https://github.com/beegee-tokyo","followers_url":"https://api.github.com/users/beegee-tokyo/followers","following_url":"https://api.github.com/users/beegee-tokyo/following{/other_user}","gists_url":"https://api.github.com/users/beegee-tokyo/gists{/gist_id}","starred_url":"https://api.github.com/users/beegee-tokyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beegee-tokyo/subscriptions","organizations_url":"https://api.github.com/users/beegee-tokyo/orgs","repos_url":"https://api.github.com/users/beegee-tokyo/repos","events_url":"https://api.github.com/users/beegee-tokyo/events{/privacy}","received_events_url":"https://api.github.com/users/beegee-tokyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beegee-tokyo/arduino-esp32","description":"Arduino core for the ESP32","fork":true,"url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32","forks_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/forks","keys_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/teams","hooks_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/hooks","issue_events_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/issues/events{/number}","events_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/events","assignees_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/assignees{/user}","branches_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/branches{/branch}","tags_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/tags","blobs_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/git/refs{/sha}","trees_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/statuses/{sha}","languages_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/languages","stargazers_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/stargazers","contributors_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/contributors","subscribers_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/subscribers","subscription_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/subscription","commits_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/commits{/sha}","git_commits_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/git/commits{/sha}","comments_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/comments{/number}","issue_comment_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/issues/comments{/number}","contents_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/contents/{+path}","compare_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/merges","archive_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/downloads","issues_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/issues{/number}","pulls_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/pulls{/number}","milestones_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/milestones{/number}","notifications_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/labels{/name}","releases_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/releases{/id}","deployments_url":"https://api.github.com/repos/beegee-tokyo/arduino-esp32/deployments","created_at":"2018-02-06T02:10:31Z","updated_at":"2018-02-22T06:14:31Z","pushed_at":"2018-02-06T08:32:59Z","git_url":"git://github.com/beegee-tokyo/arduino-esp32.git","ssh_url":"git@github.com:beegee-tokyo/arduino-esp32.git","clone_url":"https://github.com/beegee-tokyo/arduino-esp32.git","svn_url":"https://github.com/beegee-tokyo/arduino-esp32","homepage":null,"size":108594,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"espressif:master","ref":"master","sha":"c8596cb9bb9f15578cc6ac0582edcd81976e585c","user":{"login":"espressif","id":9460735,"avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"repo":{"id":70127218,"name":"arduino-esp32","full_name":"espressif/arduino-esp32","owner":{"login":"espressif","id":9460735,"avatar_url":"https://avatars2.githubusercontent.com/u/9460735?v=4","gravatar_id":"","url":"https://api.github.com/users/espressif","html_url":"https://github.com/espressif","followers_url":"https://api.github.com/users/espressif/followers","following_url":"https://api.github.com/users/espressif/following{/other_user}","gists_url":"https://api.github.com/users/espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressif/subscriptions","organizations_url":"https://api.github.com/users/espressif/orgs","repos_url":"https://api.github.com/users/espressif/repos","events_url":"https://api.github.com/users/espressif/events{/privacy}","received_events_url":"https://api.github.com/users/espressif/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressif/arduino-esp32","description":"Arduino core for the ESP32","fork":false,"url":"https://api.github.com/repos/espressif/arduino-esp32","forks_url":"https://api.github.com/repos/espressif/arduino-esp32/forks","keys_url":"https://api.github.com/repos/espressif/arduino-esp32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressif/arduino-esp32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressif/arduino-esp32/teams","hooks_url":"https://api.github.com/repos/espressif/arduino-esp32/hooks","issue_events_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/events{/number}","events_url":"https://api.github.com/repos/espressif/arduino-esp32/events","assignees_url":"https://api.github.com/repos/espressif/arduino-esp32/assignees{/user}","branches_url":"https://api.github.com/repos/espressif/arduino-esp32/branches{/branch}","tags_url":"https://api.github.com/repos/espressif/arduino-esp32/tags","blobs_url":"https://api.github.com/repos/espressif/arduino-esp32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressif/arduino-esp32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressif/arduino-esp32/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressif/arduino-esp32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressif/arduino-esp32/statuses/{sha}","languages_url":"https://api.github.com/repos/espressif/arduino-esp32/languages","stargazers_url":"https://api.github.com/repos/espressif/arduino-esp32/stargazers","contributors_url":"https://api.github.com/repos/espressif/arduino-esp32/contributors","subscribers_url":"https://api.github.com/repos/espressif/arduino-esp32/subscribers","subscription_url":"https://api.github.com/repos/espressif/arduino-esp32/subscription","commits_url":"https://api.github.com/repos/espressif/arduino-esp32/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressif/arduino-esp32/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressif/arduino-esp32/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressif/arduino-esp32/contents/{+path}","compare_url":"https://api.github.com/repos/espressif/arduino-esp32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressif/arduino-esp32/merges","archive_url":"https://api.github.com/repos/espressif/arduino-esp32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressif/arduino-esp32/downloads","issues_url":"https://api.github.com/repos/espressif/arduino-esp32/issues{/number}","pulls_url":"https://api.github.com/repos/espressif/arduino-esp32/pulls{/number}","milestones_url":"https://api.github.com/repos/espressif/arduino-esp32/milestones{/number}","notifications_url":"https://api.github.com/repos/espressif/arduino-esp32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressif/arduino-esp32/labels{/name}","releases_url":"https://api.github.com/repos/espressif/arduino-esp32/releases{/id}","deployments_url":"https://api.github.com/repos/espressif/arduino-esp32/deployments","created_at":"2016-10-06T06:04:20Z","updated_at":"2018-03-04T18:12:01Z","pushed_at":"2018-03-04T19:50:39Z","git_url":"git://github.com/espressif/arduino-esp32.git","ssh_url":"git@github.com:espressif/arduino-esp32.git","clone_url":"https://github.com/espressif/arduino-esp32.git","svn_url":"https://github.com/espressif/arduino-esp32","homepage":null,"size":107404,"stargazers_count":1595,"watchers_count":1595,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":622,"mirror_url":null,"archived":false,"open_issues_count":345,"license":null,"forks":622,"open_issues":345,"watchers":1595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085"},"html":{"href":"https://github.com/espressif/arduino-esp32/pull/1085"},"issue":{"href":"https://api.github.com/repos/espressif/arduino-esp32/issues/1085"},"comments":{"href":"https://api.github.com/repos/espressif/arduino-esp32/issues/1085/comments"},"review_comments":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085/comments"},"review_comment":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressif/arduino-esp32/pulls/1085/commits"},"statuses":{"href":"https://api.github.com/repos/espressif/arduino-esp32/statuses/1c93c1befa587bb9294c9f27837964a5ede63d6a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"me-no-dev","id":12663778,"avatar_url":"https://avatars3.githubusercontent.com/u/12663778?v=4","gravatar_id":"","url":"https://api.github.com/users/me-no-dev","html_url":"https://github.com/me-no-dev","followers_url":"https://api.github.com/users/me-no-dev/followers","following_url":"https://api.github.com/users/me-no-dev/following{/other_user}","gists_url":"https://api.github.com/users/me-no-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/me-no-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/me-no-dev/subscriptions","organizations_url":"https://api.github.com/users/me-no-dev/orgs","repos_url":"https://api.github.com/users/me-no-dev/repos","events_url":"https://api.github.com/users/me-no-dev/events{/privacy}","received_events_url":"https://api.github.com/users/me-no-dev/received_events","type":"User","site_admin":false},"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":39,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"me-no-dev"}}