{"action":"created","issue":{"url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1830","repository_url":"https://api.github.com/repos/pydanny/cookiecutter-django","labels_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1830/labels{/name}","comments_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1830/comments","events_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1830/events","html_url":"https://github.com/pydanny/cookiecutter-django/pull/1830","id":368939819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTk2OTYx","number":1830,"title":"Remove requirements.txt file from delete list.","user":{"login":"cmackenzie1","id":10947617,"node_id":"MDQ6VXNlcjEwOTQ3NjE3","avatar_url":"https://avatars3.githubusercontent.com/u/10947617?v=4","gravatar_id":"","url":"https://api.github.com/users/cmackenzie1","html_url":"https://github.com/cmackenzie1","followers_url":"https://api.github.com/users/cmackenzie1/followers","following_url":"https://api.github.com/users/cmackenzie1/following{/other_user}","gists_url":"https://api.github.com/users/cmackenzie1/gists{/gist_id}","starred_url":"https://api.github.com/users/cmackenzie1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmackenzie1/subscriptions","organizations_url":"https://api.github.com/users/cmackenzie1/orgs","repos_url":"https://api.github.com/users/cmackenzie1/repos","events_url":"https://api.github.com/users/cmackenzie1/events{/privacy}","received_events_url":"https://api.github.com/users/cmackenzie1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-11T03:39:02Z","updated_at":"2018-10-16T19:05:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pydanny/cookiecutter-django/pulls/1830","html_url":"https://github.com/pydanny/cookiecutter-django/pull/1830","diff_url":"https://github.com/pydanny/cookiecutter-django/pull/1830.diff","patch_url":"https://github.com/pydanny/cookiecutter-django/pull/1830.patch"},"body":"fixes #1829\r\n\r\n[//]: # (Thank you for helping us out: your efforts mean great deal to the project and the community as a whole!)\r\n\r\n[//]: # (Before you proceed:)\r\n\r\n[//]: # (1. Make sure to add yourself to `CONTRIBUTORS.rst` through this PR provided you're contributing here for the first time)\r\n[//]: # (2. Don't forget to update the `docs/` presuming others would benefit from a concise description of whatever that you're proposing)\r\n\r\n\r\n## Description\r\n\r\n[//]: # (What's it you're proposing?)\r\nRemoving the `requirements.txt` from the list of files to delete if heroku is not enabled.\r\n\r\n\r\n\r\n## Rationale\r\n\r\n[//]: # (Why does the project need that?)\r\nUsing TravisCI but not enabling Heroku causes the `requirements.txt` file in the root dir to be deleted, thus needing an overridden `.travis.yml` install key.\r\n\r\n\r\n## Use case(s) / visualization(s)\r\n\r\n[//]: # (\"Better to see something once than to hear about it a thousand times.\")\r\n\r\nAs a user of this template, I want to create an app without Heroku support, but support for TravisCI, using the output of `cookiecutter`\r\n"},"comment":{"url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/comments/430359701","html_url":"https://github.com/pydanny/cookiecutter-django/pull/1830#issuecomment-430359701","issue_url":"https://api.github.com/repos/pydanny/cookiecutter-django/issues/1830","id":430359701,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDM1OTcwMQ==","user":{"login":"webyneter","id":2845133,"node_id":"MDQ6VXNlcjI4NDUxMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2845133?v=4","gravatar_id":"","url":"https://api.github.com/users/webyneter","html_url":"https://github.com/webyneter","followers_url":"https://api.github.com/users/webyneter/followers","following_url":"https://api.github.com/users/webyneter/following{/other_user}","gists_url":"https://api.github.com/users/webyneter/gists{/gist_id}","starred_url":"https://api.github.com/users/webyneter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webyneter/subscriptions","organizations_url":"https://api.github.com/users/webyneter/orgs","repos_url":"https://api.github.com/users/webyneter/repos","events_url":"https://api.github.com/users/webyneter/events{/privacy}","received_events_url":"https://api.github.com/users/webyneter/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T19:05:17Z","updated_at":"2018-10-16T19:05:17Z","author_association":"COLLABORATOR","body":"@cmackenzie1 the thing is, we've already got `./requirements/` with a number of requirements files in it: some of them serve as base templates -- like `base.txt` -- while the others -- `test.txt`, `local.txt`, and `production.txt` -- are used directly. As a result, there's no need to have yet another requirements file serving merely as a proxy; it's only required in Heroku bare-bones deployment setup anyway... My point is, if not for Heroku we wouldn't have `./requirements.txt` in the first place."}}
{"actor":{"display_login":"webyneter"}}