{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/184477302","pull_request_review_id":115682967,"id":184477302,"diff_hunk":"@@ -127,14 +127,10 @@ rec {\n         ]\n       ];\n \n-      # When cross-compiling checks need to be enabled explicitly via crossAttrs\n-      doCheck' = if stdenv.hostPlatform == stdenv.buildPlatform\n-                 then doCheck\n-                 else attrs.crossAttrs.doCheck or false;\n-\n-      doInstallCheck' = if stdenv.hostPlatform == stdenv.buildPlatform\n-                        then doInstallCheck\n-                        else attrs.crossAttrs.doInstallCheck or false;\n+      # TODO(@oxij, @Ericson2314): This is here to keep the old semantics, remove when\n+      # no package has `doCheck = true`.","path":"pkgs/stdenv/generic/make-derivation.nix","position":null,"original_position":13,"commit_id":"9ee061ac01e96b594e46b35937d4eea25355bd05","original_commit_id":"9ee061ac01e96b594e46b35937d4eea25355bd05","user":{"login":"Ericson2314","id":1055245,"avatar_url":"https://avatars3.githubusercontent.com/u/1055245?v=4","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"body":"\"no package has `doCheck = true`.\" is an excellent way to phrase it, thanks :).","created_at":"2018-04-26T17:50:25Z","updated_at":"2018-04-26T17:50:26Z","html_url":"https://github.com/NixOS/nixpkgs/pull/39464#discussion_r184477302","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/184477302"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39464#discussion_r184477302"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464","id":183921148,"html_url":"https://github.com/NixOS/nixpkgs/pull/39464","diff_url":"https://github.com/NixOS/nixpkgs/pull/39464.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/39464.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39464","number":39464,"state":"open","locked":false,"title":"stdenv: implement most of #33599","user":{"login":"oxij","id":391919,"avatar_url":"https://avatars2.githubusercontent.com/u/391919?v=4","gravatar_id":"","url":"https://api.github.com/users/oxij","html_url":"https://github.com/oxij","followers_url":"https://api.github.com/users/oxij/followers","following_url":"https://api.github.com/users/oxij/following{/other_user}","gists_url":"https://api.github.com/users/oxij/gists{/gist_id}","starred_url":"https://api.github.com/users/oxij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxij/subscriptions","organizations_url":"https://api.github.com/users/oxij/orgs","repos_url":"https://api.github.com/users/oxij/repos","events_url":"https://api.github.com/users/oxij/events{/privacy}","received_events_url":"https://api.github.com/users/oxij/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nSee #39463. <strike>This is from the same patchset that implements #33599. This subpatchset implements the main feature needed to implement #33599: `checkTarget` autodetection.\r\n\r\nNote that this is independent from #39463 because this _does not set `doCheck` to `true` by default_.\r\n\r\nAlso note that applying this to master changes nothing (except it causes a mass-rebuild). This makes #33599 trivial to implement, however.</strike>\r\n\r\nThis now has everything you need to have #33599. Just set `config.doCheckByDefault = true` and behold how many more failed tests there are. I will PR a huge bunch of fixes for those bugs later (after I rebuild everything myself on top of this version).\r\n\r\n###### Things done\r\n\r\n- [X] When combined with other patches in the series the system builds.\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n","created_at":"2018-04-25T04:15:31Z","updated_at":"2018-04-26T17:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d06b7dcfc6cfe2c9d7b6107ac2029db8bb0df46","assignee":null,"assignees":[],"requested_reviewers":[{"login":"peti","id":28323,"avatar_url":"https://avatars3.githubusercontent.com/u/28323?v=4","gravatar_id":"","url":"https://api.github.com/users/peti","html_url":"https://github.com/peti","followers_url":"https://api.github.com/users/peti/followers","following_url":"https://api.github.com/users/peti/following{/other_user}","gists_url":"https://api.github.com/users/peti/gists{/gist_id}","starred_url":"https://api.github.com/users/peti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peti/subscriptions","organizations_url":"https://api.github.com/users/peti/orgs","repos_url":"https://api.github.com/users/peti/repos","events_url":"https://api.github.com/users/peti/events{/privacy}","received_events_url":"https://api.github.com/users/peti/received_events","type":"User","site_admin":false},{"login":"FRidh","id":2129135,"avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":737692408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin-stdenv","name":"10.rebuild-darwin-stdenv","color":"b60205","default":false},{"id":731735740,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20501+","name":"10.rebuild-darwin: 501+","color":"b60205","default":false},{"id":737692313,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux-stdenv","name":"10.rebuild-linux-stdenv","color":"b60205","default":false},{"id":731734523,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":99513706,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20haskell","name":"6.topic: haskell","color":"fef2c0","default":false},{"id":9820195,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":897230915,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20stdenv","name":"6.topic: stdenv","color":"fef2c0","default":false},{"id":290122655,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39464/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9ee061ac01e96b594e46b35937d4eea25355bd05","head":{"label":"oxij:stdenv/docheck-infra","ref":"stdenv/docheck-infra","sha":"9ee061ac01e96b594e46b35937d4eea25355bd05","user":{"login":"oxij","id":391919,"avatar_url":"https://avatars2.githubusercontent.com/u/391919?v=4","gravatar_id":"","url":"https://api.github.com/users/oxij","html_url":"https://github.com/oxij","followers_url":"https://api.github.com/users/oxij/followers","following_url":"https://api.github.com/users/oxij/following{/other_user}","gists_url":"https://api.github.com/users/oxij/gists{/gist_id}","starred_url":"https://api.github.com/users/oxij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxij/subscriptions","organizations_url":"https://api.github.com/users/oxij/orgs","repos_url":"https://api.github.com/users/oxij/repos","events_url":"https://api.github.com/users/oxij/events{/privacy}","received_events_url":"https://api.github.com/users/oxij/received_events","type":"User","site_admin":false},"repo":{"id":4931866,"name":"nixpkgs","full_name":"oxij/nixpkgs","owner":{"login":"oxij","id":391919,"avatar_url":"https://avatars2.githubusercontent.com/u/391919?v=4","gravatar_id":"","url":"https://api.github.com/users/oxij","html_url":"https://github.com/oxij","followers_url":"https://api.github.com/users/oxij/followers","following_url":"https://api.github.com/users/oxij/following{/other_user}","gists_url":"https://api.github.com/users/oxij/gists{/gist_id}","starred_url":"https://api.github.com/users/oxij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxij/subscriptions","organizations_url":"https://api.github.com/users/oxij/orgs","repos_url":"https://api.github.com/users/oxij/repos","events_url":"https://api.github.com/users/oxij/events{/privacy}","received_events_url":"https://api.github.com/users/oxij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oxij/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/oxij/nixpkgs","forks_url":"https://api.github.com/repos/oxij/nixpkgs/forks","keys_url":"https://api.github.com/repos/oxij/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oxij/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oxij/nixpkgs/teams","hooks_url":"https://api.github.com/repos/oxij/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/oxij/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/oxij/nixpkgs/events","assignees_url":"https://api.github.com/repos/oxij/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/oxij/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/oxij/nixpkgs/tags","blobs_url":"https://api.github.com/repos/oxij/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oxij/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oxij/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/oxij/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oxij/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/oxij/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/oxij/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/oxij/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/oxij/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/oxij/nixpkgs/subscription","commits_url":"https://api.github.com/repos/oxij/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/oxij/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/oxij/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/oxij/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/oxij/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/oxij/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oxij/nixpkgs/merges","archive_url":"https://api.github.com/repos/oxij/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oxij/nixpkgs/downloads","issues_url":"https://api.github.com/repos/oxij/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/oxij/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/oxij/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/oxij/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oxij/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/oxij/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/oxij/nixpkgs/deployments","created_at":"2012-07-06T22:22:29Z","updated_at":"2018-04-25T01:00:20Z","pushed_at":"2018-04-26T17:38:35Z","git_url":"git://github.com/oxij/nixpkgs.git","ssh_url":"git@github.com:oxij/nixpkgs.git","clone_url":"https://github.com/oxij/nixpkgs.git","svn_url":"https://github.com/oxij/nixpkgs","homepage":null,"size":709143,"stargazers_count":1,"watchers_count":1,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"893bf70a1cfe94e257d10ca093c06ddf30dde093","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-04-26T16:23:54Z","pushed_at":"2018-04-26T17:47:10Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":780777,"stargazers_count":2391,"watchers_count":2391,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2730,"mirror_url":null,"archived":false,"open_issues_count":3098,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2730,"open_issues":3098,"watchers":2391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/39464"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39464"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/39464/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39464/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9ee061ac01e96b594e46b35937d4eea25355bd05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ericson2314"}}