{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/228113081","pull_request_review_id":168304719,"id":228113081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODExMzA4MQ==","diff_hunk":"@@ -86,12 +87,17 @@ power_down:\n     // if b_enable_lpsram = 0 (bool disable_lpsram) - do not disable lpsram.\n     beqz b_enable_lpsram, _PD_DISABLE_HPSRAM\n \n-\n _PD_DISABLE_LPSRAM:\n-    m_cavs_lpsram_power_off temp_reg0, temp_reg1, temp_reg2\n+    movi temp_reg0, SHIM_LDOCTL_LP_SRAM_LDO_ON\n+    m_cavs_set_lpldo_state temp_reg0, temp_reg1, temp_reg2\n+\n+\t\tm_cavs_lpsram_power_off temp_reg0, temp_reg1, temp_reg2\n+\n+    movi temp_reg0, SHIM_LDOCTL_LP_SRAM_LDO_OFF\n+    m_cavs_set_lpldo_state temp_reg0, temp_reg1, temp_reg2\n \n-    // DISABLE_HPSRAM is aligned so there can be zeros between it\n-    // and last instr.\n+    // DISABLE_HPSRAM is aligned so there can be zeros between\n+\t\t//it and last instr.","path":"src/platform/apollolake/power_down.S","position":null,"original_position":26,"commit_id":"d5c38284a1e4f97267b3e57d437445f96c53087e","original_commit_id":"dfcf50c1f04730c15f9c3e68e03d9a53cd53d3fb","user":{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},"body":"Changes applied. ","created_at":"2018-10-25T10:09:19Z","updated_at":"2018-10-25T10:09:19Z","html_url":"https://github.com/thesofproject/sof/pull/500#discussion_r228113081","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/500","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/228113081"},"html":{"href":"https://github.com/thesofproject/sof/pull/500#discussion_r228113081"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/500"}},"in_reply_to_id":227696860},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/500","id":224325353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzI1MzUz","html_url":"https://github.com/thesofproject/sof/pull/500","diff_url":"https://github.com/thesofproject/sof/pull/500.diff","patch_url":"https://github.com/thesofproject/sof/pull/500.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/500","number":500,"state":"open","locked":false,"title":"Set SRAM LDO off on power down - additional power gating on D0->D3 path.","user":{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},"body":"Added assembly macros to control state of LDO for LP and HP SRAM.\r\nMacros are used during power down procedure to properly handle LDO state.\r\n\r\nSigned-off-by: Lech Betlej <lech.betlej@linux.intel.com>","created_at":"2018-10-19T15:25:14Z","updated_at":"2018-10-25T10:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75fac236db2162cebc9c92bb9f1684a77840d1be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/500/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/500/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/500/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/d5c38284a1e4f97267b3e57d437445f96c53087e","head":{"label":"lbetlej:ldo_off_on_power_down","ref":"ldo_off_on_power_down","sha":"d5c38284a1e4f97267b3e57d437445f96c53087e","user":{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},"repo":{"id":138878909,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4Nzg5MDk=","name":"sof","full_name":"lbetlej/sof","private":false,"owner":{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lbetlej/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/lbetlej/sof","forks_url":"https://api.github.com/repos/lbetlej/sof/forks","keys_url":"https://api.github.com/repos/lbetlej/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbetlej/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbetlej/sof/teams","hooks_url":"https://api.github.com/repos/lbetlej/sof/hooks","issue_events_url":"https://api.github.com/repos/lbetlej/sof/issues/events{/number}","events_url":"https://api.github.com/repos/lbetlej/sof/events","assignees_url":"https://api.github.com/repos/lbetlej/sof/assignees{/user}","branches_url":"https://api.github.com/repos/lbetlej/sof/branches{/branch}","tags_url":"https://api.github.com/repos/lbetlej/sof/tags","blobs_url":"https://api.github.com/repos/lbetlej/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbetlej/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbetlej/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbetlej/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbetlej/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/lbetlej/sof/languages","stargazers_url":"https://api.github.com/repos/lbetlej/sof/stargazers","contributors_url":"https://api.github.com/repos/lbetlej/sof/contributors","subscribers_url":"https://api.github.com/repos/lbetlej/sof/subscribers","subscription_url":"https://api.github.com/repos/lbetlej/sof/subscription","commits_url":"https://api.github.com/repos/lbetlej/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbetlej/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbetlej/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbetlej/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbetlej/sof/contents/{+path}","compare_url":"https://api.github.com/repos/lbetlej/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbetlej/sof/merges","archive_url":"https://api.github.com/repos/lbetlej/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbetlej/sof/downloads","issues_url":"https://api.github.com/repos/lbetlej/sof/issues{/number}","pulls_url":"https://api.github.com/repos/lbetlej/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/lbetlej/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/lbetlej/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbetlej/sof/labels{/name}","releases_url":"https://api.github.com/repos/lbetlej/sof/releases{/id}","deployments_url":"https://api.github.com/repos/lbetlej/sof/deployments","created_at":"2018-06-27T12:32:36Z","updated_at":"2018-10-24T08:20:23Z","pushed_at":"2018-10-24T13:06:29Z","git_url":"git://github.com/lbetlej/sof.git","ssh_url":"git@github.com:lbetlej/sof.git","clone_url":"https://github.com/lbetlej/sof.git","svn_url":"https://github.com/lbetlej/sof","homepage":null,"size":3910,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"b793f0c1a019ddd78b78d245707489c4cacb7121","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2018-10-25T09:34:26Z","pushed_at":"2018-10-25T09:34:23Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":3999,"stargazers_count":20,"watchers_count":20,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":36,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/500"},"html":{"href":"https://github.com/thesofproject/sof/pull/500"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/500"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/d5c38284a1e4f97267b3e57d437445f96c53087e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lbetlej"}}