{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/239351216","pull_request_review_id":182111199,"id":239351216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM1MTIxNg==","diff_hunk":"@@ -34,10 +34,11 @@ namespace NUnit.Framework.Constraints\n     /// </summary>\n     public abstract class CollectionItemsEqualConstraint : CollectionConstraint\n     {\n+\n         /// <summary>\n         /// The NUnitEqualityComparer in use for this constraint\n         /// </summary>\n-        private readonly NUnitEqualityComparer _comparer = new NUnitEqualityComparer();\n+        protected NUnitEqualityComparer Comparer { get; } = new NUnitEqualityComparer();","path":"src/NUnitFramework/framework/Constraints/CollectionItemsEqualConstraint.cs","position":9,"original_position":9,"commit_id":"3fc8d4c37b7ff2c1ec56105ea12586cb07bae82e","original_commit_id":"3fc8d4c37b7ff2c1ec56105ea12586cb07bae82e","user":{"login":"mikkelbu","id":1007631,"node_id":"MDQ6VXNlcjEwMDc2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1007631?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkelbu","html_url":"https://github.com/mikkelbu","followers_url":"https://api.github.com/users/mikkelbu/followers","following_url":"https://api.github.com/users/mikkelbu/following{/other_user}","gists_url":"https://api.github.com/users/mikkelbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkelbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkelbu/subscriptions","organizations_url":"https://api.github.com/users/mikkelbu/orgs","repos_url":"https://api.github.com/users/mikkelbu/repos","events_url":"https://api.github.com/users/mikkelbu/events{/privacy}","received_events_url":"https://api.github.com/users/mikkelbu/received_events","type":"User","site_admin":false},"body":"Mostly curious, why this change and the consequences below?","created_at":"2018-12-06T07:36:11Z","updated_at":"2018-12-06T07:37:10Z","html_url":"https://github.com/nunit/nunit/pull/3106#discussion_r239351216","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/3106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/239351216"},"html":{"href":"https://github.com/nunit/nunit/pull/3106#discussion_r239351216"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3106"}}},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/3106","id":236381534,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzgxNTM0","html_url":"https://github.com/nunit/nunit/pull/3106","diff_url":"https://github.com/nunit/nunit/pull/3106.diff","patch_url":"https://github.com/nunit/nunit/pull/3106.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/3106","number":3106,"state":"open","locked":false,"title":"Methods obsoleted in CollectionEquivalentConstraint","user":{"login":"OmicronPersei","id":5589035,"node_id":"MDQ6VXNlcjU1ODkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5589035?v=4","gravatar_id":"","url":"https://api.github.com/users/OmicronPersei","html_url":"https://github.com/OmicronPersei","followers_url":"https://api.github.com/users/OmicronPersei/followers","following_url":"https://api.github.com/users/OmicronPersei/following{/other_user}","gists_url":"https://api.github.com/users/OmicronPersei/gists{/gist_id}","starred_url":"https://api.github.com/users/OmicronPersei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmicronPersei/subscriptions","organizations_url":"https://api.github.com/users/OmicronPersei/orgs","repos_url":"https://api.github.com/users/OmicronPersei/repos","events_url":"https://api.github.com/users/OmicronPersei/events{/privacy}","received_events_url":"https://api.github.com/users/OmicronPersei/received_events","type":"User","site_admin":false},"body":"Closes issue #2870 .  Wasn't sure if we should unit test the methods since they're obsolete anyway.","created_at":"2018-12-06T01:44:29Z","updated_at":"2018-12-06T07:37:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98b52cd2c432531f22aad0a1b26d97af6e9cdabb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/3106/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/3106/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/3106/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/3fc8d4c37b7ff2c1ec56105ea12586cb07bae82e","head":{"label":"OmicronPersei:issue-2870","ref":"issue-2870","sha":"3fc8d4c37b7ff2c1ec56105ea12586cb07bae82e","user":{"login":"OmicronPersei","id":5589035,"node_id":"MDQ6VXNlcjU1ODkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5589035?v=4","gravatar_id":"","url":"https://api.github.com/users/OmicronPersei","html_url":"https://github.com/OmicronPersei","followers_url":"https://api.github.com/users/OmicronPersei/followers","following_url":"https://api.github.com/users/OmicronPersei/following{/other_user}","gists_url":"https://api.github.com/users/OmicronPersei/gists{/gist_id}","starred_url":"https://api.github.com/users/OmicronPersei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmicronPersei/subscriptions","organizations_url":"https://api.github.com/users/OmicronPersei/orgs","repos_url":"https://api.github.com/users/OmicronPersei/repos","events_url":"https://api.github.com/users/OmicronPersei/events{/privacy}","received_events_url":"https://api.github.com/users/OmicronPersei/received_events","type":"User","site_admin":false},"repo":{"id":94648446,"node_id":"MDEwOlJlcG9zaXRvcnk5NDY0ODQ0Ng==","name":"nunit","full_name":"OmicronPersei/nunit","private":false,"owner":{"login":"OmicronPersei","id":5589035,"node_id":"MDQ6VXNlcjU1ODkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5589035?v=4","gravatar_id":"","url":"https://api.github.com/users/OmicronPersei","html_url":"https://github.com/OmicronPersei","followers_url":"https://api.github.com/users/OmicronPersei/followers","following_url":"https://api.github.com/users/OmicronPersei/following{/other_user}","gists_url":"https://api.github.com/users/OmicronPersei/gists{/gist_id}","starred_url":"https://api.github.com/users/OmicronPersei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmicronPersei/subscriptions","organizations_url":"https://api.github.com/users/OmicronPersei/orgs","repos_url":"https://api.github.com/users/OmicronPersei/repos","events_url":"https://api.github.com/users/OmicronPersei/events{/privacy}","received_events_url":"https://api.github.com/users/OmicronPersei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/OmicronPersei/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/OmicronPersei/nunit","forks_url":"https://api.github.com/repos/OmicronPersei/nunit/forks","keys_url":"https://api.github.com/repos/OmicronPersei/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmicronPersei/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmicronPersei/nunit/teams","hooks_url":"https://api.github.com/repos/OmicronPersei/nunit/hooks","issue_events_url":"https://api.github.com/repos/OmicronPersei/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/OmicronPersei/nunit/events","assignees_url":"https://api.github.com/repos/OmicronPersei/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/OmicronPersei/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/OmicronPersei/nunit/tags","blobs_url":"https://api.github.com/repos/OmicronPersei/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmicronPersei/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmicronPersei/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmicronPersei/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmicronPersei/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/OmicronPersei/nunit/languages","stargazers_url":"https://api.github.com/repos/OmicronPersei/nunit/stargazers","contributors_url":"https://api.github.com/repos/OmicronPersei/nunit/contributors","subscribers_url":"https://api.github.com/repos/OmicronPersei/nunit/subscribers","subscription_url":"https://api.github.com/repos/OmicronPersei/nunit/subscription","commits_url":"https://api.github.com/repos/OmicronPersei/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmicronPersei/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmicronPersei/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmicronPersei/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmicronPersei/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/OmicronPersei/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmicronPersei/nunit/merges","archive_url":"https://api.github.com/repos/OmicronPersei/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmicronPersei/nunit/downloads","issues_url":"https://api.github.com/repos/OmicronPersei/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/OmicronPersei/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/OmicronPersei/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/OmicronPersei/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmicronPersei/nunit/labels{/name}","releases_url":"https://api.github.com/repos/OmicronPersei/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/OmicronPersei/nunit/deployments","created_at":"2017-06-17T20:48:58Z","updated_at":"2018-07-17T01:32:59Z","pushed_at":"2018-12-06T01:22:49Z","git_url":"git://github.com/OmicronPersei/nunit.git","ssh_url":"git@github.com:OmicronPersei/nunit.git","clone_url":"https://github.com/OmicronPersei/nunit.git","svn_url":"https://github.com/OmicronPersei/nunit","homepage":"http://www.nunit.org/","size":35640,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"fe1c9fbd0dc33503c76d28428536342330cd6fbb","user":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MjE4Mw==","name":"nunit","full_name":"nunit/nunit","private":false,"owner":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2018-12-05T20:38:36Z","pushed_at":"2018-12-06T01:44:30Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":35070,"stargazers_count":1491,"watchers_count":1491,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":527,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":527,"open_issues":339,"watchers":1491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3106"},"html":{"href":"https://github.com/nunit/nunit/pull/3106"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/3106"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/3106/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3106/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/3106/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/3fc8d4c37b7ff2c1ec56105ea12586cb07bae82e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikkelbu"}}