{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/7268","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/7268/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/7268/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/7268/events","html_url":"https://github.com/minetest/minetest/issues/7268","id":316539760,"number":7268,"title":"New 1-texture cube drawtype to increase performance","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"labels":[{"id":73369003,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"0e8a16","default":false},{"id":256918838,"url":"https://api.github.com/repos/minetest/minetest/labels/Performance","name":"Performance","color":"ffff00","default":false},{"id":285897422,"url":"https://api.github.com/repos/minetest/minetest/labels/Request%20/%20Suggestion","name":"Request / Suggestion","color":"8db4e0","default":false}],"state":"open","locked":false,"assignee":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"assignees":[{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-04-22T01:21:16Z","updated_at":"2018-04-22T22:26:51Z","closed_at":null,"author_association":"MEMBER","body":"See #6929 and #7233 for discussion.\r\nRelated to #7222 \r\n\r\nIt seems likely that due to poor tilespec performance the number of textures a drawtype uses effects meshgen performance.\r\nMost nodes in a world are stone, sand or dirt which are all using a 6-texture drawtype when they only need 1 texture. I suggest a new cube drawtype that only accepts 1 texture to hopefully increase meshgen performance.\r\nIt would need to be profiled to find out, even if it doesn't help it will be a useful test. I might code this to test for any improvement.\r\n\r\nRelated to this, it may be a good idea to keep the 1-texture allfaces and glasslike drawtypes even if 6-texture versions are added by #7233 especially due to the very heavy use of alface-optional in forests.\r\n@numberZero "},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/383417320","html_url":"https://github.com/minetest/minetest/issues/7268#issuecomment-383417320","issue_url":"https://api.github.com/repos/minetest/minetest/issues/7268","id":383417320,"user":{"login":"numberZero","id":7352626,"avatar_url":"https://avatars0.githubusercontent.com/u/7352626?v=4","gravatar_id":"","url":"https://api.github.com/users/numberZero","html_url":"https://github.com/numberZero","followers_url":"https://api.github.com/users/numberZero/followers","following_url":"https://api.github.com/users/numberZero/following{/other_user}","gists_url":"https://api.github.com/users/numberZero/gists{/gist_id}","starred_url":"https://api.github.com/users/numberZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numberZero/subscriptions","organizations_url":"https://api.github.com/users/numberZero/orgs","repos_url":"https://api.github.com/users/numberZero/repos","events_url":"https://api.github.com/users/numberZero/events{/privacy}","received_events_url":"https://api.github.com/users/numberZero/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T22:26:51Z","updated_at":"2018-04-22T22:26:51Z","author_association":"CONTRIBUTOR","body":"For solid (and liquid) nodes, that doesn’t matter AFAIK, due to the way FastFaces work.\r\nFor any drawtype, that may be done as an implementation detail—runtime conversion, similar to the way `_optional` drawtypes work. That’s simple to implement, but such things make the code less readable, so:\r\n\r\n1. testing is necessary to make sure performance difference is significant,\r\n2. there might be better solutions that need to be considered (maybe https://github.com/minetest/minetest/issues/6929#issuecomment-383417303)."}}
{"actor":{"display_login":"numberZero"}}