{"action":"created","comment":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/comments/166844370","pull_request_review_id":94970113,"id":166844370,"diff_hunk":"@@ -42,15 +42,40 @@\n     <script>\n       var video, hls, logString ='';\n \n-      function startStream(streamUrl, callback) {\n+      // Object.assign polyfill\n+      function objectAssign(target, firstSource) {\n+        if (target === undefined || target === null) {\n+          throw new TypeError('Cannot convert first argument to object');\n+        }\n+\n+        var to = Object(target);\n+        for (var i = 1; i < arguments.length; i++) {\n+          var nextSource = arguments[i];\n+          if (nextSource === undefined || nextSource === null) {\n+            continue;\n+          }\n+\n+          var keysArray = Object.keys(Object(nextSource));\n+          for (var nextIndex = 0, len = keysArray.length; nextIndex < len; nextIndex++) {\n+            var nextKey = keysArray[nextIndex];\n+            var desc = Object.getOwnPropertyDescriptor(nextSource, nextKey);\n+            if (desc !== undefined && desc.enumerable) {\n+              to[nextKey] = nextSource[nextKey];\n+            }\n+          }\n+        }\n+        return to;\n+      }\n+\n+      function startStream(streamUrl, config, callback) {\n         if (Hls.isSupported()) {\n           if (hls) {\n             callback({ code : 'hlsjsAlreadyInitialised', logs : logString});\n            return;\n           }\n           video = document.getElementById('video');\n           try {\n-            hls = new Hls({debug: true});\n+            hls = new Hls(objectAssign({}, config, {debug: true}));","path":"tests/functional/auto/hlsjs.html","position":39,"original_position":39,"commit_id":"a7d60da22b9d176a9c4d17a72654d38d07356a13","original_commit_id":"a7d60da22b9d176a9c4d17a72654d38d07356a13","user":{"login":"azu","id":19714,"avatar_url":"https://avatars1.githubusercontent.com/u/19714?v=4","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"body":"This line fix angelOneShakaWidevine function test. Maybe...","created_at":"2018-02-08T06:48:36Z","updated_at":"2018-02-08T06:48:36Z","html_url":"https://github.com/video-dev/hls.js/pull/1550#discussion_r166844370","pull_request_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1550","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/comments/166844370"},"html":{"href":"https://github.com/video-dev/hls.js/pull/1550#discussion_r166844370"},"pull_request":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1550"}}},"pull_request":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/1550","id":167889919,"html_url":"https://github.com/video-dev/hls.js/pull/1550","diff_url":"https://github.com/video-dev/hls.js/pull/1550.diff","patch_url":"https://github.com/video-dev/hls.js/pull/1550.patch","issue_url":"https://api.github.com/repos/video-dev/hls.js/issues/1550","number":1550,"state":"open","locked":false,"title":"fix angelOneShakaWidevine function test","user":{"login":"azu","id":19714,"avatar_url":"https://avatars1.githubusercontent.com/u/19714?v=4","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"body":"### Description of the Changes\r\n\r\nPass `config` to HlsJs correctly if the `config` object is defined in `test-streams.js`\r\n\r\nPreviously, the test does not pass `config` object to hlsJs constructor.\r\nAs as result, `angelOneShakaWidevine` stream could not played in the test.\r\nBecause, this stream require `widevineLicenseUrl` and `emeEnabled` config.\r\n\r\nhttps://github.com/video-dev/hls.js/blob/6d227c187a2c0ab9fbe90d6d7aadfd49c3176495/tests/test-streams.js#L114-L120\r\n\r\n### CheckLists\r\n\r\n- [ ] changes have been done against master branch, and PR does not conflict\r\n- [ ] no commits have been done in dist folder (we will take care of updating it)\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] API or design changes are documented in API.md\r\n","created_at":"2018-02-08T06:44:53Z","updated_at":"2018-02-08T06:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23211a3fe3c75eb7c91bb2210a493bbe34922d6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1550/commits","review_comments_url":"https://api.github.com/repos/video-dev/hls.js/pulls/1550/comments","review_comment_url":"https://api.github.com/repos/video-dev/hls.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/video-dev/hls.js/issues/1550/comments","statuses_url":"https://api.github.com/repos/video-dev/hls.js/statuses/a7d60da22b9d176a9c4d17a72654d38d07356a13","head":{"label":"azu:fix-function-test-widevine-drm","ref":"fix-function-test-widevine-drm","sha":"a7d60da22b9d176a9c4d17a72654d38d07356a13","user":{"login":"azu","id":19714,"avatar_url":"https://avatars1.githubusercontent.com/u/19714?v=4","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"repo":{"id":82520779,"name":"hls.js","full_name":"azu/hls.js","owner":{"login":"azu","id":19714,"avatar_url":"https://avatars1.githubusercontent.com/u/19714?v=4","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azu/hls.js","description":"MSE-based HLS client - http://dailymotion.github.io/hls.js/demo","fork":true,"url":"https://api.github.com/repos/azu/hls.js","forks_url":"https://api.github.com/repos/azu/hls.js/forks","keys_url":"https://api.github.com/repos/azu/hls.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azu/hls.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azu/hls.js/teams","hooks_url":"https://api.github.com/repos/azu/hls.js/hooks","issue_events_url":"https://api.github.com/repos/azu/hls.js/issues/events{/number}","events_url":"https://api.github.com/repos/azu/hls.js/events","assignees_url":"https://api.github.com/repos/azu/hls.js/assignees{/user}","branches_url":"https://api.github.com/repos/azu/hls.js/branches{/branch}","tags_url":"https://api.github.com/repos/azu/hls.js/tags","blobs_url":"https://api.github.com/repos/azu/hls.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azu/hls.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azu/hls.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/azu/hls.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azu/hls.js/statuses/{sha}","languages_url":"https://api.github.com/repos/azu/hls.js/languages","stargazers_url":"https://api.github.com/repos/azu/hls.js/stargazers","contributors_url":"https://api.github.com/repos/azu/hls.js/contributors","subscribers_url":"https://api.github.com/repos/azu/hls.js/subscribers","subscription_url":"https://api.github.com/repos/azu/hls.js/subscription","commits_url":"https://api.github.com/repos/azu/hls.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/azu/hls.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/azu/hls.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/azu/hls.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/azu/hls.js/contents/{+path}","compare_url":"https://api.github.com/repos/azu/hls.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azu/hls.js/merges","archive_url":"https://api.github.com/repos/azu/hls.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azu/hls.js/downloads","issues_url":"https://api.github.com/repos/azu/hls.js/issues{/number}","pulls_url":"https://api.github.com/repos/azu/hls.js/pulls{/number}","milestones_url":"https://api.github.com/repos/azu/hls.js/milestones{/number}","notifications_url":"https://api.github.com/repos/azu/hls.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azu/hls.js/labels{/name}","releases_url":"https://api.github.com/repos/azu/hls.js/releases{/id}","deployments_url":"https://api.github.com/repos/azu/hls.js/deployments","created_at":"2017-02-20T05:37:49Z","updated_at":"2017-02-20T05:37:52Z","pushed_at":"2018-02-08T06:27:29Z","git_url":"git://github.com/azu/hls.js.git","ssh_url":"git@github.com:azu/hls.js.git","clone_url":"https://github.com/azu/hls.js.git","svn_url":"https://github.com/azu/hls.js","homepage":"","size":30748,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"video-dev:master","ref":"master","sha":"6d227c187a2c0ab9fbe90d6d7aadfd49c3176495","user":{"login":"video-dev","id":25984302,"avatar_url":"https://avatars0.githubusercontent.com/u/25984302?v=4","gravatar_id":"","url":"https://api.github.com/users/video-dev","html_url":"https://github.com/video-dev","followers_url":"https://api.github.com/users/video-dev/followers","following_url":"https://api.github.com/users/video-dev/following{/other_user}","gists_url":"https://api.github.com/users/video-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/video-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/video-dev/subscriptions","organizations_url":"https://api.github.com/users/video-dev/orgs","repos_url":"https://api.github.com/users/video-dev/repos","events_url":"https://api.github.com/users/video-dev/events{/privacy}","received_events_url":"https://api.github.com/users/video-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":30064588,"name":"hls.js","full_name":"video-dev/hls.js","owner":{"login":"video-dev","id":25984302,"avatar_url":"https://avatars0.githubusercontent.com/u/25984302?v=4","gravatar_id":"","url":"https://api.github.com/users/video-dev","html_url":"https://github.com/video-dev","followers_url":"https://api.github.com/users/video-dev/followers","following_url":"https://api.github.com/users/video-dev/following{/other_user}","gists_url":"https://api.github.com/users/video-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/video-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/video-dev/subscriptions","organizations_url":"https://api.github.com/users/video-dev/orgs","repos_url":"https://api.github.com/users/video-dev/repos","events_url":"https://api.github.com/users/video-dev/events{/privacy}","received_events_url":"https://api.github.com/users/video-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/video-dev/hls.js","description":"JavaScript HLS client using Media Source Extension","fork":false,"url":"https://api.github.com/repos/video-dev/hls.js","forks_url":"https://api.github.com/repos/video-dev/hls.js/forks","keys_url":"https://api.github.com/repos/video-dev/hls.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/video-dev/hls.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/video-dev/hls.js/teams","hooks_url":"https://api.github.com/repos/video-dev/hls.js/hooks","issue_events_url":"https://api.github.com/repos/video-dev/hls.js/issues/events{/number}","events_url":"https://api.github.com/repos/video-dev/hls.js/events","assignees_url":"https://api.github.com/repos/video-dev/hls.js/assignees{/user}","branches_url":"https://api.github.com/repos/video-dev/hls.js/branches{/branch}","tags_url":"https://api.github.com/repos/video-dev/hls.js/tags","blobs_url":"https://api.github.com/repos/video-dev/hls.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/video-dev/hls.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/video-dev/hls.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/video-dev/hls.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/video-dev/hls.js/statuses/{sha}","languages_url":"https://api.github.com/repos/video-dev/hls.js/languages","stargazers_url":"https://api.github.com/repos/video-dev/hls.js/stargazers","contributors_url":"https://api.github.com/repos/video-dev/hls.js/contributors","subscribers_url":"https://api.github.com/repos/video-dev/hls.js/subscribers","subscription_url":"https://api.github.com/repos/video-dev/hls.js/subscription","commits_url":"https://api.github.com/repos/video-dev/hls.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/video-dev/hls.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/video-dev/hls.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/video-dev/hls.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/video-dev/hls.js/contents/{+path}","compare_url":"https://api.github.com/repos/video-dev/hls.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/video-dev/hls.js/merges","archive_url":"https://api.github.com/repos/video-dev/hls.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/video-dev/hls.js/downloads","issues_url":"https://api.github.com/repos/video-dev/hls.js/issues{/number}","pulls_url":"https://api.github.com/repos/video-dev/hls.js/pulls{/number}","milestones_url":"https://api.github.com/repos/video-dev/hls.js/milestones{/number}","notifications_url":"https://api.github.com/repos/video-dev/hls.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/video-dev/hls.js/labels{/name}","releases_url":"https://api.github.com/repos/video-dev/hls.js/releases{/id}","deployments_url":"https://api.github.com/repos/video-dev/hls.js/deployments","created_at":"2015-01-30T09:06:27Z","updated_at":"2018-02-08T06:17:02Z","pushed_at":"2018-02-08T06:44:54Z","git_url":"git://github.com/video-dev/hls.js.git","ssh_url":"git@github.com:video-dev/hls.js.git","clone_url":"https://github.com/video-dev/hls.js.git","svn_url":"https://github.com/video-dev/hls.js","homepage":"http://video-dev.github.io/hls.js/demo","size":37554,"stargazers_count":3540,"watchers_count":3540,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":836,"mirror_url":null,"archived":false,"open_issues_count":394,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":836,"open_issues":394,"watchers":3540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1550"},"html":{"href":"https://github.com/video-dev/hls.js/pull/1550"},"issue":{"href":"https://api.github.com/repos/video-dev/hls.js/issues/1550"},"comments":{"href":"https://api.github.com/repos/video-dev/hls.js/issues/1550/comments"},"review_comments":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1550/comments"},"review_comment":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/video-dev/hls.js/pulls/1550/commits"},"statuses":{"href":"https://api.github.com/repos/video-dev/hls.js/statuses/a7d60da22b9d176a9c4d17a72654d38d07356a13"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"azu"}}