{"action":"created","comment":{"url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments/187007657","pull_request_review_id":118698482,"id":187007657,"diff_hunk":"@@ -126,3 +126,202 @@ const onSort = ({sortBy, descending, tableData}) => {};\n     onSort={onSort}\n />;\n ```\n+Bruk av render funksjoner for columns: cellRender, columnHeaderRender, columnFooterRender.\n+\n+For hele tabellen: rowRender, headerRender, footerRender.\n+\n+```js\n+const classNames = require('classnames');\n+const HakeIkon = require('@sb1/ffe-icons-react/lib').HakeIkon;\n+const KryssIkon = require('@sb1/ffe-icons-react/lib').KryssIkon;\n+\n+\n+const generateCheckbox = (value) => {\n+    return <div style={{width: '100%', textAlign: 'center'}}>{value ?\n+        <HakeIkon className={classNames({'icon-green': true, 'ffe-table__expand-icon': true})}/> :\n+        <KryssIkon className={classNames({'icon-red': true, 'ffe-table__expand-icon': true})}/>}</div>;\n+};","path":"packages/ffe-tables-react/src/Table.md","position":null,"original_position":18,"commit_id":"66f4886b7794da2bda3ec817d1d1be616cb00270","original_commit_id":"06ca08b67805b861d4f1f0cdf0fb87825adf289c","user":{"login":"ksawerysb1","id":37411268,"avatar_url":"https://avatars1.githubusercontent.com/u/37411268?v=4","gravatar_id":"","url":"https://api.github.com/users/ksawerysb1","html_url":"https://github.com/ksawerysb1","followers_url":"https://api.github.com/users/ksawerysb1/followers","following_url":"https://api.github.com/users/ksawerysb1/following{/other_user}","gists_url":"https://api.github.com/users/ksawerysb1/gists{/gist_id}","starred_url":"https://api.github.com/users/ksawerysb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksawerysb1/subscriptions","organizations_url":"https://api.github.com/users/ksawerysb1/orgs","repos_url":"https://api.github.com/users/ksawerysb1/repos","events_url":"https://api.github.com/users/ksawerysb1/events{/privacy}","received_events_url":"https://api.github.com/users/ksawerysb1/received_events","type":"User","site_admin":false},"body":"@selbekk prettiefied and cleaned up","created_at":"2018-05-09T11:17:58Z","updated_at":"2018-05-09T11:17:58Z","html_url":"https://github.com/SpareBank1/designsystem/pull/228#discussion_r187007657","pull_request_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments/187007657"},"html":{"href":"https://github.com/SpareBank1/designsystem/pull/228#discussion_r187007657"},"pull_request":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228"}},"in_reply_to_id":186940291},"pull_request":{"url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228","id":186602898,"html_url":"https://github.com/SpareBank1/designsystem/pull/228","diff_url":"https://github.com/SpareBank1/designsystem/pull/228.diff","patch_url":"https://github.com/SpareBank1/designsystem/pull/228.patch","issue_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/228","number":228,"state":"open","locked":false,"title":"feat(ffe-tables-react): added render override functions","user":{"login":"ksawerysb1","id":37411268,"avatar_url":"https://avatars1.githubusercontent.com/u/37411268?v=4","gravatar_id":"","url":"https://api.github.com/users/ksawerysb1","html_url":"https://github.com/ksawerysb1","followers_url":"https://api.github.com/users/ksawerysb1/followers","following_url":"https://api.github.com/users/ksawerysb1/following{/other_user}","gists_url":"https://api.github.com/users/ksawerysb1/gists{/gist_id}","starred_url":"https://api.github.com/users/ksawerysb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksawerysb1/subscriptions","organizations_url":"https://api.github.com/users/ksawerysb1/orgs","repos_url":"https://api.github.com/users/ksawerysb1/repos","events_url":"https://api.github.com/users/ksawerysb1/events{/privacy}","received_events_url":"https://api.github.com/users/ksawerysb1/received_events","type":"User","site_admin":false},"body":"added render override functions, should not be a breaking change\r\ncolumns: cellRender, columnHeaderRender, columnFooterRender\r\ntable: rowRender, headerRender, footerRender\r\n\r\n<!-- \r\nThanks for opening a pull request! 🎉\r\n\r\nIf your changes include some kind of UI element, please attach a screenshot of \r\nhow it looks.\r\n\r\nBefore submitting a pull request, please have a look through the CONTRIBUTING.md\r\ndocument. TL;DR:\r\n\r\n- Follow the conventional commit standard\r\n- Write full, explanatory commit messages\r\n- Follow our code standards\r\n- Write tests where applicable\r\n- Be courteous and respect our code of conduct\r\n-->\r\n","created_at":"2018-05-08T11:21:05Z","updated_at":"2018-05-09T11:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fbdc1bc659e71db620e80758fb95ee8c1f805ea","assignee":null,"assignees":[],"requested_reviewers":[{"login":"henrikhermansen","id":435037,"avatar_url":"https://avatars2.githubusercontent.com/u/435037?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikhermansen","html_url":"https://github.com/henrikhermansen","followers_url":"https://api.github.com/users/henrikhermansen/followers","following_url":"https://api.github.com/users/henrikhermansen/following{/other_user}","gists_url":"https://api.github.com/users/henrikhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikhermansen/subscriptions","organizations_url":"https://api.github.com/users/henrikhermansen/orgs","repos_url":"https://api.github.com/users/henrikhermansen/repos","events_url":"https://api.github.com/users/henrikhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/henrikhermansen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228/commits","review_comments_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228/comments","review_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/228/comments","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/66f4886b7794da2bda3ec817d1d1be616cb00270","head":{"label":"SpareBank1:132-ffe-tables-react-render-override-api","ref":"132-ffe-tables-react-render-override-api","sha":"66f4886b7794da2bda3ec817d1d1be616cb00270","user":{"login":"SpareBank1","id":12732343,"avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"repo":{"id":122945940,"name":"designsystem","full_name":"SpareBank1/designsystem","owner":{"login":"SpareBank1","id":12732343,"avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpareBank1/designsystem","description":"SpareBank 1's design system and component library.","fork":false,"url":"https://api.github.com/repos/SpareBank1/designsystem","forks_url":"https://api.github.com/repos/SpareBank1/designsystem/forks","keys_url":"https://api.github.com/repos/SpareBank1/designsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpareBank1/designsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpareBank1/designsystem/teams","hooks_url":"https://api.github.com/repos/SpareBank1/designsystem/hooks","issue_events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/events{/number}","events_url":"https://api.github.com/repos/SpareBank1/designsystem/events","assignees_url":"https://api.github.com/repos/SpareBank1/designsystem/assignees{/user}","branches_url":"https://api.github.com/repos/SpareBank1/designsystem/branches{/branch}","tags_url":"https://api.github.com/repos/SpareBank1/designsystem/tags","blobs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpareBank1/designsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpareBank1/designsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SpareBank1/designsystem/languages","stargazers_url":"https://api.github.com/repos/SpareBank1/designsystem/stargazers","contributors_url":"https://api.github.com/repos/SpareBank1/designsystem/contributors","subscribers_url":"https://api.github.com/repos/SpareBank1/designsystem/subscribers","subscription_url":"https://api.github.com/repos/SpareBank1/designsystem/subscription","commits_url":"https://api.github.com/repos/SpareBank1/designsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpareBank1/designsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpareBank1/designsystem/contents/{+path}","compare_url":"https://api.github.com/repos/SpareBank1/designsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpareBank1/designsystem/merges","archive_url":"https://api.github.com/repos/SpareBank1/designsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpareBank1/designsystem/downloads","issues_url":"https://api.github.com/repos/SpareBank1/designsystem/issues{/number}","pulls_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SpareBank1/designsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SpareBank1/designsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/labels{/name}","releases_url":"https://api.github.com/repos/SpareBank1/designsystem/releases{/id}","deployments_url":"https://api.github.com/repos/SpareBank1/designsystem/deployments","created_at":"2018-02-26T09:29:13Z","updated_at":"2018-05-09T11:13:46Z","pushed_at":"2018-05-09T11:15:52Z","git_url":"git://github.com/SpareBank1/designsystem.git","ssh_url":"git@github.com:SpareBank1/designsystem.git","clone_url":"https://github.com/SpareBank1/designsystem.git","svn_url":"https://github.com/SpareBank1/designsystem","homepage":"https://design.sparebank1.no/","size":87335,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":28,"watchers":32,"default_branch":"develop"}},"base":{"label":"SpareBank1:develop","ref":"develop","sha":"d7b523e822b6aac4d2b83594b3127b313a2a49d7","user":{"login":"SpareBank1","id":12732343,"avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"repo":{"id":122945940,"name":"designsystem","full_name":"SpareBank1/designsystem","owner":{"login":"SpareBank1","id":12732343,"avatar_url":"https://avatars0.githubusercontent.com/u/12732343?v=4","gravatar_id":"","url":"https://api.github.com/users/SpareBank1","html_url":"https://github.com/SpareBank1","followers_url":"https://api.github.com/users/SpareBank1/followers","following_url":"https://api.github.com/users/SpareBank1/following{/other_user}","gists_url":"https://api.github.com/users/SpareBank1/gists{/gist_id}","starred_url":"https://api.github.com/users/SpareBank1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpareBank1/subscriptions","organizations_url":"https://api.github.com/users/SpareBank1/orgs","repos_url":"https://api.github.com/users/SpareBank1/repos","events_url":"https://api.github.com/users/SpareBank1/events{/privacy}","received_events_url":"https://api.github.com/users/SpareBank1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpareBank1/designsystem","description":"SpareBank 1's design system and component library.","fork":false,"url":"https://api.github.com/repos/SpareBank1/designsystem","forks_url":"https://api.github.com/repos/SpareBank1/designsystem/forks","keys_url":"https://api.github.com/repos/SpareBank1/designsystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpareBank1/designsystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpareBank1/designsystem/teams","hooks_url":"https://api.github.com/repos/SpareBank1/designsystem/hooks","issue_events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/events{/number}","events_url":"https://api.github.com/repos/SpareBank1/designsystem/events","assignees_url":"https://api.github.com/repos/SpareBank1/designsystem/assignees{/user}","branches_url":"https://api.github.com/repos/SpareBank1/designsystem/branches{/branch}","tags_url":"https://api.github.com/repos/SpareBank1/designsystem/tags","blobs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpareBank1/designsystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpareBank1/designsystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpareBank1/designsystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpareBank1/designsystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SpareBank1/designsystem/languages","stargazers_url":"https://api.github.com/repos/SpareBank1/designsystem/stargazers","contributors_url":"https://api.github.com/repos/SpareBank1/designsystem/contributors","subscribers_url":"https://api.github.com/repos/SpareBank1/designsystem/subscribers","subscription_url":"https://api.github.com/repos/SpareBank1/designsystem/subscription","commits_url":"https://api.github.com/repos/SpareBank1/designsystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpareBank1/designsystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpareBank1/designsystem/contents/{+path}","compare_url":"https://api.github.com/repos/SpareBank1/designsystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpareBank1/designsystem/merges","archive_url":"https://api.github.com/repos/SpareBank1/designsystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpareBank1/designsystem/downloads","issues_url":"https://api.github.com/repos/SpareBank1/designsystem/issues{/number}","pulls_url":"https://api.github.com/repos/SpareBank1/designsystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SpareBank1/designsystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SpareBank1/designsystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/labels{/name}","releases_url":"https://api.github.com/repos/SpareBank1/designsystem/releases{/id}","deployments_url":"https://api.github.com/repos/SpareBank1/designsystem/deployments","created_at":"2018-02-26T09:29:13Z","updated_at":"2018-05-09T11:13:46Z","pushed_at":"2018-05-09T11:15:52Z","git_url":"git://github.com/SpareBank1/designsystem.git","ssh_url":"git@github.com:SpareBank1/designsystem.git","clone_url":"https://github.com/SpareBank1/designsystem.git","svn_url":"https://github.com/SpareBank1/designsystem","homepage":"https://design.sparebank1.no/","size":87335,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":28,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228"},"html":{"href":"https://github.com/SpareBank1/designsystem/pull/228"},"issue":{"href":"https://api.github.com/repos/SpareBank1/designsystem/issues/228"},"comments":{"href":"https://api.github.com/repos/SpareBank1/designsystem/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpareBank1/designsystem/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/SpareBank1/designsystem/statuses/66f4886b7794da2bda3ec817d1d1be616cb00270"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ksawerysb1"}}