{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/12724","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/12724/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/12724/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/12724/events","html_url":"https://github.com/ampproject/amphtml/issues/12724","id":287131547,"number":12724,"title":"amp-image-lightbox thumbnail with extra zoom image","user":{"login":"mazuk6","id":35265677,"avatar_url":"https://avatars3.githubusercontent.com/u/35265677?v=4","gravatar_id":"","url":"https://api.github.com/users/mazuk6","html_url":"https://github.com/mazuk6","followers_url":"https://api.github.com/users/mazuk6/followers","following_url":"https://api.github.com/users/mazuk6/following{/other_user}","gists_url":"https://api.github.com/users/mazuk6/gists{/gist_id}","starred_url":"https://api.github.com/users/mazuk6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazuk6/subscriptions","organizations_url":"https://api.github.com/users/mazuk6/orgs","repos_url":"https://api.github.com/users/mazuk6/repos","events_url":"https://api.github.com/users/mazuk6/events{/privacy}","received_events_url":"https://api.github.com/users/mazuk6/received_events","type":"User","site_admin":false},"labels":[{"id":530198214,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Presentation","name":"Category: Presentation","color":"1d76db","default":false},{"id":284529946,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Feature%20Request","name":"Type: Feature Request","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"assignees":[{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/23","html_url":"https://github.com/ampproject/amphtml/milestone/23","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/23/labels","id":2293339,"number":23,"title":"New FRs","description":"These are new feature requests opened, that are still at discussion level or need to be verified on whether they can be prioritized or not. ","creator":{"login":"adelinamart","id":24213793,"avatar_url":"https://avatars2.githubusercontent.com/u/24213793?v=4","gravatar_id":"","url":"https://api.github.com/users/adelinamart","html_url":"https://github.com/adelinamart","followers_url":"https://api.github.com/users/adelinamart/followers","following_url":"https://api.github.com/users/adelinamart/following{/other_user}","gists_url":"https://api.github.com/users/adelinamart/gists{/gist_id}","starred_url":"https://api.github.com/users/adelinamart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelinamart/subscriptions","organizations_url":"https://api.github.com/users/adelinamart/orgs","repos_url":"https://api.github.com/users/adelinamart/repos","events_url":"https://api.github.com/users/adelinamart/events{/privacy}","received_events_url":"https://api.github.com/users/adelinamart/received_events","type":"User","site_admin":false},"open_issues":293,"closed_issues":166,"state":"open","created_at":"2017-02-01T19:32:04Z","updated_at":"2018-02-22T19:53:47Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-01-09T15:38:44Z","updated_at":"2018-02-22T19:53:47Z","closed_at":"2018-02-22T19:53:46Z","author_association":"NONE","body":"My understanding of a lightbox component is: you have a thumbnail Image and get a bigger image opened in a bigger view once you click the thumbnail. I am missing this logic completely.  When making an AMP-Only Website I have to load all the big images as thumbnails in the desktop view in order to not getting blurry zoom images.\r\n\r\nIt would be nice to have a possibility to define an extra zoom image.\r\n\r\nThank you,\r\nMarkus"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/367800990","html_url":"https://github.com/ampproject/amphtml/issues/12724#issuecomment-367800990","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/12724","id":367800990,"user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T19:53:46Z","updated_at":"2018-02-22T19:53:46Z","author_association":"COLLABORATOR","body":"@mazuk6 I think what will actually solve this issue is solving https://github.com/ampproject/amphtml/issues/11575. For both the current `<amp-image-lightbox>` and as designed for `<amp-lightbox-gallery>`, we will use `srcset` to upgrade the image to its desired resolution in lightbox mode depending on the zoom scale. Basically what you should do is just provide a `srcset` that includes a low-res image for your default thumbnail, a medium-res image for the lightbox mode, and a high-res image for lightbox zoom mode. Note that this isn't an appropriate use for cropping / different dimensions, only for different resolutions of the same image. The problem isn't that lightbox doesn't upgrade, it's rather that we don't have the option to provide a lower resolution thumbnail default. This problem can be solved with `sizes` and `srcset` once we resolve https://github.com/ampproject/amphtml/issues/11575. \r\n\r\nI believe that `<amp-image-lightbox>` already handles upgrading resolution. This parity feature is tracked for `<amp-lightbox-gallery>` in https://github.com/ampproject/amphtml/issues/12929. "}}
{"actor":{"display_login":"cathyxz"}}