{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/sls-packaging/pulls/comments/203794109","pull_request_review_id":138755821,"id":203794109,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzc5NDEwOQ==","diff_hunk":"@@ -63,15 +63,14 @@ class ServiceDistributionPluginTests extends GradleTestSpec {\n \n         then:\n         // try all of the service commands\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'start') ==~ /(?m)Running 'service-name'\\.\\.\\.\\s+Started \\(\\d+\\)\\n/\n-        file('dist/service-name-0.0.1/var/log/service-name-startup.log', projectDir).text.contains('Test started\\n')\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'start') ==~ /(?m)Process is already running\\n/\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'status') ==~ /(?m)Checking 'service-name'\\.\\.\\.\\s+Running \\(\\d+\\)\\n/\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'restart') ==~\n-                /(?m)Stopping 'service-name'\\.\\.\\.\\s+Stopped \\(\\d+\\)\\nRunning 'service-name'\\.\\.\\.\\s+Started \\(\\d+\\)\\n/\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'stop') ==~ /(?m)Stopping 'service-name'\\.\\.\\.\\s+Stopped \\(\\d+\\)\\n/\n-        exec('dist/service-name-0.0.1/service/bin/init.sh', 'check') ==~ /(?m)Checking health of 'service-name'\\.\\.\\.\\s+Healthy.*\\n/\n-        exec('dist/service-name-0.0.1/service/monitoring/bin/check.sh') ==~ /(?m)Checking health of 'service-name'\\.\\.\\.\\s+Healthy.*\\n/\n+        execWithExitCode('dist/service-name-0.0.1/service/bin/init.sh', 'start') == 0","path":"gradle-sls-packaging/src/test/groovy/com/palantir/gradle/dist/service/ServiceDistributionPluginTests.groovy","position":13,"original_position":13,"commit_id":"d8fe68c398c124bd2cb1525f32fd88c588513e47","original_commit_id":"d8fe68c398c124bd2cb1525f32fd88c588513e47","user":{"login":"dansanduleac","id":222827,"node_id":"MDQ6VXNlcjIyMjgyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/222827?v=4","gravatar_id":"","url":"https://api.github.com/users/dansanduleac","html_url":"https://github.com/dansanduleac","followers_url":"https://api.github.com/users/dansanduleac/followers","following_url":"https://api.github.com/users/dansanduleac/following{/other_user}","gists_url":"https://api.github.com/users/dansanduleac/gists{/gist_id}","starred_url":"https://api.github.com/users/dansanduleac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansanduleac/subscriptions","organizations_url":"https://api.github.com/users/dansanduleac/orgs","repos_url":"https://api.github.com/users/dansanduleac/repos","events_url":"https://api.github.com/users/dansanduleac/events{/privacy}","received_events_url":"https://api.github.com/users/dansanduleac/received_events","type":"User","site_admin":false},"body":"Think we should just add a `sleep 1000` after this line (to wait for the process to be up), and remove the sleeps in the util methods - execWithExitCode and execWithOutput","created_at":"2018-07-19T16:34:57Z","updated_at":"2018-07-19T16:34:57Z","html_url":"https://github.com/palantir/sls-packaging/pull/306#discussion_r203794109","pull_request_url":"https://api.github.com/repos/palantir/sls-packaging/pulls/306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/comments/203794109"},"html":{"href":"https://github.com/palantir/sls-packaging/pull/306#discussion_r203794109"},"pull_request":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/sls-packaging/pulls/306","id":202401905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDAxOTA1","html_url":"https://github.com/palantir/sls-packaging/pull/306","diff_url":"https://github.com/palantir/sls-packaging/pull/306.diff","patch_url":"https://github.com/palantir/sls-packaging/pull/306.patch","issue_url":"https://api.github.com/repos/palantir/sls-packaging/issues/306","number":306,"state":"open","locked":false,"title":"Update init.sh to use go-init","user":{"login":"gregakinman","id":6173659,"node_id":"MDQ6VXNlcjYxNzM2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6173659?v=4","gravatar_id":"","url":"https://api.github.com/users/gregakinman","html_url":"https://github.com/gregakinman","followers_url":"https://api.github.com/users/gregakinman/followers","following_url":"https://api.github.com/users/gregakinman/following{/other_user}","gists_url":"https://api.github.com/users/gregakinman/gists{/gist_id}","starred_url":"https://api.github.com/users/gregakinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregakinman/subscriptions","organizations_url":"https://api.github.com/users/gregakinman/orgs","repos_url":"https://api.github.com/users/gregakinman/repos","events_url":"https://api.github.com/users/gregakinman/events{/privacy}","received_events_url":"https://api.github.com/users/gregakinman/received_events","type":"User","site_admin":false},"body":"fysa @cbrockington ","created_at":"2018-07-18T22:53:30Z","updated_at":"2018-07-19T16:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bbdbfd1c52a9c5310ebd20a65189a1ab1e26b8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/sls-packaging/pulls/306/commits","review_comments_url":"https://api.github.com/repos/palantir/sls-packaging/pulls/306/comments","review_comment_url":"https://api.github.com/repos/palantir/sls-packaging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/sls-packaging/issues/306/comments","statuses_url":"https://api.github.com/repos/palantir/sls-packaging/statuses/d8fe68c398c124bd2cb1525f32fd88c588513e47","head":{"label":"gregakinman:gk/go-init","ref":"gk/go-init","sha":"d8fe68c398c124bd2cb1525f32fd88c588513e47","user":{"login":"gregakinman","id":6173659,"node_id":"MDQ6VXNlcjYxNzM2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6173659?v=4","gravatar_id":"","url":"https://api.github.com/users/gregakinman","html_url":"https://github.com/gregakinman","followers_url":"https://api.github.com/users/gregakinman/followers","following_url":"https://api.github.com/users/gregakinman/following{/other_user}","gists_url":"https://api.github.com/users/gregakinman/gists{/gist_id}","starred_url":"https://api.github.com/users/gregakinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregakinman/subscriptions","organizations_url":"https://api.github.com/users/gregakinman/orgs","repos_url":"https://api.github.com/users/gregakinman/repos","events_url":"https://api.github.com/users/gregakinman/events{/privacy}","received_events_url":"https://api.github.com/users/gregakinman/received_events","type":"User","site_admin":false},"repo":{"id":134637640,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ2Mzc2NDA=","name":"sls-packaging","full_name":"gregakinman/sls-packaging","owner":{"login":"gregakinman","id":6173659,"node_id":"MDQ6VXNlcjYxNzM2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6173659?v=4","gravatar_id":"","url":"https://api.github.com/users/gregakinman","html_url":"https://github.com/gregakinman","followers_url":"https://api.github.com/users/gregakinman/followers","following_url":"https://api.github.com/users/gregakinman/following{/other_user}","gists_url":"https://api.github.com/users/gregakinman/gists{/gist_id}","starred_url":"https://api.github.com/users/gregakinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregakinman/subscriptions","organizations_url":"https://api.github.com/users/gregakinman/orgs","repos_url":"https://api.github.com/users/gregakinman/repos","events_url":"https://api.github.com/users/gregakinman/events{/privacy}","received_events_url":"https://api.github.com/users/gregakinman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregakinman/sls-packaging","description":"A set of Gradle plugins for creating SLS-compatible packages","fork":true,"url":"https://api.github.com/repos/gregakinman/sls-packaging","forks_url":"https://api.github.com/repos/gregakinman/sls-packaging/forks","keys_url":"https://api.github.com/repos/gregakinman/sls-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregakinman/sls-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregakinman/sls-packaging/teams","hooks_url":"https://api.github.com/repos/gregakinman/sls-packaging/hooks","issue_events_url":"https://api.github.com/repos/gregakinman/sls-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/gregakinman/sls-packaging/events","assignees_url":"https://api.github.com/repos/gregakinman/sls-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/gregakinman/sls-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/gregakinman/sls-packaging/tags","blobs_url":"https://api.github.com/repos/gregakinman/sls-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregakinman/sls-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregakinman/sls-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregakinman/sls-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregakinman/sls-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/gregakinman/sls-packaging/languages","stargazers_url":"https://api.github.com/repos/gregakinman/sls-packaging/stargazers","contributors_url":"https://api.github.com/repos/gregakinman/sls-packaging/contributors","subscribers_url":"https://api.github.com/repos/gregakinman/sls-packaging/subscribers","subscription_url":"https://api.github.com/repos/gregakinman/sls-packaging/subscription","commits_url":"https://api.github.com/repos/gregakinman/sls-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregakinman/sls-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregakinman/sls-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregakinman/sls-packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregakinman/sls-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/gregakinman/sls-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregakinman/sls-packaging/merges","archive_url":"https://api.github.com/repos/gregakinman/sls-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregakinman/sls-packaging/downloads","issues_url":"https://api.github.com/repos/gregakinman/sls-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/gregakinman/sls-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/gregakinman/sls-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/gregakinman/sls-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregakinman/sls-packaging/labels{/name}","releases_url":"https://api.github.com/repos/gregakinman/sls-packaging/releases{/id}","deployments_url":"https://api.github.com/repos/gregakinman/sls-packaging/deployments","created_at":"2018-05-23T23:52:36Z","updated_at":"2018-05-23T23:52:38Z","pushed_at":"2018-07-18T23:24:54Z","git_url":"git://github.com/gregakinman/sls-packaging.git","ssh_url":"git@github.com:gregakinman/sls-packaging.git","clone_url":"https://github.com/gregakinman/sls-packaging.git","svn_url":"https://github.com/gregakinman/sls-packaging","homepage":"","size":7019,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"2f002c7c79394244cc848fd24be9ac4d07997f02","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":41394255,"node_id":"MDEwOlJlcG9zaXRvcnk0MTM5NDI1NQ==","name":"sls-packaging","full_name":"palantir/sls-packaging","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/sls-packaging","description":"A set of Gradle plugins for creating SLS-compatible packages","fork":false,"url":"https://api.github.com/repos/palantir/sls-packaging","forks_url":"https://api.github.com/repos/palantir/sls-packaging/forks","keys_url":"https://api.github.com/repos/palantir/sls-packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/sls-packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/sls-packaging/teams","hooks_url":"https://api.github.com/repos/palantir/sls-packaging/hooks","issue_events_url":"https://api.github.com/repos/palantir/sls-packaging/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/sls-packaging/events","assignees_url":"https://api.github.com/repos/palantir/sls-packaging/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/sls-packaging/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/sls-packaging/tags","blobs_url":"https://api.github.com/repos/palantir/sls-packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/sls-packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/sls-packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/sls-packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/sls-packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/sls-packaging/languages","stargazers_url":"https://api.github.com/repos/palantir/sls-packaging/stargazers","contributors_url":"https://api.github.com/repos/palantir/sls-packaging/contributors","subscribers_url":"https://api.github.com/repos/palantir/sls-packaging/subscribers","subscription_url":"https://api.github.com/repos/palantir/sls-packaging/subscription","commits_url":"https://api.github.com/repos/palantir/sls-packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/sls-packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/sls-packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/sls-packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/sls-packaging/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/sls-packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/sls-packaging/merges","archive_url":"https://api.github.com/repos/palantir/sls-packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/sls-packaging/downloads","issues_url":"https://api.github.com/repos/palantir/sls-packaging/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/sls-packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/sls-packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/sls-packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/sls-packaging/labels{/name}","releases_url":"https://api.github.com/repos/palantir/sls-packaging/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/sls-packaging/deployments","created_at":"2015-08-26T00:03:55Z","updated_at":"2018-06-28T17:48:32Z","pushed_at":"2018-07-19T15:17:11Z","git_url":"git://github.com/palantir/sls-packaging.git","ssh_url":"git@github.com:palantir/sls-packaging.git","clone_url":"https://github.com/palantir/sls-packaging.git","svn_url":"https://github.com/palantir/sls-packaging","homepage":"","size":4112,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":58,"open_issues":40,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/306"},"html":{"href":"https://github.com/palantir/sls-packaging/pull/306"},"issue":{"href":"https://api.github.com/repos/palantir/sls-packaging/issues/306"},"comments":{"href":"https://api.github.com/repos/palantir/sls-packaging/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/sls-packaging/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/sls-packaging/statuses/d8fe68c398c124bd2cb1525f32fd88c588513e47"}},"author_association":"NONE"}}
{"actor":{"display_login":"dansanduleac"}}