{"action":"created","issue":{"url":"https://api.github.com/repos/runelite/runelite/issues/4118","repository_url":"https://api.github.com/repos/runelite/runelite","labels_url":"https://api.github.com/repos/runelite/runelite/issues/4118/labels{/name}","comments_url":"https://api.github.com/repos/runelite/runelite/issues/4118/comments","events_url":"https://api.github.com/repos/runelite/runelite/issues/4118/events","html_url":"https://github.com/runelite/runelite/pull/4118","id":337278989,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTE2Nzk4","number":4118,"title":"Add drag and drop reordering for XP tracker bars","user":{"login":"Shingyx","id":11037113,"node_id":"MDQ6VXNlcjExMDM3MTEz","avatar_url":"https://avatars2.githubusercontent.com/u/11037113?v=4","gravatar_id":"","url":"https://api.github.com/users/Shingyx","html_url":"https://github.com/Shingyx","followers_url":"https://api.github.com/users/Shingyx/followers","following_url":"https://api.github.com/users/Shingyx/following{/other_user}","gists_url":"https://api.github.com/users/Shingyx/gists{/gist_id}","starred_url":"https://api.github.com/users/Shingyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shingyx/subscriptions","organizations_url":"https://api.github.com/users/Shingyx/orgs","repos_url":"https://api.github.com/users/Shingyx/repos","events_url":"https://api.github.com/users/Shingyx/events{/privacy}","received_events_url":"https://api.github.com/users/Shingyx/received_events","type":"User","site_admin":false},"labels":[{"id":771846940,"node_id":"MDU6TGFiZWw3NzE4NDY5NDA=","url":"https://api.github.com/repos/runelite/runelite/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-01T10:01:44Z","updated_at":"2018-07-14T13:11:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/runelite/runelite/pulls/4118","html_url":"https://github.com/runelite/runelite/pull/4118","diff_url":"https://github.com/runelite/runelite/pull/4118.diff","patch_url":"https://github.com/runelite/runelite/pull/4118.patch"},"body":"Implement a custom MouseAdapter which watches for mouse drag events to move child components within a JPanel. Include a workaround for child popup menus, since setComponentPopupMenu consumes the required MouseEvents. Also remove redundant line in `XpInfoBox#reset`.\r\n\r\nResolves https://github.com/runelite/runelite/issues/3102 and https://github.com/runelite/runelite/issues/2029. There could be others too, I didn't look that hard.\r\n\r\nThe mouse adapter should be generic enough so that it could be applied to some of the other plugins in the future."},"comment":{"url":"https://api.github.com/repos/runelite/runelite/issues/comments/405022896","html_url":"https://github.com/runelite/runelite/pull/4118#issuecomment-405022896","issue_url":"https://api.github.com/repos/runelite/runelite/issues/4118","id":405022896,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTAyMjg5Ng==","user":{"login":"Shingyx","id":11037113,"node_id":"MDQ6VXNlcjExMDM3MTEz","avatar_url":"https://avatars2.githubusercontent.com/u/11037113?v=4","gravatar_id":"","url":"https://api.github.com/users/Shingyx","html_url":"https://github.com/Shingyx","followers_url":"https://api.github.com/users/Shingyx/followers","following_url":"https://api.github.com/users/Shingyx/following{/other_user}","gists_url":"https://api.github.com/users/Shingyx/gists{/gist_id}","starred_url":"https://api.github.com/users/Shingyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shingyx/subscriptions","organizations_url":"https://api.github.com/users/Shingyx/orgs","repos_url":"https://api.github.com/users/Shingyx/repos","events_url":"https://api.github.com/users/Shingyx/events{/privacy}","received_events_url":"https://api.github.com/users/Shingyx/received_events","type":"User","site_admin":false},"created_at":"2018-07-14T13:11:29Z","updated_at":"2018-07-14T13:11:29Z","author_association":"CONTRIBUTOR","body":"I don't know of any more issues from testing on Windows. However, I tried this out on Ubuntu (and Kubuntu) and it works great in most cases, except for one issue I noticed where it can get into a weird state when trying to drag an info panel while a pop up menu for another info panel is open, where the dragging panel gets \"stuck\" when the mouse is released. This is because the `MouseReleased` event doesn't seem to get received when this happens. The overall UI recoverable by clicking somewhere else in the XP plugin panel.\r\n\r\nOn that note, should the reordering be configurable? I don't know how I'd workaround this issue..."}}
{"actor":{"display_login":"Shingyx"}}