{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1892","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1892/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1892/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1892/events","html_url":"https://github.com/shopware/shopware/pull/1892","id":383229123,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzQ5NzQz","number":1892,"title":"fix StateManager miscalculation for iOS > 10","user":{"login":"webisdead","id":6973876,"node_id":"MDQ6VXNlcjY5NzM4NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/6973876?v=4","gravatar_id":"","url":"https://api.github.com/users/webisdead","html_url":"https://github.com/webisdead","followers_url":"https://api.github.com/users/webisdead/followers","following_url":"https://api.github.com/users/webisdead/following{/other_user}","gists_url":"https://api.github.com/users/webisdead/gists{/gist_id}","starred_url":"https://api.github.com/users/webisdead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webisdead/subscriptions","organizations_url":"https://api.github.com/users/webisdead/orgs","repos_url":"https://api.github.com/users/webisdead/repos","events_url":"https://api.github.com/users/webisdead/events{/privacy}","received_events_url":"https://api.github.com/users/webisdead/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-21T17:42:33Z","updated_at":"2018-11-23T07:53:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1892","html_url":"https://github.com/shopware/shopware/pull/1892","diff_url":"https://github.com/shopware/shopware/pull/1892.diff","patch_url":"https://github.com/shopware/shopware/pull/1892.patch"},"body":"<!--\r\nThank you for contributing to Shopware! Please fill out this description template to help us to process your pull request.\r\n\r\nPlease make sure to fulfil our contribution guideline (https://developers.shopware.com/contributing/contribution-guideline/).\r\n-->\r\n\r\n### 1. Why is this change necessary?\r\n- this fixes wrong calculation for viewport-width in statemanager since iOS ignores \"user-scalable=no\" meta-value\r\n\r\n### 2. What does this change do, exactly?\r\n- it returns the correct value if window is zoomed\r\n- it makes the operation more readable\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n- use Safari on iPad on iOS > 10 (wich is ignoring \"user-scalable=no\")\r\n- scroll to elements relying on State Manager e.g. .column-headline in footer on https://www.shopwaredemo.de/\r\n-  pinch-zoom a little bit (zoom > 1)\r\n- tap mutiple times on title-element (e.g. \"Newsletter\")\r\n- see content collapsing\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n-\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n-\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [ ] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/441173323","html_url":"https://github.com/shopware/shopware/pull/1892#issuecomment-441173323","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1892","id":441173323,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTE3MzMyMw==","user":{"login":"shopwareBot","id":4725494,"node_id":"MDQ6VXNlcjQ3MjU0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4725494?v=4","gravatar_id":"","url":"https://api.github.com/users/shopwareBot","html_url":"https://github.com/shopwareBot","followers_url":"https://api.github.com/users/shopwareBot/followers","following_url":"https://api.github.com/users/shopwareBot/following{/other_user}","gists_url":"https://api.github.com/users/shopwareBot/gists{/gist_id}","starred_url":"https://api.github.com/users/shopwareBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopwareBot/subscriptions","organizations_url":"https://api.github.com/users/shopwareBot/orgs","repos_url":"https://api.github.com/users/shopwareBot/repos","events_url":"https://api.github.com/users/shopwareBot/events{/privacy}","received_events_url":"https://api.github.com/users/shopwareBot/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T07:53:22Z","updated_at":"2018-11-23T07:53:22Z","author_association":"NONE","body":"Hello,\n\nthank you for creating this pull request.\nI have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-23025\n\nPlease use this issue to track the state of your pull request."}}
{"actor":{"display_login":"shopwareBot"}}