{"action":"created","comment":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments/190067552","pull_request_review_id":122368414,"id":190067552,"diff_hunk":"@@ -16,9 +14,10 @@ import memoize from '../utils/memoize'\n  */\n \n const DEFAULTS = {\n-  characters: new List(),\n+  leaves: List(),\n   key: undefined,\n }\n+const emptyLeaf = Leaf.create({})","path":"packages/slate/src/models/text.js","position":19,"original_position":19,"commit_id":"3736824ccbed1e025ebd02f4dbf9d5c020466c2d","original_commit_id":"3736824ccbed1e025ebd02f4dbf9d5c020466c2d","user":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"body":"What's this doing here? Why is it not in `CONSTANT_CASE`? Why does it not have a docblock comment? Why is there no line break before it?","created_at":"2018-05-22T22:03:12Z","updated_at":"2018-05-22T22:21:39Z","html_url":"https://github.com/ianstormtaylor/slate/pull/1816#discussion_r190067552","pull_request_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments/190067552"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/1816#discussion_r190067552"},"pull_request":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816"}}},"pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816","id":185750970,"html_url":"https://github.com/ianstormtaylor/slate/pull/1816","diff_url":"https://github.com/ianstormtaylor/slate/pull/1816.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/1816.patch","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1816","number":1816,"state":"open","locked":false,"title":"Characters to leaves","user":{"login":"zhujinxuan","id":746159,"avatar_url":"https://avatars3.githubusercontent.com/u/746159?v=4","gravatar_id":"","url":"https://api.github.com/users/zhujinxuan","html_url":"https://github.com/zhujinxuan","followers_url":"https://api.github.com/users/zhujinxuan/followers","following_url":"https://api.github.com/users/zhujinxuan/following{/other_user}","gists_url":"https://api.github.com/users/zhujinxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhujinxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhujinxuan/subscriptions","organizations_url":"https://api.github.com/users/zhujinxuan/orgs","repos_url":"https://api.github.com/users/zhujinxuan/repos","events_url":"https://api.github.com/users/zhujinxuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhujinxuan/received_events","type":"User","site_admin":false},"body":"Feature;\r\nCurrently, this PR is on development of writing tests and some leaf functions.  ","created_at":"2018-05-03T15:18:12Z","updated_at":"2018-05-22T22:21:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abc5129a77663b00f81d48c87eb2827fbb07e0b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1816/comments","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/3736824ccbed1e025ebd02f4dbf9d5c020466c2d","head":{"label":"zhujinxuan:characters-to-leaves","ref":"characters-to-leaves","sha":"3736824ccbed1e025ebd02f4dbf9d5c020466c2d","user":{"login":"zhujinxuan","id":746159,"avatar_url":"https://avatars3.githubusercontent.com/u/746159?v=4","gravatar_id":"","url":"https://api.github.com/users/zhujinxuan","html_url":"https://github.com/zhujinxuan","followers_url":"https://api.github.com/users/zhujinxuan/followers","following_url":"https://api.github.com/users/zhujinxuan/following{/other_user}","gists_url":"https://api.github.com/users/zhujinxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhujinxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhujinxuan/subscriptions","organizations_url":"https://api.github.com/users/zhujinxuan/orgs","repos_url":"https://api.github.com/users/zhujinxuan/repos","events_url":"https://api.github.com/users/zhujinxuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhujinxuan/received_events","type":"User","site_admin":false},"repo":{"id":117600430,"name":"slate","full_name":"zhujinxuan/slate","owner":{"login":"zhujinxuan","id":746159,"avatar_url":"https://avatars3.githubusercontent.com/u/746159?v=4","gravatar_id":"","url":"https://api.github.com/users/zhujinxuan","html_url":"https://github.com/zhujinxuan","followers_url":"https://api.github.com/users/zhujinxuan/followers","following_url":"https://api.github.com/users/zhujinxuan/following{/other_user}","gists_url":"https://api.github.com/users/zhujinxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhujinxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhujinxuan/subscriptions","organizations_url":"https://api.github.com/users/zhujinxuan/orgs","repos_url":"https://api.github.com/users/zhujinxuan/repos","events_url":"https://api.github.com/users/zhujinxuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhujinxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhujinxuan/slate","description":"A completely customizable framework for building rich text editors.","fork":true,"url":"https://api.github.com/repos/zhujinxuan/slate","forks_url":"https://api.github.com/repos/zhujinxuan/slate/forks","keys_url":"https://api.github.com/repos/zhujinxuan/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhujinxuan/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhujinxuan/slate/teams","hooks_url":"https://api.github.com/repos/zhujinxuan/slate/hooks","issue_events_url":"https://api.github.com/repos/zhujinxuan/slate/issues/events{/number}","events_url":"https://api.github.com/repos/zhujinxuan/slate/events","assignees_url":"https://api.github.com/repos/zhujinxuan/slate/assignees{/user}","branches_url":"https://api.github.com/repos/zhujinxuan/slate/branches{/branch}","tags_url":"https://api.github.com/repos/zhujinxuan/slate/tags","blobs_url":"https://api.github.com/repos/zhujinxuan/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhujinxuan/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhujinxuan/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhujinxuan/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhujinxuan/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/zhujinxuan/slate/languages","stargazers_url":"https://api.github.com/repos/zhujinxuan/slate/stargazers","contributors_url":"https://api.github.com/repos/zhujinxuan/slate/contributors","subscribers_url":"https://api.github.com/repos/zhujinxuan/slate/subscribers","subscription_url":"https://api.github.com/repos/zhujinxuan/slate/subscription","commits_url":"https://api.github.com/repos/zhujinxuan/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhujinxuan/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhujinxuan/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhujinxuan/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhujinxuan/slate/contents/{+path}","compare_url":"https://api.github.com/repos/zhujinxuan/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhujinxuan/slate/merges","archive_url":"https://api.github.com/repos/zhujinxuan/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhujinxuan/slate/downloads","issues_url":"https://api.github.com/repos/zhujinxuan/slate/issues{/number}","pulls_url":"https://api.github.com/repos/zhujinxuan/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/zhujinxuan/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/zhujinxuan/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhujinxuan/slate/labels{/name}","releases_url":"https://api.github.com/repos/zhujinxuan/slate/releases{/id}","deployments_url":"https://api.github.com/repos/zhujinxuan/slate/deployments","created_at":"2018-01-15T22:06:20Z","updated_at":"2018-04-27T23:28:30Z","pushed_at":"2018-05-22T20:57:36Z","git_url":"git://github.com/zhujinxuan/slate.git","ssh_url":"git@github.com:zhujinxuan/slate.git","clone_url":"https://github.com/zhujinxuan/slate.git","svn_url":"https://github.com/zhujinxuan/slate","homepage":"http://slatejs.org","size":182218,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ianstormtaylor:master","ref":"master","sha":"ffb19cac1aa90bb1a38d57e84b4ac5728bfd101f","user":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"repo":{"id":61412022,"name":"slate","full_name":"ianstormtaylor/slate","owner":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianstormtaylor/slate","description":"A completely customizable framework for building rich text editors.","fork":false,"url":"https://api.github.com/repos/ianstormtaylor/slate","forks_url":"https://api.github.com/repos/ianstormtaylor/slate/forks","keys_url":"https://api.github.com/repos/ianstormtaylor/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianstormtaylor/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianstormtaylor/slate/teams","hooks_url":"https://api.github.com/repos/ianstormtaylor/slate/hooks","issue_events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/events{/number}","events_url":"https://api.github.com/repos/ianstormtaylor/slate/events","assignees_url":"https://api.github.com/repos/ianstormtaylor/slate/assignees{/user}","branches_url":"https://api.github.com/repos/ianstormtaylor/slate/branches{/branch}","tags_url":"https://api.github.com/repos/ianstormtaylor/slate/tags","blobs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianstormtaylor/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianstormtaylor/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/ianstormtaylor/slate/languages","stargazers_url":"https://api.github.com/repos/ianstormtaylor/slate/stargazers","contributors_url":"https://api.github.com/repos/ianstormtaylor/slate/contributors","subscribers_url":"https://api.github.com/repos/ianstormtaylor/slate/subscribers","subscription_url":"https://api.github.com/repos/ianstormtaylor/slate/subscription","commits_url":"https://api.github.com/repos/ianstormtaylor/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianstormtaylor/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianstormtaylor/slate/contents/{+path}","compare_url":"https://api.github.com/repos/ianstormtaylor/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianstormtaylor/slate/merges","archive_url":"https://api.github.com/repos/ianstormtaylor/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianstormtaylor/slate/downloads","issues_url":"https://api.github.com/repos/ianstormtaylor/slate/issues{/number}","pulls_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/ianstormtaylor/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/ianstormtaylor/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/labels{/name}","releases_url":"https://api.github.com/repos/ianstormtaylor/slate/releases{/id}","deployments_url":"https://api.github.com/repos/ianstormtaylor/slate/deployments","created_at":"2016-06-18T01:52:42Z","updated_at":"2018-05-22T21:49:04Z","pushed_at":"2018-05-22T20:57:39Z","git_url":"git://github.com/ianstormtaylor/slate.git","ssh_url":"git@github.com:ianstormtaylor/slate.git","clone_url":"https://github.com/ianstormtaylor/slate.git","svn_url":"https://github.com/ianstormtaylor/slate","homepage":"http://slatejs.org","size":192765,"stargazers_count":7501,"watchers_count":7501,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":589,"mirror_url":null,"archived":false,"open_issues_count":232,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":589,"open_issues":232,"watchers":7501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/1816"},"issue":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/1816"},"comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/ianstormtaylor/slate/statuses/3736824ccbed1e025ebd02f4dbf9d5c020466c2d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ianstormtaylor"}}