{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-superset/issues/6502","repository_url":"https://api.github.com/repos/apache/incubator-superset","labels_url":"https://api.github.com/repos/apache/incubator-superset/issues/6502/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/6502/comments","events_url":"https://api.github.com/repos/apache/incubator-superset/issues/6502/events","html_url":"https://github.com/apache/incubator-superset/issues/6502","id":388900716,"node_id":"MDU6SXNzdWUzODg5MDA3MTY=","number":6502,"title":"Markup chart disappear in Chart list -> cannot run custom javascript","user":{"login":"kaitorecca","id":24359044,"node_id":"MDQ6VXNlcjI0MzU5MDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/24359044?v=4","gravatar_id":"","url":"https://api.github.com/users/kaitorecca","html_url":"https://github.com/kaitorecca","followers_url":"https://api.github.com/users/kaitorecca/followers","following_url":"https://api.github.com/users/kaitorecca/following{/other_user}","gists_url":"https://api.github.com/users/kaitorecca/gists{/gist_id}","starred_url":"https://api.github.com/users/kaitorecca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaitorecca/subscriptions","organizations_url":"https://api.github.com/users/kaitorecca/orgs","repos_url":"https://api.github.com/users/kaitorecca/repos","events_url":"https://api.github.com/users/kaitorecca/events{/privacy}","received_events_url":"https://api.github.com/users/kaitorecca/received_events","type":"User","site_admin":false},"labels":[{"id":238899555,"node_id":"MDU6TGFiZWwyMzg4OTk1NTU=","url":"https://api.github.com/repos/apache/incubator-superset/labels/%23question","name":"#question","color":"dbdb18","default":false},{"id":1126422885,"node_id":"MDU6TGFiZWwxMTI2NDIyODg1","url":"https://api.github.com/repos/apache/incubator-superset/labels/v0.29","name":"v0.29","color":"B1D558","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-12-08T08:30:45Z","updated_at":"2018-12-13T19:04:27Z","closed_at":null,"author_association":"NONE","body":"Make sure these boxes are checked before submitting your issue - thank you!\r\n\r\n- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.\r\n- [x] I have reproduced the issue with at least the latest released version of superset.\r\n- [x] I have checked the issue tracker for the same issue and I haven't found one similar.\r\n\r\n\r\n### Superset version\r\n0.29.0rc6\r\n\r\n### Expected results\r\nStill see the markup component in Chart which can run Javascript & JQuery in HTML mode like 0.28.1\r\n\r\n### Actual results\r\nCannot find the Markup in Chart. In Dashboard, there is one Markdown in panel but it supported only the Markdown standard, without HTML. So I cannot run custom javascript in my dashhboard.\r\n\r\n### Steps to reproduce\r\nMenu > Data Source > Markup Chart > ...\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-superset/issues/comments/447082781","html_url":"https://github.com/apache/incubator-superset/issues/6502#issuecomment-447082781","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/6502","id":447082781,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA4Mjc4MQ==","user":{"login":"williaster","id":4496521,"node_id":"MDQ6VXNlcjQ0OTY1MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4496521?v=4","gravatar_id":"","url":"https://api.github.com/users/williaster","html_url":"https://github.com/williaster","followers_url":"https://api.github.com/users/williaster/followers","following_url":"https://api.github.com/users/williaster/following{/other_user}","gists_url":"https://api.github.com/users/williaster/gists{/gist_id}","starred_url":"https://api.github.com/users/williaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williaster/subscriptions","organizations_url":"https://api.github.com/users/williaster/orgs","repos_url":"https://api.github.com/users/williaster/repos","events_url":"https://api.github.com/users/williaster/events{/privacy}","received_events_url":"https://api.github.com/users/williaster/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T19:04:27Z","updated_at":"2018-12-13T19:04:27Z","author_association":"CONTRIBUTOR","body":"We'd rather not turn the markup chart back on, it was deprecated for a reason, namely that it makes no sense in the context of a slice, it should be a dashboard construct. Even if it was turned back on in explorer, these chart types are filtered in the edit dashboard flow, so you can't add them to dashboards either.\r\n\r\nI also don't understand what you mean by this sentence\r\n\r\n> Regards to security, the user has level of making dashboard show have responsibility to make safe javascript by their customization.\r\n\r\nbut generally agree that custom JS is a security concern and am not sure if I fully support the sandboxed JS. I think if this type of hook is needed we should find another way to expose it. As mistercrunch pointed out, we will have chart plugins soon which you could leverage to re-enable something like this."}}
{"actor":{"display_login":"williaster"}}