{"action":"closed","issue":{"url":"https://api.github.com/repos/ethers-io/ethers.js/issues/162","repository_url":"https://api.github.com/repos/ethers-io/ethers.js","labels_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/162/comments","events_url":"https://api.github.com/repos/ethers-io/ethers.js/issues/162/events","html_url":"https://github.com/ethers-io/ethers.js/issues/162","id":313869648,"node_id":"MDU6SXNzdWUzMTM4Njk2NDg=","number":162,"title":"Signing transactions send to Quorum permissioned blockchain","user":{"login":"michaelerose","id":3155425,"node_id":"MDQ6VXNlcjMxNTU0MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3155425?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelerose","html_url":"https://github.com/michaelerose","followers_url":"https://api.github.com/users/michaelerose/followers","following_url":"https://api.github.com/users/michaelerose/following{/other_user}","gists_url":"https://api.github.com/users/michaelerose/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelerose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelerose/subscriptions","organizations_url":"https://api.github.com/users/michaelerose/orgs","repos_url":"https://api.github.com/users/michaelerose/repos","events_url":"https://api.github.com/users/michaelerose/events{/privacy}","received_events_url":"https://api.github.com/users/michaelerose/received_events","type":"User","site_admin":false},"labels":[{"id":409075434,"node_id":"MDU6TGFiZWw0MDkwNzU0MzQ=","url":"https://api.github.com/repos/ethers-io/ethers.js/labels/discussion","name":"discussion","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-04-12T20:08:06Z","updated_at":"2018-07-03T20:54:30Z","closed_at":"2018-07-03T20:54:30Z","author_association":"NONE","body":"I got an \"Invalid sender\" error message when I called the sendTransaction method for a local permissioned network launched by the quorum-maker application\r\n\r\nlet contract = await ethers.Contract.getDeployTransaction ( byteCode, compile.interface ) ; \r\nlet response = wallet.sendTransaction ( contract ) ;\r\n\r\nThe error was thrown within the Quorum library - which does more stringent error checking than vanilla go-ethereum - and I traced this to the ether.js transaction signature.\r\n\r\nI replaced lines 280-288 in ethers/wallet/wallet.js and used the web3@1.0.0-beta.33 signer instead, i.e. the code\r\n\r\n    var signedTransaction = self.sign({ to: results[2], data: data, gasLimit: gasLimit, gasPrice: results[0], nonce: results[1], value: value, chainId: chainId }) ; \r\n\r\nwas replaced with \r\n\r\n    var txData = { to: results[2], data: data, gasLimit: gasLimit, gasPrice: results[0], nonce: results[1], value: value, chainId: chainId } ;\r\n    txData.from = wallet.address ;\r\n    let web3SignedTx = await web3.eth.signTransaction ( txData , wallet.address ) ;\r\n    let signedTransaction = web3SignedTx.raw ;\r\n\r\nand I successfully deployed the transaction to the blockchain. Not a great solution since I want to remove web3 from my code, but it works. \r\n\r\nThe relevant Quorum code is in quorum/core/types directory in source files transactions.go and transaction_signing.go, which overrides some of ethereum-go's transaction processing. "}}
{"actor":{"display_login":"ricmoo"}}