{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/419","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/419/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/419/events","html_url":"https://github.com/StrikeNP/trac_test/issues/419","id":330446351,"node_id":"MDU6SXNzdWUzMzA0NDYzNTE=","number":419,"title":"Use *_surface.in file for all cases (Trac #419)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":958019852,"node_id":"MDU6TGFiZWw5NTgwMTk4NTI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":958042830,"node_id":"MDU6TGFiZWw5NTgwNDI4MzA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":958056283,"node_id":"MDU6TGFiZWw5NTgwNTYyODM=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/connork@uwm.edu","name":"connork@uwm.edu","color":"FFFFFF","default":false},{"id":958019578,"node_id":"MDU6TGFiZWw5NTgwMTk1Nzg=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4","html_url":"https://github.com/StrikeNP/trac_test/milestone/4","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/4/labels","id":3408870,"node_id":"MDk6TWlsZXN0b25lMzQwODg3MA==","number":4,"title":"3. Refactor CLUBB","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":55,"state":"open","created_at":"2018-06-07T19:57:05Z","updated_at":"2018-06-09T01:43:38Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-06-07T21:42:28Z","updated_at":"2018-06-09T01:43:56Z","closed_at":null,"author_association":"OWNER","body":"'''Introduction'''\n\nThe surface sensible and latent heat fluxes are not put in sfc.in files for all cases, e.g., BOMEX. We should rectify this. Also, we should standardize and document the notation, e.g., SH = sensible heat and LH = latent heat. \n\n'''Technical Specs'''\n\nFigure out how bomex, arm, astex, and clex9_nov02 input the surface data. Think of how we can make these share as much code as possible.\n\nCurrently, CLUBB inputs the surface fluxes (wpthlp_sfc a.k.a sensible heat flux a.k.a SH and wpqtp_sfc a.k.a latent heat flux a.k.a LH) in subroutine bomex_sfclyr. Instead, we would like the data to be entered in a text file called bomex_surface.in, as is done with cloud_feedback_s11_surface.in.\n\nWe need to convert units into W/m^2^. For this, use the invers of the functions postprocessing/matlab_include/convert_units.m:flux_in_W_m_sq_to_Kms and flux_in_W_m_sq_to_kgkgms. Use \n```constants_clubb, only: Cp, Lv```\n\nWe will need to find the value of density at the surface, rho_zm(1). This can be found from the bomex_zm GrADS output file. Use variable dn0, as in Benchmark_cases/arm.F90.\n\nStructure the code similar to Benchmark_cases/arm.F90:arm_sfclyr.\n\n\n'''Tests'''\n\nResults for modified cases should be the same within roundoff.\n\nAttachments:\n\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/419\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2011-09-07T20:00:48\", \n    \"description\": \"'''Introduction'''\\n\\nThe surface sensible and latent heat fluxes are not put in sfc.in files for all cases, e.g., BOMEX. We should rectify this. Also, we should standardize and document the notation, e.g., SH = sensible heat and LH = latent heat. \\n\\n'''Technical Specs'''\\n\\nFigure out how bomex, arm, astex, and clex9_nov02 input the surface data. Think of how we can make these share as much code as possible.\\n\\nCurrently, CLUBB inputs the surface fluxes (wpthlp_sfc a.k.a sensible heat flux a.k.a SH and wpqtp_sfc a.k.a latent heat flux a.k.a LH) in subroutine bomex_sfclyr. Instead, we would like the data to be entered in a text file called bomex_surface.in, as is done with cloud_feedback_s11_surface.in.\\n\\nWe need to convert units into W/m^2^. For this, use the invers of the functions postprocessing/matlab_include/convert_units.m:flux_in_W_m_sq_to_Kms and flux_in_W_m_sq_to_kgkgms. Use \\n{{{constants_clubb, only: Cp, Lv}}}\\n\\nWe will need to find the value of density at the surface, rho_zm(1). This can be found from the bomex_zm GrADS output file. Use variable dn0, as in Benchmark_cases/arm.F90.\\n\\nStructure the code similar to Benchmark_cases/arm.F90:arm_sfclyr.\\n\\n\\n'''Tests'''\\n\\nResults for modified cases should be the same within roundoff.\", \n    \"reporter\": \"connork@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu, meyern@uwm.edu, dschanen@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1315425648000000\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Use *_surface.in file for all cases\", \n    \"priority\": \"major\", \n    \"keywords\": \"\", \n    \"time\": \"2011-06-09T18:38:36\", \n    \"milestone\": \"3. Refactor CLUBB\", \n    \"owner\": \"connork@uwm.edu\", \n    \"type\": \"enhancement\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/395930668","html_url":"https://github.com/StrikeNP/trac_test/issues/419#issuecomment-395930668","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/419","id":395930668,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTkzMDY2OA==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T01:43:56Z","updated_at":"2018-06-09T01:43:56Z","author_association":"OWNER","body":"Trac update at 2011/06/16 at 18:40\n\ndschanen@uwm.edu commented:\n\nReplying to [comment:6 connork@…]:\n> Replying to [comment:5 connork@…]:\n> > I modified the time_select subroutine (source:trunk/src/time_dependent_input.F90#L666) so that if a time was given before or after the first or last given time, the program would stop. After running the code with this change, both the cobra and jun25_altocu cases failed. This means that these cases have inputs before or after the given times. There are two options for changing time_select to deal with this\n> > \n> >  1. If the time is less than the first given time, set the time to the the first given time. If the time is greater than the last given time, set the time to the last given time.\n> >  2. If the time is before or after the first of last given time, just interpolate beyond the ends of the data.\n> > \n> > Which option seems better? Should I try both and see which gives better results?\n> \n> I just tried both options, and both are bin-diff identical with the current HEAD version of clubb. This means that with the current cases and configuration, both ways have the same output. Which one should I use?\n\nHow does option 2 work?  Is it extrapolating in time somehow?\nCould cobra and June 25 Altocu be modified to have extra time data so we could keep an error message for when the data isn't present?  It seems dangerous to assume that when data is missing the user intended for the last time given to be used.\n\n"}}
{"actor":{"display_login":"StrikeNP"}}