{"action":"created","issue":{"url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/242","repository_url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android","labels_url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/242/comments","events_url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/242/events","html_url":"https://github.com/firebase/firebase-jobdispatcher-android/issues/242","id":323985471,"node_id":"MDU6SXNzdWUzMjM5ODU0NzE=","number":242,"title":"onStartJob return true/false","user":{"login":"eladlavi","id":7921247,"node_id":"MDQ6VXNlcjc5MjEyNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/7921247?v=4","gravatar_id":"","url":"https://api.github.com/users/eladlavi","html_url":"https://github.com/eladlavi","followers_url":"https://api.github.com/users/eladlavi/followers","following_url":"https://api.github.com/users/eladlavi/following{/other_user}","gists_url":"https://api.github.com/users/eladlavi/gists{/gist_id}","starred_url":"https://api.github.com/users/eladlavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladlavi/subscriptions","organizations_url":"https://api.github.com/users/eladlavi/orgs","repos_url":"https://api.github.com/users/eladlavi/repos","events_url":"https://api.github.com/users/eladlavi/events{/privacy}","received_events_url":"https://api.github.com/users/eladlavi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-17T11:38:47Z","updated_at":"2018-10-05T09:14:54Z","closed_at":null,"author_association":"NONE","body":"Because job runs on main thread, in order to download content from server, a Thread must be created.\r\nBut then, what is the meaning of returning true or false in onStartJon?\r\nIf we must return a boolean immediately, and the Thread is still running (which is always the case) then do we return false or true?\r\nI think the design was suppose to be that the Thread notifies the JobService of completion."},"comment":{"url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/comments/427298802","html_url":"https://github.com/firebase/firebase-jobdispatcher-android/issues/242#issuecomment-427298802","issue_url":"https://api.github.com/repos/firebase/firebase-jobdispatcher-android/issues/242","id":427298802,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzI5ODgwMg==","user":{"login":"HimanshuNarang","id":17849725,"node_id":"MDQ6VXNlcjE3ODQ5NzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17849725?v=4","gravatar_id":"","url":"https://api.github.com/users/HimanshuNarang","html_url":"https://github.com/HimanshuNarang","followers_url":"https://api.github.com/users/HimanshuNarang/followers","following_url":"https://api.github.com/users/HimanshuNarang/following{/other_user}","gists_url":"https://api.github.com/users/HimanshuNarang/gists{/gist_id}","starred_url":"https://api.github.com/users/HimanshuNarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HimanshuNarang/subscriptions","organizations_url":"https://api.github.com/users/HimanshuNarang/orgs","repos_url":"https://api.github.com/users/HimanshuNarang/repos","events_url":"https://api.github.com/users/HimanshuNarang/events{/privacy}","received_events_url":"https://api.github.com/users/HimanshuNarang/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T09:14:54Z","updated_at":"2018-10-05T09:14:54Z","author_association":"NONE","body":"Whenever I am calling jobFinished() from background thread or returning false from onStartJob,  OnStop never get called."}}
{"actor":{"display_login":"HimanshuNarang"}}