{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/czmq/issues/1864","repository_url":"https://api.github.com/repos/zeromq/czmq","labels_url":"https://api.github.com/repos/zeromq/czmq/issues/1864/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/czmq/issues/1864/comments","events_url":"https://api.github.com/repos/zeromq/czmq/issues/1864/events","html_url":"https://github.com/zeromq/czmq/pull/1864","id":297748320,"number":1864,"title":"Fix window compilation for non-draft builds","user":{"login":"hambre","id":6901566,"avatar_url":"https://avatars2.githubusercontent.com/u/6901566?v=4","gravatar_id":"","url":"https://api.github.com/users/hambre","html_url":"https://github.com/hambre","followers_url":"https://api.github.com/users/hambre/followers","following_url":"https://api.github.com/users/hambre/following{/other_user}","gists_url":"https://api.github.com/users/hambre/gists{/gist_id}","starred_url":"https://api.github.com/users/hambre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hambre/subscriptions","organizations_url":"https://api.github.com/users/hambre/orgs","repos_url":"https://api.github.com/users/hambre/repos","events_url":"https://api.github.com/users/hambre/events{/privacy}","received_events_url":"https://api.github.com/users/hambre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-16T11:00:59Z","updated_at":"2018-02-16T11:50:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/1864","html_url":"https://github.com/zeromq/czmq/pull/1864","diff_url":"https://github.com/zeromq/czmq/pull/1864.diff","patch_url":"https://github.com/zeromq/czmq/pull/1864.patch"},"body":"When trying to build on windows with the draft-api disabled, compilation fails for multiple reasons.\r\n\r\n- some functions definitions in zsys.c have the CZMQ_EXPORT macro which conflicts in non-draft builds with the CZMQ_PRIVATE declaration of these functions in czmq_classes.h\r\n- declaration of structs ztrie_t, zproc_t, zargs_t and ztimerset_t are disables in czmq_library.h for non-draft builds causing comilation errors in ztrie.c, zproc.c, zargs.c and ztimerset.c\r\n\r\nFor the second point I disabled the respective classes completely using the CZMQ_BUILD_DRAFT_API macro as they were not declared as private classes in non-draft builds.\r\n"},"comment":{"url":"https://api.github.com/repos/zeromq/czmq/issues/comments/366215851","html_url":"https://github.com/zeromq/czmq/pull/1864#issuecomment-366215851","issue_url":"https://api.github.com/repos/zeromq/czmq/issues/1864","id":366215851,"user":{"login":"hambre","id":6901566,"avatar_url":"https://avatars2.githubusercontent.com/u/6901566?v=4","gravatar_id":"","url":"https://api.github.com/users/hambre","html_url":"https://github.com/hambre","followers_url":"https://api.github.com/users/hambre/followers","following_url":"https://api.github.com/users/hambre/following{/other_user}","gists_url":"https://api.github.com/users/hambre/gists{/gist_id}","starred_url":"https://api.github.com/users/hambre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hambre/subscriptions","organizations_url":"https://api.github.com/users/hambre/orgs","repos_url":"https://api.github.com/users/hambre/repos","events_url":"https://api.github.com/users/hambre/events{/privacy}","received_events_url":"https://api.github.com/users/hambre/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T11:50:20Z","updated_at":"2018-02-16T11:50:20Z","author_association":"NONE","body":"Another option would be to just add the declaration of these structs to czmq_classes.h if the draft api is disabled. This would be less invasive and would probably work too. Opinions?\r\n"}}
{"actor":{"display_login":"hambre"}}