{"action":"created","comment":{"url":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments/226403226","pull_request_review_id":166218142,"id":226403226,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQwMzIyNg==","diff_hunk":"@@ -2574,9 +2574,234 @@\n                     }\n                 }\n             }\n+        },\n+        \"/addresses\": {\n+            \"get\": {\n+                \"tags\": [\n+                    \"Default\", \"Fleet\"\n+                ],\n+                \"summary\": \"/addresses\",\n+                \"description\": \"Fetch all addresses/geofences for the organization\",","path":"swagger.json","position":11,"original_position":11,"commit_id":"bad10ca7d22ea9bfe80062bba7de26a70d787911","original_commit_id":"bad10ca7d22ea9bfe80062bba7de26a70d787911","user":{"login":"dsharrison","id":9137905,"node_id":"MDQ6VXNlcjkxMzc5MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9137905?v=4","gravatar_id":"","url":"https://api.github.com/users/dsharrison","html_url":"https://github.com/dsharrison","followers_url":"https://api.github.com/users/dsharrison/followers","following_url":"https://api.github.com/users/dsharrison/following{/other_user}","gists_url":"https://api.github.com/users/dsharrison/gists{/gist_id}","starred_url":"https://api.github.com/users/dsharrison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsharrison/subscriptions","organizations_url":"https://api.github.com/users/dsharrison/orgs","repos_url":"https://api.github.com/users/dsharrison/repos","events_url":"https://api.github.com/users/dsharrison/events{/privacy}","received_events_url":"https://api.github.com/users/dsharrison/received_events","type":"User","site_admin":false},"body":"I agree that addresses/geofences is a bit confusing, but we use this terminology to refer to addresses in the dashboard so customers will likely be expecting this same terminology in the API. I think we should change this to refer to just addresses but will need to change it everywhere, so I propose we have the API docs match the dashboard for now.\r\n\r\ncc @samsarahq/design \r\n","created_at":"2018-10-18T17:48:14Z","updated_at":"2018-10-18T17:48:14Z","html_url":"https://github.com/samsarahq/api-docs/pull/62#discussion_r226403226","pull_request_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/62","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments/226403226"},"html":{"href":"https://github.com/samsarahq/api-docs/pull/62#discussion_r226403226"},"pull_request":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/62"}},"in_reply_to_id":225237028},"pull_request":{"url":"https://api.github.com/repos/samsarahq/api-docs/pulls/62","id":222332354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzMyMzU0","html_url":"https://github.com/samsarahq/api-docs/pull/62","diff_url":"https://github.com/samsarahq/api-docs/pull/62.diff","patch_url":"https://github.com/samsarahq/api-docs/pull/62.patch","issue_url":"https://api.github.com/repos/samsarahq/api-docs/issues/62","number":62,"state":"open","locked":false,"title":"swagger.json: add api docs for addresses CRUD","user":{"login":"ehzhang","id":3484848,"node_id":"MDQ6VXNlcjM0ODQ4NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3484848?v=4","gravatar_id":"","url":"https://api.github.com/users/ehzhang","html_url":"https://github.com/ehzhang","followers_url":"https://api.github.com/users/ehzhang/followers","following_url":"https://api.github.com/users/ehzhang/following{/other_user}","gists_url":"https://api.github.com/users/ehzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/ehzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehzhang/subscriptions","organizations_url":"https://api.github.com/users/ehzhang/orgs","repos_url":"https://api.github.com/users/ehzhang/repos","events_url":"https://api.github.com/users/ehzhang/events{/privacy}","received_events_url":"https://api.github.com/users/ehzhang/received_events","type":"User","site_admin":false},"body":"Here we go!\r\n\r\n![image](https://user-images.githubusercontent.com/3484848/46844548-72cdb700-cd8c-11e8-8a10-4430daf62696.png)\r\n![image](https://user-images.githubusercontent.com/3484848/46844559-7d884c00-cd8c-11e8-9061-662ffac4e98e.png)\r\n![image](https://user-images.githubusercontent.com/3484848/46844569-8711b400-cd8c-11e8-9d7f-32377bd1c8f5.png)\r\n![image](https://user-images.githubusercontent.com/3484848/46844576-91cc4900-cd8c-11e8-9a3d-ba1ace312c90.png)\r\n![image](https://user-images.githubusercontent.com/3484848/46844583-98f35700-cd8c-11e8-8de2-9ea7528ae302.png)","created_at":"2018-10-12T02:34:03Z","updated_at":"2018-10-18T17:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7443bc6725115c13033826052cac884afde1f374","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kelseylam","id":10555857,"node_id":"MDQ6VXNlcjEwNTU1ODU3","avatar_url":"https://avatars0.githubusercontent.com/u/10555857?v=4","gravatar_id":"","url":"https://api.github.com/users/kelseylam","html_url":"https://github.com/kelseylam","followers_url":"https://api.github.com/users/kelseylam/followers","following_url":"https://api.github.com/users/kelseylam/following{/other_user}","gists_url":"https://api.github.com/users/kelseylam/gists{/gist_id}","starred_url":"https://api.github.com/users/kelseylam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelseylam/subscriptions","organizations_url":"https://api.github.com/users/kelseylam/orgs","repos_url":"https://api.github.com/users/kelseylam/repos","events_url":"https://api.github.com/users/kelseylam/events{/privacy}","received_events_url":"https://api.github.com/users/kelseylam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/62/commits","review_comments_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/62/comments","review_comment_url":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/issues/62/comments","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/bad10ca7d22ea9bfe80062bba7de26a70d787911","head":{"label":"samsarahq:ehzhang/addresses-api-docs","ref":"ehzhang/addresses-api-docs","sha":"bad10ca7d22ea9bfe80062bba7de26a70d787911","user":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"repo":{"id":67077150,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NzE1MA==","name":"api-docs","full_name":"samsarahq/api-docs","private":false,"owner":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samsarahq/api-docs","description":null,"fork":false,"url":"https://api.github.com/repos/samsarahq/api-docs","forks_url":"https://api.github.com/repos/samsarahq/api-docs/forks","keys_url":"https://api.github.com/repos/samsarahq/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsarahq/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsarahq/api-docs/teams","hooks_url":"https://api.github.com/repos/samsarahq/api-docs/hooks","issue_events_url":"https://api.github.com/repos/samsarahq/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/samsarahq/api-docs/events","assignees_url":"https://api.github.com/repos/samsarahq/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/samsarahq/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/samsarahq/api-docs/tags","blobs_url":"https://api.github.com/repos/samsarahq/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsarahq/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsarahq/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsarahq/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/samsarahq/api-docs/languages","stargazers_url":"https://api.github.com/repos/samsarahq/api-docs/stargazers","contributors_url":"https://api.github.com/repos/samsarahq/api-docs/contributors","subscribers_url":"https://api.github.com/repos/samsarahq/api-docs/subscribers","subscription_url":"https://api.github.com/repos/samsarahq/api-docs/subscription","commits_url":"https://api.github.com/repos/samsarahq/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsarahq/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsarahq/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsarahq/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/samsarahq/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsarahq/api-docs/merges","archive_url":"https://api.github.com/repos/samsarahq/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsarahq/api-docs/downloads","issues_url":"https://api.github.com/repos/samsarahq/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/samsarahq/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/samsarahq/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/samsarahq/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsarahq/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/samsarahq/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/samsarahq/api-docs/deployments","created_at":"2016-08-31T22:11:01Z","updated_at":"2018-10-12T14:52:29Z","pushed_at":"2018-10-12T02:34:03Z","git_url":"git://github.com/samsarahq/api-docs.git","ssh_url":"git@github.com:samsarahq/api-docs.git","clone_url":"https://github.com/samsarahq/api-docs.git","svn_url":"https://github.com/samsarahq/api-docs","homepage":null,"size":362,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"samsarahq:master","ref":"master","sha":"809a5b7327e1e31c5d31838a22db5c52cc9461a2","user":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"repo":{"id":67077150,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NzE1MA==","name":"api-docs","full_name":"samsarahq/api-docs","private":false,"owner":{"login":"samsarahq","id":14863620,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODYzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/14863620?v=4","gravatar_id":"","url":"https://api.github.com/users/samsarahq","html_url":"https://github.com/samsarahq","followers_url":"https://api.github.com/users/samsarahq/followers","following_url":"https://api.github.com/users/samsarahq/following{/other_user}","gists_url":"https://api.github.com/users/samsarahq/gists{/gist_id}","starred_url":"https://api.github.com/users/samsarahq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsarahq/subscriptions","organizations_url":"https://api.github.com/users/samsarahq/orgs","repos_url":"https://api.github.com/users/samsarahq/repos","events_url":"https://api.github.com/users/samsarahq/events{/privacy}","received_events_url":"https://api.github.com/users/samsarahq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/samsarahq/api-docs","description":null,"fork":false,"url":"https://api.github.com/repos/samsarahq/api-docs","forks_url":"https://api.github.com/repos/samsarahq/api-docs/forks","keys_url":"https://api.github.com/repos/samsarahq/api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsarahq/api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsarahq/api-docs/teams","hooks_url":"https://api.github.com/repos/samsarahq/api-docs/hooks","issue_events_url":"https://api.github.com/repos/samsarahq/api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/samsarahq/api-docs/events","assignees_url":"https://api.github.com/repos/samsarahq/api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/samsarahq/api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/samsarahq/api-docs/tags","blobs_url":"https://api.github.com/repos/samsarahq/api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsarahq/api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsarahq/api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsarahq/api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsarahq/api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/samsarahq/api-docs/languages","stargazers_url":"https://api.github.com/repos/samsarahq/api-docs/stargazers","contributors_url":"https://api.github.com/repos/samsarahq/api-docs/contributors","subscribers_url":"https://api.github.com/repos/samsarahq/api-docs/subscribers","subscription_url":"https://api.github.com/repos/samsarahq/api-docs/subscription","commits_url":"https://api.github.com/repos/samsarahq/api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsarahq/api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsarahq/api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsarahq/api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsarahq/api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/samsarahq/api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsarahq/api-docs/merges","archive_url":"https://api.github.com/repos/samsarahq/api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsarahq/api-docs/downloads","issues_url":"https://api.github.com/repos/samsarahq/api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/samsarahq/api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/samsarahq/api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/samsarahq/api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsarahq/api-docs/labels{/name}","releases_url":"https://api.github.com/repos/samsarahq/api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/samsarahq/api-docs/deployments","created_at":"2016-08-31T22:11:01Z","updated_at":"2018-10-12T14:52:29Z","pushed_at":"2018-10-12T02:34:03Z","git_url":"git://github.com/samsarahq/api-docs.git","ssh_url":"git@github.com:samsarahq/api-docs.git","clone_url":"https://github.com/samsarahq/api-docs.git","svn_url":"https://github.com/samsarahq/api-docs","homepage":null,"size":362,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/62"},"html":{"href":"https://github.com/samsarahq/api-docs/pull/62"},"issue":{"href":"https://api.github.com/repos/samsarahq/api-docs/issues/62"},"comments":{"href":"https://api.github.com/repos/samsarahq/api-docs/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsarahq/api-docs/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/samsarahq/api-docs/statuses/bad10ca7d22ea9bfe80062bba7de26a70d787911"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dsharrison"}}