{"action":"opened","number":14578,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14578","id":178582732,"html_url":"https://github.com/sympy/sympy/pull/14578","diff_url":"https://github.com/sympy/sympy/pull/14578.diff","patch_url":"https://github.com/sympy/sympy/pull/14578.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14578","number":14578,"state":"open","locked":false,"title":"Stats: Corrections to conditions of type `Or`","user":{"login":"akash9712","id":20995294,"avatar_url":"https://avatars3.githubusercontent.com/u/20995294?v=4","gravatar_id":"","url":"https://api.github.com/users/akash9712","html_url":"https://github.com/akash9712","followers_url":"https://api.github.com/users/akash9712/followers","following_url":"https://api.github.com/users/akash9712/following{/other_user}","gists_url":"https://api.github.com/users/akash9712/gists{/gist_id}","starred_url":"https://api.github.com/users/akash9712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash9712/subscriptions","organizations_url":"https://api.github.com/users/akash9712/orgs","repos_url":"https://api.github.com/users/akash9712/repos","events_url":"https://api.github.com/users/akash9712/events{/privacy}","received_events_url":"https://api.github.com/users/akash9712/received_events","type":"User","site_admin":false},"body":"Previously, the domain where conditions of type `Or` were valid was calculated\r\nin a way that resulted in the condition being treated in the same way as\r\n`And`. This PR is to fix this wrong result. Tests for the same have been\r\nadded.\r\n\r\nExamples:\r\n(Before Fix)\r\n```\r\n>>> E = Exponential('E', 1)\r\n>>> P(Or(E < 0, E > 0))\r\n0\r\n>>> P(Or(E > 1, E > 2)) == P(And(E > 1, E > 2))\r\nTrue\r\n```\r\n(After fix)\r\n```\r\n>>> E = Exponential('E', 1)\r\n>>> P(Or(E < 0, E > 0))\r\n1\r\n>>> P(Or(E > 1, E > 2)) == P(E > 1)\r\nTrue\r\n```\r\n\r\n<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\n\r\n\r\n#### Brief description of what is fixed or changed\r\n\r\n\r\n#### Other comments\r\n","created_at":"2018-03-30T15:37:39Z","updated_at":"2018-03-30T15:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d33b0321518b1a6442394a632098eeeb419ad87d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/14578/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/14578/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14578/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/002a7140f55101c9a59f2383226750aa8e63cdc7","head":{"label":"akash9712:stats_where","ref":"stats_where","sha":"002a7140f55101c9a59f2383226750aa8e63cdc7","user":{"login":"akash9712","id":20995294,"avatar_url":"https://avatars3.githubusercontent.com/u/20995294?v=4","gravatar_id":"","url":"https://api.github.com/users/akash9712","html_url":"https://github.com/akash9712","followers_url":"https://api.github.com/users/akash9712/followers","following_url":"https://api.github.com/users/akash9712/following{/other_user}","gists_url":"https://api.github.com/users/akash9712/gists{/gist_id}","starred_url":"https://api.github.com/users/akash9712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash9712/subscriptions","organizations_url":"https://api.github.com/users/akash9712/orgs","repos_url":"https://api.github.com/users/akash9712/repos","events_url":"https://api.github.com/users/akash9712/events{/privacy}","received_events_url":"https://api.github.com/users/akash9712/received_events","type":"User","site_admin":false},"repo":{"id":85571178,"name":"sympy","full_name":"akash9712/sympy","owner":{"login":"akash9712","id":20995294,"avatar_url":"https://avatars3.githubusercontent.com/u/20995294?v=4","gravatar_id":"","url":"https://api.github.com/users/akash9712","html_url":"https://github.com/akash9712","followers_url":"https://api.github.com/users/akash9712/followers","following_url":"https://api.github.com/users/akash9712/following{/other_user}","gists_url":"https://api.github.com/users/akash9712/gists{/gist_id}","starred_url":"https://api.github.com/users/akash9712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akash9712/subscriptions","organizations_url":"https://api.github.com/users/akash9712/orgs","repos_url":"https://api.github.com/users/akash9712/repos","events_url":"https://api.github.com/users/akash9712/events{/privacy}","received_events_url":"https://api.github.com/users/akash9712/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akash9712/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/akash9712/sympy","forks_url":"https://api.github.com/repos/akash9712/sympy/forks","keys_url":"https://api.github.com/repos/akash9712/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akash9712/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akash9712/sympy/teams","hooks_url":"https://api.github.com/repos/akash9712/sympy/hooks","issue_events_url":"https://api.github.com/repos/akash9712/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/akash9712/sympy/events","assignees_url":"https://api.github.com/repos/akash9712/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/akash9712/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/akash9712/sympy/tags","blobs_url":"https://api.github.com/repos/akash9712/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akash9712/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akash9712/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/akash9712/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akash9712/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/akash9712/sympy/languages","stargazers_url":"https://api.github.com/repos/akash9712/sympy/stargazers","contributors_url":"https://api.github.com/repos/akash9712/sympy/contributors","subscribers_url":"https://api.github.com/repos/akash9712/sympy/subscribers","subscription_url":"https://api.github.com/repos/akash9712/sympy/subscription","commits_url":"https://api.github.com/repos/akash9712/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/akash9712/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/akash9712/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/akash9712/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/akash9712/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/akash9712/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akash9712/sympy/merges","archive_url":"https://api.github.com/repos/akash9712/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akash9712/sympy/downloads","issues_url":"https://api.github.com/repos/akash9712/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/akash9712/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/akash9712/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/akash9712/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akash9712/sympy/labels{/name}","releases_url":"https://api.github.com/repos/akash9712/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/akash9712/sympy/deployments","created_at":"2017-03-20T11:53:39Z","updated_at":"2018-03-20T06:13:04Z","pushed_at":"2018-03-30T15:35:26Z","git_url":"git://github.com/akash9712/sympy.git","ssh_url":"git@github.com:akash9712/sympy.git","clone_url":"https://github.com/akash9712/sympy.git","svn_url":"https://github.com/akash9712/sympy","homepage":"http://sympy.org/","size":89563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"a8325303f25273fe0f500902f4b6d8d9bdbb5985","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2018-03-30T07:59:54Z","pushed_at":"2018-03-30T15:37:40Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":89653,"stargazers_count":4738,"watchers_count":4738,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2252,"mirror_url":null,"archived":false,"open_issues_count":3277,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2252,"open_issues":3277,"watchers":4738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14578"},"html":{"href":"https://github.com/sympy/sympy/pull/14578"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/14578"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/14578/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14578/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/14578/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/002a7140f55101c9a59f2383226750aa8e63cdc7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"akash9712"}}