{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/228349858","pull_request_review_id":168604996,"id":228349858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODM0OTg1OA==","diff_hunk":"@@ -46,7 +46,8 @@\n     /**\n      * Return true if this impl is going to be smaller than {@link SinglePackedOrdinals} by at least 20%.\n      */\n-    public static boolean significantlySmallerThanSinglePackedOrdinals(int maxDoc, int numDocsWithValue, long numOrds, float acceptableOverheadRatio) {\n+    public static boolean significantlySmallerThanSinglePackedOrdinals(int maxDoc, int numDocsWithValue, long numOrds,\n+        float acceptableOverheadRatio) {","path":"server/src/main/java/org/elasticsearch/index/fielddata/ordinals/MultiOrdinals.java","position":6,"original_position":6,"commit_id":"0aad1e48588c2c9478374a3569f9eee5bac015eb","original_commit_id":"0aad1e48588c2c9478374a3569f9eee5bac015eb","user":{"login":"nik9000","id":215970,"node_id":"MDQ6VXNlcjIxNTk3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/215970?v=4","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2018-10-25T22:02:45Z","updated_at":"2018-10-25T22:05:28Z","html_url":"https://github.com/elastic/elasticsearch/pull/34891#discussion_r228349858","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/228349858"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/34891#discussion_r228349858"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891","id":225915830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTE1ODMw","html_url":"https://github.com/elastic/elasticsearch/pull/34891","diff_url":"https://github.com/elastic/elasticsearch/pull/34891.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/34891.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/34891","number":34891,"state":"open","locked":false,"title":"Fix LineLength Check Suppressions: index.fielddata","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"* Fix linelength suppressions in index.fielddata\r\n  * Some lines that were too long were dead code => Removed them and all code that became dead because of it\r\n* Relates #34884","created_at":"2018-10-25T21:52:20Z","updated_at":"2018-10-25T22:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03e8c5aca5e20e1212874de90d82c8aff39f81d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144797810,"node_id":"MDU6TGFiZWwxNDQ3OTc4MTA=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Core","name":":Core/Core","color":"0e8a16","default":false},{"id":73544,"node_id":"MDU6TGFiZWw3MzU0NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Enon-issue","name":">non-issue","color":"cfcfcf","default":false},{"id":837440720,"node_id":"MDU6TGFiZWw4Mzc0NDA3MjA=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Erefactoring","name":">refactoring","color":"dddddd","default":false},{"id":1102494662,"node_id":"MDU6TGFiZWwxMTAyNDk0NjYy","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.6.0","name":"v6.6.0","color":"dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/34891/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/0aad1e48588c2c9478374a3569f9eee5bac015eb","head":{"label":"original-brownbear:fielddata-line-lengths","ref":"fielddata-line-lengths","sha":"0aad1e48588c2c9478374a3569f9eee5bac015eb","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":92321292,"node_id":"MDEwOlJlcG9zaXRvcnk5MjMyMTI5Mg==","name":"elasticsearch","full_name":"original-brownbear/elasticsearch","private":false,"owner":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"html_url":"https://github.com/original-brownbear/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/original-brownbear/elasticsearch","forks_url":"https://api.github.com/repos/original-brownbear/elasticsearch/forks","keys_url":"https://api.github.com/repos/original-brownbear/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/elasticsearch/teams","hooks_url":"https://api.github.com/repos/original-brownbear/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/elasticsearch/events","assignees_url":"https://api.github.com/repos/original-brownbear/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/elasticsearch/tags","blobs_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/elasticsearch/subscription","commits_url":"https://api.github.com/repos/original-brownbear/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/elasticsearch/merges","archive_url":"https://api.github.com/repos/original-brownbear/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/elasticsearch/downloads","issues_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/elasticsearch/deployments","created_at":"2017-05-24T18:00:17Z","updated_at":"2017-05-24T18:01:04Z","pushed_at":"2018-10-25T21:51:42Z","git_url":"git://github.com/original-brownbear/elasticsearch.git","ssh_url":"git@github.com:original-brownbear/elasticsearch.git","clone_url":"https://github.com/original-brownbear/elasticsearch.git","svn_url":"https://github.com/original-brownbear/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":488536,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"3cde1356c1f2c9dca23be1ded4627093c0d3477c","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-10-25T21:04:39Z","pushed_at":"2018-10-25T21:52:21Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":522455,"stargazers_count":35554,"watchers_count":35554,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12008,"mirror_url":null,"archived":false,"open_issues_count":1747,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12008,"open_issues":1747,"watchers":35554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/34891"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/34891"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/34891/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/34891/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/0aad1e48588c2c9478374a3569f9eee5bac015eb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nik9000"}}