{"action":"created","comment":{"url":"https://api.github.com/repos/HackYourFuture/React/pulls/comments/175254509","pull_request_review_id":104762707,"id":175254509,"diff_hunk":"@@ -0,0 +1,66 @@\n+import React, { Component } from 'react'\n+\n+import Checkbox from './sub-components/Checkbox';\n+import InputField from './sub-components/InputField'\n+\n+class ListItem extends Component {\n+  // The Worst practice Ever\n+  state = {\n+    edit: false\n+  }\n+  \n+  handleSubmit = (event) => {\n+    const { id } = this.props\n+    event.preventDefault()\n+    this.props.handleUpdateListItem(event, id, 'description', event.target.description.value)","path":"documentation/homework/week3/todo/src/components/ListItem.js","position":15,"original_position":15,"commit_id":"007658ae5b1a44cf26dd6182eed6f2eb64fd9b2d","original_commit_id":"007658ae5b1a44cf26dd6182eed6f2eb64fd9b2d","user":{"login":"isaachinman","id":10575782,"avatar_url":"https://avatars1.githubusercontent.com/u/10575782?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachinman","html_url":"https://github.com/isaachinman","followers_url":"https://api.github.com/users/isaachinman/followers","following_url":"https://api.github.com/users/isaachinman/following{/other_user}","gists_url":"https://api.github.com/users/isaachinman/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachinman/subscriptions","organizations_url":"https://api.github.com/users/isaachinman/orgs","repos_url":"https://api.github.com/users/isaachinman/repos","events_url":"https://api.github.com/users/isaachinman/events{/privacy}","received_events_url":"https://api.github.com/users/isaachinman/received_events","type":"User","site_admin":false},"body":"You are not using controlled inputs! This is not the React way! You are accessing values as form data onSubmit instead of passing a `value` and a `onChange` prop to your input.\r\n\r\nAdditionally, because of this, when I click \"edit\" on a todo item, I see empty text fields instead of the existing values which should be there.\r\n\r\nPlease make these inputs controlled.","created_at":"2018-03-17T10:40:42Z","updated_at":"2018-03-17T10:42:38Z","html_url":"https://github.com/HackYourFuture/React/pull/69#discussion_r175254509","pull_request_url":"https://api.github.com/repos/HackYourFuture/React/pulls/69","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/comments/175254509"},"html":{"href":"https://github.com/HackYourFuture/React/pull/69#discussion_r175254509"},"pull_request":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/HackYourFuture/React/pulls/69","id":175671723,"html_url":"https://github.com/HackYourFuture/React/pull/69","diff_url":"https://github.com/HackYourFuture/React/pull/69.diff","patch_url":"https://github.com/HackYourFuture/React/pull/69.patch","issue_url":"https://api.github.com/repos/HackYourFuture/React/issues/69","number":69,"state":"open","locked":false,"title":"HW 3","user":{"login":"JawharBairakdar","id":25272822,"avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/JawharBairakdar","html_url":"https://github.com/JawharBairakdar","followers_url":"https://api.github.com/users/JawharBairakdar/followers","following_url":"https://api.github.com/users/JawharBairakdar/following{/other_user}","gists_url":"https://api.github.com/users/JawharBairakdar/gists{/gist_id}","starred_url":"https://api.github.com/users/JawharBairakdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JawharBairakdar/subscriptions","organizations_url":"https://api.github.com/users/JawharBairakdar/orgs","repos_url":"https://api.github.com/users/JawharBairakdar/repos","events_url":"https://api.github.com/users/JawharBairakdar/events{/privacy}","received_events_url":"https://api.github.com/users/JawharBairakdar/received_events","type":"User","site_admin":false},"body":"Hi @isaachinman \r\nI am sorry i didn't modify the Change that you request i found it hard to figuering out and i have to practice more so i just did it again.","created_at":"2018-03-17T00:12:10Z","updated_at":"2018-03-17T10:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b21931512c87ede7173afdad726e6fed8fbbebd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HackYourFuture/React/pulls/69/commits","review_comments_url":"https://api.github.com/repos/HackYourFuture/React/pulls/69/comments","review_comment_url":"https://api.github.com/repos/HackYourFuture/React/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HackYourFuture/React/issues/69/comments","statuses_url":"https://api.github.com/repos/HackYourFuture/React/statuses/007658ae5b1a44cf26dd6182eed6f2eb64fd9b2d","head":{"label":"JawharBairakdar:master","ref":"master","sha":"007658ae5b1a44cf26dd6182eed6f2eb64fd9b2d","user":{"login":"JawharBairakdar","id":25272822,"avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/JawharBairakdar","html_url":"https://github.com/JawharBairakdar","followers_url":"https://api.github.com/users/JawharBairakdar/followers","following_url":"https://api.github.com/users/JawharBairakdar/following{/other_user}","gists_url":"https://api.github.com/users/JawharBairakdar/gists{/gist_id}","starred_url":"https://api.github.com/users/JawharBairakdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JawharBairakdar/subscriptions","organizations_url":"https://api.github.com/users/JawharBairakdar/orgs","repos_url":"https://api.github.com/users/JawharBairakdar/repos","events_url":"https://api.github.com/users/JawharBairakdar/events{/privacy}","received_events_url":"https://api.github.com/users/JawharBairakdar/received_events","type":"User","site_admin":false},"repo":{"id":123605306,"name":"React","full_name":"JawharBairakdar/React","owner":{"login":"JawharBairakdar","id":25272822,"avatar_url":"https://avatars0.githubusercontent.com/u/25272822?v=4","gravatar_id":"","url":"https://api.github.com/users/JawharBairakdar","html_url":"https://github.com/JawharBairakdar","followers_url":"https://api.github.com/users/JawharBairakdar/followers","following_url":"https://api.github.com/users/JawharBairakdar/following{/other_user}","gists_url":"https://api.github.com/users/JawharBairakdar/gists{/gist_id}","starred_url":"https://api.github.com/users/JawharBairakdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JawharBairakdar/subscriptions","organizations_url":"https://api.github.com/users/JawharBairakdar/orgs","repos_url":"https://api.github.com/users/JawharBairakdar/repos","events_url":"https://api.github.com/users/JawharBairakdar/events{/privacy}","received_events_url":"https://api.github.com/users/JawharBairakdar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JawharBairakdar/React","description":"Specifications React Module","fork":true,"url":"https://api.github.com/repos/JawharBairakdar/React","forks_url":"https://api.github.com/repos/JawharBairakdar/React/forks","keys_url":"https://api.github.com/repos/JawharBairakdar/React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JawharBairakdar/React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JawharBairakdar/React/teams","hooks_url":"https://api.github.com/repos/JawharBairakdar/React/hooks","issue_events_url":"https://api.github.com/repos/JawharBairakdar/React/issues/events{/number}","events_url":"https://api.github.com/repos/JawharBairakdar/React/events","assignees_url":"https://api.github.com/repos/JawharBairakdar/React/assignees{/user}","branches_url":"https://api.github.com/repos/JawharBairakdar/React/branches{/branch}","tags_url":"https://api.github.com/repos/JawharBairakdar/React/tags","blobs_url":"https://api.github.com/repos/JawharBairakdar/React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JawharBairakdar/React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JawharBairakdar/React/git/refs{/sha}","trees_url":"https://api.github.com/repos/JawharBairakdar/React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JawharBairakdar/React/statuses/{sha}","languages_url":"https://api.github.com/repos/JawharBairakdar/React/languages","stargazers_url":"https://api.github.com/repos/JawharBairakdar/React/stargazers","contributors_url":"https://api.github.com/repos/JawharBairakdar/React/contributors","subscribers_url":"https://api.github.com/repos/JawharBairakdar/React/subscribers","subscription_url":"https://api.github.com/repos/JawharBairakdar/React/subscription","commits_url":"https://api.github.com/repos/JawharBairakdar/React/commits{/sha}","git_commits_url":"https://api.github.com/repos/JawharBairakdar/React/git/commits{/sha}","comments_url":"https://api.github.com/repos/JawharBairakdar/React/comments{/number}","issue_comment_url":"https://api.github.com/repos/JawharBairakdar/React/issues/comments{/number}","contents_url":"https://api.github.com/repos/JawharBairakdar/React/contents/{+path}","compare_url":"https://api.github.com/repos/JawharBairakdar/React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JawharBairakdar/React/merges","archive_url":"https://api.github.com/repos/JawharBairakdar/React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JawharBairakdar/React/downloads","issues_url":"https://api.github.com/repos/JawharBairakdar/React/issues{/number}","pulls_url":"https://api.github.com/repos/JawharBairakdar/React/pulls{/number}","milestones_url":"https://api.github.com/repos/JawharBairakdar/React/milestones{/number}","notifications_url":"https://api.github.com/repos/JawharBairakdar/React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JawharBairakdar/React/labels{/name}","releases_url":"https://api.github.com/repos/JawharBairakdar/React/releases{/id}","deployments_url":"https://api.github.com/repos/JawharBairakdar/React/deployments","created_at":"2018-03-02T16:49:04Z","updated_at":"2018-03-17T03:41:43Z","pushed_at":"2018-03-17T03:41:42Z","git_url":"git://github.com/JawharBairakdar/React.git","ssh_url":"git@github.com:JawharBairakdar/React.git","clone_url":"https://github.com/JawharBairakdar/React.git","svn_url":"https://github.com/JawharBairakdar/React","homepage":null,"size":673,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HackYourFuture:master","ref":"master","sha":"0363475cdb2e5045fd935d3e1e29871b4ab53d03","user":{"login":"HackYourFuture","id":20858568,"avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"repo":{"id":93503545,"name":"React","full_name":"HackYourFuture/React","owner":{"login":"HackYourFuture","id":20858568,"avatar_url":"https://avatars2.githubusercontent.com/u/20858568?v=4","gravatar_id":"","url":"https://api.github.com/users/HackYourFuture","html_url":"https://github.com/HackYourFuture","followers_url":"https://api.github.com/users/HackYourFuture/followers","following_url":"https://api.github.com/users/HackYourFuture/following{/other_user}","gists_url":"https://api.github.com/users/HackYourFuture/gists{/gist_id}","starred_url":"https://api.github.com/users/HackYourFuture/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackYourFuture/subscriptions","organizations_url":"https://api.github.com/users/HackYourFuture/orgs","repos_url":"https://api.github.com/users/HackYourFuture/repos","events_url":"https://api.github.com/users/HackYourFuture/events{/privacy}","received_events_url":"https://api.github.com/users/HackYourFuture/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HackYourFuture/React","description":"Specifications React Module","fork":false,"url":"https://api.github.com/repos/HackYourFuture/React","forks_url":"https://api.github.com/repos/HackYourFuture/React/forks","keys_url":"https://api.github.com/repos/HackYourFuture/React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackYourFuture/React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackYourFuture/React/teams","hooks_url":"https://api.github.com/repos/HackYourFuture/React/hooks","issue_events_url":"https://api.github.com/repos/HackYourFuture/React/issues/events{/number}","events_url":"https://api.github.com/repos/HackYourFuture/React/events","assignees_url":"https://api.github.com/repos/HackYourFuture/React/assignees{/user}","branches_url":"https://api.github.com/repos/HackYourFuture/React/branches{/branch}","tags_url":"https://api.github.com/repos/HackYourFuture/React/tags","blobs_url":"https://api.github.com/repos/HackYourFuture/React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackYourFuture/React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackYourFuture/React/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackYourFuture/React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackYourFuture/React/statuses/{sha}","languages_url":"https://api.github.com/repos/HackYourFuture/React/languages","stargazers_url":"https://api.github.com/repos/HackYourFuture/React/stargazers","contributors_url":"https://api.github.com/repos/HackYourFuture/React/contributors","subscribers_url":"https://api.github.com/repos/HackYourFuture/React/subscribers","subscription_url":"https://api.github.com/repos/HackYourFuture/React/subscription","commits_url":"https://api.github.com/repos/HackYourFuture/React/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackYourFuture/React/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackYourFuture/React/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackYourFuture/React/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackYourFuture/React/contents/{+path}","compare_url":"https://api.github.com/repos/HackYourFuture/React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackYourFuture/React/merges","archive_url":"https://api.github.com/repos/HackYourFuture/React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackYourFuture/React/downloads","issues_url":"https://api.github.com/repos/HackYourFuture/React/issues{/number}","pulls_url":"https://api.github.com/repos/HackYourFuture/React/pulls{/number}","milestones_url":"https://api.github.com/repos/HackYourFuture/React/milestones{/number}","notifications_url":"https://api.github.com/repos/HackYourFuture/React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackYourFuture/React/labels{/name}","releases_url":"https://api.github.com/repos/HackYourFuture/React/releases{/id}","deployments_url":"https://api.github.com/repos/HackYourFuture/React/deployments","created_at":"2017-06-06T09:58:23Z","updated_at":"2018-03-11T13:37:14Z","pushed_at":"2018-03-17T03:41:43Z","git_url":"git://github.com/HackYourFuture/React.git","ssh_url":"git@github.com:HackYourFuture/React.git","clone_url":"https://github.com/HackYourFuture/React.git","svn_url":"https://github.com/HackYourFuture/React","homepage":null,"size":652,"stargazers_count":10,"watchers_count":10,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":40,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/69"},"html":{"href":"https://github.com/HackYourFuture/React/pull/69"},"issue":{"href":"https://api.github.com/repos/HackYourFuture/React/issues/69"},"comments":{"href":"https://api.github.com/repos/HackYourFuture/React/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HackYourFuture/React/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/HackYourFuture/React/statuses/007658ae5b1a44cf26dd6182eed6f2eb64fd9b2d"}},"author_association":"NONE"}}
{"actor":{"display_login":"isaachinman"}}