{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/comments/231633070","pull_request_review_id":172644677,"id":231633070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTYzMzA3MA==","diff_hunk":"@@ -56,10 +56,12 @@ def perform_initial_query!\n \n         def connect_with_retries(path:)\n           response = client.get(path)\n+          raise \"#{response.reason_phrase}: #{response.status}  (#{response.body})\" unless response.success?\n           JSON.parse(response.body)\n         rescue StandardError => exception\n-          logger.warn \"Error fetching #{path}: #{exception.message} (#{exception.class})\"\n-          {}\n+          msg = \"Error fetching #{path}: #{exception.message} (#{exception.class})\"\n+          logger.warn msg\n+          raise msg","path":"lib/rialto/etl/service_client/web_of_science_client.rb","position":11,"original_position":11,"commit_id":"7f387571ed2db373135ef2fe055f7b081430cfc9","original_commit_id":"7f387571ed2db373135ef2fe055f7b081430cfc9","user":{"login":"jcoyne","id":92044,"node_id":"MDQ6VXNlcjkyMDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/92044?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"Why don't we re-raise the original error, so that it's easier to track down the cause?","created_at":"2018-11-07T18:53:21Z","updated_at":"2018-11-07T18:53:21Z","html_url":"https://github.com/sul-dlss/rialto-etl/pull/287#discussion_r231633070","pull_request_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/comments/231633070"},"html":{"href":"https://github.com/sul-dlss/rialto-etl/pull/287#discussion_r231633070"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287","id":229128349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTI4MzQ5","html_url":"https://github.com/sul-dlss/rialto-etl/pull/287","diff_url":"https://github.com/sul-dlss/rialto-etl/pull/287.diff","patch_url":"https://github.com/sul-dlss/rialto-etl/pull/287.patch","issue_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/287","number":287,"state":"open","locked":false,"title":"Log error and not create ndj file when wos extract error occurs.","user":{"login":"justinlittman","id":588335,"node_id":"MDQ6VXNlcjU4ODMzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/588335?v=4","gravatar_id":"","url":"https://api.github.com/users/justinlittman","html_url":"https://github.com/justinlittman","followers_url":"https://api.github.com/users/justinlittman/followers","following_url":"https://api.github.com/users/justinlittman/following{/other_user}","gists_url":"https://api.github.com/users/justinlittman/gists{/gist_id}","starred_url":"https://api.github.com/users/justinlittman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinlittman/subscriptions","organizations_url":"https://api.github.com/users/justinlittman/orgs","repos_url":"https://api.github.com/users/justinlittman/repos","events_url":"https://api.github.com/users/justinlittman/events{/privacy}","received_events_url":"https://api.github.com/users/justinlittman/received_events","type":"User","site_admin":false},"body":"closes #285","created_at":"2018-11-07T18:38:59Z","updated_at":"2018-11-07T18:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c299f673ce11abd79260a5fb9ed372227b88782","assignee":{"login":"justinlittman","id":588335,"node_id":"MDQ6VXNlcjU4ODMzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/588335?v=4","gravatar_id":"","url":"https://api.github.com/users/justinlittman","html_url":"https://github.com/justinlittman","followers_url":"https://api.github.com/users/justinlittman/followers","following_url":"https://api.github.com/users/justinlittman/following{/other_user}","gists_url":"https://api.github.com/users/justinlittman/gists{/gist_id}","starred_url":"https://api.github.com/users/justinlittman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinlittman/subscriptions","organizations_url":"https://api.github.com/users/justinlittman/orgs","repos_url":"https://api.github.com/users/justinlittman/repos","events_url":"https://api.github.com/users/justinlittman/events{/privacy}","received_events_url":"https://api.github.com/users/justinlittman/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinlittman","id":588335,"node_id":"MDQ6VXNlcjU4ODMzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/588335?v=4","gravatar_id":"","url":"https://api.github.com/users/justinlittman","html_url":"https://github.com/justinlittman","followers_url":"https://api.github.com/users/justinlittman/followers","following_url":"https://api.github.com/users/justinlittman/following{/other_user}","gists_url":"https://api.github.com/users/justinlittman/gists{/gist_id}","starred_url":"https://api.github.com/users/justinlittman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinlittman/subscriptions","organizations_url":"https://api.github.com/users/justinlittman/orgs","repos_url":"https://api.github.com/users/justinlittman/repos","events_url":"https://api.github.com/users/justinlittman/events{/privacy}","received_events_url":"https://api.github.com/users/justinlittman/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":935367323,"node_id":"MDU6TGFiZWw5MzUzNjczMjM=","url":"https://api.github.com/repos/sul-dlss/rialto-etl/labels/review","name":"review","color":"ee66ee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/287/comments","statuses_url":"https://api.github.com/repos/sul-dlss/rialto-etl/statuses/7f387571ed2db373135ef2fe055f7b081430cfc9","head":{"label":"sul-dlss:t285-wos_500","ref":"t285-wos_500","sha":"7f387571ed2db373135ef2fe055f7b081430cfc9","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":114801070,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MDEwNzA=","name":"rialto-etl","full_name":"sul-dlss/rialto-etl","private":false,"owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sul-dlss/rialto-etl","description":"ETL tools for RIALTO, Stanford Libraries' research intelligence project","fork":false,"url":"https://api.github.com/repos/sul-dlss/rialto-etl","forks_url":"https://api.github.com/repos/sul-dlss/rialto-etl/forks","keys_url":"https://api.github.com/repos/sul-dlss/rialto-etl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/rialto-etl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/rialto-etl/teams","hooks_url":"https://api.github.com/repos/sul-dlss/rialto-etl/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/rialto-etl/events","assignees_url":"https://api.github.com/repos/sul-dlss/rialto-etl/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/rialto-etl/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/rialto-etl/tags","blobs_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/rialto-etl/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/rialto-etl/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/rialto-etl/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/rialto-etl/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/rialto-etl/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/rialto-etl/subscription","commits_url":"https://api.github.com/repos/sul-dlss/rialto-etl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/rialto-etl/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/rialto-etl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/rialto-etl/merges","archive_url":"https://api.github.com/repos/sul-dlss/rialto-etl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/rialto-etl/downloads","issues_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/rialto-etl/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/rialto-etl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/rialto-etl/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/rialto-etl/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/deployments","created_at":"2017-12-19T19:02:12Z","updated_at":"2018-11-06T15:58:07Z","pushed_at":"2018-11-07T18:39:00Z","git_url":"git://github.com/sul-dlss/rialto-etl.git","ssh_url":"git@github.com:sul-dlss/rialto-etl.git","clone_url":"https://github.com/sul-dlss/rialto-etl.git","svn_url":"https://github.com/sul-dlss/rialto-etl","homepage":"","size":788,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"f18bd8c92c9447c868443dc9ef1b1d71d1bdf991","user":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":114801070,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MDEwNzA=","name":"rialto-etl","full_name":"sul-dlss/rialto-etl","private":false,"owner":{"login":"sul-dlss","id":230583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/230583?v=4","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sul-dlss/rialto-etl","description":"ETL tools for RIALTO, Stanford Libraries' research intelligence project","fork":false,"url":"https://api.github.com/repos/sul-dlss/rialto-etl","forks_url":"https://api.github.com/repos/sul-dlss/rialto-etl/forks","keys_url":"https://api.github.com/repos/sul-dlss/rialto-etl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/rialto-etl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/rialto-etl/teams","hooks_url":"https://api.github.com/repos/sul-dlss/rialto-etl/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/rialto-etl/events","assignees_url":"https://api.github.com/repos/sul-dlss/rialto-etl/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/rialto-etl/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/rialto-etl/tags","blobs_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/rialto-etl/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/rialto-etl/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/rialto-etl/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/rialto-etl/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/rialto-etl/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/rialto-etl/subscription","commits_url":"https://api.github.com/repos/sul-dlss/rialto-etl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/rialto-etl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/rialto-etl/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/rialto-etl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/rialto-etl/merges","archive_url":"https://api.github.com/repos/sul-dlss/rialto-etl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/rialto-etl/downloads","issues_url":"https://api.github.com/repos/sul-dlss/rialto-etl/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/rialto-etl/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/rialto-etl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/rialto-etl/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/rialto-etl/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/rialto-etl/deployments","created_at":"2017-12-19T19:02:12Z","updated_at":"2018-11-06T15:58:07Z","pushed_at":"2018-11-07T18:39:00Z","git_url":"git://github.com/sul-dlss/rialto-etl.git","ssh_url":"git@github.com:sul-dlss/rialto-etl.git","clone_url":"https://github.com/sul-dlss/rialto-etl.git","svn_url":"https://github.com/sul-dlss/rialto-etl","homepage":"","size":788,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287"},"html":{"href":"https://github.com/sul-dlss/rialto-etl/pull/287"},"issue":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/287"},"comments":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/rialto-etl/statuses/7f387571ed2db373135ef2fe055f7b081430cfc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jcoyne"}}