{"action":"created","issue":{"url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/675","repository_url":"https://api.github.com/repos/IsraelHikingMap/Site","labels_url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/675/labels{/name}","comments_url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/675/comments","events_url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/675/events","html_url":"https://github.com/IsraelHikingMap/Site/issues/675","id":313392476,"number":675,"title":"Follow-up for the merge algorithm","user":{"login":"zstadler","id":1304610,"avatar_url":"https://avatars1.githubusercontent.com/u/1304610?v=4","gravatar_id":"","url":"https://api.github.com/users/zstadler","html_url":"https://github.com/zstadler","followers_url":"https://api.github.com/users/zstadler/followers","following_url":"https://api.github.com/users/zstadler/following{/other_user}","gists_url":"https://api.github.com/users/zstadler/gists{/gist_id}","starred_url":"https://api.github.com/users/zstadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zstadler/subscriptions","organizations_url":"https://api.github.com/users/zstadler/orgs","repos_url":"https://api.github.com/users/zstadler/repos","events_url":"https://api.github.com/users/zstadler/events{/privacy}","received_events_url":"https://api.github.com/users/zstadler/received_events","type":"User","site_admin":false},"labels":[{"id":242112941,"url":"https://api.github.com/repos/IsraelHikingMap/Site/labels/Medium","name":"Medium","color":"fbca04","default":false},{"id":235085371,"url":"https://api.github.com/repos/IsraelHikingMap/Site/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"HarelM","id":3269297,"avatar_url":"https://avatars3.githubusercontent.com/u/3269297?v=4","gravatar_id":"","url":"https://api.github.com/users/HarelM","html_url":"https://github.com/HarelM","followers_url":"https://api.github.com/users/HarelM/followers","following_url":"https://api.github.com/users/HarelM/following{/other_user}","gists_url":"https://api.github.com/users/HarelM/gists{/gist_id}","starred_url":"https://api.github.com/users/HarelM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarelM/subscriptions","organizations_url":"https://api.github.com/users/HarelM/orgs","repos_url":"https://api.github.com/users/HarelM/repos","events_url":"https://api.github.com/users/HarelM/events{/privacy}","received_events_url":"https://api.github.com/users/HarelM/received_events","type":"User","site_admin":false},"assignees":[{"login":"HarelM","id":3269297,"avatar_url":"https://avatars3.githubusercontent.com/u/3269297?v=4","gravatar_id":"","url":"https://api.github.com/users/HarelM","html_url":"https://github.com/HarelM","followers_url":"https://api.github.com/users/HarelM/followers","following_url":"https://api.github.com/users/HarelM/following{/other_user}","gists_url":"https://api.github.com/users/HarelM/gists{/gist_id}","starred_url":"https://api.github.com/users/HarelM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarelM/subscriptions","organizations_url":"https://api.github.com/users/HarelM/orgs","repos_url":"https://api.github.com/users/HarelM/repos","events_url":"https://api.github.com/users/HarelM/events{/privacy}","received_events_url":"https://api.github.com/users/HarelM/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-11T16:10:49Z","updated_at":"2018-04-12T22:07:49Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Follow-up for #660 \r\n\r\n- [ ] **iNature and Wikipedia POIs** \r\n  When iNature and Wikipedia POIs are merged, the iNature information and link do not show. For example, [מערת חריטון](https://israelhiking.osm.org.il/#!/?q=מערת+חריטון) does not show [iNature's מערת חריטון](https://inature.info/wiki/%D7%9E%D7%A2%D7%A8%D7%AA_%D7%97%D7%A8%D7%99%D7%98%D7%95%D7%9F)\r\n\r\n  <img width=\"746\" alt=\"2018-04-11 11_26_44-israel hiking map\" src=\"https://user-images.githubusercontent.com/1304610/38616973-6ebdbe5e-3d9e-11e8-863a-d73da3d7aa18.png\">\r\n\r\n  I Also suggest that the side pane will show the hiking-oriented information from iNature rather than the more general information from Wikipedia. Perhaps we should define a global priority list of the information sources.\r\n\r\n- [ ] **Incomplete merge**\r\n  The merge is incomplete when multiple objects exist close to one another. For example, there are [8 nearby nodes named \"צומת פלוגות\"](http://overpass-turbo.eu/s/xNQ). They are merged into at [5 POIs](https://israelhiking.osm.org.il/#!/?s=fIS4CD2Rpx) instead of just one.\r\n\r\n  ![image](https://user-images.githubusercontent.com/1304610/38621160-f068e10e-3da8-11e8-9562-2c7b12336200.png)\r\n\r\n  This is probably because the algorithm is order-dependent. Consider the following POIs, having 80 meter gaps:   \r\n\r\n  ![image](https://user-images.githubusercontent.com/1304610/38624651-4f96a406-3db1-11e8-88d2-4b5c86beb82a.png)   \r\n  If processed in the order of their IDs, the 2nd POI is 160 meters form the 1st POI and will not be merged with it. However, when the 3rd POI is processed, the opportunity to merge all 3 of them can be detected."},"comment":{"url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/comments/380959102","html_url":"https://github.com/IsraelHikingMap/Site/issues/675#issuecomment-380959102","issue_url":"https://api.github.com/repos/IsraelHikingMap/Site/issues/675","id":380959102,"user":{"login":"HarelM","id":3269297,"avatar_url":"https://avatars3.githubusercontent.com/u/3269297?v=4","gravatar_id":"","url":"https://api.github.com/users/HarelM","html_url":"https://github.com/HarelM","followers_url":"https://api.github.com/users/HarelM/followers","following_url":"https://api.github.com/users/HarelM/following{/other_user}","gists_url":"https://api.github.com/users/HarelM/gists{/gist_id}","starred_url":"https://api.github.com/users/HarelM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarelM/subscriptions","organizations_url":"https://api.github.com/users/HarelM/orgs","repos_url":"https://api.github.com/users/HarelM/repos","events_url":"https://api.github.com/users/HarelM/events{/privacy}","received_events_url":"https://api.github.com/users/HarelM/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T22:07:49Z","updated_at":"2018-04-12T22:07:49Z","author_association":"OWNER","body":"I'm looking into צומת פלוגות and it seems that even if I solve the issue above with the order the merge will not take place as the distance between the nodes is more than 100 meters...\r\nI don't fancy the idea of defining threshold per type of point, it will create a complex code that I'll have a hard time debugging and explaining the results, I think..."}}
{"actor":{"display_login":"HarelM"}}