{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/195221278","pull_request_review_id":128545673,"id":195221278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTIyMTI3OA==","diff_hunk":"@@ -448,6 +448,12 @@ Feature Extraction\n   (words or n-grams). :issue:`9147` by :user:`Claes-Fredrik Mannby <mannby>`\n   and `Roman Yurchak`_.\n \n+- Fixed bug in :class:`feature_extraction.text.TFIDFVectorizer` in which the\n+  output of the vectorizer will be defined by the parameter ``dtype``. In","path":"doc/whats_new/v0.20.rst","position":5,"original_position":5,"commit_id":"68996025498434e3a94b9d309e9d4239d50ab5df","original_commit_id":"68996025498434e3a94b9d309e9d4239d50ab5df","user":{"login":"rth","id":630936,"node_id":"MDQ6VXNlcjYzMDkzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"body":"Maybe,\r\n```rst\r\nFixed bug in :class:`feature_extraction.text.TFIDFVectorizer` which \r\nwas ignoring the parameter ``dtype``. \r\n```\r\n?","created_at":"2018-06-13T20:16:46Z","updated_at":"2018-06-13T20:46:06Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10443#discussion_r195221278","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/195221278"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10443#discussion_r195221278"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443","id":162032104,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYyMDMyMTA0","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10443","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10443.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10443.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10443","number":10443,"state":"open","locked":false,"title":"[MRG] FIX TFIDFVectorizer follow parameter dtype and TFIDFTransformer preserve dtype","user":{"login":"maykulkarni","id":4528636,"node_id":"MDQ6VXNlcjQ1Mjg2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4528636?v=4","gravatar_id":"","url":"https://api.github.com/users/maykulkarni","html_url":"https://github.com/maykulkarni","followers_url":"https://api.github.com/users/maykulkarni/followers","following_url":"https://api.github.com/users/maykulkarni/following{/other_user}","gists_url":"https://api.github.com/users/maykulkarni/gists{/gist_id}","starred_url":"https://api.github.com/users/maykulkarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maykulkarni/subscriptions","organizations_url":"https://api.github.com/users/maykulkarni/orgs","repos_url":"https://api.github.com/users/maykulkarni/repos","events_url":"https://api.github.com/users/maykulkarni/events{/privacy}","received_events_url":"https://api.github.com/users/maykulkarni/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\nFixes #10411 #8044\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n- [x] TfidfVectorizer now respects data type\r\n- [x] TfidfVectorizer validates intput and casts if int*\r\n- [x] 2 test cases to check the changes\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-01-10T04:02:32Z","updated_at":"2018-06-13T20:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b45dd39aab2e5a3e2d9d048121d94546bf3c643d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10443/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/68996025498434e3a94b9d309e9d4239d50ab5df","head":{"label":"maykulkarni:TfidfVectorizerFix","ref":"TfidfVectorizerFix","sha":"68996025498434e3a94b9d309e9d4239d50ab5df","user":{"login":"maykulkarni","id":4528636,"node_id":"MDQ6VXNlcjQ1Mjg2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4528636?v=4","gravatar_id":"","url":"https://api.github.com/users/maykulkarni","html_url":"https://github.com/maykulkarni","followers_url":"https://api.github.com/users/maykulkarni/followers","following_url":"https://api.github.com/users/maykulkarni/following{/other_user}","gists_url":"https://api.github.com/users/maykulkarni/gists{/gist_id}","starred_url":"https://api.github.com/users/maykulkarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maykulkarni/subscriptions","organizations_url":"https://api.github.com/users/maykulkarni/orgs","repos_url":"https://api.github.com/users/maykulkarni/repos","events_url":"https://api.github.com/users/maykulkarni/events{/privacy}","received_events_url":"https://api.github.com/users/maykulkarni/received_events","type":"User","site_admin":false},"repo":{"id":114114919,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxMTQ5MTk=","name":"scikit-learn","full_name":"maykulkarni/scikit-learn","owner":{"login":"maykulkarni","id":4528636,"node_id":"MDQ6VXNlcjQ1Mjg2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4528636?v=4","gravatar_id":"","url":"https://api.github.com/users/maykulkarni","html_url":"https://github.com/maykulkarni","followers_url":"https://api.github.com/users/maykulkarni/followers","following_url":"https://api.github.com/users/maykulkarni/following{/other_user}","gists_url":"https://api.github.com/users/maykulkarni/gists{/gist_id}","starred_url":"https://api.github.com/users/maykulkarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maykulkarni/subscriptions","organizations_url":"https://api.github.com/users/maykulkarni/orgs","repos_url":"https://api.github.com/users/maykulkarni/repos","events_url":"https://api.github.com/users/maykulkarni/events{/privacy}","received_events_url":"https://api.github.com/users/maykulkarni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maykulkarni/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/maykulkarni/scikit-learn","forks_url":"https://api.github.com/repos/maykulkarni/scikit-learn/forks","keys_url":"https://api.github.com/repos/maykulkarni/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maykulkarni/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maykulkarni/scikit-learn/teams","hooks_url":"https://api.github.com/repos/maykulkarni/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/maykulkarni/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/maykulkarni/scikit-learn/events","assignees_url":"https://api.github.com/repos/maykulkarni/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/maykulkarni/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/maykulkarni/scikit-learn/tags","blobs_url":"https://api.github.com/repos/maykulkarni/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maykulkarni/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maykulkarni/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/maykulkarni/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maykulkarni/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/maykulkarni/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/maykulkarni/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/maykulkarni/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/maykulkarni/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/maykulkarni/scikit-learn/subscription","commits_url":"https://api.github.com/repos/maykulkarni/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/maykulkarni/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/maykulkarni/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/maykulkarni/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/maykulkarni/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/maykulkarni/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maykulkarni/scikit-learn/merges","archive_url":"https://api.github.com/repos/maykulkarni/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maykulkarni/scikit-learn/downloads","issues_url":"https://api.github.com/repos/maykulkarni/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/maykulkarni/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/maykulkarni/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/maykulkarni/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maykulkarni/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/maykulkarni/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/maykulkarni/scikit-learn/deployments","created_at":"2017-12-13T11:53:33Z","updated_at":"2017-12-13T11:53:41Z","pushed_at":"2018-06-13T12:31:56Z","git_url":"git://github.com/maykulkarni/scikit-learn.git","ssh_url":"git@github.com:maykulkarni/scikit-learn.git","clone_url":"https://github.com/maykulkarni/scikit-learn.git","svn_url":"https://github.com/maykulkarni/scikit-learn","homepage":"http://scikit-learn.org","size":89858,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"48f3303bfc0be26136b98e9aa95dc3b3f916daff","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-06-13T20:45:06Z","pushed_at":"2018-06-13T20:09:49Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":90792,"stargazers_count":28759,"watchers_count":28759,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14273,"mirror_url":null,"archived":false,"open_issues_count":1612,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14273,"open_issues":1612,"watchers":28759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10443"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10443"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10443/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10443/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/68996025498434e3a94b9d309e9d4239d50ab5df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rth"}}