{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/209347237","pull_request_review_id":145351083,"id":209347237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTM0NzIzNw==","diff_hunk":"@@ -48,9 +48,16 @@ ProtoValidationException::ProtoValidationException(const std::string& validation\n   ENVOY_LOG_MISC(debug, \"Proto validation error; throwing {}\", what());\n }\n \n+bool MessageUtil::allow_unknown_fields = false;","path":"source/common/protobuf/utility.cc","position":4,"original_position":4,"commit_id":"7d51f8e75e21351da6ec394a6619f76d407650b0","original_commit_id":"7d51f8e75e21351da6ec394a6619f76d407650b0","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Just for clarity, can we make this an enum with 2 states? Then the function can take the enum value like I mentioned before (and CLI can convert to enum). ","created_at":"2018-08-10T18:25:24Z","updated_at":"2018-08-10T18:26:09Z","html_url":"https://github.com/envoyproxy/envoy/pull/4096#discussion_r209347237","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/209347237"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4096#discussion_r209347237"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096","id":207199958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTk5OTU4","html_url":"https://github.com/envoyproxy/envoy/pull/4096","diff_url":"https://github.com/envoyproxy/envoy/pull/4096.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4096.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4096","number":4096,"state":"open","locked":false,"title":"config: allow unknown fields flag (take 2)","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"body":"*Description*: Add a flag `allow-unknown-fields` that controls whether proto conversion ignores unknown fields. Proto structs are uniformly used for extension configuration. A smaller fix than https://github.com/envoyproxy/envoy/pull/4094.\r\n\r\nThe validation is applied in the following places:\r\n- Any conversion (e.g. xDS payloads)\r\n- Struct conversion (e.g. filter configs)\r\n- bootstrap proto binary\r\n\r\n*Risk Level*: Medium. Allow unknown fields is set to false by default, meaning unknown fields will be rejected by envoy. A missing check for xDS type checking was discovered.\r\n\r\n*Testing*: Unit tests were updated to have it strict by default. Some wrong filter configs were discovered.\r\n\r\n*Docs Changes*: None\r\n\r\n*Release Notes*:\r\nAdd a flag `allow-unknown-fields` to control validation of protobuf configurations for unknown fields.\r\n\r\nFixes #4053 \r\n\r\n/cc @PiotrSikora ","created_at":"2018-08-09T04:50:12Z","updated_at":"2018-08-10T18:26:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f548f6afc862ff0fe8da4d8addcddc24214ee63","assignee":{"login":"zuercher","id":53179,"node_id":"MDQ6VXNlcjUzMTc5","avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},"assignees":[{"login":"zuercher","id":53179,"node_id":"MDQ6VXNlcjUzMTc5","avatar_url":"https://avatars3.githubusercontent.com/u/53179?v=4","gravatar_id":"","url":"https://api.github.com/users/zuercher","html_url":"https://github.com/zuercher","followers_url":"https://api.github.com/users/zuercher/followers","following_url":"https://api.github.com/users/zuercher/following{/other_user}","gists_url":"https://api.github.com/users/zuercher/gists{/gist_id}","starred_url":"https://api.github.com/users/zuercher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuercher/subscriptions","organizations_url":"https://api.github.com/users/zuercher/orgs","repos_url":"https://api.github.com/users/zuercher/repos","events_url":"https://api.github.com/users/zuercher/events{/privacy}","received_events_url":"https://api.github.com/users/zuercher/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"node_id":"MDQ6VXNlcjEwOTE0NzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4096/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/7d51f8e75e21351da6ec394a6619f76d407650b0","head":{"label":"kyessenov:allow_unknown_fields_flag2","ref":"allow_unknown_fields_flag2","sha":"7d51f8e75e21351da6ec394a6619f76d407650b0","user":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"repo":{"id":78710562,"node_id":"MDEwOlJlcG9zaXRvcnk3ODcxMDU2Mg==","name":"envoy","full_name":"kyessenov/envoy","owner":{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyessenov/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/kyessenov/envoy","forks_url":"https://api.github.com/repos/kyessenov/envoy/forks","keys_url":"https://api.github.com/repos/kyessenov/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyessenov/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyessenov/envoy/teams","hooks_url":"https://api.github.com/repos/kyessenov/envoy/hooks","issue_events_url":"https://api.github.com/repos/kyessenov/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/kyessenov/envoy/events","assignees_url":"https://api.github.com/repos/kyessenov/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/kyessenov/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/kyessenov/envoy/tags","blobs_url":"https://api.github.com/repos/kyessenov/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyessenov/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyessenov/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyessenov/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyessenov/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/kyessenov/envoy/languages","stargazers_url":"https://api.github.com/repos/kyessenov/envoy/stargazers","contributors_url":"https://api.github.com/repos/kyessenov/envoy/contributors","subscribers_url":"https://api.github.com/repos/kyessenov/envoy/subscribers","subscription_url":"https://api.github.com/repos/kyessenov/envoy/subscription","commits_url":"https://api.github.com/repos/kyessenov/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyessenov/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyessenov/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyessenov/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyessenov/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/kyessenov/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyessenov/envoy/merges","archive_url":"https://api.github.com/repos/kyessenov/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyessenov/envoy/downloads","issues_url":"https://api.github.com/repos/kyessenov/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/kyessenov/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/kyessenov/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/kyessenov/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyessenov/envoy/labels{/name}","releases_url":"https://api.github.com/repos/kyessenov/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/kyessenov/envoy/deployments","created_at":"2017-01-12T05:05:53Z","updated_at":"2017-01-12T05:05:57Z","pushed_at":"2018-08-10T18:16:42Z","git_url":"git://github.com/kyessenov/envoy.git","ssh_url":"git@github.com:kyessenov/envoy.git","clone_url":"https://github.com/kyessenov/envoy.git","svn_url":"https://github.com/kyessenov/envoy","homepage":"https://lyft.github.io/envoy","size":22156,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"14baa40ea6e3727406a11320d90aa1e435c34925","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-08-10T16:39:14Z","pushed_at":"2018-08-10T18:19:35Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":18796,"stargazers_count":6149,"watchers_count":6149,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":808,"mirror_url":null,"archived":false,"open_issues_count":323,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":808,"open_issues":323,"watchers":6149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4096"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4096"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4096/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4096/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/7d51f8e75e21351da6ec394a6619f76d407650b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattklein123"}}