{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59471","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59471/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59471/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59471/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59471","id":295052927,"number":59471,"title":"Remove method NewCronJobControllerFromClient","user":{"login":"dmathieu","id":9347,"avatar_url":"https://avatars1.githubusercontent.com/u/9347?v=4","gravatar_id":"","url":"https://api.github.com/users/dmathieu","html_url":"https://github.com/dmathieu","followers_url":"https://api.github.com/users/dmathieu/followers","following_url":"https://api.github.com/users/dmathieu/following{/other_user}","gists_url":"https://api.github.com/users/dmathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/dmathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmathieu/subscriptions","organizations_url":"https://api.github.com/users/dmathieu/orgs","repos_url":"https://api.github.com/users/dmathieu/repos","events_url":"https://api.github.com/users/dmathieu/events{/privacy}","received_events_url":"https://api.github.com/users/dmathieu/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":136892195,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/batch","name":"area/batch","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":711852621,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/milestone/needs-approval","name":"milestone/needs-approval","color":"ededed","default":false},{"id":496752236,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-longterm","name":"priority/important-longterm","color":"eb6420","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":404091735,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":15,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-03-21T11:02:15Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2018-02-07T08:52:24Z","updated_at":"2018-03-21T13:24:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59471","html_url":"https://github.com/kubernetes/kubernetes/pull/59471","diff_url":"https://github.com/kubernetes/kubernetes/pull/59471.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59471.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis method was originally introduced when cronjob was still called scheduledjob: https://github.com/kubernetes/kubernetes/commit/7a34347f7f7503dea787c6cb0f27c5e97b1c49d2\r\nBack then, both init methods had different signatures.\r\n\r\nSince the rename to cronjob (https://github.com/kubernetes/kubernetes/commit/41d88d30ddbec0f06bc82bf087a85dfcc030db79), this method is an alias to the normal initializer, have the same signature and is not used anywhere in the codebase.\r\n\r\nSince this method was never actually used for cronjobs, it doesn't seem removing it would need any deprecation notice.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n\r\n```release-note\r\nRemove never used NewCronJobControllerFromClient method\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/374934696","html_url":"https://github.com/kubernetes/kubernetes/pull/59471#issuecomment-374934696","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59471","id":374934696,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T13:24:23Z","updated_at":"2018-03-21T13:24:23Z","author_association":"COLLABORATOR","body":"@dmathieu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-integration | 6bd0a7d6a9c31b16ad2d5aa18f51702ea6393f82 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/59471/pull-kubernetes-integration/2798/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/59471). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/dmathieu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}