{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/206827423","pull_request_review_id":142313073,"id":206827423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjgyNzQyMw==","diff_hunk":"@@ -0,0 +1,75 @@\n+package io.improbable.keanu.algorithms.variational;\n+\n+import io.improbable.keanu.tensor.TensorShape;\n+import io.improbable.keanu.tensor.dbl.DoubleTensor;\n+import io.improbable.keanu.vertices.Vertex;\n+import lombok.RequiredArgsConstructor;\n+import org.apache.commons.math3.optim.SimpleBounds;","path":"keanu-project/src/main/java/io/improbable/keanu/algorithms/variational/BoundsCalculator.java","position":7,"original_position":7,"commit_id":"e4f443b7ce0aa7efff23e85f110d02d81163564c","original_commit_id":"e4f443b7ce0aa7efff23e85f110d02d81163564c","user":{"login":"christophernorth","id":41296447,"node_id":"MDQ6VXNlcjQxMjk2NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/41296447?v=4","gravatar_id":"","url":"https://api.github.com/users/christophernorth","html_url":"https://github.com/christophernorth","followers_url":"https://api.github.com/users/christophernorth/followers","following_url":"https://api.github.com/users/christophernorth/following{/other_user}","gists_url":"https://api.github.com/users/christophernorth/gists{/gist_id}","starred_url":"https://api.github.com/users/christophernorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophernorth/subscriptions","organizations_url":"https://api.github.com/users/christophernorth/orgs","repos_url":"https://api.github.com/users/christophernorth/repos","events_url":"https://api.github.com/users/christophernorth/events{/privacy}","received_events_url":"https://api.github.com/users/christophernorth/received_events","type":"User","site_admin":false},"body":"There was a previous comment mentioning that we shouldn't depend explicitly on this in Keanu - have we decided that it's ok to do that now?","created_at":"2018-08-01T10:20:12Z","updated_at":"2018-08-01T10:30:00Z","html_url":"https://github.com/improbable-research/keanu/pull/145#discussion_r206827423","pull_request_url":"https://api.github.com/repos/improbable-research/keanu/pulls/145","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/206827423"},"html":{"href":"https://github.com/improbable-research/keanu/pull/145#discussion_r206827423"},"pull_request":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/145","id":204888716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODg4NzE2","html_url":"https://github.com/improbable-research/keanu/pull/145","diff_url":"https://github.com/improbable-research/keanu/pull/145.diff","patch_url":"https://github.com/improbable-research/keanu/pull/145.patch","issue_url":"https://api.github.com/repos/improbable-research/keanu/issues/145","number":145,"state":"open","locked":false,"title":"Allow specific bounds for each vertex to be provided to BOBYQA","user":{"login":"rory-improbable","id":33732077,"node_id":"MDQ6VXNlcjMzNzMyMDc3","avatar_url":"https://avatars0.githubusercontent.com/u/33732077?v=4","gravatar_id":"","url":"https://api.github.com/users/rory-improbable","html_url":"https://github.com/rory-improbable","followers_url":"https://api.github.com/users/rory-improbable/followers","following_url":"https://api.github.com/users/rory-improbable/following{/other_user}","gists_url":"https://api.github.com/users/rory-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/rory-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rory-improbable/subscriptions","organizations_url":"https://api.github.com/users/rory-improbable/orgs","repos_url":"https://api.github.com/users/rory-improbable/repos","events_url":"https://api.github.com/users/rory-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/rory-improbable/received_events","type":"User","site_admin":false},"body":"Rather than just providing one bounds number for all the latent vertices passed to the optimizer, this allows you to pass in a map of latent vertices to bounds and therefore gives greater flexibility.\r\n\r\nThe default behaviour is still to pass in boundsRange as normal. If you don't pass in `vertexSpecificBounds` then this will revert to default behaviour","created_at":"2018-07-30T18:21:37Z","updated_at":"2018-08-01T10:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0838af8deae4ebbe759fe893155e8cf4a8d7b5a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GeorgeNash","id":5854544,"node_id":"MDQ6VXNlcjU4NTQ1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5854544?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeNash","html_url":"https://github.com/GeorgeNash","followers_url":"https://api.github.com/users/GeorgeNash/followers","following_url":"https://api.github.com/users/GeorgeNash/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeNash/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeNash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeNash/subscriptions","organizations_url":"https://api.github.com/users/GeorgeNash/orgs","repos_url":"https://api.github.com/users/GeorgeNash/repos","events_url":"https://api.github.com/users/GeorgeNash/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeNash/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-research/keanu/pulls/145/commits","review_comments_url":"https://api.github.com/repos/improbable-research/keanu/pulls/145/comments","review_comment_url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-research/keanu/issues/145/comments","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/e4f443b7ce0aa7efff23e85f110d02d81163564c","head":{"label":"improbable-research:custom-bounds","ref":"custom-bounds","sha":"e4f443b7ce0aa7efff23e85f110d02d81163564c","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-07-31T14:42:58Z","pushed_at":"2018-08-01T09:58:08Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"git@github.com:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3443,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":12,"watchers":75,"default_branch":"develop"}},"base":{"label":"improbable-research:develop","ref":"develop","sha":"ba90f3a1a9ced50b66ee7e244a32d5368c82de51","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-07-31T14:42:58Z","pushed_at":"2018-08-01T09:58:08Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"git@github.com:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3443,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":12,"watchers":75,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/145"},"html":{"href":"https://github.com/improbable-research/keanu/pull/145"},"issue":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/145"},"comments":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-research/keanu/statuses/e4f443b7ce0aa7efff23e85f110d02d81163564c"}},"author_association":"NONE"}}
{"actor":{"display_login":"christophernorth"}}