{"action":"created","issue":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/29","repository_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/29/comments","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/29/events","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/29","id":327706649,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDM0MjIw","number":29,"title":"BASW-122: Change payment plan recurring contribution status when paying installments","user":{"login":"omarabuhussein","id":6275540,"node_id":"MDQ6VXNlcjYyNzU1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6275540?v=4","gravatar_id":"","url":"https://api.github.com/users/omarabuhussein","html_url":"https://github.com/omarabuhussein","followers_url":"https://api.github.com/users/omarabuhussein/followers","following_url":"https://api.github.com/users/omarabuhussein/following{/other_user}","gists_url":"https://api.github.com/users/omarabuhussein/gists{/gist_id}","starred_url":"https://api.github.com/users/omarabuhussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarabuhussein/subscriptions","organizations_url":"https://api.github.com/users/omarabuhussein/orgs","repos_url":"https://api.github.com/users/omarabuhussein/repos","events_url":"https://api.github.com/users/omarabuhussein/events{/privacy}","received_events_url":"https://api.github.com/users/omarabuhussein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-30T12:23:24Z","updated_at":"2018-06-03T20:10:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/29","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/29","diff_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/29.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/29.patch"},"body":"## Before\r\n\r\nWhen paying the first payment plan installment (completely or partially) or when the all the payment plan installments are completed, the recurring contribution status will stay on \"pending\" status.\r\n\r\n![ddsadas](https://user-images.githubusercontent.com/6275540/40720003-3a6907fe-640d-11e8-8f23-9e81a7a3b644.gif)\r\n\r\n\r\n## After\r\n\r\n- When paying the first payment plan installment (completely or partially) , the recurring contribution status will change to \"in progress\".\r\n\r\n- When paying completing all the payment plan installments, the recurring contribution will change to \"Completed\".\r\n\r\n![before](https://user-images.githubusercontent.com/6275540/40720191-d8c2136e-640d-11e8-8d00-a6f38b0a7859.gif)\r\n\r\n\r\n## Other Notes\r\n\r\nThere was a problem where the membership get extended when you finish the last payment, I fixed it in this commit : \r\n\r\nhttps://github.com/compucorp/uk.co.compucorp.membershipextras/commit/3fff6ec4d9d2441d2c15ae9acf9e8617a87ba254\r\n\r\n\r\n\r\n## Limitations\r\n\r\n\r\nCurrently there is a problem with handling \"partial payments\" that emerge from CiviCRM side and hard to be solved currently (without probably some fixes to CiviCRM core) , the problem consist of two parts : \r\n\r\n1- If you paid the **last** installment partially then you completed it, then the recurring contribution status will stay \"in progress\" instead of \"completed\".\r\n\r\n2- If for partially paid any installment (other than the first installment) then completed it, then the membership will get extended when you complete the partially paid installment.\r\n\r\nHere is a gif that demonstrate the two issues : \r\n\r\n![aaaa](https://user-images.githubusercontent.com/6275540/40720457-b63b2f8c-640e-11e8-9762-9b139e0b7eaf.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments/394187848","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/29#issuecomment-394187848","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/29","id":394187848,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDE4Nzg0OA==","user":{"login":"omarabuhussein","id":6275540,"node_id":"MDQ6VXNlcjYyNzU1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6275540?v=4","gravatar_id":"","url":"https://api.github.com/users/omarabuhussein","html_url":"https://github.com/omarabuhussein","followers_url":"https://api.github.com/users/omarabuhussein/followers","following_url":"https://api.github.com/users/omarabuhussein/following{/other_user}","gists_url":"https://api.github.com/users/omarabuhussein/gists{/gist_id}","starred_url":"https://api.github.com/users/omarabuhussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarabuhussein/subscriptions","organizations_url":"https://api.github.com/users/omarabuhussein/orgs","repos_url":"https://api.github.com/users/omarabuhussein/repos","events_url":"https://api.github.com/users/omarabuhussein/events{/privacy}","received_events_url":"https://api.github.com/users/omarabuhussein/received_events","type":"User","site_admin":false},"created_at":"2018-06-03T20:10:08Z","updated_at":"2018-06-03T20:10:08Z","author_association":"MEMBER","body":"@MiyaNoctem \r\n\r\nHey man, thanks for your comments, they made me to rethink my approach again and I opened a new PR that implement this differently, the new PR also fix the first  mentioned limitation in this PR.\r\n\r\nhttps://github.com/compucorp/uk.co.compucorp.membershipextras/\r\n"}}
{"actor":{"display_login":"omarabuhussein"}}