{"action":"created","issue":{"url":"https://api.github.com/repos/OISF/suricata/issues/3344","repository_url":"https://api.github.com/repos/OISF/suricata","labels_url":"https://api.github.com/repos/OISF/suricata/issues/3344/labels{/name}","comments_url":"https://api.github.com/repos/OISF/suricata/issues/3344/comments","events_url":"https://api.github.com/repos/OISF/suricata/issues/3344/events","html_url":"https://github.com/OISF/suricata/pull/3344","id":315380056,"number":3344,"title":"fileinfo: fix IP parameters order in events","user":{"login":"regit","id":308616,"avatar_url":"https://avatars2.githubusercontent.com/u/308616?v=4","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-18T08:28:24Z","updated_at":"2018-04-19T09:12:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OISF/suricata/pulls/3344","html_url":"https://github.com/OISF/suricata/pull/3344","diff_url":"https://github.com/OISF/suricata/pull/3344.diff","patch_url":"https://github.com/OISF/suricata/pull/3344.patch"},"body":"All fileinfo events should have a source IP that is the one sending\r\nthe data and a destination IP that is the receiving part. This was\r\nnot the case as the side information was not contained in the File\r\nstructure.\r\n\r\nThis patch adds a side information to the File allowing the\r\napplication layer to define which side should be considered at\r\nlogging time.\r\n\r\nMake sure these boxes are signed before submitting your Pull Request -- thank you.\r\n\r\n- [x] I have read the contributing guide lines at https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing\r\n- [x] I have signed the Open Information Security Foundation contribution agreement at https://suricata-ids.org/about/contribution-agreement/\r\n- [x] I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)\r\n\r\nLink to [redmine](https://redmine.openinfosecfoundation.org/projects/suricata/issues) ticket: https://redmine.openinfosecfoundation.org/issues/2492\r\n\r\nDescribe changes:\r\n- Add FileSetSide function to set if file is to_client or to_server\r\n- Make SMTP, HTTP and FTP use that API\r\n- Protocols with Rust parser are NOT covered\r\n\r\n[PRScript](https://redmine.openinfosecfoundation.org/projects/suricata/wiki/PRscript) output:\r\n- PR regit: https://buildbot.openinfosecfoundation.org/builders/regit/builds/396\r\n- PR regit-pcap: https://buildbot.openinfosecfoundation.org/builders/regit-pcap/builds/179\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OISF/suricata/issues/comments/382666437","html_url":"https://github.com/OISF/suricata/pull/3344#issuecomment-382666437","issue_url":"https://api.github.com/repos/OISF/suricata/issues/3344","id":382666437,"user":{"login":"regit","id":308616,"avatar_url":"https://avatars2.githubusercontent.com/u/308616?v=4","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T09:12:24Z","updated_at":"2018-04-19T09:12:24Z","author_association":"MEMBER","body":"Do you want to update the API used by JsonFileLogger or do you want to set the flag introduced in the File in a generic way ?"}}
{"actor":{"display_login":"regit"}}