{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/240887405","pull_request_review_id":184018916,"id":240887405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDg4NzQwNQ==","diff_hunk":"@@ -229,12 +230,20 @@ public OperationContext createContext(String scope, String name) {\n     @Override\n     public CompletableFuture<Map<String, StreamConfiguration>> listStreamsInScope(final String scopeName) {\n         return getScope(scopeName).listStreamsInScope().thenCompose(streams -> {\n-            HashMap<String, CompletableFuture<StreamConfiguration>> result = new HashMap<>();\n+            HashMap<String, CompletableFuture<Optional<StreamConfiguration>>> result = new HashMap<>();\n             for (String s : streams) {\n                 Stream stream = getStream(scopeName, s, null);\n-                result.put(stream.getName(), stream.getConfiguration());\n+                result.put(stream.getName(), \n+                        Futures.exceptionallyExpecting(stream.getConfiguration(), \n+                                e -> e instanceof StoreException.DataNotFoundException, ","path":"controller/src/main/java/io/pravega/controller/store/stream/AbstractStreamMetadataStore.java","position":19,"original_position":19,"commit_id":"110cf57fee170cf344e9ca14b9c0470cc1b4851b","original_commit_id":"110cf57fee170cf344e9ca14b9c0470cc1b4851b","user":{"login":"shiveshr","id":13659022,"node_id":"MDQ6VXNlcjEzNjU5MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"body":"If for whatever reason any stream does not have its configuration present, we should not fail listing of all other streams.\r\nPresently the failure could happen for several reasons -- \r\n1. a partially created failed stream with no configuration record created\r\n(presence of such streams currently causes consistent failure to list streams in scope)\r\n2. an on-going stream creation where we have not gotten around to creating its configuration.\r\n(this would be transient and subsequent attempts to list streams in scope should succeed)\r\n3. an ongoing delete stream where configuration metadata is removed but the stream root metadata is not yet cleaned up.\r\n(this is also transient).  \r\n4. metadata corruption leading to configuration being deleted.\r\n(though this is unlikely unless someone goes and messes up the metadata, but any such corruption will render stream unusable for many scenarios. In any case, if we want admin to be able to list such streams and know their status, we should address it in a separate issue).\r\n\r\nThe objective of this issue is to NOT fail listing of streams for the `listStreamsInScope` api for any of these above reasons. And this fix addresses them.\r\n\r\nIf we want to have the ability to list failed/corrupted streams with their corresponding status we should have a separate issue for the same. ","created_at":"2018-12-12T05:38:05Z","updated_at":"2018-12-12T05:38:05Z","html_url":"https://github.com/pravega/pravega/pull/3190#discussion_r240887405","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/3190","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/240887405"},"html":{"href":"https://github.com/pravega/pravega/pull/3190#discussion_r240887405"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3190"}},"in_reply_to_id":240567341},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/3190","id":237553738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTUzNzM4","html_url":"https://github.com/pravega/pravega/pull/3190","diff_url":"https://github.com/pravega/pravega/pull/3190.diff","patch_url":"https://github.com/pravega/pravega/pull/3190.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/3190","number":3190,"state":"open","locked":false,"title":"Issue 1510: List streams in scope throws exception if there is partially created stream with no configuration","user":{"login":"shiveshr","id":13659022,"node_id":"MDQ6VXNlcjEzNjU5MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shivesh Ranjan <shivesh.ranjan@gmail.com>\r\n\r\n**Change log description**  \r\nIf a stream is only partially created, with no configuration created yet (or failed) then `liststreamsinscope` api fails to list streams. \r\n\r\n**Purpose of the change**  \r\nFixes #1510 \r\n\r\n**What the code does**  \r\nIgnores streams for which we get data not found exception while doing getConfiguration. \r\n\r\n**How to verify it**  \r\nUnit test added. ","created_at":"2018-12-11T05:19:44Z","updated_at":"2018-12-12T05:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93d9524135c14ea59c775da908502506c9f8569f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/3190/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/3190/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/3190/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/110cf57fee170cf344e9ca14b9c0470cc1b4851b","head":{"label":"shiveshr:issue1510","ref":"issue1510","sha":"110cf57fee170cf344e9ca14b9c0470cc1b4851b","user":{"login":"shiveshr","id":13659022,"node_id":"MDQ6VXNlcjEzNjU5MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"repo":{"id":92372740,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3Mjc0MA==","name":"pravega-1","full_name":"shiveshr/pravega-1","private":false,"owner":{"login":"shiveshr","id":13659022,"node_id":"MDQ6VXNlcjEzNjU5MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shiveshr/pravega-1","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/shiveshr/pravega-1","forks_url":"https://api.github.com/repos/shiveshr/pravega-1/forks","keys_url":"https://api.github.com/repos/shiveshr/pravega-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shiveshr/pravega-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shiveshr/pravega-1/teams","hooks_url":"https://api.github.com/repos/shiveshr/pravega-1/hooks","issue_events_url":"https://api.github.com/repos/shiveshr/pravega-1/issues/events{/number}","events_url":"https://api.github.com/repos/shiveshr/pravega-1/events","assignees_url":"https://api.github.com/repos/shiveshr/pravega-1/assignees{/user}","branches_url":"https://api.github.com/repos/shiveshr/pravega-1/branches{/branch}","tags_url":"https://api.github.com/repos/shiveshr/pravega-1/tags","blobs_url":"https://api.github.com/repos/shiveshr/pravega-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shiveshr/pravega-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shiveshr/pravega-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/shiveshr/pravega-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shiveshr/pravega-1/statuses/{sha}","languages_url":"https://api.github.com/repos/shiveshr/pravega-1/languages","stargazers_url":"https://api.github.com/repos/shiveshr/pravega-1/stargazers","contributors_url":"https://api.github.com/repos/shiveshr/pravega-1/contributors","subscribers_url":"https://api.github.com/repos/shiveshr/pravega-1/subscribers","subscription_url":"https://api.github.com/repos/shiveshr/pravega-1/subscription","commits_url":"https://api.github.com/repos/shiveshr/pravega-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/shiveshr/pravega-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/shiveshr/pravega-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/shiveshr/pravega-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/shiveshr/pravega-1/contents/{+path}","compare_url":"https://api.github.com/repos/shiveshr/pravega-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shiveshr/pravega-1/merges","archive_url":"https://api.github.com/repos/shiveshr/pravega-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shiveshr/pravega-1/downloads","issues_url":"https://api.github.com/repos/shiveshr/pravega-1/issues{/number}","pulls_url":"https://api.github.com/repos/shiveshr/pravega-1/pulls{/number}","milestones_url":"https://api.github.com/repos/shiveshr/pravega-1/milestones{/number}","notifications_url":"https://api.github.com/repos/shiveshr/pravega-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shiveshr/pravega-1/labels{/name}","releases_url":"https://api.github.com/repos/shiveshr/pravega-1/releases{/id}","deployments_url":"https://api.github.com/repos/shiveshr/pravega-1/deployments","created_at":"2017-05-25T06:31:49Z","updated_at":"2018-12-10T13:50:46Z","pushed_at":"2018-12-11T05:17:43Z","git_url":"git://github.com/shiveshr/pravega-1.git","ssh_url":"git@github.com:shiveshr/pravega-1.git","clone_url":"https://github.com/shiveshr/pravega-1.git","svn_url":"https://github.com/shiveshr/pravega-1","homepage":"http://pravega.io","size":28859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"68e7bf0a163859d7566deeb4318c10b15e8e8540","user":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA5NjgyMg==","name":"pravega","full_name":"pravega/pravega","private":false,"owner":{"login":"pravega","id":25698199,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njk4MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2018-12-11T18:00:12Z","pushed_at":"2018-12-12T02:18:11Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":27197,"stargazers_count":287,"watchers_count":287,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":314,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":92,"open_issues":314,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3190"},"html":{"href":"https://github.com/pravega/pravega/pull/3190"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/3190"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/3190/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3190/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/3190/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/110cf57fee170cf344e9ca14b9c0470cc1b4851b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shiveshr"}}