{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/172769491","pull_request_review_id":101840615,"id":172769491,"diff_hunk":"@@ -35,6 +35,52 @@ sub check_profile {\n       unless ($output =~ /Current active profile: $profile/);\n }\n \n+sub run_developers_tests {\n+    my $devel_repo = 'https://gitlab.suse.de/AngelaBriel/sapconf-test/repository/master/archive.tar.gz';\n+    my $log        = '/tmp/sapconf_test.log';\n+\n+    # Download and unpack the test scripts supplied by the developers\n+    # Record soft failure and continue if it can not be downloaded\n+    my $ret    = script_run \"curl -k $devel_repo > /tmp/sapconf-test.tar.gz\";\n+    my $output = script_output \"file /tmp/sapconf-test.tar.gz\";\n+    unless (defined $ret and $ret == 0 and $output =~ /gzip compressed data/) {","path":"tests/sles4sap/sapconf.pm","position":21,"original_position":21,"commit_id":"a5b219915e2c4454ee791b9667f703380ef6c189","original_commit_id":"a5b219915e2c4454ee791b9667f703380ef6c189","user":{"login":"coolo","id":1067203,"avatar_url":"https://avatars1.githubusercontent.com/u/1067203?v=4","gravatar_id":"","url":"https://api.github.com/users/coolo","html_url":"https://github.com/coolo","followers_url":"https://api.github.com/users/coolo/followers","following_url":"https://api.github.com/users/coolo/following{/other_user}","gists_url":"https://api.github.com/users/coolo/gists{/gist_id}","starred_url":"https://api.github.com/users/coolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolo/subscriptions","organizations_url":"https://api.github.com/users/coolo/orgs","repos_url":"https://api.github.com/users/coolo/repos","events_url":"https://api.github.com/users/coolo/events{/privacy}","received_events_url":"https://api.github.com/users/coolo/received_events","type":"User","site_admin":false},"body":"you can also assert_script_run(\"curl $devel_repo | tar xvf -\"); this will always fail if it fails :)","created_at":"2018-03-07T08:32:55Z","updated_at":"2018-03-07T08:32:56Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564#discussion_r172769491","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/172769491"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564#discussion_r172769491"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564"}},"in_reply_to_id":172759017},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564","id":173241037,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4564","number":4564,"state":"open","locked":false,"title":"Add developer supplied tests to tests/sles4sap/sapconf","user":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"body":"This commits adds into the existing `sles4sap/sapconf` test, the execution of test scripts supplied by the developers which offer a more thorough examination of sapconf profile setting in the target system.\r\n\r\nAlso taking the opportunity to add a couple of comment lines on `sles4sap/saptune` regarding https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4477 to make it clear why the list of saptune solutions is different when the `OFW` variable is set.\r\n\r\n- Related ticket: N/A\r\n- Needles: N/A\r\n- Verification run: http://mango.suse.de/tests/272#step/sapconf/180\r\n","created_at":"2018-03-06T18:20:26Z","updated_at":"2018-03-07T08:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"568f79a8165bf1865eb0bc242e824fa6a2b44131","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4564/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/a5b219915e2c4454ee791b9667f703380ef6c189","head":{"label":"alvarocarvajald:sapconf-devel-test","ref":"sapconf-devel-test","sha":"a5b219915e2c4454ee791b9667f703380ef6c189","user":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"repo":{"id":105257141,"name":"os-autoinst-distri-opensuse","full_name":"alvarocarvajald/os-autoinst-distri-opensuse","owner":{"login":"alvarocarvajald","id":32273286,"avatar_url":"https://avatars2.githubusercontent.com/u/32273286?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarocarvajald","html_url":"https://github.com/alvarocarvajald","followers_url":"https://api.github.com/users/alvarocarvajald/followers","following_url":"https://api.github.com/users/alvarocarvajald/following{/other_user}","gists_url":"https://api.github.com/users/alvarocarvajald/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarocarvajald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarocarvajald/subscriptions","organizations_url":"https://api.github.com/users/alvarocarvajald/orgs","repos_url":"https://api.github.com/users/alvarocarvajald/repos","events_url":"https://api.github.com/users/alvarocarvajald/events{/privacy}","received_events_url":"https://api.github.com/users/alvarocarvajald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/alvarocarvajald/os-autoinst-distri-opensuse/deployments","created_at":"2017-09-29T09:50:15Z","updated_at":"2017-09-29T09:50:19Z","pushed_at":"2018-03-06T18:10:00Z","git_url":"git://github.com/alvarocarvajald/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:alvarocarvajald/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/alvarocarvajald/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":88681,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"8888b57f6d5cba30caa0a5f9546eb15e821c9bd7","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-02-08T00:11:31Z","pushed_at":"2018-03-07T01:04:25Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":88710,"stargazers_count":29,"watchers_count":29,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":119,"open_issues":39,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4564"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4564"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/4564/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/4564/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/a5b219915e2c4454ee791b9667f703380ef6c189"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"coolo"}}