{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/comments/175236662","pull_request_review_id":104743950,"id":175236662,"diff_hunk":"@@ -198,7 +198,7 @@\n             },\n             {\n               \"title\": \"Data Types\",\n-              \"type\": \"google/dlp/v2/datatypes\"\n+              \"type\": \"google/privacy/dlp/v2/datatypes\"","path":"google-cloud/docs/toc.json","position":null,"original_position":5,"commit_id":"6ce4cb0ca26842609a159177237d9426ef415d38","original_commit_id":"6ce4cb0ca26842609a159177237d9426ef415d38","user":{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"body":"I believe `Google::Privacy::Dlp::V2::DataTypes` is generated. All the generated protobuf classes are under `Google::Privacy` instead of `Google::Cloud` because of how it was setup. So AFAIK this is consistent.  ","created_at":"2018-03-16T23:35:29Z","updated_at":"2018-03-16T23:35:29Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009#discussion_r175236662","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/comments/175236662"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009#discussion_r175236662"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009"}},"in_reply_to_id":175233596},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009","id":175576122,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/2009","number":2009,"state":"open","locked":false,"title":"Version and documentation updates for v2 release","user":{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"body":"Follow up for #2005. I went over it once more and found a few things that I missed the first time around needed for a release.\r\n\r\nA few questions for you all:\r\n- Recommendations on the version number for the gem? The API has major changes but it was a beta and is now GA - @geigerj do you have any thoughts on this?\r\n- @blowmage is this the doc update you mentioned last time? Is there a way to test the links or did you mean that I should check after pushing the tag? I believe Jacob mentioned the doc pages are updated by CI when the tag is pushed - is that right?\r\n- Anything else I missed?","created_at":"2018-03-16T16:01:17Z","updated_at":"2018-03-16T23:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ce602b2dcb813951657f69bc596aabd7c23e5b0","assignee":{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166382179,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/2009/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/statuses/6ce4cb0ca26842609a159177237d9426ef415d38","head":{"label":"jbolinger:dlpv2-gem-prep","ref":"dlpv2-gem-prep","sha":"6ce4cb0ca26842609a159177237d9426ef415d38","user":{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"repo":{"id":115045400,"name":"google-cloud-ruby","full_name":"jbolinger/google-cloud-ruby","owner":{"login":"jbolinger","id":4023128,"avatar_url":"https://avatars2.githubusercontent.com/u/4023128?v=4","gravatar_id":"","url":"https://api.github.com/users/jbolinger","html_url":"https://github.com/jbolinger","followers_url":"https://api.github.com/users/jbolinger/followers","following_url":"https://api.github.com/users/jbolinger/following{/other_user}","gists_url":"https://api.github.com/users/jbolinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jbolinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbolinger/subscriptions","organizations_url":"https://api.github.com/users/jbolinger/orgs","repos_url":"https://api.github.com/users/jbolinger/repos","events_url":"https://api.github.com/users/jbolinger/events{/privacy}","received_events_url":"https://api.github.com/users/jbolinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbolinger/google-cloud-ruby","description":"Google Cloud Client Library for Ruby","fork":true,"url":"https://api.github.com/repos/jbolinger/google-cloud-ruby","forks_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/forks","keys_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/teams","hooks_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/hooks","issue_events_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/events","assignees_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/tags","blobs_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/languages","stargazers_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/stargazers","contributors_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/contributors","subscribers_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/subscribers","subscription_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/subscription","commits_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/merges","archive_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/downloads","issues_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jbolinger/google-cloud-ruby/deployments","created_at":"2017-12-21T20:41:57Z","updated_at":"2018-03-16T15:22:42Z","pushed_at":"2018-03-16T22:53:33Z","git_url":"git://github.com/jbolinger/google-cloud-ruby.git","ssh_url":"git@github.com:jbolinger/google-cloud-ruby.git","clone_url":"https://github.com/jbolinger/google-cloud-ruby.git","svn_url":"https://github.com/jbolinger/google-cloud-ruby","homepage":"https://googlecloudplatform.github.io/google-cloud-ruby/","size":30778,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ad91b18181416bb1df9161161c92ccb02aeb4c25","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20343475,"name":"google-cloud-ruby","full_name":"GoogleCloudPlatform/google-cloud-ruby","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby","description":"Google Cloud Client Library for Ruby","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/deployments","created_at":"2014-05-30T21:47:14Z","updated_at":"2018-03-16T01:50:07Z","pushed_at":"2018-03-16T22:53:34Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-ruby.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-ruby.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby","homepage":"https://googlecloudplatform.github.io/google-cloud-ruby/","size":32496,"stargazers_count":467,"watchers_count":467,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":180,"open_issues":35,"watchers":467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/2009"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/2009"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/2009/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/2009/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/statuses/6ce4cb0ca26842609a159177237d9426ef415d38"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbolinger"}}