{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/226802698","pull_request_review_id":166721966,"id":226802698,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjgwMjY5OA==","diff_hunk":"@@ -36,62 +34,41 @@ const (\n \tcmdExecuteTimeout = 1 * time.Minute\n )\n \n-func FinalizeCephCommandArgs(command string, args []string, configDir, clusterName string) (string, []string) {\n-\t// If the command should be run inside the toolbox pod, include the kubectl args to call the toolbox\n-\tif RunAllCephCommandsInToolbox {\n-\t\ttoolArgs := []string{\"-it\", \"exec\", \"rook-ceph-tools\", \"-n\", clusterName, \"--\", command}\n-\t\treturn Kubectl, append(toolArgs, args...)\n-\t}\n-\n-\t// No need to append the args if it's the default ceph cluster\n-\tif clusterName == \"ceph\" && configDir == \"/etc\" {\n-\t\treturn command, args\n-\t}\n-\n-\t// Append the args to find the config and keyring\n-\tconfFile := fmt.Sprintf(\"%s.config\", clusterName)\n-\tkeyringFile := fmt.Sprintf(\"%s.keyring\", AdminUsername)\n-\tconfigArgs := []string{","path":"pkg/daemon/ceph/client/command.go","position":28,"original_position":28,"commit_id":"d256b2fd819a6f01f88fca2f4ff6cb678cf7d828","original_commit_id":"d256b2fd819a6f01f88fca2f4ff6cb678cf7d828","user":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"Yes, I would hope the integration test(s) will catch any issues around this, especially the one that runs two clusters from the same operator. I'll plan on taking this for a spin as well when you're getting closer. ","created_at":"2018-10-19T23:14:07Z","updated_at":"2018-10-19T23:14:07Z","html_url":"https://github.com/rook/rook/pull/2230#discussion_r226802698","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/2230","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/226802698"},"html":{"href":"https://github.com/rook/rook/pull/2230#discussion_r226802698"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/2230"}},"in_reply_to_id":226724494},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2230","id":224098925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDk4OTI1","html_url":"https://github.com/rook/rook/pull/2230","diff_url":"https://github.com/rook/rook/pull/2230.diff","patch_url":"https://github.com/rook/rook/pull/2230.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/2230","number":2230,"state":"open","locked":false,"title":"WIP: Ceph use default config paths","user":{"login":"BlaineEXE","id":3989526,"node_id":"MDQ6VXNlcjM5ODk1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false},"body":"[skip ci]\r\n\r\n**Description of your changes:**\r\n\r\nRefactor ceph to use only default config locations in the container during runtime.\r\n`/etc/ceph/ceph.conf`, `/etc/ceph/keyring`, `/var/lib/ceph`\r\n\r\nAlso establish a consistent to create a data dir for a given daemon.\r\n`/var/lib/ceph/<daemon_type>-<daemon_name>`\r\nexample: `/var/lib/ceph/mds-myfs-c`\r\n\r\nThe locations `'/etc/ceph` and `/var/lib/ceph` can be modified for unit tests to test actual file readwrites to disk without risk of clobbering any real user data at these locations.\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves (partially) #1368\r\n\r\n**Checklist:**\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [ ] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md#comments)\r\n","created_at":"2018-10-18T21:05:14Z","updated_at":"2018-10-19T23:14:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f43de270f4e55e3fc37f6cce1ac70626b0096c6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/2230/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/2230/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/2230/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/d256b2fd819a6f01f88fca2f4ff6cb678cf7d828","head":{"label":"SUSE:ceph-use-default-config-paths","ref":"ceph-use-default-config-paths","sha":"d256b2fd819a6f01f88fca2f4ff6cb678cf7d828","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":116781773,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3ODE3NzM=","name":"rook","full_name":"SUSE/rook","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/SUSE/rook","forks_url":"https://api.github.com/repos/SUSE/rook/forks","keys_url":"https://api.github.com/repos/SUSE/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/rook/teams","hooks_url":"https://api.github.com/repos/SUSE/rook/hooks","issue_events_url":"https://api.github.com/repos/SUSE/rook/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/rook/events","assignees_url":"https://api.github.com/repos/SUSE/rook/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/rook/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/rook/tags","blobs_url":"https://api.github.com/repos/SUSE/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/rook/languages","stargazers_url":"https://api.github.com/repos/SUSE/rook/stargazers","contributors_url":"https://api.github.com/repos/SUSE/rook/contributors","subscribers_url":"https://api.github.com/repos/SUSE/rook/subscribers","subscription_url":"https://api.github.com/repos/SUSE/rook/subscription","commits_url":"https://api.github.com/repos/SUSE/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/rook/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/rook/merges","archive_url":"https://api.github.com/repos/SUSE/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/rook/downloads","issues_url":"https://api.github.com/repos/SUSE/rook/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/rook/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/rook/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/rook/deployments","created_at":"2018-01-09T07:30:45Z","updated_at":"2018-10-18T18:10:53Z","pushed_at":"2018-10-18T21:00:21Z","git_url":"git://github.com/SUSE/rook.git","ssh_url":"git@github.com:SUSE/rook.git","clone_url":"https://github.com/SUSE/rook.git","svn_url":"https://github.com/SUSE/rook","homepage":"https://rook.io","size":6559,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"9ba4fcc45095479bd8313fcbec2b912b30994266","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-10-19T17:52:53Z","pushed_at":"2018-10-19T22:45:27Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":6578,"stargazers_count":3595,"watchers_count":3595,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":233,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":466,"open_issues":233,"watchers":3595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/2230"},"html":{"href":"https://github.com/rook/rook/pull/2230"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/2230"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/2230/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/2230/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/2230/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/d256b2fd819a6f01f88fca2f4ff6cb678cf7d828"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"travisn"}}