{"action":"created","issue":{"url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/1606","repository_url":"https://api.github.com/repos/codeigniter4/CodeIgniter4","labels_url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/1606/labels{/name}","comments_url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/1606/comments","events_url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/1606/events","html_url":"https://github.com/codeigniter4/CodeIgniter4/pull/1606","id":390153922,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTgwMTUw","number":1606,"title":"release framework script clean up","user":{"login":"samsonasik","id":459648,"node_id":"MDQ6VXNlcjQ1OTY0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/459648?v=4","gravatar_id":"","url":"https://api.github.com/users/samsonasik","html_url":"https://github.com/samsonasik","followers_url":"https://api.github.com/users/samsonasik/followers","following_url":"https://api.github.com/users/samsonasik/following{/other_user}","gists_url":"https://api.github.com/users/samsonasik/gists{/gist_id}","starred_url":"https://api.github.com/users/samsonasik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsonasik/subscriptions","organizations_url":"https://api.github.com/users/samsonasik/orgs","repos_url":"https://api.github.com/users/samsonasik/repos","events_url":"https://api.github.com/users/samsonasik/events{/privacy}","received_events_url":"https://api.github.com/users/samsonasik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-12T10:13:34Z","updated_at":"2018-12-12T17:33:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/pulls/1606","html_url":"https://github.com/codeigniter4/CodeIgniter4/pull/1606","diff_url":"https://github.com/codeigniter4/CodeIgniter4/pull/1606.diff","patch_url":"https://github.com/codeigniter4/CodeIgniter4/pull/1606.patch"},"body":"@jim-parry I think the flow before distribute `framework` files as below:\r\n\r\n- clean up `dist/framework/*` with `rm -rf *` to ensure no unneeded old files not removed.\r\n- cp the main directories/files ( system README.md <del>composer.json</del> contributing.md license.txt )\r\n\r\n**Checklist:**\r\n- [x] Securely signed commits\r\n"},"comment":{"url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/comments/446674270","html_url":"https://github.com/codeigniter4/CodeIgniter4/pull/1606#issuecomment-446674270","issue_url":"https://api.github.com/repos/codeigniter4/CodeIgniter4/issues/1606","id":446674270,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjY3NDI3MA==","user":{"login":"jim-parry","id":3203951,"node_id":"MDQ6VXNlcjMyMDM5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3203951?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-parry","html_url":"https://github.com/jim-parry","followers_url":"https://api.github.com/users/jim-parry/followers","following_url":"https://api.github.com/users/jim-parry/following{/other_user}","gists_url":"https://api.github.com/users/jim-parry/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-parry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-parry/subscriptions","organizations_url":"https://api.github.com/users/jim-parry/orgs","repos_url":"https://api.github.com/users/jim-parry/repos","events_url":"https://api.github.com/users/jim-parry/events{/privacy}","received_events_url":"https://api.github.com/users/jim-parry/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T17:33:21Z","updated_at":"2018-12-12T17:33:21Z","author_association":"COLLABORATOR","body":".gitattributres should be neither here nor there. I took the approach of only copying in what should be part of the framework download, rather than copying most/all of it and then excluding with .gitattributes. trying to keep things simple.\r\nWhat would .gitattributes add?"}}
{"actor":{"display_login":"jim-parry"}}