{"action":"closed","number":490,"pull_request":{"url":"https://api.github.com/repos/dotnet/source-build/pulls/490","id":185089635,"html_url":"https://github.com/dotnet/source-build/pull/490","diff_url":"https://github.com/dotnet/source-build/pull/490.diff","patch_url":"https://github.com/dotnet/source-build/pull/490.patch","issue_url":"https://api.github.com/repos/dotnet/source-build/issues/490","number":490,"state":"closed","locked":false,"title":"Force corefx to build identity and runtime packages","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"@dseefeld this should fix the issue you are seeing with corefx not publishing packages.\r\n\r\nLooks like when we tried to fix the corefx/coreclr package builds we based it off the wrong property.\r\n\r\nhttps://github.com/dotnet/corefx/pull/28607\r\nhttps://github.com/dotnet/coreclr/pull/17323\r\n\r\nIn those PR's we based it on DotNetBuildOffline but that is only set in the tarball not the source-build. We should instead update corefx and coreclr to use DotNetBuildFromSource for these conditions. I will submit a PR to change them. \r\n\r\nNote that I'm only workaround the corefx in this PR because we don't actually use the identity packages from coreclr in our other builds. \r\n","created_at":"2018-04-30T23:25:20Z","updated_at":"2018-05-01T19:34:58Z","closed_at":"2018-05-01T19:34:57Z","merged_at":"2018-05-01T19:34:57Z","merge_commit_sha":"182a2b8aa59575c1188916e66a3c407ef88d99d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/source-build/pulls/490/commits","review_comments_url":"https://api.github.com/repos/dotnet/source-build/pulls/490/comments","review_comment_url":"https://api.github.com/repos/dotnet/source-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/source-build/issues/490/comments","statuses_url":"https://api.github.com/repos/dotnet/source-build/statuses/6a09421929afbfe2fdce522e3d12a000073ad402","head":{"label":"weshaggard:CorefxPackageBuildWorkaround","ref":"CorefxPackageBuildWorkaround","sha":"6a09421929afbfe2fdce522e3d12a000073ad402","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":101937924,"name":"source-build","full_name":"weshaggard/source-build","owner":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weshaggard/source-build","description":"A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components","fork":true,"url":"https://api.github.com/repos/weshaggard/source-build","forks_url":"https://api.github.com/repos/weshaggard/source-build/forks","keys_url":"https://api.github.com/repos/weshaggard/source-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/source-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/source-build/teams","hooks_url":"https://api.github.com/repos/weshaggard/source-build/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/source-build/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/source-build/events","assignees_url":"https://api.github.com/repos/weshaggard/source-build/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/source-build/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/source-build/tags","blobs_url":"https://api.github.com/repos/weshaggard/source-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/source-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/source-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/source-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/source-build/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/source-build/languages","stargazers_url":"https://api.github.com/repos/weshaggard/source-build/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/source-build/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/source-build/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/source-build/subscription","commits_url":"https://api.github.com/repos/weshaggard/source-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/source-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/source-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/source-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/source-build/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/source-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/source-build/merges","archive_url":"https://api.github.com/repos/weshaggard/source-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/source-build/downloads","issues_url":"https://api.github.com/repos/weshaggard/source-build/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/source-build/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/source-build/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/source-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/source-build/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/source-build/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/source-build/deployments","created_at":"2017-08-30T23:27:03Z","updated_at":"2017-08-30T23:27:07Z","pushed_at":"2018-04-30T23:21:39Z","git_url":"git://github.com/weshaggard/source-build.git","ssh_url":"git@github.com:weshaggard/source-build.git","clone_url":"https://github.com/weshaggard/source-build.git","svn_url":"https://github.com/weshaggard/source-build","homepage":"","size":1904,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/release/2.1","ref":"dev/release/2.1","sha":"ef3251b83ee6e1339e2e74e9bb7b1bd9b214d852","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":65490742,"name":"source-build","full_name":"dotnet/source-build","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/source-build","description":"A repository to track efforts to produce a source tarball of the .NET Core SDK and all its components","fork":false,"url":"https://api.github.com/repos/dotnet/source-build","forks_url":"https://api.github.com/repos/dotnet/source-build/forks","keys_url":"https://api.github.com/repos/dotnet/source-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/source-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/source-build/teams","hooks_url":"https://api.github.com/repos/dotnet/source-build/hooks","issue_events_url":"https://api.github.com/repos/dotnet/source-build/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/source-build/events","assignees_url":"https://api.github.com/repos/dotnet/source-build/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/source-build/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/source-build/tags","blobs_url":"https://api.github.com/repos/dotnet/source-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/source-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/source-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/source-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/source-build/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/source-build/languages","stargazers_url":"https://api.github.com/repos/dotnet/source-build/stargazers","contributors_url":"https://api.github.com/repos/dotnet/source-build/contributors","subscribers_url":"https://api.github.com/repos/dotnet/source-build/subscribers","subscription_url":"https://api.github.com/repos/dotnet/source-build/subscription","commits_url":"https://api.github.com/repos/dotnet/source-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/source-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/source-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/source-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/source-build/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/source-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/source-build/merges","archive_url":"https://api.github.com/repos/dotnet/source-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/source-build/downloads","issues_url":"https://api.github.com/repos/dotnet/source-build/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/source-build/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/source-build/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/source-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/source-build/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/source-build/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/source-build/deployments","created_at":"2016-08-11T18:03:56Z","updated_at":"2018-05-01T19:33:39Z","pushed_at":"2018-05-01T19:34:57Z","git_url":"git://github.com/dotnet/source-build.git","ssh_url":"git@github.com:dotnet/source-build.git","clone_url":"https://github.com/dotnet/source-build.git","svn_url":"https://github.com/dotnet/source-build","homepage":"","size":1922,"stargazers_count":24,"watchers_count":24,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":40,"open_issues":86,"watchers":24,"default_branch":"dev/release/2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/source-build/pulls/490"},"html":{"href":"https://github.com/dotnet/source-build/pull/490"},"issue":{"href":"https://api.github.com/repos/dotnet/source-build/issues/490"},"comments":{"href":"https://api.github.com/repos/dotnet/source-build/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/source-build/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/source-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/source-build/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/source-build/statuses/6a09421929afbfe2fdce522e3d12a000073ad402"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"weshaggard"}}