{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50927","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50927/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50927/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50927/events","html_url":"https://github.com/NixOS/nixpkgs/pull/50927","id":383652628,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDcwNTgw","number":50927,"title":"mutt/neomutt: work around S/MIME issues with `application/pgp-encrypted`","user":{"login":"Ma27","id":6025220,"node_id":"MDQ6VXNlcjYwMjUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6025220?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-11-22T20:46:00Z","updated_at":"2018-11-27T22:18:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/50927","html_url":"https://github.com/NixOS/nixpkgs/pull/50927","diff_url":"https://github.com/NixOS/nixpkgs/pull/50927.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/50927.patch"},"body":"###### Motivation for this change\r\n\r\nThe original issue can be reproduced when sending with an unpatched\r\n`mutt` or `neomutt` an email with an attachement which as han `.asc`\r\nextension. This will be interpreted as `application/pgp-encrypted` which\r\nexperiences special logic, in the end the attachement will contain\r\n\"Version: 1\"[1][2][3]\r\n\r\nRight now, there are the following issues in the {,neo}mutt packages:\r\n\r\n* `mutt.override { smimeSupport = true }` fails to build since the\r\n  Debian patch results in a 404. Debian moved their packages to\r\n  `salsa.debian.org`.\r\n\r\n  However we can't use a versioned URL for this as Debian only tracks\r\n  the Mutt versions that are available in their releases. The patch\r\n  doesn't touch Mutt's core and is therefore simple to rebase, so\r\n  sticking to the 1.10.2 patch for now should be sufficient.\r\n\r\n* The original issue was never fixed in NeoMutt, currently we use the\r\n  S/MIME database from `pkgs.mime-types` which contains the issue with\r\n  `application/pgp-encrypted` as well.\r\n\r\n  It seems as it's more reliable to use the default `neomutt` database\r\n  for now which lives in `doc/mime.types` and place it into `PKGDATADIR`\r\n  ($out/share/neomutt).\r\n\r\n[1] https://bugs.archlinux.org/task/43319\r\n[2] https://bugs.gentoo.org/534658\r\n[3] https://github.com/neomutt/neomutt/blob/neomutt-20180716/sendlib.c#L490-L496\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/442239288","html_url":"https://github.com/NixOS/nixpkgs/pull/50927#issuecomment-442239288","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/50927","id":442239288,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjIzOTI4OA==","user":{"login":"c0bw3b","id":24417923,"node_id":"MDQ6VXNlcjI0NDE3OTIz","avatar_url":"https://avatars1.githubusercontent.com/u/24417923?v=4","gravatar_id":"","url":"https://api.github.com/users/c0bw3b","html_url":"https://github.com/c0bw3b","followers_url":"https://api.github.com/users/c0bw3b/followers","following_url":"https://api.github.com/users/c0bw3b/following{/other_user}","gists_url":"https://api.github.com/users/c0bw3b/gists{/gist_id}","starred_url":"https://api.github.com/users/c0bw3b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0bw3b/subscriptions","organizations_url":"https://api.github.com/users/c0bw3b/orgs","repos_url":"https://api.github.com/users/c0bw3b/repos","events_url":"https://api.github.com/users/c0bw3b/events{/privacy}","received_events_url":"https://api.github.com/users/c0bw3b/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T22:18:05Z","updated_at":"2018-11-27T22:18:05Z","author_association":"CONTRIBUTOR","body":"( so I edited my message to correct a typo and it duplicated ofBorg jobs... that's dangerous :p )\r\n\r\nLGTM"}}
{"actor":{"display_login":"c0bw3b"}}