{"action":"created","comment":{"url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments/214984607","pull_request_review_id":152152278,"id":214984607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDk4NDYwNw==","diff_hunk":"@@ -1,21 +1,28 @@\n-export default (environment = 'development') => ({ // eslint-disable-line\n-\n+/**\n+ * @file\n+ * Article-level configuration.\n+ *\n+ * @TODO Please ensure this file is filled out before publishing!!!\n+ */\n+\n+export default (environment = 'development') => ({\n   // link file UUID\n-  id: '$UUID',\n+  id: environment === 'development' ? '3a499586-b2e0-11e4-a058-00144feab7de' : '$URL',\n \n   // canonical URL of the published page\n   // \"$URL\" get filled in by the ./configure script\n-  url: '$URL',\n+  url: 'http://local.ft.com:8080',\n \n   // To set an exact publish date do this:\n   //       new Date('2016-05-17T17:11:22Z')\n-  publishedDate: new Date(),\n+  publishedDate: new Date().toISOString().replace(/:\\d{2}\\.\\d{3}Z$/i, ''),","path":"config/article.js","position":23,"original_position":23,"commit_id":"4458c8b4e616b37781599dfefbd9be124b0288b5","original_commit_id":"2466db314023fe6ae2ab0bfe766b6e19e7911842","user":{"login":"aendrew","id":185041,"node_id":"MDQ6VXNlcjE4NTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/185041?v=4","gravatar_id":"","url":"https://api.github.com/users/aendrew","html_url":"https://github.com/aendrew","followers_url":"https://api.github.com/users/aendrew/followers","following_url":"https://api.github.com/users/aendrew/following{/other_user}","gists_url":"https://api.github.com/users/aendrew/gists{/gist_id}","starred_url":"https://api.github.com/users/aendrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aendrew/subscriptions","organizations_url":"https://api.github.com/users/aendrew/orgs","repos_url":"https://api.github.com/users/aendrew/repos","events_url":"https://api.github.com/users/aendrew/events{/privacy}","received_events_url":"https://api.github.com/users/aendrew/received_events","type":"User","site_admin":false},"body":"Yeah, you're not wrong. I think this just strips off seconds to prevent mismatch hydration errors.","created_at":"2018-09-04T16:34:59Z","updated_at":"2018-09-04T16:34:59Z","html_url":"https://github.com/ft-interactive/starter-kit/pull/204#discussion_r214984607","pull_request_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments/214984607"},"html":{"href":"https://github.com/ft-interactive/starter-kit/pull/204#discussion_r214984607"},"pull_request":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204"}},"in_reply_to_id":213997400},"pull_request":{"url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204","id":205190596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTkwNTk2","html_url":"https://github.com/ft-interactive/starter-kit/pull/204","diff_url":"https://github.com/ft-interactive/starter-kit/pull/204.diff","patch_url":"https://github.com/ft-interactive/starter-kit/pull/204.patch","issue_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/204","number":204,"state":"open","locked":false,"title":"V2 [work-in-progress]","user":{"login":"aendrew","id":185041,"node_id":"MDQ6VXNlcjE4NTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/185041?v=4","gravatar_id":"","url":"https://api.github.com/users/aendrew","html_url":"https://github.com/aendrew","followers_url":"https://api.github.com/users/aendrew/followers","following_url":"https://api.github.com/users/aendrew/following{/other_user}","gists_url":"https://api.github.com/users/aendrew/gists{/gist_id}","starred_url":"https://api.github.com/users/aendrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aendrew/subscriptions","organizations_url":"https://api.github.com/users/aendrew/orgs","repos_url":"https://api.github.com/users/aendrew/repos","events_url":"https://api.github.com/users/aendrew/events{/privacy}","received_events_url":"https://api.github.com/users/aendrew/received_events","type":"User","site_admin":false},"body":"Okay, lots of stuff\tgoing on here.\r\n\r\n- `views/` has been totally replaced by [@financial-times/g-components][1]\r\n- Nunjucks is dead, long live React SSR!\r\n  - In practice, this means that `server/index.js` does the first pass of rendering the page. Once the client loads the bundle, it re-hydrates with possibly updated state or whatever else.\r\n- I've always hated the Orwell copytext because it way too closely resembles English (and, quite frankly, I find that particular essay to be Orwell at his worst and most pretentious). I've thus replaced it with Lorem Ipsum text in Esperanto and with a boatload of olde English diacritic marks.\r\n- `client/` now has two JS files by default — the Webpack entry point (`index.js`) and the root `<App>` component (`app.js`). Would love to simplify this more, not sure if it's possible. Mostly you won't ever have to do anything in `index.js`.\r\n- The main text blob is now in `client/app.js`. Currently you can't use Markdown, though that isn't overly difficult to add.\r\n- It dawns on me I've not really surfaced `client/components/core/top.css`. I may just minify it and put it statically in the `<HtmlHead>` element of `g-components`. Doesn't seem to have broken anything, though?\r\n- Worth noting that anything that Origami does on page load might be overwritten by the React client-side rehydration process (which is why `<Comments>` is a PureComponent and not a stateless component). It's generally better to initialise Origami stuff in `componentDidMount()`, unless the issue I was running into merely was due to `o-comments` not loading without a title attribute (in which case some better error logging would be nice...). See source for [<Comments>][2].\r\n- There are probably some bits around it that are a touch broken (particularly, inline elements need a nbsp of format `{' '}` in JSX to separate them from the next word when in, say, a paragraph). Please fix these as you notice them and push your fixes to this branch, thanks.\r\n- I've not tested a prod build of any of this stuff yet. It's rather likely the Webpack config will need some tweaking.\r\n- Deps bumped to Babel 7 and Webpack 4. N.b., this is inconsistent with `g-components` because the latter needs Webpack 3 for Storybook to build properly.\r\n\r\n[1]: https://github.com/Financial-Times/g-components\r\n[2]: https://github.com/Financial-Times/g-components/blob/master/components/comments.js","created_at":"2018-07-31T17:42:59Z","updated_at":"2018-09-04T16:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bced102438511e4a18f2e75c362e7caf71bb289a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204/commits","review_comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204/comments","review_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/204/comments","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/4458c8b4e616b37781599dfefbd9be124b0288b5","head":{"label":"ft-interactive:v2","ref":"v2","sha":"4458c8b4e616b37781599dfefbd9be124b0288b5","user":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"repo":{"id":44748522,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc0ODUyMg==","name":"starter-kit","full_name":"ft-interactive/starter-kit","owner":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ft-interactive/starter-kit","description":"A template for Financial Times responsive and interactive graphics projects","fork":false,"url":"https://api.github.com/repos/ft-interactive/starter-kit","forks_url":"https://api.github.com/repos/ft-interactive/starter-kit/forks","keys_url":"https://api.github.com/repos/ft-interactive/starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ft-interactive/starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ft-interactive/starter-kit/teams","hooks_url":"https://api.github.com/repos/ft-interactive/starter-kit/hooks","issue_events_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/ft-interactive/starter-kit/events","assignees_url":"https://api.github.com/repos/ft-interactive/starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/ft-interactive/starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/tags","blobs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/ft-interactive/starter-kit/languages","stargazers_url":"https://api.github.com/repos/ft-interactive/starter-kit/stargazers","contributors_url":"https://api.github.com/repos/ft-interactive/starter-kit/contributors","subscribers_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscribers","subscription_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscription","commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ft-interactive/starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/ft-interactive/starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ft-interactive/starter-kit/merges","archive_url":"https://api.github.com/repos/ft-interactive/starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ft-interactive/starter-kit/downloads","issues_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/ft-interactive/starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/ft-interactive/starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ft-interactive/starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/ft-interactive/starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/ft-interactive/starter-kit/deployments","created_at":"2015-10-22T13:54:04Z","updated_at":"2018-07-11T17:41:43Z","pushed_at":"2018-09-04T16:32:38Z","git_url":"git://github.com/ft-interactive/starter-kit.git","ssh_url":"git@github.com:ft-interactive/starter-kit.git","clone_url":"https://github.com/ft-interactive/starter-kit.git","svn_url":"https://github.com/ft-interactive/starter-kit","homepage":"","size":2399,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":10,"open_issues":22,"watchers":34,"default_branch":"master"}},"base":{"label":"ft-interactive:master","ref":"master","sha":"de55dfcaa706fa8bac67ac8ed754a1c340f89c49","user":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"repo":{"id":44748522,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc0ODUyMg==","name":"starter-kit","full_name":"ft-interactive/starter-kit","owner":{"login":"ft-interactive","id":2511089,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTEwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/2511089?v=4","gravatar_id":"","url":"https://api.github.com/users/ft-interactive","html_url":"https://github.com/ft-interactive","followers_url":"https://api.github.com/users/ft-interactive/followers","following_url":"https://api.github.com/users/ft-interactive/following{/other_user}","gists_url":"https://api.github.com/users/ft-interactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ft-interactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ft-interactive/subscriptions","organizations_url":"https://api.github.com/users/ft-interactive/orgs","repos_url":"https://api.github.com/users/ft-interactive/repos","events_url":"https://api.github.com/users/ft-interactive/events{/privacy}","received_events_url":"https://api.github.com/users/ft-interactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ft-interactive/starter-kit","description":"A template for Financial Times responsive and interactive graphics projects","fork":false,"url":"https://api.github.com/repos/ft-interactive/starter-kit","forks_url":"https://api.github.com/repos/ft-interactive/starter-kit/forks","keys_url":"https://api.github.com/repos/ft-interactive/starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ft-interactive/starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ft-interactive/starter-kit/teams","hooks_url":"https://api.github.com/repos/ft-interactive/starter-kit/hooks","issue_events_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/ft-interactive/starter-kit/events","assignees_url":"https://api.github.com/repos/ft-interactive/starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/ft-interactive/starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/tags","blobs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/ft-interactive/starter-kit/languages","stargazers_url":"https://api.github.com/repos/ft-interactive/starter-kit/stargazers","contributors_url":"https://api.github.com/repos/ft-interactive/starter-kit/contributors","subscribers_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscribers","subscription_url":"https://api.github.com/repos/ft-interactive/starter-kit/subscription","commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ft-interactive/starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ft-interactive/starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ft-interactive/starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/ft-interactive/starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ft-interactive/starter-kit/merges","archive_url":"https://api.github.com/repos/ft-interactive/starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ft-interactive/starter-kit/downloads","issues_url":"https://api.github.com/repos/ft-interactive/starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/ft-interactive/starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/ft-interactive/starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/ft-interactive/starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ft-interactive/starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/ft-interactive/starter-kit/releases{/id}","deployments_url":"https://api.github.com/repos/ft-interactive/starter-kit/deployments","created_at":"2015-10-22T13:54:04Z","updated_at":"2018-07-11T17:41:43Z","pushed_at":"2018-09-04T16:32:38Z","git_url":"git://github.com/ft-interactive/starter-kit.git","ssh_url":"git@github.com:ft-interactive/starter-kit.git","clone_url":"https://github.com/ft-interactive/starter-kit.git","svn_url":"https://github.com/ft-interactive/starter-kit","homepage":"","size":2399,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":22,"license":null,"forks":10,"open_issues":22,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204"},"html":{"href":"https://github.com/ft-interactive/starter-kit/pull/204"},"issue":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/issues/204"},"comments":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/ft-interactive/starter-kit/statuses/4458c8b4e616b37781599dfefbd9be124b0288b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aendrew"}}