{"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/comments/193827048","pull_request_review_id":126879372,"id":193827048,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzgyNzA0OA==","diff_hunk":"@@ -302,34 +313,57 @@ virtualenv:\n \t@echo\n \t# Note: We pass --no-download flag to make sure version of pip which we install (9.0.1) is used\n \t# instead of latest version being downloaded from PyPi\n-\ttest -f $(VIRTUALENV_DIR)/bin/activate || virtualenv --python=$(PYTHON_VERSION) --no-site-packages $(VIRTUALENV_DIR) --no-download\n-\n-\t# Setup PYTHONPATH in bash activate script...\n-\t# Delete existing entries (if any)\n-\tsed -i '/_OLD_PYTHONPATHp/d' $(VIRTUALENV_DIR)/bin/activate\n-\tsed -i '/PYTHONPATH=/d' $(VIRTUALENV_DIR)/bin/activate\n-\tsed -i '/export PYTHONPATH/d' $(VIRTUALENV_DIR)/bin/activate\n-\n-\techo '_OLD_PYTHONPATH=$$PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate\n-\t#echo 'PYTHONPATH=$$_OLD_PYTHONPATH:$(COMPONENT_PYTHONPATH)' >> $(VIRTUALENV_DIR)/bin/activate\n-\techo 'PYTHONPATH=${ROOT_DIR}:$(COMPONENT_PYTHONPATH)' >> $(VIRTUALENV_DIR)/bin/activate\n-\techo 'export PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate\n-\ttouch $(VIRTUALENV_DIR)/bin/activate\n-\n-\t# Setup PYTHONPATH in fish activate script...\n-\t#echo '' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo 'set -gx _OLD_PYTHONPATH $$PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo 'set -gx PYTHONPATH $$_OLD_PYTHONPATH $(COMPONENT_PYTHONPATH)' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo 'functions -c deactivate old_deactivate' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo 'function deactivate' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '  if test -n $$_OLD_PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '    set -gx PYTHONPATH $$_OLD_PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '    set -e _OLD_PYTHONPATH' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '  end' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '  old_deactivate' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo '  functions -e old_deactivate' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#echo 'end' >> $(VIRTUALENV_DIR)/bin/activate.fish\n-\t#touch $(VIRTUALENV_DIR)/bin/activate.fish\n+\t# For OS X, we have to bootstrap install pip because otherwise it runs into\n+\t# SSLv1 errors when connecting to https://pypi.python.org/simple/ to\n+\t# download anything\n+\t@if [[ \"$(OS)\" == \"Darwin\" ]]; then \\\n+\t    if [[ ! -f $(VIRTUALENV_DIR)/bin/activate ]]; then \\\n+\t        virtualenv --python=$(PYTHON_VERSION) --no-site-packages --no-setuptools --never-download $(VIRTUALENV_DIR); \\","path":"Makefile","position":67,"original_position":67,"commit_id":"7171608a92d936220e37fbb07d822a9122b3b5e3","original_commit_id":"7171608a92d936220e37fbb07d822a9122b3b5e3","user":{"login":"lakshmi-kannan","id":1839421,"node_id":"MDQ6VXNlcjE4Mzk0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839421?v=4","gravatar_id":"","url":"https://api.github.com/users/lakshmi-kannan","html_url":"https://github.com/lakshmi-kannan","followers_url":"https://api.github.com/users/lakshmi-kannan/followers","following_url":"https://api.github.com/users/lakshmi-kannan/following{/other_user}","gists_url":"https://api.github.com/users/lakshmi-kannan/gists{/gist_id}","starred_url":"https://api.github.com/users/lakshmi-kannan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lakshmi-kannan/subscriptions","organizations_url":"https://api.github.com/users/lakshmi-kannan/orgs","repos_url":"https://api.github.com/users/lakshmi-kannan/repos","events_url":"https://api.github.com/users/lakshmi-kannan/events{/privacy}","received_events_url":"https://api.github.com/users/lakshmi-kannan/received_events","type":"User","site_admin":false},"body":"I'd install pip first and then virtualenv because stock OS X doesn't come with neither. We can also assume people have pip and virtualenv installed in which case you should just check if they exist and if not ask user to install those. ","created_at":"2018-06-07T17:22:12Z","updated_at":"2018-06-07T17:22:12Z","html_url":"https://github.com/StackStorm/st2/pull/4145#discussion_r193827048","pull_request_url":"https://api.github.com/repos/StackStorm/st2/pulls/4145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments/193827048"},"html":{"href":"https://github.com/StackStorm/st2/pull/4145#discussion_r193827048"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4145"}}},"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/4145","id":190427748,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDI3NzQ4","html_url":"https://github.com/StackStorm/st2/pull/4145","diff_url":"https://github.com/StackStorm/st2/pull/4145.diff","patch_url":"https://github.com/StackStorm/st2/pull/4145.patch","issue_url":"https://api.github.com/repos/StackStorm/st2/issues/4145","number":4145,"state":"open","locked":false,"title":"Fix mac install","user":{"login":"blag","id":597113,"node_id":"MDQ6VXNlcjU5NzExMw==","avatar_url":"https://avatars0.githubusercontent.com/u/597113?v=4","gravatar_id":"","url":"https://api.github.com/users/blag","html_url":"https://github.com/blag","followers_url":"https://api.github.com/users/blag/followers","following_url":"https://api.github.com/users/blag/following{/other_user}","gists_url":"https://api.github.com/users/blag/gists{/gist_id}","starred_url":"https://api.github.com/users/blag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blag/subscriptions","organizations_url":"https://api.github.com/users/blag/orgs","repos_url":"https://api.github.com/users/blag/repos","events_url":"https://api.github.com/users/blag/events{/privacy}","received_events_url":"https://api.github.com/users/blag/received_events","type":"User","site_admin":false},"body":"Fixes some things on Mac by creating a separate virtualenv in `virtualenv-osx`, so you can run stuff in a (Linux) docker container and still do stuff in OS X.\r\n\r\n~~I will try to include a fix for #3934 by implementing #3785 before this PR is ready.~~ Done.\r\n\r\n~~Also (for now) includes the additional logging from #4141.~~\r\n\r\nReviewers: please check the changes to the relative virtualenv path in `tools/launchdev.sh`, as I'm not 100% sure where that command is supposed to be run from. This PR changes the virtualenv to the `virtualenv` directory at the root of the repo, because that's what makes the most sense to me.\r\n\r\n~~Also, my implementation in `tail.py` works, but I'm not sure if it's the most optimal threading model.~~\r\nFixed. It now uses `eventlet` greenthreads and a greenpool.","created_at":"2018-05-24T21:39:27Z","updated_at":"2018-06-07T17:22:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e90745c0891654a70a389145976ac3561f4409","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm/st2/pulls/4145/commits","review_comments_url":"https://api.github.com/repos/StackStorm/st2/pulls/4145/comments","review_comment_url":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/st2/issues/4145/comments","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/7171608a92d936220e37fbb07d822a9122b3b5e3","head":{"label":"StackStorm:fix-mac-install","ref":"fix-mac-install","sha":"7171608a92d936220e37fbb07d822a9122b3b5e3","user":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":19051806,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA1MTgwNg==","name":"st2","full_name":"StackStorm/st2","owner":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2","description":"StackStorm (aka \"IFTTT for Ops\") is event-driven automation for auto-remediation, security responses, troubleshooting, deployments, and more. Includes rules engine, workflow, 2000+ integrations (see https://exchange.stackstorm.org), ChatOps, etc. Installer at https://docs.stackstorm.com/install/index.html. Questions? https://forum.stackstorm.com/.","fork":false,"url":"https://api.github.com/repos/StackStorm/st2","forks_url":"https://api.github.com/repos/StackStorm/st2/forks","keys_url":"https://api.github.com/repos/StackStorm/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2/events","assignees_url":"https://api.github.com/repos/StackStorm/st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2/merges","archive_url":"https://api.github.com/repos/StackStorm/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2/deployments","created_at":"2014-04-23T00:51:34Z","updated_at":"2018-06-07T13:58:45Z","pushed_at":"2018-06-07T12:45:12Z","git_url":"git://github.com/StackStorm/st2.git","ssh_url":"git@github.com:StackStorm/st2.git","clone_url":"https://github.com/StackStorm/st2.git","svn_url":"https://github.com/StackStorm/st2","homepage":"http://www.stackstorm.com/","size":24072,"stargazers_count":2650,"watchers_count":2650,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":342,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":348,"open_issues":342,"watchers":2650,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"9a560d2d5b6a354f8b3a405b48722a54f47458c0","user":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":19051806,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA1MTgwNg==","name":"st2","full_name":"StackStorm/st2","owner":{"login":"StackStorm","id":4969009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5NjkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4969009?v=4","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2","description":"StackStorm (aka \"IFTTT for Ops\") is event-driven automation for auto-remediation, security responses, troubleshooting, deployments, and more. Includes rules engine, workflow, 2000+ integrations (see https://exchange.stackstorm.org), ChatOps, etc. Installer at https://docs.stackstorm.com/install/index.html. Questions? https://forum.stackstorm.com/.","fork":false,"url":"https://api.github.com/repos/StackStorm/st2","forks_url":"https://api.github.com/repos/StackStorm/st2/forks","keys_url":"https://api.github.com/repos/StackStorm/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2/events","assignees_url":"https://api.github.com/repos/StackStorm/st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2/merges","archive_url":"https://api.github.com/repos/StackStorm/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2/releases{/id}","deployments_url":"https://api.github.com/repos/StackStorm/st2/deployments","created_at":"2014-04-23T00:51:34Z","updated_at":"2018-06-07T13:58:45Z","pushed_at":"2018-06-07T12:45:12Z","git_url":"git://github.com/StackStorm/st2.git","ssh_url":"git@github.com:StackStorm/st2.git","clone_url":"https://github.com/StackStorm/st2.git","svn_url":"https://github.com/StackStorm/st2","homepage":"http://www.stackstorm.com/","size":24072,"stargazers_count":2650,"watchers_count":2650,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":342,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":348,"open_issues":342,"watchers":2650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4145"},"html":{"href":"https://github.com/StackStorm/st2/pull/4145"},"issue":{"href":"https://api.github.com/repos/StackStorm/st2/issues/4145"},"comments":{"href":"https://api.github.com/repos/StackStorm/st2/issues/4145/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4145/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/4145/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/st2/statuses/7171608a92d936220e37fbb07d822a9122b3b5e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lakshmi-kannan"}}