{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/229541029","pull_request_review_id":170065372,"id":229541029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTU0MTAyOQ==","diff_hunk":"@@ -24,19 +37,19 @@ export default class InternalModelMap {\n    * @param id {String}\n    * @return {InternalModel}\n    */\n-  get(id) {\n+  get(id: string): InternalModel|undefined {\n     return this._idToModel[id];\n   }\n \n-  has(id) {\n+  has(id: string): boolean {\n     return !!this._idToModel[id];\n   }\n \n-  get length() {\n+  get length(): number {","path":"addon/-private/system/internal-model-map.ts","position":44,"original_position":44,"commit_id":"6013d716db144429d7bb4a2c3d798710c995fb78","original_commit_id":"6013d716db144429d7bb4a2c3d798710c995fb78","user":{"login":"mike-north","id":558005,"node_id":"MDQ6VXNlcjU1ODAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"body":"If you want to use tslint to enforce explicit return types, the rule looks like\r\n\r\n```json\r\n\"rules\": {\r\n  \"typedef\": [true, \"call-signature\"]\r\n}\r\n```","created_at":"2018-10-31T01:37:55Z","updated_at":"2018-10-31T01:37:55Z","html_url":"https://github.com/emberjs/data/pull/5727#discussion_r229541029","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/5727","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/229541029"},"html":{"href":"https://github.com/emberjs/data/pull/5727#discussion_r229541029"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/5727"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/5727","id":227123278,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTIzMjc4","html_url":"https://github.com/emberjs/data/pull/5727","diff_url":"https://github.com/emberjs/data/pull/5727.diff","patch_url":"https://github.com/emberjs/data/pull/5727.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/5727","number":5727,"state":"open","locked":false,"title":"[CHORE ts] A couple of dabblings to start us down the road","user":{"login":"runspired","id":650309,"node_id":"MDQ6VXNlcjY1MDMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/650309?v=4","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"body":"// ... please delete this default text after reading\r\n\r\nIf this is your first PR to `ember-data`, you may want to read our [Contributor Guide](https://github.com/emberjs/data/blob/master/CONTRIBUTING.md).\r\n","created_at":"2018-10-31T00:26:34Z","updated_at":"2018-10-31T01:37:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceae7a35ec319aa493f81963854799675306935f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/5727/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/5727/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/5727/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/6013d716db144429d7bb4a2c3d798710c995fb78","head":{"label":"emberjs:ts-work","ref":"ts-work","sha":"6013d716db144429d7bb4a2c3d798710c995fb78","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"node_id":"MDEwOlJlcG9zaXRvcnkzMDE2NTYy","name":"data","full_name":"emberjs/data","private":false,"owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2018-10-30T23:07:46Z","pushed_at":"2018-10-31T01:23:11Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":16948,"stargazers_count":2895,"watchers_count":2895,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1242,"open_issues":144,"watchers":2895,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"7c721dd29e541624fe8144d19ff8a0150ccbd36a","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"node_id":"MDEwOlJlcG9zaXRvcnkzMDE2NTYy","name":"data","full_name":"emberjs/data","private":false,"owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2018-10-30T23:07:46Z","pushed_at":"2018-10-31T01:23:11Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":16948,"stargazers_count":2895,"watchers_count":2895,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1242,"open_issues":144,"watchers":2895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/5727"},"html":{"href":"https://github.com/emberjs/data/pull/5727"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/5727"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/5727/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/5727/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/5727/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/6013d716db144429d7bb4a2c3d798710c995fb78"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mike-north"}}