{"action":"created","comment":{"url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments/178512048","pull_request_review_id":108577205,"id":178512048,"diff_hunk":"@@ -53,6 +53,16 @@ def _to_designspace_source(self, master, is_regular):\n             # FIXME: (jany) have this function not write the dot\n             build_ufo_path('.', source.familyName, source.styleName))\n \n+        # Make sure UFO filenames are unique, lest we overwrite masters that\n+        # happen to have the same weight name.\n+        if any(s != source and s.filename == source.filename","path":"Lib/glyphsLib/builder/sources.py","position":6,"original_position":6,"commit_id":"35daa5278a3b481c7f9477c2e131782f86692181","original_commit_id":"35daa5278a3b481c7f9477c2e131782f86692181","user":{"login":"madig","id":380829,"avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"body":"`s` is the same type as `source`, both are in the same list. I'm filtering out the element in question while looking at all other elements in the list. Will try `is not` :)","created_at":"2018-04-02T09:04:40Z","updated_at":"2018-04-02T09:04:40Z","html_url":"https://github.com/googlei18n/glyphsLib/pull/335#discussion_r178512048","pull_request_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments/178512048"},"html":{"href":"https://github.com/googlei18n/glyphsLib/pull/335#discussion_r178512048"},"pull_request":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335"}},"in_reply_to_id":178510159},"pull_request":{"url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335","id":177512297,"html_url":"https://github.com/googlei18n/glyphsLib/pull/335","diff_url":"https://github.com/googlei18n/glyphsLib/pull/335.diff","patch_url":"https://github.com/googlei18n/glyphsLib/pull/335.patch","issue_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/335","number":335,"state":"open","locked":false,"title":"Make to target UFOs filenames unique if masters have the same style name","user":{"login":"madig","id":380829,"avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"body":"Found this when a colleague made a six master glyphs file, where Glyphs provides just five different weight names; he just made the two boldest ones \"Bold\". Before, we would  overwrite the first with the second.","created_at":"2018-03-26T17:17:13Z","updated_at":"2018-04-02T09:04:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a4920a9b33964676d9f5c2ae9a72876fadafd92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335/commits","review_comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335/comments","review_comment_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/335/comments","statuses_url":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/35daa5278a3b481c7f9477c2e131782f86692181","head":{"label":"madig:unique-ufo-filenames-if-same-style","ref":"unique-ufo-filenames-if-same-style","sha":"35daa5278a3b481c7f9477c2e131782f86692181","user":{"login":"madig","id":380829,"avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"repo":{"id":110568729,"name":"glyphsLib","full_name":"madig/glyphsLib","owner":{"login":"madig","id":380829,"avatar_url":"https://avatars1.githubusercontent.com/u/380829?v=4","gravatar_id":"","url":"https://api.github.com/users/madig","html_url":"https://github.com/madig","followers_url":"https://api.github.com/users/madig/followers","following_url":"https://api.github.com/users/madig/following{/other_user}","gists_url":"https://api.github.com/users/madig/gists{/gist_id}","starred_url":"https://api.github.com/users/madig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madig/subscriptions","organizations_url":"https://api.github.com/users/madig/orgs","repos_url":"https://api.github.com/users/madig/repos","events_url":"https://api.github.com/users/madig/events{/privacy}","received_events_url":"https://api.github.com/users/madig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madig/glyphsLib","description":"A bridge from Glyphs source files (.glyphs) to UFOs","fork":true,"url":"https://api.github.com/repos/madig/glyphsLib","forks_url":"https://api.github.com/repos/madig/glyphsLib/forks","keys_url":"https://api.github.com/repos/madig/glyphsLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madig/glyphsLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madig/glyphsLib/teams","hooks_url":"https://api.github.com/repos/madig/glyphsLib/hooks","issue_events_url":"https://api.github.com/repos/madig/glyphsLib/issues/events{/number}","events_url":"https://api.github.com/repos/madig/glyphsLib/events","assignees_url":"https://api.github.com/repos/madig/glyphsLib/assignees{/user}","branches_url":"https://api.github.com/repos/madig/glyphsLib/branches{/branch}","tags_url":"https://api.github.com/repos/madig/glyphsLib/tags","blobs_url":"https://api.github.com/repos/madig/glyphsLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madig/glyphsLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madig/glyphsLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/madig/glyphsLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madig/glyphsLib/statuses/{sha}","languages_url":"https://api.github.com/repos/madig/glyphsLib/languages","stargazers_url":"https://api.github.com/repos/madig/glyphsLib/stargazers","contributors_url":"https://api.github.com/repos/madig/glyphsLib/contributors","subscribers_url":"https://api.github.com/repos/madig/glyphsLib/subscribers","subscription_url":"https://api.github.com/repos/madig/glyphsLib/subscription","commits_url":"https://api.github.com/repos/madig/glyphsLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/madig/glyphsLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/madig/glyphsLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/madig/glyphsLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/madig/glyphsLib/contents/{+path}","compare_url":"https://api.github.com/repos/madig/glyphsLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madig/glyphsLib/merges","archive_url":"https://api.github.com/repos/madig/glyphsLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madig/glyphsLib/downloads","issues_url":"https://api.github.com/repos/madig/glyphsLib/issues{/number}","pulls_url":"https://api.github.com/repos/madig/glyphsLib/pulls{/number}","milestones_url":"https://api.github.com/repos/madig/glyphsLib/milestones{/number}","notifications_url":"https://api.github.com/repos/madig/glyphsLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madig/glyphsLib/labels{/name}","releases_url":"https://api.github.com/repos/madig/glyphsLib/releases{/id}","deployments_url":"https://api.github.com/repos/madig/glyphsLib/deployments","created_at":"2017-11-13T15:54:01Z","updated_at":"2018-03-26T17:14:57Z","pushed_at":"2018-03-28T15:03:19Z","git_url":"git://github.com/madig/glyphsLib.git","ssh_url":"git@github.com:madig/glyphsLib.git","clone_url":"https://github.com/madig/glyphsLib.git","svn_url":"https://github.com/madig/glyphsLib","homepage":"","size":3138,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:master","ref":"master","sha":"5133a43a2c8652633935525f27c98059fdbc71a2","user":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars3.githubusercontent.com/u/5503833?v=4","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":44563779,"name":"glyphsLib","full_name":"googlei18n/glyphsLib","owner":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars3.githubusercontent.com/u/5503833?v=4","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlei18n/glyphsLib","description":"A bridge from Glyphs source files (.glyphs) to UFOs","fork":false,"url":"https://api.github.com/repos/googlei18n/glyphsLib","forks_url":"https://api.github.com/repos/googlei18n/glyphsLib/forks","keys_url":"https://api.github.com/repos/googlei18n/glyphsLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/glyphsLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/glyphsLib/teams","hooks_url":"https://api.github.com/repos/googlei18n/glyphsLib/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/glyphsLib/events","assignees_url":"https://api.github.com/repos/googlei18n/glyphsLib/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/glyphsLib/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/glyphsLib/tags","blobs_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/glyphsLib/languages","stargazers_url":"https://api.github.com/repos/googlei18n/glyphsLib/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/glyphsLib/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/glyphsLib/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/glyphsLib/subscription","commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/glyphsLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/glyphsLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/glyphsLib/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/glyphsLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/glyphsLib/merges","archive_url":"https://api.github.com/repos/googlei18n/glyphsLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/glyphsLib/downloads","issues_url":"https://api.github.com/repos/googlei18n/glyphsLib/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/glyphsLib/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/glyphsLib/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/glyphsLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/glyphsLib/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/glyphsLib/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/glyphsLib/deployments","created_at":"2015-10-19T21:00:22Z","updated_at":"2018-03-31T15:57:24Z","pushed_at":"2018-03-31T15:57:22Z","git_url":"git://github.com/googlei18n/glyphsLib.git","ssh_url":"git@github.com:googlei18n/glyphsLib.git","clone_url":"https://github.com/googlei18n/glyphsLib.git","svn_url":"https://github.com/googlei18n/glyphsLib","homepage":"","size":3238,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":26,"open_issues":42,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335"},"html":{"href":"https://github.com/googlei18n/glyphsLib/pull/335"},"issue":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/issues/335"},"comments":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/glyphsLib/statuses/35daa5278a3b481c7f9477c2e131782f86692181"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"madig"}}