{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/comments/230803275","pull_request_review_id":171623038,"id":230803275,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDgwMzI3NQ==","diff_hunk":"@@ -16,5 +16,6 @@\n         \"warningLevel\"\n       ]\n     }\n-  ]\n+  ],\n+  \"attributes\":[\"sleepTime\",\"warningLevel\"]","path":"test/subscriptions/subscriptionRequest.json","position":6,"original_position":6,"commit_id":"fb639e1db5173e9a904308da6fc2ba7615943a66","original_commit_id":"fb639e1db5173e9a904308da6fc2ba7615943a66","user":{"login":"fgalan","id":1534240,"node_id":"MDQ6VXNlcjE1MzQyNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1534240?v=4","gravatar_id":"","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"Why this change was needed? Were test not passing without the change?","created_at":"2018-11-05T15:54:46Z","updated_at":"2018-11-05T15:54:47Z","html_url":"https://github.com/telefonicaid/iotagent-json/pull/339#discussion_r230803275","pull_request_url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/comments/230803275"},"html":{"href":"https://github.com/telefonicaid/iotagent-json/pull/339#discussion_r230803275"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339","id":226319660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzE5NjYw","html_url":"https://github.com/telefonicaid/iotagent-json/pull/339","diff_url":"https://github.com/telefonicaid/iotagent-json/pull/339.diff","patch_url":"https://github.com/telefonicaid/iotagent-json/pull/339.patch","issue_url":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/339","number":339,"state":"open","locked":false,"title":"Updates dependencies and supports Node.js v8","user":{"login":"dcalvoalonso","id":11388886,"node_id":"MDQ6VXNlcjExMzg4ODg2","avatar_url":"https://avatars3.githubusercontent.com/u/11388886?v=4","gravatar_id":"","url":"https://api.github.com/users/dcalvoalonso","html_url":"https://github.com/dcalvoalonso","followers_url":"https://api.github.com/users/dcalvoalonso/followers","following_url":"https://api.github.com/users/dcalvoalonso/following{/other_user}","gists_url":"https://api.github.com/users/dcalvoalonso/gists{/gist_id}","starred_url":"https://api.github.com/users/dcalvoalonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcalvoalonso/subscriptions","organizations_url":"https://api.github.com/users/dcalvoalonso/orgs","repos_url":"https://api.github.com/users/dcalvoalonso/repos","events_url":"https://api.github.com/users/dcalvoalonso/events{/privacy}","received_events_url":"https://api.github.com/users/dcalvoalonso/received_events","type":"User","site_admin":false},"body":"Following what was discussed in https://github.com/telefonicaid/iotagent-node-lib/issues/681 and the example of https://github.com/telefonicaid/iotagent-node-lib/pull/682, this PR aims to update all dependencies, supporting newer versions of Node.js and removing the use of Grunt.","created_at":"2018-10-27T19:58:59Z","updated_at":"2018-11-05T15:54:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd336a7aaedaecfcb8bc54a061b1f9a35c57e9b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/339/comments","statuses_url":"https://api.github.com/repos/telefonicaid/iotagent-json/statuses/fb639e1db5173e9a904308da6fc2ba7615943a66","head":{"label":"dcalvoalonso:task/nodejs-8","ref":"task/nodejs-8","sha":"fb639e1db5173e9a904308da6fc2ba7615943a66","user":{"login":"dcalvoalonso","id":11388886,"node_id":"MDQ6VXNlcjExMzg4ODg2","avatar_url":"https://avatars3.githubusercontent.com/u/11388886?v=4","gravatar_id":"","url":"https://api.github.com/users/dcalvoalonso","html_url":"https://github.com/dcalvoalonso","followers_url":"https://api.github.com/users/dcalvoalonso/followers","following_url":"https://api.github.com/users/dcalvoalonso/following{/other_user}","gists_url":"https://api.github.com/users/dcalvoalonso/gists{/gist_id}","starred_url":"https://api.github.com/users/dcalvoalonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcalvoalonso/subscriptions","organizations_url":"https://api.github.com/users/dcalvoalonso/orgs","repos_url":"https://api.github.com/users/dcalvoalonso/repos","events_url":"https://api.github.com/users/dcalvoalonso/events{/privacy}","received_events_url":"https://api.github.com/users/dcalvoalonso/received_events","type":"User","site_admin":false},"repo":{"id":107998209,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5OTgyMDk=","name":"iotagent-json","full_name":"dcalvoalonso/iotagent-json","private":false,"owner":{"login":"dcalvoalonso","id":11388886,"node_id":"MDQ6VXNlcjExMzg4ODg2","avatar_url":"https://avatars3.githubusercontent.com/u/11388886?v=4","gravatar_id":"","url":"https://api.github.com/users/dcalvoalonso","html_url":"https://github.com/dcalvoalonso","followers_url":"https://api.github.com/users/dcalvoalonso/followers","following_url":"https://api.github.com/users/dcalvoalonso/following{/other_user}","gists_url":"https://api.github.com/users/dcalvoalonso/gists{/gist_id}","starred_url":"https://api.github.com/users/dcalvoalonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcalvoalonso/subscriptions","organizations_url":"https://api.github.com/users/dcalvoalonso/orgs","repos_url":"https://api.github.com/users/dcalvoalonso/repos","events_url":"https://api.github.com/users/dcalvoalonso/events{/privacy}","received_events_url":"https://api.github.com/users/dcalvoalonso/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dcalvoalonso/iotagent-json","description":"IoT Agent for a JSON based protocol (with HTTP and MQTT transport)","fork":true,"url":"https://api.github.com/repos/dcalvoalonso/iotagent-json","forks_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/forks","keys_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/teams","hooks_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/hooks","issue_events_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/issues/events{/number}","events_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/events","assignees_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/assignees{/user}","branches_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/branches{/branch}","tags_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/tags","blobs_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/statuses/{sha}","languages_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/languages","stargazers_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/stargazers","contributors_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/contributors","subscribers_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/subscribers","subscription_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/subscription","commits_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/contents/{+path}","compare_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/merges","archive_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/downloads","issues_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/issues{/number}","pulls_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/pulls{/number}","milestones_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/milestones{/number}","notifications_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/labels{/name}","releases_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/releases{/id}","deployments_url":"https://api.github.com/repos/dcalvoalonso/iotagent-json/deployments","created_at":"2017-10-23T15:03:20Z","updated_at":"2017-10-23T15:03:22Z","pushed_at":"2018-11-03T14:18:29Z","git_url":"git://github.com/dcalvoalonso/iotagent-json.git","ssh_url":"git@github.com:dcalvoalonso/iotagent-json.git","clone_url":"https://github.com/dcalvoalonso/iotagent-json.git","svn_url":"https://github.com/dcalvoalonso/iotagent-json","homepage":"","size":789,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telefonicaid:master","ref":"master","sha":"982054252ebecb1a96c3e9cf7d55f97ab20edfca","user":{"login":"telefonicaid","id":968363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODM2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":45597990,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU5Nzk5MA==","name":"iotagent-json","full_name":"telefonicaid/iotagent-json","private":false,"owner":{"login":"telefonicaid","id":968363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODM2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telefonicaid/iotagent-json","description":"IoT Agent for a JSON based protocol (with HTTP and MQTT transport)","fork":false,"url":"https://api.github.com/repos/telefonicaid/iotagent-json","forks_url":"https://api.github.com/repos/telefonicaid/iotagent-json/forks","keys_url":"https://api.github.com/repos/telefonicaid/iotagent-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/iotagent-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/iotagent-json/teams","hooks_url":"https://api.github.com/repos/telefonicaid/iotagent-json/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/iotagent-json/events","assignees_url":"https://api.github.com/repos/telefonicaid/iotagent-json/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/iotagent-json/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/iotagent-json/tags","blobs_url":"https://api.github.com/repos/telefonicaid/iotagent-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/iotagent-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/iotagent-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/iotagent-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/iotagent-json/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/iotagent-json/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/iotagent-json/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/iotagent-json/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/iotagent-json/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/iotagent-json/subscription","commits_url":"https://api.github.com/repos/telefonicaid/iotagent-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/iotagent-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/iotagent-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/iotagent-json/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/iotagent-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/iotagent-json/merges","archive_url":"https://api.github.com/repos/telefonicaid/iotagent-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/iotagent-json/downloads","issues_url":"https://api.github.com/repos/telefonicaid/iotagent-json/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/iotagent-json/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/iotagent-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/iotagent-json/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/iotagent-json/releases{/id}","deployments_url":"https://api.github.com/repos/telefonicaid/iotagent-json/deployments","created_at":"2015-11-05T08:31:24Z","updated_at":"2018-10-30T12:39:48Z","pushed_at":"2018-11-03T14:18:30Z","git_url":"git://github.com/telefonicaid/iotagent-json.git","ssh_url":"git@github.com:telefonicaid/iotagent-json.git","clone_url":"https://github.com/telefonicaid/iotagent-json.git","svn_url":"https://github.com/telefonicaid/iotagent-json","homepage":"","size":779,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":37,"open_issues":25,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339"},"html":{"href":"https://github.com/telefonicaid/iotagent-json/pull/339"},"issue":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/339"},"comments":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/iotagent-json/statuses/fb639e1db5173e9a904308da6fc2ba7615943a66"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fgalan"}}