{"action":"created","issue":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/467","repository_url":"https://api.github.com/repos/MaslowCNC/Firmware","labels_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/467/labels{/name}","comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/467/comments","events_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/467/events","html_url":"https://github.com/MaslowCNC/Firmware/pull/467","id":370438724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTE0NDc3","number":467,"title":"Beam tilt correction","user":{"login":"johnboiles","id":218876,"node_id":"MDQ6VXNlcjIxODg3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/218876?v=4","gravatar_id":"","url":"https://api.github.com/users/johnboiles","html_url":"https://github.com/johnboiles","followers_url":"https://api.github.com/users/johnboiles/followers","following_url":"https://api.github.com/users/johnboiles/following{/other_user}","gists_url":"https://api.github.com/users/johnboiles/gists{/gist_id}","starred_url":"https://api.github.com/users/johnboiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnboiles/subscriptions","organizations_url":"https://api.github.com/users/johnboiles/orgs","repos_url":"https://api.github.com/users/johnboiles/repos","events_url":"https://api.github.com/users/johnboiles/events{/privacy}","received_events_url":"https://api.github.com/users/johnboiles/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-10-16T04:51:34Z","updated_at":"2018-10-16T18:09:11Z","closed_at":"2018-10-16T16:09:19Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/467","html_url":"https://github.com/MaslowCNC/Firmware/pull/467","diff_url":"https://github.com/MaslowCNC/Firmware/pull/467.diff","patch_url":"https://github.com/MaslowCNC/Firmware/pull/467.patch"},"body":"I'm starting to cherry-pick features and fixes from @madgrizzle's fork so that we can get them merged back upstream.\r\n\r\nThis change adds beam tilt correction -- From reading the code, it adjusts the x,y coordinates of the motors to account for the top beam being out-of-level.\r\n\r\nRelated GroundControl change is in https://github.com/MaslowCNC/GroundControl/pull/778"},"comment":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/comments/430340003","html_url":"https://github.com/MaslowCNC/Firmware/pull/467#issuecomment-430340003","issue_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/467","id":430340003,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDM0MDAwMw==","user":{"login":"madgrizzle","id":5055291,"node_id":"MDQ6VXNlcjUwNTUyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5055291?v=4","gravatar_id":"","url":"https://api.github.com/users/madgrizzle","html_url":"https://github.com/madgrizzle","followers_url":"https://api.github.com/users/madgrizzle/followers","following_url":"https://api.github.com/users/madgrizzle/following{/other_user}","gists_url":"https://api.github.com/users/madgrizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/madgrizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madgrizzle/subscriptions","organizations_url":"https://api.github.com/users/madgrizzle/orgs","repos_url":"https://api.github.com/users/madgrizzle/repos","events_url":"https://api.github.com/users/madgrizzle/events{/privacy}","received_events_url":"https://api.github.com/users/madgrizzle/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T18:09:11Z","updated_at":"2018-10-16T18:09:11Z","author_association":"CONTRIBUTOR","body":"> I think what this simulator shows is the situation where the top beam isn't parallel to the workarea. I guess I misunderstood their purpose.\r\n> If that's what these settings are meant for, then adjusting the workarea sheet within the frame is a better answer, and is independent of the frames attachment to the floor or ceiling.\r\n\r\nI see what you are saying and yes, this shows things based upon the top beam not being parallel to the work area.  Maybe you have a point.. I'd have to add gravity to the simulator to truly show the effects and I had other things to work on.  I'm personally convinced it matters, but the optical calibration method I'm working on potentially mitigates it as well as a host of other things.  That's part of the reason why I asked if anyone else is developing for the maslow, because I'm not spending time on improving the current calibration routine or trying to figure out chain sag, chain tolerance, etc."}}
{"actor":{"display_login":"madgrizzle"}}