{"action":"opened","number":24831,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24831","id":226960911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTYwOTEx","html_url":"https://github.com/ceph/ceph/pull/24831","diff_url":"https://github.com/ceph/ceph/pull/24831.diff","patch_url":"https://github.com/ceph/ceph/pull/24831.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24831","number":24831,"state":"open","locked":false,"title":"mgr/dashboard: Cleanup","user":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"body":"While trying to understand the code already written for the QoS implementation for pools and rbds, I've stumbled upon a few things which could be improved for the sake of readability.\r\n\r\n- Make a method static instead of keeping it as classmethod\r\n- Fix return type of methods type hint\r\n- Reformat to fit 100 chars max width\r\n- Rename some variables, methods and argument names for a better\r\n  understanding\r\n\r\n  Examples:\r\n    - activatedCompression() -> hasCompressionEnabled()\r\n    - extendByItemsForSubmit() -> assignFormFields()\r\n        - api -> fieldName\r\n        - name -> formControlName\r\n        - fn -> replaceFn\r\n        - edit -> editable\r\n- Replace `undefined` with `null` in an argument call.\r\n- Extract type declaration to interface and adapted the code to use\r\n  that interface\r\n- Replace unused nearly-global variables with local ones\r\n- Add types where missing and appropriate\r\n  Exmaples:\r\n    - PoolService::getInfo() -> Observable<PoolFormInfo>\r\n- Moved model declaration to shared directory\r\n- Added documentation for a method which isn't that easy to understand\r\n\r\nSigned-off-by: Patrick Nawracay <pnawracay@suse.com>\r\n","created_at":"2018-10-30T15:07:27Z","updated_at":"2018-10-30T15:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":140959062,"node_id":"MDU6TGFiZWwxNDA5NTkwNjI=","url":"https://api.github.com/repos/ceph/ceph/labels/cleanup","name":"cleanup","color":"009800","default":false},{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/24831/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/24831/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24831/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/917baf0dd794b49f21b7021422b2f44659e6dd35","head":{"label":"p-na:wip-pna-cleanup-fe","ref":"wip-pna-cleanup-fe","sha":"917baf0dd794b49f21b7021422b2f44659e6dd35","user":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"repo":{"id":117105163,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMDUxNjM=","name":"ceph","full_name":"p-na/ceph","private":false,"owner":{"login":"p-na","id":9606095,"node_id":"MDQ6VXNlcjk2MDYwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9606095?v=4","gravatar_id":"","url":"https://api.github.com/users/p-na","html_url":"https://github.com/p-na","followers_url":"https://api.github.com/users/p-na/followers","following_url":"https://api.github.com/users/p-na/following{/other_user}","gists_url":"https://api.github.com/users/p-na/gists{/gist_id}","starred_url":"https://api.github.com/users/p-na/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-na/subscriptions","organizations_url":"https://api.github.com/users/p-na/orgs","repos_url":"https://api.github.com/users/p-na/repos","events_url":"https://api.github.com/users/p-na/events{/privacy}","received_events_url":"https://api.github.com/users/p-na/received_events","type":"User","site_admin":false},"html_url":"https://github.com/p-na/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/p-na/ceph","forks_url":"https://api.github.com/repos/p-na/ceph/forks","keys_url":"https://api.github.com/repos/p-na/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p-na/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p-na/ceph/teams","hooks_url":"https://api.github.com/repos/p-na/ceph/hooks","issue_events_url":"https://api.github.com/repos/p-na/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/p-na/ceph/events","assignees_url":"https://api.github.com/repos/p-na/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/p-na/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/p-na/ceph/tags","blobs_url":"https://api.github.com/repos/p-na/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p-na/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p-na/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/p-na/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p-na/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/p-na/ceph/languages","stargazers_url":"https://api.github.com/repos/p-na/ceph/stargazers","contributors_url":"https://api.github.com/repos/p-na/ceph/contributors","subscribers_url":"https://api.github.com/repos/p-na/ceph/subscribers","subscription_url":"https://api.github.com/repos/p-na/ceph/subscription","commits_url":"https://api.github.com/repos/p-na/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/p-na/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/p-na/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/p-na/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/p-na/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/p-na/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p-na/ceph/merges","archive_url":"https://api.github.com/repos/p-na/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p-na/ceph/downloads","issues_url":"https://api.github.com/repos/p-na/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/p-na/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/p-na/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/p-na/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p-na/ceph/labels{/name}","releases_url":"https://api.github.com/repos/p-na/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/p-na/ceph/deployments","created_at":"2018-01-11T13:38:30Z","updated_at":"2018-01-11T13:38:52Z","pushed_at":"2018-10-30T15:04:44Z","git_url":"git://github.com/p-na/ceph.git","ssh_url":"git@github.com:p-na/ceph.git","clone_url":"https://github.com/p-na/ceph.git","svn_url":"https://github.com/p-na/ceph","homepage":"http://ceph.com","size":318678,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"fbb9bfd71d7473e5da41ec52953dd2e546e60e56","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-10-30T15:00:17Z","pushed_at":"2018-10-30T15:00:08Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":330227,"stargazers_count":5210,"watchers_count":5210,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2743,"mirror_url":null,"archived":false,"open_issues_count":605,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2743,"open_issues":605,"watchers":5210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24831"},"html":{"href":"https://github.com/ceph/ceph/pull/24831"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/24831"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/24831/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24831/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24831/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/917baf0dd794b49f21b7021422b2f44659e6dd35"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":94,"deletions":76,"changed_files":7}}
{"actor":{"display_login":"p-na"}}