{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/192418512","pull_request_review_id":125196057,"id":192418512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQxODUxMg==","diff_hunk":"@@ -13,6 +13,11 @@\n import com.ibm.websphere.ras.annotation.Sensitive;\n import com.ibm.ws.managedobject.ManagedObject;\n import com.ibm.ws.managedobject.ManagedObjectContext;\n+import com.ibm.ws.managedobject.ManagedObjectException;","path":"dev/com.ibm.ws.webcontainer/src/com/ibm/ws/webcontainer/osgi/managed/WCManagedObjectImpl.java","position":4,"original_position":4,"commit_id":"362a402dea4ae9ec7b39c6636b3bcc50efd7a494","original_commit_id":"362a402dea4ae9ec7b39c6636b3bcc50efd7a494","user":{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"body":"Could be that this whole class is redundant now ... there should always be a \"normal\" managed object, this one shouldn't be needed.","created_at":"2018-06-01T14:43:34Z","updated_at":"2018-06-01T14:43:34Z","html_url":"https://github.com/OpenLiberty/open-liberty/pull/3804#discussion_r192418512","pull_request_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/192418512"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3804#discussion_r192418512"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804","id":191789770,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzg5Nzcw","html_url":"https://github.com/OpenLiberty/open-liberty/pull/3804","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/3804.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/3804.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3804","number":3804,"state":"open","locked":false,"title":"3473 use ManagedObjectFactory for all injection and do JEE validation","user":{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"body":"this is the next iteration of issue #3473 ","created_at":"2018-05-31T15:23:56Z","updated_at":"2018-06-01T14:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8992c1a93e4f04fa8fcf99ce20a5dfab1a5f3e","assignee":{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"assignees":[{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tkburroughs","id":29557092,"node_id":"MDQ6VXNlcjI5NTU3MDky","avatar_url":"https://avatars0.githubusercontent.com/u/29557092?v=4","gravatar_id":"","url":"https://api.github.com/users/tkburroughs","html_url":"https://github.com/tkburroughs","followers_url":"https://api.github.com/users/tkburroughs/followers","following_url":"https://api.github.com/users/tkburroughs/following{/other_user}","gists_url":"https://api.github.com/users/tkburroughs/gists{/gist_id}","starred_url":"https://api.github.com/users/tkburroughs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkburroughs/subscriptions","organizations_url":"https://api.github.com/users/tkburroughs/orgs","repos_url":"https://api.github.com/users/tkburroughs/repos","events_url":"https://api.github.com/users/tkburroughs/events{/privacy}","received_events_url":"https://api.github.com/users/tkburroughs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3804/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/362a402dea4ae9ec7b39c6636b3bcc50efd7a494","head":{"label":"tevans78:3473-useMOFforInjectionWithValidation","ref":"3473-useMOFforInjectionWithValidation","sha":"362a402dea4ae9ec7b39c6636b3bcc50efd7a494","user":{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"repo":{"id":104051928,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQwNTE5Mjg=","name":"open-liberty","full_name":"tevans78/open-liberty","owner":{"login":"tevans78","id":22099681,"node_id":"MDQ6VXNlcjIyMDk5Njgx","avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tevans78/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/tevans78/open-liberty","forks_url":"https://api.github.com/repos/tevans78/open-liberty/forks","keys_url":"https://api.github.com/repos/tevans78/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tevans78/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tevans78/open-liberty/teams","hooks_url":"https://api.github.com/repos/tevans78/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/tevans78/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/tevans78/open-liberty/events","assignees_url":"https://api.github.com/repos/tevans78/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/tevans78/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/tevans78/open-liberty/tags","blobs_url":"https://api.github.com/repos/tevans78/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tevans78/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tevans78/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/tevans78/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tevans78/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/tevans78/open-liberty/languages","stargazers_url":"https://api.github.com/repos/tevans78/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/tevans78/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/tevans78/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/tevans78/open-liberty/subscription","commits_url":"https://api.github.com/repos/tevans78/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/tevans78/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/tevans78/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/tevans78/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/tevans78/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/tevans78/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tevans78/open-liberty/merges","archive_url":"https://api.github.com/repos/tevans78/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tevans78/open-liberty/downloads","issues_url":"https://api.github.com/repos/tevans78/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/tevans78/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/tevans78/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/tevans78/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tevans78/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/tevans78/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/tevans78/open-liberty/deployments","created_at":"2017-09-19T09:02:04Z","updated_at":"2018-04-30T10:57:38Z","pushed_at":"2018-06-01T13:31:24Z","git_url":"git://github.com/tevans78/open-liberty.git","ssh_url":"git@github.com:tevans78/open-liberty.git","clone_url":"https://github.com/tevans78/open-liberty.git","svn_url":"https://github.com/tevans78/open-liberty","homepage":"http://openliberty.io","size":133625,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"78c352525785f2b98b64df5e1a75073385427af5","user":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM2OTQzNzc=","name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE2NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-06-01T14:35:00Z","pushed_at":"2018-06-01T14:34:46Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":133950,"stargazers_count":292,"watchers_count":292,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":244,"mirror_url":null,"archived":false,"open_issues_count":467,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":244,"open_issues":467,"watchers":292,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3804"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3804"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3804/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3804/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/362a402dea4ae9ec7b39c6636b3bcc50efd7a494"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tevans78"}}