{"push_id":2395292936,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"55d172617c2b6df3abdd430bf5751ddbd4420551","before":"14cd21417f8774a92900cb707064d650ea769615","commits":[{"sha":"55d172617c2b6df3abdd430bf5751ddbd4420551","author":{"name":"Harald Welte","email":"1bea0d4f31c8562ffb1eea349653b7434bf390c6@gnumonks.org"},"message":"sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6\n\nFixes a regression in the code generating SI5* and SI6 on SACCH,\nwhere the L2 pseudo-length is not part of the 'struct' definition\nwe have in gsm_04_08.h and hence has to be encoded manually into\nthe first byte of the SI buffer.\n\nWe were doing this correctly until April 2017, when the following\npatch was merged:\n\n> commit 6f0e50c8337355eb59033903ede9ab6528890835\n> Author: Max <msuraev@sysmocom.de>\n> Date:   Wed Apr 12 15:30:54 2017 +0200\n>\n>     Prepare for extended SI2quater support\n\nThis patch cacidentially overwrote the l2_plen that was just enoded,\nas the 'struct' was no longer pointing to 'output' (si_buf+1), but\nnow directly to the start of the si_buf.\n\nNOTE: The Wireshark RSL dissector (and more recently also LAPDm)\ncontain a similar bug, so the SACCH will not be decoded correctly\nafter applying this patch. Nevertheless, it's correct.\n\nback-port of OsmoBSC Change-Id: Ie8c907b1317566670aeb68f933ceefd552c17565\nCloses: #3059\nRelated: #2963\nChange-Id: Iaf5feefc1bb3194dd491955fee418795c61787f7","distinct":true,"url":"https://api.github.com/repos/osmocom/openbsc/commits/55d172617c2b6df3abdd430bf5751ddbd4420551"}]}
{"actor":{"display_login":"osmocom-gerrit"}}