{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/binding/pulls/comments/237825765","pull_request_review_id":180220296,"id":237825765,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgyNTc2NQ==","diff_hunk":"@@ -184,10 +184,13 @@ export declare interface ICollectionObserverSplice<T = any> {\n   value: T;\n                                                    \n   /**\n-   * The type of change that has taken place. Valid options are \"add\", \"delete\", and \"update\".\n-   * \"update\" is invalid for Set.\n+   * The type of change that has taken place. Valid options are \"splice\", \"add\", \"delete\", \"update\", and \"clear\".\n+   * \n+   * *Note:* \"splice\" is only valid for Array; \"add\", \"update\", and \"clear\" are invalid for Array.\n+   * \n+   * *Note:* \"update\" is invalid for Set.\n    */\n-  type: \"add\" | \"delete\" | \"update\";\n+  type: \"splice\" | \"add\" | \"delete\" | \"update\" | \"clear\";","path":"src/aurelia-binding.d.ts","position":null,"original_position":37,"commit_id":"1aa9c43355a454579ae7f522969028979f616808","original_commit_id":"133edc357b1b78ce4d9242881f9b4aa64f6fa99b","user":{"login":"bigopon","id":9994529,"node_id":"MDQ6VXNlcjk5OTQ1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/9994529?v=4","gravatar_id":"","url":"https://api.github.com/users/bigopon","html_url":"https://github.com/bigopon","followers_url":"https://api.github.com/users/bigopon/followers","following_url":"https://api.github.com/users/bigopon/following{/other_user}","gists_url":"https://api.github.com/users/bigopon/gists{/gist_id}","starred_url":"https://api.github.com/users/bigopon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigopon/subscriptions","organizations_url":"https://api.github.com/users/bigopon/orgs","repos_url":"https://api.github.com/users/bigopon/repos","events_url":"https://api.github.com/users/bigopon/events{/privacy}","received_events_url":"https://api.github.com/users/bigopon/received_events","type":"User","site_admin":false},"body":"In the gist, it shows that 'clear' is a valid type for Map | Set","created_at":"2018-11-30T11:12:04Z","updated_at":"2018-11-30T11:12:04Z","html_url":"https://github.com/aurelia/binding/pull/728#discussion_r237825765","pull_request_url":"https://api.github.com/repos/aurelia/binding/pulls/728","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aurelia/binding/pulls/comments/237825765"},"html":{"href":"https://github.com/aurelia/binding/pull/728#discussion_r237825765"},"pull_request":{"href":"https://api.github.com/repos/aurelia/binding/pulls/728"}},"in_reply_to_id":237648646},"pull_request":{"url":"https://api.github.com/repos/aurelia/binding/pulls/728","id":234074848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDc0ODQ4","html_url":"https://github.com/aurelia/binding/pull/728","diff_url":"https://github.com/aurelia/binding/pull/728.diff","patch_url":"https://github.com/aurelia/binding/pull/728.patch","issue_url":"https://api.github.com/repos/aurelia/binding/issues/728","number":728,"state":"open","locked":false,"title":"Update Collection Observer Typings","user":{"login":"alienriver49","id":1094009,"node_id":"MDQ6VXNlcjEwOTQwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1094009?v=4","gravatar_id":"","url":"https://api.github.com/users/alienriver49","html_url":"https://github.com/alienriver49","followers_url":"https://api.github.com/users/alienriver49/followers","following_url":"https://api.github.com/users/alienriver49/following{/other_user}","gists_url":"https://api.github.com/users/alienriver49/gists{/gist_id}","starred_url":"https://api.github.com/users/alienriver49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienriver49/subscriptions","organizations_url":"https://api.github.com/users/alienriver49/orgs","repos_url":"https://api.github.com/users/alienriver49/repos","events_url":"https://api.github.com/users/alienriver49/events{/privacy}","received_events_url":"https://api.github.com/users/alienriver49/received_events","type":"User","site_admin":false},"body":"Correction to the ICollectionObserverSplice interface. Adding missing methods to the InternalCollectionObserver interface and ObserverLocator class.\r\n\r\nOne thing I noticed with the InternalCollectionObserver interface was the `subscribe(callback: (changeRecords: any) => void): void;` and `unsubscribe(callback: (changeRecords: any) => void): void;` method definitions; am I crazy to think that these are not supported / depreciated?","created_at":"2018-11-27T21:59:38Z","updated_at":"2018-11-30T11:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bacb2743dca14a01179b7c7416f2375173f83862","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/binding/pulls/728/commits","review_comments_url":"https://api.github.com/repos/aurelia/binding/pulls/728/comments","review_comment_url":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/binding/issues/728/comments","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/1aa9c43355a454579ae7f522969028979f616808","head":{"label":"alienriver49:master","ref":"master","sha":"1aa9c43355a454579ae7f522969028979f616808","user":{"login":"alienriver49","id":1094009,"node_id":"MDQ6VXNlcjEwOTQwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1094009?v=4","gravatar_id":"","url":"https://api.github.com/users/alienriver49","html_url":"https://github.com/alienriver49","followers_url":"https://api.github.com/users/alienriver49/followers","following_url":"https://api.github.com/users/alienriver49/following{/other_user}","gists_url":"https://api.github.com/users/alienriver49/gists{/gist_id}","starred_url":"https://api.github.com/users/alienriver49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienriver49/subscriptions","organizations_url":"https://api.github.com/users/alienriver49/orgs","repos_url":"https://api.github.com/users/alienriver49/repos","events_url":"https://api.github.com/users/alienriver49/events{/privacy}","received_events_url":"https://api.github.com/users/alienriver49/received_events","type":"User","site_admin":false},"repo":{"id":159397290,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzOTcyOTA=","name":"binding","full_name":"alienriver49/binding","private":false,"owner":{"login":"alienriver49","id":1094009,"node_id":"MDQ6VXNlcjEwOTQwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1094009?v=4","gravatar_id":"","url":"https://api.github.com/users/alienriver49","html_url":"https://github.com/alienriver49","followers_url":"https://api.github.com/users/alienriver49/followers","following_url":"https://api.github.com/users/alienriver49/following{/other_user}","gists_url":"https://api.github.com/users/alienriver49/gists{/gist_id}","starred_url":"https://api.github.com/users/alienriver49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alienriver49/subscriptions","organizations_url":"https://api.github.com/users/alienriver49/orgs","repos_url":"https://api.github.com/users/alienriver49/repos","events_url":"https://api.github.com/users/alienriver49/events{/privacy}","received_events_url":"https://api.github.com/users/alienriver49/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alienriver49/binding","description":"A modern databinding library for JavaScript and HTML.","fork":true,"url":"https://api.github.com/repos/alienriver49/binding","forks_url":"https://api.github.com/repos/alienriver49/binding/forks","keys_url":"https://api.github.com/repos/alienriver49/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alienriver49/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alienriver49/binding/teams","hooks_url":"https://api.github.com/repos/alienriver49/binding/hooks","issue_events_url":"https://api.github.com/repos/alienriver49/binding/issues/events{/number}","events_url":"https://api.github.com/repos/alienriver49/binding/events","assignees_url":"https://api.github.com/repos/alienriver49/binding/assignees{/user}","branches_url":"https://api.github.com/repos/alienriver49/binding/branches{/branch}","tags_url":"https://api.github.com/repos/alienriver49/binding/tags","blobs_url":"https://api.github.com/repos/alienriver49/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alienriver49/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alienriver49/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/alienriver49/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alienriver49/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/alienriver49/binding/languages","stargazers_url":"https://api.github.com/repos/alienriver49/binding/stargazers","contributors_url":"https://api.github.com/repos/alienriver49/binding/contributors","subscribers_url":"https://api.github.com/repos/alienriver49/binding/subscribers","subscription_url":"https://api.github.com/repos/alienriver49/binding/subscription","commits_url":"https://api.github.com/repos/alienriver49/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/alienriver49/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/alienriver49/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/alienriver49/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/alienriver49/binding/contents/{+path}","compare_url":"https://api.github.com/repos/alienriver49/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alienriver49/binding/merges","archive_url":"https://api.github.com/repos/alienriver49/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alienriver49/binding/downloads","issues_url":"https://api.github.com/repos/alienriver49/binding/issues{/number}","pulls_url":"https://api.github.com/repos/alienriver49/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/alienriver49/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/alienriver49/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alienriver49/binding/labels{/name}","releases_url":"https://api.github.com/repos/alienriver49/binding/releases{/id}","deployments_url":"https://api.github.com/repos/alienriver49/binding/deployments","created_at":"2018-11-27T20:48:03Z","updated_at":"2018-11-29T21:48:34Z","pushed_at":"2018-11-29T21:48:32Z","git_url":"git://github.com/alienriver49/binding.git","ssh_url":"git@github.com:alienriver49/binding.git","clone_url":"https://github.com/alienriver49/binding.git","svn_url":"https://github.com/alienriver49/binding","homepage":null,"size":6772,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"f78529be053ba6a2d69db1dfdfb3a59bf7a1f75c","user":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27744828,"node_id":"MDEwOlJlcG9zaXRvcnkyNzc0NDgyOA==","name":"binding","full_name":"aurelia/binding","private":false,"owner":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aurelia/binding","description":"A modern databinding library for JavaScript and HTML.","fork":false,"url":"https://api.github.com/repos/aurelia/binding","forks_url":"https://api.github.com/repos/aurelia/binding/forks","keys_url":"https://api.github.com/repos/aurelia/binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/binding/teams","hooks_url":"https://api.github.com/repos/aurelia/binding/hooks","issue_events_url":"https://api.github.com/repos/aurelia/binding/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/binding/events","assignees_url":"https://api.github.com/repos/aurelia/binding/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/binding/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/binding/tags","blobs_url":"https://api.github.com/repos/aurelia/binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/binding/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/binding/languages","stargazers_url":"https://api.github.com/repos/aurelia/binding/stargazers","contributors_url":"https://api.github.com/repos/aurelia/binding/contributors","subscribers_url":"https://api.github.com/repos/aurelia/binding/subscribers","subscription_url":"https://api.github.com/repos/aurelia/binding/subscription","commits_url":"https://api.github.com/repos/aurelia/binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/binding/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/binding/merges","archive_url":"https://api.github.com/repos/aurelia/binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/binding/downloads","issues_url":"https://api.github.com/repos/aurelia/binding/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/binding/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/binding/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/binding/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/binding/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/binding/deployments","created_at":"2014-12-09T02:00:32Z","updated_at":"2018-11-22T21:20:14Z","pushed_at":"2018-11-29T21:48:33Z","git_url":"git://github.com/aurelia/binding.git","ssh_url":"git@github.com:aurelia/binding.git","clone_url":"https://github.com/aurelia/binding.git","svn_url":"https://github.com/aurelia/binding","homepage":null,"size":6760,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":103,"open_issues":27,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/binding/pulls/728"},"html":{"href":"https://github.com/aurelia/binding/pull/728"},"issue":{"href":"https://api.github.com/repos/aurelia/binding/issues/728"},"comments":{"href":"https://api.github.com/repos/aurelia/binding/issues/728/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/binding/pulls/728/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/binding/pulls/728/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/binding/statuses/1aa9c43355a454579ae7f522969028979f616808"}},"author_association":"NONE"}}
{"actor":{"display_login":"bigopon"}}