{"action":"created","comment":{"url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/comments/195068647","pull_request_review_id":128360164,"id":195068647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTA2ODY0Nw==","diff_hunk":"@@ -31,7 +31,10 @@ public partial class _404 : BaseError\n         protected override void OnLoad(EventArgs e)\n         {\n             // set properties\n-            base.SettingsKey = \"ItemNotFoundUrl\";\n+            var isMedia = Context.Items.Contains(\"IsMedia\")\n+                ? Convert.ToBoolean(Context.Items[\"IsMedia\"])","path":"src/Unic.ErrorManager.Website/sitecore modules/Web/Error Manager/404.aspx.cs","position":6,"original_position":6,"commit_id":"2e273945803c25e5664b07ada23ee21d8ad04f80","original_commit_id":"45351a0cc7fb42b1099045ff7ac4809d7a3830b5","user":{"login":"kreiswelt","id":5144272,"node_id":"MDQ6VXNlcjUxNDQyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5144272?v=4","gravatar_id":"","url":"https://api.github.com/users/kreiswelt","html_url":"https://github.com/kreiswelt","followers_url":"https://api.github.com/users/kreiswelt/followers","following_url":"https://api.github.com/users/kreiswelt/following{/other_user}","gists_url":"https://api.github.com/users/kreiswelt/gists{/gist_id}","starred_url":"https://api.github.com/users/kreiswelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreiswelt/subscriptions","organizations_url":"https://api.github.com/users/kreiswelt/orgs","repos_url":"https://api.github.com/users/kreiswelt/repos","events_url":"https://api.github.com/users/kreiswelt/events{/privacy}","received_events_url":"https://api.github.com/users/kreiswelt/received_events","type":"User","site_admin":false},"body":"Yes, agreed. \r\nI saw your fixes","created_at":"2018-06-13T12:51:39Z","updated_at":"2018-06-13T12:51:40Z","html_url":"https://github.com/unic/SitecoreErrorManager/pull/14#discussion_r195068647","pull_request_url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/comments/195068647"},"html":{"href":"https://github.com/unic/SitecoreErrorManager/pull/14#discussion_r195068647"},"pull_request":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14"}},"in_reply_to_id":194725878},"pull_request":{"url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14","id":167072011,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3MDcyMDEx","html_url":"https://github.com/unic/SitecoreErrorManager/pull/14","diff_url":"https://github.com/unic/SitecoreErrorManager/pull/14.diff","patch_url":"https://github.com/unic/SitecoreErrorManager/pull/14.patch","issue_url":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/14","number":14,"state":"closed","locked":false,"title":"Modify 404 behaviour for CMS Managed Media Items","user":{"login":"kreiswelt","id":5144272,"node_id":"MDQ6VXNlcjUxNDQyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5144272?v=4","gravatar_id":"","url":"https://api.github.com/users/kreiswelt","html_url":"https://github.com/kreiswelt","followers_url":"https://api.github.com/users/kreiswelt/followers","following_url":"https://api.github.com/users/kreiswelt/following{/other_user}","gists_url":"https://api.github.com/users/kreiswelt/gists{/gist_id}","starred_url":"https://api.github.com/users/kreiswelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreiswelt/subscriptions","organizations_url":"https://api.github.com/users/kreiswelt/orgs","repos_url":"https://api.github.com/users/kreiswelt/repos","events_url":"https://api.github.com/users/kreiswelt/events{/privacy}","received_events_url":"https://api.github.com/users/kreiswelt/received_events","type":"User","site_admin":false},"body":"* Allow different NotFoundUrl between media and item\r\n* Introduce MediaNotFoundUrl.UseStatic as preset for static url","created_at":"2018-02-05T07:16:53Z","updated_at":"2018-06-13T12:51:40Z","closed_at":"2018-06-12T15:33:13Z","merged_at":"2018-06-12T15:33:13Z","merge_commit_sha":"2e273945803c25e5664b07ada23ee21d8ad04f80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14/commits","review_comments_url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14/comments","review_comment_url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/14/comments","statuses_url":"https://api.github.com/repos/unic/SitecoreErrorManager/statuses/2e273945803c25e5664b07ada23ee21d8ad04f80","head":{"label":"kreiswelt:not_found_media","ref":"not_found_media","sha":"2e273945803c25e5664b07ada23ee21d8ad04f80","user":{"login":"kreiswelt","id":5144272,"node_id":"MDQ6VXNlcjUxNDQyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5144272?v=4","gravatar_id":"","url":"https://api.github.com/users/kreiswelt","html_url":"https://github.com/kreiswelt","followers_url":"https://api.github.com/users/kreiswelt/followers","following_url":"https://api.github.com/users/kreiswelt/following{/other_user}","gists_url":"https://api.github.com/users/kreiswelt/gists{/gist_id}","starred_url":"https://api.github.com/users/kreiswelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreiswelt/subscriptions","organizations_url":"https://api.github.com/users/kreiswelt/orgs","repos_url":"https://api.github.com/users/kreiswelt/repos","events_url":"https://api.github.com/users/kreiswelt/events{/privacy}","received_events_url":"https://api.github.com/users/kreiswelt/received_events","type":"User","site_admin":false},"repo":{"id":119642935,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2NDI5MzU=","name":"SitecoreErrorManager","full_name":"kreiswelt/SitecoreErrorManager","owner":{"login":"kreiswelt","id":5144272,"node_id":"MDQ6VXNlcjUxNDQyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5144272?v=4","gravatar_id":"","url":"https://api.github.com/users/kreiswelt","html_url":"https://github.com/kreiswelt","followers_url":"https://api.github.com/users/kreiswelt/followers","following_url":"https://api.github.com/users/kreiswelt/following{/other_user}","gists_url":"https://api.github.com/users/kreiswelt/gists{/gist_id}","starred_url":"https://api.github.com/users/kreiswelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreiswelt/subscriptions","organizations_url":"https://api.github.com/users/kreiswelt/orgs","repos_url":"https://api.github.com/users/kreiswelt/repos","events_url":"https://api.github.com/users/kreiswelt/events{/privacy}","received_events_url":"https://api.github.com/users/kreiswelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kreiswelt/SitecoreErrorManager","description":"Sitecore Error Manager Module - Handles all the HTTP Errors for your Sitecore Solution","fork":true,"url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager","forks_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/forks","keys_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/teams","hooks_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/hooks","issue_events_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/issues/events{/number}","events_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/events","assignees_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/assignees{/user}","branches_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/branches{/branch}","tags_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/tags","blobs_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/statuses/{sha}","languages_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/languages","stargazers_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/stargazers","contributors_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/contributors","subscribers_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/subscribers","subscription_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/subscription","commits_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/contents/{+path}","compare_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/merges","archive_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/downloads","issues_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/issues{/number}","pulls_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/pulls{/number}","milestones_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/milestones{/number}","notifications_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/labels{/name}","releases_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/releases{/id}","deployments_url":"https://api.github.com/repos/kreiswelt/SitecoreErrorManager/deployments","created_at":"2018-01-31T06:09:35Z","updated_at":"2018-06-13T02:38:10Z","pushed_at":"2018-06-13T02:38:09Z","git_url":"git://github.com/kreiswelt/SitecoreErrorManager.git","ssh_url":"git@github.com:kreiswelt/SitecoreErrorManager.git","clone_url":"https://github.com/kreiswelt/SitecoreErrorManager.git","svn_url":"https://github.com/kreiswelt/SitecoreErrorManager","homepage":"http://marketplace.sitecore.net/en/Modules/Sitecore_Error_Manager.aspx","size":4673,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unic:master","ref":"master","sha":"6a228d85fa5896c290e1889acfd923452615d77e","user":{"login":"unic","id":2689502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODk1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2689502?v=4","gravatar_id":"","url":"https://api.github.com/users/unic","html_url":"https://github.com/unic","followers_url":"https://api.github.com/users/unic/followers","following_url":"https://api.github.com/users/unic/following{/other_user}","gists_url":"https://api.github.com/users/unic/gists{/gist_id}","starred_url":"https://api.github.com/users/unic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unic/subscriptions","organizations_url":"https://api.github.com/users/unic/orgs","repos_url":"https://api.github.com/users/unic/repos","events_url":"https://api.github.com/users/unic/events{/privacy}","received_events_url":"https://api.github.com/users/unic/received_events","type":"Organization","site_admin":false},"repo":{"id":7204212,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA0MjEy","name":"SitecoreErrorManager","full_name":"unic/SitecoreErrorManager","owner":{"login":"unic","id":2689502,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODk1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2689502?v=4","gravatar_id":"","url":"https://api.github.com/users/unic","html_url":"https://github.com/unic","followers_url":"https://api.github.com/users/unic/followers","following_url":"https://api.github.com/users/unic/following{/other_user}","gists_url":"https://api.github.com/users/unic/gists{/gist_id}","starred_url":"https://api.github.com/users/unic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unic/subscriptions","organizations_url":"https://api.github.com/users/unic/orgs","repos_url":"https://api.github.com/users/unic/repos","events_url":"https://api.github.com/users/unic/events{/privacy}","received_events_url":"https://api.github.com/users/unic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unic/SitecoreErrorManager","description":"Sitecore Error Manager Module - Handles all the HTTP Errors for your Sitecore Solution","fork":false,"url":"https://api.github.com/repos/unic/SitecoreErrorManager","forks_url":"https://api.github.com/repos/unic/SitecoreErrorManager/forks","keys_url":"https://api.github.com/repos/unic/SitecoreErrorManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unic/SitecoreErrorManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unic/SitecoreErrorManager/teams","hooks_url":"https://api.github.com/repos/unic/SitecoreErrorManager/hooks","issue_events_url":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/events{/number}","events_url":"https://api.github.com/repos/unic/SitecoreErrorManager/events","assignees_url":"https://api.github.com/repos/unic/SitecoreErrorManager/assignees{/user}","branches_url":"https://api.github.com/repos/unic/SitecoreErrorManager/branches{/branch}","tags_url":"https://api.github.com/repos/unic/SitecoreErrorManager/tags","blobs_url":"https://api.github.com/repos/unic/SitecoreErrorManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unic/SitecoreErrorManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unic/SitecoreErrorManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/unic/SitecoreErrorManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unic/SitecoreErrorManager/statuses/{sha}","languages_url":"https://api.github.com/repos/unic/SitecoreErrorManager/languages","stargazers_url":"https://api.github.com/repos/unic/SitecoreErrorManager/stargazers","contributors_url":"https://api.github.com/repos/unic/SitecoreErrorManager/contributors","subscribers_url":"https://api.github.com/repos/unic/SitecoreErrorManager/subscribers","subscription_url":"https://api.github.com/repos/unic/SitecoreErrorManager/subscription","commits_url":"https://api.github.com/repos/unic/SitecoreErrorManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/unic/SitecoreErrorManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/unic/SitecoreErrorManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/unic/SitecoreErrorManager/contents/{+path}","compare_url":"https://api.github.com/repos/unic/SitecoreErrorManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unic/SitecoreErrorManager/merges","archive_url":"https://api.github.com/repos/unic/SitecoreErrorManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unic/SitecoreErrorManager/downloads","issues_url":"https://api.github.com/repos/unic/SitecoreErrorManager/issues{/number}","pulls_url":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls{/number}","milestones_url":"https://api.github.com/repos/unic/SitecoreErrorManager/milestones{/number}","notifications_url":"https://api.github.com/repos/unic/SitecoreErrorManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unic/SitecoreErrorManager/labels{/name}","releases_url":"https://api.github.com/repos/unic/SitecoreErrorManager/releases{/id}","deployments_url":"https://api.github.com/repos/unic/SitecoreErrorManager/deployments","created_at":"2012-12-17T12:10:24Z","updated_at":"2018-06-12T15:33:14Z","pushed_at":"2018-06-12T15:33:12Z","git_url":"git://github.com/unic/SitecoreErrorManager.git","ssh_url":"git@github.com:unic/SitecoreErrorManager.git","clone_url":"https://github.com/unic/SitecoreErrorManager.git","svn_url":"https://github.com/unic/SitecoreErrorManager","homepage":"http://marketplace.sitecore.net/en/Modules/Sitecore_Error_Manager.aspx","size":4672,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":0,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14"},"html":{"href":"https://github.com/unic/SitecoreErrorManager/pull/14"},"issue":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/14"},"comments":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/unic/SitecoreErrorManager/statuses/2e273945803c25e5664b07ada23ee21d8ad04f80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kreiswelt"}}