{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8925","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8925/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8925/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8925/events","html_url":"https://github.com/RobotLocomotion/drake/pull/8925","id":329150183,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNDc4NTM5","number":8925,"title":"Implicit Stribeck solver","user":{"login":"amcastro-tri","id":17601461,"node_id":"MDQ6VXNlcjE3NjAxNDYx","avatar_url":"https://avatars3.githubusercontent.com/u/17601461?v=4","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false},"labels":[{"id":77798003,"node_id":"MDU6TGFiZWw3Nzc5ODAwMw==","url":"https://api.github.com/repos/RobotLocomotion/drake/labels/priority:%20high","name":"priority: high","color":"b60205","default":false},{"id":470891318,"node_id":"MDU6TGFiZWw0NzA4OTEzMTg=","url":"https://api.github.com/repos/RobotLocomotion/drake/labels/status:%20curate%20commits%20before%20merging","name":"status: curate commits before merging","color":"d93f0b","default":false},{"id":351649295,"node_id":"MDU6TGFiZWwzNTE2NDkyOTU=","url":"https://api.github.com/repos/RobotLocomotion/drake/labels/team:%20dynamics","name":"team: dynamics","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"edrumwri","id":2224335,"node_id":"MDQ6VXNlcjIyMjQzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2224335?v=4","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},"assignees":[{"login":"edrumwri","id":2224335,"node_id":"MDQ6VXNlcjIyMjQzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2224335?v=4","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},{"login":"sherm1","id":4088016,"node_id":"MDQ6VXNlcjQwODgwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2018-06-04T17:34:42Z","updated_at":"2018-06-12T20:43:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/8925","html_url":"https://github.com/RobotLocomotion/drake/pull/8925","diff_url":"https://github.com/RobotLocomotion/drake/pull/8925.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/8925.patch"},"body":"This PR implements the implicit Stribeck solver for friction forces once normal forces are known (compliant in the normal direction).\r\nI tried my best to keep the PR small but I failed. I only include a single pair of tests but I have another PR following this one where there are more tests, #8926 (in order to keep this one as small as possible).\r\nMy apologies to the reviewers.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/8925)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/396727053","html_url":"https://github.com/RobotLocomotion/drake/pull/8925#issuecomment-396727053","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/8925","id":396727053,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjcyNzA1Mw==","user":{"login":"sherm1","id":4088016,"node_id":"MDQ6VXNlcjQwODgwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T20:43:30Z","updated_at":"2018-06-12T20:43:30Z","author_association":"MEMBER","body":"Yes -- looking at this now.\n\n---\n\nReview status: 2 unresolved discussions, LGTM missing from assignee sherm1, platform LGTM missing, commit history needs curation\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/robotlocomotion/drake/8925#-:-LEpjGYBAvBuHh_SbuHn:b65wogc)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"sherm1"}}