{"action":"created","comment":{"url":"https://api.github.com/repos/AidenRHall/blank/pulls/comments/169837374","pull_request_review_id":98428729,"id":169837374,"diff_hunk":"@@ -0,0 +1,15 @@\n+import * as React from 'react';\n+import NotificationsModal from './notifications/NotificationsModal';\n+\n+// All modals will live here and be triggered through redux\n+class Modals extends React.Component<{}, {}> {","path":"Lively/src/components/modals/Modals.tsx","position":5,"original_position":5,"commit_id":"26cb8ebd777e61c99d68ceafe368d03f2eb5ac8d","original_commit_id":"26cb8ebd777e61c99d68ceafe368d03f2eb5ac8d","user":{"login":"Th3Nathan","id":21062561,"avatar_url":"https://avatars2.githubusercontent.com/u/21062561?v=4","gravatar_id":"","url":"https://api.github.com/users/Th3Nathan","html_url":"https://github.com/Th3Nathan","followers_url":"https://api.github.com/users/Th3Nathan/followers","following_url":"https://api.github.com/users/Th3Nathan/following{/other_user}","gists_url":"https://api.github.com/users/Th3Nathan/gists{/gist_id}","starred_url":"https://api.github.com/users/Th3Nathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Th3Nathan/subscriptions","organizations_url":"https://api.github.com/users/Th3Nathan/orgs","repos_url":"https://api.github.com/users/Th3Nathan/repos","events_url":"https://api.github.com/users/Th3Nathan/events{/privacy}","received_events_url":"https://api.github.com/users/Th3Nathan/received_events","type":"User","site_admin":false},"body":"https://www.typescriptlang.org/docs/handbook/react-&-webpack.html\r\n\"// State is never set so we use the '{}' type.\"\r\nhttps://blog.logrocket.com/how-why-a-guide-to-using-typescript-with-react-fffb76c61614\r\nI saw it used like that in these articles, but no further explanation. \r\n\r\nStack overflow people are doing it every which way:\r\nhttps://stackoverflow.com/questions/44738954/react-typescript-type-of-react-component-with-no-state-no-props\r\n\r\nI looked at the type definitions for React components and the default values for props and state are {}. I think those {}s merge with other types that are inherited which is why null can't work instead of {}. It would be possible to either omit the <> entirely, or just use 'any' but I though the {} was more communicative. \r\n","created_at":"2018-02-22T02:08:48Z","updated_at":"2018-02-22T02:08:49Z","html_url":"https://github.com/AidenRHall/blank/pull/1#discussion_r169837374","pull_request_url":"https://api.github.com/repos/AidenRHall/blank/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/comments/169837374"},"html":{"href":"https://github.com/AidenRHall/blank/pull/1#discussion_r169837374"},"pull_request":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/1"}},"in_reply_to_id":162833734},"pull_request":{"url":"https://api.github.com/repos/AidenRHall/blank/pulls/1","id":164166554,"html_url":"https://github.com/AidenRHall/blank/pull/1","diff_url":"https://github.com/AidenRHall/blank/pull/1.diff","patch_url":"https://github.com/AidenRHall/blank/pull/1.patch","issue_url":"https://api.github.com/repos/AidenRHall/blank/issues/1","number":1,"state":"open","locked":false,"title":"Slack","user":{"login":"Th3Nathan","id":21062561,"avatar_url":"https://avatars2.githubusercontent.com/u/21062561?v=4","gravatar_id":"","url":"https://api.github.com/users/Th3Nathan","html_url":"https://github.com/Th3Nathan","followers_url":"https://api.github.com/users/Th3Nathan/followers","following_url":"https://api.github.com/users/Th3Nathan/following{/other_user}","gists_url":"https://api.github.com/users/Th3Nathan/gists{/gist_id}","starred_url":"https://api.github.com/users/Th3Nathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Th3Nathan/subscriptions","organizations_url":"https://api.github.com/users/Th3Nathan/orgs","repos_url":"https://api.github.com/users/Th3Nathan/repos","events_url":"https://api.github.com/users/Th3Nathan/events{/privacy}","received_events_url":"https://api.github.com/users/Th3Nathan/received_events","type":"User","site_admin":false},"body":"This is the Slack clone","created_at":"2018-01-21T09:14:29Z","updated_at":"2018-02-22T02:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac5ee53bd65137b287ca037dcfc0f3de91bb9b20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AidenRHall/blank/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AidenRHall/blank/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AidenRHall/blank/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AidenRHall/blank/issues/1/comments","statuses_url":"https://api.github.com/repos/AidenRHall/blank/statuses/26cb8ebd777e61c99d68ceafe368d03f2eb5ac8d","head":{"label":"Th3Nathan:slack","ref":"slack","sha":"26cb8ebd777e61c99d68ceafe368d03f2eb5ac8d","user":{"login":"Th3Nathan","id":21062561,"avatar_url":"https://avatars2.githubusercontent.com/u/21062561?v=4","gravatar_id":"","url":"https://api.github.com/users/Th3Nathan","html_url":"https://github.com/Th3Nathan","followers_url":"https://api.github.com/users/Th3Nathan/followers","following_url":"https://api.github.com/users/Th3Nathan/following{/other_user}","gists_url":"https://api.github.com/users/Th3Nathan/gists{/gist_id}","starred_url":"https://api.github.com/users/Th3Nathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Th3Nathan/subscriptions","organizations_url":"https://api.github.com/users/Th3Nathan/orgs","repos_url":"https://api.github.com/users/Th3Nathan/repos","events_url":"https://api.github.com/users/Th3Nathan/events{/privacy}","received_events_url":"https://api.github.com/users/Th3Nathan/received_events","type":"User","site_admin":false},"repo":{"id":118276466,"name":"blank","full_name":"Th3Nathan/blank","owner":{"login":"Th3Nathan","id":21062561,"avatar_url":"https://avatars2.githubusercontent.com/u/21062561?v=4","gravatar_id":"","url":"https://api.github.com/users/Th3Nathan","html_url":"https://github.com/Th3Nathan","followers_url":"https://api.github.com/users/Th3Nathan/followers","following_url":"https://api.github.com/users/Th3Nathan/following{/other_user}","gists_url":"https://api.github.com/users/Th3Nathan/gists{/gist_id}","starred_url":"https://api.github.com/users/Th3Nathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Th3Nathan/subscriptions","organizations_url":"https://api.github.com/users/Th3Nathan/orgs","repos_url":"https://api.github.com/users/Th3Nathan/repos","events_url":"https://api.github.com/users/Th3Nathan/events{/privacy}","received_events_url":"https://api.github.com/users/Th3Nathan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Th3Nathan/blank","description":null,"fork":true,"url":"https://api.github.com/repos/Th3Nathan/blank","forks_url":"https://api.github.com/repos/Th3Nathan/blank/forks","keys_url":"https://api.github.com/repos/Th3Nathan/blank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Th3Nathan/blank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Th3Nathan/blank/teams","hooks_url":"https://api.github.com/repos/Th3Nathan/blank/hooks","issue_events_url":"https://api.github.com/repos/Th3Nathan/blank/issues/events{/number}","events_url":"https://api.github.com/repos/Th3Nathan/blank/events","assignees_url":"https://api.github.com/repos/Th3Nathan/blank/assignees{/user}","branches_url":"https://api.github.com/repos/Th3Nathan/blank/branches{/branch}","tags_url":"https://api.github.com/repos/Th3Nathan/blank/tags","blobs_url":"https://api.github.com/repos/Th3Nathan/blank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Th3Nathan/blank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Th3Nathan/blank/git/refs{/sha}","trees_url":"https://api.github.com/repos/Th3Nathan/blank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Th3Nathan/blank/statuses/{sha}","languages_url":"https://api.github.com/repos/Th3Nathan/blank/languages","stargazers_url":"https://api.github.com/repos/Th3Nathan/blank/stargazers","contributors_url":"https://api.github.com/repos/Th3Nathan/blank/contributors","subscribers_url":"https://api.github.com/repos/Th3Nathan/blank/subscribers","subscription_url":"https://api.github.com/repos/Th3Nathan/blank/subscription","commits_url":"https://api.github.com/repos/Th3Nathan/blank/commits{/sha}","git_commits_url":"https://api.github.com/repos/Th3Nathan/blank/git/commits{/sha}","comments_url":"https://api.github.com/repos/Th3Nathan/blank/comments{/number}","issue_comment_url":"https://api.github.com/repos/Th3Nathan/blank/issues/comments{/number}","contents_url":"https://api.github.com/repos/Th3Nathan/blank/contents/{+path}","compare_url":"https://api.github.com/repos/Th3Nathan/blank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Th3Nathan/blank/merges","archive_url":"https://api.github.com/repos/Th3Nathan/blank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Th3Nathan/blank/downloads","issues_url":"https://api.github.com/repos/Th3Nathan/blank/issues{/number}","pulls_url":"https://api.github.com/repos/Th3Nathan/blank/pulls{/number}","milestones_url":"https://api.github.com/repos/Th3Nathan/blank/milestones{/number}","notifications_url":"https://api.github.com/repos/Th3Nathan/blank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Th3Nathan/blank/labels{/name}","releases_url":"https://api.github.com/repos/Th3Nathan/blank/releases{/id}","deployments_url":"https://api.github.com/repos/Th3Nathan/blank/deployments","created_at":"2018-01-20T20:04:26Z","updated_at":"2018-01-17T01:51:48Z","pushed_at":"2018-01-21T09:12:20Z","git_url":"git://github.com/Th3Nathan/blank.git","ssh_url":"git@github.com:Th3Nathan/blank.git","clone_url":"https://github.com/Th3Nathan/blank.git","svn_url":"https://github.com/Th3Nathan/blank","homepage":null,"size":1390,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AidenRHall:master","ref":"master","sha":"7d2a9a5febab9f39b587474e8394b13cddacc3a2","user":{"login":"AidenRHall","id":4148248,"avatar_url":"https://avatars0.githubusercontent.com/u/4148248?v=4","gravatar_id":"","url":"https://api.github.com/users/AidenRHall","html_url":"https://github.com/AidenRHall","followers_url":"https://api.github.com/users/AidenRHall/followers","following_url":"https://api.github.com/users/AidenRHall/following{/other_user}","gists_url":"https://api.github.com/users/AidenRHall/gists{/gist_id}","starred_url":"https://api.github.com/users/AidenRHall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AidenRHall/subscriptions","organizations_url":"https://api.github.com/users/AidenRHall/orgs","repos_url":"https://api.github.com/users/AidenRHall/repos","events_url":"https://api.github.com/users/AidenRHall/events{/privacy}","received_events_url":"https://api.github.com/users/AidenRHall/received_events","type":"User","site_admin":false},"repo":{"id":117768058,"name":"blank","full_name":"AidenRHall/blank","owner":{"login":"AidenRHall","id":4148248,"avatar_url":"https://avatars0.githubusercontent.com/u/4148248?v=4","gravatar_id":"","url":"https://api.github.com/users/AidenRHall","html_url":"https://github.com/AidenRHall","followers_url":"https://api.github.com/users/AidenRHall/followers","following_url":"https://api.github.com/users/AidenRHall/following{/other_user}","gists_url":"https://api.github.com/users/AidenRHall/gists{/gist_id}","starred_url":"https://api.github.com/users/AidenRHall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AidenRHall/subscriptions","organizations_url":"https://api.github.com/users/AidenRHall/orgs","repos_url":"https://api.github.com/users/AidenRHall/repos","events_url":"https://api.github.com/users/AidenRHall/events{/privacy}","received_events_url":"https://api.github.com/users/AidenRHall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AidenRHall/blank","description":null,"fork":false,"url":"https://api.github.com/repos/AidenRHall/blank","forks_url":"https://api.github.com/repos/AidenRHall/blank/forks","keys_url":"https://api.github.com/repos/AidenRHall/blank/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AidenRHall/blank/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AidenRHall/blank/teams","hooks_url":"https://api.github.com/repos/AidenRHall/blank/hooks","issue_events_url":"https://api.github.com/repos/AidenRHall/blank/issues/events{/number}","events_url":"https://api.github.com/repos/AidenRHall/blank/events","assignees_url":"https://api.github.com/repos/AidenRHall/blank/assignees{/user}","branches_url":"https://api.github.com/repos/AidenRHall/blank/branches{/branch}","tags_url":"https://api.github.com/repos/AidenRHall/blank/tags","blobs_url":"https://api.github.com/repos/AidenRHall/blank/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AidenRHall/blank/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AidenRHall/blank/git/refs{/sha}","trees_url":"https://api.github.com/repos/AidenRHall/blank/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AidenRHall/blank/statuses/{sha}","languages_url":"https://api.github.com/repos/AidenRHall/blank/languages","stargazers_url":"https://api.github.com/repos/AidenRHall/blank/stargazers","contributors_url":"https://api.github.com/repos/AidenRHall/blank/contributors","subscribers_url":"https://api.github.com/repos/AidenRHall/blank/subscribers","subscription_url":"https://api.github.com/repos/AidenRHall/blank/subscription","commits_url":"https://api.github.com/repos/AidenRHall/blank/commits{/sha}","git_commits_url":"https://api.github.com/repos/AidenRHall/blank/git/commits{/sha}","comments_url":"https://api.github.com/repos/AidenRHall/blank/comments{/number}","issue_comment_url":"https://api.github.com/repos/AidenRHall/blank/issues/comments{/number}","contents_url":"https://api.github.com/repos/AidenRHall/blank/contents/{+path}","compare_url":"https://api.github.com/repos/AidenRHall/blank/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AidenRHall/blank/merges","archive_url":"https://api.github.com/repos/AidenRHall/blank/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AidenRHall/blank/downloads","issues_url":"https://api.github.com/repos/AidenRHall/blank/issues{/number}","pulls_url":"https://api.github.com/repos/AidenRHall/blank/pulls{/number}","milestones_url":"https://api.github.com/repos/AidenRHall/blank/milestones{/number}","notifications_url":"https://api.github.com/repos/AidenRHall/blank/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AidenRHall/blank/labels{/name}","releases_url":"https://api.github.com/repos/AidenRHall/blank/releases{/id}","deployments_url":"https://api.github.com/repos/AidenRHall/blank/deployments","created_at":"2018-01-17T01:51:48Z","updated_at":"2018-01-17T01:51:48Z","pushed_at":"2018-01-21T09:15:10Z","git_url":"git://github.com/AidenRHall/blank.git","ssh_url":"git@github.com:AidenRHall/blank.git","clone_url":"https://github.com/AidenRHall/blank.git","svn_url":"https://github.com/AidenRHall/blank","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/1"},"html":{"href":"https://github.com/AidenRHall/blank/pull/1"},"issue":{"href":"https://api.github.com/repos/AidenRHall/blank/issues/1"},"comments":{"href":"https://api.github.com/repos/AidenRHall/blank/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AidenRHall/blank/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AidenRHall/blank/statuses/26cb8ebd777e61c99d68ceafe368d03f2eb5ac8d"}},"author_association":"NONE"}}
{"actor":{"display_login":"Th3Nathan"}}