{"action":"closed","number":1394,"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394","id":221861871,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODYxODcx","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/1394","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/1394.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/1394.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1394","number":1394,"state":"closed","locked":false,"title":"Use published rpm repos for 3.11 and later; compare_versions function","user":{"login":"richm","id":23066,"node_id":"MDQ6VXNlcjIzMDY2","avatar_url":"https://avatars2.githubusercontent.com/u/23066?v=4","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"body":"For 3.11 and later, there are published RPMs we can use at\n\nhttps://rpms.svc.ci.openshift.org/openshift-origin-v${version}.repo\n\nTo simplify and future proof version comparisons, a new shell\nfunction compare_versions is introduced.  This allows us to\nwrite bash code like this:\n\n    if compare_versions \"\\${curbranch}\" \">\" release-3.10 ; then\n       echo do something different for recent versions\n       ....\n\nAlso fixes some issues with the way versioning/tagging works\nin 3.11 and later.","created_at":"2018-10-10T16:52:48Z","updated_at":"2018-10-10T18:45:42Z","closed_at":"2018-10-10T18:45:41Z","merged_at":"2018-10-10T18:45:41Z","merge_commit_sha":"d38cd454ecdb4cc9301650cd30f755012b702f38","assignee":{"login":"jcantrill","id":4548408,"node_id":"MDQ6VXNlcjQ1NDg0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcantrill","id":4548408,"node_id":"MDQ6VXNlcjQ1NDg0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4548408?v=4","gravatar_id":"","url":"https://api.github.com/users/jcantrill","html_url":"https://github.com/jcantrill","followers_url":"https://api.github.com/users/jcantrill/followers","following_url":"https://api.github.com/users/jcantrill/following{/other_user}","gists_url":"https://api.github.com/users/jcantrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcantrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcantrill/subscriptions","organizations_url":"https://api.github.com/users/jcantrill/orgs","repos_url":"https://api.github.com/users/jcantrill/repos","events_url":"https://api.github.com/users/jcantrill/events{/privacy}","received_events_url":"https://api.github.com/users/jcantrill/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lukas-vlcek","id":205174,"node_id":"MDQ6VXNlcjIwNTE3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/205174?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-vlcek","html_url":"https://github.com/lukas-vlcek","followers_url":"https://api.github.com/users/lukas-vlcek/followers","following_url":"https://api.github.com/users/lukas-vlcek/following{/other_user}","gists_url":"https://api.github.com/users/lukas-vlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-vlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-vlcek/subscriptions","organizations_url":"https://api.github.com/users/lukas-vlcek/orgs","repos_url":"https://api.github.com/users/lukas-vlcek/repos","events_url":"https://api.github.com/users/lukas-vlcek/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-vlcek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":708588242,"node_id":"MDU6TGFiZWw3MDg1ODgyNDI=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":710086058,"node_id":"MDU6TGFiZWw3MTAwODYwNTg=","url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1394/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/ff35c4240bf493a08187765ac2b9356926ae74b5","head":{"label":"richm:get-machine-use-published-rpms","ref":"get-machine-use-published-rpms","sha":"ff35c4240bf493a08187765ac2b9356926ae74b5","user":{"login":"richm","id":23066,"node_id":"MDQ6VXNlcjIzMDY2","avatar_url":"https://avatars2.githubusercontent.com/u/23066?v=4","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"repo":{"id":49232711,"node_id":"MDEwOlJlcG9zaXRvcnk0OTIzMjcxMQ==","name":"origin-aggregated-logging","full_name":"richm/origin-aggregated-logging","private":false,"owner":{"login":"richm","id":23066,"node_id":"MDQ6VXNlcjIzMDY2","avatar_url":"https://avatars2.githubusercontent.com/u/23066?v=4","gravatar_id":"","url":"https://api.github.com/users/richm","html_url":"https://github.com/richm","followers_url":"https://api.github.com/users/richm/followers","following_url":"https://api.github.com/users/richm/following{/other_user}","gists_url":"https://api.github.com/users/richm/gists{/gist_id}","starred_url":"https://api.github.com/users/richm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richm/subscriptions","organizations_url":"https://api.github.com/users/richm/orgs","repos_url":"https://api.github.com/users/richm/repos","events_url":"https://api.github.com/users/richm/events{/privacy}","received_events_url":"https://api.github.com/users/richm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richm/origin-aggregated-logging","description":null,"fork":true,"url":"https://api.github.com/repos/richm/origin-aggregated-logging","forks_url":"https://api.github.com/repos/richm/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/richm/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richm/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richm/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/richm/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/richm/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/richm/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/richm/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/richm/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richm/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/richm/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/richm/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/richm/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/richm/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/richm/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/richm/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/richm/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/richm/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/richm/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/richm/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richm/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/richm/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richm/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/richm/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/richm/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/richm/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/richm/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richm/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/richm/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/richm/origin-aggregated-logging/deployments","created_at":"2016-01-07T21:46:59Z","updated_at":"2016-01-14T20:15:40Z","pushed_at":"2018-10-10T16:52:40Z","git_url":"git://github.com/richm/origin-aggregated-logging.git","ssh_url":"git@github.com:richm/origin-aggregated-logging.git","clone_url":"https://github.com/richm/origin-aggregated-logging.git","svn_url":"https://github.com/richm/origin-aggregated-logging","homepage":null,"size":20988,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"1310d8b384f7123d8cb1a5948e6e25d30503a233","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ2NzgyMg==","name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/origin-aggregated-logging","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2018-10-10T07:31:52Z","pushed_at":"2018-10-10T18:45:41Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":12892,"stargazers_count":73,"watchers_count":73,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":91,"license":null,"forks":149,"open_issues":91,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/1394"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1394"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/1394/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/1394/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/ff35c4240bf493a08187765ac2b9356926ae74b5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":90,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"openshift-merge-robot"}}