{"push_id":2957380267,"size":5,"distinct_size":5,"ref":"refs/heads/develop","head":"ff23227d449c7654877b03a3bbcf68ddc10f4b02","before":"31dd263ccf81f4f1bdaefae75eefa477729492ce","commits":[{"sha":"e6a432f7a179936a718a79f8720612560dcc3d9a","author":{"name":"John Joseph","email":"f1919b9cce23a00b2073dc81317ef601429b59c4@gmail.com"},"message":"Reviewinging commit 5f7ec05:\nAvoid conditionalizing the log via the JUCE_LOG_CURRENT_ASSERTION in jassertfalse to ensure ARA assertions log the FILE and line number.","distinct":true,"url":"https://api.github.com/repos/Celemony/JUCE_ARA/commits/e6a432f7a179936a718a79f8720612560dcc3d9a"},{"sha":"16f6df90d348e96c92c00114ba371dc9b46eeac8","author":{"name":"John Joseph","email":"f1919b9cce23a00b2073dc81317ef601429b59c4@gmail.com"},"message":"Reviewing commit 2642f39:\n1. Changing the name from juce_ARA_Interface.h ==> juce_ARA_audio_plugin.h and juce_audio_plugin_client_ARA.cpp ==> juce_ARA_audio_plugin.cpp.\n2, Removing TODOs regarding relative include paths.","distinct":true,"url":"https://api.github.com/repos/Celemony/JUCE_ARA/commits/16f6df90d348e96c92c00114ba371dc9b46eeac8"},{"sha":"afe6cad0a1c30b37ca22b330755ff44cfa066c1e","author":{"name":"John Joseph","email":"f1919b9cce23a00b2073dc81317ef601429b59c4@gmail.com"},"message":"Reviewing commit 431871a:\n1. Giving the readers a function like setAudioSource glosses over the fact that a new ARA:PlugIn::HostAudioReader is going to be constructed. Because this class is effectively a juce wrapper of the AR::PlugIn::HostAudioReader the user should reconstruct, the juce::ARAAudioSource::Reader to get this behavior. I've renamed that function to createHostAudioReaderForSource\n2. Instead of allowing for the setAudioSource(nullptr) behavior I've added an invalidate function that resets the std::unique_ptr containing the ARA:PlugIn::HostAudioReader instance. However I've left the invalidations that occur when creating a host audio reader for a null or unreadable source - this may be incorrect, so I've added a note that we may want to assert that this invalidation should never occur.\n3. Removing getAudioSource, it's unnecessary.","distinct":true,"url":"https://api.github.com/repos/Celemony/JUCE_ARA/commits/afe6cad0a1c30b37ca22b330755ff44cfa066c1e"},{"sha":"f46837595b1021ddcd19139d6e8331e8b82e745d","author":{"name":"John Joseph","email":"f1919b9cce23a00b2073dc81317ef601429b59c4@gmail.com"},"message":"Reverting commit 784b6fe - the pointer check is misleading and could lead to type mismatches (though checking against another type did raise an error in Visual Studio.)","distinct":true,"url":"https://api.github.com/repos/Celemony/JUCE_ARA/commits/f46837595b1021ddcd19139d6e8331e8b82e745d"},{"sha":"ff23227d449c7654877b03a3bbcf68ddc10f4b02","author":{"name":"John Joseph","email":"f1919b9cce23a00b2073dc81317ef601429b59c4@gmail.com"},"message":"Bumping supported ARA SDK release to 1.9.6.002.","distinct":true,"url":"https://api.github.com/repos/Celemony/JUCE_ARA/commits/ff23227d449c7654877b03a3bbcf68ddc10f4b02"}]}
{"actor":{"display_login":"mynameisjohn"}}