{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2","id":186028033,"html_url":"https://github.com/marcodave/protractor-http-client/pull/2","diff_url":"https://github.com/marcodave/protractor-http-client/pull/2.diff","patch_url":"https://github.com/marcodave/protractor-http-client/pull/2.patch","issue_url":"https://api.github.com/repos/marcodave/protractor-http-client/issues/2","number":2,"state":"open","locked":false,"title":"feature:","user":{"login":"sudharsan-selvaraj","id":20136913,"avatar_url":"https://avatars1.githubusercontent.com/u/20136913?v=4","gravatar_id":"","url":"https://api.github.com/users/sudharsan-selvaraj","html_url":"https://github.com/sudharsan-selvaraj","followers_url":"https://api.github.com/users/sudharsan-selvaraj/followers","following_url":"https://api.github.com/users/sudharsan-selvaraj/following{/other_user}","gists_url":"https://api.github.com/users/sudharsan-selvaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/sudharsan-selvaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudharsan-selvaraj/subscriptions","organizations_url":"https://api.github.com/users/sudharsan-selvaraj/orgs","repos_url":"https://api.github.com/users/sudharsan-selvaraj/repos","events_url":"https://api.github.com/users/sudharsan-selvaraj/events{/privacy}","received_events_url":"https://api.github.com/users/sudharsan-selvaraj/received_events","type":"User","site_admin":false},"body":"I have added few additional improvements to make testing even more flexible. You have already implemented most of the key features required for making API calls from protractor tests. \r\n\r\n There are few scenario's where testing of some real time applications becomes more complex because we need to relay on API's for test data. In such situation we need to make API call for same endpoint in multiple places. To make it more easier i have modified your existing client to provide a way to register a set of API's in bulk and reuse them in the tests directly(inspired from [Angular resource project](https://docs.angularjs.org/api/ngResource/service/$resource)). Below are the list for changes that i have done.\r\n\r\n1. Added PATCH request method.(current framework doesn't have a way to make path calls.)\r\n2. Provided ability to register API enpoints in bulk.\r\n3. Provided support for wildcard routes like \"/products/{productId}\".\r\n4. Created additional Utility methods to JsonPromise class for processing response body.\r\n5. Added new Tests for registered API's(with authentication and without authentication).\r\n6. Included demo REST API server developed using Json-server for testing all methods.\r\n7. Integrated gulp to automate build process.\r\n\r\nFeel free to approve/reject the pull request after reviewing the changes.\r\n\r\nThanks.","created_at":"2018-05-04T16:09:21Z","updated_at":"2018-05-04T16:09:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2/commits","review_comments_url":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2/comments","review_comment_url":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marcodave/protractor-http-client/issues/2/comments","statuses_url":"https://api.github.com/repos/marcodave/protractor-http-client/statuses/b362f593e627fad6cb1858d574d5a9f376660cca","head":{"label":"sudharsan-selvaraj:feature/update_comments","ref":"feature/update_comments","sha":"b362f593e627fad6cb1858d574d5a9f376660cca","user":{"login":"sudharsan-selvaraj","id":20136913,"avatar_url":"https://avatars1.githubusercontent.com/u/20136913?v=4","gravatar_id":"","url":"https://api.github.com/users/sudharsan-selvaraj","html_url":"https://github.com/sudharsan-selvaraj","followers_url":"https://api.github.com/users/sudharsan-selvaraj/followers","following_url":"https://api.github.com/users/sudharsan-selvaraj/following{/other_user}","gists_url":"https://api.github.com/users/sudharsan-selvaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/sudharsan-selvaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudharsan-selvaraj/subscriptions","organizations_url":"https://api.github.com/users/sudharsan-selvaraj/orgs","repos_url":"https://api.github.com/users/sudharsan-selvaraj/repos","events_url":"https://api.github.com/users/sudharsan-selvaraj/events{/privacy}","received_events_url":"https://api.github.com/users/sudharsan-selvaraj/received_events","type":"User","site_admin":false},"repo":{"id":131841565,"name":"protractor-http-client","full_name":"sudharsan-selvaraj/protractor-http-client","owner":{"login":"sudharsan-selvaraj","id":20136913,"avatar_url":"https://avatars1.githubusercontent.com/u/20136913?v=4","gravatar_id":"","url":"https://api.github.com/users/sudharsan-selvaraj","html_url":"https://github.com/sudharsan-selvaraj","followers_url":"https://api.github.com/users/sudharsan-selvaraj/followers","following_url":"https://api.github.com/users/sudharsan-selvaraj/following{/other_user}","gists_url":"https://api.github.com/users/sudharsan-selvaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/sudharsan-selvaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudharsan-selvaraj/subscriptions","organizations_url":"https://api.github.com/users/sudharsan-selvaraj/orgs","repos_url":"https://api.github.com/users/sudharsan-selvaraj/repos","events_url":"https://api.github.com/users/sudharsan-selvaraj/events{/privacy}","received_events_url":"https://api.github.com/users/sudharsan-selvaraj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sudharsan-selvaraj/protractor-http-client","description":"HTTP Client library to use in protractor tests","fork":true,"url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client","forks_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/forks","keys_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/teams","hooks_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/hooks","issue_events_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/issues/events{/number}","events_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/events","assignees_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/assignees{/user}","branches_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/branches{/branch}","tags_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/tags","blobs_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/statuses/{sha}","languages_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/languages","stargazers_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/stargazers","contributors_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/contributors","subscribers_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/subscribers","subscription_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/subscription","commits_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/contents/{+path}","compare_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/merges","archive_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/downloads","issues_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/issues{/number}","pulls_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/pulls{/number}","milestones_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/milestones{/number}","notifications_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/labels{/name}","releases_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/releases{/id}","deployments_url":"https://api.github.com/repos/sudharsan-selvaraj/protractor-http-client/deployments","created_at":"2018-05-02T11:33:16Z","updated_at":"2018-05-04T13:03:08Z","pushed_at":"2018-05-04T15:41:25Z","git_url":"git://github.com/sudharsan-selvaraj/protractor-http-client.git","ssh_url":"git@github.com:sudharsan-selvaraj/protractor-http-client.git","clone_url":"https://github.com/sudharsan-selvaraj/protractor-http-client.git","svn_url":"https://github.com/sudharsan-selvaraj/protractor-http-client","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marcodave:master","ref":"master","sha":"46066704ce083880b923c3bef25739fb169e350f","user":{"login":"marcodave","id":4719609,"avatar_url":"https://avatars3.githubusercontent.com/u/4719609?v=4","gravatar_id":"","url":"https://api.github.com/users/marcodave","html_url":"https://github.com/marcodave","followers_url":"https://api.github.com/users/marcodave/followers","following_url":"https://api.github.com/users/marcodave/following{/other_user}","gists_url":"https://api.github.com/users/marcodave/gists{/gist_id}","starred_url":"https://api.github.com/users/marcodave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcodave/subscriptions","organizations_url":"https://api.github.com/users/marcodave/orgs","repos_url":"https://api.github.com/users/marcodave/repos","events_url":"https://api.github.com/users/marcodave/events{/privacy}","received_events_url":"https://api.github.com/users/marcodave/received_events","type":"User","site_admin":false},"repo":{"id":122848310,"name":"protractor-http-client","full_name":"marcodave/protractor-http-client","owner":{"login":"marcodave","id":4719609,"avatar_url":"https://avatars3.githubusercontent.com/u/4719609?v=4","gravatar_id":"","url":"https://api.github.com/users/marcodave","html_url":"https://github.com/marcodave","followers_url":"https://api.github.com/users/marcodave/followers","following_url":"https://api.github.com/users/marcodave/following{/other_user}","gists_url":"https://api.github.com/users/marcodave/gists{/gist_id}","starred_url":"https://api.github.com/users/marcodave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcodave/subscriptions","organizations_url":"https://api.github.com/users/marcodave/orgs","repos_url":"https://api.github.com/users/marcodave/repos","events_url":"https://api.github.com/users/marcodave/events{/privacy}","received_events_url":"https://api.github.com/users/marcodave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcodave/protractor-http-client","description":"HTTP Client library to use in protractor tests","fork":false,"url":"https://api.github.com/repos/marcodave/protractor-http-client","forks_url":"https://api.github.com/repos/marcodave/protractor-http-client/forks","keys_url":"https://api.github.com/repos/marcodave/protractor-http-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcodave/protractor-http-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcodave/protractor-http-client/teams","hooks_url":"https://api.github.com/repos/marcodave/protractor-http-client/hooks","issue_events_url":"https://api.github.com/repos/marcodave/protractor-http-client/issues/events{/number}","events_url":"https://api.github.com/repos/marcodave/protractor-http-client/events","assignees_url":"https://api.github.com/repos/marcodave/protractor-http-client/assignees{/user}","branches_url":"https://api.github.com/repos/marcodave/protractor-http-client/branches{/branch}","tags_url":"https://api.github.com/repos/marcodave/protractor-http-client/tags","blobs_url":"https://api.github.com/repos/marcodave/protractor-http-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcodave/protractor-http-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcodave/protractor-http-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcodave/protractor-http-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcodave/protractor-http-client/statuses/{sha}","languages_url":"https://api.github.com/repos/marcodave/protractor-http-client/languages","stargazers_url":"https://api.github.com/repos/marcodave/protractor-http-client/stargazers","contributors_url":"https://api.github.com/repos/marcodave/protractor-http-client/contributors","subscribers_url":"https://api.github.com/repos/marcodave/protractor-http-client/subscribers","subscription_url":"https://api.github.com/repos/marcodave/protractor-http-client/subscription","commits_url":"https://api.github.com/repos/marcodave/protractor-http-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcodave/protractor-http-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcodave/protractor-http-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcodave/protractor-http-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcodave/protractor-http-client/contents/{+path}","compare_url":"https://api.github.com/repos/marcodave/protractor-http-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcodave/protractor-http-client/merges","archive_url":"https://api.github.com/repos/marcodave/protractor-http-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcodave/protractor-http-client/downloads","issues_url":"https://api.github.com/repos/marcodave/protractor-http-client/issues{/number}","pulls_url":"https://api.github.com/repos/marcodave/protractor-http-client/pulls{/number}","milestones_url":"https://api.github.com/repos/marcodave/protractor-http-client/milestones{/number}","notifications_url":"https://api.github.com/repos/marcodave/protractor-http-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcodave/protractor-http-client/labels{/name}","releases_url":"https://api.github.com/repos/marcodave/protractor-http-client/releases{/id}","deployments_url":"https://api.github.com/repos/marcodave/protractor-http-client/deployments","created_at":"2018-02-25T15:25:23Z","updated_at":"2018-04-17T07:42:52Z","pushed_at":"2018-03-01T21:49:27Z","git_url":"git://github.com/marcodave/protractor-http-client.git","ssh_url":"git@github.com:marcodave/protractor-http-client.git","clone_url":"https://github.com/marcodave/protractor-http-client.git","svn_url":"https://github.com/marcodave/protractor-http-client","homepage":null,"size":27,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2"},"html":{"href":"https://github.com/marcodave/protractor-http-client/pull/2"},"issue":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/issues/2"},"comments":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/marcodave/protractor-http-client/statuses/b362f593e627fad6cb1858d574d5a9f376660cca"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":750,"deletions":14,"changed_files":12}}
{"actor":{"display_login":"sudharsan-selvaraj"}}