{"action":"created","comment":{"url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments/228752470","pull_request_review_id":169095224,"id":228752470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1MjQ3MA==","diff_hunk":"@@ -77,15 +77,13 @@ export default {\n     created () {\n         this.loadCourses()\n \n-        assignmentAPI.getUpcoming()\n+        assignmentAPI.getUpcoming(null)","path":"src/vue/src/views/Home.vue","position":5,"original_position":5,"commit_id":"bb4d6020d88468b4d246d3c92b6023841080793d","original_commit_id":"bb4d6020d88468b4d246d3c92b6023841080793d","user":{"login":"Larspolo","id":11822478,"node_id":"MDQ6VXNlcjExODIyNDc4","avatar_url":"https://avatars2.githubusercontent.com/u/11822478?v=4","gravatar_id":"","url":"https://api.github.com/users/Larspolo","html_url":"https://github.com/Larspolo","followers_url":"https://api.github.com/users/Larspolo/followers","following_url":"https://api.github.com/users/Larspolo/following{/other_user}","gists_url":"https://api.github.com/users/Larspolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Larspolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Larspolo/subscriptions","organizations_url":"https://api.github.com/users/Larspolo/orgs","repos_url":"https://api.github.com/users/Larspolo/repos","events_url":"https://api.github.com/users/Larspolo/events{/privacy}","received_events_url":"https://api.github.com/users/Larspolo/received_events","type":"User","site_admin":false},"body":"Why not null by default?","created_at":"2018-10-28T15:10:57Z","updated_at":"2018-10-28T15:13:22Z","html_url":"https://github.com/eJourn-al/eJournal/pull/480#discussion_r228752470","pull_request_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments/228752470"},"html":{"href":"https://github.com/eJourn-al/eJournal/pull/480#discussion_r228752470"},"pull_request":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480"}}},"pull_request":{"url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480","id":226370992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzcwOTky","html_url":"https://github.com/eJourn-al/eJournal/pull/480","diff_url":"https://github.com/eJourn-al/eJournal/pull/480.diff","patch_url":"https://github.com/eJourn-al/eJournal/pull/480.patch","issue_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/480","number":480,"state":"open","locked":false,"title":"Bugfix/xss","user":{"login":"mjvkeulen","id":39912610,"node_id":"MDQ6VXNlcjM5OTEyNjEw","avatar_url":"https://avatars2.githubusercontent.com/u/39912610?v=4","gravatar_id":"","url":"https://api.github.com/users/mjvkeulen","html_url":"https://github.com/mjvkeulen","followers_url":"https://api.github.com/users/mjvkeulen/followers","following_url":"https://api.github.com/users/mjvkeulen/following{/other_user}","gists_url":"https://api.github.com/users/mjvkeulen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjvkeulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjvkeulen/subscriptions","organizations_url":"https://api.github.com/users/mjvkeulen/orgs","repos_url":"https://api.github.com/users/mjvkeulen/repos","events_url":"https://api.github.com/users/mjvkeulen/events{/privacy}","received_events_url":"https://api.github.com/users/mjvkeulen/received_events","type":"User","site_admin":false},"body":"## Description\r\nReworked front-end API calls to include a connection arguments object. Allowing for the removal of a lot of duplicate rejection and success handling message display. Allowing for the sanitization of success and or error messages in a concentrated location.\r\n\r\n## Summary of changes\r\nEach API call accepts a connection argument object, which expects the following keys and values as default:\r\n```\r\nconst DEFAULT_CONN_ARGS = {\r\n    redirect: true,\r\n    customSuccessToast: false,\r\n    responseSuccessToast: false,\r\n    customErrorToast: false\r\n}\r\n```\r\nThis object defines how success and error responses are handled and toasted by default.\r\n\r\nChanges can be made by overwriting the DEFAULT_CONN_ARGS keys in an API call.\r\nHandled errors are redirected by default when present in ERRORS_TO_REDIRECT unless redirect set to false.\r\nHandled errors messages default to: response.data.description, unless customErrorToast set.\r\nHandled successes do not redirect or display a message unless:\r\n\r\n- responseSuccessToast is set, toasting the response description\r\n- customSuccessToast is set, toasting the given message.\r\n\r\n","created_at":"2018-10-28T14:28:16Z","updated_at":"2018-10-28T15:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c4a6f47e2a674422ff7acd5a88aa4a23b33d84f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480/commits","review_comments_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480/comments","review_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/480/comments","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/bb4d6020d88468b4d246d3c92b6023841080793d","head":{"label":"eJourn-al:bugfix/xss","ref":"bugfix/xss","sha":"bb4d6020d88468b4d246d3c92b6023841080793d","user":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"repo":{"id":136030378,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAzNzg=","name":"eJournal","full_name":"eJourn-al/eJournal","private":false,"owner":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eJourn-al/eJournal","description":"eJournal is a platform for long term assignments designed for virtual learning environments.","fork":false,"url":"https://api.github.com/repos/eJourn-al/eJournal","forks_url":"https://api.github.com/repos/eJourn-al/eJournal/forks","keys_url":"https://api.github.com/repos/eJourn-al/eJournal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eJourn-al/eJournal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eJourn-al/eJournal/teams","hooks_url":"https://api.github.com/repos/eJourn-al/eJournal/hooks","issue_events_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/events{/number}","events_url":"https://api.github.com/repos/eJourn-al/eJournal/events","assignees_url":"https://api.github.com/repos/eJourn-al/eJournal/assignees{/user}","branches_url":"https://api.github.com/repos/eJourn-al/eJournal/branches{/branch}","tags_url":"https://api.github.com/repos/eJourn-al/eJournal/tags","blobs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eJourn-al/eJournal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/refs{/sha}","trees_url":"https://api.github.com/repos/eJourn-al/eJournal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/{sha}","languages_url":"https://api.github.com/repos/eJourn-al/eJournal/languages","stargazers_url":"https://api.github.com/repos/eJourn-al/eJournal/stargazers","contributors_url":"https://api.github.com/repos/eJourn-al/eJournal/contributors","subscribers_url":"https://api.github.com/repos/eJourn-al/eJournal/subscribers","subscription_url":"https://api.github.com/repos/eJourn-al/eJournal/subscription","commits_url":"https://api.github.com/repos/eJourn-al/eJournal/commits{/sha}","git_commits_url":"https://api.github.com/repos/eJourn-al/eJournal/git/commits{/sha}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/comments{/number}","issue_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/comments{/number}","contents_url":"https://api.github.com/repos/eJourn-al/eJournal/contents/{+path}","compare_url":"https://api.github.com/repos/eJourn-al/eJournal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eJourn-al/eJournal/merges","archive_url":"https://api.github.com/repos/eJourn-al/eJournal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eJourn-al/eJournal/downloads","issues_url":"https://api.github.com/repos/eJourn-al/eJournal/issues{/number}","pulls_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls{/number}","milestones_url":"https://api.github.com/repos/eJourn-al/eJournal/milestones{/number}","notifications_url":"https://api.github.com/repos/eJourn-al/eJournal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eJourn-al/eJournal/labels{/name}","releases_url":"https://api.github.com/repos/eJourn-al/eJournal/releases{/id}","deployments_url":"https://api.github.com/repos/eJourn-al/eJournal/deployments","created_at":"2018-06-04T13:36:31Z","updated_at":"2018-10-28T11:40:20Z","pushed_at":"2018-10-28T14:28:17Z","git_url":"git://github.com/eJourn-al/eJournal.git","ssh_url":"git@github.com:eJourn-al/eJournal.git","clone_url":"https://github.com/eJourn-al/eJournal.git","svn_url":"https://github.com/eJourn-al/eJournal","homepage":"https://eJourn.al","size":23592,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":60,"watchers":10,"default_branch":"develop"}},"base":{"label":"eJourn-al:develop","ref":"develop","sha":"e7f40a0cacfd27a4a14c4be062bb704b81b88ee7","user":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"repo":{"id":136030378,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAzNzg=","name":"eJournal","full_name":"eJourn-al/eJournal","private":false,"owner":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eJourn-al/eJournal","description":"eJournal is a platform for long term assignments designed for virtual learning environments.","fork":false,"url":"https://api.github.com/repos/eJourn-al/eJournal","forks_url":"https://api.github.com/repos/eJourn-al/eJournal/forks","keys_url":"https://api.github.com/repos/eJourn-al/eJournal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eJourn-al/eJournal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eJourn-al/eJournal/teams","hooks_url":"https://api.github.com/repos/eJourn-al/eJournal/hooks","issue_events_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/events{/number}","events_url":"https://api.github.com/repos/eJourn-al/eJournal/events","assignees_url":"https://api.github.com/repos/eJourn-al/eJournal/assignees{/user}","branches_url":"https://api.github.com/repos/eJourn-al/eJournal/branches{/branch}","tags_url":"https://api.github.com/repos/eJourn-al/eJournal/tags","blobs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eJourn-al/eJournal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/refs{/sha}","trees_url":"https://api.github.com/repos/eJourn-al/eJournal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/{sha}","languages_url":"https://api.github.com/repos/eJourn-al/eJournal/languages","stargazers_url":"https://api.github.com/repos/eJourn-al/eJournal/stargazers","contributors_url":"https://api.github.com/repos/eJourn-al/eJournal/contributors","subscribers_url":"https://api.github.com/repos/eJourn-al/eJournal/subscribers","subscription_url":"https://api.github.com/repos/eJourn-al/eJournal/subscription","commits_url":"https://api.github.com/repos/eJourn-al/eJournal/commits{/sha}","git_commits_url":"https://api.github.com/repos/eJourn-al/eJournal/git/commits{/sha}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/comments{/number}","issue_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/comments{/number}","contents_url":"https://api.github.com/repos/eJourn-al/eJournal/contents/{+path}","compare_url":"https://api.github.com/repos/eJourn-al/eJournal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eJourn-al/eJournal/merges","archive_url":"https://api.github.com/repos/eJourn-al/eJournal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eJourn-al/eJournal/downloads","issues_url":"https://api.github.com/repos/eJourn-al/eJournal/issues{/number}","pulls_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls{/number}","milestones_url":"https://api.github.com/repos/eJourn-al/eJournal/milestones{/number}","notifications_url":"https://api.github.com/repos/eJourn-al/eJournal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eJourn-al/eJournal/labels{/name}","releases_url":"https://api.github.com/repos/eJourn-al/eJournal/releases{/id}","deployments_url":"https://api.github.com/repos/eJourn-al/eJournal/deployments","created_at":"2018-06-04T13:36:31Z","updated_at":"2018-10-28T11:40:20Z","pushed_at":"2018-10-28T14:28:17Z","git_url":"git://github.com/eJourn-al/eJournal.git","ssh_url":"git@github.com:eJourn-al/eJournal.git","clone_url":"https://github.com/eJourn-al/eJournal.git","svn_url":"https://github.com/eJourn-al/eJournal","homepage":"https://eJourn.al","size":23592,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":60,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480"},"html":{"href":"https://github.com/eJourn-al/eJournal/pull/480"},"issue":{"href":"https://api.github.com/repos/eJourn-al/eJournal/issues/480"},"comments":{"href":"https://api.github.com/repos/eJourn-al/eJournal/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/eJourn-al/eJournal/statuses/bb4d6020d88468b4d246d3c92b6023841080793d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Larspolo"}}