{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347/events","html_url":"https://github.com/pandas-dev/pandas/pull/20347","id":305189209,"number":20347,"title":"API: str.cat will align on Series","user":{"login":"h-vetinari","id":33685575,"avatar_url":"https://avatars1.githubusercontent.com/u/33685575?v=4","gravatar_id":"","url":"https://api.github.com/users/h-vetinari","html_url":"https://github.com/h-vetinari","followers_url":"https://api.github.com/users/h-vetinari/followers","following_url":"https://api.github.com/users/h-vetinari/following{/other_user}","gists_url":"https://api.github.com/users/h-vetinari/gists{/gist_id}","starred_url":"https://api.github.com/users/h-vetinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-vetinari/subscriptions","organizations_url":"https://api.github.com/users/h-vetinari/orgs","repos_url":"https://api.github.com/users/h-vetinari/repos","events_url":"https://api.github.com/users/h-vetinari/events{/privacy}","received_events_url":"https://api.github.com/users/h-vetinari/received_events","type":"User","site_admin":false},"labels":[{"id":35818298,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/API%20Design","name":"API Design","color":"AD7FA8","default":false},{"id":57522093,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Strings","name":"Strings","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":70,"created_at":"2018-03-14T14:44:38Z","updated_at":"2018-05-01T14:40:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20347","html_url":"https://github.com/pandas-dev/pandas/pull/20347","diff_url":"https://github.com/pandas-dev/pandas/pull/20347.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/20347.patch"},"body":"Fixes issue #18657, fixed existing tests, added new test; all pass.\r\n\r\nAfter I pushed everything and thought about it some more, I realised that one may argue about the default alignment-behavior, and whether it should be changed to `join=outer`. The behavior as implemented is compatible with the current requirement that everything be of the same length. To me, it is more intuitive that the concatenated `other` is added to the current series without enlarging it, but I can also see the argument why that restriction is unnecessary.\r\n\r\nPS. This is my first PR, tried to follow all the rules. Sorry if I overlooked something.\r\n\r\nEdit: Also fixes #20842 "},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/385686992","html_url":"https://github.com/pandas-dev/pandas/pull/20347#issuecomment-385686992","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20347","id":385686992,"user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T14:40:07Z","updated_at":"2018-05-01T14:40:07Z","author_association":"CONTRIBUTOR","body":"Right, we'll keep you on the hook for future maintenance of this :) We can\ndo the small things in the RC period.\n\nOn Tue, May 1, 2018 at 9:31 AM, h-vetinari <notifications@github.com> wrote:\n\n> @TomAugspurger <https://github.com/TomAugspurger>\n> Thanks for waiting with the cut-off! I meant that small fixes like the\n> typos you found (or dealing with dict) can still be sorted between RC and\n> final.\n>\n> FYI, the Appveyor-queue still has one build before mine, so 2*~45min =\n> 1h:30 before it's through.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/pandas-dev/pandas/pull/20347#issuecomment-385684844>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABQHIhl_RuNNbeM62P-QVU9CW-gwO5Qtks5tuHG7gaJpZM4SqkE_>\n> .\n>\n"}}
{"actor":{"display_login":"TomAugspurger"}}