{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21","id":193180362,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTgwMzYy","html_url":"https://github.com/lmc-eu/php-coding-standard/pull/21","diff_url":"https://github.com/lmc-eu/php-coding-standard/pull/21.diff","patch_url":"https://github.com/lmc-eu/php-coding-standard/pull/21.patch","issue_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/21","number":21,"state":"open","locked":false,"title":"Fix false positives on one-line annotations with PHP_CS 3.3.0","user":{"login":"OndraM","id":793041,"node_id":"MDQ6VXNlcjc5MzA0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/793041?v=4","gravatar_id":"","url":"https://api.github.com/users/OndraM","html_url":"https://github.com/OndraM","followers_url":"https://api.github.com/users/OndraM/followers","following_url":"https://api.github.com/users/OndraM/following{/other_user}","gists_url":"https://api.github.com/users/OndraM/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraM/subscriptions","organizations_url":"https://api.github.com/users/OndraM/orgs","repos_url":"https://api.github.com/users/OndraM/repos","events_url":"https://api.github.com/users/OndraM/events{/privacy}","received_events_url":"https://api.github.com/users/OndraM/received_events","type":"User","site_admin":false},"body":"PHP_CodeSniffer 3.3.0 was just released, and behavior of `Generic.Commenting.DocComment.SpacingBeforeTags` sniff code changed, so even with our current excludes, it don't allow one-line annotations (which we use):\r\n```\r\nclass Example\r\n{\r\n    /** @var string */\r\n    private $userId;\r\n    /** @var string[] */\r\n    private $itemIds = [];\r\n}\r\n```\r\nWhich will now cause an error \"There must be exactly one blank line before the tags in a doc comment\".\r\n\r\nThis PR adds this code to other excludes of DocCommentSniff we already have in order to allow  short annotations are do not considered them codestyle violation.","created_at":"2018-06-07T01:18:19Z","updated_at":"2018-06-07T01:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":868399064,"node_id":"MDU6TGFiZWw4NjgzOTkwNjQ=","url":"https://api.github.com/repos/lmc-eu/php-coding-standard/labels/bug","name":"bug","color":"d73a4a","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21/commits","review_comments_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21/comments","review_comment_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/21/comments","statuses_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/statuses/25ff51e2236dd96b76519526a329d167ce862e6b","head":{"label":"OndraM:bugfix/phpcs-3.3.0","ref":"bugfix/phpcs-3.3.0","sha":"25ff51e2236dd96b76519526a329d167ce862e6b","user":{"login":"OndraM","id":793041,"node_id":"MDQ6VXNlcjc5MzA0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/793041?v=4","gravatar_id":"","url":"https://api.github.com/users/OndraM","html_url":"https://github.com/OndraM","followers_url":"https://api.github.com/users/OndraM/followers","following_url":"https://api.github.com/users/OndraM/following{/other_user}","gists_url":"https://api.github.com/users/OndraM/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraM/subscriptions","organizations_url":"https://api.github.com/users/OndraM/orgs","repos_url":"https://api.github.com/users/OndraM/repos","events_url":"https://api.github.com/users/OndraM/events{/privacy}","received_events_url":"https://api.github.com/users/OndraM/received_events","type":"User","site_admin":false},"repo":{"id":126047133,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwNDcxMzM=","name":"php-coding-standard","full_name":"OndraM/php-coding-standard","owner":{"login":"OndraM","id":793041,"node_id":"MDQ6VXNlcjc5MzA0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/793041?v=4","gravatar_id":"","url":"https://api.github.com/users/OndraM","html_url":"https://github.com/OndraM","followers_url":"https://api.github.com/users/OndraM/followers","following_url":"https://api.github.com/users/OndraM/following{/other_user}","gists_url":"https://api.github.com/users/OndraM/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraM/subscriptions","organizations_url":"https://api.github.com/users/OndraM/orgs","repos_url":"https://api.github.com/users/OndraM/repos","events_url":"https://api.github.com/users/OndraM/events{/privacy}","received_events_url":"https://api.github.com/users/OndraM/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OndraM/php-coding-standard","description":"[WIP] PHP coding standard used in LMC projects","fork":true,"url":"https://api.github.com/repos/OndraM/php-coding-standard","forks_url":"https://api.github.com/repos/OndraM/php-coding-standard/forks","keys_url":"https://api.github.com/repos/OndraM/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OndraM/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OndraM/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/OndraM/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/OndraM/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/OndraM/php-coding-standard/events","assignees_url":"https://api.github.com/repos/OndraM/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/OndraM/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/OndraM/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/OndraM/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OndraM/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OndraM/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/OndraM/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OndraM/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/OndraM/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/OndraM/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/OndraM/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/OndraM/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/OndraM/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/OndraM/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/OndraM/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/OndraM/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/OndraM/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/OndraM/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/OndraM/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OndraM/php-coding-standard/merges","archive_url":"https://api.github.com/repos/OndraM/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OndraM/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/OndraM/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/OndraM/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/OndraM/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/OndraM/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OndraM/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/OndraM/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/OndraM/php-coding-standard/deployments","created_at":"2018-03-20T16:20:14Z","updated_at":"2018-05-14T15:13:39Z","pushed_at":"2018-06-07T01:17:24Z","git_url":"git://github.com/OndraM/php-coding-standard.git","ssh_url":"git@github.com:OndraM/php-coding-standard.git","clone_url":"https://github.com/OndraM/php-coding-standard.git","svn_url":"https://github.com/OndraM/php-coding-standard","homepage":"","size":43,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lmc-eu:master","ref":"master","sha":"55a8fd209a232429c9c348b7562db4df6a798a56","user":{"login":"lmc-eu","id":429615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTYxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/429615?v=4","gravatar_id":"","url":"https://api.github.com/users/lmc-eu","html_url":"https://github.com/lmc-eu","followers_url":"https://api.github.com/users/lmc-eu/followers","following_url":"https://api.github.com/users/lmc-eu/following{/other_user}","gists_url":"https://api.github.com/users/lmc-eu/gists{/gist_id}","starred_url":"https://api.github.com/users/lmc-eu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmc-eu/subscriptions","organizations_url":"https://api.github.com/users/lmc-eu/orgs","repos_url":"https://api.github.com/users/lmc-eu/repos","events_url":"https://api.github.com/users/lmc-eu/events{/privacy}","received_events_url":"https://api.github.com/users/lmc-eu/received_events","type":"Organization","site_admin":false},"repo":{"id":125386379,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzODYzNzk=","name":"php-coding-standard","full_name":"lmc-eu/php-coding-standard","owner":{"login":"lmc-eu","id":429615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTYxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/429615?v=4","gravatar_id":"","url":"https://api.github.com/users/lmc-eu","html_url":"https://github.com/lmc-eu","followers_url":"https://api.github.com/users/lmc-eu/followers","following_url":"https://api.github.com/users/lmc-eu/following{/other_user}","gists_url":"https://api.github.com/users/lmc-eu/gists{/gist_id}","starred_url":"https://api.github.com/users/lmc-eu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmc-eu/subscriptions","organizations_url":"https://api.github.com/users/lmc-eu/orgs","repos_url":"https://api.github.com/users/lmc-eu/repos","events_url":"https://api.github.com/users/lmc-eu/events{/privacy}","received_events_url":"https://api.github.com/users/lmc-eu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lmc-eu/php-coding-standard","description":"PHP coding standard used in LMC projects","fork":false,"url":"https://api.github.com/repos/lmc-eu/php-coding-standard","forks_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/forks","keys_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/events","assignees_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/merges","archive_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/lmc-eu/php-coding-standard/deployments","created_at":"2018-03-15T15:18:40Z","updated_at":"2018-05-14T15:14:00Z","pushed_at":"2018-05-14T15:14:07Z","git_url":"git://github.com/lmc-eu/php-coding-standard.git","ssh_url":"git@github.com:lmc-eu/php-coding-standard.git","clone_url":"https://github.com/lmc-eu/php-coding-standard.git","svn_url":"https://github.com/lmc-eu/php-coding-standard","homepage":"","size":43,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21"},"html":{"href":"https://github.com/lmc-eu/php-coding-standard/pull/21"},"issue":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/21"},"comments":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/lmc-eu/php-coding-standard/statuses/25ff51e2236dd96b76519526a329d167ce862e6b"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"OndraM"}}