{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/247","repository_url":"https://api.github.com/repos/Microsoft/GraphEngine","labels_url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/247/comments","events_url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/247/events","html_url":"https://github.com/Microsoft/GraphEngine/issues/247","id":387651453,"node_id":"MDU6SXNzdWUzODc2NTE0NTM=","number":247,"title":"Seems we remove the first 4 byte of message length data for LocalSendMessage?","user":{"login":"huoyao","id":5733388,"node_id":"MDQ6VXNlcjU3MzMzODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5733388?v=4","gravatar_id":"","url":"https://api.github.com/users/huoyao","html_url":"https://github.com/huoyao","followers_url":"https://api.github.com/users/huoyao/followers","following_url":"https://api.github.com/users/huoyao/following{/other_user}","gists_url":"https://api.github.com/users/huoyao/gists{/gist_id}","starred_url":"https://api.github.com/users/huoyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huoyao/subscriptions","organizations_url":"https://api.github.com/users/huoyao/orgs","repos_url":"https://api.github.com/users/huoyao/repos","events_url":"https://api.github.com/users/huoyao/events{/privacy}","received_events_url":"https://api.github.com/users/huoyao/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-05T08:51:42Z","updated_at":"2018-12-15T06:57:15Z","closed_at":"2018-12-15T06:57:15Z","author_association":"NONE","body":"https://github.com/Microsoft/GraphEngine/blob/3a83cba54f5d3d9b2cb1e6cf34670679a9dffcce/src/Trinity.Core/Storage/LocalMemoryStorage/LocalMemoryStorage.Message.cs#L36\r\n\r\nHere, we send the buf to native codes, but the buf has a 8 byte header with the first 4 byte **message length** data.\r\nShoule we remove the first 4 byte **message length** data?\r\n\r\nBecause in\r\nhttps://github.com/Microsoft/GraphEngine/blob/3a83cba54f5d3d9b2cb1e6cf34670679a9dffcce/src/Trinity.C/src/Events/Events.cpp#L423\r\nHere, \"**\\*(uint16_t*)message->buf**\" seems get 2 bytes of the message length. But, we supporse want to get the message type index here. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/comments/447543274","html_url":"https://github.com/Microsoft/GraphEngine/issues/247#issuecomment-447543274","issue_url":"https://api.github.com/repos/Microsoft/GraphEngine/issues/247","id":447543274,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzU0MzI3NA==","user":{"login":"yatli","id":20684720,"node_id":"MDQ6VXNlcjIwNjg0NzIw","avatar_url":"https://avatars3.githubusercontent.com/u/20684720?v=4","gravatar_id":"","url":"https://api.github.com/users/yatli","html_url":"https://github.com/yatli","followers_url":"https://api.github.com/users/yatli/followers","following_url":"https://api.github.com/users/yatli/following{/other_user}","gists_url":"https://api.github.com/users/yatli/gists{/gist_id}","starred_url":"https://api.github.com/users/yatli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatli/subscriptions","organizations_url":"https://api.github.com/users/yatli/orgs","repos_url":"https://api.github.com/users/yatli/repos","events_url":"https://api.github.com/users/yatli/events{/privacy}","received_events_url":"https://api.github.com/users/yatli/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T06:57:15Z","updated_at":"2018-12-15T06:57:15Z","author_association":"MEMBER","body":"closing this issue now;"}}
{"actor":{"display_login":"yatli"}}