{"action":"created","comment":{"url":"https://api.github.com/repos/swisspush/gateleen/pulls/comments/208201722","pull_request_review_id":143959451,"id":208201722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODIwMTcyMg==","diff_hunk":"@@ -277,7 +280,23 @@ public static CollectionResourceContainer verifyCollectionResponse(String target\n             throw new ResourceCollectionException(\"Request did not return data. Invalid usage of params \" + params + \" ?\", StatusCode.BAD_REQUEST);\n         }\n \n-        JsonObject obj = new JsonObject(data.toString(\"UTF-8\"));\n+        // Parse payload\n+        final String dataAsString = data.toString(UTF_8);\n+        final JsonObject obj;\n+        try {\n+            obj = new JsonObject(dataAsString);\n+        } catch (DecodeException e) {\n+            final int MAX_CHARS_TO_PRINT = 4096;","path":"gateleen-core/src/main/java/org/swisspush/gateleen/core/util/ExpansionDeltaUtil.java","position":37,"original_position":37,"commit_id":"720ff27433515a76553df3926977eb2407f857a8","original_commit_id":"720ff27433515a76553df3926977eb2407f857a8","user":{"login":"oli-h","id":20283081,"node_id":"MDQ6VXNlcjIwMjgzMDgx","avatar_url":"https://avatars0.githubusercontent.com/u/20283081?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-h","html_url":"https://github.com/oli-h","followers_url":"https://api.github.com/users/oli-h/followers","following_url":"https://api.github.com/users/oli-h/following{/other_user}","gists_url":"https://api.github.com/users/oli-h/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-h/subscriptions","organizations_url":"https://api.github.com/users/oli-h/orgs","repos_url":"https://api.github.com/users/oli-h/repos","events_url":"https://api.github.com/users/oli-h/events{/privacy}","received_events_url":"https://api.github.com/users/oli-h/received_events","type":"User","site_admin":false},"body":"Agree. Some limit makes sense.\r\nThough I have the feeling that 4096 is a bit small. Often Stacktraces themselves are 1-2 kBytes in size.\r\nSuggest to increase limit to 64k (65536) - and can be provide the URL from where we got the non-JSON-parseable response?","created_at":"2018-08-07T11:55:58Z","updated_at":"2018-08-07T11:55:59Z","html_url":"https://github.com/swisspush/gateleen/pull/242#discussion_r208201722","pull_request_url":"https://api.github.com/repos/swisspush/gateleen/pulls/242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/comments/208201722"},"html":{"href":"https://github.com/swisspush/gateleen/pull/242#discussion_r208201722"},"pull_request":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/242"}},"in_reply_to_id":208117544},"pull_request":{"url":"https://api.github.com/repos/swisspush/gateleen/pulls/242","id":206446823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDQ2ODIz","html_url":"https://github.com/swisspush/gateleen/pull/242","diff_url":"https://github.com/swisspush/gateleen/pull/242.diff","patch_url":"https://github.com/swisspush/gateleen/pull/242.patch","issue_url":"https://api.github.com/repos/swisspush/gateleen/issues/242","number":242,"state":"open","locked":false,"title":"240: Add error handling for crashing delta handler","user":{"login":"hiddenalpha","id":23085769,"node_id":"MDQ6VXNlcjIzMDg1NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/23085769?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddenalpha","html_url":"https://github.com/hiddenalpha","followers_url":"https://api.github.com/users/hiddenalpha/followers","following_url":"https://api.github.com/users/hiddenalpha/following{/other_user}","gists_url":"https://api.github.com/users/hiddenalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddenalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddenalpha/subscriptions","organizations_url":"https://api.github.com/users/hiddenalpha/orgs","repos_url":"https://api.github.com/users/hiddenalpha/repos","events_url":"https://api.github.com/users/hiddenalpha/events{/privacy}","received_events_url":"https://api.github.com/users/hiddenalpha/received_events","type":"User","site_admin":false},"body":"- Attach a general error handler in LocalHttpServerResponse to log such\r\n  issues\r\n- Handle undocumented DecodeException by throwing a corresponding\r\n  ResourceCollectionException","created_at":"2018-08-06T16:06:24Z","updated_at":"2018-08-07T11:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19396bb5d6ed74e69a9378384a9c912501b8dca9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swisspush/gateleen/pulls/242/commits","review_comments_url":"https://api.github.com/repos/swisspush/gateleen/pulls/242/comments","review_comment_url":"https://api.github.com/repos/swisspush/gateleen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swisspush/gateleen/issues/242/comments","statuses_url":"https://api.github.com/repos/swisspush/gateleen/statuses/720ff27433515a76553df3926977eb2407f857a8","head":{"label":"hiddenalpha:bugfix-240-deltaHandlerCrashOnUnexpectedUpstreamResponse","ref":"bugfix-240-deltaHandlerCrashOnUnexpectedUpstreamResponse","sha":"720ff27433515a76553df3926977eb2407f857a8","user":{"login":"hiddenalpha","id":23085769,"node_id":"MDQ6VXNlcjIzMDg1NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/23085769?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddenalpha","html_url":"https://github.com/hiddenalpha","followers_url":"https://api.github.com/users/hiddenalpha/followers","following_url":"https://api.github.com/users/hiddenalpha/following{/other_user}","gists_url":"https://api.github.com/users/hiddenalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddenalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddenalpha/subscriptions","organizations_url":"https://api.github.com/users/hiddenalpha/orgs","repos_url":"https://api.github.com/users/hiddenalpha/repos","events_url":"https://api.github.com/users/hiddenalpha/events{/privacy}","received_events_url":"https://api.github.com/users/hiddenalpha/received_events","type":"User","site_admin":false},"repo":{"id":81066516,"node_id":"MDEwOlJlcG9zaXRvcnk4MTA2NjUxNg==","name":"gateleen","full_name":"hiddenalpha/gateleen","owner":{"login":"hiddenalpha","id":23085769,"node_id":"MDQ6VXNlcjIzMDg1NzY5","avatar_url":"https://avatars0.githubusercontent.com/u/23085769?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddenalpha","html_url":"https://github.com/hiddenalpha","followers_url":"https://api.github.com/users/hiddenalpha/followers","following_url":"https://api.github.com/users/hiddenalpha/following{/other_user}","gists_url":"https://api.github.com/users/hiddenalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddenalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddenalpha/subscriptions","organizations_url":"https://api.github.com/users/hiddenalpha/orgs","repos_url":"https://api.github.com/users/hiddenalpha/repos","events_url":"https://api.github.com/users/hiddenalpha/events{/privacy}","received_events_url":"https://api.github.com/users/hiddenalpha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiddenalpha/gateleen","description":"Gateleen is a RESTful middleware toolkit for building API gateways","fork":true,"url":"https://api.github.com/repos/hiddenalpha/gateleen","forks_url":"https://api.github.com/repos/hiddenalpha/gateleen/forks","keys_url":"https://api.github.com/repos/hiddenalpha/gateleen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiddenalpha/gateleen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiddenalpha/gateleen/teams","hooks_url":"https://api.github.com/repos/hiddenalpha/gateleen/hooks","issue_events_url":"https://api.github.com/repos/hiddenalpha/gateleen/issues/events{/number}","events_url":"https://api.github.com/repos/hiddenalpha/gateleen/events","assignees_url":"https://api.github.com/repos/hiddenalpha/gateleen/assignees{/user}","branches_url":"https://api.github.com/repos/hiddenalpha/gateleen/branches{/branch}","tags_url":"https://api.github.com/repos/hiddenalpha/gateleen/tags","blobs_url":"https://api.github.com/repos/hiddenalpha/gateleen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiddenalpha/gateleen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiddenalpha/gateleen/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiddenalpha/gateleen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiddenalpha/gateleen/statuses/{sha}","languages_url":"https://api.github.com/repos/hiddenalpha/gateleen/languages","stargazers_url":"https://api.github.com/repos/hiddenalpha/gateleen/stargazers","contributors_url":"https://api.github.com/repos/hiddenalpha/gateleen/contributors","subscribers_url":"https://api.github.com/repos/hiddenalpha/gateleen/subscribers","subscription_url":"https://api.github.com/repos/hiddenalpha/gateleen/subscription","commits_url":"https://api.github.com/repos/hiddenalpha/gateleen/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiddenalpha/gateleen/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiddenalpha/gateleen/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiddenalpha/gateleen/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiddenalpha/gateleen/contents/{+path}","compare_url":"https://api.github.com/repos/hiddenalpha/gateleen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiddenalpha/gateleen/merges","archive_url":"https://api.github.com/repos/hiddenalpha/gateleen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiddenalpha/gateleen/downloads","issues_url":"https://api.github.com/repos/hiddenalpha/gateleen/issues{/number}","pulls_url":"https://api.github.com/repos/hiddenalpha/gateleen/pulls{/number}","milestones_url":"https://api.github.com/repos/hiddenalpha/gateleen/milestones{/number}","notifications_url":"https://api.github.com/repos/hiddenalpha/gateleen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiddenalpha/gateleen/labels{/name}","releases_url":"https://api.github.com/repos/hiddenalpha/gateleen/releases{/id}","deployments_url":"https://api.github.com/repos/hiddenalpha/gateleen/deployments","created_at":"2017-02-06T08:46:59Z","updated_at":"2017-02-06T08:47:01Z","pushed_at":"2018-08-06T16:04:53Z","git_url":"git://github.com/hiddenalpha/gateleen.git","ssh_url":"git@github.com:hiddenalpha/gateleen.git","clone_url":"https://github.com/hiddenalpha/gateleen.git","svn_url":"https://github.com/hiddenalpha/gateleen","homepage":"","size":2288,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swisspush:develop","ref":"develop","sha":"6942428da592d9dad71480b837d7f71eeb4514d9","user":{"login":"swisspush","id":6490266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0OTAyNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/6490266?v=4","gravatar_id":"","url":"https://api.github.com/users/swisspush","html_url":"https://github.com/swisspush","followers_url":"https://api.github.com/users/swisspush/followers","following_url":"https://api.github.com/users/swisspush/following{/other_user}","gists_url":"https://api.github.com/users/swisspush/gists{/gist_id}","starred_url":"https://api.github.com/users/swisspush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swisspush/subscriptions","organizations_url":"https://api.github.com/users/swisspush/orgs","repos_url":"https://api.github.com/users/swisspush/repos","events_url":"https://api.github.com/users/swisspush/events{/privacy}","received_events_url":"https://api.github.com/users/swisspush/received_events","type":"Organization","site_admin":false},"repo":{"id":52609528,"node_id":"MDEwOlJlcG9zaXRvcnk1MjYwOTUyOA==","name":"gateleen","full_name":"swisspush/gateleen","owner":{"login":"swisspush","id":6490266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0OTAyNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/6490266?v=4","gravatar_id":"","url":"https://api.github.com/users/swisspush","html_url":"https://github.com/swisspush","followers_url":"https://api.github.com/users/swisspush/followers","following_url":"https://api.github.com/users/swisspush/following{/other_user}","gists_url":"https://api.github.com/users/swisspush/gists{/gist_id}","starred_url":"https://api.github.com/users/swisspush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swisspush/subscriptions","organizations_url":"https://api.github.com/users/swisspush/orgs","repos_url":"https://api.github.com/users/swisspush/repos","events_url":"https://api.github.com/users/swisspush/events{/privacy}","received_events_url":"https://api.github.com/users/swisspush/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swisspush/gateleen","description":"Gateleen is a RESTful middleware toolkit for building API gateways","fork":false,"url":"https://api.github.com/repos/swisspush/gateleen","forks_url":"https://api.github.com/repos/swisspush/gateleen/forks","keys_url":"https://api.github.com/repos/swisspush/gateleen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swisspush/gateleen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swisspush/gateleen/teams","hooks_url":"https://api.github.com/repos/swisspush/gateleen/hooks","issue_events_url":"https://api.github.com/repos/swisspush/gateleen/issues/events{/number}","events_url":"https://api.github.com/repos/swisspush/gateleen/events","assignees_url":"https://api.github.com/repos/swisspush/gateleen/assignees{/user}","branches_url":"https://api.github.com/repos/swisspush/gateleen/branches{/branch}","tags_url":"https://api.github.com/repos/swisspush/gateleen/tags","blobs_url":"https://api.github.com/repos/swisspush/gateleen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swisspush/gateleen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swisspush/gateleen/git/refs{/sha}","trees_url":"https://api.github.com/repos/swisspush/gateleen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swisspush/gateleen/statuses/{sha}","languages_url":"https://api.github.com/repos/swisspush/gateleen/languages","stargazers_url":"https://api.github.com/repos/swisspush/gateleen/stargazers","contributors_url":"https://api.github.com/repos/swisspush/gateleen/contributors","subscribers_url":"https://api.github.com/repos/swisspush/gateleen/subscribers","subscription_url":"https://api.github.com/repos/swisspush/gateleen/subscription","commits_url":"https://api.github.com/repos/swisspush/gateleen/commits{/sha}","git_commits_url":"https://api.github.com/repos/swisspush/gateleen/git/commits{/sha}","comments_url":"https://api.github.com/repos/swisspush/gateleen/comments{/number}","issue_comment_url":"https://api.github.com/repos/swisspush/gateleen/issues/comments{/number}","contents_url":"https://api.github.com/repos/swisspush/gateleen/contents/{+path}","compare_url":"https://api.github.com/repos/swisspush/gateleen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swisspush/gateleen/merges","archive_url":"https://api.github.com/repos/swisspush/gateleen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swisspush/gateleen/downloads","issues_url":"https://api.github.com/repos/swisspush/gateleen/issues{/number}","pulls_url":"https://api.github.com/repos/swisspush/gateleen/pulls{/number}","milestones_url":"https://api.github.com/repos/swisspush/gateleen/milestones{/number}","notifications_url":"https://api.github.com/repos/swisspush/gateleen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swisspush/gateleen/labels{/name}","releases_url":"https://api.github.com/repos/swisspush/gateleen/releases{/id}","deployments_url":"https://api.github.com/repos/swisspush/gateleen/deployments","created_at":"2016-02-26T14:24:58Z","updated_at":"2018-08-03T06:16:39Z","pushed_at":"2018-08-06T16:06:25Z","git_url":"git://github.com/swisspush/gateleen.git","ssh_url":"git@github.com:swisspush/gateleen.git","clone_url":"https://github.com/swisspush/gateleen.git","svn_url":"https://github.com/swisspush/gateleen","homepage":"","size":2306,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":28,"watchers":51,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/242"},"html":{"href":"https://github.com/swisspush/gateleen/pull/242"},"issue":{"href":"https://api.github.com/repos/swisspush/gateleen/issues/242"},"comments":{"href":"https://api.github.com/repos/swisspush/gateleen/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swisspush/gateleen/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/swisspush/gateleen/statuses/720ff27433515a76553df3926977eb2407f857a8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"oli-h"}}