{"action":"closed","number":1157,"pull_request":{"url":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157","id":190773277,"html_url":"https://github.com/Gallopsled/pwntools/pull/1157","diff_url":"https://github.com/Gallopsled/pwntools/pull/1157.diff","patch_url":"https://github.com/Gallopsled/pwntools/pull/1157.patch","issue_url":"https://api.github.com/repos/Gallopsled/pwntools/issues/1157","number":1157,"state":"closed","locked":false,"title":"check if \":\" exists before index(':')","user":{"login":"excalibur44","id":17786395,"avatar_url":"https://avatars3.githubusercontent.com/u/17786395?v=4","gravatar_id":"","url":"https://api.github.com/users/excalibur44","html_url":"https://github.com/excalibur44","followers_url":"https://api.github.com/users/excalibur44/followers","following_url":"https://api.github.com/users/excalibur44/following{/other_user}","gists_url":"https://api.github.com/users/excalibur44/gists{/gist_id}","starred_url":"https://api.github.com/users/excalibur44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excalibur44/subscriptions","organizations_url":"https://api.github.com/users/excalibur44/orgs","repos_url":"https://api.github.com/users/excalibur44/repos","events_url":"https://api.github.com/users/excalibur44/events{/privacy}","received_events_url":"https://api.github.com/users/excalibur44/received_events","type":"User","site_admin":false},"body":"When I use `gdb.attach(p)`, I get an error: `ValueError: substring not found`\r\n\r\nI debug it and found that the file **/proc/%d/status** may have blank line. But util/proc.py doesn't solve it very well. If status file has blank line, then it will raise an error.\r\n\r\nSo I add some code to detect if \":\" exists. If find \":\" failed, it will continue.\r\n\r\nSorry for my bad english ...","created_at":"2018-05-27T06:45:09Z","updated_at":"2018-05-29T02:33:35Z","closed_at":"2018-05-29T02:33:35Z","merged_at":null,"merge_commit_sha":"8ab9adb012f4f1b2e07837eb1d5e8bba959babde","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157/commits","review_comments_url":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157/comments","review_comment_url":"https://api.github.com/repos/Gallopsled/pwntools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Gallopsled/pwntools/issues/1157/comments","statuses_url":"https://api.github.com/repos/Gallopsled/pwntools/statuses/f153096dc42e65b4f794d4e64c7c248272d3b464","head":{"label":"excalibur44:dev","ref":"dev","sha":"f153096dc42e65b4f794d4e64c7c248272d3b464","user":{"login":"excalibur44","id":17786395,"avatar_url":"https://avatars3.githubusercontent.com/u/17786395?v=4","gravatar_id":"","url":"https://api.github.com/users/excalibur44","html_url":"https://github.com/excalibur44","followers_url":"https://api.github.com/users/excalibur44/followers","following_url":"https://api.github.com/users/excalibur44/following{/other_user}","gists_url":"https://api.github.com/users/excalibur44/gists{/gist_id}","starred_url":"https://api.github.com/users/excalibur44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excalibur44/subscriptions","organizations_url":"https://api.github.com/users/excalibur44/orgs","repos_url":"https://api.github.com/users/excalibur44/repos","events_url":"https://api.github.com/users/excalibur44/events{/privacy}","received_events_url":"https://api.github.com/users/excalibur44/received_events","type":"User","site_admin":false},"repo":{"id":135021131,"name":"pwntools","full_name":"excalibur44/pwntools","owner":{"login":"excalibur44","id":17786395,"avatar_url":"https://avatars3.githubusercontent.com/u/17786395?v=4","gravatar_id":"","url":"https://api.github.com/users/excalibur44","html_url":"https://github.com/excalibur44","followers_url":"https://api.github.com/users/excalibur44/followers","following_url":"https://api.github.com/users/excalibur44/following{/other_user}","gists_url":"https://api.github.com/users/excalibur44/gists{/gist_id}","starred_url":"https://api.github.com/users/excalibur44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excalibur44/subscriptions","organizations_url":"https://api.github.com/users/excalibur44/orgs","repos_url":"https://api.github.com/users/excalibur44/repos","events_url":"https://api.github.com/users/excalibur44/events{/privacy}","received_events_url":"https://api.github.com/users/excalibur44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/excalibur44/pwntools","description":"CTF framework and exploit development library","fork":true,"url":"https://api.github.com/repos/excalibur44/pwntools","forks_url":"https://api.github.com/repos/excalibur44/pwntools/forks","keys_url":"https://api.github.com/repos/excalibur44/pwntools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excalibur44/pwntools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excalibur44/pwntools/teams","hooks_url":"https://api.github.com/repos/excalibur44/pwntools/hooks","issue_events_url":"https://api.github.com/repos/excalibur44/pwntools/issues/events{/number}","events_url":"https://api.github.com/repos/excalibur44/pwntools/events","assignees_url":"https://api.github.com/repos/excalibur44/pwntools/assignees{/user}","branches_url":"https://api.github.com/repos/excalibur44/pwntools/branches{/branch}","tags_url":"https://api.github.com/repos/excalibur44/pwntools/tags","blobs_url":"https://api.github.com/repos/excalibur44/pwntools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excalibur44/pwntools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excalibur44/pwntools/git/refs{/sha}","trees_url":"https://api.github.com/repos/excalibur44/pwntools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excalibur44/pwntools/statuses/{sha}","languages_url":"https://api.github.com/repos/excalibur44/pwntools/languages","stargazers_url":"https://api.github.com/repos/excalibur44/pwntools/stargazers","contributors_url":"https://api.github.com/repos/excalibur44/pwntools/contributors","subscribers_url":"https://api.github.com/repos/excalibur44/pwntools/subscribers","subscription_url":"https://api.github.com/repos/excalibur44/pwntools/subscription","commits_url":"https://api.github.com/repos/excalibur44/pwntools/commits{/sha}","git_commits_url":"https://api.github.com/repos/excalibur44/pwntools/git/commits{/sha}","comments_url":"https://api.github.com/repos/excalibur44/pwntools/comments{/number}","issue_comment_url":"https://api.github.com/repos/excalibur44/pwntools/issues/comments{/number}","contents_url":"https://api.github.com/repos/excalibur44/pwntools/contents/{+path}","compare_url":"https://api.github.com/repos/excalibur44/pwntools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excalibur44/pwntools/merges","archive_url":"https://api.github.com/repos/excalibur44/pwntools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excalibur44/pwntools/downloads","issues_url":"https://api.github.com/repos/excalibur44/pwntools/issues{/number}","pulls_url":"https://api.github.com/repos/excalibur44/pwntools/pulls{/number}","milestones_url":"https://api.github.com/repos/excalibur44/pwntools/milestones{/number}","notifications_url":"https://api.github.com/repos/excalibur44/pwntools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excalibur44/pwntools/labels{/name}","releases_url":"https://api.github.com/repos/excalibur44/pwntools/releases{/id}","deployments_url":"https://api.github.com/repos/excalibur44/pwntools/deployments","created_at":"2018-05-27T06:21:48Z","updated_at":"2018-05-27T06:26:14Z","pushed_at":"2018-05-29T02:32:40Z","git_url":"git://github.com/excalibur44/pwntools.git","ssh_url":"git@github.com:excalibur44/pwntools.git","clone_url":"https://github.com/excalibur44/pwntools.git","svn_url":"https://github.com/excalibur44/pwntools","homepage":"http://pwntools.com","size":21256,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Gallopsled:stable","ref":"stable","sha":"fe6619b33615544511bbd7b7088e6a41ef664510","user":{"login":"Gallopsled","id":4292577,"avatar_url":"https://avatars1.githubusercontent.com/u/4292577?v=4","gravatar_id":"","url":"https://api.github.com/users/Gallopsled","html_url":"https://github.com/Gallopsled","followers_url":"https://api.github.com/users/Gallopsled/followers","following_url":"https://api.github.com/users/Gallopsled/following{/other_user}","gists_url":"https://api.github.com/users/Gallopsled/gists{/gist_id}","starred_url":"https://api.github.com/users/Gallopsled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gallopsled/subscriptions","organizations_url":"https://api.github.com/users/Gallopsled/orgs","repos_url":"https://api.github.com/users/Gallopsled/repos","events_url":"https://api.github.com/users/Gallopsled/events{/privacy}","received_events_url":"https://api.github.com/users/Gallopsled/received_events","type":"Organization","site_admin":false},"repo":{"id":9750233,"name":"pwntools","full_name":"Gallopsled/pwntools","owner":{"login":"Gallopsled","id":4292577,"avatar_url":"https://avatars1.githubusercontent.com/u/4292577?v=4","gravatar_id":"","url":"https://api.github.com/users/Gallopsled","html_url":"https://github.com/Gallopsled","followers_url":"https://api.github.com/users/Gallopsled/followers","following_url":"https://api.github.com/users/Gallopsled/following{/other_user}","gists_url":"https://api.github.com/users/Gallopsled/gists{/gist_id}","starred_url":"https://api.github.com/users/Gallopsled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gallopsled/subscriptions","organizations_url":"https://api.github.com/users/Gallopsled/orgs","repos_url":"https://api.github.com/users/Gallopsled/repos","events_url":"https://api.github.com/users/Gallopsled/events{/privacy}","received_events_url":"https://api.github.com/users/Gallopsled/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Gallopsled/pwntools","description":"CTF framework and exploit development library","fork":false,"url":"https://api.github.com/repos/Gallopsled/pwntools","forks_url":"https://api.github.com/repos/Gallopsled/pwntools/forks","keys_url":"https://api.github.com/repos/Gallopsled/pwntools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gallopsled/pwntools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gallopsled/pwntools/teams","hooks_url":"https://api.github.com/repos/Gallopsled/pwntools/hooks","issue_events_url":"https://api.github.com/repos/Gallopsled/pwntools/issues/events{/number}","events_url":"https://api.github.com/repos/Gallopsled/pwntools/events","assignees_url":"https://api.github.com/repos/Gallopsled/pwntools/assignees{/user}","branches_url":"https://api.github.com/repos/Gallopsled/pwntools/branches{/branch}","tags_url":"https://api.github.com/repos/Gallopsled/pwntools/tags","blobs_url":"https://api.github.com/repos/Gallopsled/pwntools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gallopsled/pwntools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gallopsled/pwntools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gallopsled/pwntools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gallopsled/pwntools/statuses/{sha}","languages_url":"https://api.github.com/repos/Gallopsled/pwntools/languages","stargazers_url":"https://api.github.com/repos/Gallopsled/pwntools/stargazers","contributors_url":"https://api.github.com/repos/Gallopsled/pwntools/contributors","subscribers_url":"https://api.github.com/repos/Gallopsled/pwntools/subscribers","subscription_url":"https://api.github.com/repos/Gallopsled/pwntools/subscription","commits_url":"https://api.github.com/repos/Gallopsled/pwntools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gallopsled/pwntools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gallopsled/pwntools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gallopsled/pwntools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gallopsled/pwntools/contents/{+path}","compare_url":"https://api.github.com/repos/Gallopsled/pwntools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gallopsled/pwntools/merges","archive_url":"https://api.github.com/repos/Gallopsled/pwntools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gallopsled/pwntools/downloads","issues_url":"https://api.github.com/repos/Gallopsled/pwntools/issues{/number}","pulls_url":"https://api.github.com/repos/Gallopsled/pwntools/pulls{/number}","milestones_url":"https://api.github.com/repos/Gallopsled/pwntools/milestones{/number}","notifications_url":"https://api.github.com/repos/Gallopsled/pwntools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gallopsled/pwntools/labels{/name}","releases_url":"https://api.github.com/repos/Gallopsled/pwntools/releases{/id}","deployments_url":"https://api.github.com/repos/Gallopsled/pwntools/deployments","created_at":"2013-04-29T14:43:03Z","updated_at":"2018-05-29T00:21:04Z","pushed_at":"2018-05-27T06:45:10Z","git_url":"git://github.com/Gallopsled/pwntools.git","ssh_url":"git@github.com:Gallopsled/pwntools.git","clone_url":"https://github.com/Gallopsled/pwntools.git","svn_url":"https://github.com/Gallopsled/pwntools","homepage":"http://pwntools.com","size":21250,"stargazers_count":3905,"watchers_count":3905,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":807,"open_issues":78,"watchers":3905,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157"},"html":{"href":"https://github.com/Gallopsled/pwntools/pull/1157"},"issue":{"href":"https://api.github.com/repos/Gallopsled/pwntools/issues/1157"},"comments":{"href":"https://api.github.com/repos/Gallopsled/pwntools/issues/1157/comments"},"review_comments":{"href":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157/comments"},"review_comment":{"href":"https://api.github.com/repos/Gallopsled/pwntools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Gallopsled/pwntools/pulls/1157/commits"},"statuses":{"href":"https://api.github.com/repos/Gallopsled/pwntools/statuses/f153096dc42e65b4f794d4e64c7c248272d3b464"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":43,"additions":581,"deletions":248,"changed_files":111}}
{"actor":{"display_login":"excalibur44"}}