{"action":"created","issue":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/615","repository_url":"https://api.github.com/repos/pvlib/pvlib-python","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/615/labels{/name}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/615/comments","events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/615/events","html_url":"https://github.com/pvlib/pvlib-python/pull/615","id":379480522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTI1MzUw","number":615,"title":"ENH: iotools ecmwf macc","user":{"login":"mikofski","id":1385621,"node_id":"MDQ6VXNlcjEzODU2MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1385621?v=4","gravatar_id":"","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"labels":[{"id":177800479,"node_id":"MDU6TGFiZWwxNzc4MDA0Nzk=","url":"https://api.github.com/repos/pvlib/pvlib-python/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/22","html_url":"https://github.com/pvlib/pvlib-python/milestone/22","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/milestones/22/labels","id":3333501,"node_id":"MDk6TWlsZXN0b25lMzMzMzUwMQ==","number":22,"title":"0.6.1","description":"","creator":{"login":"wholmgren","id":4383303,"node_id":"MDQ6VXNlcjQzODMzMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":37,"state":"open","created_at":"2018-05-09T15:16:47Z","updated_at":"2018-12-14T00:56:55Z","due_on":"2018-07-15T07:00:00Z","closed_at":null},"comments":11,"created_at":"2018-11-11T01:48:55Z","updated_at":"2018-12-16T18:12:09Z","closed_at":"2018-12-14T00:56:55Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/615","html_url":"https://github.com/pvlib/pvlib-python/pull/615","diff_url":"https://github.com/pvlib/pvlib-python/pull/615.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/615.patch"},"body":"pvlib python pull request guidelines\r\n====================================\r\n\r\nThank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.\r\n\r\nYou may submit a pull request with your code at any stage of completion.\r\n\r\nThe following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:\r\n\r\n - [x] Closes  #602\r\n - [x] I am familiar with the [contributing guidelines](http://pvlib-python.readthedocs.io/en/latest/contributing.html).\r\n - [x] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.\r\n - [x] Updates entries to `docs/sphinx/source/api.rst` for API changes.\r\n - [x] Adds description and name entries in the appropriate `docs/sphinx/source/whatsnew` file for all changes.\r\n - [x] Code quality and style is sufficient. Passes LGTM and SticklerCI checks.\r\n - [x] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.\r\n - [x] Pull request is nearly complete and ready for detailed review.\r\n\r\nBrief description of the problem and proposed solution (if not already fully described in the issue linked to above):\r\n"},"comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments/447663978","html_url":"https://github.com/pvlib/pvlib-python/pull/615#issuecomment-447663978","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/615","id":447663978,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzY2Mzk3OA==","user":{"login":"mikofski","id":1385621,"node_id":"MDQ6VXNlcjEzODU2MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1385621?v=4","gravatar_id":"","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"created_at":"2018-12-16T18:12:09Z","updated_at":"2018-12-16T18:12:09Z","author_association":"CONTRIBUTOR","body":"@cwhanse and @wholmgren , I was thinking, I *could* add a test for `get_emcwf_macc` that just checks that `t.is_alive` is true, because `pytest` will exit and kill the thread, and processing by ecmwf of the request is enough to make sure the parameters are correct, if bad then the thread would die right away, this would improve coverage a little bit, maybe 25%, but to do it is have to edit the Travis yaml to pip install the ecmwfapi client from source bc it's not available from pypi, so you can decide if it's worth it"}}
{"actor":{"display_login":"mikofski"}}