{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/172404245","pull_request_review_id":101413347,"id":172404245,"diff_hunk":"@@ -103,30 +114,86 @@ You may also want to modify the `-p 80:80` to utilize other ports instead. Refer\n **Note**: if you're using the GPU Docker, skip ahead to the next section.\n \n ```bash\n-docker run -it -p 80:80 mms_image:latest\n+$ docker run -i -t -d -p 80:80 --name mms -v /home/user/models:/models mms_image:latest\n+# This runs the docker image in a detached mode\n ```\n-Now that you have a prompt inside the container, the final step is to run the following command:\n \n+To run the MMS with $HOSTNAME as its endpoint, or for `nginx's server_name` to be configured to `$HOSTNAME` run the following command.\n ```bash\n-cd mms_docker_cpu && ./launch.sh\n+$ echo $HOSTNAME\n+user.ant.amazon.com\n+\n+$ docker run -i -t -d -p 80:80 --name mms -v /home/user/models:/models -e MMS_HOST=$HOSTNAME mms_image:latest\n+```\n+The above command lets you run inference with `$HOSTNAME` as 'server_name'.  ","path":"docker/README.md","position":70,"original_position":70,"commit_id":"9d160902d7c0720f154bdc9632f4884418a8d419","original_commit_id":"0ff230c1601ae991124f2bd42568670e1fa015f7","user":{"login":"vdantu","id":36211508,"avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"body":"When nginx was configured with server_name as \"localhost\" I wasn't able to reach it with curl -X POST http://127.0.0.1:80/squeezenet/predict -F \"data=@kitten.jpg\". I get 404 error. So, I thought customers would want to use their public-ip to run inference.","created_at":"2018-03-06T04:05:32Z","updated_at":"2018-03-06T04:05:32Z","html_url":"https://github.com/awslabs/mxnet-model-server/pull/334#discussion_r172404245","pull_request_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments/172404245"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/334#discussion_r172404245"},"pull_request":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334"}},"in_reply_to_id":172392834},"pull_request":{"url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334","id":172765701,"html_url":"https://github.com/awslabs/mxnet-model-server/pull/334","diff_url":"https://github.com/awslabs/mxnet-model-server/pull/334.diff","patch_url":"https://github.com/awslabs/mxnet-model-server/pull/334.patch","issue_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/334","number":334,"state":"open","locked":false,"title":"Streamline Docker build code and Address multiple model file download issue in current Dockerized-MMS","user":{"login":"vdantu","id":36211508,"avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n\r\n*Description of changes:*\r\n1. Streamline the docker image build process.\r\n2. Make mms_app.conf more customizable.\r\n3. Decouple MMS instantiation and download/extract of Model files\r\n4. Modify MMS start-up script to make it \"docker exec\" friendly.\r\n5. Remove unnecessary files and directories.\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-03-05T03:21:50Z","updated_at":"2018-03-06T04:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cea49b259d7df786af10db61d192f3e2db6bb8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334/commits","review_comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334/comments","review_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/334/comments","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/9d160902d7c0720f154bdc9632f4884418a8d419","head":{"label":"vdantu:MultiFileDownloadFix","ref":"MultiFileDownloadFix","sha":"9d160902d7c0720f154bdc9632f4884418a8d419","user":{"login":"vdantu","id":36211508,"avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"repo":{"id":120691512,"name":"mxnet-model-server","full_name":"vdantu/mxnet-model-server","owner":{"login":"vdantu","id":36211508,"avatar_url":"https://avatars1.githubusercontent.com/u/36211508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdantu","html_url":"https://github.com/vdantu","followers_url":"https://api.github.com/users/vdantu/followers","following_url":"https://api.github.com/users/vdantu/following{/other_user}","gists_url":"https://api.github.com/users/vdantu/gists{/gist_id}","starred_url":"https://api.github.com/users/vdantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdantu/subscriptions","organizations_url":"https://api.github.com/users/vdantu/orgs","repos_url":"https://api.github.com/users/vdantu/repos","events_url":"https://api.github.com/users/vdantu/events{/privacy}","received_events_url":"https://api.github.com/users/vdantu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdantu/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for deploying neural net models for inference","fork":true,"url":"https://api.github.com/repos/vdantu/mxnet-model-server","forks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/vdantu/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdantu/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdantu/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/vdantu/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/vdantu/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/vdantu/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdantu/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vdantu/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/vdantu/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdantu/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdantu/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/vdantu/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdantu/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/vdantu/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdantu/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/vdantu/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/vdantu/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vdantu/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vdantu/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdantu/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/vdantu/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/vdantu/mxnet-model-server/deployments","created_at":"2018-02-08T00:55:11Z","updated_at":"2018-02-08T00:55:13Z","pushed_at":"2018-03-06T02:36:44Z","git_url":"git://github.com/vdantu/mxnet-model-server.git","ssh_url":"git@github.com:vdantu/mxnet-model-server.git","clone_url":"https://github.com/vdantu/mxnet-model-server.git","svn_url":"https://github.com/vdantu/mxnet-model-server","homepage":"","size":30631,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"60096ab4691aad8da7598166ccd68773d1849239","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105830539,"name":"mxnet-model-server","full_name":"awslabs/mxnet-model-server","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/mxnet-model-server","description":"Model Server for Apache MXNet is a tool for deploying neural net models for inference","fork":false,"url":"https://api.github.com/repos/awslabs/mxnet-model-server","forks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/forks","keys_url":"https://api.github.com/repos/awslabs/mxnet-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/mxnet-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/mxnet-model-server/teams","hooks_url":"https://api.github.com/repos/awslabs/mxnet-model-server/hooks","issue_events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/mxnet-model-server/events","assignees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/mxnet-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/tags","blobs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/mxnet-model-server/languages","stargazers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/stargazers","contributors_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contributors","subscribers_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscribers","subscription_url":"https://api.github.com/repos/awslabs/mxnet-model-server/subscription","commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/mxnet-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/mxnet-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/mxnet-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/mxnet-model-server/merges","archive_url":"https://api.github.com/repos/awslabs/mxnet-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/mxnet-model-server/downloads","issues_url":"https://api.github.com/repos/awslabs/mxnet-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/mxnet-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/mxnet-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/mxnet-model-server/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/mxnet-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/mxnet-model-server/deployments","created_at":"2017-10-04T23:41:07Z","updated_at":"2018-03-05T14:49:50Z","pushed_at":"2018-03-06T02:36:45Z","git_url":"git://github.com/awslabs/mxnet-model-server.git","ssh_url":"git@github.com:awslabs/mxnet-model-server.git","clone_url":"https://github.com/awslabs/mxnet-model-server.git","svn_url":"https://github.com/awslabs/mxnet-model-server","homepage":"","size":30604,"stargazers_count":142,"watchers_count":142,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":21,"open_issues":30,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334"},"html":{"href":"https://github.com/awslabs/mxnet-model-server/pull/334"},"issue":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/334"},"comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/mxnet-model-server/statuses/9d160902d7c0720f154bdc9632f4884418a8d419"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vdantu"}}