{"push_id":3158027744,"size":6,"distinct_size":0,"ref":"refs/heads/travis-ubuntu-bionic","head":"f49702e2f92468776f142dc28e68bba1a4e27067","before":"590dd127fcf15d2f51b4676c29d96db558f26e8f","commits":[{"sha":"169270757d6a2d61df730d1971613dff98db57eb","author":{"name":"D. Hugh Redelmeier","email":"a6c5230a10c458028ff1bd5985dd47c394028d47@mimosa.com"},"message":"pluto: plug multiple leaks of null_auth in ikev2_parent_inR1outI2_tail()","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/169270757d6a2d61df730d1971613dff98db57eb"},{"sha":"ca6287c54c8e87eec5975b46618ca44b9712499d","author":{"name":"Paul Wouters","email":"ec2c9f3bc0735a7b70259ffc693d94f4bcd4289e@redhat.com"},"message":"Revert \"Revert \"pluto: emit_v2N's \"critical\" parameter since it was identical in each call\"\"\n\nThis reverts commit 526a3c46693bdd521fbe4c739a33c4e8f5ce89c8.\n\nHugh was actually right, as per RFC 7296:\n\n   IKEv2 adds a \"critical\" flag to each payload header for further\n   flexibility for forward compatibility.  If the critical flag is set\n   and the payload type is unrecognized, the message MUST be rejected\n   and the response to the IKE request containing that payload MUST\n   include a Notify payload UNSUPPORTED_CRITICAL_PAYLOAD, indicating an\n   unsupported critical payload was included.  In that Notify payload,\n   the Notification Data contains the one-octet payload type.  If the\n   critical flag is not set and the payload type is unsupported, that\n   payload MUST be ignored.  Payloads sent in IKE response messages\n   MUST NOT have the critical flag set.  Note that the critical flag\n   applies only to the payload type, not the contents.  If the payload\n   type is recognized, but the payload contains something that is not\n   (such as an unknown transform inside an SA payload, or an unknown\n   Notify Message Type inside a Notify payload), the critical flag is\n   ignored.\n\nSo I guess this actually means, since we all must understand the Notify\ntype payload, even if we dont understand the content (notify type +\npayload), so all notify payloads do NOT set the critical flag.","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/ca6287c54c8e87eec5975b46618ca44b9712499d"},{"sha":"96702cd31f95f8c0214d29cc440e193e5ad01b45","author":{"name":"D. Hugh Redelmeier","email":"a6c5230a10c458028ff1bd5985dd47c394028d47@mimosa.com"},"message":"Merge branch 'master' of vault.libreswan.org:/srv/src/libreswan","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/96702cd31f95f8c0214d29cc440e193e5ad01b45"},{"sha":"60505257ae2d788ccd5ee66eb481712ed5596ca2","author":{"name":"D. Hugh Redelmeier","email":"a6c5230a10c458028ff1bd5985dd47c394028d47@mimosa.com"},"message":"pluto: get rid of a scope in ikev2_parent_inR1outI2_tail","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/60505257ae2d788ccd5ee66eb481712ed5596ca2"},{"sha":"c8ab90136dcb48a102fed84fbd97e9e7e7d007da","author":{"name":"Paul Wouters","email":"ec2c9f3bc0735a7b70259ffc693d94f4bcd4289e@redhat.com"},"message":"documentation: add comment about Critical Flag to emit_v2N()","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/c8ab90136dcb48a102fed84fbd97e9e7e7d007da"},{"sha":"f49702e2f92468776f142dc28e68bba1a4e27067","author":{"name":"Antony Antony","email":"1799296195846afeef14df836a5db11994803780@phenome.org"},"message":"Merge branch 'master' of https://github.com/libreswan/libreswan","distinct":false,"url":"https://api.github.com/repos/antonyantony/libreswan/commits/f49702e2f92468776f142dc28e68bba1a4e27067"}]}
{"actor":{"display_login":"antonyantony"}}