{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21455","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21455/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21455/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21455/events","html_url":"https://github.com/Microsoft/TypeScript/pull/21455","id":292473274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY1NzUzMzEz","number":21455,"title":"allowJs:true + declaration:true","user":{"login":"nojvek","id":1018196,"node_id":"MDQ6VXNlcjEwMTgxOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1018196?v=4","gravatar_id":"","url":"https://api.github.com/users/nojvek","html_url":"https://github.com/nojvek","followers_url":"https://api.github.com/users/nojvek/followers","following_url":"https://api.github.com/users/nojvek/following{/other_user}","gists_url":"https://api.github.com/users/nojvek/gists{/gist_id}","starred_url":"https://api.github.com/users/nojvek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojvek/subscriptions","organizations_url":"https://api.github.com/users/nojvek/orgs","repos_url":"https://api.github.com/users/nojvek/repos","events_url":"https://api.github.com/users/nojvek/events{/privacy}","received_events_url":"https://api.github.com/users/nojvek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-01-29T16:32:01Z","updated_at":"2018-08-22T19:50:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/21455","html_url":"https://github.com/Microsoft/TypeScript/pull/21455","diff_url":"https://github.com/Microsoft/TypeScript/pull/21455.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/21455.patch"},"body":" - [x] There is an associated issue. Fixes #7546\r\n - [x] Code is up-to-date with the `master` branch\r\n - [x] You've successfully run `jake runtests` locally\r\n - [x] You've signed the CLA\r\n - [x] There are new or updated unit tests validating the change\r\n\r\n** TODO **\r\n\r\nFrom previous PR: #15911\r\n\r\n - [ ] Fix commented out tsserver test. Not sure what the correct fix is \r\n - [ ] ES5 prototype style function definitions\r\n```\r\nfunction f() {\r\n}\r\nf.prototype.method = function() {}   // should probably emit a class?\r\n```\r\n - [ ] @typedef {Object} SpecialType -> Interfaces\r\n\r\n```\r\n/**\r\n * @typedef {object} SpecialType1 - creates a new type named 'SpecialType'\r\n * @property {string} prop1 - a string property of SpecialType\r\n * @property {number} prop2 - a number property of SpecialType\r\n * @property {number=} prop3 - an optional number property of SpecialType\r\n */\r\n/** @type {SpecialType1} */\r\nvar specialTypeObject1;\r\n```\r\n\r\n - [ ] Recognize @private/@readonly -> private X / readonly X\r\n\r\n```\r\n  /** @private */\r\n  _render() {...}\r\n\r\n  /** @readonly */\r\n  static observedAttributes() {...}\r\n```"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/415157562","html_url":"https://github.com/Microsoft/TypeScript/pull/21455#issuecomment-415157562","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/21455","id":415157562,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTE1NzU2Mg==","user":{"login":"nojvek","id":1018196,"node_id":"MDQ6VXNlcjEwMTgxOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1018196?v=4","gravatar_id":"","url":"https://api.github.com/users/nojvek","html_url":"https://github.com/nojvek","followers_url":"https://api.github.com/users/nojvek/followers","following_url":"https://api.github.com/users/nojvek/following{/other_user}","gists_url":"https://api.github.com/users/nojvek/gists{/gist_id}","starred_url":"https://api.github.com/users/nojvek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojvek/subscriptions","organizations_url":"https://api.github.com/users/nojvek/orgs","repos_url":"https://api.github.com/users/nojvek/repos","events_url":"https://api.github.com/users/nojvek/events{/privacy}","received_events_url":"https://api.github.com/users/nojvek/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T19:50:40Z","updated_at":"2018-08-22T19:50:40Z","author_association":"CONTRIBUTOR","body":"I basically just need to re-focus and get back into it. TSC has moved some pieces around so need to re-base and figure out the merge conflicts + tests.\r\n\r\nHopefully we don't end up bikeshedding again. Been trying to land this for a couple of years now :/"}}
{"actor":{"display_login":"nojvek"}}