{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/comments/241440862","pull_request_review_id":184712652,"id":241440862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ0MDg2Mg==","diff_hunk":"@@ -17,27 +15,31 @@ module \"saml_soap_proxy_ecs_asg\" {\n }\n \n data \"template_file\" \"saml_soap_proxy_task_def\" {\n-  template = \"${file(\"${path.module}/files/tasks/stub.json\")}\"\n+  template = \"${file(\"${path.module}/files/tasks/hub-saml-soap-proxy.json\")}\"\n \n   vars {\n-    app = \"saml_soap_proxy\"\n+    image_and_tag = \"${local.tools_account_ecr_url_prefix}-verify-saml-soap-proxy:latest\"\n+    domain        = \"${var.domain}\"\n+    deployment    = \"${var.deployment}\"\n   }\n }\n \n module \"saml_soap_proxy\" {\n   source = \"modules/ecs_app\"\n \n-  deployment            = \"${var.deployment}\"\n-  cluster               = \"saml-soap-proxy\"\n-  domain                = \"${var.domain}\"\n-  vpc_id                = \"${aws_vpc.hub.id}\"\n-  lb_subnets            = [\"${aws_subnet.internal.*.id}\"]\n-  task_definition       = \"${data.template_file.saml_soap_proxy_task_def.rendered}\"\n-  container_name        = \"stub\"\n-  container_port        = \"8080\"\n-  number_of_tasks       = 1\n-  health_check_protocol = \"HTTP\"\n-  tools_account_id      = \"${var.tools_account_id}\"\n+  deployment                 = \"${var.deployment}\"\n+  cluster                    = \"saml-soap-proxy\"\n+  domain                     = \"${var.domain}\"\n+  vpc_id                     = \"${aws_vpc.hub.id}\"\n+  lb_subnets                 = [\"${aws_subnet.internal.*.id}\"]\n+  task_definition            = \"${data.template_file.saml_soap_proxy_task_def.rendered}\"\n+  container_name             = \"saml-soap-proxy\"\n+  container_port             = \"8080\"\n+  number_of_tasks            = 1\n+  health_check_protocol      = \"HTTP\"\n+  health_check_path          = \"/saml-soap-proxy/matching-service-health-check\"\n+  tools_account_id           = \"${var.tools_account_id}\"\n   instance_security_group_id = \"${module.saml_soap_proxy_ecs_asg.instance_sg_id}\"\n   certificate_arn            = \"${data.aws_acm_certificate.wildcard.arn}\"\n+  image_name                 = \"verify-saml-soap-proxy\"","path":"terraform/modules/hub/hub_saml_soap_proxy.tf","position":64,"original_position":64,"commit_id":"6a642fac9655e12d87ae42a58137a93e70c83a62","original_commit_id":"6a642fac9655e12d87ae42a58137a93e70c83a62","user":{"login":"issyl0","id":355033,"node_id":"MDQ6VXNlcjM1NTAzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/355033?v=4","gravatar_id":"","url":"https://api.github.com/users/issyl0","html_url":"https://github.com/issyl0","followers_url":"https://api.github.com/users/issyl0/followers","following_url":"https://api.github.com/users/issyl0/following{/other_user}","gists_url":"https://api.github.com/users/issyl0/gists{/gist_id}","starred_url":"https://api.github.com/users/issyl0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/issyl0/subscriptions","organizations_url":"https://api.github.com/users/issyl0/orgs","repos_url":"https://api.github.com/users/issyl0/repos","events_url":"https://api.github.com/users/issyl0/events{/privacy}","received_events_url":"https://api.github.com/users/issyl0/received_events","type":"User","site_admin":false},"body":"What's the difference between `image_name` and `image_and_tag` in the variables?","created_at":"2018-12-13T15:21:50Z","updated_at":"2018-12-13T15:21:57Z","html_url":"https://github.com/alphagov/verify-infrastructure/pull/6#discussion_r241440862","pull_request_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/comments/241440862"},"html":{"href":"https://github.com/alphagov/verify-infrastructure/pull/6#discussion_r241440862"},"pull_request":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6","id":238360979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzYwOTc5","html_url":"https://github.com/alphagov/verify-infrastructure/pull/6","diff_url":"https://github.com/alphagov/verify-infrastructure/pull/6.diff","patch_url":"https://github.com/alphagov/verify-infrastructure/pull/6.patch","issue_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/6","number":6,"state":"open","locked":false,"title":"Enable and add task definition for saml-soap-proxy","user":{"login":"sakisv","id":4289633,"node_id":"MDQ6VXNlcjQyODk2MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4289633?v=4","gravatar_id":"","url":"https://api.github.com/users/sakisv","html_url":"https://github.com/sakisv","followers_url":"https://api.github.com/users/sakisv/followers","following_url":"https://api.github.com/users/sakisv/following{/other_user}","gists_url":"https://api.github.com/users/sakisv/gists{/gist_id}","starred_url":"https://api.github.com/users/sakisv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakisv/subscriptions","organizations_url":"https://api.github.com/users/sakisv/orgs","repos_url":"https://api.github.com/users/sakisv/repos","events_url":"https://api.github.com/users/sakisv/events{/privacy}","received_events_url":"https://api.github.com/users/sakisv/received_events","type":"User","site_admin":false},"body":"@bartlabno @sakisv","created_at":"2018-12-13T11:48:51Z","updated_at":"2018-12-13T15:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f49eba59bd76c0a83c9bfcecb828f12feb69547f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6/commits","review_comments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6/comments","review_comment_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/6/comments","statuses_url":"https://api.github.com/repos/alphagov/verify-infrastructure/statuses/6a642fac9655e12d87ae42a58137a93e70c83a62","head":{"label":"alphagov:auto-saml-soap-proxy","ref":"auto-saml-soap-proxy","sha":"6a642fac9655e12d87ae42a58137a93e70c83a62","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":159705375,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3MDUzNzU=","name":"verify-infrastructure","full_name":"alphagov/verify-infrastructure","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-infrastructure","description":"[Spike] Infrastructure code for GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-infrastructure","forks_url":"https://api.github.com/repos/alphagov/verify-infrastructure/forks","keys_url":"https://api.github.com/repos/alphagov/verify-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-infrastructure/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-infrastructure/events","assignees_url":"https://api.github.com/repos/alphagov/verify-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-infrastructure/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-infrastructure/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-infrastructure/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-infrastructure/merges","archive_url":"https://api.github.com/repos/alphagov/verify-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-infrastructure/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/deployments","created_at":"2018-11-29T17:46:38Z","updated_at":"2018-12-13T11:20:21Z","pushed_at":"2018-12-13T11:59:27Z","git_url":"git://github.com/alphagov/verify-infrastructure.git","ssh_url":"git@github.com:alphagov/verify-infrastructure.git","clone_url":"https://github.com/alphagov/verify-infrastructure.git","svn_url":"https://github.com/alphagov/verify-infrastructure","homepage":"","size":49,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"aa8848da42f0a45b0de2e32b58a82751588129b6","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":159705375,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3MDUzNzU=","name":"verify-infrastructure","full_name":"alphagov/verify-infrastructure","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/verify-infrastructure","description":"[Spike] Infrastructure code for GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-infrastructure","forks_url":"https://api.github.com/repos/alphagov/verify-infrastructure/forks","keys_url":"https://api.github.com/repos/alphagov/verify-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-infrastructure/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-infrastructure/events","assignees_url":"https://api.github.com/repos/alphagov/verify-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-infrastructure/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-infrastructure/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-infrastructure/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-infrastructure/merges","archive_url":"https://api.github.com/repos/alphagov/verify-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-infrastructure/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-infrastructure/deployments","created_at":"2018-11-29T17:46:38Z","updated_at":"2018-12-13T11:20:21Z","pushed_at":"2018-12-13T11:59:27Z","git_url":"git://github.com/alphagov/verify-infrastructure.git","ssh_url":"git@github.com:alphagov/verify-infrastructure.git","clone_url":"https://github.com/alphagov/verify-infrastructure.git","svn_url":"https://github.com/alphagov/verify-infrastructure","homepage":"","size":49,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6"},"html":{"href":"https://github.com/alphagov/verify-infrastructure/pull/6"},"issue":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/6"},"comments":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/verify-infrastructure/statuses/6a642fac9655e12d87ae42a58137a93e70c83a62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"issyl0"}}