{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1757","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1757/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1757/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1757/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1757","id":343328280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDEwODMy","number":1757,"title":"Fix key reset button issue under LP #1748001, plus some typo fixes in keycontrol.cpp","user":{"login":"beenisss","id":36423450,"node_id":"MDQ6VXNlcjM2NDIzNDUw","avatar_url":"https://avatars0.githubusercontent.com/u/36423450?v=4","gravatar_id":"","url":"https://api.github.com/users/beenisss","html_url":"https://github.com/beenisss","followers_url":"https://api.github.com/users/beenisss/followers","following_url":"https://api.github.com/users/beenisss/following{/other_user}","gists_url":"https://api.github.com/users/beenisss/gists{/gist_id}","starred_url":"https://api.github.com/users/beenisss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beenisss/subscriptions","organizations_url":"https://api.github.com/users/beenisss/orgs","repos_url":"https://api.github.com/users/beenisss/repos","events_url":"https://api.github.com/users/beenisss/events{/privacy}","received_events_url":"https://api.github.com/users/beenisss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-21T13:56:59Z","updated_at":"2018-07-22T20:06:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1757","html_url":"https://github.com/mixxxdj/mixxx/pull/1757","diff_url":"https://github.com/mixxxdj/mixxx/pull/1757.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1757.patch"},"body":"LP bug [here](https://bugs.launchpad.net/mixxx/+bug/1748001), Zulip discussion [here](https://mixxx.zulipchat.com/#narrow/stream/109171-development/subject/Reset.20key.20button.2Ftracks.20with.20no.20key/near/130053817)."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/406892984","html_url":"https://github.com/mixxxdj/mixxx/pull/1757#issuecomment-406892984","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1757","id":406892984,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjg5Mjk4NA==","user":{"login":"daschuer","id":1777442,"node_id":"MDQ6VXNlcjE3Nzc0NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"created_at":"2018-07-22T20:06:31Z","updated_at":"2018-07-22T20:06:31Z","author_association":"MEMBER","body":"Thank you for the PR. \r\nI am afraid we need to make it more complex to be complete. \r\n\r\nWhile I think the in the proposed slotResetKey() we can simplify it and always reset the pitch: \r\n```\r\nvoid KeyControl::slotResetKey(double v) {\r\n    if (v > 0) {\r\n            m_pPitch->set(0);\r\n            slotPitchChanged(0);\r\n    }\r\n}\r\n```\r\n\r\nIn setEngineKey we can continue to ignore the invalid key and do nothing. The issue is with \"visual_key_distance\". We can make it work as well. I think  it is \r\nfloor(pitch) or cail() + visual_key_distance depending to what is closer. \r\n\r\nBy the way: \r\nA pending issue is that the code assumes always the original track key as a full key. That is probably not always the case, depending of the trimming of the band, recording. For example A can be 440 .. 443 Hz. \r\n \r\n\r\n\r\n\r\n \r\n\r\n"}}
{"actor":{"display_login":"daschuer"}}