{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/226591647","pull_request_review_id":166452091,"id":226591647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU5MTY0Nw==","diff_hunk":"@@ -62,3 +62,28 @@ class BackendConfigurationError(BuildConfigurationError):\n \n class IncompatiblePlatformsError(Exception):\n   \"\"\"Indicates that target platforms are incompatible with a target that contains native code.\"\"\"\n+\n+\n+class GracefulTerminationException(Exception):","path":"src/python/pants/base/exceptions.py","position":null,"original_position":6,"commit_id":"802e6eb720430f8f29c589a0b42a59417d94619c","original_commit_id":"4164b9bd412d93dc9ffcea7b6e178489a0cf001c","user":{"login":"illicitonion","id":1131704,"node_id":"MDQ6VXNlcjExMzE3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1131704?v=4","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"body":"Moved into src/python/pants/rules/core/exceptions.py - happy to re-use `TaskError` if that feels better to folks, but I quite like single-purpose exceptions for this kind of context","created_at":"2018-10-19T09:49:34Z","updated_at":"2018-10-19T09:49:35Z","html_url":"https://github.com/pantsbuild/pants/pull/6654#discussion_r226591647","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/226591647"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6654#discussion_r226591647"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6654"}},"in_reply_to_id":226402610},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/6654","id":223983080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTgzMDgw","html_url":"https://github.com/pantsbuild/pants/pull/6654","diff_url":"https://github.com/pantsbuild/pants/pull/6654.diff","patch_url":"https://github.com/pantsbuild/pants/pull/6654.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/6654","number":6654,"state":"open","locked":false,"title":"console_rules can exit with exit codes","user":{"login":"illicitonion","id":1131704,"node_id":"MDQ6VXNlcjExMzE3MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1131704?v=4","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"body":"This will eagerly halt execution.","created_at":"2018-10-18T14:39:45Z","updated_at":"2018-10-19T09:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"673a19dafa0be190b408afcef97ebfe97931a7a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benjyw","id":512764,"node_id":"MDQ6VXNlcjUxMjc2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/512764?v=4","gravatar_id":"","url":"https://api.github.com/users/benjyw","html_url":"https://github.com/benjyw","followers_url":"https://api.github.com/users/benjyw/followers","following_url":"https://api.github.com/users/benjyw/following{/other_user}","gists_url":"https://api.github.com/users/benjyw/gists{/gist_id}","starred_url":"https://api.github.com/users/benjyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjyw/subscriptions","organizations_url":"https://api.github.com/users/benjyw/orgs","repos_url":"https://api.github.com/users/benjyw/repos","events_url":"https://api.github.com/users/benjyw/events{/privacy}","received_events_url":"https://api.github.com/users/benjyw/received_events","type":"User","site_admin":false},{"login":"blorente","id":5861182,"node_id":"MDQ6VXNlcjU4NjExODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5861182?v=4","gravatar_id":"","url":"https://api.github.com/users/blorente","html_url":"https://github.com/blorente","followers_url":"https://api.github.com/users/blorente/followers","following_url":"https://api.github.com/users/blorente/following{/other_user}","gists_url":"https://api.github.com/users/blorente/gists{/gist_id}","starred_url":"https://api.github.com/users/blorente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blorente/subscriptions","organizations_url":"https://api.github.com/users/blorente/orgs","repos_url":"https://api.github.com/users/blorente/repos","events_url":"https://api.github.com/users/blorente/events{/privacy}","received_events_url":"https://api.github.com/users/blorente/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6654/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6654/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/6654/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/802e6eb720430f8f29c589a0b42a59417d94619c","head":{"label":"twitter:dwagnerhall/v2/gracefultermination","ref":"dwagnerhall/v2/gracefultermination","sha":"802e6eb720430f8f29c589a0b42a59417d94619c","user":{"login":"twitter","id":50278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMjc4","avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":29317658,"node_id":"MDEwOlJlcG9zaXRvcnkyOTMxNzY1OA==","name":"pants","full_name":"twitter/pants","private":false,"owner":{"login":"twitter","id":50278,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMjc4","avatar_url":"https://avatars1.githubusercontent.com/u/50278?v=4","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twitter/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/twitter/pants","forks_url":"https://api.github.com/repos/twitter/pants/forks","keys_url":"https://api.github.com/repos/twitter/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/pants/teams","hooks_url":"https://api.github.com/repos/twitter/pants/hooks","issue_events_url":"https://api.github.com/repos/twitter/pants/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/pants/events","assignees_url":"https://api.github.com/repos/twitter/pants/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/pants/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/pants/tags","blobs_url":"https://api.github.com/repos/twitter/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/pants/languages","stargazers_url":"https://api.github.com/repos/twitter/pants/stargazers","contributors_url":"https://api.github.com/repos/twitter/pants/contributors","subscribers_url":"https://api.github.com/repos/twitter/pants/subscribers","subscription_url":"https://api.github.com/repos/twitter/pants/subscription","commits_url":"https://api.github.com/repos/twitter/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/pants/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/pants/merges","archive_url":"https://api.github.com/repos/twitter/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/pants/downloads","issues_url":"https://api.github.com/repos/twitter/pants/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/pants/labels{/name}","releases_url":"https://api.github.com/repos/twitter/pants/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/pants/deployments","created_at":"2015-01-15T20:51:58Z","updated_at":"2018-09-08T10:46:46Z","pushed_at":"2018-10-19T09:34:53Z","git_url":"git://github.com/twitter/pants.git","ssh_url":"git@github.com:twitter/pants.git","clone_url":"https://github.com/twitter/pants.git","svn_url":"https://github.com/twitter/pants","homepage":"http://pantsbuild.github.io/","size":121565,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":0,"watchers":64,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"4884683319ac964958a0f4885f7a1a790f470a2b","user":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA5MDc1","name":"pants","full_name":"pantsbuild/pants","private":false,"owner":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-10-18T23:05:25Z","pushed_at":"2018-10-19T09:34:56Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":88470,"stargazers_count":1038,"watchers_count":1038,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":725,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":300,"open_issues":725,"watchers":1038,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6654"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6654"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6654"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6654/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6654/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6654/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/802e6eb720430f8f29c589a0b42a59417d94619c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"illicitonion"}}