{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/comments/212678719","pull_request_review_id":149366063,"id":212678719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY3ODcxOQ==","diff_hunk":"@@ -34,6 +34,8 @@ def _make(elements = None):\n       A set containing the passed in values.\n     \"\"\"\n     elements = elements if elements else []\n+    if type(elements) == \"depset\":\n+        elements = elements.to_list()","path":"lib/new_sets.bzl","position":5,"original_position":5,"commit_id":"db6690a950ddb573ac6da65e4bb16d545d0076d9","original_commit_id":"db6690a950ddb573ac6da65e4bb16d545d0076d9","user":{"login":"laurentlb","id":485572,"node_id":"MDQ6VXNlcjQ4NTU3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/485572?v=4","gravatar_id":"","url":"https://api.github.com/users/laurentlb","html_url":"https://github.com/laurentlb","followers_url":"https://api.github.com/users/laurentlb/followers","following_url":"https://api.github.com/users/laurentlb/following{/other_user}","gists_url":"https://api.github.com/users/laurentlb/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentlb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentlb/subscriptions","organizations_url":"https://api.github.com/users/laurentlb/orgs","repos_url":"https://api.github.com/users/laurentlb/repos","events_url":"https://api.github.com/users/laurentlb/events{/privacy}","received_events_url":"https://api.github.com/users/laurentlb/received_events","type":"User","site_admin":false},"body":"The g3doc page is here: https://docs.bazel.build/versions/master/skylark/depsets.html#upcoming-changes","created_at":"2018-08-24T16:09:36Z","updated_at":"2018-08-24T16:09:36Z","html_url":"https://github.com/bazelbuild/bazel-skylib/pull/54#discussion_r212678719","pull_request_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/comments/212678719"},"html":{"href":"https://github.com/bazelbuild/bazel-skylib/pull/54#discussion_r212678719"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54"}},"in_reply_to_id":212568534},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54","id":210618406,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjE4NDA2","html_url":"https://github.com/bazelbuild/bazel-skylib/pull/54","diff_url":"https://github.com/bazelbuild/bazel-skylib/pull/54.diff","patch_url":"https://github.com/bazelbuild/bazel-skylib/pull/54.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/54","number":54,"state":"open","locked":false,"title":"All incompatible changes","user":{"login":"jjudd","id":3375226,"node_id":"MDQ6VXNlcjMzNzUyMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/3375226?v=4","gravatar_id":"","url":"https://api.github.com/users/jjudd","html_url":"https://github.com/jjudd","followers_url":"https://api.github.com/users/jjudd/followers","following_url":"https://api.github.com/users/jjudd/following{/other_user}","gists_url":"https://api.github.com/users/jjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/jjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjudd/subscriptions","organizations_url":"https://api.github.com/users/jjudd/orgs","repos_url":"https://api.github.com/users/jjudd/repos","events_url":"https://api.github.com/users/jjudd/events{/privacy}","received_events_url":"https://api.github.com/users/jjudd/received_events","type":"User","site_admin":false},"body":"This enables --all_incompatible_changes with Bazel 0.16. With this change, when things are deprecated in the future, builds will fail, and the deprecated features can be changed before they are actually removed from Bazel/Starlark.","created_at":"2018-08-24T01:43:28Z","updated_at":"2018-08-24T16:09:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42e50bf54c12b03f2841df05109e5b95b0547340","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":881603810,"node_id":"MDU6TGFiZWw4ODE2MDM4MTA=","url":"https://api.github.com/repos/bazelbuild/bazel-skylib/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/54/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/statuses/db6690a950ddb573ac6da65e4bb16d545d0076d9","head":{"label":"lucidsoftware:all-incompatible-changes","ref":"all-incompatible-changes","sha":"db6690a950ddb573ac6da65e4bb16d545d0076d9","user":{"login":"lucidsoftware","id":3140022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDAwMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3140022?v=4","gravatar_id":"","url":"https://api.github.com/users/lucidsoftware","html_url":"https://github.com/lucidsoftware","followers_url":"https://api.github.com/users/lucidsoftware/followers","following_url":"https://api.github.com/users/lucidsoftware/following{/other_user}","gists_url":"https://api.github.com/users/lucidsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidsoftware/subscriptions","organizations_url":"https://api.github.com/users/lucidsoftware/orgs","repos_url":"https://api.github.com/users/lucidsoftware/repos","events_url":"https://api.github.com/users/lucidsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/lucidsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":145926035,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MjYwMzU=","name":"bazel-skylib","full_name":"lucidsoftware/bazel-skylib","owner":{"login":"lucidsoftware","id":3140022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDAwMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3140022?v=4","gravatar_id":"","url":"https://api.github.com/users/lucidsoftware","html_url":"https://github.com/lucidsoftware","followers_url":"https://api.github.com/users/lucidsoftware/followers","following_url":"https://api.github.com/users/lucidsoftware/following{/other_user}","gists_url":"https://api.github.com/users/lucidsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/lucidsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucidsoftware/subscriptions","organizations_url":"https://api.github.com/users/lucidsoftware/orgs","repos_url":"https://api.github.com/users/lucidsoftware/repos","events_url":"https://api.github.com/users/lucidsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/lucidsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lucidsoftware/bazel-skylib","description":"Common useful functions for writing custom build rules with Skylark","fork":true,"url":"https://api.github.com/repos/lucidsoftware/bazel-skylib","forks_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/forks","keys_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/teams","hooks_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/hooks","issue_events_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/issues/events{/number}","events_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/events","assignees_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/assignees{/user}","branches_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/branches{/branch}","tags_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/tags","blobs_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/statuses/{sha}","languages_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/languages","stargazers_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/stargazers","contributors_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/contributors","subscribers_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/subscribers","subscription_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/subscription","commits_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/contents/{+path}","compare_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/merges","archive_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/downloads","issues_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/issues{/number}","pulls_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/pulls{/number}","milestones_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/milestones{/number}","notifications_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/labels{/name}","releases_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/releases{/id}","deployments_url":"https://api.github.com/repos/lucidsoftware/bazel-skylib/deployments","created_at":"2018-08-24T01:24:47Z","updated_at":"2018-08-24T01:24:49Z","pushed_at":"2018-08-24T01:41:48Z","git_url":"git://github.com/lucidsoftware/bazel-skylib.git","ssh_url":"git@github.com:lucidsoftware/bazel-skylib.git","clone_url":"https://github.com/lucidsoftware/bazel-skylib.git","svn_url":"https://github.com/lucidsoftware/bazel-skylib","homepage":"","size":83,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"7490380c6bbf9a5a060df78dc2222e7de6ffae5c","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":106432039,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0MzIwMzk=","name":"bazel-skylib","full_name":"bazelbuild/bazel-skylib","owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/bazel-skylib","description":"Common useful functions for writing custom build rules with Skylark","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel-skylib","forks_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel-skylib/deployments","created_at":"2017-10-10T14:57:57Z","updated_at":"2018-08-23T11:42:24Z","pushed_at":"2018-08-24T01:43:29Z","git_url":"git://github.com/bazelbuild/bazel-skylib.git","ssh_url":"git@github.com:bazelbuild/bazel-skylib.git","clone_url":"https://github.com/bazelbuild/bazel-skylib.git","svn_url":"https://github.com/bazelbuild/bazel-skylib","homepage":"","size":80,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":11,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54"},"html":{"href":"https://github.com/bazelbuild/bazel-skylib/pull/54"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/54"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel-skylib/statuses/db6690a950ddb573ac6da65e4bb16d545d0076d9"}},"author_association":"NONE"}}
{"actor":{"display_login":"laurentlb"}}