{"action":"created","issue":{"url":"https://api.github.com/repos/trestletech/plumber/issues/315","repository_url":"https://api.github.com/repos/trestletech/plumber","labels_url":"https://api.github.com/repos/trestletech/plumber/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/trestletech/plumber/issues/315/comments","events_url":"https://api.github.com/repos/trestletech/plumber/issues/315/events","html_url":"https://github.com/trestletech/plumber/pull/315","id":367672269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDI4MTkx","number":315,"title":"Accept NA handling arg for serializers","user":{"login":"namelessjon","id":2833,"node_id":"MDQ6VXNlcjI4MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2833?v=4","gravatar_id":"","url":"https://api.github.com/users/namelessjon","html_url":"https://github.com/namelessjon","followers_url":"https://api.github.com/users/namelessjon/followers","following_url":"https://api.github.com/users/namelessjon/following{/other_user}","gists_url":"https://api.github.com/users/namelessjon/gists{/gist_id}","starred_url":"https://api.github.com/users/namelessjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namelessjon/subscriptions","organizations_url":"https://api.github.com/users/namelessjon/orgs","repos_url":"https://api.github.com/users/namelessjon/repos","events_url":"https://api.github.com/users/namelessjon/events{/privacy}","received_events_url":"https://api.github.com/users/namelessjon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-08T07:51:00Z","updated_at":"2018-10-11T19:22:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/trestletech/plumber/pulls/315","html_url":"https://github.com/trestletech/plumber/pull/315","diff_url":"https://github.com/trestletech/plumber/pull/315.diff","patch_url":"https://github.com/trestletech/plumber/pull/315.patch"},"body":"Happy to receive any comments or feedback\r\n\r\nThis allows the use of `#' json(na = ...)` in a comment block, which is handled appropriately.  It requires the use of `purrr::partial` to apply the arguments, as otherwise the fact plumber uses R6 classes breaks relying on using simple closures.\r\n\r\nThis fixes #279 \r\n\r\nI think this code could be generalised to allow specification of any `toJSON` arguments."},"comment":{"url":"https://api.github.com/repos/trestletech/plumber/issues/comments/429086128","html_url":"https://github.com/trestletech/plumber/pull/315#issuecomment-429086128","issue_url":"https://api.github.com/repos/trestletech/plumber/issues/315","id":429086128,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTA4NjEyOA==","user":{"login":"namelessjon","id":2833,"node_id":"MDQ6VXNlcjI4MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2833?v=4","gravatar_id":"","url":"https://api.github.com/users/namelessjon","html_url":"https://github.com/namelessjon","followers_url":"https://api.github.com/users/namelessjon/followers","following_url":"https://api.github.com/users/namelessjon/following{/other_user}","gists_url":"https://api.github.com/users/namelessjon/gists{/gist_id}","starred_url":"https://api.github.com/users/namelessjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namelessjon/subscriptions","organizations_url":"https://api.github.com/users/namelessjon/orgs","repos_url":"https://api.github.com/users/namelessjon/repos","events_url":"https://api.github.com/users/namelessjon/events{/privacy}","received_events_url":"https://api.github.com/users/namelessjon/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T19:22:27Z","updated_at":"2018-10-11T19:22:27Z","author_association":"NONE","body":"Hi @schloerke \r\n\r\nThanks for the feedback.  I completely agree on not keeping up with the arguments, and did wonder about adding support for `...`.  I don't *think* that would break anything, and I'm willing to look at doing that.  I can also try and refactor the parse block code to avoid too much copy/paste.\r\n\r\n@wch I will look into that."}}
{"actor":{"display_login":"namelessjon"}}