{"action":"closed","number":25682,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/25682","id":216319740,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzE5NzQw","html_url":"https://github.com/laravel/framework/pull/25682","diff_url":"https://github.com/laravel/framework/pull/25682.diff","patch_url":"https://github.com/laravel/framework/pull/25682.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/25682","number":25682,"state":"closed","locked":false,"title":"[5.8] Updated the container for better PSR-11 ContainerInterface compliance","user":{"login":"Shawty81","id":8200183,"node_id":"MDQ6VXNlcjgyMDAxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8200183?v=4","gravatar_id":"","url":"https://api.github.com/users/Shawty81","html_url":"https://github.com/Shawty81","followers_url":"https://api.github.com/users/Shawty81/followers","following_url":"https://api.github.com/users/Shawty81/following{/other_user}","gists_url":"https://api.github.com/users/Shawty81/gists{/gist_id}","starred_url":"https://api.github.com/users/Shawty81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shawty81/subscriptions","organizations_url":"https://api.github.com/users/Shawty81/orgs","repos_url":"https://api.github.com/users/Shawty81/repos","events_url":"https://api.github.com/users/Shawty81/events{/privacy}","received_events_url":"https://api.github.com/users/Shawty81/received_events","type":"User","site_admin":false},"body":"@laurencei To be honest I did not run the HTTP tests because I wasn't able to configure PHPUnit properly. Tried for an hour or 2 but kept on getting hundreds of errors. By simply looking at the failed test I understand my changes cause it to fail. I can fix those, but as @deleugpn states this implementation might be a bit flawed...\r\n\r\nAfter a quick test and checking the PHP docs, only abstract classes will cause a problem. class_exists will return false on interface and traits and they both have their own respective _exists methods. I've updated my code to check through the Reflection API if the identifier resolves to an instantiable class.\r\n\r\nThen the only thing remaining is the comment made by @taylorotwell made here https://github.com/laravel/framework/pull/21327#issuecomment-331430213 :\r\n> Just because a class is concrete doesn't mean the Laravel container can resolve it. What if it has an interface dependency that isn't configured?\r\n\r\nTo that my response is:\r\nWhy would you check if all the dependencies are resolvable for a unbound class if you don't do that for a bound class? I mean currently I can bind any class with unresolvable dependencies and the code would break just as hard.","created_at":"2018-09-18T14:02:43Z","updated_at":"2018-09-19T18:39:30Z","closed_at":"2018-09-19T18:39:30Z","merged_at":null,"merge_commit_sha":"b736fe2cca8e725b67418a7d14838f5087bce5d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/25682/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/25682/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/25682/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/7081d543ab8061dc3083f41d53bcb8f470185ed8","head":{"label":"Weblab-nl:master","ref":"master","sha":"7081d543ab8061dc3083f41d53bcb8f470185ed8","user":{"login":"Weblab-nl","id":11502670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTAyNjcw","avatar_url":"https://avatars0.githubusercontent.com/u/11502670?v=4","gravatar_id":"","url":"https://api.github.com/users/Weblab-nl","html_url":"https://github.com/Weblab-nl","followers_url":"https://api.github.com/users/Weblab-nl/followers","following_url":"https://api.github.com/users/Weblab-nl/following{/other_user}","gists_url":"https://api.github.com/users/Weblab-nl/gists{/gist_id}","starred_url":"https://api.github.com/users/Weblab-nl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weblab-nl/subscriptions","organizations_url":"https://api.github.com/users/Weblab-nl/orgs","repos_url":"https://api.github.com/users/Weblab-nl/repos","events_url":"https://api.github.com/users/Weblab-nl/events{/privacy}","received_events_url":"https://api.github.com/users/Weblab-nl/received_events","type":"Organization","site_admin":false},"repo":{"id":148780593,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3ODA1OTM=","name":"framework","full_name":"Weblab-nl/framework","private":false,"owner":{"login":"Weblab-nl","id":11502670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTAyNjcw","avatar_url":"https://avatars0.githubusercontent.com/u/11502670?v=4","gravatar_id":"","url":"https://api.github.com/users/Weblab-nl","html_url":"https://github.com/Weblab-nl","followers_url":"https://api.github.com/users/Weblab-nl/followers","following_url":"https://api.github.com/users/Weblab-nl/following{/other_user}","gists_url":"https://api.github.com/users/Weblab-nl/gists{/gist_id}","starred_url":"https://api.github.com/users/Weblab-nl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weblab-nl/subscriptions","organizations_url":"https://api.github.com/users/Weblab-nl/orgs","repos_url":"https://api.github.com/users/Weblab-nl/repos","events_url":"https://api.github.com/users/Weblab-nl/events{/privacy}","received_events_url":"https://api.github.com/users/Weblab-nl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Weblab-nl/framework","description":null,"fork":true,"url":"https://api.github.com/repos/Weblab-nl/framework","forks_url":"https://api.github.com/repos/Weblab-nl/framework/forks","keys_url":"https://api.github.com/repos/Weblab-nl/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Weblab-nl/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Weblab-nl/framework/teams","hooks_url":"https://api.github.com/repos/Weblab-nl/framework/hooks","issue_events_url":"https://api.github.com/repos/Weblab-nl/framework/issues/events{/number}","events_url":"https://api.github.com/repos/Weblab-nl/framework/events","assignees_url":"https://api.github.com/repos/Weblab-nl/framework/assignees{/user}","branches_url":"https://api.github.com/repos/Weblab-nl/framework/branches{/branch}","tags_url":"https://api.github.com/repos/Weblab-nl/framework/tags","blobs_url":"https://api.github.com/repos/Weblab-nl/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Weblab-nl/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Weblab-nl/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Weblab-nl/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Weblab-nl/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Weblab-nl/framework/languages","stargazers_url":"https://api.github.com/repos/Weblab-nl/framework/stargazers","contributors_url":"https://api.github.com/repos/Weblab-nl/framework/contributors","subscribers_url":"https://api.github.com/repos/Weblab-nl/framework/subscribers","subscription_url":"https://api.github.com/repos/Weblab-nl/framework/subscription","commits_url":"https://api.github.com/repos/Weblab-nl/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Weblab-nl/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Weblab-nl/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Weblab-nl/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Weblab-nl/framework/contents/{+path}","compare_url":"https://api.github.com/repos/Weblab-nl/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Weblab-nl/framework/merges","archive_url":"https://api.github.com/repos/Weblab-nl/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Weblab-nl/framework/downloads","issues_url":"https://api.github.com/repos/Weblab-nl/framework/issues{/number}","pulls_url":"https://api.github.com/repos/Weblab-nl/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Weblab-nl/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Weblab-nl/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Weblab-nl/framework/labels{/name}","releases_url":"https://api.github.com/repos/Weblab-nl/framework/releases{/id}","deployments_url":"https://api.github.com/repos/Weblab-nl/framework/deployments","created_at":"2018-09-14T11:40:30Z","updated_at":"2018-09-14T11:40:39Z","pushed_at":"2018-09-18T14:09:00Z","git_url":"git://github.com/Weblab-nl/framework.git","ssh_url":"git@github.com:Weblab-nl/framework.git","clone_url":"https://github.com/Weblab-nl/framework.git","svn_url":"https://github.com/Weblab-nl/framework","homepage":"http://laravel.com","size":36312,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"laravel:master","ref":"master","sha":"3d7a97121c5dc129143f417c429091f0b80cf846","user":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"node_id":"MDEwOlJlcG9zaXRvcnk3NTQ4OTg2","name":"framework","full_name":"laravel/framework","private":false,"owner":{"login":"laravel","id":958072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1ODA3Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-09-19T18:37:02Z","pushed_at":"2018-09-19T18:36:58Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":36352,"stargazers_count":13922,"watchers_count":13922,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5790,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5790,"open_issues":201,"watchers":13922,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/25682"},"html":{"href":"https://github.com/laravel/framework/pull/25682"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/25682"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/25682/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/25682/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/25682/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/7081d543ab8061dc3083f41d53bcb8f470185ed8"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":59,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"taylorotwell"}}