{"action":"created","comment":{"url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/comments/241302918","pull_request_review_id":184539274,"id":241302918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTMwMjkxOA==","diff_hunk":"@@ -83,7 +80,7 @@ public void shouldIncrementInt() throws Exception{\n                 .andExpect(content().string(\"12\"));\n \n         mockMvc.perform(put(\"/actualkey4\").header(\"op\",\"INCR\"))\n-                .andExpect(status().isOk());","path":"eixampledb-api/src/test/java/com/eixampledb/api/MainControllerTest.java","position":null,"original_position":16,"commit_id":"87cb8ae78f4b90d437ff28fb508a03b0f6b8a391","original_commit_id":"87cb8ae78f4b90d437ff28fb508a03b0f6b8a391","user":{"login":"GuillermoBlasco","id":1889971,"node_id":"MDQ6VXNlcjE4ODk5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1889971?v=4","gravatar_id":"","url":"https://api.github.com/users/GuillermoBlasco","html_url":"https://github.com/GuillermoBlasco","followers_url":"https://api.github.com/users/GuillermoBlasco/followers","following_url":"https://api.github.com/users/GuillermoBlasco/following{/other_user}","gists_url":"https://api.github.com/users/GuillermoBlasco/gists{/gist_id}","starred_url":"https://api.github.com/users/GuillermoBlasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuillermoBlasco/subscriptions","organizations_url":"https://api.github.com/users/GuillermoBlasco/orgs","repos_url":"https://api.github.com/users/GuillermoBlasco/repos","events_url":"https://api.github.com/users/GuillermoBlasco/events{/privacy}","received_events_url":"https://api.github.com/users/GuillermoBlasco/received_events","type":"User","site_admin":false},"body":"Ok respones with empty body should return 204 status code.","created_at":"2018-12-13T08:09:07Z","updated_at":"2018-12-13T08:09:07Z","html_url":"https://github.com/EixampleDB/eixampledb/pull/2#discussion_r241302918","pull_request_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/comments/241302918"},"html":{"href":"https://github.com/EixampleDB/eixampledb/pull/2#discussion_r241302918"},"pull_request":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2","id":238169592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTY5NTky","html_url":"https://github.com/EixampleDB/eixampledb/pull/2","diff_url":"https://github.com/EixampleDB/eixampledb/pull/2.diff","patch_url":"https://github.com/EixampleDB/eixampledb/pull/2.patch","issue_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/2","number":2,"state":"open","locked":false,"title":"Number Type","user":{"login":"Xexio15","id":22416074,"node_id":"MDQ6VXNlcjIyNDE2MDc0","avatar_url":"https://avatars0.githubusercontent.com/u/22416074?v=4","gravatar_id":"","url":"https://api.github.com/users/Xexio15","html_url":"https://github.com/Xexio15","followers_url":"https://api.github.com/users/Xexio15/followers","following_url":"https://api.github.com/users/Xexio15/following{/other_user}","gists_url":"https://api.github.com/users/Xexio15/gists{/gist_id}","starred_url":"https://api.github.com/users/Xexio15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xexio15/subscriptions","organizations_url":"https://api.github.com/users/Xexio15/orgs","repos_url":"https://api.github.com/users/Xexio15/repos","events_url":"https://api.github.com/users/Xexio15/events{/privacy}","received_events_url":"https://api.github.com/users/Xexio15/received_events","type":"User","site_admin":false},"body":"**Requests Changes:**\r\n- `POST` method now has a new header `type` which is meant to have the type of introduced data. Currently available types are `STR` for String and `NUM` for any number no matter float or int. It's an optional header but if it's not in the request, the type is `STR` by default.\r\n\r\n- Added a `PUT` method to `/{key}` to make operations in over the keys values. Currently the available operations are increment and decrement by one. The operation to be realized is defined in the header `op` with the operation wanted as value, currently `INCR` for increment and `DECR` for decrement. The idea is that every operation over a key uses this function.\r\n\r\nMore information about the requests: https://hackmd.io/s/r1ojylJgE#\r\n\r\n**Implementation Changes:**\r\n- New attribute `int type` added to the `EixampleDbEntry` so we can know if a value is a number or a string, the idea is that new type come to the DB the only needed is to increment that number by one. \r\n\r\n- New class added in Core (`CoreServices`) to implement all the functions that do any operation, that way the code will be cleaner that putting every operation in the API wich is a bad practice.","created_at":"2018-12-12T20:19:42Z","updated_at":"2018-12-13T08:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2bf41e0fa8ba83b1386bbf6135113dedbdc091d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2/commits","review_comments_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2/comments","review_comment_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/2/comments","statuses_url":"https://api.github.com/repos/EixampleDB/eixampledb/statuses/87cb8ae78f4b90d437ff28fb508a03b0f6b8a391","head":{"label":"EixampleDB:dev-number-type","ref":"dev-number-type","sha":"87cb8ae78f4b90d437ff28fb508a03b0f6b8a391","user":{"login":"EixampleDB","id":45004791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDA0Nzkx","avatar_url":"https://avatars1.githubusercontent.com/u/45004791?v=4","gravatar_id":"","url":"https://api.github.com/users/EixampleDB","html_url":"https://github.com/EixampleDB","followers_url":"https://api.github.com/users/EixampleDB/followers","following_url":"https://api.github.com/users/EixampleDB/following{/other_user}","gists_url":"https://api.github.com/users/EixampleDB/gists{/gist_id}","starred_url":"https://api.github.com/users/EixampleDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EixampleDB/subscriptions","organizations_url":"https://api.github.com/users/EixampleDB/orgs","repos_url":"https://api.github.com/users/EixampleDB/repos","events_url":"https://api.github.com/users/EixampleDB/events{/privacy}","received_events_url":"https://api.github.com/users/EixampleDB/received_events","type":"Organization","site_admin":false},"repo":{"id":157190148,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxOTAxNDg=","name":"eixampledb","full_name":"EixampleDB/eixampledb","private":false,"owner":{"login":"EixampleDB","id":45004791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDA0Nzkx","avatar_url":"https://avatars1.githubusercontent.com/u/45004791?v=4","gravatar_id":"","url":"https://api.github.com/users/EixampleDB","html_url":"https://github.com/EixampleDB","followers_url":"https://api.github.com/users/EixampleDB/followers","following_url":"https://api.github.com/users/EixampleDB/following{/other_user}","gists_url":"https://api.github.com/users/EixampleDB/gists{/gist_id}","starred_url":"https://api.github.com/users/EixampleDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EixampleDB/subscriptions","organizations_url":"https://api.github.com/users/EixampleDB/orgs","repos_url":"https://api.github.com/users/EixampleDB/repos","events_url":"https://api.github.com/users/EixampleDB/events{/privacy}","received_events_url":"https://api.github.com/users/EixampleDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EixampleDB/eixampledb","description":"EixampleDb is a simple key-value store implemented in Java and Springframework","fork":false,"url":"https://api.github.com/repos/EixampleDB/eixampledb","forks_url":"https://api.github.com/repos/EixampleDB/eixampledb/forks","keys_url":"https://api.github.com/repos/EixampleDB/eixampledb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EixampleDB/eixampledb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EixampleDB/eixampledb/teams","hooks_url":"https://api.github.com/repos/EixampleDB/eixampledb/hooks","issue_events_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/events{/number}","events_url":"https://api.github.com/repos/EixampleDB/eixampledb/events","assignees_url":"https://api.github.com/repos/EixampleDB/eixampledb/assignees{/user}","branches_url":"https://api.github.com/repos/EixampleDB/eixampledb/branches{/branch}","tags_url":"https://api.github.com/repos/EixampleDB/eixampledb/tags","blobs_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/refs{/sha}","trees_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EixampleDB/eixampledb/statuses/{sha}","languages_url":"https://api.github.com/repos/EixampleDB/eixampledb/languages","stargazers_url":"https://api.github.com/repos/EixampleDB/eixampledb/stargazers","contributors_url":"https://api.github.com/repos/EixampleDB/eixampledb/contributors","subscribers_url":"https://api.github.com/repos/EixampleDB/eixampledb/subscribers","subscription_url":"https://api.github.com/repos/EixampleDB/eixampledb/subscription","commits_url":"https://api.github.com/repos/EixampleDB/eixampledb/commits{/sha}","git_commits_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/commits{/sha}","comments_url":"https://api.github.com/repos/EixampleDB/eixampledb/comments{/number}","issue_comment_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/comments{/number}","contents_url":"https://api.github.com/repos/EixampleDB/eixampledb/contents/{+path}","compare_url":"https://api.github.com/repos/EixampleDB/eixampledb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EixampleDB/eixampledb/merges","archive_url":"https://api.github.com/repos/EixampleDB/eixampledb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EixampleDB/eixampledb/downloads","issues_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues{/number}","pulls_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls{/number}","milestones_url":"https://api.github.com/repos/EixampleDB/eixampledb/milestones{/number}","notifications_url":"https://api.github.com/repos/EixampleDB/eixampledb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EixampleDB/eixampledb/labels{/name}","releases_url":"https://api.github.com/repos/EixampleDB/eixampledb/releases{/id}","deployments_url":"https://api.github.com/repos/EixampleDB/eixampledb/deployments","created_at":"2018-11-12T09:42:04Z","updated_at":"2018-12-08T16:54:03Z","pushed_at":"2018-12-13T08:04:42Z","git_url":"git://github.com/EixampleDB/eixampledb.git","ssh_url":"git@github.com:EixampleDB/eixampledb.git","clone_url":"https://github.com/EixampleDB/eixampledb.git","svn_url":"https://github.com/EixampleDB/eixampledb","homepage":"","size":62,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":6,"default_branch":"master"}},"base":{"label":"EixampleDB:master","ref":"master","sha":"844cd2d7db25184c73f4f9e67e06ea49c0148989","user":{"login":"EixampleDB","id":45004791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDA0Nzkx","avatar_url":"https://avatars1.githubusercontent.com/u/45004791?v=4","gravatar_id":"","url":"https://api.github.com/users/EixampleDB","html_url":"https://github.com/EixampleDB","followers_url":"https://api.github.com/users/EixampleDB/followers","following_url":"https://api.github.com/users/EixampleDB/following{/other_user}","gists_url":"https://api.github.com/users/EixampleDB/gists{/gist_id}","starred_url":"https://api.github.com/users/EixampleDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EixampleDB/subscriptions","organizations_url":"https://api.github.com/users/EixampleDB/orgs","repos_url":"https://api.github.com/users/EixampleDB/repos","events_url":"https://api.github.com/users/EixampleDB/events{/privacy}","received_events_url":"https://api.github.com/users/EixampleDB/received_events","type":"Organization","site_admin":false},"repo":{"id":157190148,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxOTAxNDg=","name":"eixampledb","full_name":"EixampleDB/eixampledb","private":false,"owner":{"login":"EixampleDB","id":45004791,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MDA0Nzkx","avatar_url":"https://avatars1.githubusercontent.com/u/45004791?v=4","gravatar_id":"","url":"https://api.github.com/users/EixampleDB","html_url":"https://github.com/EixampleDB","followers_url":"https://api.github.com/users/EixampleDB/followers","following_url":"https://api.github.com/users/EixampleDB/following{/other_user}","gists_url":"https://api.github.com/users/EixampleDB/gists{/gist_id}","starred_url":"https://api.github.com/users/EixampleDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EixampleDB/subscriptions","organizations_url":"https://api.github.com/users/EixampleDB/orgs","repos_url":"https://api.github.com/users/EixampleDB/repos","events_url":"https://api.github.com/users/EixampleDB/events{/privacy}","received_events_url":"https://api.github.com/users/EixampleDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EixampleDB/eixampledb","description":"EixampleDb is a simple key-value store implemented in Java and Springframework","fork":false,"url":"https://api.github.com/repos/EixampleDB/eixampledb","forks_url":"https://api.github.com/repos/EixampleDB/eixampledb/forks","keys_url":"https://api.github.com/repos/EixampleDB/eixampledb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EixampleDB/eixampledb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EixampleDB/eixampledb/teams","hooks_url":"https://api.github.com/repos/EixampleDB/eixampledb/hooks","issue_events_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/events{/number}","events_url":"https://api.github.com/repos/EixampleDB/eixampledb/events","assignees_url":"https://api.github.com/repos/EixampleDB/eixampledb/assignees{/user}","branches_url":"https://api.github.com/repos/EixampleDB/eixampledb/branches{/branch}","tags_url":"https://api.github.com/repos/EixampleDB/eixampledb/tags","blobs_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/refs{/sha}","trees_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EixampleDB/eixampledb/statuses/{sha}","languages_url":"https://api.github.com/repos/EixampleDB/eixampledb/languages","stargazers_url":"https://api.github.com/repos/EixampleDB/eixampledb/stargazers","contributors_url":"https://api.github.com/repos/EixampleDB/eixampledb/contributors","subscribers_url":"https://api.github.com/repos/EixampleDB/eixampledb/subscribers","subscription_url":"https://api.github.com/repos/EixampleDB/eixampledb/subscription","commits_url":"https://api.github.com/repos/EixampleDB/eixampledb/commits{/sha}","git_commits_url":"https://api.github.com/repos/EixampleDB/eixampledb/git/commits{/sha}","comments_url":"https://api.github.com/repos/EixampleDB/eixampledb/comments{/number}","issue_comment_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues/comments{/number}","contents_url":"https://api.github.com/repos/EixampleDB/eixampledb/contents/{+path}","compare_url":"https://api.github.com/repos/EixampleDB/eixampledb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EixampleDB/eixampledb/merges","archive_url":"https://api.github.com/repos/EixampleDB/eixampledb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EixampleDB/eixampledb/downloads","issues_url":"https://api.github.com/repos/EixampleDB/eixampledb/issues{/number}","pulls_url":"https://api.github.com/repos/EixampleDB/eixampledb/pulls{/number}","milestones_url":"https://api.github.com/repos/EixampleDB/eixampledb/milestones{/number}","notifications_url":"https://api.github.com/repos/EixampleDB/eixampledb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EixampleDB/eixampledb/labels{/name}","releases_url":"https://api.github.com/repos/EixampleDB/eixampledb/releases{/id}","deployments_url":"https://api.github.com/repos/EixampleDB/eixampledb/deployments","created_at":"2018-11-12T09:42:04Z","updated_at":"2018-12-08T16:54:03Z","pushed_at":"2018-12-13T08:04:42Z","git_url":"git://github.com/EixampleDB/eixampledb.git","ssh_url":"git@github.com:EixampleDB/eixampledb.git","clone_url":"https://github.com/EixampleDB/eixampledb.git","svn_url":"https://github.com/EixampleDB/eixampledb","homepage":"","size":62,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2"},"html":{"href":"https://github.com/EixampleDB/eixampledb/pull/2"},"issue":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/issues/2"},"comments":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/EixampleDB/eixampledb/statuses/87cb8ae78f4b90d437ff28fb508a03b0f6b8a391"}},"author_association":"NONE"}}
{"actor":{"display_login":"GuillermoBlasco"}}