{"action":"created","issue":{"url":"https://api.github.com/repos/matterpoll/matterpoll/issues/51","repository_url":"https://api.github.com/repos/matterpoll/matterpoll","labels_url":"https://api.github.com/repos/matterpoll/matterpoll/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/matterpoll/matterpoll/issues/51/comments","events_url":"https://api.github.com/repos/matterpoll/matterpoll/issues/51/events","html_url":"https://github.com/matterpoll/matterpoll/pull/51","id":357955062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODQyNTMw","number":51,"title":"[WP] Add poll settings","user":{"login":"Hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/Hanzei","html_url":"https://github.com/Hanzei","followers_url":"https://api.github.com/users/Hanzei/followers","following_url":"https://api.github.com/users/Hanzei/following{/other_user}","gists_url":"https://api.github.com/users/Hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/Hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hanzei/subscriptions","organizations_url":"https://api.github.com/users/Hanzei/orgs","repos_url":"https://api.github.com/users/Hanzei/repos","events_url":"https://api.github.com/users/Hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/Hanzei/received_events","type":"User","site_admin":false},"labels":[{"id":801575689,"node_id":"MDU6TGFiZWw4MDE1NzU2ODk=","url":"https://api.github.com/repos/matterpoll/matterpoll/labels/2.%20developing","name":"2. developing","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"Hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/Hanzei","html_url":"https://github.com/Hanzei","followers_url":"https://api.github.com/users/Hanzei/followers","following_url":"https://api.github.com/users/Hanzei/following{/other_user}","gists_url":"https://api.github.com/users/Hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/Hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hanzei/subscriptions","organizations_url":"https://api.github.com/users/Hanzei/orgs","repos_url":"https://api.github.com/users/Hanzei/repos","events_url":"https://api.github.com/users/Hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/Hanzei/received_events","type":"User","site_admin":false},"assignees":[{"login":"Hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/Hanzei","html_url":"https://github.com/Hanzei","followers_url":"https://api.github.com/users/Hanzei/followers","following_url":"https://api.github.com/users/Hanzei/following{/other_user}","gists_url":"https://api.github.com/users/Hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/Hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hanzei/subscriptions","organizations_url":"https://api.github.com/users/Hanzei/orgs","repos_url":"https://api.github.com/users/Hanzei/repos","events_url":"https://api.github.com/users/Hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/Hanzei/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/matterpoll/matterpoll/milestones/5","html_url":"https://github.com/matterpoll/matterpoll/milestone/5","labels_url":"https://api.github.com/repos/matterpoll/matterpoll/milestones/5/labels","id":3620080,"node_id":"MDk6TWlsZXN0b25lMzYyMDA4MA==","number":5,"title":"v0.2.0","description":null,"creator":{"login":"Hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/Hanzei","html_url":"https://github.com/Hanzei","followers_url":"https://api.github.com/users/Hanzei/followers","following_url":"https://api.github.com/users/Hanzei/following{/other_user}","gists_url":"https://api.github.com/users/Hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/Hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hanzei/subscriptions","organizations_url":"https://api.github.com/users/Hanzei/orgs","repos_url":"https://api.github.com/users/Hanzei/repos","events_url":"https://api.github.com/users/Hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/Hanzei/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-09-04T11:45:18Z","updated_at":"2018-09-10T09:15:51Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-09-07T07:41:25Z","updated_at":"2018-09-11T12:28:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/matterpoll/matterpoll/pulls/51","html_url":"https://github.com/matterpoll/matterpoll/pull/51","diff_url":"https://github.com/matterpoll/matterpoll/pull/51.diff","patch_url":"https://github.com/matterpoll/matterpoll/pull/51.patch"},"body":"This PR adds to two settings for polls:\r\n\r\n- secret: Don't show who voted for what at the end\r\n- progress: During the poll, show how many votes each answer option got\r\n\r\nThis is still quite early in development, but I want to give the possibility for feedback.\r\nI'm 1/5 on the naming of the setting and the term \"setting\".\r\n\r\nSettings parsing is quite bad, but i failed to find a working regex for this, see code comments.\r\n\r\n\r\nFixes #35 "},"comment":{"url":"https://api.github.com/repos/matterpoll/matterpoll/issues/comments/420256315","html_url":"https://github.com/matterpoll/matterpoll/pull/51#issuecomment-420256315","issue_url":"https://api.github.com/repos/matterpoll/matterpoll/issues/51","id":420256315,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDI1NjMxNQ==","user":{"login":"kaakaa","id":1453749,"node_id":"MDQ6VXNlcjE0NTM3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1453749?v=4","gravatar_id":"","url":"https://api.github.com/users/kaakaa","html_url":"https://github.com/kaakaa","followers_url":"https://api.github.com/users/kaakaa/followers","following_url":"https://api.github.com/users/kaakaa/following{/other_user}","gists_url":"https://api.github.com/users/kaakaa/gists{/gist_id}","starred_url":"https://api.github.com/users/kaakaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaakaa/subscriptions","organizations_url":"https://api.github.com/users/kaakaa/orgs","repos_url":"https://api.github.com/users/kaakaa/repos","events_url":"https://api.github.com/users/kaakaa/events{/privacy}","received_events_url":"https://api.github.com/users/kaakaa/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T12:28:39Z","updated_at":"2018-09-11T12:28:39Z","author_association":"CONTRIBUTOR","body":"> Why?\r\n\r\nI thisn that regex is hard to understand completely and it may require many test cases.\r\nSo if we can achieve it by other way, I wanna avoid regex. Of course, regex is not bad.\r\n\r\n> The problem is that we still need something like strings.Split() to cut the input in pieces. But by doing so we distinguish between a setting in a question e.g. /poll \"Question -secret\" from a setting outside a question, e.g. /poll \"Question\" -secret\r\n\r\nOh...It was. We can avoid that by replacing sentence surrounded by quotes with dummy word without spaces, but it's achieved by regex... `¯\\_(ツ)_/¯`\r\nDoes your implementation solve this problem?\r\n"}}
{"actor":{"display_login":"kaakaa"}}