{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/202186980","pull_request_review_id":136838740,"id":202186980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE4Njk4MA==","diff_hunk":"@@ -1010,6 +1010,99 @@ func (s *xlSets) ReloadFormat(ctx context.Context, dryRun bool) (err error) {\n \treturn nil\n }\n \n+// FixDeploymentID - Add deployment id if it is not present.\n+func (s *xlSets) FixDeploymentID(ctx context.Context) (err error) {\n+\t// Acquire lock on format.json\n+\tformatLock := s.getHashedSet(formatConfigFile).nsMutex.NewNSLock(minioMetaBucket, formatConfigFile)\n+\tif err = formatLock.GetLock(globalHealingTimeout); err != nil {\n+\t\treturn err\n+\t}\n+\tdefer formatLock.Unlock()\n+\n+\tstorageDisks, err := initStorageDisks(s.endpoints)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tdefer func(storageDisks []StorageAPI) {\n+\t\tif err != nil {\n+\t\t\tcloseStorageDisks(storageDisks)","path":"cmd/xl-sets.go","position":20,"original_position":20,"commit_id":"318c97d03a9b6bf703c0867cf7c38513341fccc1","original_commit_id":"318c97d03a9b6bf703c0867cf7c38513341fccc1","user":{"login":"harshavardhana","id":622699,"node_id":"MDQ6VXNlcjYyMjY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"No FixDeploymentID rewrites the storageDisks so it shouldn't close them upon success @vadmeste @kannappanr ","created_at":"2018-07-12T21:36:10Z","updated_at":"2018-07-12T21:36:10Z","html_url":"https://github.com/minio/minio/pull/6144#discussion_r202186980","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/6144","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/202186980"},"html":{"href":"https://github.com/minio/minio/pull/6144#discussion_r202186980"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/6144"}},"in_reply_to_id":202125049},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6144","id":200861899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODYxODk5","html_url":"https://github.com/minio/minio/pull/6144","diff_url":"https://github.com/minio/minio/pull/6144.diff","patch_url":"https://github.com/minio/minio/pull/6144.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6144","number":6144,"state":"open","locked":false,"title":"Add support for deployment ID","user":{"login":"kannappanr","id":30541348,"node_id":"MDQ6VXNlcjMwNTQxMzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"body":"## Description\r\ndeployment ID helps in identifying a minio deployment in the case of remote\r\nlogging targets.\r\n\r\n## Motivation and Context\r\nThis is part of the next set of logging improvements. Deployment ID will be useful while sending log messages to a remote target.\r\n\r\n## How Has This Been Tested?\r\nManually\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-07-12T00:48:46Z","updated_at":"2018-07-12T21:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b62f479cea16dc85df81ea53ea3c24719095fce7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"krishnasrinivas","id":634494,"node_id":"MDQ6VXNlcjYzNDQ5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/634494?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6144/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6144/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6144/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/318c97d03a9b6bf703c0867cf7c38513341fccc1","head":{"label":"kannappanr:add_deployment_id","ref":"add_deployment_id","sha":"318c97d03a9b6bf703c0867cf7c38513341fccc1","user":{"login":"kannappanr","id":30541348,"node_id":"MDQ6VXNlcjMwNTQxMzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"repo":{"id":100306434,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAzMDY0MzQ=","name":"minio","full_name":"kannappanr/minio","owner":{"login":"kannappanr","id":30541348,"node_id":"MDQ6VXNlcjMwNTQxMzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kannappanr/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/kannappanr/minio","forks_url":"https://api.github.com/repos/kannappanr/minio/forks","keys_url":"https://api.github.com/repos/kannappanr/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kannappanr/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kannappanr/minio/teams","hooks_url":"https://api.github.com/repos/kannappanr/minio/hooks","issue_events_url":"https://api.github.com/repos/kannappanr/minio/issues/events{/number}","events_url":"https://api.github.com/repos/kannappanr/minio/events","assignees_url":"https://api.github.com/repos/kannappanr/minio/assignees{/user}","branches_url":"https://api.github.com/repos/kannappanr/minio/branches{/branch}","tags_url":"https://api.github.com/repos/kannappanr/minio/tags","blobs_url":"https://api.github.com/repos/kannappanr/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kannappanr/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kannappanr/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/kannappanr/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kannappanr/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/kannappanr/minio/languages","stargazers_url":"https://api.github.com/repos/kannappanr/minio/stargazers","contributors_url":"https://api.github.com/repos/kannappanr/minio/contributors","subscribers_url":"https://api.github.com/repos/kannappanr/minio/subscribers","subscription_url":"https://api.github.com/repos/kannappanr/minio/subscription","commits_url":"https://api.github.com/repos/kannappanr/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/kannappanr/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/kannappanr/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/kannappanr/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/kannappanr/minio/contents/{+path}","compare_url":"https://api.github.com/repos/kannappanr/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kannappanr/minio/merges","archive_url":"https://api.github.com/repos/kannappanr/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kannappanr/minio/downloads","issues_url":"https://api.github.com/repos/kannappanr/minio/issues{/number}","pulls_url":"https://api.github.com/repos/kannappanr/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/kannappanr/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/kannappanr/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kannappanr/minio/labels{/name}","releases_url":"https://api.github.com/repos/kannappanr/minio/releases{/id}","deployments_url":"https://api.github.com/repos/kannappanr/minio/deployments","created_at":"2017-08-14T20:23:09Z","updated_at":"2017-08-14T20:23:12Z","pushed_at":"2018-07-12T01:45:08Z","git_url":"git://github.com/kannappanr/minio.git","ssh_url":"git@github.com:kannappanr/minio.git","clone_url":"https://github.com/kannappanr/minio.git","svn_url":"https://github.com/kannappanr/minio","homepage":"https://minio.io","size":39005,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"44865596dbe4153c8b2edf63332595d40731b8ae","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-07-12T21:12:47Z","pushed_at":"2018-07-12T21:12:41Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":38081,"stargazers_count":12079,"watchers_count":12079,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1055,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1055,"open_issues":132,"watchers":12079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6144"},"html":{"href":"https://github.com/minio/minio/pull/6144"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6144"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6144/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6144/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6144/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/318c97d03a9b6bf703c0867cf7c38513341fccc1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"harshavardhana"}}