{"action":"created","comment":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/227244631","pull_request_review_id":167238759,"id":227244631,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzI0NDYzMQ==","diff_hunk":"@@ -2,6 +2,7 @@ import React, { Component } from 'react'\n \n import { connect } from 'redaction'\n import actions from 'redux/actions'\n+import reducers from 'redux/core/reducers'","path":"shared/components/modals/OfferModal/AddOffer/AddOffer.js","position":4,"original_position":4,"commit_id":"ac592566bd22e5994ec1dc5e3d46583d0b1ae7b7","original_commit_id":"ac592566bd22e5994ec1dc5e3d46583d0b1ae7b7","user":{"login":"nikdementev","id":17093843,"node_id":"MDQ6VXNlcjE3MDkzODQz","avatar_url":"https://avatars1.githubusercontent.com/u/17093843?v=4","gravatar_id":"","url":"https://api.github.com/users/nikdementev","html_url":"https://github.com/nikdementev","followers_url":"https://api.github.com/users/nikdementev/followers","following_url":"https://api.github.com/users/nikdementev/following{/other_user}","gists_url":"https://api.github.com/users/nikdementev/gists{/gist_id}","starred_url":"https://api.github.com/users/nikdementev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikdementev/subscriptions","organizations_url":"https://api.github.com/users/nikdementev/orgs","repos_url":"https://api.github.com/users/nikdementev/repos","events_url":"https://api.github.com/users/nikdementev/events{/privacy}","received_events_url":"https://api.github.com/users/nikdementev/received_events","type":"User","site_admin":false},"body":"Зачем если ты его не используешь ?\r\nи его как мы нельзя тут использовать","created_at":"2018-10-23T06:45:12Z","updated_at":"2018-10-23T06:45:12Z","html_url":"https://github.com/swaponline/swap.react/pull/723#discussion_r227244631","pull_request_url":"https://api.github.com/repos/swaponline/swap.react/pulls/723","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/227244631"},"html":{"href":"https://github.com/swaponline/swap.react/pull/723#discussion_r227244631"},"pull_request":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/723","id":224913390,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTEzMzkw","html_url":"https://github.com/swaponline/swap.react/pull/723","diff_url":"https://github.com/swaponline/swap.react/pull/723.diff","patch_url":"https://github.com/swaponline/swap.react/pull/723.patch","issue_url":"https://api.github.com/repos/swaponline/swap.react/issues/723","number":723,"state":"open","locked":false,"title":"Fix calculate final balance width unconfirmed balance;","user":{"login":"sdwas","id":43396375,"node_id":"MDQ6VXNlcjQzMzk2Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/43396375?v=4","gravatar_id":"","url":"https://api.github.com/users/sdwas","html_url":"https://github.com/sdwas","followers_url":"https://api.github.com/users/sdwas/followers","following_url":"https://api.github.com/users/sdwas/following{/other_user}","gists_url":"https://api.github.com/users/sdwas/gists{/gist_id}","starred_url":"https://api.github.com/users/sdwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdwas/subscriptions","organizations_url":"https://api.github.com/users/sdwas/orgs","repos_url":"https://api.github.com/users/sdwas/repos","events_url":"https://api.github.com/users/sdwas/events{/privacy}","received_events_url":"https://api.github.com/users/sdwas/received_events","type":"User","site_admin":false},"body":"Fix issue #711\r\nУчитывает отрицательный неподтвержденный баланс, чтобы не дать потратить, что уже потрачено.\r\n\r\n![screenshot_20181023_161306](https://user-images.githubusercontent.com/43396375/47339621-2022c200-d6df-11e8-8b9f-bb28edbfc9e8.png)\r\n\r\nНе учитывается положительный неподтвержденный баланс, так как фактически его пока нет.\r\n\r\n![screenshot_20181023_161324](https://user-images.githubusercontent.com/43396375/47339628-27e26680-d6df-11e8-81af-53eda8bb333c.png)\r\n\r\nНо! Если в неподтверженном балансе будет положительная часть больше отрицательной, то неподтвержденный баланс не будет учитываться, однако можно попытаться потратить отрицательный неподтвержденный баланс, которого фактически уже нет, что приведет к изначальной ошибке.\r\n\r\nДля решения этой проблемы нужно разработать метод getUnconfirmedBalance в actions/[coin].js для получения неподтвержденного баланса объектом вроде:\r\nunconfirmedBalance = {\r\nplus: 24.3402\r\nminus: -0.23003\r\n}\r\nМетод getUnconfirmedBalance будет перебирать все неподтвержденные транзакции и суммировать  отрицательные и положительные балансы соответственно в \"plus\" и \"minus\"","created_at":"2018-10-23T06:40:17Z","updated_at":"2018-10-23T06:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10f24f1c78e33fb5ebf82847a85f51b1ee698edd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaponline/swap.react/pulls/723/commits","review_comments_url":"https://api.github.com/repos/swaponline/swap.react/pulls/723/comments","review_comment_url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaponline/swap.react/issues/723/comments","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/ac592566bd22e5994ec1dc5e3d46583d0b1ae7b7","head":{"label":"sdwas:thread1","ref":"thread1","sha":"ac592566bd22e5994ec1dc5e3d46583d0b1ae7b7","user":{"login":"sdwas","id":43396375,"node_id":"MDQ6VXNlcjQzMzk2Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/43396375?v=4","gravatar_id":"","url":"https://api.github.com/users/sdwas","html_url":"https://github.com/sdwas","followers_url":"https://api.github.com/users/sdwas/followers","following_url":"https://api.github.com/users/sdwas/following{/other_user}","gists_url":"https://api.github.com/users/sdwas/gists{/gist_id}","starred_url":"https://api.github.com/users/sdwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdwas/subscriptions","organizations_url":"https://api.github.com/users/sdwas/orgs","repos_url":"https://api.github.com/users/sdwas/repos","events_url":"https://api.github.com/users/sdwas/events{/privacy}","received_events_url":"https://api.github.com/users/sdwas/received_events","type":"User","site_admin":false},"repo":{"id":150054339,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwNTQzMzk=","name":"swap.react","full_name":"sdwas/swap.react","private":false,"owner":{"login":"sdwas","id":43396375,"node_id":"MDQ6VXNlcjQzMzk2Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/43396375?v=4","gravatar_id":"","url":"https://api.github.com/users/sdwas","html_url":"https://github.com/sdwas","followers_url":"https://api.github.com/users/sdwas/followers","following_url":"https://api.github.com/users/sdwas/following{/other_user}","gists_url":"https://api.github.com/users/sdwas/gists{/gist_id}","starred_url":"https://api.github.com/users/sdwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdwas/subscriptions","organizations_url":"https://api.github.com/users/sdwas/orgs","repos_url":"https://api.github.com/users/sdwas/repos","events_url":"https://api.github.com/users/sdwas/events{/privacy}","received_events_url":"https://api.github.com/users/sdwas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sdwas/swap.react","description":"In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":true,"url":"https://api.github.com/repos/sdwas/swap.react","forks_url":"https://api.github.com/repos/sdwas/swap.react/forks","keys_url":"https://api.github.com/repos/sdwas/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdwas/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdwas/swap.react/teams","hooks_url":"https://api.github.com/repos/sdwas/swap.react/hooks","issue_events_url":"https://api.github.com/repos/sdwas/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/sdwas/swap.react/events","assignees_url":"https://api.github.com/repos/sdwas/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/sdwas/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/sdwas/swap.react/tags","blobs_url":"https://api.github.com/repos/sdwas/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdwas/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdwas/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdwas/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdwas/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/sdwas/swap.react/languages","stargazers_url":"https://api.github.com/repos/sdwas/swap.react/stargazers","contributors_url":"https://api.github.com/repos/sdwas/swap.react/contributors","subscribers_url":"https://api.github.com/repos/sdwas/swap.react/subscribers","subscription_url":"https://api.github.com/repos/sdwas/swap.react/subscription","commits_url":"https://api.github.com/repos/sdwas/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdwas/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdwas/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdwas/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdwas/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/sdwas/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdwas/swap.react/merges","archive_url":"https://api.github.com/repos/sdwas/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdwas/swap.react/downloads","issues_url":"https://api.github.com/repos/sdwas/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/sdwas/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/sdwas/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/sdwas/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdwas/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/sdwas/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/sdwas/swap.react/deployments","created_at":"2018-09-24T04:31:34Z","updated_at":"2018-10-23T04:17:13Z","pushed_at":"2018-10-23T06:28:42Z","git_url":"git://github.com/sdwas/swap.react.git","ssh_url":"git@github.com:sdwas/swap.react.git","clone_url":"https://github.com/sdwas/swap.react.git","svn_url":"https://github.com/sdwas/swap.react","homepage":"https://swap.online","size":13586,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swaponline:master","ref":"master","sha":"cc627d7605550d8483f8d86c6803a67d173a90b4","user":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"repo":{"id":130675402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzU0MDI=","name":"swap.react","full_name":"swaponline/swap.react","private":false,"owner":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swaponline/swap.react","description":"MASTER --> https://testnet.swap.online :) In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":false,"url":"https://api.github.com/repos/swaponline/swap.react","forks_url":"https://api.github.com/repos/swaponline/swap.react/forks","keys_url":"https://api.github.com/repos/swaponline/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaponline/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaponline/swap.react/teams","hooks_url":"https://api.github.com/repos/swaponline/swap.react/hooks","issue_events_url":"https://api.github.com/repos/swaponline/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/swaponline/swap.react/events","assignees_url":"https://api.github.com/repos/swaponline/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/swaponline/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/swaponline/swap.react/tags","blobs_url":"https://api.github.com/repos/swaponline/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaponline/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaponline/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaponline/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/swaponline/swap.react/languages","stargazers_url":"https://api.github.com/repos/swaponline/swap.react/stargazers","contributors_url":"https://api.github.com/repos/swaponline/swap.react/contributors","subscribers_url":"https://api.github.com/repos/swaponline/swap.react/subscribers","subscription_url":"https://api.github.com/repos/swaponline/swap.react/subscription","commits_url":"https://api.github.com/repos/swaponline/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaponline/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaponline/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaponline/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaponline/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/swaponline/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaponline/swap.react/merges","archive_url":"https://api.github.com/repos/swaponline/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaponline/swap.react/downloads","issues_url":"https://api.github.com/repos/swaponline/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/swaponline/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/swaponline/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/swaponline/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaponline/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/swaponline/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/swaponline/swap.react/deployments","created_at":"2018-04-23T09:48:44Z","updated_at":"2018-10-23T06:28:11Z","pushed_at":"2018-10-23T06:40:17Z","git_url":"git://github.com/swaponline/swap.react.git","ssh_url":"git@github.com:swaponline/swap.react.git","clone_url":"https://github.com/swaponline/swap.react.git","svn_url":"https://github.com/swaponline/swap.react","homepage":"https://swap.online","size":13550,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":70,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/723"},"html":{"href":"https://github.com/swaponline/swap.react/pull/723"},"issue":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/723"},"comments":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/swaponline/swap.react/statuses/ac592566bd22e5994ec1dc5e3d46583d0b1ae7b7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nikdementev"}}