{"action":"created","comment":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/comments/231478527","pull_request_review_id":172456355,"id":231478527,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ3ODUyNw==","diff_hunk":"@@ -12,10 +13,10 @@ let getWishListFromDB userName =\n     if not fi.Exists then Defaults.defaultWishList userName\n     else\n         File.ReadAllText(fi.FullName)\n-        |> FableJson.ofJson<WishList>\n+        |> Decode.Auto.unsafeFromString<WishList>\n \n let saveWishListToDB wishList =\n     let fi = FileInfo(getJSONFileName wishList.UserName)\n     if not fi.Directory.Exists then\n         fi.Directory.Create()\n-    File.WriteAllText(fi.FullName, FableJson.toJson wishList)\n\\ No newline at end of file\n+    File.WriteAllText(fi.FullName, Encode.Auto.toString(4, wishList))","path":"src/Server/Storage/FileSystem.fs","position":21,"original_position":21,"commit_id":"33efc0fab24c8785e244c5966c54fce2ba03e65a","original_commit_id":"33efc0fab24c8785e244c5966c54fce2ba03e65a","user":{"login":"MangelMaxime","id":4760796,"node_id":"MDQ6VXNlcjQ3NjA3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4760796?v=4","gravatar_id":"","url":"https://api.github.com/users/MangelMaxime","html_url":"https://github.com/MangelMaxime","followers_url":"https://api.github.com/users/MangelMaxime/followers","following_url":"https://api.github.com/users/MangelMaxime/following{/other_user}","gists_url":"https://api.github.com/users/MangelMaxime/gists{/gist_id}","starred_url":"https://api.github.com/users/MangelMaxime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MangelMaxime/subscriptions","organizations_url":"https://api.github.com/users/MangelMaxime/orgs","repos_url":"https://api.github.com/users/MangelMaxime/repos","events_url":"https://api.github.com/users/MangelMaxime/events{/privacy}","received_events_url":"https://api.github.com/users/MangelMaxime/received_events","type":"User","site_admin":false},"body":"It's the number of spaces used for indendation.\r\n\r\nIn general, I set it to `4` in DEBUG mode and `0` for production usage.","created_at":"2018-11-07T12:01:52Z","updated_at":"2018-11-07T12:01:53Z","html_url":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349#discussion_r231478527","pull_request_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/comments/231478527"},"html":{"href":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349#discussion_r231478527"},"pull_request":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349"}},"in_reply_to_id":231463561},"pull_request":{"url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349","id":201885157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODg1MTU3","html_url":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349","diff_url":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349.diff","patch_url":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349.patch","issue_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/349","number":349,"state":"closed","locked":false,"title":"Update to Fable 2 alpha","user":{"login":"MangelMaxime","id":4760796,"node_id":"MDQ6VXNlcjQ3NjA3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4760796?v=4","gravatar_id":"","url":"https://api.github.com/users/MangelMaxime","html_url":"https://github.com/MangelMaxime","followers_url":"https://api.github.com/users/MangelMaxime/followers","following_url":"https://api.github.com/users/MangelMaxime/following{/other_user}","gists_url":"https://api.github.com/users/MangelMaxime/gists{/gist_id}","starred_url":"https://api.github.com/users/MangelMaxime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MangelMaxime/subscriptions","organizations_url":"https://api.github.com/users/MangelMaxime/orgs","repos_url":"https://api.github.com/users/MangelMaxime/repos","events_url":"https://api.github.com/users/MangelMaxime/events{/privacy}","received_events_url":"https://api.github.com/users/MangelMaxime/received_events","type":"User","site_admin":false},"body":"The project is now compiling and working but several things are needed before considering Fable 2 ready for booktstore.\r\n\r\n- [x] Release a new version of Fable.PowerPack that is using Thoth.Json\r\n    - This is needed in order to fix `Fetch.fetchAs<'T>` which failed silently as it's now just using JavaScript `parse`\r\n- [x] Create `Thoth.Json.Net.Giraffe` to host the `ThothSerializer` type\r\n- [x] Clean the code\r\n  - Remove logs\r\n  - Remove dead code","created_at":"2018-07-17T09:53:09Z","updated_at":"2018-11-07T12:01:53Z","closed_at":"2018-10-02T12:10:41Z","merged_at":"2018-10-02T12:10:41Z","merge_commit_sha":"33efc0fab24c8785e244c5966c54fce2ba03e65a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349/commits","review_comments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349/comments","review_comment_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/349/comments","statuses_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/statuses/33efc0fab24c8785e244c5966c54fce2ba03e65a","head":{"label":"MangelMaxime:feature/fable2","ref":"feature/fable2","sha":"33efc0fab24c8785e244c5966c54fce2ba03e65a","user":{"login":"MangelMaxime","id":4760796,"node_id":"MDQ6VXNlcjQ3NjA3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4760796?v=4","gravatar_id":"","url":"https://api.github.com/users/MangelMaxime","html_url":"https://github.com/MangelMaxime","followers_url":"https://api.github.com/users/MangelMaxime/followers","following_url":"https://api.github.com/users/MangelMaxime/following{/other_user}","gists_url":"https://api.github.com/users/MangelMaxime/gists{/gist_id}","starred_url":"https://api.github.com/users/MangelMaxime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MangelMaxime/subscriptions","organizations_url":"https://api.github.com/users/MangelMaxime/orgs","repos_url":"https://api.github.com/users/MangelMaxime/repos","events_url":"https://api.github.com/users/MangelMaxime/events{/privacy}","received_events_url":"https://api.github.com/users/MangelMaxime/received_events","type":"User","site_admin":false},"repo":{"id":79566667,"node_id":"MDEwOlJlcG9zaXRvcnk3OTU2NjY2Nw==","name":"fable-suave-scaffold","full_name":"MangelMaxime/fable-suave-scaffold","private":false,"owner":{"login":"MangelMaxime","id":4760796,"node_id":"MDQ6VXNlcjQ3NjA3OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/4760796?v=4","gravatar_id":"","url":"https://api.github.com/users/MangelMaxime","html_url":"https://github.com/MangelMaxime","followers_url":"https://api.github.com/users/MangelMaxime/followers","following_url":"https://api.github.com/users/MangelMaxime/following{/other_user}","gists_url":"https://api.github.com/users/MangelMaxime/gists{/gist_id}","starred_url":"https://api.github.com/users/MangelMaxime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MangelMaxime/subscriptions","organizations_url":"https://api.github.com/users/MangelMaxime/orgs","repos_url":"https://api.github.com/users/MangelMaxime/repos","events_url":"https://api.github.com/users/MangelMaxime/events{/privacy}","received_events_url":"https://api.github.com/users/MangelMaxime/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MangelMaxime/fable-suave-scaffold","description":"[WIP] Working sample of a Suave + Fable + Elmish project with hot reloading","fork":true,"url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold","forks_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/forks","keys_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/teams","hooks_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/hooks","issue_events_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/events","assignees_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/tags","blobs_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/languages","stargazers_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/stargazers","contributors_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/contributors","subscribers_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/subscribers","subscription_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/subscription","commits_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/merges","archive_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/downloads","issues_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/MangelMaxime/fable-suave-scaffold/deployments","created_at":"2017-01-20T14:39:49Z","updated_at":"2017-01-20T14:39:50Z","pushed_at":"2018-10-03T09:09:36Z","git_url":"git://github.com/MangelMaxime/fable-suave-scaffold.git","ssh_url":"git@github.com:MangelMaxime/fable-suave-scaffold.git","clone_url":"https://github.com/MangelMaxime/fable-suave-scaffold.git","svn_url":"https://github.com/MangelMaxime/fable-suave-scaffold","homepage":"","size":16032,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAFE-Stack:master","ref":"master","sha":"1e4266c8357095b483475f738b056f17c0588420","user":{"login":"SAFE-Stack","id":31617369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjE3MzY5","avatar_url":"https://avatars0.githubusercontent.com/u/31617369?v=4","gravatar_id":"","url":"https://api.github.com/users/SAFE-Stack","html_url":"https://github.com/SAFE-Stack","followers_url":"https://api.github.com/users/SAFE-Stack/followers","following_url":"https://api.github.com/users/SAFE-Stack/following{/other_user}","gists_url":"https://api.github.com/users/SAFE-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/SAFE-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAFE-Stack/subscriptions","organizations_url":"https://api.github.com/users/SAFE-Stack/orgs","repos_url":"https://api.github.com/users/SAFE-Stack/repos","events_url":"https://api.github.com/users/SAFE-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/SAFE-Stack/received_events","type":"Organization","site_admin":false},"repo":{"id":79465360,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQ2NTM2MA==","name":"SAFE-BookStore","full_name":"SAFE-Stack/SAFE-BookStore","private":false,"owner":{"login":"SAFE-Stack","id":31617369,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjE3MzY5","avatar_url":"https://avatars0.githubusercontent.com/u/31617369?v=4","gravatar_id":"","url":"https://api.github.com/users/SAFE-Stack","html_url":"https://github.com/SAFE-Stack","followers_url":"https://api.github.com/users/SAFE-Stack/followers","following_url":"https://api.github.com/users/SAFE-Stack/following{/other_user}","gists_url":"https://api.github.com/users/SAFE-Stack/gists{/gist_id}","starred_url":"https://api.github.com/users/SAFE-Stack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAFE-Stack/subscriptions","organizations_url":"https://api.github.com/users/SAFE-Stack/orgs","repos_url":"https://api.github.com/users/SAFE-Stack/repos","events_url":"https://api.github.com/users/SAFE-Stack/events{/privacy}","received_events_url":"https://api.github.com/users/SAFE-Stack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAFE-Stack/SAFE-BookStore","description":"Working sample of a SAFE-Stack project with hot reloading","fork":false,"url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore","forks_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/forks","keys_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/teams","hooks_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/hooks","issue_events_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/events{/number}","events_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/events","assignees_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/assignees{/user}","branches_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/branches{/branch}","tags_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/tags","blobs_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/statuses/{sha}","languages_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/languages","stargazers_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/stargazers","contributors_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/contributors","subscribers_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/subscribers","subscription_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/subscription","commits_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/contents/{+path}","compare_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/merges","archive_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/downloads","issues_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues{/number}","pulls_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls{/number}","milestones_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/milestones{/number}","notifications_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/labels{/name}","releases_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/releases{/id}","deployments_url":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/deployments","created_at":"2017-01-19T15:12:54Z","updated_at":"2018-11-06T12:42:51Z","pushed_at":"2018-11-06T12:42:51Z","git_url":"git://github.com/SAFE-Stack/SAFE-BookStore.git","ssh_url":"git@github.com:SAFE-Stack/SAFE-BookStore.git","clone_url":"https://github.com/SAFE-Stack/SAFE-BookStore.git","svn_url":"https://github.com/SAFE-Stack/SAFE-BookStore","homepage":"","size":16074,"stargazers_count":366,"watchers_count":366,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":128,"open_issues":48,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349"},"html":{"href":"https://github.com/SAFE-Stack/SAFE-BookStore/pull/349"},"issue":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/349"},"comments":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/SAFE-Stack/SAFE-BookStore/statuses/33efc0fab24c8785e244c5966c54fce2ba03e65a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MangelMaxime"}}