{"action":"created","comment":{"url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/comments/190000091","pull_request_review_id":122261453,"id":190000091,"diff_hunk":"@@ -239,32 +406,63 @@ export default class Treemap extends DoubleClickReactComponent<\n       strokeWidth,\n     } = this.props;\n \n-    const {\n-      xScale,\n-      yScale,\n-    } = this.state;\n-\n     return (\n       <TreemapCell\n-        key={`cell-${datum.id}`}\n-        colorScale={colorScale}\n+        key={key}\n+        cellFill={colorScale(datum.data.type)}","path":"src/containers/Treemap.tsx","position":467,"original_position":467,"commit_id":"03216f1f28ca2642f1f164c185db4b0e0d866337","original_commit_id":"9442ba368972a744b57223f85dd0e94c659e481d","user":{"login":"kbeame","id":15950768,"avatar_url":"https://avatars2.githubusercontent.com/u/15950768?v=4","gravatar_id":"","url":"https://api.github.com/users/kbeame","html_url":"https://github.com/kbeame","followers_url":"https://api.github.com/users/kbeame/followers","following_url":"https://api.github.com/users/kbeame/following{/other_user}","gists_url":"https://api.github.com/users/kbeame/gists{/gist_id}","starred_url":"https://api.github.com/users/kbeame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbeame/subscriptions","organizations_url":"https://api.github.com/users/kbeame/orgs","repos_url":"https://api.github.com/users/kbeame/repos","events_url":"https://api.github.com/users/kbeame/events{/privacy}","received_events_url":"https://api.github.com/users/kbeame/received_events","type":"User","site_admin":false},"body":"I like \"cellFill\", its more precise","created_at":"2018-05-22T18:08:20Z","updated_at":"2018-05-22T18:16:45Z","html_url":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10#discussion_r190000091","pull_request_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/comments/190000091"},"html":{"href":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10#discussion_r190000091"},"pull_request":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10","id":189452691,"html_url":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10","diff_url":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10.diff","patch_url":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10.patch","issue_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/10","number":10,"state":"open","locked":false,"title":"Animate generic nodegroup","user":{"login":"jimvermillion","id":13440053,"avatar_url":"https://avatars3.githubusercontent.com/u/13440053?v=4","gravatar_id":"","url":"https://api.github.com/users/jimvermillion","html_url":"https://github.com/jimvermillion","followers_url":"https://api.github.com/users/jimvermillion/followers","following_url":"https://api.github.com/users/jimvermillion/following{/other_user}","gists_url":"https://api.github.com/users/jimvermillion/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvermillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvermillion/subscriptions","organizations_url":"https://api.github.com/users/jimvermillion/orgs","repos_url":"https://api.github.com/users/jimvermillion/repos","events_url":"https://api.github.com/users/jimvermillion/events{/privacy}","received_events_url":"https://api.github.com/users/jimvermillion/received_events","type":"User","site_admin":false},"body":"This PR is my third (or fourth, I forget) attempt at making this component animate in a generic way. I've implemented react-move's <NodeGroup/> in the (newish) IHME-UI way. So a user could potentially completely override ANY of the animations set in the component. \r\n\r\nI've moved all the animation functionality out of the smaller, consumed components and into the Treemap class. Hopefully this makes sense. [React-move recommends working in this way.](https://react-move.js.org/#/documentation/animate).\r\n\r\nThe basic approach that I'm going for is that every smaller component that is consumed provides static function of how to process a treemap datum for its class, but it doesn't do so by itself -- hence being static methods. There will still probably need to be some touchups, perhaps I can break down the processing further so the TreemapRectangle also has a datum processing function...\r\n\r\nPlease let me know if this component still makes sense and feels organized...it's turning into a rather complex thing. Hopefully it is still navigable and easy to work with.\r\n\r\nCheers!\r\n-Jim","created_at":"2018-05-21T18:25:01Z","updated_at":"2018-05-22T18:16:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52900a447801ae452aac53fef7c8d579327aea0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10/commits","review_comments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10/comments","review_comment_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/10/comments","statuses_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/statuses/03216f1f28ca2642f1f164c185db4b0e0d866337","head":{"label":"jimvermillion:animate-generic-nodegroup","ref":"animate-generic-nodegroup","sha":"03216f1f28ca2642f1f164c185db4b0e0d866337","user":{"login":"jimvermillion","id":13440053,"avatar_url":"https://avatars3.githubusercontent.com/u/13440053?v=4","gravatar_id":"","url":"https://api.github.com/users/jimvermillion","html_url":"https://github.com/jimvermillion","followers_url":"https://api.github.com/users/jimvermillion/followers","following_url":"https://api.github.com/users/jimvermillion/following{/other_user}","gists_url":"https://api.github.com/users/jimvermillion/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvermillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvermillion/subscriptions","organizations_url":"https://api.github.com/users/jimvermillion/orgs","repos_url":"https://api.github.com/users/jimvermillion/repos","events_url":"https://api.github.com/users/jimvermillion/events{/privacy}","received_events_url":"https://api.github.com/users/jimvermillion/received_events","type":"User","site_admin":false},"repo":{"id":132040762,"name":"zoomable-treemap-prototype","full_name":"jimvermillion/zoomable-treemap-prototype","owner":{"login":"jimvermillion","id":13440053,"avatar_url":"https://avatars3.githubusercontent.com/u/13440053?v=4","gravatar_id":"","url":"https://api.github.com/users/jimvermillion","html_url":"https://github.com/jimvermillion","followers_url":"https://api.github.com/users/jimvermillion/followers","following_url":"https://api.github.com/users/jimvermillion/following{/other_user}","gists_url":"https://api.github.com/users/jimvermillion/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvermillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvermillion/subscriptions","organizations_url":"https://api.github.com/users/jimvermillion/orgs","repos_url":"https://api.github.com/users/jimvermillion/repos","events_url":"https://api.github.com/users/jimvermillion/events{/privacy}","received_events_url":"https://api.github.com/users/jimvermillion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimvermillion/zoomable-treemap-prototype","description":null,"fork":false,"url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype","forks_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/forks","keys_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/teams","hooks_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/hooks","issue_events_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/events","assignees_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/tags","blobs_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/languages","stargazers_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/stargazers","contributors_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/contributors","subscribers_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/subscribers","subscription_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/subscription","commits_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/merges","archive_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/downloads","issues_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/labels{/name}","releases_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/deployments","created_at":"2018-05-03T19:30:12Z","updated_at":"2018-05-17T22:52:03Z","pushed_at":"2018-05-22T17:59:49Z","git_url":"git://github.com/jimvermillion/zoomable-treemap-prototype.git","ssh_url":"git@github.com:jimvermillion/zoomable-treemap-prototype.git","clone_url":"https://github.com/jimvermillion/zoomable-treemap-prototype.git","svn_url":"https://github.com/jimvermillion/zoomable-treemap-prototype","homepage":null,"size":229,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jimvermillion:master","ref":"master","sha":"238ce5ec6be92afc36a0b57fc0977fd427c961b0","user":{"login":"jimvermillion","id":13440053,"avatar_url":"https://avatars3.githubusercontent.com/u/13440053?v=4","gravatar_id":"","url":"https://api.github.com/users/jimvermillion","html_url":"https://github.com/jimvermillion","followers_url":"https://api.github.com/users/jimvermillion/followers","following_url":"https://api.github.com/users/jimvermillion/following{/other_user}","gists_url":"https://api.github.com/users/jimvermillion/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvermillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvermillion/subscriptions","organizations_url":"https://api.github.com/users/jimvermillion/orgs","repos_url":"https://api.github.com/users/jimvermillion/repos","events_url":"https://api.github.com/users/jimvermillion/events{/privacy}","received_events_url":"https://api.github.com/users/jimvermillion/received_events","type":"User","site_admin":false},"repo":{"id":132040762,"name":"zoomable-treemap-prototype","full_name":"jimvermillion/zoomable-treemap-prototype","owner":{"login":"jimvermillion","id":13440053,"avatar_url":"https://avatars3.githubusercontent.com/u/13440053?v=4","gravatar_id":"","url":"https://api.github.com/users/jimvermillion","html_url":"https://github.com/jimvermillion","followers_url":"https://api.github.com/users/jimvermillion/followers","following_url":"https://api.github.com/users/jimvermillion/following{/other_user}","gists_url":"https://api.github.com/users/jimvermillion/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvermillion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvermillion/subscriptions","organizations_url":"https://api.github.com/users/jimvermillion/orgs","repos_url":"https://api.github.com/users/jimvermillion/repos","events_url":"https://api.github.com/users/jimvermillion/events{/privacy}","received_events_url":"https://api.github.com/users/jimvermillion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimvermillion/zoomable-treemap-prototype","description":null,"fork":false,"url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype","forks_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/forks","keys_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/teams","hooks_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/hooks","issue_events_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/events","assignees_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/tags","blobs_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/languages","stargazers_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/stargazers","contributors_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/contributors","subscribers_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/subscribers","subscription_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/subscription","commits_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/merges","archive_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/downloads","issues_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/labels{/name}","releases_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/deployments","created_at":"2018-05-03T19:30:12Z","updated_at":"2018-05-17T22:52:03Z","pushed_at":"2018-05-22T17:59:49Z","git_url":"git://github.com/jimvermillion/zoomable-treemap-prototype.git","ssh_url":"git@github.com:jimvermillion/zoomable-treemap-prototype.git","clone_url":"https://github.com/jimvermillion/zoomable-treemap-prototype.git","svn_url":"https://github.com/jimvermillion/zoomable-treemap-prototype","homepage":null,"size":229,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10"},"html":{"href":"https://github.com/jimvermillion/zoomable-treemap-prototype/pull/10"},"issue":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/10"},"comments":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/jimvermillion/zoomable-treemap-prototype/statuses/03216f1f28ca2642f1f164c185db4b0e0d866337"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kbeame"}}