{"action":"created","comment":{"url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/comments/201754033","pull_request_review_id":136316577,"id":201754033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc1NDAzMw==","diff_hunk":"@@ -44,15 +44,9 @@ class SimpleSelect extends React.Component {\n     deprecatePrimaryColor(this.props, 'hoverColor');\n     deprecateProp(this.props, 'iconStyles', 'styles', 'simple-select');\n     deprecateProp(this.props, 'menuStyles', 'styles', 'simple-select');\n-\n-    window.addEventListener('keydown', this._handleKeyDown);\n-  }\n-\n-  componentWillUnmount () {\n-    window.removeEventListener('keydown', this._handleKeyDown);\n   }\n \n-  _handleKeyDown = (e) => {\n+  _handleKeyUp = (e) => {","path":"src/components/SimpleSelect.js","position":13,"original_position":13,"commit_id":"4c48632ff501e89f4c8775d4f157a72eecf64dfb","original_commit_id":"4c48632ff501e89f4c8775d4f157a72eecf64dfb","user":{"login":"paniclater","id":1081167,"node_id":"MDQ6VXNlcjEwODExNjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1081167?v=4","gravatar_id":"","url":"https://api.github.com/users/paniclater","html_url":"https://github.com/paniclater","followers_url":"https://api.github.com/users/paniclater/followers","following_url":"https://api.github.com/users/paniclater/following{/other_user}","gists_url":"https://api.github.com/users/paniclater/gists{/gist_id}","starred_url":"https://api.github.com/users/paniclater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paniclater/subscriptions","organizations_url":"https://api.github.com/users/paniclater/orgs","repos_url":"https://api.github.com/users/paniclater/repos","events_url":"https://api.github.com/users/paniclater/events{/privacy}","received_events_url":"https://api.github.com/users/paniclater/received_events","type":"User","site_admin":false},"body":"What's the need to change from keyDown to keyUp?","created_at":"2018-07-11T16:13:24Z","updated_at":"2018-07-11T16:13:24Z","html_url":"https://github.com/mxenabled/mx-react-components/pull/756#discussion_r201754033","pull_request_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/comments/201754033"},"html":{"href":"https://github.com/mxenabled/mx-react-components/pull/756#discussion_r201754033"},"pull_request":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756"}}},"pull_request":{"url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756","id":200751301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzUxMzAx","html_url":"https://github.com/mxenabled/mx-react-components/pull/756","diff_url":"https://github.com/mxenabled/mx-react-components/pull/756.diff","patch_url":"https://github.com/mxenabled/mx-react-components/pull/756.patch","issue_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/756","number":756,"state":"open","locked":false,"title":"remove event from window and put it into top level div","user":{"login":"hokakede1","id":23319568,"node_id":"MDQ6VXNlcjIzMzE5NTY4","avatar_url":"https://avatars2.githubusercontent.com/u/23319568?v=4","gravatar_id":"","url":"https://api.github.com/users/hokakede1","html_url":"https://github.com/hokakede1","followers_url":"https://api.github.com/users/hokakede1/followers","following_url":"https://api.github.com/users/hokakede1/following{/other_user}","gists_url":"https://api.github.com/users/hokakede1/gists{/gist_id}","starred_url":"https://api.github.com/users/hokakede1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hokakede1/subscriptions","organizations_url":"https://api.github.com/users/hokakede1/orgs","repos_url":"https://api.github.com/users/hokakede1/repos","events_url":"https://api.github.com/users/hokakede1/events{/privacy}","received_events_url":"https://api.github.com/users/hokakede1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-11T16:03:53Z","updated_at":"2018-07-11T16:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"539ff948701ae764625570033c8258f06be1a51c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cerinman","id":6463914,"node_id":"MDQ6VXNlcjY0NjM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6463914?v=4","gravatar_id":"","url":"https://api.github.com/users/cerinman","html_url":"https://github.com/cerinman","followers_url":"https://api.github.com/users/cerinman/followers","following_url":"https://api.github.com/users/cerinman/following{/other_user}","gists_url":"https://api.github.com/users/cerinman/gists{/gist_id}","starred_url":"https://api.github.com/users/cerinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerinman/subscriptions","organizations_url":"https://api.github.com/users/cerinman/orgs","repos_url":"https://api.github.com/users/cerinman/repos","events_url":"https://api.github.com/users/cerinman/events{/privacy}","received_events_url":"https://api.github.com/users/cerinman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756/commits","review_comments_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756/comments","review_comment_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/756/comments","statuses_url":"https://api.github.com/repos/mxenabled/mx-react-components/statuses/4c48632ff501e89f4c8775d4f157a72eecf64dfb","head":{"label":"mxenabled:hd/accessablity_for_simple_select","ref":"hd/accessablity_for_simple_select","sha":"4c48632ff501e89f4c8775d4f157a72eecf64dfb","user":{"login":"mxenabled","id":991323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/991323?v=4","gravatar_id":"","url":"https://api.github.com/users/mxenabled","html_url":"https://github.com/mxenabled","followers_url":"https://api.github.com/users/mxenabled/followers","following_url":"https://api.github.com/users/mxenabled/following{/other_user}","gists_url":"https://api.github.com/users/mxenabled/gists{/gist_id}","starred_url":"https://api.github.com/users/mxenabled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxenabled/subscriptions","organizations_url":"https://api.github.com/users/mxenabled/orgs","repos_url":"https://api.github.com/users/mxenabled/repos","events_url":"https://api.github.com/users/mxenabled/events{/privacy}","received_events_url":"https://api.github.com/users/mxenabled/received_events","type":"Organization","site_admin":false},"repo":{"id":41570643,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MDY0Mw==","name":"mx-react-components","full_name":"mxenabled/mx-react-components","owner":{"login":"mxenabled","id":991323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/991323?v=4","gravatar_id":"","url":"https://api.github.com/users/mxenabled","html_url":"https://github.com/mxenabled","followers_url":"https://api.github.com/users/mxenabled/followers","following_url":"https://api.github.com/users/mxenabled/following{/other_user}","gists_url":"https://api.github.com/users/mxenabled/gists{/gist_id}","starred_url":"https://api.github.com/users/mxenabled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxenabled/subscriptions","organizations_url":"https://api.github.com/users/mxenabled/orgs","repos_url":"https://api.github.com/users/mxenabled/repos","events_url":"https://api.github.com/users/mxenabled/events{/privacy}","received_events_url":"https://api.github.com/users/mxenabled/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxenabled/mx-react-components","description":"A library of generic React components used at MX","fork":false,"url":"https://api.github.com/repos/mxenabled/mx-react-components","forks_url":"https://api.github.com/repos/mxenabled/mx-react-components/forks","keys_url":"https://api.github.com/repos/mxenabled/mx-react-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxenabled/mx-react-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxenabled/mx-react-components/teams","hooks_url":"https://api.github.com/repos/mxenabled/mx-react-components/hooks","issue_events_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/events{/number}","events_url":"https://api.github.com/repos/mxenabled/mx-react-components/events","assignees_url":"https://api.github.com/repos/mxenabled/mx-react-components/assignees{/user}","branches_url":"https://api.github.com/repos/mxenabled/mx-react-components/branches{/branch}","tags_url":"https://api.github.com/repos/mxenabled/mx-react-components/tags","blobs_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxenabled/mx-react-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mxenabled/mx-react-components/languages","stargazers_url":"https://api.github.com/repos/mxenabled/mx-react-components/stargazers","contributors_url":"https://api.github.com/repos/mxenabled/mx-react-components/contributors","subscribers_url":"https://api.github.com/repos/mxenabled/mx-react-components/subscribers","subscription_url":"https://api.github.com/repos/mxenabled/mx-react-components/subscription","commits_url":"https://api.github.com/repos/mxenabled/mx-react-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxenabled/mx-react-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxenabled/mx-react-components/contents/{+path}","compare_url":"https://api.github.com/repos/mxenabled/mx-react-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxenabled/mx-react-components/merges","archive_url":"https://api.github.com/repos/mxenabled/mx-react-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxenabled/mx-react-components/downloads","issues_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues{/number}","pulls_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mxenabled/mx-react-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mxenabled/mx-react-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxenabled/mx-react-components/labels{/name}","releases_url":"https://api.github.com/repos/mxenabled/mx-react-components/releases{/id}","deployments_url":"https://api.github.com/repos/mxenabled/mx-react-components/deployments","created_at":"2015-08-28T21:47:32Z","updated_at":"2018-07-02T20:01:10Z","pushed_at":"2018-07-11T16:03:53Z","git_url":"git://github.com/mxenabled/mx-react-components.git","ssh_url":"git@github.com:mxenabled/mx-react-components.git","clone_url":"https://github.com/mxenabled/mx-react-components.git","svn_url":"https://github.com/mxenabled/mx-react-components","homepage":null,"size":31435,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":24,"watchers":60,"default_branch":"master"}},"base":{"label":"mxenabled:master","ref":"master","sha":"6c9a47841827696a513065b8758fb29d20035b4e","user":{"login":"mxenabled","id":991323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/991323?v=4","gravatar_id":"","url":"https://api.github.com/users/mxenabled","html_url":"https://github.com/mxenabled","followers_url":"https://api.github.com/users/mxenabled/followers","following_url":"https://api.github.com/users/mxenabled/following{/other_user}","gists_url":"https://api.github.com/users/mxenabled/gists{/gist_id}","starred_url":"https://api.github.com/users/mxenabled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxenabled/subscriptions","organizations_url":"https://api.github.com/users/mxenabled/orgs","repos_url":"https://api.github.com/users/mxenabled/repos","events_url":"https://api.github.com/users/mxenabled/events{/privacy}","received_events_url":"https://api.github.com/users/mxenabled/received_events","type":"Organization","site_admin":false},"repo":{"id":41570643,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MDY0Mw==","name":"mx-react-components","full_name":"mxenabled/mx-react-components","owner":{"login":"mxenabled","id":991323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/991323?v=4","gravatar_id":"","url":"https://api.github.com/users/mxenabled","html_url":"https://github.com/mxenabled","followers_url":"https://api.github.com/users/mxenabled/followers","following_url":"https://api.github.com/users/mxenabled/following{/other_user}","gists_url":"https://api.github.com/users/mxenabled/gists{/gist_id}","starred_url":"https://api.github.com/users/mxenabled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxenabled/subscriptions","organizations_url":"https://api.github.com/users/mxenabled/orgs","repos_url":"https://api.github.com/users/mxenabled/repos","events_url":"https://api.github.com/users/mxenabled/events{/privacy}","received_events_url":"https://api.github.com/users/mxenabled/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxenabled/mx-react-components","description":"A library of generic React components used at MX","fork":false,"url":"https://api.github.com/repos/mxenabled/mx-react-components","forks_url":"https://api.github.com/repos/mxenabled/mx-react-components/forks","keys_url":"https://api.github.com/repos/mxenabled/mx-react-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxenabled/mx-react-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxenabled/mx-react-components/teams","hooks_url":"https://api.github.com/repos/mxenabled/mx-react-components/hooks","issue_events_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/events{/number}","events_url":"https://api.github.com/repos/mxenabled/mx-react-components/events","assignees_url":"https://api.github.com/repos/mxenabled/mx-react-components/assignees{/user}","branches_url":"https://api.github.com/repos/mxenabled/mx-react-components/branches{/branch}","tags_url":"https://api.github.com/repos/mxenabled/mx-react-components/tags","blobs_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxenabled/mx-react-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mxenabled/mx-react-components/languages","stargazers_url":"https://api.github.com/repos/mxenabled/mx-react-components/stargazers","contributors_url":"https://api.github.com/repos/mxenabled/mx-react-components/contributors","subscribers_url":"https://api.github.com/repos/mxenabled/mx-react-components/subscribers","subscription_url":"https://api.github.com/repos/mxenabled/mx-react-components/subscription","commits_url":"https://api.github.com/repos/mxenabled/mx-react-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxenabled/mx-react-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxenabled/mx-react-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxenabled/mx-react-components/contents/{+path}","compare_url":"https://api.github.com/repos/mxenabled/mx-react-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxenabled/mx-react-components/merges","archive_url":"https://api.github.com/repos/mxenabled/mx-react-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxenabled/mx-react-components/downloads","issues_url":"https://api.github.com/repos/mxenabled/mx-react-components/issues{/number}","pulls_url":"https://api.github.com/repos/mxenabled/mx-react-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mxenabled/mx-react-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mxenabled/mx-react-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxenabled/mx-react-components/labels{/name}","releases_url":"https://api.github.com/repos/mxenabled/mx-react-components/releases{/id}","deployments_url":"https://api.github.com/repos/mxenabled/mx-react-components/deployments","created_at":"2015-08-28T21:47:32Z","updated_at":"2018-07-02T20:01:10Z","pushed_at":"2018-07-11T16:03:53Z","git_url":"git://github.com/mxenabled/mx-react-components.git","ssh_url":"git@github.com:mxenabled/mx-react-components.git","clone_url":"https://github.com/mxenabled/mx-react-components.git","svn_url":"https://github.com/mxenabled/mx-react-components","homepage":null,"size":31435,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":55,"open_issues":24,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756"},"html":{"href":"https://github.com/mxenabled/mx-react-components/pull/756"},"issue":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/issues/756"},"comments":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/issues/756/comments"},"review_comments":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756/comments"},"review_comment":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/pulls/756/commits"},"statuses":{"href":"https://api.github.com/repos/mxenabled/mx-react-components/statuses/4c48632ff501e89f4c8775d4f157a72eecf64dfb"}},"author_association":"NONE"}}
{"actor":{"display_login":"paniclater"}}