{"action":"created","comment":{"url":"https://api.github.com/repos/magento/magento2/pulls/comments/234925285","pull_request_review_id":176669579,"id":234925285,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDkyNTI4NQ==","diff_hunk":"@@ -6,9 +6,7 @@\n  */\n namespace Magento\\Customer\\Controller\\Address;\n \n-use Magento\\Framework\\App\\Action\\HttpPostActionInterface;\n-\n-class Delete extends \\Magento\\Customer\\Controller\\Address implements HttpPostActionInterface\n+class Delete extends \\Magento\\Customer\\Controller\\Address","path":"app/code/Magento/Customer/Controller/Address/Delete.php","position":7,"original_position":7,"commit_id":"e2c9a7ae2ce816f9fb78e9d3c2e7b90ec3e3d717","original_commit_id":"e2c9a7ae2ce816f9fb78e9d3c2e7b90ec3e3d717","user":{"login":"dmitrijivanenko","id":10165801,"node_id":"MDQ6VXNlcjEwMTY1ODAx","avatar_url":"https://avatars0.githubusercontent.com/u/10165801?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrijivanenko","html_url":"https://github.com/dmitrijivanenko","followers_url":"https://api.github.com/users/dmitrijivanenko/followers","following_url":"https://api.github.com/users/dmitrijivanenko/following{/other_user}","gists_url":"https://api.github.com/users/dmitrijivanenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrijivanenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrijivanenko/subscriptions","organizations_url":"https://api.github.com/users/dmitrijivanenko/orgs","repos_url":"https://api.github.com/users/dmitrijivanenko/repos","events_url":"https://api.github.com/users/dmitrijivanenko/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrijivanenko/received_events","type":"User","site_admin":false},"body":"So, regarding this, do you think i have to report a new bug issue? i mean, i removed the interface, couse the current storefront use GET method (https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Customer/view/frontend/web/js/address.js#L65), or should i fix it with this PR?","created_at":"2018-11-20T09:29:19Z","updated_at":"2018-11-20T09:29:19Z","html_url":"https://github.com/magento/magento2/pull/19047#discussion_r234925285","pull_request_url":"https://api.github.com/repos/magento/magento2/pulls/19047","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/234925285"},"html":{"href":"https://github.com/magento/magento2/pull/19047#discussion_r234925285"},"pull_request":{"href":"https://api.github.com/repos/magento/magento2/pulls/19047"}},"in_reply_to_id":234910559},"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/19047","id":227991596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTkxNTk2","html_url":"https://github.com/magento/magento2/pull/19047","diff_url":"https://github.com/magento/magento2/pull/19047.diff","patch_url":"https://github.com/magento/magento2/pull/19047.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/19047","number":19047,"state":"open","locked":false,"title":"Refactoring for Customer\\Controller\\Address\\FormPost","user":{"login":"shandyDev","id":633883,"node_id":"MDQ6VXNlcjYzMzg4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/633883?v=4","gravatar_id":"","url":"https://api.github.com/users/shandyDev","html_url":"https://github.com/shandyDev","followers_url":"https://api.github.com/users/shandyDev/followers","following_url":"https://api.github.com/users/shandyDev/following{/other_user}","gists_url":"https://api.github.com/users/shandyDev/gists{/gist_id}","starred_url":"https://api.github.com/users/shandyDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shandyDev/subscriptions","organizations_url":"https://api.github.com/users/shandyDev/orgs","repos_url":"https://api.github.com/users/shandyDev/repos","events_url":"https://api.github.com/users/shandyDev/events{/privacy}","received_events_url":"https://api.github.com/users/shandyDev/received_events","type":"User","site_admin":false},"body":"\r\n### Description (*)\r\nInitially this should be fix for #5013 \r\nBut current implementation saving customer addresses by storefront is different then REST API or Adminhtml controller:  uses AddressRepository::save instead if CustomerRepository::save as aggregate root saving.\r\n\r\n### Fixed Issues (if relevant)\r\n\r\n1. #5013 \r\n2. New found issue: \r\nDuring saving address with VAT & group changing implemented in https://github.com/arijit-de/magento2/blob/2.3-develop/app/code/Magento/Customer/Observer/AfterAddressSaveObserver.php observer was run code `$customer->save()` which have OLD address collection which loaded in memory before new address data persist to database. So customer address re-saved with old data on `$customer->save()` call.\r\n\r\n### Manual testing scenarios (*)\r\n\r\n\r\n    1. First pull a customer with using REST API and note down the updated time.\r\n    2. Login to Frontend with the same account and edit the addresses.\r\n    3. Pull the same again and see the updated time also got changed.\r\n\r\n\r\n### Contribution checklist (*)\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [x] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [x] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-11-02T16:27:31Z","updated_at":"2018-11-20T09:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31f32888907ba40700fd417c656392e88c47ce9f","assignee":{"login":"sivaschenko","id":2028541,"node_id":"MDQ6VXNlcjIwMjg1NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2028541?v=4","gravatar_id":"","url":"https://api.github.com/users/sivaschenko","html_url":"https://github.com/sivaschenko","followers_url":"https://api.github.com/users/sivaschenko/followers","following_url":"https://api.github.com/users/sivaschenko/following{/other_user}","gists_url":"https://api.github.com/users/sivaschenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaschenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaschenko/subscriptions","organizations_url":"https://api.github.com/users/sivaschenko/orgs","repos_url":"https://api.github.com/users/sivaschenko/repos","events_url":"https://api.github.com/users/sivaschenko/events{/privacy}","received_events_url":"https://api.github.com/users/sivaschenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"sivaschenko","id":2028541,"node_id":"MDQ6VXNlcjIwMjg1NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2028541?v=4","gravatar_id":"","url":"https://api.github.com/users/sivaschenko","html_url":"https://github.com/sivaschenko","followers_url":"https://api.github.com/users/sivaschenko/followers","following_url":"https://api.github.com/users/sivaschenko/following{/other_user}","gists_url":"https://api.github.com/users/sivaschenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaschenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaschenko/subscriptions","organizations_url":"https://api.github.com/users/sivaschenko/orgs","repos_url":"https://api.github.com/users/sivaschenko/repos","events_url":"https://api.github.com/users/sivaschenko/events{/privacy}","received_events_url":"https://api.github.com/users/sivaschenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":374015207,"node_id":"MDU6TGFiZWwzNzQwMTUyMDc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Customer","name":"Component: Customer","color":"7fb703","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":420000864,"node_id":"MDU6TGFiZWw0MjAwMDA4NjQ=","url":"https://api.github.com/repos/magento/magento2/labels/bugfix","name":"bugfix","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/19047/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/19047/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/19047/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/e2c9a7ae2ce816f9fb78e9d3c2e7b90ec3e3d717","head":{"label":"opsway:2.3-develop","ref":"2.3-develop","sha":"e2c9a7ae2ce816f9fb78e9d3c2e7b90ec3e3d717","user":{"login":"opsway","id":3851238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTEyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3851238?v=4","gravatar_id":"","url":"https://api.github.com/users/opsway","html_url":"https://github.com/opsway","followers_url":"https://api.github.com/users/opsway/followers","following_url":"https://api.github.com/users/opsway/following{/other_user}","gists_url":"https://api.github.com/users/opsway/gists{/gist_id}","starred_url":"https://api.github.com/users/opsway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opsway/subscriptions","organizations_url":"https://api.github.com/users/opsway/orgs","repos_url":"https://api.github.com/users/opsway/repos","events_url":"https://api.github.com/users/opsway/events{/privacy}","received_events_url":"https://api.github.com/users/opsway/received_events","type":"Organization","site_admin":false},"repo":{"id":155832173,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4MzIxNzM=","name":"magento2","full_name":"opsway/magento2","private":false,"owner":{"login":"opsway","id":3851238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTEyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3851238?v=4","gravatar_id":"","url":"https://api.github.com/users/opsway","html_url":"https://github.com/opsway","followers_url":"https://api.github.com/users/opsway/followers","following_url":"https://api.github.com/users/opsway/following{/other_user}","gists_url":"https://api.github.com/users/opsway/gists{/gist_id}","starred_url":"https://api.github.com/users/opsway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opsway/subscriptions","organizations_url":"https://api.github.com/users/opsway/orgs","repos_url":"https://api.github.com/users/opsway/repos","events_url":"https://api.github.com/users/opsway/events{/privacy}","received_events_url":"https://api.github.com/users/opsway/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opsway/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/opsway/magento2","forks_url":"https://api.github.com/repos/opsway/magento2/forks","keys_url":"https://api.github.com/repos/opsway/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opsway/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opsway/magento2/teams","hooks_url":"https://api.github.com/repos/opsway/magento2/hooks","issue_events_url":"https://api.github.com/repos/opsway/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/opsway/magento2/events","assignees_url":"https://api.github.com/repos/opsway/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/opsway/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/opsway/magento2/tags","blobs_url":"https://api.github.com/repos/opsway/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opsway/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opsway/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/opsway/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opsway/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/opsway/magento2/languages","stargazers_url":"https://api.github.com/repos/opsway/magento2/stargazers","contributors_url":"https://api.github.com/repos/opsway/magento2/contributors","subscribers_url":"https://api.github.com/repos/opsway/magento2/subscribers","subscription_url":"https://api.github.com/repos/opsway/magento2/subscription","commits_url":"https://api.github.com/repos/opsway/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/opsway/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/opsway/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/opsway/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/opsway/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/opsway/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opsway/magento2/merges","archive_url":"https://api.github.com/repos/opsway/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opsway/magento2/downloads","issues_url":"https://api.github.com/repos/opsway/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/opsway/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/opsway/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/opsway/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opsway/magento2/labels{/name}","releases_url":"https://api.github.com/repos/opsway/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/opsway/magento2/deployments","created_at":"2018-11-02T07:51:46Z","updated_at":"2018-11-19T07:41:54Z","pushed_at":"2018-11-19T07:41:48Z","git_url":"git://github.com/opsway/magento2.git","ssh_url":"git@github.com:opsway/magento2.git","clone_url":"https://github.com/opsway/magento2.git","svn_url":"https://github.com/opsway/magento2","homepage":"http://www.magento.com","size":490257,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"b9bd73832a0cd6c1ad4e479ab060c2bf2551f24a","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-11-20T08:04:31Z","pushed_at":"2018-11-20T08:21:59Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":492619,"stargazers_count":6376,"watchers_count":6376,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5561,"mirror_url":null,"archived":false,"open_issues_count":1309,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5561,"open_issues":1309,"watchers":6376,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/19047"},"html":{"href":"https://github.com/magento/magento2/pull/19047"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/19047"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/19047/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/19047/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/19047/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/e2c9a7ae2ce816f9fb78e9d3c2e7b90ec3e3d717"}},"author_association":"NONE"}}
{"actor":{"display_login":"dmitrijivanenko"}}