{"action":"created","issue":{"url":"https://api.github.com/repos/rancher/rancher/issues/16648","repository_url":"https://api.github.com/repos/rancher/rancher","labels_url":"https://api.github.com/repos/rancher/rancher/issues/16648/labels{/name}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/16648/comments","events_url":"https://api.github.com/repos/rancher/rancher/issues/16648/events","html_url":"https://github.com/rancher/rancher/pull/16648","id":382406345,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTIyMzAw","number":16648,"title":"Fix snapshot upgrade","user":{"login":"maxkorp","id":1302526,"node_id":"MDQ6VXNlcjEzMDI1MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1302526?v=4","gravatar_id":"","url":"https://api.github.com/users/maxkorp","html_url":"https://github.com/maxkorp","followers_url":"https://api.github.com/users/maxkorp/followers","following_url":"https://api.github.com/users/maxkorp/following{/other_user}","gists_url":"https://api.github.com/users/maxkorp/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkorp/subscriptions","organizations_url":"https://api.github.com/users/maxkorp/orgs","repos_url":"https://api.github.com/users/maxkorp/repos","events_url":"https://api.github.com/users/maxkorp/events{/privacy}","received_events_url":"https://api.github.com/users/maxkorp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T21:47:57Z","updated_at":"2018-11-20T00:34:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/16648","html_url":"https://github.com/rancher/rancher/pull/16648","diff_url":"https://github.com/rancher/rancher/pull/16648.diff","patch_url":"https://github.com/rancher/rancher/pull/16648.patch"},"body":"For existing clusters, the snapshot value for the etcd service is nil. The RKE driver will interpret this as true, but we want it to behave as false in the API. We catch it before norman applies defaults (which would cause it to show as true), and say that if it is nil, it is false. \r\n\r\nWe also now convert a nil value for the snapshot setting as false. This only happens when we're already planning on passing the clusterspec to the driver update. This way, nil snapshot values which are considered false in the UI don't get handled as true in the RKE driver"},"comment":{"url":"https://api.github.com/repos/rancher/rancher/issues/comments/440093011","html_url":"https://github.com/rancher/rancher/pull/16648#issuecomment-440093011","issue_url":"https://api.github.com/repos/rancher/rancher/issues/16648","id":440093011,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDA5MzAxMQ==","user":{"login":"alena1108","id":1562176,"node_id":"MDQ6VXNlcjE1NjIxNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1562176?v=4","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T00:34:59Z","updated_at":"2018-11-20T00:34:59Z","author_association":"MEMBER","body":"LGTM. Can we squash 3 commits into 1? "}}
{"actor":{"display_login":"alena1108"}}