{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16","id":178924523,"html_url":"https://github.com/GabrielCastro/neon-serde/pull/16","diff_url":"https://github.com/GabrielCastro/neon-serde/pull/16.diff","patch_url":"https://github.com/GabrielCastro/neon-serde/pull/16.patch","issue_url":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/16","number":16,"state":"closed","locked":false,"title":"Skip deserializing unused values","user":{"login":"kjvalencik","id":2471970,"avatar_url":"https://avatars0.githubusercontent.com/u/2471970?v=4","gravatar_id":"","url":"https://api.github.com/users/kjvalencik","html_url":"https://github.com/kjvalencik","followers_url":"https://api.github.com/users/kjvalencik/followers","following_url":"https://api.github.com/users/kjvalencik/following{/other_user}","gists_url":"https://api.github.com/users/kjvalencik/gists{/gist_id}","starred_url":"https://api.github.com/users/kjvalencik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjvalencik/subscriptions","organizations_url":"https://api.github.com/users/kjvalencik/orgs","repos_url":"https://api.github.com/users/kjvalencik/repos","events_url":"https://api.github.com/users/kjvalencik/events{/privacy}","received_events_url":"https://api.github.com/users/kjvalencik/received_events","type":"User","site_admin":false},"body":"This should optimize parsing sparse objects by preventing recursion if the value is thrown away. It also partially resolves https://github.com/GabrielCastro/neon-serde/issues/15 for circular references that are not in the model.\r\n\r\nFor example, attempting to deserialize even a single field from the http `request` object will cause a segfault from the circular references even `client`, `socket`, and `connection` (the objects that contain circular references) are omitted.\r\n\r\nThe full fix for circular references will require some bookkeeping on raw handles in the depth first walk. I'm not sure this is worth it because it would require a rust object that allows for cycles and a source object that also has them.","created_at":"2018-04-02T20:27:43Z","updated_at":"2018-04-09T15:25:22Z","closed_at":"2018-04-09T15:25:22Z","merged_at":"2018-04-09T15:25:21Z","merge_commit_sha":"64f22a9611638bad1a54b049a761cfbf0bbb4edd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16/commits","review_comments_url":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16/comments","review_comment_url":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/16/comments","statuses_url":"https://api.github.com/repos/GabrielCastro/neon-serde/statuses/0c57f27dfde298c0148f9c93691ba324c7544607","head":{"label":"kjvalencik:master","ref":"master","sha":"0c57f27dfde298c0148f9c93691ba324c7544607","user":{"login":"kjvalencik","id":2471970,"avatar_url":"https://avatars0.githubusercontent.com/u/2471970?v=4","gravatar_id":"","url":"https://api.github.com/users/kjvalencik","html_url":"https://github.com/kjvalencik","followers_url":"https://api.github.com/users/kjvalencik/followers","following_url":"https://api.github.com/users/kjvalencik/following{/other_user}","gists_url":"https://api.github.com/users/kjvalencik/gists{/gist_id}","starred_url":"https://api.github.com/users/kjvalencik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjvalencik/subscriptions","organizations_url":"https://api.github.com/users/kjvalencik/orgs","repos_url":"https://api.github.com/users/kjvalencik/repos","events_url":"https://api.github.com/users/kjvalencik/events{/privacy}","received_events_url":"https://api.github.com/users/kjvalencik/received_events","type":"User","site_admin":false},"repo":{"id":127808215,"name":"neon-serde","full_name":"kjvalencik/neon-serde","owner":{"login":"kjvalencik","id":2471970,"avatar_url":"https://avatars0.githubusercontent.com/u/2471970?v=4","gravatar_id":"","url":"https://api.github.com/users/kjvalencik","html_url":"https://github.com/kjvalencik","followers_url":"https://api.github.com/users/kjvalencik/followers","following_url":"https://api.github.com/users/kjvalencik/following{/other_user}","gists_url":"https://api.github.com/users/kjvalencik/gists{/gist_id}","starred_url":"https://api.github.com/users/kjvalencik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjvalencik/subscriptions","organizations_url":"https://api.github.com/users/kjvalencik/orgs","repos_url":"https://api.github.com/users/kjvalencik/repos","events_url":"https://api.github.com/users/kjvalencik/events{/privacy}","received_events_url":"https://api.github.com/users/kjvalencik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjvalencik/neon-serde","description":null,"fork":true,"url":"https://api.github.com/repos/kjvalencik/neon-serde","forks_url":"https://api.github.com/repos/kjvalencik/neon-serde/forks","keys_url":"https://api.github.com/repos/kjvalencik/neon-serde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjvalencik/neon-serde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjvalencik/neon-serde/teams","hooks_url":"https://api.github.com/repos/kjvalencik/neon-serde/hooks","issue_events_url":"https://api.github.com/repos/kjvalencik/neon-serde/issues/events{/number}","events_url":"https://api.github.com/repos/kjvalencik/neon-serde/events","assignees_url":"https://api.github.com/repos/kjvalencik/neon-serde/assignees{/user}","branches_url":"https://api.github.com/repos/kjvalencik/neon-serde/branches{/branch}","tags_url":"https://api.github.com/repos/kjvalencik/neon-serde/tags","blobs_url":"https://api.github.com/repos/kjvalencik/neon-serde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjvalencik/neon-serde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjvalencik/neon-serde/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjvalencik/neon-serde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjvalencik/neon-serde/statuses/{sha}","languages_url":"https://api.github.com/repos/kjvalencik/neon-serde/languages","stargazers_url":"https://api.github.com/repos/kjvalencik/neon-serde/stargazers","contributors_url":"https://api.github.com/repos/kjvalencik/neon-serde/contributors","subscribers_url":"https://api.github.com/repos/kjvalencik/neon-serde/subscribers","subscription_url":"https://api.github.com/repos/kjvalencik/neon-serde/subscription","commits_url":"https://api.github.com/repos/kjvalencik/neon-serde/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjvalencik/neon-serde/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjvalencik/neon-serde/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjvalencik/neon-serde/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjvalencik/neon-serde/contents/{+path}","compare_url":"https://api.github.com/repos/kjvalencik/neon-serde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjvalencik/neon-serde/merges","archive_url":"https://api.github.com/repos/kjvalencik/neon-serde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjvalencik/neon-serde/downloads","issues_url":"https://api.github.com/repos/kjvalencik/neon-serde/issues{/number}","pulls_url":"https://api.github.com/repos/kjvalencik/neon-serde/pulls{/number}","milestones_url":"https://api.github.com/repos/kjvalencik/neon-serde/milestones{/number}","notifications_url":"https://api.github.com/repos/kjvalencik/neon-serde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjvalencik/neon-serde/labels{/name}","releases_url":"https://api.github.com/repos/kjvalencik/neon-serde/releases{/id}","deployments_url":"https://api.github.com/repos/kjvalencik/neon-serde/deployments","created_at":"2018-04-02T20:23:29Z","updated_at":"2018-04-02T20:57:18Z","pushed_at":"2018-04-04T15:52:58Z","git_url":"git://github.com/kjvalencik/neon-serde.git","ssh_url":"git@github.com:kjvalencik/neon-serde.git","clone_url":"https://github.com/kjvalencik/neon-serde.git","svn_url":"https://github.com/kjvalencik/neon-serde","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GabrielCastro:master","ref":"master","sha":"2cbdd185ad3d35925cd41378c8cdc58c89ebc53a","user":{"login":"GabrielCastro","id":3661001,"avatar_url":"https://avatars1.githubusercontent.com/u/3661001?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielCastro","html_url":"https://github.com/GabrielCastro","followers_url":"https://api.github.com/users/GabrielCastro/followers","following_url":"https://api.github.com/users/GabrielCastro/following{/other_user}","gists_url":"https://api.github.com/users/GabrielCastro/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielCastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielCastro/subscriptions","organizations_url":"https://api.github.com/users/GabrielCastro/orgs","repos_url":"https://api.github.com/users/GabrielCastro/repos","events_url":"https://api.github.com/users/GabrielCastro/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielCastro/received_events","type":"User","site_admin":false},"repo":{"id":103866748,"name":"neon-serde","full_name":"GabrielCastro/neon-serde","owner":{"login":"GabrielCastro","id":3661001,"avatar_url":"https://avatars1.githubusercontent.com/u/3661001?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielCastro","html_url":"https://github.com/GabrielCastro","followers_url":"https://api.github.com/users/GabrielCastro/followers","following_url":"https://api.github.com/users/GabrielCastro/following{/other_user}","gists_url":"https://api.github.com/users/GabrielCastro/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielCastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielCastro/subscriptions","organizations_url":"https://api.github.com/users/GabrielCastro/orgs","repos_url":"https://api.github.com/users/GabrielCastro/repos","events_url":"https://api.github.com/users/GabrielCastro/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielCastro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GabrielCastro/neon-serde","description":null,"fork":false,"url":"https://api.github.com/repos/GabrielCastro/neon-serde","forks_url":"https://api.github.com/repos/GabrielCastro/neon-serde/forks","keys_url":"https://api.github.com/repos/GabrielCastro/neon-serde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GabrielCastro/neon-serde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GabrielCastro/neon-serde/teams","hooks_url":"https://api.github.com/repos/GabrielCastro/neon-serde/hooks","issue_events_url":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/events{/number}","events_url":"https://api.github.com/repos/GabrielCastro/neon-serde/events","assignees_url":"https://api.github.com/repos/GabrielCastro/neon-serde/assignees{/user}","branches_url":"https://api.github.com/repos/GabrielCastro/neon-serde/branches{/branch}","tags_url":"https://api.github.com/repos/GabrielCastro/neon-serde/tags","blobs_url":"https://api.github.com/repos/GabrielCastro/neon-serde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GabrielCastro/neon-serde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GabrielCastro/neon-serde/git/refs{/sha}","trees_url":"https://api.github.com/repos/GabrielCastro/neon-serde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GabrielCastro/neon-serde/statuses/{sha}","languages_url":"https://api.github.com/repos/GabrielCastro/neon-serde/languages","stargazers_url":"https://api.github.com/repos/GabrielCastro/neon-serde/stargazers","contributors_url":"https://api.github.com/repos/GabrielCastro/neon-serde/contributors","subscribers_url":"https://api.github.com/repos/GabrielCastro/neon-serde/subscribers","subscription_url":"https://api.github.com/repos/GabrielCastro/neon-serde/subscription","commits_url":"https://api.github.com/repos/GabrielCastro/neon-serde/commits{/sha}","git_commits_url":"https://api.github.com/repos/GabrielCastro/neon-serde/git/commits{/sha}","comments_url":"https://api.github.com/repos/GabrielCastro/neon-serde/comments{/number}","issue_comment_url":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/comments{/number}","contents_url":"https://api.github.com/repos/GabrielCastro/neon-serde/contents/{+path}","compare_url":"https://api.github.com/repos/GabrielCastro/neon-serde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GabrielCastro/neon-serde/merges","archive_url":"https://api.github.com/repos/GabrielCastro/neon-serde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GabrielCastro/neon-serde/downloads","issues_url":"https://api.github.com/repos/GabrielCastro/neon-serde/issues{/number}","pulls_url":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls{/number}","milestones_url":"https://api.github.com/repos/GabrielCastro/neon-serde/milestones{/number}","notifications_url":"https://api.github.com/repos/GabrielCastro/neon-serde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GabrielCastro/neon-serde/labels{/name}","releases_url":"https://api.github.com/repos/GabrielCastro/neon-serde/releases{/id}","deployments_url":"https://api.github.com/repos/GabrielCastro/neon-serde/deployments","created_at":"2017-09-17T22:33:12Z","updated_at":"2018-04-09T15:24:36Z","pushed_at":"2018-04-09T15:25:21Z","git_url":"git://github.com/GabrielCastro/neon-serde.git","ssh_url":"git@github.com:GabrielCastro/neon-serde.git","clone_url":"https://github.com/GabrielCastro/neon-serde.git","svn_url":"https://github.com/GabrielCastro/neon-serde","homepage":null,"size":108,"stargazers_count":17,"watchers_count":17,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16"},"html":{"href":"https://github.com/GabrielCastro/neon-serde/pull/16"},"issue":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/16"},"comments":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/GabrielCastro/neon-serde/statuses/0c57f27dfde298c0148f9c93691ba324c7544607"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"GabrielCastro","id":3661001,"avatar_url":"https://avatars1.githubusercontent.com/u/3661001?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielCastro","html_url":"https://github.com/GabrielCastro","followers_url":"https://api.github.com/users/GabrielCastro/followers","following_url":"https://api.github.com/users/GabrielCastro/following{/other_user}","gists_url":"https://api.github.com/users/GabrielCastro/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielCastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielCastro/subscriptions","organizations_url":"https://api.github.com/users/GabrielCastro/orgs","repos_url":"https://api.github.com/users/GabrielCastro/repos","events_url":"https://api.github.com/users/GabrielCastro/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielCastro/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"GabrielCastro"}}