{"action":"created","issue":{"url":"https://api.github.com/repos/bigtestjs/convergence/issues/25","repository_url":"https://api.github.com/repos/bigtestjs/convergence","labels_url":"https://api.github.com/repos/bigtestjs/convergence/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/bigtestjs/convergence/issues/25/comments","events_url":"https://api.github.com/repos/bigtestjs/convergence/issues/25/events","html_url":"https://github.com/bigtestjs/convergence/issues/25","id":385009665,"node_id":"MDU6SXNzdWUzODUwMDk2NjU=","number":25,"title":"when() and always() are throwing \"Error: convergent assertion encountered a async function or promise; since convergent assertions can run multiple times, you should avoid introducing side-effects inside of them\"","user":{"login":"jonnolen","id":617662,"node_id":"MDQ6VXNlcjYxNzY2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/617662?v=4","gravatar_id":"","url":"https://api.github.com/users/jonnolen","html_url":"https://github.com/jonnolen","followers_url":"https://api.github.com/users/jonnolen/followers","following_url":"https://api.github.com/users/jonnolen/following{/other_user}","gists_url":"https://api.github.com/users/jonnolen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonnolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonnolen/subscriptions","organizations_url":"https://api.github.com/users/jonnolen/orgs","repos_url":"https://api.github.com/users/jonnolen/repos","events_url":"https://api.github.com/users/jonnolen/events{/privacy}","received_events_url":"https://api.github.com/users/jonnolen/received_events","type":"User","site_admin":false},"labels":[{"id":902611499,"node_id":"MDU6TGFiZWw5MDI2MTE0OTk=","url":"https://api.github.com/repos/bigtestjs/convergence/labels/triage","name":"triage","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-27T22:12:55Z","updated_at":"2018-11-27T22:46:25Z","closed_at":"2018-11-27T22:41:11Z","author_association":"NONE","body":"bigtest/convergence v 1.1.1\r\n\r\n```\r\nit('why does it say async function when there is no async function?!', always( () => {\r\n   expect(0).to.not.equal(1);\r\n}));\r\n```\r\n\r\n```\r\nit('why does it say async function when there is no async function?!', always( () => {\r\n   return 0 !== 1;\r\n}));\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bigtestjs/convergence/issues/comments/442247489","html_url":"https://github.com/bigtestjs/convergence/issues/25#issuecomment-442247489","issue_url":"https://api.github.com/repos/bigtestjs/convergence/issues/25","id":442247489,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjI0NzQ4OQ==","user":{"login":"Robdel12","id":2072894,"node_id":"MDQ6VXNlcjIwNzI4OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2072894?v=4","gravatar_id":"","url":"https://api.github.com/users/Robdel12","html_url":"https://github.com/Robdel12","followers_url":"https://api.github.com/users/Robdel12/followers","following_url":"https://api.github.com/users/Robdel12/following{/other_user}","gists_url":"https://api.github.com/users/Robdel12/gists{/gist_id}","starred_url":"https://api.github.com/users/Robdel12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robdel12/subscriptions","organizations_url":"https://api.github.com/users/Robdel12/orgs","repos_url":"https://api.github.com/users/Robdel12/repos","events_url":"https://api.github.com/users/Robdel12/events{/privacy}","received_events_url":"https://api.github.com/users/Robdel12/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T22:46:25Z","updated_at":"2018-11-27T22:46:25Z","author_association":"MEMBER","body":"Gotcha! That makes sense. We saw some issues where `@bigtest/mocha` would subtly troll people because it requires a strict testing style. All effects in `beforeEach` and pure assertions in `its` 😊\r\n\r\nSo that's where that error came from. If you mix and match that style, what you did was totally valid outside of `@bigtest/mocha`. You could use a regular mocha setup and use `async/await` too. "}}
{"actor":{"display_login":"Robdel12"}}