{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/rkv/pulls/comments/205638131","pull_request_review_id":140951192,"id":205638131,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTYzODEzMQ==","diff_hunk":"@@ -336,6 +336,25 @@ mod tests {\n         let _sk: Store<&str> = k.open(\"sk\").expect(\"open a missing store\");\n     }\n \n+    #[test]\n+    fn test_open_fail_with_badrslot() {\n+        let root = Builder::new().prefix(\"test_open_fail_with_badrslot\").tempdir().expect(\"tempdir\");\n+        fs::create_dir_all(root.path()).expect(\"dir created\");\n+        let k = Rkv::new(root.path()).expect(\"new succeeded\");\n+        // First create the store\n+        let _sk: Store<&str> = k.open_or_create(\"sk\").expect(\"opened\");\n+        // Open the same store for read\n+        let sk_readonly: Store<&str> = k.open(\"sk\").expect(\"opened\");","path":"src/env.rs","position":null,"original_position":12,"commit_id":"e86a36b983d1ce2c3245563702bbab8f5ebfc441","original_commit_id":"96158ad405c680ddb5bec78a72fedbd8123e9a76","user":{"login":"ncloudioj","id":1455254,"node_id":"MDQ6VXNlcjE0NTUyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1455254?v=4","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"body":"@mykmelez You're completely right, as long as there is an ongoing reader, the underlying read transaction in `Rkv::open()` would hit \"BAD_SLOT\".\r\n\r\nAlready updated the patch.","created_at":"2018-07-27T00:17:50Z","updated_at":"2018-07-27T00:17:50Z","html_url":"https://github.com/mozilla/rkv/pull/63#discussion_r205638131","pull_request_url":"https://api.github.com/repos/mozilla/rkv/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/comments/205638131"},"html":{"href":"https://github.com/mozilla/rkv/pull/63#discussion_r205638131"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/63"}},"in_reply_to_id":205635113},"pull_request":{"url":"https://api.github.com/repos/mozilla/rkv/pulls/63","id":204213521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjEzNTIx","html_url":"https://github.com/mozilla/rkv/pull/63","diff_url":"https://github.com/mozilla/rkv/pull/63.diff","patch_url":"https://github.com/mozilla/rkv/pull/63.patch","issue_url":"https://api.github.com/repos/mozilla/rkv/issues/63","number":63,"state":"open","locked":false,"title":"add a test to cover the bad_rslot error","user":{"login":"ncloudioj","id":1455254,"node_id":"MDQ6VXNlcjE0NTUyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1455254?v=4","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"body":"A followup of #61 \r\n\r\nr? @mykmelez ","created_at":"2018-07-26T17:29:58Z","updated_at":"2018-07-27T00:17:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec3f6c0add3a0b55e12544b5ba7ef87ce1a68a3c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/rkv/pulls/63/commits","review_comments_url":"https://api.github.com/repos/mozilla/rkv/pulls/63/comments","review_comment_url":"https://api.github.com/repos/mozilla/rkv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/rkv/issues/63/comments","statuses_url":"https://api.github.com/repos/mozilla/rkv/statuses/e86a36b983d1ce2c3245563702bbab8f5ebfc441","head":{"label":"ncloudioj:test-badrslot","ref":"test-badrslot","sha":"e86a36b983d1ce2c3245563702bbab8f5ebfc441","user":{"login":"ncloudioj","id":1455254,"node_id":"MDQ6VXNlcjE0NTUyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1455254?v=4","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"repo":{"id":136370841,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzNzA4NDE=","name":"rkv","full_name":"ncloudioj/rkv","owner":{"login":"ncloudioj","id":1455254,"node_id":"MDQ6VXNlcjE0NTUyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1455254?v=4","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncloudioj/rkv","description":"A simple, humane, typed Rust interface to LMDB.","fork":true,"url":"https://api.github.com/repos/ncloudioj/rkv","forks_url":"https://api.github.com/repos/ncloudioj/rkv/forks","keys_url":"https://api.github.com/repos/ncloudioj/rkv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncloudioj/rkv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncloudioj/rkv/teams","hooks_url":"https://api.github.com/repos/ncloudioj/rkv/hooks","issue_events_url":"https://api.github.com/repos/ncloudioj/rkv/issues/events{/number}","events_url":"https://api.github.com/repos/ncloudioj/rkv/events","assignees_url":"https://api.github.com/repos/ncloudioj/rkv/assignees{/user}","branches_url":"https://api.github.com/repos/ncloudioj/rkv/branches{/branch}","tags_url":"https://api.github.com/repos/ncloudioj/rkv/tags","blobs_url":"https://api.github.com/repos/ncloudioj/rkv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncloudioj/rkv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncloudioj/rkv/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncloudioj/rkv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncloudioj/rkv/statuses/{sha}","languages_url":"https://api.github.com/repos/ncloudioj/rkv/languages","stargazers_url":"https://api.github.com/repos/ncloudioj/rkv/stargazers","contributors_url":"https://api.github.com/repos/ncloudioj/rkv/contributors","subscribers_url":"https://api.github.com/repos/ncloudioj/rkv/subscribers","subscription_url":"https://api.github.com/repos/ncloudioj/rkv/subscription","commits_url":"https://api.github.com/repos/ncloudioj/rkv/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncloudioj/rkv/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncloudioj/rkv/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncloudioj/rkv/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncloudioj/rkv/contents/{+path}","compare_url":"https://api.github.com/repos/ncloudioj/rkv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncloudioj/rkv/merges","archive_url":"https://api.github.com/repos/ncloudioj/rkv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncloudioj/rkv/downloads","issues_url":"https://api.github.com/repos/ncloudioj/rkv/issues{/number}","pulls_url":"https://api.github.com/repos/ncloudioj/rkv/pulls{/number}","milestones_url":"https://api.github.com/repos/ncloudioj/rkv/milestones{/number}","notifications_url":"https://api.github.com/repos/ncloudioj/rkv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncloudioj/rkv/labels{/name}","releases_url":"https://api.github.com/repos/ncloudioj/rkv/releases{/id}","deployments_url":"https://api.github.com/repos/ncloudioj/rkv/deployments","created_at":"2018-06-06T18:35:18Z","updated_at":"2018-06-19T18:04:49Z","pushed_at":"2018-07-27T00:13:30Z","git_url":"git://github.com/ncloudioj/rkv.git","ssh_url":"git@github.com:ncloudioj/rkv.git","clone_url":"https://github.com/ncloudioj/rkv.git","svn_url":"https://github.com/ncloudioj/rkv","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"235e5411fdf2495f8f36ff58676bcdd15fd10774","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":118936515,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5MzY1MTU=","name":"rkv","full_name":"mozilla/rkv","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/rkv","description":"A simple, humane, typed Rust interface to LMDB.","fork":false,"url":"https://api.github.com/repos/mozilla/rkv","forks_url":"https://api.github.com/repos/mozilla/rkv/forks","keys_url":"https://api.github.com/repos/mozilla/rkv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/rkv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/rkv/teams","hooks_url":"https://api.github.com/repos/mozilla/rkv/hooks","issue_events_url":"https://api.github.com/repos/mozilla/rkv/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/rkv/events","assignees_url":"https://api.github.com/repos/mozilla/rkv/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/rkv/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/rkv/tags","blobs_url":"https://api.github.com/repos/mozilla/rkv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/rkv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/rkv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/rkv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/rkv/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/rkv/languages","stargazers_url":"https://api.github.com/repos/mozilla/rkv/stargazers","contributors_url":"https://api.github.com/repos/mozilla/rkv/contributors","subscribers_url":"https://api.github.com/repos/mozilla/rkv/subscribers","subscription_url":"https://api.github.com/repos/mozilla/rkv/subscription","commits_url":"https://api.github.com/repos/mozilla/rkv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/rkv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/rkv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/rkv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/rkv/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/rkv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/rkv/merges","archive_url":"https://api.github.com/repos/mozilla/rkv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/rkv/downloads","issues_url":"https://api.github.com/repos/mozilla/rkv/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/rkv/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/rkv/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/rkv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/rkv/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/rkv/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/rkv/deployments","created_at":"2018-01-25T16:15:17Z","updated_at":"2018-07-26T16:36:31Z","pushed_at":"2018-07-27T00:13:32Z","git_url":"git://github.com/mozilla/rkv.git","ssh_url":"git@github.com:mozilla/rkv.git","clone_url":"https://github.com/mozilla/rkv.git","svn_url":"https://github.com/mozilla/rkv","homepage":null,"size":85,"stargazers_count":30,"watchers_count":30,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":26,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/63"},"html":{"href":"https://github.com/mozilla/rkv/pull/63"},"issue":{"href":"https://api.github.com/repos/mozilla/rkv/issues/63"},"comments":{"href":"https://api.github.com/repos/mozilla/rkv/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/rkv/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/rkv/statuses/e86a36b983d1ce2c3245563702bbab8f5ebfc441"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ncloudioj"}}