{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/remix-ide/pulls/comments/199704343","pull_request_review_id":133872988,"id":199704343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTcwNDM0Mw==","diff_hunk":"@@ -96,11 +114,17 @@ class MultiParamManager {\n     }\n   }\n \n-  createMultiFields () {\n+  createMultiFields (uniqueId) {\n     if (this.funABI.inputs) {\n+      var that = this\n       return yo`<div>\n-        ${this.funABI.inputs.map(function (inp) {\n-          return yo`<div class=\"${css.multiArg}\"><label for=\"${inp.name}\"> ${inp.name}: </label><input placeholder=\"${inp.type}\" title=\"${inp.name}\"></div>`\n+        ${this.funABI.inputs.map(function (inp, idx) {\n+          function setUpValidator (id) {\n+            $(`#${id}`).off('blur')\n+            $(`#${id}`).blur(() => doValidation(that, id))\n+          }\n+          var id = `${uniqueId}${inp.type}${inp.name}${idx}`\n+          return yo`<div class=\"${css.multiArg}\"><label for=\"${inp.name}\"> ${inp.name}: </label><input id=\"${id}\" onclick=${() => { setUpValidator(id) }} placeholder=\"${inp.type}\" title=\"${inp.name}\"></div>`","path":"src/multiParamManager.js","position":51,"original_position":51,"commit_id":"63ccadd68811b69361b9f90d662d06a2cc566a82","original_commit_id":"63ccadd68811b69361b9f90d662d06a2cc566a82","user":{"login":"yann300","id":6940742,"node_id":"MDQ6VXNlcjY5NDA3NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/6940742?v=4","gravatar_id":"","url":"https://api.github.com/users/yann300","html_url":"https://github.com/yann300","followers_url":"https://api.github.com/users/yann300/followers","following_url":"https://api.github.com/users/yann300/following{/other_user}","gists_url":"https://api.github.com/users/yann300/gists{/gist_id}","starred_url":"https://api.github.com/users/yann300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yann300/subscriptions","organizations_url":"https://api.github.com/users/yann300/orgs","repos_url":"https://api.github.com/users/yann300/repos","events_url":"https://api.github.com/users/yann300/events{/privacy}","received_events_url":"https://api.github.com/users/yann300/received_events","type":"User","site_admin":false},"body":"Perhaps using `onchange` event instead of onclick would be better for this? \r\nAnd to avoid spamming perhaps having a mechanism like https://github.com/ethereum/remix-ide/blob/master/src/app.js#L941\r\nwhich start validating after like 700ms of inactivity\r\n","created_at":"2018-07-03T07:14:50Z","updated_at":"2018-07-03T07:14:51Z","html_url":"https://github.com/ethereum/remix-ide/pull/1381#discussion_r199704343","pull_request_url":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/comments/199704343"},"html":{"href":"https://github.com/ethereum/remix-ide/pull/1381#discussion_r199704343"},"pull_request":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381","id":198501749,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTAxNzQ5","html_url":"https://github.com/ethereum/remix-ide/pull/1381","diff_url":"https://github.com/ethereum/remix-ide/pull/1381.diff","patch_url":"https://github.com/ethereum/remix-ide/pull/1381.patch","issue_url":"https://api.github.com/repos/ethereum/remix-ide/issues/1381","number":1381,"state":"open","locked":false,"title":"Fixes Issue #1321","user":{"login":"willdeuschle","id":16803992,"node_id":"MDQ6VXNlcjE2ODAzOTky","avatar_url":"https://avatars0.githubusercontent.com/u/16803992?v=4","gravatar_id":"","url":"https://api.github.com/users/willdeuschle","html_url":"https://github.com/willdeuschle","followers_url":"https://api.github.com/users/willdeuschle/followers","following_url":"https://api.github.com/users/willdeuschle/following{/other_user}","gists_url":"https://api.github.com/users/willdeuschle/gists{/gist_id}","starred_url":"https://api.github.com/users/willdeuschle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdeuschle/subscriptions","organizations_url":"https://api.github.com/users/willdeuschle/orgs","repos_url":"https://api.github.com/users/willdeuschle/repos","events_url":"https://api.github.com/users/willdeuschle/events{/privacy}","received_events_url":"https://api.github.com/users/willdeuschle/received_events","type":"User","site_admin":false},"body":"A fix for #1321, found via bounty on Gitcoin.\r\n\r\nWe check the validity of the address, and render it red or grey accordingly:\r\n\r\n![screen shot 2018-06-30 at 8 40 23 pm](https://user-images.githubusercontent.com/16803992/42130167-6258fab6-7caa-11e8-9e85-fe7d489d8366.png)\r\n","created_at":"2018-07-01T01:13:16Z","updated_at":"2018-07-03T07:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cce54aa80a3b187e86a280fcf54bee0c771e13d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381/commits","review_comments_url":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381/comments","review_comment_url":"https://api.github.com/repos/ethereum/remix-ide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/remix-ide/issues/1381/comments","statuses_url":"https://api.github.com/repos/ethereum/remix-ide/statuses/63ccadd68811b69361b9f90d662d06a2cc566a82","head":{"label":"willdeuschle:fixing-highlight","ref":"fixing-highlight","sha":"63ccadd68811b69361b9f90d662d06a2cc566a82","user":{"login":"willdeuschle","id":16803992,"node_id":"MDQ6VXNlcjE2ODAzOTky","avatar_url":"https://avatars0.githubusercontent.com/u/16803992?v=4","gravatar_id":"","url":"https://api.github.com/users/willdeuschle","html_url":"https://github.com/willdeuschle","followers_url":"https://api.github.com/users/willdeuschle/followers","following_url":"https://api.github.com/users/willdeuschle/following{/other_user}","gists_url":"https://api.github.com/users/willdeuschle/gists{/gist_id}","starred_url":"https://api.github.com/users/willdeuschle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdeuschle/subscriptions","organizations_url":"https://api.github.com/users/willdeuschle/orgs","repos_url":"https://api.github.com/users/willdeuschle/repos","events_url":"https://api.github.com/users/willdeuschle/events{/privacy}","received_events_url":"https://api.github.com/users/willdeuschle/received_events","type":"User","site_admin":false},"repo":{"id":139290389,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyOTAzODk=","name":"remix-ide","full_name":"willdeuschle/remix-ide","owner":{"login":"willdeuschle","id":16803992,"node_id":"MDQ6VXNlcjE2ODAzOTky","avatar_url":"https://avatars0.githubusercontent.com/u/16803992?v=4","gravatar_id":"","url":"https://api.github.com/users/willdeuschle","html_url":"https://github.com/willdeuschle","followers_url":"https://api.github.com/users/willdeuschle/followers","following_url":"https://api.github.com/users/willdeuschle/following{/other_user}","gists_url":"https://api.github.com/users/willdeuschle/gists{/gist_id}","starred_url":"https://api.github.com/users/willdeuschle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdeuschle/subscriptions","organizations_url":"https://api.github.com/users/willdeuschle/orgs","repos_url":"https://api.github.com/users/willdeuschle/repos","events_url":"https://api.github.com/users/willdeuschle/events{/privacy}","received_events_url":"https://api.github.com/users/willdeuschle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willdeuschle/remix-ide","description":"Browser-Only Solidity IDE and Runtime Environment","fork":true,"url":"https://api.github.com/repos/willdeuschle/remix-ide","forks_url":"https://api.github.com/repos/willdeuschle/remix-ide/forks","keys_url":"https://api.github.com/repos/willdeuschle/remix-ide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willdeuschle/remix-ide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willdeuschle/remix-ide/teams","hooks_url":"https://api.github.com/repos/willdeuschle/remix-ide/hooks","issue_events_url":"https://api.github.com/repos/willdeuschle/remix-ide/issues/events{/number}","events_url":"https://api.github.com/repos/willdeuschle/remix-ide/events","assignees_url":"https://api.github.com/repos/willdeuschle/remix-ide/assignees{/user}","branches_url":"https://api.github.com/repos/willdeuschle/remix-ide/branches{/branch}","tags_url":"https://api.github.com/repos/willdeuschle/remix-ide/tags","blobs_url":"https://api.github.com/repos/willdeuschle/remix-ide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willdeuschle/remix-ide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willdeuschle/remix-ide/git/refs{/sha}","trees_url":"https://api.github.com/repos/willdeuschle/remix-ide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willdeuschle/remix-ide/statuses/{sha}","languages_url":"https://api.github.com/repos/willdeuschle/remix-ide/languages","stargazers_url":"https://api.github.com/repos/willdeuschle/remix-ide/stargazers","contributors_url":"https://api.github.com/repos/willdeuschle/remix-ide/contributors","subscribers_url":"https://api.github.com/repos/willdeuschle/remix-ide/subscribers","subscription_url":"https://api.github.com/repos/willdeuschle/remix-ide/subscription","commits_url":"https://api.github.com/repos/willdeuschle/remix-ide/commits{/sha}","git_commits_url":"https://api.github.com/repos/willdeuschle/remix-ide/git/commits{/sha}","comments_url":"https://api.github.com/repos/willdeuschle/remix-ide/comments{/number}","issue_comment_url":"https://api.github.com/repos/willdeuschle/remix-ide/issues/comments{/number}","contents_url":"https://api.github.com/repos/willdeuschle/remix-ide/contents/{+path}","compare_url":"https://api.github.com/repos/willdeuschle/remix-ide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willdeuschle/remix-ide/merges","archive_url":"https://api.github.com/repos/willdeuschle/remix-ide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willdeuschle/remix-ide/downloads","issues_url":"https://api.github.com/repos/willdeuschle/remix-ide/issues{/number}","pulls_url":"https://api.github.com/repos/willdeuschle/remix-ide/pulls{/number}","milestones_url":"https://api.github.com/repos/willdeuschle/remix-ide/milestones{/number}","notifications_url":"https://api.github.com/repos/willdeuschle/remix-ide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willdeuschle/remix-ide/labels{/name}","releases_url":"https://api.github.com/repos/willdeuschle/remix-ide/releases{/id}","deployments_url":"https://api.github.com/repos/willdeuschle/remix-ide/deployments","created_at":"2018-07-01T00:51:34Z","updated_at":"2018-07-01T00:51:37Z","pushed_at":"2018-07-01T01:10:10Z","git_url":"git://github.com/willdeuschle/remix-ide.git","ssh_url":"git@github.com:willdeuschle/remix-ide.git","clone_url":"https://github.com/willdeuschle/remix-ide.git","svn_url":"https://github.com/willdeuschle/remix-ide","homepage":null,"size":19233,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"d04e8991cf1e0b202602eaef1674673a2e81f0b1","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":59065830,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA2NTgzMA==","name":"remix-ide","full_name":"ethereum/remix-ide","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/remix-ide","description":"Browser-Only Solidity IDE and Runtime Environment","fork":false,"url":"https://api.github.com/repos/ethereum/remix-ide","forks_url":"https://api.github.com/repos/ethereum/remix-ide/forks","keys_url":"https://api.github.com/repos/ethereum/remix-ide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/remix-ide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/remix-ide/teams","hooks_url":"https://api.github.com/repos/ethereum/remix-ide/hooks","issue_events_url":"https://api.github.com/repos/ethereum/remix-ide/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/remix-ide/events","assignees_url":"https://api.github.com/repos/ethereum/remix-ide/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/remix-ide/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/remix-ide/tags","blobs_url":"https://api.github.com/repos/ethereum/remix-ide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/remix-ide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/remix-ide/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/remix-ide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/remix-ide/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/remix-ide/languages","stargazers_url":"https://api.github.com/repos/ethereum/remix-ide/stargazers","contributors_url":"https://api.github.com/repos/ethereum/remix-ide/contributors","subscribers_url":"https://api.github.com/repos/ethereum/remix-ide/subscribers","subscription_url":"https://api.github.com/repos/ethereum/remix-ide/subscription","commits_url":"https://api.github.com/repos/ethereum/remix-ide/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/remix-ide/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/remix-ide/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/remix-ide/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/remix-ide/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/remix-ide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/remix-ide/merges","archive_url":"https://api.github.com/repos/ethereum/remix-ide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/remix-ide/downloads","issues_url":"https://api.github.com/repos/ethereum/remix-ide/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/remix-ide/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/remix-ide/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/remix-ide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/remix-ide/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/remix-ide/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/remix-ide/deployments","created_at":"2016-05-17T23:17:34Z","updated_at":"2018-07-02T09:02:01Z","pushed_at":"2018-07-02T15:16:16Z","git_url":"git://github.com/ethereum/remix-ide.git","ssh_url":"git@github.com:ethereum/remix-ide.git","clone_url":"https://github.com/ethereum/remix-ide.git","svn_url":"https://github.com/ethereum/remix-ide","homepage":null,"size":19242,"stargazers_count":912,"watchers_count":912,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":183,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":397,"open_issues":183,"watchers":912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381"},"html":{"href":"https://github.com/ethereum/remix-ide/pull/1381"},"issue":{"href":"https://api.github.com/repos/ethereum/remix-ide/issues/1381"},"comments":{"href":"https://api.github.com/repos/ethereum/remix-ide/issues/1381/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/remix-ide/pulls/1381/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/remix-ide/statuses/63ccadd68811b69361b9f90d662d06a2cc566a82"}},"author_association":"NONE"}}
{"actor":{"display_login":"yann300"}}