{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/skyscrapers/charts/pulls/50","id":231516597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTE2NTk3","html_url":"https://github.com/skyscrapers/charts/pull/50","diff_url":"https://github.com/skyscrapers/charts/pull/50.diff","patch_url":"https://github.com/skyscrapers/charts/pull/50.patch","issue_url":"https://api.github.com/repos/skyscrapers/charts/issues/50","number":50,"state":"closed","locked":false,"title":"Move kube-prometheus to prometheus-operator","user":{"login":"duboisph","id":33081,"node_id":"MDQ6VXNlcjMzMDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33081?v=4","gravatar_id":"","url":"https://api.github.com/users/duboisph","html_url":"https://github.com/duboisph","followers_url":"https://api.github.com/users/duboisph/followers","following_url":"https://api.github.com/users/duboisph/following{/other_user}","gists_url":"https://api.github.com/users/duboisph/gists{/gist_id}","starred_url":"https://api.github.com/users/duboisph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duboisph/subscriptions","organizations_url":"https://api.github.com/users/duboisph/orgs","repos_url":"https://api.github.com/users/duboisph/repos","events_url":"https://api.github.com/users/duboisph/events{/privacy}","received_events_url":"https://api.github.com/users/duboisph/received_events","type":"User","site_admin":false},"body":"Related issue: https://github.com/skyscrapers/engineering/issues/143 \r\nRelated PR: https://github.com/skyscrapers/kubernetes-stack/pull/6\r\n\r\nMove our monitoring stack from coreos/kube-prometheus to the upstream stable/prometheus-operator chart.\r\n\r\n- Use the newest versions of prometheus-operator, prometheus, grafana etc.\r\n- Updated dashboards\r\n- Move our dashboards from https://github.com/skyscrapers/kubernetes-stack/pull/6 to the cluster-monitoring chart. Dashboards can now simple be added as json in the `dashboards-default` or `dashboards-extra` folder and ConfigMaps will be generated from them\r\n- Fixed / improved our dashboards a bit, added tags, ...\r\n\r\nDeployed and tested on SkyscrapersStaging. You can view the dashboards on https://grafana.staging.skyscrape.rs\r\n\r\n**Note**: The CoreDNS and Etcd dashboards are empty. This is expected since we don't use CoreDNS yet and are on ETCDv2 which doesn't export the metrics used in the dashboard\r\n\r\n**Note**: This is a breaking change and an upgrade from previous versions is not possible. You need to remove everything before deploying the new version:\r\n\r\n```\r\nhelm delete --purge prometheus-operator\r\nhelm delete --purge k8s-monitor\r\n\r\nkubectl delete deployment -n infrastructure k8s-monitor-exporter-kube-state\r\nkubectl delete daemonset -n infrastructure k8s-monitor-exporter-node\r\nkubectl delete svc -n infrastructure k8s-monitor-alertmanager\r\nkubectl delete svc -n infrastructure k8s-monitor-exporter-kube-state\r\nkubectl delete svc -n infrastructure k8s-monitor-exporter-node\r\nkubectl delete svc -n infrastructure k8s-monitor-prometheus\r\nkubectl delete svc -n infrastructure prometheus-operated\r\nkubectl delete svc -n infrastructure alertmanager-operated\r\nkubectl delete svc -n kube-system k8s-monitor-exporter-kube-controller-manager\r\nkubectl delete svc -n kube-system k8s-monitor-exporter-kube-dns\r\nkubectl delete svc -n kube-system k8s-monitor-exporter-kube-etcd\r\nkubectl delete svc -n kube-system k8s-monitor-exporter-kube-scheduler\r\n\r\nkubectl delete crd prometheuses.monitoring.coreos.com\r\nkubectl delete crd prometheusrules.monitoring.coreos.com\r\nkubectl delete crd servicemonitors.monitoring.coreos.com\r\nkubectl delete crd alertmanagers.monitoring.coreos.com\r\n\r\nhelm upgrade --install k8s-monitor ~/skyscrapers/charts/cluster-monitoring/ --namespace infrastructure --values helm-values.yaml\r\n```","created_at":"2018-11-16T12:35:45Z","updated_at":"2018-11-16T16:07:55Z","closed_at":"2018-11-16T16:07:55Z","merged_at":"2018-11-16T16:07:55Z","merge_commit_sha":"d66a7d2f2ab2105277aebd8d71ffe5a6f867b644","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skyscrapers/charts/pulls/50/commits","review_comments_url":"https://api.github.com/repos/skyscrapers/charts/pulls/50/comments","review_comment_url":"https://api.github.com/repos/skyscrapers/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skyscrapers/charts/issues/50/comments","statuses_url":"https://api.github.com/repos/skyscrapers/charts/statuses/a828d677733cb30de7260b189b8e3e73531e9c23","head":{"label":"skyscrapers:monitoring","ref":"monitoring","sha":"a828d677733cb30de7260b189b8e3e73531e9c23","user":{"login":"skyscrapers","id":8297228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyOTcyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8297228?v=4","gravatar_id":"","url":"https://api.github.com/users/skyscrapers","html_url":"https://github.com/skyscrapers","followers_url":"https://api.github.com/users/skyscrapers/followers","following_url":"https://api.github.com/users/skyscrapers/following{/other_user}","gists_url":"https://api.github.com/users/skyscrapers/gists{/gist_id}","starred_url":"https://api.github.com/users/skyscrapers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyscrapers/subscriptions","organizations_url":"https://api.github.com/users/skyscrapers/orgs","repos_url":"https://api.github.com/users/skyscrapers/repos","events_url":"https://api.github.com/users/skyscrapers/events{/privacy}","received_events_url":"https://api.github.com/users/skyscrapers/received_events","type":"Organization","site_admin":false},"repo":{"id":92736368,"node_id":"MDEwOlJlcG9zaXRvcnk5MjczNjM2OA==","name":"charts","full_name":"skyscrapers/charts","private":false,"owner":{"login":"skyscrapers","id":8297228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyOTcyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8297228?v=4","gravatar_id":"","url":"https://api.github.com/users/skyscrapers","html_url":"https://github.com/skyscrapers","followers_url":"https://api.github.com/users/skyscrapers/followers","following_url":"https://api.github.com/users/skyscrapers/following{/other_user}","gists_url":"https://api.github.com/users/skyscrapers/gists{/gist_id}","starred_url":"https://api.github.com/users/skyscrapers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyscrapers/subscriptions","organizations_url":"https://api.github.com/users/skyscrapers/orgs","repos_url":"https://api.github.com/users/skyscrapers/repos","events_url":"https://api.github.com/users/skyscrapers/events{/privacy}","received_events_url":"https://api.github.com/users/skyscrapers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/skyscrapers/charts","description":"Our Kubernetes applications","fork":false,"url":"https://api.github.com/repos/skyscrapers/charts","forks_url":"https://api.github.com/repos/skyscrapers/charts/forks","keys_url":"https://api.github.com/repos/skyscrapers/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyscrapers/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyscrapers/charts/teams","hooks_url":"https://api.github.com/repos/skyscrapers/charts/hooks","issue_events_url":"https://api.github.com/repos/skyscrapers/charts/issues/events{/number}","events_url":"https://api.github.com/repos/skyscrapers/charts/events","assignees_url":"https://api.github.com/repos/skyscrapers/charts/assignees{/user}","branches_url":"https://api.github.com/repos/skyscrapers/charts/branches{/branch}","tags_url":"https://api.github.com/repos/skyscrapers/charts/tags","blobs_url":"https://api.github.com/repos/skyscrapers/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyscrapers/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyscrapers/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyscrapers/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyscrapers/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/skyscrapers/charts/languages","stargazers_url":"https://api.github.com/repos/skyscrapers/charts/stargazers","contributors_url":"https://api.github.com/repos/skyscrapers/charts/contributors","subscribers_url":"https://api.github.com/repos/skyscrapers/charts/subscribers","subscription_url":"https://api.github.com/repos/skyscrapers/charts/subscription","commits_url":"https://api.github.com/repos/skyscrapers/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyscrapers/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyscrapers/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyscrapers/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyscrapers/charts/contents/{+path}","compare_url":"https://api.github.com/repos/skyscrapers/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyscrapers/charts/merges","archive_url":"https://api.github.com/repos/skyscrapers/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyscrapers/charts/downloads","issues_url":"https://api.github.com/repos/skyscrapers/charts/issues{/number}","pulls_url":"https://api.github.com/repos/skyscrapers/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/skyscrapers/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/skyscrapers/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyscrapers/charts/labels{/name}","releases_url":"https://api.github.com/repos/skyscrapers/charts/releases{/id}","deployments_url":"https://api.github.com/repos/skyscrapers/charts/deployments","created_at":"2017-05-29T12:07:03Z","updated_at":"2018-11-14T08:16:56Z","pushed_at":"2018-11-16T16:07:55Z","git_url":"git://github.com/skyscrapers/charts.git","ssh_url":"git@github.com:skyscrapers/charts.git","clone_url":"https://github.com/skyscrapers/charts.git","svn_url":"https://github.com/skyscrapers/charts","homepage":null,"size":3873,"stargazers_count":3,"watchers_count":3,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"skyscrapers:master","ref":"master","sha":"84e02f5bc34df5bb34b60da8be6784544f131c35","user":{"login":"skyscrapers","id":8297228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyOTcyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8297228?v=4","gravatar_id":"","url":"https://api.github.com/users/skyscrapers","html_url":"https://github.com/skyscrapers","followers_url":"https://api.github.com/users/skyscrapers/followers","following_url":"https://api.github.com/users/skyscrapers/following{/other_user}","gists_url":"https://api.github.com/users/skyscrapers/gists{/gist_id}","starred_url":"https://api.github.com/users/skyscrapers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyscrapers/subscriptions","organizations_url":"https://api.github.com/users/skyscrapers/orgs","repos_url":"https://api.github.com/users/skyscrapers/repos","events_url":"https://api.github.com/users/skyscrapers/events{/privacy}","received_events_url":"https://api.github.com/users/skyscrapers/received_events","type":"Organization","site_admin":false},"repo":{"id":92736368,"node_id":"MDEwOlJlcG9zaXRvcnk5MjczNjM2OA==","name":"charts","full_name":"skyscrapers/charts","private":false,"owner":{"login":"skyscrapers","id":8297228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyOTcyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8297228?v=4","gravatar_id":"","url":"https://api.github.com/users/skyscrapers","html_url":"https://github.com/skyscrapers","followers_url":"https://api.github.com/users/skyscrapers/followers","following_url":"https://api.github.com/users/skyscrapers/following{/other_user}","gists_url":"https://api.github.com/users/skyscrapers/gists{/gist_id}","starred_url":"https://api.github.com/users/skyscrapers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyscrapers/subscriptions","organizations_url":"https://api.github.com/users/skyscrapers/orgs","repos_url":"https://api.github.com/users/skyscrapers/repos","events_url":"https://api.github.com/users/skyscrapers/events{/privacy}","received_events_url":"https://api.github.com/users/skyscrapers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/skyscrapers/charts","description":"Our Kubernetes applications","fork":false,"url":"https://api.github.com/repos/skyscrapers/charts","forks_url":"https://api.github.com/repos/skyscrapers/charts/forks","keys_url":"https://api.github.com/repos/skyscrapers/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyscrapers/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyscrapers/charts/teams","hooks_url":"https://api.github.com/repos/skyscrapers/charts/hooks","issue_events_url":"https://api.github.com/repos/skyscrapers/charts/issues/events{/number}","events_url":"https://api.github.com/repos/skyscrapers/charts/events","assignees_url":"https://api.github.com/repos/skyscrapers/charts/assignees{/user}","branches_url":"https://api.github.com/repos/skyscrapers/charts/branches{/branch}","tags_url":"https://api.github.com/repos/skyscrapers/charts/tags","blobs_url":"https://api.github.com/repos/skyscrapers/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyscrapers/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyscrapers/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyscrapers/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyscrapers/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/skyscrapers/charts/languages","stargazers_url":"https://api.github.com/repos/skyscrapers/charts/stargazers","contributors_url":"https://api.github.com/repos/skyscrapers/charts/contributors","subscribers_url":"https://api.github.com/repos/skyscrapers/charts/subscribers","subscription_url":"https://api.github.com/repos/skyscrapers/charts/subscription","commits_url":"https://api.github.com/repos/skyscrapers/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyscrapers/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyscrapers/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyscrapers/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyscrapers/charts/contents/{+path}","compare_url":"https://api.github.com/repos/skyscrapers/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyscrapers/charts/merges","archive_url":"https://api.github.com/repos/skyscrapers/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyscrapers/charts/downloads","issues_url":"https://api.github.com/repos/skyscrapers/charts/issues{/number}","pulls_url":"https://api.github.com/repos/skyscrapers/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/skyscrapers/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/skyscrapers/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyscrapers/charts/labels{/name}","releases_url":"https://api.github.com/repos/skyscrapers/charts/releases{/id}","deployments_url":"https://api.github.com/repos/skyscrapers/charts/deployments","created_at":"2017-05-29T12:07:03Z","updated_at":"2018-11-14T08:16:56Z","pushed_at":"2018-11-16T16:07:55Z","git_url":"git://github.com/skyscrapers/charts.git","ssh_url":"git@github.com:skyscrapers/charts.git","clone_url":"https://github.com/skyscrapers/charts.git","svn_url":"https://github.com/skyscrapers/charts","homepage":null,"size":3873,"stargazers_count":3,"watchers_count":3,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skyscrapers/charts/pulls/50"},"html":{"href":"https://github.com/skyscrapers/charts/pull/50"},"issue":{"href":"https://api.github.com/repos/skyscrapers/charts/issues/50"},"comments":{"href":"https://api.github.com/repos/skyscrapers/charts/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/skyscrapers/charts/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/skyscrapers/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skyscrapers/charts/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/skyscrapers/charts/statuses/a828d677733cb30de7260b189b8e3e73531e9c23"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"duboisph","id":33081,"node_id":"MDQ6VXNlcjMzMDgx","avatar_url":"https://avatars1.githubusercontent.com/u/33081?v=4","gravatar_id":"","url":"https://api.github.com/users/duboisph","html_url":"https://github.com/duboisph","followers_url":"https://api.github.com/users/duboisph/followers","following_url":"https://api.github.com/users/duboisph/following{/other_user}","gists_url":"https://api.github.com/users/duboisph/gists{/gist_id}","starred_url":"https://api.github.com/users/duboisph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duboisph/subscriptions","organizations_url":"https://api.github.com/users/duboisph/orgs","repos_url":"https://api.github.com/users/duboisph/repos","events_url":"https://api.github.com/users/duboisph/events{/privacy}","received_events_url":"https://api.github.com/users/duboisph/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":12,"additions":10545,"deletions":205,"changed_files":37}}
{"actor":{"display_login":"duboisph"}}