{"action":"created","issue":{"url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4","repository_url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill","labels_url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4/comments","events_url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4/events","html_url":"https://github.com/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4","id":314982331,"number":4,"title":"What is \"current\"","user":{"login":"ermteri","id":30531475,"avatar_url":"https://avatars0.githubusercontent.com/u/30531475?v=4","gravatar_id":"","url":"https://api.github.com/users/ermteri","html_url":"https://github.com/ermteri","followers_url":"https://api.github.com/users/ermteri/followers","following_url":"https://api.github.com/users/ermteri/following{/other_user}","gists_url":"https://api.github.com/users/ermteri/gists{/gist_id}","starred_url":"https://api.github.com/users/ermteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermteri/subscriptions","organizations_url":"https://api.github.com/users/ermteri/orgs","repos_url":"https://api.github.com/users/ermteri/repos","events_url":"https://api.github.com/users/ermteri/events{/privacy}","received_events_url":"https://api.github.com/users/ermteri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-17T09:41:13Z","updated_at":"2018-04-18T07:02:50Z","closed_at":null,"author_association":"NONE","body":"Hi, \r\nI add this as a bug but it is just a question:\r\nMaybe i misunderstand the objective of your task but i can't figure out why this code is used (in the beginning after int main() ):\r\n\r\n> int current = absu(rand() + rand() - rand()) % (nrEvent - add_counter); //random N\r\n\tcurrent = absu(current);\r\n\twhile (current == 0) {\r\n\t\tcurrent = (rand() + rand() - rand()) % (nrEvent - add_counter);\r\n\t}\r\n\r\nThen current is used as number of nodes added in the skew heap. Printing this value is using 2 as nrEvent current seem to be between ~2000 - ~4000. So how can you measure time for so different number of elements in the list? What is the explanation of the parameter nrEvent? What event is referred to?\r\nCheers,\r\nTorsten"},"comment":{"url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/comments/382284398","html_url":"https://github.com/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4#issuecomment-382284398","issue_url":"https://api.github.com/repos/GiantPanda0090/Pioritory_Queue_ENGskill/issues/4","id":382284398,"user":{"login":"ermteri","id":30531475,"avatar_url":"https://avatars0.githubusercontent.com/u/30531475?v=4","gravatar_id":"","url":"https://api.github.com/users/ermteri","html_url":"https://github.com/ermteri","followers_url":"https://api.github.com/users/ermteri/followers","following_url":"https://api.github.com/users/ermteri/following{/other_user}","gists_url":"https://api.github.com/users/ermteri/gists{/gist_id}","starred_url":"https://api.github.com/users/ermteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ermteri/subscriptions","organizations_url":"https://api.github.com/users/ermteri/orgs","repos_url":"https://api.github.com/users/ermteri/repos","events_url":"https://api.github.com/users/ermteri/events{/privacy}","received_events_url":"https://api.github.com/users/ermteri/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T07:02:50Z","updated_at":"2018-04-18T07:02:50Z","author_association":"NONE","body":"#### First\r\nOk. So why don't you just use?\r\n\r\n> current = rand() % nrEvent;\r\n\r\nIt also seems your code can generate negative numbers?\r\n\r\n#### Second\r\nThe nrEvent parameter is passed as first argument in both run_heap.sh and heap.o (same for the list variants). So it seems you use this value for two purposes:\r\n- As a counter that increases for each invocation of heap.o\r\n- As a random initializer  of the queue. This means that if you run the run_heap.sh with parameter nrEvent set to 10, in heap.o you will use 1-2, 1-3,1-4, ... ,1-10 random intervals to initialize the queue. Maybe one parameter is missing and the intention is to generate random interval, say 2, around a certain value, the counter? Then the invocation would be 1-2, 2-3, 3-4, 4-5, ... ,9-10 ?\r\n"}}
{"actor":{"display_login":"ermteri"}}