{"action":"created","issue":{"url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/19","repository_url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet","labels_url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/19/comments","events_url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/19/events","html_url":"https://github.com/Mr-Markus/ZigbeeNet/issues/19","id":372348953,"node_id":"MDU6SXNzdWUzNzIzNDg5NTM=","number":19,"title":"Fix reader thread code to fit the CC protocol","user":{"login":"eiaro","id":3652665,"node_id":"MDQ6VXNlcjM2NTI2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3652665?v=4","gravatar_id":"","url":"https://api.github.com/users/eiaro","html_url":"https://github.com/eiaro","followers_url":"https://api.github.com/users/eiaro/followers","following_url":"https://api.github.com/users/eiaro/following{/other_user}","gists_url":"https://api.github.com/users/eiaro/gists{/gist_id}","starred_url":"https://api.github.com/users/eiaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiaro/subscriptions","organizations_url":"https://api.github.com/users/eiaro/orgs","repos_url":"https://api.github.com/users/eiaro/repos","events_url":"https://api.github.com/users/eiaro/events{/privacy}","received_events_url":"https://api.github.com/users/eiaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-10-21T19:36:05Z","updated_at":"2018-10-22T17:32:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This code need to be fixed so the CC protocol is implemented correct. My assumptions when writing it was more than slightly off, but should be a good basis.\r\n\r\n- Reading and parsing\r\nhttps://github.com/Mr-Markus/ZigbeeNet/blob/0d06cf9d5b402de25a95c8ea38ce89e1ff84090e/ZigbeeNet/CC/CCZnp.cs#L386-L412\r\n\r\n- Sending and waiting for response\r\nhttps://github.com/Mr-Markus/ZigbeeNet/blob/0d06cf9d5b402de25a95c8ea38ce89e1ff84090e/ZigbeeNet/CC/CCZnp.cs#L509-L514\r\n\r\n- Code does now allow the Cmd1\r\nhttps://github.com/Mr-Markus/ZigbeeNet/blob/0d06cf9d5b402de25a95c8ea38ce89e1ff84090e/ZigbeeNet/CC/CCZnp.cs#L494-L507"},"comment":{"url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/comments/431908001","html_url":"https://github.com/Mr-Markus/ZigbeeNet/issues/19#issuecomment-431908001","issue_url":"https://api.github.com/repos/Mr-Markus/ZigbeeNet/issues/19","id":431908001,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTkwODAwMQ==","user":{"login":"eiaro","id":3652665,"node_id":"MDQ6VXNlcjM2NTI2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3652665?v=4","gravatar_id":"","url":"https://api.github.com/users/eiaro","html_url":"https://github.com/eiaro","followers_url":"https://api.github.com/users/eiaro/followers","following_url":"https://api.github.com/users/eiaro/following{/other_user}","gists_url":"https://api.github.com/users/eiaro/gists{/gist_id}","starred_url":"https://api.github.com/users/eiaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiaro/subscriptions","organizations_url":"https://api.github.com/users/eiaro/orgs","repos_url":"https://api.github.com/users/eiaro/repos","events_url":"https://api.github.com/users/eiaro/events{/privacy}","received_events_url":"https://api.github.com/users/eiaro/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T17:32:33Z","updated_at":"2018-10-22T17:32:33Z","author_association":"CONTRIBUTOR","body":"Yes, but not the kind of callback you would wait for. Say you send a discovery to see what nodes is on, when would you return to the user? On the first node reply, or until you time out waiting for a unknown number of callbacks? "}}
{"actor":{"display_login":"eiaro"}}