{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/dipy/pulls/comments/201432210","pull_request_review_id":135933784,"id":201432210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQzMjIxMA==","diff_hunk":"@@ -4,17 +4,26 @@\n from dipy.io.image import load_nifti, save_nifti\n from dipy.workflows.workflow import Workflow\n \n+import numpy as np\n+import nibabel as nib\n+from dipy.align.imaffine import (transform_centers_of_mass, AffineMap,\n+                                 MutualInformationMetric, AffineRegistration)\n+from dipy.align.transforms import (TranslationTransform3D, RigidTransform3D,\n+                                   AffineTransform3D)\n+from dipy.io.image import save_nifti, save_affine_matrix, \\\n+    save_quality_assur_metric","path":"dipy/workflows/align.py","position":11,"original_position":11,"commit_id":"3db7affad03a7484e0ada1327d463104371ddbed","original_commit_id":"3db7affad03a7484e0ada1327d463104371ddbed","user":{"login":"parichit","id":12007458,"node_id":"MDQ6VXNlcjEyMDA3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/12007458?v=4","gravatar_id":"","url":"https://api.github.com/users/parichit","html_url":"https://github.com/parichit","followers_url":"https://api.github.com/users/parichit/followers","following_url":"https://api.github.com/users/parichit/following{/other_user}","gists_url":"https://api.github.com/users/parichit/gists{/gist_id}","starred_url":"https://api.github.com/users/parichit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parichit/subscriptions","organizations_url":"https://api.github.com/users/parichit/orgs","repos_url":"https://api.github.com/users/parichit/repos","events_url":"https://api.github.com/users/parichit/events{/privacy}","received_events_url":"https://api.github.com/users/parichit/received_events","type":"User","site_admin":false},"body":"Done, Thanks. Actually, part of this file was contributed was someone else earlier and so I did not fiddle with the parts that were already there but you have a valid point, I also support code consistency and standard. It's better to just stick to a single standard rather than using different ones. Good catch, I did not even notice it until you pointed this out. ","created_at":"2018-07-10T17:37:42Z","updated_at":"2018-07-10T17:37:42Z","html_url":"https://github.com/nipy/dipy/pull/1581#discussion_r201432210","pull_request_url":"https://api.github.com/repos/nipy/dipy/pulls/1581","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments/201432210"},"html":{"href":"https://github.com/nipy/dipy/pull/1581#discussion_r201432210"},"pull_request":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1581"}},"in_reply_to_id":201361755},"pull_request":{"url":"https://api.github.com/repos/nipy/dipy/pulls/1581","id":198539853,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTM5ODUz","html_url":"https://github.com/nipy/dipy/pull/1581","diff_url":"https://github.com/nipy/dipy/pull/1581.diff","patch_url":"https://github.com/nipy/dipy/pull/1581.patch","issue_url":"https://api.github.com/repos/nipy/dipy/issues/1581","number":1581,"state":"open","locked":false,"title":"Image registration Workflow with quality metrices","user":{"login":"parichit","id":12007458,"node_id":"MDQ6VXNlcjEyMDA3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/12007458?v=4","gravatar_id":"","url":"https://api.github.com/users/parichit","html_url":"https://github.com/parichit","followers_url":"https://api.github.com/users/parichit/followers","following_url":"https://api.github.com/users/parichit/following{/other_user}","gists_url":"https://api.github.com/users/parichit/gists{/gist_id}","starred_url":"https://api.github.com/users/parichit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parichit/subscriptions","organizations_url":"https://api.github.com/users/parichit/orgs","repos_url":"https://api.github.com/users/parichit/repos","events_url":"https://api.github.com/users/parichit/events{/privacy}","received_events_url":"https://api.github.com/users/parichit/received_events","type":"User","site_admin":false},"body":"1) Opening the PR for the image registration workflow.\r\n2) The tests have been written for both correct and incorrect input.\r\n3) The older branches have been removed and the code is included in the align.py and test_align.py files for code consistency.\r\n4) Also, added the reporting of quality metrics such as the distance between the registered images and the metric of optimal parameters (to assist in quantitative quality assessment).","created_at":"2018-07-01T19:55:50Z","updated_at":"2018-07-10T17:37:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9787855efcc138089dca50f3df344fbfc815096d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":901696012,"node_id":"MDU6TGFiZWw5MDE2OTYwMTI=","url":"https://api.github.com/repos/nipy/dipy/labels/gsoc2018","name":"gsoc2018","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/dipy/pulls/1581/commits","review_comments_url":"https://api.github.com/repos/nipy/dipy/pulls/1581/comments","review_comment_url":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/dipy/issues/1581/comments","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/3db7affad03a7484e0ada1327d463104371ddbed","head":{"label":"parichit:affine_registration","ref":"affine_registration","sha":"3db7affad03a7484e0ada1327d463104371ddbed","user":{"login":"parichit","id":12007458,"node_id":"MDQ6VXNlcjEyMDA3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/12007458?v=4","gravatar_id":"","url":"https://api.github.com/users/parichit","html_url":"https://github.com/parichit","followers_url":"https://api.github.com/users/parichit/followers","following_url":"https://api.github.com/users/parichit/following{/other_user}","gists_url":"https://api.github.com/users/parichit/gists{/gist_id}","starred_url":"https://api.github.com/users/parichit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parichit/subscriptions","organizations_url":"https://api.github.com/users/parichit/orgs","repos_url":"https://api.github.com/users/parichit/repos","events_url":"https://api.github.com/users/parichit/events{/privacy}","received_events_url":"https://api.github.com/users/parichit/received_events","type":"User","site_admin":false},"repo":{"id":132988743,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5ODg3NDM=","name":"dipy","full_name":"parichit/dipy","owner":{"login":"parichit","id":12007458,"node_id":"MDQ6VXNlcjEyMDA3NDU4","avatar_url":"https://avatars2.githubusercontent.com/u/12007458?v=4","gravatar_id":"","url":"https://api.github.com/users/parichit","html_url":"https://github.com/parichit","followers_url":"https://api.github.com/users/parichit/followers","following_url":"https://api.github.com/users/parichit/following{/other_user}","gists_url":"https://api.github.com/users/parichit/gists{/gist_id}","starred_url":"https://api.github.com/users/parichit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parichit/subscriptions","organizations_url":"https://api.github.com/users/parichit/orgs","repos_url":"https://api.github.com/users/parichit/repos","events_url":"https://api.github.com/users/parichit/events{/privacy}","received_events_url":"https://api.github.com/users/parichit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parichit/dipy","description":"Diffusion MR Imaging in Python","fork":true,"url":"https://api.github.com/repos/parichit/dipy","forks_url":"https://api.github.com/repos/parichit/dipy/forks","keys_url":"https://api.github.com/repos/parichit/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parichit/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parichit/dipy/teams","hooks_url":"https://api.github.com/repos/parichit/dipy/hooks","issue_events_url":"https://api.github.com/repos/parichit/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/parichit/dipy/events","assignees_url":"https://api.github.com/repos/parichit/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/parichit/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/parichit/dipy/tags","blobs_url":"https://api.github.com/repos/parichit/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parichit/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parichit/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/parichit/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parichit/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/parichit/dipy/languages","stargazers_url":"https://api.github.com/repos/parichit/dipy/stargazers","contributors_url":"https://api.github.com/repos/parichit/dipy/contributors","subscribers_url":"https://api.github.com/repos/parichit/dipy/subscribers","subscription_url":"https://api.github.com/repos/parichit/dipy/subscription","commits_url":"https://api.github.com/repos/parichit/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/parichit/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/parichit/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/parichit/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/parichit/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/parichit/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parichit/dipy/merges","archive_url":"https://api.github.com/repos/parichit/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parichit/dipy/downloads","issues_url":"https://api.github.com/repos/parichit/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/parichit/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/parichit/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/parichit/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parichit/dipy/labels{/name}","releases_url":"https://api.github.com/repos/parichit/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/parichit/dipy/deployments","created_at":"2018-05-11T04:21:42Z","updated_at":"2018-05-11T04:21:45Z","pushed_at":"2018-07-09T20:34:40Z","git_url":"git://github.com/parichit/dipy.git","ssh_url":"git@github.com:parichit/dipy.git","clone_url":"https://github.com/parichit/dipy.git","svn_url":"https://github.com/parichit/dipy","homepage":"http://dipy.org","size":32937,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"7f2966db938fe4f795b64eb1462d0476509dac97","user":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":505209,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUyMDk=","name":"dipy","full_name":"nipy/dipy","owner":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/dipy","description":"Diffusion MR Imaging in Python","fork":false,"url":"https://api.github.com/repos/nipy/dipy","forks_url":"https://api.github.com/repos/nipy/dipy/forks","keys_url":"https://api.github.com/repos/nipy/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/dipy/teams","hooks_url":"https://api.github.com/repos/nipy/dipy/hooks","issue_events_url":"https://api.github.com/repos/nipy/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/dipy/events","assignees_url":"https://api.github.com/repos/nipy/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/dipy/tags","blobs_url":"https://api.github.com/repos/nipy/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/dipy/languages","stargazers_url":"https://api.github.com/repos/nipy/dipy/stargazers","contributors_url":"https://api.github.com/repos/nipy/dipy/contributors","subscribers_url":"https://api.github.com/repos/nipy/dipy/subscribers","subscription_url":"https://api.github.com/repos/nipy/dipy/subscription","commits_url":"https://api.github.com/repos/nipy/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/dipy/merges","archive_url":"https://api.github.com/repos/nipy/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/dipy/downloads","issues_url":"https://api.github.com/repos/nipy/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/dipy/labels{/name}","releases_url":"https://api.github.com/repos/nipy/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/dipy/deployments","created_at":"2010-02-06T11:43:08Z","updated_at":"2018-07-09T16:16:03Z","pushed_at":"2018-07-09T20:34:42Z","git_url":"git://github.com/nipy/dipy.git","ssh_url":"git@github.com:nipy/dipy.git","clone_url":"https://github.com/nipy/dipy.git","svn_url":"https://github.com/nipy/dipy","homepage":"http://dipy.org","size":32893,"stargazers_count":169,"watchers_count":169,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":214,"open_issues":170,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1581"},"html":{"href":"https://github.com/nipy/dipy/pull/1581"},"issue":{"href":"https://api.github.com/repos/nipy/dipy/issues/1581"},"comments":{"href":"https://api.github.com/repos/nipy/dipy/issues/1581/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1581/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1581/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/dipy/statuses/3db7affad03a7484e0ada1327d463104371ddbed"}},"author_association":"NONE"}}
{"actor":{"display_login":"parichit"}}