{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3568","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3568/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3568/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3568/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3568","id":303998356,"number":3568,"title":"Fixed code that displays values saved for NTP Servers for selected zone","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"labels":[{"id":515069740,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/blocker","name":"blocker","color":"000000","default":false},{"id":505074429,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/bug","name":"bug","color":"ee0701","default":true},{"id":736077187,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false},{"id":534302577,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/settings","name":"settings","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-09T22:17:31Z","updated_at":"2018-03-09T22:32:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3568","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3568","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3568.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3568.patch"},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553771\r\n\r\nbefore:\r\n![before](https://user-images.githubusercontent.com/3450808/37232452-0ee4183e-23bd-11e8-8c2b-b64fb5f3cf55.png)\r\n\r\nafter:\r\n![after](https://user-images.githubusercontent.com/3450808/37232448-0ba71ee6-23bd-11e8-9051-13f5c384f0bb.png)\r\n\r\n@bdunne @chrisarcand please review, fixed to display NTP servers values for a Zone, this issue was introduced by changes in following 2 PRs\r\nhttps://github.com/ManageIQ/manageiq-ui-classic/pull/2720\r\nhttps://github.com/ManageIQ/manageiq-ui-classic/pull/2359 (fixes saving of NTP servers from UI)\r\n\r\n@dclarizio please review."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/371964426","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3568#issuecomment-371964426","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3568","id":371964426,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T22:32:49Z","updated_at":"2018-03-09T22:32:49Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/h-kataria/manageiq-ui-classic/commit/d7bdfcbbcf1ef7df330e20b5dd6a170672cdc77d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n3 files checked, 2 offenses detected\n\n**\\*\\***\n- [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Haml - Linter::Haml STDERR:\n```\nwarning: parser/current is loading parser/ruby23, which recognizes\nwarning: 2.3.6-compliant syntax, but you are running 2.3.3.\nwarning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.\n\n```\n\n**app/controllers/ops_controller/settings/common.rb**\n- [ ] :exclamation: - [Line 1197](https://github.com/h-kataria/manageiq-ui-classic/blob/d7bdfcbbcf1ef7df330e20b5dd6a170672cdc77d/app/controllers/ops_controller/settings/common.rb#L1197), Col 22 - [Style/MultilineTernaryOperator](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/MultilineTernaryOperator) - Avoid multi-line ternary operators, use `if` or `unless` instead.\n"}}
{"actor":{"display_login":"miq-bot"}}