{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/193403362","pull_request_review_id":126366802,"id":193403362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQwMzM2Mg==","diff_hunk":"@@ -72,4 +77,38 @@ - (UIInterfaceOrientation)preferredInterfaceOrientationForPresentation {\n   return self.contentViewController.preferredInterfaceOrientationForPresentation;\n }\n \n+#pragma mark - Enabling top layout guide adjustment behavior\n+\n+- (void)updateTopLayoutGuideBehavior {\n+  if (self.topLayoutGuideAdjustmentEnabled) {\n+    if ([self isViewLoaded]) {\n+      self.contentViewController.view.translatesAutoresizingMaskIntoConstraints = YES;","path":"components/AppBar/src/MDCAppBarContainerViewController.m","position":27,"original_position":27,"commit_id":"a6584a9abd5daa008544adf70b1d92b07c88f368","original_commit_id":"a6584a9abd5daa008544adf70b1d92b07c88f368","user":{"login":"jverkoey","id":45670,"node_id":"MDQ6VXNlcjQ1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"We entirely own the content view controller's layout. In general, views should not make assumptions about their own layout within the context of its parent.","created_at":"2018-06-06T13:11:31Z","updated_at":"2018-06-06T13:11:31Z","html_url":"https://github.com/material-components/material-components-ios/pull/4370#discussion_r193403362","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/193403362"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4370#discussion_r193403362"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370"}},"in_reply_to_id":193401136},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370","id":192981691,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTgxNjkx","html_url":"https://github.com/material-components/material-components-ios/pull/4370","diff_url":"https://github.com/material-components/material-components-ios/pull/4370.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/4370.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4370","number":4370,"state":"open","locked":false,"title":"[AppBar] Implement topLayoutGuideAdjustmentEnabled on the app bar container.","user":{"login":"jverkoey","id":45670,"node_id":"MDQ6VXNlcjQ1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"This mimics the behavior of the flexible header container view controller introduced in 80fd217f766e0f5be6a3bc6bef5923f231721f9d. Notably, this allows content view controllers that are wrapped by an App Bar to make proper use of the top layout guide and additional safe area insets APIs.\r\n\r\nBlocked by https://github.com/material-components/material-components-ios/pull/4354\r\n\r\nCloses https://github.com/material-components/material-components-ios/issues/2540\r\n\r\n## Screenshots\r\n\r\nBefore:\r\n\r\n![before](https://user-images.githubusercontent.com/45670/41035558-0456d42c-695b-11e8-8071-62e174d8d90e.png)\r\n\r\nAfter:\r\n\r\n![after](https://user-images.githubusercontent.com/45670/41035560-06708b9a-695b-11e8-9231-f96ea34caea9.png)\r\n","created_at":"2018-06-06T11:25:36Z","updated_at":"2018-06-06T13:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9900c018179095ef0a90b39090f3bdfa1c8e65b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":343102818,"node_id":"MDU6TGFiZWwzNDMxMDI4MTg=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[AppBar]","name":"[AppBar]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4370/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/a6584a9abd5daa008544adf70b1d92b07c88f368","head":{"label":"jverkoey:layoutguides","ref":"layoutguides","sha":"a6584a9abd5daa008544adf70b1d92b07c88f368","user":{"login":"jverkoey","id":45670,"node_id":"MDQ6VXNlcjQ1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"repo":{"id":91832448,"node_id":"MDEwOlJlcG9zaXRvcnk5MTgzMjQ0OA==","name":"material-components-ios","full_name":"jverkoey/material-components-ios","owner":{"login":"jverkoey","id":45670,"node_id":"MDQ6VXNlcjQ1Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jverkoey/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/jverkoey/material-components-ios","forks_url":"https://api.github.com/repos/jverkoey/material-components-ios/forks","keys_url":"https://api.github.com/repos/jverkoey/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jverkoey/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jverkoey/material-components-ios/teams","hooks_url":"https://api.github.com/repos/jverkoey/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/jverkoey/material-components-ios/events","assignees_url":"https://api.github.com/repos/jverkoey/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/jverkoey/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/jverkoey/material-components-ios/tags","blobs_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jverkoey/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/jverkoey/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/jverkoey/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/jverkoey/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/jverkoey/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/jverkoey/material-components-ios/subscription","commits_url":"https://api.github.com/repos/jverkoey/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/jverkoey/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/jverkoey/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/jverkoey/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jverkoey/material-components-ios/merges","archive_url":"https://api.github.com/repos/jverkoey/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jverkoey/material-components-ios/downloads","issues_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/jverkoey/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/jverkoey/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/jverkoey/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jverkoey/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/jverkoey/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/jverkoey/material-components-ios/deployments","created_at":"2017-05-19T18:02:30Z","updated_at":"2018-05-19T14:30:43Z","pushed_at":"2018-06-06T13:10:24Z","git_url":"git://github.com/jverkoey/material-components-ios.git","ssh_url":"git@github.com:jverkoey/material-components-ios.git","clone_url":"https://github.com/jverkoey/material-components-ios.git","svn_url":"https://github.com/jverkoey/material-components-ios","homepage":"","size":113138,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"0b5706dadd4837ddf8d4da45a73ff9a5203c76ee","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-06-06T01:35:33Z","pushed_at":"2018-06-06T11:28:14Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":112945,"stargazers_count":2419,"watchers_count":2419,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":348,"mirror_url":null,"archived":false,"open_issues_count":971,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":348,"open_issues":971,"watchers":2419,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4370"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4370"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4370/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4370/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/a6584a9abd5daa008544adf70b1d92b07c88f368"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jverkoey"}}