{"action":"created","comment":{"url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments/215674982","pull_request_review_id":152993675,"id":215674982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTY3NDk4Mg==","diff_hunk":"@@ -55,7 +55,30 @@\n import static java.util.stream.Stream.concat;\n \n /**\n- * HTTP request with a fully aggregated/decoded body.\n+ * An immutable HTTP request object including full body content.\n+ * <p>\n+ * A {@link FullHttpRequest} is useful for request messages with a","path":"components/api/src/main/java/com/hotels/styx/api/FullHttpRequest.java","position":7,"original_position":7,"commit_id":"1a0f6bc39e84e717212c0321cab0b9a2791ebd23","original_commit_id":"1a0f6bc39e84e717212c0321cab0b9a2791ebd23","user":{"login":"kvosper","id":5182059,"node_id":"MDQ6VXNlcjUxODIwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5182059?v=4","gravatar_id":"","url":"https://api.github.com/users/kvosper","html_url":"https://github.com/kvosper","followers_url":"https://api.github.com/users/kvosper/followers","following_url":"https://api.github.com/users/kvosper/following{/other_user}","gists_url":"https://api.github.com/users/kvosper/gists{/gist_id}","starred_url":"https://api.github.com/users/kvosper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvosper/subscriptions","organizations_url":"https://api.github.com/users/kvosper/orgs","repos_url":"https://api.github.com/users/kvosper/repos","events_url":"https://api.github.com/users/kvosper/events{/privacy}","received_events_url":"https://api.github.com/users/kvosper/received_events","type":"User","site_admin":false},"body":"It might be better to just say \"requests\" instead of \"request messages\", even though they both make sense. I think HTTP requests are typically just referred to that way.\r\n\r\nPerhaps we could go with \"A {@link FullHttpRequest} is useful for representing requests with ...\"","created_at":"2018-09-06T15:38:20Z","updated_at":"2018-09-06T15:45:14Z","html_url":"https://github.com/HotelsDotCom/styx/pull/271#discussion_r215674982","pull_request_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments/215674982"},"html":{"href":"https://github.com/HotelsDotCom/styx/pull/271#discussion_r215674982"},"pull_request":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271","id":213562662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTYyNjYy","html_url":"https://github.com/HotelsDotCom/styx/pull/271","diff_url":"https://github.com/HotelsDotCom/styx/pull/271.diff","patch_url":"https://github.com/HotelsDotCom/styx/pull/271.patch","issue_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/271","number":271,"state":"open","locked":false,"title":"Add Javadoc maven plugin and improve docs for styx-api module","user":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"body":"This PR adds Javadoc maven plugin into master `pom.xml`. The javadocs can be generated locally like this:\r\n\r\n```\r\nmvn javadoc:javadoc\r\n```\r\n\r\nOr specifically for the *styx-api* module:\r\n\r\n```\r\nmvn -f components/api/pom.xml javadoc:javadoc\r\n```\r\n\r\nThis PR also adds package level API docs for `com.hotels.styx.api` and improves existing Javadocs for HTTP message objects.\r\n","created_at":"2018-09-06T10:04:51Z","updated_at":"2018-09-06T15:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"331105e5f59b7aff0cc04389bb6996a5db39ee92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271/commits","review_comments_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271/comments","review_comment_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/271/comments","statuses_url":"https://api.github.com/repos/HotelsDotCom/styx/statuses/1a0f6bc39e84e717212c0321cab0b9a2791ebd23","head":{"label":"mikkokar:api-docs","ref":"api-docs","sha":"1a0f6bc39e84e717212c0321cab0b9a2791ebd23","user":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"repo":{"id":107119976,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTk5NzY=","name":"styx","full_name":"mikkokar/styx","owner":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikkokar/styx","description":"Programmable, asynchronous, event-based reverse proxy for JVM.","fork":true,"url":"https://api.github.com/repos/mikkokar/styx","forks_url":"https://api.github.com/repos/mikkokar/styx/forks","keys_url":"https://api.github.com/repos/mikkokar/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikkokar/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikkokar/styx/teams","hooks_url":"https://api.github.com/repos/mikkokar/styx/hooks","issue_events_url":"https://api.github.com/repos/mikkokar/styx/issues/events{/number}","events_url":"https://api.github.com/repos/mikkokar/styx/events","assignees_url":"https://api.github.com/repos/mikkokar/styx/assignees{/user}","branches_url":"https://api.github.com/repos/mikkokar/styx/branches{/branch}","tags_url":"https://api.github.com/repos/mikkokar/styx/tags","blobs_url":"https://api.github.com/repos/mikkokar/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikkokar/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikkokar/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikkokar/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikkokar/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/mikkokar/styx/languages","stargazers_url":"https://api.github.com/repos/mikkokar/styx/stargazers","contributors_url":"https://api.github.com/repos/mikkokar/styx/contributors","subscribers_url":"https://api.github.com/repos/mikkokar/styx/subscribers","subscription_url":"https://api.github.com/repos/mikkokar/styx/subscription","commits_url":"https://api.github.com/repos/mikkokar/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikkokar/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikkokar/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikkokar/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikkokar/styx/contents/{+path}","compare_url":"https://api.github.com/repos/mikkokar/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikkokar/styx/merges","archive_url":"https://api.github.com/repos/mikkokar/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikkokar/styx/downloads","issues_url":"https://api.github.com/repos/mikkokar/styx/issues{/number}","pulls_url":"https://api.github.com/repos/mikkokar/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/mikkokar/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/mikkokar/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikkokar/styx/labels{/name}","releases_url":"https://api.github.com/repos/mikkokar/styx/releases{/id}","deployments_url":"https://api.github.com/repos/mikkokar/styx/deployments","created_at":"2017-10-16T11:45:05Z","updated_at":"2018-09-06T07:30:28Z","pushed_at":"2018-09-06T15:28:33Z","git_url":"git://github.com/mikkokar/styx.git","ssh_url":"git@github.com:mikkokar/styx.git","clone_url":"https://github.com/mikkokar/styx.git","svn_url":"https://github.com/mikkokar/styx","homepage":"","size":3737,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HotelsDotCom:master","ref":"master","sha":"4e0ff6c8de8aac5b17ebc8ea1824e791fe6fbeed","user":{"login":"HotelsDotCom","id":8900689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDA2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"repo":{"id":106841635,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NDE2MzU=","name":"styx","full_name":"HotelsDotCom/styx","owner":{"login":"HotelsDotCom","id":8900689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDA2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HotelsDotCom/styx","description":"Programmable, asynchronous, event-based reverse proxy for JVM.","fork":false,"url":"https://api.github.com/repos/HotelsDotCom/styx","forks_url":"https://api.github.com/repos/HotelsDotCom/styx/forks","keys_url":"https://api.github.com/repos/HotelsDotCom/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotelsDotCom/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotelsDotCom/styx/teams","hooks_url":"https://api.github.com/repos/HotelsDotCom/styx/hooks","issue_events_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/events{/number}","events_url":"https://api.github.com/repos/HotelsDotCom/styx/events","assignees_url":"https://api.github.com/repos/HotelsDotCom/styx/assignees{/user}","branches_url":"https://api.github.com/repos/HotelsDotCom/styx/branches{/branch}","tags_url":"https://api.github.com/repos/HotelsDotCom/styx/tags","blobs_url":"https://api.github.com/repos/HotelsDotCom/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotelsDotCom/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotelsDotCom/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotelsDotCom/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotelsDotCom/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/HotelsDotCom/styx/languages","stargazers_url":"https://api.github.com/repos/HotelsDotCom/styx/stargazers","contributors_url":"https://api.github.com/repos/HotelsDotCom/styx/contributors","subscribers_url":"https://api.github.com/repos/HotelsDotCom/styx/subscribers","subscription_url":"https://api.github.com/repos/HotelsDotCom/styx/subscription","commits_url":"https://api.github.com/repos/HotelsDotCom/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotelsDotCom/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotelsDotCom/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotelsDotCom/styx/contents/{+path}","compare_url":"https://api.github.com/repos/HotelsDotCom/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotelsDotCom/styx/merges","archive_url":"https://api.github.com/repos/HotelsDotCom/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotelsDotCom/styx/downloads","issues_url":"https://api.github.com/repos/HotelsDotCom/styx/issues{/number}","pulls_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/HotelsDotCom/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/HotelsDotCom/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotelsDotCom/styx/labels{/name}","releases_url":"https://api.github.com/repos/HotelsDotCom/styx/releases{/id}","deployments_url":"https://api.github.com/repos/HotelsDotCom/styx/deployments","created_at":"2017-10-13T15:27:53Z","updated_at":"2018-09-06T07:29:52Z","pushed_at":"2018-09-06T15:30:43Z","git_url":"git://github.com/HotelsDotCom/styx.git","ssh_url":"git@github.com:HotelsDotCom/styx.git","clone_url":"https://github.com/HotelsDotCom/styx.git","svn_url":"https://github.com/HotelsDotCom/styx","homepage":"","size":3165,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":25,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271"},"html":{"href":"https://github.com/HotelsDotCom/styx/pull/271"},"issue":{"href":"https://api.github.com/repos/HotelsDotCom/styx/issues/271"},"comments":{"href":"https://api.github.com/repos/HotelsDotCom/styx/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/HotelsDotCom/styx/statuses/1a0f6bc39e84e717212c0321cab0b9a2791ebd23"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kvosper"}}