{"action":"created","issue":{"url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/428","repository_url":"https://api.github.com/repos/GMLC-TDC/HELICS-src","labels_url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/428/labels{/name}","comments_url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/428/comments","events_url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/428/events","html_url":"https://github.com/GMLC-TDC/HELICS-src/issues/428","id":348757262,"node_id":"MDU6SXNzdWUzNDg3NTcyNjI=","number":428,"title":"Should subscriptions have types?","user":{"login":"phlptp","id":20667153,"node_id":"MDQ6VXNlcjIwNjY3MTUz","avatar_url":"https://avatars0.githubusercontent.com/u/20667153?v=4","gravatar_id":"","url":"https://api.github.com/users/phlptp","html_url":"https://github.com/phlptp","followers_url":"https://api.github.com/users/phlptp/followers","following_url":"https://api.github.com/users/phlptp/following{/other_user}","gists_url":"https://api.github.com/users/phlptp/gists{/gist_id}","starred_url":"https://api.github.com/users/phlptp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phlptp/subscriptions","organizations_url":"https://api.github.com/users/phlptp/orgs","repos_url":"https://api.github.com/users/phlptp/repos","events_url":"https://api.github.com/users/phlptp/events{/privacy}","received_events_url":"https://api.github.com/users/phlptp/received_events","type":"User","site_admin":false},"labels":[{"id":617752790,"node_id":"MDU6TGFiZWw2MTc3NTI3OTA=","url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-08-08T14:42:13Z","updated_at":"2018-12-13T22:20:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now we have type associated with publications,  with the new input interface there will also be a named type associated with it.  \r\nThe question is should subscriptions which are inputs with no names associated with them have a type in the function call.  Types were intended to be a way of specifying what the underlying raw data was.  The Application API specifies a number of well defined types that it knows about but arbitrary ones can be used for passing raw data.   So they are required for publications, and for inputs you want to be able to specify the type you are expecting.  But subscriptions have a different meaning in that a user should either know or not care and check what the data is when subscribing to a publication.  So on the uses that I have observed no one has actually used the type on a subscription for much meaning.  \r\n\r\nSo I am considering removing that field from the application API/ and C API calls for registering subscriptions.  \r\nDoes anyone have any thoughts on this?  \r\n\r\nI may add a checkCompatibleType call for inputs to do a verification that the input types are compatible as well to take care of one use case for types.  "},"comment":{"url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/comments/447141404","html_url":"https://github.com/GMLC-TDC/HELICS-src/issues/428#issuecomment-447141404","issue_url":"https://api.github.com/repos/GMLC-TDC/HELICS-src/issues/428","id":447141404,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzE0MTQwNA==","user":{"login":"Jacobhansens","id":2597888,"node_id":"MDQ6VXNlcjI1OTc4ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/2597888?v=4","gravatar_id":"","url":"https://api.github.com/users/Jacobhansens","html_url":"https://github.com/Jacobhansens","followers_url":"https://api.github.com/users/Jacobhansens/followers","following_url":"https://api.github.com/users/Jacobhansens/following{/other_user}","gists_url":"https://api.github.com/users/Jacobhansens/gists{/gist_id}","starred_url":"https://api.github.com/users/Jacobhansens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jacobhansens/subscriptions","organizations_url":"https://api.github.com/users/Jacobhansens/orgs","repos_url":"https://api.github.com/users/Jacobhansens/repos","events_url":"https://api.github.com/users/Jacobhansens/events{/privacy}","received_events_url":"https://api.github.com/users/Jacobhansens/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T22:20:35Z","updated_at":"2018-12-13T22:20:35Z","author_association":"NONE","body":"I can get behind that plan. If you want I am happy to provide a review of #536. That way I can make sure I capture how you made the change."}}
{"actor":{"display_login":"Jacobhansens"}}