{"action":"created","comment":{"url":"https://api.github.com/repos/kubeless/kubeless/pulls/comments/167562453","pull_request_review_id":95797592,"id":167562453,"diff_hunk":"@@ -146,6 +146,27 @@ get-ruby-custom-port:\n get-ruby-custom-port-verify:\n \tkubeless function call get-ruby-custom-port |egrep hello.world\n \n+get-php:\n+\tkubeless function deploy get-php --trigger-http --runtime php7.2 --handler helloget.foo --from-file php/helloget.php\n+\techo \"curl localhost:8080/api/v1/proxy/namespaces/default/services/get-php/\"\n+\n+get-php-verify:\n+\tkubeless function call get-php | egrep \"hello world\"\n+\n+get-php-deps:\n+\tkubeless function deploy get-php-deps --trigger-http --runtime php7.2 --handler hellowithdeps.foo --from-file php/hellowithdeps.php --dependencies php/composer.json\n+\techo \"curl localhost:8080/api/v1/proxy/namespaces/default/services/get-php-deps/\"\n+\n+get-php-deps-verify:\n+\tkubectl logs -l function=get-php-deps | egrep \"Hello\"\n+\n+post-php:\n+\tkubeless function deploy post-php --trigger-http --runtime php7.2 --handler hellowithdata.foo --from-file php/hellowithdata.php\n+\techo \"curl --data '{\\\"hello\\\":\\\"world\\\"}' localhost:8080/api/v1/proxy/namespaces/default/services/post-php/ --header \\\"Content-Type:application/json\\\"\"\n+\n+post-php-verify:\n+\tkubeless function call post-php --data '{\"it-s\": \"alive\"}'| egrep \"it.*alive\"\n+","path":"examples/Makefile","position":24,"original_position":24,"commit_id":"7999cdfc5326ce4ea83773ce02a756232bf8e785","original_commit_id":"9b6e36dc69f2e5246e75f4edcc3225b1b23fb987","user":{"login":"paolomainardi","id":8747,"avatar_url":"https://avatars0.githubusercontent.com/u/8747?v=4","gravatar_id":"","url":"https://api.github.com/users/paolomainardi","html_url":"https://github.com/paolomainardi","followers_url":"https://api.github.com/users/paolomainardi/followers","following_url":"https://api.github.com/users/paolomainardi/following{/other_user}","gists_url":"https://api.github.com/users/paolomainardi/gists{/gist_id}","starred_url":"https://api.github.com/users/paolomainardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolomainardi/subscriptions","organizations_url":"https://api.github.com/users/paolomainardi/orgs","repos_url":"https://api.github.com/users/paolomainardi/repos","events_url":"https://api.github.com/users/paolomainardi/events{/privacy}","received_events_url":"https://api.github.com/users/paolomainardi/received_events","type":"User","site_admin":false},"body":"Thanks, added!","created_at":"2018-02-12T14:00:04Z","updated_at":"2018-02-12T14:00:04Z","html_url":"https://github.com/kubeless/kubeless/pull/581#discussion_r167562453","pull_request_url":"https://api.github.com/repos/kubeless/kubeless/pulls/581","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/comments/167562453"},"html":{"href":"https://github.com/kubeless/kubeless/pull/581#discussion_r167562453"},"pull_request":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/581"}},"in_reply_to_id":167489594},"pull_request":{"url":"https://api.github.com/repos/kubeless/kubeless/pulls/581","id":166808670,"html_url":"https://github.com/kubeless/kubeless/pull/581","diff_url":"https://github.com/kubeless/kubeless/pull/581.diff","patch_url":"https://github.com/kubeless/kubeless/pull/581.patch","issue_url":"https://api.github.com/repos/kubeless/kubeless/issues/581","number":581,"state":"open","locked":false,"title":"PHP runtime","user":{"login":"paolomainardi","id":8747,"avatar_url":"https://avatars0.githubusercontent.com/u/8747?v=4","gravatar_id":"","url":"https://api.github.com/users/paolomainardi","html_url":"https://github.com/paolomainardi","followers_url":"https://api.github.com/users/paolomainardi/followers","following_url":"https://api.github.com/users/paolomainardi/following{/other_user}","gists_url":"https://api.github.com/users/paolomainardi/gists{/gist_id}","starred_url":"https://api.github.com/users/paolomainardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolomainardi/subscriptions","organizations_url":"https://api.github.com/users/paolomainardi/orgs","repos_url":"https://api.github.com/users/paolomainardi/repos","events_url":"https://api.github.com/users/paolomainardi/events{/privacy}","received_events_url":"https://api.github.com/users/paolomainardi/received_events","type":"User","site_admin":false},"body":"**Issue Ref**: None\r\n \r\n**Description**: \r\n\r\nPHP runtime implementation, still a working in progress.\r\n\r\n[PR Description]\r\n\r\n**TODOs**:\r\n - [x] Make php controller to handle function timeout (maybe using something like pthreads.org)\r\n - [x] Ready to review\r\n - [x] Automated Tests\r\n - [ ] Docs\r\n","created_at":"2018-02-02T13:57:55Z","updated_at":"2018-02-12T14:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1a1bfa3d85f63daf0f1c9ccf625708f12edf51f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubeless/kubeless/pulls/581/commits","review_comments_url":"https://api.github.com/repos/kubeless/kubeless/pulls/581/comments","review_comment_url":"https://api.github.com/repos/kubeless/kubeless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeless/kubeless/issues/581/comments","statuses_url":"https://api.github.com/repos/kubeless/kubeless/statuses/7999cdfc5326ce4ea83773ce02a756232bf8e785","head":{"label":"paolomainardi:feature/php-runtime","ref":"feature/php-runtime","sha":"7999cdfc5326ce4ea83773ce02a756232bf8e785","user":{"login":"paolomainardi","id":8747,"avatar_url":"https://avatars0.githubusercontent.com/u/8747?v=4","gravatar_id":"","url":"https://api.github.com/users/paolomainardi","html_url":"https://github.com/paolomainardi","followers_url":"https://api.github.com/users/paolomainardi/followers","following_url":"https://api.github.com/users/paolomainardi/following{/other_user}","gists_url":"https://api.github.com/users/paolomainardi/gists{/gist_id}","starred_url":"https://api.github.com/users/paolomainardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolomainardi/subscriptions","organizations_url":"https://api.github.com/users/paolomainardi/orgs","repos_url":"https://api.github.com/users/paolomainardi/repos","events_url":"https://api.github.com/users/paolomainardi/events{/privacy}","received_events_url":"https://api.github.com/users/paolomainardi/received_events","type":"User","site_admin":false},"repo":{"id":118191889,"name":"kubeless","full_name":"paolomainardi/kubeless","owner":{"login":"paolomainardi","id":8747,"avatar_url":"https://avatars0.githubusercontent.com/u/8747?v=4","gravatar_id":"","url":"https://api.github.com/users/paolomainardi","html_url":"https://github.com/paolomainardi","followers_url":"https://api.github.com/users/paolomainardi/followers","following_url":"https://api.github.com/users/paolomainardi/following{/other_user}","gists_url":"https://api.github.com/users/paolomainardi/gists{/gist_id}","starred_url":"https://api.github.com/users/paolomainardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolomainardi/subscriptions","organizations_url":"https://api.github.com/users/paolomainardi/orgs","repos_url":"https://api.github.com/users/paolomainardi/repos","events_url":"https://api.github.com/users/paolomainardi/events{/privacy}","received_events_url":"https://api.github.com/users/paolomainardi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paolomainardi/kubeless","description":"Kubernetes Native Serverless Framework","fork":true,"url":"https://api.github.com/repos/paolomainardi/kubeless","forks_url":"https://api.github.com/repos/paolomainardi/kubeless/forks","keys_url":"https://api.github.com/repos/paolomainardi/kubeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paolomainardi/kubeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paolomainardi/kubeless/teams","hooks_url":"https://api.github.com/repos/paolomainardi/kubeless/hooks","issue_events_url":"https://api.github.com/repos/paolomainardi/kubeless/issues/events{/number}","events_url":"https://api.github.com/repos/paolomainardi/kubeless/events","assignees_url":"https://api.github.com/repos/paolomainardi/kubeless/assignees{/user}","branches_url":"https://api.github.com/repos/paolomainardi/kubeless/branches{/branch}","tags_url":"https://api.github.com/repos/paolomainardi/kubeless/tags","blobs_url":"https://api.github.com/repos/paolomainardi/kubeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paolomainardi/kubeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paolomainardi/kubeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/paolomainardi/kubeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paolomainardi/kubeless/statuses/{sha}","languages_url":"https://api.github.com/repos/paolomainardi/kubeless/languages","stargazers_url":"https://api.github.com/repos/paolomainardi/kubeless/stargazers","contributors_url":"https://api.github.com/repos/paolomainardi/kubeless/contributors","subscribers_url":"https://api.github.com/repos/paolomainardi/kubeless/subscribers","subscription_url":"https://api.github.com/repos/paolomainardi/kubeless/subscription","commits_url":"https://api.github.com/repos/paolomainardi/kubeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/paolomainardi/kubeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/paolomainardi/kubeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/paolomainardi/kubeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/paolomainardi/kubeless/contents/{+path}","compare_url":"https://api.github.com/repos/paolomainardi/kubeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paolomainardi/kubeless/merges","archive_url":"https://api.github.com/repos/paolomainardi/kubeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paolomainardi/kubeless/downloads","issues_url":"https://api.github.com/repos/paolomainardi/kubeless/issues{/number}","pulls_url":"https://api.github.com/repos/paolomainardi/kubeless/pulls{/number}","milestones_url":"https://api.github.com/repos/paolomainardi/kubeless/milestones{/number}","notifications_url":"https://api.github.com/repos/paolomainardi/kubeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paolomainardi/kubeless/labels{/name}","releases_url":"https://api.github.com/repos/paolomainardi/kubeless/releases{/id}","deployments_url":"https://api.github.com/repos/paolomainardi/kubeless/deployments","created_at":"2018-01-20T00:00:12Z","updated_at":"2018-01-20T00:00:15Z","pushed_at":"2018-02-12T13:58:18Z","git_url":"git://github.com/paolomainardi/kubeless.git","ssh_url":"git@github.com:paolomainardi/kubeless.git","clone_url":"https://github.com/paolomainardi/kubeless.git","svn_url":"https://github.com/paolomainardi/kubeless","homepage":"http://kubeless.io","size":49098,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeless:master","ref":"master","sha":"5ffe6699731d486dd8d2c20b4ed169ca9111ef03","user":{"login":"kubeless","id":25339039,"avatar_url":"https://avatars3.githubusercontent.com/u/25339039?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeless","html_url":"https://github.com/kubeless","followers_url":"https://api.github.com/users/kubeless/followers","following_url":"https://api.github.com/users/kubeless/following{/other_user}","gists_url":"https://api.github.com/users/kubeless/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeless/subscriptions","organizations_url":"https://api.github.com/users/kubeless/orgs","repos_url":"https://api.github.com/users/kubeless/repos","events_url":"https://api.github.com/users/kubeless/events{/privacy}","received_events_url":"https://api.github.com/users/kubeless/received_events","type":"Organization","site_admin":false},"repo":{"id":73902337,"name":"kubeless","full_name":"kubeless/kubeless","owner":{"login":"kubeless","id":25339039,"avatar_url":"https://avatars3.githubusercontent.com/u/25339039?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeless","html_url":"https://github.com/kubeless","followers_url":"https://api.github.com/users/kubeless/followers","following_url":"https://api.github.com/users/kubeless/following{/other_user}","gists_url":"https://api.github.com/users/kubeless/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeless/subscriptions","organizations_url":"https://api.github.com/users/kubeless/orgs","repos_url":"https://api.github.com/users/kubeless/repos","events_url":"https://api.github.com/users/kubeless/events{/privacy}","received_events_url":"https://api.github.com/users/kubeless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeless/kubeless","description":"Kubernetes Native Serverless Framework","fork":false,"url":"https://api.github.com/repos/kubeless/kubeless","forks_url":"https://api.github.com/repos/kubeless/kubeless/forks","keys_url":"https://api.github.com/repos/kubeless/kubeless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeless/kubeless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeless/kubeless/teams","hooks_url":"https://api.github.com/repos/kubeless/kubeless/hooks","issue_events_url":"https://api.github.com/repos/kubeless/kubeless/issues/events{/number}","events_url":"https://api.github.com/repos/kubeless/kubeless/events","assignees_url":"https://api.github.com/repos/kubeless/kubeless/assignees{/user}","branches_url":"https://api.github.com/repos/kubeless/kubeless/branches{/branch}","tags_url":"https://api.github.com/repos/kubeless/kubeless/tags","blobs_url":"https://api.github.com/repos/kubeless/kubeless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeless/kubeless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeless/kubeless/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeless/kubeless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeless/kubeless/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeless/kubeless/languages","stargazers_url":"https://api.github.com/repos/kubeless/kubeless/stargazers","contributors_url":"https://api.github.com/repos/kubeless/kubeless/contributors","subscribers_url":"https://api.github.com/repos/kubeless/kubeless/subscribers","subscription_url":"https://api.github.com/repos/kubeless/kubeless/subscription","commits_url":"https://api.github.com/repos/kubeless/kubeless/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeless/kubeless/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeless/kubeless/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeless/kubeless/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeless/kubeless/contents/{+path}","compare_url":"https://api.github.com/repos/kubeless/kubeless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeless/kubeless/merges","archive_url":"https://api.github.com/repos/kubeless/kubeless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeless/kubeless/downloads","issues_url":"https://api.github.com/repos/kubeless/kubeless/issues{/number}","pulls_url":"https://api.github.com/repos/kubeless/kubeless/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeless/kubeless/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeless/kubeless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeless/kubeless/labels{/name}","releases_url":"https://api.github.com/repos/kubeless/kubeless/releases{/id}","deployments_url":"https://api.github.com/repos/kubeless/kubeless/deployments","created_at":"2016-11-16T09:03:03Z","updated_at":"2018-02-12T13:35:13Z","pushed_at":"2018-02-12T13:58:20Z","git_url":"git://github.com/kubeless/kubeless.git","ssh_url":"git@github.com:kubeless/kubeless.git","clone_url":"https://github.com/kubeless/kubeless.git","svn_url":"https://github.com/kubeless/kubeless","homepage":"http://kubeless.io","size":49132,"stargazers_count":1904,"watchers_count":1904,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":167,"open_issues":62,"watchers":1904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/581"},"html":{"href":"https://github.com/kubeless/kubeless/pull/581"},"issue":{"href":"https://api.github.com/repos/kubeless/kubeless/issues/581"},"comments":{"href":"https://api.github.com/repos/kubeless/kubeless/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeless/kubeless/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/kubeless/kubeless/statuses/7999cdfc5326ce4ea83773ce02a756232bf8e785"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paolomainardi"}}