{"action":"created","issue":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/685","repository_url":"https://api.github.com/repos/MaslowCNC/GroundControl","labels_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/685/labels{/name}","comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/685/comments","events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/685/events","html_url":"https://github.com/MaslowCNC/GroundControl/pull/685","id":311813282,"number":685,"title":"Add chain tolerance parameters","user":{"login":"reecej","id":4712504,"avatar_url":"https://avatars1.githubusercontent.com/u/4712504?v=4","gravatar_id":"","url":"https://api.github.com/users/reecej","html_url":"https://github.com/reecej","followers_url":"https://api.github.com/users/reecej/followers","following_url":"https://api.github.com/users/reecej/following{/other_user}","gists_url":"https://api.github.com/users/reecej/gists{/gist_id}","starred_url":"https://api.github.com/users/reecej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reecej/subscriptions","organizations_url":"https://api.github.com/users/reecej/orgs","repos_url":"https://api.github.com/users/reecej/repos","events_url":"https://api.github.com/users/reecej/events{/privacy}","received_events_url":"https://api.github.com/users/reecej/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-06T00:32:48Z","updated_at":"2018-05-02T17:06:06Z","closed_at":"2018-04-06T21:50:37Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/685","html_url":"https://github.com/MaslowCNC/GroundControl/pull/685","diff_url":"https://github.com/MaslowCNC/GroundControl/pull/685.diff","patch_url":"https://github.com/MaslowCNC/GroundControl/pull/685.patch"},"body":"This adds the chain tolerance parameters, calculates the new distPerRotation values, and sends them to the firmware.\r\n\r\nThis is the first GC update for Firmware [422](https://github.com/MaslowCNC/Firmware/pull/422)."},"comment":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/comments/386049887","html_url":"https://github.com/MaslowCNC/GroundControl/pull/685#issuecomment-386049887","issue_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/685","id":386049887,"user":{"login":"reecej","id":4712504,"avatar_url":"https://avatars1.githubusercontent.com/u/4712504?v=4","gravatar_id":"","url":"https://api.github.com/users/reecej","html_url":"https://github.com/reecej","followers_url":"https://api.github.com/users/reecej/followers","following_url":"https://api.github.com/users/reecej/following{/other_user}","gists_url":"https://api.github.com/users/reecej/gists{/gist_id}","starred_url":"https://api.github.com/users/reecej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reecej/subscriptions","organizations_url":"https://api.github.com/users/reecej/orgs","repos_url":"https://api.github.com/users/reecej/repos","events_url":"https://api.github.com/users/reecej/events{/privacy}","received_events_url":"https://api.github.com/users/reecej/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T17:06:06Z","updated_at":"2018-05-02T17:06:06Z","author_association":"CONTRIBUTOR","body":"I agree, the length independent component is nice. But the unfortunate part is this will just give us an average chain pitch variance. We will still have variable chain pitch on a link-by-link basis, and I don't know if a good way to easily determine that more specifically.\r\n\r\nThe only time this might be a concern is considering how the chain ages. Over time, I would expect the chain links attached close to the sled to stretch more than the other end of the chain, due to usage. So I would expect chain tolerance calibrations to be required on some recurring basis, but for the accuracy to decline over time even with these recalibrations.\r\n\r\nAlso, for your chain tolerance calculation, I believe it would actually be (10/2990)*100."}}
{"actor":{"display_login":"reecej"}}