{"action":"created","comment":{"url":"https://api.github.com/repos/saros-project/saros/pulls/comments/235019411","pull_request_review_id":176787166,"id":235019411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTAxOTQxMQ==","diff_hunk":"@@ -116,10 +113,10 @@ public Editor openEditor(\n         @NotNull\n             IProject project, boolean activate) {\n \n-        IResource resource = virtualFileConverter\n-            .getResource(virtualFile, project);\n+        IResource resource = VirtualFileConverter\n+            .convertToResource(virtualFile, project);\n \n-        if (resource == null) {\n+        if (resource == null || !SessionUtils.isShared(resource)) {","path":"de.fu_berlin.inf.dpp.intellij/src/de/fu_berlin/inf/dpp/intellij/editor/LocalEditorHandler.java","position":52,"original_position":52,"commit_id":"0a082e4c2dfe1403719abd2251afc14350ff0917","original_commit_id":"0a082e4c2dfe1403719abd2251afc14350ff0917","user":{"login":"saros-infrastructure","id":39915837,"node_id":"MDQ6VXNlcjM5OTE1ODM3","avatar_url":"https://avatars1.githubusercontent.com/u/39915837?v=4","gravatar_id":"","url":"https://api.github.com/users/saros-infrastructure","html_url":"https://github.com/saros-infrastructure","followers_url":"https://api.github.com/users/saros-infrastructure/followers","following_url":"https://api.github.com/users/saros-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/saros-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/saros-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saros-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/saros-infrastructure/orgs","repos_url":"https://api.github.com/users/saros-infrastructure/repos","events_url":"https://api.github.com/users/saros-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/saros-infrastructure/received_events","type":"User","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Remove this use of \"SessionUtils\"; it is deprecated. ([squid:CallToDeprecatedMethod](https://sonarcloud.io/organizations/saros/rules#rule_key=squid%3ACallToDeprecatedMethod))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=saros_complete&pullRequest=294&issues=AWcxYM7E0EcSutaxLwSa&open=AWcxYM7E0EcSutaxLwSa)\n\n[ISSUE_KEY]: AWcxYM7E0EcSutaxLwSa","created_at":"2018-11-20T14:19:22Z","updated_at":"2018-11-20T14:19:23Z","html_url":"https://github.com/saros-project/saros/pull/294#discussion_r235019411","pull_request_url":"https://api.github.com/repos/saros-project/saros/pulls/294","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/saros-project/saros/pulls/comments/235019411"},"html":{"href":"https://github.com/saros-project/saros/pull/294#discussion_r235019411"},"pull_request":{"href":"https://api.github.com/repos/saros-project/saros/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/saros-project/saros/pulls/294","id":227799393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Nzk5Mzkz","html_url":"https://github.com/saros-project/saros/pull/294","diff_url":"https://github.com/saros-project/saros/pull/294.diff","patch_url":"https://github.com/saros-project/saros/pull/294.patch","issue_url":"https://api.github.com/repos/saros-project/saros/issues/294","number":294,"state":"open","locked":false,"title":"[INTERNAL][I] Make VirtualFileConverter static and session independent","user":{"login":"tobous","id":12495415,"node_id":"MDQ6VXNlcjEyNDk1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/12495415?v=4","gravatar_id":"","url":"https://api.github.com/users/tobous","html_url":"https://github.com/tobous","followers_url":"https://api.github.com/users/tobous/followers","following_url":"https://api.github.com/users/tobous/following{/other_user}","gists_url":"https://api.github.com/users/tobous/gists{/gist_id}","starred_url":"https://api.github.com/users/tobous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobous/subscriptions","organizations_url":"https://api.github.com/users/tobous/orgs","repos_url":"https://api.github.com/users/tobous/repos","events_url":"https://api.github.com/users/tobous/events{/privacy}","received_events_url":"https://api.github.com/users/tobous/received_events","type":"User","site_admin":false},"body":"Makes the VirtualFileConverter session independent. The new\r\nimplementation now uses the IntelliJ API to get the module objects\r\nneeded to convert the VirtualFile.\r\n\r\nAs a consequence to being independent of the session, the\r\nVirtualFileConverter can now also return resource objects for resources\r\nthat are not shared. This means any class using the converter now has to\r\ncheck whether the returned resource is shared itself.\r\nAdjustments for preexisting usages of the VirtualFileConverter are\r\nincluded in this commit.\r\n\r\nSubsequently makes the VirtualFileListener static for better usability.\r\n\r\nAdds utility methods to VirtualFileConverter to convert Saros resources\r\nto VirtualFiles and replaces the existing logic in multiple classes with a\r\ncall to the VirtualFileConverter.","created_at":"2018-11-02T00:29:09Z","updated_at":"2018-11-20T14:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"521085fab30e4ad7faa977dc2098620b776b379b","assignee":{"login":"tobous","id":12495415,"node_id":"MDQ6VXNlcjEyNDk1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/12495415?v=4","gravatar_id":"","url":"https://api.github.com/users/tobous","html_url":"https://github.com/tobous","followers_url":"https://api.github.com/users/tobous/followers","following_url":"https://api.github.com/users/tobous/following{/other_user}","gists_url":"https://api.github.com/users/tobous/gists{/gist_id}","starred_url":"https://api.github.com/users/tobous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobous/subscriptions","organizations_url":"https://api.github.com/users/tobous/orgs","repos_url":"https://api.github.com/users/tobous/repos","events_url":"https://api.github.com/users/tobous/events{/privacy}","received_events_url":"https://api.github.com/users/tobous/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobous","id":12495415,"node_id":"MDQ6VXNlcjEyNDk1NDE1","avatar_url":"https://avatars1.githubusercontent.com/u/12495415?v=4","gravatar_id":"","url":"https://api.github.com/users/tobous","html_url":"https://github.com/tobous","followers_url":"https://api.github.com/users/tobous/followers","following_url":"https://api.github.com/users/tobous/following{/other_user}","gists_url":"https://api.github.com/users/tobous/gists{/gist_id}","starred_url":"https://api.github.com/users/tobous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobous/subscriptions","organizations_url":"https://api.github.com/users/tobous/orgs","repos_url":"https://api.github.com/users/tobous/repos","events_url":"https://api.github.com/users/tobous/events{/privacy}","received_events_url":"https://api.github.com/users/tobous/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"donut87","id":1391577,"node_id":"MDQ6VXNlcjEzOTE1Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1391577?v=4","gravatar_id":"","url":"https://api.github.com/users/donut87","html_url":"https://github.com/donut87","followers_url":"https://api.github.com/users/donut87/followers","following_url":"https://api.github.com/users/donut87/following{/other_user}","gists_url":"https://api.github.com/users/donut87/gists{/gist_id}","starred_url":"https://api.github.com/users/donut87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donut87/subscriptions","organizations_url":"https://api.github.com/users/donut87/orgs","repos_url":"https://api.github.com/users/donut87/repos","events_url":"https://api.github.com/users/donut87/events{/privacy}","received_events_url":"https://api.github.com/users/donut87/received_events","type":"User","site_admin":false},{"login":"m273d15","id":7346610,"node_id":"MDQ6VXNlcjczNDY2MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7346610?v=4","gravatar_id":"","url":"https://api.github.com/users/m273d15","html_url":"https://github.com/m273d15","followers_url":"https://api.github.com/users/m273d15/followers","following_url":"https://api.github.com/users/m273d15/following{/other_user}","gists_url":"https://api.github.com/users/m273d15/gists{/gist_id}","starred_url":"https://api.github.com/users/m273d15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m273d15/subscriptions","organizations_url":"https://api.github.com/users/m273d15/orgs","repos_url":"https://api.github.com/users/m273d15/repos","events_url":"https://api.github.com/users/m273d15/events{/privacy}","received_events_url":"https://api.github.com/users/m273d15/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":881373676,"node_id":"MDU6TGFiZWw4ODEzNzM2NzY=","url":"https://api.github.com/repos/saros-project/saros/labels/intellij","name":"intellij","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/saros-project/saros/pulls/294/commits","review_comments_url":"https://api.github.com/repos/saros-project/saros/pulls/294/comments","review_comment_url":"https://api.github.com/repos/saros-project/saros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saros-project/saros/issues/294/comments","statuses_url":"https://api.github.com/repos/saros-project/saros/statuses/0a082e4c2dfe1403719abd2251afc14350ff0917","head":{"label":"saros-project:pr/intellij/static_virtualfileconverter","ref":"pr/intellij/static_virtualfileconverter","sha":"0a082e4c2dfe1403719abd2251afc14350ff0917","user":{"login":"saros-project","id":1419284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTkyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1419284?v=4","gravatar_id":"","url":"https://api.github.com/users/saros-project","html_url":"https://github.com/saros-project","followers_url":"https://api.github.com/users/saros-project/followers","following_url":"https://api.github.com/users/saros-project/following{/other_user}","gists_url":"https://api.github.com/users/saros-project/gists{/gist_id}","starred_url":"https://api.github.com/users/saros-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saros-project/subscriptions","organizations_url":"https://api.github.com/users/saros-project/orgs","repos_url":"https://api.github.com/users/saros-project/repos","events_url":"https://api.github.com/users/saros-project/events{/privacy}","received_events_url":"https://api.github.com/users/saros-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11182907,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MjkwNw==","name":"saros","full_name":"saros-project/saros","private":false,"owner":{"login":"saros-project","id":1419284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTkyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1419284?v=4","gravatar_id":"","url":"https://api.github.com/users/saros-project","html_url":"https://github.com/saros-project","followers_url":"https://api.github.com/users/saros-project/followers","following_url":"https://api.github.com/users/saros-project/following{/other_user}","gists_url":"https://api.github.com/users/saros-project/gists{/gist_id}","starred_url":"https://api.github.com/users/saros-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saros-project/subscriptions","organizations_url":"https://api.github.com/users/saros-project/orgs","repos_url":"https://api.github.com/users/saros-project/repos","events_url":"https://api.github.com/users/saros-project/events{/privacy}","received_events_url":"https://api.github.com/users/saros-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/saros-project/saros","description":"Saros Plugin","fork":false,"url":"https://api.github.com/repos/saros-project/saros","forks_url":"https://api.github.com/repos/saros-project/saros/forks","keys_url":"https://api.github.com/repos/saros-project/saros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saros-project/saros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saros-project/saros/teams","hooks_url":"https://api.github.com/repos/saros-project/saros/hooks","issue_events_url":"https://api.github.com/repos/saros-project/saros/issues/events{/number}","events_url":"https://api.github.com/repos/saros-project/saros/events","assignees_url":"https://api.github.com/repos/saros-project/saros/assignees{/user}","branches_url":"https://api.github.com/repos/saros-project/saros/branches{/branch}","tags_url":"https://api.github.com/repos/saros-project/saros/tags","blobs_url":"https://api.github.com/repos/saros-project/saros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saros-project/saros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saros-project/saros/git/refs{/sha}","trees_url":"https://api.github.com/repos/saros-project/saros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saros-project/saros/statuses/{sha}","languages_url":"https://api.github.com/repos/saros-project/saros/languages","stargazers_url":"https://api.github.com/repos/saros-project/saros/stargazers","contributors_url":"https://api.github.com/repos/saros-project/saros/contributors","subscribers_url":"https://api.github.com/repos/saros-project/saros/subscribers","subscription_url":"https://api.github.com/repos/saros-project/saros/subscription","commits_url":"https://api.github.com/repos/saros-project/saros/commits{/sha}","git_commits_url":"https://api.github.com/repos/saros-project/saros/git/commits{/sha}","comments_url":"https://api.github.com/repos/saros-project/saros/comments{/number}","issue_comment_url":"https://api.github.com/repos/saros-project/saros/issues/comments{/number}","contents_url":"https://api.github.com/repos/saros-project/saros/contents/{+path}","compare_url":"https://api.github.com/repos/saros-project/saros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saros-project/saros/merges","archive_url":"https://api.github.com/repos/saros-project/saros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saros-project/saros/downloads","issues_url":"https://api.github.com/repos/saros-project/saros/issues{/number}","pulls_url":"https://api.github.com/repos/saros-project/saros/pulls{/number}","milestones_url":"https://api.github.com/repos/saros-project/saros/milestones{/number}","notifications_url":"https://api.github.com/repos/saros-project/saros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saros-project/saros/labels{/name}","releases_url":"https://api.github.com/repos/saros-project/saros/releases{/id}","deployments_url":"https://api.github.com/repos/saros-project/saros/deployments","created_at":"2013-07-04T17:14:07Z","updated_at":"2018-11-20T13:42:50Z","pushed_at":"2018-11-20T14:01:27Z","git_url":"git://github.com/saros-project/saros.git","ssh_url":"git@github.com:saros-project/saros.git","clone_url":"https://github.com/saros-project/saros.git","svn_url":"https://github.com/saros-project/saros","homepage":"http://www.saros-project.org","size":143838,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":27,"open_issues":177,"watchers":59,"default_branch":"master"}},"base":{"label":"saros-project:pr/core/add_sessionutils","ref":"pr/core/add_sessionutils","sha":"e5232e246c5a07145aadf117445d65905ad445bd","user":{"login":"saros-project","id":1419284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTkyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1419284?v=4","gravatar_id":"","url":"https://api.github.com/users/saros-project","html_url":"https://github.com/saros-project","followers_url":"https://api.github.com/users/saros-project/followers","following_url":"https://api.github.com/users/saros-project/following{/other_user}","gists_url":"https://api.github.com/users/saros-project/gists{/gist_id}","starred_url":"https://api.github.com/users/saros-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saros-project/subscriptions","organizations_url":"https://api.github.com/users/saros-project/orgs","repos_url":"https://api.github.com/users/saros-project/repos","events_url":"https://api.github.com/users/saros-project/events{/privacy}","received_events_url":"https://api.github.com/users/saros-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11182907,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MjkwNw==","name":"saros","full_name":"saros-project/saros","private":false,"owner":{"login":"saros-project","id":1419284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTkyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1419284?v=4","gravatar_id":"","url":"https://api.github.com/users/saros-project","html_url":"https://github.com/saros-project","followers_url":"https://api.github.com/users/saros-project/followers","following_url":"https://api.github.com/users/saros-project/following{/other_user}","gists_url":"https://api.github.com/users/saros-project/gists{/gist_id}","starred_url":"https://api.github.com/users/saros-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saros-project/subscriptions","organizations_url":"https://api.github.com/users/saros-project/orgs","repos_url":"https://api.github.com/users/saros-project/repos","events_url":"https://api.github.com/users/saros-project/events{/privacy}","received_events_url":"https://api.github.com/users/saros-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/saros-project/saros","description":"Saros Plugin","fork":false,"url":"https://api.github.com/repos/saros-project/saros","forks_url":"https://api.github.com/repos/saros-project/saros/forks","keys_url":"https://api.github.com/repos/saros-project/saros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saros-project/saros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saros-project/saros/teams","hooks_url":"https://api.github.com/repos/saros-project/saros/hooks","issue_events_url":"https://api.github.com/repos/saros-project/saros/issues/events{/number}","events_url":"https://api.github.com/repos/saros-project/saros/events","assignees_url":"https://api.github.com/repos/saros-project/saros/assignees{/user}","branches_url":"https://api.github.com/repos/saros-project/saros/branches{/branch}","tags_url":"https://api.github.com/repos/saros-project/saros/tags","blobs_url":"https://api.github.com/repos/saros-project/saros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saros-project/saros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saros-project/saros/git/refs{/sha}","trees_url":"https://api.github.com/repos/saros-project/saros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saros-project/saros/statuses/{sha}","languages_url":"https://api.github.com/repos/saros-project/saros/languages","stargazers_url":"https://api.github.com/repos/saros-project/saros/stargazers","contributors_url":"https://api.github.com/repos/saros-project/saros/contributors","subscribers_url":"https://api.github.com/repos/saros-project/saros/subscribers","subscription_url":"https://api.github.com/repos/saros-project/saros/subscription","commits_url":"https://api.github.com/repos/saros-project/saros/commits{/sha}","git_commits_url":"https://api.github.com/repos/saros-project/saros/git/commits{/sha}","comments_url":"https://api.github.com/repos/saros-project/saros/comments{/number}","issue_comment_url":"https://api.github.com/repos/saros-project/saros/issues/comments{/number}","contents_url":"https://api.github.com/repos/saros-project/saros/contents/{+path}","compare_url":"https://api.github.com/repos/saros-project/saros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saros-project/saros/merges","archive_url":"https://api.github.com/repos/saros-project/saros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saros-project/saros/downloads","issues_url":"https://api.github.com/repos/saros-project/saros/issues{/number}","pulls_url":"https://api.github.com/repos/saros-project/saros/pulls{/number}","milestones_url":"https://api.github.com/repos/saros-project/saros/milestones{/number}","notifications_url":"https://api.github.com/repos/saros-project/saros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saros-project/saros/labels{/name}","releases_url":"https://api.github.com/repos/saros-project/saros/releases{/id}","deployments_url":"https://api.github.com/repos/saros-project/saros/deployments","created_at":"2013-07-04T17:14:07Z","updated_at":"2018-11-20T13:42:50Z","pushed_at":"2018-11-20T14:01:27Z","git_url":"git://github.com/saros-project/saros.git","ssh_url":"git@github.com:saros-project/saros.git","clone_url":"https://github.com/saros-project/saros.git","svn_url":"https://github.com/saros-project/saros","homepage":"http://www.saros-project.org","size":143838,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":27,"open_issues":177,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saros-project/saros/pulls/294"},"html":{"href":"https://github.com/saros-project/saros/pull/294"},"issue":{"href":"https://api.github.com/repos/saros-project/saros/issues/294"},"comments":{"href":"https://api.github.com/repos/saros-project/saros/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/saros-project/saros/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/saros-project/saros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saros-project/saros/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/saros-project/saros/statuses/0a082e4c2dfe1403719abd2251afc14350ff0917"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"saros-infrastructure"}}