{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/196170751","pull_request_review_id":129673030,"id":196170751,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE3MDc1MQ==","diff_hunk":"@@ -37,7 +43,13 @@ If B<bits> is 1 then B<top> cannot also be B<BN_RAND_FLG_TOPTWO>.\n BN_rand_range() generates a cryptographically strong pseudo-random\n number B<rnd> in the range 0 E<lt>= B<rnd> E<lt> B<range>.\n \n-The PRNG must be seeded prior to calling BN_rand() or BN_rand_range().\n+BN_priv_rand() and BN_priv_rand_range() have, respectively, the same","path":"doc/man3/BN_rand.pod","position":31,"original_position":31,"commit_id":"cab0fb73964494fe122eef5a5dd03a68dd355ef2","original_commit_id":"cab0fb73964494fe122eef5a5dd03a68dd355ef2","user":{"login":"mspncp","id":11467854,"node_id":"MDQ6VXNlcjExNDY3ODU0","avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"body":"Maybe move \",respectively\" to the end?  (that saves a comma.)","created_at":"2018-06-18T17:59:26Z","updated_at":"2018-06-18T18:04:21Z","html_url":"https://github.com/openssl/openssl/pull/6514#discussion_r196170751","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6514","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/196170751"},"html":{"href":"https://github.com/openssl/openssl/pull/6514#discussion_r196170751"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6514"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6514","id":195579194,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTc5MTk0","html_url":"https://github.com/openssl/openssl/pull/6514","diff_url":"https://github.com/openssl/openssl/pull/6514.diff","patch_url":"https://github.com/openssl/openssl/pull/6514.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6514","number":6514,"state":"open","locked":false,"title":"Fix & update documentation about RAND_priv_bytes()","user":{"login":"romen","id":338418,"node_id":"MDQ6VXNlcjMzODQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/338418?v=4","gravatar_id":"","url":"https://api.github.com/users/romen","html_url":"https://github.com/romen","followers_url":"https://api.github.com/users/romen/followers","following_url":"https://api.github.com/users/romen/following{/other_user}","gists_url":"https://api.github.com/users/romen/gists{/gist_id}","starred_url":"https://api.github.com/users/romen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romen/subscriptions","organizations_url":"https://api.github.com/users/romen/orgs","repos_url":"https://api.github.com/users/romen/repos","events_url":"https://api.github.com/users/romen/events{/privacy}","received_events_url":"https://api.github.com/users/romen/received_events","type":"User","site_admin":false},"body":"Stemming from https://github.com/openssl/openssl/pull/6501#discussion_r195978940 this PR updates the documentation about `RAND_priv_bytes()` and then adds missing documentation about `BN_priv_rand()` and `BN_priv_rand_range()`:\r\n- [x] documentation is updated\r\n- [x] documentation is added\r\n\r\nPinging @kroeckx , @richsalz and @mspncp  for comments: bear in mind that I'm not entirely familiar with pod syntax, so please double check for newbie errors!","created_at":"2018-06-18T16:21:52Z","updated_at":"2018-06-18T18:04:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf7a52d3ecd2a663c65064efa3ebb7b5d2c5bd5b","assignee":{"login":"richsalz","id":7332500,"node_id":"MDQ6VXNlcjczMzI1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7332500?v=4","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"assignees":[{"login":"richsalz","id":7332500,"node_id":"MDQ6VXNlcjczMzI1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7332500?v=4","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":441165399,"node_id":"MDU6TGFiZWw0NDExNjUzOTk=","url":"https://api.github.com/repos/openssl/openssl/labels/1.1.0","name":"1.1.0","color":"bfdadc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false},{"id":613575196,"node_id":"MDU6TGFiZWw2MTM1NzUxOTY=","url":"https://api.github.com/repos/openssl/openssl/labels/pending%202nd%20review","name":"pending 2nd review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6514/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6514/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6514/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/cab0fb73964494fe122eef5a5dd03a68dd355ef2","head":{"label":"romen:priv_rand_docfix","ref":"priv_rand_docfix","sha":"cab0fb73964494fe122eef5a5dd03a68dd355ef2","user":{"login":"romen","id":338418,"node_id":"MDQ6VXNlcjMzODQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/338418?v=4","gravatar_id":"","url":"https://api.github.com/users/romen","html_url":"https://github.com/romen","followers_url":"https://api.github.com/users/romen/followers","following_url":"https://api.github.com/users/romen/following{/other_user}","gists_url":"https://api.github.com/users/romen/gists{/gist_id}","starred_url":"https://api.github.com/users/romen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romen/subscriptions","organizations_url":"https://api.github.com/users/romen/orgs","repos_url":"https://api.github.com/users/romen/repos","events_url":"https://api.github.com/users/romen/events{/privacy}","received_events_url":"https://api.github.com/users/romen/received_events","type":"User","site_admin":false},"repo":{"id":130825508,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4MjU1MDg=","name":"openssl","full_name":"romen/openssl","owner":{"login":"romen","id":338418,"node_id":"MDQ6VXNlcjMzODQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/338418?v=4","gravatar_id":"","url":"https://api.github.com/users/romen","html_url":"https://github.com/romen","followers_url":"https://api.github.com/users/romen/followers","following_url":"https://api.github.com/users/romen/following{/other_user}","gists_url":"https://api.github.com/users/romen/gists{/gist_id}","starred_url":"https://api.github.com/users/romen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romen/subscriptions","organizations_url":"https://api.github.com/users/romen/orgs","repos_url":"https://api.github.com/users/romen/repos","events_url":"https://api.github.com/users/romen/events{/privacy}","received_events_url":"https://api.github.com/users/romen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romen/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/romen/openssl","forks_url":"https://api.github.com/repos/romen/openssl/forks","keys_url":"https://api.github.com/repos/romen/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romen/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romen/openssl/teams","hooks_url":"https://api.github.com/repos/romen/openssl/hooks","issue_events_url":"https://api.github.com/repos/romen/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/romen/openssl/events","assignees_url":"https://api.github.com/repos/romen/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/romen/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/romen/openssl/tags","blobs_url":"https://api.github.com/repos/romen/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romen/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romen/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/romen/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romen/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/romen/openssl/languages","stargazers_url":"https://api.github.com/repos/romen/openssl/stargazers","contributors_url":"https://api.github.com/repos/romen/openssl/contributors","subscribers_url":"https://api.github.com/repos/romen/openssl/subscribers","subscription_url":"https://api.github.com/repos/romen/openssl/subscription","commits_url":"https://api.github.com/repos/romen/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/romen/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/romen/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/romen/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/romen/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/romen/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romen/openssl/merges","archive_url":"https://api.github.com/repos/romen/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romen/openssl/downloads","issues_url":"https://api.github.com/repos/romen/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/romen/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/romen/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/romen/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romen/openssl/labels{/name}","releases_url":"https://api.github.com/repos/romen/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/romen/openssl/deployments","created_at":"2018-04-24T08:56:29Z","updated_at":"2018-04-24T08:56:48Z","pushed_at":"2018-06-18T17:20:29Z","git_url":"git://github.com/romen/openssl.git","ssh_url":"git@github.com:romen/openssl.git","clone_url":"https://github.com/romen/openssl.git","svn_url":"https://github.com/romen/openssl","homepage":"https://www.openssl.org","size":148360,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"a47f0a8507e054f8707129bf33455effd7201358","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-06-18T18:00:17Z","pushed_at":"2018-06-18T18:03:55Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":148855,"stargazers_count":7380,"watchers_count":7380,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3519,"mirror_url":null,"archived":false,"open_issues_count":418,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3519,"open_issues":418,"watchers":7380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6514"},"html":{"href":"https://github.com/openssl/openssl/pull/6514"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6514"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6514/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6514/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6514/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/cab0fb73964494fe122eef5a5dd03a68dd355ef2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mspncp"}}