{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28372","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28372/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28372/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28372/events","html_url":"https://github.com/Automattic/wp-calypso/pull/28372","id":378527173,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjEzMDg1","number":28372,"title":"Gutenberg: show opt-in modals on wpcalypso","user":{"login":"gwwar","id":1270189,"node_id":"MDQ6VXNlcjEyNzAxODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"labels":[{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":838866001,"node_id":"MDU6TGFiZWw4Mzg4NjYwMDE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20e2e%20Testing","name":"[Status] Needs e2e Testing","color":"ed74b2","default":false}],"state":"open","locked":false,"assignee":{"login":"gwwar","id":1270189,"node_id":"MDQ6VXNlcjEyNzAxODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"assignees":[{"login":"gwwar","id":1270189,"node_id":"MDQ6VXNlcjEyNzAxODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-11-08T00:26:28Z","updated_at":"2018-11-08T11:55:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28372","html_url":"https://github.com/Automattic/wp-calypso/pull/28372","diff_url":"https://github.com/Automattic/wp-calypso/pull/28372.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/28372.patch"},"body":"#### Changes proposed in this Pull Request\r\n\r\n* This enables the `gutenberg/opt-in` feature flag to enable Gutenberg opt-in modals to be shown on wpcalypso. We should see if we need to prepare any e2e test updates.\r\n\r\n![screen shot 2018-11-07 at 4 20 36 pm](https://user-images.githubusercontent.com/1270189/48169739-4af94280-e2a9-11e8-9eae-ae131b2eda74.png)\r\n\r\n![screen shot 2018-11-07 at 4 20 43 pm](https://user-images.githubusercontent.com/1270189/48169743-4f256000-e2a9-11e8-8d68-ffe707bd0b60.png)\r\n\r\n#### Testing instructions\r\n\r\n- Sandbox D20226-code, or add `enable-gutenberg` sticker to a simple site of your choice\r\n- Checkout this branch, clicking on \"Try the new editor\" will take you to the Calypsoified Gutenberg Editor.\r\n- Click on close takes you back to Calypso\r\n- Folks can also change their preference with:\r\n![screen_shot_2018-11-07_at_4 01 49_pm](https://user-images.githubusercontent.com/1270189/48169856-cd820200-e2a9-11e8-97b3-69e0c1ad23c8.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/436969771","html_url":"https://github.com/Automattic/wp-calypso/pull/28372#issuecomment-436969771","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28372","id":436969771,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjk2OTc3MQ==","user":{"login":"mmtr","id":1233880,"node_id":"MDQ6VXNlcjEyMzM4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1233880?v=4","gravatar_id":"","url":"https://api.github.com/users/mmtr","html_url":"https://github.com/mmtr","followers_url":"https://api.github.com/users/mmtr/followers","following_url":"https://api.github.com/users/mmtr/following{/other_user}","gists_url":"https://api.github.com/users/mmtr/gists{/gist_id}","starred_url":"https://api.github.com/users/mmtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmtr/subscriptions","organizations_url":"https://api.github.com/users/mmtr/orgs","repos_url":"https://api.github.com/users/mmtr/repos","events_url":"https://api.github.com/users/mmtr/events{/privacy}","received_events_url":"https://api.github.com/users/mmtr/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T11:55:00Z","updated_at":"2018-11-08T11:55:00Z","author_association":"MEMBER","body":"> @mmtr What if instead of changing the e2e tests, we changed the notice z-index to not appear in front of the sidebar? 🤔\r\n\r\nThanks @Copons! Nice work-around 😄. Applied in https://github.com/Automattic/wp-calypso/pull/28372/commits/b38a8659b242b24b58799c569032e1ea988ff051\r\n\r\nThe notice `z-index` matches now the one used by the sidebar when the sidebar is open in mobile devices, so it's placed behind it. The problem is not present in bigger viewports, as the notice is over the content side."}}
{"actor":{"display_login":"mmtr"}}