{"action":"closed","number":760,"pull_request":{"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760","id":229046033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDQ2MDMz","html_url":"https://github.com/Aptoide/aptoide-client-v8/pull/760","diff_url":"https://github.com/Aptoide/aptoide-client-v8/pull/760.diff","patch_url":"https://github.com/Aptoide/aptoide-client-v8/pull/760.patch","issue_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/760","number":760,"state":"closed","locked":false,"title":"[ASV-1035] New Comments Core and Store implementation","user":{"login":"jdandrade","id":10675941,"node_id":"MDQ6VXNlcjEwNjc1OTQx","avatar_url":"https://avatars0.githubusercontent.com/u/10675941?v=4","gravatar_id":"","url":"https://api.github.com/users/jdandrade","html_url":"https://github.com/jdandrade","followers_url":"https://api.github.com/users/jdandrade/followers","following_url":"https://api.github.com/users/jdandrade/following{/other_user}","gists_url":"https://api.github.com/users/jdandrade/gists{/gist_id}","starred_url":"https://api.github.com/users/jdandrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdandrade/subscriptions","organizations_url":"https://api.github.com/users/jdandrade/orgs","repos_url":"https://api.github.com/users/jdandrade/repos","events_url":"https://api.github.com/users/jdandrade/events{/privacy}","received_events_url":"https://api.github.com/users/jdandrade/received_events","type":"User","site_admin":false},"body":"**What does this PR do?**\r\n\r\n   This pull-request has the core of the comments API using clean architecture. This core will be the dependency for every view that touches comments in the future. This also has a low def implementation of the comments with the new look and feel in the Stores ( stores comments ) and it is composed in 3 main views: the storefragment (still widgets-displayables), which has the store's latests comments, the commentsfragment (generic list of comments) and commentsdetailfragment (generic comment detail with latest 10 replies).\r\n\r\nAlso tried to test most of the flows.\r\n\r\n**Database changed?**\r\n\r\n   No\r\n\r\n**Where should the reviewer start?**\r\n\r\n- [ ] CommentsFragment.java\r\n- [ ] StoreLatestCommentsWidget.java\r\n- [ ] CommentDetailFragment.java\r\n\r\n**How should this be manually tested?**\r\n\r\n  Go to a store with comments, see comments, click more, see all comments, make a reply, pull to refresh, infinite scroll, click comment with replies, try to reply etc.\r\n\r\n**What are the relevant tickets?**\r\n\r\n  Tickets related to this pull-request: [ASV-1042](https://aptoide.atlassian.net/browse/ASV-1042)\r\n[ASV-1043](https://aptoide.atlassian.net/browse/ASV-1043)\r\n[ASV-1044](https://aptoide.atlassian.net/browse/ASV-1044)\r\n\r\n**Code Review Checklist**\r\n\r\n- [ ] Architecture\r\n- [ ] Documentation on public interfaces\r\n- [ ] Database changed?\r\n- [ ] If yes - Database migration?\r\n- [ ] Remove comments & unused code & forgotten testing Logs\r\n- [ ] Codestyle\r\n- [ ] Partners build\r\n- [ ] Unit tests pass\r\n- [ ] Functional QA tests pass","created_at":"2018-11-07T14:29:45Z","updated_at":"2018-11-12T11:38:24Z","closed_at":"2018-11-12T11:38:24Z","merged_at":"2018-11-12T11:38:24Z","merge_commit_sha":"4a0bdc666fd633705bac07c0704bb14b4fc77696","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760/commits","review_comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760/comments","review_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/760/comments","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/8fe8be0fce7617141c39175bd97a6b3f195c292a","head":{"label":"Aptoide:feature/ASV-1042_comments-store-home","ref":"feature/ASV-1042_comments-store-home","sha":"8fe8be0fce7617141c39175bd97a6b3f195c292a","user":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"repo":{"id":56278667,"node_id":"MDEwOlJlcG9zaXRvcnk1NjI3ODY2Nw==","name":"aptoide-client-v8","full_name":"Aptoide/aptoide-client-v8","private":false,"owner":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Aptoide/aptoide-client-v8","description":"All the Apps you need. Discover your new Android App Store.","fork":false,"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8","forks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/forks","keys_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/teams","hooks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/hooks","issue_events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/events{/number}","events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/events","assignees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/assignees{/user}","branches_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/branches{/branch}","tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/tags","blobs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/{sha}","languages_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/languages","stargazers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/stargazers","contributors_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contributors","subscribers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscribers","subscription_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscription","commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contents/{+path}","compare_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/merges","archive_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/downloads","issues_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues{/number}","pulls_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls{/number}","milestones_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/milestones{/number}","notifications_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/labels{/name}","releases_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/releases{/id}","deployments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/deployments","created_at":"2016-04-15T00:32:20Z","updated_at":"2018-11-05T05:29:23Z","pushed_at":"2018-11-12T11:38:24Z","git_url":"git://github.com/Aptoide/aptoide-client-v8.git","ssh_url":"git@github.com:Aptoide/aptoide-client-v8.git","clone_url":"https://github.com/Aptoide/aptoide-client-v8.git","svn_url":"https://github.com/Aptoide/aptoide-client-v8","homepage":"http://en.aptoide.com","size":93738,"stargazers_count":65,"watchers_count":65,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":25,"open_issues":5,"watchers":65,"default_branch":"master"}},"base":{"label":"Aptoide:feature/ASV-1035_new-comment-core","ref":"feature/ASV-1035_new-comment-core","sha":"1af2a0dc2e1e95d50e251a09dc24bdcb06fd0b3b","user":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"repo":{"id":56278667,"node_id":"MDEwOlJlcG9zaXRvcnk1NjI3ODY2Nw==","name":"aptoide-client-v8","full_name":"Aptoide/aptoide-client-v8","private":false,"owner":{"login":"Aptoide","id":10279797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjc5Nzk3","avatar_url":"https://avatars2.githubusercontent.com/u/10279797?v=4","gravatar_id":"","url":"https://api.github.com/users/Aptoide","html_url":"https://github.com/Aptoide","followers_url":"https://api.github.com/users/Aptoide/followers","following_url":"https://api.github.com/users/Aptoide/following{/other_user}","gists_url":"https://api.github.com/users/Aptoide/gists{/gist_id}","starred_url":"https://api.github.com/users/Aptoide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aptoide/subscriptions","organizations_url":"https://api.github.com/users/Aptoide/orgs","repos_url":"https://api.github.com/users/Aptoide/repos","events_url":"https://api.github.com/users/Aptoide/events{/privacy}","received_events_url":"https://api.github.com/users/Aptoide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Aptoide/aptoide-client-v8","description":"All the Apps you need. Discover your new Android App Store.","fork":false,"url":"https://api.github.com/repos/Aptoide/aptoide-client-v8","forks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/forks","keys_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/teams","hooks_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/hooks","issue_events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/events{/number}","events_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/events","assignees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/assignees{/user}","branches_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/branches{/branch}","tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/tags","blobs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/{sha}","languages_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/languages","stargazers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/stargazers","contributors_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contributors","subscribers_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscribers","subscription_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/subscription","commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/contents/{+path}","compare_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/merges","archive_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/downloads","issues_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues{/number}","pulls_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls{/number}","milestones_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/milestones{/number}","notifications_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/labels{/name}","releases_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/releases{/id}","deployments_url":"https://api.github.com/repos/Aptoide/aptoide-client-v8/deployments","created_at":"2016-04-15T00:32:20Z","updated_at":"2018-11-05T05:29:23Z","pushed_at":"2018-11-12T11:38:24Z","git_url":"git://github.com/Aptoide/aptoide-client-v8.git","ssh_url":"git@github.com:Aptoide/aptoide-client-v8.git","clone_url":"https://github.com/Aptoide/aptoide-client-v8.git","svn_url":"https://github.com/Aptoide/aptoide-client-v8","homepage":"http://en.aptoide.com","size":93738,"stargazers_count":65,"watchers_count":65,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":25,"open_issues":5,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760"},"html":{"href":"https://github.com/Aptoide/aptoide-client-v8/pull/760"},"issue":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/760"},"comments":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/issues/760/comments"},"review_comments":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760/comments"},"review_comment":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/pulls/760/commits"},"statuses":{"href":"https://api.github.com/repos/Aptoide/aptoide-client-v8/statuses/8fe8be0fce7617141c39175bd97a6b3f195c292a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tiagopedrinho","id":30079251,"node_id":"MDQ6VXNlcjMwMDc5MjUx","avatar_url":"https://avatars0.githubusercontent.com/u/30079251?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagopedrinho","html_url":"https://github.com/tiagopedrinho","followers_url":"https://api.github.com/users/tiagopedrinho/followers","following_url":"https://api.github.com/users/tiagopedrinho/following{/other_user}","gists_url":"https://api.github.com/users/tiagopedrinho/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagopedrinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagopedrinho/subscriptions","organizations_url":"https://api.github.com/users/tiagopedrinho/orgs","repos_url":"https://api.github.com/users/tiagopedrinho/repos","events_url":"https://api.github.com/users/tiagopedrinho/events{/privacy}","received_events_url":"https://api.github.com/users/tiagopedrinho/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":38,"additions":2307,"deletions":43,"changed_files":64}}
{"actor":{"display_login":"tiagopedrinho"}}