{"action":"closed","number":1946,"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946","id":204273475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MjczNDc1","html_url":"https://github.com/Opentrons/opentrons/pull/1946","diff_url":"https://github.com/Opentrons/opentrons/pull/1946.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/1946.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/1946","number":1946,"state":"closed","locked":false,"title":"feat(protocol-designer): make pipettes eagerly drop tips","user":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"## overview\r\n\r\nCloses #1706\r\n\r\nTo make StepCreators composable, and because they individually can't be aware of future steps, they always hang on to their tip at the end. However, this can cause liquids to drip while tips are needlessly carried over. Plus it looks really freaking weird. In practice, the only time tips shouldn't be dropped at the end of a step is if the next step for that pipette has \"change tip: never\" set -- this means \"reuse tips from previous step with this pipette\".\r\n\r\nSo this PR makes the `robotStateTimeline` selector look into the future, and drop tips at the end of each step unless they'll need to be carried over.\r\n\r\n## changelog\r\n\r\n- drop tips eagerly at the end of each step unless the next step for a pipette uses change tip: \"never\"\r\n\r\n## review requests\r\n\r\nDo you see any edge cases where this won't work right?\r\n\r\nTo see exactly what it's doing, either inspect the JSON commands, or load into Run App and look at the command log!","created_at":"2018-07-26T21:34:45Z","updated_at":"2018-07-27T16:52:53Z","closed_at":"2018-07-27T16:52:53Z","merged_at":"2018-07-27T16:52:53Z","merge_commit_sha":"9fb0725ebcc06da0447745bc0254dd46ce9480b5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcous","id":2963448,"node_id":"MDQ6VXNlcjI5NjM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},{"login":"Kadee80","id":3430313,"node_id":"MDQ6VXNlcjM0MzAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":770645862,"node_id":"MDU6TGFiZWw3NzA2NDU4NjI=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/protocol%20designer","name":"protocol designer","color":"440f89","default":false},{"id":762619415,"node_id":"MDU6TGFiZWw3NjI2MTk0MTU=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/ready%20for%20review","name":"ready for review","color":"6ed32a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/1946/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/8ff7af4b212a0bb323d18c212bbe8cec061c2ed3","head":{"label":"Opentrons:pd_eager-tip-dropping","ref":"pd_eager-tip-dropping","sha":"8ff7af4b212a0bb323d18c212bbe8cec061c2ed3","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-07-27T14:11:25Z","pushed_at":"2018-07-27T16:52:53Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":29000,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":173,"watchers":56,"default_branch":"edge"}},"base":{"label":"Opentrons:edge","ref":"edge","sha":"84d2e3d0857330c0cb73aea6894c865bf4ec2913","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-07-27T14:11:25Z","pushed_at":"2018-07-27T16:52:53Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":29000,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":38,"open_issues":173,"watchers":56,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/1946"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/1946"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/1946/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/1946/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/8ff7af4b212a0bb323d18c212bbe8cec061c2ed3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"IanLondon"}}