{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/210863050","pull_request_review_id":147167899,"id":210863050,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg2MzA1MA==","diff_hunk":"@@ -52,7 +46,6 @@ public function testArrayConvertsToPHPValue()\n \n     public function testConversionFailure()\n     {\n-        error_reporting( (E_ALL | E_STRICT) - \\E_NOTICE );","path":"tests/Doctrine/Tests/DBAL/Types/ArrayTest.php","position":17,"original_position":17,"commit_id":"c88daf1f99aea62e7873cf02d76cf5be2450343d","original_commit_id":"c88daf1f99aea62e7873cf02d76cf5be2450343d","user":{"login":"seferov","id":1233843,"node_id":"MDQ6VXNlcjEyMzM4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1233843?v=4","gravatar_id":"","url":"https://api.github.com/users/seferov","html_url":"https://github.com/seferov","followers_url":"https://api.github.com/users/seferov/followers","following_url":"https://api.github.com/users/seferov/following{/other_user}","gists_url":"https://api.github.com/users/seferov/gists{/gist_id}","starred_url":"https://api.github.com/users/seferov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seferov/subscriptions","organizations_url":"https://api.github.com/users/seferov/orgs","repos_url":"https://api.github.com/users/seferov/repos","events_url":"https://api.github.com/users/seferov/events{/privacy}","received_events_url":"https://api.github.com/users/seferov/received_events","type":"User","site_admin":false},"body":"@guilliamxavier you are right. I will make the changes you suggested. However I am not sure what the maintainers think about this PR.","created_at":"2018-08-17T10:05:02Z","updated_at":"2018-08-17T10:05:03Z","html_url":"https://github.com/doctrine/dbal/pull/3254#discussion_r210863050","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/3254","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/210863050"},"html":{"href":"https://github.com/doctrine/dbal/pull/3254#discussion_r210863050"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3254"}},"in_reply_to_id":210860235},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/3254","id":209084709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDg0NzA5","html_url":"https://github.com/doctrine/dbal/pull/3254","diff_url":"https://github.com/doctrine/dbal/pull/3254.diff","patch_url":"https://github.com/doctrine/dbal/pull/3254.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/3254","number":3254,"state":"open","locked":false,"title":"Suppress unserialize notice error since it is done with ConversionException","user":{"login":"seferov","id":1233843,"node_id":"MDQ6VXNlcjEyMzM4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1233843?v=4","gravatar_id":"","url":"https://api.github.com/users/seferov","html_url":"https://github.com/seferov","followers_url":"https://api.github.com/users/seferov/followers","following_url":"https://api.github.com/users/seferov/following{/other_user}","gists_url":"https://api.github.com/users/seferov/gists{/gist_id}","starred_url":"https://api.github.com/users/seferov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seferov/subscriptions","organizations_url":"https://api.github.com/users/seferov/orgs","repos_url":"https://api.github.com/users/seferov/repos","events_url":"https://api.github.com/users/seferov/events{/privacy}","received_events_url":"https://api.github.com/users/seferov/received_events","type":"User","site_admin":false},"body":"<!-- Fill in the relevant information below to help triage your pull request. -->\r\n\r\n|      Q       |   A\r\n|------------- | -----------\r\n| Type         | bug/improvement\r\n| BC Break     | no\r\n\r\n#### Summary\r\n\r\n**Problem:** Converting invalid data with ArrayType throws PHP notice error.\r\n\r\n**Solution:** inside convert method unserialize notice error can be suppressed since a proper exception (ConversionException) will be thrown right after that. No need to deal with error reporting.\r\n","created_at":"2018-08-17T08:53:58Z","updated_at":"2018-08-17T10:05:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02df8f49759dbe385e2fed60656d73a4c294277b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/3254/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/3254/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/3254/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/c88daf1f99aea62e7873cf02d76cf5be2450343d","head":{"label":"seferov:array-type-convert","ref":"array-type-convert","sha":"c88daf1f99aea62e7873cf02d76cf5be2450343d","user":{"login":"seferov","id":1233843,"node_id":"MDQ6VXNlcjEyMzM4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1233843?v=4","gravatar_id":"","url":"https://api.github.com/users/seferov","html_url":"https://github.com/seferov","followers_url":"https://api.github.com/users/seferov/followers","following_url":"https://api.github.com/users/seferov/following{/other_user}","gists_url":"https://api.github.com/users/seferov/gists{/gist_id}","starred_url":"https://api.github.com/users/seferov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seferov/subscriptions","organizations_url":"https://api.github.com/users/seferov/orgs","repos_url":"https://api.github.com/users/seferov/repos","events_url":"https://api.github.com/users/seferov/events{/privacy}","received_events_url":"https://api.github.com/users/seferov/received_events","type":"User","site_admin":false},"repo":{"id":145095940,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTU5NDA=","name":"dbal","full_name":"seferov/dbal","owner":{"login":"seferov","id":1233843,"node_id":"MDQ6VXNlcjEyMzM4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1233843?v=4","gravatar_id":"","url":"https://api.github.com/users/seferov","html_url":"https://github.com/seferov","followers_url":"https://api.github.com/users/seferov/followers","following_url":"https://api.github.com/users/seferov/following{/other_user}","gists_url":"https://api.github.com/users/seferov/gists{/gist_id}","starred_url":"https://api.github.com/users/seferov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seferov/subscriptions","organizations_url":"https://api.github.com/users/seferov/orgs","repos_url":"https://api.github.com/users/seferov/repos","events_url":"https://api.github.com/users/seferov/events{/privacy}","received_events_url":"https://api.github.com/users/seferov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seferov/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/seferov/dbal","forks_url":"https://api.github.com/repos/seferov/dbal/forks","keys_url":"https://api.github.com/repos/seferov/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seferov/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seferov/dbal/teams","hooks_url":"https://api.github.com/repos/seferov/dbal/hooks","issue_events_url":"https://api.github.com/repos/seferov/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/seferov/dbal/events","assignees_url":"https://api.github.com/repos/seferov/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/seferov/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/seferov/dbal/tags","blobs_url":"https://api.github.com/repos/seferov/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seferov/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seferov/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/seferov/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seferov/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/seferov/dbal/languages","stargazers_url":"https://api.github.com/repos/seferov/dbal/stargazers","contributors_url":"https://api.github.com/repos/seferov/dbal/contributors","subscribers_url":"https://api.github.com/repos/seferov/dbal/subscribers","subscription_url":"https://api.github.com/repos/seferov/dbal/subscription","commits_url":"https://api.github.com/repos/seferov/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/seferov/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/seferov/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/seferov/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/seferov/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/seferov/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seferov/dbal/merges","archive_url":"https://api.github.com/repos/seferov/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seferov/dbal/downloads","issues_url":"https://api.github.com/repos/seferov/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/seferov/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/seferov/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/seferov/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seferov/dbal/labels{/name}","releases_url":"https://api.github.com/repos/seferov/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/seferov/dbal/deployments","created_at":"2018-08-17T08:46:44Z","updated_at":"2018-08-17T08:46:48Z","pushed_at":"2018-08-17T09:44:21Z","git_url":"git://github.com/seferov/dbal.git","ssh_url":"git@github.com:seferov/dbal.git","clone_url":"https://github.com/seferov/dbal.git","svn_url":"https://github.com/seferov/dbal","homepage":"https://www.doctrine-project.org/projects/dbal.html","size":24870,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"319e20f847efecc8a2727c8dac5ceb592498b81b","user":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzc0NjQ=","name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTI1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2018-08-17T10:00:00Z","pushed_at":"2018-08-17T09:44:24Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"https://www.doctrine-project.org/projects/dbal.html","size":24882,"stargazers_count":3054,"watchers_count":3054,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":900,"mirror_url":null,"archived":false,"open_issues_count":435,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":900,"open_issues":435,"watchers":3054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3254"},"html":{"href":"https://github.com/doctrine/dbal/pull/3254"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3254"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/3254/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3254/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/3254/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/c88daf1f99aea62e7873cf02d76cf5be2450343d"}},"author_association":"NONE"}}
{"actor":{"display_login":"seferov"}}