{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/6888","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/6888/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6888/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/6888/events","html_url":"https://github.com/status-im/status-react/pull/6888","id":384503309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjkxMDgx","number":6888,"title":"show unread messages count for desktop","user":{"login":"rcullito","id":909156,"node_id":"MDQ6VXNlcjkwOTE1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/909156?v=4","gravatar_id":"","url":"https://api.github.com/users/rcullito","html_url":"https://github.com/rcullito","followers_url":"https://api.github.com/users/rcullito/followers","following_url":"https://api.github.com/users/rcullito/following{/other_user}","gists_url":"https://api.github.com/users/rcullito/gists{/gist_id}","starred_url":"https://api.github.com/users/rcullito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcullito/subscriptions","organizations_url":"https://api.github.com/users/rcullito/orgs","repos_url":"https://api.github.com/users/rcullito/repos","events_url":"https://api.github.com/users/rcullito/events{/privacy}","received_events_url":"https://api.github.com/users/rcullito/received_events","type":"User","site_admin":false},"labels":[{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false}],"state":"open","locked":false,"assignee":{"login":"SlizkovaGanna","id":43638377,"node_id":"MDQ6VXNlcjQzNjM4Mzc3","avatar_url":"https://avatars0.githubusercontent.com/u/43638377?v=4","gravatar_id":"","url":"https://api.github.com/users/SlizkovaGanna","html_url":"https://github.com/SlizkovaGanna","followers_url":"https://api.github.com/users/SlizkovaGanna/followers","following_url":"https://api.github.com/users/SlizkovaGanna/following{/other_user}","gists_url":"https://api.github.com/users/SlizkovaGanna/gists{/gist_id}","starred_url":"https://api.github.com/users/SlizkovaGanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlizkovaGanna/subscriptions","organizations_url":"https://api.github.com/users/SlizkovaGanna/orgs","repos_url":"https://api.github.com/users/SlizkovaGanna/repos","events_url":"https://api.github.com/users/SlizkovaGanna/events{/privacy}","received_events_url":"https://api.github.com/users/SlizkovaGanna/received_events","type":"User","site_admin":false},"assignees":[{"login":"SlizkovaGanna","id":43638377,"node_id":"MDQ6VXNlcjQzNjM4Mzc3","avatar_url":"https://avatars0.githubusercontent.com/u/43638377?v=4","gravatar_id":"","url":"https://api.github.com/users/SlizkovaGanna","html_url":"https://github.com/SlizkovaGanna","followers_url":"https://api.github.com/users/SlizkovaGanna/followers","following_url":"https://api.github.com/users/SlizkovaGanna/following{/other_user}","gists_url":"https://api.github.com/users/SlizkovaGanna/gists{/gist_id}","starred_url":"https://api.github.com/users/SlizkovaGanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlizkovaGanna/subscriptions","organizations_url":"https://api.github.com/users/SlizkovaGanna/orgs","repos_url":"https://api.github.com/users/SlizkovaGanna/repos","events_url":"https://api.github.com/users/SlizkovaGanna/events{/privacy}","received_events_url":"https://api.github.com/users/SlizkovaGanna/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-11-26T20:45:59Z","updated_at":"2018-11-28T13:42:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6888","html_url":"https://github.com/status-im/status-react/pull/6888","diff_url":"https://github.com/status-im/status-react/pull/6888.diff","patch_url":"https://github.com/status-im/status-react/pull/6888.patch"},"body":"### Summary:\r\n\r\nfixes #6749 \r\n\r\nShows unread messages count for desktop.  \r\n\r\nAs is suggested in the issue by @errorists, this PR shifts the barrier from \"large messages\" from anything over 9 to a system that displays the actual count for anything less than 1,000, rounds to the \"lowest\" thousand for anything up to 10,000, and simply displays \"10K+\" for anything greater than that. \r\n\r\nThe default styling of \"large\" numbers looked ok on my machine so I left it as is, although comments are welcome of specific scenarios where the current styling does not hold up.\r\n\r\nThis feature is a case of different implementations for mobile and desktop and this PR specifically addresses the desktop version. I'll open another one for mobile once I've gotten my emulator set up but at least wanted to get this out there for review, comment, and testing to see if others find this schema for displaying messages agreeable. \r\n\r\nOne aside for devs reviewing this PR is a question around the preferred method of running the test suite? It was ambiguous to me whether we are using lein for this or clj, so any background here from the last few months would be appreciated! Thanks!"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/442450642","html_url":"https://github.com/status-im/status-react/pull/6888#issuecomment-442450642","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6888","id":442450642,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjQ1MDY0Mg==","user":{"login":"EugeOrtiz","id":37297779,"node_id":"MDQ6VXNlcjM3Mjk3Nzc5","avatar_url":"https://avatars3.githubusercontent.com/u/37297779?v=4","gravatar_id":"","url":"https://api.github.com/users/EugeOrtiz","html_url":"https://github.com/EugeOrtiz","followers_url":"https://api.github.com/users/EugeOrtiz/followers","following_url":"https://api.github.com/users/EugeOrtiz/following{/other_user}","gists_url":"https://api.github.com/users/EugeOrtiz/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeOrtiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeOrtiz/subscriptions","organizations_url":"https://api.github.com/users/EugeOrtiz/orgs","repos_url":"https://api.github.com/users/EugeOrtiz/repos","events_url":"https://api.github.com/users/EugeOrtiz/events{/privacy}","received_events_url":"https://api.github.com/users/EugeOrtiz/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T13:42:25Z","updated_at":"2018-11-28T13:42:25Z","author_association":"NONE","body":"+1, they look better to the right. [Designs on Figma](https://www.figma.com/file/MRYBI5axcTwL4Ft8xAYhFOfy/Desktop-Chat?node-id=377%3A0)\r\n\r\nI also think the amounts we are showing are weird. What is the difference between saying 900, +4K or +10K? The idea is to say \"hey, you have a lot of unread messages here\", but I think we can convey that message with a max limit, e.g. +99. From there, it doesn't make much sense to be literal about the amount of messages you have, and also brings a lot of anxiety, because you'll never get to read those 10k messages anyway."}}
{"actor":{"display_login":"EugeOrtiz"}}