{"action":"closed","number":211,"pull_request":{"url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211","id":188119116,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MTE5MTE2","html_url":"https://github.com/crawler-commons/crawler-commons/pull/211","diff_url":"https://github.com/crawler-commons/crawler-commons/pull/211.diff","patch_url":"https://github.com/crawler-commons/crawler-commons/pull/211.patch","issue_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/211","number":211,"state":"closed","locked":false,"title":"Allow for legacy URIs when checking sitemap namespaces","user":{"login":"sebastian-nagel","id":1630582,"node_id":"MDQ6VXNlcjE2MzA1ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1630582?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-nagel","html_url":"https://github.com/sebastian-nagel","followers_url":"https://api.github.com/users/sebastian-nagel/followers","following_url":"https://api.github.com/users/sebastian-nagel/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-nagel/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-nagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-nagel/subscriptions","organizations_url":"https://api.github.com/users/sebastian-nagel/orgs","repos_url":"https://api.github.com/users/sebastian-nagel/repos","events_url":"https://api.github.com/users/sebastian-nagel/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-nagel/received_events","type":"User","site_admin":false},"body":"- e.g., allow legacy namespace URI but ignore URLs\r\n  from image and video sitemap extensions\r\n- resolve relative namespace URIs\r\n- add namespace URIs of sitemap extensions (news, images, videos)\r\n\r\nE.g., to check the namespace but allow legacy URIs and also sitemaps without a namespace declaration:\r\n```\r\nsitemapParser.setStrictNamespace(true);\r\nsitemapParser.addAcceptedNamespace(Namespace.SITEMAP_LEGACY);\r\nsitemapParser.addAcceptedNamespace(Namespace.EMPTY);\r\n```\r\n\r\nTo allow image URLs one could add\r\n```\r\nsitemapParser.addAcceptedNamespace(Namespace.IMAGE);\r\n```\r\nIt's also easy to add any other namespace URI.","created_at":"2018-05-15T12:57:12Z","updated_at":"2018-06-05T10:20:27Z","closed_at":"2018-06-05T10:20:27Z","merged_at":"2018-06-05T10:20:27Z","merge_commit_sha":"d98a3f14cfd7bab0cd32ee6313322b2bdabe840c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211/commits","review_comments_url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211/comments","review_comment_url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/211/comments","statuses_url":"https://api.github.com/repos/crawler-commons/crawler-commons/statuses/5126cc61d1952452caa31eaa10b396a2ab10f45f","head":{"label":"sebastian-nagel:cc-210-sitemap-legacy-namespace","ref":"cc-210-sitemap-legacy-namespace","sha":"5126cc61d1952452caa31eaa10b396a2ab10f45f","user":{"login":"sebastian-nagel","id":1630582,"node_id":"MDQ6VXNlcjE2MzA1ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1630582?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-nagel","html_url":"https://github.com/sebastian-nagel","followers_url":"https://api.github.com/users/sebastian-nagel/followers","following_url":"https://api.github.com/users/sebastian-nagel/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-nagel/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-nagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-nagel/subscriptions","organizations_url":"https://api.github.com/users/sebastian-nagel/orgs","repos_url":"https://api.github.com/users/sebastian-nagel/repos","events_url":"https://api.github.com/users/sebastian-nagel/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-nagel/received_events","type":"User","site_admin":false},"repo":{"id":62044859,"node_id":"MDEwOlJlcG9zaXRvcnk2MjA0NDg1OQ==","name":"crawler-commons","full_name":"sebastian-nagel/crawler-commons","owner":{"login":"sebastian-nagel","id":1630582,"node_id":"MDQ6VXNlcjE2MzA1ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1630582?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-nagel","html_url":"https://github.com/sebastian-nagel","followers_url":"https://api.github.com/users/sebastian-nagel/followers","following_url":"https://api.github.com/users/sebastian-nagel/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-nagel/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-nagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-nagel/subscriptions","organizations_url":"https://api.github.com/users/sebastian-nagel/orgs","repos_url":"https://api.github.com/users/sebastian-nagel/repos","events_url":"https://api.github.com/users/sebastian-nagel/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-nagel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastian-nagel/crawler-commons","description":"A set of reusable Java components that implement functionality common to any web crawler","fork":true,"url":"https://api.github.com/repos/sebastian-nagel/crawler-commons","forks_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/forks","keys_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/teams","hooks_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/hooks","issue_events_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/issues/events{/number}","events_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/events","assignees_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/assignees{/user}","branches_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/branches{/branch}","tags_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/tags","blobs_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/languages","stargazers_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/stargazers","contributors_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/contributors","subscribers_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/subscribers","subscription_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/subscription","commits_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/contents/{+path}","compare_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/merges","archive_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/downloads","issues_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/issues{/number}","pulls_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/labels{/name}","releases_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/releases{/id}","deployments_url":"https://api.github.com/repos/sebastian-nagel/crawler-commons/deployments","created_at":"2016-06-27T09:50:47Z","updated_at":"2018-05-15T09:43:40Z","pushed_at":"2018-06-05T10:11:44Z","git_url":"git://github.com/sebastian-nagel/crawler-commons.git","ssh_url":"git@github.com:sebastian-nagel/crawler-commons.git","clone_url":"https://github.com/sebastian-nagel/crawler-commons.git","svn_url":"https://github.com/sebastian-nagel/crawler-commons","homepage":"","size":2036,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crawler-commons:master","ref":"master","sha":"993c4fdb9e0e27d9d8884397c6fc741df36c792d","user":{"login":"crawler-commons","id":11871279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODcxMjc5","avatar_url":"https://avatars0.githubusercontent.com/u/11871279?v=4","gravatar_id":"","url":"https://api.github.com/users/crawler-commons","html_url":"https://github.com/crawler-commons","followers_url":"https://api.github.com/users/crawler-commons/followers","following_url":"https://api.github.com/users/crawler-commons/following{/other_user}","gists_url":"https://api.github.com/users/crawler-commons/gists{/gist_id}","starred_url":"https://api.github.com/users/crawler-commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawler-commons/subscriptions","organizations_url":"https://api.github.com/users/crawler-commons/orgs","repos_url":"https://api.github.com/users/crawler-commons/repos","events_url":"https://api.github.com/users/crawler-commons/events{/privacy}","received_events_url":"https://api.github.com/users/crawler-commons/received_events","type":"Organization","site_admin":false},"repo":{"id":33669215,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY2OTIxNQ==","name":"crawler-commons","full_name":"crawler-commons/crawler-commons","owner":{"login":"crawler-commons","id":11871279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODcxMjc5","avatar_url":"https://avatars0.githubusercontent.com/u/11871279?v=4","gravatar_id":"","url":"https://api.github.com/users/crawler-commons","html_url":"https://github.com/crawler-commons","followers_url":"https://api.github.com/users/crawler-commons/followers","following_url":"https://api.github.com/users/crawler-commons/following{/other_user}","gists_url":"https://api.github.com/users/crawler-commons/gists{/gist_id}","starred_url":"https://api.github.com/users/crawler-commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawler-commons/subscriptions","organizations_url":"https://api.github.com/users/crawler-commons/orgs","repos_url":"https://api.github.com/users/crawler-commons/repos","events_url":"https://api.github.com/users/crawler-commons/events{/privacy}","received_events_url":"https://api.github.com/users/crawler-commons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crawler-commons/crawler-commons","description":"A set of reusable Java components that implement functionality common to any web crawler","fork":false,"url":"https://api.github.com/repos/crawler-commons/crawler-commons","forks_url":"https://api.github.com/repos/crawler-commons/crawler-commons/forks","keys_url":"https://api.github.com/repos/crawler-commons/crawler-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crawler-commons/crawler-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crawler-commons/crawler-commons/teams","hooks_url":"https://api.github.com/repos/crawler-commons/crawler-commons/hooks","issue_events_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/events{/number}","events_url":"https://api.github.com/repos/crawler-commons/crawler-commons/events","assignees_url":"https://api.github.com/repos/crawler-commons/crawler-commons/assignees{/user}","branches_url":"https://api.github.com/repos/crawler-commons/crawler-commons/branches{/branch}","tags_url":"https://api.github.com/repos/crawler-commons/crawler-commons/tags","blobs_url":"https://api.github.com/repos/crawler-commons/crawler-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crawler-commons/crawler-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crawler-commons/crawler-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/crawler-commons/crawler-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crawler-commons/crawler-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/crawler-commons/crawler-commons/languages","stargazers_url":"https://api.github.com/repos/crawler-commons/crawler-commons/stargazers","contributors_url":"https://api.github.com/repos/crawler-commons/crawler-commons/contributors","subscribers_url":"https://api.github.com/repos/crawler-commons/crawler-commons/subscribers","subscription_url":"https://api.github.com/repos/crawler-commons/crawler-commons/subscription","commits_url":"https://api.github.com/repos/crawler-commons/crawler-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/crawler-commons/crawler-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/crawler-commons/crawler-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/crawler-commons/crawler-commons/contents/{+path}","compare_url":"https://api.github.com/repos/crawler-commons/crawler-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crawler-commons/crawler-commons/merges","archive_url":"https://api.github.com/repos/crawler-commons/crawler-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crawler-commons/crawler-commons/downloads","issues_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues{/number}","pulls_url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/crawler-commons/crawler-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/crawler-commons/crawler-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crawler-commons/crawler-commons/labels{/name}","releases_url":"https://api.github.com/repos/crawler-commons/crawler-commons/releases{/id}","deployments_url":"https://api.github.com/repos/crawler-commons/crawler-commons/deployments","created_at":"2015-04-09T13:05:29Z","updated_at":"2018-06-04T20:28:11Z","pushed_at":"2018-06-05T10:20:27Z","git_url":"git://github.com/crawler-commons/crawler-commons.git","ssh_url":"git@github.com:crawler-commons/crawler-commons.git","clone_url":"https://github.com/crawler-commons/crawler-commons.git","svn_url":"https://github.com/crawler-commons/crawler-commons","homepage":"","size":2535,"stargazers_count":108,"watchers_count":108,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":41,"open_issues":22,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211"},"html":{"href":"https://github.com/crawler-commons/crawler-commons/pull/211"},"issue":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/211"},"comments":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/crawler-commons/crawler-commons/statuses/5126cc61d1952452caa31eaa10b396a2ab10f45f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jnioche","id":218319,"node_id":"MDQ6VXNlcjIxODMxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/218319?v=4","gravatar_id":"","url":"https://api.github.com/users/jnioche","html_url":"https://github.com/jnioche","followers_url":"https://api.github.com/users/jnioche/followers","following_url":"https://api.github.com/users/jnioche/following{/other_user}","gists_url":"https://api.github.com/users/jnioche/gists{/gist_id}","starred_url":"https://api.github.com/users/jnioche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnioche/subscriptions","organizations_url":"https://api.github.com/users/jnioche/orgs","repos_url":"https://api.github.com/users/jnioche/repos","events_url":"https://api.github.com/users/jnioche/events{/privacy}","received_events_url":"https://api.github.com/users/jnioche/received_events","type":"User","site_admin":false},"comments":0,"review_comments":6,"maintainer_can_modify":false,"commits":2,"additions":161,"deletions":24,"changed_files":6}}
{"actor":{"display_login":"jnioche"}}