{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/1098","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/1098/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/1098/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/1098/events","html_url":"https://github.com/Valloric/ycmd/pull/1098","id":356792636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTYzMDIx","number":1098,"title":"[READY] Update Go completer","user":{"login":"micbou","id":10026824,"node_id":"MDQ6VXNlcjEwMDI2ODI0","avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-09-04T12:44:41Z","updated_at":"2018-09-09T03:11:10Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/1098","html_url":"https://github.com/Valloric/ycmd/pull/1098","diff_url":"https://github.com/Valloric/ycmd/pull/1098.diff","patch_url":"https://github.com/Valloric/ycmd/pull/1098.patch"},"body":"As discussed in issue #1097, switch the Gocode version to [mdempsky's fork](https://github.com/mdempsky/gocode). This requires moving the Gocode submodule to `third_party/go/src/github.com/mdempsky/gocode` and setting `GOPATH` to `third_party/go` when building Gocode. Do the same for Godef. This way, using [Manishearth's fork](https://github.com/Manishearth/godef) is not needed anymore.\r\n\r\nThe following changes to the Go completer are required with this new version of Gocode:\r\n - the `status` endpoint has been removed so the server is now assumed to be healthy if it's running;\r\n - the `null` response is returned when there are no completions.\r\n\r\nCloses #1090.\r\nCloses #1092.\r\nCloses #1097.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/1098)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/419687516","html_url":"https://github.com/Valloric/ycmd/pull/1098#issuecomment-419687516","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/1098","id":419687516,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTY4NzUxNg==","user":{"login":"zzbot","id":28640366,"node_id":"MDQ6VXNlcjI4NjQwMzY2","avatar_url":"https://avatars1.githubusercontent.com/u/28640366?v=4","gravatar_id":"","url":"https://api.github.com/users/zzbot","html_url":"https://github.com/zzbot","followers_url":"https://api.github.com/users/zzbot/followers","following_url":"https://api.github.com/users/zzbot/following{/other_user}","gists_url":"https://api.github.com/users/zzbot/gists{/gist_id}","starred_url":"https://api.github.com/users/zzbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzbot/subscriptions","organizations_url":"https://api.github.com/users/zzbot/orgs","repos_url":"https://api.github.com/users/zzbot/repos","events_url":"https://api.github.com/users/zzbot/events{/privacy}","received_events_url":"https://api.github.com/users/zzbot/received_events","type":"User","site_admin":false},"created_at":"2018-09-09T03:11:10Z","updated_at":"2018-09-09T03:11:10Z","author_association":"COLLABORATOR","body":":sunny: Test successful - [status-appveyor](https://ci.appveyor.com/project/Valloric/ycmd/build/4076), [status-travis](https://travis-ci.org/Valloric/ycmd/builds/426237191?utm_source=github_status&utm_medium=notification)\nApproved by: micbou\nPushing 10dc665ee5a8097b17424ebf7d27b069c60228c8 to master..."}}
{"actor":{"display_login":"zzbot"}}