{"action":"opened","number":323,"pull_request":{"url":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323","id":220925767,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTI1NzY3","html_url":"https://github.com/tpope/vim-fireplace/pull/323","diff_url":"https://github.com/tpope/vim-fireplace/pull/323.diff","patch_url":"https://github.com/tpope/vim-fireplace/pull/323.patch","issue_url":"https://api.github.com/repos/tpope/vim-fireplace/issues/323","number":323,"state":"open","locked":false,"title":"fix a few hangs due to missing terminators","user":{"login":"raymond-w-ko","id":855478,"node_id":"MDQ6VXNlcjg1NTQ3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/855478?v=4","gravatar_id":"","url":"https://api.github.com/users/raymond-w-ko","html_url":"https://github.com/raymond-w-ko","followers_url":"https://api.github.com/users/raymond-w-ko/followers","following_url":"https://api.github.com/users/raymond-w-ko/following{/other_user}","gists_url":"https://api.github.com/users/raymond-w-ko/gists{/gist_id}","starred_url":"https://api.github.com/users/raymond-w-ko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymond-w-ko/subscriptions","organizations_url":"https://api.github.com/users/raymond-w-ko/orgs","repos_url":"https://api.github.com/users/raymond-w-ko/repos","events_url":"https://api.github.com/users/raymond-w-ko/events{/privacy}","received_events_url":"https://api.github.com/users/raymond-w-ko/received_events","type":"User","site_admin":false},"body":"Like many other people I keep getting unexplainable hangs, so I decided to do some debugging. It turns out that vim-fireplace expects a `status: [\"done\"]` inside the return message as a terminator, but there are  last messages returned that don't have this.\r\n\r\nSo far I found 2:\r\n1. If you break something during a `:Require`, like a wrong symbol, It tries to fetch a strack trace, which returns one with this terminator.\r\n2. Randomly (?) it tries to return this packet as the last message:\r\n```\r\nRESPONSE:\r\n{'changed-namespaces': {},\r\n 'id': 'fireplace-hostname-1538883267-20',\r\n 'repl-type': 'clj',\r\n 'session': '2b7e5a1e-748b-40c9-b65e-9a9b2c7c49a2',\r\n}\r\n```\r\n\r\nI am using cider-nrepl 0.18.0 if that makes a difference.\r\n\r\nI am not sure what is the \"truly correct\" way, but the fix seems simple and safe enough. The truly correct way seems to be rewrite vim-fireplace using a persistent connection and command stream, but that really hard / impossible to do...\r\n\r\nThis patch detects these message and places the missing response if there is not a status.","created_at":"2018-10-07T03:58:15Z","updated_at":"2018-10-07T03:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323/commits","review_comments_url":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323/comments","review_comment_url":"https://api.github.com/repos/tpope/vim-fireplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tpope/vim-fireplace/issues/323/comments","statuses_url":"https://api.github.com/repos/tpope/vim-fireplace/statuses/576137df1e426a85be8d22c9ebfc4ea0ce373fd4","head":{"label":"raymond-w-ko:fix-hangs","ref":"fix-hangs","sha":"576137df1e426a85be8d22c9ebfc4ea0ce373fd4","user":{"login":"raymond-w-ko","id":855478,"node_id":"MDQ6VXNlcjg1NTQ3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/855478?v=4","gravatar_id":"","url":"https://api.github.com/users/raymond-w-ko","html_url":"https://github.com/raymond-w-ko","followers_url":"https://api.github.com/users/raymond-w-ko/followers","following_url":"https://api.github.com/users/raymond-w-ko/following{/other_user}","gists_url":"https://api.github.com/users/raymond-w-ko/gists{/gist_id}","starred_url":"https://api.github.com/users/raymond-w-ko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymond-w-ko/subscriptions","organizations_url":"https://api.github.com/users/raymond-w-ko/orgs","repos_url":"https://api.github.com/users/raymond-w-ko/repos","events_url":"https://api.github.com/users/raymond-w-ko/events{/privacy}","received_events_url":"https://api.github.com/users/raymond-w-ko/received_events","type":"User","site_admin":false},"repo":{"id":151664033,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2NjQwMzM=","name":"vim-fireplace","full_name":"raymond-w-ko/vim-fireplace","private":false,"owner":{"login":"raymond-w-ko","id":855478,"node_id":"MDQ6VXNlcjg1NTQ3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/855478?v=4","gravatar_id":"","url":"https://api.github.com/users/raymond-w-ko","html_url":"https://github.com/raymond-w-ko","followers_url":"https://api.github.com/users/raymond-w-ko/followers","following_url":"https://api.github.com/users/raymond-w-ko/following{/other_user}","gists_url":"https://api.github.com/users/raymond-w-ko/gists{/gist_id}","starred_url":"https://api.github.com/users/raymond-w-ko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymond-w-ko/subscriptions","organizations_url":"https://api.github.com/users/raymond-w-ko/orgs","repos_url":"https://api.github.com/users/raymond-w-ko/repos","events_url":"https://api.github.com/users/raymond-w-ko/events{/privacy}","received_events_url":"https://api.github.com/users/raymond-w-ko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raymond-w-ko/vim-fireplace","description":"fireplace.vim: Clojure REPL support","fork":true,"url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace","forks_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/forks","keys_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/teams","hooks_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/hooks","issue_events_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/events","assignees_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/tags","blobs_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/languages","stargazers_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/stargazers","contributors_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/contributors","subscribers_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/subscribers","subscription_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/subscription","commits_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/merges","archive_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/downloads","issues_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/labels{/name}","releases_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/releases{/id}","deployments_url":"https://api.github.com/repos/raymond-w-ko/vim-fireplace/deployments","created_at":"2018-10-05T03:01:36Z","updated_at":"2018-10-07T03:44:50Z","pushed_at":"2018-10-07T03:48:40Z","git_url":"git://github.com/raymond-w-ko/vim-fireplace.git","ssh_url":"git@github.com:raymond-w-ko/vim-fireplace.git","clone_url":"https://github.com/raymond-w-ko/vim-fireplace.git","svn_url":"https://github.com/raymond-w-ko/vim-fireplace","homepage":"http://www.vim.org/scripts/script.php?script_id=4978","size":712,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tpope:master","ref":"master","sha":"1ef0f0726cadd96547a5f79103b66339f170da02","user":{"login":"tpope","id":378,"node_id":"MDQ6VXNlcjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/378?v=4","gravatar_id":"","url":"https://api.github.com/users/tpope","html_url":"https://github.com/tpope","followers_url":"https://api.github.com/users/tpope/followers","following_url":"https://api.github.com/users/tpope/following{/other_user}","gists_url":"https://api.github.com/users/tpope/gists{/gist_id}","starred_url":"https://api.github.com/users/tpope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpope/subscriptions","organizations_url":"https://api.github.com/users/tpope/orgs","repos_url":"https://api.github.com/users/tpope/repos","events_url":"https://api.github.com/users/tpope/events{/privacy}","received_events_url":"https://api.github.com/users/tpope/received_events","type":"User","site_admin":false},"repo":{"id":6994356,"node_id":"MDEwOlJlcG9zaXRvcnk2OTk0MzU2","name":"vim-fireplace","full_name":"tpope/vim-fireplace","private":false,"owner":{"login":"tpope","id":378,"node_id":"MDQ6VXNlcjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/378?v=4","gravatar_id":"","url":"https://api.github.com/users/tpope","html_url":"https://github.com/tpope","followers_url":"https://api.github.com/users/tpope/followers","following_url":"https://api.github.com/users/tpope/following{/other_user}","gists_url":"https://api.github.com/users/tpope/gists{/gist_id}","starred_url":"https://api.github.com/users/tpope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpope/subscriptions","organizations_url":"https://api.github.com/users/tpope/orgs","repos_url":"https://api.github.com/users/tpope/repos","events_url":"https://api.github.com/users/tpope/events{/privacy}","received_events_url":"https://api.github.com/users/tpope/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tpope/vim-fireplace","description":"fireplace.vim: Clojure REPL support","fork":false,"url":"https://api.github.com/repos/tpope/vim-fireplace","forks_url":"https://api.github.com/repos/tpope/vim-fireplace/forks","keys_url":"https://api.github.com/repos/tpope/vim-fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpope/vim-fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpope/vim-fireplace/teams","hooks_url":"https://api.github.com/repos/tpope/vim-fireplace/hooks","issue_events_url":"https://api.github.com/repos/tpope/vim-fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/tpope/vim-fireplace/events","assignees_url":"https://api.github.com/repos/tpope/vim-fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/tpope/vim-fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/tpope/vim-fireplace/tags","blobs_url":"https://api.github.com/repos/tpope/vim-fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpope/vim-fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpope/vim-fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpope/vim-fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpope/vim-fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/tpope/vim-fireplace/languages","stargazers_url":"https://api.github.com/repos/tpope/vim-fireplace/stargazers","contributors_url":"https://api.github.com/repos/tpope/vim-fireplace/contributors","subscribers_url":"https://api.github.com/repos/tpope/vim-fireplace/subscribers","subscription_url":"https://api.github.com/repos/tpope/vim-fireplace/subscription","commits_url":"https://api.github.com/repos/tpope/vim-fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpope/vim-fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpope/vim-fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpope/vim-fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpope/vim-fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/tpope/vim-fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpope/vim-fireplace/merges","archive_url":"https://api.github.com/repos/tpope/vim-fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpope/vim-fireplace/downloads","issues_url":"https://api.github.com/repos/tpope/vim-fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/tpope/vim-fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/tpope/vim-fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/tpope/vim-fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpope/vim-fireplace/labels{/name}","releases_url":"https://api.github.com/repos/tpope/vim-fireplace/releases{/id}","deployments_url":"https://api.github.com/repos/tpope/vim-fireplace/deployments","created_at":"2012-12-04T04:30:48Z","updated_at":"2018-09-30T02:17:07Z","pushed_at":"2018-06-01T19:08:32Z","git_url":"git://github.com/tpope/vim-fireplace.git","ssh_url":"git@github.com:tpope/vim-fireplace.git","clone_url":"https://github.com/tpope/vim-fireplace.git","svn_url":"https://github.com/tpope/vim-fireplace","homepage":"http://www.vim.org/scripts/script.php?script_id=4978","size":708,"stargazers_count":1370,"watchers_count":1370,"language":"Vim script","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":42,"license":null,"forks":121,"open_issues":42,"watchers":1370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323"},"html":{"href":"https://github.com/tpope/vim-fireplace/pull/323"},"issue":{"href":"https://api.github.com/repos/tpope/vim-fireplace/issues/323"},"comments":{"href":"https://api.github.com/repos/tpope/vim-fireplace/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/tpope/vim-fireplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tpope/vim-fireplace/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/tpope/vim-fireplace/statuses/576137df1e426a85be8d22c9ebfc4ea0ce373fd4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"raymond-w-ko"}}