{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/comments/197796113","pull_request_review_id":131602358,"id":197796113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc5NjExMw==","diff_hunk":"@@ -96,13 +114,22 @@ def generate(common_name, alt_names)\n       '-out', @ssl_paths[:server_csr], '-config', @ssl_paths[:server_config]\n     )\n \n-    RMT::Execute.on_target!(\n-      'openssl', 'x509', '-req', '-in', @ssl_paths[:server_csr], '-out', @ssl_paths[:server_certificate],\n-      '-CA', @ssl_paths[:ca_certificate], '-CAkey', @ssl_paths[:ca_private_key],\n-      '-days', OPENSSL_SERVER_CERT_VALIDITY_DAYS, '-sha256',\n-      '-CAcreateserial',\n-      '-extensions', 'v3_server_sign', '-extfile', @ssl_paths[:server_config]\n-    )\n+    if !ca_password.empty?\n+      RMT::Execute.on_target!(\n+        'openssl', 'x509', '-req', '-in', @ssl_paths[:server_csr], '-out', @ssl_paths[:server_certificate],\n+        '-CA', @ssl_paths[:ca_certificate], '-CAkey', @ssl_paths[:ca_private_key],\n+        '-passin', 'stdin', '-days', OPENSSL_SERVER_CERT_VALIDITY_DAYS, '-sha256',\n+        '-CAcreateserial', '-extensions', 'v3_server_sign', '-extfile', @ssl_paths[:server_config],\n+        stdin: ca_password\n+      )\n+    else\n+      RMT::Execute.on_target!(\n+        'openssl', 'x509', '-req', '-in', @ssl_paths[:server_csr], '-out', @ssl_paths[:server_certificate],\n+        '-CA', @ssl_paths[:ca_certificate], '-CAkey', @ssl_paths[:ca_private_key],\n+        '-days', OPENSSL_SERVER_CERT_VALIDITY_DAYS, '-sha256',\n+        '-CAcreateserial', '-extensions', 'v3_server_sign', '-extfile', @ssl_paths[:server_config]\n+      )","path":"src/lib/rmt/ssl/certificate_generator.rb","position":79,"original_position":79,"commit_id":"5a9de6c1f4db69abd452184e2f50ab55392784d3","original_commit_id":"5a9de6c1f4db69abd452184e2f50ab55392784d3","user":{"login":"ikapelyukhin","id":1793699,"node_id":"MDQ6VXNlcjE3OTM2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1793699?v=4","gravatar_id":"","url":"https://api.github.com/users/ikapelyukhin","html_url":"https://github.com/ikapelyukhin","followers_url":"https://api.github.com/users/ikapelyukhin/followers","following_url":"https://api.github.com/users/ikapelyukhin/following{/other_user}","gists_url":"https://api.github.com/users/ikapelyukhin/gists{/gist_id}","starred_url":"https://api.github.com/users/ikapelyukhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikapelyukhin/subscriptions","organizations_url":"https://api.github.com/users/ikapelyukhin/orgs","repos_url":"https://api.github.com/users/ikapelyukhin/repos","events_url":"https://api.github.com/users/ikapelyukhin/events{/privacy}","received_events_url":"https://api.github.com/users/ikapelyukhin/received_events","type":"User","site_admin":false},"body":"Seems like this code isn't reachable, since it is not possible to input an empty password in the dialog.\r\nIf that's the case, it should be removed (we don't need CAs with empty passwords).","created_at":"2018-06-25T13:31:25Z","updated_at":"2018-06-25T13:32:13Z","html_url":"https://github.com/SUSE/yast2-rmt/pull/19#discussion_r197796113","pull_request_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/comments/197796113"},"html":{"href":"https://github.com/SUSE/yast2-rmt/pull/19#discussion_r197796113"},"pull_request":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19","id":193057121,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDU3MTIx","html_url":"https://github.com/SUSE/yast2-rmt/pull/19","diff_url":"https://github.com/SUSE/yast2-rmt/pull/19.diff","patch_url":"https://github.com/SUSE/yast2-rmt/pull/19.patch","issue_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/19","number":19,"state":"open","locked":false,"title":"Implement setting & validating CA private key password","user":{"login":"Sergeykot","id":892391,"node_id":"MDQ6VXNlcjg5MjM5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/892391?v=4","gravatar_id":"","url":"https://api.github.com/users/Sergeykot","html_url":"https://github.com/Sergeykot","followers_url":"https://api.github.com/users/Sergeykot/followers","following_url":"https://api.github.com/users/Sergeykot/following{/other_user}","gists_url":"https://api.github.com/users/Sergeykot/gists{/gist_id}","starred_url":"https://api.github.com/users/Sergeykot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sergeykot/subscriptions","organizations_url":"https://api.github.com/users/Sergeykot/orgs","repos_url":"https://api.github.com/users/Sergeykot/repos","events_url":"https://api.github.com/users/Sergeykot/events{/privacy}","received_events_url":"https://api.github.com/users/Sergeykot/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-06T15:40:23Z","updated_at":"2018-06-25T13:32:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c496bd3a7a7881d1c61849d3be3911f796d2f0e6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lslezak","id":907998,"node_id":"MDQ6VXNlcjkwNzk5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/907998?v=4","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},{"login":"felixsch","id":4460715,"node_id":"MDQ6VXNlcjQ0NjA3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4460715?v=4","gravatar_id":"","url":"https://api.github.com/users/felixsch","html_url":"https://github.com/felixsch","followers_url":"https://api.github.com/users/felixsch/followers","following_url":"https://api.github.com/users/felixsch/following{/other_user}","gists_url":"https://api.github.com/users/felixsch/gists{/gist_id}","starred_url":"https://api.github.com/users/felixsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixsch/subscriptions","organizations_url":"https://api.github.com/users/felixsch/orgs","repos_url":"https://api.github.com/users/felixsch/repos","events_url":"https://api.github.com/users/felixsch/events{/privacy}","received_events_url":"https://api.github.com/users/felixsch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19/commits","review_comments_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19/comments","review_comment_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/19/comments","statuses_url":"https://api.github.com/repos/SUSE/yast2-rmt/statuses/5a9de6c1f4db69abd452184e2f50ab55392784d3","head":{"label":"SUSE:ca_password","ref":"ca_password","sha":"5a9de6c1f4db69abd452184e2f50ab55392784d3","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":119535402,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1MzU0MDI=","name":"yast2-rmt","full_name":"SUSE/yast2-rmt","owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/yast2-rmt","description":"Yast module for configuring RMT","fork":false,"url":"https://api.github.com/repos/SUSE/yast2-rmt","forks_url":"https://api.github.com/repos/SUSE/yast2-rmt/forks","keys_url":"https://api.github.com/repos/SUSE/yast2-rmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/yast2-rmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/yast2-rmt/teams","hooks_url":"https://api.github.com/repos/SUSE/yast2-rmt/hooks","issue_events_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/yast2-rmt/events","assignees_url":"https://api.github.com/repos/SUSE/yast2-rmt/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/yast2-rmt/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/yast2-rmt/tags","blobs_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/yast2-rmt/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/yast2-rmt/languages","stargazers_url":"https://api.github.com/repos/SUSE/yast2-rmt/stargazers","contributors_url":"https://api.github.com/repos/SUSE/yast2-rmt/contributors","subscribers_url":"https://api.github.com/repos/SUSE/yast2-rmt/subscribers","subscription_url":"https://api.github.com/repos/SUSE/yast2-rmt/subscription","commits_url":"https://api.github.com/repos/SUSE/yast2-rmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/yast2-rmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/yast2-rmt/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/yast2-rmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/yast2-rmt/merges","archive_url":"https://api.github.com/repos/SUSE/yast2-rmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/yast2-rmt/downloads","issues_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/yast2-rmt/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/yast2-rmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/yast2-rmt/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/yast2-rmt/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/yast2-rmt/deployments","created_at":"2018-01-30T12:51:22Z","updated_at":"2018-06-22T14:36:57Z","pushed_at":"2018-06-22T16:59:28Z","git_url":"git://github.com/SUSE/yast2-rmt.git","ssh_url":"git@github.com:SUSE/yast2-rmt.git","clone_url":"https://github.com/SUSE/yast2-rmt.git","svn_url":"https://github.com/SUSE/yast2-rmt","homepage":"","size":206,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"2345b34cbedd639f0ff81d1f65572a9d0f940d60","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":119535402,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1MzU0MDI=","name":"yast2-rmt","full_name":"SUSE/yast2-rmt","owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/yast2-rmt","description":"Yast module for configuring RMT","fork":false,"url":"https://api.github.com/repos/SUSE/yast2-rmt","forks_url":"https://api.github.com/repos/SUSE/yast2-rmt/forks","keys_url":"https://api.github.com/repos/SUSE/yast2-rmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/yast2-rmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/yast2-rmt/teams","hooks_url":"https://api.github.com/repos/SUSE/yast2-rmt/hooks","issue_events_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/yast2-rmt/events","assignees_url":"https://api.github.com/repos/SUSE/yast2-rmt/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/yast2-rmt/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/yast2-rmt/tags","blobs_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/yast2-rmt/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/yast2-rmt/languages","stargazers_url":"https://api.github.com/repos/SUSE/yast2-rmt/stargazers","contributors_url":"https://api.github.com/repos/SUSE/yast2-rmt/contributors","subscribers_url":"https://api.github.com/repos/SUSE/yast2-rmt/subscribers","subscription_url":"https://api.github.com/repos/SUSE/yast2-rmt/subscription","commits_url":"https://api.github.com/repos/SUSE/yast2-rmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/yast2-rmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/yast2-rmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/yast2-rmt/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/yast2-rmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/yast2-rmt/merges","archive_url":"https://api.github.com/repos/SUSE/yast2-rmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/yast2-rmt/downloads","issues_url":"https://api.github.com/repos/SUSE/yast2-rmt/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/yast2-rmt/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/yast2-rmt/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/yast2-rmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/yast2-rmt/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/yast2-rmt/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/yast2-rmt/deployments","created_at":"2018-01-30T12:51:22Z","updated_at":"2018-06-22T14:36:57Z","pushed_at":"2018-06-22T16:59:28Z","git_url":"git://github.com/SUSE/yast2-rmt.git","ssh_url":"git@github.com:SUSE/yast2-rmt.git","clone_url":"https://github.com/SUSE/yast2-rmt.git","svn_url":"https://github.com/SUSE/yast2-rmt","homepage":"","size":206,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19"},"html":{"href":"https://github.com/SUSE/yast2-rmt/pull/19"},"issue":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/issues/19"},"comments":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/yast2-rmt/statuses/5a9de6c1f4db69abd452184e2f50ab55392784d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ikapelyukhin"}}