{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/214734247","pull_request_review_id":151849437,"id":214734247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDczNDI0Nw==","diff_hunk":"@@ -565,6 +565,7 @@ let any: any;\n   result = validator.isMultibyte('sample');\n \n   result = validator.isNumeric('sample');\n+  result = validator.isNumeric('+358', { no_symbols: true })","path":"types/validator/validator-tests.ts","position":4,"original_position":4,"commit_id":"b6d3f4ec83cec10a76388ff7eaf2dee1c155893f","original_commit_id":"b6d3f4ec83cec10a76388ff7eaf2dee1c155893f","user":{"login":"qqilihq","id":2172260,"node_id":"MDQ6VXNlcjIxNzIyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2172260?v=4","gravatar_id":"","url":"https://api.github.com/users/qqilihq","html_url":"https://github.com/qqilihq","followers_url":"https://api.github.com/users/qqilihq/followers","following_url":"https://api.github.com/users/qqilihq/following{/other_user}","gists_url":"https://api.github.com/users/qqilihq/gists{/gist_id}","starred_url":"https://api.github.com/users/qqilihq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qqilihq/subscriptions","organizations_url":"https://api.github.com/users/qqilihq/orgs","repos_url":"https://api.github.com/users/qqilihq/repos","events_url":"https://api.github.com/users/qqilihq/events{/privacy}","received_events_url":"https://api.github.com/users/qqilihq/received_events","type":"User","site_admin":false},"body":"Add trailing `;`","created_at":"2018-09-03T16:43:19Z","updated_at":"2018-09-03T16:43:44Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600#discussion_r214734247","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/214734247"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600#discussion_r214734247"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600","id":212738063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzM4MDYz","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28600","number":28600,"state":"open","locked":false,"title":"[@types/validator] Add no_symbols as option","user":{"login":"henrikra","id":12229968,"node_id":"MDQ6VXNlcjEyMjI5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/12229968?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikra","html_url":"https://github.com/henrikra","followers_url":"https://api.github.com/users/henrikra/followers","following_url":"https://api.github.com/users/henrikra/following{/other_user}","gists_url":"https://api.github.com/users/henrikra/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikra/subscriptions","organizations_url":"https://api.github.com/users/henrikra/orgs","repos_url":"https://api.github.com/users/henrikra/repos","events_url":"https://api.github.com/users/henrikra/events{/privacy}","received_events_url":"https://api.github.com/users/henrikra/received_events","type":"User","site_admin":false},"body":"Types for `validator` was missing `options` for function `isNumeric`\r\n\r\nHere is picture of documentation for `isNumeric`\r\n![image](https://user-images.githubusercontent.com/12229968/44987597-6b96da80-af90-11e8-8855-3f0de445cd47.png)\r\n\r\nHere is also implementation for that function: https://github.com/chriso/validator.js/blob/c192d7c442193d790f5497d92267931d48b2dbc8/src/lib/isNumeric.js","created_at":"2018-09-03T12:46:10Z","updated_at":"2018-09-03T16:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9c2b67a93581a14bc8224af1f5c137e723392d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":57534397,"node_id":"MDU6TGFiZWw1NzUzNDM5Nw==","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28600/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/b6d3f4ec83cec10a76388ff7eaf2dee1c155893f","head":{"label":"henrikra:master","ref":"master","sha":"b6d3f4ec83cec10a76388ff7eaf2dee1c155893f","user":{"login":"henrikra","id":12229968,"node_id":"MDQ6VXNlcjEyMjI5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/12229968?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikra","html_url":"https://github.com/henrikra","followers_url":"https://api.github.com/users/henrikra/followers","following_url":"https://api.github.com/users/henrikra/following{/other_user}","gists_url":"https://api.github.com/users/henrikra/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikra/subscriptions","organizations_url":"https://api.github.com/users/henrikra/orgs","repos_url":"https://api.github.com/users/henrikra/repos","events_url":"https://api.github.com/users/henrikra/events{/privacy}","received_events_url":"https://api.github.com/users/henrikra/received_events","type":"User","site_admin":false},"repo":{"id":147202091,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMDIwOTE=","name":"DefinitelyTyped","full_name":"henrikra/DefinitelyTyped","owner":{"login":"henrikra","id":12229968,"node_id":"MDQ6VXNlcjEyMjI5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/12229968?v=4","gravatar_id":"","url":"https://api.github.com/users/henrikra","html_url":"https://github.com/henrikra","followers_url":"https://api.github.com/users/henrikra/followers","following_url":"https://api.github.com/users/henrikra/following{/other_user}","gists_url":"https://api.github.com/users/henrikra/gists{/gist_id}","starred_url":"https://api.github.com/users/henrikra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrikra/subscriptions","organizations_url":"https://api.github.com/users/henrikra/orgs","repos_url":"https://api.github.com/users/henrikra/repos","events_url":"https://api.github.com/users/henrikra/events{/privacy}","received_events_url":"https://api.github.com/users/henrikra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henrikra/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/henrikra/DefinitelyTyped","forks_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/henrikra/DefinitelyTyped/deployments","created_at":"2018-09-03T12:29:34Z","updated_at":"2018-09-03T12:39:08Z","pushed_at":"2018-09-03T12:38:58Z","git_url":"git://github.com/henrikra/DefinitelyTyped.git","ssh_url":"git@github.com:henrikra/DefinitelyTyped.git","clone_url":"https://github.com/henrikra/DefinitelyTyped.git","svn_url":"https://github.com/henrikra/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":351431,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"6ef608b70cdeae831fbc64c2ff8e8fa832bc51f8","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-09-03T14:44:58Z","pushed_at":"2018-09-03T15:19:04Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":353533,"stargazers_count":17205,"watchers_count":17205,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14366,"mirror_url":null,"archived":false,"open_issues_count":2369,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14366,"open_issues":2369,"watchers":17205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28600"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28600"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28600/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28600/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/b6d3f4ec83cec10a76388ff7eaf2dee1c155893f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qqilihq"}}