{"action":"created","comment":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/230900655","pull_request_review_id":171745456,"id":230900655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDkwMDY1NQ==","diff_hunk":"@@ -0,0 +1,25 @@\n+# Directly copied from github.com/logrotate/logrotate/blob/master/examples/logrotate.conf","path":"package/common_init/overlay/etc/logrotate.conf","position":1,"original_position":1,"commit_id":"1277e5f77de8e75657441b4a990b150a05dcdc77","original_commit_id":"1277e5f77de8e75657441b4a990b150a05dcdc77","user":{"login":"silverjam","id":183436,"node_id":"MDQ6VXNlcjE4MzQzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/183436?v=4","gravatar_id":"","url":"https://api.github.com/users/silverjam","html_url":"https://github.com/silverjam","followers_url":"https://api.github.com/users/silverjam/followers","following_url":"https://api.github.com/users/silverjam/following{/other_user}","gists_url":"https://api.github.com/users/silverjam/gists{/gist_id}","starred_url":"https://api.github.com/users/silverjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverjam/subscriptions","organizations_url":"https://api.github.com/users/silverjam/orgs","repos_url":"https://api.github.com/users/silverjam/repos","events_url":"https://api.github.com/users/silverjam/events{/privacy}","received_events_url":"https://api.github.com/users/silverjam/received_events","type":"User","site_admin":false},"body":"I think it makes sense to turn off the rotation of `/var/log/messages` from syslogd and control it here, we'll need to turn it off by creating `/etc/defaul/logging` and adding `-s 0` to configure syslogd accordingly:\r\n\r\n```\r\n BusyBox v1.27.2 (2018-10-10 14:08:34 PDT) multi-call binary.\r\n\r\nUsage: syslogd [OPTIONS]\r\n\r\nSystem logging utility\r\n\r\n        -n              Run in foreground\r\n        -R HOST[:PORT]  Log to HOST:PORT (default PORT:514)\r\n        -L              Log locally and via network (default is network only if -R)\r\n        -C[size_kb]     Log to shared mem buffer (use logread to read it)\r\n        -K              Log to kernel printk buffer (use dmesg to read it)\r\n        -O FILE         Log to FILE (default: /var/log/messages, stdout if -)\r\n        -s SIZE         Max size (KB) before rotation (default 200KB, 0=off)\r\n        -b N            N rotated logs to keep (default 1, max 99, 0=purge)\r\n        -l N            Log only messages more urgent than prio N (1-8)\r\n        -S              Smaller output\r\n        -D              Drop duplicates\r\n        -f FILE         Use FILE as config (default:/etc/syslog.conf)\r\n```","created_at":"2018-11-05T20:30:50Z","updated_at":"2018-11-05T20:30:51Z","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/981#discussion_r230900655","pull_request_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments/230900655"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/981#discussion_r230900655"},"pull_request":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981"}},"in_reply_to_id":230898914},"pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981","id":227718713,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzE4NzEz","html_url":"https://github.com/swift-nav/piksi_buildroot/pull/981","diff_url":"https://github.com/swift-nav/piksi_buildroot/pull/981.diff","patch_url":"https://github.com/swift-nav/piksi_buildroot/pull/981.patch","issue_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/981","number":981,"state":"open","locked":false,"title":"[WIP] Enable logrotate package and configure via init scripts and overlay [DEVC-1088]","user":{"login":"benjaminaltieri","id":5225320,"node_id":"MDQ6VXNlcjUyMjUzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5225320?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminaltieri","html_url":"https://github.com/benjaminaltieri","followers_url":"https://api.github.com/users/benjaminaltieri/followers","following_url":"https://api.github.com/users/benjaminaltieri/following{/other_user}","gists_url":"https://api.github.com/users/benjaminaltieri/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminaltieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminaltieri/subscriptions","organizations_url":"https://api.github.com/users/benjaminaltieri/orgs","repos_url":"https://api.github.com/users/benjaminaltieri/repos","events_url":"https://api.github.com/users/benjaminaltieri/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminaltieri/received_events","type":"User","site_admin":false},"body":"Addition of logrotate support with some hooking into exisiting log file creation infrastructure\r\n\r\nFeatures:\r\n * creation of confs for each template_*.sh log pair\r\n * overlay conf for metrics and resource packages\r\n * ping_log single file conf creation","created_at":"2018-11-01T18:41:57Z","updated_at":"2018-11-05T20:30:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72d86f288ed1b33a57eee2d039b8c44f4d9a9c98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981/commits","review_comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981/comments","review_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/981/comments","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/1277e5f77de8e75657441b4a990b150a05dcdc77","head":{"label":"swift-nav:benaltieri/logrotate_support","ref":"benaltieri/logrotate_support","sha":"1277e5f77de8e75657441b4a990b150a05dcdc77","user":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"node_id":"MDEwOlJlcG9zaXRvcnk2MjMzOTI3OA==","name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","private":false,"owner":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-11-01T19:15:47Z","pushed_at":"2018-11-05T20:06:32Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":9270,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":24,"open_issues":54,"watchers":6,"default_branch":"v2.0.0-release"}},"base":{"label":"swift-nav:master","ref":"master","sha":"d21cb0e9e91c05d503830129d507a2d2b1a72118","user":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":62339278,"node_id":"MDEwOlJlcG9zaXRvcnk2MjMzOTI3OA==","name":"piksi_buildroot","full_name":"swift-nav/piksi_buildroot","private":false,"owner":{"login":"swift-nav","id":1069835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjk4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1069835?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swift-nav/piksi_buildroot","description":"Tools for building Linux and the system image for Piksi Multi","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_buildroot","forks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_buildroot/deployments","created_at":"2016-06-30T20:09:21Z","updated_at":"2018-11-01T19:15:47Z","pushed_at":"2018-11-05T20:06:32Z","git_url":"git://github.com/swift-nav/piksi_buildroot.git","ssh_url":"git@github.com:swift-nav/piksi_buildroot.git","clone_url":"https://github.com/swift-nav/piksi_buildroot.git","svn_url":"https://github.com/swift-nav/piksi_buildroot","homepage":"http://www.swiftnav.com","size":9270,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":24,"open_issues":54,"watchers":6,"default_branch":"v2.0.0-release"}},"_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981"},"html":{"href":"https://github.com/swift-nav/piksi_buildroot/pull/981"},"issue":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/981"},"comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/issues/981/comments"},"review_comments":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981/comments"},"review_comment":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/pulls/981/commits"},"statuses":{"href":"https://api.github.com/repos/swift-nav/piksi_buildroot/statuses/1277e5f77de8e75657441b4a990b150a05dcdc77"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"silverjam"}}