{"action":"created","comment":{"url":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments/227994477","pull_request_review_id":168161394,"id":227994477,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzk5NDQ3Nw==","diff_hunk":"@@ -893,11 +899,42 @@ void AliAnalysisTaskEmcalJetPerformance::AllocateBackgroundHistograms()\n     histname = TString::Format(\"%s/BackgroundHistograms/hScaleFactorEMCal\", jets->GetArrayName().Data());\n     title = histname + \";Centrality;Scale factor;counts\";\n     fHistManager.CreateTH2(histname.Data(), title.Data(), 50, 0, 100, 100, 0, 5);\n-    \n     histname = TString::Format(\"%s/BackgroundHistograms/hDeltaPtEMCal\", jets->GetArrayName().Data());\n-    title = histname + \";Centrality (%);#delta#it{p}_{T} (GeV/#it{c});counts\";\n-    fHistManager.CreateTH2(histname.Data(), title.Data(), 10, 0, 100, 400, -50, 150);\n-    \n+    if (fForceBeamType == kAA) {\n+    \t\ttitle = histname + \";Centrality (%);#delta#it{p}_{T} (GeV/#it{c});counts\";\n+    \t\tfHistManager.CreateTH2(histname.Data(), title.Data(), 10, 0, 100, 400, -50, 150);","path":"PWGJE/EMCALJetTasks/UserTasks/AliAnalysisTaskEmcalJetPerformance.cxx","position":155,"original_position":155,"commit_id":"272d330062f740869844caded457b0ea61cb594a","original_commit_id":"272d330062f740869844caded457b0ea61cb594a","user":{"login":"jdmulligan","id":16219745,"node_id":"MDQ6VXNlcjE2MjE5NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/16219745?v=4","gravatar_id":"","url":"https://api.github.com/users/jdmulligan","html_url":"https://github.com/jdmulligan","followers_url":"https://api.github.com/users/jdmulligan/followers","following_url":"https://api.github.com/users/jdmulligan/following{/other_user}","gists_url":"https://api.github.com/users/jdmulligan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdmulligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdmulligan/subscriptions","organizations_url":"https://api.github.com/users/jdmulligan/orgs","repos_url":"https://api.github.com/users/jdmulligan/repos","events_url":"https://api.github.com/users/jdmulligan/events{/privacy}","received_events_url":"https://api.github.com/users/jdmulligan/received_events","type":"User","site_admin":false},"body":"Indentation again, please check all changes. And look through the PR on GitHub for these types of things before you make the PR!","created_at":"2018-10-24T23:35:47Z","updated_at":"2018-10-24T23:52:32Z","html_url":"https://github.com/alisw/AliPhysics/pull/7275#discussion_r227994477","pull_request_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments/227994477"},"html":{"href":"https://github.com/alisw/AliPhysics/pull/7275#discussion_r227994477"},"pull_request":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275"}}},"pull_request":{"url":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275","id":225581179,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTgxMTc5","html_url":"https://github.com/alisw/AliPhysics/pull/7275","diff_url":"https://github.com/alisw/AliPhysics/pull/7275.diff","patch_url":"https://github.com/alisw/AliPhysics/pull/7275.patch","issue_url":"https://api.github.com/repos/alisw/AliPhysics/issues/7275","number":7275,"state":"open","locked":false,"title":"- Changed binning of rho related histograms in Jet performance Task f…","user":{"login":"efranzis","id":19981326,"node_id":"MDQ6VXNlcjE5OTgxMzI2","avatar_url":"https://avatars0.githubusercontent.com/u/19981326?v=4","gravatar_id":"","url":"https://api.github.com/users/efranzis","html_url":"https://github.com/efranzis","followers_url":"https://api.github.com/users/efranzis/followers","following_url":"https://api.github.com/users/efranzis/following{/other_user}","gists_url":"https://api.github.com/users/efranzis/gists{/gist_id}","starred_url":"https://api.github.com/users/efranzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efranzis/subscriptions","organizations_url":"https://api.github.com/users/efranzis/orgs","repos_url":"https://api.github.com/users/efranzis/repos","events_url":"https://api.github.com/users/efranzis/events{/privacy}","received_events_url":"https://api.github.com/users/efranzis/received_events","type":"User","site_admin":false},"body":"…or pp and pPb\r\n\r\n- Changed !kpp to ==kAA check since we will study MB pPb collisions. If in the future pPb vs. centrality were to be analyzed this can be adapted.\r\n- Added a check to remove RandomCone overlaps with kT-jets from the fluctuations calculation\r\n- Added calculation of pure charged component background fluctuation\r\n- Changed check of full jets (in background fluctuation calculation) based on the jet container name\r\n\r\n\r\nPlease @jdmulligan have a look at all the changes and check.","created_at":"2018-10-24T23:29:34Z","updated_at":"2018-10-24T23:52:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8e9ae8f73e7cdde9b35e5a17288cb06a9d6337d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275/commits","review_comments_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275/comments","review_comment_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alisw/AliPhysics/issues/7275/comments","statuses_url":"https://api.github.com/repos/alisw/AliPhysics/statuses/272d330062f740869844caded457b0ea61cb594a","head":{"label":"efranzis:master","ref":"master","sha":"272d330062f740869844caded457b0ea61cb594a","user":{"login":"efranzis","id":19981326,"node_id":"MDQ6VXNlcjE5OTgxMzI2","avatar_url":"https://avatars0.githubusercontent.com/u/19981326?v=4","gravatar_id":"","url":"https://api.github.com/users/efranzis","html_url":"https://github.com/efranzis","followers_url":"https://api.github.com/users/efranzis/followers","following_url":"https://api.github.com/users/efranzis/following{/other_user}","gists_url":"https://api.github.com/users/efranzis/gists{/gist_id}","starred_url":"https://api.github.com/users/efranzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efranzis/subscriptions","organizations_url":"https://api.github.com/users/efranzis/orgs","repos_url":"https://api.github.com/users/efranzis/repos","events_url":"https://api.github.com/users/efranzis/events{/privacy}","received_events_url":"https://api.github.com/users/efranzis/received_events","type":"User","site_admin":false},"repo":{"id":89382429,"node_id":"MDEwOlJlcG9zaXRvcnk4OTM4MjQyOQ==","name":"AliPhysics","full_name":"efranzis/AliPhysics","private":false,"owner":{"login":"efranzis","id":19981326,"node_id":"MDQ6VXNlcjE5OTgxMzI2","avatar_url":"https://avatars0.githubusercontent.com/u/19981326?v=4","gravatar_id":"","url":"https://api.github.com/users/efranzis","html_url":"https://github.com/efranzis","followers_url":"https://api.github.com/users/efranzis/followers","following_url":"https://api.github.com/users/efranzis/following{/other_user}","gists_url":"https://api.github.com/users/efranzis/gists{/gist_id}","starred_url":"https://api.github.com/users/efranzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efranzis/subscriptions","organizations_url":"https://api.github.com/users/efranzis/orgs","repos_url":"https://api.github.com/users/efranzis/repos","events_url":"https://api.github.com/users/efranzis/events{/privacy}","received_events_url":"https://api.github.com/users/efranzis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/efranzis/AliPhysics","description":"ALICE Analysis Repository","fork":true,"url":"https://api.github.com/repos/efranzis/AliPhysics","forks_url":"https://api.github.com/repos/efranzis/AliPhysics/forks","keys_url":"https://api.github.com/repos/efranzis/AliPhysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efranzis/AliPhysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efranzis/AliPhysics/teams","hooks_url":"https://api.github.com/repos/efranzis/AliPhysics/hooks","issue_events_url":"https://api.github.com/repos/efranzis/AliPhysics/issues/events{/number}","events_url":"https://api.github.com/repos/efranzis/AliPhysics/events","assignees_url":"https://api.github.com/repos/efranzis/AliPhysics/assignees{/user}","branches_url":"https://api.github.com/repos/efranzis/AliPhysics/branches{/branch}","tags_url":"https://api.github.com/repos/efranzis/AliPhysics/tags","blobs_url":"https://api.github.com/repos/efranzis/AliPhysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efranzis/AliPhysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efranzis/AliPhysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/efranzis/AliPhysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efranzis/AliPhysics/statuses/{sha}","languages_url":"https://api.github.com/repos/efranzis/AliPhysics/languages","stargazers_url":"https://api.github.com/repos/efranzis/AliPhysics/stargazers","contributors_url":"https://api.github.com/repos/efranzis/AliPhysics/contributors","subscribers_url":"https://api.github.com/repos/efranzis/AliPhysics/subscribers","subscription_url":"https://api.github.com/repos/efranzis/AliPhysics/subscription","commits_url":"https://api.github.com/repos/efranzis/AliPhysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/efranzis/AliPhysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/efranzis/AliPhysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/efranzis/AliPhysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/efranzis/AliPhysics/contents/{+path}","compare_url":"https://api.github.com/repos/efranzis/AliPhysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efranzis/AliPhysics/merges","archive_url":"https://api.github.com/repos/efranzis/AliPhysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efranzis/AliPhysics/downloads","issues_url":"https://api.github.com/repos/efranzis/AliPhysics/issues{/number}","pulls_url":"https://api.github.com/repos/efranzis/AliPhysics/pulls{/number}","milestones_url":"https://api.github.com/repos/efranzis/AliPhysics/milestones{/number}","notifications_url":"https://api.github.com/repos/efranzis/AliPhysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efranzis/AliPhysics/labels{/name}","releases_url":"https://api.github.com/repos/efranzis/AliPhysics/releases{/id}","deployments_url":"https://api.github.com/repos/efranzis/AliPhysics/deployments","created_at":"2017-04-25T16:23:58Z","updated_at":"2018-10-24T23:25:31Z","pushed_at":"2018-10-24T23:24:54Z","git_url":"git://github.com/efranzis/AliPhysics.git","ssh_url":"git@github.com:efranzis/AliPhysics.git","clone_url":"https://github.com/efranzis/AliPhysics.git","svn_url":"https://github.com/efranzis/AliPhysics","homepage":"https://alisw.github.io/git-tutorial","size":739304,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alisw:master","ref":"master","sha":"f498e7a92773642f6031396bcc8f57a3b061a290","user":{"login":"alisw","id":12711103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzExMTAz","avatar_url":"https://avatars2.githubusercontent.com/u/12711103?v=4","gravatar_id":"","url":"https://api.github.com/users/alisw","html_url":"https://github.com/alisw","followers_url":"https://api.github.com/users/alisw/followers","following_url":"https://api.github.com/users/alisw/following{/other_user}","gists_url":"https://api.github.com/users/alisw/gists{/gist_id}","starred_url":"https://api.github.com/users/alisw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisw/subscriptions","organizations_url":"https://api.github.com/users/alisw/orgs","repos_url":"https://api.github.com/users/alisw/repos","events_url":"https://api.github.com/users/alisw/events{/privacy}","received_events_url":"https://api.github.com/users/alisw/received_events","type":"Organization","site_admin":false},"repo":{"id":61661378,"node_id":"MDEwOlJlcG9zaXRvcnk2MTY2MTM3OA==","name":"AliPhysics","full_name":"alisw/AliPhysics","private":false,"owner":{"login":"alisw","id":12711103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzExMTAz","avatar_url":"https://avatars2.githubusercontent.com/u/12711103?v=4","gravatar_id":"","url":"https://api.github.com/users/alisw","html_url":"https://github.com/alisw","followers_url":"https://api.github.com/users/alisw/followers","following_url":"https://api.github.com/users/alisw/following{/other_user}","gists_url":"https://api.github.com/users/alisw/gists{/gist_id}","starred_url":"https://api.github.com/users/alisw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisw/subscriptions","organizations_url":"https://api.github.com/users/alisw/orgs","repos_url":"https://api.github.com/users/alisw/repos","events_url":"https://api.github.com/users/alisw/events{/privacy}","received_events_url":"https://api.github.com/users/alisw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alisw/AliPhysics","description":"ALICE Analysis Repository","fork":false,"url":"https://api.github.com/repos/alisw/AliPhysics","forks_url":"https://api.github.com/repos/alisw/AliPhysics/forks","keys_url":"https://api.github.com/repos/alisw/AliPhysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alisw/AliPhysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alisw/AliPhysics/teams","hooks_url":"https://api.github.com/repos/alisw/AliPhysics/hooks","issue_events_url":"https://api.github.com/repos/alisw/AliPhysics/issues/events{/number}","events_url":"https://api.github.com/repos/alisw/AliPhysics/events","assignees_url":"https://api.github.com/repos/alisw/AliPhysics/assignees{/user}","branches_url":"https://api.github.com/repos/alisw/AliPhysics/branches{/branch}","tags_url":"https://api.github.com/repos/alisw/AliPhysics/tags","blobs_url":"https://api.github.com/repos/alisw/AliPhysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alisw/AliPhysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alisw/AliPhysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/alisw/AliPhysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alisw/AliPhysics/statuses/{sha}","languages_url":"https://api.github.com/repos/alisw/AliPhysics/languages","stargazers_url":"https://api.github.com/repos/alisw/AliPhysics/stargazers","contributors_url":"https://api.github.com/repos/alisw/AliPhysics/contributors","subscribers_url":"https://api.github.com/repos/alisw/AliPhysics/subscribers","subscription_url":"https://api.github.com/repos/alisw/AliPhysics/subscription","commits_url":"https://api.github.com/repos/alisw/AliPhysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/alisw/AliPhysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/alisw/AliPhysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/alisw/AliPhysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/alisw/AliPhysics/contents/{+path}","compare_url":"https://api.github.com/repos/alisw/AliPhysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alisw/AliPhysics/merges","archive_url":"https://api.github.com/repos/alisw/AliPhysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alisw/AliPhysics/downloads","issues_url":"https://api.github.com/repos/alisw/AliPhysics/issues{/number}","pulls_url":"https://api.github.com/repos/alisw/AliPhysics/pulls{/number}","milestones_url":"https://api.github.com/repos/alisw/AliPhysics/milestones{/number}","notifications_url":"https://api.github.com/repos/alisw/AliPhysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alisw/AliPhysics/labels{/name}","releases_url":"https://api.github.com/repos/alisw/AliPhysics/releases{/id}","deployments_url":"https://api.github.com/repos/alisw/AliPhysics/deployments","created_at":"2016-06-21T19:31:29Z","updated_at":"2018-10-24T16:12:29Z","pushed_at":"2018-10-24T23:29:35Z","git_url":"git://github.com/alisw/AliPhysics.git","ssh_url":"git@github.com:alisw/AliPhysics.git","clone_url":"https://github.com/alisw/AliPhysics.git","svn_url":"https://github.com/alisw/AliPhysics","homepage":"https://alisw.github.io/git-tutorial","size":772773,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":429,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":429,"open_issues":14,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275"},"html":{"href":"https://github.com/alisw/AliPhysics/pull/7275"},"issue":{"href":"https://api.github.com/repos/alisw/AliPhysics/issues/7275"},"comments":{"href":"https://api.github.com/repos/alisw/AliPhysics/issues/7275/comments"},"review_comments":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275/comments"},"review_comment":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/7275/commits"},"statuses":{"href":"https://api.github.com/repos/alisw/AliPhysics/statuses/272d330062f740869844caded457b0ea61cb594a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdmulligan"}}