{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/203095745","pull_request_review_id":137918810,"id":203095745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA5NTc0NQ==","diff_hunk":"@@ -356,20 +390,244 @@ impl HTMLImageElement {\n     }\n \n     /// <https://html.spec.whatwg.org/multipage/#update-the-source-set>\n-    fn update_source_set(&self) -> Vec<DOMString> {\n+    fn update_source_set(&self) {\n+        // Step 1\n+        *self.source_set.borrow_mut() = HTMLImageElement::new_source_set();\n+\n+        // Step 2\n         let elem = self.upcast::<Element>();\n-        // TODO: follow the algorithm\n-        let src = elem.get_string_attribute(&local_name!(\"src\"));\n-        if src.is_empty() {\n-            return vec![]\n+        let parent = elem.upcast::<Node>().GetParentElement();\n+        let is_parent_picture = match parent.clone() {\n+            Some(xparent) => xparent.is::<HTMLPictureElement>(),\n+            None => false\n+        };\n+        let nodes = parent.unwrap().upcast::<Node>().ChildNodes();","path":"components/script/dom/htmlimageelement.rs","position":132,"original_position":132,"commit_id":"af5cf3a54c0a6434fbc953a933788f84773d88c5","original_commit_id":"af5cf3a54c0a6434fbc953a933788f84773d88c5","user":{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"body":"What specific part of the code is the error message referring to?","created_at":"2018-07-17T16:43:26Z","updated_at":"2018-07-17T16:43:26Z","html_url":"https://github.com/servo/servo/pull/21181#discussion_r203095745","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/21181","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/203095745"},"html":{"href":"https://github.com/servo/servo/pull/21181#discussion_r203095745"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/21181"}},"in_reply_to_id":202869072},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21181","id":201512002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTEyMDAy","html_url":"https://github.com/servo/servo/pull/21181","diff_url":"https://github.com/servo/servo/pull/21181.diff","patch_url":"https://github.com/servo/servo/pull/21181.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/21181","number":21181,"state":"open","locked":false,"title":"Implement update source set & select image source","user":{"login":"nupurbaghel","id":20029578,"node_id":"MDQ6VXNlcjIwMDI5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/20029578?v=4","gravatar_id":"","url":"https://api.github.com/users/nupurbaghel","html_url":"https://github.com/nupurbaghel","followers_url":"https://api.github.com/users/nupurbaghel/followers","following_url":"https://api.github.com/users/nupurbaghel/following{/other_user}","gists_url":"https://api.github.com/users/nupurbaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/nupurbaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupurbaghel/subscriptions","organizations_url":"https://api.github.com/users/nupurbaghel/orgs","repos_url":"https://api.github.com/users/nupurbaghel/repos","events_url":"https://api.github.com/users/nupurbaghel/events{/privacy}","received_events_url":"https://api.github.com/users/nupurbaghel/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #11416 (github issue number if applicable).\r\n\r\n- [x] These changes require tests but cannot be written until implementation of responsive images is complete \r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21181)\n<!-- Reviewable:end -->\n","created_at":"2018-07-15T19:35:47Z","updated_at":"2018-07-17T16:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e483dd50c95a69107773d71f1a389afeb7aa50","assignee":{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"node_id":"MDQ6VXNlcjI3NjU4","avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":152310014,"node_id":"MDU6TGFiZWwxNTIzMTAwMTQ=","url":"https://api.github.com/repos/servo/servo/labels/S-needs-code-changes","name":"S-needs-code-changes","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/21181/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/21181/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/21181/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/af5cf3a54c0a6434fbc953a933788f84773d88c5","head":{"label":"nupurbaghel:update_source_set","ref":"update_source_set","sha":"af5cf3a54c0a6434fbc953a933788f84773d88c5","user":{"login":"nupurbaghel","id":20029578,"node_id":"MDQ6VXNlcjIwMDI5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/20029578?v=4","gravatar_id":"","url":"https://api.github.com/users/nupurbaghel","html_url":"https://github.com/nupurbaghel","followers_url":"https://api.github.com/users/nupurbaghel/followers","following_url":"https://api.github.com/users/nupurbaghel/following{/other_user}","gists_url":"https://api.github.com/users/nupurbaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/nupurbaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupurbaghel/subscriptions","organizations_url":"https://api.github.com/users/nupurbaghel/orgs","repos_url":"https://api.github.com/users/nupurbaghel/repos","events_url":"https://api.github.com/users/nupurbaghel/events{/privacy}","received_events_url":"https://api.github.com/users/nupurbaghel/received_events","type":"User","site_admin":false},"repo":{"id":120098438,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwOTg0Mzg=","name":"servo","full_name":"nupurbaghel/servo","owner":{"login":"nupurbaghel","id":20029578,"node_id":"MDQ6VXNlcjIwMDI5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/20029578?v=4","gravatar_id":"","url":"https://api.github.com/users/nupurbaghel","html_url":"https://github.com/nupurbaghel","followers_url":"https://api.github.com/users/nupurbaghel/followers","following_url":"https://api.github.com/users/nupurbaghel/following{/other_user}","gists_url":"https://api.github.com/users/nupurbaghel/gists{/gist_id}","starred_url":"https://api.github.com/users/nupurbaghel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupurbaghel/subscriptions","organizations_url":"https://api.github.com/users/nupurbaghel/orgs","repos_url":"https://api.github.com/users/nupurbaghel/repos","events_url":"https://api.github.com/users/nupurbaghel/events{/privacy}","received_events_url":"https://api.github.com/users/nupurbaghel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nupurbaghel/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/nupurbaghel/servo","forks_url":"https://api.github.com/repos/nupurbaghel/servo/forks","keys_url":"https://api.github.com/repos/nupurbaghel/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nupurbaghel/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nupurbaghel/servo/teams","hooks_url":"https://api.github.com/repos/nupurbaghel/servo/hooks","issue_events_url":"https://api.github.com/repos/nupurbaghel/servo/issues/events{/number}","events_url":"https://api.github.com/repos/nupurbaghel/servo/events","assignees_url":"https://api.github.com/repos/nupurbaghel/servo/assignees{/user}","branches_url":"https://api.github.com/repos/nupurbaghel/servo/branches{/branch}","tags_url":"https://api.github.com/repos/nupurbaghel/servo/tags","blobs_url":"https://api.github.com/repos/nupurbaghel/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nupurbaghel/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nupurbaghel/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nupurbaghel/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nupurbaghel/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/nupurbaghel/servo/languages","stargazers_url":"https://api.github.com/repos/nupurbaghel/servo/stargazers","contributors_url":"https://api.github.com/repos/nupurbaghel/servo/contributors","subscribers_url":"https://api.github.com/repos/nupurbaghel/servo/subscribers","subscription_url":"https://api.github.com/repos/nupurbaghel/servo/subscription","commits_url":"https://api.github.com/repos/nupurbaghel/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nupurbaghel/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nupurbaghel/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nupurbaghel/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nupurbaghel/servo/contents/{+path}","compare_url":"https://api.github.com/repos/nupurbaghel/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nupurbaghel/servo/merges","archive_url":"https://api.github.com/repos/nupurbaghel/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nupurbaghel/servo/downloads","issues_url":"https://api.github.com/repos/nupurbaghel/servo/issues{/number}","pulls_url":"https://api.github.com/repos/nupurbaghel/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/nupurbaghel/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/nupurbaghel/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nupurbaghel/servo/labels{/name}","releases_url":"https://api.github.com/repos/nupurbaghel/servo/releases{/id}","deployments_url":"https://api.github.com/repos/nupurbaghel/servo/deployments","created_at":"2018-02-03T14:29:48Z","updated_at":"2018-07-11T06:40:43Z","pushed_at":"2018-07-16T20:11:43Z","git_url":"git://github.com/nupurbaghel/servo.git","ssh_url":"git@github.com:nupurbaghel/servo.git","clone_url":"https://github.com/nupurbaghel/servo.git","svn_url":"https://github.com/nupurbaghel/servo","homepage":"https://servo.org/","size":388785,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"8eb2a53e20d2e27c811f79c19ec084533f7fb13e","user":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkwMjQz","name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2018-07-17T14:17:40Z","pushed_at":"2018-07-17T16:07:00Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":517636,"stargazers_count":11998,"watchers_count":11998,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1919,"mirror_url":null,"archived":false,"open_issues_count":2293,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1919,"open_issues":2293,"watchers":11998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/21181"},"html":{"href":"https://github.com/servo/servo/pull/21181"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/21181"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/21181/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/21181/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/21181/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/af5cf3a54c0a6434fbc953a933788f84773d88c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdm"}}