{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/186203692","pull_request_review_id":117746888,"id":186203692,"diff_hunk":"@@ -98,6 +98,14 @@ function get-cluster-ip-range {\n   echo \"${suggested_range}\"\n }\n \n+function get-alias-range-size() {","path":"cluster/gce/config-common.sh","position":null,"original_position":4,"commit_id":"86e63d3188e69c8f8258aa2291edb2aca98086c9","original_commit_id":"b54263354e23df18ed3785c20e28503df90aff10","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"body":"Done. ","created_at":"2018-05-04T20:07:06Z","updated_at":"2018-05-04T20:07:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/63114#discussion_r186203692","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/186203692"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63114#discussion_r186203692"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114"}},"in_reply_to_id":186002305},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114","id":183901194,"html_url":"https://github.com/kubernetes/kubernetes/pull/63114","diff_url":"https://github.com/kubernetes/kubernetes/pull/63114.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63114.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63114","number":63114,"state":"open","locked":false,"title":"Add MAX_PODS env allowing kubelet to be max-pods aware.","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAdd MAX_PODS env allowing kubelet to be max-pods aware. This env will be one of the argument of kubelet. By setting this parameter, correct number of pod capacity for the node will be reported.\r\n\r\n**Special notes for your reviewer**:\r\n/assign @MrHohn @jpbetz \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-04-25T00:55:13Z","updated_at":"2018-05-04T20:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4afcb839e35e52e7b30ffefd94415e263a21e71","assignee":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63114/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/86e63d3188e69c8f8258aa2291edb2aca98086c9","head":{"label":"grayluck:maxPodEnv","ref":"maxPodEnv","sha":"86e63d3188e69c8f8258aa2291edb2aca98086c9","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"repo":{"id":124442305,"name":"kubernetes","full_name":"grayluck/kubernetes","owner":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grayluck/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/grayluck/kubernetes","forks_url":"https://api.github.com/repos/grayluck/kubernetes/forks","keys_url":"https://api.github.com/repos/grayluck/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grayluck/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grayluck/kubernetes/teams","hooks_url":"https://api.github.com/repos/grayluck/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/grayluck/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/grayluck/kubernetes/events","assignees_url":"https://api.github.com/repos/grayluck/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/grayluck/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/grayluck/kubernetes/tags","blobs_url":"https://api.github.com/repos/grayluck/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grayluck/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grayluck/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/grayluck/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grayluck/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/grayluck/kubernetes/languages","stargazers_url":"https://api.github.com/repos/grayluck/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/grayluck/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/grayluck/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/grayluck/kubernetes/subscription","commits_url":"https://api.github.com/repos/grayluck/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/grayluck/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/grayluck/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/grayluck/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/grayluck/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/grayluck/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grayluck/kubernetes/merges","archive_url":"https://api.github.com/repos/grayluck/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grayluck/kubernetes/downloads","issues_url":"https://api.github.com/repos/grayluck/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/grayluck/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/grayluck/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/grayluck/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grayluck/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/grayluck/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/grayluck/kubernetes/deployments","created_at":"2018-03-08T20:07:39Z","updated_at":"2018-05-04T18:10:06Z","pushed_at":"2018-05-04T20:07:02Z","git_url":"git://github.com/grayluck/kubernetes.git","ssh_url":"git@github.com:grayluck/kubernetes.git","clone_url":"https://github.com/grayluck/kubernetes.git","svn_url":"https://github.com/grayluck/kubernetes","homepage":"http://kubernetes.io","size":555916,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5f5d4fd450ea086001f9f8a7b77605df0faff6d2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-04T19:44:30Z","pushed_at":"2018-05-04T20:06:20Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":775401,"stargazers_count":35907,"watchers_count":35907,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12660,"mirror_url":null,"archived":false,"open_issues_count":3344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12660,"open_issues":3344,"watchers":35907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/63114"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63114"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/63114/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63114/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/86e63d3188e69c8f8258aa2291edb2aca98086c9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grayluck"}}