{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1686","repository_url":"https://api.github.com/repos/apple/swift-corelibs-foundation","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1686/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1686/comments","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1686/events","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1686","id":358239776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDYwNzQz","number":1686,"title":"Fix unnecessary (and broken) preprocessor exclusion","user":{"login":"copumpkin","id":2623,"node_id":"MDQ6VXNlcjI2MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2623?v=4","gravatar_id":"","url":"https://api.github.com/users/copumpkin","html_url":"https://github.com/copumpkin","followers_url":"https://api.github.com/users/copumpkin/followers","following_url":"https://api.github.com/users/copumpkin/following{/other_user}","gists_url":"https://api.github.com/users/copumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/copumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copumpkin/subscriptions","organizations_url":"https://api.github.com/users/copumpkin/orgs","repos_url":"https://api.github.com/users/copumpkin/repos","events_url":"https://api.github.com/users/copumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/copumpkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T23:25:04Z","updated_at":"2018-09-11T16:58:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/1686","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1686","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/1686.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/1686.patch"},"body":"I'm not 100% sure this is the correct fix, but the `__nameStringOK` static function gets used even if `DEPLOYMENT_RUNTIME_SWIFT` is unset, so this just breaks the build (linkage) if this block of code gets excluded. It also just doesn't seem very Swift-specific, to my uneducated eye.\r\n\r\ncc @DougGregor or anyone willing to suggest a better fix"},"comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments/420344801","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/1686#issuecomment-420344801","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/1686","id":420344801,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDM0NDgwMQ==","user":{"login":"parkera","id":144462,"node_id":"MDQ6VXNlcjE0NDQ2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/144462?v=4","gravatar_id":"","url":"https://api.github.com/users/parkera","html_url":"https://github.com/parkera","followers_url":"https://api.github.com/users/parkera/followers","following_url":"https://api.github.com/users/parkera/following{/other_user}","gists_url":"https://api.github.com/users/parkera/gists{/gist_id}","starred_url":"https://api.github.com/users/parkera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkera/subscriptions","organizations_url":"https://api.github.com/users/parkera/orgs","repos_url":"https://api.github.com/users/parkera/repos","events_url":"https://api.github.com/users/parkera/events{/privacy}","received_events_url":"https://api.github.com/users/parkera/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T16:58:06Z","updated_at":"2018-09-11T16:58:06Z","author_association":"MEMBER","body":"LGTM"}}
{"actor":{"display_login":"parkera"}}