{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/177668174","pull_request_review_id":107569542,"id":177668174,"diff_hunk":"@@ -150,3 +164,122 @@ search:\n \t// during sealing so it's not unmapped while being read.\n \truntime.KeepAlive(dataset)\n }\n+\n+// remote starts a standalone goroutine to handle remote mining related stuff.\n+func (ethash *Ethash) remote(resultCh chan *types.Block) {","path":"consensus/ethash/sealer.go","position":73,"original_position":73,"commit_id":"cd478b82cc3a2173b00c63d35ec48cf2e268c90c","original_commit_id":"cd478b82cc3a2173b00c63d35ec48cf2e268c90c","user":{"login":"karalabe","id":129561,"avatar_url":"https://avatars2.githubusercontent.com/u/129561?v=4","gravatar_id":"","url":"https://api.github.com/users/karalabe","html_url":"https://github.com/karalabe","followers_url":"https://api.github.com/users/karalabe/followers","following_url":"https://api.github.com/users/karalabe/following{/other_user}","gists_url":"https://api.github.com/users/karalabe/gists{/gist_id}","starred_url":"https://api.github.com/users/karalabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karalabe/subscriptions","organizations_url":"https://api.github.com/users/karalabe/orgs","repos_url":"https://api.github.com/users/karalabe/repos","events_url":"https://api.github.com/users/karalabe/events{/privacy}","received_events_url":"https://api.github.com/users/karalabe/received_events","type":"User","site_admin":false},"body":"Do we even want to start this goroutine in the first place if there's no result channel?","created_at":"2018-03-28T08:07:52Z","updated_at":"2018-03-28T08:12:30Z","html_url":"https://github.com/ethereum/go-ethereum/pull/15853#discussion_r177668174","pull_request_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments/177668174"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/15853#discussion_r177668174"},"pull_request":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853"}},"in_reply_to_id":177668065},"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853","id":162296358,"html_url":"https://github.com/ethereum/go-ethereum/pull/15853","diff_url":"https://github.com/ethereum/go-ethereum/pull/15853.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/15853.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/15853","number":15853,"state":"open","locked":false,"title":"consensus/ethash: move remote agent logic to ethash internal","user":{"login":"rjl493456442","id":5959481,"avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-11T05:31:22Z","updated_at":"2018-03-28T08:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8997269558765a7dfe706bba79a43eea177d086","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/15853/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/cd478b82cc3a2173b00c63d35ec48cf2e268c90c","head":{"label":"rjl493456442:improve_miner","ref":"improve_miner","sha":"cd478b82cc3a2173b00c63d35ec48cf2e268c90c","user":{"login":"rjl493456442","id":5959481,"avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"repo":{"id":94566539,"name":"go-ethereum","full_name":"rjl493456442/go-ethereum","owner":{"login":"rjl493456442","id":5959481,"avatar_url":"https://avatars1.githubusercontent.com/u/5959481?v=4","gravatar_id":"","url":"https://api.github.com/users/rjl493456442","html_url":"https://github.com/rjl493456442","followers_url":"https://api.github.com/users/rjl493456442/followers","following_url":"https://api.github.com/users/rjl493456442/following{/other_user}","gists_url":"https://api.github.com/users/rjl493456442/gists{/gist_id}","starred_url":"https://api.github.com/users/rjl493456442/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjl493456442/subscriptions","organizations_url":"https://api.github.com/users/rjl493456442/orgs","repos_url":"https://api.github.com/users/rjl493456442/repos","events_url":"https://api.github.com/users/rjl493456442/events{/privacy}","received_events_url":"https://api.github.com/users/rjl493456442/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjl493456442/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/rjl493456442/go-ethereum","forks_url":"https://api.github.com/repos/rjl493456442/go-ethereum/forks","keys_url":"https://api.github.com/repos/rjl493456442/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjl493456442/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjl493456442/go-ethereum/teams","hooks_url":"https://api.github.com/repos/rjl493456442/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/rjl493456442/go-ethereum/events","assignees_url":"https://api.github.com/repos/rjl493456442/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/rjl493456442/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/rjl493456442/go-ethereum/tags","blobs_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjl493456442/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/rjl493456442/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/rjl493456442/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/rjl493456442/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/rjl493456442/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/rjl493456442/go-ethereum/subscription","commits_url":"https://api.github.com/repos/rjl493456442/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjl493456442/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjl493456442/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjl493456442/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/rjl493456442/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjl493456442/go-ethereum/merges","archive_url":"https://api.github.com/repos/rjl493456442/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjl493456442/go-ethereum/downloads","issues_url":"https://api.github.com/repos/rjl493456442/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/rjl493456442/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/rjl493456442/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/rjl493456442/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjl493456442/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/rjl493456442/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/rjl493456442/go-ethereum/deployments","created_at":"2017-06-16T17:25:11Z","updated_at":"2017-06-16T17:25:20Z","pushed_at":"2018-03-26T11:08:13Z","git_url":"git://github.com/rjl493456442/go-ethereum.git","ssh_url":"git@github.com:rjl493456442/go-ethereum.git","clone_url":"https://github.com/rjl493456442/go-ethereum.git","svn_url":"https://github.com/rjl493456442/go-ethereum","homepage":"https://geth.ethereum.org","size":97833,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"07d4a022573444eac0db2f5da500cc5ee1e940bb","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2018-03-28T07:46:45Z","pushed_at":"2018-03-28T06:32:15Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":99398,"stargazers_count":16018,"watchers_count":16018,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4995,"mirror_url":null,"archived":false,"open_issues_count":835,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":4995,"open_issues":835,"watchers":16018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/15853"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/15853"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/15853/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/15853/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/cd478b82cc3a2173b00c63d35ec48cf2e268c90c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karalabe"}}