{"action":"created","issue":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/2450","repository_url":"https://api.github.com/repos/ianstormtaylor/slate","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/2450/labels{/name}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/2450/comments","events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/2450/events","html_url":"https://github.com/ianstormtaylor/slate/pull/2450","id":383317266,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODE2MTA1","number":2450,"title":"feat(Examples): make tab menu responsive","user":{"login":"ericedem","id":1060669,"node_id":"MDQ6VXNlcjEwNjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1060669?v=4","gravatar_id":"","url":"https://api.github.com/users/ericedem","html_url":"https://github.com/ericedem","followers_url":"https://api.github.com/users/ericedem/followers","following_url":"https://api.github.com/users/ericedem/following{/other_user}","gists_url":"https://api.github.com/users/ericedem/gists{/gist_id}","starred_url":"https://api.github.com/users/ericedem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericedem/subscriptions","organizations_url":"https://api.github.com/users/ericedem/orgs","repos_url":"https://api.github.com/users/ericedem/repos","events_url":"https://api.github.com/users/ericedem/events{/privacy}","received_events_url":"https://api.github.com/users/ericedem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-21T22:44:12Z","updated_at":"2018-11-26T16:42:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/2450","html_url":"https://github.com/ianstormtaylor/slate/pull/2450","diff_url":"https://github.com/ianstormtaylor/slate/pull/2450.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/2450.patch"},"body":"#### Is this adding or improving a _feature_ or fixing a _bug_?\r\n\r\n_feature_\r\n\r\n#### What's the new behavior?\r\n\r\nFor small screens, don't show tabs by default. Instead, show a hamburger menu. When clicking the hamburger menu, expand the examples list.\r\n\r\nI arbitrarily picked 600px threshold which seemed reasonable to me, open to other suggestions!\r\n\r\n![kapture 2018-11-21 at 14 36 40](https://user-images.githubusercontent.com/1060669/48871938-b52ae080-ed9b-11e8-8bce-9cca329cd7dd.gif)\r\n\r\n#### Have you checked that...?\r\n\r\n<!-- \r\nPlease run through this checklist for your pull request: \r\n-->\r\n\r\n* [ ] The new code matches the existing patterns and styles.\r\n* [ ] The tests pass with `yarn test`.\r\n* [ ] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)\r\n* [ ] The relevant examples still work. (Run examples with `yarn watch`.)\r\n\r\n#### Does this fix any issues or need any specific reviewers?\r\n\r\nFixes: #2419\r\nReviewers: @ianstormtaylor @Dundercover \r\n"},"comment":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments/441708981","html_url":"https://github.com/ianstormtaylor/slate/pull/2450#issuecomment-441708981","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/2450","id":441708981,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTcwODk4MQ==","user":{"login":"ericedem","id":1060669,"node_id":"MDQ6VXNlcjEwNjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1060669?v=4","gravatar_id":"","url":"https://api.github.com/users/ericedem","html_url":"https://github.com/ericedem","followers_url":"https://api.github.com/users/ericedem/followers","following_url":"https://api.github.com/users/ericedem/following{/other_user}","gists_url":"https://api.github.com/users/ericedem/gists{/gist_id}","starred_url":"https://api.github.com/users/ericedem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericedem/subscriptions","organizations_url":"https://api.github.com/users/ericedem/orgs","repos_url":"https://api.github.com/users/ericedem/repos","events_url":"https://api.github.com/users/ericedem/events{/privacy}","received_events_url":"https://api.github.com/users/ericedem/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T16:42:23Z","updated_at":"2018-11-26T16:42:23Z","author_association":"CONTRIBUTOR","body":"Another quick iteration on improving the navigation based on your suggestions @Dundercover \r\n\r\n![kapture 2018-11-26 at 8 40 23](https://user-images.githubusercontent.com/1060669/49028337-fda91c00-f156-11e8-9c2b-4e9e5f0ea9f0.gif)\r\n\r\nPlaying with it I think I like it a lot better. The one thing I was trying to decide was whether to try and close the menu when the user clicks a nav item. It would be convenient, but might be a pretty confusing / unexpected first user experience.\r\n"}}
{"actor":{"display_login":"ericedem"}}