{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/237401883","pull_request_review_id":179688258,"id":237401883,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQwMTg4Mw==","diff_hunk":"@@ -84,6 +84,29 @@ var asm2wasmImports = { // special asm2wasm imports\n };\n \n #if RELOCATABLE\n+// dynamic linking\n+var $LDSO = {","path":"src/support.js","position":5,"original_position":5,"commit_id":"b38b6c5b581567c68cb87f198267bf2511c9dc6f","original_commit_id":"b38b6c5b581567c68cb87f198267bf2511c9dc6f","user":{"login":"navytux","id":1794248,"node_id":"MDQ6VXNlcjE3OTQyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1794248?v=4","gravatar_id":"","url":"https://api.github.com/users/navytux","html_url":"https://github.com/navytux","followers_url":"https://api.github.com/users/navytux/followers","following_url":"https://api.github.com/users/navytux/following{/other_user}","gists_url":"https://api.github.com/users/navytux/gists{/gist_id}","starred_url":"https://api.github.com/users/navytux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navytux/subscriptions","organizations_url":"https://api.github.com/users/navytux/orgs","repos_url":"https://api.github.com/users/navytux/repos","events_url":"https://api.github.com/users/navytux/events{/privacy}","received_events_url":"https://api.github.com/users/navytux/received_events","type":"User","site_admin":false},"body":"It stands for `ld.so` which is known as \"dynamic linker/loader\" (see e.g. http://man7.org/linux/man-pages/man8/ld.so.8.html).","created_at":"2018-11-29T09:10:10Z","updated_at":"2018-11-29T09:10:10Z","html_url":"https://github.com/kripken/emscripten/pull/7571#discussion_r237401883","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/7571","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/237401883"},"html":{"href":"https://github.com/kripken/emscripten/pull/7571#discussion_r237401883"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/7571"}},"in_reply_to_id":237316360},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/7571","id":233839923,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODM5OTIz","html_url":"https://github.com/kripken/emscripten/pull/7571","diff_url":"https://github.com/kripken/emscripten/pull/7571.diff","patch_url":"https://github.com/kripken/emscripten/pull/7571.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/7571","number":7571,"state":"open","locked":false,"title":"ldso: Switch dlopen to use loadDynamicLibrary instead of duplicating it","user":{"login":"navytux","id":1794248,"node_id":"MDQ6VXNlcjE3OTQyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1794248?v=4","gravatar_id":"","url":"https://api.github.com/users/navytux","html_url":"https://github.com/navytux","followers_url":"https://api.github.com/users/navytux/followers","following_url":"https://api.github.com/users/navytux/following{/other_user}","gists_url":"https://api.github.com/users/navytux/gists{/gist_id}","starred_url":"https://api.github.com/users/navytux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navytux/subscriptions","organizations_url":"https://api.github.com/users/navytux/orgs","repos_url":"https://api.github.com/users/navytux/repos","events_url":"https://api.github.com/users/navytux/events{/privacy}","received_events_url":"https://api.github.com/users/navytux/received_events","type":"User","site_admin":false},"body":"Currently dlopen duplicate loadDynamicLibrary in many ways. Since\r\nlogic to load dynamic libraries will be soon reworked to support DSO ->\r\nDSO linking, instead of adding more duplication, as a preparatory step\r\ndlopen is first reworked to use loadDynamicLibrary itself.\r\n\r\nThis moves functionality to keep track of loaded DSO, their handles,\r\nrefcounts, etc into the dynamic linker itself, with loadDynamicLibrary now\r\naccepting various flags (global/nodelete) to handle e.g.\r\nRTLD_LOCAL/RTLD_GLOBAL and RTLD_NODELETE dlopen cases (RTLD_NODELETE\r\nsemantic is needed for initially-linked-in libraries).\r\n\r\nAlso, since dlopen was using FS to read libraries, and loadDynamicLibrary was\r\npreviously using Module['read'] and friends, loadDynamicLibrary now also\r\naccepts fs interface, which if provided, is used as FS-like interface to load\r\nlibrary data, and if not - native loading capabilities of the environment\r\nare still used.\r\n\r\nAnother aspect related to deduplication is that loadDynamicLibrary now also\r\nuses preloaded/precompiled wasm modules, that were previously only used by\r\ndlopen (see a5866a5 \"Add preload plugin to compile wasm side modules async\r\n(#6663)\").","created_at":"2018-11-27T09:39:59Z","updated_at":"2018-11-29T09:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de42ddd219ddade1907c253fd0430d1d32a95a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/7571/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/7571/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/7571/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/b38b6c5b581567c68cb87f198267bf2511c9dc6f","head":{"label":"navytux:y/ldso-needed.4","ref":"y/ldso-needed.4","sha":"b38b6c5b581567c68cb87f198267bf2511c9dc6f","user":{"login":"navytux","id":1794248,"node_id":"MDQ6VXNlcjE3OTQyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1794248?v=4","gravatar_id":"","url":"https://api.github.com/users/navytux","html_url":"https://github.com/navytux","followers_url":"https://api.github.com/users/navytux/followers","following_url":"https://api.github.com/users/navytux/following{/other_user}","gists_url":"https://api.github.com/users/navytux/gists{/gist_id}","starred_url":"https://api.github.com/users/navytux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navytux/subscriptions","organizations_url":"https://api.github.com/users/navytux/orgs","repos_url":"https://api.github.com/users/navytux/repos","events_url":"https://api.github.com/users/navytux/events{/privacy}","received_events_url":"https://api.github.com/users/navytux/received_events","type":"User","site_admin":false},"repo":{"id":157689577,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2ODk1Nzc=","name":"emscripten","full_name":"navytux/emscripten","private":false,"owner":{"login":"navytux","id":1794248,"node_id":"MDQ6VXNlcjE3OTQyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1794248?v=4","gravatar_id":"","url":"https://api.github.com/users/navytux","html_url":"https://github.com/navytux","followers_url":"https://api.github.com/users/navytux/followers","following_url":"https://api.github.com/users/navytux/following{/other_user}","gists_url":"https://api.github.com/users/navytux/gists{/gist_id}","starred_url":"https://api.github.com/users/navytux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navytux/subscriptions","organizations_url":"https://api.github.com/users/navytux/orgs","repos_url":"https://api.github.com/users/navytux/repos","events_url":"https://api.github.com/users/navytux/events{/privacy}","received_events_url":"https://api.github.com/users/navytux/received_events","type":"User","site_admin":false},"html_url":"https://github.com/navytux/emscripten","description":"kirr's emscripten tree","fork":true,"url":"https://api.github.com/repos/navytux/emscripten","forks_url":"https://api.github.com/repos/navytux/emscripten/forks","keys_url":"https://api.github.com/repos/navytux/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navytux/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navytux/emscripten/teams","hooks_url":"https://api.github.com/repos/navytux/emscripten/hooks","issue_events_url":"https://api.github.com/repos/navytux/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/navytux/emscripten/events","assignees_url":"https://api.github.com/repos/navytux/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/navytux/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/navytux/emscripten/tags","blobs_url":"https://api.github.com/repos/navytux/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navytux/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navytux/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/navytux/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navytux/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/navytux/emscripten/languages","stargazers_url":"https://api.github.com/repos/navytux/emscripten/stargazers","contributors_url":"https://api.github.com/repos/navytux/emscripten/contributors","subscribers_url":"https://api.github.com/repos/navytux/emscripten/subscribers","subscription_url":"https://api.github.com/repos/navytux/emscripten/subscription","commits_url":"https://api.github.com/repos/navytux/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/navytux/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/navytux/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/navytux/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/navytux/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/navytux/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navytux/emscripten/merges","archive_url":"https://api.github.com/repos/navytux/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navytux/emscripten/downloads","issues_url":"https://api.github.com/repos/navytux/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/navytux/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/navytux/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/navytux/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navytux/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/navytux/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/navytux/emscripten/deployments","created_at":"2018-11-15T09:58:00Z","updated_at":"2018-11-16T16:59:41Z","pushed_at":"2018-11-27T09:40:55Z","git_url":"git://github.com/navytux/emscripten.git","ssh_url":"git@github.com:navytux/emscripten.git","clone_url":"https://github.com/navytux/emscripten.git","svn_url":"https://github.com/navytux/emscripten","homepage":"https://lab.nexedi.com/kirr/emscripten","size":162224,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"incoming"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"9fdd2eda43860e286cdfa4eacb4f00ca9c55df5c","user":{"login":"kripken","id":173661,"node_id":"MDQ6VXNlcjE3MzY2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3Nzk2","name":"emscripten","full_name":"kripken/emscripten","private":false,"owner":{"login":"kripken","id":173661,"node_id":"MDQ6VXNlcjE3MzY2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2018-11-29T08:13:11Z","pushed_at":"2018-11-29T00:03:20Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":169295,"stargazers_count":16028,"watchers_count":16028,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1884,"mirror_url":null,"archived":false,"open_issues_count":1611,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1884,"open_issues":1611,"watchers":16028,"default_branch":"incoming"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/7571"},"html":{"href":"https://github.com/kripken/emscripten/pull/7571"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/7571"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/7571/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/7571/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/7571/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/b38b6c5b581567c68cb87f198267bf2511c9dc6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"navytux"}}