{"push_id":2732379362,"size":21,"distinct_size":8,"ref":"refs/heads/feature/290-add-support-for-future-payscales","head":"24c8c4c8fe9791230d2617e12e7623a8fd508863","before":"e2f8d71708906dc719c320056cc0add8653722af","commits":[{"sha":"fdea48aff99e711373ff1146ef0a199eb5dcbc27","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(refactor) Rename total_count to total_count_message\n\nTotal count suggests an integer result whereas we're returning a string.","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/fdea48aff99e711373ff1146ef0a199eb5dcbc27"},{"sha":"c216a8d1975a85380d3ced3bc866f2bbdb206c6e","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(feature) Users are informed to check back if there's no listed vacancies\n\nThe content is time specific and only applicable while we're in summer\nholidays. We may want to refactor the code to have a toggle to flip this\nmessage off.","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/c216a8d1975a85380d3ced3bc866f2bbdb206c6e"},{"sha":"e1b1a9816f3438a11733b3a604de41c10b36ff2f","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"(chore): Secure application cookies with headers\n\nWith `curl -X HEAD -i https://teaching-jobs.service.gov.uk -k` we can see that our cookie setting currently looks like:\n\n```\n$ curl -X HEAD -i https://teaching-jobs.service.gov.uk -k\nWarning: Setting custom HTTP method to HEAD with -X/--request may not work the\nWarning: way you want. Consider using -I/--head instead.\nHTTP/2 200\ncontent-type: text/html; charset=utf-8\ndate: Thu, 19 Jul 2018 09:30:35 GMT\nx-frame-options: SAMEORIGIN\nx-xss-protection: 1; mode=block\nx-content-type-options: nosniff\nx-robots-tag: none\netag: W/\"74dfb9a4ab86d75ed907f22bab5c1c07\"\ncache-control: max-age=0, private, must-revalidate\nset-cookie: _teachingjobs_session=aaf55073c31b6da014e2bd20b0680348; path=/; expires=Thu, 19 Jul 2018 10:30:35 -0000; HttpOnly\nx-request-id: 02c685f2-f656-4aba-9695-f99a9f16c993\nx-runtime: 0.239087\nx-cache: Miss from cloudfront\nvia: 1.1 68126347056de2d05be3dd362ccba987.cloudfront.net (CloudFront)\nx-amz-cf-id:\n```\n\nand now after this change:\n\n```\n$ curl -X HEAD -i https://localhost:3000/ -k\nWarning: Setting custom HTTP method to HEAD with -X/--request may not work the\nWarning: way you want. Consider using -I/--head instead.\nHTTP/1.1 200 OK\nX-Frame-Options: SAMEORIGIN\nX-XSS-Protection: 1; mode=block\nX-Content-Type-Options: nosniff\nX-Robots-Tag: none\nContent-Type: text/html; charset=utf-8\nETag: W/\"e47c77651ba3d69fb066c2555ebdbf82\"\nCache-Control: max-age=0, private, must-revalidate\nSet-Cookie: _teachingjobs_session=a412819d47de1ed741736c32d7b2717c; path=/; expires=Thu, 19 Jul 2018 10:30:13 -0000; secure; HttpOnly\nX-Request-Id: a6ad9dcc-8892-432c-8925-266540fce322\nX-Runtime: 2.352722\nStrict-Transport-Security: max-age=15552000; includeSubDomains\n```","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/e1b1a9816f3438a11733b3a604de41c10b36ff2f"},{"sha":"94a15405244f79f3cc8bdea11c3e8b535d00c992","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(feature) Add instructions to add environment variables\n\nFor now there are multiple places where we need to define environment\nvariables. Having a list of these places is useful for reference.","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/94a15405244f79f3cc8bdea11c3e8b535d00c992"},{"sha":"51e36869bc156c2ae17757d3d793c7e6ce41b35d","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"Merge pull request #354 from dxw/chore/296-enable-ssl-only-cookies\n\n(chore): Secure application cookies by enabling site wide SSL only","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/51e36869bc156c2ae17757d3d793c7e6ce41b35d"},{"sha":"f8e5e5ddb1203e9edc50b41602cd43039fea7da0","author":{"name":"Despo Pentara","email":"b4dbc852ff0c77f6e38eb57cc1b87a2f3a1c9f97@extractmethod.com"},"message":"(chore) update sign-in link to match start page","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/f8e5e5ddb1203e9edc50b41602cd43039fea7da0"},{"sha":"f52d37a95cc93706823998c8619459cbd8963bd4","author":{"name":"Despo Pentara","email":"b4dbc852ff0c77f6e38eb57cc1b87a2f3a1c9f97@extractmethod.com"},"message":"Merge pull request #353 from dxw/chore/update-top-link-text\n\n(chore) update sign-in link to match start page","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/f52d37a95cc93706823998c8619459cbd8963bd4"},{"sha":"3147ae28905b99503c2d12b6c4b64675522883ed","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"Merge branch 'develop' into chore/update-terraform-readme-env-vars","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/3147ae28905b99503c2d12b6c4b64675522883ed"},{"sha":"19073edb03b020d8c40609f001e4705ad8534818","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"Merge pull request #350 from dxw/chore/update-terraform-readme-env-vars\n\n(feature) Add instructions to add environment variables","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/19073edb03b020d8c40609f001e4705ad8534818"},{"sha":"36f6454cdc18c9aaddb265aa4d05582d7b7dc181","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"Merge branch 'develop' into feature/291-no-job-listings-content","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/36f6454cdc18c9aaddb265aa4d05582d7b7dc181"},{"sha":"683e3fab3244ded6120aabec8c6591d294f661cb","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"Merge pull request #351 from dxw/feature/291-no-job-listings-content\n\nNo job listings content","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/683e3fab3244ded6120aabec8c6591d294f661cb"},{"sha":"0328bebc0062c85b03ef4e5fdda782404e2a6be0","author":{"name":"Tom Hipkin","email":"96431c8f741969838c686438f5fdcfe15b9f1fc4@gmail.com"},"message":"(feature): Copy for 0 listings includes total listed count\n\n* This will provide the reader some context on the life of this system and the traction the service is getting.","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/0328bebc0062c85b03ef4e5fdda782404e2a6be0"},{"sha":"ff83394f79048b5ec048a220ccdc3bfb4a918d46","author":{"name":"Robbie Paul","email":"71c64382fd9ae43f1dc7e8945a3f21e111568c65@me.com"},"message":"Merge pull request #357 from dxw/feature/301-explain-how-used-the-sytem-is\n\n(feature): Copy for 0 listings includes total listed count","distinct":false,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/ff83394f79048b5ec048a220ccdc3bfb4a918d46"},{"sha":"a9aab568fa7e55166b0a5dfc263b094069c372bf","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(feature) Add starts_at column to pay_scales\n\nWe already have expires_at, so we just need to at starts_at in order to\nuse current pay scales.","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/a9aab568fa7e55166b0a5dfc263b094069c372bf"},{"sha":"26260de7f91db7fe94e6e7f8fd5ca5c8c3e83b0c","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(feature) Add #current scope to PayScale model\n\nNow that we have a start and end date for pay scales we add a scope to\nonly return current pay scales.\n\nAdd sensible defaults to our pay scale factory to avoid unexpected\nresults.","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/26260de7f91db7fe94e6e7f8fd5ca5c8c3e83b0c"},{"sha":"462a59211b096d28a73a84df8370d09c6de88eee","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(refactor) Only use current pay scales for pay_scale_options\n\nSince this helper is only used in the publishing process we can switch\nto using current pay scales only","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/462a59211b096d28a73a84df8370d09c6de88eee"},{"sha":"e2bc21ab263a7e31e2d29af50c8606a6d4c4a980","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(refactor) Force `code` in PayScale factory to be unique\n\nAs we have a unique index on `code` & `expires_at` our factory will\nquickly create invalid records causing our tests to fail.\n\nFirst attempted to use `Faker::Code.unqiue.asin` however I ran in to the\n`Faker::UniqueGenerator::RetryLimitExceeded` error. By using a sequence\nwe can avoid duplication in our factories.","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/e2bc21ab263a7e31e2d29af50c8606a6d4c4a980"},{"sha":"5bd9928b605e2f89a0f62898310d69365fd56f52","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(refactor) Use current scope for minimum salary","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/5bd9928b605e2f89a0f62898310d69365fd56f52"},{"sha":"2f3f8ae821c480d03130cea64375b714e08767be","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(feature) Add Timecop gem","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/2f3f8ae821c480d03130cea64375b714e08767be"},{"sha":"e8211b473956d1817b003692f1662ef18775b878","author":{"name":"Robbie Paul","email":"8b21906604406ce085a3697b31ac8847fcce1d81@dxw.com"},"message":"(spec) `PayScale#minimum_payscale_salary` returns minimum current salary\n\nWe use Timecop to travel forward in time to make sure the minimum\npay scale salary is always the current minimum","distinct":true,"url":"https://api.github.com/repos/dxw/teacher-vacancy-service/commits/e8211b473956d1817b003692f1662ef18775b878"}]}
{"actor":{"display_login":"robbiepaul"}}