{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/comments/223393512","pull_request_review_id":162509088,"id":223393512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzM5MzUxMg==","diff_hunk":"@@ -50,13 +51,20 @@ fun isSkaffoldFile(file: VirtualFile): Boolean {\n     return false\n }\n \n-/**\n- * Finds all Skaffold configuration YAML files in the given project.\n- *\n- * @param project IDE project to search Skaffold file in\n- * @return List of Skaffold configuration files in the project.\n- */\n-fun findSkaffoldFiles(project: Project): List<VirtualFile> {\n-    return FileTypeIndex.getFiles(YAMLFileType.YML, GlobalSearchScope.allScope(project))\n-        .filter { isSkaffoldFile(it) }\n+/** Obtains current active implementation of [SkaffoldFileService] */\n+fun getSkaffoldFileService() = ServiceManager.getService(SkaffoldFileService::class.java)!!\n+\n+/** IDE service for findind Skaffold files in the given IDE project. */\n+class SkaffoldFileService {","path":"skaffold/src/main/kotlin/com/google/container/tools/skaffold/SkaffoldFiles.kt","position":25,"original_position":25,"commit_id":"7f6a9aab05ce32da7c27af66df04bb59e81b2e43","original_commit_id":"7f6a9aab05ce32da7c27af66df04bb59e81b2e43","user":{"login":"etanshaul","id":1735744,"node_id":"MDQ6VXNlcjE3MzU3NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1735744?v=4","gravatar_id":"","url":"https://api.github.com/users/etanshaul","html_url":"https://github.com/etanshaul","followers_url":"https://api.github.com/users/etanshaul/followers","following_url":"https://api.github.com/users/etanshaul/following{/other_user}","gists_url":"https://api.github.com/users/etanshaul/gists{/gist_id}","starred_url":"https://api.github.com/users/etanshaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etanshaul/subscriptions","organizations_url":"https://api.github.com/users/etanshaul/orgs","repos_url":"https://api.github.com/users/etanshaul/repos","events_url":"https://api.github.com/users/etanshaul/events{/privacy}","received_events_url":"https://api.github.com/users/etanshaul/received_events","type":"User","site_admin":false},"body":"how did you decide which functions moved to here vs staying in `SkaffoldFiles.kt`? seems like there isn't a clear boundary now.","created_at":"2018-10-08T14:53:48Z","updated_at":"2018-10-08T14:53:48Z","html_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46#discussion_r223393512","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/comments/223393512"},"html":{"href":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46#discussion_r223393512"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46","id":220821328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODIxMzI4","html_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46","diff_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46.diff","patch_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/46","number":46,"state":"open","locked":false,"title":"Created initial support for Mockk, IJ test services, Skaffold files as a service to test SkaffoldComboBox.","user":{"login":"ivanporty","id":11686100,"node_id":"MDQ6VXNlcjExNjg2MTAw","avatar_url":"https://avatars3.githubusercontent.com/u/11686100?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanporty","html_url":"https://github.com/ivanporty","followers_url":"https://api.github.com/users/ivanporty/followers","following_url":"https://api.github.com/users/ivanporty/following{/other_user}","gists_url":"https://api.github.com/users/ivanporty/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanporty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanporty/subscriptions","organizations_url":"https://api.github.com/users/ivanporty/orgs","repos_url":"https://api.github.com/users/ivanporty/repos","events_url":"https://api.github.com/users/ivanporty/events{/privacy}","received_events_url":"https://api.github.com/users/ivanporty/received_events","type":"User","site_admin":false},"body":"Part of #19.\r\nWork towards #12, #13.\r\n\r\nIn order to thouroughly test `SkaffoldComboBox` class and mock Skaffold files search across the project, Skaffold file search is now made an IDE service. \r\n\r\nTo support testing/mocking it with combo box and for later unit tests, test service support (with annotation, similar to Cloud Tools approach) is added, along with support for Mockk mocking library, which seems to be the most popular choice for Kotlin unit tests as of now.","created_at":"2018-10-05T20:52:28Z","updated_at":"2018-10-08T14:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d4d6e2f6b5d3475dc117ff0a73a8eca184408bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/46/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/statuses/7f6a9aab05ce32da7c27af66df04bb59e81b2e43","head":{"label":"GoogleContainerTools:init-service-unit-tests","ref":"init-service-unit-tests","sha":"7f6a9aab05ce32da7c27af66df04bb59e81b2e43","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":143777319,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NzczMTk=","name":"google-container-tools-intellij","full_name":"GoogleContainerTools/google-container-tools-intellij","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij","description":"In development","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij","forks_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/deployments","created_at":"2018-08-06T20:05:20Z","updated_at":"2018-10-05T20:53:16Z","pushed_at":"2018-10-05T20:52:29Z","git_url":"git://github.com/GoogleContainerTools/google-container-tools-intellij.git","ssh_url":"git@github.com:GoogleContainerTools/google-container-tools-intellij.git","clone_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij.git","svn_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij","homepage":"","size":104,"stargazers_count":8,"watchers_count":8,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":10,"watchers":8,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"af721fdab03e346b79c635288d60293482bf894b","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":143777319,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NzczMTk=","name":"google-container-tools-intellij","full_name":"GoogleContainerTools/google-container-tools-intellij","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij","description":"In development","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij","forks_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/deployments","created_at":"2018-08-06T20:05:20Z","updated_at":"2018-10-05T20:53:16Z","pushed_at":"2018-10-05T20:52:29Z","git_url":"git://github.com/GoogleContainerTools/google-container-tools-intellij.git","ssh_url":"git@github.com:GoogleContainerTools/google-container-tools-intellij.git","clone_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij.git","svn_url":"https://github.com/GoogleContainerTools/google-container-tools-intellij","homepage":"","size":104,"stargazers_count":8,"watchers_count":8,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46"},"html":{"href":"https://github.com/GoogleContainerTools/google-container-tools-intellij/pull/46"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/46"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/google-container-tools-intellij/statuses/7f6a9aab05ce32da7c27af66df04bb59e81b2e43"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"etanshaul"}}