{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/215547249","pull_request_review_id":152833250,"id":215547249,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU0NzI0OQ==","diff_hunk":"@@ -205,6 +205,8 @@ def _handle_expressions_in_comments(state, line, arguments):\n         elif data_type in ['CAST', 'PROCEDURAL LANGUAGE']:  # Restored to pg_catalog, so always filtered in\n             state.output = True\n             state.change_cast_func_schema = True  # When changing schemas, we need to ensure that functions used in casts reference the new schema\n+        elif data_type in ['SEQUENCE OWNED BY', 'SEQUENCE SET', 'DEFAULT']:","path":"gpMgmt/bin/gprestore_filter.py","position":4,"original_position":4,"commit_id":"8034e514198a74ee7c83389b1c229c1fff2adf77","original_commit_id":"8034e514198a74ee7c83389b1c229c1fff2adf77","user":{"login":"danielgustafsson","id":321790,"node_id":"MDQ6VXNlcjMyMTc5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/321790?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false},"body":"Potentially stupid question since I don't really know this tool, but since `DEFAULT` is used quite widely in a database, can this trigger on with false positives?","created_at":"2018-09-06T08:59:03Z","updated_at":"2018-09-06T08:59:07Z","html_url":"https://github.com/greenplum-db/gpdb/pull/5688#discussion_r215547249","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/215547249"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5688#discussion_r215547249"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688","id":213367295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzY3Mjk1","html_url":"https://github.com/greenplum-db/gpdb/pull/5688","diff_url":"https://github.com/greenplum-db/gpdb/pull/5688.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/5688.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5688","number":5688,"state":"open","locked":false,"title":"Fix gpdbrestore to properly restore sequences during filtered restores","user":{"login":"kyeap-pivotal","id":36176870,"node_id":"MDQ6VXNlcjM2MTc2ODcw","avatar_url":"https://avatars0.githubusercontent.com/u/36176870?v=4","gravatar_id":"","url":"https://api.github.com/users/kyeap-pivotal","html_url":"https://github.com/kyeap-pivotal","followers_url":"https://api.github.com/users/kyeap-pivotal/followers","following_url":"https://api.github.com/users/kyeap-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/kyeap-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/kyeap-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyeap-pivotal/subscriptions","organizations_url":"https://api.github.com/users/kyeap-pivotal/orgs","repos_url":"https://api.github.com/users/kyeap-pivotal/repos","events_url":"https://api.github.com/users/kyeap-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/kyeap-pivotal/received_events","type":"User","site_admin":false},"body":"Previously, gpdbrestore was not restoring any ALTER statements related to sequences\r\nduring filtered restores. Now, the gprestore_filter script will properly output these statements.\r\n\r\nThis PR is specific to 5X, as gpdbrestore has been removed in master.\r\n\r\nCo-authored-by: Kevin Yeap <kyeap@pivotal.io>\r\nCo-authored-by: Chris Hajas <chajas@pivotal.io>","created_at":"2018-09-05T17:12:16Z","updated_at":"2018-09-06T08:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45db45b08f344a9e39fa27837e26f26f0c696b5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"khuddlefish","id":4099765,"node_id":"MDQ6VXNlcjQwOTk3NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/4099765?v=4","gravatar_id":"","url":"https://api.github.com/users/khuddlefish","html_url":"https://github.com/khuddlefish","followers_url":"https://api.github.com/users/khuddlefish/followers","following_url":"https://api.github.com/users/khuddlefish/following{/other_user}","gists_url":"https://api.github.com/users/khuddlefish/gists{/gist_id}","starred_url":"https://api.github.com/users/khuddlefish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khuddlefish/subscriptions","organizations_url":"https://api.github.com/users/khuddlefish/orgs","repos_url":"https://api.github.com/users/khuddlefish/repos","events_url":"https://api.github.com/users/khuddlefish/events{/privacy}","received_events_url":"https://api.github.com/users/khuddlefish/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5688/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8034e514198a74ee7c83389b1c229c1fff2adf77","head":{"label":"kyeap-pivotal:sequence-restore","ref":"sequence-restore","sha":"8034e514198a74ee7c83389b1c229c1fff2adf77","user":{"login":"kyeap-pivotal","id":36176870,"node_id":"MDQ6VXNlcjM2MTc2ODcw","avatar_url":"https://avatars0.githubusercontent.com/u/36176870?v=4","gravatar_id":"","url":"https://api.github.com/users/kyeap-pivotal","html_url":"https://github.com/kyeap-pivotal","followers_url":"https://api.github.com/users/kyeap-pivotal/followers","following_url":"https://api.github.com/users/kyeap-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/kyeap-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/kyeap-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyeap-pivotal/subscriptions","organizations_url":"https://api.github.com/users/kyeap-pivotal/orgs","repos_url":"https://api.github.com/users/kyeap-pivotal/repos","events_url":"https://api.github.com/users/kyeap-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/kyeap-pivotal/received_events","type":"User","site_admin":false},"repo":{"id":120834328,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4MzQzMjg=","name":"gpdb","full_name":"kyeap-pivotal/gpdb","owner":{"login":"kyeap-pivotal","id":36176870,"node_id":"MDQ6VXNlcjM2MTc2ODcw","avatar_url":"https://avatars0.githubusercontent.com/u/36176870?v=4","gravatar_id":"","url":"https://api.github.com/users/kyeap-pivotal","html_url":"https://github.com/kyeap-pivotal","followers_url":"https://api.github.com/users/kyeap-pivotal/followers","following_url":"https://api.github.com/users/kyeap-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/kyeap-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/kyeap-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyeap-pivotal/subscriptions","organizations_url":"https://api.github.com/users/kyeap-pivotal/orgs","repos_url":"https://api.github.com/users/kyeap-pivotal/repos","events_url":"https://api.github.com/users/kyeap-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/kyeap-pivotal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyeap-pivotal/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/kyeap-pivotal/gpdb","forks_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/forks","keys_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/teams","hooks_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/hooks","issue_events_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/events","assignees_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/tags","blobs_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/languages","stargazers_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/stargazers","contributors_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/contributors","subscribers_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/subscribers","subscription_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/subscription","commits_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/merges","archive_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/downloads","issues_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/kyeap-pivotal/gpdb/deployments","created_at":"2018-02-09T00:15:27Z","updated_at":"2018-02-09T00:15:59Z","pushed_at":"2018-09-04T22:45:56Z","git_url":"git://github.com/kyeap-pivotal/gpdb.git","ssh_url":"git@github.com:kyeap-pivotal/gpdb.git","clone_url":"https://github.com/kyeap-pivotal/gpdb.git","svn_url":"https://github.com/kyeap-pivotal/gpdb","homepage":"http://greenplum.org","size":283596,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:5X_STABLE","ref":"5X_STABLE","sha":"a9851b6f3e104cdcd3ceb0420bad889d1d0de1c1","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-09-06T08:53:55Z","pushed_at":"2018-09-06T08:53:42Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":296791,"stargazers_count":2645,"watchers_count":2645,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":816,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":816,"open_issues":226,"watchers":2645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5688"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5688"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5688/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5688/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8034e514198a74ee7c83389b1c229c1fff2adf77"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielgustafsson"}}