{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/198337369","pull_request_review_id":132251636,"id":198337369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMzNzM2OQ==","diff_hunk":"@@ -107,12 +107,22 @@ func (configgen *ConfigGeneratorImpl) buildGatewayListeners(env model.Environmen\n \t\t\t// this is for.\n \t\t\tFilterChains: make([]plugin.FilterChain, len(l.FilterChains)),\n \t\t}\n+\n+\t\tvar si *model.ServiceInstance\n+\t\tfor _, w := range workloadInstances {\n+\t\t\tif w.Endpoint.Port == int(portNumber) {\n+\t\t\t\tsi = w\n+\t\t\t\tbreak\n+\t\t\t}\n+\t\t}\n+","path":"pilot/pkg/networking/core/v1alpha3/gateway.go","position":12,"original_position":12,"commit_id":"0c9a03d24d67ae2097dddfdf9eed2e38c19ded3c","original_commit_id":"d3c01acb09793a2b1d1baf17dccf031e7eb6c251","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"body":"log shows that workloadInstances have different Endpoint.Port \r\n\r\n2018-06-27T00:36:08.908734Z\tinfo\t************buildGatewayListeners workloadInstance &{Endpoint:{Family:tcp Address:10.12.1.9 Port:80 ServicePort:0xc420b709c0 UID:} Service:0xc420b97280 Labels:istio=ingressgateway,pod-template-hash=3392915451 AvailabilityZone:us-central1/us-central1-a ServiceAccount:spiffe://cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account} \r\n\r\n2018-06-27T00:36:08.908793Z\tinfo\t************buildGatewayListeners workloadInstance &{Endpoint:{Family:tcp Address:10.12.1.9 Port:31400 ServicePort:0xc420b70a20 UID:} Service:0xc420b97280 Labels:istio=ingressgateway,pod-template-hash=3392915451 AvailabilityZone:us-central1/us-central1-a ServiceAccount:spiffe://cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account} \r\n\r\n2018-06-27T00:36:08.908829Z\tinfo\t************buildGatewayListeners workloadInstance &{Endpoint:{Family:tcp Address:10.12.1.9 Port:443 ServicePort:0xc420b709f0 UID:} Service:0xc420b97280 Labels:istio=ingressgateway,pod-template-hash=3392915451 AvailabilityZone:us-central1/us-central1-a ServiceAccount:spiffe://cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account} \r\n","created_at":"2018-06-27T00:40:31Z","updated_at":"2018-06-27T00:40:31Z","html_url":"https://github.com/istio/istio/pull/5886#discussion_r198337369","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/5886","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/198337369"},"html":{"href":"https://github.com/istio/istio/pull/5886#discussion_r198337369"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/5886"}},"in_reply_to_id":198218280},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5886","id":191207308,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjA3MzA4","html_url":"https://github.com/istio/istio/pull/5886","diff_url":"https://github.com/istio/istio/pull/5886.diff","patch_url":"https://github.com/istio/istio/pull/5886.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/5886","number":5886,"state":"open","locked":false,"title":"JWT authN policy for Gateway","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"body":"https://github.com/istio/istio/issues/5074 ","created_at":"2018-05-29T16:45:30Z","updated_at":"2018-06-27T00:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94239b312ed0d82ccb06855cc9913fd279bd34b4","assignee":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"assignees":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"andraxylia","id":10883640,"node_id":"MDQ6VXNlcjEwODgzNjQw","avatar_url":"https://avatars0.githubusercontent.com/u/10883640?v=4","gravatar_id":"","url":"https://api.github.com/users/andraxylia","html_url":"https://github.com/andraxylia","followers_url":"https://api.github.com/users/andraxylia/followers","following_url":"https://api.github.com/users/andraxylia/following{/other_user}","gists_url":"https://api.github.com/users/andraxylia/gists{/gist_id}","starred_url":"https://api.github.com/users/andraxylia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andraxylia/subscriptions","organizations_url":"https://api.github.com/users/andraxylia/orgs","repos_url":"https://api.github.com/users/andraxylia/repos","events_url":"https://api.github.com/users/andraxylia/events{/privacy}","received_events_url":"https://api.github.com/users/andraxylia/received_events","type":"User","site_admin":false},{"login":"diemtvu","id":25132401,"node_id":"MDQ6VXNlcjI1MTMyNDAx","avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/5886/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/5886/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/5886/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/0c9a03d24d67ae2097dddfdf9eed2e38c19ded3c","head":{"label":"quanjielin:quanlinIngress2","ref":"quanlinIngress2","sha":"0c9a03d24d67ae2097dddfdf9eed2e38c19ded3c","user":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"repo":{"id":116906556,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5MDY1NTY=","name":"istio","full_name":"quanjielin/istio","owner":{"login":"quanjielin","id":32855694,"node_id":"MDQ6VXNlcjMyODU1Njk0","avatar_url":"https://avatars0.githubusercontent.com/u/32855694?v=4","gravatar_id":"","url":"https://api.github.com/users/quanjielin","html_url":"https://github.com/quanjielin","followers_url":"https://api.github.com/users/quanjielin/followers","following_url":"https://api.github.com/users/quanjielin/following{/other_user}","gists_url":"https://api.github.com/users/quanjielin/gists{/gist_id}","starred_url":"https://api.github.com/users/quanjielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quanjielin/subscriptions","organizations_url":"https://api.github.com/users/quanjielin/orgs","repos_url":"https://api.github.com/users/quanjielin/repos","events_url":"https://api.github.com/users/quanjielin/events{/privacy}","received_events_url":"https://api.github.com/users/quanjielin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quanjielin/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/quanjielin/istio","forks_url":"https://api.github.com/repos/quanjielin/istio/forks","keys_url":"https://api.github.com/repos/quanjielin/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quanjielin/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quanjielin/istio/teams","hooks_url":"https://api.github.com/repos/quanjielin/istio/hooks","issue_events_url":"https://api.github.com/repos/quanjielin/istio/issues/events{/number}","events_url":"https://api.github.com/repos/quanjielin/istio/events","assignees_url":"https://api.github.com/repos/quanjielin/istio/assignees{/user}","branches_url":"https://api.github.com/repos/quanjielin/istio/branches{/branch}","tags_url":"https://api.github.com/repos/quanjielin/istio/tags","blobs_url":"https://api.github.com/repos/quanjielin/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quanjielin/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quanjielin/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/quanjielin/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quanjielin/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/quanjielin/istio/languages","stargazers_url":"https://api.github.com/repos/quanjielin/istio/stargazers","contributors_url":"https://api.github.com/repos/quanjielin/istio/contributors","subscribers_url":"https://api.github.com/repos/quanjielin/istio/subscribers","subscription_url":"https://api.github.com/repos/quanjielin/istio/subscription","commits_url":"https://api.github.com/repos/quanjielin/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/quanjielin/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/quanjielin/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/quanjielin/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/quanjielin/istio/contents/{+path}","compare_url":"https://api.github.com/repos/quanjielin/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quanjielin/istio/merges","archive_url":"https://api.github.com/repos/quanjielin/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quanjielin/istio/downloads","issues_url":"https://api.github.com/repos/quanjielin/istio/issues{/number}","pulls_url":"https://api.github.com/repos/quanjielin/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/quanjielin/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/quanjielin/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quanjielin/istio/labels{/name}","releases_url":"https://api.github.com/repos/quanjielin/istio/releases{/id}","deployments_url":"https://api.github.com/repos/quanjielin/istio/deployments","created_at":"2018-01-10T04:07:27Z","updated_at":"2018-06-26T16:19:52Z","pushed_at":"2018-06-27T00:19:09Z","git_url":"git://github.com/quanjielin/istio.git","ssh_url":"git@github.com:quanjielin/istio.git","clone_url":"https://github.com/quanjielin/istio.git","svn_url":"https://github.com/quanjielin/istio","homepage":"https://istio.io","size":59914,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"1a6bd3f0d659701158aca704476f8c074557f36c","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-06-27T00:29:19Z","pushed_at":"2018-06-27T00:27:29Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":39988,"stargazers_count":8884,"watchers_count":8884,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":800,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1220,"open_issues":800,"watchers":8884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/5886"},"html":{"href":"https://github.com/istio/istio/pull/5886"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/5886"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/5886/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/5886/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/5886/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/0c9a03d24d67ae2097dddfdf9eed2e38c19ded3c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"quanjielin"}}