{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/167555118","pull_request_review_id":95788739,"id":167555118,"diff_hunk":"@@ -68,6 +68,14 @@ public function execute(BlockContextInterface $blockContext, Response $response\n             $blockContext->getSetting('per_page')\n         );\n \n+        if (false === $pager) {\n+            if (null === $response) {\n+                $response = new Response();\n+            }\n+\n+            return $response->setContent('')->setStatusCode(204);","path":"src/Block/AdminSearchBlockService.php","position":9,"original_position":9,"commit_id":"02d8905aa47ea8dfb3c11e092d38c285463178c0","original_commit_id":"02d8905aa47ea8dfb3c11e092d38c285463178c0","user":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"body":"The TTL is set from a BlockContext in BlockRenderer::render().","created_at":"2018-02-12T13:30:28Z","updated_at":"2018-02-12T13:30:28Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4941#discussion_r167555118","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/167555118"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4941#discussion_r167555118"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941"}},"in_reply_to_id":167543211},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941","id":168539540,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4941","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4941.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4941.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4941","number":4941,"state":"open","locked":false,"title":"Don't show admin blocks in global search results when no filters are set for global_search","user":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"body":"I am targeting this branch, because it is BC.\r\n\r\nCloses #4574\r\n\r\n## Changelog\r\n\r\n```markdown\r\n### Fixed\r\n- Admins without global search filters will no longer be shown in the global search.\r\n```\r\n\r\n## Subject\r\nIt was not possible to remove an Admin from the global search blocks.\r\n\r\nThe global search would list all the Admins. An Admin was shown with \"no results found\" if that Admin had no filters specified, no filters of that Admin had `'global_search' => true`, or no results were found within that Admin.\r\n\r\nAfter this change, the Admin block will not be shown in the global search results if there are no filters specified or all specified filters have `'global_search' => false`.\r\nThe Admin block is still shown, however, if there are filters for global search, but no results were found.\r\n","created_at":"2018-02-12T10:14:12Z","updated_at":"2018-02-12T13:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8a3b8287807adf6da45bd45e3d1a95f1d5f2a31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":356102611,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/patch","name":"patch","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4941/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/02d8905aa47ea8dfb3c11e092d38c285463178c0","head":{"label":"TimoBakx:global-search-filter","ref":"global-search-filter","sha":"02d8905aa47ea8dfb3c11e092d38c285463178c0","user":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"repo":{"id":121227685,"name":"SonataAdminBundle","full_name":"TimoBakx/SonataAdminBundle","owner":{"login":"TimoBakx","id":839801,"avatar_url":"https://avatars2.githubusercontent.com/u/839801?v=4","gravatar_id":"","url":"https://api.github.com/users/TimoBakx","html_url":"https://github.com/TimoBakx","followers_url":"https://api.github.com/users/TimoBakx/followers","following_url":"https://api.github.com/users/TimoBakx/following{/other_user}","gists_url":"https://api.github.com/users/TimoBakx/gists{/gist_id}","starred_url":"https://api.github.com/users/TimoBakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimoBakx/subscriptions","organizations_url":"https://api.github.com/users/TimoBakx/orgs","repos_url":"https://api.github.com/users/TimoBakx/repos","events_url":"https://api.github.com/users/TimoBakx/events{/privacy}","received_events_url":"https://api.github.com/users/TimoBakx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimoBakx/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle","forks_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/TimoBakx/SonataAdminBundle/deployments","created_at":"2018-02-12T09:41:23Z","updated_at":"2018-02-12T09:41:26Z","pushed_at":"2018-02-12T12:37:58Z","git_url":"git://github.com/TimoBakx/SonataAdminBundle.git","ssh_url":"git@github.com:TimoBakx/SonataAdminBundle.git","clone_url":"https://github.com/TimoBakx/SonataAdminBundle.git","svn_url":"https://github.com/TimoBakx/SonataAdminBundle","homepage":"https://sonata-project.org/","size":21001,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"215fd15911510dd7146cd917f5369afb59124d8f","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2018-02-11T16:33:35Z","pushed_at":"2018-02-12T12:37:59Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"https://sonata-project.org/","size":21000,"stargazers_count":1612,"watchers_count":1612,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1130,"mirror_url":null,"archived":false,"open_issues_count":326,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1130,"open_issues":326,"watchers":1612,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4941"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4941"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4941/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4941/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/02d8905aa47ea8dfb3c11e092d38c285463178c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TimoBakx"}}