{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/238498204","pull_request_review_id":181042664,"id":238498204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ5ODIwNA==","diff_hunk":"@@ -128,11 +128,22 @@ class Gauge_ extends BaseGraph {\n       relayout(this.node, this.layout);\n       return;\n     }\n-    data = parseFloat(_.get(data, '[0].data.result[0].value[1]'), 10);\n-    if (isNaN(data)) {\n-      // eslint-disable-next-line no-console\n-      console.warn(`Graph error: No data from query ${this.props.query}`);\n-      return;\n+\n+    const {query, percentUsed} = this.props;\n+    if (query) {\n+      data = parseFloat(_.get(data, '[0].data.result[0].value[1]'), 10);\n+      if (isNaN(data)) {\n+        // eslint-disable-next-line no-console\n+        console.warn(`Graph error: No data from query ${this.props.query}`);\n+        return;\n+      }\n+    } else if (!_.isUndefined(percentUsed)){\n+      data = parseFloat(percentUsed, 10);\n+      if (isNaN(data)) {","path":"frontend/public/components/graphs/gauge.jsx","position":20,"original_position":20,"commit_id":"2f50c16a91448a791c7cb6f20fc65d43a25d9788","original_commit_id":"2f50c16a91448a791c7cb6f20fc65d43a25d9788","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"This modeled after existing code, but we should be checking `!_.isFinite(data)`","created_at":"2018-12-04T01:08:37Z","updated_at":"2018-12-04T01:15:46Z","html_url":"https://github.com/openshift/console/pull/892#discussion_r238498204","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/892","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/238498204"},"html":{"href":"https://github.com/openshift/console/pull/892#discussion_r238498204"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/892","id":235585843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTg1ODQz","html_url":"https://github.com/openshift/console/pull/892","diff_url":"https://github.com/openshift/console/pull/892.diff","patch_url":"https://github.com/openshift/console/pull/892.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/892","number":892,"state":"open","locked":false,"title":"Resource Quota Details:  Charts, Scopes, Quota Help InfoTip","user":{"login":"dtaylor113","id":12733153,"node_id":"MDQ6VXNlcjEyNzMzMTUz","avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/12733153/49400226-94567980-f711-11e8-8b7c-80a6b8563e1b.png)\r\n\r\n**_More Charts:_**\r\n\r\n![image](https://user-images.githubusercontent.com/12733153/49400221-915b8900-f711-11e8-8b06-b0aae7e42ef7.png)\r\n\r\nDesign Doc: http://openshift.github.io/openshift-origin-design/web-console/4.0-designs/resource-quota/resource-quota\r\n\r\nJIRA: https://jira.coreos.com/browse/CONSOLE-1069","created_at":"2018-12-03T20:43:03Z","updated_at":"2018-12-04T01:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfb0c8ceaae2a3cc382f53e31808ebf6c8a74812","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cshinn","id":3300756,"node_id":"MDQ6VXNlcjMzMDA3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3300756?v=4","gravatar_id":"","url":"https://api.github.com/users/cshinn","html_url":"https://github.com/cshinn","followers_url":"https://api.github.com/users/cshinn/followers","following_url":"https://api.github.com/users/cshinn/following{/other_user}","gists_url":"https://api.github.com/users/cshinn/gists{/gist_id}","starred_url":"https://api.github.com/users/cshinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshinn/subscriptions","organizations_url":"https://api.github.com/users/cshinn/orgs","repos_url":"https://api.github.com/users/cshinn/repos","events_url":"https://api.github.com/users/cshinn/events{/privacy}","received_events_url":"https://api.github.com/users/cshinn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":926924366,"node_id":"MDU6TGFiZWw5MjY5MjQzNjY=","url":"https://api.github.com/repos/openshift/console/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/892/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/892/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/892/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/2f50c16a91448a791c7cb6f20fc65d43a25d9788","head":{"label":"dtaylor113:resource-quotoa-charts","ref":"resource-quotoa-charts","sha":"2f50c16a91448a791c7cb6f20fc65d43a25d9788","user":{"login":"dtaylor113","id":12733153,"node_id":"MDQ6VXNlcjEyNzMzMTUz","avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"repo":{"id":133376742,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNzY3NDI=","name":"console","full_name":"dtaylor113/console","private":false,"owner":{"login":"dtaylor113","id":12733153,"node_id":"MDQ6VXNlcjEyNzMzMTUz","avatar_url":"https://avatars2.githubusercontent.com/u/12733153?v=4","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dtaylor113/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/dtaylor113/console","forks_url":"https://api.github.com/repos/dtaylor113/console/forks","keys_url":"https://api.github.com/repos/dtaylor113/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtaylor113/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtaylor113/console/teams","hooks_url":"https://api.github.com/repos/dtaylor113/console/hooks","issue_events_url":"https://api.github.com/repos/dtaylor113/console/issues/events{/number}","events_url":"https://api.github.com/repos/dtaylor113/console/events","assignees_url":"https://api.github.com/repos/dtaylor113/console/assignees{/user}","branches_url":"https://api.github.com/repos/dtaylor113/console/branches{/branch}","tags_url":"https://api.github.com/repos/dtaylor113/console/tags","blobs_url":"https://api.github.com/repos/dtaylor113/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtaylor113/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtaylor113/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtaylor113/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtaylor113/console/statuses/{sha}","languages_url":"https://api.github.com/repos/dtaylor113/console/languages","stargazers_url":"https://api.github.com/repos/dtaylor113/console/stargazers","contributors_url":"https://api.github.com/repos/dtaylor113/console/contributors","subscribers_url":"https://api.github.com/repos/dtaylor113/console/subscribers","subscription_url":"https://api.github.com/repos/dtaylor113/console/subscription","commits_url":"https://api.github.com/repos/dtaylor113/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtaylor113/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtaylor113/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtaylor113/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtaylor113/console/contents/{+path}","compare_url":"https://api.github.com/repos/dtaylor113/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtaylor113/console/merges","archive_url":"https://api.github.com/repos/dtaylor113/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtaylor113/console/downloads","issues_url":"https://api.github.com/repos/dtaylor113/console/issues{/number}","pulls_url":"https://api.github.com/repos/dtaylor113/console/pulls{/number}","milestones_url":"https://api.github.com/repos/dtaylor113/console/milestones{/number}","notifications_url":"https://api.github.com/repos/dtaylor113/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtaylor113/console/labels{/name}","releases_url":"https://api.github.com/repos/dtaylor113/console/releases{/id}","deployments_url":"https://api.github.com/repos/dtaylor113/console/deployments","created_at":"2018-05-14T14:48:07Z","updated_at":"2018-07-11T14:58:48Z","pushed_at":"2018-12-03T20:37:56Z","git_url":"git://github.com/dtaylor113/console.git","ssh_url":"git@github.com:dtaylor113/console.git","clone_url":"https://github.com/dtaylor113/console.git","svn_url":"https://github.com/dtaylor113/console","homepage":"","size":89535,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"bd0beeb577d0b2d862e60239e4376557e1e2a5b5","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-12-03T18:35:35Z","pushed_at":"2018-12-03T23:36:12Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":89415,"stargazers_count":34,"watchers_count":34,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":40,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/892"},"html":{"href":"https://github.com/openshift/console/pull/892"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/892"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/2f50c16a91448a791c7cb6f20fc65d43a25d9788"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spadgett"}}