{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/272","repository_url":"https://api.github.com/repos/openzipkin/zipkin-js","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/272/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/272/events","html_url":"https://github.com/openzipkin/zipkin-js/pull/272","id":374345192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDY3NTIz","number":272,"title":"WIP: Rollup build","user":{"login":"DavideCarvalho","id":15630886,"node_id":"MDQ6VXNlcjE1NjMwODg2","avatar_url":"https://avatars1.githubusercontent.com/u/15630886?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideCarvalho","html_url":"https://github.com/DavideCarvalho","followers_url":"https://api.github.com/users/DavideCarvalho/followers","following_url":"https://api.github.com/users/DavideCarvalho/following{/other_user}","gists_url":"https://api.github.com/users/DavideCarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideCarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideCarvalho/subscriptions","organizations_url":"https://api.github.com/users/DavideCarvalho/orgs","repos_url":"https://api.github.com/users/DavideCarvalho/repos","events_url":"https://api.github.com/users/DavideCarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/DavideCarvalho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-26T11:37:13Z","updated_at":"2018-10-26T19:15:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/pulls/272","html_url":"https://github.com/openzipkin/zipkin-js/pull/272","diff_url":"https://github.com/openzipkin/zipkin-js/pull/272.diff","patch_url":"https://github.com/openzipkin/zipkin-js/pull/272.patch"},"body":"I'll make a rollup config so when we build the application, we can have .umd, .ecj and .esm files.\r\nThis is especially good if you are using a micro frontend aproach and loading everything with systemjs.\r\nSince rollup does dead code elimination, minification and tree shaking, the lib size will be smaller too.\r\n\r\nClose #270 "},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/comments/433515115","html_url":"https://github.com/openzipkin/zipkin-js/pull/272#issuecomment-433515115","issue_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/272","id":433515115,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzUxNTExNQ==","user":{"login":"jcchavezs","id":3075074,"node_id":"MDQ6VXNlcjMwNzUwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3075074?v=4","gravatar_id":"","url":"https://api.github.com/users/jcchavezs","html_url":"https://github.com/jcchavezs","followers_url":"https://api.github.com/users/jcchavezs/followers","following_url":"https://api.github.com/users/jcchavezs/following{/other_user}","gists_url":"https://api.github.com/users/jcchavezs/gists{/gist_id}","starred_url":"https://api.github.com/users/jcchavezs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcchavezs/subscriptions","organizations_url":"https://api.github.com/users/jcchavezs/orgs","repos_url":"https://api.github.com/users/jcchavezs/repos","events_url":"https://api.github.com/users/jcchavezs/events{/privacy}","received_events_url":"https://api.github.com/users/jcchavezs/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T19:15:52Z","updated_at":"2018-10-26T19:15:52Z","author_association":"CONTRIBUTOR","body":"Same happened with ts-runtime, we enabled tests only for node >4. Regarding killing node 4, that would be a major and for that I would also enable support for node >8. There is already a PR that started that work: https://github.com/openzipkin/zipkin-js/pull/146/files. Are you up for such a thing?\n\nJosé Carlos\n\n> 26. okt. 2018 kl. 16:03 skrev Davi de Carvalho <notifications@github.com>:\n> \n> Okay, we have a little problem with the ci...\n> Sounds like rollup doesn't work with node 4.x, neither with 5.x, only with node 6+\n> @jcchavezs can we do something about it?\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"jcchavezs"}}