{"action":"created","issue":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8468","repository_url":"https://api.github.com/repos/TEAMMATES/teammates","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8468/labels{/name}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8468/comments","events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8468/events","html_url":"https://github.com/TEAMMATES/teammates/issues/8468","id":298045202,"number":8468,"title":"Feedback Session : 'Never Publish' open sessions can still be published","user":{"login":"sukanta-27","id":10681755,"avatar_url":"https://avatars3.githubusercontent.com/u/10681755?v=4","gravatar_id":"","url":"https://api.github.com/users/sukanta-27","html_url":"https://github.com/sukanta-27","followers_url":"https://api.github.com/users/sukanta-27/followers","following_url":"https://api.github.com/users/sukanta-27/following{/other_user}","gists_url":"https://api.github.com/users/sukanta-27/gists{/gist_id}","starred_url":"https://api.github.com/users/sukanta-27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sukanta-27/subscriptions","organizations_url":"https://api.github.com/users/sukanta-27/orgs","repos_url":"https://api.github.com/users/sukanta-27/repos","events_url":"https://api.github.com/users/sukanta-27/events{/privacy}","received_events_url":"https://api.github.com/users/sukanta-27/received_events","type":"User","site_admin":false},"labels":[{"id":533071345,"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.NeedsInfo","name":"s.NeedsInfo","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-02-17T23:27:34Z","updated_at":"2018-02-19T11:34:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Environment:**\r\n`master` branch.\r\nDon't know if this is a bug or intentional. So, went along with the bug template.\r\n**Steps to reproduce:**\r\n- Login as `Instructor`\r\n- Create a new session, set a Opening time so earlier than current time, to get a `Open` session\r\n- Set the option `Responses visible from` to `Never`. \r\n- Now go back to `Home` or `Sessions`, and find the session you created in the session table\r\n- Open the drop down button in `Results` action, or go to Results page and click `Publish Results`\r\n\r\n**Expected behaviour:** There should be a error message that the session can not be published as the session is set to never get published. Or, the `Publish Results` button should be disabled.\r\n\r\n**Actual behaviour:** The session gets successfully published.\r\n\r\nI think the proper steps to publish results for these kind of sessions should be, `Edit` -> `Responses visible from` -> Any option other than `Never` -> `Save Changes`."},"comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments/366663708","html_url":"https://github.com/TEAMMATES/teammates/issues/8468#issuecomment-366663708","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8468","id":366663708,"user":{"login":"damithc","id":1673303,"avatar_url":"https://avatars3.githubusercontent.com/u/1673303?v=4","gravatar_id":"","url":"https://api.github.com/users/damithc","html_url":"https://github.com/damithc","followers_url":"https://api.github.com/users/damithc/followers","following_url":"https://api.github.com/users/damithc/following{/other_user}","gists_url":"https://api.github.com/users/damithc/gists{/gist_id}","starred_url":"https://api.github.com/users/damithc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damithc/subscriptions","organizations_url":"https://api.github.com/users/damithc/orgs","repos_url":"https://api.github.com/users/damithc/repos","events_url":"https://api.github.com/users/damithc/events{/privacy}","received_events_url":"https://api.github.com/users/damithc/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T11:34:54Z","updated_at":"2018-02-19T11:34:54Z","author_association":"CONTRIBUTOR","body":"UI design is not an exact science; hard to get right or even agree on the best design.\r\n\r\nI'm a bit vary of designing the UI to match how the app processes things rather than how the user thinks about things. As a user I'm thinking \"I'll publish the results at a later time\". It's an additional step for me to also figure out \"hey, that's the same as choosing 'Never' now and clicking the 'Publish' button later\" (or something of the sort). i.e., the close we can get to user intention, the easier it feels to use. \r\n\r\nI'm also wary of combining things just because they are processed the same way. I use a banking app that has an option `Transfer now / SLIIP` or something like that. Although I understand it means one or the other, I always hesitate a moment before choosing that option because I have no idea what `SLIIP` is; I feel a bit annoyed to even having to read that word with which I don't have any business. This kind of thing (e.g., choosing an option that  has some unrelated thing in it) adds anxiety to users, especially non-techie users, and makes the app less user-friendly, I think.\r\n\r\nOf course, we also have to factor in complexity of implementation. At times we may have to choose the design that simplifies the code rather than user experience."}}
{"actor":{"display_login":"damithc"}}