{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/195513552","pull_request_review_id":128898691,"id":195513552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUxMzU1Mg==","diff_hunk":"@@ -55,6 +55,12 @@ export class RestApiClient {\n     /*Codes_SRS_NODE_IOTHUB_REST_API_CLIENT_16_003: [The `RestApiClient` constructor shall use `azure-iot-common.Http` as the internal HTTP client if the `httpBase` argument is `undefined`.]*/\n     /*Codes_SRS_NODE_IOTHUB_REST_API_CLIENT_16_004: [The `RestApiClient` constructor shall use the value of the `httpBase` argument as the internal HTTP client if present.]*/\n     this._http = httpRequestBuilder || new HttpBase();\n+\n+    if (config.dontUseTls) {\n+      this._http.setOptions({\n+        dontUseTls: true\n+      });\n+    }","path":"common/transport/http/src/rest_api_client.ts","position":9,"original_position":9,"commit_id":"de2f785fb1adc51482c6451eb7caf225a2fdb4a6","original_commit_id":"de2f785fb1adc51482c6451eb7caf225a2fdb4a6","user":{"login":"pierreca","id":4979572,"node_id":"MDQ6VXNlcjQ5Nzk1NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":"we could make useTls a constructor option - and avoid the call to setOptions","created_at":"2018-06-14T17:47:54Z","updated_at":"2018-06-14T17:47:54Z","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/315#discussion_r195513552","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/195513552"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/315#discussion_r195513552"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315","id":194732065,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzMyMDY1","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/315","diff_url":"https://github.com/Azure/azure-iot-sdk-node/pull/315.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-node/pull/315.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/315","number":315,"state":"open","locked":false,"title":"Add trust bundle support","user":{"login":"avranju","id":628128,"node_id":"MDQ6VXNlcjYyODEyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/628128?v=4","gravatar_id":"","url":"https://api.github.com/users/avranju","html_url":"https://github.com/avranju","followers_url":"https://api.github.com/users/avranju/followers","following_url":"https://api.github.com/users/avranju/following{/other_user}","gists_url":"https://api.github.com/users/avranju/gists{/gist_id}","starred_url":"https://api.github.com/users/avranju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avranju/subscriptions","organizations_url":"https://api.github.com/users/avranju/orgs","repos_url":"https://api.github.com/users/avranju/repos","events_url":"https://api.github.com/users/avranju/events{/privacy}","received_events_url":"https://api.github.com/users/avranju/received_events","type":"User","site_admin":false},"body":"  - Add CA cert support for AMQP\r\n  - Turn fromEnvironment into an async function\r\n  - Add trust bundle support in edge auth provider + amqp support for gateway host name\r\n  - Add support for CA cert from environment and trust bundle support in ModuleClient\r\n","created_at":"2018-06-13T22:23:49Z","updated_at":"2018-06-14T17:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1286f5821db90771704692836f429de93223bf6e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonyvercolano","id":9854568,"node_id":"MDQ6VXNlcjk4NTQ1Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/9854568?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyvercolano","html_url":"https://github.com/anthonyvercolano","followers_url":"https://api.github.com/users/anthonyvercolano/followers","following_url":"https://api.github.com/users/anthonyvercolano/following{/other_user}","gists_url":"https://api.github.com/users/anthonyvercolano/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyvercolano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyvercolano/subscriptions","organizations_url":"https://api.github.com/users/anthonyvercolano/orgs","repos_url":"https://api.github.com/users/anthonyvercolano/repos","events_url":"https://api.github.com/users/anthonyvercolano/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyvercolano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/315/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/de2f785fb1adc51482c6451eb7caf225a2fdb4a6","head":{"label":"avranju:trust-bundle","ref":"trust-bundle","sha":"de2f785fb1adc51482c6451eb7caf225a2fdb4a6","user":{"login":"avranju","id":628128,"node_id":"MDQ6VXNlcjYyODEyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/628128?v=4","gravatar_id":"","url":"https://api.github.com/users/avranju","html_url":"https://github.com/avranju","followers_url":"https://api.github.com/users/avranju/followers","following_url":"https://api.github.com/users/avranju/following{/other_user}","gists_url":"https://api.github.com/users/avranju/gists{/gist_id}","starred_url":"https://api.github.com/users/avranju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avranju/subscriptions","organizations_url":"https://api.github.com/users/avranju/orgs","repos_url":"https://api.github.com/users/avranju/repos","events_url":"https://api.github.com/users/avranju/events{/privacy}","received_events_url":"https://api.github.com/users/avranju/received_events","type":"User","site_admin":false},"repo":{"id":95059175,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA1OTE3NQ==","name":"azure-iot-sdk-node","full_name":"avranju/azure-iot-sdk-node","owner":{"login":"avranju","id":628128,"node_id":"MDQ6VXNlcjYyODEyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/628128?v=4","gravatar_id":"","url":"https://api.github.com/users/avranju","html_url":"https://github.com/avranju","followers_url":"https://api.github.com/users/avranju/followers","following_url":"https://api.github.com/users/avranju/following{/other_user}","gists_url":"https://api.github.com/users/avranju/gists{/gist_id}","starred_url":"https://api.github.com/users/avranju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avranju/subscriptions","organizations_url":"https://api.github.com/users/avranju/orgs","repos_url":"https://api.github.com/users/avranju/repos","events_url":"https://api.github.com/users/avranju/events{/privacy}","received_events_url":"https://api.github.com/users/avranju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avranju/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/avranju/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/avranju/azure-iot-sdk-node/deployments","created_at":"2017-06-22T00:49:09Z","updated_at":"2017-06-22T00:49:12Z","pushed_at":"2018-06-14T05:38:22Z","git_url":"git://github.com/avranju/azure-iot-sdk-node.git","ssh_url":"git@github.com:avranju/azure-iot-sdk-node.git","clone_url":"https://github.com/avranju/azure-iot-sdk-node.git","svn_url":"https://github.com/avranju/azure-iot-sdk-node","homepage":"https://azure.github.io/azure-iot-sdk-node/","size":43676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:modules-preview","ref":"modules-preview","sha":"62a9419f53713dd46cfd806a6feca1f6e466deef","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNTAwMg==","name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2018-06-08T00:15:26Z","pushed_at":"2018-06-14T05:38:23Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":43772,"stargazers_count":101,"watchers_count":101,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":91,"open_issues":10,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/315"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/315"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/de2f785fb1adc51482c6451eb7caf225a2fdb4a6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pierreca"}}