{"action":"created","comment":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/comments/228039008","pull_request_review_id":168214098,"id":228039008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODAzOTAwOA==","diff_hunk":"@@ -20,13 +20,13 @@ type Header struct {\n \t// TODO smart contract fields\n }\n \n-func NewBlockHeader(round round.Round, txRoot string) *Header {\n+func NewBlockHeader(basis voting.Basis, txRoot string) *Header {\n \treturn &Header{\n-\t\tPrevBlockHash:    round.BlockHash,\n+\t\tPrevBlockHash:    basis.BlockHash,","path":"lib/block/header.go","position":17,"original_position":17,"commit_id":"7d31a90d39c4b147ebea954fcae874840a9fead0","original_commit_id":"7d31a90d39c4b147ebea954fcae874840a9fead0","user":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"body":"Isn't that super inconsistent though ? `basis.BlockHash` => previous block hash, but `basis.Height` => current block height.","created_at":"2018-10-25T05:34:03Z","updated_at":"2018-10-25T05:34:03Z","html_url":"https://github.com/bosnet/sebak/pull/594#discussion_r228039008","pull_request_url":"https://api.github.com/repos/bosnet/sebak/pulls/594","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments/228039008"},"html":{"href":"https://github.com/bosnet/sebak/pull/594#discussion_r228039008"},"pull_request":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/594","id":225588072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTg4MDcy","html_url":"https://github.com/bosnet/sebak/pull/594","diff_url":"https://github.com/bosnet/sebak/pull/594.diff","patch_url":"https://github.com/bosnet/sebak/pull/594.patch","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/594","number":594,"state":"open","locked":false,"title":"Modify round.Round to voting.Basis","user":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"body":"Because round.Round had more information besides round.\r\n\r\nround.Round -> block.Summary\r\nI modified this\r\n```\r\npackage round\r\ntype Round struct {\r\n\tRoundNumber     uint64 `json:\"round_number\"`      // round sequence number\r\n\tBlockHeight    uint64 `json:\"height\"`     // last block height\r\n\tBlockHash string `json:\"block-hash\"` // hash of last block\r\n\tTotalTxs  uint64 `json:\"total-txs\"`\r\n\tTotalOps  uint64 `json:\"total-ops\"`\r\n}\r\n\r\n```\r\nto\r\n```\r\npackage block\r\ntype Summary struct {\r\n\tRound     uint64 `json:\"round\"`      // round sequence number\r\n\tHeight    uint64 `json:\"height\"`     // last block height\r\n\tBlockHash string `json:\"block-hash\"` // hash of last block\r\n\tTotalTxs  uint64 `json:\"total-txs\"`\r\n\tTotalOps  uint64 `json:\"total-ops\"`\r\n}\r\n```\r\n\r\nDiff\r\n```\r\nround.Round.RoundNumber -> block.Summary.Round\r\nround.Round.BlockHeight -> block.Summary.Height\r\n```","created_at":"2018-10-25T00:15:04Z","updated_at":"2018-10-25T05:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560953a2e23eadb0af53383f5eef56eac2852797","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anarcher","id":12271,"node_id":"MDQ6VXNlcjEyMjcx","avatar_url":"https://avatars1.githubusercontent.com/u/12271?v=4","gravatar_id":"","url":"https://api.github.com/users/anarcher","html_url":"https://github.com/anarcher","followers_url":"https://api.github.com/users/anarcher/followers","following_url":"https://api.github.com/users/anarcher/following{/other_user}","gists_url":"https://api.github.com/users/anarcher/gists{/gist_id}","starred_url":"https://api.github.com/users/anarcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anarcher/subscriptions","organizations_url":"https://api.github.com/users/anarcher/orgs","repos_url":"https://api.github.com/users/anarcher/repos","events_url":"https://api.github.com/users/anarcher/events{/privacy}","received_events_url":"https://api.github.com/users/anarcher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bosnet/sebak/pulls/594/commits","review_comments_url":"https://api.github.com/repos/bosnet/sebak/pulls/594/comments","review_comment_url":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/594/comments","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/7d31a90d39c4b147ebea954fcae874840a9fead0","head":{"label":"Charleslee522:round-to-summary","ref":"round-to-summary","sha":"7d31a90d39c4b147ebea954fcae874840a9fead0","user":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"repo":{"id":137317850,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMTc4NTA=","name":"sebak","full_name":"Charleslee522/sebak","private":false,"owner":{"login":"Charleslee522","id":15343839,"node_id":"MDQ6VXNlcjE1MzQzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/15343839?v=4","gravatar_id":"","url":"https://api.github.com/users/Charleslee522","html_url":"https://github.com/Charleslee522","followers_url":"https://api.github.com/users/Charleslee522/followers","following_url":"https://api.github.com/users/Charleslee522/following{/other_user}","gists_url":"https://api.github.com/users/Charleslee522/gists{/gist_id}","starred_url":"https://api.github.com/users/Charleslee522/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Charleslee522/subscriptions","organizations_url":"https://api.github.com/users/Charleslee522/orgs","repos_url":"https://api.github.com/users/Charleslee522/repos","events_url":"https://api.github.com/users/Charleslee522/events{/privacy}","received_events_url":"https://api.github.com/users/Charleslee522/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Charleslee522/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":true,"url":"https://api.github.com/repos/Charleslee522/sebak","forks_url":"https://api.github.com/repos/Charleslee522/sebak/forks","keys_url":"https://api.github.com/repos/Charleslee522/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Charleslee522/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Charleslee522/sebak/teams","hooks_url":"https://api.github.com/repos/Charleslee522/sebak/hooks","issue_events_url":"https://api.github.com/repos/Charleslee522/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/Charleslee522/sebak/events","assignees_url":"https://api.github.com/repos/Charleslee522/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/Charleslee522/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/Charleslee522/sebak/tags","blobs_url":"https://api.github.com/repos/Charleslee522/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Charleslee522/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Charleslee522/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/Charleslee522/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Charleslee522/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/Charleslee522/sebak/languages","stargazers_url":"https://api.github.com/repos/Charleslee522/sebak/stargazers","contributors_url":"https://api.github.com/repos/Charleslee522/sebak/contributors","subscribers_url":"https://api.github.com/repos/Charleslee522/sebak/subscribers","subscription_url":"https://api.github.com/repos/Charleslee522/sebak/subscription","commits_url":"https://api.github.com/repos/Charleslee522/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/Charleslee522/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/Charleslee522/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/Charleslee522/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/Charleslee522/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/Charleslee522/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Charleslee522/sebak/merges","archive_url":"https://api.github.com/repos/Charleslee522/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Charleslee522/sebak/downloads","issues_url":"https://api.github.com/repos/Charleslee522/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/Charleslee522/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/Charleslee522/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/Charleslee522/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Charleslee522/sebak/labels{/name}","releases_url":"https://api.github.com/repos/Charleslee522/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/Charleslee522/sebak/deployments","created_at":"2018-06-14T06:47:48Z","updated_at":"2018-09-13T02:20:54Z","pushed_at":"2018-10-25T02:50:56Z","git_url":"git://github.com/Charleslee522/sebak.git","ssh_url":"git@github.com:Charleslee522/sebak.git","clone_url":"https://github.com/Charleslee522/sebak.git","svn_url":"https://github.com/Charleslee522/sebak","homepage":"https://boscoin.io","size":1942,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bosnet:master","ref":"master","sha":"b91b34246d7a1c1601da5321c84e465bc44779c2","user":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"repo":{"id":129848943,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg5NDM=","name":"sebak","full_name":"bosnet/sebak","private":false,"owner":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bosnet/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":false,"url":"https://api.github.com/repos/bosnet/sebak","forks_url":"https://api.github.com/repos/bosnet/sebak/forks","keys_url":"https://api.github.com/repos/bosnet/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosnet/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosnet/sebak/teams","hooks_url":"https://api.github.com/repos/bosnet/sebak/hooks","issue_events_url":"https://api.github.com/repos/bosnet/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/bosnet/sebak/events","assignees_url":"https://api.github.com/repos/bosnet/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/bosnet/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/bosnet/sebak/tags","blobs_url":"https://api.github.com/repos/bosnet/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosnet/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosnet/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosnet/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/bosnet/sebak/languages","stargazers_url":"https://api.github.com/repos/bosnet/sebak/stargazers","contributors_url":"https://api.github.com/repos/bosnet/sebak/contributors","subscribers_url":"https://api.github.com/repos/bosnet/sebak/subscribers","subscription_url":"https://api.github.com/repos/bosnet/sebak/subscription","commits_url":"https://api.github.com/repos/bosnet/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosnet/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosnet/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosnet/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosnet/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/bosnet/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosnet/sebak/merges","archive_url":"https://api.github.com/repos/bosnet/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosnet/sebak/downloads","issues_url":"https://api.github.com/repos/bosnet/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/bosnet/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/bosnet/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/bosnet/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosnet/sebak/labels{/name}","releases_url":"https://api.github.com/repos/bosnet/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/bosnet/sebak/deployments","created_at":"2018-04-17T05:05:34Z","updated_at":"2018-10-25T04:57:20Z","pushed_at":"2018-10-25T05:26:18Z","git_url":"git://github.com/bosnet/sebak.git","ssh_url":"git@github.com:bosnet/sebak.git","clone_url":"https://github.com/bosnet/sebak.git","svn_url":"https://github.com/bosnet/sebak","homepage":"https://bosnet.github.io/sebak/","size":1506,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":75,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/594"},"html":{"href":"https://github.com/bosnet/sebak/pull/594"},"issue":{"href":"https://api.github.com/repos/bosnet/sebak/issues/594"},"comments":{"href":"https://api.github.com/repos/bosnet/sebak/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/bosnet/sebak/statuses/7d31a90d39c4b147ebea954fcae874840a9fead0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Geod24"}}