{"action":"created","comment":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/213409490","pull_request_review_id":150240112,"id":213409490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzQwOTQ5MA==","diff_hunk":"@@ -0,0 +1,71 @@\n+/**\n+ * @license\n+ * Copyright 2018 The FOAM Authors. All Rights Reserved.\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ */\n+\n+foam.INTERFACE({\n+  package: 'foam.nanos.auth',\n+  name: 'HumanNameTrait',\n+\n+  properties: [\n+    {\n+      class: 'String',\n+      name: 'firstName',\n+      tableWidth: 160,\n+      documentation: 'First name of user.',\n+      validateObj: function(firstName) {\n+        if ( firstName.length > 70 ) {\n+          return 'First name cannot exceed 70 characters.';\n+        }\n+\n+        if ( /\\d/.test(firstName) ) {\n+          return 'First name cannot contain numbers.';\n+        }\n+      }\n+    },\n+    {\n+      class: 'String',\n+      name: 'middleName',\n+      documentation: 'Middle name of user.',\n+      validateObj: function(middleName) {\n+        if ( middleName.length > 70 ) {\n+          return 'Middle name cannot exceed 70 characters.';\n+        }\n+\n+        if ( /\\d/.test(middleName) ) {","path":"src/foam/nanos/auth/HumanNameTrait.js","position":36,"original_position":36,"commit_id":"61178c8072dd233fce9da031f54fe319b15174c5","original_commit_id":"61178c8072dd233fce9da031f54fe319b15174c5","user":{"login":"adamvy","id":87934,"node_id":"MDQ6VXNlcjg3OTM0","avatar_url":"https://avatars2.githubusercontent.com/u/87934?v=4","gravatar_id":"","url":"https://api.github.com/users/adamvy","html_url":"https://github.com/adamvy","followers_url":"https://api.github.com/users/adamvy/followers","following_url":"https://api.github.com/users/adamvy/following{/other_user}","gists_url":"https://api.github.com/users/adamvy/gists{/gist_id}","starred_url":"https://api.github.com/users/adamvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamvy/subscriptions","organizations_url":"https://api.github.com/users/adamvy/orgs","repos_url":"https://api.github.com/users/adamvy/repos","events_url":"https://api.github.com/users/adamvy/events{/privacy}","received_events_url":"https://api.github.com/users/adamvy/received_events","type":"User","site_admin":false},"body":"Agree, although I disagree with the decision to disallow numbers in people's names.  Who are we to say that's valid or invalid.  I'm sure somebody somewhere has a digit in their name and I really don't see the value this extra \"validation\" is providing us.","created_at":"2018-08-28T17:45:07Z","updated_at":"2018-08-28T17:45:07Z","html_url":"https://github.com/foam-framework/foam2/pull/1528#discussion_r213409490","pull_request_url":"https://api.github.com/repos/foam-framework/foam2/pulls/1528","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/213409490"},"html":{"href":"https://github.com/foam-framework/foam2/pull/1528#discussion_r213409490"},"pull_request":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/1528"}},"in_reply_to_id":213386425},"pull_request":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/1528","id":211483530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDgzNTMw","html_url":"https://github.com/foam-framework/foam2/pull/1528","diff_url":"https://github.com/foam-framework/foam2/pull/1528.diff","patch_url":"https://github.com/foam-framework/foam2/pull/1528.patch","issue_url":"https://api.github.com/repos/foam-framework/foam2/issues/1528","number":1528,"state":"open","locked":false,"title":"Create human name trait","user":{"login":"TW80000","id":4259165,"node_id":"MDQ6VXNlcjQyNTkxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4259165?v=4","gravatar_id":"","url":"https://api.github.com/users/TW80000","html_url":"https://github.com/TW80000","followers_url":"https://api.github.com/users/TW80000/followers","following_url":"https://api.github.com/users/TW80000/following{/other_user}","gists_url":"https://api.github.com/users/TW80000/gists{/gist_id}","starred_url":"https://api.github.com/users/TW80000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TW80000/subscriptions","organizations_url":"https://api.github.com/users/TW80000/orgs","repos_url":"https://api.github.com/users/TW80000/repos","events_url":"https://api.github.com/users/TW80000/events{/privacy}","received_events_url":"https://api.github.com/users/TW80000/received_events","type":"User","site_admin":false},"body":"This looks pointless on its own, but it this got merged then in the nanopay repo we could use this for contacts as originally suggested here: https://github.com/nanoPayinc/NANOPAY/pull/3358/files/7ca73a988330a11afd0316e173e1a408fba3aa33#r213310409","created_at":"2018-08-28T16:28:45Z","updated_at":"2018-08-28T17:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49dae960674b81f85f7d5afeed3e1122dd2c13fe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adamvy","id":87934,"node_id":"MDQ6VXNlcjg3OTM0","avatar_url":"https://avatars2.githubusercontent.com/u/87934?v=4","gravatar_id":"","url":"https://api.github.com/users/adamvy","html_url":"https://github.com/adamvy","followers_url":"https://api.github.com/users/adamvy/followers","following_url":"https://api.github.com/users/adamvy/following{/other_user}","gists_url":"https://api.github.com/users/adamvy/gists{/gist_id}","starred_url":"https://api.github.com/users/adamvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamvy/subscriptions","organizations_url":"https://api.github.com/users/adamvy/orgs","repos_url":"https://api.github.com/users/adamvy/repos","events_url":"https://api.github.com/users/adamvy/events{/privacy}","received_events_url":"https://api.github.com/users/adamvy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1019586488,"node_id":"MDU6TGFiZWwxMDE5NTg2NDg4","url":"https://api.github.com/repos/foam-framework/foam2/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/foam-framework/foam2/pulls/1528/commits","review_comments_url":"https://api.github.com/repos/foam-framework/foam2/pulls/1528/comments","review_comment_url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foam-framework/foam2/issues/1528/comments","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/61178c8072dd233fce9da031f54fe319b15174c5","head":{"label":"TW80000:human-name-trait","ref":"human-name-trait","sha":"61178c8072dd233fce9da031f54fe319b15174c5","user":{"login":"TW80000","id":4259165,"node_id":"MDQ6VXNlcjQyNTkxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4259165?v=4","gravatar_id":"","url":"https://api.github.com/users/TW80000","html_url":"https://github.com/TW80000","followers_url":"https://api.github.com/users/TW80000/followers","following_url":"https://api.github.com/users/TW80000/following{/other_user}","gists_url":"https://api.github.com/users/TW80000/gists{/gist_id}","starred_url":"https://api.github.com/users/TW80000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TW80000/subscriptions","organizations_url":"https://api.github.com/users/TW80000/orgs","repos_url":"https://api.github.com/users/TW80000/repos","events_url":"https://api.github.com/users/TW80000/events{/privacy}","received_events_url":"https://api.github.com/users/TW80000/received_events","type":"User","site_admin":false},"repo":{"id":135491629,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0OTE2Mjk=","name":"foam2","full_name":"TW80000/foam2","owner":{"login":"TW80000","id":4259165,"node_id":"MDQ6VXNlcjQyNTkxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4259165?v=4","gravatar_id":"","url":"https://api.github.com/users/TW80000","html_url":"https://github.com/TW80000","followers_url":"https://api.github.com/users/TW80000/followers","following_url":"https://api.github.com/users/TW80000/following{/other_user}","gists_url":"https://api.github.com/users/TW80000/gists{/gist_id}","starred_url":"https://api.github.com/users/TW80000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TW80000/subscriptions","organizations_url":"https://api.github.com/users/TW80000/orgs","repos_url":"https://api.github.com/users/TW80000/repos","events_url":"https://api.github.com/users/TW80000/events{/privacy}","received_events_url":"https://api.github.com/users/TW80000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TW80000/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":true,"url":"https://api.github.com/repos/TW80000/foam2","forks_url":"https://api.github.com/repos/TW80000/foam2/forks","keys_url":"https://api.github.com/repos/TW80000/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TW80000/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TW80000/foam2/teams","hooks_url":"https://api.github.com/repos/TW80000/foam2/hooks","issue_events_url":"https://api.github.com/repos/TW80000/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/TW80000/foam2/events","assignees_url":"https://api.github.com/repos/TW80000/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/TW80000/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/TW80000/foam2/tags","blobs_url":"https://api.github.com/repos/TW80000/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TW80000/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TW80000/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/TW80000/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TW80000/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/TW80000/foam2/languages","stargazers_url":"https://api.github.com/repos/TW80000/foam2/stargazers","contributors_url":"https://api.github.com/repos/TW80000/foam2/contributors","subscribers_url":"https://api.github.com/repos/TW80000/foam2/subscribers","subscription_url":"https://api.github.com/repos/TW80000/foam2/subscription","commits_url":"https://api.github.com/repos/TW80000/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/TW80000/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/TW80000/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/TW80000/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/TW80000/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/TW80000/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TW80000/foam2/merges","archive_url":"https://api.github.com/repos/TW80000/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TW80000/foam2/downloads","issues_url":"https://api.github.com/repos/TW80000/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/TW80000/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/TW80000/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/TW80000/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TW80000/foam2/labels{/name}","releases_url":"https://api.github.com/repos/TW80000/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/TW80000/foam2/deployments","created_at":"2018-05-30T20:01:39Z","updated_at":"2018-05-30T20:01:43Z","pushed_at":"2018-08-28T16:31:12Z","git_url":"git://github.com/TW80000/foam2.git","ssh_url":"git@github.com:TW80000/foam2.git","clone_url":"https://github.com/TW80000/foam2.git","svn_url":"https://github.com/TW80000/foam2","homepage":"","size":18147,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foam-framework:master","ref":"master","sha":"ecbc15e48dc35c649e5e5e23f957e327007f16e7","user":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":50441060,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ0MTA2MA==","name":"foam2","full_name":"foam-framework/foam2","owner":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foam-framework/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":false,"url":"https://api.github.com/repos/foam-framework/foam2","forks_url":"https://api.github.com/repos/foam-framework/foam2/forks","keys_url":"https://api.github.com/repos/foam-framework/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foam-framework/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foam-framework/foam2/teams","hooks_url":"https://api.github.com/repos/foam-framework/foam2/hooks","issue_events_url":"https://api.github.com/repos/foam-framework/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/foam-framework/foam2/events","assignees_url":"https://api.github.com/repos/foam-framework/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/foam-framework/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/foam-framework/foam2/tags","blobs_url":"https://api.github.com/repos/foam-framework/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foam-framework/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foam-framework/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/foam-framework/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/foam-framework/foam2/languages","stargazers_url":"https://api.github.com/repos/foam-framework/foam2/stargazers","contributors_url":"https://api.github.com/repos/foam-framework/foam2/contributors","subscribers_url":"https://api.github.com/repos/foam-framework/foam2/subscribers","subscription_url":"https://api.github.com/repos/foam-framework/foam2/subscription","commits_url":"https://api.github.com/repos/foam-framework/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/foam-framework/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/foam-framework/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/foam-framework/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/foam-framework/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/foam-framework/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foam-framework/foam2/merges","archive_url":"https://api.github.com/repos/foam-framework/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foam-framework/foam2/downloads","issues_url":"https://api.github.com/repos/foam-framework/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/foam-framework/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/foam-framework/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/foam-framework/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foam-framework/foam2/labels{/name}","releases_url":"https://api.github.com/repos/foam-framework/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/foam-framework/foam2/deployments","created_at":"2016-01-26T16:13:38Z","updated_at":"2018-08-28T16:36:45Z","pushed_at":"2018-08-28T16:36:41Z","git_url":"git://github.com/foam-framework/foam2.git","ssh_url":"git@github.com:foam-framework/foam2.git","clone_url":"https://github.com/foam-framework/foam2.git","svn_url":"https://github.com/foam-framework/foam2","homepage":"","size":18131,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":168,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/1528"},"html":{"href":"https://github.com/foam-framework/foam2/pull/1528"},"issue":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/1528"},"comments":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/1528/comments"},"review_comments":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/1528/comments"},"review_comment":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/1528/commits"},"statuses":{"href":"https://api.github.com/repos/foam-framework/foam2/statuses/61178c8072dd233fce9da031f54fe319b15174c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adamvy"}}