{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/4758","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/4758/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/4758/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/4758/events","html_url":"https://github.com/storybooks/storybook/pull/4758","id":379167317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Njk4MDU3","number":4758,"title":"TypeScript POC: addon-notes","user":{"login":"kroeder","id":5478899,"node_id":"MDQ6VXNlcjU0Nzg4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5478899?v=4","gravatar_id":"","url":"https://api.github.com/users/kroeder","html_url":"https://github.com/kroeder","followers_url":"https://api.github.com/users/kroeder/followers","following_url":"https://api.github.com/users/kroeder/following{/other_user}","gists_url":"https://api.github.com/users/kroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeder/subscriptions","organizations_url":"https://api.github.com/users/kroeder/orgs","repos_url":"https://api.github.com/users/kroeder/repos","events_url":"https://api.github.com/users/kroeder/events{/privacy}","received_events_url":"https://api.github.com/users/kroeder/received_events","type":"User","site_admin":false},"labels":[{"id":577335281,"node_id":"MDU6TGFiZWw1NzczMzUyODE=","url":"https://api.github.com/repos/storybooks/storybook/labels/do%20not%20merge","name":"do not merge","color":"EB484F","default":false},{"id":603489924,"node_id":"MDU6TGFiZWw2MDM0ODk5MjQ=","url":"https://api.github.com/repos/storybooks/storybook/labels/maintenance","name":"maintenance","color":"aaaaaa","default":false},{"id":885024119,"node_id":"MDU6TGFiZWw4ODUwMjQxMTk=","url":"https://api.github.com/repos/storybooks/storybook/labels/typescript","name":"typescript","color":"42e58b","default":false}],"state":"open","locked":false,"assignee":{"login":"kroeder","id":5478899,"node_id":"MDQ6VXNlcjU0Nzg4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5478899?v=4","gravatar_id":"","url":"https://api.github.com/users/kroeder","html_url":"https://github.com/kroeder","followers_url":"https://api.github.com/users/kroeder/followers","following_url":"https://api.github.com/users/kroeder/following{/other_user}","gists_url":"https://api.github.com/users/kroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeder/subscriptions","organizations_url":"https://api.github.com/users/kroeder/orgs","repos_url":"https://api.github.com/users/kroeder/repos","events_url":"https://api.github.com/users/kroeder/events{/privacy}","received_events_url":"https://api.github.com/users/kroeder/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroeder","id":5478899,"node_id":"MDQ6VXNlcjU0Nzg4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5478899?v=4","gravatar_id":"","url":"https://api.github.com/users/kroeder","html_url":"https://github.com/kroeder","followers_url":"https://api.github.com/users/kroeder/followers","following_url":"https://api.github.com/users/kroeder/following{/other_user}","gists_url":"https://api.github.com/users/kroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeder/subscriptions","organizations_url":"https://api.github.com/users/kroeder/orgs","repos_url":"https://api.github.com/users/kroeder/repos","events_url":"https://api.github.com/users/kroeder/events{/privacy}","received_events_url":"https://api.github.com/users/kroeder/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-11-09T13:44:29Z","updated_at":"2018-12-06T22:10:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/4758","html_url":"https://github.com/storybooks/storybook/pull/4758","diff_url":"https://github.com/storybooks/storybook/pull/4758.diff","patch_url":"https://github.com/storybooks/storybook/pull/4758.patch"},"body":"Issue: N/A\r\n\r\n## What I did\r\n\r\n@ndelangen and I talked about doing a POC for TypeScript in Storybook\r\n\r\nThis POC needs to answer the following questions:\r\n- [ ] How does the transition from *.js to *.ts looks like for an example addon (I took addon-notes)\r\n  - I had to configure a couple of things that are now available for the next packages we might move to `ts`\r\n  - Renaming `*.js` to `*.ts` also might cause a couple of red lines. Mostly imports that must be used differently or type mismatches.\r\n  - Rewriting the code base took me about 1-2 hours. Most of the time I worked on this I had issues with the initial configuration\r\n- [ ] CI must pass with everything else working as usual\r\n  - I guess except `Danger` everything's green 🙂 \r\n- [ ] eslint must play along with tslint. They should not get in conflict\r\n  - It seems that `tslint` was already configured. I have not noticed any weird linting errors\r\n- [ ] Performance of `yarn dev` should not get significantly slower as it is right now\r\n  -  Just running `yarn dev:ts` is super fast, `yarn dev` is slow as usual ;)\r\n\r\n## What I found out\r\n- `tslint.json` already exists in the root directory, must check if it works\r\n- `yarn dev:ts` already searches for `tsconfig.json` files inside all workspaces. If it found one, it compiles the project to `.js`\r\n- `.tsx` files can be compiled to `.js` as well\r\n\r\n## Some side notes\r\n- The current implementation has room for e.g. outsourcing the interfaces in a seperate file or even re-use them in other files but since I'm not familiar with the actual implementation I decided to not make this as clean as possible in the POC\r\n- Some things might be not correct because I am not familiar with react but I've added todos on everything I need to figure out\r\n"},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/445048282","html_url":"https://github.com/storybooks/storybook/pull/4758#issuecomment-445048282","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/4758","id":445048282,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTA0ODI4Mg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-06T22:10:46Z","updated_at":"2018-12-06T22:10:46Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=h1) Report\n> Merging [#4758](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=desc) into [next](https://codecov.io/gh/storybooks/storybook/commit/ba8680f0fc862a51df246dda2c03b554bc6112e7?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/storybooks/storybook/pull/4758/graphs/tree.svg?width=650&token=cVp0HBIrZl&height=150&src=pr)](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             next   #4758      +/-   ##\n=========================================\n- Coverage   35.61%   35.6%   -0.01%     \n=========================================\n  Files         557     554       -3     \n  Lines        6776    6732      -44     \n  Branches      904     897       -7     \n=========================================\n- Hits         2413    2397      -16     \n+ Misses       3893    3865      -28     \n  Partials      470     470\n```\n\n\n| [Impacted Files](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [app/react/src/client/preview/index.js](https://codecov.io/gh/storybooks/storybook/pull/4758/diff?src=pr&el=tree#diff-YXBwL3JlYWN0L3NyYy9jbGllbnQvcHJldmlldy9pbmRleC5qcw==) | `0% <0%> (-100%)` | :arrow_down: |\n| [app/react/src/client/preview/globals.js](https://codecov.io/gh/storybooks/storybook/pull/4758/diff?src=pr&el=tree#diff-YXBwL3JlYWN0L3NyYy9jbGllbnQvcHJldmlldy9nbG9iYWxzLmpz) | `0% <0%> (-60%)` | :arrow_down: |\n| [app/react/src/client/preview/render.js](https://codecov.io/gh/storybooks/storybook/pull/4758/diff?src=pr&el=tree#diff-YXBwL3JlYWN0L3NyYy9jbGllbnQvcHJldmlldy9yZW5kZXIuanM=) | `0% <0%> (-7.7%)` | :arrow_down: |\n| [lib/components/src/layout/desktop.js](https://codecov.io/gh/storybooks/storybook/pull/4758/diff?src=pr&el=tree#diff-bGliL2NvbXBvbmVudHMvc3JjL2xheW91dC9kZXNrdG9wLmpz) | `74.13% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=footer). Last update [ba8680f...852973f](https://codecov.io/gh/storybooks/storybook/pull/4758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}