{"action":"created","comment":{"url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/comments/185542901","pull_request_review_id":116952336,"id":185542901,"diff_hunk":"@@ -63,13 +63,22 @@ Use the following environment variables to configure your container:\n |`INSP_ADMIN_NICK`        |`MI5`                           |Nick showed by the `/admin` command           |\n |`INSP_ADMIN_EMAIL`       |`jonny.english@example.com`     |E-mail shown by the `/admin` command          |\n |`INSP_ENABLE_DNSBL`      |`yes`                           |Set to `no` to disable DNSBLs                 |\n+|`INSP_CONNECT_PASSWORD`  |`` (empty)                      |Enables a server password, empty to disable   |","path":"README.md","position":4,"original_position":4,"commit_id":"698409385a7824c769c9c18664b22fe1cadc2141","original_commit_id":"698409385a7824c769c9c18664b22fe1cadc2141","user":{"login":"SISheogorath","id":8719867,"avatar_url":"https://avatars1.githubusercontent.com/u/8719867?v=4","gravatar_id":"","url":"https://api.github.com/users/SISheogorath","html_url":"https://github.com/SISheogorath","followers_url":"https://api.github.com/users/SISheogorath/followers","following_url":"https://api.github.com/users/SISheogorath/following{/other_user}","gists_url":"https://api.github.com/users/SISheogorath/gists{/gist_id}","starred_url":"https://api.github.com/users/SISheogorath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SISheogorath/subscriptions","organizations_url":"https://api.github.com/users/SISheogorath/orgs","repos_url":"https://api.github.com/users/SISheogorath/repos","events_url":"https://api.github.com/users/SISheogorath/events{/privacy}","received_events_url":"https://api.github.com/users/SISheogorath/received_events","type":"User","site_admin":false},"body":"Could you rename this to `INSP_CONNECT_PASSWORD_HASH` as we already do with the oper password? Because this can easily cause confusion.","created_at":"2018-05-02T15:41:23Z","updated_at":"2018-05-02T15:42:46Z","html_url":"https://github.com/inspircd/inspircd-docker/pull/75#discussion_r185542901","pull_request_url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/comments/185542901"},"html":{"href":"https://github.com/inspircd/inspircd-docker/pull/75#discussion_r185542901"},"pull_request":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75","id":185417429,"html_url":"https://github.com/inspircd/inspircd-docker/pull/75","diff_url":"https://github.com/inspircd/inspircd-docker/pull/75.diff","patch_url":"https://github.com/inspircd/inspircd-docker/pull/75.patch","issue_url":"https://api.github.com/repos/inspircd/inspircd-docker/issues/75","number":75,"state":"open","locked":false,"title":"Added environment variables INSP_CONNECT_HASH and INSP_CONNECT_PASSWORD","user":{"login":"kjelle","id":598905,"avatar_url":"https://avatars2.githubusercontent.com/u/598905?v=4","gravatar_id":"","url":"https://api.github.com/users/kjelle","html_url":"https://github.com/kjelle","followers_url":"https://api.github.com/users/kjelle/followers","following_url":"https://api.github.com/users/kjelle/following{/other_user}","gists_url":"https://api.github.com/users/kjelle/gists{/gist_id}","starred_url":"https://api.github.com/users/kjelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjelle/subscriptions","organizations_url":"https://api.github.com/users/kjelle/orgs","repos_url":"https://api.github.com/users/kjelle/repos","events_url":"https://api.github.com/users/kjelle/events{/privacy}","received_events_url":"https://api.github.com/users/kjelle/received_events","type":"User","site_admin":false},"body":"## Checklist\r\n\r\n- [x] Implementation\r\n- [x] Tests\r\n- [x] Docs\r\n\r\nFixes #74 \r\n\r\nAdded environment variables to control `hash` and `password` in the main connect block.\r\n\r\nAdded test script tests/connectConfigPassword.sh\r\n\r\nAdded the environmentvariables to README.md.","created_at":"2018-05-02T12:04:07Z","updated_at":"2018-05-02T15:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"133f3264b38ad54f7c388c86c5e9847e679ff9b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75/commits","review_comments_url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75/comments","review_comment_url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspircd/inspircd-docker/issues/75/comments","statuses_url":"https://api.github.com/repos/inspircd/inspircd-docker/statuses/698409385a7824c769c9c18664b22fe1cadc2141","head":{"label":"kjelle:issue74","ref":"issue74","sha":"698409385a7824c769c9c18664b22fe1cadc2141","user":{"login":"kjelle","id":598905,"avatar_url":"https://avatars2.githubusercontent.com/u/598905?v=4","gravatar_id":"","url":"https://api.github.com/users/kjelle","html_url":"https://github.com/kjelle","followers_url":"https://api.github.com/users/kjelle/followers","following_url":"https://api.github.com/users/kjelle/following{/other_user}","gists_url":"https://api.github.com/users/kjelle/gists{/gist_id}","starred_url":"https://api.github.com/users/kjelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjelle/subscriptions","organizations_url":"https://api.github.com/users/kjelle/orgs","repos_url":"https://api.github.com/users/kjelle/repos","events_url":"https://api.github.com/users/kjelle/events{/privacy}","received_events_url":"https://api.github.com/users/kjelle/received_events","type":"User","site_admin":false},"repo":{"id":131837350,"name":"inspircd-docker","full_name":"kjelle/inspircd-docker","owner":{"login":"kjelle","id":598905,"avatar_url":"https://avatars2.githubusercontent.com/u/598905?v=4","gravatar_id":"","url":"https://api.github.com/users/kjelle","html_url":"https://github.com/kjelle","followers_url":"https://api.github.com/users/kjelle/followers","following_url":"https://api.github.com/users/kjelle/following{/other_user}","gists_url":"https://api.github.com/users/kjelle/gists{/gist_id}","starred_url":"https://api.github.com/users/kjelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjelle/subscriptions","organizations_url":"https://api.github.com/users/kjelle/orgs","repos_url":"https://api.github.com/users/kjelle/repos","events_url":"https://api.github.com/users/kjelle/events{/privacy}","received_events_url":"https://api.github.com/users/kjelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjelle/inspircd-docker","description":"InspIRCd Docker Image","fork":true,"url":"https://api.github.com/repos/kjelle/inspircd-docker","forks_url":"https://api.github.com/repos/kjelle/inspircd-docker/forks","keys_url":"https://api.github.com/repos/kjelle/inspircd-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjelle/inspircd-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjelle/inspircd-docker/teams","hooks_url":"https://api.github.com/repos/kjelle/inspircd-docker/hooks","issue_events_url":"https://api.github.com/repos/kjelle/inspircd-docker/issues/events{/number}","events_url":"https://api.github.com/repos/kjelle/inspircd-docker/events","assignees_url":"https://api.github.com/repos/kjelle/inspircd-docker/assignees{/user}","branches_url":"https://api.github.com/repos/kjelle/inspircd-docker/branches{/branch}","tags_url":"https://api.github.com/repos/kjelle/inspircd-docker/tags","blobs_url":"https://api.github.com/repos/kjelle/inspircd-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjelle/inspircd-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjelle/inspircd-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjelle/inspircd-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjelle/inspircd-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/kjelle/inspircd-docker/languages","stargazers_url":"https://api.github.com/repos/kjelle/inspircd-docker/stargazers","contributors_url":"https://api.github.com/repos/kjelle/inspircd-docker/contributors","subscribers_url":"https://api.github.com/repos/kjelle/inspircd-docker/subscribers","subscription_url":"https://api.github.com/repos/kjelle/inspircd-docker/subscription","commits_url":"https://api.github.com/repos/kjelle/inspircd-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjelle/inspircd-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjelle/inspircd-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjelle/inspircd-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjelle/inspircd-docker/contents/{+path}","compare_url":"https://api.github.com/repos/kjelle/inspircd-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjelle/inspircd-docker/merges","archive_url":"https://api.github.com/repos/kjelle/inspircd-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjelle/inspircd-docker/downloads","issues_url":"https://api.github.com/repos/kjelle/inspircd-docker/issues{/number}","pulls_url":"https://api.github.com/repos/kjelle/inspircd-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/kjelle/inspircd-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/kjelle/inspircd-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjelle/inspircd-docker/labels{/name}","releases_url":"https://api.github.com/repos/kjelle/inspircd-docker/releases{/id}","deployments_url":"https://api.github.com/repos/kjelle/inspircd-docker/deployments","created_at":"2018-05-02T10:50:12Z","updated_at":"2018-05-02T10:50:13Z","pushed_at":"2018-05-02T12:02:54Z","git_url":"git://github.com/kjelle/inspircd-docker.git","ssh_url":"git@github.com:kjelle/inspircd-docker.git","clone_url":"https://github.com/kjelle/inspircd-docker.git","svn_url":"https://github.com/kjelle/inspircd-docker","homepage":"https://hub.docker.com/r/inspircd/inspircd-docker","size":153,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspircd:master","ref":"master","sha":"33932f9b4ab11ac7d8aa77fbde04582efef17fc0","user":{"login":"inspircd","id":1560750,"avatar_url":"https://avatars0.githubusercontent.com/u/1560750?v=4","gravatar_id":"","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"repo":{"id":73217690,"name":"inspircd-docker","full_name":"inspircd/inspircd-docker","owner":{"login":"inspircd","id":1560750,"avatar_url":"https://avatars0.githubusercontent.com/u/1560750?v=4","gravatar_id":"","url":"https://api.github.com/users/inspircd","html_url":"https://github.com/inspircd","followers_url":"https://api.github.com/users/inspircd/followers","following_url":"https://api.github.com/users/inspircd/following{/other_user}","gists_url":"https://api.github.com/users/inspircd/gists{/gist_id}","starred_url":"https://api.github.com/users/inspircd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspircd/subscriptions","organizations_url":"https://api.github.com/users/inspircd/orgs","repos_url":"https://api.github.com/users/inspircd/repos","events_url":"https://api.github.com/users/inspircd/events{/privacy}","received_events_url":"https://api.github.com/users/inspircd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspircd/inspircd-docker","description":"InspIRCd Docker Image","fork":false,"url":"https://api.github.com/repos/inspircd/inspircd-docker","forks_url":"https://api.github.com/repos/inspircd/inspircd-docker/forks","keys_url":"https://api.github.com/repos/inspircd/inspircd-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspircd/inspircd-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspircd/inspircd-docker/teams","hooks_url":"https://api.github.com/repos/inspircd/inspircd-docker/hooks","issue_events_url":"https://api.github.com/repos/inspircd/inspircd-docker/issues/events{/number}","events_url":"https://api.github.com/repos/inspircd/inspircd-docker/events","assignees_url":"https://api.github.com/repos/inspircd/inspircd-docker/assignees{/user}","branches_url":"https://api.github.com/repos/inspircd/inspircd-docker/branches{/branch}","tags_url":"https://api.github.com/repos/inspircd/inspircd-docker/tags","blobs_url":"https://api.github.com/repos/inspircd/inspircd-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspircd/inspircd-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspircd/inspircd-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspircd/inspircd-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspircd/inspircd-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/inspircd/inspircd-docker/languages","stargazers_url":"https://api.github.com/repos/inspircd/inspircd-docker/stargazers","contributors_url":"https://api.github.com/repos/inspircd/inspircd-docker/contributors","subscribers_url":"https://api.github.com/repos/inspircd/inspircd-docker/subscribers","subscription_url":"https://api.github.com/repos/inspircd/inspircd-docker/subscription","commits_url":"https://api.github.com/repos/inspircd/inspircd-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspircd/inspircd-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspircd/inspircd-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspircd/inspircd-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspircd/inspircd-docker/contents/{+path}","compare_url":"https://api.github.com/repos/inspircd/inspircd-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspircd/inspircd-docker/merges","archive_url":"https://api.github.com/repos/inspircd/inspircd-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspircd/inspircd-docker/downloads","issues_url":"https://api.github.com/repos/inspircd/inspircd-docker/issues{/number}","pulls_url":"https://api.github.com/repos/inspircd/inspircd-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/inspircd/inspircd-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/inspircd/inspircd-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspircd/inspircd-docker/labels{/name}","releases_url":"https://api.github.com/repos/inspircd/inspircd-docker/releases{/id}","deployments_url":"https://api.github.com/repos/inspircd/inspircd-docker/deployments","created_at":"2016-11-08T19:01:35Z","updated_at":"2018-05-02T12:18:03Z","pushed_at":"2018-05-02T12:04:08Z","git_url":"git://github.com/inspircd/inspircd-docker.git","ssh_url":"git@github.com:inspircd/inspircd-docker.git","clone_url":"https://github.com/inspircd/inspircd-docker.git","svn_url":"https://github.com/inspircd/inspircd-docker","homepage":"https://hub.docker.com/r/inspircd/inspircd-docker","size":151,"stargazers_count":18,"watchers_count":18,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":12,"open_issues":2,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75"},"html":{"href":"https://github.com/inspircd/inspircd-docker/pull/75"},"issue":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/issues/75"},"comments":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/inspircd/inspircd-docker/statuses/698409385a7824c769c9c18664b22fe1cadc2141"}},"author_association":"NONE"}}
{"actor":{"display_login":"SISheogorath"}}