{"action":"created","comment":{"url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/comments/239963344","pull_request_review_id":182895569,"id":239963344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk2MzM0NA==","diff_hunk":"@@ -7,7 +7,8 @@ Appenders for .NET logging frameworks which send data to Sumo Logic HTTP sources\n | In keeping with industry standard security best practices, as of May 31, 2018, the Sumo Logic service will only support TLS version 1.2 going forward. Verify that all connections to Sumo Logic endpoints are made from software that supports TLS 1.2. |\n \n # Prerequisites\n-* .NET 4.5 or later or .NET Standard 1.5\n+* .NET 4.5 or later or .NET Standard 1.5 (for NLog and Log4Net)\n+* .NET 4.6.1 or later or .NET Standard 2.0 (for Serilog)","path":"README.md","position":null,"original_position":6,"commit_id":"518c281e4385d858f709fa040fa9e7b3fdaa7a32","original_commit_id":"ecbc8c9320640d819182aa5cfd264369da8e26ce","user":{"login":"wdolek","id":352808,"node_id":"MDQ6VXNlcjM1MjgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/352808?v=4","gravatar_id":"","url":"https://api.github.com/users/wdolek","html_url":"https://github.com/wdolek","followers_url":"https://api.github.com/users/wdolek/followers","following_url":"https://api.github.com/users/wdolek/following{/other_user}","gists_url":"https://api.github.com/users/wdolek/gists{/gist_id}","starred_url":"https://api.github.com/users/wdolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdolek/subscriptions","organizations_url":"https://api.github.com/users/wdolek/orgs","repos_url":"https://api.github.com/users/wdolek/repos","events_url":"https://api.github.com/users/wdolek/events{/privacy}","received_events_url":"https://api.github.com/users/wdolek/received_events","type":"User","site_admin":false},"body":"@bin3377 In my original project I was simply following guidance from [Cross-platform targeting](https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/cross-platform-targeting).\r\n\r\nSince I was _adding_ new project, I kept it like that. Now I lowered it to .NET 4.5 so current users of SumoLogic won't need to do upgrade when using SeriLog. (... despite I believe those people *should* update)","created_at":"2018-12-07T22:20:39Z","updated_at":"2018-12-07T22:20:39Z","html_url":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67#discussion_r239963344","pull_request_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/comments/239963344"},"html":{"href":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67#discussion_r239963344"},"pull_request":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67"}},"in_reply_to_id":238001201},"pull_request":{"url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67","id":231755428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzU1NDI4","html_url":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67","diff_url":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67.diff","patch_url":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67.patch","issue_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/67","number":67,"state":"open","locked":false,"title":"Introduce Serilog sink","user":{"login":"wdolek","id":352808,"node_id":"MDQ6VXNlcjM1MjgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/352808?v=4","gravatar_id":"","url":"https://api.github.com/users/wdolek","html_url":"https://github.com/wdolek","followers_url":"https://api.github.com/users/wdolek/followers","following_url":"https://api.github.com/users/wdolek/following{/other_user}","gists_url":"https://api.github.com/users/wdolek/gists{/gist_id}","starred_url":"https://api.github.com/users/wdolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdolek/subscriptions","organizations_url":"https://api.github.com/users/wdolek/orgs","repos_url":"https://api.github.com/users/wdolek/repos","events_url":"https://api.github.com/users/wdolek/events{/privacy}","received_events_url":"https://api.github.com/users/wdolek/received_events","type":"User","site_admin":false},"body":"Introducing new [Serilog](https://github.com/serilog) sink, getting inspired be already existing appenders for NLog and Log4Net. This is port of [W4k.Serilog.Sinks.SumoLogic](https://github.com/wdolek/w4k-serilog-sinks-sumologic) project.\r\n\r\n### Work done\r\n\r\n- added `SumoLogic.Logging.Serilog`, `SumoLogic.Logging.Serilog.Tests` and `SumoLogic.Logging.Serilog.Example`\r\n- exposing solution files via `.sln` so it is possible to change files from Visual Studio\r\n- adding additional `docs` directory with more detailed description of Serilog sink configuration\r\n- updating build scripts (please, verify it works)\r\n\r\n### Q&A\r\n\r\n#### Serilog.Sinks.SumoLogic is already thing!\r\n... but wait a minute, there's already [Serilog.Sinks.SumoLogic](https://github.com/billpratt/serilog-sinks-sumologic) by @billpratt , why bother?\r\n\r\nBill's implementation uses `HttpClient` directly in order to push events. On very bad circumstances, this may not be ideal - event queue may grow, eating memory, nasty things could happen. In contrast _this_ implementation makes use of `SumoLogic.Logging.Common` - following implementation of already existing appenders - so it should be fine (or at least better... \"better\"?).\r\n\r\n#### Is this correct place?\r\n\r\nThis is all nice, but why don't you put it under Serilog project then?\r\n\r\nAs you can see, Serilog already contains plenty of sinks (that's how they call appender) and other components. I was already in contact with Serilog author and we agreed to either link W4k implementation, or maybe find place under SumoLogic project as it is related.","created_at":"2018-11-17T22:25:40Z","updated_at":"2018-12-07T22:20:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65058c1ee76ce1ce14d72680980b3332f838ace4","assignee":{"login":"bin3377","id":16766633,"node_id":"MDQ6VXNlcjE2NzY2NjMz","avatar_url":"https://avatars0.githubusercontent.com/u/16766633?v=4","gravatar_id":"","url":"https://api.github.com/users/bin3377","html_url":"https://github.com/bin3377","followers_url":"https://api.github.com/users/bin3377/followers","following_url":"https://api.github.com/users/bin3377/following{/other_user}","gists_url":"https://api.github.com/users/bin3377/gists{/gist_id}","starred_url":"https://api.github.com/users/bin3377/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bin3377/subscriptions","organizations_url":"https://api.github.com/users/bin3377/orgs","repos_url":"https://api.github.com/users/bin3377/repos","events_url":"https://api.github.com/users/bin3377/events{/privacy}","received_events_url":"https://api.github.com/users/bin3377/received_events","type":"User","site_admin":false},"assignees":[{"login":"bin3377","id":16766633,"node_id":"MDQ6VXNlcjE2NzY2NjMz","avatar_url":"https://avatars0.githubusercontent.com/u/16766633?v=4","gravatar_id":"","url":"https://api.github.com/users/bin3377","html_url":"https://github.com/bin3377","followers_url":"https://api.github.com/users/bin3377/followers","following_url":"https://api.github.com/users/bin3377/following{/other_user}","gists_url":"https://api.github.com/users/bin3377/gists{/gist_id}","starred_url":"https://api.github.com/users/bin3377/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bin3377/subscriptions","organizations_url":"https://api.github.com/users/bin3377/orgs","repos_url":"https://api.github.com/users/bin3377/repos","events_url":"https://api.github.com/users/bin3377/events{/privacy}","received_events_url":"https://api.github.com/users/bin3377/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67/commits","review_comments_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67/comments","review_comment_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/67/comments","statuses_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/statuses/518c281e4385d858f709fa040fa9e7b3fdaa7a32","head":{"label":"wdolek:feature/introduce-serilog-sink","ref":"feature/introduce-serilog-sink","sha":"518c281e4385d858f709fa040fa9e7b3fdaa7a32","user":{"login":"wdolek","id":352808,"node_id":"MDQ6VXNlcjM1MjgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/352808?v=4","gravatar_id":"","url":"https://api.github.com/users/wdolek","html_url":"https://github.com/wdolek","followers_url":"https://api.github.com/users/wdolek/followers","following_url":"https://api.github.com/users/wdolek/following{/other_user}","gists_url":"https://api.github.com/users/wdolek/gists{/gist_id}","starred_url":"https://api.github.com/users/wdolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdolek/subscriptions","organizations_url":"https://api.github.com/users/wdolek/orgs","repos_url":"https://api.github.com/users/wdolek/repos","events_url":"https://api.github.com/users/wdolek/events{/privacy}","received_events_url":"https://api.github.com/users/wdolek/received_events","type":"User","site_admin":false},"repo":{"id":157607571,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc2MDc1NzE=","name":"sumologic-net-appenders","full_name":"wdolek/sumologic-net-appenders","private":false,"owner":{"login":"wdolek","id":352808,"node_id":"MDQ6VXNlcjM1MjgwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/352808?v=4","gravatar_id":"","url":"https://api.github.com/users/wdolek","html_url":"https://github.com/wdolek","followers_url":"https://api.github.com/users/wdolek/followers","following_url":"https://api.github.com/users/wdolek/following{/other_user}","gists_url":"https://api.github.com/users/wdolek/gists{/gist_id}","starred_url":"https://api.github.com/users/wdolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdolek/subscriptions","organizations_url":"https://api.github.com/users/wdolek/orgs","repos_url":"https://api.github.com/users/wdolek/repos","events_url":"https://api.github.com/users/wdolek/events{/privacy}","received_events_url":"https://api.github.com/users/wdolek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wdolek/sumologic-net-appenders","description":"Several appenders for .NET developers to use that send logs straight to SumoLogic.","fork":true,"url":"https://api.github.com/repos/wdolek/sumologic-net-appenders","forks_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/forks","keys_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/teams","hooks_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/hooks","issue_events_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/issues/events{/number}","events_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/events","assignees_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/assignees{/user}","branches_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/branches{/branch}","tags_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/tags","blobs_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/statuses/{sha}","languages_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/languages","stargazers_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/stargazers","contributors_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/contributors","subscribers_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/subscribers","subscription_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/subscription","commits_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/contents/{+path}","compare_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/merges","archive_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/downloads","issues_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/issues{/number}","pulls_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/pulls{/number}","milestones_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/milestones{/number}","notifications_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/labels{/name}","releases_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/releases{/id}","deployments_url":"https://api.github.com/repos/wdolek/sumologic-net-appenders/deployments","created_at":"2018-11-14T20:35:09Z","updated_at":"2018-11-14T20:35:12Z","pushed_at":"2018-12-07T22:12:56Z","git_url":"git://github.com/wdolek/sumologic-net-appenders.git","ssh_url":"git@github.com:wdolek/sumologic-net-appenders.git","clone_url":"https://github.com/wdolek/sumologic-net-appenders.git","svn_url":"https://github.com/wdolek/sumologic-net-appenders","homepage":null,"size":19228,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SumoLogic:master","ref":"master","sha":"af2ba55de5a99d4efa8a8ab6c451d568e17505ca","user":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":39529827,"node_id":"MDEwOlJlcG9zaXRvcnkzOTUyOTgyNw==","name":"sumologic-net-appenders","full_name":"SumoLogic/sumologic-net-appenders","private":false,"owner":{"login":"SumoLogic","id":963817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MzgxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/963817?v=4","gravatar_id":"","url":"https://api.github.com/users/SumoLogic","html_url":"https://github.com/SumoLogic","followers_url":"https://api.github.com/users/SumoLogic/followers","following_url":"https://api.github.com/users/SumoLogic/following{/other_user}","gists_url":"https://api.github.com/users/SumoLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SumoLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumoLogic/subscriptions","organizations_url":"https://api.github.com/users/SumoLogic/orgs","repos_url":"https://api.github.com/users/SumoLogic/repos","events_url":"https://api.github.com/users/SumoLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SumoLogic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SumoLogic/sumologic-net-appenders","description":"Several appenders for .NET developers to use that send logs straight to SumoLogic.","fork":false,"url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders","forks_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/forks","keys_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/teams","hooks_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/hooks","issue_events_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/events{/number}","events_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/events","assignees_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/assignees{/user}","branches_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/branches{/branch}","tags_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/tags","blobs_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/statuses/{sha}","languages_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/languages","stargazers_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/stargazers","contributors_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/contributors","subscribers_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/subscribers","subscription_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/subscription","commits_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/contents/{+path}","compare_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/merges","archive_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/downloads","issues_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues{/number}","pulls_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls{/number}","milestones_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/milestones{/number}","notifications_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/labels{/name}","releases_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/releases{/id}","deployments_url":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/deployments","created_at":"2015-07-22T20:53:33Z","updated_at":"2018-11-30T21:56:47Z","pushed_at":"2018-12-07T22:12:57Z","git_url":"git://github.com/SumoLogic/sumologic-net-appenders.git","ssh_url":"git@github.com:SumoLogic/sumologic-net-appenders.git","clone_url":"https://github.com/SumoLogic/sumologic-net-appenders.git","svn_url":"https://github.com/SumoLogic/sumologic-net-appenders","homepage":null,"size":19212,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":6,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67"},"html":{"href":"https://github.com/SumoLogic/sumologic-net-appenders/pull/67"},"issue":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/67"},"comments":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/SumoLogic/sumologic-net-appenders/statuses/518c281e4385d858f709fa040fa9e7b3fdaa7a32"}},"author_association":"NONE"}}
{"actor":{"display_login":"wdolek"}}