{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/17media/LFLiveKit/pulls/14","id":224909815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTA5ODE1","html_url":"https://github.com/17media/LFLiveKit/pull/14","diff_url":"https://github.com/17media/LFLiveKit/pull/14.diff","patch_url":"https://github.com/17media/LFLiveKit/pull/14.patch","issue_url":"https://api.github.com/repos/17media/LFLiveKit/issues/14","number":14,"state":"closed","locked":false,"title":"[APP-6099] 幫幫Sheena 開直播閃爍","user":{"login":"hanchang17media","id":26700923,"node_id":"MDQ6VXNlcjI2NzAwOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/26700923?v=4","gravatar_id":"","url":"https://api.github.com/users/hanchang17media","html_url":"https://github.com/hanchang17media","followers_url":"https://api.github.com/users/hanchang17media/followers","following_url":"https://api.github.com/users/hanchang17media/following{/other_user}","gists_url":"https://api.github.com/users/hanchang17media/gists{/gist_id}","starred_url":"https://api.github.com/users/hanchang17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanchang17media/subscriptions","organizations_url":"https://api.github.com/users/hanchang17media/orgs","repos_url":"https://api.github.com/users/hanchang17media/repos","events_url":"https://api.github.com/users/hanchang17media/events{/privacy}","received_events_url":"https://api.github.com/users/hanchang17media/received_events","type":"User","site_admin":false},"body":"#### Why\r\n\r\n將浮水印畫至texture之前有可能沒有設定currentContext. 不應該在各個filter之間共用textureId, 會造成意外刪除或是覆蓋texture的問題.\r\n\r\n#### How\r\n\r\nSolution\r\n於建立每個filter時創建浮水印texture. 記在QBGLContext部份的設定只剩下watermarkView & 是否要鏡像的設定. 其餘浮水印設定都在每個filter內.\r\n\r\n#### Risk\r\n\r\nLow\r\n","created_at":"2018-10-23T06:23:20Z","updated_at":"2018-10-24T07:55:15Z","closed_at":"2018-10-24T07:55:15Z","merged_at":"2018-10-24T07:55:15Z","merge_commit_sha":"f28608375b39f0fb372b8203248d7c73639a8b88","assignee":{"login":"hanchang17media","id":26700923,"node_id":"MDQ6VXNlcjI2NzAwOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/26700923?v=4","gravatar_id":"","url":"https://api.github.com/users/hanchang17media","html_url":"https://github.com/hanchang17media","followers_url":"https://api.github.com/users/hanchang17media/followers","following_url":"https://api.github.com/users/hanchang17media/following{/other_user}","gists_url":"https://api.github.com/users/hanchang17media/gists{/gist_id}","starred_url":"https://api.github.com/users/hanchang17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanchang17media/subscriptions","organizations_url":"https://api.github.com/users/hanchang17media/orgs","repos_url":"https://api.github.com/users/hanchang17media/repos","events_url":"https://api.github.com/users/hanchang17media/events{/privacy}","received_events_url":"https://api.github.com/users/hanchang17media/received_events","type":"User","site_admin":false},"assignees":[{"login":"hanchang17media","id":26700923,"node_id":"MDQ6VXNlcjI2NzAwOTIz","avatar_url":"https://avatars1.githubusercontent.com/u/26700923?v=4","gravatar_id":"","url":"https://api.github.com/users/hanchang17media","html_url":"https://github.com/hanchang17media","followers_url":"https://api.github.com/users/hanchang17media/followers","following_url":"https://api.github.com/users/hanchang17media/following{/other_user}","gists_url":"https://api.github.com/users/hanchang17media/gists{/gist_id}","starred_url":"https://api.github.com/users/hanchang17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanchang17media/subscriptions","organizations_url":"https://api.github.com/users/hanchang17media/orgs","repos_url":"https://api.github.com/users/hanchang17media/repos","events_url":"https://api.github.com/users/hanchang17media/events{/privacy}","received_events_url":"https://api.github.com/users/hanchang17media/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":532190967,"node_id":"MDU6TGFiZWw1MzIxOTA5Njc=","url":"https://api.github.com/repos/17media/LFLiveKit/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/17media/LFLiveKit/pulls/14/commits","review_comments_url":"https://api.github.com/repos/17media/LFLiveKit/pulls/14/comments","review_comment_url":"https://api.github.com/repos/17media/LFLiveKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/17media/LFLiveKit/issues/14/comments","statuses_url":"https://api.github.com/repos/17media/LFLiveKit/statuses/b038a21968b3414e1ef72687f0263ca2b94001b5","head":{"label":"17media:dev","ref":"dev","sha":"b038a21968b3414e1ef72687f0263ca2b94001b5","user":{"login":"17media","id":17403626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDAzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17403626?v=4","gravatar_id":"","url":"https://api.github.com/users/17media","html_url":"https://github.com/17media","followers_url":"https://api.github.com/users/17media/followers","following_url":"https://api.github.com/users/17media/following{/other_user}","gists_url":"https://api.github.com/users/17media/gists{/gist_id}","starred_url":"https://api.github.com/users/17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/17media/subscriptions","organizations_url":"https://api.github.com/users/17media/orgs","repos_url":"https://api.github.com/users/17media/repos","events_url":"https://api.github.com/users/17media/events{/privacy}","received_events_url":"https://api.github.com/users/17media/received_events","type":"Organization","site_admin":false},"repo":{"id":80935101,"node_id":"MDEwOlJlcG9zaXRvcnk4MDkzNTEwMQ==","name":"LFLiveKit","full_name":"17media/LFLiveKit","private":false,"owner":{"login":"17media","id":17403626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDAzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17403626?v=4","gravatar_id":"","url":"https://api.github.com/users/17media","html_url":"https://github.com/17media","followers_url":"https://api.github.com/users/17media/followers","following_url":"https://api.github.com/users/17media/following{/other_user}","gists_url":"https://api.github.com/users/17media/gists{/gist_id}","starred_url":"https://api.github.com/users/17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/17media/subscriptions","organizations_url":"https://api.github.com/users/17media/orgs","repos_url":"https://api.github.com/users/17media/repos","events_url":"https://api.github.com/users/17media/events{/privacy}","received_events_url":"https://api.github.com/users/17media/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/17media/LFLiveKit","description":"LaiFeng IOS Live Kit,H264 and AAC Hard coding，support GPUImage Beauty， rtmp transmission，weak network lost frame，Dynamic switching rate","fork":true,"url":"https://api.github.com/repos/17media/LFLiveKit","forks_url":"https://api.github.com/repos/17media/LFLiveKit/forks","keys_url":"https://api.github.com/repos/17media/LFLiveKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/17media/LFLiveKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/17media/LFLiveKit/teams","hooks_url":"https://api.github.com/repos/17media/LFLiveKit/hooks","issue_events_url":"https://api.github.com/repos/17media/LFLiveKit/issues/events{/number}","events_url":"https://api.github.com/repos/17media/LFLiveKit/events","assignees_url":"https://api.github.com/repos/17media/LFLiveKit/assignees{/user}","branches_url":"https://api.github.com/repos/17media/LFLiveKit/branches{/branch}","tags_url":"https://api.github.com/repos/17media/LFLiveKit/tags","blobs_url":"https://api.github.com/repos/17media/LFLiveKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/17media/LFLiveKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/17media/LFLiveKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/17media/LFLiveKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/17media/LFLiveKit/statuses/{sha}","languages_url":"https://api.github.com/repos/17media/LFLiveKit/languages","stargazers_url":"https://api.github.com/repos/17media/LFLiveKit/stargazers","contributors_url":"https://api.github.com/repos/17media/LFLiveKit/contributors","subscribers_url":"https://api.github.com/repos/17media/LFLiveKit/subscribers","subscription_url":"https://api.github.com/repos/17media/LFLiveKit/subscription","commits_url":"https://api.github.com/repos/17media/LFLiveKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/17media/LFLiveKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/17media/LFLiveKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/17media/LFLiveKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/17media/LFLiveKit/contents/{+path}","compare_url":"https://api.github.com/repos/17media/LFLiveKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/17media/LFLiveKit/merges","archive_url":"https://api.github.com/repos/17media/LFLiveKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/17media/LFLiveKit/downloads","issues_url":"https://api.github.com/repos/17media/LFLiveKit/issues{/number}","pulls_url":"https://api.github.com/repos/17media/LFLiveKit/pulls{/number}","milestones_url":"https://api.github.com/repos/17media/LFLiveKit/milestones{/number}","notifications_url":"https://api.github.com/repos/17media/LFLiveKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/17media/LFLiveKit/labels{/name}","releases_url":"https://api.github.com/repos/17media/LFLiveKit/releases{/id}","deployments_url":"https://api.github.com/repos/17media/LFLiveKit/deployments","created_at":"2017-02-04T17:22:08Z","updated_at":"2018-10-08T10:14:24Z","pushed_at":"2018-10-24T07:55:15Z","git_url":"git://github.com/17media/LFLiveKit.git","ssh_url":"git@github.com:17media/LFLiveKit.git","clone_url":"https://github.com/17media/LFLiveKit.git","svn_url":"https://github.com/17media/LFLiveKit","homepage":"","size":9294,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"17media:master","ref":"master","sha":"d6bf985840d314c21ab4cf8c19a8480f2567af1d","user":{"login":"17media","id":17403626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDAzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17403626?v=4","gravatar_id":"","url":"https://api.github.com/users/17media","html_url":"https://github.com/17media","followers_url":"https://api.github.com/users/17media/followers","following_url":"https://api.github.com/users/17media/following{/other_user}","gists_url":"https://api.github.com/users/17media/gists{/gist_id}","starred_url":"https://api.github.com/users/17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/17media/subscriptions","organizations_url":"https://api.github.com/users/17media/orgs","repos_url":"https://api.github.com/users/17media/repos","events_url":"https://api.github.com/users/17media/events{/privacy}","received_events_url":"https://api.github.com/users/17media/received_events","type":"Organization","site_admin":false},"repo":{"id":80935101,"node_id":"MDEwOlJlcG9zaXRvcnk4MDkzNTEwMQ==","name":"LFLiveKit","full_name":"17media/LFLiveKit","private":false,"owner":{"login":"17media","id":17403626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDAzNjI2","avatar_url":"https://avatars0.githubusercontent.com/u/17403626?v=4","gravatar_id":"","url":"https://api.github.com/users/17media","html_url":"https://github.com/17media","followers_url":"https://api.github.com/users/17media/followers","following_url":"https://api.github.com/users/17media/following{/other_user}","gists_url":"https://api.github.com/users/17media/gists{/gist_id}","starred_url":"https://api.github.com/users/17media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/17media/subscriptions","organizations_url":"https://api.github.com/users/17media/orgs","repos_url":"https://api.github.com/users/17media/repos","events_url":"https://api.github.com/users/17media/events{/privacy}","received_events_url":"https://api.github.com/users/17media/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/17media/LFLiveKit","description":"LaiFeng IOS Live Kit,H264 and AAC Hard coding，support GPUImage Beauty， rtmp transmission，weak network lost frame，Dynamic switching rate","fork":true,"url":"https://api.github.com/repos/17media/LFLiveKit","forks_url":"https://api.github.com/repos/17media/LFLiveKit/forks","keys_url":"https://api.github.com/repos/17media/LFLiveKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/17media/LFLiveKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/17media/LFLiveKit/teams","hooks_url":"https://api.github.com/repos/17media/LFLiveKit/hooks","issue_events_url":"https://api.github.com/repos/17media/LFLiveKit/issues/events{/number}","events_url":"https://api.github.com/repos/17media/LFLiveKit/events","assignees_url":"https://api.github.com/repos/17media/LFLiveKit/assignees{/user}","branches_url":"https://api.github.com/repos/17media/LFLiveKit/branches{/branch}","tags_url":"https://api.github.com/repos/17media/LFLiveKit/tags","blobs_url":"https://api.github.com/repos/17media/LFLiveKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/17media/LFLiveKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/17media/LFLiveKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/17media/LFLiveKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/17media/LFLiveKit/statuses/{sha}","languages_url":"https://api.github.com/repos/17media/LFLiveKit/languages","stargazers_url":"https://api.github.com/repos/17media/LFLiveKit/stargazers","contributors_url":"https://api.github.com/repos/17media/LFLiveKit/contributors","subscribers_url":"https://api.github.com/repos/17media/LFLiveKit/subscribers","subscription_url":"https://api.github.com/repos/17media/LFLiveKit/subscription","commits_url":"https://api.github.com/repos/17media/LFLiveKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/17media/LFLiveKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/17media/LFLiveKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/17media/LFLiveKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/17media/LFLiveKit/contents/{+path}","compare_url":"https://api.github.com/repos/17media/LFLiveKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/17media/LFLiveKit/merges","archive_url":"https://api.github.com/repos/17media/LFLiveKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/17media/LFLiveKit/downloads","issues_url":"https://api.github.com/repos/17media/LFLiveKit/issues{/number}","pulls_url":"https://api.github.com/repos/17media/LFLiveKit/pulls{/number}","milestones_url":"https://api.github.com/repos/17media/LFLiveKit/milestones{/number}","notifications_url":"https://api.github.com/repos/17media/LFLiveKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/17media/LFLiveKit/labels{/name}","releases_url":"https://api.github.com/repos/17media/LFLiveKit/releases{/id}","deployments_url":"https://api.github.com/repos/17media/LFLiveKit/deployments","created_at":"2017-02-04T17:22:08Z","updated_at":"2018-10-08T10:14:24Z","pushed_at":"2018-10-24T07:55:15Z","git_url":"git://github.com/17media/LFLiveKit.git","ssh_url":"git@github.com:17media/LFLiveKit.git","clone_url":"https://github.com/17media/LFLiveKit.git","svn_url":"https://github.com/17media/LFLiveKit","homepage":"","size":9294,"stargazers_count":7,"watchers_count":7,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/17media/LFLiveKit/pulls/14"},"html":{"href":"https://github.com/17media/LFLiveKit/pull/14"},"issue":{"href":"https://api.github.com/repos/17media/LFLiveKit/issues/14"},"comments":{"href":"https://api.github.com/repos/17media/LFLiveKit/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/17media/LFLiveKit/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/17media/LFLiveKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/17media/LFLiveKit/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/17media/LFLiveKit/statuses/b038a21968b3414e1ef72687f0263ca2b94001b5"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RacingWang","id":9023376,"node_id":"MDQ6VXNlcjkwMjMzNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/9023376?v=4","gravatar_id":"","url":"https://api.github.com/users/RacingWang","html_url":"https://github.com/RacingWang","followers_url":"https://api.github.com/users/RacingWang/followers","following_url":"https://api.github.com/users/RacingWang/following{/other_user}","gists_url":"https://api.github.com/users/RacingWang/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingWang/subscriptions","organizations_url":"https://api.github.com/users/RacingWang/orgs","repos_url":"https://api.github.com/users/RacingWang/repos","events_url":"https://api.github.com/users/RacingWang/events{/privacy}","received_events_url":"https://api.github.com/users/RacingWang/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":146,"deletions":178,"changed_files":19}}
{"actor":{"display_login":"RacingWang"}}