{"action":"created","comment":{"url":"https://api.github.com/repos/kythe/kythe/pulls/comments/232425321","pull_request_review_id":173630890,"id":232425321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQyNTMyMQ==","diff_hunk":"@@ -210,9 +212,9 @@ bool KytheMetadataSupport::LoadMetaElement(const rapidjson::Value& value,\n #undef JSON_SAFE_LOAD_STRING\n \n std::unique_ptr<MetadataFile> KytheMetadataSupport::LoadFromJSON(\n-    llvm::StringRef json) {\n+    absl::string_view json) {\n   rapidjson::Document document;\n-  document.Parse(json.str().c_str());\n+  document.Parse(std::string(json).c_str());","path":"kythe/cxx/common/kythe_metadata_file.cc","position":155,"original_position":155,"commit_id":"11c805df4532bdcb06fab157e7f1d55ebcfdab2b","original_commit_id":"11c805df4532bdcb06fab157e7f1d55ebcfdab2b","user":{"login":"shahms","id":2789440,"node_id":"MDQ6VXNlcjI3ODk0NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2789440?v=4","gravatar_id":"","url":"https://api.github.com/users/shahms","html_url":"https://github.com/shahms","followers_url":"https://api.github.com/users/shahms/followers","following_url":"https://api.github.com/users/shahms/following{/other_user}","gists_url":"https://api.github.com/users/shahms/gists{/gist_id}","starred_url":"https://api.github.com/users/shahms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahms/subscriptions","organizations_url":"https://api.github.com/users/shahms/orgs","repos_url":"https://api.github.com/users/shahms/repos","events_url":"https://api.github.com/users/shahms/events{/privacy}","received_events_url":"https://api.github.com/users/shahms/received_events","type":"User","site_admin":false},"body":"https://github.com/Tencent/rapidjson/blob/master/include/rapidjson/document.h#L2342\r\n\r\nIt does! we can save this copy and conversion to string.","created_at":"2018-11-09T23:47:28Z","updated_at":"2018-11-09T23:47:29Z","html_url":"https://github.com/kythe/kythe/pull/3243#discussion_r232425321","pull_request_url":"https://api.github.com/repos/kythe/kythe/pulls/3243","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kythe/kythe/pulls/comments/232425321"},"html":{"href":"https://github.com/kythe/kythe/pull/3243#discussion_r232425321"},"pull_request":{"href":"https://api.github.com/repos/kythe/kythe/pulls/3243"}},"in_reply_to_id":232423389},"pull_request":{"url":"https://api.github.com/repos/kythe/kythe/pulls/3243","id":229845991,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODQ1OTkx","html_url":"https://github.com/kythe/kythe/pull/3243","diff_url":"https://github.com/kythe/kythe/pull/3243.diff","patch_url":"https://github.com/kythe/kythe/pull/3243.patch","issue_url":"https://api.github.com/repos/kythe/kythe/issues/3243","number":3243,"state":"closed","locked":false,"title":"chore: remove the remaining llvm references from cxx/common (#945)","user":{"login":"zrlk","id":8932755,"node_id":"MDQ6VXNlcjg5MzI3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8932755?v=4","gravatar_id":"","url":"https://api.github.com/users/zrlk","html_url":"https://github.com/zrlk","followers_url":"https://api.github.com/users/zrlk/followers","following_url":"https://api.github.com/users/zrlk/following{/other_user}","gists_url":"https://api.github.com/users/zrlk/gists{/gist_id}","starred_url":"https://api.github.com/users/zrlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrlk/subscriptions","organizations_url":"https://api.github.com/users/zrlk/orgs","repos_url":"https://api.github.com/users/zrlk/repos","events_url":"https://api.github.com/users/zrlk/events{/privacy}","received_events_url":"https://api.github.com/users/zrlk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-09T23:19:13Z","updated_at":"2018-11-09T23:47:29Z","closed_at":"2018-11-09T23:33:14Z","merged_at":"2018-11-09T23:33:14Z","merge_commit_sha":"02dd296249f737838d079cda1cd5d0ee3905f423","assignee":null,"assignees":[],"requested_reviewers":[{"login":"salguarnieri","id":10076680,"node_id":"MDQ6VXNlcjEwMDc2Njgw","avatar_url":"https://avatars2.githubusercontent.com/u/10076680?v=4","gravatar_id":"","url":"https://api.github.com/users/salguarnieri","html_url":"https://github.com/salguarnieri","followers_url":"https://api.github.com/users/salguarnieri/followers","following_url":"https://api.github.com/users/salguarnieri/following{/other_user}","gists_url":"https://api.github.com/users/salguarnieri/gists{/gist_id}","starred_url":"https://api.github.com/users/salguarnieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salguarnieri/subscriptions","organizations_url":"https://api.github.com/users/salguarnieri/orgs","repos_url":"https://api.github.com/users/salguarnieri/repos","events_url":"https://api.github.com/users/salguarnieri/events{/privacy}","received_events_url":"https://api.github.com/users/salguarnieri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1024495230,"node_id":"MDU6TGFiZWwxMDI0NDk1MjMw","url":"https://api.github.com/repos/kythe/kythe/labels/cla:%20yes","name":"cla: yes","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kythe/kythe/pulls/3243/commits","review_comments_url":"https://api.github.com/repos/kythe/kythe/pulls/3243/comments","review_comment_url":"https://api.github.com/repos/kythe/kythe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kythe/kythe/issues/3243/comments","statuses_url":"https://api.github.com/repos/kythe/kythe/statuses/11c805df4532bdcb06fab157e7f1d55ebcfdab2b","head":{"label":"zrlk:nollvm","ref":"nollvm","sha":"11c805df4532bdcb06fab157e7f1d55ebcfdab2b","user":{"login":"zrlk","id":8932755,"node_id":"MDQ6VXNlcjg5MzI3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8932755?v=4","gravatar_id":"","url":"https://api.github.com/users/zrlk","html_url":"https://github.com/zrlk","followers_url":"https://api.github.com/users/zrlk/followers","following_url":"https://api.github.com/users/zrlk/following{/other_user}","gists_url":"https://api.github.com/users/zrlk/gists{/gist_id}","starred_url":"https://api.github.com/users/zrlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrlk/subscriptions","organizations_url":"https://api.github.com/users/zrlk/orgs","repos_url":"https://api.github.com/users/zrlk/repos","events_url":"https://api.github.com/users/zrlk/events{/privacy}","received_events_url":"https://api.github.com/users/zrlk/received_events","type":"User","site_admin":false},"repo":{"id":134444285,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NDQyODU=","name":"kythe","full_name":"zrlk/kythe","private":false,"owner":{"login":"zrlk","id":8932755,"node_id":"MDQ6VXNlcjg5MzI3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8932755?v=4","gravatar_id":"","url":"https://api.github.com/users/zrlk","html_url":"https://github.com/zrlk","followers_url":"https://api.github.com/users/zrlk/followers","following_url":"https://api.github.com/users/zrlk/following{/other_user}","gists_url":"https://api.github.com/users/zrlk/gists{/gist_id}","starred_url":"https://api.github.com/users/zrlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrlk/subscriptions","organizations_url":"https://api.github.com/users/zrlk/orgs","repos_url":"https://api.github.com/users/zrlk/repos","events_url":"https://api.github.com/users/zrlk/events{/privacy}","received_events_url":"https://api.github.com/users/zrlk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zrlk/kythe","description":"Kythe is a pluggable, (mostly) language-agnostic ecosystem for building tools that work with code.","fork":true,"url":"https://api.github.com/repos/zrlk/kythe","forks_url":"https://api.github.com/repos/zrlk/kythe/forks","keys_url":"https://api.github.com/repos/zrlk/kythe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zrlk/kythe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zrlk/kythe/teams","hooks_url":"https://api.github.com/repos/zrlk/kythe/hooks","issue_events_url":"https://api.github.com/repos/zrlk/kythe/issues/events{/number}","events_url":"https://api.github.com/repos/zrlk/kythe/events","assignees_url":"https://api.github.com/repos/zrlk/kythe/assignees{/user}","branches_url":"https://api.github.com/repos/zrlk/kythe/branches{/branch}","tags_url":"https://api.github.com/repos/zrlk/kythe/tags","blobs_url":"https://api.github.com/repos/zrlk/kythe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zrlk/kythe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zrlk/kythe/git/refs{/sha}","trees_url":"https://api.github.com/repos/zrlk/kythe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zrlk/kythe/statuses/{sha}","languages_url":"https://api.github.com/repos/zrlk/kythe/languages","stargazers_url":"https://api.github.com/repos/zrlk/kythe/stargazers","contributors_url":"https://api.github.com/repos/zrlk/kythe/contributors","subscribers_url":"https://api.github.com/repos/zrlk/kythe/subscribers","subscription_url":"https://api.github.com/repos/zrlk/kythe/subscription","commits_url":"https://api.github.com/repos/zrlk/kythe/commits{/sha}","git_commits_url":"https://api.github.com/repos/zrlk/kythe/git/commits{/sha}","comments_url":"https://api.github.com/repos/zrlk/kythe/comments{/number}","issue_comment_url":"https://api.github.com/repos/zrlk/kythe/issues/comments{/number}","contents_url":"https://api.github.com/repos/zrlk/kythe/contents/{+path}","compare_url":"https://api.github.com/repos/zrlk/kythe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zrlk/kythe/merges","archive_url":"https://api.github.com/repos/zrlk/kythe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zrlk/kythe/downloads","issues_url":"https://api.github.com/repos/zrlk/kythe/issues{/number}","pulls_url":"https://api.github.com/repos/zrlk/kythe/pulls{/number}","milestones_url":"https://api.github.com/repos/zrlk/kythe/milestones{/number}","notifications_url":"https://api.github.com/repos/zrlk/kythe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zrlk/kythe/labels{/name}","releases_url":"https://api.github.com/repos/zrlk/kythe/releases{/id}","deployments_url":"https://api.github.com/repos/zrlk/kythe/deployments","created_at":"2018-05-22T16:32:51Z","updated_at":"2018-11-09T23:35:06Z","pushed_at":"2018-11-09T23:45:11Z","git_url":"git://github.com/zrlk/kythe.git","ssh_url":"git@github.com:zrlk/kythe.git","clone_url":"https://github.com/zrlk/kythe.git","svn_url":"https://github.com/zrlk/kythe","homepage":"https://kythe.io","size":164815,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kythe:master","ref":"master","sha":"9c451f9de287f9f9340cb10a3c217b2d2b99c043","user":{"login":"kythe","id":44679334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Njc5MzM0","avatar_url":"https://avatars3.githubusercontent.com/u/44679334?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"Organization","site_admin":false},"repo":{"id":29174627,"node_id":"MDEwOlJlcG9zaXRvcnkyOTE3NDYyNw==","name":"kythe","full_name":"kythe/kythe","private":false,"owner":{"login":"kythe","id":44679334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0Njc5MzM0","avatar_url":"https://avatars3.githubusercontent.com/u/44679334?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kythe/kythe","description":"Kythe is a pluggable, (mostly) language-agnostic ecosystem for building tools that work with code.","fork":false,"url":"https://api.github.com/repos/kythe/kythe","forks_url":"https://api.github.com/repos/kythe/kythe/forks","keys_url":"https://api.github.com/repos/kythe/kythe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kythe/kythe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kythe/kythe/teams","hooks_url":"https://api.github.com/repos/kythe/kythe/hooks","issue_events_url":"https://api.github.com/repos/kythe/kythe/issues/events{/number}","events_url":"https://api.github.com/repos/kythe/kythe/events","assignees_url":"https://api.github.com/repos/kythe/kythe/assignees{/user}","branches_url":"https://api.github.com/repos/kythe/kythe/branches{/branch}","tags_url":"https://api.github.com/repos/kythe/kythe/tags","blobs_url":"https://api.github.com/repos/kythe/kythe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kythe/kythe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kythe/kythe/git/refs{/sha}","trees_url":"https://api.github.com/repos/kythe/kythe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kythe/kythe/statuses/{sha}","languages_url":"https://api.github.com/repos/kythe/kythe/languages","stargazers_url":"https://api.github.com/repos/kythe/kythe/stargazers","contributors_url":"https://api.github.com/repos/kythe/kythe/contributors","subscribers_url":"https://api.github.com/repos/kythe/kythe/subscribers","subscription_url":"https://api.github.com/repos/kythe/kythe/subscription","commits_url":"https://api.github.com/repos/kythe/kythe/commits{/sha}","git_commits_url":"https://api.github.com/repos/kythe/kythe/git/commits{/sha}","comments_url":"https://api.github.com/repos/kythe/kythe/comments{/number}","issue_comment_url":"https://api.github.com/repos/kythe/kythe/issues/comments{/number}","contents_url":"https://api.github.com/repos/kythe/kythe/contents/{+path}","compare_url":"https://api.github.com/repos/kythe/kythe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kythe/kythe/merges","archive_url":"https://api.github.com/repos/kythe/kythe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kythe/kythe/downloads","issues_url":"https://api.github.com/repos/kythe/kythe/issues{/number}","pulls_url":"https://api.github.com/repos/kythe/kythe/pulls{/number}","milestones_url":"https://api.github.com/repos/kythe/kythe/milestones{/number}","notifications_url":"https://api.github.com/repos/kythe/kythe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kythe/kythe/labels{/name}","releases_url":"https://api.github.com/repos/kythe/kythe/releases{/id}","deployments_url":"https://api.github.com/repos/kythe/kythe/deployments","created_at":"2015-01-13T05:39:06Z","updated_at":"2018-11-09T23:33:17Z","pushed_at":"2018-11-09T23:45:12Z","git_url":"git://github.com/kythe/kythe.git","ssh_url":"git@github.com:kythe/kythe.git","clone_url":"https://github.com/kythe/kythe.git","svn_url":"https://github.com/kythe/kythe","homepage":"https://kythe.io","size":164815,"stargazers_count":1100,"watchers_count":1100,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":175,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":141,"open_issues":175,"watchers":1100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kythe/kythe/pulls/3243"},"html":{"href":"https://github.com/kythe/kythe/pull/3243"},"issue":{"href":"https://api.github.com/repos/kythe/kythe/issues/3243"},"comments":{"href":"https://api.github.com/repos/kythe/kythe/issues/3243/comments"},"review_comments":{"href":"https://api.github.com/repos/kythe/kythe/pulls/3243/comments"},"review_comment":{"href":"https://api.github.com/repos/kythe/kythe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kythe/kythe/pulls/3243/commits"},"statuses":{"href":"https://api.github.com/repos/kythe/kythe/statuses/11c805df4532bdcb06fab157e7f1d55ebcfdab2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shahms"}}