{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/9688","repository_url":"https://api.github.com/repos/coreos/etcd","labels_url":"https://api.github.com/repos/coreos/etcd/issues/9688/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/9688/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/9688/events","html_url":"https://github.com/coreos/etcd/pull/9688","id":320069670,"number":9688,"title":"etcdctl/ctlv3: fix watch with exec commands, interactive mode flag parsing","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars0.githubusercontent.com/u/6799218?v=4","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"labels":[{"id":258824920,"url":"https://api.github.com/repos/coreos/etcd/labels/Release-Backport/v3.3","name":"Release-Backport/v3.3","color":"40C4FF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T20:32:19Z","updated_at":"2018-05-04T01:44:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/9688","html_url":"https://github.com/coreos/etcd/pull/9688","diff_url":"https://github.com/coreos/etcd/pull/9688.diff","patch_url":"https://github.com/coreos/etcd/pull/9688.patch"},"body":"Following command was failing because the parser incorrectly\r\npicks up the second \"watch\" string in exec command, thus\r\npassing wrong exec commands.\r\n\r\n```\r\nETCDCTL_API=3 ./bin/etcdctl watch aaa -- echo watch event received\r\n\r\npanic: runtime error: slice bounds out of range\r\n\r\ngoroutine 1 [running]:\r\ngithub.com/coreos/etcd/etcdctl/ctlv3/command.parseWatchArgs(0xc42002e080, 0x8, 0x8, 0xc420206a20, 0x5, 0x6, 0x0, 0x0, 0x0, 0x0, ...)\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:303 +0xbed\r\ngithub.com/coreos/etcd/etcdctl/ctlv3/command.watchCommandFunc(0xc4202a7180, 0xc420206a20, 0x5, 0x6)\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:73 +0x11d\r\ngithub.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202a7180, 0xc420206960, 0x6, 0x6, 0xc4202a7180, 0xc420206960)\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:766 +0x2c1\r\ngithub.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1363de0, 0xc420128638, 0xc420185e01, 0xc420185ee8)\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:852 +0x30a\r\ngithub.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).Execute(0x1363de0, 0x0, 0x0)\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:800 +0x2b\r\ngithub.com/coreos/etcd/etcdctl/ctlv3.Start()\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/ctl_nocov.go:25 +0x8e\r\nmain.main()\r\n\t/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/main.go:40 +0x17b\r\n```\r\n\r\nShould fix `TestCtlV3AuthAndWatch` and `TestCtlV3WatchNoTLS` in coverage tests.\r\n\r\nhttps://github.com/coreos/etcd/pull/9684"},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/386486306","html_url":"https://github.com/coreos/etcd/pull/9688#issuecomment-386486306","issue_url":"https://api.github.com/repos/coreos/etcd/issues/9688","id":386486306,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T01:44:35Z","updated_at":"2018-05-04T01:44:35Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`master@2ad0acd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `73.43%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/coreos/etcd/pull/9688/graphs/tree.svg?src=pr&token=so7nNovJo3&width=650&height=150)](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master    #9688   +/-   ##\n=========================================\n  Coverage          ?   68.91%           \n=========================================\n  Files             ?      373           \n  Lines             ?    34829           \n  Branches          ?        0           \n=========================================\n  Hits              ?    24001           \n  Misses            ?     9110           \n  Partials          ?     1718\n```\n\n\n| [Impacted Files](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [etcdctl/ctlv3/command/watch\\_command.go](https://codecov.io/gh/coreos/etcd/pull/9688/diff?src=pr&el=tree#diff-ZXRjZGN0bC9jdGx2My9jb21tYW5kL3dhdGNoX2NvbW1hbmQuZ28=) | `47.09% <73.43%> (ø)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=footer). Last update [2ad0acd...38fcfb6](https://codecov.io/gh/coreos/etcd/pull/9688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}