{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments/220176456","pull_request_review_id":158521037,"id":220176456,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDE3NjQ1Ng==","diff_hunk":"@@ -52,19 +68,41 @@ class ServiceFabrikAdminController extends FabrikBaseController {\n           });\n         });\n     }\n-    logger.info(`Forbidden Manifest flag set to ${allowForbiddenManifestChanges}`);\n-    if (allowForbiddenManifestChanges === false) {\n-      const instanceId = this.parseServiceInstanceIdFromDeployment(deploymentName);\n-      return this\n-        .getServicePlanIdForInstanceId(instanceId)\n-        .then(planId => this.getOutdatedDiff(deploymentName, catalog.getPlan(planId)))\n-        .then(diff => utils.hasChangesInForbiddenSections(diff))\n-        .tap(() => logger.info(`Doing update for ${deploymentName} as there is no forbidden changes in manifest`))\n-        .then(() => updateDeployment());\n-    } else {\n-      logger.info(`Doing update for ${deploymentName} even if forbidden changes exist in manifest`);\n-      return updateDeployment();\n-    }\n+\n+    return Promise.try(() => {\n+      logger.info(`Forbidden Manifest flag set to ${allowForbiddenManifestChanges}`);\n+      return eventmesh.apiServerClient.getResource({\n+          resourceGroup: CONST.APISERVER.RESOURCE_GROUPS.DEPLOYMENT,\n+          resourceType: CONST.APISERVER.RESOURCE_TYPES.DIRECTOR,\n+          resourceId: instanceId\n+        })\n+        .catch(errors.NotFound, () => undefined)\n+        .then(resource => _.get(resource, 'spec.options'))\n+        .then(resource => {\n+          resourceDetails = resource;\n+          if (resourceDetails === undefined) {\n+            throw new errors.NotFound(`Resource details of service instance ${instanceId} not found in api server.`);","path":"api-controllers/ServiceFabrikAdminController.js","position":83,"original_position":83,"commit_id":"9219c3b008ff4aecb901be8d8230e652c062beae","original_commit_id":"9219c3b008ff4aecb901be8d8230e652c062beae","user":{"login":"subhankarc","id":3734410,"node_id":"MDQ6VXNlcjM3MzQ0MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3734410?v=4","gravatar_id":"","url":"https://api.github.com/users/subhankarc","html_url":"https://github.com/subhankarc","followers_url":"https://api.github.com/users/subhankarc/followers","following_url":"https://api.github.com/users/subhankarc/following{/other_user}","gists_url":"https://api.github.com/users/subhankarc/gists{/gist_id}","starred_url":"https://api.github.com/users/subhankarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhankarc/subscriptions","organizations_url":"https://api.github.com/users/subhankarc/orgs","repos_url":"https://api.github.com/users/subhankarc/repos","events_url":"https://api.github.com/users/subhankarc/events{/privacy}","received_events_url":"https://api.github.com/users/subhankarc/received_events","type":"User","site_admin":false},"body":"recource details should be fine.","created_at":"2018-09-25T12:45:45Z","updated_at":"2018-09-25T12:45:45Z","html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415#discussion_r220176456","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments/220176456"},"html":{"href":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415#discussion_r220176456"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415"}},"in_reply_to_id":220171518},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415","id":217929990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTI5OTkw","html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415","diff_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415.diff","patch_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/415","number":415,"state":"open","locked":false,"title":"Added support to decouple cf update in admin update api","user":{"login":"sauravmndl","id":17878349,"node_id":"MDQ6VXNlcjE3ODc4MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/17878349?v=4","gravatar_id":"","url":"https://api.github.com/users/sauravmndl","html_url":"https://github.com/sauravmndl","followers_url":"https://api.github.com/users/sauravmndl/followers","following_url":"https://api.github.com/users/sauravmndl/following{/other_user}","gists_url":"https://api.github.com/users/sauravmndl/gists{/gist_id}","starred_url":"https://api.github.com/users/sauravmndl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauravmndl/subscriptions","organizations_url":"https://api.github.com/users/sauravmndl/orgs","repos_url":"https://api.github.com/users/sauravmndl/repos","events_url":"https://api.github.com/users/sauravmndl/events{/privacy}","received_events_url":"https://api.github.com/users/sauravmndl/received_events","type":"User","site_admin":false},"body":"1. Decoupled cf update\r\n2. For instance space guid, org guid calling api server instead of cf","created_at":"2018-09-25T10:29:36Z","updated_at":"2018-09-25T12:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6071d3a0207fce5ac07899ff909ec6c84cd55f44","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jagadish-kb","id":5938952,"node_id":"MDQ6VXNlcjU5Mzg5NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/5938952?v=4","gravatar_id":"","url":"https://api.github.com/users/jagadish-kb","html_url":"https://github.com/jagadish-kb","followers_url":"https://api.github.com/users/jagadish-kb/followers","following_url":"https://api.github.com/users/jagadish-kb/following{/other_user}","gists_url":"https://api.github.com/users/jagadish-kb/gists{/gist_id}","starred_url":"https://api.github.com/users/jagadish-kb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagadish-kb/subscriptions","organizations_url":"https://api.github.com/users/jagadish-kb/orgs","repos_url":"https://api.github.com/users/jagadish-kb/repos","events_url":"https://api.github.com/users/jagadish-kb/events{/privacy}","received_events_url":"https://api.github.com/users/jagadish-kb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":776019882,"node_id":"MDU6TGFiZWw3NzYwMTk4ODI=","url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/415/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/9219c3b008ff4aecb901be8d8230e652c062beae","head":{"label":"sauravmndl:decouple-cf-admin-update","ref":"decouple-cf-admin-update","sha":"9219c3b008ff4aecb901be8d8230e652c062beae","user":{"login":"sauravmndl","id":17878349,"node_id":"MDQ6VXNlcjE3ODc4MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/17878349?v=4","gravatar_id":"","url":"https://api.github.com/users/sauravmndl","html_url":"https://github.com/sauravmndl","followers_url":"https://api.github.com/users/sauravmndl/followers","following_url":"https://api.github.com/users/sauravmndl/following{/other_user}","gists_url":"https://api.github.com/users/sauravmndl/gists{/gist_id}","starred_url":"https://api.github.com/users/sauravmndl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauravmndl/subscriptions","organizations_url":"https://api.github.com/users/sauravmndl/orgs","repos_url":"https://api.github.com/users/sauravmndl/repos","events_url":"https://api.github.com/users/sauravmndl/events{/privacy}","received_events_url":"https://api.github.com/users/sauravmndl/received_events","type":"User","site_admin":false},"repo":{"id":122488808,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0ODg4MDg=","name":"service-fabrik-broker","full_name":"sauravmndl/service-fabrik-broker","private":false,"owner":{"login":"sauravmndl","id":17878349,"node_id":"MDQ6VXNlcjE3ODc4MzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/17878349?v=4","gravatar_id":"","url":"https://api.github.com/users/sauravmndl","html_url":"https://github.com/sauravmndl","followers_url":"https://api.github.com/users/sauravmndl/followers","following_url":"https://api.github.com/users/sauravmndl/following{/other_user}","gists_url":"https://api.github.com/users/sauravmndl/gists{/gist_id}","starred_url":"https://api.github.com/users/sauravmndl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauravmndl/subscriptions","organizations_url":"https://api.github.com/users/sauravmndl/orgs","repos_url":"https://api.github.com/users/sauravmndl/repos","events_url":"https://api.github.com/users/sauravmndl/events{/privacy}","received_events_url":"https://api.github.com/users/sauravmndl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sauravmndl/service-fabrik-broker","description":"Cloud Foundry service broker which provisions service instances as Docker containers and BOSH deployments.","fork":true,"url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker","forks_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/forks","keys_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/teams","hooks_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/hooks","issue_events_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/issues/events{/number}","events_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/events","assignees_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/assignees{/user}","branches_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/branches{/branch}","tags_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/tags","blobs_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/languages","stargazers_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/stargazers","contributors_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/contributors","subscribers_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/subscribers","subscription_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/subscription","commits_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/contents/{+path}","compare_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/merges","archive_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/downloads","issues_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/issues{/number}","pulls_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/labels{/name}","releases_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/releases{/id}","deployments_url":"https://api.github.com/repos/sauravmndl/service-fabrik-broker/deployments","created_at":"2018-02-22T14:22:38Z","updated_at":"2018-09-25T07:14:57Z","pushed_at":"2018-09-25T10:29:22Z","git_url":"git://github.com/sauravmndl/service-fabrik-broker.git","ssh_url":"git@github.com:sauravmndl/service-fabrik-broker.git","clone_url":"https://github.com/sauravmndl/service-fabrik-broker.git","svn_url":"https://github.com/sauravmndl/service-fabrik-broker","homepage":"","size":6096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry-incubator:master","ref":"master","sha":"d5aae7a0df5026592d0f0de0c7fe188b4c5e9d70","user":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68716409,"node_id":"MDEwOlJlcG9zaXRvcnk2ODcxNjQwOQ==","name":"service-fabrik-broker","full_name":"cloudfoundry-incubator/service-fabrik-broker","private":false,"owner":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker","description":"Cloud Foundry service broker which provisions service instances as Docker containers and BOSH deployments.","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/deployments","created_at":"2016-09-20T13:48:13Z","updated_at":"2018-09-24T10:04:55Z","pushed_at":"2018-09-25T10:48:36Z","git_url":"git://github.com/cloudfoundry-incubator/service-fabrik-broker.git","ssh_url":"git@github.com:cloudfoundry-incubator/service-fabrik-broker.git","clone_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker.git","svn_url":"https://github.com/cloudfoundry-incubator/service-fabrik-broker","homepage":"","size":7570,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":17,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415"},"html":{"href":"https://github.com/cloudfoundry-incubator/service-fabrik-broker/pull/415"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/415"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/service-fabrik-broker/statuses/9219c3b008ff4aecb901be8d8230e652c062beae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"subhankarc"}}