{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/comments/197536591","pull_request_review_id":131307059,"id":197536591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzUzNjU5MQ==","diff_hunk":"@@ -24,12 +24,18 @@\n   \"homepage\": \"https://github.com/imbcmdth/hls-fetcher#readme\",\n   \"dependencies\": {\n     \"aes-decrypter\": \"^1.0.2\",\n+    \"async\": \"^2.6.1\",\n     \"bluebird\": \"^3.4.0\",\n     \"m3u8-parser\": \"^1.0.2\",\n     \"mkdirp\": \"^0.5.1\",\n     \"pessimist\": \"^0.3.5\",\n     \"promise-streams\": \"^1.0.1\",\n+    \"request\": \"^2.87.0\",","path":"package.json","position":19,"original_position":19,"commit_id":"76f1f0b0fc3aa3be52cf5ded29dc3157ec40a2b6","original_commit_id":"76f1f0b0fc3aa3be52cf5ded29dc3157ec40a2b6","user":{"login":"gkatsev","id":535884,"node_id":"MDQ6VXNlcjUzNTg4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/535884?v=4","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"are we trying to make this module work in the browser as well as in node?","created_at":"2018-06-22T18:47:16Z","updated_at":"2018-06-22T18:47:17Z","html_url":"https://github.com/videojs/hls-fetcher/pull/22#discussion_r197536591","pull_request_url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/comments/197536591"},"html":{"href":"https://github.com/videojs/hls-fetcher/pull/22#discussion_r197536591"},"pull_request":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22"}},"in_reply_to_id":197534134},"pull_request":{"url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22","id":196637188,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjM3MTg4","html_url":"https://github.com/videojs/hls-fetcher/pull/22","diff_url":"https://github.com/videojs/hls-fetcher/pull/22.diff","patch_url":"https://github.com/videojs/hls-fetcher/pull/22.patch","issue_url":"https://api.github.com/repos/videojs/hls-fetcher/issues/22","number":22,"state":"open","locked":false,"title":"Async using callbacks;","user":{"login":"grsin","id":7452262,"node_id":"MDQ6VXNlcjc0NTIyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7452262?v=4","gravatar_id":"","url":"https://api.github.com/users/grsin","html_url":"https://github.com/grsin","followers_url":"https://api.github.com/users/grsin/followers","following_url":"https://api.github.com/users/grsin/following{/other_user}","gists_url":"https://api.github.com/users/grsin/gists{/gist_id}","starred_url":"https://api.github.com/users/grsin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grsin/subscriptions","organizations_url":"https://api.github.com/users/grsin/orgs","repos_url":"https://api.github.com/users/grsin/repos","events_url":"https://api.github.com/users/grsin/events{/privacy}","received_events_url":"https://api.github.com/users/grsin/received_events","type":"User","site_admin":false},"body":"Tested using:\r\n```\r\nconst newwalk = require('./src/walk-manifest.js');\r\nconst oldwalk = require('../../hls-fetcher/src/walk-manifest');\r\nconst assert = require('assert');\r\n\r\nconst urls = ['http://qthttp.apple.com.edgesuite.net/1010qwoeiuryfg/sl.m3u8',\r\n  'http://devimages.apple.com/iphone/samples/bipbop/bipbopall.m3u8',\r\n  'http://devimages.apple.com/iphone/samples/bipbop/gear1/prog_index.m3u8',\r\n  'http://playertest.longtailvideo.com/adaptive/oceans_aes/oceans_aes.m3u8',\r\n  'http://playertest.longtailvideo.com/adaptive/captions/playlist.m3u8',\r\n  'http://playertest.longtailvideo.com/adaptive/wowzaid3/playlist.m3u8',\r\n  'http://content.jwplatform.com/manifests/vM7nH0Kl.m3u8',\r\n  'http://cdn-fms.rbs.com.br/hls-vod/sample1_1500kbps.f4v.m3u8',\r\n  'http://sample.vodobox.net/skate_phantom_flex_4k/skate_phantom_flex_4k.m3u8',\r\n  'https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8',\r\n  'https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8',\r\n  'https://mnmedias.api.telequebec.tv/m3u8/29880.m3u8'];\r\n\r\nurls.forEach(function(url) {\r\n  console.log('Checking ' + url);\r\n  newwalk(false, '.', url, function(err, newResources) {\r\n    const oldResources = oldwalk(false, '.', url);\r\n    assert.deepStrictEqual(newResources, oldResources, 'NO Decrypt | ASYNC VS SYNC should be the same')\r\n  });\r\n\r\n  newwalk(true, '.', url, function(err, newResources) {\r\n    const oldResources = oldwalk(true, '.', url);\r\n    assert.deepStrictEqual(newResources, oldResources, 'Decrypt |ASYNC VS SYNC should be the same')\r\n  });\r\n});\r\n```\r\n\r\nAlso I couldn't tell what exact style you guys were following; but I guess as mentioned in a different PR - linting will get added so maybe we lint it there? Or I can change it back to just match as much as possible as before.","created_at":"2018-06-22T04:50:03Z","updated_at":"2018-06-22T18:47:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5de8cb1609d568536543763f462ee48e8de9e118","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22/commits","review_comments_url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22/comments","review_comment_url":"https://api.github.com/repos/videojs/hls-fetcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/hls-fetcher/issues/22/comments","statuses_url":"https://api.github.com/repos/videojs/hls-fetcher/statuses/76f1f0b0fc3aa3be52cf5ded29dc3157ec40a2b6","head":{"label":"grsin:callback","ref":"callback","sha":"76f1f0b0fc3aa3be52cf5ded29dc3157ec40a2b6","user":{"login":"grsin","id":7452262,"node_id":"MDQ6VXNlcjc0NTIyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7452262?v=4","gravatar_id":"","url":"https://api.github.com/users/grsin","html_url":"https://github.com/grsin","followers_url":"https://api.github.com/users/grsin/followers","following_url":"https://api.github.com/users/grsin/following{/other_user}","gists_url":"https://api.github.com/users/grsin/gists{/gist_id}","starred_url":"https://api.github.com/users/grsin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grsin/subscriptions","organizations_url":"https://api.github.com/users/grsin/orgs","repos_url":"https://api.github.com/users/grsin/repos","events_url":"https://api.github.com/users/grsin/events{/privacy}","received_events_url":"https://api.github.com/users/grsin/received_events","type":"User","site_admin":false},"repo":{"id":138241565,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNDE1NjU=","name":"hls-fetcher","full_name":"grsin/hls-fetcher","owner":{"login":"grsin","id":7452262,"node_id":"MDQ6VXNlcjc0NTIyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7452262?v=4","gravatar_id":"","url":"https://api.github.com/users/grsin","html_url":"https://github.com/grsin","followers_url":"https://api.github.com/users/grsin/followers","following_url":"https://api.github.com/users/grsin/following{/other_user}","gists_url":"https://api.github.com/users/grsin/gists{/gist_id}","starred_url":"https://api.github.com/users/grsin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grsin/subscriptions","organizations_url":"https://api.github.com/users/grsin/orgs","repos_url":"https://api.github.com/users/grsin/repos","events_url":"https://api.github.com/users/grsin/events{/privacy}","received_events_url":"https://api.github.com/users/grsin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grsin/hls-fetcher","description":null,"fork":true,"url":"https://api.github.com/repos/grsin/hls-fetcher","forks_url":"https://api.github.com/repos/grsin/hls-fetcher/forks","keys_url":"https://api.github.com/repos/grsin/hls-fetcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grsin/hls-fetcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grsin/hls-fetcher/teams","hooks_url":"https://api.github.com/repos/grsin/hls-fetcher/hooks","issue_events_url":"https://api.github.com/repos/grsin/hls-fetcher/issues/events{/number}","events_url":"https://api.github.com/repos/grsin/hls-fetcher/events","assignees_url":"https://api.github.com/repos/grsin/hls-fetcher/assignees{/user}","branches_url":"https://api.github.com/repos/grsin/hls-fetcher/branches{/branch}","tags_url":"https://api.github.com/repos/grsin/hls-fetcher/tags","blobs_url":"https://api.github.com/repos/grsin/hls-fetcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grsin/hls-fetcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grsin/hls-fetcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/grsin/hls-fetcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grsin/hls-fetcher/statuses/{sha}","languages_url":"https://api.github.com/repos/grsin/hls-fetcher/languages","stargazers_url":"https://api.github.com/repos/grsin/hls-fetcher/stargazers","contributors_url":"https://api.github.com/repos/grsin/hls-fetcher/contributors","subscribers_url":"https://api.github.com/repos/grsin/hls-fetcher/subscribers","subscription_url":"https://api.github.com/repos/grsin/hls-fetcher/subscription","commits_url":"https://api.github.com/repos/grsin/hls-fetcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/grsin/hls-fetcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/grsin/hls-fetcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/grsin/hls-fetcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/grsin/hls-fetcher/contents/{+path}","compare_url":"https://api.github.com/repos/grsin/hls-fetcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grsin/hls-fetcher/merges","archive_url":"https://api.github.com/repos/grsin/hls-fetcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grsin/hls-fetcher/downloads","issues_url":"https://api.github.com/repos/grsin/hls-fetcher/issues{/number}","pulls_url":"https://api.github.com/repos/grsin/hls-fetcher/pulls{/number}","milestones_url":"https://api.github.com/repos/grsin/hls-fetcher/milestones{/number}","notifications_url":"https://api.github.com/repos/grsin/hls-fetcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grsin/hls-fetcher/labels{/name}","releases_url":"https://api.github.com/repos/grsin/hls-fetcher/releases{/id}","deployments_url":"https://api.github.com/repos/grsin/hls-fetcher/deployments","created_at":"2018-06-22T01:49:57Z","updated_at":"2018-06-22T01:49:59Z","pushed_at":"2018-06-22T17:55:10Z","git_url":"git://github.com/grsin/hls-fetcher.git","ssh_url":"git@github.com:grsin/hls-fetcher.git","clone_url":"https://github.com/grsin/hls-fetcher.git","svn_url":"https://github.com/grsin/hls-fetcher","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"8b7884b8d0ae34f57ede2d5fbc82e940abe228ee","user":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":45928036,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkyODAzNg==","name":"hls-fetcher","full_name":"videojs/hls-fetcher","owner":{"login":"videojs","id":3287189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODcxODk=","avatar_url":"https://avatars2.githubusercontent.com/u/3287189?v=4","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/hls-fetcher","description":null,"fork":false,"url":"https://api.github.com/repos/videojs/hls-fetcher","forks_url":"https://api.github.com/repos/videojs/hls-fetcher/forks","keys_url":"https://api.github.com/repos/videojs/hls-fetcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/hls-fetcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/hls-fetcher/teams","hooks_url":"https://api.github.com/repos/videojs/hls-fetcher/hooks","issue_events_url":"https://api.github.com/repos/videojs/hls-fetcher/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/hls-fetcher/events","assignees_url":"https://api.github.com/repos/videojs/hls-fetcher/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/hls-fetcher/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/hls-fetcher/tags","blobs_url":"https://api.github.com/repos/videojs/hls-fetcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/hls-fetcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/hls-fetcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/hls-fetcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/hls-fetcher/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/hls-fetcher/languages","stargazers_url":"https://api.github.com/repos/videojs/hls-fetcher/stargazers","contributors_url":"https://api.github.com/repos/videojs/hls-fetcher/contributors","subscribers_url":"https://api.github.com/repos/videojs/hls-fetcher/subscribers","subscription_url":"https://api.github.com/repos/videojs/hls-fetcher/subscription","commits_url":"https://api.github.com/repos/videojs/hls-fetcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/hls-fetcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/hls-fetcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/hls-fetcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/hls-fetcher/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/hls-fetcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/hls-fetcher/merges","archive_url":"https://api.github.com/repos/videojs/hls-fetcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/hls-fetcher/downloads","issues_url":"https://api.github.com/repos/videojs/hls-fetcher/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/hls-fetcher/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/hls-fetcher/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/hls-fetcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/hls-fetcher/labels{/name}","releases_url":"https://api.github.com/repos/videojs/hls-fetcher/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/hls-fetcher/deployments","created_at":"2015-11-10T17:21:24Z","updated_at":"2018-06-21T21:20:13Z","pushed_at":"2018-06-22T17:55:11Z","git_url":"git://github.com/videojs/hls-fetcher.git","ssh_url":"git@github.com:videojs/hls-fetcher.git","clone_url":"https://github.com/videojs/hls-fetcher.git","svn_url":"https://github.com/videojs/hls-fetcher","homepage":null,"size":50,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":28,"open_issues":5,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22"},"html":{"href":"https://github.com/videojs/hls-fetcher/pull/22"},"issue":{"href":"https://api.github.com/repos/videojs/hls-fetcher/issues/22"},"comments":{"href":"https://api.github.com/repos/videojs/hls-fetcher/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/hls-fetcher/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/hls-fetcher/statuses/76f1f0b0fc3aa3be52cf5ded29dc3157ec40a2b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gkatsev"}}