{"action":"created","comment":{"url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/comments/184079426","pull_request_review_id":115201374,"id":184079426,"diff_hunk":"@@ -1,5 +1,9 @@\n language: node_js\n node_js:\n   - 8.11.1\n+script: npm run lint && npm test\n before_script:\n   - npm install -g grunt-cli\n+cache:\n+  directories:\n+    - \"node_modules\"","path":".travis.yml","position":9,"original_position":9,"commit_id":"5b15cb03d9a7d46bbed201e81e5562ea8390f140","original_commit_id":"5b15cb03d9a7d46bbed201e81e5562ea8390f140","user":{"login":"andrey-p","id":1431577,"avatar_url":"https://avatars1.githubusercontent.com/u/1431577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-p","html_url":"https://github.com/andrey-p","followers_url":"https://api.github.com/users/andrey-p/followers","following_url":"https://api.github.com/users/andrey-p/following{/other_user}","gists_url":"https://api.github.com/users/andrey-p/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-p/subscriptions","organizations_url":"https://api.github.com/users/andrey-p/orgs","repos_url":"https://api.github.com/users/andrey-p/repos","events_url":"https://api.github.com/users/andrey-p/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-p/received_events","type":"User","site_admin":false},"body":"Not really related to this PR, but it caches the `node_modules` directory between CI runs (updating it where necessary). It should speed things up by a lot.","created_at":"2018-04-25T14:26:35Z","updated_at":"2018-04-25T14:51:43Z","html_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212#discussion_r184079426","pull_request_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/comments/184079426"},"html":{"href":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212#discussion_r184079426"},"pull_request":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212","id":184054381,"html_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212","diff_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212.diff","patch_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212.patch","issue_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/212","number":212,"state":"open","locked":false,"title":"Lint manual fixes","user":{"login":"andrey-p","id":1431577,"avatar_url":"https://avatars1.githubusercontent.com/u/1431577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-p","html_url":"https://github.com/andrey-p","followers_url":"https://api.github.com/users/andrey-p/followers","following_url":"https://api.github.com/users/andrey-p/following{/other_user}","gists_url":"https://api.github.com/users/andrey-p/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-p/subscriptions","organizations_url":"https://api.github.com/users/andrey-p/orgs","repos_url":"https://api.github.com/users/andrey-p/repos","events_url":"https://api.github.com/users/andrey-p/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-p/received_events","type":"User","site_admin":false},"body":"<!-- Please add the WIP label if the PR isn't complete. -->\r\n\r\n**Reviewer:** TBD\r\n\r\n**CC:** @dharb @MariagraziaAlastra @jdorweiler @russellholt \r\n\r\n## Description:\r\n\r\nFixes a lot of small tweaks that Lint was complaining about. Some of them are nitpicky, but I figured we might as well do them. A couple are possible bugs.\r\n\r\n## Steps to test this PR:\r\n\r\nSee inline.\r\n\r\n## Automated tests:\r\n- [ ] Unit tests\r\n- [ ] Integration tests\r\n\r\n###### Reviewer Checklist:\r\n- [ ] **Ensure the PR solves the problem**\r\n- [ ] **Review every line of code**\r\n- [ ] **Ensure the PR does no harm by testing the changes thoroughly**\r\n- [ ] **Get help if you're uncomfortable with any of the above!**\r\n- [ ] Determine if there are any quick wins that improve the implementation\r\n\r\n\r\n###### PR Author Checklist:\r\n- [ ] Get advice or leverage existing code\r\n- [ ] Agree on technical approach with reviewer (if the changes are nuanced)\r\n- [ ] Ensure that there is a testing strategy (and documented non-automated tests)\r\n- [ ] Ensure there is a documented monitoring strategy (if necessary)\r\n- [ ] Consider systems implications \r\n","created_at":"2018-04-25T14:25:25Z","updated_at":"2018-04-25T14:51:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e999025985ee68eeb20f6c7807c3a272ac618d4","assignee":{"login":"andrey-p","id":1431577,"avatar_url":"https://avatars1.githubusercontent.com/u/1431577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-p","html_url":"https://github.com/andrey-p","followers_url":"https://api.github.com/users/andrey-p/followers","following_url":"https://api.github.com/users/andrey-p/following{/other_user}","gists_url":"https://api.github.com/users/andrey-p/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-p/subscriptions","organizations_url":"https://api.github.com/users/andrey-p/orgs","repos_url":"https://api.github.com/users/andrey-p/repos","events_url":"https://api.github.com/users/andrey-p/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-p/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrey-p","id":1431577,"avatar_url":"https://avatars1.githubusercontent.com/u/1431577?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-p","html_url":"https://github.com/andrey-p","followers_url":"https://api.github.com/users/andrey-p/followers","following_url":"https://api.github.com/users/andrey-p/following{/other_user}","gists_url":"https://api.github.com/users/andrey-p/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-p/subscriptions","organizations_url":"https://api.github.com/users/andrey-p/orgs","repos_url":"https://api.github.com/users/andrey-p/repos","events_url":"https://api.github.com/users/andrey-p/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-p/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":782197439,"url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/labels/WIP","name":"WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212/commits","review_comments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212/comments","review_comment_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/212/comments","statuses_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/statuses/5b15cb03d9a7d46bbed201e81e5562ea8390f140","head":{"label":"duckduckgo:andrey/lint-manual-fixes","ref":"andrey/lint-manual-fixes","sha":"5b15cb03d9a7d46bbed201e81e5562ea8390f140","user":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars2.githubusercontent.com/u/342708?v=4","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"repo":{"id":113919648,"name":"duckduckgo-privacy-extension","full_name":"duckduckgo/duckduckgo-privacy-extension","owner":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars2.githubusercontent.com/u/342708?v=4","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension","description":"DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome, Safari.","fork":false,"url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension","forks_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/forks","keys_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/teams","hooks_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/hooks","issue_events_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/events{/number}","events_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/events","assignees_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/assignees{/user}","branches_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/branches{/branch}","tags_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/tags","blobs_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/languages","stargazers_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/stargazers","contributors_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/contributors","subscribers_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/subscribers","subscription_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/subscription","commits_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/contents/{+path}","compare_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/merges","archive_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/downloads","issues_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues{/number}","pulls_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/labels{/name}","releases_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/releases{/id}","deployments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/deployments","created_at":"2017-12-11T23:26:44Z","updated_at":"2018-04-23T21:25:40Z","pushed_at":"2018-04-25T14:25:26Z","git_url":"git://github.com/duckduckgo/duckduckgo-privacy-extension.git","ssh_url":"git@github.com:duckduckgo/duckduckgo-privacy-extension.git","clone_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension.git","svn_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension","homepage":"https://duckduckgo.com/app","size":18533,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9,"open_issues":32,"watchers":112,"default_branch":"master"}},"base":{"label":"duckduckgo:develop","ref":"develop","sha":"fde980c749865265fa2853cde358ec729fdbcc0e","user":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars2.githubusercontent.com/u/342708?v=4","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"repo":{"id":113919648,"name":"duckduckgo-privacy-extension","full_name":"duckduckgo/duckduckgo-privacy-extension","owner":{"login":"duckduckgo","id":342708,"avatar_url":"https://avatars2.githubusercontent.com/u/342708?v=4","gravatar_id":"","url":"https://api.github.com/users/duckduckgo","html_url":"https://github.com/duckduckgo","followers_url":"https://api.github.com/users/duckduckgo/followers","following_url":"https://api.github.com/users/duckduckgo/following{/other_user}","gists_url":"https://api.github.com/users/duckduckgo/gists{/gist_id}","starred_url":"https://api.github.com/users/duckduckgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duckduckgo/subscriptions","organizations_url":"https://api.github.com/users/duckduckgo/orgs","repos_url":"https://api.github.com/users/duckduckgo/repos","events_url":"https://api.github.com/users/duckduckgo/events{/privacy}","received_events_url":"https://api.github.com/users/duckduckgo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension","description":"DuckDuckGo Privacy Essentials browser extension for Firefox, Chrome, Safari.","fork":false,"url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension","forks_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/forks","keys_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/teams","hooks_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/hooks","issue_events_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/events{/number}","events_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/events","assignees_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/assignees{/user}","branches_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/branches{/branch}","tags_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/tags","blobs_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/languages","stargazers_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/stargazers","contributors_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/contributors","subscribers_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/subscribers","subscription_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/subscription","commits_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/contents/{+path}","compare_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/merges","archive_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/downloads","issues_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues{/number}","pulls_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/labels{/name}","releases_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/releases{/id}","deployments_url":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/deployments","created_at":"2017-12-11T23:26:44Z","updated_at":"2018-04-23T21:25:40Z","pushed_at":"2018-04-25T14:25:26Z","git_url":"git://github.com/duckduckgo/duckduckgo-privacy-extension.git","ssh_url":"git@github.com:duckduckgo/duckduckgo-privacy-extension.git","clone_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension.git","svn_url":"https://github.com/duckduckgo/duckduckgo-privacy-extension","homepage":"https://duckduckgo.com/app","size":18533,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9,"open_issues":32,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212"},"html":{"href":"https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/212"},"issue":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/212"},"comments":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/duckduckgo/duckduckgo-privacy-extension/statuses/5b15cb03d9a7d46bbed201e81e5562ea8390f140"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andrey-p"}}