{"action":"created","comment":{"url":"https://api.github.com/repos/tomaka/glutin/pulls/comments/193851003","pull_request_review_id":126909251,"id":193851003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzg1MTAwMw==","diff_hunk":"@@ -37,14 +38,26 @@ pub fn get_gl_profile<T>(\n     } else if let GlRequest::Latest = opengl.version {\n         // now, find the latest supported version automatically\n         let mut attributes = vec![","path":"src/platform/macos/helpers.rs","position":13,"original_position":13,"commit_id":"30c5ee882c7171419ef375834338c0c117b7888c","original_commit_id":"30c5ee882c7171419ef375834338c0c117b7888c","user":{"login":"mkeeler","id":1641976,"node_id":"MDQ6VXNlcjE2NDE5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1641976?v=4","gravatar_id":"","url":"https://api.github.com/users/mkeeler","html_url":"https://github.com/mkeeler","followers_url":"https://api.github.com/users/mkeeler/followers","following_url":"https://api.github.com/users/mkeeler/following{/other_user}","gists_url":"https://api.github.com/users/mkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeeler/subscriptions","organizations_url":"https://api.github.com/users/mkeeler/orgs","repos_url":"https://api.github.com/users/mkeeler/repos","events_url":"https://api.github.com/users/mkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/mkeeler/received_events","type":"User","site_admin":false},"body":"I like the static array approach. 6 u32s on the stack should be no problem at all.","created_at":"2018-06-07T18:42:54Z","updated_at":"2018-06-07T18:42:54Z","html_url":"https://github.com/tomaka/glutin/pull/1026#discussion_r193851003","pull_request_url":"https://api.github.com/repos/tomaka/glutin/pulls/1026","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/comments/193851003"},"html":{"href":"https://github.com/tomaka/glutin/pull/1026#discussion_r193851003"},"pull_request":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/1026"}},"in_reply_to_id":193825425},"pull_request":{"url":"https://api.github.com/repos/tomaka/glutin/pulls/1026","id":193300914,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzAwOTE0","html_url":"https://github.com/tomaka/glutin/pull/1026","diff_url":"https://github.com/tomaka/glutin/pull/1026.diff","patch_url":"https://github.com/tomaka/glutin/pull/1026.patch","issue_url":"https://api.github.com/repos/tomaka/glutin/issues/1026","number":1026,"state":"open","locked":false,"title":"Fix gpu switching","user":{"login":"mkeeler","id":1641976,"node_id":"MDQ6VXNlcjE2NDE5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1641976?v=4","gravatar_id":"","url":"https://api.github.com/users/mkeeler","html_url":"https://github.com/mkeeler","followers_url":"https://api.github.com/users/mkeeler/followers","following_url":"https://api.github.com/users/mkeeler/following{/other_user}","gists_url":"https://api.github.com/users/mkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeeler/subscriptions","organizations_url":"https://api.github.com/users/mkeeler/orgs","repos_url":"https://api.github.com/users/mkeeler/repos","events_url":"https://api.github.com/users/mkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/mkeeler/received_events","type":"User","site_admin":false},"body":"Fixes #980\r\n\r\nThis PR contains 2 things. First users of the ContextBuilder can now specify hw accel and double buffering whereas before they were defaulted and couldn't be altered in this manner. Secondly on macOS when probing to determine the latest GL version we now take into account any requested attributes from the PixelFormatRequirements. This is to prevent forcing using a discrete GPU on macs when its not actually needed/desired.\r\n\r\nNote: The addition of NSOpenGLPFAAllowOfflineRenderers is required for automatic graphics switching to work and the main build_nsattributes already always includes this attribute. In my testing of glutin via gfx-rs this attribute will not prevent an application from using the discrete gpu but rather just enable the switching if applicable.","created_at":"2018-06-07T12:16:38Z","updated_at":"2018-06-07T18:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67a2da36a4e5638b845b2ffa03afc23ec2ac3578","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118141991,"node_id":"MDU6TGFiZWwxMTgxNDE5OTE=","url":"https://api.github.com/repos/tomaka/glutin/labels/platform:%20macOS","name":"platform: macOS","color":"FFF882","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tomaka/glutin/pulls/1026/commits","review_comments_url":"https://api.github.com/repos/tomaka/glutin/pulls/1026/comments","review_comment_url":"https://api.github.com/repos/tomaka/glutin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomaka/glutin/issues/1026/comments","statuses_url":"https://api.github.com/repos/tomaka/glutin/statuses/30c5ee882c7171419ef375834338c0c117b7888c","head":{"label":"mkeeler:fix-gpu-switching","ref":"fix-gpu-switching","sha":"30c5ee882c7171419ef375834338c0c117b7888c","user":{"login":"mkeeler","id":1641976,"node_id":"MDQ6VXNlcjE2NDE5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1641976?v=4","gravatar_id":"","url":"https://api.github.com/users/mkeeler","html_url":"https://github.com/mkeeler","followers_url":"https://api.github.com/users/mkeeler/followers","following_url":"https://api.github.com/users/mkeeler/following{/other_user}","gists_url":"https://api.github.com/users/mkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeeler/subscriptions","organizations_url":"https://api.github.com/users/mkeeler/orgs","repos_url":"https://api.github.com/users/mkeeler/repos","events_url":"https://api.github.com/users/mkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/mkeeler/received_events","type":"User","site_admin":false},"repo":{"id":136380819,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODA4MTk=","name":"glutin","full_name":"mkeeler/glutin","owner":{"login":"mkeeler","id":1641976,"node_id":"MDQ6VXNlcjE2NDE5NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1641976?v=4","gravatar_id":"","url":"https://api.github.com/users/mkeeler","html_url":"https://github.com/mkeeler","followers_url":"https://api.github.com/users/mkeeler/followers","following_url":"https://api.github.com/users/mkeeler/following{/other_user}","gists_url":"https://api.github.com/users/mkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkeeler/subscriptions","organizations_url":"https://api.github.com/users/mkeeler/orgs","repos_url":"https://api.github.com/users/mkeeler/repos","events_url":"https://api.github.com/users/mkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/mkeeler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkeeler/glutin","description":"Pure Rust alternative to GLFW","fork":true,"url":"https://api.github.com/repos/mkeeler/glutin","forks_url":"https://api.github.com/repos/mkeeler/glutin/forks","keys_url":"https://api.github.com/repos/mkeeler/glutin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkeeler/glutin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkeeler/glutin/teams","hooks_url":"https://api.github.com/repos/mkeeler/glutin/hooks","issue_events_url":"https://api.github.com/repos/mkeeler/glutin/issues/events{/number}","events_url":"https://api.github.com/repos/mkeeler/glutin/events","assignees_url":"https://api.github.com/repos/mkeeler/glutin/assignees{/user}","branches_url":"https://api.github.com/repos/mkeeler/glutin/branches{/branch}","tags_url":"https://api.github.com/repos/mkeeler/glutin/tags","blobs_url":"https://api.github.com/repos/mkeeler/glutin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkeeler/glutin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkeeler/glutin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkeeler/glutin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkeeler/glutin/statuses/{sha}","languages_url":"https://api.github.com/repos/mkeeler/glutin/languages","stargazers_url":"https://api.github.com/repos/mkeeler/glutin/stargazers","contributors_url":"https://api.github.com/repos/mkeeler/glutin/contributors","subscribers_url":"https://api.github.com/repos/mkeeler/glutin/subscribers","subscription_url":"https://api.github.com/repos/mkeeler/glutin/subscription","commits_url":"https://api.github.com/repos/mkeeler/glutin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkeeler/glutin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkeeler/glutin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkeeler/glutin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkeeler/glutin/contents/{+path}","compare_url":"https://api.github.com/repos/mkeeler/glutin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkeeler/glutin/merges","archive_url":"https://api.github.com/repos/mkeeler/glutin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkeeler/glutin/downloads","issues_url":"https://api.github.com/repos/mkeeler/glutin/issues{/number}","pulls_url":"https://api.github.com/repos/mkeeler/glutin/pulls{/number}","milestones_url":"https://api.github.com/repos/mkeeler/glutin/milestones{/number}","notifications_url":"https://api.github.com/repos/mkeeler/glutin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkeeler/glutin/labels{/name}","releases_url":"https://api.github.com/repos/mkeeler/glutin/releases{/id}","deployments_url":"https://api.github.com/repos/mkeeler/glutin/deployments","created_at":"2018-06-06T20:08:56Z","updated_at":"2018-06-06T20:08:58Z","pushed_at":"2018-06-07T12:09:39Z","git_url":"git://github.com/mkeeler/glutin.git","ssh_url":"git@github.com:mkeeler/glutin.git","clone_url":"https://github.com/mkeeler/glutin.git","svn_url":"https://github.com/mkeeler/glutin","homepage":null,"size":2384,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomaka:master","ref":"master","sha":"78afc32dda7a4d51975d0e394bc917866b485c5f","user":{"login":"tomaka","id":1412254,"node_id":"MDQ6VXNlcjE0MTIyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"repo":{"id":22305594,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMwNTU5NA==","name":"glutin","full_name":"tomaka/glutin","owner":{"login":"tomaka","id":1412254,"node_id":"MDQ6VXNlcjE0MTIyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1412254?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaka","html_url":"https://github.com/tomaka","followers_url":"https://api.github.com/users/tomaka/followers","following_url":"https://api.github.com/users/tomaka/following{/other_user}","gists_url":"https://api.github.com/users/tomaka/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaka/subscriptions","organizations_url":"https://api.github.com/users/tomaka/orgs","repos_url":"https://api.github.com/users/tomaka/repos","events_url":"https://api.github.com/users/tomaka/events{/privacy}","received_events_url":"https://api.github.com/users/tomaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaka/glutin","description":"Pure Rust alternative to GLFW","fork":false,"url":"https://api.github.com/repos/tomaka/glutin","forks_url":"https://api.github.com/repos/tomaka/glutin/forks","keys_url":"https://api.github.com/repos/tomaka/glutin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaka/glutin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaka/glutin/teams","hooks_url":"https://api.github.com/repos/tomaka/glutin/hooks","issue_events_url":"https://api.github.com/repos/tomaka/glutin/issues/events{/number}","events_url":"https://api.github.com/repos/tomaka/glutin/events","assignees_url":"https://api.github.com/repos/tomaka/glutin/assignees{/user}","branches_url":"https://api.github.com/repos/tomaka/glutin/branches{/branch}","tags_url":"https://api.github.com/repos/tomaka/glutin/tags","blobs_url":"https://api.github.com/repos/tomaka/glutin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaka/glutin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaka/glutin/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaka/glutin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaka/glutin/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaka/glutin/languages","stargazers_url":"https://api.github.com/repos/tomaka/glutin/stargazers","contributors_url":"https://api.github.com/repos/tomaka/glutin/contributors","subscribers_url":"https://api.github.com/repos/tomaka/glutin/subscribers","subscription_url":"https://api.github.com/repos/tomaka/glutin/subscription","commits_url":"https://api.github.com/repos/tomaka/glutin/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaka/glutin/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaka/glutin/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaka/glutin/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaka/glutin/contents/{+path}","compare_url":"https://api.github.com/repos/tomaka/glutin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaka/glutin/merges","archive_url":"https://api.github.com/repos/tomaka/glutin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaka/glutin/downloads","issues_url":"https://api.github.com/repos/tomaka/glutin/issues{/number}","pulls_url":"https://api.github.com/repos/tomaka/glutin/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaka/glutin/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaka/glutin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaka/glutin/labels{/name}","releases_url":"https://api.github.com/repos/tomaka/glutin/releases{/id}","deployments_url":"https://api.github.com/repos/tomaka/glutin/deployments","created_at":"2014-07-27T07:13:16Z","updated_at":"2018-06-07T10:47:29Z","pushed_at":"2018-06-07T12:16:38Z","git_url":"git://github.com/tomaka/glutin.git","ssh_url":"git@github.com:tomaka/glutin.git","clone_url":"https://github.com/tomaka/glutin.git","svn_url":"https://github.com/tomaka/glutin","homepage":null,"size":2384,"stargazers_count":898,"watchers_count":898,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":252,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":252,"open_issues":96,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/1026"},"html":{"href":"https://github.com/tomaka/glutin/pull/1026"},"issue":{"href":"https://api.github.com/repos/tomaka/glutin/issues/1026"},"comments":{"href":"https://api.github.com/repos/tomaka/glutin/issues/1026/comments"},"review_comments":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/1026/comments"},"review_comment":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomaka/glutin/pulls/1026/commits"},"statuses":{"href":"https://api.github.com/repos/tomaka/glutin/statuses/30c5ee882c7171419ef375834338c0c117b7888c"}},"author_association":"NONE"}}
{"actor":{"display_login":"mkeeler"}}