{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/vault/issues/4018","repository_url":"https://api.github.com/repos/hashicorp/vault","labels_url":"https://api.github.com/repos/hashicorp/vault/issues/4018/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/4018/comments","events_url":"https://api.github.com/repos/hashicorp/vault/issues/4018/events","html_url":"https://github.com/hashicorp/vault/pull/4018","id":299049530,"number":4018,"title":"Add PKCS1v15 as a RSA signature and verification option on the Transit secret engine ","user":{"login":"broamski","id":5578240,"avatar_url":"https://avatars2.githubusercontent.com/u/5578240?v=4","gravatar_id":"","url":"https://api.github.com/users/broamski","html_url":"https://github.com/broamski","followers_url":"https://api.github.com/users/broamski/followers","following_url":"https://api.github.com/users/broamski/following{/other_user}","gists_url":"https://api.github.com/users/broamski/gists{/gist_id}","starred_url":"https://api.github.com/users/broamski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broamski/subscriptions","organizations_url":"https://api.github.com/users/broamski/orgs","repos_url":"https://api.github.com/users/broamski/repos","events_url":"https://api.github.com/users/broamski/events{/privacy}","received_events_url":"https://api.github.com/users/broamski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-21T16:58:34Z","updated_at":"2018-02-21T18:15:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/4018","html_url":"https://github.com/hashicorp/vault/pull/4018","diff_url":"https://github.com/hashicorp/vault/pull/4018.diff","patch_url":"https://github.com/hashicorp/vault/pull/4018.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/hashicorp/vault/issues/comments/367419569","html_url":"https://github.com/hashicorp/vault/pull/4018#issuecomment-367419569","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/4018","id":367419569,"user":{"login":"jefferai","id":28627,"avatar_url":"https://avatars0.githubusercontent.com/u/28627?v=4","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T18:15:48Z","updated_at":"2018-02-21T18:15:48Z","author_association":"OWNER","body":"@broamski I'm not against adding it, although I think you're generally better off switching to PSS. I'm trying to think through the right place for this kind of option. It's definitely not that field, it's too single-purpose -- there's always the possibility that such a choice might become available for some other key type.\r\n\r\nOne possibility is simply a `signature_algorithm` field (and maybe renaming `algorithm` to `hash_algorithm`). Another might be to make it a configurable key property that you'd set with the `keys/<key>/config` endpoint. The benefit to doing that is that you take the onus off of the user to specify the parameter with every single sign/verify; the downside is you can't use the same key for both operations.\r\n\r\nWe could potentially do what Joel suggested and add it somehow to the output, although that would be a kind of a \"spec change\" for the output format."}}
{"actor":{"display_login":"jefferai"}}