{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/comments/211739757","pull_request_review_id":148226106,"id":211739757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTczOTc1Nw==","diff_hunk":"@@ -1,9 +1,9 @@\n ---\n-Checks:          '*'\n+Checks:          '*,-fuchsia-default-arguments'","path":".clang-tidy","position":3,"original_position":3,"commit_id":"8e10cf3efb2037d0c54a8a11b803205e34bc51ea","original_commit_id":"8e10cf3efb2037d0c54a8a11b803205e34bc51ea","user":{"login":"springmeyer","id":20300,"node_id":"MDQ6VXNlcjIwMzAw","avatar_url":"https://avatars1.githubusercontent.com/u/20300?v=4","gravatar_id":"","url":"https://api.github.com/users/springmeyer","html_url":"https://github.com/springmeyer","followers_url":"https://api.github.com/users/springmeyer/followers","following_url":"https://api.github.com/users/springmeyer/following{/other_user}","gists_url":"https://api.github.com/users/springmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/springmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springmeyer/subscriptions","organizations_url":"https://api.github.com/users/springmeyer/orgs","repos_url":"https://api.github.com/users/springmeyer/repos","events_url":"https://api.github.com/users/springmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/springmeyer/received_events","type":"User","site_admin":false},"body":"Yes, the `fuchsia-default-arguments` was triggering this error (just on linux):\r\n\r\n```\r\n/home/travis/build/mapbox/node-cpp-skel/build/../src/object_async/hello_async.cpp:249:37: error: calling a function that uses a default argument is disallowed [fuchsia-default-arguments,-warnings-as-errors]\r\n        return utils::CallbackError(\"first arg 'options' must be an object\",\r\n                                    ^\r\n/usr/lib/gcc/x86_64-linux-gnu/4.9/../../../../include/c++/4.9/bits/basic_string.h:494:39: note: default parameter was declared here\r\n      basic_string(const _CharT* __s, const _Alloc& __a = _Alloc());\r\n```\r\n\r\nhttps://travis-ci.org/mapbox/node-cpp-skel/jobs/418057304#L942. Disabling the `fuchsia-default-arguments` fixed the error, which I think is the best route because I can't see an easy way to workaround and I can imagine the usefulness of default args in downstream apps (even if we don't use them in node-cpp-skel).","created_at":"2018-08-21T20:00:44Z","updated_at":"2018-08-21T20:00:44Z","html_url":"https://github.com/mapbox/node-cpp-skel/pull/152#discussion_r211739757","pull_request_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/comments/211739757"},"html":{"href":"https://github.com/mapbox/node-cpp-skel/pull/152#discussion_r211739757"},"pull_request":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152"}},"in_reply_to_id":211684537},"pull_request":{"url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152","id":209401339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDAxMzM5","html_url":"https://github.com/mapbox/node-cpp-skel/pull/152","diff_url":"https://github.com/mapbox/node-cpp-skel/pull/152.diff","patch_url":"https://github.com/mapbox/node-cpp-skel/pull/152.patch","issue_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/152","number":152,"state":"open","locked":false,"title":"Upgrade mason deps","user":{"login":"springmeyer","id":20300,"node_id":"MDQ6VXNlcjIwMzAw","avatar_url":"https://avatars1.githubusercontent.com/u/20300?v=4","gravatar_id":"","url":"https://api.github.com/users/springmeyer","html_url":"https://github.com/springmeyer","followers_url":"https://api.github.com/users/springmeyer/followers","following_url":"https://api.github.com/users/springmeyer/following{/other_user}","gists_url":"https://api.github.com/users/springmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/springmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springmeyer/subscriptions","organizations_url":"https://api.github.com/users/springmeyer/orgs","repos_url":"https://api.github.com/users/springmeyer/repos","events_url":"https://api.github.com/users/springmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/springmeyer/received_events","type":"User","site_admin":false},"body":"This includes clang++ and clang-tidy packages that both no longer symlink the `c++` directory, which should avoid the (previous) problem with the llvm `6.0.0` packages mentioned at https://github.com/mapbox/node-cpp-skel/pull/146\r\n\r\n\r\nrefs https://github.com/mapbox/mason/pull/650","created_at":"2018-08-20T03:14:05Z","updated_at":"2018-08-21T20:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86b53997e406369e63af9383b309a052f00b2ad1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152/commits","review_comments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152/comments","review_comment_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/152/comments","statuses_url":"https://api.github.com/repos/mapbox/node-cpp-skel/statuses/8e10cf3efb2037d0c54a8a11b803205e34bc51ea","head":{"label":"mapbox:upgrade-mason-deps","ref":"upgrade-mason-deps","sha":"8e10cf3efb2037d0c54a8a11b803205e34bc51ea","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":61248806,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0ODgwNg==","name":"node-cpp-skel","full_name":"mapbox/node-cpp-skel","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/node-cpp-skel","description":"Skeleton for bindings to C++ libraries for Node.js using NAN","fork":false,"url":"https://api.github.com/repos/mapbox/node-cpp-skel","forks_url":"https://api.github.com/repos/mapbox/node-cpp-skel/forks","keys_url":"https://api.github.com/repos/mapbox/node-cpp-skel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/node-cpp-skel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/node-cpp-skel/teams","hooks_url":"https://api.github.com/repos/mapbox/node-cpp-skel/hooks","issue_events_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/node-cpp-skel/events","assignees_url":"https://api.github.com/repos/mapbox/node-cpp-skel/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/node-cpp-skel/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/node-cpp-skel/tags","blobs_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/node-cpp-skel/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/node-cpp-skel/languages","stargazers_url":"https://api.github.com/repos/mapbox/node-cpp-skel/stargazers","contributors_url":"https://api.github.com/repos/mapbox/node-cpp-skel/contributors","subscribers_url":"https://api.github.com/repos/mapbox/node-cpp-skel/subscribers","subscription_url":"https://api.github.com/repos/mapbox/node-cpp-skel/subscription","commits_url":"https://api.github.com/repos/mapbox/node-cpp-skel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/node-cpp-skel/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/node-cpp-skel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/node-cpp-skel/merges","archive_url":"https://api.github.com/repos/mapbox/node-cpp-skel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/node-cpp-skel/downloads","issues_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/node-cpp-skel/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/node-cpp-skel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/node-cpp-skel/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/node-cpp-skel/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/deployments","created_at":"2016-06-15T23:59:16Z","updated_at":"2018-08-01T05:49:47Z","pushed_at":"2018-08-21T16:28:22Z","git_url":"git://github.com/mapbox/node-cpp-skel.git","ssh_url":"git@github.com:mapbox/node-cpp-skel.git","clone_url":"https://github.com/mapbox/node-cpp-skel.git","svn_url":"https://github.com/mapbox/node-cpp-skel","homepage":null,"size":344,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":5,"open_issues":23,"watchers":35,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"4d39466e0bebd6fc44bd95f9e8a670fe39ae490c","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":61248806,"node_id":"MDEwOlJlcG9zaXRvcnk2MTI0ODgwNg==","name":"node-cpp-skel","full_name":"mapbox/node-cpp-skel","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/node-cpp-skel","description":"Skeleton for bindings to C++ libraries for Node.js using NAN","fork":false,"url":"https://api.github.com/repos/mapbox/node-cpp-skel","forks_url":"https://api.github.com/repos/mapbox/node-cpp-skel/forks","keys_url":"https://api.github.com/repos/mapbox/node-cpp-skel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/node-cpp-skel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/node-cpp-skel/teams","hooks_url":"https://api.github.com/repos/mapbox/node-cpp-skel/hooks","issue_events_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/node-cpp-skel/events","assignees_url":"https://api.github.com/repos/mapbox/node-cpp-skel/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/node-cpp-skel/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/node-cpp-skel/tags","blobs_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/node-cpp-skel/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/node-cpp-skel/languages","stargazers_url":"https://api.github.com/repos/mapbox/node-cpp-skel/stargazers","contributors_url":"https://api.github.com/repos/mapbox/node-cpp-skel/contributors","subscribers_url":"https://api.github.com/repos/mapbox/node-cpp-skel/subscribers","subscription_url":"https://api.github.com/repos/mapbox/node-cpp-skel/subscription","commits_url":"https://api.github.com/repos/mapbox/node-cpp-skel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/node-cpp-skel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/node-cpp-skel/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/node-cpp-skel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/node-cpp-skel/merges","archive_url":"https://api.github.com/repos/mapbox/node-cpp-skel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/node-cpp-skel/downloads","issues_url":"https://api.github.com/repos/mapbox/node-cpp-skel/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/node-cpp-skel/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/node-cpp-skel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/node-cpp-skel/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/node-cpp-skel/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/node-cpp-skel/deployments","created_at":"2016-06-15T23:59:16Z","updated_at":"2018-08-01T05:49:47Z","pushed_at":"2018-08-21T16:28:22Z","git_url":"git://github.com/mapbox/node-cpp-skel.git","ssh_url":"git@github.com:mapbox/node-cpp-skel.git","clone_url":"https://github.com/mapbox/node-cpp-skel.git","svn_url":"https://github.com/mapbox/node-cpp-skel","homepage":null,"size":344,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":5,"open_issues":23,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152"},"html":{"href":"https://github.com/mapbox/node-cpp-skel/pull/152"},"issue":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/152"},"comments":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/node-cpp-skel/statuses/8e10cf3efb2037d0c54a8a11b803205e34bc51ea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"springmeyer"}}