{"action":"created","comment":{"url":"https://api.github.com/repos/BOINC/boinc/pulls/comments/241828094","pull_request_review_id":185204801,"id":241828094,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTgyODA5NA==","diff_hunk":"@@ -819,35 +819,48 @@ private Integer getPidForProcessName(String processName) {\n     \t\n     \t// figure out what index PID has\n     \tString [] headers = processLinesAr[0].split(\"[\\\\s]+\");\n-    \tInteger PidIndex = 1;\n+    \tInteger PidIndex = -1;\n     \tfor (int x = 0; x < headers.length; x++) {\n     \t\tif(headers[x].equals(\"PID\")) {\n     \t\t\tPidIndex = x;\n     \t\t\tbreak;\n     \t\t}\n     \t}\n-\t\tif(Logging.DEBUG) Log.d(Logging.TAG,\"getPidForProcessName(): PID at index: \" + PidIndex + \" for output: \" + processLinesAr[0]);\n-    \t\n+\n+\t\tif (PidIndex == -1)\n+\t\t\treturn null;","path":"android/BOINC/app/src/main/java/edu/berkeley/boinc/client/Monitor.java","position":17,"original_position":16,"commit_id":"f43d0ec69900ff96e48ff24d1fca65a31dae24ac","original_commit_id":"f43d0ec69900ff96e48ff24d1fca65a31dae24ac","user":{"login":"adamradocz","id":16503773,"node_id":"MDQ6VXNlcjE2NTAzNzcz","avatar_url":"https://avatars1.githubusercontent.com/u/16503773?v=4","gravatar_id":"","url":"https://api.github.com/users/adamradocz","html_url":"https://github.com/adamradocz","followers_url":"https://api.github.com/users/adamradocz/followers","following_url":"https://api.github.com/users/adamradocz/following{/other_user}","gists_url":"https://api.github.com/users/adamradocz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamradocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamradocz/subscriptions","organizations_url":"https://api.github.com/users/adamradocz/orgs","repos_url":"https://api.github.com/users/adamradocz/repos","events_url":"https://api.github.com/users/adamradocz/events{/privacy}","received_events_url":"https://api.github.com/users/adamradocz/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-12-14T17:16:51Z","updated_at":"2018-12-14T17:16:51Z","html_url":"https://github.com/BOINC/boinc/pull/2898#discussion_r241828094","pull_request_url":"https://api.github.com/repos/BOINC/boinc/pulls/2898","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/comments/241828094"},"html":{"href":"https://github.com/BOINC/boinc/pull/2898#discussion_r241828094"},"pull_request":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/2898"}},"in_reply_to_id":241682243},"pull_request":{"url":"https://api.github.com/repos/BOINC/boinc/pulls/2898","id":237020612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDIwNjEy","html_url":"https://github.com/BOINC/boinc/pull/2898","diff_url":"https://github.com/BOINC/boinc/pull/2898.diff","patch_url":"https://github.com/BOINC/boinc/pull/2898.patch","issue_url":"https://api.github.com/repos/BOINC/boinc/issues/2898","number":2898,"state":"open","locked":false,"title":"[Android] Fix misused 'continue' statements.","user":{"login":"adamradocz","id":16503773,"node_id":"MDQ6VXNlcjE2NTAzNzcz","avatar_url":"https://avatars1.githubusercontent.com/u/16503773?v=4","gravatar_id":"","url":"https://api.github.com/users/adamradocz","html_url":"https://github.com/adamradocz","followers_url":"https://api.github.com/users/adamradocz/followers","following_url":"https://api.github.com/users/adamradocz/following{/other_user}","gists_url":"https://api.github.com/users/adamradocz/gists{/gist_id}","starred_url":"https://api.github.com/users/adamradocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamradocz/subscriptions","organizations_url":"https://api.github.com/users/adamradocz/orgs","repos_url":"https://api.github.com/users/adamradocz/repos","events_url":"https://api.github.com/users/adamradocz/events{/privacy}","received_events_url":"https://api.github.com/users/adamradocz/received_events","type":"User","site_admin":false},"body":"**Description of the Change**\r\nThe `continue` statement has been used wrongly a couple of times. I changed to `break` or deleted them, but it changes the logic of the loops, so please check thoroughly.\r\n\r\n**Alternate Designs**\r\nSome `for + break` loop could have changed to `while`.\r\n\r\n**Release Notes**\r\n[Android] Minor improvement.\r\n","created_at":"2018-12-07T23:23:05Z","updated_at":"2018-12-14T17:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84b120e54d5f79b720b781167be56081315e4f8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":173329728,"node_id":"MDU6TGFiZWwxNzMzMjk3Mjg=","url":"https://api.github.com/repos/BOINC/boinc/labels/C:%20Android%20-%20Manager","name":"C: Android - Manager","color":"0052cc","default":false},{"id":576130100,"node_id":"MDU6TGFiZWw1NzYxMzAxMDA=","url":"https://api.github.com/repos/BOINC/boinc/labels/C:%20Client%20-%20Android","name":"C: Client - Android","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BOINC/boinc/pulls/2898/commits","review_comments_url":"https://api.github.com/repos/BOINC/boinc/pulls/2898/comments","review_comment_url":"https://api.github.com/repos/BOINC/boinc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BOINC/boinc/issues/2898/comments","statuses_url":"https://api.github.com/repos/BOINC/boinc/statuses/f43d0ec69900ff96e48ff24d1fca65a31dae24ac","head":{"label":"BOINC:android-fix-Unnecessary-continue-statements","ref":"android-fix-Unnecessary-continue-statements","sha":"f43d0ec69900ff96e48ff24d1fca65a31dae24ac","user":{"login":"BOINC","id":985688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NTY4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/985688?v=4","gravatar_id":"","url":"https://api.github.com/users/BOINC","html_url":"https://github.com/BOINC","followers_url":"https://api.github.com/users/BOINC/followers","following_url":"https://api.github.com/users/BOINC/following{/other_user}","gists_url":"https://api.github.com/users/BOINC/gists{/gist_id}","starred_url":"https://api.github.com/users/BOINC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BOINC/subscriptions","organizations_url":"https://api.github.com/users/BOINC/orgs","repos_url":"https://api.github.com/users/BOINC/repos","events_url":"https://api.github.com/users/BOINC/events{/privacy}","received_events_url":"https://api.github.com/users/BOINC/received_events","type":"Organization","site_admin":false},"repo":{"id":30260406,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI2MDQwNg==","name":"boinc","full_name":"BOINC/boinc","private":false,"owner":{"login":"BOINC","id":985688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NTY4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/985688?v=4","gravatar_id":"","url":"https://api.github.com/users/BOINC","html_url":"https://github.com/BOINC","followers_url":"https://api.github.com/users/BOINC/followers","following_url":"https://api.github.com/users/BOINC/following{/other_user}","gists_url":"https://api.github.com/users/BOINC/gists{/gist_id}","starred_url":"https://api.github.com/users/BOINC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BOINC/subscriptions","organizations_url":"https://api.github.com/users/BOINC/orgs","repos_url":"https://api.github.com/users/BOINC/repos","events_url":"https://api.github.com/users/BOINC/events{/privacy}","received_events_url":"https://api.github.com/users/BOINC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BOINC/boinc","description":"Open-source software for volunteer computing and grid computing.","fork":false,"url":"https://api.github.com/repos/BOINC/boinc","forks_url":"https://api.github.com/repos/BOINC/boinc/forks","keys_url":"https://api.github.com/repos/BOINC/boinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BOINC/boinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BOINC/boinc/teams","hooks_url":"https://api.github.com/repos/BOINC/boinc/hooks","issue_events_url":"https://api.github.com/repos/BOINC/boinc/issues/events{/number}","events_url":"https://api.github.com/repos/BOINC/boinc/events","assignees_url":"https://api.github.com/repos/BOINC/boinc/assignees{/user}","branches_url":"https://api.github.com/repos/BOINC/boinc/branches{/branch}","tags_url":"https://api.github.com/repos/BOINC/boinc/tags","blobs_url":"https://api.github.com/repos/BOINC/boinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BOINC/boinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BOINC/boinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/BOINC/boinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BOINC/boinc/statuses/{sha}","languages_url":"https://api.github.com/repos/BOINC/boinc/languages","stargazers_url":"https://api.github.com/repos/BOINC/boinc/stargazers","contributors_url":"https://api.github.com/repos/BOINC/boinc/contributors","subscribers_url":"https://api.github.com/repos/BOINC/boinc/subscribers","subscription_url":"https://api.github.com/repos/BOINC/boinc/subscription","commits_url":"https://api.github.com/repos/BOINC/boinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/BOINC/boinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/BOINC/boinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/BOINC/boinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/BOINC/boinc/contents/{+path}","compare_url":"https://api.github.com/repos/BOINC/boinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BOINC/boinc/merges","archive_url":"https://api.github.com/repos/BOINC/boinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BOINC/boinc/downloads","issues_url":"https://api.github.com/repos/BOINC/boinc/issues{/number}","pulls_url":"https://api.github.com/repos/BOINC/boinc/pulls{/number}","milestones_url":"https://api.github.com/repos/BOINC/boinc/milestones{/number}","notifications_url":"https://api.github.com/repos/BOINC/boinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BOINC/boinc/labels{/name}","releases_url":"https://api.github.com/repos/BOINC/boinc/releases{/id}","deployments_url":"https://api.github.com/repos/BOINC/boinc/deployments","created_at":"2015-02-03T19:28:28Z","updated_at":"2018-12-14T09:26:07Z","pushed_at":"2018-12-14T17:08:22Z","git_url":"git://github.com/BOINC/boinc.git","ssh_url":"git@github.com:BOINC/boinc.git","clone_url":"https://github.com/BOINC/boinc.git","svn_url":"https://github.com/BOINC/boinc","homepage":"https://boinc.berkeley.edu","size":221838,"stargazers_count":773,"watchers_count":773,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":434,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":434,"watchers":773,"default_branch":"master"}},"base":{"label":"BOINC:master","ref":"master","sha":"1af5ecf51d1b8235f7045becb07dd725804ad631","user":{"login":"BOINC","id":985688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NTY4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/985688?v=4","gravatar_id":"","url":"https://api.github.com/users/BOINC","html_url":"https://github.com/BOINC","followers_url":"https://api.github.com/users/BOINC/followers","following_url":"https://api.github.com/users/BOINC/following{/other_user}","gists_url":"https://api.github.com/users/BOINC/gists{/gist_id}","starred_url":"https://api.github.com/users/BOINC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BOINC/subscriptions","organizations_url":"https://api.github.com/users/BOINC/orgs","repos_url":"https://api.github.com/users/BOINC/repos","events_url":"https://api.github.com/users/BOINC/events{/privacy}","received_events_url":"https://api.github.com/users/BOINC/received_events","type":"Organization","site_admin":false},"repo":{"id":30260406,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI2MDQwNg==","name":"boinc","full_name":"BOINC/boinc","private":false,"owner":{"login":"BOINC","id":985688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4NTY4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/985688?v=4","gravatar_id":"","url":"https://api.github.com/users/BOINC","html_url":"https://github.com/BOINC","followers_url":"https://api.github.com/users/BOINC/followers","following_url":"https://api.github.com/users/BOINC/following{/other_user}","gists_url":"https://api.github.com/users/BOINC/gists{/gist_id}","starred_url":"https://api.github.com/users/BOINC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BOINC/subscriptions","organizations_url":"https://api.github.com/users/BOINC/orgs","repos_url":"https://api.github.com/users/BOINC/repos","events_url":"https://api.github.com/users/BOINC/events{/privacy}","received_events_url":"https://api.github.com/users/BOINC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BOINC/boinc","description":"Open-source software for volunteer computing and grid computing.","fork":false,"url":"https://api.github.com/repos/BOINC/boinc","forks_url":"https://api.github.com/repos/BOINC/boinc/forks","keys_url":"https://api.github.com/repos/BOINC/boinc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BOINC/boinc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BOINC/boinc/teams","hooks_url":"https://api.github.com/repos/BOINC/boinc/hooks","issue_events_url":"https://api.github.com/repos/BOINC/boinc/issues/events{/number}","events_url":"https://api.github.com/repos/BOINC/boinc/events","assignees_url":"https://api.github.com/repos/BOINC/boinc/assignees{/user}","branches_url":"https://api.github.com/repos/BOINC/boinc/branches{/branch}","tags_url":"https://api.github.com/repos/BOINC/boinc/tags","blobs_url":"https://api.github.com/repos/BOINC/boinc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BOINC/boinc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BOINC/boinc/git/refs{/sha}","trees_url":"https://api.github.com/repos/BOINC/boinc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BOINC/boinc/statuses/{sha}","languages_url":"https://api.github.com/repos/BOINC/boinc/languages","stargazers_url":"https://api.github.com/repos/BOINC/boinc/stargazers","contributors_url":"https://api.github.com/repos/BOINC/boinc/contributors","subscribers_url":"https://api.github.com/repos/BOINC/boinc/subscribers","subscription_url":"https://api.github.com/repos/BOINC/boinc/subscription","commits_url":"https://api.github.com/repos/BOINC/boinc/commits{/sha}","git_commits_url":"https://api.github.com/repos/BOINC/boinc/git/commits{/sha}","comments_url":"https://api.github.com/repos/BOINC/boinc/comments{/number}","issue_comment_url":"https://api.github.com/repos/BOINC/boinc/issues/comments{/number}","contents_url":"https://api.github.com/repos/BOINC/boinc/contents/{+path}","compare_url":"https://api.github.com/repos/BOINC/boinc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BOINC/boinc/merges","archive_url":"https://api.github.com/repos/BOINC/boinc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BOINC/boinc/downloads","issues_url":"https://api.github.com/repos/BOINC/boinc/issues{/number}","pulls_url":"https://api.github.com/repos/BOINC/boinc/pulls{/number}","milestones_url":"https://api.github.com/repos/BOINC/boinc/milestones{/number}","notifications_url":"https://api.github.com/repos/BOINC/boinc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BOINC/boinc/labels{/name}","releases_url":"https://api.github.com/repos/BOINC/boinc/releases{/id}","deployments_url":"https://api.github.com/repos/BOINC/boinc/deployments","created_at":"2015-02-03T19:28:28Z","updated_at":"2018-12-14T09:26:07Z","pushed_at":"2018-12-14T17:08:22Z","git_url":"git://github.com/BOINC/boinc.git","ssh_url":"git@github.com:BOINC/boinc.git","clone_url":"https://github.com/BOINC/boinc.git","svn_url":"https://github.com/BOINC/boinc","homepage":"https://boinc.berkeley.edu","size":221838,"stargazers_count":773,"watchers_count":773,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":249,"mirror_url":null,"archived":false,"open_issues_count":434,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":434,"watchers":773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/2898"},"html":{"href":"https://github.com/BOINC/boinc/pull/2898"},"issue":{"href":"https://api.github.com/repos/BOINC/boinc/issues/2898"},"comments":{"href":"https://api.github.com/repos/BOINC/boinc/issues/2898/comments"},"review_comments":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/2898/comments"},"review_comment":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BOINC/boinc/pulls/2898/commits"},"statuses":{"href":"https://api.github.com/repos/BOINC/boinc/statuses/f43d0ec69900ff96e48ff24d1fca65a31dae24ac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adamradocz"}}