{"action":"created","issue":{"url":"https://api.github.com/repos/stsp/dosemu2/issues/650","repository_url":"https://api.github.com/repos/stsp/dosemu2","labels_url":"https://api.github.com/repos/stsp/dosemu2/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/stsp/dosemu2/issues/650/comments","events_url":"https://api.github.com/repos/stsp/dosemu2/issues/650/events","html_url":"https://github.com/stsp/dosemu2/pull/650","id":344634821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTg0OTEz","number":650,"title":"MFS: Redirect control functions have no drive associated","user":{"login":"andrewbird","id":220835,"node_id":"MDQ6VXNlcjIyMDgzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/220835?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewbird","html_url":"https://github.com/andrewbird","followers_url":"https://api.github.com/users/andrewbird/followers","following_url":"https://api.github.com/users/andrewbird/following{/other_user}","gists_url":"https://api.github.com/users/andrewbird/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbird/subscriptions","organizations_url":"https://api.github.com/users/andrewbird/orgs","repos_url":"https://api.github.com/users/andrewbird/repos","events_url":"https://api.github.com/users/andrewbird/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbird/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":37,"created_at":"2018-07-25T22:51:12Z","updated_at":"2018-07-27T20:31:52Z","closed_at":"2018-07-26T18:24:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stsp/dosemu2/pulls/650","html_url":"https://github.com/stsp/dosemu2/pull/650","diff_url":"https://github.com/stsp/dosemu2/pull/650.diff","patch_url":"https://github.com/stsp/dosemu2/pull/650.patch"},"body":"Redirector status, setup and listing functions have no associated drive,\r\nso looking for a drive and printing results can cause a crash as seen in\r\n[#561], so return early from select_drive() in that case.\r\n"},"comment":{"url":"https://api.github.com/repos/stsp/dosemu2/issues/comments/408531076","html_url":"https://github.com/stsp/dosemu2/pull/650#issuecomment-408531076","issue_url":"https://api.github.com/repos/stsp/dosemu2/issues/650","id":408531076,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODUzMTA3Ng==","user":{"login":"stsp","id":3295627,"node_id":"MDQ6VXNlcjMyOTU2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3295627?v=4","gravatar_id":"","url":"https://api.github.com/users/stsp","html_url":"https://github.com/stsp","followers_url":"https://api.github.com/users/stsp/followers","following_url":"https://api.github.com/users/stsp/following{/other_user}","gists_url":"https://api.github.com/users/stsp/gists{/gist_id}","starred_url":"https://api.github.com/users/stsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsp/subscriptions","organizations_url":"https://api.github.com/users/stsp/orgs","repos_url":"https://api.github.com/users/stsp/repos","events_url":"https://api.github.com/users/stsp/events{/privacy}","received_events_url":"https://api.github.com/users/stsp/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T20:31:52Z","updated_at":"2018-07-27T20:31:52Z","author_association":"OWNER","body":"> dosemu figures out the drive from the SFT only to see if that drive is a dosemu\r\n> redirected drive or not. If it is, it knows that the SFT was initialized (in other words,\r\n> owned) by dosemu and can use sft_fd(sft) to obtain the Linux fd. And if not, return.\r\n\r\nSo as it is currently implemented, indeed you\r\nneed to look up the drive from SFT and check\r\nit. And indeed there seem to be no way to get\r\nqualified filename, but I don't agree it is unhelpful,\r\neven in this case. For example if we support\r\n`QUALIFY_FILENAME` and thus get rid of the\r\n`drives` array, the SFT check can be reduced\r\nto a bitmask lookup. The bitmask of all drives\r\nis just one `uint32_t` val, where you can mark\r\nthe \"owned\" drives with 1. You don't need the\r\nredirection root in this case. I don't think you\r\never need it when the qualified filename is\r\nunavailable."}}
{"actor":{"display_login":"stsp"}}