{"action":"created","issue":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/1634","repository_url":"https://api.github.com/repos/tendermint/tendermint","labels_url":"https://api.github.com/repos/tendermint/tendermint/issues/1634/labels{/name}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/1634/comments","events_url":"https://api.github.com/repos/tendermint/tendermint/issues/1634/events","html_url":"https://github.com/tendermint/tendermint/pull/1634","id":327039858,"number":1634,"title":"Introduce local option for peerconfig","user":{"login":"xla","id":1585,"avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},"labels":[{"id":728824307,"url":"https://api.github.com/repos/tendermint/tendermint/labels/p2p","name":"p2p","color":"fafad2","default":false},{"id":811849255,"url":"https://api.github.com/repos/tendermint/tendermint/labels/test","name":"test","color":"d2fafa","default":false}],"state":"open","locked":false,"assignee":{"login":"xla","id":1585,"avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},"assignees":[{"login":"xla","id":1585,"avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-28T14:11:40Z","updated_at":"2018-05-28T14:17:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/1634","html_url":"https://github.com/tendermint/tendermint/pull/1634","diff_url":"https://github.com/tendermint/tendermint/pull/1634.diff","patch_url":"https://github.com/tendermint/tendermint/pull/1634.patch"},"body":"In line with other options we use for testing in the peerConfig we add the Local flag which signals to use the LocalAddr from the connection instead of the RemoteAddr. We require this as we piggyback on the loopback (127.0.0/8) addresses to simulate multiple peers.\r\n"},"comment":{"url":"https://api.github.com/repos/tendermint/tendermint/issues/comments/392539224","html_url":"https://github.com/tendermint/tendermint/pull/1634#issuecomment-392539224","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/1634","id":392539224,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T14:17:57Z","updated_at":"2018-05-28T14:17:57Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/tendermint/tendermint/pull/1634?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`develop@6004587`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `100%`.\n\n```diff\n@@            Coverage Diff             @@\n##             develop    #1634   +/-   ##\n==========================================\n  Coverage           ?   61.83%           \n==========================================\n  Files              ?      121           \n  Lines              ?    11104           \n  Branches           ?        0           \n==========================================\n  Hits               ?     6866           \n  Misses             ?     3621           \n  Partials           ?      617\n```\n\n| [Impacted Files](https://codecov.io/gh/tendermint/tendermint/pull/1634?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [p2p/switch.go](https://codecov.io/gh/tendermint/tendermint/pull/1634/diff?src=pr&el=tree#diff-cDJwL3N3aXRjaC5nbw==) | `53.73% <100%> (ø)` | |\n| [p2p/peer.go](https://codecov.io/gh/tendermint/tendermint/pull/1634/diff?src=pr&el=tree#diff-cDJwL3BlZXIuZ28=) | `66.66% <100%> (ø)` | |\n| [p2p/test\\_util.go](https://codecov.io/gh/tendermint/tendermint/pull/1634/diff?src=pr&el=tree#diff-cDJwL3Rlc3RfdXRpbC5nbw==) | `58.42% <100%> (ø)` | |\n"}}
{"actor":{"display_login":"codecov-io"}}