{"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/170316390","pull_request_review_id":98980138,"id":170316390,"diff_hunk":"@@ -27,14 +27,16 @@ type ListProps = {\n   /** highlights the whole TitledList if true */\n   selected?: boolean,\n   /** disables the whole TitledList if true */\n-  disabled?: boolean\n+  disabled?: boolean,\n+  /** inline style */\n+  style?: {[string]: string}\n }\n \n /**\n  * An ordered list with optional title, icon, and description.\n  */\n export default function TitledList (props: ListProps) {\n-  const {iconName, disabled, onCollapseToggle} = props\n+  const {iconName, disabled, onCollapseToggle, style} = props","path":"components/src/lists/TitledList.js","position":15,"original_position":15,"commit_id":"5f1847a8fe2b34dd679780a58c09b4a81597f42a","original_commit_id":"5f1847a8fe2b34dd679780a58c09b4a81597f42a","user":{"login":"mcous","id":2963448,"avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},"body":"Fine to leave it in place to get this PR merged, but I'm a little uncomfortable with this change. Given that the goal here appears to be to color the icon, how would you feel about updating the `iconName` prop (or, if it's not gonna happen in one PR, adding a new prop) to be an `iconProps` object?\r\n\r\nWe could then add a style prop to `Icon` (`style` on an Icon feel appropriate to me for some reason), and pass `{name: 'icon-name', style: {color: whateverColor}` to `TitledList` as `iconProps`. This would (I think) also have the added benefit of removing that color var `postcss` keeps complaining about.\r\n\r\n`AlertModal` works in a similar way by taking an array of `ButtonProps` to render a row of buttons that may be different depending on the modal type.","created_at":"2018-02-23T17:37:03Z","updated_at":"2018-02-23T18:02:37Z","html_url":"https://github.com/Opentrons/opentrons/pull/894#discussion_r170316390","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/894","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/170316390"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/894#discussion_r170316390"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/894"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/894","id":170631426,"html_url":"https://github.com/Opentrons/opentrons/pull/894","diff_url":"https://github.com/Opentrons/opentrons/pull/894.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/894.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/894","number":894,"state":"open","locked":false,"title":"Pd ingred editor form & ingred sidebar restyle","user":{"login":"IanLondon","id":11590381,"avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"## overview\r\n\r\nFixes #819 \r\n\r\n## changelog\r\n\r\n### Component Library changes\r\n\r\n1. Added circle icon\r\n\r\n2. Messed with some component library props:\r\n\r\n* onClick of Button => mixed\r\n* onBackClick of TitleBar => mixed\r\n\r\nThis is because `dispatch: Dispatch<*>` doesn't play well with `onClick: () => *` because of the two `*`s, and dispatch returns the action, not void. Mixed is better than `any` because it's still got potential to be typed, and `any` is a red flag that you're cheating in flow so we should avoid it unless we are actually cheating.\r\n\r\n3. I put a `style` prop on `TitledList` for using javascript to pass in css vars. This is specifically to color the circle icon in the ingredient list.\r\n\r\n4. Added prop to `TitleBar` to allow you to rewrite the \"Back\" text to something else\r\n\r\n### PD changes\r\n\r\n* ConnectedSidebar will display either Step List, or when ingredient selection mode is entered (by clicking \"Add Ingredients\" in Deck Setup mode) then it displays Ingredients List\r\n* New styles for Ingredients List -- threw away a ton of styles thanks to component library\r\n* No more `Concentration` field\r\n* New styles for Ingredient Editing Form, using component library's form field components instead of old custom ones\r\n* TitleBar will update depending whether you're on Step List, File Page (file page isn't a page, just a nav button, so it's a little weird to see now), or ingredient selection mode. Later, it will also update for well selection mode.\r\n* Cleaned up all containers in PD, making sure to type `mapStateToProps`\r\n\r\n## review requests\r\n\r\nMake sure nothing in Run App is broken from component library changes\r\n\r\n![2018-02-22 21-15_894](https://user-images.githubusercontent.com/11590381/36574852-9e776fea-1815-11e8-9045-7b1e641d51e9.gif)\r\n","created_at":"2018-02-22T01:02:50Z","updated_at":"2018-02-23T18:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07c732701c2ecf94b6010ae8aeeb9cbb9aa2c676","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kadee80","id":3430313,"avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":772967030,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/components","name":"components","color":"0052cc","default":false},{"id":770645862,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/protocol%20designer","name":"protocol designer","color":"440f89","default":false},{"id":762619415,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/ready%20for%20review","name":"ready for review","color":"6ed32a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/894/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/894/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/894/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/5f1847a8fe2b34dd679780a58c09b4a81597f42a","head":{"label":"Opentrons:pd_ingred-editor-form-restyle","ref":"pd_ingred-editor-form-restyle","sha":"5f1847a8fe2b34dd679780a58c09b4a81597f42a","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-02-19T16:00:51Z","pushed_at":"2018-02-23T17:20:18Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":18300,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":136,"watchers":42,"default_branch":"v3a"}},"base":{"label":"Opentrons:v3a","ref":"v3a","sha":"fe74f69635df1d54355d15609ec612a03365c4e4","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-02-19T16:00:51Z","pushed_at":"2018-02-23T17:20:18Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":18300,"stargazers_count":42,"watchers_count":42,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":136,"watchers":42,"default_branch":"v3a"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/894"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/894"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/894"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/894/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/894/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/894/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/5f1847a8fe2b34dd679780a58c09b4a81597f42a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcous"}}