{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/comments/192273549","pull_request_review_id":125018647,"id":192273549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI3MzU0OQ==","diff_hunk":"@@ -51,11 +52,14 @@ public class DeviceGroupsClient : IDeviceGroupsClient\n             var groupToDeviceMapping = new Dictionary<string, IEnumerable<string>>();\n             if (deviceGroupList?.Items != null)\n             {\n-                // TODO: Add retry if this call fails\n-                // https://github.com/Azure/asa-manager-dotnet/issues/7\n                 foreach (DeviceGroupApiModel group in deviceGroupList.Items)\n                 {\n-                    groupToDeviceMapping.Add(group.Id, await this.GetDevicesAsync(group));\n+                    // TODO: await these calls after starting all of them instead of individually","path":"DeviceGroupsAgent/DeviceGroupsClient.cs","position":17,"original_position":17,"commit_id":"42b54e7ea3bb418b9ab6070d8c599f5cd458401b","original_commit_id":"42b54e7ea3bb418b9ab6070d8c599f5cd458401b","user":{"login":"dluc","id":371009,"node_id":"MDQ6VXNlcjM3MTAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/371009?v=4","gravatar_id":"","url":"https://api.github.com/users/dluc","html_url":"https://github.com/dluc","followers_url":"https://api.github.com/users/dluc/followers","following_url":"https://api.github.com/users/dluc/following{/other_user}","gists_url":"https://api.github.com/users/dluc/gists{/gist_id}","starred_url":"https://api.github.com/users/dluc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dluc/subscriptions","organizations_url":"https://api.github.com/users/dluc/orgs","repos_url":"https://api.github.com/users/dluc/repos","events_url":"https://api.github.com/users/dluc/events{/privacy}","received_events_url":"https://api.github.com/users/dluc/received_events","type":"User","site_admin":false},"body":"create work item and add link here","created_at":"2018-06-01T00:33:30Z","updated_at":"2018-06-01T00:33:30Z","html_url":"https://github.com/Azure/asa-manager-dotnet/pull/17#discussion_r192273549","pull_request_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/comments/192273549"},"html":{"href":"https://github.com/Azure/asa-manager-dotnet/pull/17#discussion_r192273549"},"pull_request":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17","id":187046324,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MDQ2MzI0","html_url":"https://github.com/Azure/asa-manager-dotnet/pull/17","diff_url":"https://github.com/Azure/asa-manager-dotnet/pull/17.diff","patch_url":"https://github.com/Azure/asa-manager-dotnet/pull/17.patch","issue_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/17","number":17,"state":"open","locked":false,"title":"Only write to file if device group mapping changed","user":{"login":"molly-moen","id":33666587,"node_id":"MDQ6VXNlcjMzNjY2NTg3","avatar_url":"https://avatars1.githubusercontent.com/u/33666587?v=4","gravatar_id":"","url":"https://api.github.com/users/molly-moen","html_url":"https://github.com/molly-moen","followers_url":"https://api.github.com/users/molly-moen/followers","following_url":"https://api.github.com/users/molly-moen/following{/other_user}","gists_url":"https://api.github.com/users/molly-moen/gists{/gist_id}","starred_url":"https://api.github.com/users/molly-moen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molly-moen/subscriptions","organizations_url":"https://api.github.com/users/molly-moen/orgs","repos_url":"https://api.github.com/users/molly-moen/repos","events_url":"https://api.github.com/users/molly-moen/events{/privacy}","received_events_url":"https://api.github.com/users/molly-moen/received_events","type":"User","site_admin":false},"body":"\r\n# Description and Motivation <!-- Info & Context so we can review your pull request -->\r\nOnly write out group id -> device id mapping if the mapping is different from the previous mapping written. Verify changes by storing previous dictionary that was written to file and only writing new mapping if it changed. The device groups agent will still always write to file on its first iteration. \r\n\r\n# Change type <!-- [x] in all the boxes that apply -->\r\n\r\n- [ ] Bug fix\r\n- [ ] New feature\r\n- [x] Enhancement\r\n- [ ] Breaking change (breaks backward compatibility)\r\n\r\n**Checklist:**\r\n\r\n- [x] All tests passed\r\n- [x] The code follows the code style and conventions of this project\r\n- [ ] The change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n","created_at":"2018-05-09T21:33:45Z","updated_at":"2018-06-01T00:33:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb8c730de3824338647d89d183b9b46831a43a87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17/commits","review_comments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17/comments","review_comment_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/17/comments","statuses_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/statuses/42b54e7ea3bb418b9ab6070d8c599f5cd458401b","head":{"label":"Azure:Device-Groups-Check-Changes","ref":"Device-Groups-Check-Changes","sha":"42b54e7ea3bb418b9ab6070d8c599f5cd458401b","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":127493037,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0OTMwMzc=","name":"asa-manager-dotnet","full_name":"Azure/asa-manager-dotnet","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/asa-manager-dotnet","description":"Azure Stream Analytics management microservice","fork":false,"url":"https://api.github.com/repos/Azure/asa-manager-dotnet","forks_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/deployments","created_at":"2018-03-31T02:47:13Z","updated_at":"2018-05-31T21:12:14Z","pushed_at":"2018-05-31T21:12:15Z","git_url":"git://github.com/Azure/asa-manager-dotnet.git","ssh_url":"git@github.com:Azure/asa-manager-dotnet.git","clone_url":"https://github.com/Azure/asa-manager-dotnet.git","svn_url":"https://github.com/Azure/asa-manager-dotnet","homepage":null,"size":218,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"fa133511a9584d50898947c530def87d35139ec4","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":127493037,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0OTMwMzc=","name":"asa-manager-dotnet","full_name":"Azure/asa-manager-dotnet","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/asa-manager-dotnet","description":"Azure Stream Analytics management microservice","fork":false,"url":"https://api.github.com/repos/Azure/asa-manager-dotnet","forks_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/asa-manager-dotnet/deployments","created_at":"2018-03-31T02:47:13Z","updated_at":"2018-05-31T21:12:14Z","pushed_at":"2018-05-31T21:12:15Z","git_url":"git://github.com/Azure/asa-manager-dotnet.git","ssh_url":"git@github.com:Azure/asa-manager-dotnet.git","clone_url":"https://github.com/Azure/asa-manager-dotnet.git","svn_url":"https://github.com/Azure/asa-manager-dotnet","homepage":null,"size":218,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17"},"html":{"href":"https://github.com/Azure/asa-manager-dotnet/pull/17"},"issue":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/17"},"comments":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/asa-manager-dotnet/statuses/42b54e7ea3bb418b9ab6070d8c599f5cd458401b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dluc"}}