{"push_id":2549551455,"size":175,"distinct_size":175,"ref":"refs/heads/nw30","head":"d7a34234545975ccff9b7f925b34de2c4376f123","before":"4ae28731eb48762e2a7ee6b1733493d485a865cf","commits":[{"sha":"4289402aa3a7b02554aa0ebcb70af40447083fc8","author":{"name":"James M Snell","email":"2d64a127ffc94dbe6295928a16bedf8b26814159@gmail.com"},"message":"Working on v10.0.1","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/4289402aa3a7b02554aa0ebcb70af40447083fc8"},{"sha":"cd83df386bc0c567bda9a00ed297467b6046d785","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api: initialize a module via a special symbol\n\nMuch like regular modules, N-API modules can also benefit from having\na special symbol which they can expose.\n\nFixes: https://github.com/nodejs/node/issues/19845\nPR-URL: https://github.com/nodejs/node/pull/20161\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/cd83df386bc0c567bda9a00ed297467b6046d785"},{"sha":"a4dae6c22671b19886c5b7c2b653aebdbaaa6e69","author":{"name":"Daniel Bevenius","email":"ae63d1d4d7994483a3e520cafec7a829fe25c0a1@gmail.com"},"message":"src: prefer false instead of bool zero\n\nThis commit updates node_crypto.cc VerifySpkac function to use false\ninstead of 0 for its return bool value i.\n\nPR-URL: https://github.com/nodejs/node/pull/20218\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/a4dae6c22671b19886c5b7c2b653aebdbaaa6e69"},{"sha":"bd2e52109652ee7b0fb84fa8ead462a03048df53","author":{"name":"Daniel Bevenius","email":"ae63d1d4d7994483a3e520cafec7a829fe25c0a1@gmail.com"},"message":"src: rename return var in VerifySpkac functions\n\nThis commit renames the verification result variable, that is currently\nnamed i, to verify_result.\n\nPR-URL: https://github.com/nodejs/node/pull/20218\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/bd2e52109652ee7b0fb84fa8ead462a03048df53"},{"sha":"9eacd66bcb21d8e3faf667b5e77ff0f1352f4a9b","author":{"name":"Kyle Farnung","email":"88e6c356250197158ea31d0fb200ae850d7c3085@microsoft.com"},"message":"lib: make sure `console` is writable\n\nThe code currently assumes that `console` is already writable, but\nthat's only if it was previously defined as writable. If it hasn't\nalready been defined then the default value is false.\n\nRefs: https://github.com/nodejs/node/pull/17708\n\nPR-URL: https://github.com/nodejs/node/pull/20185\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/9eacd66bcb21d8e3faf667b5e77ff0f1352f4a9b"},{"sha":"b5584c448ab3b5db13122a19c0988b08410b3274","author":{"name":"Vse Mozhet Byt","email":"39164014c1ea1d786372ed67424a3db1c9cda5d3@gmail.com"},"message":"tools: modernize and optimize doc/addon-verify.js\n\nModernize:\n* Replace `var` with `const` / `let`.\n* Replace common functions with arrow functions.\n* Use destructuring.\n* Use `String.prototype.padStart()`, `String.prototype.endsWith()`.\n\nOptimize:\n* Reduce function calls.\n* Reduce intermediate variables.\n* Cache retrieved object properties.\n* Move RegExp declaration out of a cycle.\n* Simplify RegExps.\n* Replace RegExp with string when string suffices.\n* Remove conditions that cannot be false.\n* Replace for..in with `Object.keys().forEach()`.\n\nAlso, eliminate needlessly complicated function chains:\n* `ondone` callback only checks errors;\n* if there is an error, it is called once and throws, then script exits;\n* if there are no errors, it is noop;\n* so there is no need to wrap it into `once()` function\n* and there is no need to call it without errors;\n* we can eliminate it and replace with `throw` where an error occurs;\n* we can also replace `onprogress` callback with `console.log` in place;\n* at last, we can eliminate `waiting` counter and `once()` utility.\n\nThe new script produces results identical to the old ones.\n\nPR-URL: https://github.com/nodejs/node/pull/20188\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/b5584c448ab3b5db13122a19c0988b08410b3274"},{"sha":"c5b34590031472fac421b4b2095b94bd96a60430","author":{"name":"Rich Trott","email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com"},"message":"build: use -9 with `kill` in Makefile\n\nFixes: https://github.com/nodejs/node/issues/20194\n\nPR-URL: https://github.com/nodejs/node/pull/20195\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/c5b34590031472fac421b4b2095b94bd96a60430"},{"sha":"3bc5353110eade297ed80fa6d4005a06964f1de2","author":{"name":"Tobias Nießen","email":"d5cbe4fbc25bfd8bd67d36c93ca64e996a33b595@tnie.de"},"message":"doc: fix spelling of API name in 10.0.0 changelog\n\nPR-URL: https://github.com/nodejs/node/pull/20257\nRefs: https://github.com/nodejs/node/pull/19403\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Gus Caplan <me@gus.host>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/3bc5353110eade297ed80fa6d4005a06964f1de2"},{"sha":"26525ef5ab865f9881085ae2e806252deff01cda","author":{"name":"Vse Mozhet Byt","email":"39164014c1ea1d786372ed67424a3db1c9cda5d3@gmail.com"},"message":"doc: fix typos in doc/changelogs/CHANGELOG_V10.md\n\nPR-URL: https://github.com/nodejs/node/pull/20265\nReviewed-By: Gus Caplan <me@gus.host>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/26525ef5ab865f9881085ae2e806252deff01cda"},{"sha":"99e0b913c62ccd31ad11292cf4fd153b1e6c1467","author":{"name":"Daniel Bevenius","email":"ae63d1d4d7994483a3e520cafec7a829fe25c0a1@gmail.com"},"message":"test: add checkMethods function for Certificate\n\nThis commit adds a checkMethods function so that it can be reused to\navoid duplicating the same code for instance methods, and static\nmethods of the Certificate object.\n\nPR-URL: https://github.com/nodejs/node/pull/20224\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/99e0b913c62ccd31ad11292cf4fd153b1e6c1467"},{"sha":"6bf816fde2b9c9b947204ad3588dd4808956431a","author":{"name":"Ulan Degenbaev","email":"56dd103d017ceadb708086e2f118997b62b54fda@chromium.org"},"message":"src: limit foreground tasks draining loop\n\nForeground tasks that repost themselves can force the draining loop\nto run indefinitely long without giving other tasks chance to run.\n\nThis limits the foreground task draining loop to run only the tasks\nthat were in the tasks queue at the beginning of the loop.\n\nPR-URL: https://github.com/nodejs/node/pull/19987\nFixes: https://github.com/nodejs/node/issues/19937\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Yang Guo <yangguo@chromium.org>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>\nReviewed-By: Khaidi Chu <i@2333.moe>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/6bf816fde2b9c9b947204ad3588dd4808956431a"},{"sha":"171cbb1c6423714998351c9c3c0e6145481335bf","author":{"name":"Hackzzila","email":"d033e22ae348aeb5660fc2140aec35850c4da997@hackzzila.com"},"message":"doc: fix net.Socket link inconsistencies\n\nPR-URL: https://github.com/nodejs/node/pull/20271\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/171cbb1c6423714998351c9c3c0e6145481335bf"},{"sha":"3bf736e569bd3fafe82a63e88c7adc644ba0a39b","author":{"name":"Zachary Vacura","email":"d033e22ae348aeb5660fc2140aec35850c4da997@hackzzila.com"},"message":"doc: update pull request template in guide\n\nPR-URL: https://github.com/nodejs/node/pull/20277\nRefs: https://github.com/nodejs/node/pull/19125\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/3bf736e569bd3fafe82a63e88c7adc644ba0a39b"},{"sha":"d4b19cf43fd61c04f6186b0aaf27aca4a0f2b34a","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"test,n-api: re-write test_error in C\n\nPR-URL: https://github.com/nodejs/node/pull/20244\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/d4b19cf43fd61c04f6186b0aaf27aca4a0f2b34a"},{"sha":"b239591ed8ddbfb073aa522dd68b2e25f805dc05","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api,test: make methods static\n\nPR-URL: https://github.com/nodejs/node/pull/20243\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/b239591ed8ddbfb073aa522dd68b2e25f805dc05"},{"sha":"b5bc6bd94bfeee46216602a7557cffa8813e6358","author":{"name":"William Cohen","email":"7ad90ad7035ff1d5b2ddada0aaffa89765886b13@redhat.com"},"message":"src: fix Systemtap node_gc_stop probe\n\nThe process(\"node\").mark(\"gc__stop\") is actually\nprocess(\"node\").mark(\"gc__done\"). Use the proper name so that a\ndeveloper can use SystemTap to determine the duration of garbage\ncollection.\n\nPR-URL: https://github.com/nodejs/node/pull/20152\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Matheus Marchini <matheus@sthima.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/b5bc6bd94bfeee46216602a7557cffa8813e6358"},{"sha":"c9b202f817643d777407c86da408da703afc163d","author":{"name":"Ajido","email":"e4ee77dca218ec4371356a372c1e66994218e342@me.com"},"message":"doc: add emitter.off() to events.md\n\nPR-URL: https://github.com/nodejs/node/pull/20291\nRefs: https://github.com/nodejs/node/pull/17156\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/c9b202f817643d777407c86da408da703afc163d"},{"sha":"7f6172b64b66a76ec6a9407e060d244e2d646824","author":{"name":"Ujjwal Sharma","email":"2654b79e64bfd3bcd83f4d54d1a2803341dd9f14@gmail.com"},"message":"doc: improve docs for Http2Session:frameError\n\nImprove documentation regarding the callback parameters for the\nframeError event for instances of Http2Session, making it inline with\nthe currently accepted structure, like the rest of the documentation.\n\nRefs: https://github.com/nodejs/help/issues/877#issuecomment-381253464\n\nPR-URL: https://github.com/nodejs/node/pull/20236\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/7f6172b64b66a76ec6a9407e060d244e2d646824"},{"sha":"391d2f830a3b861be2ee2adf7204a0c8e660f91b","author":{"name":"Daniel Bevenius","email":"ae63d1d4d7994483a3e520cafec7a829fe25c0a1@gmail.com"},"message":"crypto: simplify diffiehellman getFormat function\n\nThis commit aims to simplify the getFormat function in\ndiffiehellman.js.\n\nPR-URL: https://github.com/nodejs/node/pull/20246\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/391d2f830a3b861be2ee2adf7204a0c8e660f91b"},{"sha":"e81bb9f8a368c21b9e60434eb7403739f87d448f","author":{"name":"Daniel Bevenius","email":"ae63d1d4d7994483a3e520cafec7a829fe25c0a1@gmail.com"},"message":"crypto: add getIntOption function to reduce dupl\n\nThis commit adds a getIntOption function to reduce the code duplicated\nfor getting the padding, and saltLength options.\n\nPR-URL: https://github.com/nodejs/node/pull/20247\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/nwjs/node/commits/e81bb9f8a368c21b9e60434eb7403739f87d448f"}]}
{"actor":{"display_login":"rogerwang"}}