{"action":"created","comment":{"url":"https://api.github.com/repos/pywbem/pywbem/pulls/comments/180008135","pull_request_review_id":110352321,"id":180008135,"diff_hunk":"@@ -48,8 +48,25 @@\n   responses between the pywbem client and WBEM server. This logs the HTTP\n   request data and response data including HTTP headers and CIM-XML payload.\n \n-These pywbem loggers output log records when they are configured and activated.\n-The pywbem loggers log at the :attr:`py:logging.DEBUG` logging level.\n+Pywbem uses the :attr:`py:logging.DEBUG` logging level for both loggers.\n+\n+The best practices for Python libraries suggest that libraries such as pywbem\n+have a null handler attached to the Python logger for the package (the\n+logger named `'pywbem'`, in this case), because since Python 2.7, the Python\n+root logger will by default (i.e. when not being configured) print log\n+records of logging level :attr:`py:logging.WARNING` or greater to `sys.stderr`.\n+Having a null handler on the logger for the library prevent such log events\n+to propagate up to the Python root logger, and thus the library will be silent","path":"pywbem/_logging.py","position":14,"original_position":14,"commit_id":"36b220109ea34158d56ae74463ef14b374562884","original_commit_id":"36b220109ea34158d56ae74463ef14b374562884","user":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"body":"DONE, both.","created_at":"2018-04-09T07:31:27Z","updated_at":"2018-04-09T07:31:28Z","html_url":"https://github.com/pywbem/pywbem/pull/1179#discussion_r180008135","pull_request_url":"https://api.github.com/repos/pywbem/pywbem/pulls/1179","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/comments/180008135"},"html":{"href":"https://github.com/pywbem/pywbem/pull/1179#discussion_r180008135"},"pull_request":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/1179"}},"in_reply_to_id":179952007},"pull_request":{"url":"https://api.github.com/repos/pywbem/pywbem/pulls/1179","id":180129824,"html_url":"https://github.com/pywbem/pywbem/pull/1179","diff_url":"https://github.com/pywbem/pywbem/pull/1179.diff","patch_url":"https://github.com/pywbem/pywbem/pull/1179.patch","issue_url":"https://api.github.com/repos/pywbem/pywbem/issues/1179","number":1179,"state":"open","locked":false,"title":"Fixes #1175 Cleaned up the use of logging NullHandler","user":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"body":"For details, see the commit message.\r\nReady for review and merge.","created_at":"2018-04-07T23:16:43Z","updated_at":"2018-04-09T07:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a894715865bb9eb059b568809a87edcdddd835c","assignee":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"assignees":[{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pywbem/pywbem/milestones/11","html_url":"https://github.com/pywbem/pywbem/milestone/11","labels_url":"https://api.github.com/repos/pywbem/pywbem/milestones/11/labels","id":2797894,"number":11,"title":"0.12.0","description":"Current development version.\r\nPRs marked with this milestone should merge into branch `master` (the default).\r\n\r\nIn January 2018 we changed the release date from Jan 2018 to Feb 2018.","creator":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":373,"state":"open","created_at":"2017-09-27T15:08:56Z","updated_at":"2018-04-08T18:10:52Z","due_on":"2018-02-05T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pywbem/pywbem/pulls/1179/commits","review_comments_url":"https://api.github.com/repos/pywbem/pywbem/pulls/1179/comments","review_comment_url":"https://api.github.com/repos/pywbem/pywbem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pywbem/pywbem/issues/1179/comments","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/36b220109ea34158d56ae74463ef14b374562884","head":{"label":"pywbem:andy/#1175-null-handler","ref":"andy/#1175-null-handler","sha":"36b220109ea34158d56ae74463ef14b374562884","user":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"repo":{"id":43776349,"name":"pywbem","full_name":"pywbem/pywbem","owner":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywbem/pywbem","description":"Pywbem - A WBEM client and related utilities, written in pure Python.","fork":false,"url":"https://api.github.com/repos/pywbem/pywbem","forks_url":"https://api.github.com/repos/pywbem/pywbem/forks","keys_url":"https://api.github.com/repos/pywbem/pywbem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywbem/pywbem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywbem/pywbem/teams","hooks_url":"https://api.github.com/repos/pywbem/pywbem/hooks","issue_events_url":"https://api.github.com/repos/pywbem/pywbem/issues/events{/number}","events_url":"https://api.github.com/repos/pywbem/pywbem/events","assignees_url":"https://api.github.com/repos/pywbem/pywbem/assignees{/user}","branches_url":"https://api.github.com/repos/pywbem/pywbem/branches{/branch}","tags_url":"https://api.github.com/repos/pywbem/pywbem/tags","blobs_url":"https://api.github.com/repos/pywbem/pywbem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywbem/pywbem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywbem/pywbem/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywbem/pywbem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/{sha}","languages_url":"https://api.github.com/repos/pywbem/pywbem/languages","stargazers_url":"https://api.github.com/repos/pywbem/pywbem/stargazers","contributors_url":"https://api.github.com/repos/pywbem/pywbem/contributors","subscribers_url":"https://api.github.com/repos/pywbem/pywbem/subscribers","subscription_url":"https://api.github.com/repos/pywbem/pywbem/subscription","commits_url":"https://api.github.com/repos/pywbem/pywbem/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywbem/pywbem/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywbem/pywbem/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywbem/pywbem/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywbem/pywbem/contents/{+path}","compare_url":"https://api.github.com/repos/pywbem/pywbem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywbem/pywbem/merges","archive_url":"https://api.github.com/repos/pywbem/pywbem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywbem/pywbem/downloads","issues_url":"https://api.github.com/repos/pywbem/pywbem/issues{/number}","pulls_url":"https://api.github.com/repos/pywbem/pywbem/pulls{/number}","milestones_url":"https://api.github.com/repos/pywbem/pywbem/milestones{/number}","notifications_url":"https://api.github.com/repos/pywbem/pywbem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywbem/pywbem/labels{/name}","releases_url":"https://api.github.com/repos/pywbem/pywbem/releases{/id}","deployments_url":"https://api.github.com/repos/pywbem/pywbem/deployments","created_at":"2015-10-06T20:22:46Z","updated_at":"2018-04-08T18:10:54Z","pushed_at":"2018-04-08T20:40:58Z","git_url":"git://github.com/pywbem/pywbem.git","ssh_url":"git@github.com:pywbem/pywbem.git","clone_url":"https://github.com/pywbem/pywbem.git","svn_url":"https://github.com/pywbem/pywbem","homepage":"http://pywbem.github.io","size":36393,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":12,"open_issues":88,"watchers":19,"default_branch":"master"}},"base":{"label":"pywbem:master","ref":"master","sha":"a18145b47e4a443e2dd0b04fde5a0b18d175f472","user":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"repo":{"id":43776349,"name":"pywbem","full_name":"pywbem/pywbem","owner":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywbem/pywbem","description":"Pywbem - A WBEM client and related utilities, written in pure Python.","fork":false,"url":"https://api.github.com/repos/pywbem/pywbem","forks_url":"https://api.github.com/repos/pywbem/pywbem/forks","keys_url":"https://api.github.com/repos/pywbem/pywbem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywbem/pywbem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywbem/pywbem/teams","hooks_url":"https://api.github.com/repos/pywbem/pywbem/hooks","issue_events_url":"https://api.github.com/repos/pywbem/pywbem/issues/events{/number}","events_url":"https://api.github.com/repos/pywbem/pywbem/events","assignees_url":"https://api.github.com/repos/pywbem/pywbem/assignees{/user}","branches_url":"https://api.github.com/repos/pywbem/pywbem/branches{/branch}","tags_url":"https://api.github.com/repos/pywbem/pywbem/tags","blobs_url":"https://api.github.com/repos/pywbem/pywbem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywbem/pywbem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywbem/pywbem/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywbem/pywbem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/{sha}","languages_url":"https://api.github.com/repos/pywbem/pywbem/languages","stargazers_url":"https://api.github.com/repos/pywbem/pywbem/stargazers","contributors_url":"https://api.github.com/repos/pywbem/pywbem/contributors","subscribers_url":"https://api.github.com/repos/pywbem/pywbem/subscribers","subscription_url":"https://api.github.com/repos/pywbem/pywbem/subscription","commits_url":"https://api.github.com/repos/pywbem/pywbem/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywbem/pywbem/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywbem/pywbem/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywbem/pywbem/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywbem/pywbem/contents/{+path}","compare_url":"https://api.github.com/repos/pywbem/pywbem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywbem/pywbem/merges","archive_url":"https://api.github.com/repos/pywbem/pywbem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywbem/pywbem/downloads","issues_url":"https://api.github.com/repos/pywbem/pywbem/issues{/number}","pulls_url":"https://api.github.com/repos/pywbem/pywbem/pulls{/number}","milestones_url":"https://api.github.com/repos/pywbem/pywbem/milestones{/number}","notifications_url":"https://api.github.com/repos/pywbem/pywbem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywbem/pywbem/labels{/name}","releases_url":"https://api.github.com/repos/pywbem/pywbem/releases{/id}","deployments_url":"https://api.github.com/repos/pywbem/pywbem/deployments","created_at":"2015-10-06T20:22:46Z","updated_at":"2018-04-08T18:10:54Z","pushed_at":"2018-04-08T20:40:58Z","git_url":"git://github.com/pywbem/pywbem.git","ssh_url":"git@github.com:pywbem/pywbem.git","clone_url":"https://github.com/pywbem/pywbem.git","svn_url":"https://github.com/pywbem/pywbem","homepage":"http://pywbem.github.io","size":36393,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":12,"open_issues":88,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/1179"},"html":{"href":"https://github.com/pywbem/pywbem/pull/1179"},"issue":{"href":"https://api.github.com/repos/pywbem/pywbem/issues/1179"},"comments":{"href":"https://api.github.com/repos/pywbem/pywbem/issues/1179/comments"},"review_comments":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/1179/comments"},"review_comment":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/1179/commits"},"statuses":{"href":"https://api.github.com/repos/pywbem/pywbem/statuses/36b220109ea34158d56ae74463ef14b374562884"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andy-maier"}}