{"action":"created","comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/239003325","pull_request_review_id":181678633,"id":239003325,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTAwMzMyNQ==","diff_hunk":"@@ -9,5 +9,7 @@ export class TypeaheadPage {\n \n   getDropdownItems() { return this.getDropdown().$$('button'); }\n \n+  getErrorMsgElement() { return $('#error_msg'); }","path":"e2e-app/src/app/typeahead/typeahead.po.ts","position":4,"original_position":4,"commit_id":"5b06433e97f3aa9743fd54b8dd616f7aab33d0d8","original_commit_id":"5b06433e97f3aa9743fd54b8dd616f7aab33d0d8","user":{"login":"maxokorokov","id":8074436,"node_id":"MDQ6VXNlcjgwNzQ0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/8074436?v=4","gravatar_id":"","url":"https://api.github.com/users/maxokorokov","html_url":"https://github.com/maxokorokov","followers_url":"https://api.github.com/users/maxokorokov/followers","following_url":"https://api.github.com/users/maxokorokov/following{/other_user}","gists_url":"https://api.github.com/users/maxokorokov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxokorokov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxokorokov/subscriptions","organizations_url":"https://api.github.com/users/maxokorokov/orgs","repos_url":"https://api.github.com/users/maxokorokov/repos","events_url":"https://api.github.com/users/maxokorokov/events{/privacy}","received_events_url":"https://api.github.com/users/maxokorokov/received_events","type":"User","site_admin":false},"body":"not used antymore","created_at":"2018-12-05T10:13:06Z","updated_at":"2018-12-05T10:15:52Z","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872#discussion_r239003325","pull_request_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/239003325"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872#discussion_r239003325"},"pull_request":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872"}}},"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872","id":231569215,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTY5MjE1","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2872","number":2872,"state":"open","locked":false,"title":"fix(typeahead): prevent validation during an item click","user":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"body":"fix #2719 \r\n\r\nLanded here the solution proposed in #2843 (thanks @wannadream !), with some changes:\r\n\r\n- The fix for this particular issue is separated from the others,\r\n- The 'if' inside the handleBlur has been simplified,\r\n- Protractor tests have been added to cover this case\r\n","created_at":"2018-11-16T15:37:34Z","updated_at":"2018-12-05T10:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae3f900dca2dad80a5f0803e05b972080631902a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":263376179,"node_id":"MDU6TGFiZWwyNjMzNzYxNzk=","url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/component:%20typeahead","name":"component: typeahead","color":"ffffff","default":false},{"id":260884548,"node_id":"MDU6TGFiZWwyNjA4ODQ1NDg=","url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7","default":false},{"id":260891359,"node_id":"MDU6TGFiZWwyNjA4OTEzNTk=","url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels/type:%20tests","name":"type: tests","color":"0b02e1","default":false}],"milestone":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/71","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/milestone/71","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/71/labels","id":3751690,"node_id":"MDk6TWlsZXN0b25lMzc1MTY5MA==","number":71,"title":"4.0.1","description":"","creator":{"login":"pkozlowski-opensource","id":973550,"node_id":"MDQ6VXNlcjk3MzU1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/973550?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":10,"state":"open","created_at":"2018-10-19T08:54:39Z","updated_at":"2018-12-04T15:16:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2872/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/5b06433e97f3aa9743fd54b8dd616f7aab33d0d8","head":{"label":"fbasso:typeahead-validation","ref":"typeahead-validation","sha":"5b06433e97f3aa9743fd54b8dd616f7aab33d0d8","user":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"repo":{"id":70463623,"node_id":"MDEwOlJlcG9zaXRvcnk3MDQ2MzYyMw==","name":"ng-bootstrap","full_name":"fbasso/ng-bootstrap","private":false,"owner":{"login":"fbasso","id":1152930,"node_id":"MDQ6VXNlcjExNTI5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1152930?v=4","gravatar_id":"","url":"https://api.github.com/users/fbasso","html_url":"https://github.com/fbasso","followers_url":"https://api.github.com/users/fbasso/followers","following_url":"https://api.github.com/users/fbasso/following{/other_user}","gists_url":"https://api.github.com/users/fbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/fbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbasso/subscriptions","organizations_url":"https://api.github.com/users/fbasso/orgs","repos_url":"https://api.github.com/users/fbasso/repos","events_url":"https://api.github.com/users/fbasso/events{/privacy}","received_events_url":"https://api.github.com/users/fbasso/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fbasso/ng-bootstrap","description":"Angular 2 powered Bootstrap","fork":true,"url":"https://api.github.com/repos/fbasso/ng-bootstrap","forks_url":"https://api.github.com/repos/fbasso/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/fbasso/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbasso/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbasso/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/fbasso/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/fbasso/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/fbasso/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/fbasso/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/fbasso/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbasso/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/fbasso/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/fbasso/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/fbasso/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/fbasso/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/fbasso/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/fbasso/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbasso/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbasso/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbasso/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/fbasso/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbasso/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/fbasso/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbasso/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/fbasso/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/fbasso/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/fbasso/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/fbasso/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbasso/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/fbasso/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/fbasso/ng-bootstrap/deployments","created_at":"2016-10-10T07:39:10Z","updated_at":"2018-11-29T13:22:02Z","pushed_at":"2018-12-04T14:18:31Z","git_url":"git://github.com/fbasso/ng-bootstrap.git","ssh_url":"git@github.com:fbasso/ng-bootstrap.git","clone_url":"https://github.com/fbasso/ng-bootstrap.git","svn_url":"https://github.com/fbasso/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":3350,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"e0fe9f566061d6a346aab1742f4162ff23e10b70","user":{"login":"ng-bootstrap","id":14283866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjgzODY2","avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ4MTY2NA==","name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","private":false,"owner":{"login":"ng-bootstrap","id":14283866,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjgzODY2","avatar_url":"https://avatars1.githubusercontent.com/u/14283866?v=4","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2018-12-05T09:34:39Z","pushed_at":"2018-12-05T10:09:41Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"git@github.com:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":3182,"stargazers_count":6327,"watchers_count":6327,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1052,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1052,"open_issues":192,"watchers":6327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/2872"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2872"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/2872/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/2872/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/5b06433e97f3aa9743fd54b8dd616f7aab33d0d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maxokorokov"}}