{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/242797681","pull_request_review_id":186395287,"id":242797681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjc5NzY4MQ==","diff_hunk":"@@ -15,17 +15,26 @@ def build(&block)\n       end\n \n       def build_menu_item(title, options, &block)\n-        fragment = options.fetch(:id, title.parameterize)\n+        fragment = options.fetch(:id, fragmentize(title))\n+\n         html_options = options.fetch(:html_options, {})\n         li html_options do\n           link_to title, \"##{fragment}\"\n         end\n       end\n \n       def build_content_item(title, options, &block)\n-        options = options.reverse_merge(id: title.parameterize)\n+        options = options.reverse_merge(id: fragmentize(title))","path":"lib/active_admin/views/components/tabs.rb","position":15,"original_position":15,"commit_id":"cd2a9e76a934826b122ca2e71604b80853819c86","original_commit_id":"cd2a9e76a934826b122ca2e71604b80853819c86","user":{"login":"timoschilling","id":165599,"node_id":"MDQ6VXNlcjE2NTU5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/165599?v=4","gravatar_id":"","url":"https://api.github.com/users/timoschilling","html_url":"https://github.com/timoschilling","followers_url":"https://api.github.com/users/timoschilling/followers","following_url":"https://api.github.com/users/timoschilling/following{/other_user}","gists_url":"https://api.github.com/users/timoschilling/gists{/gist_id}","starred_url":"https://api.github.com/users/timoschilling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoschilling/subscriptions","organizations_url":"https://api.github.com/users/timoschilling/orgs","repos_url":"https://api.github.com/users/timoschilling/repos","events_url":"https://api.github.com/users/timoschilling/events{/privacy}","received_events_url":"https://api.github.com/users/timoschilling/received_events","type":"User","site_admin":false},"body":"`URI.encode` is a good catch, but I think with it we no longer need `fragmentize` and can do:\r\n```suggestion\r\n        options = options.reverse_merge(id: URI.encode(title))\r\n```","created_at":"2018-12-19T05:50:06Z","updated_at":"2018-12-19T05:50:06Z","html_url":"https://github.com/activeadmin/activeadmin/pull/5650#discussion_r242797681","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/242797681"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/5650#discussion_r242797681"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650","id":239360958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzYwOTU4","html_url":"https://github.com/activeadmin/activeadmin/pull/5650","diff_url":"https://github.com/activeadmin/activeadmin/pull/5650.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/5650.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/5650","number":5650,"state":"open","locked":false,"title":"Added workaround for non-transliteratable tab titles","user":{"login":"panasyuk","id":2225551,"node_id":"MDQ6VXNlcjIyMjU1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2225551?v=4","gravatar_id":"","url":"https://api.github.com/users/panasyuk","html_url":"https://github.com/panasyuk","followers_url":"https://api.github.com/users/panasyuk/followers","following_url":"https://api.github.com/users/panasyuk/following{/other_user}","gists_url":"https://api.github.com/users/panasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/panasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panasyuk/subscriptions","organizations_url":"https://api.github.com/users/panasyuk/orgs","repos_url":"https://api.github.com/users/panasyuk/repos","events_url":"https://api.github.com/users/panasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/panasyuk/received_events","type":"User","site_admin":false},"body":"Fixed code that generates fragment link and id for tab content for non-transliteratable tab titles.\r\n\r\nFixes #5484.\r\nCloses #5508.","created_at":"2018-12-18T04:24:08Z","updated_at":"2018-12-19T05:50:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c269d33b768e17a541951d4891fd81e4cf9120b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/5650/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/cd2a9e76a934826b122ca2e71604b80853819c86","head":{"label":"panasyuk:fix_tab_fragment","ref":"fix_tab_fragment","sha":"cd2a9e76a934826b122ca2e71604b80853819c86","user":{"login":"panasyuk","id":2225551,"node_id":"MDQ6VXNlcjIyMjU1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2225551?v=4","gravatar_id":"","url":"https://api.github.com/users/panasyuk","html_url":"https://github.com/panasyuk","followers_url":"https://api.github.com/users/panasyuk/followers","following_url":"https://api.github.com/users/panasyuk/following{/other_user}","gists_url":"https://api.github.com/users/panasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/panasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panasyuk/subscriptions","organizations_url":"https://api.github.com/users/panasyuk/orgs","repos_url":"https://api.github.com/users/panasyuk/repos","events_url":"https://api.github.com/users/panasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/panasyuk/received_events","type":"User","site_admin":false},"repo":{"id":162228714,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIyMjg3MTQ=","name":"activeadmin","full_name":"panasyuk/activeadmin","private":false,"owner":{"login":"panasyuk","id":2225551,"node_id":"MDQ6VXNlcjIyMjU1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2225551?v=4","gravatar_id":"","url":"https://api.github.com/users/panasyuk","html_url":"https://github.com/panasyuk","followers_url":"https://api.github.com/users/panasyuk/followers","following_url":"https://api.github.com/users/panasyuk/following{/other_user}","gists_url":"https://api.github.com/users/panasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/panasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panasyuk/subscriptions","organizations_url":"https://api.github.com/users/panasyuk/orgs","repos_url":"https://api.github.com/users/panasyuk/repos","events_url":"https://api.github.com/users/panasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/panasyuk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/panasyuk/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/panasyuk/activeadmin","forks_url":"https://api.github.com/repos/panasyuk/activeadmin/forks","keys_url":"https://api.github.com/repos/panasyuk/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panasyuk/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panasyuk/activeadmin/teams","hooks_url":"https://api.github.com/repos/panasyuk/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/panasyuk/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/panasyuk/activeadmin/events","assignees_url":"https://api.github.com/repos/panasyuk/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/panasyuk/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/panasyuk/activeadmin/tags","blobs_url":"https://api.github.com/repos/panasyuk/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panasyuk/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panasyuk/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/panasyuk/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panasyuk/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/panasyuk/activeadmin/languages","stargazers_url":"https://api.github.com/repos/panasyuk/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/panasyuk/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/panasyuk/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/panasyuk/activeadmin/subscription","commits_url":"https://api.github.com/repos/panasyuk/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/panasyuk/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/panasyuk/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/panasyuk/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/panasyuk/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/panasyuk/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panasyuk/activeadmin/merges","archive_url":"https://api.github.com/repos/panasyuk/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panasyuk/activeadmin/downloads","issues_url":"https://api.github.com/repos/panasyuk/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/panasyuk/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/panasyuk/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/panasyuk/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panasyuk/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/panasyuk/activeadmin/releases{/id}","deployments_url":"https://api.github.com/repos/panasyuk/activeadmin/deployments","created_at":"2018-12-18T04:10:47Z","updated_at":"2018-12-18T04:10:50Z","pushed_at":"2018-12-19T02:26:20Z","git_url":"git://github.com/panasyuk/activeadmin.git","ssh_url":"git@github.com:panasyuk/activeadmin.git","clone_url":"https://github.com/panasyuk/activeadmin.git","svn_url":"https://github.com/panasyuk/activeadmin","homepage":"https://activeadmin.info","size":8598,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"3c7fac35e2f0912d8e4fd583e5e0512de7450d1a","user":{"login":"activeadmin","id":814570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDU3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/814570?v=4","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE5MjE=","name":"activeadmin","full_name":"activeadmin/activeadmin","private":false,"owner":{"login":"activeadmin","id":814570,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxNDU3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/814570?v=4","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","deployments_url":"https://api.github.com/repos/activeadmin/activeadmin/deployments","created_at":"2010-04-15T14:26:03Z","updated_at":"2018-12-18T23:49:15Z","pushed_at":"2018-12-19T02:26:25Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"https://activeadmin.info","size":8565,"stargazers_count":8262,"watchers_count":8262,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2921,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2921,"open_issues":228,"watchers":8262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/5650"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/5650"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/5650/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/5650/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/cd2a9e76a934826b122ca2e71604b80853819c86"}},"author_association":"NONE"}}
{"actor":{"display_login":"timoschilling"}}