{"action":"closed","number":287,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287","id":196231325,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjMxMzI1","html_url":"https://github.com/thoughtbot/ex_machina/pull/287","diff_url":"https://github.com/thoughtbot/ex_machina/pull/287.diff","patch_url":"https://github.com/thoughtbot/ex_machina/pull/287.patch","issue_url":"https://api.github.com/repos/thoughtbot/ex_machina/issues/287","number":287,"state":"closed","locked":false,"title":"Remove obsolete `fields_for/2` function","user":{"login":"moxley","id":86996,"node_id":"MDQ6VXNlcjg2OTk2","avatar_url":"https://avatars2.githubusercontent.com/u/86996?v=4","gravatar_id":"","url":"https://api.github.com/users/moxley","html_url":"https://github.com/moxley","followers_url":"https://api.github.com/users/moxley/followers","following_url":"https://api.github.com/users/moxley/following{/other_user}","gists_url":"https://api.github.com/users/moxley/gists{/gist_id}","starred_url":"https://api.github.com/users/moxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxley/subscriptions","organizations_url":"https://api.github.com/users/moxley/orgs","repos_url":"https://api.github.com/users/moxley/repos","events_url":"https://api.github.com/users/moxley/events{/privacy}","received_events_url":"https://api.github.com/users/moxley/received_events","type":"User","site_admin":false},"body":"Fixes #157\r\n\r\nSince version 1.0.0, when users of ex_machina try to call the deprecated `fields_for/2` function, it raises an exception. This doesn't seem to provide any benefit. If instead it's removed, calls to it will fail at compile time. But if it stays in, calls will fail at runtime, possibly in production.\r\n\r\nThis PR solves the Dialyzer issue and it provides a better solution for dealing with the obsolete function.","created_at":"2018-06-20T18:19:19Z","updated_at":"2018-07-20T18:52:57Z","closed_at":"2018-07-20T18:52:57Z","merged_at":"2018-07-20T18:52:57Z","merge_commit_sha":"b17ba1c9c8f65c4aed4401c1fff19565187e1d0a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/ex_machina/issues/287/comments","statuses_url":"https://api.github.com/repos/thoughtbot/ex_machina/statuses/b528c4bde184629f4906a9fa23471fee87eeb764","head":{"label":"moxley:remove-fields-for","ref":"remove-fields-for","sha":"b528c4bde184629f4906a9fa23471fee87eeb764","user":{"login":"moxley","id":86996,"node_id":"MDQ6VXNlcjg2OTk2","avatar_url":"https://avatars2.githubusercontent.com/u/86996?v=4","gravatar_id":"","url":"https://api.github.com/users/moxley","html_url":"https://github.com/moxley","followers_url":"https://api.github.com/users/moxley/followers","following_url":"https://api.github.com/users/moxley/following{/other_user}","gists_url":"https://api.github.com/users/moxley/gists{/gist_id}","starred_url":"https://api.github.com/users/moxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxley/subscriptions","organizations_url":"https://api.github.com/users/moxley/orgs","repos_url":"https://api.github.com/users/moxley/repos","events_url":"https://api.github.com/users/moxley/events{/privacy}","received_events_url":"https://api.github.com/users/moxley/received_events","type":"User","site_admin":false},"repo":{"id":138069034,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwNjkwMzQ=","name":"ex_machina","full_name":"moxley/ex_machina","owner":{"login":"moxley","id":86996,"node_id":"MDQ6VXNlcjg2OTk2","avatar_url":"https://avatars2.githubusercontent.com/u/86996?v=4","gravatar_id":"","url":"https://api.github.com/users/moxley","html_url":"https://github.com/moxley","followers_url":"https://api.github.com/users/moxley/followers","following_url":"https://api.github.com/users/moxley/following{/other_user}","gists_url":"https://api.github.com/users/moxley/gists{/gist_id}","starred_url":"https://api.github.com/users/moxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxley/subscriptions","organizations_url":"https://api.github.com/users/moxley/orgs","repos_url":"https://api.github.com/users/moxley/repos","events_url":"https://api.github.com/users/moxley/events{/privacy}","received_events_url":"https://api.github.com/users/moxley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moxley/ex_machina","description":"Create test data for Elixir applications","fork":true,"url":"https://api.github.com/repos/moxley/ex_machina","forks_url":"https://api.github.com/repos/moxley/ex_machina/forks","keys_url":"https://api.github.com/repos/moxley/ex_machina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moxley/ex_machina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moxley/ex_machina/teams","hooks_url":"https://api.github.com/repos/moxley/ex_machina/hooks","issue_events_url":"https://api.github.com/repos/moxley/ex_machina/issues/events{/number}","events_url":"https://api.github.com/repos/moxley/ex_machina/events","assignees_url":"https://api.github.com/repos/moxley/ex_machina/assignees{/user}","branches_url":"https://api.github.com/repos/moxley/ex_machina/branches{/branch}","tags_url":"https://api.github.com/repos/moxley/ex_machina/tags","blobs_url":"https://api.github.com/repos/moxley/ex_machina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moxley/ex_machina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moxley/ex_machina/git/refs{/sha}","trees_url":"https://api.github.com/repos/moxley/ex_machina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moxley/ex_machina/statuses/{sha}","languages_url":"https://api.github.com/repos/moxley/ex_machina/languages","stargazers_url":"https://api.github.com/repos/moxley/ex_machina/stargazers","contributors_url":"https://api.github.com/repos/moxley/ex_machina/contributors","subscribers_url":"https://api.github.com/repos/moxley/ex_machina/subscribers","subscription_url":"https://api.github.com/repos/moxley/ex_machina/subscription","commits_url":"https://api.github.com/repos/moxley/ex_machina/commits{/sha}","git_commits_url":"https://api.github.com/repos/moxley/ex_machina/git/commits{/sha}","comments_url":"https://api.github.com/repos/moxley/ex_machina/comments{/number}","issue_comment_url":"https://api.github.com/repos/moxley/ex_machina/issues/comments{/number}","contents_url":"https://api.github.com/repos/moxley/ex_machina/contents/{+path}","compare_url":"https://api.github.com/repos/moxley/ex_machina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moxley/ex_machina/merges","archive_url":"https://api.github.com/repos/moxley/ex_machina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moxley/ex_machina/downloads","issues_url":"https://api.github.com/repos/moxley/ex_machina/issues{/number}","pulls_url":"https://api.github.com/repos/moxley/ex_machina/pulls{/number}","milestones_url":"https://api.github.com/repos/moxley/ex_machina/milestones{/number}","notifications_url":"https://api.github.com/repos/moxley/ex_machina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moxley/ex_machina/labels{/name}","releases_url":"https://api.github.com/repos/moxley/ex_machina/releases{/id}","deployments_url":"https://api.github.com/repos/moxley/ex_machina/deployments","created_at":"2018-06-20T18:09:10Z","updated_at":"2018-06-20T18:09:11Z","pushed_at":"2018-06-20T18:11:13Z","git_url":"git://github.com/moxley/ex_machina.git","ssh_url":"git@github.com:moxley/ex_machina.git","clone_url":"https://github.com/moxley/ex_machina.git","svn_url":"https://github.com/moxley/ex_machina","homepage":"https://hex.pm/packages/ex_machina","size":257,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"4d1cb60e76bc8897ab4ebd9f0266ec0fe8b0cda4","user":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":42458047,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ1ODA0Nw==","name":"ex_machina","full_name":"thoughtbot/ex_machina","owner":{"login":"thoughtbot","id":6183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/ex_machina","description":"Create test data for Elixir applications","fork":false,"url":"https://api.github.com/repos/thoughtbot/ex_machina","forks_url":"https://api.github.com/repos/thoughtbot/ex_machina/forks","keys_url":"https://api.github.com/repos/thoughtbot/ex_machina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/ex_machina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/ex_machina/teams","hooks_url":"https://api.github.com/repos/thoughtbot/ex_machina/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/ex_machina/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/ex_machina/events","assignees_url":"https://api.github.com/repos/thoughtbot/ex_machina/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/ex_machina/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/ex_machina/tags","blobs_url":"https://api.github.com/repos/thoughtbot/ex_machina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/ex_machina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/ex_machina/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/ex_machina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/ex_machina/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/ex_machina/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/ex_machina/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/ex_machina/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/ex_machina/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/ex_machina/subscription","commits_url":"https://api.github.com/repos/thoughtbot/ex_machina/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/ex_machina/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/ex_machina/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/ex_machina/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/ex_machina/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/ex_machina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/ex_machina/merges","archive_url":"https://api.github.com/repos/thoughtbot/ex_machina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/ex_machina/downloads","issues_url":"https://api.github.com/repos/thoughtbot/ex_machina/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/ex_machina/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/ex_machina/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/ex_machina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/ex_machina/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/ex_machina/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/ex_machina/deployments","created_at":"2015-09-14T15:40:28Z","updated_at":"2018-07-20T17:36:02Z","pushed_at":"2018-07-20T18:52:57Z","git_url":"git://github.com/thoughtbot/ex_machina.git","ssh_url":"git@github.com:thoughtbot/ex_machina.git","clone_url":"https://github.com/thoughtbot/ex_machina.git","svn_url":"https://github.com/thoughtbot/ex_machina","homepage":"https://hex.pm/packages/ex_machina","size":261,"stargazers_count":1019,"watchers_count":1019,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":90,"open_issues":28,"watchers":1019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287"},"html":{"href":"https://github.com/thoughtbot/ex_machina/pull/287"},"issue":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/issues/287"},"comments":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/ex_machina/statuses/b528c4bde184629f4906a9fa23471fee87eeb764"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"germsvel","id":3245976,"node_id":"MDQ6VXNlcjMyNDU5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3245976?v=4","gravatar_id":"","url":"https://api.github.com/users/germsvel","html_url":"https://github.com/germsvel","followers_url":"https://api.github.com/users/germsvel/followers","following_url":"https://api.github.com/users/germsvel/following{/other_user}","gists_url":"https://api.github.com/users/germsvel/gists{/gist_id}","starred_url":"https://api.github.com/users/germsvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germsvel/subscriptions","organizations_url":"https://api.github.com/users/germsvel/orgs","repos_url":"https://api.github.com/users/germsvel/repos","events_url":"https://api.github.com/users/germsvel/events{/privacy}","received_events_url":"https://api.github.com/users/germsvel/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"germsvel"}}