{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/comments/178397678","pull_request_review_id":108456836,"id":178397678,"diff_hunk":"@@ -2065,6 +2065,11 @@ protected function getPreAlterTableIndexForeignKeySQL(TableDiff $diff)\n             $sql[] = $this->getDropIndexSQL($index, $tableName);\n         }\n         foreach ($diff->changedIndexes as $index) {\n+            if ($index->isPrimary()) {\n+                $sql[] = $this->getDropPrimaryKeySQL($tableName);","path":"lib/Doctrine/DBAL/Platforms/AbstractPlatform.php","position":5,"original_position":5,"commit_id":"49992d506f2a7ec2b2ca9cf8cb51b23943209973","original_commit_id":"6147eb5f831851787cdce939aca2723d96bc3660","user":{"login":"morozov","id":59683,"avatar_url":"https://avatars1.githubusercontent.com/u/59683?v=4","gravatar_id":"","url":"https://api.github.com/users/morozov","html_url":"https://github.com/morozov","followers_url":"https://api.github.com/users/morozov/followers","following_url":"https://api.github.com/users/morozov/following{/other_user}","gists_url":"https://api.github.com/users/morozov/gists{/gist_id}","starred_url":"https://api.github.com/users/morozov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morozov/subscriptions","organizations_url":"https://api.github.com/users/morozov/orgs","repos_url":"https://api.github.com/users/morozov/repos","events_url":"https://api.github.com/users/morozov/events{/privacy}","received_events_url":"https://api.github.com/users/morozov/received_events","type":"User","site_admin":false},"body":"@SCIF it's not because of the formatting issue. I want to see if the behavior of dropping a non-existing PK is consistent with other platforms.","created_at":"2018-03-30T22:29:20Z","updated_at":"2018-03-30T22:29:20Z","html_url":"https://github.com/doctrine/dbal/pull/2929#discussion_r178397678","pull_request_url":"https://api.github.com/repos/doctrine/dbal/pulls/2929","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments/178397678"},"html":{"href":"https://github.com/doctrine/dbal/pull/2929#discussion_r178397678"},"pull_request":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2929"}},"in_reply_to_id":161327168},"pull_request":{"url":"https://api.github.com/repos/doctrine/dbal/pulls/2929","id":155678921,"html_url":"https://github.com/doctrine/dbal/pull/2929","diff_url":"https://github.com/doctrine/dbal/pull/2929.diff","patch_url":"https://github.com/doctrine/dbal/pull/2929.patch","issue_url":"https://api.github.com/repos/doctrine/dbal/issues/2929","number":2929,"state":"open","locked":false,"title":"DBAL-2925: Added functional test checking ability to change PK for po…","user":{"login":"SCIF","id":671925,"avatar_url":"https://avatars3.githubusercontent.com/u/671925?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIF","html_url":"https://github.com/SCIF","followers_url":"https://api.github.com/users/SCIF/followers","following_url":"https://api.github.com/users/SCIF/following{/other_user}","gists_url":"https://api.github.com/users/SCIF/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIF/subscriptions","organizations_url":"https://api.github.com/users/SCIF/orgs","repos_url":"https://api.github.com/users/SCIF/repos","events_url":"https://api.github.com/users/SCIF/events{/privacy}","received_events_url":"https://api.github.com/users/SCIF/received_events","type":"User","site_admin":false},"body":"…stgres platform","created_at":"2017-11-30T18:00:03Z","updated_at":"2018-03-30T22:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fee019e9d4d8e97bc220a04695de361cccf2b72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/dbal/pulls/2929/commits","review_comments_url":"https://api.github.com/repos/doctrine/dbal/pulls/2929/comments","review_comment_url":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/dbal/issues/2929/comments","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/49992d506f2a7ec2b2ca9cf8cb51b23943209973","head":{"label":"SCIF:bugfix/DBAL-2925","ref":"bugfix/DBAL-2925","sha":"49992d506f2a7ec2b2ca9cf8cb51b23943209973","user":{"login":"SCIF","id":671925,"avatar_url":"https://avatars3.githubusercontent.com/u/671925?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIF","html_url":"https://github.com/SCIF","followers_url":"https://api.github.com/users/SCIF/followers","following_url":"https://api.github.com/users/SCIF/following{/other_user}","gists_url":"https://api.github.com/users/SCIF/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIF/subscriptions","organizations_url":"https://api.github.com/users/SCIF/orgs","repos_url":"https://api.github.com/users/SCIF/repos","events_url":"https://api.github.com/users/SCIF/events{/privacy}","received_events_url":"https://api.github.com/users/SCIF/received_events","type":"User","site_admin":false},"repo":{"id":112602522,"name":"dbal","full_name":"SCIF/dbal","owner":{"login":"SCIF","id":671925,"avatar_url":"https://avatars3.githubusercontent.com/u/671925?v=4","gravatar_id":"","url":"https://api.github.com/users/SCIF","html_url":"https://github.com/SCIF","followers_url":"https://api.github.com/users/SCIF/followers","following_url":"https://api.github.com/users/SCIF/following{/other_user}","gists_url":"https://api.github.com/users/SCIF/gists{/gist_id}","starred_url":"https://api.github.com/users/SCIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCIF/subscriptions","organizations_url":"https://api.github.com/users/SCIF/orgs","repos_url":"https://api.github.com/users/SCIF/repos","events_url":"https://api.github.com/users/SCIF/events{/privacy}","received_events_url":"https://api.github.com/users/SCIF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SCIF/dbal","description":"Doctrine Database Abstraction Layer","fork":true,"url":"https://api.github.com/repos/SCIF/dbal","forks_url":"https://api.github.com/repos/SCIF/dbal/forks","keys_url":"https://api.github.com/repos/SCIF/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCIF/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCIF/dbal/teams","hooks_url":"https://api.github.com/repos/SCIF/dbal/hooks","issue_events_url":"https://api.github.com/repos/SCIF/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/SCIF/dbal/events","assignees_url":"https://api.github.com/repos/SCIF/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/SCIF/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/SCIF/dbal/tags","blobs_url":"https://api.github.com/repos/SCIF/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCIF/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCIF/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCIF/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCIF/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/SCIF/dbal/languages","stargazers_url":"https://api.github.com/repos/SCIF/dbal/stargazers","contributors_url":"https://api.github.com/repos/SCIF/dbal/contributors","subscribers_url":"https://api.github.com/repos/SCIF/dbal/subscribers","subscription_url":"https://api.github.com/repos/SCIF/dbal/subscription","commits_url":"https://api.github.com/repos/SCIF/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCIF/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCIF/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCIF/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCIF/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/SCIF/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCIF/dbal/merges","archive_url":"https://api.github.com/repos/SCIF/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCIF/dbal/downloads","issues_url":"https://api.github.com/repos/SCIF/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/SCIF/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/SCIF/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/SCIF/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCIF/dbal/labels{/name}","releases_url":"https://api.github.com/repos/SCIF/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/SCIF/dbal/deployments","created_at":"2017-11-30T11:16:13Z","updated_at":"2017-11-30T11:16:16Z","pushed_at":"2018-03-30T22:23:12Z","git_url":"git://github.com/SCIF/dbal.git","ssh_url":"git@github.com:SCIF/dbal.git","clone_url":"https://github.com/SCIF/dbal.git","svn_url":"https://github.com/SCIF/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":23319,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"a4015c8b53f3c9041cb17582300f87be4f2e2cff","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677464,"name":"dbal","full_name":"doctrine/dbal","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/dbal","description":"Doctrine Database Abstraction Layer","fork":false,"url":"https://api.github.com/repos/doctrine/dbal","forks_url":"https://api.github.com/repos/doctrine/dbal/forks","keys_url":"https://api.github.com/repos/doctrine/dbal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/dbal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/dbal/teams","hooks_url":"https://api.github.com/repos/doctrine/dbal/hooks","issue_events_url":"https://api.github.com/repos/doctrine/dbal/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/dbal/events","assignees_url":"https://api.github.com/repos/doctrine/dbal/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/dbal/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/dbal/tags","blobs_url":"https://api.github.com/repos/doctrine/dbal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/dbal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/dbal/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/dbal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/dbal/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/dbal/languages","stargazers_url":"https://api.github.com/repos/doctrine/dbal/stargazers","contributors_url":"https://api.github.com/repos/doctrine/dbal/contributors","subscribers_url":"https://api.github.com/repos/doctrine/dbal/subscribers","subscription_url":"https://api.github.com/repos/doctrine/dbal/subscription","commits_url":"https://api.github.com/repos/doctrine/dbal/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/dbal/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/dbal/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/dbal/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/dbal/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/dbal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/dbal/merges","archive_url":"https://api.github.com/repos/doctrine/dbal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/dbal/downloads","issues_url":"https://api.github.com/repos/doctrine/dbal/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/dbal/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/dbal/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/dbal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/dbal/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/dbal/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/dbal/deployments","created_at":"2010-05-20T17:01:42Z","updated_at":"2018-03-30T22:08:27Z","pushed_at":"2018-03-30T22:23:14Z","git_url":"git://github.com/doctrine/dbal.git","ssh_url":"git@github.com:doctrine/dbal.git","clone_url":"https://github.com/doctrine/dbal.git","svn_url":"https://github.com/doctrine/dbal","homepage":"http://www.doctrine-project.org/projects/dbal","size":23764,"stargazers_count":2165,"watchers_count":2165,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":865,"mirror_url":null,"archived":false,"open_issues_count":405,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":865,"open_issues":405,"watchers":2165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2929"},"html":{"href":"https://github.com/doctrine/dbal/pull/2929"},"issue":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2929"},"comments":{"href":"https://api.github.com/repos/doctrine/dbal/issues/2929/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2929/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/dbal/pulls/2929/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/dbal/statuses/49992d506f2a7ec2b2ca9cf8cb51b23943209973"}},"author_association":"NONE"}}
{"actor":{"display_login":"morozov"}}